--- Log opened Wed Feb 10 00:00:28 2016
20160210 00:09:36-!- mjs-de [~mjs-de@x5ce48356.dyn.telefonica.de] has quit [Remote host closed the connection]
20160210 00:12:39-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160210 00:13:31-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160210 00:36:12-!- Appleman1234 [~Appleman1@KD119104009204.au-net.ne.jp] has joined #wesnoth-dev
20160210 00:43:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160210 00:54:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160210 01:54:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160210 01:56:27-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Remote host closed the connection]
20160210 02:03:16-!- irker639 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160210 02:03:16< irker639> wesnoth: sigurdfdragon wesnoth:master 2fe58d3e6749 / data/core/units.cfg: Help: Fix typo in Orcs description. https://github.com/wesnoth/wesnoth/commit/2fe58d3e6749d0019942f4dea76e4f7141e10300
20160210 02:03:18< irker639> wesnoth: Charles Dang wesnoth:master 157b76fb1daa / data/core/units.cfg: Merge pull request #590 from sigurdfdragon/Typo_Fix_in_Orcs_Description https://github.com/wesnoth/wesnoth/commit/157b76fb1daa5e4d30ab2c36ce807a5f696c05dc
20160210 02:04:35< irker639> wesnoth: sigurdfdragon wesnoth:master 3501f6eb910d / data/core/units.cfg: Help: Fix typo in Trolls description. https://github.com/wesnoth/wesnoth/commit/3501f6eb910d2231e58ebd407c735a9ddebf1619
20160210 02:04:37< irker639> wesnoth: Charles Dang wesnoth:master 9cfa7f55aee4 / data/core/units.cfg: Merge pull request #591 from sigurdfdragon/Fix_Typo_in_Trolls_Description https://github.com/wesnoth/wesnoth/commit/9cfa7f55aee46d751617ab085bc5af6d41944fb3
20160210 02:05:38< irker639> wesnoth: sigurdfdragon wesnoth:master 36683cfb9bf5 / data/campaigns/An_Orcish_Incursion/scenarios/ (04_Valley_of_Trolls.cfg 05_Linaera_the_Quick.cfg 07_Showdown.cfg): AOI: Fix unreported bug of advisor dialog not showing in S4 & S5. https://github.com/wesnoth/wesnoth/commit/36683cfb9bf5627a813b19f3b6bbb22d2573dd91
20160210 02:05:40< irker639> wesnoth: Charles Dang wesnoth:master b564fb7c5b2b / data/campaigns/An_Orcish_Incursion/scenarios/ (04_Valley_of_Trolls.cfg 05_Linaera_the_Quick.cfg 07_Showdown.cfg): Merge pull request #592 from sigurdfdragon/AOI_advisor_fix https://github.com/wesnoth/wesnoth/commit/b564fb7c5b2b37dbe06d5fd2f72a27b196e62657
20160210 02:05:54< irker639> wesnoth: sigurdfdragon wesnoth:master c7618d95abfa / data/campaigns/An_Orcish_Incursion/scenarios/ (7 files): AOI: Standardize all recruit lists. https://github.com/wesnoth/wesnoth/commit/c7618d95abfa72d8436a33a7d9b68cff377e121f
20160210 02:05:56< irker639> wesnoth: sigurdfdragon wesnoth:master 953a9442b3e6 / data/campaigns/An_Orcish_Incursion/scenarios/ (7 files): AOI: Standardize player and enemy team_name key. https://github.com/wesnoth/wesnoth/commit/953a9442b3e6b473c82e613fc023eaea330b9538
20160210 02:05:58< irker639> wesnoth: sigurdfdragon wesnoth:master 7a035a79c2dc / data/campaigns/An_Orcish_Incursion/scenarios/05_Linaera_the_Quick.cfg: AOI S5: Change Linaera's side name to Mages & hide side in status table. https://github.com/wesnoth/wesnoth/commit/7a035a79c2dc53eea6b5c5fa25eba1183b8c6ef8
20160210 02:06:00< irker639> wesnoth: sigurdfdragon wesnoth:master 652b0c0873df / data/campaigns/An_Orcish_Incursion/scenarios/03_Wasteland.cfg: AOI S3: Remove duplicate die event. https://github.com/wesnoth/wesnoth/commit/652b0c0873df35b60817ba1d26144fccb7118450
20160210 02:06:02< irker639> wesnoth: sigurdfdragon wesnoth:master da273c5bc9e4 / data/campaigns/An_Orcish_Incursion/scenarios/ (01_Defend_the_Forest.cfg 07_Showdown.cfg): AOI: Make Lomarfel so he has same traits in both scenarios and loyal clearly ind https://github.com/wesnoth/wesnoth/commit/da273c5bc9e42da971b5caecfa2a73d406a846ae
20160210 02:06:04< irker639> wesnoth: sigurdfdragon wesnoth:master b8d3935a1a25 / data/campaigns/An_Orcish_Incursion/scenarios/07_Showdown.cfg: AOI S7: Make Elvish Rangers loyal trait clearly indicated to the player. https://github.com/wesnoth/wesnoth/commit/b8d3935a1a256e30f009b9a7167f1e8e3f1a2245
20160210 02:06:06< irker639> wesnoth: Charles Dang wesnoth:master 78ff08293456 / data/campaigns/An_Orcish_Incursion/scenarios/ (7 files): Merge pull request #593 from sigurdfdragon/AOI_Cleanup_&_Fixes https://github.com/wesnoth/wesnoth/commit/78ff082934569dd54a031dbb08e048e1326b7354
20160210 02:48:44-!- neverEnough [~nEnough@host76-232-dynamic.21-79-r.retail.telecomitalia.it] has quit [Quit: Sto andando via]
20160210 02:56:01-!- shadowm_desktop [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20160210 02:57:29< shadowm> vultraz: Why does #581 remove the name_short attribute from combo-type adv preferences?
20160210 02:57:42< vultraz> shadowm: because it's now unused 
20160210 02:57:47< shadowm> Not really?
20160210 02:57:58< vultraz> Uh...
20160210 02:58:02< vultraz> what?
20160210 02:58:03< shadowm> It's definitely not obvious to you because otherwise we wouldn't be speaking this, but compare the values.
20160210 02:58:20< shadowm> The short version is not Sentence case.
20160210 02:58:44< vultraz> right
20160210 02:58:46< shadowm> This was a style choice to match the yes/no labels (which I hope you kept lowercase...?).
20160210 02:59:06< shadowm> Oh right, yes/no are no longer needed because toggle buttons are inline.
20160210 02:59:20< vultraz> I kept yes/no
20160210 02:59:34< vultraz> though I'm on the fence
20160210 02:59:51< vultraz> it seems to look weird without a status label in every row 
20160210 03:00:55< shadowm> Look, deal with that later. I don't want to see the PR get bloated further with more architectural flip-flops.
20160210 03:01:19< shadowm> (And by "deal" I mean "decide". I don't really care about the aesthetics to that extent right now.)
20160210 03:01:43< vultraz> Are you reviewing the PR?
20160210 03:02:08< shadowm> No, I'm flying to France right now.
20160210 03:02:24< shadowm> "Customize orb colors (unimplemented)" why is this here?
20160210 03:02:52< vultraz> Because it's unimplemented
20160210 03:02:55< vultraz> I can comment it out
20160210 03:03:06< shadowm> Then either don't include it or #ifdef it out.
20160210 03:04:19< shadowm>     {_GUI_PREFS_PLACEHOLDER (1)}
20160210 03:04:54< shadowm> Oh I see you just didn't bother to remove my test code and left it there taking up preprocessor table entries.
20160210 03:05:45< shadowm>     label = _ "display_resolution^9999x9999 (999:999)"
20160210 03:05:49< shadowm> This shouldn't be translatable.
20160210 03:05:58< vultraz> i left that in?
20160210 03:06:50< shadowm> (I'm only doing a very shallow skim pass on the WML, btw. Whatever I miss will simply go unmentioned no matter how inappropriate or broken it is.)
20160210 03:08:00< shadowm> Recommend "Find Server Executable" -> "Server Executable" to make life easier for translators and vultrazes looking at the ugly stretched-out buttons.
20160210 03:08:31< shadowm>     size_text = "very long text which might need to fit"
20160210 03:08:47< shadowm> No matter what mordante's older GUI WML code might have led you to believe, this attribute does not exist.
20160210 03:09:07< vultraz> whut
20160210 03:09:13< vultraz> well then..
20160210 03:10:54< shadowm> // IMPORTANT: NEVER have trailing zeroes here
20160210 03:10:56< shadowm> Explain.
20160210 03:11:09< shadowm> (In the code. Not to me. Otherwise the comment is meaningless.)
20160210 03:11:36< vultraz> Ok
20160210 03:11:44< shadowm> This is  src/gui/dialogs/preferences_dialog.cpp , by the way.
20160210 03:11:47< shadowm> Line 101.
20160210 03:11:51< vultraz> I know
20160210 03:11:54< shadowm> Also, you are doing the column-of-commas thing there.
20160210 03:12:37< vultraz> yes, because it looked nice there and had a leading symbol
20160210 03:12:44< shadowm> I was hoping that when I gave you the solution to that conundrum, you'd use const on num_items out of your own volition, but you didn't.
20160210 03:12:59< shadowm> It doesn't make any practical differences really, but it's a missed bonus point on my book.
20160210 03:13:46< shadowm> i.e. "vultraz can be handed out code and refine it further rather than stick it there and call it a day".
20160210 03:14:03< vultraz> I didn't make it const?
20160210 03:14:26< shadowm> Line 180 starts with a comma.
20160210 03:14:49< shadowm> I feel like you didn't get the message here. The column-of-commas thing is only used in constructor initialization lists.
20160210 03:14:53< shadowm> In constructor definitions.
20160210 03:15:17< shadowm> This is a constructor initialization list:   foo::foo() : member1(), member2(), member3() {}
20160210 03:15:27< vultraz> GAH
20160210 03:15:30< vultraz> I thought I fixed all those
20160210 03:15:33< shadowm> This is not a constructor initialization list:    T foo = { 1, 2, 3, 4 };
20160210 03:15:41< shadowm> (That's an initializer list.)
20160210 03:16:50< shadowm>     data["friend_name"]["label"] = _("Empty list");
20160210 03:17:10< shadowm> In an ideal world this listbox would be part of a stacked_widget along with a page containing only a label with this text.
20160210 03:17:32< shadowm> Or listboxes would have the power to set placeholder entries.
20160210 03:17:38< shadowm> But I'm okay with this solution.
20160210 03:18:36< shadowm> Blah blah blah C++ code etc. etc. I believe I saw most of this before so I can skip it.
20160210 03:18:47< shadowm> Great, there we have another TODO-introducing commit.
20160210 03:19:16< shadowm> Look, an orphaned Doxygen comment at 909.
20160210 03:19:55< shadowm> Furthermore, why are the Doxygen comments for these methods in the implementation and not in the header?
20160210 03:21:42< shadowm> preferences.cpp:215 opening brace of function definition not on next line. Try to not do that in general unless you are writing inline functions in public headers.
20160210 03:22:35< vultraz> other functions in the same file also do that
20160210 03:22:47< shadowm> src/video.cpp:851 sees a useless whitespace change from our canonical style to a non-canonical style.
20160210 03:23:46< shadowm> Same for a few other lines in that file. Suddenly I really feel like adopting mordante's clang-format proposal just to make a point.
20160210 03:24:16< shadowm> OTOH I also see a few useless consts propping up in a few function declarations.
20160210 03:24:57< shadowm> I guess I don't feel strongly about them as long as people realize they do nothing.
20160210 03:25:14< shadowm> Nothing other than tell the compiler to disallow non-const access, that is.
20160210 03:27:10< shadowm> Why they do nothing: you can't mark a CPU register read-only and you can't mark stack pages read-only (okay you technically could do that in some contexts I guess but then I imagine you'll get a stack fault if you CALL/RET/ENTER/LEAVE from the current frame).
20160210 03:27:20< vultraz> should I merge b7fd4a10 into the 'add gui2 prefs dialog' commit?
20160210 03:28:04< shadowm> Arguably, the same applies to variables declared in function scope, but I _think_ someone told me once they still allow for optimization opportunities.
20160210 03:28:45< shadowm> I've not gotten to the history style review part yet, I was looking at the combined diff.
20160210 03:29:25< shadowm> And another reason why const parameters-by-value "do nothing": they are copies already. You can't modify the caller's copies no matter how hard you try.
20160210 03:29:51< shadowm> The same obviously doesn't apply to references, but it does apply to pointers (which is why pointers-of-pointers and deeper levels of indirection exist).
20160210 03:32:13< vultraz> are you saying 'const std::string& foo' is useless?
20160210 03:44:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 03:47:16< shadowm> No, vultraz, that's not what I said at all.
20160210 03:47:45< vultraz> then im confused
20160210 03:47:47< shadowm> And since I don't feel like explaining it all over again, I'd prefer if you ignore everything I said about the matter rather than drawing incorrect conclusions from it.
20160210 03:48:50< shadowm> Especially since in this case, the alternative conclusions would result in poorer code.
20160210 03:49:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160210 03:51:09< shadowm> Like, why commits like this are still present? https://github.com/Vultraz/wesnoth/commit/e45704969976eb3726146f4c7303d2b750ea5ae3
20160210 03:51:34< shadowm> At least the parts that touch code that didn't exist before.
20160210 03:52:31< shadowm> You know what, I don't care. Merge this so no-one has to keep looking at it.
20160210 03:52:56< shadowm> And maybe update the copyright statement for preferences_dialog.?pp since 90% of the code in those files is yours, not mine.
20160210 03:53:19< vultraz> To me or the project?
20160210 03:53:54< shadowm> You wrote the code, that means the code is yours.
20160210 03:54:12< shadowm> For better or worse, that's our current (de facto, not de jure) policy.
20160210 03:54:22< shadowm> (Which means that it's not even a policy I guess.)
20160210 03:55:00< vultraz> Yes, but since there was some talk of a possible discussion about potentially maybe moving copyrights to the project, I was wondering if it might be easier to make new copyrights out to that
20160210 03:55:19< shadowm> I HAVE NO IDEA WHAT YOU ARE TALKING ABOUT.
20160210 03:55:47< shadowm> Wait, I haven't tested the thing even.
20160210 03:56:01< shadowm> I probably should do that first so people don't blame me if things break later.
20160210 03:56:06< vultraz> YOU HAVEN'T TESTED IT :|
20160210 03:56:23< shadowm> That's what I said.
20160210 03:56:32< shadowm> Except in Sentence case.
20160210 03:56:47< shadowm> And with a different grammatical person, and stuff.
20160210 03:57:18< shadowm> I won't test it thoroughly, let that be known.
20160210 03:57:42< shadowm> The assumption here is that you and the people who helped you create this already did most of the testing.
20160210 03:57:42< vultraz> I've tested the damn thing already
20160210 03:58:00< vultraz> Though so far ONLY I have done the testing
20160210 03:58:04< shadowm> Yes, but I vaguely remember hitting some bugs last time.
20160210 03:58:26< shadowm> I informed you about them, and at no point you suggested that you were already aware of their existence.
20160210 03:58:46< shadowm> Also, GitHub is ded.
20160210 03:59:20< shadowm> Or maybe my terminal emulator went crazy.
20160210 03:59:26< shadowm> Okay, looks like it's the latter.
20160210 04:00:31< vultraz> I also have to commit the fixups you suggested above
20160210 04:00:34< vultraz> well
20160210 04:00:41< vultraz> commit and merge and forcepush
20160210 04:02:09< vultraz> and I still want to know if I should merge b7fd4a10 
20160210 04:02:41< shadowm> Does knowing that the original implementation ever existed hold any value for future maintainers in your view?
20160210 04:02:54< shadowm> (I'd like to say 'yes' but the reasons aren't very nice.)
20160210 04:03:06< vultraz> I'd also like to say yes
20160210 04:03:29< vultraz> Just as a proof-of-concept of that type of tree view use
20160210 04:03:47< vultraz> And to show what issues it had
20160210 04:04:12< shadowm> So, I'm going to say something, and I don't want you to include it in your PR.
20160210 04:04:39< shadowm> The current scheme with the checkboxes on the left and the yes/no labels on the right seems more than a bit redundant.
20160210 04:05:03< shadowm> But having the checkboxes on the left alone would look a bit weird and unbalanced.
20160210 04:05:15< vultraz> I know this
20160210 04:05:28< shadowm> Having the checkboxes on the right alone would fit the current design but make the list a bit inconsistent with every other toggle list in the game.
20160210 04:05:48< shadowm> Just food for thought.
20160210 04:07:25< shadowm> And GUI2 listboxes really one or two more focused bug fixes to make Advanced Preferences 100% usable, I'm afraid.
20160210 04:07:49< vultraz> I know
20160210 04:07:57< vultraz> but that's a different issue outside the scope of this
20160210 04:08:01< shadowm> For example, changing the selection between static and expandable items OKAY you know then I don't need to waste time wording it.
20160210 04:08:13< shadowm> I said GUI2 listboxes, plural, I know it's not specific to the dialog.
20160210 04:08:24< shadowm> I did say "focused bug fixes" as in bug fixes specifically targeting the dialog, though.
20160210 04:08:36< vultraz> gfgtdf said a currently unimplemented event needs to be implemented 
20160210 04:08:47< shadowm> It's not within the PR's scope, but it is within the overall mission's scope.
20160210 04:09:07< shadowm> After all, you did this because you wanted to fix existing usability issues too.
20160210 04:10:28< shadowm> I feel like typing a name that's not on the acq. list and then clicking Remove should provide some feedback as to why nothing changed as a result.
20160210 04:10:39< shadowm> For example, a popup box.
20160210 04:10:52< vultraz> Ok
20160210 04:11:19< shadowm> I'm pretty sure the autosaves slider had an 'infinite' option at the end.
20160210 04:11:42< vultraz> :|
20160210 04:11:44< vultraz> :|
20160210 04:11:45< vultraz> :|
20160210 04:11:56< shadowm> 1.12: the range is 0 to 60, plus the infinite option at the end.
20160210 04:12:05< vultraz> fuck
20160210 04:12:07< vultraz> it did
20160210 04:12:09< vultraz> FUCK
20160210 04:12:31< shadowm> Is 61 a magic value that means infinite in the config?
20160210 04:14:01< shadowm> Hm, GUI2 sliders seem to have some issues with rapid mouse movement.
20160210 04:14:30< vultraz> they do
20160210 04:14:34< vultraz> I spoke of this earlier
20160210 04:14:37< vultraz> to Aginor 
20160210 04:14:38< shadowm> But that could be due to missed events due to the load issue as I mentioned the other night.
20160210 04:14:42< vultraz> you said it was event polling 
20160210 04:14:56< shadowm> I didn't say it _was_, I merely proposed it as a plausible explanation.
20160210 04:15:24< vultraz> const int INFINITE_AUTO_SAVES = 61;
20160210 04:16:04< shadowm> Anyway, it seems the dialog otherwise works correctly.
20160210 04:16:26< shadowm> Congratulations, you somehow achieved an intermediate-to-advanced task despite not knowing enough C++ for it at the start.
20160210 04:17:03< shadowm> If that isn't a sign of true determination then I don't know what is.
20160210 04:17:24< shadowm> Next time though, I'd like to suggest something to ease the learning experience a bit.
20160210 04:18:30< shadowm> Instead of stuffing code into the unbelievably hideous abomination that is Wesnoth's codebase, you might want to write small test programs that write and read from the console.
20160210 04:18:42< shadowm> It's not even hard to compile them if GCC is in %PATH%.
20160210 04:19:07< shadowm> e.g.: g++ -std=c++98 -W -Wall -Werror -o test.exe test.cpp
20160210 04:19:33< shadowm> (C++98, all warnings enabled (important), strict mode (important), take test.cpp and compile it into test.exe.)
20160210 04:19:55< shadowm> (Use -std=c++11 for C++11.)
20160210 04:21:25< shadowm> The entry point's signature is obviously int main(int, char**).
20160210 04:28:42 * shadowm is off now.
20160210 04:58:38-!- shadowm_desktop [~ignacio@wesnoth/developer/shadowm] has quit [Quit: shadowm_desktop]
20160210 05:48:59-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160210 05:52:54-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160210 06:11:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 06:13:01-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-109-141.zoominternet.net] has quit []
20160210 06:16:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160210 06:44:22-!- celticminstrel is now known as celmin|Zzzz
20160210 06:53:53-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160210 06:57:51-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160210 07:16:30-!- Kwandulin [~Miranda@p200300760F0BC5C5317B49FB4D7D8246.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160210 07:55:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160210 08:09:06-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 240 seconds]
20160210 08:09:55-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160210 08:13:27-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160210 08:31:35-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160210 08:38:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 08:42:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160210 08:49:16-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160210 08:53:36-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Ping timeout: 240 seconds]
20160210 09:08:58-!- Alduin_ [~Alduin@2001:4ca0:0:f255:79de:d0d6:758a:2837] has joined #wesnoth-dev
20160210 09:54:25-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160210 10:09:23< irker639> wesnoth: Ignacio R. Morelle wesnoth:master 677e7077ae81 / / (12 files in 4 dirs): gui2/tpreferences: initial layout https://github.com/wesnoth/wesnoth/commit/677e7077ae818ecd91d33426f56a6d780cb57c32
20160210 10:09:26< irker639> wesnoth: Charles Dang wesnoth:master a5b2f5cd7b26 / projectfiles/CodeBlocks/wesnoth.cbp src/CMakeLists.txt src/SConscript: Updated build lists + cb projfile https://github.com/wesnoth/wesnoth/commit/a5b2f5cd7b265402e298b84cbe9f3c024fc22bad
20160210 10:09:29< irker639> wesnoth: Charles Dang wesnoth:master d131f1d58c5b / data/advanced_preferences.cfg src/display.cpp src/display.hpp: Removed the option to turn off Local ToD lighting. It is now always on. https://github.com/wesnoth/wesnoth/commit/d131f1d58c5b343e4119e201204fcc3ecbb53c7d
20160210 10:09:32< irker639> wesnoth: Charles Dang wesnoth:master db8c65aad8ef / / (4 files in 2 dirs): Remove Reverse Time Graphics option https://github.com/wesnoth/wesnoth/commit/db8c65aad8ef998ca0c02e92432a086f77b187aa
20160210 10:09:35< irker639> wesnoth: Charles Dang wesnoth:master 352bd1cae219 / / (7 files in 5 dirs): Removed Titlescreen Animation option and related code https://github.com/wesnoth/wesnoth/commit/352bd1cae2199bcc61fbdfa6cc3b2803eb4c0388
20160210 10:09:38< irker639> wesnoth: Charles Dang wesnoth:master 0135b702720b / src/gui/dialogs/helper.hpp: Added additional dialog callback helper function by iceiceice https://github.com/wesnoth/wesnoth/commit/0135b702720bba8bd1fa790b0dbd59b46cbfc105
20160210 10:09:41< irker639> wesnoth: Charles Dang wesnoth:master d21235deb581 / data/gui/default/widget/ (label_default.cfg scroll_label_default.cfg): Added definition for small-size scroll label https://github.com/wesnoth/wesnoth/commit/d21235deb58190ba274fe707cbdf96128cf50823
20160210 10:09:44< irker639> wesnoth: Charles Dang wesnoth:master 8b31f8fa28c1 / src/game_preferences.hpp: Name lobby joins enum https://github.com/wesnoth/wesnoth/commit/8b31f8fa28c11007bc03c6357587c7fddc35336d
20160210 10:09:47< irker639> wesnoth: Charles Dang wesnoth:master 9a11e9e86a96 / src/game_preferences.cpp: Remove reliance on static acquaintances_initialized variable https://github.com/wesnoth/wesnoth/commit/9a11e9e86a967c745c20478b92b95764c79580d7
20160210 10:09:50< irker639> wesnoth: Charles Dang wesnoth:master 6626bbce2248 / src/ (video.cpp video.hpp): Add flag to get_available_resolutions() to include current resolution https://github.com/wesnoth/wesnoth/commit/6626bbce22482c2ab7974c7a545d034f61f4e664
20160210 10:09:53< irker639> wesnoth: Charles Dang wesnoth:master b7d56e0c11ae / / (15 files in 5 dirs): gui2/tpreferences: implemented new gui2 Preferences dialog https://github.com/wesnoth/wesnoth/commit/b7d56e0c11ae1a97b874133a20cbbef8d52dd489
20160210 10:09:56< irker639> wesnoth: Charles Dang wesnoth:master 9eecc28ef9c7 / / (4 files in 4 dirs): Moved 'Accept whispers from friends only' pref from Advanced to Multiplayer https://github.com/wesnoth/wesnoth/commit/9eecc28ef9c7dcc9a6530d5238d4d1e1eedc02ad
20160210 10:09:59< irker639> wesnoth: Charles Dang wesnoth:master 28acb89a77d8 / data/advanced_preferences.cfg: Added advanced preferences for Adv. Graphics and Orb Colors https://github.com/wesnoth/wesnoth/commit/28acb89a77d8b0cf84e6ae27c3e3fda63cc4e273
20160210 10:10:02< irker639> wesnoth: Charles Dang wesnoth:master a8ca6a054308 / src/game_preferences_display.cpp: Remove code for old GUI1 preferences dialog https://github.com/wesnoth/wesnoth/commit/a8ca6a054308cf2026f24ac2f30cb5feb0069ee8
20160210 10:10:05< irker639> wesnoth: Charles Dang wesnoth:master 758847d5459a / src/game_preferences_display.cpp: Cleaned up show_theme_dialog() a bit https://github.com/wesnoth/wesnoth/commit/758847d5459a485f97780438692ea205975b8403
20160210 10:10:08< irker639> wesnoth: Charles Dang wesnoth:master 1668b7518fa8 / src/tests/gui/test_gui2.cpp: Updated GUI2 unit tests https://github.com/wesnoth/wesnoth/commit/1668b7518fa83e27f1b56161bec74df6b3a654ed
20160210 10:10:11< irker639> wesnoth: Charles Dang wesnoth:master faf5d82a4eff / / (2 files in 2 dirs): gui2/tpreferences: switch back to Alerts dialog (as opposed to tab) for now https://github.com/wesnoth/wesnoth/commit/faf5d82a4eff2416197bc2a630f466a010da7e00
20160210 10:10:14< irker639> wesnoth: Charles Dang wesnoth:master acd46a835395 / data/gui/default/window/mp_alerts_options.cfg: gui2/tmp_alerts_options: applied some formatting https://github.com/wesnoth/wesnoth/commit/acd46a8353950f25750d1cdd448ce8358251a13c
20160210 10:10:17< irker639> wesnoth: Charles Dang wesnoth:master d54490ec78e2 / src/gui/dialogs/helper.hpp: Removed some unnecessary dynamic_casts in callback bind helpers https://github.com/wesnoth/wesnoth/commit/d54490ec78e24d38afb29cf6c507b4bc04476ce1
20160210 10:10:20< irker639> wesnoth: Charles Dang wesnoth:master fda94c814811 / data/advanced_preferences.cfg: Removed unused [option] name_short keys from combobox-type advanced prefs https://github.com/wesnoth/wesnoth/commit/fda94c814811a242c2e89d14d49ef2c411ba835b
20160210 10:10:23< irker639> wesnoth: Charles Dang wesnoth:master 4e5a42cc4215 / / (4 files in 3 dirs): tpreferences: refactored Advanced section to use a listbox https://github.com/wesnoth/wesnoth/commit/4e5a42cc4215479f446683ca7665c6b930cc9cac
20160210 10:10:26< irker639> wesnoth: Charles Dang wesnoth:master 3c6edb49a08b / src/ (3 files in 2 dirs): Cleaned up some preferences-related includes and helper functions https://github.com/wesnoth/wesnoth/commit/3c6edb49a08be16c270324ff767f4dac5077af3c
20160210 10:10:29< irker639> wesnoth: Charles Dang wesnoth:master 0ff4830f8d0c / src/ (game_preferences.cpp game_preferences.hpp gui/dialogs/preferences_dialog.cpp): Allow preferences::remove_acquaintance to return a bool success value https://github.com/wesnoth/wesnoth/commit/0ff4830f8d0c9eec0076e28596353bc1ea621d7b
20160210 10:10:32< irker639> wesnoth: Charles Dang wesnoth:master 5d60f991a1c5 / / (38 files in 9 dirs): Merge pull request #581 from Vultraz/prefs_dialog_refactor https://github.com/wesnoth/wesnoth/commit/5d60f991a1c5f80523514356cf7b2736e1207e78
20160210 10:10:56< vultraz> WHOOT \o/
20160210 10:58:03-!- travis-ci [~travis-ci@ec2-50-17-26-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20160210 10:58:05< travis-ci> wesnoth/wesnoth#8432 (master - 5d60f99 : Charles Dang): The build has errored.
20160210 10:58:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/108240545
20160210 10:58:05-!- travis-ci [~travis-ci@ec2-50-17-26-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20160210 11:05:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 11:05:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160210 11:09:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20160210 11:39:48-!- Kwandulin [~Miranda@p200300760F0BC5C5317B49FB4D7D8246.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160210 11:52:06-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 240 seconds]
20160210 12:11:09< vultraz> oh, I forgot to make the autosaves slider say infinite at 61
20160210 12:47:33< irker639> wesnoth: Charles Dang wesnoth:master 77e2eb82289c / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: display proper symbol for infinite autosaves https://github.com/wesnoth/wesnoth/commit/77e2eb82289c431fb9458eaeea21af7c909b00e3
20160210 12:48:28< vultraz> shadowm: ^ I used the unicode infinity symbol. If you want I can make it "infinite" instead.
20160210 12:49:52< irker639> wesnoth: Charles Dang wesnoth:master 7740fe1f878b / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: update file copyright https://github.com/wesnoth/wesnoth/commit/7740fe1f878b28ccaa6d2ca53be0e958c3b05cf8
20160210 12:50:06< vultraz> (and the reason it's bold is so it doesn't look like shit on windows)
20160210 13:02:44-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160210 13:14:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160210 13:20:17< irker639> wesnoth: Charles Dang wesnoth:master 34838f3819a6 / src/gui/dialogs/campaign_selection.cpp: tcampaign_selection: fixed some bad_lexcical_cast assertions https://github.com/wesnoth/wesnoth/commit/34838f3819a6099e715315298aa91ff1a439680c
20160210 13:27:58< irker639> wesnoth: Charles Dang wesnoth:master edbd84d0b66d / src/gui/widgets/tree_view_node.cpp: Revert "ttree_view_node: bind label selection event to toggle if label is not pr https://github.com/wesnoth/wesnoth/commit/edbd84d0b66d42b41f36e4ce9b929048b757ad6b
20160210 13:29:04< vultraz> gfgtdf: ^ caused problems so I reverted
20160210 13:31:36< Soliton> what's a bad_lexcical_cast assertion?
20160210 13:32:40< Soliton> presumably you meant an exception.
20160210 13:33:17< Soliton> better catch the exception and handle that case instead of trying to check for all cases lexical_cast would throw.
20160210 13:33:37< Soliton> that's lexical_cast's job not the job of every caller.
20160210 13:35:05< vultraz> wesnoth crashed if you passed what I think was an empty string
20160210 13:38:46< vultraz> which seems to be deliberate behavior
20160210 13:39:00-!- Alduin_ [~Alduin@2001:4ca0:0:f255:79de:d0d6:758a:2837] has quit [Ping timeout: 252 seconds]
20160210 13:39:25-!- Alduin_ [~Alduin@host231-2.natpool.mwn.de] has joined #wesnoth-dev
20160210 13:40:04-!- Kwandulin [~Miranda@p200300760F0BC5FE399F7BB2EE9136F3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160210 13:42:37-!- celmin|Zzzz is now known as celticminstrel
20160210 13:43:33-!- travis-ci [~travis-ci@ec2-50-17-26-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20160210 13:43:34< travis-ci> wesnoth/wesnoth#8434 (master - 7740fe1 : Charles Dang): The build passed.
20160210 13:43:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/108267770
20160210 13:43:34-!- travis-ci [~travis-ci@ec2-50-17-26-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20160210 13:43:52< celticminstrel> vultraz: The groups are still not merged, right?
20160210 13:44:34< Soliton> vultraz: was there anything unclear about what i said?
20160210 13:45:26< celticminstrel> Instead of if(some_string != "") I think it's cleaner to if(!some_string.empty()).
20160210 13:45:47< celticminstrel> Soliton: For the specific case of empty strings I think it's reasonable to test first.
20160210 13:45:48< Soliton> agreed, but the whole check seems misguided.
20160210 13:46:05< Soliton> if that is all that can possibly happen...
20160210 13:46:09< celticminstrel> Though you're right that the exception should be caught.
20160210 14:05:34-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160210 14:05:35-!- travis-ci [~travis-ci@ec2-50-17-26-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20160210 14:05:36< travis-ci> wesnoth/wesnoth#8433 (master - 77e2eb8 : Charles Dang): The build has errored.
20160210 14:05:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/108267420
20160210 14:05:36-!- travis-ci [~travis-ci@ec2-50-17-26-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20160210 14:05:53-!- mjs-de [~mjs-de@x4db6c1a9.dyn.telefonica.de] has joined #wesnoth-dev
20160210 14:10:51-!- gfgtdf [~chatzilla@f054152156.adsl.alicedsl.de] has joined #wesnoth-dev
20160210 14:14:59< gfgtdf> vultraz: how can i preproduce a crash in scmapigns menu ?
20160210 14:15:24< vultraz> gfgtdf: before that commit, clicking on the 'Modifications' label causes a crash
20160210 14:22:27< gfgtdf> vultraz: hmm i'd think that that was fixed in https://github.com/wesnoth/wesnoth/commit/edbd84d0b66d42b41f36e4ce9b929048b757ad6b already ?
20160210 14:22:55< vultraz> hm...
20160210 14:27:35< vultraz> maybe?
20160210 14:28:00-!- travis-ci [~travis-ci@ec2-54-166-9-161.compute-1.amazonaws.com] has joined #wesnoth-dev
20160210 14:28:01< travis-ci> wesnoth/wesnoth#8435 (master - 34838f3 : Charles Dang): The build passed.
20160210 14:28:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/108273032
20160210 14:28:01-!- travis-ci [~travis-ci@ec2-54-166-9-161.compute-1.amazonaws.com] has left #wesnoth-dev []
20160210 14:33:42-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160210 14:34:02-!- Appleman1234 [~Appleman1@KD119104009204.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20160210 14:34:12< mattsc> Hi vultraz
20160210 14:34:37< vultraz> hey
20160210 14:34:44< mattsc> I’ve decided that I’ll give rewriting/reorganizing the AI wiki pages a shot.
20160210 14:34:49< gfgtdf> so the preferences pr is not merged ?
20160210 14:34:51< gfgtdf> now*
20160210 14:35:35< mattsc> It’s going to take me a little because they are a huge mess and I still don’t have much time, but it has to happen sometime.
20160210 14:36:33< mattsc> I might ask for help with wording (I’m horrible at writing introductions and summaries) or deleting pages at times.
20160210 14:36:52< vultraz> gfgtdf: yes
20160210 14:37:03< vultraz> mattsc: ok, sure :)
20160210 14:37:04< gfgtdf> hmm will test then.
20160210 14:37:34< mattsc> Anyways, my first question, I’d like to set up a new start or go-to or summary page.
20160210 14:37:52< mattsc> Any opinion on the title?  “Wesnoth AI”, “AI in Wesnoth”, something else?
20160210 14:38:57< mattsc> The current front page, is anything like that exists at all, is AiWML, but that should really be about, well, the WML to modify the AI
20160210 14:39:06< mattsc> s/is/if
20160210 14:39:26< vultraz> either of those two is fine
20160210 14:41:05< vultraz> leaning towards the second, though
20160210 14:43:58< mattsc> okay, sounds good; I need to organize my thoughts for a little before getting going on this for real.  I don’t know if that means a couple hours or a couple weeks.  :P
20160210 14:44:22< mattsc> Probably a couple hours of work, but that could mean a couple weeks of elapsed time.
20160210 15:04:55-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160210 15:24:06-!- gfgtdf [~chatzilla@f054152156.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.1/20160205155049]]
20160210 15:38:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160210 15:42:06-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20160210 15:43:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160210 15:48:31< vultraz> zookeeper: I'd like to get your final opinion on the look of fizz-sized portraits in the help browser before I decide whether to drop small_profile or not
20160210 15:49:05< zookeeper> full? :P
20160210 15:49:32< vultraz> er
20160210 15:49:33< vultraz> yes
20160210 15:49:35< vultraz> xD
20160210 15:51:31< zookeeper> well they look ok if your window is big, but if you go down to like 1024x768, they take up half the horizontal space and the attack stats layout breaks.
20160210 15:51:50< zookeeper> or 90% in the case of the ancient wose.
20160210 15:54:22< zookeeper> so i can't really say that it's acceptable long-term as-is. i don't mind if it's like that in an early development version, but...
20160210 15:57:11< zookeeper> what i'd suggest is anchoring the portrait(s) to the bottom of the window/panel/whatever, draw them behind all the text and darken them by 50% or something so they don't hurt text legibility much. if that's at all possible, which it might not be.
20160210 15:58:28< zookeeper> you know, like this: https://dl.dropboxusercontent.com/u/63964618/wesnoth/help_dialog_portrait_idea.jpg
20160210 15:58:42< celticminstrel> Not sure if mattsc will see this, but I think "Wesnoth AI" is a good name for a general introduction, which then links to such pages as AiWML or LuaAI or whatever.
20160210 15:59:17< vultraz> zookeeper: I'd definitely like to do that in GUI2
20160210 15:59:25< vultraz> but I don't think GUI1 allows canvas access
20160210 15:59:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160210 16:00:31< vultraz> converting the help browser to GUI2, however... will be a MONUMENTAL task
20160210 16:00:42< celticminstrel> Aaand he's already back, heh.
20160210 16:01:07< zookeeper> vultraz, how about a dirty hack, then? :p
20160210 16:02:06 * mattsc has now seen celticminstrel’s message
20160210 16:02:09< vultraz> zookeeper: I could implement a scale IPF that takes a ratio instead of dimensions and then scale the portraits to, say 400w
20160210 16:02:32< vultraz> s/ratio/factor
20160210 16:03:09< vultraz> though
20160210 16:03:21< vultraz> even WITH gui2, there's no way to anchor the portrait to the bottom of the visible area
20160210 16:03:34< vultraz> that's something our gui toolkit should be able to do, but... meh :/
20160210 16:03:39< vultraz> (or maybe there is? who knows)
20160210 16:04:44< zookeeper> would you really need to add an IPF for that, couldn't you just hardcode the scaling in somewhere?
20160210 16:05:09< vultraz> no, because ~SCALE() sets the image to the specified h/w
20160210 16:05:22< vultraz> so if the image isn't square, it will get distorted
20160210 16:06:17< zookeeper> blit it onto a blank square first, then :P
20160210 16:07:04< zookeeper> or just... calculate the new h/w
20160210 16:07:26< zookeeper> i don't know where you'd have to write that and with what constraints
20160210 16:08:25< zookeeper> but if you know the dimensions of the image and the width of the window, then it's super reasy to figure out what the image's new dimensions should be
20160210 16:09:05< vultraz> maybe size =  (imageW - 400), W - size, H - size
20160210 16:10:30< zookeeper> width = min(img_width, win_width / 2); if width != img_width then <calculate corresponding height and stuff both values into a ~SCALE>?
20160210 16:11:34< vultraz> something like that
20160210 16:12:28< zookeeper> i mean if there's nothing that prevents you from adding in a simple algorithm like that, then yes absolutely that's how it should work (exact ratio notwithstanding)
20160210 16:15:20< vultraz> that min() bit is kinda useless
20160210 16:15:25< vultraz> oh wait
20160210 16:15:29< vultraz> WIN_width
20160210 16:15:30< vultraz> hm
20160210 16:15:39< vultraz> dunno if I have that
20160210 16:18:09< zookeeper> well of course you need to know how much space you got, otherwise you can't do any smart scaling like that.
20160210 16:19:50< vultraz> simple, getting that value is not
20160210 16:20:04< vultraz> because you want the width of the text area not the entire dialog :|
20160210 16:22:26< zookeeper> on a likely related note, the unit browser crashes on 800x resolutions
20160210 16:22:34< vultraz> known
20160210 16:22:36< zookeeper> probably because a wide portrait won't fit
20160210 16:22:38< zookeeper> oh, okay
20160210 16:23:51-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160210 16:24:28< zookeeper> anyway, you can still do it based on the whole dialog's width if you have to.
20160210 16:25:00< celticminstrel> You need new_width/new_height == old_width/old_height. (Don't actually perform that check, though - it'll probably fail due to floating-point rounding and stuff.)
20160210 16:25:39< celticminstrel> Solving that for new_width or new_height is trivial.
20160210 16:25:49< celticminstrel> I assume you have at least that much algebra skill.
20160210 16:26:21< celticminstrel> I guess the harder part is deciding which to fix and which to calculate.
20160210 16:28:01-!- irker639 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160210 16:40:30< zookeeper> to me it looks like capping the portrait width as per my suggestion but to 1/3 of the total dialog width would be pretty good at all resolutions
20160210 16:41:10< zookeeper> even at 800x it would then only take up half the horizontal space of the info panel
20160210 16:42:39< zookeeper> well... a bit more, it seems. so let's say 30%.
20160210 16:45:07< zookeeper> i guess it'd still shrink down them a bit too much at big resolutions, so add in an additional threshold of some kind. in any case, it should be pretty easy.
20160210 16:47:11< vultraz> still trying to get the text area width :P
20160210 16:47:24< vultraz> there's a place where that value can be found, just trying to expose that to this bit somehow
20160210 16:49:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 17:00:07-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160210 17:14:31-!- Kwandulin [~Miranda@p200300760F0BC5FE399F7BB2EE9136F3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160210 17:28:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160210 18:03:13< vultraz> this is really not as simple as I thought it would be :|
20160210 18:03:19-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160210 18:07:20< vultraz> yeah, it's not simple
20160210 18:07:33< vultraz> (getting that value, that is)
20160210 18:07:56-!- Alduin_ [~Alduin@host231-2.natpool.mwn.de] has quit [Ping timeout: 240 seconds]
20160210 18:09:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160210 18:19:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 18:33:04-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 252 seconds]
20160210 18:35:08-!- irker321 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160210 18:35:08< irker321> wesnoth: ln-zookeeper wesnoth:master b6d2a685d328 / data/core/ (terrain-graphics.cfg terrain-graphics/new-macros.cfg): Streamlined the WML for the basic terrain base and transition rules https://github.com/wesnoth/wesnoth/commit/b6d2a685d3285913614e432d0a4d0d4e8efd5273
20160210 18:36:22-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20160210 19:14:45< zookeeper> ^ that actually seemed to make the terrain_builder constructor run quite a bit faster, for example when starting TRoW the loading screen duration went down from ~2000ms to ~1700ms.
20160210 19:14:58< vultraz> :O
20160210 19:23:18-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160210 19:51:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160210 20:09:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 20:12:37-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20160210 20:14:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160210 20:15:15< vultraz> what in the world is this https://www.dropbox.com/s/2i8ikwihiujm8pt/watdis.PNG?dl=0
20160210 20:17:29< vultraz> I've done something that gives me the mp configure screen whenever i start a campaign and that on turn 1
20160210 20:17:31< vultraz> what have i done O_O
20160210 20:19:21< vultraz> OOOOOOOH
20160210 20:19:24< vultraz> it's gfgtdf's mod
20160210 20:19:26< vultraz> whew
20160210 20:19:27< vultraz> ok
20160210 20:19:30< vultraz> i haven't broken wesnoth
20160210 20:19:51< vultraz> or the space-time continuum 
20160210 20:19:52< zookeeper> uh... wasn't that from the PYR no prep turn add-on?
20160210 20:21:57< zookeeper> oh, you said it
20160210 20:28:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160210 20:48:52-!- gfgtdf [~chatzilla@f054152156.adsl.alicedsl.de] has joined #wesnoth-dev
20160210 20:51:15< gfgtdf> vultraz: when you have a modification with [option]s enabled in sp, then the game aill automatically show you the configure screen so that you can change those [option]s. This is still not idea, see also this burreport https://gna.org/bugs/?23734
20160210 20:51:49< gfgtdf> vultraz: besides, that dialog doesnt look very good on the right side if you only hva ethat much units allowed, maybe i should fix that.
20160210 20:56:37< zookeeper> gfgtdf, can you check whether the water memory use has dropped noticeably?
20160210 20:57:23< gfgtdf> zookeeper: you mean afer your commit from 2 hours ago ?
20160210 20:57:46< zookeeper> after all my commits from the last couple of days
20160210 20:58:50< zookeeper> there won't be a big difference, but maybe a bit
20160210 21:01:05< gfgtdf> zookeeper: hmm somehow i cannot turn 'animate map' on..
20160210 21:01:36< gfgtdf> zookeeper: i enables it in the poreferences and i shows as activated there, but the mapos dont animate
20160210 21:01:49< gfgtdf> zookeeper: coudl be related to the new preferences dialog
20160210 21:01:59< gfgtdf> zookeeper: not sure though
20160210 21:02:00< zookeeper> ...and for me, when i turn it off, the map stays animated
20160210 21:02:23< zookeeper> vultraz, ^
20160210 21:02:27< vultraz> noted
20160210 21:05:26< irker321> wesnoth: Charles Dang wesnoth:master 9d77100e2ccf / src/gui/dialogs/preferences_dialog.cpp: tpreferences: fixed Animate Map toggle not working https://github.com/wesnoth/wesnoth/commit/9d77100e2ccf9be550c3bfe273664c0814ca8cb4
20160210 21:05:28< vultraz> zookeeper, gfgtdf ^
20160210 21:08:22< gfgtdf> zookeeper: I tested at my local branch which is at https://github.com/wesnoth/wesnoth/commit/edbd84d0b66d42b41f36e4ce9b929048b757ad6b (so it doen't include your latest commit 2 hours ago) and it seems to be at 900 mb ram which coudl be ~1/10 less than before. But im not fully sure that the testing environment is 100% the same.
20160210 21:09:29< zookeeper> hmh, okay. about what i expected.
20160210 21:09:47< vultraz> gfgtdf: there's a bug in the editor - the custom tod sliders don't update the tile tint anymore
20160210 21:10:11< zookeeper> gfgtdf, was your testcase still starting up DW and scrolling around the map?
20160210 21:10:29< zookeeper> oh, last one, not the first one.
20160210 21:10:40< gfgtdf> zookeeper: yes, i used the lasst scenario.
20160210 21:11:36< gfgtdf> 'tint' ?
20160210 21:12:06< vultraz> gfgtdf: the tod r/g/b tint on the map hexes 
20160210 21:12:08< zookeeper> the ToD lighting. you need to move the mouse around to refresh the hexes.
20160210 21:12:38< gfgtdf> vultraz: you mean teh 'custom time scedule' dialog ?
20160210 21:12:46< zookeeper> gfgtdf, ok, scrolling with the first scenario and then going to the last and doing the same there gets me to 925mb too.
20160210 21:13:07< gfgtdf> zookeeper: i wasnt at first i loaded a savegame form the last
20160210 21:13:13< vultraz> gfgtdf: yes, dragging those sliders are supposed to change the map tint in team time
20160210 21:13:17< gfgtdf> zookeeper: not sure if i also did that last time i testes
20160210 21:13:46< gfgtdf> vultraz: those sliders behave strange in general.
20160210 21:13:59< vultraz> gfgtdf: yes it's been like that for ~2 years
20160210 21:14:03< gfgtdf> vultraz: even if i dont mose the mouse, the sliders mode slowly to the left
20160210 21:14:07< gfgtdf> move*
20160210 21:14:12< gfgtdf> vultraz: but not liek this afaik
20160210 21:14:17< vultraz> gfgtdf: i think it's bc the window is undrawn
20160210 21:14:25< vultraz> gfgtdf: and then redrawn
20160210 21:14:44< vultraz> gfgtdf: so maybe some event somewhere isn't terminated
20160210 21:14:46< gfgtdf> vultraz: the lawful slider doesnt have this issue
20160210 21:14:47< vultraz> but im not sure
20160210 21:15:12< vultraz> gfgtdf: yes bc it doesn't undraw the window
20160210 21:15:29< gfgtdf> vultraz: hmm ok but the color of the tile border do change whne i move those slidersw
20160210 21:15:31< zookeeper> gfgtdf, i get to 540mb and ~15% of one core when i start the game, load the autosave of the last scenario, and don't scroll anywhere at all.
20160210 21:15:36< vultraz> gfgtdf: the r/g/b sliders have callbacks that undraw the window
20160210 21:15:47< vultraz> and refresh the tile tint but that doesn't work now
20160210 21:16:34< gfgtdf> vultraz: the 'okay' button fif that wondow doesnt work eigher
20160210 21:16:37< gfgtdf> window
20160210 21:16:54< vultraz> yeah i dont think fabi ever implemented that
20160210 21:17:02< vultraz> so 1.12 got shipped with a broken dialog :P
20160210 21:17:44< vultraz> it's been like that since I implemented the dialog back in 1.11
20160210 21:20:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160210 21:21:25< gfgtdf> vultraz: idk why tod light doens twokr in editor
20160210 21:23:34< vultraz> gfgtdf: hm... ok so I checked the values of the 'tod_red_field_->get_widget_value(window)' lines in stderr and they're all weird
20160210 21:26:53< vultraz> like '370', 4700, 2400
20160210 21:26:55< vultraz> etc
20160210 21:27:48< vultraz> totally wrong values
20160210 21:28:00< vultraz> so it's something in tfield probably
20160210 21:30:09< vultraz> gfgtdf: I could change this to use find_widget and see if it fixes it
20160210 21:31:04< gfgtdf> vultraz: you mean in the editor custom tod dialog?
20160210 21:35:40-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Ping timeout: 252 seconds]
20160210 21:37:17< vultraz> gfgtdf: yes
20160210 21:37:30< vultraz> gfgtdf: i think gui2 tfield is broken and that's why it's not working
20160210 21:38:01< gfgtdf> vultraz: hmm but before it also change dteh tod color when sleectign adifferent tod in the the tod list which is not the case anymore
20160210 21:38:19< gfgtdf> vultraz: so i think its rather an issue in editor <->display commuication
20160210 21:38:34< vultraz> possibly 
20160210 21:38:51< vultraz> there were some issues after making cvideo a singleton (like the buttons not displaying right),  remember 
20160210 21:38:55< vultraz> maybe this is related
20160210 21:40:51< zookeeper> 540mb normal; 240mb without water transitions; 190mb without any water; 405mb without ToD lighting.
20160210 21:41:47< shadowm> vultraz: We could've done that before, the reason I never bothered is that I was worried some people might not know what the symbol means (non-Western users?).
20160210 21:42:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160210 21:42:14< shadowm> Good job on making it non-translatable btw. :|
20160210 21:43:37< vultraz> Is that a serious comment
20160210 21:43:44< vultraz> or are your being sarcastic
20160210 21:43:55< vultraz> Because how do you translate the infinity symbol
20160210 21:45:28< shadowm> vultraz: Re https://github.com/wesnoth/wesnoth/commit/34838f3819a6099e715315298aa91ff1a439680c consider lexical_cast_default instead.
20160210 21:45:57< shadowm> I was being sarcastic. Make it translatable.
20160210 21:46:17< shadowm> Or just revert the commit, really, since I just noticed the reason why you made it bold.
20160210 21:46:37< vultraz> Again, how do you translate an infinity symbol
20160210 21:46:53< shadowm> Are you a translator?
20160210 21:47:10< vultraz> No, but you are
20160210 21:47:15< shadowm> No, I am not.
20160210 21:48:38-!- Netsplit *.net <-> *.split quits: tomreyn, stikonas, shikadibot_
20160210 21:48:39< vultraz> You're used to be and also you know how translations work
20160210 21:48:42< vultraz> You*
20160210 21:48:56< vultraz> And as far as I know, symbols don't have a translation
20160210 21:49:00< vultraz> It's like translating an arrow
20160210 21:49:04< shadowm> For one (western european) language, vultraz.
20160210 21:49:11-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20160210 21:49:20< shadowm> Last time I checked there were at least two dozen more languages more in the world that weren't western european.
20160210 21:50:01< zookeeper> i see two solutions to the water problem; either i scrap the whole thing, or someone manages to make ~CS, ~MASK and ToD lighting (or some of them) to be efficiently handled at render time instead of requiring creation of new surfaces.
20160210 21:50:07< shadowm> If translators don't want/need to change the string, they'll leave it unchanged.
20160210 21:50:20< shadowm> It's their problem to worry about, not yours, but you must provide the venue for them to solve it.
20160210 21:50:32< shadowm> Regardless, I said above to revert it back to plain text.
20160210 21:50:33< vultraz> alright, alright
20160210 21:50:51-!- Netsplit over, joins: tomreyn
20160210 21:52:32-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 250 seconds]
20160210 21:53:16< irker321> wesnoth: Charles Dang wesnoth:master 2b47d9582ada / src/gui/dialogs/preferences_dialog.cpp: tpreferences: use plain-text label for infinite autosaves https://github.com/wesnoth/wesnoth/commit/2b47d9582ada1aa1508ed5e6da98a717f7480d3e
20160210 21:53:30< vultraz> one day we will update pango and cairo and have nice rendering again
20160210 21:54:06< shadowm> We probably won't.
20160210 21:54:23< gfgtdf> vultraz: well even newere püango/caurpo version still have problems
20160210 21:55:06< vultraz> gfgtdf: oh?
20160210 21:55:10< shadowm> I'm fairly sure the real issue is somewhere in ttext's implementation. Anyone who's paying attention will notice that we specifically use different alpha decoding math on Windows, because the formula we use on X11 yields awful results there.
20160210 21:55:33< gfgtdf> vultraz: this https://gna.org/bugs/?21649 ny maybe more
20160210 21:55:36< shadowm> Or perhaps more accurately we brute-force it on Windows instead of using maths.
20160210 21:55:46< gfgtdf> and*
20160210 21:56:27< vultraz> gfgtdf: yeah I hate that bug so much >_>
20160210 21:56:34< shadowm> It's just that someone more knowledgeable ought to take the time to figure out why the X11 formula doesn't work properly there (even with ClearType disabled).
20160210 21:56:38< shadowm> *X11/OS X
20160210 21:56:46< gfgtdf> zookeeper: im not sure, another option woudl be to hope that we get hw acceleration with SDL2.
20160210 21:57:32< shadowm> (And I'm sure everything I said went above the intended audience member's head. Oh well.)
20160210 21:58:38< vultraz> Ok this is... just...what??
20160210 21:59:08< vultraz> to quote ancestral from the bug report
20160210 21:59:09< zookeeper> gfgtdf, well, sure.
20160210 21:59:12< vultraz> "The font issue goes away if I change line 8 of /data/hardwired/fonts.cfg from a comma-separated string of fonts to just: 
20160210 21:59:13< vultraz> family_order=_"DejaVu Sans" "
20160210 21:59:23< vultraz> but if you do that on windows, and then open the Campaign dialog
20160210 21:59:32< vultraz> the dialog is rendered... thinner
20160210 21:59:35< vultraz> it's not as wide
20160210 21:59:37< vultraz> what????
20160210 21:59:44< vultraz> what is this
20160210 22:01:50< vultraz> also confirms that... actually does fix the newline bug on windows as well O_O
20160210 22:01:52< vultraz> whattt????
20160210 22:02:01< vultraz> our font rendering be fucked up
20160210 22:04:47< gfgtdf> vultraz: hmm i didnt notice the text beeing smaller when its changes to "dejaVu sans"
20160210 22:04:57< vultraz> gfgtdf: no no no
20160210 22:05:00< vultraz> gfgtdf: not the text
20160210 22:05:02< vultraz> gfgtdf: window size
20160210 22:05:20< zookeeper> gfgtdf, just being able to offload the surfaces to video memory ought to solve the memory issues. i presume there's a reason why that isn't the case currently, since i'd expect even SDL1 to have that capability.
20160210 22:06:47< vultraz> gfgtdf: this is how the campaign dialog appears WITHOUT the change to the font family list: https://www.dropbox.com/s/zeksu5vb5f9pqnk/campaign_dialog_DVS_family_full_list.PNG?dl=0
20160210 22:06:57< vultraz> gfgtdf: and WITH the change https://www.dropbox.com/s/jihaxse4yto5tev/campaign_dialog_DVS_family_only.PNG?dl=0
20160210 22:08:21-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160210 22:08:22< gfgtdf> vultraz: i see
20160210 22:08:36< vultraz> yeah it's really weird
20160210 22:08:53< vultraz> also there seems to be a minor performance increase with the change 
20160210 22:09:11< gfgtdf> vultraz: maybe it used characters_per_line or similar to calculate the with of the dialog which is different if you use differnt fonts
20160210 22:09:25< vultraz> gfgtdf: it does use characters_per_line
20160210 22:09:39< vultraz> the campaign_dialog, that is
20160210 22:09:43< vultraz> campaign dialog
20160210 22:09:53< gfgtdf> vultraz: does the dialog get buigger iof you increadse that value ?
20160210 22:10:02< gfgtdf> bigger*
20160210 22:10:34< vultraz> gfgtdf: yes
20160210 22:11:32-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160210 22:12:25< vultraz> praise ancestral!
20160210 22:12:36< ancestral> You’re too kind
20160210 22:12:50< ancestral> I deserve only a small amount of praise
20160210 22:13:11< ancestral> You, however, deserve mounds of praise
20160210 22:13:49< shadowm> vultraz: You ar enot going to commit that, surely.
20160210 22:15:00< vultraz> shadowm: commit the removal of the list? 
20160210 22:15:05< shadowm> Yes.
20160210 22:15:23< vultraz> you tell me. It does fix the bug.
20160210 22:15:29< shadowm> https://www.wesnoth.org/irclogs/2016/02/%23wesnoth-dev.2016-02-04.log
20160210 22:15:48< shadowm> "No unless you can do the full research."
20160210 22:16:08< vultraz> I'm looking into it
20160210 22:16:28< shadowm> Well, I wouldn't expect _you_ to look into Pango's source code.
20160210 22:16:45< shadowm> But if you are comfortable with that then okay I guess.
20160210 22:17:27-!- ancestral_ [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160210 22:17:31< shadowm> Just, no compulsive committing, okay? All fixes need to have a reason. Treating everything like a blackbox and fixing things with piles of oblique hacks is what got us here.
20160210 22:18:07< shadowm> I'm asking this not for my sake, but rather for the sake of the Aginors who will eventually have to figure things out for us.
20160210 22:18:23< shadowm> Hopefully you'll understand.
20160210 22:22:56-!- ancestral [~ancestral@63.92.240.233] has quit [Ping timeout: 240 seconds]
20160210 22:22:57-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20160210 22:22:58-!- ancestral_ is now known as ancestral
20160210 22:23:20-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20160210 22:23:35-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160210 22:26:22-!- TheJJ [~rofl@ipbcc36ea9.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds]
20160210 22:29:24-!- mjs-de [~mjs-de@x4db6c1a9.dyn.telefonica.de] has quit [Remote host closed the connection]
20160210 22:31:08-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has joined #wesnoth-dev
20160210 22:57:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160210 23:06:02-!- gfgtdf [~chatzilla@f054152156.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.1/20160205155049]]
20160210 23:18:53< vultraz> I really can't figure out the problem
20160210 23:19:05-!- louis94 [~~louis94@13.149-243-81.adsl-dyn.isp.belgacom.be] has quit [Quit: Konversation terminated!]
20160210 23:29:30< shadowm> zookeeper: Is there a non-slanted version of the current world map somewhere in the resources repo?
20160210 23:30:00< zookeeper> shadowm, no, haven't gotten around to making one yet
20160210 23:30:03< vultraz> someone more talented than me will have to look at this
20160210 23:30:42< shadowm> *Making* so the one we use atm has the same perspective in the source?
20160210 23:31:06< vultraz> from what I can gather from source code of a later version, the families list should be split...
20160210 23:32:19< shadowm> *? So
20160210 23:32:39< vultraz> but for some reason it seems the widths of other fonts are used in the text calculations
20160210 23:33:17< shadowm> Well, that's annoying. I assumed the perspective version was generated by a script or something.
20160210 23:34:24< shadowm> zookeeper: Do we have a greater resolution version than 1280x960 px though?
20160210 23:34:57< shadowm> This has to be the most disorganized repository I've ever seen btw.
20160210 23:35:25< vultraz> it's not affected by whether the family is valid or not
20160210 23:40:12< zookeeper> shadowm, gimme a few minutes, gaming atm...
20160210 23:42:30< vultraz> none of this makes any sense
20160210 23:42:41< vultraz> layouts are supposed to have multiples ones..
20160210 23:51:58< vultraz> no duplicate calls to the description setter, either
--- Log closed Thu Feb 11 00:00:28 2016