--- Log opened Sun Feb 21 00:00:57 2016
20160221 00:06:32< ancestral_> Okay
20160221 00:06:52< ancestral_> Tell me the AI choices like I’m 5
20160221 00:07:32< ancestral_> Also, what’s up with this: https://img42.com/EfHi2
20160221 00:08:09< ancestral_> “Player/Type" and some kind of text on top
20160221 00:11:47< ancestral_> so “Dev AI + Exp Recruit C++ Akihara”, the “default” choice chosen, does not recruit ANY units
20160221 00:11:55< ancestral_> Pretty much garbage
20160221 00:12:15< ancestral_> (that is, it shouldn’t be the choice chosen when starting a game, eh?)
20160221 00:14:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160221 00:15:06< celticminstrel> vultraz: That thing about defaults applies when you press OK?
20160221 00:15:37< celticminstrel> ancestral_: That only exists in debug builds.
20160221 00:15:49< celticminstrel> And it should no longer be the default selection, either.
20160221 00:16:36< ancestral_> Debug builds?
20160221 00:16:44< ancestral_> Hmm
20160221 00:16:46< celticminstrel> Or something like that.
20160221 00:16:50< ancestral_> Okay
20160221 00:16:59< ancestral_> What is the “best” or good default AI?
20160221 00:17:44< celticminstrel> I thought it says "Default" in the name, or maybe RCA.
20160221 00:17:44< ancestral_> Default AI (RCA)? Strong AI (RECA)? Experimental AI?
20160221 00:17:57< celticminstrel> One of the first two, probably.
20160221 00:18:10< celticminstrel> I dunno what the experimental one is though.
20160221 00:18:26< celticminstrel> The one to ask would be mattsc.
20160221 00:18:29< irker314> wesnoth: Ignacio R. Morelle wesnoth:master b430993a3162 / src/make_enum.hpp: Make the MAKE_ENUM Doxygen documentation actually sane https://github.com/wesnoth/wesnoth/commit/b430993a31620883def32d2f7e55a4cc3b88e90e
20160221 00:18:52< ancestral_> vultraz: Hey, any chance we could make the AI choose box wider?
20160221 00:19:03< shadowm> gfgtdf: Comments on my last commit above?
20160221 00:19:14< ancestral_> Can’t read the whole choice in that small of a box, and there is room in the window it seems for a wider button
20160221 00:29:42< ancestral_> RLY? I saved a replay
20160221 00:29:57< ancestral_> from a local multiplayer game, all bots
20160221 00:30:09< ancestral_> When I opened the replay, it said “out of sync” >:(
20160221 00:30:27< ancestral_> I clicked No and now Wesnoth froze
20160221 00:30:46< celticminstrel> Oh my.
20160221 00:31:06< ancestral_> Ah, I need to go to Multiplayer -> Load game
20160221 00:31:07< ancestral_> STILL
20160221 00:31:27< ancestral_> Wait, there is no load game from Multiplayer
20160221 00:31:36< ancestral_> Oh
20160221 00:31:39< celticminstrel> Yeah, when it's a local game I think that shouldn't be required...
20160221 00:31:40< ancestral_> I have to create a local game
20160221 00:31:47< ancestral_> and then click the load game button
20160221 00:31:58< ancestral_> Wesnoth crashed
20160221 00:32:21< ancestral_> Wow, does not like that replay
20160221 00:34:44-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160221 00:34:44-!- enchilado [enchilado@defocus/yummy/enchilado] has quit [Client Quit]
20160221 00:35:46-!- enchilado [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160221 00:36:00-!- enchilado is now known as enchi
20160221 00:48:21-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160221 00:59:00< gfgtdf> shadowm: 'It is recommended to use MAKE_ENUM types with the built-in versions of lexical_cast or lexical_cast_default provided by Wesnoth (see util.hpp).'
20160221 00:59:35< gfgtdf> shadowm: i woudlnt really agree on this, i perosnalyl woudl recoment to use the enumname::parse function to convert strings to enum
20160221 01:00:52< gfgtdf> shadowm: i actualyl don't know how doxycomment bahave in macros. Some of the memeber function inisde teh make num macros have doxygen comments, but i dotn really know whether doxygen will parse them
20160221 01:09:22< gfgtdf> shadowm: i also dont know what 'Currently this comes in 1-argument and 2-argument versions.'  means
20160221 01:14:12< gfgtdf> vultraz: i notced that the gui2 attack dialog somethimes has a ungly scrolbar at the botttom similar to the game versionj info dialog
20160221 01:14:46< vultraz> gfgtdf: yes, I know. I need to add characters_per_line keys to the attack name labels
20160221 01:21:17< shadowm> gfgtdf: Well, I was asking specifically about the twml_exception bit.
20160221 01:22:19< shadowm> You commented out the call to make_enum_detail::debug_conversion_error without updating the documentation, so I was wondering if that was a mistake or...?
20160221 01:22:55< irker314> wesnoth: Charles Dang wesnoth:master d3617548060a / data/gui/default/window/unit_attack.cfg: tunit_attack: specify characters per line for attack name details https://github.com/wesnoth/wesnoth/commit/d3617548060a2accedd417841175bd4cb7871141
20160221 01:23:38< vultraz> shadowm: ^ should fix last issue with attack dialog layout
20160221 01:23:48< vultraz> shadowm: if you have other critiques let me know
20160221 01:23:59< vultraz> (including if I should make that line a different color)
20160221 01:25:06< shadowm> vultraz, celticminstrel: "Such a thing should be handled in the post_show function. The display() function isn't supposed to be implemented outside the header." -- According to who?
20160221 01:25:19< vultraz> Which part?
20160221 01:25:35< shadowm> "Such a thing should be handled in the post_show function. The display() function isn't supposed to be implemented outside the header."
20160221 01:25:38< shadowm> According tow ho?
20160221 01:26:25-!- rcmonnet [~rcmonnet@user-24-214-87-127.knology.net] has joined #wesnoth-dev
20160221 01:26:25-!- rcmonnet [~rcmonnet@user-24-214-87-127.knology.net] has quit [Client Quit]
20160221 01:26:32< shadowm> The whole thing, vultraz. Both sentences are uncited.
20160221 01:26:39< vultraz> The former, from what I've observed in other code. The latter, I just assumed.
20160221 01:27:52< shadowm> Just because all cats you've seen in your life are tabbies doesn't mean that calicos don't exist.
20160221 01:29:15< shadowm> I would like to note that GUI2 is very bad in general about delegation of responsibilities with dialogs.
20160221 01:29:42< shadowm> Sometimes it's up to the caller to act upon dialog input, sometimes the dialog does it itself.
20160221 01:31:15< shadowm> The fact that multiple people with their own coding styles have written GUI2 dialogs that are later taken as example by other people doesn't help matters. In fact, it makes the situation exponentially worse as time goes on.
20160221 01:32:31< shadowm> If your dialog is taking responsibility for user actions already, I'd tend to agree that it should do so in post_show and not in the optional static wrapper.
20160221 01:33:19< gfgtdf> shadowm: about debug conversion error
20160221 01:33:21< shadowm> However, there's little point in making a rule about whether the wrapper should be inline or not, and in fact, there is no such rule.
20160221 01:33:43< shadowm> There's basically no point in such a thing because the wrapper will be called exactly once per context.
20160221 01:34:06< shadowm> There's no inline vs. function call overhead argument to even think about in such a situation.
20160221 01:34:07< gfgtdf> shadowm: it looks to me liek i disables it becasue i wanted to use MAKE_ENUM in teh server code and debug conversion had client specific dependencies
20160221 01:35:48< shadowm> gfgtdf: Okay, so basically it's intentional and the implementation just diverged from the documentation?
20160221 01:36:40< shadowm> In that case I'll remove the remaining bit about the exception.
20160221 01:38:19< shadowm> I don't think Doxygen can parse comments generated by macro contents, that'd be a bit weird.
20160221 01:38:57< gfgtdf> shadowm: hmm yes i think removing the remaining bit about the exception. is good
20160221 01:39:11< gfgtdf> shadowm: you mean twmlexception right ?
20160221 01:40:32< shadowm> Yes.
20160221 01:46:58< celticminstrel> The fact that GUI2 recommends a static wrapper in the first place is problematic.
20160221 01:47:34< celticminstrel> And it seems to require that every window has an ID, but are those IDs even used for anything?
20160221 01:50:12< shadowm> Window instance, or window definition?
20160221 01:50:22< celticminstrel> Definition.
20160221 01:50:35< shadowm> You mean window_id()?
20160221 01:50:41< celticminstrel> Yeah.
20160221 01:50:50< shadowm> I'd assume it's how the engine matches the WML defining the window layout.
20160221 01:51:31< celticminstrel> Yeah, okay, I can see how that would work.
20160221 01:59:06< vultraz> celticminstrel, shadowm: the C++ code validates whether a window id is present in WML at startup
20160221 02:01:25< irker314> wesnoth: Charles Dang wesnoth:master a6101bf80dda / data/gui/default/ (macros/_initial.cfg widget/label_default.cfg): gui2: tweak title-style label design https://github.com/wesnoth/wesnoth/commit/a6101bf80dda9a10b2a9b9f1ca0c085901d78047
20160221 02:01:28< irker314> wesnoth: Charles Dang wesnoth:master 4ad472216062 / data/gui/default/window/preferences.cfg: tpreferences: slight height bump https://github.com/wesnoth/wesnoth/commit/4ad47221606246b805dc77c926fafa8ea610b88d
20160221 02:05:18< vultraz> celticminstrel: do tell me when 603 is ready to merge
20160221 02:11:17< irker314> wesnoth: Ignacio R. Morelle wesnoth:master eabe55b40781 / src/make_enum.hpp: Remove obsolete documentation bit https://github.com/wesnoth/wesnoth/commit/eabe55b4078102bceb720002b854f71529bdc3c6
20160221 02:16:59< irker314> wesnoth: Ignacio R. Morelle wesnoth:master b04c158e89c3 / data/gui/default/window/ (5 files in 2 dirs): gui2/tpreferences: Macro scope cleanup https://github.com/wesnoth/wesnoth/commit/b04c158e89c3453e4f3affb4c655d8cf68be5a5a
20160221 02:18:53< irker314> wesnoth: Charles Dang wesnoth:master b0344fed20a2 / src/ (font.hpp show_dialog.cpp): Update GUI1 title style to match GUI2 (as of a6101bf80dda) https://github.com/wesnoth/wesnoth/commit/b0344fed20a2e49a8f06108e70ff3df9bed53f88
20160221 02:20:21< vultraz> new title style looks cleaner, IMO
20160221 02:22:50< vultraz> I'm not sure why, but bold text often doesn't seems as elegant as larger text
20160221 02:23:56< ancestral_> Actual bold, or faux bold?
20160221 02:24:13< vultraz> What do you mean
20160221 02:24:20< vultraz> What is faux bold
20160221 02:25:34< ancestral_> Fake bold; basically the rendering system tries to make the text thicker
20160221 02:25:50< shadowm> We ship DejaVu Sans Bold, so it shouldn't be synthetic bold even in GUI1.
20160221 02:26:15< vultraz> Well, still. Take a look now and tell me what you think
20160221 02:26:21< ancestral_> https://www.smashingmagazine.com/2012/07/avoiding-faux-weights-styles-google-web-fonts/
20160221 02:26:27< ancestral_> shadowm: It *shouldn’t*
20160221 02:26:45< ancestral_> That’s why I was curious when vultraz said it didn’t look good
20160221 02:27:04< shadowm> Personal preference, I'd say.
20160221 02:28:00< vultraz> I will say that the old style looked better in GUI1
20160221 02:28:10< vultraz> But the new style looks better in GUI2
20160221 02:28:41< shadowm> And that's saying something, because you are looking at glitchy fonts all over GUI2.
20160221 02:29:01< ancestral_> vultraz: If you start a multiplayer local game, does the header at the top, just above the entries for the players, does the text render correctly for you?
20160221 02:29:32< vultraz> Not really, shadowm. I've come to appreciate the current font settings.
20160221 02:29:42< vultraz> ancestral_: gimme a sec to finish bulding
20160221 02:29:49< shadowm> No vultraz, you are looking at a bug.
20160221 02:29:58< shadowm> Fonts in GUI2 are not supposed to look like they do for you.
20160221 02:30:17< vultraz> Then what are they supposed to look like?
20160221 02:31:00< vultraz> ancestral_: yes
20160221 02:31:05< vultraz> oh wait
20160221 02:31:06< shadowm> This: https://dl.dropboxusercontent.com/u/21371130/Screenshots/zzzzz13.png Not those horrid emaciated shapes you get on Windows.
20160221 02:31:15< shadowm> *emaciated aliased shapes
20160221 02:31:23< vultraz> ancestral_: do you mean the "player type"label?
20160221 02:31:27< ancestral_> Yes\
20160221 02:31:48< vultraz> ancestral_: that is glitched 
20160221 02:32:05< ancestral_> Same here
20160221 02:32:13< ancestral_> Do you want me to create a bug for it?
20160221 02:32:16< vultraz> yes
20160221 02:32:48< vultraz> shadowm: to be honest... I can't see the difference
20160221 02:32:49< ancestral_> Assign you, or leave that field alone?
20160221 02:34:00< vultraz> ancestral_: weird... if I go back to the same screen it's no longer bugged
20160221 02:34:14< vultraz> ancestral_: probably leave that field alone, but you should confirm what I just said
20160221 02:34:30< vultraz> wait
20160221 02:34:52< vultraz> ancestral_: ok it's not bugged unless you switch away from the window and back
20160221 02:34:56< ancestral_> Now this time, I don’t see it bugged
20160221 02:35:01< ancestral_> So it’s intermittent
20160221 02:35:14< vultraz> I can consistently reproduce it that way
20160221 02:35:18< vultraz> in which case, assign it to Aginor 
20160221 02:35:42< ancestral_> Wow
20160221 02:35:50< ancestral_> I left the window and came back, and it’s bugged
20160221 02:35:53< ancestral_> Alright
20160221 02:36:26< ancestral_> Yeah, when you leave the window
20160221 02:36:38< vultraz> I wish I could read what's drawing over it
20160221 02:36:45< ancestral_> Same, hard to tell
20160221 02:37:03< vultraz> I seem to see
20160221 02:37:06< vultraz> äe or gam
20160221 02:37:07< vultraz> er
20160221 02:37:10< vultraz> "ae or gam"
20160221 02:37:10< ancestral_> I can see “of” and a a
20160221 02:37:27< ancestral_> Type of Game?
20160221 02:37:36< ancestral_> (obviously some of that is clipped)
20160221 02:37:41< vultraz> AH
20160221 02:37:42< vultraz> no no
20160221 02:37:50< vultraz> it's "name of game" bleeding through from the previous screen
20160221 02:38:03< ancestral_> You are exactly right!
20160221 02:41:25< celticminstrel> BTW Vultraz, event:: is a namespace specifier, not a class specifier (because event is a namespace, not a class).
20160221 02:42:16< ancestral_> https://gna.org/bugs/?24437
20160221 02:48:41< vultraz> shadowm: I took that screenshot, overlayed the same shot from my build, and did a comparison
20160221 02:48:48< vultraz> shadowm: there's *no* difference between them
20160221 02:49:04< vultraz> Except you had bad kerning between the "T" and "u" in 'Turn Dialog'
20160221 02:49:47< vultraz> so I'm not sure where the 'glitchy glyphs' are
20160221 02:52:38< vultraz> either way, seems windows fonts are now rendering 'correctly'
20160221 02:55:53< ancestral_> vultraz: Is that with the comma-separated list or without?
20160221 02:56:04-!- gfgtdf_ [~chatzilla@f054144058.adsl.alicedsl.de] has joined #wesnoth-dev
20160221 02:56:46< vultraz> ancestral_: with
20160221 02:57:55< ancestral_> It renders the same regardless of the list for you, right? It’s only the multiple returns that has trouble
20160221 02:58:11< vultraz> yes
20160221 02:58:13-!- gfgtdf [~chatzilla@x50ab6d92.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160221 02:58:14-!- gfgtdf_ is now known as gfgtdf
20160221 02:58:22< vultraz> and the character width value
20160221 03:00:19< ancestral_> Right
20160221 03:00:26< ancestral_> That could be an issue
20160221 03:00:45< ancestral_> vultraz: Oh I noticed something
20160221 03:00:45< vultraz> so far it only means excessive dialog space is allocated
20160221 03:01:17< ancestral_> I have Deja Vu Sans Condensed installed on my system
20160221 03:01:34< ancestral_> If I put “Deja Vu Sans” in the fonts.cfg, guess what
20160221 03:01:38< vultraz> what?
20160221 03:01:42< ancestral_> It uses DVS Condensed
20160221 03:01:47< vultraz> ...weird
20160221 03:01:50< ancestral_> Even though I also have DVS installed
20160221 03:02:00< ancestral_> Mm hmm
20160221 03:02:36< ancestral_> I am growing less and less fond of Pango/Cairo
20160221 03:03:55< vultraz> Let's switch to Harfbuzz + Pango :P
20160221 03:05:47-!- prkc [~prkc@46.166.190.184] has quit [Remote host closed the connection]
20160221 03:08:29< celticminstrel> vultraz: New orb buttons aren't bad.
20160221 03:08:33< ancestral_> Let’s just have bitmap fonts for everything and make everyone’s eyes bleed
20160221 03:08:50< vultraz> celticminstrel: 'not bad' or 'good'? :)
20160221 03:08:52< celticminstrel> Actually makes them look like inverted radiobuttons. :P
20160221 03:09:05< vultraz> celticminstrel: your problem was you had a 24x24 image with a size specified as 30
20160221 03:09:10< vultraz> so it was being scaled up
20160221 03:09:13< vultraz> and didn't look good
20160221 03:09:23< celticminstrel> Did I? I didn't notice.
20160221 03:09:24< celticminstrel> >_>
20160221 03:10:10< vultraz> also the square bg thing was bleh
20160221 03:10:10-!- ancestral_ [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: ancestral_]
20160221 03:10:15< celticminstrel> The diff said that the existing orb icons were changed too, but I didn't see any difference (except removal of that weird square from tbehind the pressed one).
20160221 03:10:26< vultraz> yes
20160221 03:10:30< vultraz> i made them 30x30
20160221 03:10:43< celticminstrel> Ah, so you resized them.
20160221 03:12:55< celticminstrel> Were they 24x24 too?
20160221 03:13:06< celticminstrel> I just used the existing icons from the old GUI1 version.
20160221 03:14:12< celticminstrel> Also, I'm pretty sure orb and orb-pressed are now the same.
20160221 03:15:59< celticminstrel> shadowm: What's your opinion on what Vultraz said? Should I use post_show instead of display? Should I remove the unnecessary event:: qualifier?
20160221 03:23:54-!- gfgtdf [~chatzilla@f054144058.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160221 03:46:11< shadowm> The fact that a static function is taking responsibility for acting on user input makes things pretty much the same as if the dialog itself was doing so.
20160221 03:46:47< shadowm> In such case, it should be in the post_show() method unless you have a very specific reason for doing otherwise.
20160221 04:02:24< nkr> Hey is there a dev roadmap?
20160221 04:02:24< vultraz> celticminstrel: oh, you mean the images/buttons/orbs thing was from gui1?
20160221 04:05:06< celticminstrel> Yeah.
20160221 04:06:42< vultraz> those are the ones i resized
20160221 04:09:55< celticminstrel> So everyone says 603 is merge-ready?
20160221 04:10:20< vultraz> yes\
20160221 04:10:40< vultraz> did you add the border i requested?
20160221 04:10:55< vultraz> er, spacer row
20160221 04:11:10< celticminstrel> Huh?
20160221 04:11:19< celticminstrel> I don't remember such a thing.
20160221 04:11:54< vultraz> i asked if you could add a spacer row above the zooms lider
20160221 04:11:56< vultraz> slider
20160221 04:12:05< vultraz> just recently
20160221 04:12:07< vultraz> not earlier
20160221 04:12:23< celticminstrel> Ah.
20160221 04:12:52< celticminstrel> I'm not sure how to do that.
20160221 04:13:13< vultraz> I said in my comment
20160221 04:13:19< celticminstrel> Okay.
20160221 04:13:30< vultraz> just add a macro inclusion of that macro right at the line specified
20160221 04:18:32< vultraz> then merge
20160221 04:19:10< vultraz> I'll probably do a code cleanup on the orb dialog once tgroup is done
20160221 04:19:37< vultraz> i've realized I also need a 'get active member' method
20160221 04:19:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160221 04:22:22< celticminstrel> In groups?
20160221 04:22:30< celticminstrel> You didn't realize that until now? :|
20160221 04:44:01-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160221 04:44:01-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20160221 04:44:01-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160221 04:52:52< vultraz> no :P
20160221 04:53:57-!- Gambit [~derek@wesnoth/developer/grickit] has quit [Quit: No Ping reply in 180 seconds.]
20160221 04:54:19< celticminstrel> I'm sure I must've mentioned it once or twice.
20160221 04:55:33-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20160221 05:02:19< celticminstrel> ...
20160221 05:02:31< celticminstrel> "switch (pref_type.v)"
20160221 05:02:43< celticminstrel> Whose idea was it to name it that.
20160221 05:03:01< celticminstrel> (Is that a MAKE_ENUM thing? It looks like it probably is.)
20160221 05:03:22< celticminstrel> Okay, so V is for value or something, but still...
20160221 05:08:45< vultraz> yes
20160221 05:08:50< vultraz> I don't know why it's called v
20160221 05:08:52< vultraz> but it is
20160221 05:09:03< vultraz> (yes, it's MAKE_ENUM)
20160221 05:09:13< shadowm> Because whoever wrote it hates us.
20160221 05:09:25< celticminstrel> Ha ha.
20160221 05:10:13< shadowm> I don't have anything against single-letter variable names per se, but if their purpose isn't obvious from context (e.g. if declared as parameters to a function)...
20160221 05:15:42< vultraz> shadowm: I'd like to move Cores to preferences
20160221 05:16:13< vultraz> (though tbh I'd like to scrap the feature altogether. If we're aiming for larger distribution it could be dangerous)
20160221 05:16:27< vultraz> or problematic 
20160221 05:16:37< celticminstrel> Why?
20160221 05:17:19< vultraz> well...
20160221 05:17:34< vultraz> i assume different cores can't be used with each other
20160221 05:17:36< vultraz> but still
20160221 05:17:50< vultraz> who would add the whole library of stuff required to use it?
20160221 05:17:57< vultraz> music/fonts/sounds/images/etc
20160221 05:18:27< vultraz> and I don't even know if we can validate the files in the core
20160221 05:18:39< celticminstrel> Validate?
20160221 05:18:42< vultraz> what if someone used it to distribute... inappropriate or malicious material
20160221 05:18:58< celticminstrel> Malicious seems kinda unlikely.
20160221 05:19:25< vultraz> plus the entire feature is useless because each addon is its own core
20160221 05:19:52< celticminstrel> Huh? No it's not.
20160221 05:21:09< shadowm> vultraz: I told you two years ago I wanted to move it to Add-ons.
20160221 05:21:38< vultraz> in what capacity
20160221 05:21:40< shadowm> If you want to drop it, I won't stop you, but you will have to take responsibility for the whole thing and the potential fall out.
20160221 05:21:55< shadowm> That's all I have to say on the matter.
20160221 05:22:14< celticminstrel> I imagine there was some sort of reason for adding it.
20160221 05:22:33< vultraz> the same person who added the orbs added it
20160221 05:22:40< celticminstrel> Ah.
20160221 05:22:53< celticminstrel> You can't really say an addon is its own core.
20160221 05:23:43-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20160221 05:24:11-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160221 05:25:00< iceiceice> all i will say is, it looks like MAKE_ENUM has evolved considerably since it was created and since I wrote the docs for it
20160221 05:25:12< iceiceice> idk at what point the exception thing went away, or when it had a "v" variable
20160221 05:25:21< shadowm> vultraz: I will say this though: you have an alarming tendency to suggest removing anything that you don't consider useful for your own ends or that caters to a niche audience you aren't a part of.
20160221 05:28:20< celticminstrel> iceiceice: Still has a "v" variable.
20160221 05:28:40< iceiceice> did it always though? I don't remember that
20160221 05:30:00< vultraz> shadowm: it's not just for my own ends here. I see it as a complication for steam, a potential distribution method for inappropriate material, a complication in the future regarding maintainability, as well as a feature which currently doesn't make much sense or seem to even theoretically provide usefulness to UMC authors
20160221 05:30:31< shadowm> "Inappropriate material" is as much a valid argument against cores as it is against add-ons in general.
20160221 05:30:42< celticminstrel> Yeah, I agree there.
20160221 05:31:19< shadowm> Regarding maintainability, dropping translations support would simplify the codebase by at least 500%.
20160221 05:31:49< shadowm> As for theoretical usefulness, the author of the feature actually wanted to use it/used it for his own add-on.
20160221 05:32:19< vultraz> what addon was that?
20160221 05:32:54< shadowm> I don't remember the name but it exists in some form.
20160221 05:34:08< vultraz> Plus, I believe we should consider just how much moddability we want to give wesnoth.
20160221 05:34:09< shadowm> Now, I did say I won't stop you. All I'm expecting from you is to make a judicious choice and not act based on a hunch and broken arguments.
20160221 05:35:25< shadowm> I already said far more words than the word budget I had alloted for the subject.
20160221 05:35:46< vultraz> you have word budgets?
20160221 05:36:27< ancestral> vultraz: shadowm’s brain only has so much storage and memory
20160221 05:37:03< ancestral> Don’t crash his kernel
20160221 05:37:32< celticminstrel> It looks like the so-called failsafe core doesn't work as advertised.
20160221 05:37:42< vultraz> celticminstrel: that is another point
20160221 05:37:58< celticminstrel> Well, it's not necessarily an argument for removal.
20160221 05:38:02< vultraz> as a temporary measure I'll probably just hide the button if there are no custom cores
20160221 05:38:07< vultraz> until we decide what to do with it
20160221 05:38:34< ancestral> Good
20160221 05:39:03< ancestral> …and eventually, very incomplete languages too? ;-)
20160221 05:39:46< vultraz> you'll have to give me a way to specify the excluded ones :P
20160221 05:39:52< shadowm> https://gna.org/bugs/index.php?18826
20160221 05:40:58< celticminstrel> I want to remove the images/icons/terrain folder since everything in there is a duplicate.
20160221 05:41:09< ancestral> Interesting. I noticed https://gna.org/bugs/?15633
20160221 05:41:12< vultraz> I'd agree but I think it's for umc
20160221 05:41:16< vultraz> ya know
20160221 05:41:16< shadowm> Parse msgfmt's output (the stdout output, not the file output), collect numbers, do something with them.
20160221 05:42:39< celticminstrel> But that probably means scouring the code for places that might hardcode references to the folder.
20160221 05:42:39< vultraz> the whole 'umc in core, core game in images', thing
20160221 05:42:39< vultraz> celticminstrel: uh, no?
20160221 05:42:39< vultraz> celticminstrel: the paths are the same
20160221 05:42:39< vultraz> i think
20160221 05:42:39< celticminstrel> Sorry vultraz, I'm not sure what you're talking about.
20160221 05:42:39< vultraz> oh
20160221 05:42:40< vultraz> you want to remove the one in images not in core?
20160221 05:43:42< celticminstrel> Well, one of them, but I prefer the one in images.
20160221 05:44:25< celticminstrel> Last I checked the editor wouldn't actually accept an image that wasn't in that folder. I think.
20160221 05:44:40< celticminstrel> Though I could've just been doing something wrong, I suppose.
20160221 05:58:04-!- Kwandulin [~Miranda@p200300760F0BC50021F90AD3D5DBEFB6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160221 06:20:08-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Read error: Connection reset by peer]
20160221 06:20:33-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160221 06:32:57< Aginor> hi again
20160221 06:33:02< Aginor> I'm back :)
20160221 06:33:30< Aginor> finally got that wire or whatever was broken repaired
20160221 06:35:00< irker314> wesnoth: Celtic Minstrel wesnoth:master b238c42caf7b / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): preferences: Copy friend name and notes to field when selected, for easier editi https://github.com/wesnoth/wesnoth/commit/b238c42caf7b4dd5053bb6ad072875be696939a6
20160221 06:35:02< irker314> wesnoth: Celtic Minstrel wesnoth:master 270d3fd482e8 / / (6 files in 3 dirs): Preferences: Implement a font scaling option https://github.com/wesnoth/wesnoth/commit/270d3fd482e820da47e2516ae27b4e20fff724d8
20160221 06:35:04< irker314> wesnoth: Celtic Minstrel wesnoth:master fc12c8bcc800 / src/ (font.cpp loadscreen.cpp marked-up_text.cpp): Honour font scaling factor when drawing with SDL_TTF https://github.com/wesnoth/wesnoth/commit/fc12c8bcc8000123064458e094ae6e29bd2bedb5
20160221 06:35:06< irker314> wesnoth: Celtic Minstrel wesnoth:master d8268c0bd6c1 / src/gui/auxiliary/ (window_builder.cpp window_builder.hpp): GUI2: Improve an error message https://github.com/wesnoth/wesnoth/commit/d8268c0bd6c130c9ccc5d1717bea9cfc22e4d207
20160221 06:35:08< celticminstrel> Aginor: Yay!
20160221 06:35:08< irker314> wesnoth: Celtic Minstrel wesnoth:master 38ddbb98f232 / / (9 files in 6 dirs): Preferences: Reimplement orb color options https://github.com/wesnoth/wesnoth/commit/38ddbb98f23221aae8a60cc387c520f69db077d3
20160221 06:35:10< irker314> wesnoth: Celtic Minstrel wesnoth:master 33da7920cf97 / / (5 files in 4 dirs): Add new orb selection dialog to unit tests and other build systems https://github.com/wesnoth/wesnoth/commit/33da7920cf97461feca3fcdba9c16bede132af80
20160221 06:35:12< irker314> wesnoth: Celtic Minstrel wesnoth:master eef5db932760 / src/ (gui/dialogs/preferences_dialog.cpp preferences_display.cpp): Minor prefs cleanup https://github.com/wesnoth/wesnoth/commit/eef5db9327606023a124b64a786e73c329778838
20160221 06:35:14< irker314> wesnoth: Celtic Minstrel wesnoth:master 1e71e1f0bcfe / src/preferences.cpp: Preferences: Handle cases of renamed orb colour ranges https://github.com/wesnoth/wesnoth/commit/1e71e1f0bcfef232cbcd798e294681e97f1cce8b
20160221 06:35:16< irker314> wesnoth: Charles Dang wesnoth:master 85fefbe5b88c / / (6 files in 2 dirs): Improve design of Orb toggle buttons https://github.com/wesnoth/wesnoth/commit/85fefbe5b88c5da23f28297dffcbaf9355c9bcbc
20160221 06:35:19< irker314> wesnoth: Celtic Minstrel wesnoth:master 6848a6d596a0 / / (4 files in 2 dirs): Preferences: code cleanup and minor bugfix https://github.com/wesnoth/wesnoth/commit/6848a6d596a054568607697744a7b5c4f7899eba
20160221 06:35:21< irker314> wesnoth: Celtic Minstrel wesnoth:master 742d17932f68 / / (30 files in 13 dirs): Merge pull request #603 from CelticMinstrel/prefs_stuff https://github.com/wesnoth/wesnoth/commit/742d17932f68bfec011516b62da193763c30bb31
20160221 06:35:55< Aginor> celticminstrel: yay indeed
20160221 06:36:21< Aginor> I hadn't realised quite how dependant I was on the internet until it was suddenly gone for a few days
20160221 06:40:20-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160221 06:40:27< celticminstrel> Now that's merged, I'm going to bed.
20160221 06:42:31-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160221 06:45:37-!- fr_rrr [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 252 seconds]
20160221 06:46:06-!- fr_rrr [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160221 06:59:49-!- travis-ci [~travis-ci@ec2-54-162-45-155.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 06:59:51< travis-ci> wesnoth/wesnoth#8533 (master - 742d179 : Celtic Minstrel): The build was broken.
20160221 06:59:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110712304
20160221 06:59:51-!- travis-ci [~travis-ci@ec2-54-162-45-155.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 07:19:21< vultraz> hey Aginor :)
20160221 07:22:50< shadowm> Well, I tried to reboot and it looks like midway through the console driver crashed, then systemd hung up, then the UEFI crashed after using alt+sysrq+b to force a reboot.
20160221 07:23:07< vultraz> fun!
20160221 07:23:29< shadowm> I kind of wonder if it's related to the machine miraculously surviving a power failure yesterday without shutting down.
20160221 07:26:03< shadowm> (Power went out for one second and somehow only the monitor was switched off.)
20160221 07:26:49< shadowm> (Same monitor that some time ago stayed blinking the power indicator LED for 15 minutes after power went out.)
20160221 07:32:57< vultraz> don't you have a UPS?
20160221 07:34:49< shadowm> I have never said anything that would imply such a thing to be the case.
20160221 07:36:45< vultraz> [18:26:02]	shadowm	(Power went out for one second and somehow only the monitor was switched off.)
20160221 07:36:58< vultraz> if you had a UPS such a power outage would be of no concern 
20160221 07:37:12< shadowm> Thank you, Admiral Obvious.
20160221 07:38:56< vultraz> now, I don't have a UPS
20160221 07:39:01< vultraz> but you should acquire one
20160221 07:39:31< shadowm> Give me money.
20160221 07:39:57< vultraz> I thought you had money
20160221 07:41:45< shadowm> Oh, I know, let me bait you some more so you can gain some more XP to level up to Grand Admiral.
20160221 07:42:00< shadowm> Daaamn my hard disk drive feels so much slower every daaaay.
20160221 07:42:10< shadowm> If oooonly there was a waaaaay to fix that.
20160221 07:43:29< shadowm> Maybe some kind of NON-MAGNETIC permanent STORAGE contraption.
20160221 07:43:34< vultraz> If you bought a SSD that would be fixed
20160221 07:43:51< shadowm> Tell me more.
20160221 07:45:04< vultraz> It is a non-magnetic permanent storage contraption.
20160221 07:45:39< shadowm> What do I need to do in order to acquire this item?
20160221 07:46:50< vultraz> Present currency to a retailer 
20160221 07:47:22 * shadowm congratulates vultraz for his promotion.
20160221 07:47:39< shadowm> Yay, huzzah, etcetera.
20160221 07:48:11 * vultraz feels accomplished
20160221 07:52:15< iceiceice> sounds like the perfect opportunity to spend a day trying to install "libreboot" :)
20160221 08:03:28-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160221 08:04:22-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Client Quit]
20160221 08:07:11-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160221 08:12:33< Ivanovic> shadowm: i am just adding a new translation (Asturian)
20160221 08:12:50< Ivanovic> shadowm: please keep an eye out at the next po update of master to make sure the files still compile
20160221 08:13:06< Ivanovic> sometimes, during first pot-update, the files create build issues
20160221 08:13:14< Ivanovic> (they are building nicely right now)
20160221 08:14:01< irker314> wesnoth: Nils Kneuper wesnoth:master a13ad0c23e9d / / (63 files in 32 dirs): added Asturian translation https://github.com/wesnoth/wesnoth/commit/a13ad0c23e9d27f71c5581f163d9caa94eba462e
20160221 08:15:56< irker314> wesnoth: Nils Kneuper website:master 404a990f7003 / gettext.wesnoth.org/langs.php: added Asturian translation to g.w.o https://github.com/wesnoth/website/commit/404a990f700372364e9e029fc1ab2dad06a44bc1
20160221 08:17:49< shadowm> Ivanovic: Okay.
20160221 08:18:08< Ivanovic> and i hope that just adding the lang was enough for wescamp to keep working
20160221 08:18:25< shadowm> WesCamp has been dead for like two years, so it doesn't really matter.
20160221 08:18:29< Ivanovic> of course it will cause some "problems" with "files missing" on the stable pages until there is a stable release with it
20160221 08:18:32< Ivanovic> ah, okay
20160221 08:30:26< irker314> wesnoth: Charles Dang wesnoth:master 6d48d72b7b1a / data/gui/default/window/ (preferences.cfg preferences/01_general.cfg): tpreferences: move composite slider definition to main file https://github.com/wesnoth/wesnoth/commit/6d48d72b7b1a7850979d9bea6ece084dde1aab9e
20160221 08:34:28< shadowm> Welp: http://blog.linuxmint.com/?p=2994
20160221 08:35:08< Aginor> that's pretty bad
20160221 08:35:37< Aginor> although you shouldn't use Mint if you're even remotely security concious
20160221 08:36:47< shadowm> The average user (the kind of person who'd choose Ubuntu or Mint over e.g. Debian or CentOS or RHEL or OpenBSD) doesn't care much about security, though.
20160221 08:37:15< Aginor> no, but they'd hopefully pick Ubuntu over Mint
20160221 08:37:18< shadowm> Or doesn't necessarily understand why they should care.
20160221 08:37:31< Aginor> (my complaint is about update policies in Mint)
20160221 08:37:39< Aginor> it might have changed though
20160221 08:38:10-!- travis-ci [~travis-ci@ec2-54-162-45-155.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 08:38:11< travis-ci> wesnoth/wesnoth#8534 (master - a13ad0c : Nils Kneuper): The build is still failing.
20160221 08:38:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110719975
20160221 08:38:11-!- travis-ci [~travis-ci@ec2-54-162-45-155.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 08:38:23< shadowm> I'm not really familiarized with Mint beyond hearing from other people (including one of our devs) that it's somehow "better than Ubuntu".
20160221 08:39:04< shadowm> I thought it relies on the Ubuntu repositories, which hopefully means it also uses their security update repos?
20160221 08:39:34< shadowm> s/one/two/
20160221 08:40:08< Aginor> they are a customised version of ubuntu, they rely on their repos but augment with their own. They also filter all packages submitted by ubuntu to the repos so they can control when things get updated
20160221 08:40:33< Aginor> they at least were holding back critical security updates in case they might affect performance or stability
20160221 08:40:46< Aginor> actively exploited updates :/
20160221 08:40:57< Aginor> at which point I switched to Fedora
20160221 08:41:40< vultraz> interesting......
20160221 08:44:54< vultraz> ah I see why the slider was behaving that way
20160221 08:50:48< vultraz> I'm going to make the font scaling slider only take affect once prefs is closed
20160221 08:52:37< vultraz> effect
20160221 08:54:36< Aginor> vultraz: is that concistent with the rest of the behaviour there?
20160221 08:54:57< vultraz> Aginor: no, actually. other prefs are set as soon as their widgets change
20160221 08:55:01< vultraz> but this is a special case
20160221 08:55:13< vultraz> if you don't, the font size changes *as you drag the slider*
20160221 08:55:16< vultraz> t'is bad :P
20160221 08:55:32< Aginor> not from a usability point of view
20160221 08:56:03-!- Appleman1234 [~Appleman1@KD119104009060.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20160221 08:56:38< vultraz> Aginor: well, actually, it only grows as you drag the slider (and this too only if you use a scroll label)
20160221 08:56:41< vultraz> doesn't shrink
20160221 08:56:50< vultraz> AND
20160221 08:56:56< vultraz> it only happens in the prefs window
20160221 08:57:41< Aginor> :D
20160221 08:57:49< Aginor> the joys of our event handling
20160221 08:58:15< vultraz> the joys of shitty gui2 widgets, you mean :P
20160221 08:59:03< Aginor> no, if all you had was gui2 it'd be alright
20160221 08:59:11< Aginor> the mix between 1 and 2 is terrible
20160221 08:59:29< Aginor> and the event handling is... not so awesome in the interaction thereof
20160221 09:00:52-!- travis-ci [~travis-ci@ec2-54-90-132-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 09:00:53< travis-ci> wesnoth/wesnoth#8535 (master - 6d48d72 : Charles Dang): The build was fixed.
20160221 09:00:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110721389
20160221 09:00:53-!- travis-ci [~travis-ci@ec2-54-90-132-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 09:06:23< irker314> wesnoth: Charles Dang wesnoth:master ad8468698916 / data/gui/default/window/preferences/02_display.cfg: tpreferences: tweaked layout of Font Scaling slider https://github.com/wesnoth/wesnoth/commit/ad8468698916694085ba6d40b79959881d2fc315
20160221 09:06:27< irker314> wesnoth: Charles Dang wesnoth:master 4f6be879a5fe / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: made font scaling apply during post show not when dragging slider https://github.com/wesnoth/wesnoth/commit/4f6be879a5fe5d3bff1ffe7d7ca0490f92c435e8
20160221 09:06:29< irker314> wesnoth: Charles Dang wesnoth:master 8952ca05a839 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: always apply suffix to bound status labels https://github.com/wesnoth/wesnoth/commit/8952ca05a839233e790c6d30a2b6568c7ad77353
20160221 09:07:13< vultraz> Aginor: so do you plan to merge guifixes soon?
20160221 09:08:20< Aginor> vultraz: let's see how this particular set of changes I am poking right now looks
20160221 09:08:28< vultraz> :)
20160221 09:08:41< Aginor> but if it looks alright I see no harm in merging them
20160221 09:08:56< Aginor> there's still issues, but I think the worst might be dealt with
20160221 09:10:00< Aginor> good
20160221 09:10:11< Aginor> gui2 dialogs/windows are now properly removed
20160221 09:10:21< Aginor> just need to do some housekeeping
20160221 09:15:28< irker314> wesnoth: Andreas Löf wesnoth:guifixes a275ea9053d8 / src/gui/auxiliary/event/ (dispatcher.hpp distributor.hpp handler.cpp): Ensure that GUI2 windows trigger the redraw-events when closed https://github.com/wesnoth/wesnoth/commit/a275ea9053d886e903b88653a3014247c19b9daa
20160221 09:15:50< Aginor> vultraz: can you please mute ircer for me? - I want to merge master to resolve conflicts
20160221 09:16:05< vultraz> er, shadowm ^
20160221 09:16:09< vultraz> (I'm not sure how)
20160221 09:17:50-!- mode/#wesnoth-dev [+q *!*@uruz.ai0867.net] by ChanServ
20160221 09:17:50-ChanServ:#wesnoth-dev- shadowm quieted *!*@uruz.ai0867.net
20160221 09:17:59-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20160221 09:18:03-!- mode/#wesnoth-dev [+z] by shadowm
20160221 09:18:04<@shadowm> Aginor: Done.
20160221 09:25:42< Aginor> bah
20160221 09:25:48< Aginor> this merge will take a lot longer
20160221 09:26:00< Aginor> shadowm: thanks, but unmute for now
20160221 09:26:07-!- mode/#wesnoth-dev [-qzo *!*@uruz.ai0867.net shadowm] by shadowm
20160221 09:26:07< Aginor> this was more than I thought
20160221 09:26:12< shadowm> Okay, I had assumed you had already done the merge locally.
20160221 09:26:16< Aginor> and I'm being called away from the computer
20160221 09:26:33< Aginor> no, I thought it was few/small conflicts
20160221 09:26:54< shadowm> I'm curious why you prefer to resolve conflicts this way rather than when merging the leaf branch.
20160221 09:27:53< shadowm> Or alternatively, rebasing the leaf.
20160221 09:28:14< Aginor> shadowm: I'm not rebasing because it's a public branch in the main repo
20160221 09:28:21< Aginor> (something I am regretting doing)
20160221 09:28:33< shadowm> It's a shortlived leaf branch, though.
20160221 09:28:57< shadowm> Only people who really care about the task in question are tracking it and they can probably deal with forced updates. Probably.
20160221 09:28:58< Aginor> and I want to see a clean bill of health on the branch before I merge it back, not after having pushed to master
20160221 09:29:05< Aginor> that include travis and the like
20160221 09:29:29< shadowm> It's not like the stable branches and master which are tracked by more people and tools and also contain internal references (commit SHA1s in commit messages).
20160221 09:30:07< Aginor> which is a fair point, but I still prefer to not do that in the main repo
20160221 09:31:23< vultraz> hmmmm
20160221 09:31:24< vultraz> dammit
20160221 09:31:36< vultraz> I seem to have found an issue with 4f6be879a5fe 
20160221 09:31:56< shadowm> shadowm@nanacore:~/src/wesnoth% git show 4f6be879a5fe
20160221 09:31:56< shadowm> fatal: ambiguous argument '4f6be879a5fe': unknown revision or path not in the working tree.
20160221 09:32:08< Aginor> maybe he rebased :D
20160221 09:32:10< vultraz> the thing I just committed
20160221 09:32:43< Aginor> hmm
20160221 09:32:59< shadowm> I suspect it took you more effort to paste the SHA1 here than it would've if you had named the subject instead.
20160221 09:33:49< shadowm> Oh, look, the diff contains more made-up Doxygen.
20160221 09:34:14< shadowm> Whoever told you that you were supposed to use Doxygen comments in the middle of a function's implementation?
20160221 09:34:49< vultraz> what>
20160221 09:34:50< vultraz> ?
20160221 09:35:12< shadowm> The diff context reveals two Doxygen comments in the middle of a function's implementation.
20160221 09:35:46< vultraz> I thought /// was doxygen
20160221 09:35:48< vultraz> I used //
20160221 09:36:14< shadowm>   /** Doxygen comment */
20160221 09:36:17< shadowm>   /// Doxygen comment
20160221 09:36:22< shadowm>   /* Normal comment */
20160221 09:36:25< shadowm>   // Normal comment
20160221 09:36:32< shadowm> I explained this to you the other day.
20160221 09:36:51< vultraz> ...yes
20160221 09:36:56< shadowm> Also /**< Doxygen comment for preceding thing */
20160221 09:36:56< vultraz> I used //
20160221 09:37:05< shadowm> And ///< Doxygen comment for preceding thing
20160221 09:37:10< shadowm> No, you didn't.
20160221 09:37:15< shadowm>   /** FONT SCALING **/
20160221 09:37:19< shadowm>   /** SELECT THEME **/
20160221 09:37:33< vultraz> That's from ages ago :|
20160221 09:37:45< shadowm> That's in the context for commit 4f6be879a5fe5d3bff1ffe7d7ca0490f92c435e8.
20160221 09:39:22< shadowm> vultraz: http://devdocs.wesnoth.org/classgui2_1_1tpreferences.html#a2ba1e9cce90aa6aab5a2e03fb25104a4
20160221 09:39:23< vultraz> Yes, but not modified by that commit
20160221 09:39:52< shadowm> vultraz: The point wasn't whether it was introduced/erased by the commit or not, but rather that the commit's diff context reveals that this is a thing that you did.
20160221 09:40:15< shadowm> And whether it was in the past or now doesn't make it any less incorrect of a thing to do.
20160221 09:40:18< vultraz> I'll fix
20160221 09:40:19< shadowm> *not
20160221 09:40:55< vultraz> I'm pondering what's a better solution for the issue
20160221 09:41:13< vultraz> set the Display tab to visible in post show so the slider can be found
20160221 09:41:25< vultraz> or keep a class member value around with its value 
20160221 09:41:55< vultraz> 'I feel the latter would be less hacky
20160221 09:49:34 * Aginor is compiling
20160221 09:53:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160221 10:00:17-!- travis-ci [~travis-ci@ec2-54-91-149-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 10:00:17< travis-ci> wesnoth/wesnoth#8537 (guifixes - a275ea9 : Andreas Löf): The build is still failing.
20160221 10:00:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110725511
20160221 10:00:18-!- travis-ci [~travis-ci@ec2-54-91-149-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 10:00:46< irker314> wesnoth: Charles Dang wesnoth:master 07169f5e7afe / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: fixup ad8468698916 https://github.com/wesnoth/wesnoth/commit/07169f5e7afe146bd0a02190183bfd7710039f2f
20160221 10:01:16< Aginor> shadowm: would you mind muting the bot again please?
20160221 10:02:20-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160221 10:02:33-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20160221 10:02:43-!- mode/#wesnoth-dev [+qz *!*@uruz.ai0867.net] by shadowm
20160221 10:02:44<@shadowm> Aginor: Done.
20160221 10:03:32< Aginor> thank you
20160221 10:03:37< Aginor> pushing
20160221 10:04:04< Aginor> done pushing
20160221 10:04:12< Aginor> now the bot is presumably doing its thing
20160221 10:04:24<@shadowm> Yes.
20160221 10:07:18< zookeeper> Aginor, anyone, so are we going to be having some further post-SDL2 performance improvements in the near future?
20160221 10:08:26< zookeeper> nkr, no, we don't really have a current roadmap written down anywhere, i believe.
20160221 10:09:04-!- Appleman1234 [~Appleman1@KD119104012232.au-net.ne.jp] has joined #wesnoth-dev
20160221 10:20:32<@shadowm> In case you are curious, yes, it's still going.
20160221 10:20:44-!- irker314 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160221 10:20:57<@shadowm> Oh wait, that was the last commit just one second before I pressed enter.
20160221 10:21:12-!- mode/#wesnoth-dev [-qzo *!*@uruz.ai0867.net shadowm] by shadowm
20160221 10:22:06-!- travis-ci [~travis-ci@ec2-54-90-132-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 10:22:07< travis-ci> wesnoth/wesnoth#8538 (master - 07169f5 : Charles Dang): The build was broken.
20160221 10:22:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110729810
20160221 10:22:07-!- travis-ci [~travis-ci@ec2-54-90-132-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 10:23:41< zookeeper> anyway, i'm asking because i kind of need to know whether i should do something to the water animations to alleviate the performance issues, or if i can just assume someone else is planning on making everything faster sometime soon.
20160221 10:25:59< zookeeper> another option which i think could be good is to create a new display option for it. either having a separate toggle to switch water animations off (in addition to animate map, that is), or to switch to a less costly version. to do that all i'd need would be a checkbox which toggles some global flag somewhere, i could do the rest of the coding myself.
20160221 10:26:41< vultraz> no no no no no
20160221 10:27:04< vultraz> no more switches
20160221 10:29:01-!- irker979 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160221 10:29:01< irker979> wesnoth: Charles Dang wesnoth:master c08a87a255cb / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: hopefully silenced unused parameter warning https://github.com/wesnoth/wesnoth/commit/c08a87a255cb05d2e7cca67708e9b6754455a27e
20160221 10:33:08< shadowm> http://gna.org/bugs/?7507 -- And this is why we should keep at least the buffer size option.
20160221 10:33:40< shadowm> (Also notice that the latest comment is literally from 10 minutes ago.)
20160221 10:42:29< zookeeper> vultraz, well... it could be a drop-down menu or slider, too :p
20160221 10:43:55< zookeeper> we have the vertical space for it
20160221 10:46:42< zookeeper> either it would be specific to terrain graphics, or a more general graphics quality option which could control some other things too.
20160221 10:48:29< vultraz> no, no
20160221 10:48:46< vultraz> better to fix quality issues at their source than introducing more of such things
20160221 10:48:57< vultraz> until we get significantly more special effects, that is
20160221 10:49:02< vultraz> then it might be worth considering
20160221 10:49:05< vultraz> like dota does
20160221 10:49:57-!- louis94 [~~louis94@91.178.241.157] has joined #wesnoth-dev
20160221 10:51:27< Aginor> zookeeper: it's in the pipeline, but it'll be a decent amount of time before there will be anything happening
20160221 10:51:41< Aginor> shadowm: thanks for your help
20160221 10:56:35< zookeeper> Aginor, before 1.14 anyway, i take it?
20160221 10:58:50-!- travis-ci [~travis-ci@ec2-54-91-149-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 10:58:51< travis-ci> wesnoth/wesnoth#8540 (guifixes - b8f1891 : Andreas Löf): The build is still failing.
20160221 10:58:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110730165
20160221 10:58:51-!- travis-ci [~travis-ci@ec2-54-91-149-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 11:15:58-!- Kwandulin [~Miranda@p200300760F0BC50021F90AD3D5DBEFB6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160221 11:21:52< zookeeper> i've spent the last 1-2 weeks trying to find ways to further optimize the terrain drawing, and haven't really managed to achieve anything. the drawing/masking/invalidation/etc code does a lot of wasteful work which could be eliminated, but that doesn't seem to bring any real-world speedups.
20160221 11:23:14< zookeeper> or at least not enough to warrant the extra code, i believe.
20160221 11:37:18-!- travis-ci [~travis-ci@ec2-54-91-149-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20160221 11:37:19< travis-ci> wesnoth/wesnoth#8541 (master - c08a87a : Charles Dang): The build was fixed.
20160221 11:37:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/110732881
20160221 11:37:19-!- travis-ci [~travis-ci@ec2-54-91-149-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20160221 11:46:05-!- mjs-de [~mjs-de@x4db6bb57.dyn.telefonica.de] has joined #wesnoth-dev
20160221 12:07:31-!- Kwandulin [~Miranda@p200300760F0BC500E0E1AFB6ED17687A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160221 12:11:15-!- louis94 [~~louis94@91.178.241.157] has quit [Ping timeout: 248 seconds]
20160221 12:34:29-!- Kwandulin [~Miranda@p200300760F0BC500E0E1AFB6ED17687A.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20160221 12:37:34-!- Kwandulin [~Miranda@2003:76:f0b:c521:e0e1:afb6:ed17:687a] has joined #wesnoth-dev
20160221 12:41:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160221 12:58:16-!- louis94 [~~louis94@91.178.241.157] has joined #wesnoth-dev
20160221 13:11:54-!- Kwandulin [~Miranda@2003:76:f0b:c521:e0e1:afb6:ed17:687a] has quit [Read error: Connection reset by peer]
20160221 13:49:59-!- mjs-de [~mjs-de@x4db6bb57.dyn.telefonica.de] has quit [Remote host closed the connection]
20160221 13:58:03-!- irker979 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160221 14:24:20-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160221 14:35:24-!- Kwandulin [~Miranda@p200300760F0BC5216504EDE1FC175179.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160221 15:35:25-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160221 15:37:03-!- fr_rrr [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 240 seconds]
20160221 15:52:01-!- Appleman1234 [~Appleman1@KD119104012232.au-net.ne.jp] has quit [Ping timeout: 255 seconds]
20160221 16:03:02-!- louis94 [~~louis94@91.178.241.157] has quit [Ping timeout: 244 seconds]
20160221 16:40:10-!- Kwandulin [~Miranda@p200300760F0BC5216504EDE1FC175179.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160221 16:48:24-!- Kwandulin [~Miranda@p200300760F0BC521D96C251BE09E3D16.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160221 17:28:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160221 17:48:05-!- Kwandulin [~Miranda@p200300760F0BC521D96C251BE09E3D16.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160221 18:10:04-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 240 seconds]
20160221 18:11:44-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160221 18:57:59< Aginor> zookeeper: that depends entirely on when 1.14 actually happens
20160221 19:05:38< zookeeper> right
20160221 19:09:17-!- Kwandulin [~Miranda@p200300760F0BC521C4BEC50CFFE6A46D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160221 19:11:10< Aginor> zookeeper: I need to go to work (as opposed to needing to sleep), I'll try to catch up with you later and we can talk more
20160221 19:19:21< zookeeper> sure, cool
20160221 19:42:18-!- mjs-de [~mjs-de@x4db6bb57.dyn.telefonica.de] has joined #wesnoth-dev
20160221 20:04:43< vultraz> celticminstrel: see the bunch of commits I made earlier regarding font scaling handling in prefs
20160221 20:04:43-!- new_one_ is now known as new_one
20160221 20:16:17-!- louis94 [~~louis94@91.178.241.157] has joined #wesnoth-dev
20160221 20:20:42< celticminstrel> So, first you move the macro, then you stop using it.
20160221 20:21:27< celticminstrel> Thank you for 4f6be87.
20160221 20:21:51< celticminstrel> ...why is github showing the percent sign in red?
20160221 20:21:57< vultraz> No idea
20160221 20:23:12< vultraz> Basically, the reason the dialog was redrawing was that that macro had a scroll label
20160221 20:23:37< vultraz> As I've mentioned in the past, scroll labels have scrollbar containers which trigger window invalidation (ie, redraws)
20160221 20:24:17< vultraz> So you moved the slider, the value got changed, the font size was changing, and the window redrawing
20160221 20:24:41< vultraz> Now for downscaling, I'm not sure why it wasn't working the same way, but doesn't matter
20160221 20:24:42< celticminstrel> I usually just delete the parameter name altogether when silencing used parameter warnings, but I delete it in the definition only, not the declaration.
20160221 20:25:00< celticminstrel> So, you didn't need to do this: https://github.com/wesnoth/wesnoth/commit/c08a87a255cb05d2e7cca67708e9b6754455a27e#diff-43f8d21537d836c5770fbe4e639ecadfR1055
20160221 20:25:10< vultraz> celticminstrel: well, post_show needs twindow or else it doesn't actually do anything
20160221 20:25:11< celticminstrel> Ah, sorry.
20160221 20:25:16< celticminstrel> The other one you didn't need.
20160221 20:25:32< celticminstrel> You could've left it as is in the header, is what I'm trying to say.
20160221 20:28:51< vultraz> ah
20160221 20:28:58< vultraz> oh well
20160221 20:29:42< vultraz> either way, handling is much nicer now
20160221 21:27:03-!- louis94 [~~louis94@91.178.241.157] has quit [Ping timeout: 240 seconds]
20160221 21:28:27-!- Kwandulin [~Miranda@p200300760F0BC521C4BEC50CFFE6A46D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160221 21:47:29-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 240 seconds]
20160221 21:52:42-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160221 22:20:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160221 22:25:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160221 22:30:40-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160221 22:42:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160221 22:43:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160221 23:03:43-!- mjs-de [~mjs-de@x4db6bb57.dyn.telefonica.de] has quit [Remote host closed the connection]
20160221 23:05:00-!- louis94 [~~louis94@91.178.241.157] has joined #wesnoth-dev
20160221 23:07:10-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 255 seconds]
20160221 23:12:10-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160221 23:44:59-!- Appleman1234 [~Appleman1@KD119104017112.au-net.ne.jp] has joined #wesnoth-dev
20160221 23:49:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160221 23:49:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20160221 23:51:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
--- Log closed Mon Feb 22 00:00:18 2016