--- Log opened Thu Feb 25 00:00:36 2016
20160225 00:01:57-!- irker717 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160225 00:19:19-!- SpoOkyMagician [~chatzilla@2607:fcc8:be59:b00:d1b0:28ba:f53b:2157] has joined #wesnoth-dev
20160225 00:25:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160225 00:25:54-!- gfgtdf [~chatzilla@f054061068.adsl.alicedsl.de] has joined #wesnoth-dev
20160225 00:26:43< gfgtdf> vultraz: you tested that the personaly preferences of the edtor are still saved now that we exit by exception? this specaiyll included the recent maps list and other possible editor settings that i don't know of.
20160225 00:31:54-!- mjs-de [~mjs-de@f048076100.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160225 00:48:04-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20160225 01:01:28-!- SigurdFireDragon [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160225 01:02:07-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit [Ping timeout: 250 seconds]
20160225 01:11:41-!- SigurdFireDragon [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160225 01:20:22< vultraz> [09:52:19]	celticminstrel	(When forward-declaring a template, you also need to include the "template" part of the declaration.)
20160225 01:20:26< vultraz> celticminstrel: what did you mean?
20160225 01:20:40< vultraz> 'template<class tgroup>?
20160225 01:21:45< vultraz> 'class tgroup<>'?
20160225 01:22:20< celticminstrel> template<class T> class tgroup;
20160225 01:22:54< celticminstrel> For forward declarations, everything up to the opening brace (or for classes with parents, the colon) is required.
20160225 01:23:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160225 01:23:05< celticminstrel> (That's true for functions too.)
20160225 01:23:17< celticminstrel> It's identical to what's used for the definition.
20160225 01:23:43< celticminstrel> Apart from complications when it's a member of a class (eg, you need the scope resolution).
20160225 01:24:17< celticminstrel> (Also, the way to declare a template function in a template class might surprise you.)
20160225 01:24:40< celticminstrel> (...well, that's more about defining it, rather than declaring.)
20160225 01:27:13-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160225 01:32:28< vultraz> this is weird
20160225 01:33:30< vultraz> ttree_view_node casts a widget as tselectable_ before using connect_signal
20160225 01:33:43< vultraz> when I do that, I get errors saying tselectable_ has no connect_signal
20160225 01:34:17< vultraz> also this "..\..\src\gui\widgets\selectable.hpp|96|error: 'tgroup' is not a type|"
20160225 01:34:44< celticminstrel> I have no idea what you're talking about.
20160225 01:35:12< celticminstrel> tselectable_ doesn't have a connect_signal.
20160225 01:35:45< celticminstrel> [Feb 24@5:40:01pm] celticminstrel: A dynamic_cast to tdispatcher should work.
20160225 01:35:47< celticminstrel> [Feb 24@5:40:39pm] celticminstrel: Or, I guess, you could use twidget instead of tselectable_.
20160225 01:35:47< celticminstrel> [Feb 24@5:41:03pm] celticminstrel: Or, option three would be for the widget class to be a template argument to the tgroup.
20160225 01:36:14< vultraz> ohhh I'm misreading the code here
20160225 01:36:16< vultraz> twidget
20160225 01:36:17< vultraz> twidget
20160225 01:36:19< vultraz> yes
20160225 01:38:22< vultraz> still on the fence between twidget specilization or tselectable, now that I decided to keep the selectable group operator in tselectable
20160225 01:38:24< vultraz> anyway
20160225 01:38:26< vultraz> last error...
20160225 01:38:32< vultraz> ..\..\src\gui\widgets\selectable.hpp|96|error: 'tgroup' is not a type|
20160225 01:38:52< celticminstrel> Forward declare tgroup.
20160225 01:40:07< vultraz> but I did
20160225 01:40:28< celticminstrel> Oh, wait, I remember seeing this code.
20160225 01:40:36< celticminstrel> tgroup is indeed not a type.
20160225 01:40:43< celticminstrel> It's a template. A template is not a type.
20160225 01:40:54< celticminstrel> To get a type from a template, you need template arguments.
20160225 01:41:19< celticminstrel> Obviously, that's only if it's a class template.
20160225 01:41:39< vultraz> right - but I don't have an argument for it there
20160225 01:41:47< vultraz> or should I just use <void>
20160225 01:42:03< celticminstrel> No, make the function a template too and just forward the template argument.
20160225 01:45:17< vultraz> sorry if I've been slow
20160225 01:45:22< vultraz> I just never actually wrote a class template
20160225 01:54:04-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160225 02:05:15< vultraz> built!
20160225 02:05:16< vultraz> ok
20160225 02:05:18< vultraz> nowwww uh
20160225 02:05:27< vultraz> now I need a test case
20160225 02:05:45< ancestral> For what?
20160225 02:06:05< vultraz> my gui2 widget groups
20160225 02:06:07< vultraz> 2.0
20160225 02:07:51< celticminstrel> I already suggested a dialog to convert... advanced graphics options. But feel free to choose something else instead.
20160225 02:08:23< vultraz> I looked at that, yes
20160225 02:08:30< vultraz> but the code is actually quite complicated
20160225 02:08:51< vultraz> and I don't want to tinker with it right now
20160225 02:08:56< vultraz> so I'm going to use preferences
20160225 02:08:58< vultraz> since I know the code
20160225 02:09:03< celticminstrel> Well, I'm sure there must be lots of other simple ones.
20160225 02:09:12< celticminstrel> Or fine, if you must, you could use the monstrosity that is preferences.
20160225 02:09:21< vultraz> :|
20160225 02:09:28< vultraz> it's not a monstrosity 
20160225 02:09:29< celticminstrel> ...does it even use radiobuttons?
20160225 02:09:35< vultraz> and yes it does in one case
20160225 02:09:39< celticminstrel> It's a monstrosity in the size sense.
20160225 02:10:03< celticminstrel> Oh, only one case, I suppose that helps a little.
20160225 02:15:41< vultraz> you can pass a tselectable_ object to a function requiring twidget, right?
20160225 02:16:03-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 248 seconds]
20160225 02:16:50< celticminstrel> There's no reason why you should be able to do that.
20160225 02:16:59< celticminstrel> There's no relationship between the two classes.
20160225 02:17:43< vultraz> oh right, I keep forgetting tselectable_ is not a class
20160225 02:17:44< vultraz> er
20160225 02:17:46< vultraz> not a widget
20160225 02:17:49< vultraz> it's a helper class
20160225 02:20:15-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160225 02:20:35< vultraz> hmmmm
20160225 02:20:45< vultraz> having trouble binding enum values to the group...
20160225 02:22:01< vultraz> or maybe something else..?
20160225 02:22:05< vultraz> ..\..\src\gui\widgets\group.hpp|40|error: no matching function for call to 'bind(<unresolved overloaded function type>, gui2::tselectable_**, gui2::tgroup<preferences::LOBBY_JOINS>*)'|
20160225 02:23:29< celticminstrel> Probably missing template arguments on the function.
20160225 02:23:46< celticminstrel> It's also suspicious that there's two **
20160225 02:23:55< celticminstrel> Try dropping an &
20160225 02:25:24< vultraz> well I added the address-of operator because otherwise: preferences_dialog.cpp|267|error: no matching function for call to 'gui2::tgroup<preferences::LOBBY_JOINS>::add_member(gui2::ttoggle_button&, preferences::LOBBY_JOINS&)'|
20160225 02:25:30< vultraz> ..\..\src\gui\widgets\group.hpp|36|note: candidate: void gui2::tgroup<T>::add_member(gui2::tselectable_*, const T&) [with T = preferences::LOBBY_JOINS]|
20160225 02:25:39< vultraz> it wants a pointer, not a reference
20160225 02:26:13< celticminstrel> Uhh... that's a different place...
20160225 02:26:48< celticminstrel> You have bind(&some_function, &widgets, this) <-- that's the & I'm talking about, the second one.
20160225 02:26:58< celticminstrel> Also need some_function<T>
20160225 02:27:23< vultraz> oh
20160225 02:28:58< ancestral> If I want to change just one value in a macro, I have to rewrite the whole macro, correct? (Or don’t use the macro?)
20160225 02:29:41< ancestral> For example, in a macro, `image=foo`, if I want `image=bar`, I have to re-define the macro with `image=bar`
20160225 02:29:54< vultraz> ...what?
20160225 02:29:59< vultraz> er, yes
20160225 02:30:09< vultraz> unless either foo or bar were a macro argument
20160225 02:30:35< ancestral> {{LOLCAT}} and `#define LOLCAT` has `image=derp`
20160225 02:30:47< ancestral> oh right, macro argument
20160225 02:30:52< ancestral> Okay
20160225 02:33:08< vultraz> ugh
20160225 02:33:14< vultraz> undefined references...
20160225 02:33:16< celticminstrel> It's also just single braces, ancestral 
20160225 02:33:25< celticminstrel> vultraz: Undefined references to what?
20160225 02:33:25< ancestral> You’re right
20160225 02:33:43 * ancestral is too used to templating in Django and other frameworks
20160225 02:33:45< vultraz> undefined reference to `void gui2::tselectable_::group_operator<preferences::LOBBY_JOINS>(gui2::tgroup<preferences::LOBBY_JOINS>*)'|
20160225 02:34:21< vultraz> the only reason group_operator has a template argument is so it can specify it for tgroup...
20160225 02:34:28< vultraz> but why is that undefined
20160225 02:34:36< celticminstrel> So um...
20160225 02:34:54< celticminstrel> What's the declaration of the function, and the call point?
20160225 02:36:18< vultraz> declaration is 	
20160225 02:36:19< vultraz> template <typename T>
20160225 02:36:21< vultraz> void group_operator(tgroup<T>* group);
20160225 02:36:28< vultraz> and the call point...
20160225 02:36:30< vultraz> 		dynamic_cast<twidget*>(widget)->connect_signal<event::LEFT_BUTTON_CLICK>(boost::bind(
20160225 02:36:32< vultraz> 			&tselectable_::group_operator<T>, widget, this), event::tdispatcher::front_child);
20160225 02:37:03< celticminstrel> That's not actually the call point, but it is what I needed.
20160225 02:37:26< celticminstrel> widget is a pointer, right?
20160225 02:37:40< vultraz> obviously, since I just dynamic cast it
20160225 02:37:50< celticminstrel> Right.
20160225 02:38:15< celticminstrel> Where is group_operator defined? (Not declared - defined.)
20160225 02:39:00< vultraz> as a temporary measure, in ttoggle_button
20160225 02:39:04< vultraz> as you said
20160225 02:40:26< celticminstrel> Maybe that header isn't included.
20160225 02:41:18< celticminstrel> (BTW, I said define it in the ttoggle_button header, not in the ttoggle_button class.)
20160225 02:43:37< vultraz> ahhh
20160225 02:45:50-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160225 02:46:51< vultraz> builds!
20160225 02:46:57-!- gfgtdf [~chatzilla@f054061068.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160225 02:47:07< ancestral> Hmm
20160225 02:47:37< vultraz> celticminstrel: it works :D
20160225 02:47:49< vultraz> same functionality, such reduced overhead 
20160225 02:47:52< celticminstrel> How's it look in the code?
20160225 02:48:03< celticminstrel> The place where the group is defined and such, I mean.
20160225 02:48:19< vultraz> ok, so I declared, in the preferences header: tgroup<preferences::LOBBY_JOINS> lobby_joins_group;
20160225 02:48:30< vultraz> then
20160225 02:48:32< vultraz> lobby_joins_group.add_member(&button, enum_value);
20160225 02:49:13< celticminstrel> And that's all?
20160225 02:49:49< celticminstrel> Since this is a MAKE_ENUM, you might actually be able to populate the group in a loop.
20160225 02:50:02< celticminstrel> Did you make sure to remove any previously registered handlers for those buttons?
20160225 02:50:14< celticminstrel> Is the preference actually saved when you exit the dialog?
20160225 02:51:03< vultraz> that last one, no, because I didn't call the setter
20160225 02:51:18< vultraz> I'm pondering the best way to do that
20160225 02:51:33< celticminstrel> How did you do it before?
20160225 02:52:36< vultraz> https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/preferences_dialog.cpp#L1025
20160225 02:52:58< vultraz> that callback's on every button
20160225 02:53:40< celticminstrel> Well, I can think of three ways.
20160225 02:53:49< vultraz> simplest way would be to implement a get_active_group_widget member in tselectable and then call the setter in postshow
20160225 02:53:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160225 02:54:02< vultraz> but that'd be against the preferences design paradigm
20160225 02:54:18< celticminstrel> 1) Attach a simpler version of that callback to each of the buttons; it would have no loop, simply checking if it's the active one and, if so, setting the value. (But, that doesn't really leverage the whole groups thing.)
20160225 02:54:30< celticminstrel> 2) Get the selected value from the group in post_show, and set it there.
20160225 02:54:52< celticminstrel> 3) Somehow make tgroup able to handle NOTIFY_MODIFIED events, and attach such a callback that sets the value.
20160225 02:55:56< vultraz> 3) would be most optimal 
20160225 02:56:25< celticminstrel> 3) relies on the same infrastructure as 2) - the get_selected_widget (or whatever) function in tgroup.
20160225 02:56:26< vultraz> probably for other dialogs too
20160225 02:56:28< vultraz> I think
20160225 02:56:38< celticminstrel> Depends on the dialog, really.
20160225 02:56:46< vultraz> in tselectable, I was thinking
20160225 02:57:01< celticminstrel> Incidentally, if there's a get_selected_widget, of course there should also be a set_selected_widget.
20160225 02:57:05< celticminstrel> In tgroup.
20160225 02:57:27< vultraz> well if that;s in tgroup, group_operator should also be in tgroup
20160225 02:57:31< celticminstrel> Or whatever you want to all them.
20160225 02:57:42< celticminstrel> Maybe, maybe not.
20160225 02:57:50< celticminstrel> Depends on  how generic you intend to go.
20160225 02:58:07< celticminstrel> If you're sticking with tselectable_, it wouldn't hurt to move group_operator into tgroup.
20160225 02:58:17< celticminstrel> (That'd also involve swapping the arguments in the bind.)
20160225 02:59:17< celticminstrel> However, if you want tgroup to be even more generic and use a template argument in place of tselectable_, then the group_operator would have to go in tselectable_.
20160225 02:59:23< celticminstrel> (Or ttoggle_button.)
20160225 03:02:22-!- twooey [~twooey@24.51.190.244] has joined #wesnoth-dev
20160225 03:03:39< vultraz> I think for now...
20160225 03:03:48< vultraz> ehhhhhh
20160225 03:03:54< vultraz> I think I'll stick with tselectable
20160225 03:04:00< vultraz> er
20160225 03:04:02< vultraz> i mean 
20160225 03:04:12-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160225 03:04:12< vultraz> stick with tgroup specialized for tselctable 
20160225 03:06:00< vultraz> it consolidates function
20160225 03:06:11< celticminstrel> Ah, I was wrong about MAKE_ENUM providing a nice way to loop through, but it does provide a count() function, so you could use a standard for-loop.
20160225 03:07:03< vultraz> that's not even a MAKE_ENUM object
20160225 03:07:07< vultraz> it's a plain enum
20160225 03:07:13< celticminstrel> It's not? Huh, okay then.
20160225 03:07:29< celticminstrel> If it's only a very small number of constants, it doesn't really make a difference, I guess.
20160225 03:08:07< vultraz> yeah
20160225 03:11:03< celticminstrel> (Technically, you could still do a forloop if you really wanted to.)
20160225 03:11:29< ancestral> vultraz: I want to increase the size of the time-of-day graphics
20160225 03:11:43< vultraz> ancestral: write to lord bob and ask for new ones :)
20160225 03:11:56< ancestral> Excellent
20160225 03:12:00< celticminstrel> There are also some new ones already for unit_box.
20160225 03:12:11< celticminstrel> But those might not be appropriate for your purposes.
20160225 03:12:16< ancestral> You mean the funky round sphere thingy?
20160225 03:12:23< celticminstrel> Yeah.
20160225 03:12:27 * ancestral hides
20160225 03:12:34< ancestral> I’m staying away from that
20160225 03:12:47< celticminstrel> BTW, if you do ask for new ones, it'd be great if the standard schedule, UtBS schedule, and 24-hour schedule were all consistent.
20160225 03:13:24< vultraz> he is a bit busy right now, though, so don't expect anything right away
20160225 03:13:58< ancestral> celticminstrel: Agreed
20160225 03:14:15< ancestral> Well, in my theme, 200px-wide graphics would be great
20160225 03:14:27< ancestral> GUI elements don’t like to scale up I’ve found
20160225 03:14:32< ancestral> Scaling down? No problem
20160225 03:14:45< celticminstrel> I think the UtBS and 24-hour ones might be already, but the default schedule is a little less... touched-up, I guess? For exampke, no glow around the moon.
20160225 03:15:05< celticminstrel> Scaling down isn't "no problem". If it's half or quarter size, it might be fine.
20160225 03:15:12< celticminstrel> But not arbitrarily.
20160225 03:15:16< ancestral> It’s not that
20160225 03:15:24< celticminstrel> ^example
20160225 03:15:25< ancestral> It’s that if I set a rect to larger than the image
20160225 03:15:32< ancestral> The image does NOT scale up to fit the rect
20160225 03:15:39< ancestral> Unless I’m missing something
20160225 03:16:05< celticminstrel> I dunno how Wesnoth does this.
20160225 03:16:14< ancestral> In other words, if I have a rect (image box) that is 100 x 100 pixels 
20160225 03:16:20< celticminstrel> You could use the ~SCALE() IPF if you actually want it scaled.
20160225 03:16:21< ancestral> And I say “fill it with foo.png”
20160225 03:16:25< celticminstrel> But it wouldn't look as good.
20160225 03:16:30< ancestral> And foo.png is 50 x 50
20160225 03:16:40< ancestral> It will only be in the corner of the box, 50 x 50
20160225 03:16:41< vultraz> ah
20160225 03:16:44< vultraz> no, i don't think it can do that
20160225 03:16:56< ancestral> celticminstrel: I can’t scale it up. There is no place to do the transform in the theme
20160225 03:17:09< celticminstrel> Don't you give it the image path?
20160225 03:17:09< ancestral> But, scaling down is automatic
20160225 03:17:13< vultraz> ancestral: what is this theme for?
20160225 03:17:21< ancestral> celticminstrel: It’s not defined in the theme :(
20160225 03:17:25< ancestral> It’s defined in schedules.cfg
20160225 03:17:31< celticminstrel> Oh, right.
20160225 03:17:33< ancestral> And I can’t overwrite the macro
20160225 03:17:40< vultraz> sure you can
20160225 03:17:42< vultraz> #undef
20160225 03:17:44< vultraz> #define
20160225 03:17:45< ancestral> Because I guess schedules.cfg loads AFTER the theme
20160225 03:17:53< celticminstrel> I think I get the issue here.
20160225 03:17:58< vultraz> or define your own macro, then undef it
20160225 03:18:00< ancestral> vultraz: I’ll show you
20160225 03:18:17< ancestral> vultraz: But doesn’t schedules.cfg load after the theme cfgs?
20160225 03:18:39< celticminstrel> Themes are the very first thing loaded in the main config.
20160225 03:18:53< ancestral> ^
20160225 03:18:54< celticminstrel> (I think gui configs are loaded before that, but separately.)
20160225 03:19:18< ancestral> I mean, we could radically overhaul the tod stuff
20160225 03:19:31< ancestral> Like have the images point to a macro defined in the themes
20160225 03:19:32< celticminstrel> Well. "english.cfg" is also loaded before the themes.
20160225 03:19:34< vultraz> ancestral: I like those words :D
20160225 03:19:53< vultraz> ("radically overhaul", that is)
20160225 03:19:57< ancestral> Heh
20160225 03:19:57< celticminstrel> schedules.cfg is in macros, right?
20160225 03:20:24< ancestral> Which, in a design standpoint, kinda makes sense. Why should the core macros be defining the sizes of elements?
20160225 03:20:28< ancestral> Yes
20160225 03:20:32< celticminstrel> So, you have english.cfg on line 14, themes on line 16, core on line 18. schedules.cfg is eventually included by core.
20160225 03:20:33< ancestral> the other option is
20160225 03:20:43< ancestral> Let me resize images within the theme
20160225 03:21:11< ancestral> However, larger tod images solves everything, and will future-proof us onto the way to truly high-dpi interfaces
20160225 03:23:33< ancestral> Oooh, did I mention, I figured out a clever way to get the end turn button to be recognized all the way at the bottom corner/edges of the screen?
20160225 03:25:25< vultraz> exactly on the edge?
20160225 03:26:01< ancestral> Yeah
20160225 03:26:19< ancestral> It’s pretty simple; just made the button a little bigger and added transparency
20160225 03:26:37< ancestral> “made” meaning increased the canvas size around the button
20160225 03:29:35< vultraz> but why would you want that
20160225 03:30:28< ancestral> Because it makes no sense to have the button several pixels away from the edges when the user wants to bring the cursor down there to click on it
20160225 03:31:03< ancestral> Not unlike clicking on the Apple menu in the top left corner, or maybe the Windows menu in the bottom right; the UI elements don’t actually extend to the edge, but they recognize the edge
20160225 03:31:09< ancestral> Honestly, it’s good UI design
20160225 03:32:13< ancestral> vultraz, celticminstrel: http://mproud.com/wesnoth/modern-wip.png  This is really rough. (I haven’t addressed the unit text yet, and I have some ideas on how to make it better.)
20160225 03:33:00< ancestral> I’ve been working my way from the top right corner down
20160225 03:33:23< celticminstrel> Looks almost the same to me.
20160225 03:33:42< celticminstrel> Or is that because you used the default theme as a base?
20160225 03:33:52< ancestral> Yes
20160225 03:34:01< vultraz> ancestral: damn your text looks nice
20160225 03:34:06< vultraz> how be it your text is so smooth
20160225 03:34:20< celticminstrel> I can't really tell what you changed, except for the time of day image moving.
20160225 03:34:33< ancestral> I moved the ToD up. I added an extra button under the mini-map. I made the text bigger
20160225 03:34:50< celticminstrel> ...extra button?
20160225 03:34:52< ancestral> I am going to blow the hell up with that profile image
20160225 03:34:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 03:34:57< celticminstrel> Why'd you make the text bigger?
20160225 03:35:00< ancestral> celticminstrel: Zoom in and zoom out
20160225 03:35:11< ancestral> celticminstrel: That is my biggest UI gripe
20160225 03:35:13< vultraz> ancestral: suggestion: get rid of that line between the coordinates and the terrain type label
20160225 03:35:21< ancestral> The text is too damn small!
20160225 03:35:45< ancestral> Everything below the minimap I’m working on like right now
20160225 03:35:48< ancestral> vultraz: Consider it done
20160225 03:35:55< celticminstrel> I haven't had a problem with the text size. (I don't have a retina monitor, though.)
20160225 03:36:09< ancestral> It’s not just a problem with retina monitors
20160225 03:36:10< celticminstrel> Did the unit image change?
20160225 03:36:17< ancestral> It’s a problem with large-ish monitors
20160225 03:36:22< ancestral> And people over the age of 40
20160225 03:36:22< celticminstrel> It almost seems like that's the portrait instead of the sprite.
20160225 03:36:30< ancestral> And kids under the age of 12
20160225 03:36:52< ancestral> celticminstrel: That was part experiment and part haven’t-gotten-to-making-it-larger
20160225 03:37:03< ancestral> It proved I can scale images down automagically
20160225 03:37:33< celticminstrel> I wonder if the larger text would interact badly with the new font scaling preference.
20160225 03:37:46< ancestral> Let’s find out
20160225 03:38:00 * celticminstrel hopes it doesn't crash.
20160225 03:38:10< ancestral> Yes
20160225 03:38:13< ancestral> It’s bad
20160225 03:38:37< ancestral> The problem is, the font scaling doesn’t take into account the space to fit in the GUI
20160225 03:38:42< celticminstrel> ...though I think the theme is far better than GUI2 at dealing with a lack of space, so I guess crashing is unlikely. (It didn't crash, did it?)
20160225 03:38:48< celticminstrel> Yeah.
20160225 03:39:05< celticminstrel> It wasn't great even in the old theme, just functional.
20160225 03:39:14< ancestral> It’s bad with just the regular theme
20160225 03:39:19< ancestral> Maybe it’s a GUI 1 vs. GUI2 thing
20160225 03:39:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160225 03:39:45< ancestral> vultraz: Actually, you might want to try the font scaling out once with a game. Set it to 150% and see it for yourself…
20160225 03:40:01< ancestral> celticminstrel: Did not crash
20160225 03:40:03< celticminstrel> I think it's sorta okay at 150%, but looks pretty bad at 200%.
20160225 03:40:40< ancestral> Anyway, we have wider monitors now, so we can afford more space in the sidebar
20160225 03:40:54< ancestral> Heh
20160225 03:41:00< celticminstrel> This is... probably true, yeah.
20160225 03:41:04< ancestral> At 150%, if I click on Menu
20160225 03:41:07< ancestral> It disappears
20160225 03:41:12< celticminstrel> I noticed that too.
20160225 03:41:54< ancestral> Hey, would it be too hard to force some kind of refresh when changing the theme?
20160225 03:42:13< ancestral> Yoiu can’t change the theme in the middle of the game
20160225 03:42:18< celticminstrel> I have no idea.
20160225 03:42:19< ancestral> (You can try)
20160225 03:42:44< ancestral> I know at one time there was a message saying something like “sorry, try again in the main menu”
20160225 03:43:05< celticminstrel> I think there's still a note somewhere that it won't work.
20160225 03:43:18< celticminstrel> Maybe in the theme selection dialog itself?
20160225 03:43:44< ancestral> You’re right
20160225 03:43:47< ancestral> I missed it
20160225 03:44:06< celticminstrel> I think I did too, initially.
20160225 03:53:11< ancestral> Otherwise, I’m having trouble figuring out how to right-align text in the sidebar
20160225 03:53:19< ancestral> I’m not sure it’s actually possible
20160225 03:56:27-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160225 03:57:55< vultraz> celticminstrel: I'm getting a warning about 'reaching end of non-void function' here: http://pastebin.com/zuz8a6di
20160225 03:58:02< vultraz> but I'm not sure what to make the default return value
20160225 03:58:48< celticminstrel> There's no logical option, so might as well go with the default value of T.
20160225 03:58:49-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160225 03:58:51< celticminstrel> ie, return T()
20160225 03:59:20< celticminstrel> Alternatively, throw an exception.
20160225 03:59:35< vultraz> that counts?
20160225 03:59:40< celticminstrel> Throwing an exception instead of returning will also silence that warning, yes.
20160225 03:59:50< vultraz> I'd have to define an exception, thoguh
20160225 04:00:02< celticminstrel> Not necessarily.
20160225 04:00:25< vultraz> plus in the future we might want members with no bound values
20160225 04:01:24< vultraz> (I guess then the function should return a pointer, but I'll consider that later)
20160225 04:01:28-!- SpoOkyMagician [~chatzilla@2607:fcc8:be59:b00:d1b0:28ba:f53b:2157] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160225 04:01:37< vultraz> celticminstrel: ok, so besides that, everything's working
20160225 04:01:41< vultraz> setter and everything
20160225 04:01:44< vultraz> gonna update PR
20160225 04:02:24< celticminstrel> If you mean the thing where I said <void> as the value type, that function simply wouldn't exist.
20160225 04:02:53< vultraz> blagh
20160225 04:02:57< vultraz> ..\..\src\gui\widgets\group.hpp|78|error: invalid initialization of non-const reference of type 'preferences::LOBBY_JOINS&' from an rvalue of type 'preferences::LOBBY_JOINS'|
20160225 04:03:13< celticminstrel> You can throw literally any object you want.
20160225 04:03:20< celticminstrel> For example: throw "Something went wrong!"
20160225 04:04:28< celticminstrel> What line is that on?
20160225 04:04:40< vultraz> 'return T();"
20160225 04:05:16< celticminstrel> Ah, I see the problem.
20160225 04:05:41< celticminstrel> For "return T()" to work, the return type needs to be T (or const T&, but that would be dangerous and would probably raise a warning).
20160225 04:06:33< vultraz> so you recommend making it T?
20160225 04:06:54< celticminstrel> I think that should be fine - usually T is going to be something like an int or an enum.
20160225 04:07:10< celticminstrel> It could also be a string though, so it's not quite ideal.
20160225 04:07:23< vultraz> I can think of at least one case where it will be a string
20160225 04:07:33< iceiceice> this is just a preference dialog, right?
20160225 04:07:47< vultraz> iceiceice: no, this is an interface for all radio buttons
20160225 04:07:51< iceiceice> its ok to make a copy of a tiny string like that
20160225 04:07:52< celticminstrel> I think it'll be a string for the orb dialog.
20160225 04:08:15< vultraz> you sure a const ref wouldn't work?
20160225 04:08:31< iceiceice> vultraz, you dont want to return a reference to temporary is the thing
20160225 04:08:39< celticminstrel> It might, if you're lucky, but what iceiceice said.
20160225 04:08:40< iceiceice> if you are sure you wont be doing that then go ahead
20160225 04:09:01< vultraz> not as far as I know
20160225 04:09:11< celticminstrel> Like I said, it'll usually be an int or an enum, so it's probably fine if it's just T.
20160225 04:09:23< iceiceice> yeah that would be my suggestion also
20160225 04:09:31< vultraz> alright, T it is
20160225 04:09:39< vultraz> I'll see if shadowm says something
20160225 04:09:39< celticminstrel> And as iceiceice pointed out, even when it's a string it'll be a short one, so the time to copy is still pretty tiny.
20160225 04:09:51< celticminstrel> (And most compilers would optimize away the copy, anyway.)
20160225 04:10:54< ancestral> iceiceice: Do you know which algorithm ~SCALE() uses by default?
20160225 04:11:02< ancestral> NN or Bicubic?
20160225 04:11:26< vultraz> I assume whatever you specified
20160225 04:11:41< ancestral> (or if anyone else knows)
20160225 04:13:04< iceiceice> ancestral, its in image.cpp
20160225 04:15:23-!- twooey [~twooey@24.51.190.244] has quit [Ping timeout: 250 seconds]
20160225 04:16:11< iceiceice> ancestral, i think its not actually there
20160225 04:16:19< iceiceice> the defaults are set here:
20160225 04:16:19< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/image.cpp#L1281
20160225 04:16:23< iceiceice> they are read from preferences
20160225 04:16:29< iceiceice> if it doesnt find them in your preferences it uses linear
20160225 04:16:33< iceiceice> however that's not relevant to ~SCALE
20160225 04:16:41< iceiceice> iirc ~SCALE does not depend on any preferences
20160225 04:16:54< iceiceice> b/c i assume that someone who is using ~SCALE wants precise control
20160225 04:17:01< ancestral> So
20160225 04:17:01< iceiceice> and can use ~XBRZ if they want that
20160225 04:17:22< ancestral> Probably the theming system is using some sort of default
20160225 04:17:33< ancestral> Probably linear then
20160225 04:19:58< ancestral> Technically, “bilinear”
20160225 04:20:37< iceiceice> do you know if its using the new bilinear or the old bilinear?
20160225 04:20:57< iceiceice> the old bilinear did some squirrely stuff with alpha that i fixed i think
20160225 04:21:15< iceiceice> i cant remember if i left it there though and just made the other the default though
20160225 04:21:15< iceiceice> or not
20160225 04:21:26< ancestral> I guess I won’t worry too much
20160225 04:21:32< ancestral> It looks okay
20160225 04:21:49< ancestral> (For ToD graphics)
20160225 04:26:53-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160225 04:37:26< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/pull/588
20160225 04:41:07< vultraz> celticminstrel: seriously, huge thanks for your suggestions
20160225 04:41:15< vultraz> it really, really simplified the whole thing
20160225 04:41:22< vultraz> now it's a nice little package in one header file
20160225 04:41:26< vultraz> as opposed to spread out over like
20160225 04:41:28< vultraz> 6
20160225 05:09:15< vultraz> celticminstrel: replied
20160225 05:12:02-!- twooey [~twooey@24.51.190.244] has joined #wesnoth-dev
20160225 05:15:44-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit [Read error: Connection reset by peer]
20160225 05:16:28-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160225 05:17:11-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160225 05:17:46-!- twooey [~twooey@24.51.190.244] has quit [Ping timeout: 252 seconds]
20160225 05:20:06< vultraz> celticminstrel: do you mean someting like this?
20160225 05:20:09< vultraz> http://pastebin.com/fr5SikhH
20160225 05:20:14< vultraz> I'm not sure how useful it would be
20160225 05:20:39< vultraz> especially when you consider enums
20160225 05:22:31< celticminstrel> Hmm, not quite.
20160225 05:22:46< celticminstrel> It can't return early - it needs to set the chosen one to true and all others to false.
20160225 05:22:52< celticminstrel> (So, only one argument, as well.)
20160225 05:23:12< celticminstrel> member.first->set_value(member.second == value) should work.
20160225 05:23:36< celticminstrel> The main use would be for initializing the group.
20160225 05:23:54< celticminstrel> First, you add all the members; then you call that function to ensure that the correct button is initially selected.
20160225 05:23:56< vultraz> hmm
20160225 05:24:13< vultraz> yes, this seems like a good idea
20160225 05:24:21< vultraz> I do it a bit differently in prefs but this is also good
20160225 05:25:02< celticminstrel> I think you actually have unnecessary templates in prefs, assuming there really is only one radiobutton group. (But, having the templates does mean adding another group later would be a little easier, probably.)
20160225 05:25:30< vultraz> that's the point, yes
20160225 05:28:44< vultraz> ok, pushed that
20160225 05:28:49< celticminstrel> I seem to recall thinking about some potential extensions to the animation syntax... but I don't remember what they were...
20160225 05:29:03< celticminstrel> I mean the progressive values syntax, to clarify.
20160225 05:29:07< vultraz> I should probably add documentation 
20160225 05:29:12< vultraz> to tgroup
20160225 05:29:15< celticminstrel> Documentation is always good.
20160225 05:30:38< celticminstrel> I see you arbitrarily chose a different name.
20160225 05:30:59< celticminstrel> My reason for the name I gave was because it's basically the opposite of the existing get_ function.
20160225 05:31:33< vultraz> but then it sounds like it's 'set the value of the active member'
20160225 05:32:21< celticminstrel> Good point.
20160225 05:32:42< celticminstrel> set_active_member and get_active_member, maybe?
20160225 05:32:45< celticminstrel> I dunno.
20160225 05:33:33< celticminstrel> I'm sure I remember saying something about progressive syntax in animations awhile back...
20160225 05:37:07< celticminstrel> Maybe it was for a range-with-step syntax?
20160225 05:37:26-!- Kwandulin [~Miranda@p200300760F0BC583353EE84AC87F3BD3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160225 05:42:03-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160225 06:15:23-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: ancestral]
20160225 06:17:10-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160225 06:22:53< Aginor> good evening
20160225 06:28:29< vultraz> allos, Aginor 
20160225 06:35:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 06:36:34-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: End Transmission.]
20160225 06:39:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160225 06:46:27< celticminstrel> Is there any point in adding usage and cost to the Lua view of a unit? I imagine both can be read from the __cfg variable.
20160225 06:46:57< celticminstrel> What about abilities?
20160225 06:48:20< celticminstrel> (The latter being simply a list of all abilities with IDs, rather than the full ability configs since those are obtainable from __cfg anway.)
20160225 06:48:47-!- Kwandulin [~Miranda@p200300760F0BC583353EE84AC87F3BD3.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160225 06:49:26< celticminstrel> What about traits? (Similarly, just a list of all traits present.)
20160225 07:48:40-!- Kwandulin [~Miranda@p200300760F0BC583353EE84AC87F3BD3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160225 07:50:26-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160225 07:52:56-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160225 07:52:56-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20160225 07:52:56-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160225 07:57:25-!- celticminstrel is now known as celmin|sleep
20160225 08:09:47-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160225 08:12:58-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: Smell ya later]
20160225 08:34:30< Aginor> I can't tell if I've introduced a bug, or if I have fixed something that's been broken for so long that I'm now hitting people's workarounds instead
20160225 08:34:44< Aginor> 20160225 21:32:31 error display: could not open image 'icons/action/editor-switch-time_30_30.png'
20160225 08:40:38-!- Kwandulin [~Miranda@p200300760F0BC583353EE84AC87F3BD3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160225 08:49:04< wedge009> When does that happen?
20160225 08:49:11< Aginor> in guifixes
20160225 08:49:25< Aginor> I think I'm hitting an ancient bug in GUI1
20160225 08:49:34< Aginor> it's a merge blocker for me
20160225 08:49:48< wedge009> Oh, okay. I'm guessing this branch is attempting to resolve lingering issues with the SDL2 migration, right?
20160225 08:49:55< Aginor> yeah
20160225 08:50:05< Aginor> around resize issues
20160225 08:50:25< Aginor> and I've had to make some small improvements to come parts of the GUI stuff for it
20160225 08:51:14< wedge009> I haven't been keeping up with developments recently. I'm still trying to contribute in my own small way, though. Not sure if I'm just making more work for people, though.
20160225 08:51:26< Aginor> I don't think you are
20160225 08:51:36< Aginor> which reminds me that I should merge your PR
20160225 08:51:46< Aginor> wedge009: all contributions are appreciated
20160225 08:51:57< wedge009> Oh, remember the null hot-key thingy you wanted me to work on back in PR 530? I believe I got it working with PR 564.
20160225 08:52:02< wedge009> Thanks.
20160225 08:52:07< Aginor> sweet
20160225 08:52:21< Aginor> I'll review tomorrow or so
20160225 08:52:33< wedge009> It's pretty basic, but I think it does the job.
20160225 08:52:44< wedge009> And no rush, but I think you were the only one interested in it previously.
20160225 08:53:28< Aginor> I think it ended up as a "me" thing because I touched that subsystem the last time
20160225 08:53:49< Aginor> but I'm pretty super-busy at the moment, I'm not quite keeping up with everything
20160225 08:54:02< wedge009> Issue arose from command="null" being used to not print anything in the hot-key menu, flag a hot-key as deleted in the preference file, and flag it as deleted from the in-memory set of hot-keys during run-time.
20160225 08:54:18< wedge009> I think everyone is.
20160225 08:54:23-!- irker334 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160225 08:54:23< irker334> wesnoth: Wedge009 wesnoth:master d2be47f5ddd1 / src/replay.hpp: Fix broken build in VC https://github.com/wesnoth/wesnoth/commit/d2be47f5ddd1e546756ef9e8360913c945677115
20160225 08:54:23< irker334> wesnoth: Andreas wesnoth:master dd705441391a / src/replay.hpp: Merge pull request #610 from Wedge009/Fix_VC_build https://github.com/wesnoth/wesnoth/commit/dd705441391aef97649fd046dedadf6eb591f4a9
20160225 08:54:30< wedge009> Heh, thanks.
20160225 08:54:35< Aginor> ;)
20160225 08:54:52< zookeeper> Aginor, btw, apparently stuff going into the "debug output stream" should show up in VS's debug output window, but in this case it still just stays empty.
20160225 08:54:55< wedge009> Dunno why it didn't cause a problem in Linux build.
20160225 08:55:57< Aginor> probably pulled in from another header that's not included in a VC build
20160225 09:00:19-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160225 09:00:19-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20160225 09:00:19-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160225 09:02:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 09:03:49< vultraz> Aginor: I;d say ignore that and merge, then when more people can see tbhe bug we can look at it
20160225 09:04:57< vultraz> Aginor: does the icon appear in the editor for you?
20160225 09:05:11< vultraz> Aginor: it's the 4th icon from the right in the topbar
20160225 09:07:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160225 09:09:44< Aginor> there's a lot of them
20160225 09:09:49< Aginor> I've introduced a workaround now
20160225 09:09:57< Aginor> I haven't found the real bug though
20160225 09:14:34< irker334> wesnoth: Andreas Löf wesnoth:guifixes b576e1ae9081 / / (6 files in 6 dirs): Ensure that the map-editor still works https://github.com/wesnoth/wesnoth/commit/b576e1ae9081379222483713f85eb50130140001
20160225 09:15:25 * Aginor smiles
20160225 09:15:31< Aginor> that is the last commit
20160225 09:15:51< Aginor> I hope
20160225 09:16:15< Aginor> please give it a whirl and see if you can find something I've missed
20160225 09:16:26< Aginor> otherwise I think it's time to merge
20160225 09:19:53< zookeeper> Aginor, i compiled SDL myself, and with that the SDL_LogCritical calls are completely gone.
20160225 09:20:13< Aginor> zookeeper: that sounds like a bad build :/
20160225 09:20:30< zookeeper> Aginor, not that it helps performance any; it's actually a lot worse, probably due to build options and whatnot.
20160225 09:21:32< vultraz> Aginor: ok, let me just get my gui2 widget groups merged and I'll take a look in a bit
20160225 09:21:38< Aginor> zookeeper: water performance_
20160225 09:21:53< Aginor> zookeeper: what's a good way to test it?
20160225 09:22:52< zookeeper> Aginor, the first scenario of dead water
20160225 09:23:45< zookeeper> a modified version of that is basically what i've been using all the time.
20160225 09:24:28< Aginor> hmm
20160225 09:24:42< Aginor> that map leaves wesnoth at 60% cpu consumption for me
20160225 09:25:54< zookeeper> do you still get steady ~50fps if you use --fps?
20160225 09:26:47< Aginor> when idling, yes
20160225 09:26:55< zookeeper> okay
20160225 09:26:59< Aginor> scrolling is worse
20160225 09:27:50< Aginor> but I think that's to be expected
20160225 09:28:11< zookeeper> one thing i was wondering was whether it'd help if animations would halt when scrolling. i'd expect that usually people have scrolling speed set high enough that you wouldn't really see animations anyway when scrolling.
20160225 09:28:45< Aginor> yeah, that might make sense
20160225 09:29:04 * Aginor ponders
20160225 09:29:06< vultraz> (speaking of that fps, we should bump the default to 60)
20160225 09:29:09< vultraz> (not 50)
20160225 09:29:36< vultraz> (I can't find where the value is hardcoded, though)
20160225 09:29:42< Aginor> vultraz: there's really no need to do that though, it's not something where you want to hit vsync
20160225 09:30:15< vultraz> Aginor: well, if nothing else we can boast that our game runs at 60 fps :P which is a buzzword nowadays
20160225 09:30:36< Aginor> vultraz: save the planet! conserve electricity!
20160225 09:31:18< vultraz> "Battle for Wesnoth will reduce your electricity usage by 15% per year because it takes so long to play that you'll abandon your household chores"
20160225 09:31:20< vultraz> :D
20160225 09:33:27-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 250 seconds]
20160225 09:33:48< vultraz> anyway, just waiting on travis for my PR and then I'll test yours
20160225 09:35:43-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160225 09:35:46< Aginor> thanks
20160225 09:35:52< Aginor> merge it if you're happy with it
20160225 09:36:03< vultraz> mk
20160225 09:36:25< vultraz> so once that's done, can we start getting ready for 1.13.3?
20160225 09:36:34< Aginor> I think so
20160225 09:36:42< vultraz> :D
20160225 09:38:22< vultraz> If shadowm comes back I'll ask him if he's free for Sunday
20160225 09:38:35< Aginor> I won't be, just a heads up
20160225 09:39:25< vultraz> this will be the first public release with SDL 2, right?
20160225 09:39:38< Aginor> yes
20160225 09:40:37< zookeeper> vultraz, he said he'd be gone for the rest of the week
20160225 09:40:46< zookeeper> this week, that is
20160225 09:40:47< vultraz> zookeeper: when was this?
20160225 09:40:54< vultraz> well it's almost the end of the week
20160225 09:40:56< zookeeper> 2 days ago maybe?
20160225 09:41:58< vultraz> alright
20160225 09:55:52< Aginor> me and my cold are going to bed
20160225 09:56:00< Aginor> wedge009: I'll try to look at your PR tomorrow
20160225 09:56:12< vultraz> night
20160225 09:59:27-!- mjs-de [~mjs-de@f048100206.adsl.alicedsl.de] has joined #wesnoth-dev
20160225 10:07:38-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160225 10:38:11< wedge009> Ouch, yes, water-rich environments do seem to guzzle a lot of CPU - nearly a whole thread on my primary Windows machine. Less water, less CPU usage. But it still uses a lot even in 1.12.x - around half a thread for first scenario of Dead Water.
20160225 10:38:18< wedge009> Water animation seems different in master.
20160225 10:38:29< wedge009> Aginor: No rush - you get yourself well.
20160225 11:05:14< zookeeper> one thing i considered was whether color-keying (as opposed to alpha-blending) images when possible (such as most hex-cut terrain images) could actually improve blitting performance.
20160225 11:05:19< zookeeper> but a simple dumb change to make _everything_ color-keyed didn't really make things any faster (might have been slower, even), and i'm not even sure if one can even assume it's generally any faster or whether it depends on platform etc.
20160225 11:08:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20160225 11:11:46-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160225 11:18:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160225 11:20:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160225 11:20:25< irker334> wesnoth: Charles Dang wesnoth:master dfe7fcca8839 / projectfiles/CodeBlocks/wesnoth.cbp src/gui/widgets/group.hpp: gui2: implement widget groups https://github.com/wesnoth/wesnoth/commit/dfe7fcca8839bd926c3ee312e7411c892f00d787
20160225 11:20:28< irker334> wesnoth: Charles Dang wesnoth:master 6d883e10f429 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: reimplement radio toggle setup to use groups https://github.com/wesnoth/wesnoth/commit/6d883e10f429cbd3ba29b6553728f8f0470df0e5
20160225 11:20:31< irker334> wesnoth: Charles Dang wesnoth:master 2185faa40320 / / (4 files in 3 dirs): Merge pull request #588 from Vultraz/gui2_widget_groups https://github.com/wesnoth/wesnoth/commit/2185faa4032031c6a542814b792782da5d4dbc3c
20160225 11:21:43-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160225 11:25:11< irker334> wesnoth: Charles Dang wesnoth:master 1fd5eb63e1e9 / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/1fd5eb63e1e9896bd00b25c565a21dedbff03b6a
20160225 11:26:27< vultraz> celmin|sleep: ^ you can convert orbs to use groups now
20160225 11:29:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 11:34:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160225 12:37:55< vultraz> Aginor: opening dialogs in the editor causes screen flickering
20160225 12:38:26-!- louis94 [~~louis94@91.178.241.169] has joined #wesnoth-dev
20160225 12:40:20-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160225 12:44:49< vultraz> Aginor: the close button no longer appears in the help browser
20160225 12:45:12< vultraz> Aginor: gui2 window invalidation doesn't erase the old window
20160225 12:45:20< vultraz> Aginor: (see - the Addon Connect progress bar)
20160225 12:45:52< vultraz> Aginor: (note the help Close button only doesn't appear when opening from the titlescreen)
20160225 12:47:02< vultraz> Aginor: ok, seems it's not just window invalidation... if you try to start a campaign, the campaign dialog doesn't disappear before the Difficulty dialog appears
20160225 12:47:34< vultraz> Aginor: resizing in the titlescreen causes a flash
20160225 12:48:53< vultraz> Aginor: right click or opening menus still causes labels and chat messages to vanish as long as they're open
20160225 12:50:26< vultraz> Aginor: on the plus side, I'm noticing a general increase in snappiness 
20160225 12:50:32< vultraz> Aginor: things seem to happen faster
20160225 13:04:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160225 13:07:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160225 13:08:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20160225 14:05:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160225 14:21:44-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160225 14:25:40-!- irker334 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160225 14:32:35-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 248 seconds]
20160225 14:33:30< zookeeper> Aginor, it's kind of hilarious. i've recompiled SDL after removing all traces of SDL_LogCritical from it, recompiled wesnoth after removing all traces of SDL_LogCritical from the dependency headers, and still it just keeps showing up in the profiler. :P
20160225 14:36:51< zookeeper> (i also checked the very sleepy sources that it's not using SDL or anything like that)
20160225 14:42:23< zookeeper> it does keep showing up in the wesnoth.sdf file though, even after i deleted it and MSVC presumably regenerated it
20160225 14:51:28< zookeeper> hrhm. symbol caching.
20160225 14:57:58-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160225 15:12:50< mattsc> celmin|sleep: as far as I am concerned, the front page is now done: https://wiki.wesnoth.org/Wesnoth_AI
20160225 15:13:13< mattsc> If you feel so inclined, have a look sometime and tell me if you think something significant is missing.
20160225 15:13:32< mattsc> I mean this mostly as a start page, giving a very brief overview, but mostly as a collection of links
20160225 15:18:59-!- louis94 [~~louis94@91.178.241.169] has quit [Ping timeout: 248 seconds]
20160225 15:24:20-!- louis94 [~~louis94@91.178.241.169] has joined #wesnoth-dev
20160225 15:27:01-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has quit [Ping timeout: 240 seconds]
20160225 15:27:18-!- Rhonda [~rhonda@anguilla.noreply.org] has joined #wesnoth-dev
20160225 15:44:16-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 244 seconds]
20160225 15:55:54-!- stikonas_ is now known as stikonas
20160225 15:58:58-!- prkc [~prkc@46.166.188.242] has joined #wesnoth-dev
20160225 16:06:45-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160225 16:15:38< celmin|sleep> zookeeper, Aginor: I'm pretty sure that MSVC doesn't show any output in the debut output window unless you use MSVC's own API call to put it there, though I could be mistaken (or Wesnoth might even be using that method).
20160225 16:15:47< celmin|sleep> vultraz: Huh, you merged it already?
20160225 16:20:19< celmin|sleep> Does anyone think there's any point in adding usage, cost, traits, and abilities to the Lua view of a unit? The latter two would be just a list of IDs or something.
20160225 16:21:05-!- celmin|sleep is now known as celticminstrel
20160225 16:23:00-!- Kwandulin [~Miranda@p200300760F0BC58568FB28454DCB1E10.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160225 16:29:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160225 16:38:12< mattsc> celticminstrel: I have AIs which require access to cost, traits and abilities.  I have to go through __cfg at the moment to do that, which is slow.  However, I likely have to do so anyway for something else, so it doesn’t make a big difference.
20160225 16:38:59< mattsc> I just do so once at the beginning of the AI turn (or as needed) and then store it in tables that can be accessed more quickly.
20160225 16:40:07 * celticminstrel wonders what the something else is now.
20160225 16:41:18-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160225 16:41:19< mattsc> E.g. all the individual attributes of each attack.
20160225 16:41:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 16:41:37< mattsc> Also, ids for traits and abilities might not be enough.
20160225 16:41:49< mattsc> I don’t know, it changes all the time as I try things.
20160225 16:42:09< celticminstrel> It looks like attacks are already exposed without going through __cfg.
20160225 16:43:25< mattsc> Possibly, I don’t remember right now.
20160225 16:43:54< mattsc> The point is, unless you expose everything, there is likely something that might be needed at one point or another.
20160225 16:44:16< mattsc> This can be one going through _cfg, so I don’t really have an opinion one way or another.
20160225 16:45:10< celticminstrel> I personally think it'd make more sense if everything is exposed directly, and __cfg removed, but I guess keeping __cfg around could be considered a "last resort" in case something new is added but the Lua support for it is forgotten.
20160225 16:46:47< mattsc> My question would be, do you slow things down for the most-needed attributes by exposing everything directly?
20160225 16:46:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160225 16:47:00< mattsc> Anyway, if you really care, you can check out this: https://github.com/mattsc/AI-demos/blob/master/AI-demos/lua/fred_gamestate_utils.lua
20160225 16:47:10< mattsc> to see what I use _cfg for at the moment.
20160225 16:47:17< mattsc> But as I said, this changes all the time.
20160225 16:47:20< celticminstrel> mattsc: MediaWiki treats underscores and spaces as the same thing in page names, so there's no need to include the underscores when linking.
20160225 16:47:41< mattsc> And there’s certainly stuff in there that I won’t need in the end when I get to ceaning up everything.
20160225 16:48:03 * celticminstrel is doing a read-through and potentially typo-fix of Wesnoth AI.
20160225 16:48:17< mattsc> celticminstrel: I know; but there’s also no difference in how they are displayed, so does it matter?
20160225 16:48:27< mattsc> Great, thanks!
20160225 16:49:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 16:52:19< mattsc> FYI, the reason why I mostly have the underscore version is because I usually just copy-and-paste them from the URL.
20160225 16:57:39< celticminstrel> The actual reason I was asking is because the formula engine exposes them.
20160225 16:57:57< celticminstrel> On the other hand, the formula engine doesn't have any way of exposing the full config.
20160225 17:00:01< mattsc> I see.  Well, I need to do some preprocessing at the beginning of the turn anyway, so it doesn’t really matter for my own purposes.
20160225 17:00:40< celticminstrel> I thought it would be good to bring the Lua and Formula vies of a unit more in line (if not for AI, then at least for filter formulas).
20160225 17:00:51< celticminstrel> ^views
20160225 17:01:35< mattsc> I don’t think it matters for the AI.
20160225 17:01:43< mattsc> I don’t have an opinion on other uses.
20160225 17:04:52-!- louis94 [~~louis94@91.178.241.169] has quit [Ping timeout: 244 seconds]
20160225 17:14:17< mattsc> celticminstrel: thanks for the typo fixes!  Do you want me to let you know as I get done with the other pages?  As in, do you care?
20160225 17:14:33< celticminstrel> Sure.
20160225 17:15:04< mattsc> Thanks; this is much appreciated (esp. as a non-native English speaker)
20160225 17:15:31< celticminstrel> Oh? What's your native language?
20160225 17:15:40< mattsc> German
20160225 17:15:49< celticminstrel> Ah. A little similar, then.
20160225 17:16:34< mattsc> Right, definitely much easier than for some other languages.  Also, I’ve no lived in English speaking countries for almost as long as not.
20160225 17:16:42< mattsc> s/no/now
20160225 17:16:59-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 240 seconds]
20160225 17:17:32< celticminstrel> Who was it who said that the formula engine is prone to crashes? Was that Ravana_?
20160225 17:20:22< mattsc> I don’t remember.
20160225 17:31:30< vultraz> celticminstrel: is this valid: "members_.erase(std::find_if(members_.begin(), members_.end(), [&i](){ return members_[i].first == widget; }));" ?
20160225 17:32:44< celticminstrel> It's not. I suggest using [&] instead of [&i]. What's this for? Are you adding conditional compilation for C++11 or something?
20160225 17:33:12< celticminstrel> Also, you don't even need i, so I guess &widget would suffice.
20160225 17:33:27< celticminstrel> "members_[i]" is in fact passed as an argument to the lambda.
20160225 17:34:10< vultraz> for tgroup::remove_member. Just trying to understand the lambdas, might commit it commented out for now.
20160225 17:35:31< celticminstrel> You can probably put it in an #ifdef HAVE_CXX11 section instead of commented out (with the other version in #else)
20160225 17:35:39< vultraz> why would I pass &widget when widget is a function argument?
20160225 17:35:53< celticminstrel> That may or may not require including config.hpp.
20160225 17:35:55< celticminstrel> Huh?
20160225 17:36:13< celticminstrel> Okay, do you understand how local functions work in Lua?
20160225 17:36:40< celticminstrel> Like if you declare a function inside another function.
20160225 17:36:57< vultraz> yes, only exist within that scope yada yada, etc.
20160225 17:37:09< celticminstrel> And they can access local variables from the enclosing scope.
20160225 17:37:43< celticminstrel> The set of local variables they can access is called the "closure", and in Lua, it's automatically all variables in scope at the point of definition.
20160225 17:37:59< celticminstrel> In C++, however, you get to pick and choose exactly which variables go in the closure.
20160225 17:38:12< celticminstrel> That's what the [...] bit is for at the beginning of the lambda.
20160225 17:38:35< celticminstrel> In other words, you can't access any variables from the enclosing scope unless one of the following is true:
20160225 17:38:45< celticminstrel> 1) You used [&] to capture all variables by reference.
20160225 17:38:56< celticminstrel> 2) You used [=] to capture all variables by copying.
20160225 17:39:07< celticminstrel> 3) The variable is explicitly listed in the closure.
20160225 17:39:26< vultraz> so [&widget] captures the 'widget' variable?
20160225 17:39:45< celticminstrel> Yes, and the & means it captures it by reference rather than copying it. Though, since it's a pointer, that's probably not necessary.
20160225 17:39:58< celticminstrel> But certainly doesn't hurt.
20160225 17:40:39< vultraz> and you say members_[i] is automatically passed?
20160225 17:41:11< celticminstrel> The value that members_[i] would evaluated to in a for-loop is passed by std::find_if as an argument to the lambda.
20160225 17:41:25< celticminstrel> So you need to declare the lambda to take an argument.
20160225 17:42:16< vultraz> so something like this?
20160225 17:42:28< vultraz> [&widget](const tselectable_* member){ return member == widget; }
20160225 17:42:50< celticminstrel> Much better, but what's the type of members_? I suspect you have the wrong argument type there.
20160225 17:43:41< vultraz> oh, right, members_ is the vector of pairs
20160225 17:47:09< vultraz> are you saying the argument has to be a pair?
20160225 17:47:52< celticminstrel> It has to be the element type of the container you're iterating over, so in this case, yes, a pair.
20160225 17:48:28< celticminstrel> Because that's what std::find_if passes. It has to match.
20160225 17:48:44< vultraz> ok, so like... [&widget](const std::pair<tselectable_*, T>& member){ return member.first == widget; } ?
20160225 18:00:21-!- irker430 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160225 18:00:21< irker430> wesnoth: Charles Dang wesnoth:master 8691ae247d0b / src/gui/widgets/group.hpp: tgroup: implement remove_member (C++11 only) https://github.com/wesnoth/wesnoth/commit/8691ae247d0b9b8fc4acf9646d72757b753e715e
20160225 18:28:18< Aginor> vultraz: I can't do anything about the flickering at this stage without rewriting wesnoth's entire GUI systems and rendering pipeline
20160225 18:37:16< vultraz> that's unfortunate
20160225 18:45:56< celticminstrel> Flickering?
20160225 18:46:04< vultraz> entire window redraws
20160225 18:46:23< celticminstrel> Is it a constant flicker, or just at certain times?
20160225 18:48:24< vultraz> certain times
20160225 18:48:50< celticminstrel> Sounds probably bearable, then.
20160225 18:48:59< vultraz> opening menus in the editor and such
20160225 18:49:27< vultraz> as I said, though, there seems to be a big performance boost using the PR, so there's that
20160225 18:51:43< vultraz> I'll happily take the flickering in exchange :P
20160225 18:54:05< celticminstrel> Apparently LoW uses FormulaAI and is missing the formula for scenario 19.
20160225 19:00:09< celticminstrel> Nearly all the instances of formula= in mainline are either there or in one of the test scenarios. Only one instance is actually a filter.
20160225 19:00:20< celticminstrel> I wonder how often it's used for filters in addons.
20160225 19:15:30< celticminstrel> The reason why formula="moves < max_moves" did not work in a unit filter is because the formula engine had different names for the keys, for some reason - "movement_left < max_movement" would have worked.
20160225 19:16:02< Ravana_> I always specify $this_unit.something in formulas
20160225 19:16:10< celticminstrel> Sorry, it was total_movement.
20160225 19:16:33< celticminstrel> Well, using $this_unit means the formula sees the number hard-coded, so that works too.
20160225 19:17:26< celticminstrel> Formulas do sort of support string concatenation - '{a}{b}' concatenates the strings a and b.
20160225 19:17:59< celticminstrel> A lot of the formula stuff is probably mainly meant for AI and has little use in filters, but, whatever.
20160225 19:18:10< celticminstrel> It might have some use.
20160225 19:24:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160225 19:24:55< Ravana_> and yes, I was the one who said that any incorrect formula causes crashes
20160225 19:25:49< Ravana_> https://github.com/wesnoth/wesnoth/blob/0769824821eace028a35c2bc82bc0db2d8961f88/src/formula.cpp#L178 causes it most often
20160225 19:31:44< Aginor> vultraz: I'm confused about the performance boost, there shouldn't be one. rather the opposite since it's doing more work
20160225 19:32:09< vultraz> Aginor: well, I have no metrics to back it up
20160225 19:32:17< vultraz> just that everything felt like it was showing up faster
20160225 19:32:35 * Aginor shrugs
20160225 19:33:50< Aginor> I'll see if I feel up for sitting in front of the computer more later
20160225 19:33:58< Aginor> home sick from work today
20160225 19:34:02< Aginor> summer colds are the worst
20160225 19:39:24< vultraz> sucks :(
20160225 20:02:03< Aginor> one hour into it and I'm already bored
20160225 20:02:15< Aginor> probably means I'm not sick enough
20160225 20:04:10< Aginor> vultraz: are you up early or very late?
20160225 20:04:16< vultraz> early :)
20160225 20:04:22< Aginor> :D
20160225 20:09:27< irker430> wesnoth: Charles Dang wesnoth:master a0909a9d4749 / src/gui/dialogs/ (unit_create.cpp unit_create.hpp): tunit_create: simplified gender toggle using a group https://github.com/wesnoth/wesnoth/commit/a0909a9d4749bee9c2432d044052a553a1b7cdc2
20160225 20:09:30< irker430> wesnoth: Charles Dang wesnoth:master ec88475d2309 / src/ (gui/dialogs/unit_create.cpp gui/dialogs/unit_create.hpp menu_events.cpp): tunit_create: refactored out display argument https://github.com/wesnoth/wesnoth/commit/ec88475d2309e4b89436ef255c6a82b975457da4
20160225 20:09:33< irker430> wesnoth: Charles Dang wesnoth:master 6612b71b8d03 / src/ (gui/dialogs/unit_attack.cpp gui/dialogs/unit_attack.hpp mouse_events.cpp): tunit_attack: refactored out display argument https://github.com/wesnoth/wesnoth/commit/6612b71b8d03601e9254b719f6ea7cb3a602b8fc
20160225 20:10:25-!- Revvy [~Revvy@159.230.209.35] has joined #wesnoth-dev
20160225 20:11:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160225 20:13:28-!- Revvy [~Revvy@159.230.209.35] has quit [Quit: Going offline, see ya! (www.adiirc.com)]
20160225 20:15:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160225 20:18:08< irker430> wesnoth: Charles Dang wesnoth:master 02995731ced7 / src/gui/dialogs/ (addon_connect.cpp addon_connect.hpp): taddon_connect: removed unused display argument https://github.com/wesnoth/wesnoth/commit/02995731ced7808e25e2ecefbf4d7d7a292d450d
20160225 20:18:11< irker430> wesnoth: Charles Dang wesnoth:master e23a4764971b / src/ (3 files in 2 dirs): teditor_generate_map: refactored out reliance on display https://github.com/wesnoth/wesnoth/commit/e23a4764971bc71dc615e7a433a379f4cdca9865
20160225 20:19:13< vultraz> cleanup! 
20160225 20:42:16-!- prkc [~prkc@46.166.188.242] has quit [Ping timeout: 255 seconds]
20160225 20:43:02-!- prkc [~prkc@46.166.188.242] has joined #wesnoth-dev
20160225 20:53:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160225 21:00:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 21:02:01-!- travis-ci [~travis-ci@ec2-54-144-210-174.compute-1.amazonaws.com] has joined #wesnoth-dev
20160225 21:02:02< travis-ci> wesnoth/wesnoth#8618 (master - 6612b71 : Charles Dang): The build was broken.
20160225 21:02:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/111841494
20160225 21:02:02-!- travis-ci [~travis-ci@ec2-54-144-210-174.compute-1.amazonaws.com] has left #wesnoth-dev []
20160225 21:05:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160225 21:11:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 21:16:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160225 21:16:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160225 21:16:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160225 21:22:38-!- gfgtdf [~chatzilla@x50ab9478.dyn.telefonica.de] has joined #wesnoth-dev
20160225 21:27:43-!- Kwandulin [~Miranda@p200300760F0BC58568FB28454DCB1E10.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160225 21:34:34-!- travis-ci [~travis-ci@ec2-54-144-242-105.compute-1.amazonaws.com] has joined #wesnoth-dev
20160225 21:34:35< travis-ci> wesnoth/wesnoth#8619 (master - e23a476 : Charles Dang): The build was broken.
20160225 21:34:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/111843431
20160225 21:34:35-!- travis-ci [~travis-ci@ec2-54-144-242-105.compute-1.amazonaws.com] has left #wesnoth-dev []
20160225 21:59:57-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160225 22:03:28-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20160225 22:16:56-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160225 22:20:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160225 22:20:31-!- wedge010 is now known as wedge009
20160225 22:37:59-!- Appleman1234 [~Appleman1@KD119104005043.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160225 23:04:12-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160225 23:04:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160225 23:04:34-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160225 23:11:42-!- gfgtdf [~chatzilla@x50ab9478.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160225 23:18:30-!- irker430 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160225 23:33:28-!- louis94 [~~louis94@91.178.241.169] has joined #wesnoth-dev
20160225 23:33:41-!- irker372 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160225 23:33:41< irker372> wesnoth: Charles Dang wesnoth:master f84fc5cb0b3e / src/gui/dialogs/unit_create.cpp: Fixup a0909a9d4749 (unused parameter) https://github.com/wesnoth/wesnoth/commit/f84fc5cb0b3e62a766d3bedf3a565e68fc3b936d
20160225 23:34:22-!- Appleman1234 [~Appleman1@KD106161148078.au-net.ne.jp] has joined #wesnoth-dev
20160225 23:42:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160225 23:42:43< Aginor> vultraz: you should  modify your compiler settings so you detect that before you push
20160225 23:42:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160225 23:45:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160225 23:48:45 * vultraz isn't sure where to add that
20160225 23:57:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160225 23:59:28-!- gfgtdf [~chatzilla@x50ab9478.dyn.telefonica.de] has joined #wesnoth-dev
20160225 23:59:50< gfgtdf> vultraz: is there a reason why you used c++11 to implement tgroup::remove_member ?
--- Log closed Fri Feb 26 00:00:53 2016