--- Log opened Mon Feb 29 00:00:12 2016
20160229 00:01:50< gfgtdf> vultraz: im working one the gui2 hotkey dialog again, teh current plan is to leave the 'press the key' promt to gui1 and port everythign else to gui2.
20160229 00:02:00< vultraz> gfgtdf: that sounds good
20160229 00:03:21-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160229 00:03:28< vultraz> tfw you accidentally click Rebuild :(
20160229 00:04:55< gfgtdf> i know that well.
20160229 00:05:48< ancestral> vultraz: Works!
20160229 00:05:58< vultraz> ancestral: ah, good, good :D
20160229 00:07:03< ancestral> Can we get rid of the “load from multiplayer” message?
20160229 00:07:33< vultraz> we could, yes
20160229 00:07:43< gfgtdf> ancestral: y i'd say we can, as said in the bugreport all those bugs were fixed afaik.
20160229 00:07:56< ancestral> Well
20160229 00:08:03< ancestral> The Load Game… from multiplayer is broken
20160229 00:08:12< ancestral> But yes
20160229 00:08:12< gfgtdf> ancestral: it is ?
20160229 00:08:19< ancestral> Yeah it’s totally broken
20160229 00:08:29< gfgtdf> ancestral: what exactly is broken ?
20160229 00:08:32< ancestral> The button that says “Load Game…”
20160229 00:08:37< ancestral> In Multiplayer
20160229 00:08:41< ancestral> You choose a game
20160229 00:08:50< ancestral> Wesnoth crashes
20160229 00:08:56< gfgtdf> ancestral: hmm
20160229 00:09:03< gfgtdf> ancestral: that sounds bad
20160229 00:09:17< ancestral> What’s the point of loading game from multiplayer?
20160229 00:09:27< vultraz> ancestral: even more reason to remove the warning :P
20160229 00:09:41< ancestral> vultraz: That’s exactly my point
20160229 00:09:42< gfgtdf> ancestral: to load mp games
20160229 00:09:47< ancestral> g
20160229 00:09:55< ancestral> But seeing it works from Load
20160229 00:09:59< ancestral> There’s no reason, right?
20160229 00:10:17< vultraz> ancestral: but then you can't load an mp game in progress and resume it
20160229 00:10:22< gfgtdf> ancestral: well no, if you load them via sp load you can not play eh loaded game with others
20160229 00:10:29< vultraz> ^
20160229 00:10:30< ancestral> Can you from Load?
20160229 00:10:35< ancestral> Ah
20160229 00:10:53< ancestral> Okay so I see the problem
20160229 00:11:15< ancestral> It fails on replays
20160229 00:11:57< ancestral> There’s a message that shows “this is not a multiplayer save” when loading a sp game
20160229 00:12:05< gfgtdf> ancestral: well of it only fails on replays its not that bad, since you can always watch replays via sp mode (you cannot watch replay together with others onlie anyway)
20160229 00:12:07< ancestral> Maybe we need that on a replay
20160229 00:12:41< gfgtdf> ancestral: hmm yes
20160229 00:14:35< gfgtdf> ancestral: that woudl be rather easy i think you add a check for replay wheree currently the 'this is not a multiplayer save' message is shown
20160229 00:14:52< ancestral> Thanks for your help
20160229 00:14:54< ancestral> guys
20160229 00:17:38-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 00:19:50-!- gfgtdf [~chatzilla@x55b19b7e.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20160229 00:23:05< celticminstrel> Sounds like the MP load function should simply disallow loading replays.
20160229 00:23:27< celticminstrel> Make the load game dialog take a bool which determines whether replays are allowed?
20160229 00:25:04< irker494> wesnoth: Charles Dang wesnoth:master 5349552515f6 / src/ (display.cpp widgets/button.cpp): Add more comprehensive check for invalid button image loading (improves 0babe82b https://github.com/wesnoth/wesnoth/commit/5349552515f662877bed0b5be781eb78d396a754
20160229 00:26:14< vultraz> ^ also fixes another bug where certain overlays weren't drawn properly after setting font scaling in the editor
20160229 00:27:31-!- travis-ci [~travis-ci@ec2-54-92-141-248.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 00:27:32< travis-ci> wesnoth/wesnoth#8662 (master - 0babe82 : Charles Dang): The build has errored.
20160229 00:27:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112484887
20160229 00:27:33-!- travis-ci [~travis-ci@ec2-54-92-141-248.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 00:41:23-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160229 00:49:18-!- aidanhs_ [~aidanhs@81.4.110.234] has quit [Ping timeout: 276 seconds]
20160229 00:51:28-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160229 00:51:52< irker494> wesnoth: Charles Dang wesnoth:master c17e1448f5a2 / src/game_launcher.cpp: Removed warning for loading mp save from titlescreen https://github.com/wesnoth/wesnoth/commit/c17e1448f5a2736bce8868c337865e346a628de4
20160229 00:51:55< vultraz> ancestral ^
20160229 00:55:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160229 00:56:27-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160229 00:57:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160229 00:59:55-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160229 01:05:07-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 248 seconds]
20160229 01:07:23< vultraz> celticminstrel: I'll deal with your suggestion later
20160229 01:07:28 * vultraz is out
20160229 01:08:07< vultraz> Aginor: do you want me to open a bug for the Credits screen segfault or do your have a fix?
20160229 01:10:14< Aginor> vultraz: please open a bug, I haven't had time to look at it
20160229 01:10:22< Aginor> I have other worries atm
20160229 01:14:20< vultraz> ok, will do
20160229 01:14:22< vultraz> no rush
20160229 01:14:27< vultraz> hope stuff's ok :)
20160229 01:16:16< vultraz> filed as a blocker
20160229 01:24:56< mattsc> celticminstrel: LuaAI is now also ready, except for the last section
20160229 01:25:14< mattsc> That section is related to the one still missing at Creating_Custom_AIs
20160229 01:25:29< mattsc> So what’s left for me to do is:
20160229 01:25:37< mattsc> 1. Write those two sections
20160229 01:25:59< mattsc> 2. Go through all pages and fix the links that I broke while cleaning up other pages.
20160229 01:26:57< mattsc> 2. is easy; 1. will happen sometime  (it requires me actually writing some code and testing it, as the method I currently use is different from what I’d recommend to others)
20160229 01:27:15< mattsc> In any case, I think the AI documentation is in a much better shape now than it used to be.
20160229 01:27:29< mattsc> Whether it’s actually in a good shape is a different question  :P
20160229 01:29:35< celticminstrel> The [state] tag appears to work in Lua goals, aspects, stages, and candidate actions (execution only) and is passed to the code (though it's inaccessible to the external Lua CAs), but it's effectively read-only.
20160229 01:30:16< celticminstrel> Oh, right, it doesn't (currently) work in goals and aspects, but could easily be changed to do so.
20160229 01:30:34< celticminstrel> The read-only nature seems to defy the name used in the code, which is "serialized_evaluation_state".
20160229 01:32:39< mattsc> celticminstrel: as far as I am concerned, you can get rid of that
20160229 01:32:54< celticminstrel> Eh.
20160229 01:33:08< celticminstrel> I'm still against dropping the Lua stage, too.
20160229 01:33:13< mattsc> it’s not documented, and never has been; even I did not remember it; I very much doubt it has been used for anything
20160229 01:33:30< mattsc> well, I said “as far as I am concerned"
20160229 01:33:33< celticminstrel> And it seems potentially useful.
20160229 01:34:04< mattsc> Let’s just say we disagree on that.  :)
20160229 01:34:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160229 01:34:16< mattsc> Not that it’s potentially useful, I agree with that.
20160229 01:34:22< celticminstrel> Sure.
20160229 01:34:29< mattsc> But that it should be kept because it is _potentially_ useful.
20160229 01:35:02< mattsc> Since you are the one who’ll have  to maintain the code, not I, I really don’t mind or care one way or the other.  :)
20160229 01:35:07< celticminstrel> eval_parms and exec_parms mean that you can use the same external file with different input to create two separate CAs, right?
20160229 01:35:28< celticminstrel> I think that's a different use-case than having CA-private state that's serialized to the save file.
20160229 01:36:02< mattsc> yes, that’s correct
20160229 01:36:30< mattsc> I had to read that three times before I could wrap my brain around what it meant.  Haven’t had enough beer yet tonight, apparently.  ;)
20160229 01:36:59< celticminstrel> Though, the way it's currently set up, [state] is more like *_parms than [data].
20160229 01:37:08< mattsc> ok
20160229 01:37:12< celticminstrel> Do you often need exec_parms and eval_parms to be radically different?
20160229 01:37:31< mattsc> yes and no
20160229 01:37:52< celticminstrel> What sort of differences?
20160229 01:37:53< mattsc> they often are different, but mostly in the sense that not both of them require all of the same information.
20160229 01:38:15< celticminstrel> So, in that case, it would work if you combined them and passed both the same thing?
20160229 01:38:18< mattsc> In the Micro_AIs, I just pass them the same parameters, even though only some of it is used by one or both functions.
20160229 01:38:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160229 01:38:25 * celticminstrel nod
20160229 01:38:27< mattsc> yes - see ^
20160229 01:38:41< mattsc> I am being called away again, will be back later
20160229 01:38:49< celticminstrel> Okay. I'm proofreading a bit now.
20160229 01:38:56< mattsc> Thanks !
20160229 01:55:21< celticminstrel> I think the [ai]id= attribute is actually used internally to identify it... so it might be required for era/mod AIs...
20160229 01:56:44< celticminstrel> Is name and description really used as in your example? My impression was that "description" is in fact the name that appears in the menu.
20160229 01:57:19< celticminstrel> The text of the page seems to agree, but not the example.
20160229 02:05:07< celticminstrel> Aspects and goals also have access to the ai table, but I wonder what would happen if you tried to do something like ai.move() in an aspect or goal...
20160229 02:13:40-!- travis-ci [~travis-ci@ec2-107-22-51-111.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 02:13:41< travis-ci> wesnoth/wesnoth#8664 (master - c17e144 : Charles Dang): The build passed.
20160229 02:13:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112491057
20160229 02:13:41-!- travis-ci [~travis-ci@ec2-107-22-51-111.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 02:17:47< mattsc> celticminstrel: which example?
20160229 02:18:07< celticminstrel> The example of defining an AI for an era, I think it was.
20160229 02:18:28< mattsc> celticminstrel: if you use ai.move() in aspects, you get OOS errors.
20160229 02:18:33< celticminstrel> By the way, you state that the old method of defining Lua CAs requires the definition of an engine, but I believe that that is not the case.
20160229 02:19:04< celticminstrel> As far as I can tell, making the engine definition implicit is separate from the external Lua CA type.
20160229 02:19:04< mattsc> For the modification example (not era), note that there are two places where description appears
20160229 02:19:28< celticminstrel> Right, it was a modification.
20160229 02:19:34< celticminstrel> Ahh, okay, I see.
20160229 02:19:40< celticminstrel> I got confused, sorry.
20160229 02:20:11< mattsc> It’s the one in the [ai] tag that appears in the computer player menu
20160229 02:20:31< mattsc> the other one appears in the first page of the MP game setup, where you select the modification
20160229 02:21:26< mattsc> As for what you say about the engine, hmm ...
20160229 02:22:04< mattsc> I am pretty sure that the engine definition used to be necessary.  Maybe that was changed in general, not just for external CAs, when the extCAs were introduced?  I don’t know.
20160229 02:22:13< celticminstrel> I'm testing it now.
20160229 02:22:24< mattsc> celticminstrel: also interesting that you captialized all the L.'s
20160229 02:22:36< celticminstrel> Yeah, I thought it was clearer that way.
20160229 02:22:48< celticminstrel> Since a lower-case L might be mistaken for something else.
20160229 02:22:55< mattsc> So, in a sentence piece like: “Unit Bob of side 1, …” would you capitalize Side?
20160229 02:23:07< celticminstrel> No.
20160229 02:23:14< celticminstrel> Probably.
20160229 02:23:28< mattsc> Because in the journals in which I publish, you would do so.  Whereas in some others you would not.
20160229 02:23:37< celticminstrel> Why would you capitalize side there?
20160229 02:23:50< mattsc> Because in this content it is a proper name.
20160229 02:23:56< mattsc> *context
20160229 02:23:59< celticminstrel> It is?
20160229 02:24:21< mattsc> As I said, in some publications it is.
20160229 02:24:36< mattsc> Section 1, Chapter 3, Line 17, etc., is all capitalized.
20160229 02:24:49< celticminstrel> Section and chapter I would understand, yes.
20160229 02:25:11< mattsc> It’s the same thing isn’t it?
20160229 02:25:23< celticminstrel> I don't see how?
20160229 02:25:35< mattsc> It’s the third chapter, but Chapter 3.
20160229 02:25:49< mattsc> Why would that be capitalized, but not side if it is used in the same way?
20160229 02:25:55< mattsc> As in, what’s the difference?
20160229 02:26:36< celticminstrel> Just now, I replaced my dummy external CA with one using evaluation and execution tags. It worked.
20160229 02:26:49< celticminstrel> I dunno.
20160229 02:26:59< celticminstrel> Maybe it's that "side" isn't referring to some sort of sectioning of the text.
20160229 02:27:21< celticminstrel> (I used [ai][modify_ai] to add both CAs, for the record.)
20160229 02:28:17< mattsc> Both meaning external and old-style?
20160229 02:28:28< celticminstrel> Yes,
20160229 02:28:43< celticminstrel> The external still has a significant advantage though.
20160229 02:28:59< celticminstrel> With the external, it's possible for the evaluation and execution to share state, which I don't think is possible in the old style.
20160229 02:30:17< mattsc> ok
20160229 02:30:54< mattsc> BTw, just one more comment on the capitalization: even professional journals use different style on this, so … who cares, as far as I am concerned.  ;)
20160229 02:31:13< celticminstrel> With external CAs you don't even need self.data to share state within the CA - local variables also work.
20160229 02:31:16< mattsc> But yes, I like your reason for making the L’s capital.
20160229 02:31:34< celticminstrel> (I think that must be because they're loaded with wesnoth.require.)
20160229 02:31:44< mattsc> Yes — in fact the example on the wiki page does so.
20160229 02:32:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160229 02:32:13< mattsc> or, well, …
20160229 02:32:17< celticminstrel> The return guardian?
20160229 02:32:28< mattsc> do you mean local variables defined _within_ the evaluation and execution functions?
20160229 02:32:32< celticminstrel> It does have local variables, but it's not using them for shared state, only for utility stuff.
20160229 02:32:39< celticminstrel> No, local variables at the file level.
20160229 02:32:54< mattsc> Right — the get_guardian function is used like that  (through closure)
20160229 02:33:21< mattsc> yes, in the return guardian
20160229 02:33:42< celticminstrel> I'll probably proofread Experimental AI too at some point. I'll skip Micro AI since you say you didn't change much (plus it's a much newer page).
20160229 02:35:41< mattsc> It is — and I wrote that one entirely myself (well, and the MAIs themselves too, of course), so I am pretty confident about it.
20160229 02:35:58< mattsc> Not talking about the wording, only abou the content.  ;)
20160229 02:36:27< mattsc> Again, thanks for all the proof reading!
20160229 02:38:23< celticminstrel> Oh, right, I guess old-style CAs defined without an engine tag would be passed the self table instead of the ai table.
20160229 02:38:34< celticminstrel> But they do work, at least.
20160229 02:38:41< mattsc> ok
20160229 02:39:03< mattsc> celticminstrel: I like the change you made to Lua goals.  The change on eval/exec keys turned it into something different than what I was trying to say though.
20160229 02:39:17< mattsc> Which, admittedly, I did not say very well.
20160229 02:39:58< mattsc> This is good though.
20160229 02:40:44< celticminstrel> Oh, you mean the change in the old CA syntax.
20160229 02:41:04< celticminstrel> Something could be mentioned about the engine thing, I suppose. If you think it's worthwhile noting the self thing.
20160229 02:41:23< mattsc> nah, it’s fine the way it is
20160229 02:42:57< celticminstrel> Maybe I should just transform the [stage] mechanism into a generic mechanism for passing in arbitrary parameters, like exec_parms and eval_parms, rather than a way to persist data. After all, the self.data handles persistence perfectly fine. (Though currently only external CAa have access to it.)
20160229 02:43:29-!- Ivanovic_ [~ivanovic@p579FBD31.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160229 02:43:29-!- Ivanovic_ [~ivanovic@p579FBD31.dip0.t-ipconnect.de] has quit [Changing host]
20160229 02:43:29-!- Ivanovic_ [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20160229 02:43:45< mattsc> that sounds good to me
20160229 02:45:42< celticminstrel> Having everything global leads to potential conflicts if lots of CAs are using it, but there are ways to handle that.
20160229 02:45:58< celticminstrel> I mean if lots of CAs are storing stuff in self.data.
20160229 02:45:59-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Ping timeout: 268 seconds]
20160229 02:47:29-!- Ivanovic_ is now known as Ivanovic
20160229 02:47:50-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 268 seconds]
20160229 02:48:10-!- AI0867 [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20160229 02:53:44< mattsc> that’s true; that’s the same problem as with WML variables and macros
20160229 02:55:19< celticminstrel> Okay, [data] appears to work perfectly for persistence, which is good, but...
20160229 02:55:21< mattsc> celticminstrel: I'm going to sign out soon(ish).  Anythign else we should discuss tonight?
20160229 02:55:45< celticminstrel> I can't think of anything.
20160229 02:56:27< mattsc> okay; I always search the logs for my nick anyway  (I do not always read the full logs)
20160229 03:05:19-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160229 03:09:42< celticminstrel> Oh!
20160229 03:10:16< celticminstrel> In the Lua engine, the data table is a sibling of the ai table - they're stored in a table representing the Lua AI context.
20160229 03:10:35< celticminstrel> Hmm...
20160229 03:11:56< celticminstrel> This table is the first parameter to the CA...
20160229 03:12:07< celticminstrel> (Or to the goal, or aspect, or stage.)
20160229 03:15:01< celticminstrel> External CAs fiddle around with this.
20160229 03:15:09< celticminstrel> (Specifically, the dummy engine does.)
20160229 03:18:53< celticminstrel> Okay, that sibling thing is just a debug mode code path that is never actually called.
20160229 03:20:45-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160229 03:52:09-!- irker494 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160229 03:54:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160229 03:57:33-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 04:03:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160229 04:39:21-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Remote host closed the connection]
20160229 04:53:44-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160229 05:43:29-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160229 05:43:29-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20160229 05:43:29-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160229 05:43:37-!- iceiceice [~chris@wesnoth/developer/iceiceice] has left #wesnoth-dev []
20160229 06:28:45-!- Kwandulin [~Miranda@p200300760F0BD4E0D46B3F8B580F0812.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160229 06:33:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160229 06:48:27-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 06:54:43-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 06:59:46-!- irker928 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160229 06:59:46< irker928> wesnoth: Andreas Löf wesnoth:master 2a0631c6da1a / src/show_dialog.cpp: Fix bug #24477: Segfault when launching credits screen https://github.com/wesnoth/wesnoth/commit/2a0631c6da1aad256670b852a7bb4de59b752c78
20160229 06:59:46< irker928> wesnoth: Andreas Löf wesnoth:master dff09570888d / src/ (dialogs.cpp game_launcher.cpp widgets/button.cpp): Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/dff09570888da1b17ed79877381899c005c92279
20160229 07:07:29-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has quit [Ping timeout: 260 seconds]
20160229 07:10:56< zookeeper> gfgtdf, for what it's worth, the redo problem exists in 1.12 too.
20160229 07:12:12< zookeeper> but, i think it's necessary to fix that for [on_undo] to actually be usable
20160229 07:12:35< zookeeper> because otherwise the point of breakage just shifts from undo to redo
20160229 07:50:44< zookeeper> vultraz, whether the alignment icon in the debug unit create dialog works seems to depend on language. in spanish for example, "image not found" shows up instead.
20160229 07:51:00< vultraz> o-O
20160229 07:51:02< zookeeper> so you're probably using the translated string as part of the filename
20160229 07:51:03< vultraz> ehhh???
20160229 07:51:46< zookeeper> error display: could not open image 'icons/alignments/alignment_caótico_30.png'
20160229 07:52:15< vultraz> ahh...
20160229 07:52:17< vultraz> 	const std::string& alignment_name = unit_type::alignment_description(
20160229 07:52:19< vultraz> 		u->alignment(),
20160229 07:52:20< vultraz> 		u->genders().front());
20160229 07:52:22< vultraz> probably this
20160229 07:58:39< irker928> wesnoth: Charles Dang wesnoth:master 01168d50c8e0 / src/gui/dialogs/unit_create.cpp: tunit_create: fixed alignment icon paths being language-sensitive https://github.com/wesnoth/wesnoth/commit/01168d50c8e056162d337a1ef6e57870e0ae2699
20160229 07:58:51< vultraz> zookeeper: ^ can you confirm
20160229 08:01:16-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160229 08:01:20< vultraz> eh, forgot to fix the tooltip
20160229 08:02:30< zookeeper> seems to work
20160229 08:05:51< vultraz> weird
20160229 08:06:00< vultraz> tooltips not working in that dialog
20160229 08:08:56< vultraz> will have to investigate
20160229 08:08:57< irker928> wesnoth: Charles Dang wesnoth:master 032ab4557e4c / src/gui/dialogs/unit_create.cpp: tunit_create: made alignment tooltip use translated text again https://github.com/wesnoth/wesnoth/commit/032ab4557e4c89e7ad359ae2260203aecbc080b6
20160229 08:14:47-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 260 seconds]
20160229 08:35:05-!- atarocch [~atarocch@151.64.78.59] has joined #wesnoth-dev
20160229 08:42:28-!- Kwandulin [~Miranda@p200300760F0BD4E0D46B3F8B580F0812.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160229 08:45:01-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160229 09:10:46-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 09:37:15-!- mjs-de [~mjs-de@x4db5c9a3.dyn.telefonica.de] has joined #wesnoth-dev
20160229 09:46:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160229 10:15:54-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160229 10:31:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160229 10:31:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160229 10:52:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160229 10:56:43< zookeeper> gfgtdf, it looks like it could be easy to just fire events in the redo functions in undo_*_action.cpp, but i'm not sure if there's some reason why they shouldn't.
20160229 10:57:22< zookeeper> when undoing, events shouldn't be fired (because you don't want the signpost message to pop up just because you were standing on it, moved away, and used undo), but i don't know if the same is never true for redo.
20160229 10:59:22< zookeeper> my initial reaction would be that events should fire on redo
20160229 11:00:37< zookeeper> if you do something which triggers an event, undo, and then redo, it makes more sense to just fire the event again than for example to make the WML author specify actions to take at that point.
20160229 11:10:55< zookeeper> simply adding a resources::game_events->pump().fire("moveto", u->get_location()); to move_action::redo seems to do the trick for undo/redo of movement, but maybe you'll have some further insights.
20160229 11:31:36-!- mjs-de [~mjs-de@x4db5c9a3.dyn.telefonica.de] has quit [Remote host closed the connection]
20160229 11:34:05< irker928> wesnoth: Charles Dang wesnoth:master fb904c6b314b / src/ (gui/dialogs/game_load.cpp gui/dialogs/game_load.hpp savegame.cpp savegame.hpp): Pass savegame summary config to loadgame class https://github.com/wesnoth/wesnoth/commit/fb904c6b314b469dec8558eeda776ba05ba3cec5
20160229 11:34:08< irker928> wesnoth: Charles Dang wesnoth:master 2febafd7f990 / src/savegame.cpp: Added dedicated fallback message if a replay is loaded from mp create https://github.com/wesnoth/wesnoth/commit/2febafd7f9907efa667a71dcb6891eec0b2c697b
20160229 11:34:11< vultraz> that took more effort than it should have
20160229 11:43:28< irker928> wesnoth: Charles Dang wesnoth:master 3baba9235e24 / src/ (saved_game.cpp saved_game.hpp): Add missing copyright notices https://github.com/wesnoth/wesnoth/commit/3baba9235e24e8ac58158b01de99467e278b5f2d
20160229 11:51:48-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has quit [Remote host closed the connection]
20160229 11:59:32< vultraz> zookeeper: will you eventually deal with the editor loadscreen issue? it never seems to get to 'building terrain rules' which would be the relevant step
20160229 12:00:32< vultraz> or should I open a bug for someone
20160229 12:02:39-!- louis94 [~~louis94@91.178.240.127] has joined #wesnoth-dev
20160229 12:22:19-!- travis-ci [~travis-ci@ec2-50-17-47-241.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 12:22:20< travis-ci> wesnoth/wesnoth#8670 (master - 2febafd : Charles Dang): The build was broken.
20160229 12:22:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112565035
20160229 12:22:20-!- travis-ci [~travis-ci@ec2-50-17-47-241.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 12:31:32-!- louis94 [~~louis94@91.178.240.127] has quit [Quit: Konversation terminated!]
20160229 12:41:30-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 12:45:24< vultraz> ancestral: I've removed that warning you wanted and disallowed loading replays from mp
20160229 12:45:34< ancestral> Slick, thanks
20160229 12:46:41-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 12:46:42< travis-ci> wesnoth/wesnoth#8671 (master - 3baba92 : Charles Dang): The build was broken.
20160229 12:46:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112566296
20160229 12:46:42-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 12:47:02< vultraz> offf course iti s
20160229 12:48:06< zookeeper> vultraz, i doubt i'll try to fix it
20160229 12:51:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160229 12:53:31< vultraz> hm..
20160229 12:53:46< vultraz> ancestral: do any leader images show up in load game for you?
20160229 12:53:52< vultraz> ancestral: I just noticed here that I don't see any
20160229 12:53:59< ancestral> Leader images?
20160229 12:54:30< vultraz> yes, next to the map
20160229 12:54:49< ancestral> in the usual spot in the sidebar?
20160229 12:54:55< ancestral> Showing up in my build from last night
20160229 12:55:01< ancestral> Yes, I have leader images
20160229 12:55:12< vultraz> ok, pull my latest changes and see if you still have them
20160229 12:56:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160229 12:56:01-!- wedge010 is now known as wedge009
20160229 13:04:13-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160229 13:05:15< ancestral> Still looks good
20160229 13:05:24< vultraz> huh
20160229 13:05:32< vultraz> i must have a defective build
20160229 13:06:03< ancestral> This looks funny though
20160229 13:06:36< ancestral> https://img42.com/473SZ
20160229 13:07:07< vultraz> what in god's name happened O_O
20160229 13:07:09< ancestral> Do you see the random box hanging out?
20160229 13:07:29< vultraz> i do not
20160229 13:07:45< ancestral> Below the list
20160229 13:07:53< ancestral> of scenarios
20160229 13:08:02< ancestral> In the long black rectangle pane
20160229 13:08:04< vultraz> no I do in the screenshot
20160229 13:08:08< vultraz> I mean I do not in my build
20160229 13:08:13< ancestral> Ah
20160229 13:08:49< ancestral> Okay so I went back in
20160229 13:08:58< ancestral> Was there, clicked back, now it’s not
20160229 13:09:44< ancestral> Strange
20160229 13:09:58< ancestral> There it goes again
20160229 13:10:31< ancestral> vultraz: Okay, in the main menu
20160229 13:10:37< ancestral> Reload/refresh
20160229 13:10:39< ancestral> F5
20160229 13:10:48< ancestral> Then, go to Multplayer > Local Game
20160229 13:10:57< ancestral> Choose a map, click Next
20160229 13:11:05< ancestral> Click Back
20160229 13:13:53-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Ping timeout: 250 seconds]
20160229 13:15:58< ancestral> vultraz: Any luck?
20160229 13:16:09-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20160229 13:16:12< vultraz> nope
20160229 13:17:16< ancestral> Okay
20160229 13:17:33< ancestral> Try choosing “4p — Loris River”
20160229 13:18:24< ancestral> It looks like any of the maps 4p+
20160229 13:19:06< ancestral> Except not the 9p
20160229 13:19:25< vultraz> ah
20160229 13:19:27< vultraz> yes
20160229 13:19:28< vultraz> there it is
20160229 13:20:41< ancestral> If I leave the app and come back, it goes away (like that other bug we saw with the label that bled from the previous screen)
20160229 13:21:18-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160229 13:31:34-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160229 13:31:57-!- fendrin is now known as fabi
20160229 13:32:01< zookeeper> gfgtdf, random musings: apparently queued_event has the data member for basically storing arbitrary data (?), so i guess one could add some kind of flag there when firing the events from the redo functions, and then t_pump::process_event could return if it's set. that way an event could define whether it wants to be re-triggered on redo or not.
20160229 13:32:12< zookeeper> ...all that assuming that i actually understood it right, of course.
20160229 13:39:02-!- Appleman1234 [~Appleman1@KD106161150109.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20160229 13:51:30-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 246 seconds]
20160229 13:55:11-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160229 13:55:11-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20160229 13:55:11-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160229 14:05:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160229 14:19:21-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 14:30:56-!- Nobun [~nobun@host226-19-dynamic.52-82-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160229 14:41:19-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 268 seconds]
20160229 14:42:17-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160229 14:43:37-!- irker928 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160229 14:44:14< vultraz> zookeeper: could you take a look at doofus's mine walls?
20160229 14:44:24< vultraz> he posted a new version
20160229 14:44:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160229 14:50:50-!- mjs-de [~mjs-de@x4db5c9a3.dyn.telefonica.de] has joined #wesnoth-dev
20160229 15:01:15< zookeeper> vultraz, yes, but not right now
20160229 15:01:24< vultraz> no rush
20160229 15:07:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160229 15:08:01-!- irker829 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160229 15:08:01< irker829> wesnoth: Charles Dang wesnoth:master fb0285c27ff6 / / (5 files in 3 dirs): ttext_box: added support for defining a maximum input length https://github.com/wesnoth/wesnoth/commit/fb0285c27ff6e06ddde6c0b4343c1d2e8b4e0f5e
20160229 15:08:02< irker829> wesnoth: Charles Dang wesnoth:master 5c897703ecd3 / data/gui/default/window/game_save.cfg: tgame_save: specify a maximum savefile name length https://github.com/wesnoth/wesnoth/commit/5c897703ecd34ab7b80d67aeee9da25ee8322048
20160229 15:08:03< irker829> wesnoth: Charles Dang wesnoth:master 7adf43a4a201 / src/savegame.cpp: Don't truncate savefile names on disk (bug bug #23632) https://github.com/wesnoth/wesnoth/commit/7adf43a4a201def9f1659559f834b18f8e17932a
20160229 15:11:19< irker829> wesnoth: Charles Dang wesnoth:master ce8ca0a9dfa8 / src/savegame.cpp: Small indent fixup for 7adf43a4a201 https://github.com/wesnoth/wesnoth/commit/ce8ca0a9dfa8a21282c64c73b2902417c3a11aa0
20160229 15:13:48-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 276 seconds]
20160229 15:14:14-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160229 15:14:14-!- boucman_work [~jrosen@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Changing host]
20160229 15:14:14-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160229 15:19:51< vultraz> I wonder when shadowm will get back
20160229 15:27:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160229 15:55:21-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 16:06:42-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 260 seconds]
20160229 16:06:59< Nobun> anyone here knows how to use readthedocs? I need to upload the docs (sphinx) from my github project. I am asking here since the github project is the python 3 wmlxgettext rewrite
20160229 16:07:50-!- Kwandulin [~Miranda@p200300760F0BD43765129AD0E5D540A8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160229 16:09:11< vultraz> not sure
20160229 16:21:08-!- prkc [~prkc@catv-212-96-34-60.catv.broadband.hu] has joined #wesnoth-dev
20160229 16:25:40-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160229 16:30:47-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160229 16:30:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160229 16:34:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 16:40:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160229 16:41:46-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 16:41:47< travis-ci> wesnoth/wesnoth#8672 (master - 7adf43a : Charles Dang): The build is still failing.
20160229 16:41:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112608521
20160229 16:41:47-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 16:46:04< vultraz> but why is it failing :|
20160229 16:46:47< Nobun> vultraz... perhaps you did something wrong in your commit
20160229 16:48:33< vultraz> well, yes
20160229 16:48:39< vultraz> but the travis log is unhelpful
20160229 16:49:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 16:50:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20160229 16:50:58-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 16:52:13< Nobun> I will take a look
20160229 16:52:43< Nobun> what is the last log? 
20160229 16:53:36< vultraz> the one travis just left
20160229 16:54:20-!- gfgtdf [~chatzilla@f054168028.adsl.alicedsl.de] has joined #wesnoth-dev
20160229 16:54:47< Nobun> yep but I mean... the log points to different builds... what is the last build? the 8672.1?
20160229 16:54:49< gfgtdf> zookeeper: whihc redo problem ?
20160229 16:56:27< gfgtdf> zookeeper: i dont thinjk it is a good idea to fire events from the redo functions in undo_*_action.cpp
20160229 16:57:05< zookeeper> <zookeeper> gfgtdf, problem: moveto event triggers on a move. on_undo triggers when undoing the move. however, if you redo, the moveto event doesn't trigger.
20160229 16:57:23< vultraz> Nobun: yes
20160229 16:58:05-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160229 16:58:13< gfgtdf> zookeeper: in master we currently have [on_undo] and [on_redo] so that you could actions that shoudl be done qhen redoing in in on_redo
20160229 16:58:31< zookeeper> wait, we have [on_redo] too?
20160229 16:58:42< gfgtdf> zookeeper: the laternative is that we remove the redo function from the c++ code and just do the move the same way as we did it the first time
20160229 16:59:15< gfgtdf> zookeeper: i actually dont really know why we have those redo functions in undo actions.cpp. Maybe its just for beeeing faster than the nromal moving code ?
20160229 16:59:20< Nobun> vultraz: I can notice: ImportError: No module named 'libstdcxx'
20160229 16:59:41< Nobun> that it is very strange since it should be the linking of the standard c++ library
20160229 17:00:28< zookeeper> gfgtdf, the changelog only mentions [on_undo]
20160229 17:00:56< zookeeper> so, i didn't realize [on_redo] exists
20160229 17:01:02 * zookeeper tries it
20160229 17:01:09< gfgtdf> zookeeper: y it does exist.
20160229 17:02:01< gfgtdf> zookeeper: note that some actions like recuiting just call use the normal recuit code when redoing (which also fires recruit events afaik) while other actions liek moves have custom undo code.
20160229 17:02:47< gfgtdf> zookeeper: for the first type on_redo will not be called when redoing, it will onyl used for actions like move that haev a cusom redo code.
20160229 17:03:00-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 276 seconds]
20160229 17:05:30< zookeeper> gfgtdf, yeah, seems to work
20160229 17:05:44< zookeeper> well, there's no problem anymore then
20160229 17:06:20< vultraz> Nobun: weird
20160229 17:09:04< zookeeper> gfgtdf, funnily enough, i was actually looking at your commit which added both tags, but since after checking at the changelog i was only looking for [on_undo] i guess i never noticed that it mentioned [on_redo] too :p
20160229 17:09:14< zookeeper> -at
20160229 17:15:59-!- travis-ci [~travis-ci@ec2-107-22-55-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 17:16:00< travis-ci> wesnoth/wesnoth#8673 (master - ce8ca0a : Charles Dang): The build is still failing.
20160229 17:16:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112609297
20160229 17:16:00-!- travis-ci [~travis-ci@ec2-107-22-55-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 17:16:26-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160229 17:16:35< vultraz> gfgtdf: ^ do you have any ideas on that
20160229 17:18:43-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 17:26:31< irker829> wesnoth: Charles Dang wesnoth:master 91f79a956d22 / src/gui/widgets/ (text.cpp text_box.cpp): ttext: move maximum_length validity check to member function https://github.com/wesnoth/wesnoth/commit/91f79a956d22533b4893b298504cbedcd81b7183
20160229 17:31:57< gfgtdf> vultraz: well the gui2 tests segfault
20160229 17:34:35< vultraz> I can't understand why though
20160229 17:36:35-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Ping timeout: 248 seconds]
20160229 17:36:50-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160229 17:37:04< gfgtdf> vultraz: mostlikeley beacsue of what you added in tgame_load::post_show
20160229 17:37:47< gfgtdf> vultraz: did you test your loadgame dialog changes with any empty savefile list?
20160229 17:39:33< vultraz> yes it works fine with no saves
20160229 17:42:56-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160229 17:43:46< vultraz> well
20160229 17:43:59< vultraz> mostly because the dialog is caught first..
20160229 17:44:50< gfgtdf> what do you mean by 'caught'?
20160229 17:45:32< vultraz> before tloadgame is created there's a check if there are no saves and display a popup accordingly
20160229 17:45:41< vultraz> so we never reach the dialog if there are no saves
20160229 17:45:45< vultraz> so I think I know how to fix this now
20160229 17:46:26< irker829> wesnoth: Charles Dang wesnoth:master 56d8b9e36570 / src/gui/dialogs/game_load.cpp: tgame_load: attempt to fix unit tests https://github.com/wesnoth/wesnoth/commit/56d8b9e36570dd081d7e471890dd1a836f93cd8b
20160229 17:47:20< celticminstrel> Was that how the GUI1 saved game handled no saves, too?
20160229 17:51:11< vultraz> no
20160229 17:54:26< vultraz> gfgtdf: btw didn't you fix this bug months ago? https://gna.org/bugs/index.php?18002 can I close it?
20160229 17:54:57< celticminstrel> Showing a popup seems weird to me.
20160229 17:55:05< gfgtdf> hmm i dont remember having fixed this bug
20160229 17:55:12< vultraz> celticminstrel: do you know if this is still valid https://gna.org/bugs/index.php?18679
20160229 17:55:25< gfgtdf> i just added some more debuggin output in those cases
20160229 17:56:12-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 17:56:40< celticminstrel> I'm pretty sure it's not, but I've only been testing with one [ai] block. I'll try it in a few minutes.
20160229 17:57:38< vultraz> gfgtdf: maybe this is what you fixed? https://gna.org/bugs/index.php?15693
20160229 17:58:00< vultraz> celticminstrel: do close it if it's not valid anymore
20160229 18:06:04< celticminstrel> Hm, actually, I wonder if the issue there is different from what the poster thinks.
20160229 18:06:39< celticminstrel> If you have two [avoid]s like that, only one will take effect, because each is a different facet, and only the top facet matching the current turn will be active.
20160229 18:07:28-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 18:14:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 18:19:24< gfgtdf> vultraz: i have a more or less gui2 hotkey dialog working, cou'll test it when i push it to master ?
20160229 18:19:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160229 18:20:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 18:21:15< vultraz> gfgtdf: sure
20160229 18:23:49< vultraz> celticminstrel: so the bug is invalid?
20160229 18:23:58-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 18:24:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160229 18:24:06< celticminstrel> Not sure, possibly?
20160229 18:27:38-!- mjs-de [~mjs-de@x4db5c9a3.dyn.telefonica.de] has quit [Remote host closed the connection]
20160229 18:31:41-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 18:31:42< travis-ci> wesnoth/wesnoth#8674 (master - 91f79a9 : Charles Dang): The build is still failing.
20160229 18:31:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112643023
20160229 18:31:42-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 18:32:19-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 18:33:21< celticminstrel> ...the advancements aspect is kinda...
20160229 18:33:48< celticminstrel> Convoluted?
20160229 18:34:13< irker829> wesnoth: gfgtdf wesnoth:master 43f7fced78c2 / src/hotkey/ (hotkey_item.hpp hotkey_preferences_display.cpp): split out show_binding_dialog function from gui1 hotkey_preferences_dialog https://github.com/wesnoth/wesnoth/commit/43f7fced78c2f6daf777c0f06542ad30df6e8c6d
20160229 18:34:15< irker829> wesnoth: gfgtdf wesnoth:master 0efda655b802 / / (5 files in 4 dirs): port hotkey preferences dialog to gui2 https://github.com/wesnoth/wesnoth/commit/0efda655b802ffd72bdf1517f0c272b60746df68
20160229 18:34:17< irker829> wesnoth: gfgtdf wesnoth:master 1bb7489e31f9 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): implement tpreferences::default_hotkey_callback https://github.com/wesnoth/wesnoth/commit/1bb7489e31f9277419e8945656951b90d7748634
20160229 18:34:26-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 18:36:08< gfgtdf> vultraz: ^
20160229 18:36:37< vultraz> will test
20160229 18:44:02-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 18:44:38-!- louis94 [~~louis94@91.178.240.127] has joined #wesnoth-dev
20160229 18:46:44< irker829> wesnoth: Charles Dang wesnoth:master cff3f4afd916 / src/gui/dialogs/mp_connect.cpp: tmp_connect: enable undrawing of dialog and sub-dialog https://github.com/wesnoth/wesnoth/commit/cff3f4afd9162070edbe299d345e5983d8689ea2
20160229 18:48:08< vultraz> gfgtdf: sorting by Action doesn't work right - order isn't alphabetical 
20160229 18:49:40< gfgtdf> vultraz: hmm i cannot reproduce that
20160229 18:50:00< vultraz> gfgtdf: also, if you clear a hotkey and then reassign it, it says it's already assigned to some other action
20160229 18:50:22< vultraz> gfgtdf: where's the Defaults button?
20160229 18:50:29< gfgtdf> vultraz: not there yet
20160229 18:50:47< vultraz> ok
20160229 18:51:04< vultraz> I'll do some layout cleanup on the wml
20160229 18:51:16< vultraz> add borders and stuff
20160229 18:52:42-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 19:04:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 19:05:37< vultraz> gfgtdf: can I commit my cleanup of the wml file?
20160229 19:05:41< vultraz> or are you workingon it
20160229 19:06:35< Aginor> vultraz: please let me update the issue tracker status on the bugs assigned to me. The fixes need to go into the release notes and I do that while updating the issue tracker
20160229 19:06:50< vultraz> Aginor: oh, sorry :)
20160229 19:06:52< vultraz> :( *
20160229 19:06:58< vultraz> wrong smiley too.. :P
20160229 19:07:18< Aginor> excelent
20160229 19:07:26< Aginor> and with that, I shall go to work
20160229 19:11:58< vultraz> gfgtdf: https://www.dropbox.com/s/4vszs4cx64ny4kw/hotkeys_dialog_incorrect_sorting.PNG?dl=0 this is the sorting I get, BTW 
20160229 19:14:34-!- atarocch [~atarocch@151.64.78.59] has quit [Read error: Connection reset by peer]
20160229 19:14:44< gfgtdf> vultraz: feel free to change the cfg file
20160229 19:15:26-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160229 19:15:38< irker829> wesnoth: Charles Dang wesnoth:master 65fe7ddea6bc / data/gui/default/window/ (preferences.cfg preferences/06_hotkeys.cfg): tpreferences: cleaned up layout of Hotkeys panel https://github.com/wesnoth/wesnoth/commit/65fe7ddea6bc2fdb66f9db4e7ad63d0165803f58
20160229 19:15:57< gfgtdf> vultraz: hmm not i get the wrong sroting too...
20160229 19:16:14< gfgtdf> vultraz: seems liek i broke it between yb last test adn current master
20160229 19:17:05< gfgtdf> vultraz: ys seems liek it borke it in the last 'implement default hotkey callback'
20160229 19:17:07< gfgtdf> commit
20160229 19:17:23< gfgtdf> vultraz: willy ou also add a 'rest to default' button to the cfg file ?
20160229 19:17:24< vultraz> ahh
20160229 19:17:34< vultraz> yes
20160229 19:18:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 19:19:16-!- travis-ci [~travis-ci@ec2-107-22-55-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 19:19:17< travis-ci> wesnoth/wesnoth#8675 (master - 56d8b9e : Charles Dang): The build was fixed.
20160229 19:19:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112647026
20160229 19:19:17-!- travis-ci [~travis-ci@ec2-107-22-55-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 19:20:36-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160229 19:21:00< irker829> wesnoth: Charles Dang wesnoth:master 858c3fbe694e / data/gui/default/window/preferences/06_hotkeys.cfg: tpreferences: added Defaults button to hotkeys panel (WML only) https://github.com/wesnoth/wesnoth/commit/858c3fbe694e3cb0a2853933467ee3c2e1aea5ef
20160229 19:21:02< vultraz> gfgtdf: ^
20160229 19:21:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 19:24:13-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Quit: Konversation terminated!]
20160229 19:40:14< irker829> wesnoth: Charles Dang wesnoth:master 12ba9bd5c789 / data/gui/default/widget/listbox_default.cfg: tlistbox: move header and footer grids out of main grid (workaround for bug #237 https://github.com/wesnoth/wesnoth/commit/12ba9bd5c78919621718434591d511c66c10d774
20160229 19:40:41< celticminstrel> ...bug #237?
20160229 19:40:48< celticminstrel> There are bugs that old still open?
20160229 19:41:10< vultraz> IRC cutoff
20160229 19:41:12< vultraz> :P
20160229 19:41:15< celticminstrel> Oh.
20160229 19:41:20< vultraz> https://gna.org/bugs/index.php?23752
20160229 19:43:10-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160229 19:43:33-!- prkc [~prkc@catv-212-96-34-60.catv.broadband.hu] has quit [Ping timeout: 276 seconds]
20160229 19:44:53< vultraz> celticminstrel: btw, I added that warning you wanted when loading replays in MP
20160229 19:47:02< celticminstrel> I don't remember.
20160229 19:47:56< vultraz> you said maybe a flag should be added to game load saying whether to show replays or now
20160229 19:47:57< vultraz> not
20160229 19:48:09< vultraz> instead I just added an error message if you tried to load one
20160229 19:48:26< celticminstrel> Can you also disable the Show Replay button?
20160229 19:48:40< celticminstrel> (Or hide it.)
20160229 19:49:23< vultraz> slightly more complicated, but probably
20160229 19:49:24< irker829> wesnoth: gfgtdf wesnoth:master e2a097ac38c1 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): fix gui2 hotkey preferences page. https://github.com/wesnoth/wesnoth/commit/e2a097ac38c1f64288c988d83495bb0da93fc447
20160229 19:49:26< irker829> wesnoth: gfgtdf wesnoth:master 908b7bda1aec / src/gui/dialogs/preferences_dialog.cpp: make gui2 reset hotkeys button work. https://github.com/wesnoth/wesnoth/commit/908b7bda1aecf7e4aef670316d21110387d3f17c
20160229 19:49:30< gfgtdf> vultraz: try that ^
20160229 19:50:47< gfgtdf> vultraz: the descrition entry in the lists are now yellow/broen did you do that ?=
20160229 19:50:53< vultraz> yes
20160229 19:51:00< vultraz> for consistency with the rest of the dialog
20160229 19:51:36< gfgtdf> vultraz: i personalyl think that yellow is confusin
20160229 19:51:58< vultraz> gfgtdf: those commits fix all the issues I had :)
20160229 19:52:00< gfgtdf> vultraz: since its usualyl uses as the 'cou can click here' yellow life for teh labesls near toggebutton
20160229 19:52:08< gfgtdf> you*
20160229 19:52:12< gfgtdf> like*
20160229 19:52:30< vultraz> I might change it back later
20160229 19:53:54< gfgtdf> vultraz: i think we maybe shoudl just just smybols for the last 3 columsn in the hotkey list
20160229 19:54:03< vultraz> gfgtdf: I agree
20160229 19:54:05< gfgtdf> vultraz: to make the layout more independent from languages
20160229 19:54:08< vultraz> gfgtdf: I can do that tho
20160229 19:55:42< gfgtdf> vultraz: also the hotkey entry in the main list lacks an image
20160229 19:55:48< gfgtdf> vultraz: my paint skills arent that good
20160229 19:56:00-!- prkc [~prkc@46.166.188.227] has joined #wesnoth-dev
20160229 19:56:26< irker829> wesnoth: Charles Dang wesnoth:master 2bc3faf1b669 / data/gui/default/window/preferences.cfg: tpreferences: used fixed_height = true to enforce side panel icon sizes https://github.com/wesnoth/wesnoth/commit/2bc3faf1b6697ddf0b520bcc9bfd13c6b06e2b9f
20160229 19:56:29< irker829> wesnoth: Charles Dang wesnoth:master be5164df2278 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: different icon for Hotkey section https://github.com/wesnoth/wesnoth/commit/be5164df2278b4284851f3c6faf399ca3c6a58d3
20160229 19:56:33< vultraz> gfgtdf: I just used the small game icon for now
20160229 19:56:58-!- travis-ci [~travis-ci@ec2-50-17-47-241.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 19:56:59< travis-ci> wesnoth/wesnoth#8676 (master - 1bb7489 : gfgtdf): The build is still failing.
20160229 19:56:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112657962
20160229 19:56:59-!- travis-ci [~travis-ci@ec2-50-17-47-241.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 19:57:11< celticminstrel> Wait, wait, has hotkeys become a separate pane in main prefs?
20160229 19:57:23< vultraz> yes
20160229 19:57:30< celticminstrel> Huh.
20160229 19:57:37< celticminstrel> Didn't expect that.
20160229 20:00:33< celticminstrel> But the hotkeys dialog already had sections of its own, with their own icons. How are those handled now?
20160229 20:01:56< vultraz> all in one panel :)
20160229 20:02:52< celticminstrel> Uh. That sounds bad.
20160229 20:03:42< irker829> wesnoth: Charles Dang wesnoth:master 84ae04a5cee3 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: some formatting of the Reassign prompt https://github.com/wesnoth/wesnoth/commit/84ae04a5cee3deef3df434df3f2f1e0f748e5abe
20160229 20:06:10< gfgtdf> celticminstrel: the points that the the previosu implementatopn woith diffeent sections was rather consufing, becasue it looked liek a hotkey coudl eigher be available in 'tiltesceen' 'game' 'editor' or 'general' which is just not true.
20160229 20:06:43< gfgtdf> celticminstrel: for example 'load game' is avalialbe ingame in in titltescrreen and there are a lot of hotkewys only avaialbe in editor and ingame
20160229 20:07:34< celticminstrel> I think I see what you mean.
20160229 20:07:49< celticminstrel> You're saying it gives the impression that each hotkey is only available in one context.
20160229 20:09:23< gfgtdf> or in all tree (general)
20160229 20:09:32< gfgtdf> also i dont realyl see any advantages of the previousl wqay to present them
20160229 20:10:19-!- Kwandulin [~Miranda@p200300760F0BD43765129AD0E5D540A8.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160229 20:10:49< celticminstrel> I'd like to see what this new hotkeys dialog looks like, but I can check it out myself later if you don't feel like posting screenshots.
20160229 20:11:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 20:12:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 20:12:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 20:12:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 20:12:13< gfgtdf> celticminstrel: noo imugur alrady annoyed me enough .. And i dont feel liek go searching another page to upload them
20160229 20:12:23< vultraz> gfgtdf: hm.. I'm trying to figure out how to restore the icons next to certain hotkeys like in the old dialog
20160229 20:12:53< vultraz> seems like they weren't stored in any config... the dialog just checked image paths
20160229 20:14:15< vultraz> ahhh got it
20160229 20:14:41< vultraz> these should probably be stored somewhere internally 
20160229 20:14:44< vultraz> eventually
20160229 20:15:23< Ravana_> why not just get some application that provides easy shortcut to take and upload screen
20160229 20:16:35< celticminstrel> What are these icons?
20160229 20:17:01< vultraz> celticminstrel: https://drive.google.com/file/d/0B-mR9s8FduLLWHF2NDBabVFkR2M/view?usp=sharing
20160229 20:17:28< celticminstrel> Ah.
20160229 20:17:31< vultraz> (all that yes/no I'm going to change to icons)
20160229 20:17:49< celticminstrel> Looks fairly good.
20160229 20:18:04< celticminstrel> I'd put it above Advanced in the left panel.
20160229 20:18:16< celticminstrel> Advanced really should stay last.
20160229 20:18:48< vultraz> ok
20160229 20:19:02< celticminstrel> Instead of G / E / T, would it be possible to use the icons from the old hotkeys dialog?
20160229 20:19:16< celticminstrel> Might not look good enough scaled down, though...
20160229 20:19:42< vultraz> definitely not :P
20160229 20:20:05< celticminstrel> Is there any indication anywhere of what G / E / T stands for?
20160229 20:20:47< vultraz> tooltips
20160229 20:20:55< vultraz> celticminstrel: what do you think of Hotkeys after General
20160229 20:21:04< celticminstrel> Sounds okay to me.
20160229 20:22:06< celticminstrel> It could be nice if G were split into subcategories. For example, "debug commands", "information commands", "action commands", "planning commands".
20160229 20:22:45< celticminstrel> (Those categories are probably not exhaustive.)
20160229 20:22:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160229 20:23:48< irker829> wesnoth: Charles Dang wesnoth:master 854acb192b74 / / (2 files in 2 dirs): tpreferences: restore display of optional hotkey icons https://github.com/wesnoth/wesnoth/commit/854acb192b74cd5e9c8589f6a76fc3ba327ef585
20160229 20:23:51< irker829> wesnoth: Charles Dang wesnoth:master 7f5fe8c7f62b / src/gui/dialogs/preferences_dialog.cpp: tpreferences: moved Hotkeys option second https://github.com/wesnoth/wesnoth/commit/7f5fe8c7f62bafceeaac78b2137a22b3e8f0c84b
20160229 20:25:22< gfgtdf> vultraz: sure taht tahst enoght to make teh hotkeys on second row ?
20160229 20:26:08< vultraz> gfgtdf: what do you mean
20160229 20:27:26< gfgtdf> vultraz: also why did you add grow_factor = 1 to the icom column ?
20160229 20:27:40< vultraz> to allow the header to grow accordingly
20160229 20:27:49< vultraz> so the header for row 2 lines up with column 2
20160229 20:31:04< vultraz> now to change yes/no to symbols
20160229 20:32:04< gfgtdf> vultraz: but if the list contnt doesnt have grow_Factor=1 thatn the header shouldnt have it eigher if they want to line up i'd say
20160229 20:32:20< vultraz> that's not how it works
20160229 20:32:26 * vultraz shrugs
20160229 20:33:45< gfgtdf> vultraz: thewn how do you think i works ?
20160229 20:34:00< vultraz> it works the way I used it
20160229 20:34:01< celticminstrel> I can barely understand what gfgtdf is saying sometimes.
20160229 20:34:24< vultraz> I really don't know
20160229 20:34:36< vultraz> just that headers need to be as unrestricted as possible
20160229 20:34:41< vultraz> so they always match their rows
20160229 20:37:30< vultraz> celticminstrel, gfgtdf: https://drive.google.com/file/d/0B-mR9s8FduLLamZnMlhtRVliVE0/view?usp=sharing
20160229 20:37:52< vultraz> i thought instead of having x's in those empty spaces I'd just leave it black
20160229 20:38:07< celticminstrel> Better.
20160229 20:38:24< vultraz> doesn't even have to be green
20160229 20:38:33< vultraz> not sure
20160229 20:39:55< vultraz> celticminstrel: what say you, green or no green
20160229 20:40:09< celticminstrel> Green is fine.
20160229 20:40:14< celticminstrel> What's the alternative?
20160229 20:40:21< vultraz> white
20160229 20:41:51< celticminstrel> I think I like green.
20160229 20:41:54< vultraz> alright
20160229 20:43:30< irker829> wesnoth: Charles Dang wesnoth:master 073188f72761 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: switch Hotkeys status section to an icon view https://github.com/wesnoth/wesnoth/commit/073188f727611f5729e77b9813eb9523b7871b82
20160229 20:43:39< celticminstrel> I got a little distracted from AI stuff into making every Lua API function accept either {1,2} or {x=1,y=2} or 1,2 as locations.
20160229 20:47:13< gfgtdf> celticminstrel: i dont think thats agood idea, you can usually easisy convert at lest to the 1,2 format and it sure makes those functions more complicated
20160229 20:47:55< celticminstrel> More complicated how?
20160229 20:48:49< gfgtdf> celticminstrel: well the c++ side of te code has to expect 3 usases instead of just one
20160229 20:49:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 20:49:17< celticminstrel> Three what?
20160229 20:53:09< irker829> wesnoth: Charles Dang wesnoth:master 40edd588722f / src/gui/dialogs/preferences_dialog.cpp: tpreferences: formatting and minor code cleanup https://github.com/wesnoth/wesnoth/commit/40edd588722f7f667f8cd6a57f626ff0fa388e67
20160229 20:53:12-!- travis-ci [~travis-ci@ec2-50-17-47-241.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 20:53:12< irker829> wesnoth: Charles Dang wesnoth:master cc8b2d0cd020 / data/gui/default/window/preferences/ (10 files): tpreferences: renamed pref panel files in order of appearance (fixup 7f5fe8c7f62 https://github.com/wesnoth/wesnoth/commit/cc8b2d0cd020ec97d22da8c9fa7cb2de6dedbb5e
20160229 20:53:13< travis-ci> wesnoth/wesnoth#8677 (master - cff3f4a : Charles Dang): The build is still failing.
20160229 20:53:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112660930
20160229 20:53:13-!- travis-ci [~travis-ci@ec2-50-17-47-241.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 20:53:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 20:54:08< gfgtdf> celticminstrel: i just dont see any advantage of acceopting more different parameter types
20160229 20:54:45< celticminstrel> This is actually simplifying the C++ code.
20160229 20:55:16< gfgtdf> celticminstrel: how that ?
20160229 20:55:34< vultraz> gfgtdf: can we clean out most of hotkey_preferences_display.cpp now?
20160229 20:55:40< celticminstrel> Because I wrote a function to handle all the fiddly stuff of determining which way the location was passed.
20160229 20:55:46< vultraz> gfgtdf: also big thanks for doing this :)
20160229 20:56:48< gfgtdf> celticminstrel: and that is easier than x = Lua_checklint(1),y = Lua_checklint(2) qwhich is currentl the default way to handle those parmaeters ?
20160229 20:57:02< celticminstrel> Well, I think it's easier, at least.
20160229 20:57:12< celticminstrel> map_location loc = luaW_checklocation(L, 1);
20160229 20:57:45< celticminstrel> And the caller can then continue to act as if it were a single parameter, even if it was passed as two.
20160229 20:58:07-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20160229 20:58:31< gfgtdf> celticminstrel: that sounds like luaW_checklocation would to some black magic which coudl also be rather slow.
20160229 21:00:10< celticminstrel> If it's passed as two parameters, it's equivalent to luaL_checkint(L, 1); luaL_checkint(L, 2); lua_remove(L, 1);
20160229 21:01:07< celticminstrel> (Plus relevant assignments and the adjustment of adding 1 to each coordinate.)
20160229 21:01:16< celticminstrel> (Or subtracting 1, sorry.)
20160229 21:01:47-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160229 21:06:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 21:08:20< irker829> wesnoth: Charles Dang wesnoth:master fdb8b392c1d2 / / (2 files in 2 dirs): tpreferences: removed old Hotkey button under General https://github.com/wesnoth/wesnoth/commit/fdb8b392c1d2da5415753ae4767cca1d57df6cb6
20160229 21:08:23< irker829> wesnoth: Charles Dang wesnoth:master 05b0d478ee9a / src/hotkey/hotkey_preferences_display.cpp: Cleaned out old GUI1 hotkeys dialog implementation https://github.com/wesnoth/wesnoth/commit/05b0d478ee9a156307a2c3a1dfad165154a9ff4c
20160229 21:10:06-!- louis94 [~~louis94@91.178.240.127] has quit [Ping timeout: 250 seconds]
20160229 21:14:45< gfgtdf> celticminstrel: are there currently lua function which have a 'uncommon' was to pass locations ?
20160229 21:15:36< gfgtdf> celticminstrel: i mean different than passing as 2 integers ?
20160229 21:16:08< celticminstrel> Some accept them as a table with x and y keys, or an array with 2 elements. There are also a lot that return the latter format.
20160229 21:16:25< celticminstrel> (Such as the pathfinder functions.)
20160229 21:16:42< celticminstrel> (Though they have more than 2 elements, but the first 2 are the coordinates.)
20160229 21:16:51< gfgtdf> celticminstrel: the pathfiner functions returns arrays afaik so there isnt really another option
20160229 21:17:02< celticminstrel> Well, there's always another option.
20160229 21:17:22< celticminstrel> They could return an array of tables with string keys instead of an array of tuples.
20160229 21:17:36< gfgtdf> celticminstrel: hmm string lookups are slower
20160229 21:18:07< celticminstrel> How much slower?
20160229 21:18:40< gfgtdf> celticminstrel: didnt beanchmark yet.
20160229 21:26:41-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 21:26:42< travis-ci> wesnoth/wesnoth#8678 (master - 65fe7dd : Charles Dang): The build is still failing.
20160229 21:26:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112667163
20160229 21:26:42-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 21:27:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 21:32:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160229 21:32:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160229 21:34:32-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20160229 21:37:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160229 21:40:02-!- Nobun [~nobun@host226-19-dynamic.52-82-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160229 21:42:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160229 21:43:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 21:44:36-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160229 21:48:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160229 21:49:07-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160229 21:56:29-!- Soizic [~Jim@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160229 22:00:16-!- Soizic [~Jim@blk-138-75-91.eastlink.ca] has quit [Remote host closed the connection]
20160229 22:04:21-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 22:08:46-!- travis-ci [~travis-ci@ec2-107-22-55-79.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 22:08:47< travis-ci> wesnoth/wesnoth#8679 (master - 858c3fb : Charles Dang): The build was broken.
20160229 22:08:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112668560
20160229 22:08:47-!- travis-ci [~travis-ci@ec2-107-22-55-79.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 22:14:57-!- gfgtdf [~chatzilla@f054168028.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160229 22:15:55-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit [Remote host closed the connection]
20160229 22:18:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160229 22:18:41-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160229 22:21:41-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 22:28:48-!- louis94 [~~louis94@91.178.240.127] has joined #wesnoth-dev
20160229 22:33:40-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit [Remote host closed the connection]
20160229 22:35:40< celticminstrel> I can now write "ai.aspects.aggression" instead of "ai.get_aggression()".
20160229 22:35:53< celticminstrel> And it works for all aspects except the deprecated recruitment aspect. At least in theory.
20160229 22:36:05< celticminstrel> For advancements, it returns a location set.
20160229 22:39:46< celticminstrel> (Containing the results for each own unit on the map.)
20160229 22:39:55< celticminstrel> I haven't removed anu get_* functions related to aspects.
20160229 22:39:59< celticminstrel> ^any
20160229 22:46:00-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 22:47:30-!- gfgtdf [~chatzilla@f054168028.adsl.alicedsl.de] has joined #wesnoth-dev
20160229 22:47:50< gfgtdf> celticminstrel: do you know how the ai handles unit advantaments?
20160229 22:48:57< gfgtdf> celticminstrel: becasue currently the attack code has some ai advancemnts related parameters, i think it'd be good if we coudl get rid of that and instead be able to ask the ai the advancement question
20160229 22:51:21< celticminstrel> It uses the advancements aspect.
20160229 22:51:40< celticminstrel> Retrieve the aspect, and call adv.get_advancements(unit_iterator).
20160229 22:52:10< celticminstrel> adv is of type unit_advancements_aspect, so grepping for that might help.
20160229 22:56:54-!- travis-ci [~travis-ci@ec2-54-159-59-176.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 22:56:55< travis-ci> wesnoth/wesnoth#8680 (master - 12ba9bd : Charles Dang): The build was broken.
20160229 22:56:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112673351
20160229 22:56:55-!- travis-ci [~travis-ci@ec2-54-159-59-176.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 22:56:55< gfgtdf> celticminstrel: is unit_advancements_aspect also used by the default mp ai ? 
20160229 22:57:15< celticminstrel> I'm pretty sure it is? It only works on the AI's turn, though.
20160229 23:03:24< mattsc> yes and yes
20160229 23:05:42 * celticminstrel is currently removing the old recruitment CA/aspect.
20160229 23:06:51-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit []
20160229 23:08:00< mattsc> celticminstrel: I hope you are keeping track of all this, because I certainly have lost track.  (and that you will update the wiki accordingly whenever this gets merged)
20160229 23:08:08< celticminstrel> Which involves breaking recruitment in FormulaAI.
20160229 23:08:16-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 23:08:22< celticminstrel> I'll update the wiki based on the commit log once it's merged to master.
20160229 23:08:31< celticminstrel> (And also the changelog and release notes.)
20160229 23:08:40< mattsc> Great.
20160229 23:09:15< celticminstrel> Old recruitment was actually a separate CA.
20160229 23:09:26< mattsc> Yes.
20160229 23:09:42< celticminstrel> So this cuts out a lot of code.
20160229 23:10:21< celticminstrel> In fact, somehow it seems like it was two CAs.
20160229 23:13:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20160229 23:17:27-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit [Remote host closed the connection]
20160229 23:27:01-!- Appleman1234 [~Appleman1@KD106161144077.au-net.ne.jp] has joined #wesnoth-dev
20160229 23:29:27-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 23:32:07-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit [Remote host closed the connection]
20160229 23:35:33-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has joined #wesnoth-dev
20160229 23:35:34< travis-ci> wesnoth/wesnoth#8681 (master - 908b7bd : gfgtdf): The build was broken.
20160229 23:35:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/112675419
20160229 23:35:34-!- travis-ci [~travis-ci@ec2-54-147-13-163.compute-1.amazonaws.com] has left #wesnoth-dev []
20160229 23:36:34< celticminstrel> I feel like the AI interface could be dropped entirely...
20160229 23:36:44-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 23:36:47< celticminstrel> It's only used by the fallback stage now.
20160229 23:36:56< celticminstrel> I guess at one time it was used elsewhere.
20160229 23:37:57< celticminstrel> And with the composite AI system, people wanting to write entirely new AIs in C++ should really be writing a stage rather than something that replaces the entire composite AI structure.
20160229 23:38:31-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit [Remote host closed the connection]
20160229 23:53:34-!- Greg-Boggs [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 23:55:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160229 23:56:12-!- Greg-Bog_ [~greg_bogg@74.92.168.145] has joined #wesnoth-dev
20160229 23:57:33 * celticminstrel started doing it but then decided to give up.
20160229 23:58:02-!- Greg-Boggs [~greg_bogg@74.92.168.145] has quit [Ping timeout: 260 seconds]
--- Log closed Tue Mar 01 00:00:14 2016