--- Log opened Wed Mar 02 00:00:15 2016
20160302 00:15:10-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160302 00:15:26-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Client Quit]
20160302 00:16:18-!- aeonchild [~aeonchild@defocus/yummy/enchilado] has joined #wesnoth-dev
20160302 00:28:41-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 00:34:13-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 00:47:22-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160302 00:51:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160302 00:54:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160302 00:54:49-!- wedge010 is now known as wedge009
20160302 01:01:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 01:13:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 01:17:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 01:37:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 260 seconds]
20160302 01:44:14-!- legoktm [~quassel@wikipedia/Legoktm] has left #wesnoth-dev ["bye!"]
20160302 01:54:15-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160302 01:54:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160302 02:34:08-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 02:42:43-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 03:06:49< vultraz> celticminstrel: if you have a pair, are you allowed to initialize it in the constructor like pair(0,0)?
20160302 03:07:13< vultraz> or do you need pair(std::make_pair(0,0))
20160302 03:07:55< celticminstrel> I actually have no idea. Try it and see.
20160302 03:11:23< vultraz> that does work
20160302 03:11:25< vultraz> huh
20160302 03:11:45< vultraz> one of those things where "it works but why? who knows"
20160302 03:12:03< celticminstrel> The why is obvious - pair defines a constructor for it.
20160302 03:14:02< vultraz> a type constructor?
20160302 03:14:11< celticminstrel> A what?
20160302 03:15:15< vultraz> I'm asking you
20160302 03:15:22< vultraz> what do you mean by constructor for pair
20160302 03:15:31< celticminstrel> Pair is a class.
20160302 03:15:41< celticminstrel> Thus, it can define a constructor.
20160302 03:16:00< vultraz> oh
20160302 03:16:02< vultraz> ohhhh
20160302 03:16:03< vultraz> I seeeeee
20160302 03:16:06< celticminstrel> It's defined in <utility>, if you want to see its definition.
20160302 03:16:11< celticminstrel> (Or documentation.)
20160302 03:16:45< vultraz> so when you have a pair, you just have a instance of the pair class?
20160302 03:16:56< celticminstrel> More or less.
20160302 03:17:01< vultraz> ahhh
20160302 03:17:13< celticminstrel> It's a template class.
20160302 03:18:17< vultraz> so how are the 'base types' defined? ie, int, bool, char, etc
20160302 03:18:40< celticminstrel> Those are built into the language.
20160302 03:18:49< celticminstrel> That's why they can be multiple words.
20160302 03:19:13< vultraz> multiple words?
20160302 03:19:19< celticminstrel> Like "unsigned int" for example.
20160302 03:19:30< vultraz> ah
20160302 03:20:24< vultraz> i am enlightened 
20160302 03:20:54< celticminstrel> There's actually quite a lot of them - bool, signed char, unsigned char, char, signed short, unsigned short, signed int, unsigned int, signed long, unsigned long, signed long long, unsigned long long, float, double, long double.
20160302 03:21:07< vultraz> signed char?
20160302 03:21:11< vultraz> what is a signed char
20160302 03:21:15< celticminstrel> It is a signed char.
20160302 03:21:25< celticminstrel> "char" is really an integer type.
20160302 03:21:26< vultraz> :|
20160302 03:21:36< celticminstrel> So, it can be signed or unsigned just like any other integer type.
20160302 03:21:42< celticminstrel> Oh right, there's also wchar_t.
20160302 03:21:42< vultraz> ...wha??
20160302 03:21:50< vultraz> how is a character a number
20160302 03:22:00< celticminstrel> Also, "signed char" and "char" are, bizarrely, two different types. (Both are signed.)
20160302 03:22:58< celticminstrel> A character is a number. '0' in C is a numeric literal with a value of 48.
20160302 03:23:46< celticminstrel> "signed" and "unsigned" are also valid types (they imply "int").
20160302 03:24:00< celticminstrel> "signed" is always optional, except in "signed char".
20160302 03:24:01< vultraz> so are you saying internally the letter "C" and the number "0" are basically handled as...numbers?
20160302 03:24:05< celticminstrel> Yes.
20160302 03:24:12< vultraz> ....huh
20160302 03:24:39< vultraz> this is going deep
20160302 03:25:52< celticminstrel> This is an approximation (since the char type can't represent Unicode except in UTF-8), but it's stored as the numeric code point of the character.
20160302 03:28:08< vultraz> but what implements the code points
20160302 03:28:47< celticminstrel> Anything that takes characters or strings as an argument can interpret them however they want.
20160302 03:28:57< celticminstrel> So, in practice, I think the answer would be "your operating system".
20160302 03:29:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 03:34:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160302 03:39:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160302 03:39:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160302 03:40:33< vultraz> blagh
20160302 03:40:58< vultraz> adding some code to enable prefs to open to any selected panel
20160302 03:41:04< vultraz> but it makes prefs open slower :|
20160302 03:41:41< vultraz> or
20160302 03:41:42< vultraz> hm
20160302 03:41:44< vultraz> maybe not?
20160302 03:42:58< shadowm> Here's a better question: what could a character possibly be if not a number?
20160302 03:43:30< shadowm> I mean, you know where the name 'computer' comes from.
20160302 03:44:29< vultraz> good point
20160302 03:44:31< shadowm> Another thing that's also numbers: the CPU instructions generated by a C or C++ compiler.
20160302 03:44:35< celticminstrel> Since you're calling set_visible_page anyway in pre_show, there's no reason why making the arguments passed to that variable would slow down prefs, I think.
20160302 03:44:51< celticminstrel> (I assume that's indeed how you're making it variable...
20160302 03:44:55< celticminstrel> )
20160302 03:47:33< vultraz> basically, yes
20160302 03:47:53< shadowm> And to go even deeper, numbers actually are sequences of digital signals.
20160302 03:48:10< vultraz> shadowm: I thought at the very bottom everything was bools
20160302 03:48:22< shadowm> Digital signals = "zeroes and ones".
20160302 03:48:43< vultraz> so, binary 
20160302 03:48:48< shadowm> Be careful about the language -- the 'bool' type in C++ is an int with another name.
20160302 03:49:05< vultraz> what?
20160302 03:49:21< shadowm> It just happens to have boolean semantics (but then again, all integer types do) and two standarized values.
20160302 03:49:52< celticminstrel> Yeah, it's technically possible for a bool to hold a value other than true or false.
20160302 03:50:07< celticminstrel> Though in practice this probably never matters unless you actually use "== true".
20160302 03:50:17< celticminstrel> Since any nonzero value is considered "true".
20160302 03:50:36< celticminstrel> [Mar 01@10:48:10pm] vultraz: shadowm: I thought at the very bottom everything was bools
20160302 03:50:41< celticminstrel> Bits. Not bools.
20160302 03:50:46< shadowm> And it still wouldn't matter unless your bools are coming from shady places (including unusual casts).
20160302 03:50:51< celticminstrel> ^
20160302 03:50:58< celticminstrel> Bool is a type with a size of at least 8 bits.
20160302 03:51:04< celticminstrel> (As is char.)
20160302 03:51:18< vultraz> so binary 0/1 is not a bool switch?
20160302 03:51:27< celticminstrel> Not exactly.
20160302 03:51:37< celticminstrel> You can actually work with individual bits as if they were bools.
20160302 03:52:05< celticminstrel> This is a little-used (I think) syntax feature called "bit fields" which (I think) can only be used on class member variables.
20160302 03:52:58< celticminstrel> But no, binary 0/1 is not the same as a bool.
20160302 03:53:01< shadowm> That's a thing I hadn't heard mentioned in something like 10 years.
20160302 03:53:39< vultraz> huh
20160302 03:53:40< shadowm> Most people would just declare any garden-variety int and do bitwise operations with it.
20160302 03:53:45 * celticminstrel is someone who reads up on every little arcane corner of the language. >_>
20160302 03:53:53< vultraz> ok, so my assumptions were wrong
20160302 03:53:55< shadowm> And probably never need more than 32 bits.
20160302 03:54:57< vultraz> so is a binary 0 or 1 one bit?
20160302 03:55:14< shadowm> A bit is most directly represented by a binary digit, yes.
20160302 03:55:16< celticminstrel> Yeah.
20160302 03:57:38< vultraz> and does this relate to transistor gates on a piece of hardware?
20160302 04:12:37< vultraz> blagh
20160302 04:12:43< vultraz> this code isn't going to work
20160302 04:13:36-!- irker956 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160302 04:14:28< celticminstrel> Why not?
20160302 04:21:53< wedge009> Quick and easy PR if anyone is around to merge it: PR #613.
20160302 04:23:04< celticminstrel> Oh, more spelling. Fun.
20160302 04:23:46-!- irker492 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160302 04:23:46< irker492> wesnoth: Wedge009 wesnoth:master b148907938b1 / data/gui/default/window/preferences/04_sound.cfg: Spelling corrections https://github.com/wesnoth/wesnoth/commit/b148907938b190624e925c5816c842738d1f4da8
20160302 04:23:46< irker492> wesnoth: Celtic Minstrel wesnoth:master dfcdefeb2de3 / data/gui/default/window/preferences/04_sound.cfg: Merge pull request #613 from Wedge009/Spelling_corrections https://github.com/wesnoth/wesnoth/commit/dfcdefeb2de32320935f79e8be2716d8b5a9b44d
20160302 04:24:38< celticminstrel> 612 should probably be merged too, assuming it's correct.
20160302 04:25:11< wedge009> Thanks, cm.
20160302 04:34:31< celticminstrel> For a moment I thought "why'd he change button to buttom".
20160302 04:38:02-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160302 04:38:07< celticminstrel> What should we do with PR585?
20160302 04:54:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160302 05:12:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 246 seconds]
20160302 05:15:33-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160302 05:19:07-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 05:19:22< vultraz> ask zookeeper
20160302 05:19:31-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 05:22:26< vultraz> I keep forgetting... does wesnoth use i++ or ++1
20160302 05:22:30< vultraz> ++i*
20160302 05:22:37< shadowm> Prefix.
20160302 05:22:48< shadowm> Unless, of course, you need to use postfix.
20160302 05:26:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160302 05:41:38< vultraz> gahhhhh
20160302 05:41:45< vultraz> code y u no work
20160302 05:41:51< celticminstrel> ?
20160302 05:42:50< vultraz> I'm attempting to add a loop through every prefs page and then set the page of any sub-stacked widgets
20160302 05:43:00< celticminstrel> Huh?
20160302 05:43:20< vultraz> ok so I'm trying to add support of opening prefs on a specific page and tab
20160302 05:43:23< vultraz> s/of/for
20160302 05:43:44< celticminstrel> Why does this require looping through every prefs page?
20160302 05:44:30< vultraz> Right now, only one page (mp) has a sub-stack used for tabs
20160302 05:44:46< celticminstrel> Sub-stack?
20160302 05:44:52< vultraz> a stacked widget
20160302 05:44:59< vultraz> inside the page of a stacked widget
20160302 05:45:25< vultraz> so my code would allow you to provide an int pair to prefs
20160302 05:45:26< vultraz> say 4,1
20160302 05:45:36< vultraz> which would say select top page 4 and sub page 1
20160302 05:45:58< vultraz> the loop is to ensure *only* the subpage of top page A gets set to B
20160302 05:46:30< vultraz> but I'm getting a gui2 assert and I'm not sure what I did wrong
20160302 05:46:58< vultraz> I added a method to stacked widget to get the grid of a page..
20160302 05:47:03< vultraz> maybe I'm doing it wrong
20160302 05:47:15< celticminstrel> Okay, let's start simple. Does it work if you forget about the sub-stacks and only have a single page parameter?
20160302 05:47:54< vultraz> well, no
20160302 05:48:17< vultraz> stacked widgets, by default, display every page visible at once unless you select one
20160302 05:48:43< celticminstrel> Okay, does it work as long as you select a page other than MP?
20160302 05:49:56< vultraz> right now it doesn't work at all because I'm getting an assert that index < items_.count in tgenerator and that's what I'm trying to figure out
20160302 05:50:14< celticminstrel> So, the assert isn't related to trying to deal with sub-stacks?
20160302 05:50:41< vultraz> no, I think it's related to trying to get a page grid (which is a method I added)
20160302 05:50:58< celticminstrel> You don't need that to set the page though, right?
20160302 05:51:36< vultraz> I'm not sure
20160302 05:51:51< celticminstrel> I'm 99% sure you don't.
20160302 05:52:03< celticminstrel> If you did, then the preferences dialog wouldn't function normally, I think.
20160302 05:52:06< vultraz> since all pages are visible until you select one, that means that all pages are eligible to be searched by find_widget
20160302 05:52:17< celticminstrel> Look at your pre_show function.
20160302 05:52:32< celticminstrel> At the end there is the code to select the prefs page, right?
20160302 05:52:43< vultraz> yes, that makes only one visible
20160302 05:52:44< celticminstrel> Nothing about getting grids that I can see.
20160302 05:52:52< vultraz> right
20160302 05:52:53< shadowm>  In which order are you selecting the pages?
20160302 05:52:57< vultraz> becuase why would you need it there?
20160302 05:53:06< celticminstrel> So all you have to do is alter (or adapt) that code in order to select a page other than the first.
20160302 05:53:10< shadowm> I.e. parent page then subpage, or subpage then parent page?
20160302 05:53:17< vultraz> subpage first
20160302 05:53:24< shadowm> Okay.
20160302 05:53:34< celticminstrel> (I imagine you have similar code elsewhere, too, for handling clicks on the categories.)
20160302 05:53:54< vultraz> http://pastebin.com/dk3LANQm
20160302 05:54:22< vultraz> get_page_widget is a simply has 'return &generator_->item(i);'
20160302 05:56:17< vultraz> I know it has its members or else this would fail: assert(selector.get_item_count() == pager.get_layer_count());
20160302 05:56:34< vultraz> maybe this is because the layers are set from wml?
20160302 05:56:48< vultraz> hm..
20160302 05:56:54< vultraz> no, or else select_layer() would do nothing
20160302 05:59:01< celticminstrel> I imagine this would've been much easier if, instead of having a substack, you had included the friends list in the same stack as the other pages and just omitted it from the sidebar.
20160302 05:59:25< celticminstrel> Like I believe shadowm suggested.
20160302 05:59:28< vultraz> he did
20160302 05:59:36< vultraz> I can't remember why I said that wouldn't work
20160302 06:00:15< vultraz> probably because it'd involve too many magic numbers
20160302 06:00:19< vultraz> yes, that's right
20160302 06:00:31< celticminstrel> Magic numbers aren't necessarily bad.
20160302 06:00:50< shadowm> He heard me complaining about magic numbers in GUI1 once.
20160302 06:01:03< shadowm> I have a feeling that's somehow connected to this.
20160302 06:01:53< vultraz> I just don't like it in this case
20160302 06:02:01< vultraz> I always code a feature as general as possible
20160302 06:02:34< shadowm> Adopting that as a dogma results in overengineering.
20160302 06:02:41< celticminstrel> That's a good intention, but... sometimes it creates too many complications.
20160302 06:02:53< vultraz> I don't want to have to do (num of toplevel pages + num of subtab pages in n number of pages before this page)
20160302 06:03:35< celticminstrel> XCode just crashed in the middle of debugging. o.o
20160302 06:03:42< celticminstrel> vultraz: Why not?
20160302 06:03:49< shadowm> I've had gdb crash on me. A lot of times.
20160302 06:03:56< celticminstrel> There is only one subtab page, anyway.
20160302 06:04:01< vultraz> for now
20160302 06:04:08< vultraz> I don't know how many will be added in the future
20160302 06:04:22< celticminstrel> I don't think this was lldb crashing. I think it was XCode.
20160302 06:04:30< vultraz> I don't want to force future!maintainer to have to hunt down magic numbers
20160302 06:04:39< celticminstrel> vultraz: Then use const int.
20160302 06:04:43< shadowm> Then leave relevant documentation for the future maintainer in question.
20160302 06:05:09< vultraz> either way, I *think* this code will work
20160302 06:05:17< shadowm> A rampant lack of documentation is the root of 90% of all problems in our codebase, not the overuse of specialized code.
20160302 06:05:17< vultraz> the issue is why tgenerator is asserting
20160302 06:05:43< shadowm> In fact, the overuse of generic code is the root of 98% of all problems in GUI2. :p
20160302 06:05:49< celticminstrel> Heh.
20160302 06:07:50< shadowm> I've said this before and I'll say it again: the real world isn't black and white, good vs. evil. If people took such an approach to programming, a lot of things would work poorly or wouldn't exist.
20160302 06:07:59< celticminstrel> I like things to be generic too, but I still thing GUI2 took it too far.
20160302 06:08:02< celticminstrel> ^think
20160302 06:08:24< shadowm> For example, operating system kernels and device drivers usually include quirks for almost every supported hardware.
20160302 06:09:09< shadowm> Often, Windows works "better" with some hardware compared to Linux only because Microsoft works closely with hardware manufacturers to incorporate such quirks well in advance before a given product is released to the general public.
20160302 06:10:03< celticminstrel> I feel like the End Turn button could be a few pixels higher.
20160302 06:10:41< shadowm> GPU drivers tend to ship with large quirk databases to optimize for known use cases in games etc.
20160302 06:11:18< shadowm> Conversely, games tend to include workarounds and optimizations for specific GPU models and system configurations.
20160302 06:12:30< shadowm> Low level code in operating systems is often written to take advantage (or conversely, work around bugs) of specific ISA features from some CPU models.
20160302 06:12:50< shadowm> The same applies to the assembly-emiting stage of compilers too.
20160302 06:13:46< shadowm> I'm not saying anything about this particular situation, I'm just reminding you of the crude reality of the world.
20160302 06:16:16< shadowm> As for what happens to programmers who place theory above practicality, well, they go on to create projects like the HURD.
20160302 06:16:45< celticminstrel> What's that?
20160302 06:17:11< shadowm> GNU's most ambitious project ever.
20160302 06:18:53< shadowm> Linux is the de facto kernel of the GNU operating system family. GNU isn't happy about this. GNU wants to create their own kernel (and were working on it before Linux came along anyway) to remedy this.
20160302 06:19:32< vultraz> why would they not be happy?
20160302 06:19:51< shadowm> But they spent so much time fiddling around with the theory that it's still unsuitable for production.
20160302 06:20:16< shadowm> Linux is a monolithic kernel, much like Windows 9x and MS-DOS were back in the day.
20160302 06:20:42< shadowm> The HURD is supposed to be a microkernel and base OS services are supposed to be provided by userland.
20160302 06:21:41< shadowm> But they've not only had to replace the foundations a few times, they also have had a hard time getting the userland parts right.
20160302 06:22:24< vultraz> they're still working on it?
20160302 06:22:42< shadowm> So the status quo remains that Linux, despite being built on a design that's considered "inferior" in some circles, is the de facto GNU kernel.
20160302 06:22:43-!- Kwandulin [~Miranda@p200300760F0BD4ADE55477F68F19B4CD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160302 06:22:46< shadowm> Yes.
20160302 06:23:58< shadowm> (For reference, Windows NT is a hybrid kernel. A few base services are provided by a monolithic kernel, and others (like the Win32 API and graphical subsystem) are provided by separate server components.)
20160302 06:24:51< shadowm> (In reality though, most of its components are so intimately familiar with each other that it might as well be considered monolithic. I guess its concept of loadable device drivers spares it from qualifying as such.)
20160302 06:29:48< vultraz> ...weird. this loop seems infinite
20160302 06:29:52< vultraz> why is it infinite :|
20160302 06:30:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 06:30:24< vultraz> AH
20160302 06:30:33< vultraz> you need a condition for the second argument, don't you
20160302 06:30:44-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160302 06:30:58< shadowm> What.
20160302 06:31:02< vultraz> wait no
20160302 06:31:04< vultraz> ....
20160302 06:31:06< vultraz> wait
20160302 06:31:07< vultraz> what?
20160302 06:31:14< vultraz> then why is this an infinite loop :|
20160302 06:31:19< celticminstrel> I have no idea what you're talking about.
20160302 06:31:33< shadowm>     for( start statement ; stop condition ; iteration end statement )
20160302 06:32:03< shadowm> s/stop/continue/
20160302 06:32:10< celticminstrel> I recently noticed that used for a Lua iteration. I wish the Lua documentation showed the for-loop version, it seems more elegant.
20160302 06:32:26< vultraz> celticminstrel:  for(int i = 0; pager.get_layer_count(); ++i) gives me an infinte loop
20160302 06:32:35< shadowm> Obviously.
20160302 06:32:39< celticminstrel> Yeah.
20160302 06:32:45< shadowm> pager.get_layer_count() isn't changing, is it?
20160302 06:32:48< vultraz> no
20160302 06:32:55< celticminstrel> vultraz, a C for-loop is just thin syntactic sugar over a while-loop.
20160302 06:32:58< vultraz> I was thinking of this as a range-for statement
20160302 06:32:58< shadowm> If it never changes, and it was a true value (!= 0) at the start, then it will never be false.
20160302 06:33:04< celticminstrel> That middle thing is the while-condition.
20160302 06:33:14< celticminstrel> A range-for has a colon (and is C++11 only).
20160302 06:33:59< celticminstrel> The statement "for(A; B; C) { D }" is roughly equivalent to "A; while(B) {D; C;}".
20160302 06:34:11< vultraz> so in c++11 it would be ... for(int i = 0 : pager.get_layer_count()) ?
20160302 06:34:15< shadowm> No.
20160302 06:34:31< shadowm> That's not how range-for works in C++11 and since you are writing C++03 you shouldn't worry about it anyway.
20160302 06:34:34< celticminstrel> I say "roughly" because that representation doesn't account for the scoping of for variables or the fact that C gets executed even if you use continue.
20160302 06:34:48< celticminstrel> Chances are a C++11 range-for loop wouldn't work here, anyway.
20160302 06:35:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160302 06:35:21< celticminstrel> It's for(VAR : CONTAINER), generally, and CONTAINER needs to have begin() and end() functions.
20160302 06:35:26< shadowm> It would if I had foreseen this use case.
20160302 06:35:38< celticminstrel> Fair enough.
20160302 06:35:54< vultraz> If you had foreseen?
20160302 06:35:57< shadowm> It's quite a weird use case, I'll say that much.
20160302 06:36:03< celticminstrel> So vultraz: Think of it as a while-loop.
20160302 06:36:28< celticminstrel> Then you'll understand why it's infinite.
20160302 06:36:37< celticminstrel> And how to fix it.
20160302 06:36:58< vultraz> yes I've fixed it
20160302 06:37:02< celticminstrel> Yay.
20160302 06:37:33 * celticminstrel sleeps.
20160302 06:39:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160302 06:40:19< shadowm> I am the one who added the get_layer_count() getter.
20160302 06:40:32< vultraz> Yes, I know
20160302 06:40:53< vultraz> whoot whoot, t'is working 
20160302 06:40:54< shadowm> If I wanted it to be used with Boost.Foreach or range-based for I'd have added begin() and end() methods.
20160302 06:41:11< shadowm> That's the answer to this question, in case it wasn't obvious: 03:35:56 <vultraz> If you had foreseen?
20160302 06:41:20< vultraz> it was obvious
20160302 06:41:58< shadowm> Okay, then I'm not sure why you asked the question.
20160302 06:42:26< vultraz> I mean it's obvious what question you're answering
20160302 06:42:39< shadowm> No, I mean you said you knew I did it.
20160302 06:42:57< vultraz> right
20160302 06:42:59< vultraz> let's move on
20160302 06:58:00< vultraz> well, my code works
20160302 06:58:17< vultraz> the functionality works
20160302 06:58:52< vultraz> only one problem - I need a generic ID for the tab pagers for the loop to work..
20160302 06:59:09< vultraz> but the callback relies on specific ones
20160302 06:59:11 * vultraz ponders this
20160302 07:07:00-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 07:08:40-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 07:11:47-!- mjs-de [~mjs-de@x5ce3322e.dyn.telefonica.de] has joined #wesnoth-dev
20160302 07:14:13-!- Kwandulin [~Miranda@p200300760F0BD4ADE55477F68F19B4CD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160302 07:23:55-!- irker492 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160302 07:42:43-!- quentinp_ [~quentin@ns363174.ip-91-121-196.eu] has joined #wesnoth-dev
20160302 07:44:49-!- quentinp [~quentin@ns363174.ip-91-121-196.eu] has quit [Read error: Connection reset by peer]
20160302 07:53:13-!- Kwandulin [~Miranda@p200300760F0BD4AD35EAD11D8A9F84F4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160302 07:56:17-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has quit [Read error: Connection reset by peer]
20160302 07:57:35-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has joined #wesnoth-dev
20160302 08:00:13< vultraz> I got it
20160302 08:00:34-!- irker808 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160302 08:00:34< irker808> wesnoth: Andreas Löf wesnoth:master 8a5b4fed4122 / src/gui/dialogs/ (preferences_dialog.cpp transient_message.cpp transient_message.hpp): Make some transient messages transparent again https://github.com/wesnoth/wesnoth/commit/8a5b4fed4122c356887747e13141d9d9893e2b3e
20160302 08:00:35< Aginor> hi
20160302 08:01:08< Aginor> Can someone please tell me the most convenient way to spawn/find some [options] ? ( https://gna.org/bugs/?24478 )
20160302 08:01:33< vultraz> A New Land mp scenario
20160302 08:01:44< Aginor> ok
20160302 08:01:58< Aginor> thanks
20160302 08:03:11< Aginor> ...
20160302 08:03:15< Aginor> where do I find that?
20160302 08:03:29< vultraz> go to Multiplayer -> Local Game
20160302 08:03:35< Aginor> yeah...
20160302 08:03:37< vultraz> look through the list for 4p A New Land
20160302 08:06:14< Aginor> and now when I've found it?
20160302 08:06:23< vultraz> launch it
20160302 08:06:29< vultraz> with AI players for the other sides
20160302 08:06:32< Aginor> yes
20160302 08:06:33< Aginor> ah
20160302 08:06:53< Aginor> is it supposed to have a story screen with graphics?
20160302 08:07:22< vultraz> yes
20160302 08:07:32< Aginor> because that's black at the moment...
20160302 08:08:02< vultraz> oh wait
20160302 08:08:04< vultraz> storyscreen
20160302 08:08:06< vultraz> no graphics
20160302 08:08:14< Aginor> good
20160302 08:08:21< Aginor> I'm still not getting any options though
20160302 08:08:32< vultraz> look in the right click menues
20160302 08:08:36< vultraz> menus 
20160302 08:09:02< Aginor> yeah?
20160302 08:09:33< vultraz> Aginor: right click on your leader and select Help
20160302 08:09:45< vultraz> there are options immediately and on mouseover their backgrounds goes black
20160302 08:10:03< Aginor> ah, thank you
20160302 08:11:03< vultraz> ... the hell. I thought the deprecated WML was removed from ANL :|
20160302 08:11:09< vultraz> yet I'm getting warnings
20160302 08:11:41< Aginor> do you know the entry point in lua for that piece of code?
20160302 08:12:32< vultraz> data/lua/wml/message
20160302 08:15:17< Aginor> gui2::show_wml_message is what I was looking for :)
20160302 08:20:38< irker808> wesnoth: anatoly techtonik wesnoth:master 015cb9b3d93c / SConstruct: SConstruct: Mention how to build Windows installer https://github.com/wesnoth/wesnoth/commit/015cb9b3d93cacd6a46870d70f2f6776dd32db13
20160302 08:20:40< irker808> wesnoth: Sergey Popov wesnoth:master 703d783bad8a / SConstruct: Merge pull request #612 from techtonik/patch-1 https://github.com/wesnoth/wesnoth/commit/703d783bad8a632c808a60f843bbc25484067436
20160302 08:22:32-!- ancestral_ [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 08:24:21-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Remote host closed the connection]
20160302 08:24:21-!- ancestral_ is now known as ancestral
20160302 08:27:08 * Aginor sighs
20160302 08:27:19< Aginor> we need to fix transparency properly in GUI2
20160302 08:28:10< Aginor> I can fix https://gna.org/bugs/?24478 quickly by re-enabling undrawing for the wml_message, but it breaks resize instead
20160302 08:30:05< ancestral> Question
20160302 08:30:16< ancestral> Why support transparency in the dialogs?
20160302 08:30:42< ancestral> (outside of images, naturally)
20160302 08:30:44< ancestral> Does Wesnoth need it?
20160302 08:32:47< ancestral> As far as those credits go, why not just have a solid background and call it a day>
20160302 08:32:52< Aginor> not really, but it's an ingrained part of our UI experience by now
20160302 08:33:16< ancestral> It’s only good if it works
20160302 08:33:52< Aginor> it mostly works, except when I break it because it's tightly coupled with other stuff I'm trying to get rid of
20160302 08:37:37< vultraz> ancestral: transparency is very important
20160302 08:37:42< ancestral> Okay
20160302 08:38:51< vultraz> Aginor: could it be refactored otherwise?
20160302 08:39:03< Aginor> vultraz: too early to tell
20160302 08:39:07< Aginor> I'm trying to read the code
20160302 08:39:12< Aginor> I won't finish this tonight
20160302 08:39:24< Aginor> I had a full-on day today
20160302 08:39:26-!- Kwandulin [~Miranda@p200300760F0BD4AD35EAD11D8A9F84F4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160302 08:42:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160302 08:48:35< zookeeper> celticminstrel, we should close it
20160302 08:51:58< vultraz> I think we should merge it
20160302 08:52:36< vultraz> Give the users choice to decide whether they want wolf names or not
20160302 08:55:07< zookeeper> no, we should not merge a list of assorted mythological wolf names just in case someone wants to give their wolf units random mythological wolf names
20160302 08:55:23< vultraz> I feel our positions are suddenly reversed here :P
20160302 08:56:14< zookeeper> i posit that that's because you have a somewhat simplistic view of our positions :>
20160302 08:57:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 08:59:45< vultraz> Still doesn't explain why wolves have orcish names
20160302 08:59:52< vultraz> how does that make any more sense?
20160302 09:00:01< zookeeper> they don't
20160302 09:00:17< vultraz> look at the diff
20160302 09:00:23< vultraz> -        {ORCISH_NAMES}
20160302 09:00:25< vultraz> +        {WOLF_NAMES}
20160302 09:00:41< zookeeper> err, i mean...
20160302 09:00:45< vultraz> hmm?
20160302 09:02:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160302 09:02:18< zookeeper> no, wolves don't get orcish names. only wolf riders do.
20160302 09:02:23< zookeeper> all wolf-only units have generate_name=no
20160302 09:38:40-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 09:43:21-!- travis-ci [~travis-ci@ec2-54-205-222-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20160302 09:43:22< travis-ci> wesnoth/wesnoth#8702 (master - 703d783 : Sergey Popov): The build has errored.
20160302 09:43:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113063460
20160302 09:43:22-!- travis-ci [~travis-ci@ec2-54-205-222-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20160302 09:49:07-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160302 09:57:07< zookeeper> zombah, do you happen to be the I.H. zombah?
20160302 09:57:43< zombah> zookeeper: hello, no thats not me
20160302 09:58:25< zookeeper> all right, just checking since someone used that nick in an unrelated context in ancient times. nevermind then :P
20160302 10:12:23-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160302 10:12:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160302 10:49:36-!- aeonchild [~aeonchild@defocus/yummy/enchilado] has quit [Quit: Lost terminal]
20160302 10:49:51-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160302 11:21:15-!- irker808 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160302 11:24:21-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160302 11:24:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 11:29:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160302 11:32:49-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has quit [Read error: Connection reset by peer]
20160302 11:42:52-!- irker065 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160302 11:42:52< irker065> wesnoth: ln-zookeeper wesnoth:master d9326e13bfc4 / / (12 files in 5 dirs): Added an "Animate water" toggle to display preferences https://github.com/wesnoth/wesnoth/commit/d9326e13bfc457d2719dedbea9ab8d206ccd4fa3
20160302 11:42:55< zookeeper> vultraz, ^ ready for you to do your thing.
20160302 11:46:15< zookeeper> i used a simple is_water flag to do that because i really don't foresee having to add other kinds of similar flags anytime soon and because it's easy enough to change to a generic flag system anyway if needs be.
20160302 11:56:39< zookeeper> vultraz, and just in case: toggling "animate map" should only enable/disable the "animate water" checkbox, not (also) toggle in on/off
20160302 12:07:47-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has joined #wesnoth-dev
20160302 12:19:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160302 12:40:10-!- travis-ci [~travis-ci@ec2-54-196-97-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20160302 12:40:11< travis-ci> wesnoth/wesnoth#8703 (master - d9326e1 : ln-zookeeper): The build passed.
20160302 12:40:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113100813
20160302 12:40:11-!- travis-ci [~travis-ci@ec2-54-196-97-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20160302 12:51:27-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160302 12:54:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160302 12:54:19-!- wedge010 is now known as wedge009
20160302 13:38:46< zookeeper> the zoom slider under the minimap seems to be broken.
20160302 13:51:49< zookeeper> also, why the heck are many tooltip strings untranslatable in places like data/gui/default/window/preferences/03_display.cfg
20160302 14:13:04-!- snusnu [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160302 14:32:13-!- snusnu [~chris@ext-74.ias.edu] has quit [Quit: Leaving]
20160302 14:44:00-!- irker065 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160302 14:56:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160302 14:58:10-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has quit [Remote host closed the connection]
20160302 15:01:45-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has joined #wesnoth-dev
20160302 15:09:20-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has quit [Read error: Connection reset by peer]
20160302 15:30:03-!- atarocch [~atarocch@151.64.78.59] has joined #wesnoth-dev
20160302 15:44:50< vultraz> zookeeper: please mark them as translatable
20160302 15:47:22< vultraz> zookeeper: I'll add the callback as soon as I'm done working on what I'm working on
20160302 15:48:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 15:49:44< celticminstrel> What source file were the ActionWML handlers in again...
20160302 15:50:30< celticminstrel> Oh, there it is.
20160302 15:56:36< zookeeper> vultraz, so no reason why they weren't? odd oversight
20160302 15:56:49< vultraz> yeah, not sure
20160302 15:56:57< vultraz> probably just copied them over and forgot the markers
20160302 15:57:54< zookeeper> i considered it a possibility that maybe GUI2 explodes if the string length actually changes :p
20160302 16:01:04-!- irker487 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160302 16:01:04< irker487> wesnoth: ln-zookeeper wesnoth:master a695558836ac / src/unit_filter.cpp: Restored name= SUF with a fix to actually make it work https://github.com/wesnoth/wesnoth/commit/a695558836acb6604b97e22fa8d1b5ede02a11e8
20160302 16:01:28< zookeeper> ^ i hope no one minds that i do that, because i aside from that hypothetical problem with a later scenario of a multiplayer campaign played with a translation on or something, i can't find any problems with it.
20160302 16:01:37< celticminstrel> Eh.
20160302 16:01:59< zookeeper> i even hacked a translation to make two units have the exact same name, but the filter still matched only the correct one.
20160302 16:01:59< celticminstrel> I assume u.name() returns t_string?
20160302 16:03:02< zookeeper> i doubt the comparison would make sense otherwise
20160302 16:05:16-!- Kwandulin [~Miranda@p200300760F0BD49FE5C31BE169F4A6CB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160302 16:10:29-!- gfgtdf [~chatzilla@f050182040.adsl.alicedsl.de] has joined #wesnoth-dev
20160302 16:10:39< gfgtdf> zookeeper: whats teh reason for laoowing name= in unit fitlers ?
20160302 16:12:35< gfgtdf> allowing*
20160302 16:13:35< celticminstrel> Hmm, the wiki says that invalidate_on_tod_change implies invalidate_on_turn_start, but it seems to me that turn start would happen more often than tod_change (assuming tod_change refers to the numeric bonus).
20160302 16:13:47-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160302 16:14:00< celticminstrel> Anyone agree/disagree?
20160302 16:14:28-!- Lohengramm_ [sid1929@gateway/web/irccloud.com/x-isprwspinenskqqz] has joined #wesnoth-dev
20160302 16:14:59-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 248 seconds]
20160302 16:15:04< gfgtdf> celticminstrel: is this questuion about ai code ?
20160302 16:15:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160302 16:15:33-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-adtjhodchgggyaux] has quit [Ping timeout: 264 seconds]
20160302 16:15:35-!- wedge010 is now known as wedge009
20160302 16:15:37< celticminstrel> Not exactly. It's about AI, yes, but something that was never actually implemented fully.
20160302 16:15:43< celticminstrel> So there's no code for it.
20160302 16:15:46< zookeeper> gfgtdf, we already discussed that?
20160302 16:15:49< celticminstrel> Just config keys.
20160302 16:16:15< gfgtdf> zookeeper: well afaik you didnt gave me any readon why namy= is a good inthg to have
20160302 16:16:25-!- Lohengramm_ is now known as Lohengramm
20160302 16:16:40-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160302 16:17:41< gfgtdf> zookeeper: and i still sdont see why we shoudl want to have a feature that causes OOS easily if those things could always be done aswell with just id= or role=.
20160302 16:20:29< zookeeper> easily? i can't cause OOS with it no matter what i try. except that multiplayer campaign thing that was untestable. anyway, we should want it because it was clearly intentionally there and there's no reason to remove it when it can just as easily be fixed.
20160302 16:21:01< gfgtdf> zookeeper: will _("name1") match  _("name2") if th3ey are both trasnlated to the same string the current shown language
20160302 16:21:09< zookeeper> no
20160302 16:21:10< gfgtdf> ?
20160302 16:21:12-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 260 seconds]
20160302 16:22:40< gfgtdf> zookeeper: hmm well i guess its not that bad in that then.
20160302 16:22:54< zookeeper> i can't present any existing usecases as justification, when it's pretty much impossible to find them if they exist
20160302 16:24:11< celticminstrel> Yeah, it's not very greppable.
20160302 16:24:50< zookeeper> and if there were existing usecases and the feature was removed, one would just workaround that by putting a [filter_wml] around it, making the removal accomplish nothing but waste someone's time.
20160302 16:24:54< celticminstrel> Incidentally, will _"name" in textdomain A match _"name" in textdomain B?
20160302 16:25:11< gfgtdf> zookeeper: well, i usually assume that people dont use stuff thats not documented in the wiki.
20160302 16:28:03-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 16:29:39< zookeeper> gfgtdf, well, sure
20160302 16:31:36< zookeeper> celticminstrel, nope, won't match (even without any translation going on), which seems correct to me.
20160302 16:31:53< celticminstrel> Agreed.
20160302 16:34:12< zookeeper> and you don't need to worry about it, if someone gets into trouble with it and/or can actually demonstrate a bug, i'll happily deal with it then.
20160302 16:34:15-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160302 16:36:44< zookeeper> i'm just not very receptive to the idea of taking 0-maintenance stuff out (whether documented or not) just because someone thinks there might be a problem on the grounds that no one's painstakingly proven that there can't be.
20160302 16:38:48< celticminstrel> Oh, I just remembered what I wanted to check with ancestral.
20160302 16:38:59< ancestral> Yeah?
20160302 16:39:03< celticminstrel> In my build, the Lua console does not support history.
20160302 16:39:11-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has joined #wesnoth-dev
20160302 16:39:14< ancestral> I hope to have a draft of the trailer done today
20160302 16:39:24< celticminstrel> Pressing the up key says something like "has not been built with GNU history support".
20160302 16:39:33< ancestral> Hmm
20160302 16:39:42< ancestral> How do you access the Lua console?
20160302 16:39:55< celticminstrel> (Note that the Lua console also scrolls to the top every time the text changes, so you need to scroll down every time you do something.)
20160302 16:40:01< celticminstrel> Via the gamestate inspector.
20160302 16:40:11< ancestral> I know nothing
20160302 16:40:19< ancestral> What are the instructions?
20160302 16:40:50< celticminstrel> Start a game. Type ;debug<enter> ;inspect<enter>. Click "Lua Console" at the bottom right.
20160302 16:42:18< gfgtdf> celticminstrel: yoiu can also just press '^' to open te lua console
20160302 16:42:25< celticminstrel> I did not know that. Thanks.
20160302 16:42:30< celticminstrel> Shift-6?
20160302 16:42:31< gfgtdf> celticminstrel: note that you dotn even need dop have debug mode on for this
20160302 16:42:44< gfgtdf> celticminstrel: ah no the key roight under esc
20160302 16:42:52< celticminstrel> Tilde?
20160302 16:42:58< celticminstrel> Shift-tilde?
20160302 16:43:06< gfgtdf> '^' on german layout
20160302 16:43:14< celticminstrel> Well, anyway.
20160302 16:43:17< gfgtdf> no modifers
20160302 16:43:32< celticminstrel> I didn't know there was a direct hotkey for the console.
20160302 16:43:41< celticminstrel> Does it work anywhere outside of a game?
20160302 16:44:00< gfgtdf> celticminstrel: afik yes but it then open te 'game lua kernel'
20160302 16:44:09< celticminstrel> ?
20160302 16:44:18< ancestral> celticminstrel: I see the Lua Console
20160302 16:44:19< gfgtdf> celticminstrel: the 'game lua kernel' is feature simplemented by iceiceice mainly for the mp unittest bots
20160302 16:44:33< celticminstrel> Do you mean "application Lua kernel"?
20160302 16:44:46< gfgtdf> celticminstrel: ah yes that what i meant
20160302 16:44:55< gfgtdf> celticminstrel: the game lua kernel is the normal lua kernel inte game
20160302 16:45:07< ancestral> celticminstrel: Okay I’m there. Now what?
20160302 16:45:23< gfgtdf> celticminstrel: the lua consle currently ony supports hitsory if you use the gnu history library
20160302 16:45:30< celticminstrel> ancestral: Okay, type a command in (like, I dunno, "print(3 + 5)"). Press enter, then the up key.
20160302 16:45:31< gfgtdf> celticminstrel: this is actualy not very opimal
20160302 16:45:35< celticminstrel> Scroll down if necessary.
20160302 16:45:50< ancestral> Same error
20160302 16:45:57< gfgtdf> celticminstrel: speailyl since the gnu history library doesnt support unicode characters in filepaths on windows afaik
20160302 16:45:59< ancestral> History is disabled
20160302 16:46:14< ancestral> How does one go about enabling it?
20160302 16:46:18< celticminstrel> gfgtdf: Optimal or not, if the GNU history library is required, then I have to wonder why we aren't set up to build against it.
20160302 16:46:19< gfgtdf> celticminstrel: it would be nicec it if woudl be changes to use somethign liek just vector<string> or something
20160302 16:46:30< celticminstrel> Hmm.
20160302 16:46:41< ancestral> So it needs to be part of the build process
20160302 16:47:19< gfgtdf> celticminstrel: the scolling bug is mostlikeley related to gui2 internals
20160302 16:47:28< gfgtdf> celticminstrel: i mean thats not the only place iwth that problem
20160302 16:47:31< celticminstrel> Does the Windows build include GNU history?
20160302 16:47:43< celticminstrel> gfgtdf: Uhh, I don't think that makes sense.
20160302 16:47:44< gfgtdf> celticminstrel: iirc the gui2 chat window in the mp lobby has the same scrolling problem
20160302 16:48:00< gfgtdf> celticminstrel: what doesnt make sense?
20160302 16:48:12< celticminstrel> That the scrolling bug is related to GUI2 internals.
20160302 16:48:40< celticminstrel> If you replace the text of a scrolling widget, it makes sense for it to scroll to the top, because there's no guarantee that the old scroll position is still valid.
20160302 16:48:58< celticminstrel> A dialog like the Lua console should be explicitly readjusting the scroll position every time the text is updated.
20160302 16:49:17< ancestral> Yeah, please fix the chat log too
20160302 16:49:32< celticminstrel> Something like (pseudo-code) output.set_text(old_text + new_text); output.scroll_to_bottom();
20160302 16:49:47< gfgtdf> celticminstrel: hmm no i personalyl think the scrolling label shodul have a function append text adn 'insert text at' not just  'set_text'
20160302 16:50:17< celticminstrel> Maybe it should, but the lack of such a function shouldn't be the considered the cause of this kind of scrolling bug.
20160302 16:50:30< ancestral> celticminstrel: https://wiki.wesnoth.org/CompilingWesnoth
20160302 16:50:48< ancestral> “If you are on linux or OS X you probably already have this, as readline is a dependency of the bash shell -- however you will need to install "readline-dev" or equivalent to get the matching header.”
20160302 16:51:32< celticminstrel> I see.
20160302 16:51:35< gfgtdf> celticminstrel: well but then all function that want to inser teyt will mostlikeley have to deal with text sizes or related.
20160302 16:51:51< celticminstrel> Why would they have to deal with text sizes?
20160302 16:52:07< ancestral> Let’s see if homebrew has it
20160302 16:52:29< gfgtdf> celticminstrel: well you said it'd have to set the new positoin to 'old_text + new_text'
20160302 16:52:50< celticminstrel> No, that's not the position, that's the content.
20160302 16:52:54< ancestral> Okay, it does, and libedit does the same thing, which we have so
20160302 16:53:08< celticminstrel> libedit what now
20160302 16:53:10-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has quit [Remote host closed the connection]
20160302 16:53:19< gfgtdf> celticminstrel: ah ok
20160302 16:53:24< ancestral> “OS X provides the BSD libedit library, which shadows libreadline.”
20160302 16:53:35< gfgtdf> celticminstrel: still at lest for the mp chat indow part it shouldnt always scroll to bollon i think
20160302 16:53:41< celticminstrel> I see.
20160302 16:53:49< gfgtdf> celticminstrel: it shodul just scroll to the bollom it if was already at te bollom previousoly
20160302 16:54:04< gfgtdf> celticminstrel: otherwise you'll have no change to real previous message if new ones come fast
20160302 16:54:10< gfgtdf> chance*
20160302 16:54:11-!- danni [~quassel@203-206-161-81.perm.iinet.net.au] has joined #wesnoth-dev
20160302 16:54:50< celticminstrel> gfgtdf: Yeah, that would be ideal, but I'd prefer it to be forcing me to the bottom as new text comes than forcing me to the top.
20160302 16:55:07< gfgtdf> celticminstrel: hmm yes sure.
20160302 16:55:10< ancestral> gfgtdf: If it were up to me, whenever I enter the log, I feel like it should scroll to the most recent chat, and keep doing it, until I change the position in the log, and then it should maintain the position in the log
20160302 16:55:35< ancestral> (Unless I scroll to the very end again, in which case, it should update and show the newest messages again)
20160302 16:55:43< ancestral> (going forward)
20160302 16:55:48< gfgtdf> ancestral: is that different form what i suggested?
20160302 16:55:54< celticminstrel> I think it's the same.
20160302 16:56:05< ancestral> Ah good
20160302 16:56:17< ancestral> :)
20160302 16:57:02< celticminstrel> I have no implemented invalidate_on_tod_change. It might be a bit different than originally intended though.
20160302 16:57:06< celticminstrel> ^now
20160302 16:57:28< celticminstrel> The wiki claims that it implies invalidate_on_turn_start, but my version doesn't.
20160302 16:57:51< celticminstrel> It only triggers when the actual bonus from the time of day has changed on at least one hex (disregarding illumination).
20160302 16:57:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 16:58:04< gfgtdf> celticminstrel: i think the wiki notive is just based on the ssumption that the tod can onyl change at turn start
20160302 16:58:29< gfgtdf> celticminstrel: which is the case in normal mp maps.
20160302 16:58:45< celticminstrel> Right, which is why it doesn't make sense for it to imply turn_start. Rather, to me it actually makes sense for turn_start to imply tod_change.
20160302 16:58:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 16:58:57< celticminstrel> Should I do that? I'm not sure.
20160302 16:59:15-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds]
20160302 17:00:07< gfgtdf> celticminstrel: hmm but isnt it usualyl thae case that there can be 2 wollowing turns with the same tod ? like norning and afternoon ?
20160302 17:00:22< celticminstrel> In the default schedule, yeah.
20160302 17:01:06< gfgtdf> celticminstrel: then don't think that a change of turn numbers implies a change in tod.
20160302 17:01:35< celticminstrel> I phrased that badly.
20160302 17:02:43< celticminstrel> I don't mean the turn_start event implies the tod_change event. I was wondering if aspects that are invalidated on turn_start should also be invalidated on tod_change... but since both events will normally happen at the same time, I think that would already be the case even without baking it in.
20160302 17:04:16< celticminstrel> Hmm, wasn't there a way for WML/Lua to set the current time of day?
20160302 17:05:10< Ravana_> there is
20160302 17:05:22< ancestral> celticminstrel, vultraz, mattsc, shadowm, noy: At some point (hopefully, in the near future), it would be great if someone could fund a Mac user on the development team for an Apple developer account.
20160302 17:05:27< ancestral> What this does is a couple of things
20160302 17:05:35< celticminstrel> What is it?
20160302 17:05:44< Ravana_> [replace_schedule]
20160302 17:05:49< vultraz> ancestral: talk to Jetrel 
20160302 17:06:00< celticminstrel> Ravana_: That's not quite what I was looking for.
20160302 17:06:03< ancestral> Hey, great idea
20160302 17:06:16< Ravana_> but it has current_time=
20160302 17:06:18 * celticminstrel pings Jetrel_bot since he was mentioned.
20160302 17:06:20< ancestral> 1. It allows packagers to sign with the developer account. This means users won’t be prompted with “you maybe shouldn’t trust this app” when they try to open it
20160302 17:06:34< ancestral> 2. It allows us to publish to the Mac App Store in the future
20160302 17:06:38< celticminstrel> Ravana_: Oh? Hmm... can it be used without replacing the schedule, then?
20160302 17:06:57< Ravana_> no idea, I included {DEFAULT_SCHEDULE}
20160302 17:07:46< ancestral> (I would be more than willing to do this, but I cannot sign up for the developer account, for reasons I wish not to get into, other than, I value my job greatly)
20160302 17:08:05< celticminstrel> Hmm, yeah, that's not quite what I wanted.
20160302 17:09:17< gfgtdf> celticminstrel: if we don't have it yet i'd say we can easily add it
20160302 17:09:39< gfgtdf> celticminstrel: (assuming that you are wroking on wesnoth 1.13 ofc)
20160302 17:09:45< celticminstrel> Yeah, the prerequisite functions are already there in tod_manager, so it would be easy to add.
20160302 17:10:29< celticminstrel> Though I think there may be no point in doing so...
20160302 17:10:44< gfgtdf> celticminstrel: i thought you asked for it
20160302 17:11:24< celticminstrel> Well, sort of.
20160302 17:11:38< ancestral> (Anyway, I am pretty sure of the steps if someone has questions.)
20160302 17:11:41< celticminstrel> I thought it already existed and was considering adding something to it.
20160302 17:12:15< celticminstrel> Actually adding it would have to deal with the complication that the tod_manager recalculates the current time index every turn.
20160302 17:12:31< Ravana_> if there is immediate need I guess wesnoth.get_time_of_day could be used to get info to construct new time of day that acts like previous one
20160302 17:13:03< celticminstrel> I think.
20160302 17:14:02 * celticminstrel is looking at the math right now.
20160302 17:14:05< vultraz> ancestral: conflict of interest?
20160302 17:14:12< ancestral> Basically
20160302 17:14:22< vultraz> ah
20160302 17:14:29< ancestral> ;-)
20160302 17:15:06< celticminstrel> I'm pretty sure I have an Apple dev account, but I think simply having an account isn't sufficient to get the signing and stuff.
20160302 17:15:18< ancestral> It appears we could just create a new Apple ID and list “Wesnoth something” as the business name
20160302 17:15:25< celticminstrel> I mean, I was able to log in and download an old version of XCode, at least.
20160302 17:15:27< vultraz> Wesnoth.inc?
20160302 17:15:56< ancestral> vultraz: Whatever you want it called. Wesnoth Development Team, Wesnoth Software, Wesnoth Inc, LLC, whatever you want it to be called (or legally is)
20160302 17:16:09< vultraz> Wesnoth.inc is the holding company
20160302 17:16:19< ancestral> celticminstrel: You can download Xcode for free without a paid dev account
20160302 17:16:22< vultraz> I'd ask Jetrel_bot whether it already has a dev account
20160302 17:16:25< celticminstrel> There is a company involved?
20160302 17:16:31< celticminstrel> ancestral: Not old versions.
20160302 17:16:40< celticminstrel> Well, you don't need a paid account though.
20160302 17:16:43< ancestral> I mean, you can type something into the business name field
20160302 17:16:58< vultraz> celticminstrel: well it exists. it doesn't do much besides hold the funds
20160302 17:16:59< ancestral> The business name field is what you can choose to show on the App store and on signed apps
20160302 17:17:08< ancestral> Instead of the account’s person’s name
20160302 17:18:28< ancestral> There is another type of account, an Enterprise Development Account, which we do not want or need; this is if you are designing apps in house for download on the Intranet
20160302 17:19:05< celticminstrel> Okay, I think I was wrong. It does always advance the current time rather than setting it on turn start.
20160302 17:19:16< celticminstrel> So I'll go ahead and add that.
20160302 17:23:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160302 17:23:06-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160302 17:25:59-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160302 17:35:16-!- Nobun [~nobun@host208-90-dynamic.50-82-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160302 17:38:59< irker487> wesnoth: ln-zookeeper wesnoth:master bc8c973a5364 / data/gui/default/window/preferences/ (01_general.cfg 03_display.cfg 05_multiplayer.cfg): Added some missing translation markers for preferences tooltips https://github.com/wesnoth/wesnoth/commit/bc8c973a53644985734ee7048d277dc8d5a2361d
20160302 17:53:41-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 17:55:10-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 18:10:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 18:16:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 18:18:57-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160302 18:21:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160302 18:24:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 18:35:43-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 18:39:57-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Client Quit]
20160302 18:52:29-!- Kwandulin [~Miranda@p200300760F0BD49FE5C31BE169F4A6CB.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160302 19:00:44-!- danni_ [~quassel@203-206-161-81.perm.iinet.net.au] has joined #wesnoth-dev
20160302 19:07:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 19:08:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 19:14:43-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160302 19:27:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160302 19:27:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160302 19:34:58-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160302 19:35:08-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160302 19:36:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160302 19:41:17< celticminstrel> It seems that the loading screen doesn't redraw properly after putting up a WML error or similar.
20160302 19:41:20< celticminstrel> Aginor: ^
20160302 20:21:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160302 20:30:43-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160302 20:36:20-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160302 20:37:43< celticminstrel> Is there any particular reason why the unit test flag is not on the Wesnoth man-page?
20160302 20:38:32< celticminstrel> If there's no reason, I'll go ahead and add it.
20160302 20:38:38< celticminstrel> Anyone?
20160302 20:39:05-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 20:39:30-!- irker487 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160302 20:42:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 20:44:41-!- irker902 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160302 20:44:41< irker902> wesnoth: Celtic Minstrel wesnoth:master 13d52154fc7e / doc/man/wesnoth.6: Add missing --noaddons and -u flags to manpage https://github.com/wesnoth/wesnoth/commit/13d52154fc7ed619d003c4cf7b9d6e93153de37c
20160302 20:46:48< celticminstrel> Someone should probably also go through and check if any other flags are missing.
20160302 20:46:57< celticminstrel> (Or obsolete, for that matter.)
20160302 20:47:35-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160302 20:59:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 21:03:02< vultraz> blagh
20160302 21:03:04< vultraz> dammit
20160302 21:03:10< celticminstrel> ?
20160302 21:03:15< celticminstrel> BTW, when does string-freeze happen?
20160302 21:03:21< vultraz> everything is working, but I forgot to deal with the listbox >_>
20160302 21:03:22< celticminstrel> vultraz, loonycyborg: ^
20160302 21:03:37< vultraz> celticminstrel: I dunno, let's say 48 hours
20160302 21:05:20< celticminstrel> 48 hours is Friday.
20160302 21:05:54< vultraz> yes
20160302 21:06:00< vultraz> I meant 48 hours prior
20160302 21:06:02< vultraz> sorry
20160302 21:06:06< celticminstrel> Oh. So basically, right now.
20160302 21:06:10< celticminstrel> -ish
20160302 21:06:10< vultraz> yes
20160302 21:06:19< vultraz> gimme a few hours to get this feature in
20160302 21:06:28< celticminstrel> What feature?
20160302 21:06:39< vultraz> https://gna.org/bugs/index.php?24244
20160302 21:06:49< vultraz> I'm making it so it just opens prefs to the friends list section onstead
20160302 21:06:51< vultraz> instead
20160302 21:06:57< vultraz> but I did want to ask you about syntax
20160302 21:07:02< celticminstrel> That should probably wait until 1.13.4.
20160302 21:07:11< vultraz> not really
20160302 21:07:14< celticminstrel> Why>
20160302 21:07:15< vultraz> I have it 99% done
20160302 21:07:16< celticminstrel> ^?
20160302 21:07:22< celticminstrel> Hmm.
20160302 21:07:43< celticminstrel> Well, I guress it is filed as "Bug" and "Important".
20160302 21:07:51< celticminstrel> ^guess, is 
20160302 21:07:54< vultraz> ok, so, command line command wise, this is how it is now:
20160302 21:08:01< vultraz> ;list - lists all friends
20160302 21:08:04< vultraz> ;friend - lists friends
20160302 21:08:08< vultraz> ;ignore - lists ignore
20160302 21:08:17< vultraz> ;friend nick - add 'nick' as a friend
20160302 21:08:28< vultraz> ;ignore nick - add 'nick' as an ignore
20160302 21:08:37< vultraz> proposed behavior:
20160302 21:08:41< vultraz> ;list - open prefs
20160302 21:08:52< vultraz> ;friend - warning about no nick provided, direction to use ;list
20160302 21:08:57< vultraz> ;ignore (likewise)
20160302 21:09:05< vultraz> and the last two no change
20160302 21:09:30< celticminstrel> When you say "open prefs" I assume you mean directly to the friends list.
20160302 21:10:12< celticminstrel> I think ;list is very non-obvious.
20160302 21:10:37< vultraz> it is
20160302 21:10:41< vultraz> that is, I agree
20160302 21:10:43< celticminstrel> I'd say ;friend and ;ignore with no argument should just open the prefs panel.
20160302 21:11:13< vultraz> and remove ;list?
20160302 21:11:42< celticminstrel> If you want.
20160302 21:11:59< vultraz> ok
20160302 21:12:01< vultraz> will do that
20160302 21:15:13< shadowm> ancestral: Why do you say "a Mac user" when the only one for whom (1) is useful is you?
20160302 21:16:05< vultraz> [04:07:46]	ancestral	(I would be more than willing to do this, but I cannot sign up for the developer account, for reasons I wish not to get into, other than, I value my job greatly)
20160302 21:16:06< ancestral> I may not be a packager forever
20160302 21:16:07< vultraz> that's why
20160302 21:16:11< shadowm> celticminstrel, vultraz: There's no string-freeze for alpha releases.
20160302 21:16:15< celticminstrel> Oh.
20160302 21:16:19< vultraz> Oh, right
20160302 21:16:20< celticminstrel> Okay, sorry.
20160302 21:17:30< shadowm> ancestral: Well, suppose we get legal to fund your account and then you get hit by a bus. Can we transfer the signing permissions or whatever to someone else without having to pay 100 USD again (that was the amount, right?)?
20160302 21:18:16< vultraz> shadowm: why not just have wesnoth.inc sign it 
20160302 21:18:22 * ancestral scratches his head
20160302 21:18:26< shadowm> vultraz: Wesnoth Inc.
20160302 21:18:31< ancestral> shadowm: Someone can create an account
20160302 21:18:34< shadowm> vultraz: I have no idea.
20160302 21:18:37< ancestral> Someone can create a password for the account
20160302 21:18:42< ancestral> Someone can generate the signing key
20160302 21:18:54< ancestral> With the appropriate file, it can be distrubted to a packager
20160302 21:18:56< shadowm> Is that someone allowed to share that password with you?
20160302 21:19:24< shadowm> I've often seen in ToS for other sites that you are forbidden from sharing your account through any means.
20160302 21:19:49< shadowm> Normally I wouldn't care much  but since Apple and money are involved...
20160302 21:19:51< ancestral> So, here’s how it works normally. Person X works at large Corporation Y.
20160302 21:20:25< ancestral> Person X builds the software. Corporation Y says go ahead and get a developer key. Here’s $100.
20160302 21:20:38< ancestral> That key can be shared with other builders
20160302 21:21:07< shadowm> So essentially anyone can use that key with any account (including in the event that the key gets compromised)?
20160302 21:21:17< ancestral> shadowm: I asked in #frogatto like a year or two ago; you can choose to have the key on multiple computers
20160302 21:21:29< ancestral> I think it works like GitHub
20160302 21:21:36< ancestral> You can revoke the key and generate a new one
20160302 21:21:59< ancestral> I don’t know the speicifcs; maybe crimson_penguin or someone else has more working knowledge
20160302 21:22:15< ancestral> I am probably not the best to answer these questions, shadowm
20160302 21:22:42< shadowm> Okay then. Ask Jetrel like vultraz suggested since he's more closely involved with the finances team and can also probably answer all the questions they'll ask for you.
20160302 21:23:11< shadowm> s/team/"team"/
20160302 21:23:26< ancestral> Will do
20160302 21:24:20< ancestral> Just trying to avoid this kind of thing: https://support.apple.com/library/content/dam/edam/applecare/images/en_US/osx/unidentified_developers.png
20160302 21:25:00< celticminstrel> I assume that can still be disabled in System Prefs though.
20160302 21:25:02< shadowm> I wonder if signing our Windows installer too would protect us against AV false positives on NSIS installers.
20160302 21:25:33< ancestral> celticminstrel: It can, but many people won’t (and may have good reason not to)
20160302 21:25:44< ancestral> (You can control-click and choose open to do a one-time override)
20160302 21:27:59-!- Nobun [~nobun@host208-90-dynamic.50-82-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160302 21:37:30-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160302 21:46:53-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160302 22:01:39-!- Appleman1234 [~Appleman1@KD106161154196.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20160302 22:04:44< gfgtdf> shadowm: do you know why we disallow overrwing the version here https://github.com/wesnoth/wesnoth/blob/master/src/wesconfig.h#L37 ?
20160302 22:05:11< gfgtdf> shadowm: i'd think that beeing able to overwtire the version with a macro is useful when realeasing things like 1.12.4a
20160302 22:12:24-!- atarocch [~atarocch@151.64.78.59] has quit [Remote host closed the connection]
20160302 22:15:25< gfgtdf> shadowm: also since we will need the RC_VERSION_MAJOR/MINOR always i wonder whether it might be better define VERSION  by using VERSION_MAJOR/MINOR like in #define VERSION #VERSION_MAJOR "." #VERSION_MINOR "." #VERSION_REVISION VERSION_POFIX
20160302 22:16:15< shadowm> gfgtdf: First question: because that was important back when we supported building with the GNU autotools build system.
20160302 22:17:12< gfgtdf> shadowm: hmm so its just namein conflicts with other tools using a VERSION macro for versions of other things ?
20160302 22:17:17< shadowm> 1.12.4a is a bad example of what you want to do, because it didn't involve any changes to the wesnoth.exe binary.
20160302 22:17:27< shadowm> Yes.
20160302 22:17:53< shadowm> Second question: the version used for the Win32 resource file is actually one ahead for non-release versions.
20160302 22:18:01< gfgtdf> shadowm: well it invloves a change to wesnoth version string which is a part of the wesnoth binary.
20160302 22:18:04< shadowm> See the third bullet under here: https://wiki.wesnoth.org/ReleasingWesnoth#Release_tasks
20160302 22:18:49< shadowm> Maybe rc and windres can evaluate expressions but I don't really feel it's that important to bother checking.
20160302 22:19:08< shadowm> After all, only the release team ever needs to bother changing this file.
20160302 22:19:40< shadowm> Again, 1.12.4a didn't involve any changes to wesnoth.exe. It was just a couple of DLLs.
20160302 22:20:16< gfgtdf> shadowm: hmm so the title of the widow still shows 1.12.4 instead of 1.12.4a ?
20160302 22:20:22< shadowm> Yes.
20160302 22:20:34< gfgtdf> shadowm: hmm didnt know that
20160302 22:21:24< gfgtdf> shadowm: do the packagers like loonycyborg upload the installer to sourcefoge themselves?
20160302 22:21:41< shadowm> Yes.
20160302 22:22:26< shadowm> Tier 1 packagers do that, that is.
20160302 22:22:40< gfgtdf> shadowm: wha does 'tier 1' mean ?
20160302 22:22:49< shadowm> Our tier 1 platforms (which we support directly as part of the project) are Windows, OS X, and OpenPandora.
20160302 22:23:28< shadowm> The fact that e.g. Debian GNU/Linux isn't a tier 1 platform doesn't mean that it's unsupported, just that we don't do the packaging ourselves.
20160302 22:23:38< gfgtdf> shadowm: i thought we droppe dopenpandora becsue it had problems with the newer dependencies (boost (any maybe sdl2)) ?
20160302 22:23:53< shadowm> OpenPandora is still supported for 1.12.x.
20160302 22:25:20< gfgtdf> loonycyborg: do you use the binaries generated by jenkins  for the releases ?
20160302 22:25:27< loonycyborg> no
20160302 22:25:36< ancestral> I’d like to one day
20160302 22:25:39< loonycyborg> I boot from my winxp partition and build them therre
20160302 22:26:06< shadowm> ancestral: But Jenkins can't build for OS X yet or can it?
20160302 22:26:07< gfgtdf> loonycyborg: is there a reason against using them ?
20160302 22:26:46< loonycyborg> yes, I trust actual mingw releases more
20160302 22:27:00< loonycyborg> debian/gentoo cross toolchains may lack some patches
20160302 22:27:25< shadowm> Patches to gcc and libstdc++ you mean?
20160302 22:27:46< ancestral> There’s a way with homebrew, just haven’t hammered out all the details
20160302 22:27:58< gfgtdf> loonycyborg: the idea was that, in order to mkae the automatic updater woirk, we coudl maybe configure jenns to always store a the files the 'latest' release permantly so when generateing a diff for the updater it could automatically generate it.
20160302 22:28:18< ancestral> Something I want to explore after 1.13.3
20160302 22:28:22< loonycyborg> yes, patches to gcc and mingw-runtime
20160302 22:30:00< loonycyborg> gfgtdf: that's definitely a possibility, yes
20160302 22:30:19< loonycyborg> but
20160302 22:30:31< loonycyborg> we're already storing all releases on sf indefinitely
20160302 22:31:40< gfgtdf> loonycyborg: well the idea was to oynl soter the 'latest' release which and as sson as wegenerated the diff from that one and a newwer one we replace it with the newer one
20160302 22:32:50< gfgtdf> loonycyborg: im not 100% sure but i dont think that 400mb would be that much.
20160302 22:33:02< gfgtdf> loonycyborg: the wesnoth-1.12.4.tar.bz2 is are the source or the binary files ?
20160302 22:33:10< loonycyborg> source
20160302 22:35:47< gfgtdf> loonycyborg: you know what teh state of progress of the window patch installer is ?
20160302 22:36:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 22:36:23< loonycyborg> didn't hear from the guy who was making it lately
20160302 22:38:10< gfgtdf> loonycyborg: the point is that when i work on the updater i dont really want to learn nsis lanugage, because i think downloading and unpacking a zip fiel looks liek something thats easy on every other language lie c++ or c# too.
20160302 22:39:08< loonycyborg> working with nsis is unavoidable since you need to update registry and shortcuts too
20160302 22:39:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160302 22:41:20< gfgtdf> loonycyborg: can'T we just remove the minor (thirs)version number form the shortcuts ? I mean i don't think that any other game i know has those in their shortcuts names.
20160302 22:42:11< gfgtdf> third*
20160302 22:42:46< loonycyborg> I guess we can
20160302 22:45:37< loonycyborg> but I'm considering to push the update task on someone else
20160302 22:45:41< loonycyborg> like steam :P
20160302 22:46:40< loonycyborg> because the more I think about it the more wesnoth's own autoupate mechanism looks like reinvented wheel to me
20160302 22:47:50< gfgtdf> loonycyborg: well, it sure is.
20160302 22:48:09< gfgtdf> loonycyborg: but im not really sure whether we are on steam or alike soon
20160302 22:48:16< shadowm> 1) Not everyone will use Steam; 2) It's not guaranteed that we'll be on Steam in any given time frame.
20160302 22:48:50< loonycyborg> I recently found fully opensource GPL'd game, endless sky, it's on steam too
20160302 22:49:08< loonycyborg> so at least it's possible
20160302 22:49:10< shadowm> It not only depends on whether and when we land on the Greenlight program, it also depends on the reception.
20160302 22:49:18< gfgtdf> loonycyborg: i just think that we really need an automatic updater, specialyl because or offical deve releases often have bug that break a lot of things but are very easy to fix
20160302 22:49:30< loonycyborg> but anyway steam was only example
20160302 22:49:33< shadowm> It's true that it'll probably be positive, but I wouldn't bet the availability of a major feature on it.
20160302 22:49:44< loonycyborg> there gotta be other infrastructures we could reuse
20160302 22:51:22< gfgtdf> loonycyborg: for exampel bugs liek this https://github.com/wesnoth/wesnoth/commit/ffe5cd44e358f9537148528e8794cdacee67b666, which basically break [endlevel] in some cases.
20160302 22:52:14< shadowm> Also, we'll want to fix any important bugs found by Greenlight testers _before_ officially launching on Steam anyway (because otherwise we'd just come off as an incompetent crew and damage the project's reputation further), so that's another indeterminate amount of time to add between Greenlight approval and official submission.
20160302 22:53:18< shadowm> For example, if people watching us through Greenlight feel too strongly about lack of high DPI support then we have no option but to fix that before submitting.
20160302 22:53:56< shadowm> If they feel that the game sucks because it can't make coffee then we have no option but to add HTCPCP support too.
20160302 22:55:14< celticminstrel> What. XD
20160302 22:56:05< ancestral> shadowm: Yes, fix bad things before a release.
20160302 22:56:16< ancestral> (wide release on Steam)
20160302 22:56:18< shadowm> It sounds extreme but it illustrates my concerns about getting on Steam and exposing us to a far more vocal audience.
20160302 22:56:42< ancestral> Better ratings means more developers, more happy players
20160302 22:57:24< shadowm> It's a 180° turn from Wesnoth's historical project mentality, "the game is made by developers for developers (who almost never play the game)".
20160302 22:57:26< loonycyborg> will they give us free access to all games like to debian developers? :P
20160302 22:57:30< celticminstrel> By the way, someone said the whiteboard is being removed. Is this true?
20160302 22:57:40< celticminstrel> Not that I care personally about it.
20160302 22:58:13< ancestral> I remember a developer years ago saying he didn’t want more people contributing to the project because it would become unmanageable
20160302 22:58:16-!- Appleman1234 [~Appleman1@KD106161138231.au-net.ne.jp] has joined #wesnoth-dev
20160302 22:58:25< shadowm> Very early last year I proposed removing it if no-one could fix all the (mostly technical) problems permeating it.
20160302 22:58:40< celticminstrel> Ah.
20160302 22:58:42< shadowm> I believe I suggested polling the audience first.
20160302 22:59:18< shadowm> ancestral: Sure, what we need right now is more capable people, but not necessarily _more_ people.
20160302 22:59:43< ancestral> Right, I just don’t think we get one without the other
20160302 22:59:47< shadowm> It would indeed become unmanageable if we had two dozen C++ coders each trying to do things their own way.
20160302 23:00:20< ancestral> Adapt or die
20160302 23:00:22< loonycyborg> even having silene and mordante at the same time was unmanageable
20160302 23:00:32< shadowm> It would also be very unmanageable if we had two super-capable C++ coders managing this colossal codebase in their spare time.
20160302 23:00:41< shadowm> *only two
20160302 23:01:43-!- louis94 [~~louis94@91.178.241.197] has joined #wesnoth-dev
20160302 23:02:08< loonycyborg> but I think exact number of people is irrelevant as long as they each have own area of work
20160302 23:02:40< loonycyborg> like old saying goes if compiler writing team has 3 developers then it'll result in 3 pass compiler
20160302 23:02:50< shadowm> Except that someone needs to keep an eye on them, and keeping an eye on more than a dozen people is nearly impossible.
20160302 23:03:10< shadowm> Unless you start designating sub-officials in charge of keeping an eye on smaller groups of people.
20160302 23:03:27< shadowm> Then it starts to feel more like a corporate business than a hobbyist open-source project. :\
20160302 23:03:34< shadowm> (And that's terrible.)
20160302 23:04:59< loonycyborg> If Linus did it then we can too :P
20160302 23:04:59< ancestral> Alright, time to restart and finish that trailer
20160302 23:05:27< gfgtdf> celticminstrel: i didnt hear of whiteboard beeing removed
20160302 23:05:37< gfgtdf> celticminstrel: and i really thign it should be removed
20160302 23:06:16< ancestral> I remember how awful it was to accidentally turn on planning mode and not know how to turn it off
20160302 23:07:13< shadowm> loonycyborg: ... Yes. And guess what Linux isn't anymore.
20160302 23:07:27< celticminstrel> I know that feeling. Not sure if I've done it with planning mode, but it has happened with other things. I think fullscreen mode in Firefox, for example.
20160302 23:07:45< loonycyborg> shadowm: pretty sure it still is fun hobby for some people
20160302 23:07:48< gfgtdf> ancestral: well yes but i also know hot useful it is to have the option too looks at a unit 'like it were there'
20160302 23:08:26< shadowm> loonycyborg: I rather doubt it. Most major contributors are obviously hired by companies that _need_ Linux.
20160302 23:09:01< loonycyborg> that doesn't mean they don't have fun while fucking around with stuff they need :P
20160302 23:09:22< gfgtdf> ancestral: and DSU is definiteley not a good replacement for it since even with DSU you sometimes cannot undoa  move (whie when trigggering an ambushed unit or an event) and also i feel like >50% of the OOS bugs i fixed in teh past are related to DSU
20160302 23:09:22< shadowm> BUT IT'S FOR BUSINESS PURPOSES.
20160302 23:09:22< ancestral> gfgtdf: I changed the hotkey on my system to shift+P
20160302 23:09:40< shadowm> It's their full-time jobs.
20160302 23:09:43< ancestral> gfgtdf: What’s DSU?
20160302 23:09:50< gfgtdf> ancestral: dleayed shroud updates
20160302 23:09:53< gfgtdf> delayed*
20160302 23:09:54< ancestral> Ah
20160302 23:10:35< celticminstrel> Okay, is gfgtdf saying it should be removed, or is he saying it shouldn't be removed...
20160302 23:10:37< loonycyborg> yes, perhaps wesnoth should go the same way, employ some contributors fulltime
20160302 23:11:01< gfgtdf> celticminstrel: y my bad, i meant it shodul NOT be removed
20160302 23:11:15< celticminstrel> Maybe you could do some work on it, then?
20160302 23:11:39< celticminstrel> And speaking of planning mode, should PR559 be included in 1.13.3?
20160302 23:11:47< shadowm> loonycyborg: I'm tired of explaining why that would never work finances-wise.
20160302 23:12:15< loonycyborg> there are ways to raise finances, like patreon or targeted funraisers
20160302 23:13:12< shadowm> Well, if you want to do this full-time, then it's your choice.
20160302 23:13:33< loonycyborg> https://www.patreon.com/bay12games?ty=h
20160302 23:13:41< loonycyborg> dwarf fortress for example
20160302 23:13:58< shadowm> Me? I've invested so much time and energy on this piece of crap for free and received so much abuse from users and developers in exchange that I'm not interested on a deal like that.
20160302 23:14:09< loonycyborg> already 4000 per month :P
20160302 23:14:23< loonycyborg> and that's not the only source of donations for them
20160302 23:15:06-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: ancestral]
20160302 23:15:24-!- gfgtdf_ [~chatzilla@f050182040.adsl.alicedsl.de] has joined #wesnoth-dev
20160302 23:16:36< celticminstrel> Also, has anyone looked at PR611?
20160302 23:16:44< loonycyborg> shadowm: I assure you that any abuse from me was unintentional :P
20160302 23:16:51-!- gfgtdf [~chatzilla@f050182040.adsl.alicedsl.de] has quit [Ping timeout: 248 seconds]
20160302 23:17:03-!- gfgtdf_ is now known as gfgtdf
20160302 23:17:16-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160302 23:18:05< zookeeper> if DF is two guys then that's... quite a bit different. they can just raise money and split it, no problem.
20160302 23:20:42< shadowm> celticminstrel: The code is a bit weird.
20160302 23:21:54< ancestral> All I know is, if things don’t feel good, maybe it’s worthwhile trying something different.
20160302 23:21:58< shadowm> They explicitly call the iterator pair constructor with begin and end instead of just copying the string (which could even be achieved by declaring it as such in the parameter list).
20160302 23:22:08< celticminstrel> Sorry, that's my fault.
20160302 23:22:27< celticminstrel> But if you look at the first commit, it was even worse.
20160302 23:22:49< shadowm> And why does the new function even need to exist?
20160302 23:23:19< shadowm> Just copy the string in the caller (and there's only ONE caller it seems) and call replace_space2underbar() on the caller's copy?
20160302 23:23:37< shadowm> That's how I'd do it anyway, I'm not a fan of single-use minifunctions.
20160302 23:26:23< shadowm> The original version is...
20160302 23:27:06< shadowm> Like, um, they went to the trouble of using std::copy to create a copy of another copy.
20160302 23:27:30< celticminstrel> And copied it to an empty string without using an insert iterator.
20160302 23:27:57< shadowm> Oh right, it's going to go boom on the first insertion.
20160302 23:28:24< shadowm> (In the best case, anyway. Worst case is it'll overwrite something else.)
20160302 23:29:15< shadowm> Should I post to the thread about the current version?
20160302 23:29:26< celticminstrel> Sure.
20160302 23:33:22-!- mjs-de [~mjs-de@x5ce3322e.dyn.telefonica.de] has quit [Remote host closed the connection]
20160302 23:34:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20160302 23:36:09< shadowm> celticminstrel: Actually, do you know what bug this fixes?
20160302 23:36:34< celticminstrel> I think it says in the PR, though I haven't verified that it happens or anything.
20160302 23:37:00< celticminstrel> Something with translations.
20160302 23:37:10< shadowm> Oh, I think I get it.
20160302 23:37:20< shadowm> The "Auto-Save" string is probably translatable.
20160302 23:37:35< shadowm> Yep, it is.
20160302 23:37:54< shadowm> Uh and it's a problem if it has spaces because...
20160302 23:39:01< shadowm> Because...
20160302 23:41:00< shadowm> Actually, what problem does this solve? I really can't tell.
20160302 23:41:32< celticminstrel> He just said max autosaves didn't work, without much explanation.
20160302 23:41:59< shadowm> This is why I always ask people to write proper commit messages.
20160302 23:42:30< gfgtdf> not sure who is repsinsible, but this file https://sourceforge.net/projects/wesnoth/files/SDK/CodeBlocksWinSDK_17_08_2015.zip/download?use_mirror=netassist&r=&use_mirror=netassist seens to be invalid
20160302 23:43:31< shadowm> Tried another mirror?
20160302 23:43:59< gfgtdf> shadowm: hmm no will try
20160302 23:44:32< shadowm> Also, vultraz had me upload a newer version recently.
20160302 23:45:09< shadowm> "CodeBlocksWinSDK_2016_02_14.7z". Not sure if you are looking for the older version because it's needed for 1.12 or it's some kind of historical interest thing.
20160302 23:45:42< gfgtdf> shadowm: no im actualyl just look ing for  a test zip file for the 'download an extract zip file' part of the automatic updater
20160302 23:46:44< shadowm> Oh, okay then.
20160302 23:47:00< shadowm> There are smaller zip files in existence all over the web though. 
20160302 23:47:20< shadowm> Then again, I probably am the only person here for whom file sizes matter.
20160302 23:48:58< gfgtdf> shadowm: well with a small zipfile i couldn't watch see the progressbar of my updater programm growing :)
20160302 23:49:33< shadowm> Good point.
20160302 23:49:37< shadowm> vultraz: Have you or zookeeper looked at this? https://github.com/wesnoth/wesnoth/pull/604
20160302 23:51:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160302 23:51:25-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160302 23:51:34< shadowm> Ah yes I had forgotten that launching my IDE on the Wesnoth codebase is a game of Russian roulette. I was wondering where my IDE window had gone.
20160302 23:52:06< loonycyborg> howso? it crashes or something?
20160302 23:52:10< shadowm> Yep.
20160302 23:52:30< shadowm> And despite being a KDE application, I don't get the usual KDE "this application crashed" thingy.
20160302 23:53:08-!- louis94 [~~louis94@91.178.241.197] has quit [Quit: Konversation terminated!]
20160302 23:53:13< loonycyborg> qtcreator crashed for me too at some point
20160302 23:53:22< loonycyborg> but seems it's fixed now
20160302 23:54:55< celticminstrel> shadowm: zookeeper has looked at it, I think he talked to the submitter and suggested some different organization or something.
20160302 23:55:13< celticminstrel> (They're in #wesnoth )
20160302 23:55:33< shadowm> He should've told them to get in here too. :p
20160302 23:56:53< shadowm> loonycyborg: I use KDevelop, not Qt Creator. I find the latter's text editing component a bit awkward, it doesn't even have an option to highlight tabs.
20160302 23:57:24< shadowm> Or if there is, it's not where it's supposed to be.
20160302 23:58:09< shadowm> There isn't an option to highlight indentation either (yes, there's a difference).
--- Log closed Thu Mar 03 00:00:40 2016