--- Log opened Thu Mar 03 00:00:40 2016
--- Day changed Thu Mar 03 2016
20160303 00:00:40< gfgtdf> shadowm: why do yu want to highlight tabs ?
20160303 00:02:37< shadowm> So that I can tell when people are trying to slip space-based indentation into my code.
20160303 00:03:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 00:03:46< shadowm> And also the other way around.
20160303 00:04:38< shadowm> (Our C++ and GUI2 WML uses 4 column-wide tab indents, all other WML uses 4 space indents.)
20160303 00:06:51< gfgtdf> shadowm: maybe you can just use search to search for tabs and the use the mark function of the search window ?
20160303 00:07:13< celticminstrel> That requires specific action on your part.
20160303 00:07:18< shadowm> ^
20160303 00:08:33< shadowm> celticminstrel: Okay, I just found out that we indeed replace spaces with underscores when writing savegames.
20160303 00:08:58< shadowm> *on the entire final file name
20160303 00:11:22< shadowm> And remove_old_auto_saves() passes the untransformed save suffix as filter, hence the bug.
20160303 00:12:53< gfgtdf> shadowm: i wonder why we do that = i heard that the only reason we disallow spaces in sone cases is that some our servesides tool cannot parse spaces correctly, but i'd think that usually they'd never tough users savefiles
20160303 00:14:09< shadowm> No idea, really. Maybe one of the lesser OSes we used to support (AmigaOS 4, BeOS) didn't support spaces in filenames.
20160303 00:15:12< shadowm> Filenames containing whitespace are a bit inconvenient when working with a POSIX shell but so are most other characters (and length!) found in the saves dir.
20160303 00:15:46< shadowm> Well, not just POSIX. Windows' command prompt also requires you to use quotes around filenames like that.
20160303 00:16:12-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit [Read error: No route to host]
20160303 00:16:59< shadowm> But bear in mind that someone also decided back in 2004 that truncating save file names on disk was the way to make things easier for the UI.
20160303 00:17:30< gfgtdf> shadowm: well the difference is that mostlikely most windows users don't use shells, and if they do they are mostlikeley used to whitespaces specialyl since the "programm files" directoy where all programms are installed already includes a whitepace.
20160303 00:17:42< gfgtdf> shadowm: hmm right
20160303 00:17:49-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160303 00:18:30< gfgtdf> shadowm: i also dont understans why windows did didnt manage to increase the default allowed length of paths.
20160303 00:19:11< shadowm> I assume it's Microsoft's overzealous backwards compatibility practices at work again.
20160303 00:19:16< gfgtdf> shadowm: it once happend to me that i wanted to install a microsoft sql server and the installer crashed with "PathTooLongException"
20160303 00:19:47< shadowm> As I understand it, old Win16 and Win32 applications might have relied on MAX_PATH's manageable value of 260 a bit too much.
20160303 00:20:49< shadowm> If you increased that to the kernel-supported maximum of 2^15 - 1 you'd have a million applications suddenly taking up too much stack space.
20160303 00:21:45< shadowm> Plus I've checked that Windows 9x truly were limited to 260 char paths and didn't support the "length extension" prefix at all.
20160303 00:22:25< shadowm> So that's about 8 additional years of established practice to support I guess.
20160303 00:24:50< gfgtdf> shadowm:  but most functions like GetModuleFileName take the size of the given buffer as third parmaeter
20160303 00:25:28< gfgtdf> shadowm: so i dont see why it break backwards compability snce they'd mostlikeley still just padd 260 there.
20160303 00:25:50< shadowm> Functions that are part of the Win32 API and thus still documented to this day, you mean.
20160303 00:26:29< shadowm> Windows 9x and Windows NT up to and including XP had to deal with the historical baggage of 16-bit Windows apps.
20160303 00:27:50< shadowm> (Technically, Vista and later still have to in their 32-bit builds, but the assumption is that almost everyone has moved away from applications written in the 90s.)
20160303 00:50:25-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has joined #wesnoth-dev
20160303 00:51:26-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160303 00:52:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160303 00:52:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 00:55:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20160303 00:55:21-!- wedge010 is now known as wedge009
20160303 00:58:23-!- travis-ci [~travis-ci@ec2-54-196-97-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20160303 00:58:24< travis-ci> dreamer-88/wesnoth#1 (autosave_fixer - ec682ee : dream-88): The build has errored.
20160303 00:58:24< travis-ci> Build details : https://travis-ci.org/dreamer-88/wesnoth/builds/113267404
20160303 00:58:25-!- travis-ci [~travis-ci@ec2-54-196-97-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20160303 01:17:09< irker902> wesnoth: Ignacio R. Morelle wesnoth:master c548e4a61a91 / src/ (19 files in 7 dirs): New Year copyright update https://github.com/wesnoth/wesnoth/commit/c548e4a61a91d4ce43cab83e117b976741613fc8
20160303 01:24:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160303 01:40:23-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160303 01:51:11-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160303 01:56:54-!- travis-ci [~travis-ci@ec2-54-159-73-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20160303 01:56:55< travis-ci> dreamer-88/wesnoth#2 (master - bc8c973 : ln-zookeeper): The build has errored.
20160303 01:56:55< travis-ci> Build details : https://travis-ci.org/dreamer-88/wesnoth/builds/113267422
20160303 01:56:55-!- travis-ci [~travis-ci@ec2-54-159-73-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20160303 02:15:02-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160303 02:15:53-!- gfgtdf [~chatzilla@f050182040.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160303 02:19:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160303 02:19:30-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Disconnected by services]
20160303 02:19:38-!- Soliton [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20160303 02:23:02-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160303 02:23:47-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 248 seconds]
20160303 02:23:48-!- Appleman1234 [~Appleman1@KD106161138231.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20160303 02:23:48-!- prkc [~prkc@46.166.188.227] has quit [Ping timeout: 248 seconds]
20160303 02:23:48-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Ping timeout: 248 seconds]
20160303 02:23:58-!- nurupo_ is now known as nurupo
20160303 02:24:28-!- prkc [~prkc@46.166.188.227] has joined #wesnoth-dev
20160303 02:47:26-!- Waste [~Cracker@blk-138-75-91.eastlink.ca] has quit [Quit: Leaving]
20160303 02:59:51< irker902> wesnoth: Vasya Novikov wesnoth:master fa7a342c2fe8 / data/core/help.cfg: help.cfg: healing clarification https://github.com/wesnoth/wesnoth/commit/fa7a342c2fe825576c4eeffeb80a3aa30e03dc0c
20160303 02:59:53< irker902> wesnoth: Charles Dang wesnoth:master fbad6bdddd79 / data/core/help.cfg: Merge pull request #604 from vn971/patch-2 https://github.com/wesnoth/wesnoth/commit/fbad6bdddd797ce588c53302320d07b5d908e7fd
20160303 03:06:16< SigurdFD> vultraz: Do any of my PR's need changelog entries?
20160303 03:06:26< vultraz> not as far as I know
20160303 03:06:43< SigurdFD> ok
20160303 03:10:00< vultraz> thanks for doing them, btw
20160303 03:10:28< SigurdFD> you're welcome
20160303 03:10:44< SigurdFD> is HttT still in need of a maintainer?
20160303 03:11:26< vultraz> Yes
20160303 03:11:41< vultraz> It'd be nice if someone where to go through and make the maps a bit more interesting
20160303 03:11:51< vultraz> (this is true for every campaign)
20160303 03:12:09< SigurdFD> I'm thinking about it, but I'll decide when I finish the campaign
20160303 03:13:11< SigurdFD> though so far I've seen things I could do something about. (I just finished Gryphon Mountain)
20160303 03:22:13< SigurdFD> what do mean by 'make the maps more interesting'? Emeblishments & other non-gameplay terrain changes?
20160303 03:23:36-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160303 03:24:55-!- Appleman1234 [~Appleman1@KD106161138231.au-net.ne.jp] has joined #wesnoth-dev
20160303 03:26:13< vultraz> that
20160303 03:26:14-!- Yaiyan_ [~Yaiyan@46.101.48.31] has joined #wesnoth-dev
20160303 03:26:15-!- shikadibot_ [~shikadi@wesnoth/umc-dev/bot/shikadibot] has joined #wesnoth-dev
20160303 03:26:21-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160303 03:26:23< SigurdFD> Ok
20160303 03:26:27-!- clavi [~clavi@163.172.10.77] has quit [Ping timeout: 260 seconds]
20160303 03:26:29-!- Yaiyan [~Yaiyan@46.101.48.31] has quit [Ping timeout: 260 seconds]
20160303 03:26:29-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Ping timeout: 260 seconds]
20160303 03:26:30-!- Rhonda [~rhonda@anguilla.noreply.org] has quit [Ping timeout: 260 seconds]
20160303 03:26:30-!- shikadibot [~shikadi@wesnoth/umc-dev/bot/shikadibot] has quit [Ping timeout: 260 seconds]
20160303 03:26:30-!- _laco [~laco@static.95.25.4.46.clients.your-server.de] has quit [Ping timeout: 260 seconds]
20160303 03:26:32-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20160303 03:26:44< vultraz> but also things like expanding single-hex rivers
20160303 03:26:44< vultraz> more terrain diversity in water
20160303 03:26:44< vultraz> (using the water variants)
20160303 03:26:44< vultraz> different types of villages
20160303 03:26:58< vultraz> different types of castles
20160303 03:27:01< vultraz> different types of forests
20160303 03:27:03< vultraz> etc etc
20160303 03:27:29< SigurdFD> yep, Valley of Death could use some ruined villages as one example.
20160303 03:27:41< vultraz> yes
20160303 03:27:49 * vultraz will be back later
20160303 03:27:54-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: End Transmission.]
20160303 03:31:46-!- Rhonda [~rhonda@anguilla.noreply.org] has joined #wesnoth-dev
20160303 03:34:03-!- clavi [~clavi@163.172.10.77] has joined #wesnoth-dev
20160303 03:39:34-!- _laco [~laco@static.95.25.4.46.clients.your-server.de] has joined #wesnoth-dev
20160303 03:44:16-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160303 04:15:23< celticminstrel> vultraz: I thought we weren't sold on PR604.
20160303 04:24:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 04:29:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160303 05:11:29-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160303 05:41:19-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160303 05:52:37-!- aeth_ is now known as aeth
20160303 06:02:37-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160303 06:13:02-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160303 06:24:37-!- irker902 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160303 06:34:06< vultraz> celticminstrel: it seemed fine
20160303 06:37:27< celticminstrel> I can't really think of anything more to do with the AI stuff, apart from reams of unit tests.
20160303 06:37:53< celticminstrel> Maybe implementing invalidate_on_minor_gamestate_change, but I haven't the slightest idea how and it's probably not very useful anyway.
20160303 06:41:07< celticminstrel> I think I'll open the PR for it now. Obviously it won't be merged until mattsc gets a chance to review it, and I'll probably push a few more commits (and pluck out some that are unrelated to AI).
20160303 06:44:15< celticminstrel> ...oh! I should make recruitment map to recruitment_instructions.
20160303 06:44:58-!- Kwandulin [~Miranda@p200300760F0BD49FF04DD4A897E19871.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160303 06:51:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 06:55:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160303 07:05:49< celticminstrel> Okay, PR created. Needs lots of review and more testing, also some rebasing, but is functional.
20160303 07:06:40-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160303 07:10:44< vultraz> holy shit
20160303 07:10:47< vultraz> that is a huge PR
20160303 07:10:55< celticminstrel> It is, isn't it.
20160303 07:11:40< vultraz> I'm impressed, though
20160303 07:11:44< celticminstrel> Oh?
20160303 07:11:46< vultraz> you cut the relevant code by hald
20160303 07:11:50< vultraz> half
20160303 07:11:59< vultraz> 1,455 additions and 2,809 deletions.
20160303 07:12:08< celticminstrel> I hadn't noticed those stats.
20160303 07:12:22< celticminstrel> Removing the recruitment stage alone was quite a bit.
20160303 07:12:31-!- shikadibot_ is now known as shikadibot
20160303 07:13:09< shadowm> This guide is telling me I'm a Rust programmer now. I only wrote a Hello world program.
20160303 07:15:48-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160303 07:16:02-!- celticminstrel is now known as celmin|sleep
20160303 07:43:28< Aginor> celmin|sleep: please raise a bug about it so we don't forget. Ideally the entire loading screen should be reimplemented to be doing proper redrawing and stuff
20160303 07:54:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160303 07:58:02< zookeeper> shadowm, vultraz, celmin|sleep, yes, #604 was supposed to get a redo as per the last discussion of https://www.wesnoth.org/irclogs/2016/02/%23wesnoth.2016-02-23.log
20160303 08:03:31< shadowm> So was the redo completed before the merge?
20160303 08:04:50< zookeeper> no
20160303 08:05:36< shadowm> How do you feel about this, zookeeper?
20160303 08:06:03< zookeeper> i feel like vultraz will now make sure that the redo will happen before next release one way or another :>
20160303 08:06:53< shadowm> vultraz: As this is a mainline game content change, you should've run this through zookeeper first (or read what celmin said earlier in response to me).
20160303 08:07:11< shadowm> zookeeper: You should've assigned the PR to yourself so vultraz wouldn't have felt inclined to handle it himself with incomplete information.
20160303 08:07:48< zookeeper> agreed
20160303 08:13:44< zookeeper> wait, you can use "or" in place of ||? O___o
20160303 08:14:36< shadowm> and &&, and_eq &=, bitand &, bitor |, compl ~, not !, not_eq !=, or ||, or_eq |=, xor ^, xor_eq ^=
20160303 08:15:11< zookeeper> since when have those been a thing in c++?
20160303 08:15:33< shadowm> To my understanding, C++98 already had this.
20160303 08:15:43-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160303 08:16:42< shadowm> C89 didn't, but a revision published in 1995 added equivalent macros in iso646.h.
20160303 08:16:51< zookeeper> strange
20160303 08:17:01< shadowm> Therefore I assume C++98 is the first version of the C++ standard that has the keywords.
20160303 08:17:35< shadowm> Like digraphs and trigraphs, they exist for the sake of some keyboard layouts where certain characters aren't easy to type/aren't available at all.
20160303 08:18:19< shadowm> Unlike digraphs and trigraphs, they are readable by humans and decidedly non-evil.
20160303 08:20:26< shadowm> Ah, I see, C++98 is the first version of the C++ standard ever published by the ISO. :p
20160303 08:31:48< vultraz> zookeeper: I'll do a revision pass
20160303 08:40:04 * vultraz wishes he knew how to make the proper apostrophes so he didn't have to always go copy them from another file
20160303 08:40:40-!- Kwandulin [~Miranda@p200300760F0BD49FF04DD4A897E19871.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160303 08:42:26< zookeeper> nah, there's always one nearby
20160303 08:46:09< vultraz> zookeeper: "in a village" vs "on a village"
20160303 08:54:13-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160303 08:56:58< shadowm> vultraz: Alt+0146 (on the numpad).
20160303 08:57:28< shadowm> (At least for _me_, it doesn't seem to work with the alphanumeric keys, but that might be specific to my convoluted configuration.)
20160303 08:58:00< shadowm> ‘: Alt+0145  ’: Alt+0146  “: Alt+0147  ”: Alt+0148
20160303 08:58:34< vultraz> ah, thanks
20160303 08:58:36< vultraz> zookeeper: http://pastebin.com/Gn69ESzY
20160303 09:01:01< vultraz> please approve
20160303 09:03:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 09:03:22< shadowm> Worth noting that it only took me a quick Google search to find this out just now (although I already knew and used the general feature back in 1998).
20160303 09:08:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20160303 09:08:25< vultraz> can someone tell greg boggs to fix his connection
20160303 09:13:02< shadowm> In doofus-01's latest screenshot of the new mine walls terrain (which may not necessarily reflect his latest files I guess) the wood structures seem too shiny and saturated for a mine.
20160303 09:13:37< shadowm> In fact I assumed they were some kind of stone material rather than wood, at first.
20160303 09:14:15< shadowm> It might mostly be that they stick out like a sore thumb compared to 90% of our dull desaturated terrains.
20160303 09:15:51< zookeeper> vultraz, now that i checked how wonderfully simple and straightforward the old original was, i can't
20160303 09:16:15< zookeeper> give me a while
20160303 09:19:25-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds]
20160303 09:26:13-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160303 09:33:06-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160303 09:43:48-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds]
20160303 09:47:49-!- atarocch [atarocch@nat/redhat/x-xkrhcsymxztoxiqt] has joined #wesnoth-dev
20160303 09:48:41-!- Appleman1234 [~Appleman1@KD106161138231.au-net.ne.jp] has quit [Remote host closed the connection]
20160303 09:49:24-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160303 10:45:25-!- mjs-de [~mjs-de@f049232232.adsl.alicedsl.de] has joined #wesnoth-dev
20160303 10:57:32-!- atarocch [atarocch@nat/redhat/x-xkrhcsymxztoxiqt] has quit [Quit: Leaving]
20160303 11:03:17-!- irker716 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160303 11:03:17< irker716> wesnoth: gfgtdf wesnoth:master ab8bf2d97ec5 / data/themes/_initial.cfg: fix replay pause button description https://github.com/wesnoth/wesnoth/commit/ab8bf2d97ec55ae5b398d07a9d8bda4d37c7828a
20160303 11:09:06< vultraz> zookeeper: http://pastebin.com/ibVjA9qn
20160303 11:09:14< vultraz> zookeeper: how's that
20160303 11:36:38< zookeeper> i don't know, i can't mentally compare literally 5 different big blocks of text at the same time
20160303 11:42:54< zookeeper> i'm working on it, give me time
20160303 11:45:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 11:49:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160303 12:07:22-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160303 12:07:28-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160303 12:51:27-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160303 12:54:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160303 12:54:58-!- wedge010 is now known as wedge009
20160303 13:02:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160303 13:02:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160303 13:11:52-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160303 13:22:04-!- Appleman1234 [~Appleman1@KD106161151013.au-net.ne.jp] has joined #wesnoth-dev
20160303 13:24:45-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160303 13:27:01< vultraz> celmin|sleep: question: why if I have this: std::min(std::max(0, first), foo()), where foo() returns an unsigned int, I get compiler errors, but if I put "std::min(std::max(0, first), second)" in a function that takes two plain int and pass the result of foo() as the second argument, I get no compiler errors
20160303 13:28:15< vultraz> without the helper function I need to static cast the result of foo() to int
20160303 13:28:51< celmin|sleep> You don't need the helper function or the static cast.
20160303 13:29:07< vultraz> but it wasn't building :|
20160303 13:29:11< celmin|sleep> The reason you get the error is because std::min is a template with a single template argument.
20160303 13:29:27< celmin|sleep> Thus, if you pass two arguments of different types, it breaks down.
20160303 13:29:42< celmin|sleep> The template deduction fails, or something.
20160303 13:29:49< vultraz> yes, that
20160303 13:29:51< vultraz> s what happened
20160303 13:29:58< celmin|sleep> You work around this by forcing a specific template substitution.
20160303 13:30:33< celmin|sleep> Assuming these are not "long" or "unsigned something", std::min<int>(...) should do the trick.
20160303 13:48:11< irker716> wesnoth: Charles Dang wesnoth:master ff7128f8dc53 / data/tools/GUI.pyw: GUI.pyw: New years copyright update https://github.com/wesnoth/wesnoth/commit/ff7128f8dc53347643572053d5737debe491c75d
20160303 13:48:14< irker716> wesnoth: Charles Dang wesnoth:master 02597f023042 / src/gui/widgets/ (stacked_widget.cpp stacked_widget.hpp): tstacked_widget: added getter method for layer grids https://github.com/wesnoth/wesnoth/commit/02597f0230427fa2ce300b1bb98566bd378fbad3
20160303 13:48:17< irker716> wesnoth: Charles Dang wesnoth:master 3d0f1364fbe0 / / (6 files in 4 dirs): tpreferences: added support for opening preferences to specific main/tab pages https://github.com/wesnoth/wesnoth/commit/3d0f1364fbe0639de5e6e1ada4a0d0289380d457
20160303 13:48:20< irker716> wesnoth: Charles Dang wesnoth:master c07d0d236559 / src/menu_events.cpp: Made ;friend <empty> and ;ignore <empty> open prefs to friends list (bug #24244) https://github.com/wesnoth/wesnoth/commit/c07d0d236559cf800e2ab099a9840a6c4c379a7b
20160303 13:48:22< vultraz> celmin|sleep: ^
20160303 13:50:20< vultraz> Dunno if I could have done it more simply 
20160303 13:53:26< vultraz> random thought
20160303 13:53:41< vultraz> strictly typed enums seem more natural, syntax-wise, than plain enums
20160303 13:54:12-!- Appleman1234 [~Appleman1@KD106161151013.au-net.ne.jp] has quit [Remote host closed the connection]
20160303 13:54:55-!- Appleman1234 [~Appleman1@KD106161151013.au-net.ne.jp] has joined #wesnoth-dev
20160303 13:55:34< irker716> wesnoth: Charles Dang wesnoth:master 5267d83ebc91 / src/preferences_display.hpp: Cleaned up some unused preferences stuff https://github.com/wesnoth/wesnoth/commit/5267d83ebc91f4233c924190fdf41ca81c71ba97
20160303 14:17:44< irker716> wesnoth: Charles Dang wesnoth:master d66e33c80fab / src/ (CMakeLists.txt SConscript game_preferences_display.cpp preferences_display.cpp): Merge contents of two prefs files https://github.com/wesnoth/wesnoth/commit/d66e33c80fab1436a20c74bc2fb983ef8cc0e121
20160303 14:31:09-!- gfgtdf [~chatzilla@f054059119.adsl.alicedsl.de] has joined #wesnoth-dev
20160303 14:31:25< gfgtdf> vultraz: th savegame comprssion option in advanced prefs doesn tseem to work
20160303 14:32:31< vultraz> will fix
20160303 14:32:52< vultraz> gfgtdf: but could you add support for an optional second column
20160303 14:32:55< vultraz> in tdropdownlist
20160303 14:32:57< vultraz> for descrips
20160303 14:32:58< vultraz> or should I
20160303 14:33:19< gfgtdf> vultraz: hmm what do mean exactly ?
20160303 14:34:45< vultraz> well so like
20160303 14:34:47< vultraz> two columns
20160303 14:34:49< gfgtdf> vultraz: actually i think it woudl maybe be best if the droplist would pop up right after you click on the arrow in the advanced prefs section
20160303 14:34:52< vultraz> one for names and one for descriptions
20160303 14:35:14< gfgtdf> vultraz: so maybe inteadof using caombobox we sould use teh drodownload dialog directly
20160303 14:35:33< vultraz> hm
20160303 14:35:39< vultraz> im in a dota match ill get back to you
20160303 14:40:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160303 14:43:12-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160303 15:11:31-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds]
20160303 15:17:08-!- gfgtdf [~chatzilla@f054059119.adsl.alicedsl.de] has quit [Read error: Connection reset by peer]
20160303 15:17:30< celmin|sleep> I don't clearly understand what your code is doing.
20160303 15:18:39< vultraz> celmin|sleep: where so?
20160303 15:18:55< celmin|sleep> 3d0f1364
20160303 15:19:13< vultraz> basically, it loops through every layer of the main stack
20160303 15:19:18< celmin|sleep> Seems to be filled with seemingly superfluous changes.
20160303 15:19:20< vultraz> finds if there's both the tab bar and the tab pager
20160303 15:20:18< vultraz> if so, it sets the selected tab and visible page to the specified index if you're on the specified main page, else 0
20160303 15:20:47< vultraz> show_preferences_dialog now takes an enum that sets index pairs in tpreferences
20160303 15:21:17< vultraz> sadly, I don't think nums can't have values unless you use make_enum... but I don't think you can make it an enum of pairs and not strings
20160303 15:21:37< celmin|sleep> ...huh?
20160303 15:21:52< vultraz> It would be nice if I could just have each enum already have the pair value
20160303 15:21:58< vultraz> like VIEW_FRIENDS = 4,1
20160303 15:22:30< vultraz> anyway, any index changes have to happen before the dialog is shown
20160303 15:22:46< celmin|sleep> Wait, how do you get index_ anyway... or is that in a different commit...
20160303 15:22:50< vultraz> then during the tab setup loop, it also calls initialize_tabs with an index that tells that function which set of values to enter into that listbox
20160303 15:22:57< vultraz> same commit
20160303 15:23:02< vultraz> look at the entire thing
20160303 15:23:16< celmin|sleep> Initialized to 0 in the constructor...
20160303 15:23:19< celmin|sleep> ^0,0
20160303 15:23:47< celmin|sleep> There's set_selected_index()...
20160303 15:24:14< celmin|sleep> Oh, it's that switch in game_preferences_display.
20160303 15:25:10-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160303 15:25:11< celmin|sleep> Well, if you want, you could have a static const map<DIALOG_OPEN_TO,pair<int,int>>.
20160303 15:25:36< celmin|sleep> And since we don't have C++11 with generalized initializers, it could be initialized using Boost.Assign.
20160303 15:25:45< celmin|sleep> Specifically boost::assign::map_list_of.
20160303 15:25:47< celmin|sleep> HOWEVER.
20160303 15:25:48< vultraz> :|
20160303 15:26:05< celmin|sleep> I think it's fine as it is now.
20160303 15:26:45< vultraz> in c++11 can you assign values to enums in the way I'd like?
20160303 15:27:16< celmin|sleep> In C++11 you can write map<string,int> my_map = {{"foo", 6}, {"bar", 12}};
20160303 15:27:50< celmin|sleep> With Boost.Assign, I think that becomes map<string,int> my_map = boost::assign::map_list_of("foo", 6)("bar", 12);
20160303 15:28:30< celmin|sleep> In C++11 you can initialize vectors the same way as arrays, with {} notation.
20160303 15:34:16-!- celmin|sleep is now known as celticminstrel
20160303 15:47:06< celticminstrel> My PR's travis build failed because XCode is more liberal about locating include files. :/
20160303 15:55:32< vultraz> yeeesss
20160303 15:55:37< vultraz> I figured out this conditional
20160303 15:55:45< vultraz> if(has_description || (selected_type != ADVANCED_PREF_TYPE::SPECIAL && (!has_description && selected_type != ADVANCED_PREF_TYPE::TOGGLE))) {
20160303 15:55:59< vultraz> took like 15 minutes of thinking :P
20160303 15:56:20< celticminstrel> So if it has a description, it succeeds.
20160303 15:56:36< celticminstrel> Otherwise, if the selected type is something other than special, then it fails.
20160303 15:56:51< celticminstrel> Otherwise, if it has a description, then it fails.
20160303 15:57:01< vultraz> perhaps I should have specified I needed to write it
20160303 15:57:15< celticminstrel> Otherwise, it the selected type is something other than toggle, it succeeds.
20160303 15:57:23< celticminstrel> Remove the first instance of "something other than".
20160303 15:57:27< celticminstrel> I think.
20160303 15:57:36< vultraz> which part?
20160303 15:58:10< celticminstrel> I think it kind of sounds about right.
20160303 15:58:16< celticminstrel> Let me do this again.
20160303 15:58:21-!- Kwandulin [~Miranda@p200300760F0BD430E018208FA8A2E56E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160303 15:58:53< vultraz> What I wanted was:
20160303 15:59:55< vultraz> Do actions IF there's a description. If not, do them anyway as long as the selected type isn't SPECIAL or TOGGLE and has no description 
20160303 16:00:38< celticminstrel> I'm going to try making a tree out of this to figure out if it's correct.
20160303 16:00:51< vultraz> (note: the above does work)
20160303 16:01:02< vultraz> but I don't know if it's the best way to do it
20160303 16:01:33< celticminstrel> if(A || B) {X} is exactly equivalent to if(A) {X} else if(B) {X}.
20160303 16:01:45< celticminstrel> Bah, that converted to a smiley.
20160303 16:01:57< vultraz> same, heh
20160303 16:03:13< celticminstrel> if(A && B) {X} I think is exactly equivalent to if(!A) {} else if(!B) {} else {X}
20160303 16:03:25< celticminstrel> This is called short-circuiting, by the way.
20160303 16:03:27< celticminstrel> Anyway.
20160303 16:04:03< vultraz> short circuiting?
20160303 16:04:08< celticminstrel> So if it has a description, the condition is true. Thus I assume the condition is to decide whether to show the description.
20160303 16:04:20< celticminstrel> I'll explain that in a moment.
20160303 16:04:49< vultraz> This is specifically related to expanding the options in advanced prefs
20160303 16:05:16< vultraz> see, the toggle specification is necessary because otherwise an empty space gets revealed 
20160303 16:05:24< vultraz> since the placeholder widget had borders
20160303 16:05:32< celticminstrel> Hang on, because of short-circuiting, the !has_description is redundant.
20160303 16:05:53< celticminstrel> The program never gets to that part of the condition if has_description is true.
20160303 16:06:58< celticminstrel> And since && is associative, you don't need the extra pair of parentheses... though you wouldn't need them anyway for the reason mentioned above, since you'd then only have two conditions linked by &&.
20160303 16:07:29< celticminstrel> Okay, so. If it doesn't have a description, then the condition succeeds if and only if the type is something other than SPECIAL or TOGGLE.
20160303 16:07:55< vultraz> you're right, if(has_description || (selected_type != ADVANCED_PREF_TYPE::SPECIAL && selected_type != ADVANCED_PREF_TYPE::TOGGLE)) { works
20160303 16:08:22< celticminstrel> What's inside the braces? As a description, not the actual code.
20160303 16:08:32< vultraz> toggles a grid visible
20160303 16:09:24< vultraz> I'll go with this version
20160303 16:09:26< celticminstrel> And that grid contains...?
20160303 16:09:26< vultraz> thanks
20160303 16:09:59< vultraz> the advanced preference options
20160303 16:10:01< vultraz> and description
20160303 16:10:16< celticminstrel> Ah, right.
20160303 16:12:03< irker716> wesnoth: Charles Dang wesnoth:master 1e68fcdb0a17 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: fixed regression where certain advanced options weren't opening https://github.com/wesnoth/wesnoth/commit/1e68fcdb0a17cb914550cef5c1dc7622dbdc257b
20160303 16:12:04< vultraz> so what is this about short circuiting 
20160303 16:12:08< vultraz> gfgtdf ^
20160303 16:12:37-!- timotei_ [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20160303 16:13:52-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 244 seconds]
20160303 16:15:37< celticminstrel> In C++ (and most other languages, for that matter), the && and || operators (or their equivalent) are short-circuiting operators.
20160303 16:15:51< celticminstrel> (In C++ that only applies to the built-in meaning, not to overloaded meanings.)
20160303 16:16:22< celticminstrel> In "A || B", if A is true, the B is never evaluated, because the compiler knows that the full expression will be true no matter what B is.
20160303 16:16:33< celticminstrel> ^then
20160303 16:16:54< celticminstrel> In "A && B", if A is false, then B is never evaluated, because the compiler knows that the full expression will be false no matter what B is.
20160303 16:17:40< celticminstrel> The ?: operator also sort of has something like this, but I don't think you can call it short-circuiting. In "A ? B : C", if A is true, then B is evaluated but C never is; similarly, if A is false, then C is evaluated but B never is.
20160303 16:18:54< celticminstrel> This can make a significant difference if B (and/or C) requires a lot of computation or has side-effects.
20160303 16:20:16< celticminstrel> (So, for example, it would be inefficient write "std::find(some_list.begin(), some_list.end(), n) != some_list.end() && n < 12"; instead, reverse the order.)
20160303 16:28:49-!- boucman_work [~jrosen@193.56.60.161] has joined #wesnoth-dev
20160303 16:28:49-!- boucman_work [~jrosen@193.56.60.161] has quit [Changing host]
20160303 16:28:49-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160303 16:29:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 16:29:53< celticminstrel> vultraz: ^
20160303 16:34:18-!- timotei_ [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20160303 16:37:46-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Quit: Leaving]
20160303 16:38:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160303 16:39:24-!- travis-ci [~travis-ci@ec2-54-159-73-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20160303 16:39:25< travis-ci> wesnoth/wesnoth#8715 (master - d66e33c : Charles Dang): The build was broken.
20160303 16:39:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113409754
20160303 16:39:25-!- travis-ci [~travis-ci@ec2-54-159-73-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20160303 16:39:28< vultraz> ah I see
20160303 16:44:01< shadowm> Ah good, someone presented my concern with that terrain in a more graphical fashion so I don't need to.
20160303 16:58:17-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160303 16:59:57-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 260 seconds]
20160303 17:01:16-!- fendrin [~quassel@176.4.139.100] has joined #wesnoth-dev
20160303 17:01:16-!- fendrin [~quassel@176.4.139.100] has quit [Changing host]
20160303 17:01:16-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160303 17:07:51< vultraz> hm
20160303 17:07:53< vultraz> I broke scons
20160303 17:08:05< vultraz> could someone who knows scons tell me how to fix it
20160303 17:08:12< vultraz> should I just have removed that line?
20160303 17:08:17< vultraz> (d66e33c80fab )
20160303 17:13:12< loonycyborg> vultraz: probably yes
20160303 17:13:30< loonycyborg> though would need to doublecheck if that define affects other file now
20160303 17:13:37< loonycyborg> and move it into that line instead
20160303 17:14:58< celticminstrel> ...did someone just use a Lua idiom in Python?
20160303 17:15:12< celticminstrel> Did they not know that Python has a ternary conditional operator?
20160303 17:16:00< loonycyborg> Isn't it relatively new addition?
20160303 17:16:14< celticminstrel> I don't believe so?
20160303 17:16:22-!- horrowind [~Icedove@2a02:810a:8380:834:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160303 17:16:48< shadowm> I actually had to drop a few instances of the Python ternary expression in the past.
20160303 17:17:19< shadowm> IIRC the target was Python 2.5 and the feature was added in 2.6.
20160303 17:18:05< celticminstrel> I don't think 2.6 can be called recent.
20160303 17:18:21< celticminstrel> But, I suppose it's a bit more recent than I thought.
20160303 17:18:30< loonycyborg> it was when this code was written
20160303 17:18:44< celticminstrel> I guess I can believe that.
20160303 17:19:06< shadowm> Oh, Python 2.3.
20160303 17:19:12< shadowm> Figures.
20160303 17:19:59< shadowm> (The deployment target, not the series which introduced the feature.)
20160303 17:21:13< shadowm> Don't worry about it for 1.13.x, though, because there's pretty much no way in hell I'm ever going to deploy 1.13.x series wesnothds there after 1.13.3.
20160303 17:28:37< loonycyborg> vultraz:   that file is in wesnoth_sources too, so need to remove it from that list
20160303 17:29:02< loonycyborg> I'll commit it myself
20160303 17:34:27-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20160303 17:34:51< Elvish_Hunter> Hi all :)
20160303 17:35:04< loonycyborg> hi :P
20160303 17:36:17< vultraz> hey
20160303 17:37:02< Elvish_Hunter> About my wmllint patch for [filter] name=, I decided to drop it, since I noticed from the logs that zookeeper fixed the issue.
20160303 17:37:37< Elvish_Hunter> By the way, I had troubles coming up with a decent solution to handle [message] [option] [command] [message]... :P
20160303 17:39:36< Elvish_Hunter> I also prepared a small IRC bot based on the WeeChat client. For everyone that might be interested in it, it's here: https://github.com/Elvish-Hunter/elvishbot
20160303 17:41:00-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160303 17:41:12< loonycyborg> shadowm: I've already made asio_wesnothd work as redirect server and implemented fifo commands. What more stuff I should ensure is there before merging it into master?
20160303 17:46:27< celticminstrel> So, problems with nested messages?
20160303 17:49:02< Elvish_Hunter> Yes, with nested messages and pretty much everything that was nested inside [command]. I was thinking of a solution, but zookeeper was faster than me...
20160303 17:49:30< celticminstrel> Is it kosher to use lua_optint() to get an optional boolean argument?
20160303 17:49:49< celticminstrel> ^luaL_optint
20160303 17:51:32< celticminstrel> Can anyone tell me why the lua_unit copy constructor is private?
20160303 17:51:50 * celticminstrel would probably poke gfgtdf or iceiceice about it if they were here.
20160303 18:02:56< Elvish_Hunter> In the Lua documentation, I see that there are two suitable functions for that purpose (lua_isboolean and lua_toboolean), but no specific functions to get boolean args.
20160303 18:03:42< celticminstrel> None for optional booleans, no.
20160303 18:05:25< Elvish_Hunter> I guess that you'll have to combine luaL_optint and those two functions then.
20160303 18:05:42< celticminstrel> They don't combine.
20160303 18:06:08< celticminstrel> They both do the same thing, except that optint does a bit extra.
20160303 18:06:59< celticminstrel> I wonder what happens if you call lua_toboolean on an invalid stack index...
20160303 18:07:42< celticminstrel> Looks like that would work... but only if the flag should default to false.
20160303 18:08:30< celticminstrel> Assuming the none-type coerces to false.
20160303 18:09:00< vultraz> I should really redo my lua 5.3 pr again...
20160303 18:10:20-!- travis-ci [~travis-ci@ec2-23-23-34-58.compute-1.amazonaws.com] has joined #wesnoth-dev
20160303 18:10:21< travis-ci> wesnoth/wesnoth#8717 (master - 1e68fcd : Charles Dang): The build was broken.
20160303 18:10:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113440080
20160303 18:10:21-!- travis-ci [~travis-ci@ec2-23-23-34-58.compute-1.amazonaws.com] has left #wesnoth-dev []
20160303 18:10:30 * celticminstrel goes with lua_isboolean(L, 3) ? lua_toboolean(L, 3) : true to be on the safe side.
20160303 18:11:22< Elvish_Hunter> There's also lua_isnoneornil that might be useful.
20160303 18:11:39< celticminstrel> Yeah, that's useful to test if an argument exists.
20160303 18:11:51< celticminstrel> Particularly when the argument could be of multiple types.
20160303 18:12:50< irker716> wesnoth: loonycyborg wesnoth:master 0b7b820f4f02 / src/SConscript: scons: remove redundant source file reference https://github.com/wesnoth/wesnoth/commit/0b7b820f4f02962c86cafa1f4ba9f3d2360cece7
20160303 18:13:57< celticminstrel> no_add means the [object[ is not added to [modifications], right?
20160303 18:14:10< vultraz> right
20160303 18:14:11< celticminstrel> Ah, yeah, there's the code for it.
20160303 18:15:22< celticminstrel> times= does not accept any values except for "per level". Interesting.
20160303 18:15:54< celticminstrel> I wonder if there'd be any other sensible values (other than a number).
20160303 18:27:21< celticminstrel> I think this should work now.
20160303 18:27:37 * celticminstrel is finishing the work on the wesnoth.effects table that gfgtdf started.
20160303 18:28:30-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Quit: Konversation terminated!]
20160303 18:29:19< celticminstrel> vultraz, loonycyborg: If I reimplement THoT's inspire in analogy with the reimplementation of leadership, can I push it for 1.13.3?
20160303 18:29:27 * celticminstrel will do it only of both of you say yes.
20160303 18:29:49< celticminstrel> ...should I ping zookeeper too on this?
20160303 18:30:04< loonycyborg> zookeeper would know better than me for sure
20160303 18:30:40< vultraz> do it
20160303 18:30:59 * celticminstrel will wait to see what zookeeper has to say then.
20160303 18:31:53< celticminstrel> The diff on this commit is absolutely terrible.
20160303 18:32:11< celticminstrel> (The unit effects one, not THoT's inspire.)
20160303 18:41:14< celticminstrel> Unrelatedly, I might have discovered a bug in the WML preprocessor.
20160303 18:48:59 * zookeeper awakens
20160303 18:50:50< zookeeper> celticminstrel, i don't see why not?
20160303 18:51:36< zookeeper> there shouldn't be anything super weird in the campaign that would interact it in ways that is somehow tied to the current implementation, for example
20160303 18:51:44< zookeeper> +with
20160303 19:06:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160303 19:07:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160303 19:08:00< celticminstrel> Uhh. Why am I getting a Lua error in a core area that I didn't even touch.
20160303 19:19:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 19:19:59< celticminstrel> I wish I could see the Lua stack in my debugger...
20160303 19:21:46< Elvish_Hunter> zookeeper, celticminstrel: one example of "anything super weird" might be "units with negative levels" :P
20160303 19:22:09< Elvish_Hunter> And yes, I actually tested them a long time ago, and they actually worked!
20160303 19:22:13< celticminstrel> Huh.
20160303 19:22:23< celticminstrel> Wonder if they still work.
20160303 19:22:42< Elvish_Hunter> For example, attacking them subtracted experience from your unit.
20160303 19:22:56< celticminstrel> zookeeper: Do you know of any other values that might be useful in [effect]times=?
20160303 19:23:31< zookeeper> celticminstrel, well, just an integer would be the obvious possibility
20160303 19:23:36< celticminstrel> Okay, so the cause of this weird Lua error is (indirectly) clear.
20160303 19:23:46< zookeeper> other than that... nothing springs to mind
20160303 19:24:11< celticminstrel> zookeeper: Right, an integer... wouldn't be terribly useful literally, but in conjunction with variable substitution, it could be more useful.
20160303 19:24:31< zookeeper> yeah
20160303 19:24:54< celticminstrel> When I say "indirectly" clear I mean that commenting out three lines of code makes it go away, but those lines of code are nowhere near the site of the error.
20160303 19:30:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160303 19:32:08-!- Kwandulin [~Miranda@p200300760F0BD430E018208FA8A2E56E.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20160303 19:33:59-!- mjs-de [~mjs-de@f049232232.adsl.alicedsl.de] has quit [Remote host closed the connection]
20160303 19:40:37-!- Kwandulin [~Miranda@p200300760F0BD430E018208FA8A2E56E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160303 19:44:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160303 19:54:43< celticminstrel> Aaand. I fixed it by throwing in a random lua_settop(L,0);
20160303 19:57:19< celticminstrel> Huh, that issue with the Lua kernel that I mentioned seems to only be an issue at low resolutions (or when dialog-spanning scrollbars appear).
20160303 19:57:40< celticminstrel> Oh.
20160303 19:57:51< celticminstrel> Looks like I spoke too soon.
20160303 19:58:08< celticminstrel> I think what happened here is that the dialog was invalidated(?) - at least, it got wider all of a sudden.
20160303 19:58:16-!- travis-ci [~travis-ci@ec2-54-159-73-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20160303 19:58:17< travis-ci> wesnoth/wesnoth#8719 (master - 0b7b820 : loonycyborg): The build was fixed.
20160303 19:58:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113469416
20160303 19:58:17-!- travis-ci [~travis-ci@ec2-54-159-73-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20160303 20:05:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160303 20:07:38-!- gfgtdf [~chatzilla@f054059119.adsl.alicedsl.de] has joined #wesnoth-dev
20160303 20:07:57< gfgtdf> Aginor: the replay view has ui issues in current master
20160303 20:08:25< gfgtdf> Aginor: the replay buttons dont get removed when calling "continue play"
20160303 20:09:23< gfgtdf> Aginor: the cause seems to be that display.redraw_everything() (called form replay_cotnrollers ctor and dtor) doesn't do what it did previously.
20160303 20:11:22< zookeeper> so... what's the scheduled release time?
20160303 20:19:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 20:22:21< celticminstrel> So zookeeper, "inspire" on a level X unit should have the exact same effect as "leadership" on a level X+1 unit, right?
20160303 20:22:56< zookeeper> that's how i've understood it, yes
20160303 20:24:07< celticminstrel> The inspire ability only goes up to level 3... it's trivial for me to expand it to level 5, but do you think there's any point in doing so?
20160303 20:24:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160303 20:27:00-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160303 20:27:26< celticminstrel> ancestral: Did you see the forum PM?
20160303 20:27:33< ancestral> Yes
20160303 20:28:13< celticminstrel> It does look like it's related to my code though...
20160303 20:29:07< celticminstrel> Or, at least, it occurs in an AI-related function.
20160303 20:29:51< celticminstrel> zookeeper: ?
20160303 20:30:33< zookeeper> celticminstrel, apparently no point as far as THoT is concerned
20160303 20:31:00< zookeeper> if you want to make it easier to copy and use on >lvl3 units, go ahead
20160303 20:34:15< celticminstrel> I should probably at least make sure that the scenario can be started without errors before I push this.
20160303 20:37:27< ancestral> celticminstrel: Yeah I’m not sure, but it sounds like he is missing the right libraries
20160303 20:38:03< celticminstrel> I see.
20160303 20:39:28< celticminstrel> zookeeper: Do you happen to know how I could easily find a unit with inspire by starting THoT and using ;cl?
20160303 20:40:00< zookeeper> just debug-create one?
20160303 20:40:05< celticminstrel> ...duh!.
20160303 20:40:13< zookeeper> yeah it's really handy :P
20160303 20:40:23< celticminstrel> Sometimes I forget the obvious.
20160303 20:47:30< irker716> wesnoth: gfgtdf wesnoth:master f25385690a91 / RELEASE_NOTES: Update RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/f25385690a91564eb8a99f80a39f32a77df60b3e
20160303 20:50:19< celticminstrel> gfgtdf: I seem to recall you suspecting that bug is related to something I did, is this correct?
20160303 20:50:33< gfgtdf> celticminstrel: yes
20160303 20:51:05< gfgtdf> celticminstrel: i dont say that the code was perfect before, but it didnt have that bug
20160303 20:51:20< celticminstrel> Is it on gna?
20160303 20:51:30< gfgtdf> celticminstrel: yes
20160303 20:52:11< gfgtdf> celticminstrel: i wonder how do you know that its related to something you did if you didnt read the report on gna ?
20160303 20:52:33< celticminstrel> I don't know, maybe I did, maybe you said something in here.
20160303 20:53:08< celticminstrel> Found it.
20160303 20:53:16< celticminstrel> Ah, it's already assigned to me, then.
20160303 20:53:31< celticminstrel> I'll make a unit test for it after the release, and see if I can fix it.
20160303 20:54:35< gfgtdf> celticminstrel: mostlikeley its just removing the erase_unit() call
20160303 20:55:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160303 20:59:08< irker716> wesnoth: gfgtdf wesnoth:master 699432f11917 / src/ (hotkey_handler_sp.cpp playsingle_controller.cpp playsingle_controller.hpp): fix reset replay button https://github.com/wesnoth/wesnoth/commit/699432f119179237cbd83275f159e632a45dd5fc
20160303 20:59:10< irker716> wesnoth: gfgtdf wesnoth:master 215b7b3b7fb1 / src/server/game.cpp: Add some log to wesnothd https://github.com/wesnoth/wesnoth/commit/215b7b3b7fb1ca1da9872fabfb8ceb6bf2cd16ea
20160303 20:59:12< irker716> wesnoth: gfgtdf wesnoth:master 7c27a3109ca9 / src/replay_controller.cpp: attempt to fix 'continue play' button in replay view. https://github.com/wesnoth/wesnoth/commit/7c27a3109ca9a364cd4f6cf1aca237ba80a54d70
20160303 21:00:03< gfgtdf> Aginor: i made that acommit ^ about the replay 'continue play' issue i mentioned earlier.
20160303 21:01:41< celticminstrel> So vultraz broke the XCode project! \o/
20160303 21:06:15< celticminstrel> I think gfgtdf also broke something.
20160303 21:06:43< gfgtdf> celticminstrel: i i just saw
20160303 21:07:31< irker716> wesnoth: gfgtdf wesnoth:master e6ef29da5b76 / src/replay_controller.cpp: fix compilation https://github.com/wesnoth/wesnoth/commit/e6ef29da5b767ee5eaa26feaae5c3657fddfe1e4
20160303 21:07:39< gfgtdf> s/i/y
20160303 21:12:18< irker716> wesnoth: ln-zookeeper wesnoth:master 7ac79a4ea411 / RELEASE_NOTES: Updated RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/7ac79a4ea411acb9d086512dd6dcc9aa399ed89c
20160303 21:12:47< celticminstrel> ...
20160303 21:13:33< celticminstrel> On an unrelated note, I think I probably need to update the changelog or something.
20160303 21:16:27< celticminstrel> Hang on, surely inspire isn't supposed to apply to itself...
20160303 21:17:34< celticminstrel> Oh, wait, duh. I have three inspire units in a row. Obviously they're affecting each other.
20160303 21:17:42-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20160303 21:17:51< celticminstrel> Yeah okay, the level 3 one is not inspired.
20160303 21:19:59< irker716> wesnoth: Celtic Minstrel wesnoth:master 21bda2085967 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/21bda2085967734d87e99e375cb0170a720d0817
20160303 21:20:01< irker716> wesnoth: Celtic Minstrel wesnoth:master e2c4bc6e5371 / data/campaigns/The_Hammer_of_Thursagan/ (4 files in 2 dirs): THoT: Reimplement inspire ability using the new $other_unit variable https://github.com/wesnoth/wesnoth/commit/e2c4bc6e5371ec5717a68b07a45705a1c20ef86e
20160303 21:20:36-!- LovCAPONE [~someuser@modemcable184.138-20-96.mc.videotron.ca] has joined #wesnoth-dev
20160303 21:22:37< celticminstrel> Why can't I find a 1.13.2 tag...
20160303 21:23:24< celticminstrel> Or any 1.13.x for that matter.
20160303 21:24:31< shadowm> 21:24:15 shadowm@website:/usr/src/wesnoth/master$ git tag | fgrep 1.13
20160303 21:24:32< shadowm> 1.13.2
20160303 21:25:01< celticminstrel> Well, typing it straight into the URL bar works...
20160303 21:25:08< celticminstrel> But it's not in the dropdown list.
20160303 21:26:11< shadowm> That's GitHub being GitHub.
20160303 21:26:17< celticminstrel> Clearly.
20160303 21:26:29< celticminstrel> Aw, I was hoping I could filter the compare by author...
20160303 21:27:38< celticminstrel> compare/1.13.2...master?author=CelticMinstrel does not work. :(
20160303 21:28:41< irker716> wesnoth: anatoly techtonik wesnoth:master 1516ab6fdeff / src/wesnoth.cpp: Force console on Windows when --help is specified https://github.com/wesnoth/wesnoth/commit/1516ab6fdeff3f861559167d5ba1daf13ab1f528
20160303 21:28:43< irker716> wesnoth: anatoly techtonik wesnoth:master a1dfb9924f0e / src/wesnoth.cpp: Use pipes in if for consistency https://github.com/wesnoth/wesnoth/commit/a1dfb9924f0e146128352d5dc3b52d8afc52033a
20160303 21:28:45< irker716> wesnoth: Ignacio R. Morelle wesnoth:master dbebd452cc3e / src/wesnoth.cpp: Merge pull request #614 from techtonik/patch-1 https://github.com/wesnoth/wesnoth/commit/dbebd452cc3e5ff2d3884397f343d1543570cef5
20160303 21:33:52-!- gfgtdf [~chatzilla@f054059119.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160303 21:36:02< celticminstrel> I guess the orb selection doesn't need to go in the changelog, since it was in 1.13.2 already.
20160303 21:37:12< celticminstrel> Do I need to mention the THoT change?
20160303 21:38:49< irker716> wesnoth: Celtic Minstrel wesnoth:master fab6633bc494 / changelog players_changelog: Update changelogs https://github.com/wesnoth/wesnoth/commit/fab6633bc4945f746adb8eed4e83be7e078283eb
20160303 21:58:27-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20160303 22:01:33-!- Appleman1234 [~Appleman1@KD106161151013.au-net.ne.jp] has quit [Ping timeout: 246 seconds]
20160303 22:21:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160303 22:21:59-!- Kwandulin [~Miranda@p200300760F0BD430E018208FA8A2E56E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160303 22:34:39-!- Yaiyan_ is now known as Yaiyan
20160303 22:58:30-!- Appleman1234 [~Appleman1@KD106161136215.au-net.ne.jp] has joined #wesnoth-dev
20160303 22:58:41-!- gfgtdf [~chatzilla@f054059119.adsl.alicedsl.de] has joined #wesnoth-dev
20160303 23:08:03-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160303 23:08:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160303 23:08:23< gfgtdf> ok i'm again thinkaing about how to make teh updater work, i looked a little in inet and it seems the the default way to make it secure is to 1) download the update along with a 'signature' 2) calculate a hash of the update, 3) veryfy the hash using the signature and a public RSA key. Is that correct?
20160303 23:19:00-!- gfgtdf [~chatzilla@f054059119.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160303 23:28:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
--- Log closed Fri Mar 04 00:00:58 2016