--- Log opened Sat Mar 05 00:00:42 2016
20160305 00:05:30< celticminstrel> Open for initial comments on https://wiki.wesnoth.org/Wesnoth_Formula_Language
20160305 00:05:39< celticminstrel> Still have more work to do in the Core Functions section though.
20160305 00:05:48< celticminstrel> (A few are missing, for example, and it needs better organization.)
20160305 00:08:32-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160305 00:14:36-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 00:14:37< travis-ci> wesnoth/wesnoth#8739 (master - 4d36f08 : gfgtdf): The build has errored.
20160305 00:14:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113771934
20160305 00:14:37-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 00:16:55< celticminstrel> This is a bad time for the build to error.
20160305 00:18:31< vultraz> Aginor: https://gna.org/bugs/?24212 confirmed fixed
20160305 00:19:49< irker779> wesnoth: Charles Dang wesnoth:master 2ca0503337c6 / projectfiles/CodeBlocks/wesnoth.cbp: Updated cb projfile https://github.com/wesnoth/wesnoth/commit/2ca0503337c6a499160ba89badc8d8c98b93d76e
20160305 00:21:28< Ravana_> celticminstrel: I see that you can define functions in formula. However, where can they be defined? Meaning where should I put def something, in order to use it in filter
20160305 00:21:29< Aginor> I prefer to stick with numbers
20160305 00:21:37< Aginor> not release names
20160305 00:23:28< vultraz> Apple does not approve :P
20160305 00:28:08< Aginor> vultraz: thanks
20160305 00:28:38< loonycyborg> I made up a really cool name for an ubuntu release: Depressed Dodo
20160305 00:29:03< vultraz> hah!
20160305 00:29:20< vultraz> Ostentatious Ostrich? 
20160305 00:30:14< loonycyborg> Temperamental Thrinaxodon
20160305 00:30:51< loonycyborg> Amicable Amoeba
20160305 00:30:58< Aginor> hmmz
20160305 00:31:10< Aginor> lots of errors in that build
20160305 00:31:39< vultraz> errored isn't the same as failed
20160305 00:31:50< vultraz> ignore errors
20160305 00:32:18< vultraz> we only care if it says 'was broken', 'failed' or 'is still failing'
20160305 00:32:24-!- gfgtdf [~chatzilla@f050182048.adsl.alicedsl.de] has joined #wesnoth-dev
20160305 00:32:24< vultraz> (assuming you mean travis)
20160305 00:32:55< gfgtdf> vultraz: no, you shouldnt generally ignore erros. It posssible that they are just casues by travis silliness but that not always the case
20160305 00:33:03< Aginor> https://travis-ci.org/wesnoth/wesnoth/jobs/113771935
20160305 00:33:14< Aginor> this is not travis silliness
20160305 00:33:26< Aginor> thereäs GUI issues and thereäs still a lingering bug
20160305 00:33:34< gfgtdf> Aginor: y i saw
20160305 00:34:02< gfgtdf> Aginor: im wokring on fixing it, it seems liek ingering was more borken tha i thought it was
20160305 00:34:36< gfgtdf> Aginor: but this only effect nogui map games so i wouldn't call this a blocker.
20160305 00:36:08-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160305 00:36:31< gfgtdf> Aginor: the mp part i mean
20160305 00:36:41< gfgtdf> Aginor: i dont know about the gui issue
20160305 00:37:06< Aginor> the GUI issue looks like a problem, but I don't really know
20160305 00:37:47< irker779> wesnoth: Charles Dang wesnoth:master 6662f4e3c77d / RELEASE_NOTES: Updated RELEASE_NOTES https://github.com/wesnoth/wesnoth/commit/6662f4e3c77dabdaaa68264c089e9c7feb706d87
20160305 00:38:34< vultraz> I'm honestly really curious if this is still an issue:
20160305 00:38:35< vultraz> "Fullscreen mode does not fill the entire screen when maximum resolution is selected in Preferences → Display, and user interface elements are scaled and distorted."
20160305 00:38:59< vultraz> celticminstrel: listed under OS X specific bugs in RN, do you still observe that
20160305 00:40:27< vultraz> also this might be fixed: https://gna.org/bugs/index.php?21943
20160305 00:40:31< vultraz> can't say
20160305 00:42:50< irker779> wesnoth: gfgtdf wesnoth:master 36ac558466f4 / src/desktop/windows_tray_notification.cpp: fix crash with nogui on windows https://github.com/wesnoth/wesnoth/commit/36ac558466f4fe264b725975ea27935e4aeec4d9
20160305 00:42:52< irker779> wesnoth: gfgtdf wesnoth:master dee454afb99d / src/playmp_controller.cpp: fix lingering in mp https://github.com/wesnoth/wesnoth/commit/dee454afb99d700b01556c6fc1ea8cc62deb8064
20160305 00:43:00< gfgtdf> Aginor: next attempt to fix mp lingering ^
20160305 00:43:36< gfgtdf> Aginor: whether it works actualyl depends on whether dialogs::network_receive_dialog() also works in nogui mode
20160305 00:44:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160305 00:48:50< zookeeper> vultraz, the hotkeys preferences tab seems a bit out of place between general and display. it should probably come after sound or multiplayer.
20160305 00:49:07< vultraz> are you sure it's not just the icon
20160305 00:49:49< zookeeper> well, that too
20160305 00:50:01< zookeeper> but i haven't finished deciding what to propose as the replacement yet
20160305 00:50:23< vultraz> I've asked LB to possibly make all-new icons 
20160305 00:50:32-!- oldlaptop [~quassel@50-37-53-169.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20160305 00:50:43< vultraz> these little picture-y icons are very old
20160305 00:50:52< vultraz> and aren't even up to current pixelart standards
20160305 00:51:07< zookeeper> how are they not?
20160305 00:51:23-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160305 00:53:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160305 00:53:34-!- wedge010 is now known as wedge009
20160305 00:55:09< zookeeper> anyway, i think something like core/images/scenery/rune1-glow.png would work much better
20160305 00:55:28< zookeeper> it's clearly hot and it's a glyph so kind of a key == perfect match
20160305 00:55:57< zookeeper> (and most of all it looks nice)
20160305 00:56:06< zookeeper> (and is of the right size...)
20160305 00:56:18< vultraz> well, if you think it looks best commit the change
20160305 00:56:24< vultraz> but you;d have to make a copy in images/misc
20160305 00:56:38< irker779> wesnoth: Charles Dang wesnoth:master 6aa060ed060e / RELEASE_NOTES changelog data/lua/wml-tags.lua: Fixed [put_to_recall_list] (bug #24390) https://github.com/wesnoth/wesnoth/commit/6aa060ed060ef94adbb5f2380b596cb9e7d5946b
20160305 00:56:49< vultraz> celticminstrel, gfgtdf ^
20160305 00:57:04< zookeeper> although i think the best would be to have kalenz on a keytar
20160305 00:57:25< zookeeper> we really need to re-make the band of wesnoth one day
20160305 00:57:34< vultraz> the what now?
20160305 00:57:37< zookeeper> the cool thing
20160305 00:57:41< zookeeper> let me see if i can find it...
20160305 01:00:05< irker779> wesnoth: Charles Dang wesnoth:master 7cdf70db646f / changelog: 'correctly' not 'currently' (fixup 6aa060ed060e) https://github.com/wesnoth/wesnoth/commit/7cdf70db646f2df37ed9f3cf36e864307f34d978
20160305 01:00:08< irker779> wesnoth: Charles Dang wesnoth:master 44a84e7b0186 / RELEASE_NOTES: Fixed a case of bad RN list formatting https://github.com/wesnoth/wesnoth/commit/44a84e7b01862537f7f00ef8c00c4a9d0ca22302
20160305 01:01:43< vultraz> eh, well, the icons could be worst
20160305 01:05:27< celticminstrel> Ravana_: You define them in the formula string, before the actual formula. I suspect they also need to be terminated by a newline. vultraz: Oh thanks, I was going to fix that after the release but whatever. As for the bug, I dunno. I never use fullscreen mode.
20160305 01:06:02< vultraz> celticminstrel: could you check?
20160305 01:06:11< celticminstrel> vultraz: Not right now, in the middle of cooking.
20160305 01:06:26< vultraz> that makes two people I know who are eating... :|
20160305 01:06:35 * vultraz now feels the urge to acquire lunch
20160305 01:07:58< zookeeper> waah. no, the final gif of the wesnoth musical band has been lost, it seems. only the individual band members remain in the last post: https://forums.wesnoth.org/viewtopic.php?f=9&t=6226&start=90
20160305 01:08:19< celticminstrel> Also Ravana_, I'm not sure if they work everywhere. I know they work in an AI context, but I believe the C++ code needs to specifically enable functions, and I haven't yet tested if they work in $(...) or unit filters.
20160305 01:14:16< vultraz> zookeeper: ah, the cute things that went on in wesnoth a decade ago
20160305 01:14:25< zookeeper> yes
20160305 01:14:49< zookeeper> wesnoth was still in its infancy
20160305 01:14:53< zookeeper> as were... eh... hehe
20160305 01:17:49< zookeeper> jabs aside, how's this (assuming proper TC, of course)? https://dl.dropboxusercontent.com/u/63964618/wesnoth/hotkeys.png
20160305 01:18:09< celticminstrel> Looks good to me.
20160305 01:21:58< irker779> wesnoth: loonycyborg wesnoth:master 8bff4829e66a / scons/gettext.py: scons: pass --backup=none --previous -U to msgmerge https://github.com/wesnoth/wesnoth/commit/8bff4829e66a5c09d40d3a5af0632a7360952a94
20160305 01:23:51< zookeeper> i'll put it in, it's a quick hack but fits in better with the other icons
20160305 01:27:39< irker779> wesnoth: ln-zookeeper wesnoth:master d89102373735 / images/icons/icon-hotkeys.png src/gui/dialogs/preferences_dialog.cpp: Added new icon for hotkeys preferences https://github.com/wesnoth/wesnoth/commit/d89102373735ae5b7afed302028b7c12e5521496
20160305 01:30:12< zookeeper> aaaand that's enough for tonight
20160305 01:31:31-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 01:31:32< travis-ci> wesnoth/wesnoth#8741 (master - 6662f4e : Charles Dang): The build was canceled.
20160305 01:31:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113812929
20160305 01:31:32-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 01:32:39-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 01:32:40< travis-ci> wesnoth/wesnoth#8741 (master - 6662f4e : Charles Dang): The build was canceled.
20160305 01:32:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113812929
20160305 01:32:40-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 01:34:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 248 seconds]
20160305 01:44:07< irker779> wesnoth: loonycyborg wesnoth:master fccb00b92d3f / po/SConscript: scons: massage {wml,cpp}.pot files with msgcat instead of just moving them https://github.com/wesnoth/wesnoth/commit/fccb00b92d3ff3fe6eaa6da326d87dde92ac2891
20160305 01:44:49< vultraz> Aginor: is there anything else you have pending for the release?
20160305 01:45:23< vultraz> shadowm, gfgtdf: same question
20160305 01:45:59< Aginor> no. I/someone should possibly mention gna.org/bugs/?24212 in the changelog too
20160305 01:47:55< irker779> wesnoth: Charles Dang wesnoth:master 8100f7cce58b / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/8100f7cce58b0805c62e328e5c952e695f79a0a2
20160305 01:47:57< vultraz> Aginor: ^
20160305 01:48:26< Aginor> thanks
20160305 01:48:32< Aginor> I have nothing to add then
20160305 01:48:37< vultraz> I don't have anything else pending right now, so...
20160305 01:48:46< Aginor> are we making an RC or going directly to release?
20160305 01:48:58< vultraz> directly to release 
20160305 01:49:10< vultraz> RCs are only for betas prior to a stable series
20160305 01:49:41-!- vultraz changed the topic of #wesnoth-dev to: 1.13.3 scheduled for around now | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160305 01:49:49< vultraz> loonycyborg: whenever you're ready
20160305 01:56:33< irker779> wesnoth: loonycyborg wesnoth:master 059f329b3d40 / po/SConscript: scons: add missing --keyword arg to xgettext invocation https://github.com/wesnoth/wesnoth/commit/059f329b3d409d4d84b2c8e591a4553c28235577
20160305 01:57:20< loonycyborg> vultraz: ok, I'm doing tasks in ReleasingWesnoth
20160305 01:59:32< vultraz> I'll deal with the announcement once everything's done
20160305 02:00:51-!- Appleman1234 [~Appleman1@KD106161153008.au-net.ne.jp] has joined #wesnoth-dev
20160305 02:01:16-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 02:01:17< travis-ci> wesnoth/wesnoth#8740 (master - 2ca0503 : Charles Dang): The build has errored.
20160305 02:01:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113810277
20160305 02:01:17-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 02:06:07< irker779> wesnoth: loonycyborg wesnoth:master d09861b7d235 / / (363 files in 49 dirs): pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/d09861b7d2354ac277a5c71eed9b9ce94f05c761
20160305 02:12:36< Aginor> I dno not think we can release if travis is unhappy
20160305 02:12:41< celticminstrel> Why is the build erroiung...
20160305 02:12:45< celticminstrel> ^ing
20160305 02:12:50< celticminstrel> ^erroring
20160305 02:13:20< celticminstrel> Oh, it's ! not X so it's probably fine.
20160305 02:16:07< irker779> wesnoth: loonycyborg wesnoth:master d410c653f7f1 / Doxyfile changelog players_changelog src/wesconfig.h: Version bump for release 1.13.3 https://github.com/wesnoth/wesnoth/commit/d410c653f7f1d2166b0e9be3f43d7abfb497cba5
20160305 02:21:50-!- gfgtdf_ [~chatzilla@f054140045.adsl.alicedsl.de] has joined #wesnoth-dev
20160305 02:23:37-!- gfgtdf [~chatzilla@f050182048.adsl.alicedsl.de] has quit [Ping timeout: 240 seconds]
20160305 02:23:45-!- gfgtdf_ is now known as gfgtdf
20160305 02:26:38< vultraz> looks like travis screwiness
20160305 02:29:17-!- Appleman1234 [~Appleman1@KD106161153008.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20160305 02:31:39< celticminstrel> Ohhh, looks like formula functions are semicolon-terminated.
20160305 02:33:00< loonycyborg> shadowm: I don't have xdelta installed and package called xdelta in gentoo installs only xdelta3 command with totally different syntax
20160305 02:33:30< loonycyborg> where exactly does that xdelta command come from?
20160305 02:35:51< wedge009> Is anyone aware that story map travelling scenes are broken at the moment? (vultraz? Aginor?)
20160305 02:36:33< wedge009> Possibly due to recent SDL2/gui changes?
20160305 02:37:22< loonycyborg> actually nwm, gentoo has it as slotted package and can install version 1 too..
20160305 02:38:21< loonycyborg> wedge009: how exactly broken?
20160305 02:38:30< wedge009> Wow, I get a crash on starting the Heir to the Throne campaign (as soon as the game map first loads).
20160305 02:38:43< celticminstrel> :(
20160305 02:39:02< celticminstrel> I started AToTB on almost the latest master and it was fine.
20160305 02:39:07< celticminstrel> Is it something specific to HTTT?
20160305 02:39:26< wedge009> loonycyborg: No map background, but the red dots indicating travel are there. You only see the game map as the background.
20160305 02:39:48< wedge009> Was going to make a report, but checking if people are aware of it first, or if it's just on my build.
20160305 02:40:09< wedge009> celticminstrel: Don't know - I haven't updated master since yesterday (will recompile soon).
20160305 02:40:11-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 02:40:12< travis-ci> wesnoth/wesnoth#8742 (master - dee454a : gfgtdf): The build has errored.
20160305 02:40:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113813851
20160305 02:40:12-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 02:41:15< loonycyborg> would broken HTTT be a release blocker for 1.13? :P
20160305 02:41:43< vultraz> gfgtdf: what are all those "host: idling in Game waiting for not game" messages in travis?
20160305 02:41:55< vultraz> loonycyborg: would be if I could reproduce it myself :/
20160305 02:42:01< wedge009> I'm pulling master now.
20160305 02:43:14< vultraz> wedge009: can confirm the journeymaps are broken :|
20160305 02:43:32< wedge009> D:
20160305 02:43:42< vultraz> Aginor: we need you!
20160305 02:43:49< gfgtdf> vultraz: they mean the the travis mp test are borken
20160305 02:44:02< wedge009> It's 15:44 for him.
20160305 02:44:04< gfgtdf> vultraz: note that this desnt impl that mp is broken
20160305 02:47:26< Aginor> making food atm
20160305 02:48:08< celticminstrel> I have to wonder why the heck the formula engine includes whitespace in the token stream.
20160305 02:51:14< loonycyborg> seems HTTT doesn't crash for me
20160305 02:51:37< loonycyborg> should I wait for fix to journey maps?
20160305 02:51:51< vultraz> yes, I think that would be best
20160305 02:52:00< vultraz> it seems like it should be a simple fix
20160305 02:52:24< celticminstrel> If it really is a simple fix, then sure, wait. If it turns out to be more complicated...
20160305 02:52:57< celticminstrel> So, I was right that not all formula contexts support functions.
20160305 02:53:35< celticminstrel> $(...) formulas do not.
20160305 02:54:08< celticminstrel> Nor do unit filter formulas.
20160305 02:54:20< celticminstrel> Where was tformula again...
20160305 02:54:35< celticminstrel> Ah, gui/auxiliary
20160305 02:55:09< celticminstrel> So GUI2 formulas may support functions.
20160305 02:55:24-!- mjs-de [~mjs-de@x4db69e01.dyn.telefonica.de] has quit [Remote host closed the connection]
20160305 02:55:55< irker779> wesnoth: gfgtdf wesnoth:master 08715b422966 / src/playsingle_controller.cpp: make sure to send last action before ending the scenario https://github.com/wesnoth/wesnoth/commit/08715b42296667f4291eb71397a2a08af23fd09d
20160305 02:57:15< Aginor> pl
20160305 02:57:22< Aginor> here now, development machine booted
20160305 02:57:30< celticminstrel> Or they may not; tformula supports them, but I have no idea whether GUI2 makes use of that.
20160305 02:57:51< celticminstrel> Well, let's see if my fix works.
20160305 02:57:53< Aginor> 15:44 < wedge009> It's 15:44 for him.
20160305 02:57:58< Aginor> Well spotted :D
20160305 02:58:21< Aginor> what's the fire?
20160305 02:58:25< Aginor> vultraz?
20160305 02:58:51< vultraz> Aginor: journey maps don't show their backgrounds
20160305 02:59:03< vultraz> Aginor: they show the game UI instead
20160305 02:59:11< vultraz> but they do show the little blinking journey markers
20160305 02:59:16< Aginor> vultraz: journey maps?
20160305 02:59:20< Aginor> is that bigmap?
20160305 02:59:38< vultraz> Aginor: storyscrrens with map backgrounds and little blinking images to indicate location
20160305 02:59:42< vultraz> the map background isn't drawn
20160305 02:59:44< Aginor> aka, bigmap
20160305 02:59:55< Aginor> what's this about crash in backlog?
20160305 03:00:08< vultraz> I cannot reproduce any crash
20160305 03:00:15< celticminstrel> That was wedge009. Others couldn't reproduce.
20160305 03:00:33< wedge009> Yeah, still rebuilding.
20160305 03:00:52< celticminstrel> Sounds like storyscreen needs to remember which images were previously displayed and redraw them, or something?
20160305 03:00:52< Aginor> doing a first build here atm too
20160305 03:00:56< celticminstrel> I dunno.
20160305 03:01:14 * celticminstrel is, coincidentally, also currently building; but on a branch, not master.
20160305 03:01:17< Aginor> celticminstrel: the storyscreen needs to be rewritten using proper gui1/gui2 semantics at some point :)
20160305 03:01:41< Aginor> I should have checked branch before kicking off my build
20160305 03:01:43< celticminstrel> BTW, did anyone ever make any progress on the OSX fonts issue?
20160305 03:01:43< Aginor> oh well
20160305 03:01:49< Aginor> I think I am on master :D
20160305 03:01:55< celticminstrel> If that's solved we could go ahead and make GUI1 use ttext.
20160305 03:02:44< Aginor> also, in general; shouting for me on IRC won't help. Send me an email when you want to make sure I see a request for attention :)
20160305 03:03:01< celticminstrel> Hey, it helped this time!
20160305 03:03:34< Aginor> only because I've been sitting with a device all day long, keeping an eye on the channel. That's normally not what I do on a weekend :D
20160305 03:03:40< celticminstrel> Ah.
20160305 03:03:58< celticminstrel> It's still Friday here.
20160305 03:04:15< Aginor> it's Saturday afternoon for me
20160305 03:04:20< vultraz> same here
20160305 03:04:26< Aginor> most days, I'd be out and about at this time
20160305 03:04:51< wedge009> Yeah, this is the first weekend I haven't had anything on for quite some time. x.x
20160305 03:05:01-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Ping timeout: 248 seconds]
20160305 03:05:02< vultraz> unlike myself, Aginor has a life outside wesnoth :P
20160305 03:05:41< Aginor> ok, started wesnoth
20160305 03:05:46< Aginor> starting httt now
20160305 03:05:57< Aginor> on normal
20160305 03:06:04< vultraz> don't skip the storyscreens with esc, do next next next next next
20160305 03:06:07< wedge009> Oh, I see preferences_display.cpp has been renamed...
20160305 03:06:14< Aginor> do I snooze through the story or wait?
20160305 03:06:26< celticminstrel> Did someone forget to update the MSVC project or something?
20160305 03:06:29< wedge009> HTTT doesn't have a travel map on the first scenario.
20160305 03:06:29< vultraz> wedge009: no it hasn't?
20160305 03:06:40< vultraz> wedge009: but it shows up ... O_O
20160305 03:06:42< celticminstrel> vultraz: Wasn't it removed?
20160305 03:06:51< celticminstrel> Or is that the GUI2 file?
20160305 03:06:55< vultraz> wedge009, celticminstrel: I removed game_preferences_display.cpp
20160305 03:06:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160305 03:06:59< celticminstrel> Ah, okay.
20160305 03:07:16< vultraz> wedge009, celticminstrel: preferences_display.*pp is still a thing
20160305 03:07:28< wedge009> Ah, okay, I need to check what's changed in the VC9 project file.
20160305 03:07:29< Aginor> ok, bigmap issue confirmed
20160305 03:07:32< vultraz> wedge009: anyway, if httt s1 doesn't have a journeymap...why is it showing up as one with tbe bugged behavior
20160305 03:07:59< celticminstrel> It probably has a one-frame journey-map?
20160305 03:08:11< wedge009> vultraz: Two separate issues. I saw the journey map problem thingy in Legend of Wesmere scenario 2 and An Orcish Incursion scenario 1.
20160305 03:08:11< celticminstrel> Like, show the map, then superimpose crossed swords at some point.
20160305 03:08:18< celticminstrel> That would be the norm in a first scenario.
20160305 03:08:19< vultraz> Aginor, wedge009: the journey map works correctly in Two Brothers O_O
20160305 03:08:25< wedge009> vultraz: When I start HTTT, it crashed on entering game map.
20160305 03:08:48< wedge009> Okay, gimme some time to build stuffs and I'll report what I have.
20160305 03:09:25< vultraz> wait, htt does have a journey track in s1
20160305 03:10:19-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20160305 03:10:37< vultraz> celticminstrel: since we have a delay, could you confirm if https://gna.org/bugs/index.php?21943 is still a thing?
20160305 03:11:49< vultraz> i think it's a simple 'can switch apps in fullscreen' thing
20160305 03:13:34< celticminstrel> Activating fullscreen mode enters standard OSX fullscreen (blanking out the other monitor :( but that's normal), and I can switch between it and other spaces just fine.
20160305 03:13:35< celticminstrel> But...
20160305 03:14:36< wedge009> vultraz: Can you confirm it's just game_preferences_display.cpp that you removed? It needs to be removed from wesnoth.vcproj.
20160305 03:14:49< vultraz> yes that was it
20160305 03:15:03< wedge009> vultraz: Do you need me to make a PR for that?
20160305 03:15:15< celticminstrel> I think there is in fact a problem.
20160305 03:15:24< vultraz> wedge009: just commit the change
20160305 03:15:32< celticminstrel> He doesn't have commit access.
20160305 03:15:35< wedge009> vultraz: I can't. You can. :p
20160305 03:16:07< celticminstrel> So basically, now that Wesnoth is fullscreened, it's not responding to any input.
20160305 03:16:24< celticminstrel> If I switch to it using the arrow keys, it works, but then I'm shunted to space 1 for some reason.
20160305 03:16:41< celticminstrel> I can switch to it with Mission Control, but it seems like I can't do anything - I just get the spinning beachball.
20160305 03:16:49< vultraz> wedge009: what?
20160305 03:16:54< vultraz> ....
20160305 03:16:57< vultraz> oh
20160305 03:16:58< celticminstrel> Ah!
20160305 03:17:01< vultraz> someone rectify this immediately 
20160305 03:17:21< celticminstrel> It finally started responding again, and I exited fullscreen.
20160305 03:17:26< celticminstrel> It may be fine on newer computers, then.
20160305 03:17:50< celticminstrel> The resolution combobox has changed and no longer matches the actual resolution of the window, though.
20160305 03:17:58< celticminstrel> (It's instead the resolution of my screen.)
20160305 03:18:14< celticminstrel> vultraz: So, there you go.
20160305 03:18:25< celticminstrel> Full disclosure: this is on my branch, not master.
20160305 03:18:58< celticminstrel> The last common commit is 5615fe368647b27ba26012a53dcef664ba17e444, I think.
20160305 03:19:09< celticminstrel> Oh wait, that's not true.
20160305 03:19:29< celticminstrel> Last common commit is fab6633bc4945f746adb8eed4e83be7e078283eb.
20160305 03:27:12< wedge009> On Linux, I don't get the crash on start of HttT, but the journey map problem is there (that's where I was crashing on Windows, so I didn't notice it before).
20160305 03:27:12-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160305 03:28:06< wedge009> vultraz: PR #617.
20160305 03:29:36< celticminstrel> There was no corresponding header?
20160305 03:29:40< irker779> wesnoth: Wedge009 wesnoth:master cf37d0828843 / projectfiles/VC9/wesnoth.vcproj: game_preferences_display.cpp has been removed. https://github.com/wesnoth/wesnoth/commit/cf37d08288431ad1a6b10df3402fb1fdb130801d
20160305 03:29:42< irker779> wesnoth: Charles Dang wesnoth:master 5662ba832a02 / projectfiles/VC9/wesnoth.vcproj: Merge pull request #617 from Wedge009/vc9_update https://github.com/wesnoth/wesnoth/commit/5662ba832a02aed63613c6e381ef419940d924ec
20160305 03:31:01< wedge009> celticminstrel: Not that I could find (I did check).
20160305 03:31:12< vultraz> no there isn't
20160305 03:31:24< celticminstrel> Huh.
20160305 03:31:30-!- Appleman1234 [~Appleman1@KD106161153008.au-net.ne.jp] has joined #wesnoth-dev
20160305 03:33:14< vultraz> the functions' headers were in preferences_display.hpp
20160305 03:33:25< celticminstrel> Prototypes, not headers.
20160305 03:33:30< celticminstrel> Header refers to the file.
20160305 03:33:41< celticminstrel> Prototype refers to the declaration of function signature without a body.
20160305 03:33:52< vultraz> I see
20160305 03:34:17< celticminstrel> So I have now made it possible to define functions in all formulas - if the called doesn't provide a function table, a temporary one is created.
20160305 03:38:46< loonycyborg> Why wedge009 doesn't have commit rights? Who is even responsible for giving commit rights now anyway? :P
20160305 03:39:09< celticminstrel> I'm not entirely sure, but I suspect shadowm.
20160305 03:39:37< wedge009> I think it's a bit of a risk giving me push access. I'll probably break something. x.x
20160305 03:40:40< vultraz> Then be careful 
20160305 03:40:49< vultraz> Hell, I got push access just to maintain a projectfile
20160305 03:40:59< celticminstrel> If he doesn't want push access though, that's fine.
20160305 03:41:04< celticminstrel> In my opinion.
20160305 03:41:05< vultraz> You can still use PRs for features you don't feel comfortable merging directly
20160305 03:41:20< loonycyborg> you can just make feature branches
20160305 03:41:22< wedge009> I'd probably only update project files and spelling. I'd push everything else through PRs.
20160305 03:41:33< loonycyborg> and merge them after you gave them enough testing
20160305 03:41:39< celticminstrel> Actually, I personally highly recommend using PRs for anything big.
20160305 03:41:50< celticminstrel> Makes it easy for others to review them.
20160305 03:41:55< wedge009> Yep.
20160305 03:42:05< Aginor> I agree with that
20160305 03:42:07< vultraz> basically all of us use PRs for big things
20160305 03:42:11< celticminstrel> (You can PR from a feature branch to master, if you want. Aginor did it, possibly twice.)
20160305 03:42:17< shadowm> celticminstrel: I asked wedge009 some months ago how comfortable he was with our codebase and the answer was inconclusive.
20160305 03:42:25< shadowm> Er, loonycyborg.
20160305 03:42:29< shadowm> You were asking the 'why'.
20160305 03:42:58< loonycyborg> ok
20160305 03:43:49< Aginor> ok, I've got a workaround
20160305 03:43:53< Aginor> it's not pretty though
20160305 03:44:05< vultraz> we just need something for the release to go through
20160305 03:44:08< Aginor> trying to find the root cause instead
20160305 03:44:31< Aginor> you get the game screen for a bit before bigmap appears. It's faaaar from ideal.
20160305 03:44:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160305 03:48:13< Aginor> ok, root cause found
20160305 03:48:16< shadowm> loonycyborg: I just kept using xdelta 2 because Ivanovic was using xdelta 2. IIRC xdelta 3 has a different command line syntax and format.
20160305 03:48:22< shadowm> file format.
20160305 03:48:44< shadowm> I also considered dropping xdelta patches around 1.13.2.
20160305 03:49:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160305 03:49:38< loonycyborg> yes xdelta3 has different syntax which I found hard to convert
20160305 03:49:51< celticminstrel> I wonder if it's possible for the patch to be larger than the download.
20160305 03:49:59< loonycyborg> but I installed xdelta1 instead
20160305 03:50:16< celticminstrel> ...there's a lot of images and stuff, so I guess it's vanishingly unlikely even if technically possible.
20160305 03:50:44< shadowm> Can people see this? https://sourceforge.net/projects/wesnoth/files/wesnoth-1.12/wesnoth-1.12.5/wesnoth-1.12.4.tar-wesnoth-1.12.5.tar.xdelta/stats/timeline
20160305 03:51:21< shadowm> Here's a better time frame: https://sourceforge.net/projects/wesnoth/files/wesnoth-1.12/wesnoth-1.12.5/wesnoth-1.12.4.tar-wesnoth-1.12.5.tar.xdelta/stats/timeline?dates=2015-09-28+to+2016-03-05
20160305 03:51:46< shadowm> This suggests to me that there's no value in worrying about producing xdelta patches anymore.
20160305 03:52:21< wedge009> I can see both graphs.
20160305 03:53:08< vultraz> same
20160305 03:55:41< shadowm> If you really _must_, xdelta 2 is installed on the web VM, which is where I made releases.
20160305 04:05:20-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 04:05:21< travis-ci> wesnoth/wesnoth#8743 (master - 6aa060e : Charles Dang): The build has errored.
20160305 04:05:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113817554
20160305 04:05:21-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 04:16:23< wedge009> Rebuilt from master. I started HttT and skipped all story dialogue and I reached the start of the game map okay. In Linux, if I step through the story scenes, I get to 'bigmap' scene which doesn't show properly. In Windows, reaching that 'bigmap' scene results in a crash. Will try to find what the crash is.
20160305 04:17:32< Aginor> I'm writing a commit message right now
20160305 04:17:42< Aginor> for bigmap fix
20160305 04:17:52< Aginor> it's not resize safe though, but it looks adequate
20160305 04:17:56< wedge009> I like the new hotkey menu icon.
20160305 04:18:03< celticminstrel> Me too.
20160305 04:18:15< wedge009> People should stop resizing during story scenes. :p
20160305 04:19:07< irker779> wesnoth: Andreas Löf wesnoth:master b308df8c7eb3 / src/ (8 files in 3 dirs): Make sure bigmap isn't overdrawn by in-game UI https://github.com/wesnoth/wesnoth/commit/b308df8c7eb3b3c767580f08a454a2967405646a
20160305 04:19:09< Aginor> I couldn't agree more
20160305 04:19:09< irker779> wesnoth: Andreas Löf wesnoth:master 62ce4ff5a852 / projectfiles/VC9/wesnoth.vcproj: Merge branch 'master' of github.com:wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/62ce4ff5a8524b26c0b1be33afa59452afa70314
20160305 04:19:17< Aginor> now to see if I can reproduce your crash
20160305 04:19:31< Aginor> r
20160305 04:20:19< Aginor> ummm
20160305 04:20:26< Aginor> the skip button restarts the story
20160305 04:20:33< Aginor> that's not desired, is it
20160305 04:20:42< celticminstrel> Uh what.
20160305 04:20:49< celticminstrel> Very much not.
20160305 04:21:30 * Aginor builds an earlier revision
20160305 04:27:08< Aginor> hmm
20160305 04:27:12< Aginor> was most definitively me
20160305 04:27:18< Aginor> I should have noticed before pushing
20160305 04:28:42< wedge009> Well now, that's bloody annoying. Running in debug mode doesn't exhibit the crash. >.<
20160305 04:28:54< wedge009> Aginor: Does this mean I shouldn't test your commit yet?
20160305 04:29:07< Aginor> wedge009: no, it'd be a bit pointless
20160305 04:29:31< Aginor> ok, fixed
20160305 04:29:49< celticminstrel> You can still debug in release mode.
20160305 04:30:22< celticminstrel> As long as you have the symbol file.
20160305 04:31:11< irker779> wesnoth: Andreas Löf wesnoth:master 5b82cb041821 / src/storyscreen/interface.cpp: Fix the "skip" button in story screens. https://github.com/wesnoth/wesnoth/commit/5b82cb0418211843da338ad73a488a0900526d24
20160305 04:31:13< Aginor> there
20160305 04:31:17< Aginor> go ahead
20160305 04:31:24< Aginor> also, I cannot reproduce the crash
20160305 04:31:27< Aginor> what's the steps?
20160305 04:32:31-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 04:32:32< travis-ci> wesnoth/wesnoth#8745 (master - 8bff482 : loonycyborg): The build has errored.
20160305 04:32:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113821738
20160305 04:32:32-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 04:33:04< wedge009> I did that, actually. Run release build in debug mode. Still didn't happen. Ran stand-alone release build -> crash. At this point, looks like it's just me - no-one else has the problem.
20160305 04:33:16< wedge009> Aginor: Okay, I'll try it nwo.
20160305 04:33:16< wedge009> now
20160305 04:33:51< wedge009> Oh, crash was in sdl2.dll, apparently.
20160305 04:34:13< wedge009> (Attempted debugging after the crash.)
20160305 04:34:24< Aginor> vultraz, celticminstrel, etc please check that my two commits didn't cause any other regressions
20160305 04:34:34< Aginor> wedge009: do you have a full stacktrace?
20160305 04:34:47< Aginor> what was the part of wesnoth that called into sdl2?
20160305 04:35:31< wedge009> No, because everything is release build.
20160305 04:35:39< wedge009> I'll worry about it later. Going to try your commit now.
20160305 04:37:05< wedge009> Yay, header modifications means more rebuilding.
20160305 04:37:12< Aginor> sorry
20160305 04:37:19< Aginor> it's the worst two headers too
20160305 04:37:31< wedge009> Nah, not your fault. It's a general complaint, not levelled at you specifically.
20160305 04:38:10< vultraz> Aginor: confirmed storyscreen fix
20160305 04:38:15< wedge009> Whee!
20160305 04:38:19< Aginor> regressions though!
20160305 04:38:24< Aginor> check for regressions
20160305 04:38:36< Aginor> I do not want to have inadvertedly broken something else
20160305 04:38:51< Aginor> including mp, editor, replays
20160305 04:40:05< vultraz> interesting...
20160305 04:40:47< wedge009> Looking at the code changes, isn't in okay if forwards/backwards/skip works?
20160305 04:40:49< wedge009> What's interesting?
20160305 04:40:52< wedge009> Found something?
20160305 04:41:20< vultraz> Aginor: I'm not sure this counts as a regression but... if you resize during the stroyscreen, you'll see the game ui flash behind it for a second. then, later, if you resize in some other part of the game, you'll see the storyscreen text flash behind it for a second
20160305 04:41:44< vultraz> seems like there's a copy of the framebuffer being kept somewhere
20160305 04:41:48< vultraz> it's minor
20160305 04:41:50< wedge009> I think Aginor mentioned safe resizing isn't guaranteed.
20160305 04:41:58< vultraz> well the resizing works fine
20160305 04:42:13< celticminstrel> ...which too headers changed? display.hpp?
20160305 04:42:16< celticminstrel> ^two
20160305 04:42:18< vultraz> it's just that you can see a flash of certain previous screens at times
20160305 04:42:28< Aginor> vultraz: that's to be expected, it's the same cause as any other flickering
20160305 04:42:37< vultraz> ah
20160305 04:42:40< vultraz> the flip() calls?
20160305 04:42:46< Aginor> basically, yes
20160305 04:42:52< vultraz> ok
20160305 04:42:57< Aginor> not doing intermediate flips() would fix that
20160305 04:43:03< vultraz> I don't notice any obvious regressions, then
20160305 04:43:11< Aginor> good
20160305 04:43:58< wedge009> How did you build so quickly?
20160305 04:44:11< vultraz> what do you mean, quickly :P
20160305 04:44:17< vultraz> it took several minutes
20160305 04:44:50< wedge009> My computer isn't slow. But maybe the VC compiler is single-threaded by default.
20160305 04:45:05< vultraz> the VC compiler is so damn slow
20160305 04:45:11< vultraz> I believe it runs the unit tests while building
20160305 04:45:19< vultraz> I think that's what aquelia said
20160305 04:45:31< celticminstrel> This is a good thing.
20160305 04:45:46< celticminstrel> With the caveat that it should probably be in release builds only.
20160305 04:45:54< vultraz> it takes twice as long to build in vc than in cb
20160305 04:45:56< vultraz> or more
20160305 04:47:57< wedge009> The unit tests are run at the end, I thought.
20160305 04:48:59< wedge009> Possibly more optimisations going on.
20160305 04:49:23< wedge009> My old Core 2 takes a while to do the Linux build.
20160305 04:50:56 * Aginor times a full build
20160305 04:53:21< Aginor> real	2m28.938s
20160305 04:53:21< Aginor> user	13m18.031s
20160305 04:53:21< Aginor> sys	2m9.016s
20160305 04:53:44< Aginor> ~ 2.5 minutes
20160305 04:53:49< Aginor> using all my cores
20160305 04:57:45< Aginor> is there anything else I can be of assistance with at the moment?
20160305 04:58:39< vultraz> uhhhh 
20160305 04:58:41< vultraz> I don't think so
20160305 04:59:28< Aginor> ok
20160305 04:59:53< Aginor> next time, can we please have a freeze in preparation for the release and bit more testing?
20160305 05:00:26< Aginor> that'll make it easier to ensure that the quality is at a sufficient planning and everything doesn't have to be an emergency :)
20160305 05:11:16< wedge009> Aginor: Thanks, Aginor. 'bigmap' seems fixed for me, and as a result I'm not getting the crash that I was before either.
20160305 05:13:17< Aginor> wedge009: excellent
20160305 05:13:35< celticminstrel> So they were likely related, then.
20160305 05:13:36< Aginor> wedge009: thank you for confirming
20160305 05:13:45< celticminstrel> Should we poke loonycyborg now?
20160305 05:14:03< Aginor> probably ;)
20160305 05:14:22< wedge009> Confirmed for both Windows and Linux.
20160305 05:14:24< wedge009> No worries!
20160305 05:28:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160305 05:37:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160305 05:39:25< wedge009> Ugh, that was weird. Don't normally get blackouts unless in really bad storms.
20160305 05:40:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160305 05:41:45< loonycyborg> hmm ok
20160305 05:42:33-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160305 05:42:36-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20160305 05:44:30-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 05:44:31< travis-ci> wesnoth/wesnoth#8747 (master - fccb00b : loonycyborg): The build has errored.
20160305 05:44:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113823942
20160305 05:44:31-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 05:45:30-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 05:45:31< travis-ci> wesnoth/wesnoth#8748 (master - 8100f7c : Charles Dang): The build has errored.
20160305 05:45:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113824422
20160305 05:45:31-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 05:53:36-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160305 05:56:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160305 06:00:54-!- pydsigner_ [~pydsigner@unaffiliated/pydsigner] has joined #wesnoth-dev
20160305 06:01:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160305 06:02:35-!- pydsigner [~pydsigner@unaffiliated/pydsigner] has quit [Quit: Leaving]
20160305 06:02:44-!- pydsigner_ is now known as pydsigner
20160305 06:09:48< loonycyborg> I've uploaded tarball, checksum and xdelta
20160305 06:18:12< shadowm> loonycyborg: ... Where is the tag?
20160305 06:19:54< shadowm> And where's the SHA256 for the tarball in files.w.o/releases/ ?
20160305 06:22:01< shadowm> Also, did you email the packagers already?
20160305 06:22:05< loonycyborg> checksum uploaded now
20160305 06:25:09< loonycyborg> git tag $VERSION HEAD -m "Wesnoth $VERSION" && git push $VERSION
20160305 06:25:18< loonycyborg> it complained about this command
20160305 06:25:44< shadowm> And what did it say?
20160305 06:26:07< shadowm> Ugh, no.
20160305 06:26:21< shadowm> It's git tag -a.
20160305 06:26:50< shadowm> git tag -a -m "Wesnoth $VERSION" $VERSION HEAD && git push $VERSION
20160305 06:27:23-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160305 06:27:59< loonycyborg> it complained about second part
20160305 06:28:01< celticminstrel> But you substitute $VERSION manually, rigtht?
20160305 06:28:13-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160305 06:28:18< shadowm> loonycyborg, delete that tag you created locally before trying to push it again.
20160305 06:28:22< loonycyborg> git push, it treated version there as repo name
20160305 06:28:29< shadowm> It's bad because it's not annotated (-a).
20160305 06:28:42< shadowm> Okay, add origin before the object name to push then.
20160305 06:28:54< shadowm> Or whatever you call the upstream remote if it's not origin.
20160305 06:29:59< loonycyborg> celticminstrel: yes
20160305 06:31:05< irker779> wesnoth: loonycyborg wesnoth: 5b82cb041821 tagged as 1.13.3
20160305 06:32:22< celticminstrel> What does annotating do, anyway?
20160305 06:33:06< shadowm> "Annotated tags are meant for release while lightweight tags are meant for private or temporary object labels. For this reason, some git commands for naming objects (like git describe) will ignore lightweight tags by default."
20160305 06:33:15-!- Appleman1234 [~Appleman1@KD106161153008.au-net.ne.jp] has quit [Remote host closed the connection]
20160305 06:34:30< shadowm> loonycyborg: If you are done now you must bump the version number and email packagers.
20160305 06:35:02< vultraz> loonycyborg: much thanks :)
20160305 06:35:03< shadowm> The list is in /scratch/packagers-list.
20160305 06:35:03< loonycyborg> there are also instructions for uploading macro-reference
20160305 06:35:22< shadowm> Yse.
20160305 06:35:27-!- vultraz changed the topic of #wesnoth-dev to: 1.13.3 released, announcing "soon" | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160305 06:36:00< shadowm> You are not Ivanovic. You don't get to say "\"soon\"".
20160305 06:36:16< loonycyborg> it says permission denied when I try to upload macro-reference
20160305 06:36:23< shadowm> "soon", maybe, but not "\"soon\"".
20160305 06:36:30< loonycyborg> scp -P 10222 macro-reference.html loonycyborg@wesnoth.org:/srv/www/html/macro-reference.html
20160305 06:37:03< shadowm> 06:36:52 shadowm@website:~/WWW/html$ sudo chmod g+w macro-reference.html
20160305 06:37:05< shadowm> Try again.
20160305 06:37:22< shadowm> Wait, don't try again.
20160305 06:37:47< shadowm> 06:37:30 shadowm@website:~/WWW/html$ sudo chown :files macro-reference.html
20160305 06:37:50< shadowm> Okay, now try again.
20160305 06:38:08< loonycyborg> done
20160305 06:39:24< shadowm> Oh and when emailing, please make sure to use BCC.
20160305 06:41:21-!- Kwandulin [~Miranda@p200300760F0BD497049E346E71A9888F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 06:43:56< loonycyborg> you're mailing them from your own address and I should do the same?
20160305 06:44:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160305 06:44:19< shadowm> Do whatever you want in that regard.
20160305 06:45:07< shadowm> I use my own address because it's easier for me and I don't trust wesnoth.org to send mail.
20160305 06:57:43< vultraz> shadowm: if I write the announcement, will you do the screenshot strip
20160305 07:04:28< loonycyborg> I've sent mail to packagers
20160305 07:04:43< loonycyborg> noted that sdl2 is used by default too
20160305 07:07:11< loonycyborg> for post-release version bump I shouldn't do anything with changelogs right?
20160305 07:07:41< vultraz> I think you're supposed to add a header for the new +dev version
20160305 07:08:26-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 07:08:27< travis-ci> wesnoth/wesnoth#8749 (master - 059f329 : loonycyborg): The build has errored.
20160305 07:08:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113825261
20160305 07:08:27-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 07:13:50< loonycyborg> nope they're added in subsequent commits it seems
20160305 07:14:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160305 07:15:34< loonycyborg> hmm
20160305 07:17:26< loonycyborg> or not
20160305 07:17:41< vultraz> why not just add them
20160305 07:19:07< shadowm> They are added with the bump.
20160305 07:20:14< shadowm> vultraz: Potentially.
20160305 07:20:20< vultraz> Alright
20160305 07:20:52< vultraz> BTW, I did my own fiddling with double click stuff yesterday and didn't get anywhere
20160305 07:21:03< shadowm> "06:37:30 shadowm@website:~/WWW/html$ sudo chown :files macro-reference.html
20160305 07:21:07< vultraz> Even took your paste and made it build, but it doesn't work
20160305 07:21:08< shadowm> Oops.
20160305 07:21:22< shadowm> "I wonder if we should just drop the whiteboard right now."
20160305 07:21:35< shadowm> No.
20160305 07:21:39< shadowm> You = community manager.
20160305 07:21:44< shadowm> Forums = community.
20160305 07:21:50< shadowm> Decision making = make a poll.
20160305 07:21:54< vultraz> Tried hooking tlistbox into the dispatcher in front_pre_child, doesn't work either.
20160305 07:21:59< vultraz> poll, you say?
20160305 07:22:01< vultraz> Alright
20160305 07:22:03< vultraz> I will make this poll
20160305 07:22:37< shadowm> I said several times that I'd advocate for removing the whiteboard if it'll simplify or fix code if someone can figure out how much it'll be missed by players (if at all).
20160305 07:22:55< shadowm> Developer opinions on the matter are invalid by default because developers don't play the game, especially not multiplayer.
20160305 07:23:22< celticminstrel> It's ironic but true.
20160305 07:23:42< celticminstrel> I don't play very much at all, and when I do, it's almost always campaigns.
20160305 07:24:00< loonycyborg> I played some mp in the past, but I'm a neophile, I change games a lot
20160305 07:24:09< vultraz> I used to play a lot of MP...
20160305 07:24:40-!- travis-ci [~travis-ci@ec2-54-226-94-57.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 07:24:41< travis-ci> wesnoth/wesnoth#8750 (master - d09861b : loonycyborg): The build has errored.
20160305 07:24:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113826221
20160305 07:24:42-!- travis-ci [~travis-ci@ec2-54-226-94-57.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 07:26:07< irker779> wesnoth: loonycyborg wesnoth:master e9594367e781 / Doxyfile changelog players_changelog src/wesconfig.h: Post release version bump https://github.com/wesnoth/wesnoth/commit/e9594367e7814d8c259f83b8ce5fb714f3581a44
20160305 08:08:29-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160305 08:09:04-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 08:09:04< travis-ci> wesnoth/wesnoth#8751 (master - d410c65 : loonycyborg): The build has errored.
20160305 08:09:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113827192
20160305 08:09:04-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 08:09:25< wedge009> vultraz: Did you or anyone apply gui2 to load game menu? https://gna.org/bugs/?15763 Looks to be resolved now.
20160305 08:09:49< vultraz> Load Game is gui2
20160305 08:09:56< vultraz> what is this about a Delete Save dialog
20160305 08:10:59< shadowm> It's the confirmation prompt that's enabled by default.
20160305 08:11:12< vultraz> ah
20160305 08:11:19< wedge009> Yep.
20160305 08:11:33< wedge009> I just retested it, seems okay now.
20160305 08:11:35< vultraz> but yes, since it's gui2 that should be fixed
20160305 08:11:41< wedge009> Yay!
20160305 08:11:42< vultraz> mark as fix and assign to me
20160305 08:11:46< vultraz> fixed*
20160305 08:12:12< wedge009> Don't think I have permissions there.
20160305 08:12:29< wedge009> I think https://gna.org/bugs/?11276 is related, but don't have a suitable scenario to test it.
20160305 08:13:54< vultraz> right, you don't
20160305 08:16:56< vultraz> I plan to convert recruit and recall to gui2
20160305 08:17:44< wedge009> Okay, cool.
20160305 08:24:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160305 08:25:36-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 08:25:37< travis-ci> wesnoth/wesnoth#8752 (master - 08715b4 : gfgtdf): The build failed.
20160305 08:25:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113831302
20160305 08:25:37-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 08:28:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160305 08:33:49-!- Kwandulin [~Miranda@p200300760F0BD497049E346E71A9888F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160305 08:42:24-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Quit: Leaving.]
20160305 08:42:36-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160305 08:46:22-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160305 08:48:09-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160305 08:50:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160305 08:51:31-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160305 08:51:49-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160305 09:01:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160305 09:01:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160305 09:02:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160305 09:02:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160305 09:04:18-!- Kwandulin [~Miranda@p200300760F0BD4978C7CD66F1ACDC290.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 09:05:39< wedge009> Aginor, vultraz: On 'bigmaps' where there is an actual journey (as opposed to a single marker showing the location of the upcoming battle), it looks like 'bigmap' is being redrawn every single frame, overwriting the previous 'dot' marking the stage of the journey.
20160305 09:06:03< wedge009> It's not a big issue, and only noticeable if you knew how the journeys were marked on the map previously.
20160305 09:06:14< wedge009> But it is a 'regression' from the previous behaviour.
20160305 09:06:56< wedge009> (I just reloaded Legend of Wesmere s2 to reproduce this.)
20160305 09:08:29< wedge009> Ditto for s3, so presumably any scenario with a journey map is affected.
20160305 09:18:01-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 09:18:02< travis-ci> wesnoth/wesnoth#8754 (master - 5662ba8 : Charles Dang): The build failed.
20160305 09:18:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113834608
20160305 09:18:02-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 09:20:14< Aginor> wedge009: I'd appreciate it if you could raise a bug, maybe with a save I can load
20160305 09:20:39< wedge009> Aginor: Sure.
20160305 09:20:57< Aginor> although itäd be good to convert story screens to GUI2 too actually
20160305 09:23:39< Aginor> wedge009: thank you
20160305 09:23:50 * Aginor grumbles more
20160305 09:24:14< Aginor> let's plan a release for a month from now, with a code freeze for 4 days before the release
20160305 09:24:28< Aginor> during that window, only release blockers should be accepted
20160305 09:25:10< vultraz> Aginor: release in a month sounds good
20160305 09:25:22< vultraz> will you deal with the dropping of sdl1.2 before then?
20160305 09:25:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160305 09:25:55< Aginor> vultraz: I'd like to watch the fallout before making that decision
20160305 09:26:02< vultraz> Fallout?
20160305 09:26:23< Aginor> we've just introduced some major changes, there may be fallout from them
20160305 09:27:21-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 09:27:22< travis-ci> wesnoth/wesnoth#8755 (master - 62ce4ff : Andreas Löf): The build has errored.
20160305 09:27:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113839264
20160305 09:27:23-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 09:27:32< Aginor> while  fixing bugs and regressions, we also need to pay closse attention to what the community says
20160305 09:28:09< wedge009> Aginor: https://gna.org/bugs/?24496
20160305 09:28:13< wedge009> Agreed.
20160305 09:28:39< vultraz> true, that
20160305 09:30:18< vultraz> I doubt there will be anything raised that would require a reversion to sdl1
20160305 09:30:24< vultraz> (hopefully)
20160305 09:31:06< Aginor> so do I, but we still need to plan for the contingencies
20160305 09:31:27< vultraz> barring those, I think this should be our checklist for 1.13.4:
20160305 09:31:30< vultraz> * Drop SDL 1.2
20160305 09:31:35< vultraz> * Work on the flip() refactor
20160305 09:31:42< vultraz> * celticminstrel's AI refactor
20160305 09:32:05< vultraz> * GUI2 Recruit and Recall
20160305 09:32:12< Aginor> * GUI2 storyscreen
20160305 09:32:19< celticminstrel> * celticminstrel's Lua/formula refactor(?)
20160305 09:32:35< vultraz> that's enough for 1 month :)
20160305 09:32:38< celticminstrel> * celticminstrel's extension to wesnoth.effects table
20160305 09:32:45< Aginor> that's more than enough most likely
20160305 09:33:02< celticminstrel> The AI refactor actually might not make it untile 1.13.5.
20160305 09:33:05< celticminstrel> ^until
20160305 09:33:08< celticminstrel> We shall see.
20160305 09:33:09< vultraz> we'll see
20160305 09:33:37< celticminstrel> The wesnoth.effects thing is basically done and just needs testing. I should hurry up and PR it.
20160305 09:33:52 * celticminstrel got distracted writing a syntax highlighter for WML for my text editor. >_>
20160305 09:34:03< vultraz> ... whut
20160305 09:34:25< Aginor> to be honest
20160305 09:34:50< Aginor> depending on the bug reports from this release, I might not be able to do anything but fixing bugs before the next release
20160305 09:35:04< vultraz> again, will have to see
20160305 09:35:09< Aginor> yes
20160305 09:36:08< Aginor> but I'm trying to point out that we'll need to be flexible
20160305 09:36:22< vultraz> yeah
20160305 09:36:35< vultraz> there might be some gui2 backend changes needed for the gui2 storyscreen
20160305 09:39:27< wedge009> <assign all to Aginor>
20160305 09:39:28< wedge009> <cancel all of Aginor's leave>
20160305 09:39:33< wedge009> ;)
20160305 09:39:44< wedge009> (kidding)
20160305 09:43:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160305 09:43:44< Aginor> wedge009: unless you're willing to pay for my day job, sure :D
20160305 09:43:49< Aginor> umm
20160305 09:43:53< Aginor> wedge009: unless you're willing to pay for my day job, no :D
20160305 09:44:02< wedge009> Ha ha.
20160305 09:44:27< wedge009> Don't worry, I know. I've basically worked today (Saturday), except on Wesnoth instead of my normal job. It was only supposed to be for a few hours. x.x
20160305 09:45:38-!- Kwandulin [~Miranda@p200300760F0BD4978C7CD66F1ACDC290.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20160305 09:47:07< Aginor> wedge009: Thank you for your efforts
20160305 09:49:21-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 09:49:22< travis-ci> wesnoth/wesnoth#8756 (master - 5b82cb0 : Andreas Löf): The build failed.
20160305 09:49:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113840452
20160305 09:49:22-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 09:49:22< vultraz> thanks both of you
20160305 09:49:24< vultraz> and loony 
20160305 09:50:04< wedge009> Yeah, thanks to everyone. It's a team effort! :D
20160305 09:50:19< Aginor> yes!
20160305 09:50:30< Aginor> good job everyone!
20160305 10:03:49-!- Appleman1234 [~Appleman1@KD106161148105.au-net.ne.jp] has joined #wesnoth-dev
20160305 10:30:31-!- Kwandulin [~Miranda@p200300760F0BD4978C7CD66F1ACDC290.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 10:34:00-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 10:34:01< travis-ci> wesnoth/wesnoth#8757 (1.13.3 - 5b82cb0 : Andreas Löf): The build failed.
20160305 10:34:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113849592
20160305 10:34:01-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 10:52:59-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 10:53:00< travis-ci> wesnoth/wesnoth#8758 (master - e959436 : loonycyborg): The build failed.
20160305 10:53:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113853880
20160305 10:53:00-!- travis-ci [~travis-ci@ec2-54-224-196-47.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 10:58:25< zookeeper> regarding the journey markers bug: yeah, that's a pretty bad one and definitely needs fixing, although of course a single dev release can live with it.
20160305 11:06:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160305 11:10:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160305 12:16:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160305 12:34:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160305 12:36:20-!- Kwandulin [~Miranda@p200300760F0BD4978C7CD66F1ACDC290.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20160305 12:53:23< vultraz> 73 bugs in the tracker that can be closed for this release :D
20160305 12:55:41< vultraz> I think that's pretty impressive
20160305 12:56:22< shadowm> Aginor: I think dropping SDL 1.2 support as soon as possible is a good idea regardless of this supposed "fallout". We can't keep using SDL 1.2 forever, especially not on Windows and OS X, and people's efforts should be better focused at fixing Wesnoth on SDL 2.0 than on beating a dead horse that upstream hasn't supported for _years_.
20160305 12:57:08< shadowm> The sooner the SDL 1.2 support code goes away, the sooner the code will be cleaner so as to expedite bug-fixing.
20160305 12:57:40< shadowm> And if people need to refer to SDL 1.2-specific behavior, well, guess why we have a stable branch!
20160305 12:57:41< vultraz> Am I supposed to close bugs before or after the announcement? (And I assume I just close all Open Fixed bugs)
20160305 12:58:25< shadowm> vultraz: Open bugs with a resolution that denotes finality (Fixed, Invalid, Won't Fix).
20160305 12:58:40< shadowm> Nobody cares about the exact timing I think.
20160305 12:59:23< vultraz> Ok, doing now
20160305 13:08:37< vultraz> My email is being spammed
20160305 13:08:39< vultraz> Heh
20160305 13:13:47< wedge009> Mine too.
20160305 13:14:09< shadowm> You should be used to this since ages.
20160305 13:14:10< wedge009> vultraz: I've been reviewing old bugs - there's a lot I've commented on in the past and today, which I think could be closed or marked as fixed.
20160305 13:14:18< wedge009> Not complaining, just stating.
20160305 13:15:40< shadowm> OH MY GOD AI0867 LIVES.
20160305 13:15:52< shadowm> vultraz: https://github.com/wesnoth/wesnoth/pull/342#issuecomment-192639184
20160305 13:16:28< vultraz> I saw
20160305 13:16:33< wedge009> Who?
20160305 13:16:34< shadowm> Who knew that his first sign of life since 2001 would be in a PR like that.
20160305 13:16:40< vultraz> Ok, closed all Fixed, Won't Fix, and Invalid bugs
20160305 13:16:43< shadowm> PR comment thread even.
20160305 13:17:09< shadowm> wedge009: One of our MIA senior developers.
20160305 13:17:30< wedge009> Okay, nice.
20160305 13:17:39< vultraz> wedge009, Aginor: sorry for email spam :P
20160305 13:17:43< wedge009> Is in IRC chat, too.
20160305 13:17:57< wedge009> vultraz: No worries!
20160305 13:17:59< shadowm> Most notably, he used to be responsible for WesCamp-i18n and our project on Coverity Scan prior to his sudden disappearance.
20160305 13:18:18< shadowm> Yes, he's been an IRC zombie session for ages.
20160305 13:18:41< vultraz> wedge009: if there are others you think should be fixed, do point them out to me
20160305 13:18:51< vultraz> s/be fixed/be marked as fixed
20160305 13:19:48< shadowm> vultraz: If he truly returns and I'm not around bug him about Coverity Scan then WesCamp (in that order).
20160305 13:20:07< vultraz> ok
20160305 13:21:11-!- mjs-de [~mjs-de@x4db64648.dyn.telefonica.de] has joined #wesnoth-dev
20160305 13:27:34< loonycyborg> I've uploaded windows release too
20160305 13:29:07< zookeeper> vultraz, and how many of those 73 bugs were filed since the last release? :p
20160305 13:29:16-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160305 13:29:19< vultraz> maybe half
20160305 13:29:32< vultraz> probably less
20160305 13:30:43< zookeeper> oh. well, good then.
20160305 13:32:59< zookeeper> wedge009, WRT https://gna.org/bugs/?24226 i just started TB and looked at those two places
20160305 13:33:05< zookeeper> i'm sure any campaign will do
20160305 13:33:26< wedge009> Which one is TB?
20160305 13:33:43< wedge009> zookeeper: ^
20160305 13:33:49< zookeeper> two brothers
20160305 13:33:55< wedge009> Okay.
20160305 13:34:20-!- louis94 [~~louis94@91.178.242.157] has joined #wesnoth-dev
20160305 13:37:14< zookeeper> and it still happens with master, i just checked
20160305 13:37:19 * zookeeper is afk
20160305 13:37:49< wedge009> zookeeper: Yes, confirmed. I was using save files from older versions, I think.
20160305 13:53:36< wedge009> vultraz and anyone else: I think these can be closed (from point of view of master) or at least reviewed. There are plenty more besides, but I picked the ones I was most confident about.
20160305 13:53:38< wedge009> https://gna.org/bugs/?15567
20160305 13:53:40< wedge009> https://gna.org/bugs/?16057
20160305 13:53:40< wedge009> https://gna.org/bugs/?16069
20160305 13:53:40< wedge009> https://gna.org/bugs/?16233
20160305 13:53:40< wedge009> https://gna.org/bugs/?16638
20160305 13:53:40< wedge009> https://gna.org/bugs/?16725
20160305 13:53:40< wedge009> https://gna.org/bugs/?17323
20160305 13:53:40< wedge009> https://gna.org/bugs/?17806
20160305 13:53:40< wedge009> https://gna.org/bugs/?20036
20160305 13:53:40< wedge009> https://gna.org/bugs/?21548
20160305 13:53:41< wedge009> https://gna.org/bugs/?21565
20160305 13:53:42< wedge009> https://gna.org/bugs/?21708
20160305 13:53:42< wedge009> https://gna.org/bugs/?21887
20160305 13:53:42< wedge009> https://gna.org/bugs/?21911
20160305 13:54:02< vultraz> O_O
20160305 13:54:22< wedge009> Hey, I could have given you twice that. :p
20160305 14:08:33-!- irker779 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160305 14:18:07< vultraz> wedge009: thanks
20160305 14:18:09< vultraz> closed all
20160305 14:18:17< vultraz> :)
20160305 14:18:25< wedge009> Thank you.
20160305 14:18:33< vultraz> I think we're near 100 closed today now
20160305 14:18:39< vultraz> well, 90 at least
20160305 14:19:16< vultraz> only 700 remaining :P
20160305 14:21:46< vultraz> but it's still really nice to know so many old bugs are fixed 
20160305 14:22:00-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has joined #wesnoth-dev
20160305 14:22:14< gfgtdf> celticminstrel: what do you want to add to wesnoth. effects ?
20160305 15:25:26-!- Kwandulin [~Miranda@p200300760F0BD4D96CEBD1406D0ADBD6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 15:31:09-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160305 15:37:12-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160305 15:44:35< vultraz> zookeeper: https://forums.wesnoth.org/viewtopic.php?p=594724#p594724
20160305 16:04:21-!- louis94 [~~louis94@91.178.242.157] has quit [Ping timeout: 246 seconds]
20160305 16:08:08< celticminstrel> gfgtdf: Well, I just opened PR618, so you can see for yourself.
20160305 16:09:48-!- Kwandulin [~Miranda@p200300760F0BD4D96CEBD1406D0ADBD6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160305 16:14:21-!- louis94 [~~louis94@91.178.242.157] has joined #wesnoth-dev
20160305 16:34:58< vultraz> fun wml actions!
20160305 16:37:43-!- ancestral [~ancestral@206.sub-70-197-225.myvzw.com] has joined #wesnoth-dev
20160305 16:38:04< vultraz> hey ancestral 
20160305 16:38:10< ancestral> Hi
20160305 16:38:11< vultraz> release happened
20160305 16:38:28< ancestral> Thanks for letting me know
20160305 16:38:38< ancestral> (not sarcasm)
20160305 16:39:05< ancestral> I should be able to make a binary today or tomorrow
20160305 16:40:49< celticminstrel> What about WML actions, vultraz?
20160305 16:41:29< vultraz> celticminstrel: 'cfun_wml_action'
20160305 16:41:37< vultraz> nothing about it
20160305 16:41:39< vultraz> just the name
20160305 16:41:39< celticminstrel> Oh heh.
20160305 16:42:10< celticminstrel> For reference, the "cfun_" prefix indicates that it is a "Lua closure".
20160305 16:43:08-!- Kwandulin [~Miranda@p200300760F0BD4D96916703040420260.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 16:44:28< vultraz> I'm going to get to work on the Recruit GUI2 dialog
20160305 16:44:38< vultraz> should be relatively simple 
20160305 16:45:14< celticminstrel> I'm honestly not sure I like the unit layout in Create Unit.
20160305 16:45:26< vultraz> elaborate
20160305 16:45:57< celticminstrel> I'm not sure if it's just because I'm used to how it was before, or if I think it should look more like the sidebar, or what.
20160305 16:46:43< vultraz> That doesn't give me anything to work with
20160305 16:46:52< celticminstrel> I realize.
20160305 16:47:27-!- louis94 [~~louis94@91.178.242.157] has quit [Ping timeout: 276 seconds]
20160305 16:49:09-!- ancestral [~ancestral@206.sub-70-197-225.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160305 16:49:42< vultraz> Either way, Recruit will be a little different
20160305 16:50:31< celticminstrel> Different unit layout?
20160305 16:50:48< vultraz> different 'details' layout
20160305 16:50:56< vultraz> for one, I'm dropping the image 
20160305 16:50:58< celticminstrel> This sounds bad already.
20160305 16:51:17< vultraz> don't need image shown twice
20160305 16:51:30< celticminstrel> I suppose...
20160305 16:51:42< celticminstrel> Is it shown twice in the existing recruit dialog?
20160305 16:51:46< vultraz> yes
20160305 16:52:01< vultraz> Give me some time to come up with the layout prototype
20160305 16:57:32< vultraz> it's a PITA to set up the files for a new dialog. blah
20160305 17:01:34-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160305 17:02:04-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20160305 17:14:42< vultraz> oo, std::set
20160305 17:14:47< vultraz> haven't worked with this before..
20160305 17:15:05< vultraz> celticminstrel: what dost do the std::set?
20160305 17:15:17< celticminstrel> It's a mathematical set.
20160305 17:15:24< celticminstrel> The values are stored in sorted order.
20160305 17:17:04-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160305 17:17:05-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has joined #wesnoth-dev
20160305 17:19:46< gfgtdf> celticminstrel: i think it might be better to have seperate function tables wesnoth.effects and wesnoth.effect_descriptions
20160305 17:20:09< celticminstrel> Why?
20160305 17:21:14< gfgtdf> celticminstrel: the reason is that the interface with that need_apply parameter is rather complicated.
20160305 17:21:52< celticminstrel> I suppose, but I don't think having two tables instead of one changes that.
20160305 17:21:53< gfgtdf> celticminstrel: also the apply_builtin_effect seems to have some dublicate code becasue f that
20160305 17:22:28< celticminstrel> I didn't look closely at it. Is it actually identical, or is it slightly different? I just copy-pasted from the original add_modification function.
20160305 17:23:19< gfgtdf> celticminstrel: y the old code also had that problem it seems.
20160305 17:26:07< gfgtdf> celticminstrel: also, (it most likieley doesnt matter here beacsue it only used once at initilisation) but for builtin_effects a boost::flat_set is usualyl fastzer than std::set
20160305 17:26:20-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160305 17:26:24< celticminstrel> I have never heard of it.
20160305 17:26:43< celticminstrel> I do think a hashset would be more appropriate than a treeset, mind you.
20160305 17:27:14< gfgtdf> celticminstrel: also i thought it was also previously possiblew to call those effects via wesnoth.add_modification ?
20160305 17:27:34< celticminstrel> Yes, but this also allows you to change their behaviour if you want to.
20160305 17:27:58-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 17:27:58< travis-ci> dreamer-88/wesnoth#5 (master - e959436 : loonycyborg): The build was broken.
20160305 17:27:58< travis-ci> Build details : https://travis-ci.org/dreamer-88/wesnoth/builds/113912028
20160305 17:27:58-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 17:28:08< gfgtdf> celticminstrel: ia also dont think you need to ad the  "times=1" saveguard
20160305 17:28:28< celticminstrel> Maybe not.
20160305 17:29:01< gfgtdf> celticminstrel: i also wonder whether we shoudl maying move some of the implementation of some effect directoy to lua
20160305 17:29:16< gfgtdf> celticminstrel: i mean for the simple ones this is certainly possible
20160305 17:30:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160305 17:30:12-!- wedge010 is now known as wedge009
20160305 17:30:25< celticminstrel> I think the simplest ones actually don't expose their keys in Lua, but yeah, we could consider doing this.
20160305 17:30:47< celticminstrel> However, I would consider it low priority.
20160305 17:30:59-!- vikas_tmz [0e8b5206@gateway/web/freenode/ip.14.139.82.6] has joined #wesnoth-dev
20160305 17:31:43-!- vikas_tmz [0e8b5206@gateway/web/freenode/ip.14.139.82.6] has quit [Client Quit]
20160305 17:31:44< gfgtdf> celticminstrel: you have a usecase for when someone wants to overwrite known tags ?
20160305 17:32:07< gfgtdf> known appy tos
20160305 17:32:17< gfgtdf> celticminstrel: i mean what is teh advantage as poopsed to using a custom new apply to
20160305 17:32:48< celticminstrel> Well, it would affect units they have little or no control over.
20160305 17:33:03-!- midzer [~quassel@p5B312EF2.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20160305 17:33:59< gfgtdf> celticminstrel: hmm you mean usingts with cusom amls ?
20160305 17:34:13< celticminstrel> Sorry, what?
20160305 17:34:54< gfgtdf> celticminstrel: you mean you want to change the effects of amlas defined in [unit_type] ?
20160305 17:36:29< celticminstrel> That could be one use-case.
20160305 17:57:48-!- mjs-de [~mjs-de@x4db64648.dyn.telefonica.de] has quit [Remote host closed the connection]
20160305 18:23:17-!- irker453 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160305 18:23:17< irker453> wesnoth: dream-88 wesnoth:master 43b5d8680044 / src/storyscreen/render.cpp: Fixed bug #24496: story maps show all markers in journey trails again https://github.com/wesnoth/wesnoth/commit/43b5d868004496acfdf466f60bbb591b985b6327
20160305 18:23:17< irker453> wesnoth: Charles Dang wesnoth:master 30f42b77bf11 / src/storyscreen/render.cpp: Merge pull request #619 from dreamer-88/fix#24496 https://github.com/wesnoth/wesnoth/commit/30f42b77bf11199060f113ab189589b00203bc7c
20160305 18:25:29< zookeeper> ah, excellent.
20160305 18:25:43< vultraz> yup
20160305 18:31:52< zookeeper> would be a good idea to mention that as a known-and-already-fixed bug in the release announcement
20160305 18:32:14< vultraz> Will do
20160305 18:32:41-!- travis-ci [~travis-ci@ec2-54-196-130-209.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 18:32:42< travis-ci> dreamer-88/wesnoth#6 (fix#24496 - 43b5d86 : dream-88): The build failed.
20160305 18:32:42< travis-ci> Build details : https://travis-ci.org/dreamer-88/wesnoth/builds/113924051
20160305 18:32:42-!- travis-ci [~travis-ci@ec2-54-196-130-209.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 18:33:55< vultraz> we need to fix travis :|
20160305 18:52:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160305 19:07:16-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 19:07:17< travis-ci> wesnoth/wesnoth#8762 (master - 30f42b7 : Charles Dang): The build is still failing.
20160305 19:07:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113926764
20160305 19:07:17-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 19:10:16< vultraz> gui2 recruit dialog functional, just need to do the details area
20160305 19:14:20-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20160305 19:14:35< mordante> servus
20160305 19:14:41< mordante> vultraz, ping
20160305 19:14:48< vultraz> hello
20160305 19:14:55< mordante> hi
20160305 19:15:02< mordante> you sent me an e-mail
20160305 19:15:03< shadowm> omg
20160305 19:16:33< vultraz> mordante: yes, I was wondering if you still had details regarding how the new listbox was supposed to work
20160305 19:17:15< mordante> vultraz, not really I had several ideas how to best fix it, but I ran into issues with all of them
20160305 19:18:26< mordante> some seemed to work, but I never managed to finished that code
20160305 19:18:44< mordante> unfortunately the HDD with that code died 
20160305 19:19:34< vultraz> :/
20160305 19:21:14< mordante> I worked on getting the entire contents of the listbox rendered and then to use a view
20160305 19:21:46< mordante> that failed since SDL only supported surfaces with dimensions of 32K
20160305 19:21:56< mordante> did we switch to SDL2?
20160305 19:22:01< vultraz> yes
20160305 19:22:22< mordante> then surfaces should be able to be much larger
20160305 19:22:32< celticminstrel> I think Aginor is due to cut out SDL1 support soon.
20160305 19:22:45< vultraz> In face, we just tagged the first release (1.13.3) using SDL2 as default today
20160305 19:22:46< mordante> nice
20160305 19:22:54< celticminstrel> (Until yesterday both were still supported.)
20160305 19:23:02< vultraz> well, yesterday
20160305 19:23:09< gfgtdf> Aginor: when i start wesnoth, it somehow creates a window muhc larger than my screen
20160305 19:23:10< shadowm> Today.
20160305 19:23:15< gfgtdf> Aginor: at lest i cannot see the border
20160305 19:23:19< celticminstrel> Today, sure, whatever.
20160305 19:23:24< gfgtdf> Aginor: but  dont think it fullscrreen eigher
20160305 19:23:29< gfgtdf> Aginor: its*
20160305 19:23:30< vultraz> gfgtdf: hm I also observed that sometimes
20160305 19:23:41< vultraz> gfgtdf: not sure exactly why it does that
20160305 19:23:43< gfgtdf> vultraz: i observed that for the first time today
20160305 19:23:51< gfgtdf> vultraz: when did you obsere it for the first time
20160305 19:23:54< vultraz> it's not new
20160305 19:25:56< vultraz> mordante: was tlist intended to have a better interface with tscrollbar_container_ and tgenerator?
20160305 19:26:34< mordante> yes but that implementation wasn't panning out too well
20160305 19:27:15< mordante> so I was working on some other ideas but they were in a private git(-svn) branch
20160305 19:28:09< gfgtdf> Aginor: it seems to be related to startign wesnoth in fullscreen
20160305 19:29:11< gfgtdf> Aginor: startugn wesnoth maximized i mean
20160305 19:32:10< vultraz> mordante: one other question - it seems there's currently no way for widgets to resize themselves without the entire dialog resizing as well (invalidate_layout()). Was there/is there supposed to be a way to do that, or would that need to be implemented?
20160305 19:32:56-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20160305 19:33:28< vultraz> that's basically the #1 issue preventing full-scale use of GUI2 rightnow
20160305 19:33:39< celticminstrel> "preventing"
20160305 19:35:16< mordante> vultraz, what kind of widget resizing are you looking at?
20160305 19:35:49 * zookeeper blinks
20160305 19:35:51< zookeeper> he's alive
20160305 19:37:55< Elvish_Hunter> mordante: welcome back!
20160305 19:38:12< vultraz> mordante: well, the most obvious case is labels. the widget size of a label is determined by its text at preshow. If you try to set it to a different value (via tcontrol::set_label()) that's longer than the initial value, it will be truncated since the widget doesn't have enough space. You can sometimes work around this with scroll labels, but scroll labels contain scrollbars which trigger a...
20160305 19:38:14< vultraz> ...full dialog redraw, so it's not always ideal
20160305 19:39:13< mordante> hi Elvish_Hunter
20160305 19:39:20< zookeeper> i'm inclined to say doofus's new walls should replace the current hewn walls. they're used in very few places in mainline and i think they're all misguided uses, because they've always had that one horrible corner glitch which basically guarantees they always look bad.
20160305 19:39:22< vultraz> I'm thinking there should be a way to tell the label to see if it can find space without recalculating everything
20160305 19:39:50< vultraz> zookeeper: I agree
20160305 19:40:41< mordante> vultraz, yes that is a kind of an issue
20160305 19:41:30< mordante> when the label is in a grid and the grid contains other `large' objects you can let the label at least grow to allocate all space in its cell
20160305 19:41:46< mordante> this fixes the issue in some cases
20160305 19:42:17< mordante> for the scroll label it is possible to set the scrollbars to hidden, then the widget will reserve space for its scrollbars
20160305 19:42:37< mordante> then when needed they can be shown without resizing the window
20160305 19:42:52< Aginor> gfgtdf: would you mind raising a bug? - I think it's related to vultraz's changes, there might be an issue with how the preferences are applied
20160305 19:43:04< Aginor> hi mordante 
20160305 19:43:12< mordante> hi Aginor 
20160305 19:43:17< vultraz> Aginor: I'll take a look at it later today
20160305 19:43:55< mordante> It might be it also works for scroll labels when the size is not reserved, but I'm not sure whether I planned to do that or did it
20160305 19:44:33< mordante> the goal was also that the label first asks its parent to do the resizing
20160305 19:45:18< mordante> that way when using a listbox the window does not need to resize when a child needs to be resized
20160305 19:49:12< vultraz> ahh, you're right, using horizontal_grow = true on labels can alleviate this problem in some cases :D
20160305 19:49:53< irker453> wesnoth: Ignacio R. Morelle wesnoth:master 54d3319afb16 / data/gui/default/window/lobby_main.cfg: gui2/tlobby_main: Keep wmlxgettext from panicking https://github.com/wesnoth/wesnoth/commit/54d3319afb161cdb2113e7ad5d5e0eeaad4d61a5
20160305 19:51:08-!- mjs-de [~mjs-de@p508C9A72.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 19:51:12-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Quit: Konversation terminated!]
20160305 19:51:47< irker453> wesnoth: Charles Dang wesnoth:master c26674701912 / data/gui/default/window/ (game_load.cfg unit_create.cfg): tgame_load, tunit_create: allowed certain labels full column size https://github.com/wesnoth/wesnoth/commit/c2667470191259f11d31373c2f2351491f4129e6
20160305 19:51:54< vultraz> not sure why I never thought of that before...
20160305 19:52:20< mordante> glad to be of help
20160305 19:53:12< shadowm> Hi mordante, how has your extended vacation been?
20160305 19:53:23< mordante> hi shadowm 
20160305 19:53:27< matthiaskrgr> anyone interested in some UB and memleaks that gccs address and undefined behaviour sanitizer found? 
20160305 19:53:49< vultraz> o_O
20160305 19:53:57< mordante> fine, been quite busy, but maybe I find time to hack on Wesnoth again
20160305 19:54:04< gfgtdf> matthiaskrgr: sure why not
20160305 19:54:06< celticminstrel> vultraz: That shouldn't be surprising, the Wesnoth codebase is full of spiders after all.
20160305 19:54:11< mordante> UB always sounds tempting ;-)
20160305 19:54:21< vultraz> celticminstrel: ?
20160305 19:54:41< celticminstrel> Sorry, I assumed you were surprised by what matthiaskrgr had said.
20160305 19:54:59< celticminstrel> My statement stands even if addressing it to you was mistaken.
20160305 19:55:18< vultraz> ah
20160305 19:56:38< matthiaskrgr> if I remembered how to use this bugtracker... 
20160305 19:57:26< shadowm> With a glass of water and aspirin in hand.
20160305 19:57:48< zookeeper> typical. look at adding a terrain, notice or get reminded by several bugs with the current ones that need to be fixed.
20160305 19:57:57< zookeeper> s/by/of
20160305 19:58:06< vultraz> mordante: I've been doing a lot of work converting gui1 dialogs to gui2 in the past few months
20160305 19:58:19< mordante> :-)
20160305 19:58:34< vultraz> biggest project: https://www.dropbox.com/s/mtwp8sx761zfpks/GUI2%20addons%20list%20FULL%20WINDOW%20staging%206.PNG?dl=0
20160305 19:58:49< celticminstrel> What's that, prefs?
20160305 19:59:00< vultraz> no, the addons manager prototype
20160305 19:59:11< shadowm> zookeeper: All the cave wall terrains that aren't the default have transparency and alignment bugs and I've been yearning for someone to fix them (especially the earthy counterpart to the default).
20160305 19:59:43< mordante> looks great vultraz 
20160305 20:00:29< zookeeper> shadowm, well maybe this is your lucky d... week, month, year, something? regarding a few of them anyway.
20160305 20:00:52< vultraz> thanks :) I'll probably be able to cut the scroll label use by a lot thanks to your suggestion.
20160305 20:01:27< vultraz> still quite WIP, but this should move it along 
20160305 20:04:37< mordante> nice to hear
20160305 20:10:25-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160305 20:10:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160305 20:16:47< mordante> I'm off bye
20160305 20:16:58-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20160305 20:17:30-!- mjs-de [~mjs-de@p508C9A72.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20160305 20:18:07< vultraz> well, I can most equivocally say, I wasn't expecting that to happen today 
20160305 20:19:56-!- travis-ci [~travis-ci@ec2-54-196-130-209.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 20:19:57< travis-ci> wesnoth/wesnoth#8763 (master - 54d3319 : Ignacio R. Morelle): The build is still failing.
20160305 20:19:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113938430
20160305 20:19:57-!- travis-ci [~travis-ci@ec2-54-196-130-209.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 20:20:28< matthiaskrgr> wasn't there some kind of debug level / test map? 
20160305 20:20:41< Aginor> matthiaskrgr: ./wesnoth -t
20160305 20:20:45< shadowm> wesnoth: src/replay.cpp:642: bool replay::add_start_if_not_there_yet(): Assertion `base_->get_pos() == 0' failed.
20160305 20:20:48< shadowm> ./utils/travis/mp_test_executor.sh: line 15: 17699 Aborted                 (core dumped) ./wesnoth --plugin=host.lua --server=localhost:12345 --username=host --nogui --mp-test --noaddons
20160305 20:20:56< shadowm> gfgtdf: Perhaps you'd know something about this?
20160305 20:21:38< shadowm> It's in the failed jobs of that build above.
20160305 20:22:43< gfgtdf> shadowm: y i was just investigating it currently seems like something goes wrong in wesnoth.cpp: It seems like after doing the mp tests the game tries to start another game usign the 'old' gamestate
20160305 20:22:48< gfgtdf> shadowm: : not sure why
20160305 20:23:16< matthiaskrgr> thanks
20160305 20:34:25-!- midzer [~quassel@p5B312EF2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 20:43:10-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20160305 20:43:12< travis-ci> wesnoth/wesnoth#8764 (master - c266747 : Charles Dang): The build is still failing.
20160305 20:43:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/113938656
20160305 20:43:12-!- travis-ci [~travis-ci@ec2-54-80-181-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20160305 20:46:19< irker453> wesnoth: gfgtdf wesnoth:master 3989199a88e0 / src/wesnoth.cpp: Attempt to fix travis mp tests https://github.com/wesnoth/wesnoth/commit/3989199a88e0cc608832faf585a7c3e863fa496d
20160305 20:46:57< gfgtdf> shadowm: ^
20160305 20:56:36-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160305 21:09:58-!- mjs-de [~mjs-de@p508C96B2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160305 21:41:28-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 268 seconds]
20160305 21:42:17< Elvish_Hunter> Weird. I just started Two Brothers, and as soon as I try to attack a unit I get a segfault.
20160305 21:44:52< Elvish_Hunter> This is my backtrace: http://pastebin.com/umhBUHys
20160305 21:46:49-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160305 21:50:54-!- Kwandulin [~Miranda@p200300760F0BD4D96916703040420260.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160305 21:52:48-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has joined #wesnoth-dev
20160305 21:53:19< gfgtdf> Elvish_Hunter: i couldnt reproduce that mybae you can make a stacktrace froma debug build and with line numbers ?
20160305 21:53:37-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has quit [Client Quit]
20160305 22:00:00-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has joined #wesnoth-dev
20160305 22:01:25< gfgtdf> Ravana_, wedge009: i wonder whether we shoudl maybe just mute the whiteboard server warning message in wesnoth 1.12. Specially since we 1) know quite well how to reproduce it 2) won't fix the underlying client problem in 1.12 anyway
20160305 22:03:10-!- trewe [~trewe@bl20-26-85.dsl.telepac.pt] has joined #wesnoth-dev
20160305 22:04:17< gfgtdf> wedge009: i looked at your pr559 again and i what i wonder is why teh game here https://github.com/wesnoth/wesnoth/blob/master/src/menu_events.cpp#L621 'forces' the recuit in case it failed to add it to the whiteboard
20160305 22:05:18< gfgtdf> wedge009: i mean i'd think that the rectuit locations etc in that case woudl be based on the whiteboard applied data so doing these recruit in a non-whiteboard-aplied state might fail i'd think
20160305 22:09:40< irker453> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 907e37c307a6 / src/server/game.cpp: Mute most common case of mp illegal whiteboard data warning. https://github.com/wesnoth/wesnoth/commit/907e37c307a6b502d4b56ec5c741031d6adba18c
20160305 22:10:00< gfgtdf> wedge009, Ravana_ : https://github.com/wesnoth/wesnoth/pull/620
20160305 22:10:01< Elvish_Hunter> gfgtdf: yes, I can prepare a debug build. That, however, will have to wait until tomorrow.
20160305 22:10:17< gfgtdf> Elvish_Hunter: ok
20160305 22:14:40-!- gfgtdf [~chatzilla@f054140045.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160305 22:23:35-!- louis94 [~~louis94@91.178.242.157] has joined #wesnoth-dev
20160305 22:25:43< Aginor> vultraz: will there be a release announcement at some point? to forums and devel list?
20160305 22:28:45-!- louis94 [~~louis94@91.178.242.157] has quit [Ping timeout: 248 seconds]
20160305 22:30:49< celticminstrel> Aginor: I believe that comes when both Mac and Windows builds are available, or 72 hours at most.
20160305 22:31:00< Aginor> ok :)
20160305 22:35:03-!- louis94 [~~louis94@91.178.242.157] has joined #wesnoth-dev
20160305 22:39:14< wedge009> gfgtdf: I had something similar - I think something changed in the preferences4
20160305 22:39:15< wedge009>  
20160305 22:39:15< wedge009> 477
20160305 22:39:16< wedge009> 41
20160305 22:39:37< wedge009> Oops.
20160305 22:39:46< wedge009> I thought I switched off the keyboard before cleaning it. x.x
20160305 22:40:09 * Aginor sniggers
20160305 22:40:20< Aginor> if only I could say I haven't done the same thing in the past
20160305 22:40:41< wedge009> gfgtdf: It looks like xwindowsize/ywindowsize are the only values that are used now.
20160305 22:41:55< wedge009> It's not really a bug, I suppose. But it does look like one if one has pre-existing preferences.
20160305 22:50:08-!- trewe [~trewe@bl20-26-85.dsl.telepac.pt] has quit [Quit: quit]
20160305 22:53:57< wedge009> gfgtdf: Regarding PR #620, I'm not sure what the interaction is with #559. But I've been told whiteboard will be killed off soon, so I suppose it doesn't matter too much.
20160305 22:55:05< Aginor> wedge009, gfgtdf; shadowm rightly pointed out that we need to get community input before we kill that feature
20160305 22:55:59< wedge009> Sure, that was my thinking too.
20160305 22:56:05< celticminstrel> In particular, gfgtdf seems to be in favour of keeping it.
20160305 22:56:45< celticminstrel> I wonder if there are any Mac Wesnoth people besides me using TextWrangler.
20160305 22:56:57< celticminstrel> (Or BBEdit, but that's less likely since it's $100 or something.)
20160305 23:05:14-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20160305 23:06:09-!- mjs-de [~mjs-de@p508C96B2.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20160305 23:26:02-!- Ballador [b527d972@gateway/web/freenode/ip.181.39.217.114] has joined #wesnoth-dev
20160305 23:39:52-!- Ballador [b527d972@gateway/web/freenode/ip.181.39.217.114] has quit [Quit: Page closed]
20160305 23:41:49-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
--- Log closed Sun Mar 06 00:00:23 2016