--- Log opened Tue Mar 08 00:00:06 2016
--- Day changed Tue Mar 08 2016
20160308 00:00:06< Nobun> celticminstrel: however I will try tp explain better, if it is not enough... I am here to explain what I did, openend to suggestions :)
20160308 00:00:40< celticminstrel> Nobun: Here's an explanation of what I was trying to say about the textdomain declaration. http://pastebin.com/GrUg684G
20160308 00:00:47< celticminstrel> Now I'll go look at your paragraph.
20160308 00:02:18< irker516> wesnoth: ln-zookeeper wesnoth:master b23e6d78821a / data/campaigns/Heir_To_The_Throne/_main.cfg: Added missing portrait credits https://github.com/wesnoth/wesnoth/commit/b23e6d78821aac287a5ca4029afd41d31137a612
20160308 00:02:39< Nobun> 4.2.2.2 will show the design of the states for lua strings... however the structure of the state (the meaning of regexp, iffail and run) is explained on paragraphs 4.1 and 4.1.1, 4.1.2
20160308 00:03:35< Nobun> the lua states are located in pywmlx/state/lua_states.py
20160308 00:04:24< Nobun> states are LuaStr01, LuaStr02, LuaStr03, LuaStr03o, LuaStr10, LuaStr20, LuaStr30, and LuaStr31 mentioned on paragraph 4.2.2.2 I mentioned at first
20160308 00:05:36< Nobun> on chapter 6 I also explained deeply all regexpes used on my code (now I am reading your link...)
20160308 00:05:53< celticminstrel> BTW, you misspelled my name in the docs.
20160308 00:06:06< celticminstrel> (The docs are also full of other spelling and grammar errors.)
20160308 00:07:04< celticminstrel> WML actually has two string syntaxes, but I really don't think there's any value in accepting _ << >> even if it does actually work.
20160308 00:07:12< celticminstrel> Since << >> is almost always used to enclose Lua code.
20160308 00:08:29< Nobun> on my script << and >> are always considered as "start lua code"
20160308 00:08:53< Nobun> honestly I didn't know you could use << and >> to identify a WML string O.o
20160308 00:09:13< celticminstrel> It is, internally, just a string syntax in which preprocessor inclusions are not parsed.
20160308 00:09:25< celticminstrel> But considering it as "start Lua code" is a good thing.
20160308 00:10:03< Nobun> << is parsed by WmlGolua state as "switch to lua code rules"
20160308 00:10:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160308 00:10:46< Nobun> and >> is parsed by LuaGowml state as "came back to WML" (skipped if you are parsing a lua file)
20160308 00:11:12< celticminstrel> Hmm.
20160308 00:11:41< celticminstrel> Your documentation is pretty unclear.
20160308 00:12:28< Nobun> hmm...  I was afraided about it... I tried to be clearer as possible... but I will happy to explain better if I can
20160308 00:12:39< celticminstrel> I'm looking at the code now.
20160308 00:13:17< celticminstrel> You know, it would probably be easier if you used triple-quoted strings.
20160308 00:13:30< celticminstrel> Then you wouldn't need all this concatenation.
20160308 00:13:42< Nobun> yeah... I admit it
20160308 00:13:59< Nobun> but I used concatenation for several reasons
20160308 00:14:09< celticminstrel> Okay, so parsing regex isn't easy to begin with, and these concatenations make it even harder. What does LuaStr01 do?
20160308 00:14:37< Nobun> see Chapter 6... on chapter 6 I translated the regexp in real regexpe rules
20160308 00:15:03< Nobun> unluckly the concatenation used on regexpes was mandatory -.-
20160308 00:15:14< celticminstrel> I highly doubt that.
20160308 00:15:21< celticminstrel> Example: r'(?:[^["' + r"'" + r']*?)(_?)\s*"((?:\\"|[^"])*)("?)'
20160308 00:15:42-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Excess Flood]
20160308 00:15:42-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20160308 00:15:42< celticminstrel> r"""(?:[^["'']*?)(_?)\s*"((?:\\"|[^"])*)("?)""" would probably work just as well
20160308 00:15:50< Nobun> ah
20160308 00:16:12< Nobun> I didn't know you could use triple quotes with raw strings
20160308 00:16:14< celticminstrel> I'm not sure I edited that correctly to remove the concatenation, but I imagine you get the basic idea.
20160308 00:16:25< celticminstrel> Anyway.
20160308 00:16:41-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160308 00:18:21< celticminstrel> Okay, why is the regex anchored at line start?
20160308 00:18:36< Nobun> since the parser must be recursive
20160308 00:18:39< celticminstrel> Why is the underscore optional?
20160308 00:18:43< celticminstrel> I'm confused.
20160308 00:18:53< Nobun> I try to answer your questions
20160308 00:19:04< Nobun> 1) anchored at line start
20160308 00:19:13< celticminstrel> In particular, what happens if there are two string on the same line?
20160308 00:19:29< Nobun> this is what should happen:
20160308 00:19:35< Nobun> the first string is found
20160308 00:19:46< Nobun> the string is captured
20160308 00:20:05< Nobun> the line is still not consumed and there are things arleady to parse
20160308 00:20:27< Nobun> come back to idel state, store the pending string, and contine the parse to the non-consumed part of the line
20160308 00:20:33< celticminstrel> Ah, okay.
20160308 00:21:19< celticminstrel> I guess the underscore is optional so that you don't match something like this?
20160308 00:21:28< celticminstrel> local var = ' _"123" '
20160308 00:22:21< Nobun> in that case it will mach as ' _ "123" ' string
20160308 00:22:28< Nobun> but it is a non-translatable string
20160308 00:22:31< celticminstrel> Right.
20160308 00:22:36< celticminstrel> "check for quotation end (group 3) (if empty, is a multiline string)" - this is wrong for single-quoted and double-quoted strings.
20160308 00:22:46< celticminstrel> If they're multiline, each line ends in a backslash.
20160308 00:22:56< celticminstrel> Except for the last line which has the closing quote.
20160308 00:23:31< celticminstrel> The Perl version also fails to account for this.
20160308 00:23:49< Nobun> hmm? I am not sure I undestood the point
20160308 00:23:54< celticminstrel> I tried on the vanilla Lua interpreted, and it raises an error if I omit the backslash.
20160308 00:24:12< Nobun> I tested my regexp on regex101 and on my test it seems to work fine as I expected
20160308 00:24:13< celticminstrel> > print("abc
20160308 00:24:15< celticminstrel> >> xyz")
20160308 00:24:16< celticminstrel> stdin:1: unfinished string near '"abc'
20160308 00:24:46< celticminstrel> ^interpreter
20160308 00:25:13< Nobun> so... lua code can't use " and ' as multi-line strings?
20160308 00:25:24< celticminstrel> It can, if each line ends with \
20160308 00:25:38< Nobun> well... but it is not a problem on my script
20160308 00:25:42< celticminstrel> The \ is not part of the string.
20160308 00:25:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 00:25:48< Nobun> ah
20160308 00:25:57< celticminstrel> The Perl recognizes the multiline strings but includes that \ as part of the string.
20160308 00:26:05< Nobun> also my script
20160308 00:26:11< celticminstrel> Yeah.
20160308 00:26:13< Nobun> I didn't know this thing
20160308 00:26:31< celticminstrel> I'm not sure I knew it before yesterday. I don't think I've ever needed multiline strings in Lua.
20160308 00:26:53< Nobun> I didn't know you should use a \ at the end of the end of every line on " and ' strings
20160308 00:27:08< Nobun> well it is not hard to include
20160308 00:27:10< Nobun> to fix
20160308 00:27:17< Nobun> the regex will not changed however
20160308 00:27:48< celticminstrel> I thought you might want to change the final ("?) to ["\\]
20160308 00:27:49< Nobun> the fix should be done somewhere else... when storing the pending string into the dictionary I do some "format fixes"
20160308 00:27:55< celticminstrel> But if you think you don't need to, sure.
20160308 00:28:12< celticminstrel> Note that, if you have that kind of backslash in a bracketed string, it is part of the string.
20160308 00:28:21< Nobun> I can remove also the \ from the string
20160308 00:28:52< Nobun> yeah... but luckly the pending string class knows what kind of lua string is parsing
20160308 00:29:00< celticminstrel> Okay, that's good then.
20160308 00:29:10< Nobun> since it is stored in internal lua_type string
20160308 00:29:37< Nobun> I will fix this little issue immediately
20160308 00:30:42< celticminstrel> While you're at it, maybe you can fix what loonycyborg mentioned too?
20160308 00:31:04< celticminstrel> Replacing " with \" and \n with \\n in the string, to sanitize it for gettext.
20160308 00:31:15< celticminstrel> (Regardless of what type of string it is.)
20160308 00:31:59< celticminstrel> Or something, not sure if that was his issue, but something to do with quotes.
20160308 00:32:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 00:32:24< celticminstrel> Maybe it was in WML, where "" in the middle of a string would need to be replaced with a literal \"
20160308 00:34:01< celticminstrel> Nobun: So, if I understand this correctly, LuaStr03 is specifically single-line bracketed strings?
20160308 00:34:19< Nobun> ceyep
20160308 00:34:21< Nobun> yep
20160308 00:34:40< Nobun> while LuaStr03o is for start of multi-line bracketed string
20160308 00:34:59< celticminstrel> In LuaStr03, supporting arbitrary numbers of equals is trivial.
20160308 00:35:11< Nobun> yeah...
20160308 00:35:44< Nobun> but the is is harder if you see the relations from LuaStr03o and LuaStr30
20160308 00:36:08< Nobun> the supporting arbitrary numbers of equals is harder if *
20160308 00:36:51< Nobun> LuaStr30 is the state that check if the multi-line bracket is ended or not
20160308 00:37:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160308 00:37:08< celticminstrel> I undersYeah, I understand this.
20160308 00:37:12< celticminstrel> Gah.
20160308 00:37:37< celticminstrel> Basically, your state machine is a pure state machine - it doesn't have any auxiliary storage. Something like that.
20160308 00:38:51< Nobun> celticminstrel: it is the first time I tried to make a State Machine... I am not a true programmer... my programming skills are not so high... I am an hobby programmer who never studied programming at school, but only by myself as an hobby
20160308 00:39:37< celticminstrel> The Perl version is also roughly a state machine, but since it's just a loop in a single function, it can have a little extra storage that persists between states.
20160308 00:39:49< celticminstrel> The $quote variable is the relevant case.
20160308 00:40:18< Nobun> celticminstrel: any suggestion can accepted
20160308 00:40:23< celticminstrel> It has a single "state" for any "end of multiline string" case (sort of unfinished support for single-quoted strings).
20160308 00:40:35< celticminstrel> I don't have any ideas off the top of my head for allowing arbitrary ='s.
20160308 00:40:48< celticminstrel> I think it's good to allow it, but I also thing it's not high priority.
20160308 00:41:08< Nobun> the real problem is that
20160308 00:41:20< celticminstrel> ^think
20160308 00:41:43< Nobun> regexp want a defined way to identify a rule
20160308 00:41:49< Nobun> as you know 
20160308 00:42:25< Nobun> if I want to have a rule that "captures what it is inside markers" I must be sure to use a rule that is not bugged
20160308 00:42:32< Nobun> think this example
20160308 00:43:14< Nobun> very_weird_lua_string =  _ [=[ [====[ ]==] qualcosa ]=] ]=======]
20160308 00:43:46< Nobun> the problem is that the regexp parser should now that the string should end at "qualcosa ]=]"
20160308 00:43:54< Nobun> (sorry for the italian word)
20160308 00:43:59< celticminstrel> This would work for single-line bracketed strings: ^(?:[^["']*?)(_?)\s*\[(=*)\[(.*?)]\2]
20160308 00:44:17< celticminstrel> It's harder for multiline strings though.
20160308 00:45:33< celticminstrel> I think I can imagine a way to do it if you can track an integer representing the number of equals signs...
20160308 00:45:37< Nobun> the \2 will match exactly the same number of equals on the group2?
20160308 00:45:42< celticminstrel> Yes.
20160308 00:45:56< Nobun> I learned something new about regexpes :)
20160308 00:46:23< celticminstrel> I'm pretty sure \2 is the correct syntax in Python. Some versions of regex do that slightly differently.
20160308 00:46:37< Nobun> celticminstrel: I could test it and try
20160308 00:46:41 * celticminstrel nod
20160308 00:46:47< Nobun> if it will work
20160308 00:47:01< Nobun> I will wtite it down now, and I will test it tomorrow
20160308 00:47:33< Nobun> ok copyed
20160308 00:47:55< Nobun> celticminstrel: perhaps I could find a way to store the integer
20160308 00:48:21< Nobun> but the problem is... how to use that integer in a python regexp?
20160308 00:48:45< celticminstrel> I have an idea that would mean you don't have to. I'll show you some pseudo-Python code.
20160308 00:50:01< celticminstrel> Don't forget that with that regex, the text is now group 3, not group 2.
20160308 00:50:14< Nobun> yeah :)
20160308 00:52:26-!- mjs-de [~mjs-de@x5ce33779.dyn.telefonica.de] has joined #wesnoth-dev
20160308 00:53:18< celticminstrel> By the way, the pastebins I'm showing you today will all be there for a month.
20160308 00:53:24< celticminstrel> Then they'll disappear.
20160308 00:53:59< celticminstrel> Nobun: http://pastebin.com/Q6CdUtQi
20160308 00:55:49< celticminstrel> Does that make any sense?
20160308 00:57:21< Nobun> more or less I got the idea you had
20160308 00:57:57< Nobun> storing a variable is not a problem, since the states can access to statemachine module
20160308 00:58:15< Nobun> I could add a variable there that can be accessed by the state
20160308 00:58:41< Nobun> the real problem is how to apply your idea with the current run/iffail structure
20160308 00:59:27< Nobun> since the regexp on lua 31 matches until the first occurrance of ](=*)] 
20160308 00:59:29< celticminstrel> How does it decide what state runs next when the regex matches?
20160308 01:00:12< Nobun> the statemachine checks the state.regexp
20160308 01:00:54< Nobun> if the regexp is None (always-run states) or if the regexp matches (with re.match) than the run function is executed by statemachine
20160308 01:01:14< celticminstrel> Right, and otherwise, the state is set to the iffail state.
20160308 01:01:15< Nobun> if regexo does not match, go to iffail state
20160308 01:01:37< celticminstrel> What does it do after calling the run function? Does it test the regex again?
20160308 01:01:47< Nobun> nope
20160308 01:01:52< Nobun> run returns a tuple
20160308 01:02:00< celticminstrel> Ah.
20160308 01:02:11 * celticminstrel waits for the further explanation
20160308 01:02:13< Nobun> xline, nextstate
20160308 01:02:25< Nobun> (non-consumed part of line, next state to go)
20160308 01:02:51< celticminstrel> So xline is generally going to me m.suffix() or whatever that's called.
20160308 01:02:54< celticminstrel> ^going to be
20160308 01:03:27< Nobun> for example
20160308 01:03:32< Nobun> 123456
20160308 01:03:37< Nobun> regexp matches 123
20160308 01:03:42< Nobun> xline will be 456
20160308 01:03:56< celticminstrel> Yeah, I understand.
20160308 01:04:47< Nobun> in some cases line is must be considered consumed (example: reached final state)... xline will be none and statemachine will know it is the time to read the next line of code
20160308 01:05:12< celticminstrel> So wait, what if xline is an empty string, is that the same as if it's none?
20160308 01:05:21< Nobun> nope
20160308 01:05:34< Nobun> empty string is considered as string
20160308 01:05:55< Nobun> but it is not added (or should not added) since empty and should generate warning
20160308 01:06:08< Nobun> this is managed by statemachine.pendingluastring
20160308 01:06:18< Nobun> and statemachine.pendingwmlstring classes
20160308 01:06:44< Nobun> an empty line of code
20160308 01:06:54< Nobun> is NOT the same as None
20160308 01:07:07< Nobun> it will considered consumed only if actually consumed
20160308 01:07:09< Nobun> so
20160308 01:07:39< Nobun> empty line of code will be consumed when the parser will see that there is nothing more to parse
20160308 01:07:52< celticminstrel> Ah, so that way there's a warning if someone does something idiotic like _""
20160308 01:08:34< Nobun> currently it should generate a warning (not tested if actually worked, honestly)
20160308 01:09:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 01:09:05< Nobun> but can be switched to an actual error (program stopped) easly
20160308 01:09:50< Nobun> switching from wmlwarn to wmlerr can switch the warning converting it in a real error
20160308 01:10:12< Nobun> sorry... but it is very late here (2:10 am)
20160308 01:10:26< Nobun> perhaps it is time to go bed :P
20160308 01:10:52< celticminstrel> From what you've said, I think it should be possible to make my idea work.
20160308 01:11:19< celticminstrel> I won't keep you if you're tired.
20160308 01:11:31< Nobun> eh... I a bit tired xD
20160308 01:11:56< Nobun> however I will think about your suggestion and I will let you know if I figured how to add it
20160308 01:13:03< Nobun> from tomorrow I should connect here more oftenly, so I can read all feedings, suggestions or details
20160308 01:13:34< Nobun> for example I will try to understand better why my script didn't escape well the pot sentences
20160308 01:13:54< Nobun> perhaps I missed something about how to write correctly the .po file
20160308 01:13:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 01:14:20< Nobun> however we will speak about those things tomorrow or in the next days
20160308 01:14:27< celticminstrel> Or maybe you wrote '\"' instead of r'\"' or '\\"'?
20160308 01:14:29< celticminstrel> I dunnoe.
20160308 01:14:33< celticminstrel> ^-e
20160308 01:14:34< Nobun> for the moment, thank for your time :)
20160308 01:14:40< celticminstrel> Bye.
20160308 01:15:11< Nobun> night :)
20160308 01:15:16-!- Nobun [~nobun@host208-90-dynamic.50-82-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160308 01:18:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 01:23:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 01:26:34-!- gfgtdf [~chatzilla@x50ab6ea7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160308 02:29:24-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160308 02:35:58< celticminstrel> vultraz: Where's your announcement preview?
20160308 02:44:37-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160308 02:46:54-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160308 03:02:40-!- irker516 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160308 03:09:19-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20160308 03:09:25-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20160308 03:14:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160308 03:35:52-!- mjs-de [~mjs-de@x5ce33779.dyn.telefonica.de] has quit [Remote host closed the connection]
20160308 03:35:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 03:40:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160308 04:24:48-!- janebot_ [~Gambot@grickit.us] has quit [Remote host closed the connection]
20160308 04:24:54-!- janebot_ [~Gambot@grickit.us] has joined #wesnoth-dev
20160308 04:47:53< shadowm> Wesnoth is convinced its framerate is around the maximum (50 fps) but that's not what I see on the screen. :|
20160308 04:48:13< shadowm> Um, actually, what's the "hex" number?
20160308 04:49:35< shadowm> Disabling animated terrains doesn't make a difference.
20160308 04:51:30< shadowm> Okay, so what kind of sadistic bastard made it so the bridge in DM scenario 1 has sand at both ends?
20160308 04:52:01< celticminstrel> I can't believe I'm actually using a function-try block for something.
20160308 04:52:45< shadowm> I see the MoL halo teleporting offscreen bug hasn't been fixed.
20160308 04:53:27< shadowm> The halo must be so disappointed in the game's performance that it just decides to nope out of the stage.
20160308 04:53:51< celticminstrel> Technically it's not actually needed here, but it saves me re-indenting the whole constructor. >_>
20160308 05:01:07< shadowm> No-one's made use of the new terrains in mainline yet? Meh.
20160308 05:01:14< shadowm> What am I supposed to work with? This sucks.
20160308 05:01:23< celticminstrel> Huh?
20160308 05:01:30< shadowm> I took a screenshot of Preferences and another of the new Attack dialog.
20160308 05:02:00< shadowm> I'll just mix them up with older screenshots unless someone can point me to a map that shows off the new terrains.
20160308 05:02:14< celticminstrel> I didn't even know there were new terrains.
20160308 05:02:25< shadowm> Great.
20160308 05:10:52-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160308 05:25:18-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160308 05:30:28-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160308 05:36:55< celticminstrel> I just discovered that formula identifiers cannot contain digits.3
20160308 05:37:16< celticminstrel> Does this seem like something safe to change?
20160308 05:40:36< celticminstrel> Ah, right, the dice operator. It would break that, if nothing else.
20160308 05:41:15< celticminstrel> Well, I guess I should document it then.
20160308 05:51:04-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Quit: ancestral]
20160308 05:54:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160308 05:57:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160308 06:24:36-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has joined #wesnoth-dev
20160308 06:36:08-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 06:36:31-!- Kwandulin [~Miranda@p200300760F7D73CB6CE9A0D1C6783763.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160308 06:40:54-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160308 07:13:33-!- ancestral [~ancestral@97-116-184-84.mpls.qwest.net] has quit [Remote host closed the connection]
20160308 08:05:25< Aginor> "20160307 22:31:53< shadowm> That someone might not understand all the technical jargon that Aginor will surely dump on me." - Because of reasons
20160308 08:22:13< Aginor> and I'll try to limit my use of technical jargon
20160308 08:22:58< Aginor> there's no strong reason for only relying on the fullscreen mode we do once SDL1 support is dropped, we could then support either resolution-based fullscreen or native-resolution fullscreen
20160308 08:26:55< Aginor> just to add some confusion to the discussion in the backlog :)
20160308 08:27:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160308 08:27:49< Aginor> .t
20160308 08:42:33-!- Kwandulin [~Miranda@p200300760F7D73CB6CE9A0D1C6783763.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160308 08:48:39-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160308 09:03:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 09:05:56-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160308 09:07:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20160308 09:07:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20160308 09:07:39-!- wedge010 is now known as wedge009
20160308 09:26:30< zookeeper> shadowm, i think UtBS is pretty much the only place where the desert mountains make sense :| except maybe there's a few MP maps
20160308 09:43:07-!- Appleman1234 [~Appleman1@KD106161149214.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20160308 09:48:15-!- Rhonda [~rhonda@anguilla.noreply.org] has quit [Quit: Going down the drain....]
20160308 09:48:42-!- irker220 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160308 09:48:42< irker220> wesnoth: ln-zookeeper wesnoth:master f3d5092534e4 / data/multiplayer/maps/ (5 files): Replaced regular mountains with desert/snowy mountains in a few places https://github.com/wesnoth/wesnoth/commit/f3d5092534e474c48e68d5412585b177aeeaf55e
20160308 09:52:16-!- Rhonda [~rhonda@anguilla.noreply.org] has joined #wesnoth-dev
20160308 10:02:05-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Ping timeout: 248 seconds]
20160308 10:06:04< vultraz> hello all
20160308 10:06:07< vultraz> I have returned
20160308 10:11:46-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160308 10:15:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160308 10:15:34-!- wedge010 is now known as wedge009
20160308 10:39:18-!- Appleman1234 [~Appleman1@KD106161154152.au-net.ne.jp] has joined #wesnoth-dev
20160308 10:48:42< wedge009> Ivanovic and anyone else: Let me know if I've done anything wrong for PR #621. Thanks.
20160308 10:49:47< vultraz> looks good to me
20160308 10:49:57< vultraz> but I don't know about translations
20160308 10:51:01< wedge009> I think it should be fine, just want Ivanovic to confirm though.
20160308 11:03:10-!- travis-ci [~travis-ci@ec2-54-198-127-194.compute-1.amazonaws.com] has joined #wesnoth-dev
20160308 11:03:11< travis-ci> wesnoth/wesnoth#8795 (master - f3d5092 : ln-zookeeper): The build has errored.
20160308 11:03:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/114472135
20160308 11:03:11-!- travis-ci [~travis-ci@ec2-54-198-127-194.compute-1.amazonaws.com] has left #wesnoth-dev []
20160308 11:24:54-!- boucman_work [~jrosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160308 11:30:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 11:35:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160308 11:35:13-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160308 11:54:26-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160308 12:01:33-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20160308 12:19:43-!- louis94 [~~louis94@91.178.241.19] has quit [Quit: Konversation terminated!]
20160308 12:49:10-!- irker220 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160308 12:57:18 * vultraz pings gfgtdf
20160308 13:26:08-!- gfgtdf [~chatzilla@f054139219.adsl.alicedsl.de] has joined #wesnoth-dev
20160308 13:26:11< gfgtdf> vultraz: ?
20160308 13:26:32< vultraz> gfgtdf: I've almost managed to get the widget compiling with tcontainer but one problem
20160308 13:27:20< vultraz> gfgtdf: https://github.com/Vultraz/wesnoth/commit/01fc91f089dda581d81284868d160713b84e2049
20160308 13:27:33< vultraz> so I was trying to do this
20160308 13:27:38< vultraz> +	boost::intrusive_ptr<const tunit_preview_pane_definition::tresolution> conf
20160308 13:27:40< vultraz>  +			= boost::dynamic_pointer_cast<const tunit_preview_pane_definition::
20160308 13:27:41< vultraz>  +												  tresolution>(
20160308 13:27:43< vultraz>  +					widget->config());
20160308 13:27:44< vultraz>  +	assert(conf);
20160308 13:27:46< vultraz>  +
20160308 13:27:47< vultraz>  +	widget->init_grid(conf->grid);
20160308 13:27:49< vultraz> like in other widgets
20160308 13:27:52< vultraz> but it says contig() is protected in tcontrol
20160308 13:28:01< vultraz> so idk how to get the widget's wmol grid from tresolution
20160308 13:28:10< vultraz> bc it looks like I need to inhetir from tcontrol somewhere
20160308 13:29:15< vultraz> config()*
20160308 13:29:21< vultraz> inherit*
20160308 13:31:08< vultraz> basically conf->grid should have the contents of [resolution][grid]
20160308 13:31:17< vultraz> gfgtdf: can you help?
20160308 13:31:39< gfgtdf> vultraz: y i'm thinking about it
20160308 13:32:58< gfgtdf> vultraz: i wonder how scrolllbar panel does it
20160308 13:33:12< gfgtdf> vultraz: mostlikeley it just defines some friend structs
20160308 13:34:41< vultraz> i tried 'friend class tcontrol' in the widget but that didn't work
20160308 13:35:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160308 13:36:28< gfgtdf> vultraz: i'dtry friend struct tunit_preview_pane_definition in the tunit_preview_pane class
20160308 13:36:44< Soliton> you can't just friend some class and get access to its internals. the other class needs to friend you.
20160308 13:36:59< gfgtdf> vultraz: from looking at the cde it seems liek thas how thescrollbr panel does i
20160308 13:38:49< gfgtdf> vultraz: im not 100% sure but i think that if class A inherits from class B and class A friens class C then C has also access to prtrotected memeberof class B
20160308 13:41:15-!- gfgtdf [~chatzilla@f054139219.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 44.0.2/20160210153822]]
20160308 14:03:22-!- atarocch [~atarocch@151.64.78.59] has joined #wesnoth-dev
20160308 14:03:53-!- atarocch [~atarocch@151.64.78.59] has quit [Client Quit]
20160308 14:04:08-!- atarocch [~atarocch@151.64.78.59] has joined #wesnoth-dev
20160308 14:07:32-!- mjs-de [~mjs-de@f048105065.adsl.alicedsl.de] has joined #wesnoth-dev
20160308 14:33:34< vultraz> YES
20160308 14:33:36< vultraz> IT WORKS
20160308 14:35:03< vultraz> yes yes yes
20160308 14:35:08< vultraz> it worrrksss
20160308 14:35:44-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160308 14:36:13< vultraz> celticminstrel: it worrrkss :D
20160308 14:36:27< celticminstrel> Unit preview?
20160308 14:36:36< loonycyborg> Your world domination plan?
20160308 14:36:44< celticminstrel> What about release announcement preview?
20160308 14:36:52< vultraz> unit preview working
20160308 14:36:59< vultraz> release announcement preview up
20160308 14:37:15< vultraz> needs better writing, but I can't think of much now
20160308 14:40:28< vultraz> sadly, still one... small problem with unit preview :|
20160308 14:40:41< vultraz> the same widget dimension problems all widgets suffer from
20160308 14:53:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160308 14:54:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160308 14:59:41< celticminstrel> Preview announcement seems good to me.
20160308 15:17:48-!- gfgtdf [~chatzilla@f054139219.adsl.alicedsl.de] has joined #wesnoth-dev
20160308 15:18:36< gfgtdf> vultraz: you should rewrite the known bugs section, i think that for most of these bugs one doesnt really know what they are about onless one reasy the correcpnding report
20160308 15:19:44< gfgtdf> vultraz: for example: in 'options become black on hover'its unclear which options are meant, here it means tthe option in messages durign a game, but it could aswell mean any other options in a menu.
20160308 15:20:06< gfgtdf> vultraz: same for 'Wesnoth does not exist on the panel ': its not clear whats meant by 'panel'
20160308 15:20:56< vultraz> probably a good idea
20160308 15:21:16< celticminstrel> Oh yeah, I was wondering what that meant too.
20160308 15:27:00-!- irker228 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160308 15:27:00< irker228> wesnoth: ln-zookeeper wesnoth:master 6b297edfed16 / data/core/ (8 files in 2 dirs): Added chasm transitions for mine walls, and tweaked a few tiles https://github.com/wesnoth/wesnoth/commit/6b297edfed1616c492ddd95c8094da676129d86f
20160308 15:44:38< gfgtdf> vultraz: which problem is thill there on unit preview pane ?
20160308 15:52:48-!- Kwandulin [~Miranda@p200300760F7D7338E038E6780F81885E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160308 16:09:05-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160308 16:16:28< vultraz> gfgtdf: the same thing with the labels - setting its values to anything bigger than initial cuts it off
20160308 16:16:47< vultraz> and for some reason vertical_grow doesn't work
20160308 16:17:05< gfgtdf> vultraz: hmm
20160308 16:17:18< vultraz> tbh for some reason in general, vertical grow doesn't seem to do as much as horizontal grow
20160308 16:17:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 16:20:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160308 16:20:34-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 16:26:46< gfgtdf> vultraz: maybe you didnt have vertical/horizontal_grow in the grids in rthe preview_pane widget defintion cfg ?
20160308 16:27:11< gfgtdf> vultraz: so that the widgets grows but the child grids don't ?
20160308 16:28:44< vultraz> makes no difference :(
20160308 16:29:10< vultraz> basically we just need to implement that whole 'expand widget area without causing window resize' think
20160308 16:30:03< gfgtdf> vultraz: y thats needed anyway
20160308 16:31:05< vultraz> maybe you could work on it, or point me into the right direction
20160308 16:32:14< gfgtdf> vultraz: i also thignk such a solituin shodul know where eactly the new space is inserted/removed, this is important when calculatign the new scollbar posistion in scrollbar areas when its content was resized
20160308 16:33:07< vultraz> hm, yes
20160308 16:34:09< vultraz> but i do admit I have absolutely no idea how to do such a thing
20160308 16:51:57< vultraz> gfgtdf: ah you were right!
20160308 16:52:01< vultraz> I was just doing it wrong
20160308 16:52:16< vultraz> (referring to this: [03:26:45]	gfgtdf	vultraz: maybe you didnt have vertical/horizontal_grow in the grids in rthe preview_pane widget defintion cfg ? )
20160308 16:53:59< vultraz> it works
20160308 17:00:04 * vultraz has a million code tabs open
20160308 17:00:06< vultraz> heh
20160308 17:00:39< celticminstrel> A million code tabs?
20160308 17:00:57-!- stikonas_ is now known as stikonas
20160308 17:01:08-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 244 seconds]
20160308 17:01:25-!- travis-ci [~travis-ci@ec2-54-234-9-116.compute-1.amazonaws.com] has joined #wesnoth-dev
20160308 17:01:26< travis-ci> wesnoth/wesnoth#8797 (master - 6b297ed : ln-zookeeper): The build has errored.
20160308 17:01:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/114542678
20160308 17:01:26-!- travis-ci [~travis-ci@ec2-54-234-9-116.compute-1.amazonaws.com] has left #wesnoth-dev []
20160308 17:02:00< vultraz> celticminstrel: many, many tabs open in Notepad++
20160308 17:02:05< celticminstrel> Ah.
20160308 17:02:41< gfgtdf> vultraz: yes notepad++ can open a lot of tabs
20160308 17:03:34< gfgtdf> its fast.
20160308 17:04:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160308 17:04:17< gfgtdf> what bother me tought it its automatic updater: it always asks me for admin right even if i installed notepadd+ in a location were no adim rigth are needed
20160308 17:04:40< gfgtdf> zookeeper, vultraz, wedge009: any opinion on https://github.com/wesnoth/wesnoth/pull/622
20160308 17:05:17< vultraz> what does it do?
20160308 17:05:43< gfgtdf> vultraz: mainly fixing http://gna.org/bugs/?24226
20160308 17:05:51< gfgtdf> vultraz: see the lastest commit of that pr
20160308 17:06:23< vultraz> hm
20160308 17:06:25< vultraz> sounds good to me
20160308 17:10:24-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160308 17:15:43-!- boucman_work [~jrosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160308 17:16:52-!- prkc [~prkc@catv-212-96-34-60.catv.broadband.hu] has joined #wesnoth-dev
20160308 17:32:40< vultraz> celticminstrel: you don't need explicit on a constructor with 0 arguments, right?
20160308 17:32:55< celticminstrel> No.
20160308 17:42:08< vultraz> huh
20160308 17:42:16< vultraz> const_child_iterator doesn't have begin() and end()?
20160308 17:42:22< celticminstrel> Of course not.
20160308 17:42:25< celticminstrel> It's not a container.
20160308 17:42:33< celticminstrel> It's a pair<iterator,iterator>
20160308 17:42:39< vultraz> oh
20160308 17:43:09< celticminstrel> I'm going to submit a PR for all my formula stuff, even though it's not actually finished.
20160308 17:43:21< celticminstrel> Because it's at a point where "part A" is finished.
20160308 17:44:19-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20160308 17:45:31< vultraz> oh deer, I made wesnoth crash :|
20160308 17:45:36< celticminstrel> Fun!
20160308 17:46:36< vultraz> not sure why, though
20160308 17:47:51< vultraz> ah
20160308 17:48:09< vultraz> binding a dereferenced null pointer
20160308 17:48:30< vultraz> can't be doing that, can we
20160308 17:48:32< vultraz> :P
20160308 17:49:51 * vultraz is using so many pointers
20160308 17:49:52< celticminstrel> 'tis bad
20160308 17:50:01< celticminstrel> Try to use references instead.
20160308 17:50:47< vultraz> I decided to keep a pointer to each of the eight sub-widgets so I don't call find_widget every time you change the type
20160308 17:51:08< vultraz> plus, I want this widget to be able to handle individual widgets missing
20160308 17:51:11< vultraz> so, for example
20160308 17:51:26< vultraz> I make a definition without the image
20160308 17:51:30< vultraz> (such as for Recruit)
20160308 17:51:40< vultraz> I can just check if the pointer is valid and if not, do nothing
20160308 17:51:47< celticminstrel> Oh, that's probably okay then.
20160308 17:53:28< celticminstrel> You'll be putting this up for code review before merging?
20160308 17:53:32< vultraz> Yes
20160308 17:54:25< celticminstrel> git is taking forever to start pushing.
20160308 17:55:05< celticminstrel> Hasn't even started printing progress messages yet.
20160308 18:02:04-!- Greg-Bog_ is now known as Greg-Boggs
20160308 18:06:14< Ivanovic> wedge009: no idea if you have done something wrong
20160308 18:14:36< vultraz> I hate the gui2 schema
20160308 18:19:16< vultraz> screw it
20160308 18:23:42< vultraz> celticminstrel, gfgtdf https://github.com/wesnoth/wesnoth/pull/623
20160308 18:24:22< vultraz> I didn't update the schema because I can't figure it out
20160308 18:25:56< celticminstrel> Anyone have further thoughts on https://wiki.wesnoth.org/Wesnoth_Formula_Language ?
20160308 18:26:06< celticminstrel> I've updated it a fair bit since last linking it here.
20160308 18:27:47-!- louis94 [~~louis94@91.178.241.19] has quit [Ping timeout: 248 seconds]
20160308 18:28:43< celticminstrel> Argh, I forgot to rebase out 69e2a87. Need to remember to do that before merging this PR I'm creating.
20160308 18:31:49< celticminstrel> This is absolutely ridiculous.
20160308 18:32:00< celticminstrel> You need six source files to add a new widget?
20160308 18:36:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160308 18:36:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160308 18:37:14-!- travis-ci [~travis-ci@ec2-54-198-127-194.compute-1.amazonaws.com] has joined #wesnoth-dev
20160308 18:37:15< travis-ci> gfgtdf/wesnoth-old#608 (side_name - c941f60 : gfgtdf): The build has errored.
20160308 18:37:15< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/114567086
20160308 18:37:15-!- travis-ci [~travis-ci@ec2-54-198-127-194.compute-1.amazonaws.com] has left #wesnoth-dev []
20160308 18:37:19< gfgtdf> celticminstrel: i wondder whether we shoudl change child_range to contains a boost::iterator_range instead of std::pair
20160308 18:37:31< celticminstrel> There's no real reason to do so.
20160308 18:37:56< gfgtdf> celticminstrel: well it it the interface of a contailer maing it easier to use
20160308 18:38:03< gfgtdf> it gives them*
20160308 18:38:11< celticminstrel> Sorry, can you say that again?
20160308 18:38:30< celticminstrel> Oh wait.
20160308 18:38:39< celticminstrel> You're saying iterator_range pretends to be a container?
20160308 18:38:58< loonycyborg> iterator_range has begin() and end()
20160308 18:39:01< celticminstrel> Ah.
20160308 18:39:07< celticminstrel> And, I presume, value_type and such.
20160308 18:39:20< loonycyborg> thus it can be used as iterable by c++11 range based for
20160308 18:39:34< celticminstrel> But you can easily make a pair iterable in C++11 range-based for.
20160308 18:39:43< celticminstrel> Simply overload global std::begin and std::end.
20160308 18:39:50< celticminstrel> Possibly also specialize an iterator_traits template.
20160308 18:40:57< loonycyborg> actually there's already some c++11 support in wesnoth code, in conditional compilation blocks
20160308 18:40:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 18:41:03< celticminstrel> I know.
20160308 18:41:38< loonycyborg> does it deal with range based for loops in any way?
20160308 18:41:47< loonycyborg> I kinda forgot the details
20160308 18:42:01< loonycyborg> I only remember it dealt with move constructors
20160308 18:43:59< gfgtdf> loonycyborg: i don't think it deals with range based for loops
20160308 18:44:44< gfgtdf> loonycyborg: i mean the gain over boost_foreach is to small to add a progrocessor #if for it
20160308 18:45:07< gfgtdf> loonycyborg: mayb boost_foreach is implemented using c++ range based loops on c++11 but i also dn think that
20160308 18:56:58-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160308 18:57:05< zookeeper> gfgtdf, i haven't thought about the issue a lot, but to me it seems wrong to add yet another attribute for that. leaders have names, teams have names, sides have numbers, in multiplayer players have names...
20160308 18:58:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 18:59:38< zookeeper> gfgtdf, if it intelligently defaults to leader name in SP and player name in MP (or something; i don't know how you intend to use it) then i guess i don't see a problem with it.
20160308 19:00:10< zookeeper> but if it can do that, then i'm not sure why it'd need to be added in the first place, except for some rather niche uses.
20160308 19:02:48< gfgtdf> zookeeper: well luikie i said in the bugreportits quite difficult to create a reliable behaviour that handles all cases like mp campaigns and mp games that are reloaded in sp mode in a good way.
20160308 19:03:25< Ravana_> https://wiki.wesnoth.org/Wesnoth_Formula_Language#Other_Types_and_Operators the note part might be confusing, whether the ", meaning that" part is about general short-circuit, or the case in formulas
20160308 19:03:26< gfgtdf> zookeeper: this sultion basically lets the wml author decide whether to use the players name ot the name= attribute in those dialogs.
20160308 19:03:35< zookeeper> gfgtdf, well i don't see why it shouldn't just display the leader name. in multiplayer, the leader name is the player name (unless specifically set otherwise).
20160308 19:04:30< gfgtdf> zookeeper: you cannot specially set it otherwise in current master or in 1.12
20160308 19:05:44< zookeeper> i can't see how that makes any sense
20160308 19:06:06< zookeeper> you're saying that a scenario can't set a unit's name to whatever
20160308 19:06:10< gfgtdf> zookeeper: also 'the leader name' might be undefined, for exampel in some scenarios have 2 leaders or no leader at all
20160308 19:07:38< zookeeper> anyway, as said, i have no problem with the new attribute, maybe it's useful for multiplayer campaigns or something, but it isn't and can't be a fix for #24226
20160308 19:09:24< zookeeper> (unless you want to add that attribute to every player side of every scenario of every campaign we have, that is)
20160308 19:09:45< celticminstrel> Ravana_: Sorry, what?
20160308 19:09:54< celticminstrel> Oh wait, I see.
20160308 19:11:00< celticminstrel> Ravana_: How does this sound instead? "and and or do not short-circuit (which would mean that they may never evaluate their second argument if they can know their result solely from the first argument)."
20160308 19:11:17< celticminstrel> Perhaps replace may with will, too.
20160308 19:14:00< gfgtdf> zookeeper: ? The commitmessage said quite clearly that side_name= defaults to name= for sides in [scenario]s which is usually the leaders name.
20160308 19:14:41< zookeeper> gfgtdf, right, i forgot that already
20160308 19:16:22< Ravana_> it is better. "which would mean" part clearly says that this is not the case here
20160308 19:16:34< gfgtdf> celticminstrel: did you make porogress on allowing parameters in lua_function filters ?
20160308 19:16:52< zookeeper> gfgtdf, what happens in multiplayer then?
20160308 19:16:59< celticminstrel> gfgtdf: I haven't gotten back to that yet.
20160308 19:17:17< celticminstrel> gfgtdf: I also have an alternate branch related to Lua filters.
20160308 19:17:20< gfgtdf> zookeeper: it doesnt default to name= (it stays empty)
20160308 19:18:17< gfgtdf> celticminstrel: i think it migth be good to have something liek wesnoth.curent.filter_context similar to wesnoth.curent.event_context 
20160308 19:18:18-!- louis94 [~~louis94@91.178.240.71] has joined #wesnoth-dev
20160308 19:18:33< celticminstrel> Hmm, maybe...
20160308 19:18:36< gfgtdf> celticminstrel: so that filter_context contans variables liek filtered_unit, other_unit or similar
20160308 19:18:46< celticminstrel> That does sound kind of useful.
20160308 19:19:02< zookeeper> gfgtdf, ok, so... the PR does fix the bug, except for player sides where the leader is not defined directly in the [side] tag (which is rare if it ever happens)?
20160308 19:19:55< gfgtdf> celticminstrel: it coudl maybe also contains things like attacker_unit/defender_unit  if its used during attack preview dialgo to calculate attack dmage filter ro soemthing.
20160308 19:20:35< gfgtdf> zookeeper: y that can also happen afaik some LoW scenarios do that becasue it fixed some mp campaign issues in 1.12
20160308 19:21:12< gfgtdf> zookeeper: well i'd say it still clearly better than the 1.13 and also better than the 1.12 behaviour (where save_id way used)
20160308 19:21:30< gfgtdf> zookeeper: also note thatin such coner cases you can still give the attribute manually
20160308 19:22:51< zookeeper> gfgtdf, okay, i guess it's good then
20160308 19:23:27< irker228> wesnoth: gfgtdf wesnoth:master fcf8619a69d5 / src/ (team.cpp team.hpp): rename a c++ varaible to match config attribute name. https://github.com/wesnoth/wesnoth/commit/fcf8619a69d5a17de11c623da4ef88a28a030a7a
20160308 19:23:29< irker228> wesnoth: gfgtdf wesnoth:master 0d254fb03e7d / src/team.cpp: 'current_player' shouldn't default to 'save_id' https://github.com/wesnoth/wesnoth/commit/0d254fb03e7d33cbb0ed027e1cc5b407a139d179
20160308 19:23:31< irker228> wesnoth: gfgtdf wesnoth:master c941f60c4926 / src/ (10 files in 2 dirs): add new attribute side_name= in [side] https://github.com/wesnoth/wesnoth/commit/c941f60c4926d00b07bf0913b69dfd6455542ca1
20160308 19:23:33< irker228> wesnoth: gfgtdf wesnoth:master 41f585302886 / src/ (10 files in 2 dirs): Merge pull request #622 from gfgtdf/side_name https://github.com/wesnoth/wesnoth/commit/41f5853028862020d09c2960a28e6435b192ea19
20160308 19:25:37< zookeeper> vultraz, the known bugs section should list the labels behavior too (disappear on menu open, bleed over preferences and/or other dialogs)
20160308 19:29:30< gfgtdf> celticminstrel: do you know whether we currently have somethign liek a 'free view' hotkey, that hides chat, labels and such things while the hotkey is pressed?
20160308 19:29:58< celticminstrel> No idea, but I do know that right-clicking hides chat.
20160308 19:30:47< gfgtdf> celticminstrel: hmm yes but note sure f thats intentional
20160308 19:30:50< gfgtdf> not*
20160308 19:31:01< celticminstrel> Yeah, I doubt it.
20160308 19:31:41< gfgtdf> celticminstrel: the intention is to fix cases where someone cannot see the left upper corener of the map becasue of all teh chat
20160308 19:32:04< celticminstrel> Heh.
20160308 19:32:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160308 19:35:01< gfgtdf> celticminstrel: afaik some map are designed to work aroign thi particual issue by having unwalkable terrain in that corner
20160308 19:35:11< gfgtdf> celticminstrel: but not aall maps are
20160308 19:38:31-!- edgrey [~edgrey@178.204.111.248] has joined #wesnoth-dev
20160308 19:43:58< celticminstrel> PR 624 is now open.
20160308 19:44:00< celticminstrel> And it's big.
20160308 19:44:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160308 19:44:51-!- Kwandulin [~Miranda@p200300760F7D7338E038E6780F81885E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160308 19:45:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 19:45:58< celticminstrel> When writing the summary I thought of one or two things I'd forgotten. Unfortunately, I've now forgotten what they were. :(
20160308 19:49:01< gfgtdf> celticminstrel: o wonderwhy you getter for unti upkeep used upkeep_raw and calculates it himself unstead of using unti.upkeep()
20160308 19:49:15< celticminstrel> ?
20160308 19:50:04< gfgtdf> celticminstrel: this code: https://github.com/wesnoth/wesnoth/pull/624/files#diff-7c8955ec56722346de9e852a4e40ac97R258
20160308 19:50:21< gfgtdf> celticminstrel: coudl is just be return variant(u_.upkeep()) ?
20160308 19:50:39< celticminstrel> u_.upkeep() is not convertible to a variant.
20160308 19:50:52-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160308 19:50:58< celticminstrel> (This is a formula variant - no relation whatsoever to boost::variant.)
20160308 19:51:32< gfgtdf> celticminstrel: i thougthj upokeep can hodl an int ?
20160308 19:51:39< gfgtdf> variant can hold an int*
20160308 19:51:47< celticminstrel> Yes, it's holding an int.
20160308 19:51:56< celticminstrel> (Though I was contemplating changing it to use boost::variant... since that's a refactor rather than new feature, though, I'll save it for another time.)
20160308 19:52:34< gfgtdf> celticminstrel: and upkeep() returns an int
20160308 19:52:39< celticminstrel> Ah.
20160308 19:52:52< celticminstrel> Then you're probably right that I could do that.3
20160308 19:54:19< gfgtdf> celticminstrel: i also dont think you need to test whether random_new::generator is null
20160308 19:54:27< gfgtdf> celticminstrel: becasue iirc it is never null
20160308 19:55:27< celticminstrel> I don't think I want to rely on that.
20160308 19:55:35< celticminstrel> It doesn't hurt to check it, right?
20160308 19:56:33< gfgtdf> celticminstrel: well you code looks like it coudl be null so other people who look at that code might spend hours to find out under whcih exact conditions it is null.
20160308 19:56:39< gfgtdf> celticminstrel: but yes it not that important
20160308 19:56:52< gfgtdf> celticminstrel: also i wonder whether we shoudl move all those filed in a formula/ folder
20160308 19:56:55< gfgtdf> files*
20160308 19:57:24< celticminstrel> I think that would be a good idea. Do you want me to do it? It could break the MSVC and CB project files (I don't think I want to update them for such a major change.)
20160308 19:57:36< celticminstrel> I'll see what others think about the idea as well.
20160308 19:58:25< gfgtdf> celticminstrel: well i hink we currently have at lest soemoe who updates the CB foles, but wure about the msvc files (i usualyl update my local copy myslef)
20160308 19:58:40< celticminstrel> Maybe loonycyborg?
20160308 19:58:43< gfgtdf> celticminstrel: does formula habe regex functions
20160308 19:58:46< gfgtdf> ?
20160308 19:58:48< celticminstrel> I think vultraz uses CB.
20160308 19:58:49< gfgtdf> have*
20160308 19:58:59< celticminstrel> Formula does not have any kind of pattern matching, no.
20160308 19:59:52-!- louis94 [~~louis94@91.178.240.71] has quit [Ping timeout: 252 seconds]
20160308 20:00:07< gfgtdf> celticminstrel: you know whether foruma has 'global variables' ?
20160308 20:00:33< celticminstrel> It doesn't have assignable variables in general.
20160308 20:00:42< gfgtdf> celticminstrel: hmm ok
20160308 20:01:16< celticminstrel> The only way to assign variables is the one-time "<formula> where <var> = <value>" syntax.
20160308 20:01:32< celticminstrel> So basically, a variable's value can't be changed once assigned.
20160308 20:01:50< celticminstrel> (In fact, all built-in values are also immutable.)
20160308 20:02:01< celticminstrel> (Some AI-related values are mutable.)
20160308 20:03:41< gfgtdf> celticminstrel: hmm ok
20160308 20:04:06< celticminstrel> It is more or less a functional language.
20160308 20:04:24< celticminstrel> Not some pure-functional thing like Haskell with first-class functions, but still, basically in that paradigm.
20160308 20:06:49< celticminstrel> For the record, the luaW_getglobal has nothing to do with this - it somehow ended up in the wrong branch. It's related to lua_function=.
20160308 20:08:59< gfgtdf> celticminstrel: y you shodul remove it from that branch before merging
20160308 20:09:32< gfgtdf> celticminstrel: actualyl i dont use forula outside of gui2 so i cannot say much abouth those commits
20160308 20:09:46< celticminstrel> gfgtdf: Anything comments specifically on the final commit?
20160308 20:11:28< gfgtdf> celticminstrel: so [ is some king of escpae character ?
20160308 20:11:41< celticminstrel> More or less.
20160308 20:11:58< celticminstrel> [text] is interpolation, these three are special cases.
20160308 20:12:49< gfgtdf> celticminstrel: so [text] is th same as $text ?
20160308 20:13:34< celticminstrel> Yes, [text] in WFL is the same concept as $text in WML.
20160308 20:13:55< celticminstrel> Actually [] supports embedding another formula, so you could also write something like [i + 1].
20160308 20:13:55< gfgtdf> celticminstrel: hmm didnt know that
20160308 20:14:05< celticminstrel> It was undocumeted until now.
20160308 20:14:15< celticminstrel> (Also, it was {} rather than [] until this PR.)
20160308 20:14:21< gfgtdf> celticminstrel: so whats teh difference between  [i + 1] and just i +1 ?
20160308 20:14:35< celticminstrel> The difference is that [i + 1] appears inside a string constant.
20160308 20:14:45< gfgtdf> celticminstrel: ah ok
20160308 20:15:08< celticminstrel> Strings are enclosed in single quotes, which is why I added ['] as an escaped single quote.
20160308 20:15:23< gfgtdf> celticminstrel: y that makes sense
20160308 20:15:46< celticminstrel> Then I added [] and [.] as escaped square brackets, but I'm less sure that that makes sense.
20160308 20:15:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160308 20:17:33< gfgtdf> celticminstrel: maynbe you can just use [[] and []] ?
20160308 20:17:54< gfgtdf> celticminstrel: that woudl somehow match with the ['] syntax
20160308 20:18:32< celticminstrel> I was trying to avoid that since it complicates the tokenizer - currently it requires that the brackets be balanced (apart from possibly some extra unbalanced close brackets).
20160308 20:18:44< gfgtdf> hmm was there any progress on switching to a different butracker ?
20160308 20:18:54< gfgtdf> celticminstrel: hmm ok
20160308 20:19:07< celticminstrel> I thought of using [(] or [<] instead.
20160308 20:19:31< gfgtdf> celticminstrel: y i think that better than the [] and [.]
20160308 20:19:35< gfgtdf> thats*
20160308 20:19:42< celticminstrel> Okay, I'll change that a bit later, then.
20160308 20:19:56< celticminstrel> Which do you like better?
20160308 20:21:26< gfgtdf> celticminstrel: hmm about equal
20160308 20:21:34< celticminstrel> ?
20160308 20:21:39< celticminstrel> Oh, you don't have a preference?
20160308 20:22:05< celticminstrel> Okay.
20160308 20:22:14< celticminstrel> I'll either see what others say or pick one.
20160308 20:24:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 20:27:54-!- edgrey [~edgrey@178.204.111.248] has quit [Quit: Konversation terminated!]
20160308 20:28:11-!- edgrey [~edgrey@178.204.111.248] has joined #wesnoth-dev
20160308 20:28:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20160308 20:28:31-!- edgrey [~edgrey@178.204.111.248] has quit [Client Quit]
20160308 20:33:39-!- midzer [~quassel@p5B312EF2.dip0.t-ipconnect.de] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20160308 20:45:58-!- Nobun [~nobun@host86-131-dynamic.53-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160308 20:46:10< Nobun> hi all
20160308 20:47:11< celticminstrel> Hi.
20160308 20:47:32< Nobun> celticminstrel: today I couldn't touch / watch my code (and perhaps I couldn't do anything also tomorrow and for some days)
20160308 20:48:22< Nobun> however I have a possible method in my mind to apply your suggestions about allowing arbitrary equals sign in bracketed multi-line lua strings
20160308 20:50:18< Nobun> I will restart to work on it as soon as possible :)
20160308 20:53:34< Nobun> loonycyborg: about your report, instead, until now I have no idea what happened to you... it seems me strange that my script does not escape quotes correctly (since I did some test during the private development that appeared to me that the " sign was always escaped correctly), but now I have to take care my girlfriend and I cannot investigate deeply..
20160308 20:53:52< celticminstrel> ...
20160308 20:56:23< loonycyborg> Nobun: did you read logs and processed files in my gists?
20160308 20:57:11< Nobun> I am not sure I readed them all... can you link the files again here?
20160308 20:57:48< Nobun> So I can take a look now and try to start to think a possible solution in theese days (while I cannot write code, but I can think :P)
20160308 20:59:27-!- travis-ci [~travis-ci@ec2-54-166-189-246.compute-1.amazonaws.com] has joined #wesnoth-dev
20160308 20:59:28< travis-ci> wesnoth/wesnoth#8800 (master - 41f5853 : gfgtdf): The build has errored.
20160308 20:59:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/114601076
20160308 20:59:28-!- travis-ci [~travis-ci@ec2-54-166-189-246.compute-1.amazonaws.com] has left #wesnoth-dev []
20160308 20:59:48< loonycyborg> Nobun: https://gist.github.com/loonycyborg/f803fc37df69056844b0
20160308 21:00:21< gfgtdf> does anyone understand that errorreport ^ ?
20160308 21:00:26< loonycyborg> msgcat barfed on ... them particularly good at "resolving" territorial ...
20160308 21:00:50< loonycyborg> about "resolving" being a bad keyword
20160308 21:01:15< loonycyborg> because " ended the string it was in
20160308 21:02:01< Nobun> thank loonycyborg :)
20160308 21:02:59< Nobun> yes... it should be escaped as \"resolving\" now I try to figure why it didn't happen
20160308 21:07:08< Nobun> loonycyborg: a little question. The pot file in your link was reordered using poreorder.py?
20160308 21:07:36< loonycyborg> it wasn't
20160308 21:07:40< Nobun> ok perfect
20160308 21:07:53< Nobun> so I can focus on wmlxgettext itself
20160308 21:08:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 21:08:47< Nobun> i will take a look for the bug
20160308 21:12:04< Nobun> perhaps I found it... now I will try to fix it... but I have to do another thing before
20160308 21:12:55< celticminstrel> I just successfully used Time Machine to restore my lost TextWrangler window state.
20160308 21:21:15-!- atarocch [~atarocch@151.64.78.59] has quit [Remote host closed the connection]
20160308 21:29:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160308 21:46:20< celticminstrel> I should probably consider getting my campaign to work on 1.13.
20160308 21:46:41< gfgtdf> celticminstrel: does it work on 1.12 ?
20160308 21:46:43< celticminstrel> Last time I tried though (just by dropping it in), player 1 was mysteriously AI-controlled.
20160308 21:46:45< celticminstrel> gfgtdf: It does.
20160308 21:47:05< celticminstrel> I think last time I tried was 1.13.1 or something.
20160308 21:47:16< celticminstrel> Around when I started doing stuff around here.
20160308 21:47:26< gfgtdf> celticminstrel: is it for sp or mp ?
20160308 21:47:33< celticminstrel> SP
20160308 21:49:48< celticminstrel> Okay, now it causes an assertion failure.
20160308 21:50:03< celticminstrel> playsingle_controlled.cpp:646
20160308 21:50:05< celticminstrel> ^r
20160308 21:50:25< celticminstrel> "error engine: Networked team encountered by playsingle_controller."
20160308 21:51:03-!- prkc [~prkc@catv-212-96-34-60.catv.broadband.hu] has quit [Ping timeout: 240 seconds]
20160308 21:51:06< celticminstrel> Why does it think it's a networked team? :|
20160308 21:51:10< gfgtdf> celticminstrel: hmm that looks bad
20160308 21:51:20< gfgtdf> celticminstrel: which scenario ?
20160308 21:51:22< Nobun> loonycyborg: I found where was the error... I mistyped the line code where I expected to add the escape sign on wml strings. Before adding the commit I will also test if the escapes work correctly also on lua quotes
20160308 21:51:25< celticminstrel> First scenario.
20160308 21:52:55< Nobun> celticminstrel: it sound like a core bug ... more than a campaign problem....
20160308 21:52:59< gfgtdf> ok i'll try it
20160308 21:53:03< celticminstrel> Nobun: Yeah.
20160308 21:53:16< gfgtdf> celticminstrel: 1.13 or 1.12 addon server ?
20160308 21:53:20< celticminstrel> 1.12
20160308 21:53:27< celticminstrel> DruidSiege
20160308 21:54:31-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160308 21:54:55< gfgtdf> celticminstrel: the hex based map in the first storyscreen looks funny
20160308 21:55:06< celticminstrel> Huh?
20160308 21:58:14< gfgtdf> celticminstrel: i think the problem might be related to having current_player= defeined by wml
20160308 21:58:23< gfgtdf> celticminstrel: defined*
20160308 21:58:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 21:59:09< gfgtdf> celticminstrel: so that the the initilisation code assigns taht side to some remove network player named "Eärendil"
20160308 22:00:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 22:01:22< gfgtdf> remote*
20160308 22:01:57< celticminstrel> I'll see if that fixes it once I'm done with debugging a formula issue.
20160308 22:02:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 22:03:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 22:04:05-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160308 22:06:42< Nobun> loonycyborg, celticminstrel: http://pastebin.com/cPpjzhAE
20160308 22:07:32< celticminstrel> gfgtdf: I suggest ignoring current_player= in single-player, or maybe transferring it to side_name.
20160308 22:07:37< Nobun> loonycyborg: tell me if the result seems nice now (or suggest other test, if required). The pastebin contains a fake wml, a fake lua and the pot produced by the fix I made locally on wmlxgettext
20160308 22:08:16< Nobun> celticminstrel: here you can take a look why the -- #textdomain is used as comment in wmlxgettext (like it did on the perl version)
20160308 22:08:22< celticminstrel> gfgtdf: Removing it does fix the issue.
20160308 22:08:34< gfgtdf> celticminstrel: my plan was to ignore it and give a warning that suggest to use side_name instead if its found
20160308 22:08:51< celticminstrel> Sure.
20160308 22:08:52< loonycyborg> kinda busy atm, just commit those fixed and I'll pull them and will try more later
20160308 22:09:05< Nobun> ok, loonycyborg 
20160308 22:09:41< celticminstrel> Nobun: Why can't you parse line 15?
20160308 22:10:54< Nobun> it is not I can't... but I cannot figure at the moment a nice regexp to abolish this requirement at the moment
20160308 22:11:13< celticminstrel> Didn't I post one yesterday?
20160308 22:11:19< Nobun> I will take a look at your pastebins on the next days to figure out a good regexp for line 15 and other possible syntaxes
20160308 22:11:27< celticminstrel> Ah. You haven't looked at them yet.
20160308 22:11:44-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160308 22:11:54< celticminstrel> Keep in mind they expire after one month, so if you don't think you'll finish by then you should consider saving them to disk.
20160308 22:12:03< Nobun> yep... my girlfriend is ill and perhaps I could be ill too (we will see in the next days). Today I spent all time at the hospital
20160308 22:12:06-!- louis94 [~~louis94@91.178.240.71] has joined #wesnoth-dev
20160308 22:12:56< Nobun> now I am working on loonycyborg bug... and I will add the commit in the next minutes
20160308 22:13:21< Nobun> after that I will work at the multiline bracket strings
20160308 22:14:04< Nobun> and finally I will take a look for a method to parse line 15 and all possible alternate syntaxes (perhaps in the next days)
20160308 22:15:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160308 22:15:14-!- wedge010 is now known as wedge009
20160308 22:17:00-!- louis94 [~~louis94@91.178.240.71] has quit [Ping timeout: 250 seconds]
20160308 22:17:08< gfgtdf> celticminstrel: hmm the wiki says 'ai' is teh default for controller= but in the actual c++ code taht seems different
20160308 22:19:27< celticminstrel> I'd expect human to be the default.
20160308 22:19:34< celticminstrel> At least for side 1.
20160308 22:19:39< gfgtdf> celticminstrel: hmm for soem reason i cannot edit the wiki page ..
20160308 22:20:07< celticminstrel> If you don't have an account you'll need to talk to vultraz or another wiki-admin.
20160308 22:21:18< gfgtdf> celticminstrel: i ahve an account and i have alse edited pages in the past
20160308 22:21:36< celticminstrel> Then, I dunno.
20160308 22:23:24< gfgtdf> celticminstrel: hmm ok seems leik i wasnt logged in anymore but my i didnt se it beasue of ome caching going on
20160308 22:23:43-!- irker228 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160308 22:29:37< Nobun> loonycyborg: added the commit... sorry for taking so long
20160308 22:29:47< loonycyborg> ok
20160308 22:31:27< Nobun> this commit fixes ONLY the escape quote problem... I indeed made a stupid error on my sourcecode that now should be fixed.
20160308 22:32:43< Nobun> feel free to report me any other problem on escaping quotes (if any, but should not happen anymore) or other problems you experienced.
20160308 22:32:47< Nobun> Thank for your time
20160308 22:34:06< Nobun> now it is the time to go bed... in the next days I will work around the arbitrary number of equals in lua strings and the other feature suggested by celticminstrel 
20160308 22:34:09< Nobun> good night all :)
20160308 22:35:14-!- Nobun [~nobun@host86-131-dynamic.53-79-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160308 22:36:25< celticminstrel> I already forgot what that feature is. >_>
20160308 22:43:14-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160308 22:49:30-!- louis94 [~~louis94@91.178.240.71] has joined #wesnoth-dev
20160308 23:02:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20160308 23:04:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160308 23:09:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160308 23:28:22< celticminstrel> shadowm: Any chance of installing/enabling this? Could be useful for Lua, at least, and perhaps with a bit of work (writing a custom lexer) it could also highlight WML. https://www.mediawiki.org/wiki/Extension:SyntaxHighlight
20160308 23:30:36< celticminstrel> I can't see an equivalent module for phpbb, unfortunately.
--- Log closed Wed Mar 09 00:00:03 2016