--- Log opened Tue Mar 22 00:00:41 2016
20160322 00:12:06-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20160322 00:20:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160322 00:36:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160322 00:37:59< celticminstrel> gfgtdf: Can you remind me why apply_effect needs to push the unit twice and call clear_ref when done?
20160322 01:10:37-!- irker573 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160322 01:10:37< irker573> wesnoth: Celtic Minstrel wesnoth:master 00fa1b4da8b9 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode fixup https://github.com/wesnoth/wesnoth/commit/00fa1b4da8b952b45246b0a6345bf67d48d22d73
20160322 01:10:39< irker573> wesnoth: Celtic Minstrel wesnoth:master ca7fdedd476f / src/ (image_modifications.cpp image_modifications.hpp): Reduce code duplication in scaling IPFs https://github.com/wesnoth/wesnoth/commit/ca7fdedd476f8667f1051bf57a6d0768832ee5d8
20160322 01:10:41< irker573> wesnoth: Celtic Minstrel wesnoth:master 6b631f9e0dfb / changelog: Fix typo in changelog https://github.com/wesnoth/wesnoth/commit/6b631f9e0dfbbc96c66677577e87a364f1a6a373
20160322 01:10:43< irker573> wesnoth: Celtic Minstrel wesnoth:master 8ea72e8dd0bc / src/formula/formula.cpp: Formula engine: Fix missing operator precedence for "in" https://github.com/wesnoth/wesnoth/commit/8ea72e8dd0bcd7e82990c3ea476714b52657aca3
20160322 01:10:45< irker573> wesnoth: Celtic Minstrel wesnoth:master ff155102eba7 / src/formula/function.cpp: Formula engine: Fix replace() with 3 arguments https://github.com/wesnoth/wesnoth/commit/ff155102eba7a8bea539d644855a6c2e9527a51d
20160322 01:10:47< irker573> wesnoth: Celtic Minstrel wesnoth:master 1d67892e070a / src/scripting/game_lua_kernel.cpp: Use luaW_checklocation in teleport_unit https://github.com/wesnoth/wesnoth/commit/1d67892e070aa88c00ff711a977eda56b7b777fc
20160322 01:30:54-!- mjs-de [~mjs-de@x4db6282d.dyn.telefonica.de] has joined #wesnoth-dev
20160322 01:51:10-!- travis-ci [~travis-ci@ec2-54-161-253-28.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 01:51:11< travis-ci> wesnoth/wesnoth#9001 (master - 1d67892 : Celtic Minstrel): The build has errored.
20160322 01:51:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117608980
20160322 01:51:11-!- travis-ci [~travis-ci@ec2-54-161-253-28.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 01:52:43< celticminstrel> Okay good, Travis can compile it now.
20160322 01:53:46< celticminstrel> Looks like the MP tests may be broken.
20160322 01:54:16< celticminstrel> Oh wait, that's not an issue with the test itself.
20160322 01:55:18-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has quit [Ping timeout: 246 seconds]
20160322 01:56:25< vultraz> celticminstrel: do you know anything about scaling algorithms 
20160322 01:56:31< celticminstrel> Not really?
20160322 01:56:33< vultraz> the implementation, that is
20160322 01:56:37< celticminstrel> Why do you ask?
20160322 01:56:55< vultraz> apparently these weird artifacts are caused by bad alpha handling in our scaling implementation 
20160322 01:59:30-!- zombah [~zombah@2a02:28:3:1:214:4fff:fe47:5920] has joined #wesnoth-dev
20160322 02:00:23< vultraz> so I'm trying to figure out the implementation 
20160322 02:00:26< vultraz> but I can't
20160322 02:01:26< vultraz> then again, maybe there's a better standard scaling function in some library somewhere
20160322 02:02:40< vultraz> I checked, sdl doesn't seem to have one
20160322 02:04:28< vultraz> celticminstrel: so I was asking in case you knew of some standard implementation
20160322 02:05:05< celticminstrel> I don't know of anything.
20160322 02:05:24< vultraz> ok
20160322 02:07:46 * celticminstrel wonders how many GUI1 dialogs are left.
20160322 02:08:48< vultraz> quite a few
20160322 02:08:57< vultraz> Statistics/Scroll To Leader
20160322 02:08:59< vultraz> Recall
20160322 02:09:01< vultraz> Advance
20160322 02:09:04< vultraz> Unit List
20160322 02:09:07< celticminstrel> You converted attack and recruit, right?
20160322 02:09:13< vultraz> Scenario/Campaign Statistics
20160322 02:09:15< vultraz> yes
20160322 02:09:18< vultraz> Mp Lobby
20160322 02:09:22< celticminstrel> MP create.
20160322 02:09:24< vultraz> (gui2 version pending)
20160322 02:09:28< vultraz> Addons Manager
20160322 02:09:47< celticminstrel> MP game lobby.
20160322 02:10:02< celticminstrel> There's a third dialog in that sequence, what would it be called...
20160322 02:10:14< vultraz> oh, yeah
20160322 02:10:17< vultraz> player joining
20160322 02:10:30< celticminstrel> First you select the map to play, then something else, then you wait for players to join.
20160322 02:10:33< celticminstrel> I think?
20160322 02:10:52< celticminstrel> I just know that I have to click three times to start an MP game.
20160322 02:11:18< celticminstrel> Oh, MP options or something.
20160322 02:12:27< celticminstrel> Does attack use the unit preview widget?
20160322 02:12:36< vultraz> celticminstrel: ya know, it'd be a big help if you could do some converting of dialogs as well
20160322 02:12:41< vultraz> and no, not yet
20160322 02:12:48< vultraz> I haven't added a definition for it yet
20160322 02:13:02< celticminstrel> Maybe I'll look into that tomorrow or something.
20160322 02:13:04< vultraz> plus, I have to add code to handle displaying unit stats, not unit type stats
20160322 02:13:12< celticminstrel> That should be easy, though.
20160322 02:13:16< vultraz> yes
20160322 02:13:29< celticminstrel> If you prefer, I can let you do it.
20160322 02:13:38< celticminstrel> I'm doing formula stuff, anyway.
20160322 02:13:42< vultraz> I'll probably do it
20160322 02:28:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160322 02:29:55-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160322 02:30:54< vultraz> celticminstrel: if I handle Recall, and Advance, will you do Unit List and Leader Scroll?
20160322 02:31:20< celticminstrel> Uh. What the heck are they?
20160322 02:31:48-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160322 02:32:51< vultraz> Menu -> Unit List
20160322 02:33:16< vultraz> Leader Scroll is what you get when you press alt + s
20160322 02:36:56< vultraz> ancestral: do you think we should commit that pango font family fix?
20160322 02:37:19< celticminstrel> Oh, now that ancestral is here, wasn't there a hack-fix to the Mac font issue?
20160322 02:37:43 * ancestral may have released the 1.13.4 for Mac with that fix in it… ;-) 
20160322 02:38:07< celticminstrel> Is there something I might be able to do on my local copy to get at least the monospaced font to not leave out all the punctuation?
20160322 02:38:26< ancestral> It leaves out punctuation?
20160322 02:38:35< vultraz> ancestral: and it works?
20160322 02:38:41< ancestral> Yes
20160322 02:38:48< vultraz> then let's just commit it
20160322 02:38:50< celticminstrel> Something like that. In the gamestate inspector, or the Lua console.
20160322 02:39:06< vultraz> celticminstrel: there's punctuation in the lua console?
20160322 02:39:13< celticminstrel> vultraz: Uhh... obviously?
20160322 02:39:36< ancestral>  . : - ; ?
20160322 02:39:49< celticminstrel> vultraz: I think the hack-fix only works for certain languages, or something. Or doesn't work for certain languages.
20160322 02:40:00< ancestral> I had a graphic
20160322 02:40:06< vultraz> Most important is that it allows English to work
20160322 02:40:14< celticminstrel> It's not that it leaves out the punctuation, more that it's invisible or almost invisible.
20160322 02:40:53< celticminstrel> vultraz: Before saying that, do a survey and find out how many players are eg Japanese or Korean.
20160322 02:41:09< celticminstrel> IP survey should do, if such data is available.
20160322 02:41:21< celticminstrel> ...though sadly that'd be hard for single-player.
20160322 02:42:09< vultraz> celticminstrel: I'd rather commit fix then deal with problems than do without the fix indefinitely while we ponder whether it's a good idea
20160322 02:42:31< ancestral> http://mproud.com/wesnoth/fallback.png
20160322 02:43:56< vultraz> but I do want ancestral to do the commit
20160322 02:44:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160322 02:44:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 02:45:53< ancestral> vultraz: I can
20160322 02:47:39< ancestral> Probably tomorrow
20160322 02:48:38< celticminstrel> So does that fix the monospace?
20160322 02:48:43< ancestral> That I don’t know
20160322 02:48:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160322 02:49:12< ancestral> I feel like there’s something in hardwired/fonts.cfg that’s preventing that
20160322 02:49:27< ancestral> Well
20160322 02:49:35< ancestral> celticminstrel: Maybe. If it’s giong to the system default, it could be
20160322 02:49:49< ancestral> You can test it out, celticminstrel
20160322 02:50:01< celticminstrel> I'm not sure if it's the system default.
20160322 02:50:10< celticminstrel> What file do I edit?
20160322 02:50:14< celticminstrel> Oh.
20160322 02:50:17< celticminstrel> The one you just said?
20160322 02:50:31< ancestral> data/hardwired/fonts.cfg
20160322 02:51:14< ancestral> celticminstrel: So you can try editing line 8
20160322 02:51:18< ancestral>     family_order=_ "DejaVu Sans"
20160322 02:51:28< ancestral> Load and see if that works
20160322 02:52:33< celticminstrel> Hmm, there's a comment there about the monospace...
20160322 02:52:39< gfgtdf> celticminstrel: hmm i think i already explained twice why it need to push it wtice and call clear_ref :/
20160322 02:53:15< ancestral> celticminstrel: Where you’re seeing the issue, is it with GUI2 or GUI1?
20160322 02:53:24< celticminstrel> gfgtdf: Yeah, I definitely remember you explaining it before. Sorry for bad memory. :/
20160322 02:53:28< celticminstrel> ancestral: GUI2
20160322 02:53:56< celticminstrel> I think it's supposed to be DejaVu Sans Mono. I don't know what it actually is.
20160322 02:54:08< ancestral> Screenshot?
20160322 02:54:18< celticminstrel> Once I have a build that works, sure.
20160322 02:57:29-!- gfgtdf [~chatzilla@f054049134.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20160322 02:57:37< celticminstrel> vultraz: Alt+S is statistics, nothing to do with a leader.
20160322 02:57:45< celticminstrel> ...wait.
20160322 02:57:52-!- gfgtdf_ [~chatzilla@f054157159.adsl.alicedsl.de] has joined #wesnoth-dev
20160322 02:57:53< vultraz> well that's the diaog i mean
20160322 02:57:53-!- gfgtdf_ is now known as gfgtdf
20160322 02:57:56< celticminstrel> Maybe the alt key didn't register.
20160322 02:57:58< vultraz> it's in the source code as Leader Scroll
20160322 02:58:01< celticminstrel> Because now it's different.
20160322 02:58:06< vultraz> (I think)
20160322 02:58:08< vultraz> oh yeah
20160322 02:58:10< vultraz> you want alt s
20160322 02:58:11< celticminstrel> Yeah, that's what happened.
20160322 02:58:12< vultraz> not s
20160322 02:59:06< celticminstrel> Was the unit list always that compact?
20160322 02:59:33< celticminstrel> Does your unit preview pane show unit overlays, I wonder...
20160322 03:00:23< vultraz> don't know about the unit list
20160322 03:00:25< vultraz> and uhh
20160322 03:00:37< vultraz> not yet since as i said ive only done types not units
20160322 03:00:43< ancestral> vultraz, celticminstrel Imagine if Status Table and Statistics were both either S or T… and no alt! ;-)
20160322 03:01:00< celticminstrel> Statistics is already just S.
20160322 03:01:21< gfgtdf> celticminstrel: it need to push it twice to ensure that the oject still exists when calling clear_ref
20160322 03:01:24< ancestral> Status Table could be T (or vice versa)
20160322 03:01:36< ancestral> https://forums.wesnoth.org/viewtopic.php?p=580036#p580036
20160322 03:01:40< gfgtdf> celticminstrel: and it needs to call clear_ref to make sure the object isnt used after the function (like in storing the unit n a global variable)
20160322 03:02:04< celticminstrel> Ah, right, I remember now, the clear_ref() call basically sets it so that u.valid returns nil.
20160322 03:03:41 * celticminstrel saves the explanation this time.
20160322 03:04:44< vultraz> ancestral: probably could make some of those core default
20160322 03:05:49< celticminstrel> Not much feedback. Do you have download stats?
20160322 03:06:12< ancestral> Yep
20160322 03:06:38< ancestral> vultraz: Feel free to download the add-on and give me feedback
20160322 03:06:54< vultraz> Idid download
20160322 03:07:08< celticminstrel> ancestral: http://celmin.pwcsite.com/wesnoth/bad_monospace.png
20160322 03:07:15< vultraz> I think I did uninstall, though
20160322 03:07:19< celticminstrel> And what are those stats like?
20160322 03:07:21-!- gfgtdf [~chatzilla@f054157159.adsl.alicedsl.de] has quit [Ping timeout: 250 seconds]
20160322 03:08:08< vultraz> celticminstrel: I'm not gonna like, I really prefer the rendering you get on os x :P
20160322 03:08:14< vultraz> that font looks much better than our dvs
20160322 03:08:35< celticminstrel> It doesn't look bad per se, but the punctuation is missing or barely legible.
20160322 03:08:48< vultraz> ya
20160322 03:09:10< vultraz> always thought dvs's glyphs are too damn thin
20160322 03:09:37< celticminstrel> So I guess that's not DVS Mono?
20160322 03:10:01 * celticminstrel wonder if anyone's going to comment on the content rather than the presentation. >_>
20160322 03:12:07< vultraz> :P
20160322 03:12:10< vultraz> yeah that does look weird
20160322 03:12:14< vultraz> and not dvs mono
20160322 03:12:18< vultraz> it looks too good to be dvs mono
20160322 03:12:25< vultraz> honestly
20160322 03:12:31< vultraz> I think we should just get a brand new font
20160322 03:12:34< vultraz> DVS kinda sucks
20160322 03:12:44< celticminstrel> If you were ever wondering why the branch for my formula PR was called lua_formula_bridge when it had nothing to do with Lua, this screenshot might explain it.
20160322 03:16:53-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160322 03:26:07< celticminstrel> Down to 533 source files now, from something like 590.
20160322 03:26:14< celticminstrel> Thanks to the GUI2 consolidation, mostly.
20160322 03:26:33< vultraz> good, good
20160322 03:26:34 * celticminstrel is doing a full rebuild in order to enable Lua console history.
20160322 03:28:08< celticminstrel> BTW, you should try to somehow add wiki comments to the unit preview pane.
20160322 03:28:23< celticminstrel> I realize this might be hard since they use a cryptic magic format, but...
20160322 03:28:55< celticminstrel> It needs a comment for the definition and another comment for the builder.
20160322 03:30:13 * vultraz groans
20160322 03:30:15< vultraz> whyyy
20160322 03:30:26< celticminstrel> Why what? Why the cryptic confusing magic format?
20160322 03:31:00< vultraz> why do I have to learn the cryptic format :P
20160322 03:31:32< celticminstrel> Weeeeellll... the alternative would be to invent a new format and convert everything to it...
20160322 03:33:38< vultraz> we're programmers, isn't that our mantra :P
20160322 03:33:47< celticminstrel> Uh. Not really?
20160322 03:34:40-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160322 03:35:28< vultraz> ancestral: if you had to choose a new font for wesnoth, what would you choose
20160322 03:37:29< celticminstrel> Okay, so I guess my readline is different than the readline that Wesnoth expects, somehow?
20160322 03:37:41< celticminstrel> Because it's getting compiler errors on history calls.
20160322 03:38:15< celticminstrel> Though, only two of them. Hmm.
20160322 03:38:44< vultraz> ancestral: you have a good eye for such things
20160322 03:44:44-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160322 03:45:32-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Quit: Lost terminal]
20160322 03:45:44< celticminstrel> Okay, so it seems that I have readline 4.2.
20160322 03:45:45-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160322 03:45:56< celticminstrel> I'm guessing that's too old.
20160322 03:46:17< celticminstrel> The latest appears to be 6.3 or something.
20160322 03:47:36< celticminstrel> And lo, I have 6.3 as well. Now to get Xcode to use it without changing the project file...
20160322 03:50:11< celticminstrel> Well, that was easy. \o/
20160322 03:50:28< celticminstrel> Hope it works.
20160322 03:51:00-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 244 seconds]
20160322 03:53:48-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160322 03:53:59< ancestral> vultraz: For body text?
20160322 03:54:50< ancestral> Well, Wesnoth is in several Latin dialects and Cyrillic, so having cohesion there is sort of important, which limits your scope.
20160322 03:55:20< ancestral> If we had access to a commercial font, man, we’d have so many options
20160322 03:55:27< ancestral> Alas, that is not the case
20160322 03:56:28-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160322 03:56:48< ancestral> vultraz: Just responded to you :-P
20160322 04:02:58< ancestral> But with or without that restriction, in the realm of free fonts, and sans-serif, I’d consider testing several bodies of text with Caudex, Infini or maybe Proza (http://www.fontsquirrel.com)
20160322 04:04:00< vultraz> in order to use commercial fonts we'd have to license it, right
20160322 04:04:05< ancestral> Yeah
20160322 04:04:07< ancestral> Although
20160322 04:04:10< vultraz> can we do that?
20160322 04:04:33< ancestral> Well, most commercial places would want $ per client/download
20160322 04:04:44< ancestral> Or a flat fee, like five or six figures
20160322 04:04:48< ancestral> however
20160322 04:04:55< celticminstrel> ITALICS
20160322 04:04:59< ancestral> :-P
20160322 04:05:09< celticminstrel> Don't like underline?
20160322 04:05:19< ancestral> If someone knew what Wesnoth was, and thought it was great, maybe they would allow us to use it
20160322 04:05:27< vultraz> Caudex is nice, but it's a serif font
20160322 04:05:31< ancestral> (That might just be wishful thinking, however)
20160322 04:05:56< ancestral> Sorry, Caudex is serif, you’re right
20160322 04:06:04< celticminstrel> I think a serif font would actually be better for the monospaced portions.
20160322 04:06:08< ancestral> It’s a little stylish for body text
20160322 04:06:12< ancestral> *too
20160322 04:06:33< vultraz> I think out of those Proza is the best bet
20160322 04:06:58< ancestral> I did this: https://forums.taleworlds.com/index.php/topic,278728.0/topicseen.html
20160322 04:07:14< vultraz> ancestral: this looks nice https://fontlibrary.org/en/font/nimbus-sans-l
20160322 04:07:15< ancestral> Click the spoiler: preview buttons
20160322 04:07:28< ancestral> Nimbus sans is basically a Helvetica clone
20160322 04:08:15< vultraz> but it does look nice :P
20160322 04:08:19< ancestral> The one thing I do like with Deja Vu Sans, despite how bland it sort of is, is that it is a bit wider, which adds to the legibility, especially at smaller sizes
20160322 04:09:18< vultraz> but the glyph lines are narrow
20160322 04:09:21< vultraz> and it looks bad
20160322 04:10:10< ancestral> In hindsight, some of that could stand a little extra spacing
20160322 04:10:46< ancestral> vultraz: Part of me would like to see an old printed type in Wesnoth
20160322 04:11:01< vultraz> that's not very Modern
20160322 04:11:06< ancestral> http://iginomarini.com/fell/
20160322 04:11:37< ancestral> http://iginomarini.com/fell/the-revival-fonts/
20160322 04:12:37< vultraz> ehhh
20160322 04:12:41< vultraz> bit too 'old' looking
20160322 04:13:37< vultraz> I do like the look of some of the fonts on the teleworlds link
20160322 04:14:15< ancestral> I took some fonts that probably aren’t great for bodies of text
20160322 04:14:27< ancestral> It was to spice up dialogs a bit
20160322 04:14:32< vultraz> yeah
20160322 04:14:42< vultraz> see the thing about those games is the UI is very 'themed'
20160322 04:14:47< vultraz> we don't have that
20160322 04:14:47< ancestral> Also, the text is typically faitly large
20160322 04:15:15< ancestral> This is in many languages: https://fontlibrary.org/en/font/bretan
20160322 04:15:50< vultraz> That does look good
20160322 04:16:18< vultraz> I wonder how hard it'd be to try it out in-game
20160322 04:18:24< ancestral> It’s pretty easy to do
20160322 04:18:52< ancestral> Download it, rename DejaVuSans.ttf, rename this font to that filename, and run
20160322 04:19:40< vultraz> we want the TrueType files not OpenType, right
20160322 04:21:25< ancestral> That download has both
20160322 04:21:32< ancestral> It’s not hard to convert from otf to ttf
20160322 04:22:10< vultraz> ok, the game is using the new font for gui1...
20160322 04:22:13< ancestral> Some libraries/rendering software seem to handle otf just fine even when just looking for otf
20160322 04:22:17< ancestral> *ttf
20160322 04:22:22< ancestral> vultraz: Yeah hmm
20160322 04:22:40< ancestral> Might need to edit fonts.cfg? one sec
20160322 04:22:45< vultraz> font size need to increase... gui2 still seems to be using dvs
20160322 04:22:51< ancestral> Yeah
20160322 04:24:53< vultraz> not sure why that's happening
20160322 04:26:10< vultraz> ah got it
20160322 04:26:38< vultraz> seems to be missing one or two characters.. weird
20160322 04:26:43< vultraz> also need to bump the font size..
20160322 04:27:50< vultraz> initial results are promising
20160322 04:30:09< ancestral> I had to change the `family_order` to Coval, in hardwired/fonts.cfg (but maybe that’s because I have Deja Vu Sans installed on my computer.)
20160322 04:30:40< vultraz> yeah I did too
20160322 04:30:48< vultraz> I guess gui2 looks for fonts by family, not filename
20160322 04:31:11< ancestral> Hmm
20160322 04:31:27< ancestral> I think maybe Book may be better than Regular
20160322 04:31:31< ancestral> Let’s find out
20160322 04:31:36< vultraz> ancestral: https://www.dropbox.com/s/2lr0gm7w9xwlq2m/wesnoth%20conval%20font.PNG?dl=0
20160322 04:31:45< vultraz> that's with Regular, I think
20160322 04:31:49< ancestral> Had to do font scaling
20160322 04:31:54< ancestral> To make it look good
20160322 04:31:57< vultraz> I had to up the font size
20160322 04:32:00< vultraz> to make it look good
20160322 04:32:10< vultraz> 2 point up from DVS
20160322 04:34:18< vultraz> I feel there's something wrong with my font rendering..
20160322 04:35:33< ancestral> Yeah, I think Book works a bit better for me. There’s a bit less contrast in strokes
20160322 04:35:44< vultraz> I never though I'd say this, but the GUI1 rendering looks better than the Pango/Cairo rendering :|
20160322 04:35:56< ancestral> And as crazy as it may seem, 140% UI
20160322 04:37:13< vultraz> how in the world does SDL_ttf look better
20160322 04:37:59< vultraz> ancestral: btw, there's no BookBold
20160322 04:38:04< vultraz> so I used Black
20160322 04:38:09< vultraz> for bold
20160322 04:38:12< ancestral> So
20160322 04:38:23< ancestral> A little lesson for you ;-)
20160322 04:38:37< ancestral> If on a scale of 0-1000
20160322 04:38:42< ancestral> 0 is the thinnest
20160322 04:38:46< ancestral> 1000 is the heaviest
20160322 04:39:03< ancestral> Book is 400
20160322 04:39:06< ancestral> Regular is 500
20160322 04:39:09< ancestral> Medium is 600
20160322 04:39:16< vultraz> Oh
20160322 04:39:22< ancestral> Demi-bold, Bold, Heavy, Black
20160322 04:39:28< ancestral> (Something like that)
20160322 04:39:43< vultraz> so Black is actually less bold?
20160322 04:40:55< ancestral> It looks like
20160322 04:40:58< vultraz> huh
20160322 04:41:02< ancestral> Bold - Extra Bold - Heavy - Black
20160322 04:41:07< ancestral> Black is the heaviest
20160322 04:41:18< vultraz> wait, does heavy mean more bold is less bold
20160322 04:41:28< ancestral> Black is the most bold
20160322 04:41:48< vultraz> ah
20160322 04:42:27< vultraz> Ok, pango/cairo is seriously rendering this noticeably worse than sdl_ttf
20160322 04:42:41< vultraz> shadowm: you told me for years that sdl_ttf was worse than pango :|
20160322 04:43:01< ancestral> Thin Extra-Light Light Book Regular (normal)
20160322 04:43:21< ancestral> vultraz: I took some pics
20160322 04:43:31< vultraz> ancestral: do post, I want to compare to mine
20160322 04:43:34< celticminstrel> vultraz: That's because it is worse.
20160322 04:43:46< ancestral> vultraz: shadowm will say something about how it’s specific to Windows
20160322 04:43:47< vultraz> celticminstrel: then how does it produce a better result
20160322 04:44:08< vultraz> ancestral: last time he posted a screenshot of his wesnoth, it looked *exactly the same* to what I was seeing
20160322 04:44:21< vultraz> I even did a pixel-exact comparison
20160322 04:44:23< celticminstrel> I don't really know what the details are of how it's worse.
20160322 04:44:53< celticminstrel> But it probably is related to non-Latin characters.
20160322 04:45:21< celticminstrel> Like, okay, sure; perhaps SDL_TTF is producing a better result in English.
20160322 04:45:30< celticminstrel> Perhaps it would produce a worse result in, say, Arabic.
20160322 04:46:14< celticminstrel> BTW ancestral, mattsc, are either of you able to edit the nib (other than by hand with a text editor)?
20160322 04:47:26< ancestral> Yes, if it’s converted, but not to add in the changelog
20160322 04:47:33< ancestral> That I have to edit via text editor
20160322 04:47:44< celticminstrel> "if it's converted"
20160322 04:47:44< ancestral> It should be possible to not do it the way we’re doing it
20160322 04:47:57< ancestral> There’s an automatic conversion that my Xcode wants to do
20160322 04:48:09< ancestral> But the UI element is too long for it to be edited in IB
20160322 04:48:09< celticminstrel> I want to convert it but ibtool doesn't seem to know how or something.
20160322 04:48:19< celticminstrel> Or maybe I'm doing it wrong.
20160322 04:48:42< ancestral> I think we need to pull it automatically from file
20160322 04:49:08< celticminstrel> Huh. I can't open my build by double-clicking it... why is this...
20160322 04:49:11< ancestral> celticminstrel: If I try to edit the nib, I get errors about a field being too long
20160322 04:49:19< ancestral> What version of OS X are you rocking?
20160322 04:49:35< celticminstrel> I'm on 10.7.
20160322 04:49:52< ancestral> vultraz: http://mproud.com/wesnoth/coval.png
20160322 04:49:55< ancestral> celticminstrel: That’s probably why
20160322 04:50:08< celticminstrel> Hm?
20160322 04:50:12< ancestral> At some point it may have gotten updated to a newer IB version
20160322 04:50:23< ancestral> (oops)
20160322 04:51:12< vultraz> ancestral: is that coval on both sides?
20160322 04:51:27< vultraz> s/both/all
20160322 04:51:32< celticminstrel> Oh. I thought it was an old format, not a new one.
20160322 04:52:19< celticminstrel> Is there any way to convert it to xib?
20160322 04:52:24< ancestral> Yes, Coval everywhere
20160322 04:52:26< vultraz> ancestral: what font size are you using?
20160322 04:52:36< vultraz> I bumped current gui2 settings by 2
20160322 04:52:40< vultraz> (in the wml)
20160322 04:53:05< ancestral> Font scaling 140% (in-game preferences)
20160322 04:53:33< celticminstrel> Or is there some reason why it's nib instead of xib?
20160322 04:55:07< vultraz> ancestral: https://www.dropbox.com/s/n4bc0srso17q257/wesnoth%20conval%20font140.PNG?dl=0 it looks significantly better once scaled to 140
20160322 04:55:15< vultraz> (that is 140)
20160322 04:55:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160322 04:56:03< vultraz> I'd say it no longer looks significantly worse
20160322 04:56:38< vultraz> however, what if we make the default 130
20160322 04:56:51< ancestral> celticminstrel: for me: https://cdn.img42.com/32793f51f3d647b8117f397be10da7ec.png
20160322 04:56:58< ancestral> But then that works
20160322 04:57:32< ancestral> vultraz: Not sure I like Coval much better
20160322 04:57:47< vultraz> ancestral: I think it's better than DVS
20160322 04:57:48< irker573> wesnoth: Celtic Minstrel wesnoth:master 5aa1b738cf66 / projectfiles/Xcode/ (Mac Sources/SDLMain.m Mac Sources/SDLMain.mm Wesnoth.xcodeproj/project.pbxproj): Fix Wesnoth crashing upon encountering XCode debug arguments https://github.com/wesnoth/wesnoth/commit/5aa1b738cf66ddb2890ffccb695d2e8f060309ae
20160322 04:57:50< irker573> wesnoth: Celtic Minstrel wesnoth:master f13f7470eb80 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Link with readline https://github.com/wesnoth/wesnoth/commit/f13f7470eb80022b6cf95d452fc05f10f22db86e
20160322 04:58:03< vultraz> and it does have language support
20160322 04:58:07 * ancestral looks for others (for fun)
20160322 04:58:10< ancestral> vultraz: True
20160322 04:58:27< celticminstrel> The first of those fixes the issue whereby new contributors need to edit the scheme to get it to run.
20160322 04:58:43-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20160322 04:58:44-!- wedge010 is now known as wedge009
20160322 04:58:59< celticminstrel> ancestral: That doesn't look like XCode... o.o
20160322 04:59:08< ancestral> Why do you say?
20160322 04:59:25 * celticminstrel is using XCode 4.
20160322 04:59:42 * ancestral is using Xcode 7.2.1
20160322 04:59:53< vultraz> heh
20160322 04:59:57< celticminstrel> Where'd everything go? :|
20160322 05:00:17< vultraz> it's probably a minimal editing window
20160322 05:00:51< ancestral> celticminstrel: It’s just a window I took a screen of
20160322 05:00:57< celticminstrel> How hard would it be to make it load the changelog either on startup or when the window is shown?
20160322 05:01:22< ancestral> In the game, or in Xcode?
20160322 05:01:30< celticminstrel> The game.
20160322 05:01:39< celticminstrel> Rather than embedding it into the nib.
20160322 05:01:54< ancestral> That’s an interesting idea
20160322 05:02:05< celticminstrel> I don't know why no-one thought of it before.
20160322 05:02:16< ancestral> celticminstrel: I was going to offer, it’s likely possible to have it load in some sort of UI element from the changelog file
20160322 05:02:45< ancestral> So if the changelog file gets edited, we don’t have to copy-pasta all sorts of things
20160322 05:02:56< celticminstrel> Yeah.
20160322 05:03:26< celticminstrel> It means updating the changelog (I guess it's the players_changelog) would be as simple as adding it to XCode's copy files stage.
20160322 05:03:32< celticminstrel> And then it's automatic.
20160322 05:03:59< vultraz> ancestral: well I think coval is a solid candidate for a new font
20160322 05:04:04< celticminstrel> Also, doesn anyone else get a flicker of one of the two extra windows when quitting the game?
20160322 05:04:23< celticminstrel> ^does
20160322 05:04:27< vultraz> ancestral: do you think we should use it? (assuming you don't find a better one)
20160322 05:04:33< celticminstrel> "anyone else" here means ancestral or mattsc 
20160322 05:04:34< ancestral> vultraz: There’s a dpi setting in the source files
20160322 05:05:19< ancestral> vultraz: No need to jump to something immediately. I’d want to take more screenshots and compare.
20160322 05:05:32< ancestral> How does it look in DVS vs. Something Else
20160322 05:05:59< ancestral> celticminstrel: Lemme find out
20160322 05:06:16< ancestral> I don’t think so
20160322 05:07:29< celticminstrel> It appears for a moment and then disappears again.
20160322 05:08:14< celticminstrel> Uhh... my test scenario has mysteriously disappeared from the scenario list again... :|
20160322 05:08:24< vultraz> ancestral: I'll leave the decision up to you
20160322 05:08:58< vultraz> ancestral: but I'm thinking we could test audience reception to a new font next dev release, if we decide to do that
20160322 05:09:14< vultraz> (next dev release is a month or two away still)
20160322 05:09:26< vultraz> but these initial results are very promising 
20160322 05:09:39< ancestral> vultraz: If we’re going to change the font, we need to have more than one option. I’ve for years considered it, but I don’t want to see it changed and then Polish players or Turkish players or whomever have a hard time reading text because the buttons don’t have enough room anymore
20160322 05:10:00< vultraz> that's... a radical idea
20160322 05:10:03< ancestral> (That being said, DVS is fairly wide)
20160322 05:10:11< vultraz> games usually don't ship multiple fonts
20160322 05:10:33< ancestral> vultraz: That and it might be needed to make some spatial adjustments
20160322 05:10:38< ancestral> Which means maybe a modified theme
20160322 05:10:53< vultraz> keep in mind gui2 scales elements to fit fonts
20160322 05:11:25< vultraz> ancestral: but you raise a good point
20160322 05:11:36< vultraz> I think the best course is to decide on a new primary font
20160322 05:11:43< vultraz> then let the community give feedback
20160322 05:11:48< vultraz> especially the people who use translations
20160322 05:11:56< vultraz> too small? no glyphs? etc
20160322 05:12:16< ancestral> There might be some other considerations
20160322 05:12:26< ancestral> Like, would it be nice to have a companion serif?
20160322 05:12:41< ancestral> Or a condensed version
20160322 05:12:58< ancestral> vultraz: How far out would it be for the in-game sidebar to move to GUI2?
20160322 05:13:01< celticminstrel> I think the recruit dialog would look better if the list stuck to the top rather than floating in the middle.
20160322 05:13:10< ancestral> Would it require a fairly large conversion?
20160322 05:13:17< vultraz> extremely large conversion
20160322 05:13:20< vultraz> but a very satisfying one
20160322 05:13:22< celticminstrel> vultraz: ^
20160322 05:13:30< vultraz> celticminstrel: it is...
20160322 05:13:38< vultraz> celticminstrel: oh you mean the dialog?
20160322 05:13:42< ancestral> “if the list stuck to the top rather than floating in the middle.”
20160322 05:13:45< ancestral> Huh?
20160322 05:13:46< celticminstrel> No. Try playing the tutorial.
20160322 05:14:04< celticminstrel> It floats in the middle of the dialog.
20160322 05:14:28< celticminstrel> Or would you prefer a screenshot?
20160322 05:14:52< vultraz> oh
20160322 05:14:54< vultraz> yes
20160322 05:15:02< ancestral> Oh I see
20160322 05:15:12< ancestral> That reminds me
20160322 05:15:37< ancestral> Now that we’re talking about possibly, potentially overhauling every kind of UI :-P
20160322 05:15:48< celticminstrel> O_O
20160322 05:16:01< ancestral> vultraz: What place in the code controls the dash for the attacks-damage in the sidebar?
20160322 05:16:23< ancestral> I found a few places that hold the glyph for the recruit and damage window
20160322 05:16:28< vultraz> look for inclusions of 'weapons_damage_separator"
20160322 05:17:10< irker573> wesnoth: Charles Dang wesnoth:master 849242ca6b55 / data/gui/window/unit_recruit.cfg: tunit_recruit: align recruits listbox to top https://github.com/wesnoth/wesnoth/commit/849242ca6b5572a31ff5480012166d7bfe5b1363
20160322 05:17:11< vultraz> celticminstrel: ^
20160322 05:17:16< celticminstrel> Oh, the recruit dialog changed it to multiplication.
20160322 05:17:26< vultraz> celticminstrel: no, the unit preview pane did
20160322 05:17:28< ancestral> That
20160322 05:17:29< ancestral> 0 results found
20160322 05:17:31< celticminstrel> Yeah that.
20160322 05:17:47< celticminstrel> Maybe weapon_damage_separator?
20160322 05:17:51 * celticminstrel has no idea.
20160322 05:18:37< shadowm> vultraz: I never said that.
20160322 05:19:14< vultraz> ancestral: sorry, weapon_numbers_sep and weapon_details_sep
20160322 05:19:25< celticminstrel> Better!
20160322 05:19:32< vultraz> shadowm: well that's the impression I got
20160322 05:19:43< vultraz> I thought you considered SDL_ttf the brother of SDL_net
20160322 05:19:46< shadowm> I said SDL_ttf needs to die, for completely different reasons I should not elaborate on in public.
20160322 05:20:12< shadowm> https://gna.org/bugs/index.php?20815
20160322 05:20:22< ancestral> vultraz: Thanks
20160322 05:20:51< ancestral> Okay, ancestral’s list of things he needs to do and wants to do:
20160322 05:21:11< ancestral> 1. Fix libraries so 10.6-10.9 can use 1.13.4
20160322 05:21:15< celticminstrel> shadowm: Still happens with SDL2?
20160322 05:21:36< ancestral> 2. Update MacCompileStuff
20160322 05:21:46< ancestral> (kinda dependent on #1)
20160322 05:21:47< shadowm> celticminstrel: You shouldn't need to ask that question.
20160322 05:21:52< ancestral> 3. Finish trailer
20160322 05:22:02< ancestral> 4. Play around with themes and fonts
20160322 05:22:02< celticminstrel> :/
20160322 05:22:16< vultraz> Good, good
20160322 05:22:23< shadowm> Read the upstream report carefully and you'll find the answer.
20160322 05:23:56< vultraz> shadowm: well, it's just unfortunate that pango renders worse. for some reason.
20160322 05:24:19< shadowm> Define 'worse'.
20160322 05:24:46< ancestral> (0. Finish moving stuff into new house, spend time with fiancée, have lunch with sister)
20160322 05:24:53-!- mjs-de [~mjs-de@x4db6282d.dyn.telefonica.de] has quit [Remote host closed the connection]
20160322 05:27:18< vultraz> shadowm: GUI!: https://www.dropbox.com/s/335k62t3yjv91np/wesnoth%20conval%20font%20GUI1.PNG?dl=0 VS GUI2: https://www.dropbox.com/s/gm6py03fec0uqu8/wesnoth%20conval%20font%20GUI2.PNG?dl=0
20160322 05:27:23< vultraz> GUI1*
20160322 05:28:15< ancestral> BTW https://en.wikipedia.org/wiki/Sam_Lantinga
20160322 05:28:35< ancestral> Oh he’s over at Valve
20160322 05:28:48 * shadowm knows who he is.
20160322 05:29:03< ancestral> I figure some people around here may not
20160322 05:29:08< shadowm> vultraz: No idea what's going on there.
20160322 05:29:09< vultraz> shadowm: I dunno if it's just me, but AA looks significantly worse in the GUI2 rendering
20160322 05:29:29< ancestral> I think it looks better on OS X than GUI1
20160322 05:29:32< ancestral> By far
20160322 05:29:40< shadowm> I'm not going to waste my time with this but it looks like the shapes are different too.
20160322 05:29:46< celticminstrel> I assume that's if you havk in some fix, ancestral/
20160322 05:29:51< celticminstrel> ^hack
20160322 05:29:52< ancestral> vultraz: ClearType is off or on? I know traditionally you guys turned it off, but
20160322 05:30:00< shadowm> I disabled ClearType.
20160322 05:30:03< ancestral> celticminstrel: If I don’t, it renders Helvetica
20160322 05:30:22< shadowm> If it were enabled it'd look like smudgy colorful diarrhea.
20160322 05:30:33< ancestral> shadowm: Just curious if vultraz turned it on if he thinks it looks better for him with GUI2. Just curious is all.
20160322 05:30:53< ancestral> Colorful diarrhea? Hmm.
20160322 05:30:54< vultraz> is it that stuff in fonts.conf?
20160322 05:31:03< shadowm> No, fonts.conf isn't used on Windows.
20160322 05:31:09< vultraz> then how do I enable it?
20160322 05:31:12< celticminstrel> ClearType would be in Windows settings or something.
20160322 05:31:13< shadowm> Don't enable it.
20160322 05:31:30< ancestral> The ClearType thing is in src, but maybe shadowm knows much more than I do
20160322 05:31:43< ancestral> Maybe your computer will explode with poop flying everywhere
20160322 05:31:48< shadowm> Sigh.
20160322 05:31:58< shadowm> I'm talking of not enabling ClearType IN WESNOTH.
20160322 05:32:11< ancestral> Yes
20160322 05:32:15< vultraz> do you mean the cairo_font_options_set_antialias() thing?
20160322 05:32:27< ancestral> That is also what I was talking of
20160322 05:32:57< shadowm> https://gna.org/bugs/index.php?21648
20160322 05:33:07< shadowm> Don't make me explain the whole thing all over again.
20160322 05:33:07< celticminstrel> ClearType is antialiasing.
20160322 05:33:16< celticminstrel> I think.
20160322 05:33:24< celticminstrel> So probably.
20160322 05:34:33-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 05:34:34< travis-ci> wesnoth/wesnoth#9003 (master - f13f747 : Celtic Minstrel): The build has errored.
20160322 05:34:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117633196
20160322 05:34:34-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 05:34:46< ancestral> Subpixel anti-aliasing often looks better or worse depending on the type of monitor you have.
20160322 05:34:47< vultraz> looks like shit if you get rid of that line
20160322 05:34:56< ancestral> LCD versus CRT
20160322 05:35:09< celticminstrel> People still have CRT?
20160322 05:35:29< vultraz> if you use CRT you deserve horrible rendering
20160322 05:35:35< ancestral> But maybe even between different types of LCDs
20160322 05:35:41< vultraz> what about LED?
20160322 05:35:49< celticminstrel> I doubt that exists.
20160322 05:35:51< shadowm> LED backlight, still LCD screen.
20160322 05:36:28< shadowm> (Not to be confused with OLED.)
20160322 05:37:29< vultraz> bottom line, we still need that fix 
20160322 05:37:50< shadowm> What fix are we talking about?
20160322 05:38:03< vultraz> the AA thing
20160322 05:38:09< shadowm> What AA thing?
20160322 05:38:20< vultraz> cairo_font_options_set_antialias(fo, CAIRO_ANTIALIAS_GRAY);
20160322 05:39:26< shadowm> Oh, #21648's workaround.
20160322 05:39:26< shadowm> Which is not a fix.
20160322 05:39:26< vultraz> workaround
20160322 05:39:26< vultraz> we still need it
20160322 05:39:26< shadowm> A real fix would be for someone to make the alpha decoding logic work correctly on Windows.
20160322 05:39:26< shadowm> Blah blah blah I've said this too many times.
20160322 05:39:26< shadowm> Who the hell cares.
20160322 05:39:26< shadowm> Not you, evidently.
20160322 05:39:26< ancestral> The grayscale aa looks okay to me
20160322 05:39:40< ancestral> But I am in no place to comment
20160322 05:39:56< vultraz> 86 DPI does look pretty good
20160322 05:39:59< ancestral> I don’t have enough experience with Windows to compare it to
20160322 05:40:08< shadowm> That's quite debatable. Much of the point of ClearType is being able to use RGB subpixel hinting.
20160322 05:40:19< vultraz> ancestral: keep 86 in mind
20160322 05:40:28< shadowm> OTOH RGB subpixel hinting is a massive trap if your application isn't engineered specifically to use it.
20160322 05:40:44< ancestral> Some of the pics with ClearType do look very bad that shadowm posted
20160322 05:41:01< shadowm> Meaning, let the renderer know the background color/texture rather than render on an invisible background and then reuse that on arbitrary surfaces.
20160322 05:41:05< ancestral> The cairo-1.14.2-defaults looks like garbage
20160322 05:41:22< shadowm> That obviously wouldn't scale well for our purpose, so arguably we should stick to grayscale anyway.
20160322 05:41:23< ancestral> vultraz: Yes, halfway between 72 and 96
20160322 05:41:25< shadowm> *purposes
20160322 05:42:05< shadowm> In fact, I think I read IE disables RGB subpixel hinting with ClearType when rendering web pages, for the same reason.
20160322 05:42:06< ancestral> vultraz: Even keeping DVS. It makes it easier to read on large monitors.
20160322 05:42:57< vultraz> ancestral: well, I think 86 looks better than 84
20160322 05:43:00< vultraz> but we'll see
20160322 05:43:39< ancestral> Anyway
20160322 05:44:04< vultraz> Let's see what we can do for 1.13.5. :)
20160322 05:44:36< ancestral> vultraz: Don’t pull the carpet out under the rug, k?
20160322 05:44:47< vultraz> eh?
20160322 05:44:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 05:44:51< vultraz> what carpet
20160322 05:44:53< vultraz> what rug
20160322 05:45:01< ancestral> You’re not good with metaphors, it seems
20160322 05:45:10< vultraz> not this specific one
20160322 05:45:29< vultraz> "carpet out from under someone", yes. 
20160322 05:45:59< vultraz> but don't pull the carpet out [from] under the rug?
20160322 05:46:13< ancestral> yeah, [from]
20160322 05:46:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160322 05:46:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160322 05:47:51< ancestral> By the time vultraz is done, Wesnoth will be renamed too!
20160322 05:47:54< ancestral> ;-)
20160322 05:48:45< ancestral> (vultraz: Let’s let some of these UI ideas marinate for a little while.)
20160322 05:49:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20160322 05:50:01< vultraz> obviously 
20160322 05:50:03< vultraz> :P
20160322 05:50:23< vultraz> but I figure action is better than inaction
20160322 06:00:11-!- Kwandulin [~Miranda@p200300760F191C3B5891764187D8E127.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160322 06:00:20-!- celticminstrel is now known as celmin|sleep
20160322 06:02:11< vultraz> ancestral: I don't know what your job is, but I do have a guess, and based on that guess I'm guessing you do know that decisions regarding further development are better put forward and discussed than otherwise
20160322 06:02:33< vultraz> (basically I think you're a software dev somewhere)
20160322 06:02:58< vultraz> but yeah, I'm not going to go commit the fonts tomorrow or something :P
20160322 06:03:24< vultraz> I just think wesnoth has had its fair share of downtime
20160322 06:04:31< ancestral> Generally speaking, I agree
20160322 06:04:55< ancestral> I just want to make smart decisions
20160322 06:05:30< ancestral> Sometimes trying something different (for better or for worse) is better than not trying at all
20160322 06:09:02< vultraz> Yup
20160322 06:24:48-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 06:24:49< travis-ci> wesnoth/wesnoth#9004 (master - 849242c : Charles Dang): The build has errored.
20160322 06:24:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117635045
20160322 06:24:49-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 07:28:43< irker573> wesnoth: Charles Dang wesnoth:master b0c485f5d020 / data/core/units/ (10 files in 5 dirs): Tweak/improve several unit help profiles https://github.com/wesnoth/wesnoth/commit/b0c485f5d0204265fadcb9dcbf1b52ddc61c14d7
20160322 07:29:16< vultraz> celmin|sleep: ^
20160322 07:29:52< irker573> wesnoth: Charles Dang wesnoth:master 7a04c01dc7ee / src/gui/dialogs/wml_error.cpp: twml_error: set restore flag https://github.com/wesnoth/wesnoth/commit/7a04c01dc7ee6d8e82e7254618bb3bd2909697bf
20160322 07:33:30-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160322 07:35:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160322 07:50:21-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160322 07:57:16-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160322 08:00:22-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160322 08:11:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 08:16:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160322 08:32:33-!- travis-ci [~travis-ci@ec2-54-158-81-19.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 08:32:34< travis-ci> wesnoth/wesnoth#9006 (master - 7a04c01 : Charles Dang): The build has errored.
20160322 08:32:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117648302
20160322 08:32:34-!- travis-ci [~travis-ci@ec2-54-158-81-19.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 09:25:53< Aginor> 20160321 22:55:41< celticminstrel> Okay, I have no clue what ~BL() is doing...
20160322 09:26:00< Aginor> 20160321 22:55:59< celticminstrel> Maybe Aginor can figure this out?
20160322 09:27:35< Aginor> celmin|sleep: I can't even figure out what ~BL is in your context
20160322 09:28:41< zookeeper> the blurring IPF
20160322 09:29:35< Aginor> what's an IPF? :)
20160322 09:30:14< zookeeper> you know, this stuff: https://wiki.wesnoth.org/ImagePathFunctionWML
20160322 09:30:27< zookeeper> the blurring code being in https://github.com/wesnoth/wesnoth/blob/master/src/sdl/utils.cpp#L1659 IIRC
20160322 09:31:07< Aginor> I actually that blurring code needs to die :/
20160322 09:31:15 * Aginor facepalm
20160322 09:31:20< Aginor> That blurring code needs to die :/
20160322 09:31:35< Aginor> I actually have no idea of the image path through WML
20160322 09:32:12< zookeeper> i believe the same code is used for the dialog bg blurring too, so it's not even specific to IPF's
20160322 09:32:23< Aginor> yes
20160322 09:32:34< Aginor> it is
20160322 09:32:51< Aginor> this complicates my plans
20160322 09:33:07< Aginor> I did not realise all of those things were exposed to WML
20160322 09:33:33< Aginor> that complicates things
20160322 09:37:32< zookeeper> well, might be that blur_surface is used for the dialog blurring instead, but anyway.
20160322 09:37:46< Aginor> yeah
20160322 09:38:16< zookeeper> what plans were those?
20160322 09:38:19< Aginor> I'm dreading having to try to expose some of those things as shaders
20160322 09:38:23< zookeeper> ah, right
20160322 09:39:31< vultraz> we can kill the blue IPF
20160322 09:39:33< vultraz> if necessary
20160322 09:39:40< vultraz> er
20160322 09:39:43< vultraz> tyhe blur
20160322 09:39:44< vultraz> THE BLUR
20160322 09:40:12< vultraz> Aginor: neither of us can speak tonight :P
20160322 09:40:36< zookeeper> wouldn't a good way to do it be to just have those functions set some flags for the surface/texture, and then pass all the flags and values to the shader along with the texture?
20160322 09:40:58< Aginor> zookeeper: probably
20160322 09:41:36< Aginor> I have however managed to prove to myself that I am incapable of both coherent speech and thought tonight, so I might just zombie for a bit before going to bed
20160322 09:41:47< vultraz> heh
20160322 09:42:06< vultraz> I do hope once we switch to textures/shaders we can kill some of that code in that file
20160322 09:42:07< Aginor> been running training events at work today with little preparation, it turns exhausting
20160322 09:42:16< zookeeper> i'm no expert, but as far as i've seen passing arbitrary data as uniforms or whatever isn't tricky at all
20160322 09:42:40< Aginor> zookeeper: neither am I, so I'll take your word for it
20160322 09:42:47< Aginor> we still have some distance to go though :/
20160322 09:43:09< vultraz> always seems to be the case :P
20160322 09:43:27< zookeeper> vultraz, uh, no we can't "kill" the blur IPF
20160322 09:44:11< vultraz> if necessary it can be removed temporarily and reimplemented if necessary
20160322 09:44:25< zookeeper> removed when it's been reimplemented, yes
20160322 09:44:54< Aginor> vultraz: knowing that it's exposed in WML, I'm firmly on zookeeper's side now
20160322 09:45:13< zookeeper> and not only exposed but widely used
20160322 09:45:18< Aginor> we can't just break everything, especially not fundamental stuff like that
20160322 09:45:27< vultraz> zookeeper: ehh?
20160322 09:45:41< vultraz> by who
20160322 09:46:03< zookeeper> i dunno, by everyone who uses IPF
20160322 09:46:05< zookeeper> 's a lot?
20160322 09:46:33< vultraz> eh... I'll take your word for it...
20160322 09:47:47< vultraz> I'm just saying a new blurring implementation shouldn't have to work around the functionality of the IPF, but rather the other way around
20160322 09:48:52< zookeeper> i don't know what you might mean by that
20160322 09:49:02< zookeeper> it's not like the current API limits the new implementation
20160322 09:49:21< zookeeper> blurring is blurring, you give it a radius and it blurs. you can switch the underlying implementation whenever.
20160322 09:50:38< Aginor> zookeeper: we need to make sure it yields similar-looking results too
20160322 09:50:48< vultraz> Aginor: similar or better
20160322 09:51:30< zookeeper> of course, but i think that's kind of a given, it's not like there's usually major differences
20160322 09:51:46< zookeeper> as long as the type of blur used is similar, which i _think_ in this case is more or less gaussian blur
20160322 09:52:05< zookeeper> (not sure, might be something else too)
20160322 09:59:26-!- Kwandulin [~Miranda@p200300760F191C3B5891764187D8E127.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160322 10:06:24-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20160322 10:07:35< Elvish_Hunter> Hi all
20160322 10:07:45< Elvish_Hunter> Irker flood incoming...
20160322 10:08:14< Elvish_Hunter> I'm merging PR #461...
20160322 10:08:26< irker573> wesnoth: Bruno Macabeus wesnoth:master a79de2c35cbc / / (5 files in 4 dirs): wmlvalidator, wmlgrammar and wmldata: now it checks translatable lines. https://github.com/wesnoth/wesnoth/commit/a79de2c35cbc0fb86792284735dc08a77d872e67
20160322 10:08:28< irker573> wesnoth: Bruno Macabeus wesnoth:master aeb2dc65c112 / data/tools/wesnoth/wmlgrammar.py: It is not necessary to define default values to datatypes, they will be caught t https://github.com/wesnoth/wesnoth/commit/aeb2dc65c1128f4133f6c19b711e40114f2af43f
20160322 10:08:30< irker573> wesnoth: Bruno Macabeus wesnoth:master 2eeac0248c29 / data/ (schema.cfg tools/wmlvalidator): Created the optional parameter "list" https://github.com/wesnoth/wesnoth/commit/2eeac0248c29d30bcb2bc6920160b601b14f7831
20160322 10:08:32< irker573> wesnoth: Bruno Macabeus wesnoth:master 54efe7a8a9e5 / data/schema.cfg: Added datatype symbol https://github.com/wesnoth/wesnoth/commit/54efe7a8a9e5b8e3e7e4fb2e4019cda2ff1da7d0
20160322 10:08:34< irker573> wesnoth: Bruno Macabeus wesnoth:master 67e79f756397 / data/ (schema.cfg tools/wmlvalidator): I forgot to translate two comments https://github.com/wesnoth/wesnoth/commit/67e79f75639769d9640cf9ab9a95a34cdd4f14e7
20160322 10:08:36< irker573> wesnoth: Bruno Macabeus wesnoth:master adacf791115b / data/schema.cfg: Improved the regexp of symbols in schema.cfg https://github.com/wesnoth/wesnoth/commit/adacf791115b0e4602b384f781f2a60faba68136
20160322 10:08:38< irker573> wesnoth: Bruno Macabeus wesnoth:master b9f1ff84be4f / data/tools/ (wesnoth/wmldata.py wesnoth/wmlgrammar.py wmlvalidator): Update to Python3: using print function https://github.com/wesnoth/wesnoth/commit/b9f1ff84be4fa5fe61ba4e49adf5b13454a2610d
20160322 10:08:40< irker573> wesnoth: Bruno Macabeus wesnoth:master 128fc64f6038 / data/tools/wmlvalidator: Return message is now more readable https://github.com/wesnoth/wesnoth/commit/128fc64f603803ba052da0fc877706c6ab7f97b5
20160322 10:08:42< irker573> wesnoth: Bruno Macabeus wesnoth:master ff6aca41922d / .gitignore: Revert change in .gitignore https://github.com/wesnoth/wesnoth/commit/ff6aca41922debd61e23b32fb9d857e83bfabb9c
20160322 10:08:44< irker573> wesnoth: Bruno Macabeus wesnoth:master a6fec89753aa / data/tools/wmlvalidator: If you specify a directory, will scan all files from directory. https://github.com/wesnoth/wesnoth/commit/a6fec89753aaa6121a803e2da6812c879e742948
20160322 10:08:46< irker573> wesnoth: Bruno Macabeus wesnoth:master a2f8d93785ff / data/tools/wmlvalidator: Added some comments to organize https://github.com/wesnoth/wesnoth/commit/a2f8d93785ffd2bf062051552b7068297665d53e
20160322 10:08:48< irker573> wesnoth: Bruno Macabeus wesnoth:master 98833e2b5b84 / data/ (schema.cfg tools/wmlvalidator): Added optional parameter "optional-translatable" to some rare cases https://github.com/wesnoth/wesnoth/commit/98833e2b5b847024a8d8db801b4b0ec042bdbcc6
20160322 10:08:50< irker573> wesnoth: Bruno Macabeus wesnoth:master 42d4ae9109c6 / data/ (schema.cfg tools/wmlvalidator): Added the optional parameter "limit(\d+,\d+)", to specify the range of the value https://github.com/wesnoth/wesnoth/commit/42d4ae9109c667a09d56abca12723d382ccea624
20160322 10:08:52< irker573> wesnoth: Bruno Macabeus wesnoth:master 31794109addd / data/schema.cfg: Update schema.cfg: terrain_type finished https://github.com/wesnoth/wesnoth/commit/31794109addd846dc1c66950f2275200bb10fc93
20160322 10:08:54< irker573> wesnoth: Bruno Macabeus wesnoth:master 7009d360ab3f / data/schema.cfg: Ops, I had written twice accidentally https://github.com/wesnoth/wesnoth/commit/7009d360ab3f90768400cf4b3238fa5dda059c56
20160322 10:08:56< irker573> wesnoth: Bruno Macabeus wesnoth:master 5e5128680c2f / data/tools/wmlvalidator: Fixbug commit f1006f1adcb56fa823108a819ec5d4c739424a22: I forgot to take the cas https://github.com/wesnoth/wesnoth/commit/5e5128680c2f6965383e4e651d88a4f817978349
20160322 10:08:58< irker573> wesnoth: Bruno Macabeus wesnoth:master 426abfd46e1a / data/tools/wmlvalidator: Added check "FORBIDDEN" for element https://github.com/wesnoth/wesnoth/commit/426abfd46e1adecf4c917b5ff94b445ecb94fd47
20160322 10:09:00< irker573> wesnoth: Bruno Macabeus wesnoth:master f76a0596d985 / data/schema.cfg: Various attributes' [scenario] and derived elements' of it have been implemented https://github.com/wesnoth/wesnoth/commit/f76a0596d985f46aefbe17e073538e6aec6a10ee
20160322 10:09:02< irker573> wesnoth: Bruno Macabeus wesnoth:master 71b4d75f15f0 / data/tools/wmlvalidator: Fixbug: Not correctly checked if using the optional parameters 'limit(a,b)' and  https://github.com/wesnoth/wesnoth/commit/71b4d75f15f03f65b6644bc8f616e0530dfcf8cd
20160322 10:09:04< irker573> wesnoth: Bruno Macabeus wesnoth:master a0c882b02d05 / data/ (schema.cfg tools/wmlvalidator): Added the optional parameter "need-file-in(dir)", to check if the file exists https://github.com/wesnoth/wesnoth/commit/a0c882b02d0537e5d92557d32b4bfe0f977d82a2
20160322 10:09:06< irker573> wesnoth: Bruno Macabeus wesnoth:master 58e8bc724676 / data/ (schema.cfg tools/wmlvalidator): Added almost the attributes of the [side] https://github.com/wesnoth/wesnoth/commit/58e8bc7246766f7b86bfff0330fbeef71740cf16
20160322 10:09:08< irker573> wesnoth: Bruno Macabeus wesnoth:master 74b72bb84635 / data/ (schema.cfg tools/wmlvalidator): Added attributes of the [ai] https://github.com/wesnoth/wesnoth/commit/74b72bb8463582b19004d2b9073c5093b7e1a94a
20160322 10:10:06< Elvish_Hunter> To perform this merge I had to do a lot of cherry-picking, in order to exclude the merge commits :/
20160322 10:10:43< Aginor> Elvish_Hunter: you can rebase-away the merges
20160322 10:12:52< Elvish_Hunter> I tried rebasing. It ended up with me trying to solve a lot of conflicts in various files (especially the changelog).
20160322 10:13:23< Elvish_Hunter> Also, I had to exclude two commits related to Python 3 porting, one of which reverted the other.
20160322 10:33:35< Elvish_Hunter> shadowm: can you please add forum user 'macabeus_br' to the Code & WML Contributors group?
20160322 10:38:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 10:39:20-!- Kwandulin [~Miranda@p200300760F191C3BE9034FD9DE24AE70.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160322 10:43:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160322 10:46:00< loonycyborg> I've managed to run python wmlxgettext pot-update to completion, I had to add magic # wmlxgettext comments to lobby_main.cfg to fix those errors
20160322 10:46:19< loonycyborg> but I kinda have no idea why perl wmlxgettext doesn't barf on it :P
20160322 10:46:49-!- travis-ci [~travis-ci@ec2-54-161-253-28.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 10:46:50< travis-ci> wesnoth/wesnoth#9007 (master - 74b72bb : Bruno Macabeus): The build has errored.
20160322 10:46:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117670854
20160322 10:46:50-!- travis-ci [~travis-ci@ec2-54-161-253-28.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 11:14:43-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20160322 11:32:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160322 11:42:14-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160322 11:52:40< loonycyborg> Nobun: Elvish_Hunter: https://gist.github.com/loonycyborg/ae2e5010ef952362b6fe
20160322 11:53:09< loonycyborg> that's the diff in pot files that results in switching from perl wmlxgettext to python wmlxgettext
20160322 11:53:19< loonycyborg> seems some data in comments is lost
20160322 11:53:33< loonycyborg> and even some msgstr and msgid entries
20160322 11:56:47-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160322 12:25:10< irker573> wesnoth: loonycyborg wesnoth:master 8d948765f90f / data/gui/window/lobby_main.cfg: wmlxgettext comments fixes needed by python wmlxgettext https://github.com/wesnoth/wesnoth/commit/8d948765f90f5a927052b64803bffd9d277c06e0
20160322 12:36:25-!- Kwandulin [~Miranda@p200300760F191C3BE9034FD9DE24AE70.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20160322 12:37:47-!- Kwandulin [~Miranda@2003:76:f19:1c49:e903:4fd9:de24:ae70] has joined #wesnoth-dev
20160322 12:51:54-!- mjs-de [~mjs-de@x4db6282d.dyn.telefonica.de] has joined #wesnoth-dev
20160322 13:03:15-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 13:03:16< travis-ci> wesnoth/wesnoth#9008 (master - 8d94876 : loonycyborg): The build has errored.
20160322 13:03:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117694749
20160322 13:03:16-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 13:21:10-!- celmin|sleep is now known as celticminstrel
20160322 13:23:45-!- gfgtdf [~chatzilla@f054157159.adsl.alicedsl.de] has joined #wesnoth-dev
20160322 13:41:12-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has quit [Ping timeout: 276 seconds]
20160322 13:42:25-!- ypnos [~ypnos@lme51.informatik.uni-erlangen.de] has joined #wesnoth-dev
20160322 14:04:04-!- Kwandulin [~Miranda@2003:76:f19:1c49:e903:4fd9:de24:ae70] has quit [Read error: Connection reset by peer]
20160322 14:18:06< gfgtdf> vultraz: the easycoding page suggested to add a seperator for different addons in the sceanriso list of the mp create dialog. I wonder whether it still makes sesne to hve this on that page if we plan to port the mp dialogs to gi2
20160322 14:18:35< celticminstrel> Well, I think I finally figured out my weird std::ios_base errors. I was trying to copy the lua_kernel_base.
20160322 14:18:55< celticminstrel> Forgot an &
20160322 14:21:11< celticminstrel> What I don't understand is why the error didn't point to that line.
20160322 14:22:33< irker573> wesnoth: Celtic Minstrel wesnoth:master 04006615330e / src/ai/ (configuration.cpp configuration.hpp): Generalize simplified aspect syntax https://github.com/wesnoth/wesnoth/commit/04006615330ea303f5087ee4fbefdd266d9f4303
20160322 14:22:35< irker573> wesnoth: Celtic Minstrel wesnoth:master 9c2027a8d8b2 / / (23 files in 9 dirs): Remove version key from AI configs https://github.com/wesnoth/wesnoth/commit/9c2027a8d8b2d3fd2dbf0ba9d5a6ca42ade929cc
20160322 14:22:37< irker573> wesnoth: Celtic Minstrel wesnoth:master e3679ff5475a / src/ai/configuration.cpp: Remove list of known aspects. https://github.com/wesnoth/wesnoth/commit/e3679ff5475aa09f1dbc2c2e063eb9899cc00d5b
20160322 14:22:39< irker573> wesnoth: Celtic Minstrel wesnoth:master fbb770ef3f07 / src/ai/configuration.cpp: Suppress an erroneous error message https://github.com/wesnoth/wesnoth/commit/fbb770ef3f076783c6e4e57a986ad56b6af68626
20160322 14:22:41< irker573> wesnoth: Celtic Minstrel wesnoth:master a9a22c972143 / src/ai/configuration.cpp: Allow old goal syntax and [modify_ai] in AI definitions https://github.com/wesnoth/wesnoth/commit/a9a22c9721439ee90be4079f85adceed3a242e49
20160322 14:22:43< irker573> wesnoth: Celtic Minstrel wesnoth:master e2ea9cd69978 / src/ai/lua/core.cpp: Lua AI: Add string version of status to AI action result table https://github.com/wesnoth/wesnoth/commit/e2ea9cd69978e79d0c68385e59e112fd6f6b4230
20160322 14:22:45< irker573> wesnoth: Celtic Minstrel wesnoth:master b0b02d61c659 / src/ai/configuration.cpp: In [leader_goal], never set facet ID to * or a number https://github.com/wesnoth/wesnoth/commit/b0b02d61c6594fdd710f2f8e3a9a4c400a6d84b9
20160322 14:22:47< celticminstrel> Uhh.
20160322 14:22:47< irker573> wesnoth: Celtic Minstrel wesnoth:master 28937124f3f8 / data/core/macros/ai_controller.cfg src/ai/registry.cpp: Remove [goal]name=protect and add [goal]name=target_unit https://github.com/wesnoth/wesnoth/commit/28937124f3f8cafd79085968c15afc1e01922149
20160322 14:22:49< irker573> wesnoth: Celtic Minstrel wesnoth:master ad075afd51d3 / src/ai/configuration.cpp: Don't interpret description or id attributes as simple aspects. https://github.com/wesnoth/wesnoth/commit/ad075afd51d3a32468c1feabe2c3a63e9ca0358f
20160322 14:22:51< irker573> wesnoth: Celtic Minstrel wesnoth:master a5d131cc1f3c / src/ai/lua/core.cpp: Fix potential crash when using an [engine]name=lua https://github.com/wesnoth/wesnoth/commit/a5d131cc1f3c3db4aa219d05aa49906624b54239
20160322 14:22:53< irker573> wesnoth: Celtic Minstrel wesnoth:master 852a25593ee6 / src/gui/dialogs/gamestate_inspector.cpp: Split gamestate inspector AI config up by component type https://github.com/wesnoth/wesnoth/commit/852a25593ee65d29c47fa8ab610069cc98e83c03
20160322 14:22:55< irker573> wesnoth: Celtic Minstrel wesnoth:master 08b11139a107 / src/ai/composite/ (engine_default.cpp engine_lua.cpp goal.cpp goal.hpp): Log useful error messages (and don't crash) when creating a goal with the wrong  https://github.com/wesnoth/wesnoth/commit/08b11139a107bea6f651c22d8944dae0085e5773
20160322 14:22:57< irker573> wesnoth: Celtic Minstrel wesnoth:master f57343d6f116 / src/ai/configuration.cpp: Minor simplification of AI config parsing https://github.com/wesnoth/wesnoth/commit/f57343d6f116c42107245c7ac001f7323bf251f2
20160322 14:22:59< irker573> wesnoth: Celtic Minstrel wesnoth:master b04cca2b3058 / src/ai/configuration.cpp: Special handling for [recruitment] tag in AI config https://github.com/wesnoth/wesnoth/commit/b04cca2b3058195fd4dedf8b208a8c427b1abf6e
20160322 14:23:01< celticminstrel> Why is the AI branch being merged? :(
20160322 14:23:01< irker573> wesnoth: Celtic Minstrel wesnoth:master 4f710ea805f8 / src/ai/ (6 files in 4 dirs): Allow Lua goals to set target types as descriptive strings instead of opaque int https://github.com/wesnoth/wesnoth/commit/4f710ea805f84581bef3be7d350885e7625bc53e
20160322 14:23:03< irker573> wesnoth: Celtic Minstrel wesnoth:master bcbba6dde3fe / data/ai/dev/idle_ai.cfg src/ai/configuration.cpp: Change ID of Idle AI https://github.com/wesnoth/wesnoth/commit/bcbba6dde3fe6ea2188e749bc6b67c74e461e321
20160322 14:23:05< irker573> wesnoth: Celtic Minstrel wesnoth:master f545fbcbe866 / src/ai/ (composite/goal.cpp composite/goal.hpp registry.cpp): Remove deprecated [goal]name=protect_my_unit https://github.com/wesnoth/wesnoth/commit/f545fbcbe866dc8689916b81c20a82b4d7753139
20160322 14:23:07< irker573> wesnoth: Celtic Minstrel wesnoth:master 56a99175dad6 / src/game_initialization/connect_engine.cpp: Fix main_loop stage being duplicated in MP https://github.com/wesnoth/wesnoth/commit/56a99175dad6ff0c17a94d7b0054602a4ede05fd
20160322 14:23:09< irker573> wesnoth: Celtic Minstrel wesnoth:master f8f5557eb0b9 / / (8 files in 3 dirs): Huge refactor of Lua AI engine https://github.com/wesnoth/wesnoth/commit/f8f5557eb0b984445f399760d41089e18c6aad37
20160322 14:23:11< irker573> wesnoth: Celtic Minstrel wesnoth:master 6972d5170fba / src/ai/lua/core.cpp: Add ai.aspects table which provides access to all aspects https://github.com/wesnoth/wesnoth/commit/6972d5170fbad35425e3672842b0e7ea4a5ac09a
20160322 14:23:13< irker573> wesnoth: Celtic Minstrel wesnoth:master ca8cb3bd6a45 / / (13 files in 6 dirs): Remove the deprecated recruitment stage, candidate action, and aspect https://github.com/wesnoth/wesnoth/commit/ca8cb3bd6a45d4fd2da9de79d484d9ad16f6951d
20160322 14:23:15< irker573> wesnoth: Celtic Minstrel wesnoth:master 7c9e24aa2968 / / (69 files in 23 dirs): Remove several deprecated recruitment-related aspects https://github.com/wesnoth/wesnoth/commit/7c9e24aa2968a1b59e05bd87998114ac2956678f
20160322 14:23:17< irker573> wesnoth: Celtic Minstrel wesnoth:master d0e3bc6a7086 / src/ai/ (6 files in 4 dirs): Change syntax of fallback stage https://github.com/wesnoth/wesnoth/commit/d0e3bc6a7086186a501718ecf8c659e35010ac30
20160322 14:23:19< irker573> wesnoth: Celtic Minstrel wesnoth:master e2cbe507815c / src/ai/composite/engine_lua.cpp: Allow external Lua CAs to use [params] instead of {exec,eval}_parms https://github.com/wesnoth/wesnoth/commit/e2cbe507815caae89ae19abfa3f60262975aa995
20160322 14:23:21< irker573> wesnoth: Celtic Minstrel wesnoth:master 1d7c1c74f64b / / (4 files in 4 dirs): Improve backwards compatibility for Lua AI https://github.com/wesnoth/wesnoth/commit/1d7c1c74f64b3830099e69fe2e714abf28794234
20160322 14:23:23< irker573> wesnoth: Celtic Minstrel wesnoth:master c49fc8a72b50 / src/ai/ (composite/engine_lua.cpp lua/core.cpp lua/core.hpp): Fix wesnoth.debug_ai() https://github.com/wesnoth/wesnoth/commit/c49fc8a72b506972b18b3affc117f749d08b6de6
20160322 14:23:25< irker573> wesnoth: Celtic Minstrel wesnoth:master 597ab40a2c46 / src/ai/lua/core.cpp: Fix  Lua AI component return values being lost https://github.com/wesnoth/wesnoth/commit/597ab40a2c463266d62a11a4baafecf4b054ba25
20160322 14:23:27< irker573> wesnoth: Celtic Minstrel wesnoth:master b4720562fa49 / src/ai/ (6 files in 2 dirs): Generalize/fix some aspect stuff https://github.com/wesnoth/wesnoth/commit/b4720562fa498d072d899c72cd1b23a32915a464
20160322 14:23:28 * celticminstrel confused.
20160322 14:23:29< irker573> wesnoth: Celtic Minstrel wesnoth:master c86b4ee5a937 / src/ (5 files in 3 dirs): Implement invalidate_on_tod_change for aspects https://github.com/wesnoth/wesnoth/commit/c86b4ee5a93732177bee9e37ab82f6d30d26bf7f
20160322 14:23:31< irker573> wesnoth: Celtic Minstrel wesnoth:master 155d7007c9fe / src/ai/lua/core.cpp: Produce error message when attempting to write to ai.aspects https://github.com/wesnoth/wesnoth/commit/155d7007c9fee106ec217283354513e7f02283cd
20160322 14:23:33< irker573> wesnoth: Celtic Minstrel wesnoth:master 5954e3f2f4b8 / src/ai/composite/property_handler.hpp: [modify_ai]action=change now automatically inserts an id= key if not present https://github.com/wesnoth/wesnoth/commit/5954e3f2f4b8d5813cf3ecc10bc52559b652550f
20160322 14:23:35< irker573> wesnoth: Celtic Minstrel wesnoth:master 3939d2a4f29c / src/ai/composite/aspect.hpp: Check for code= before value= in Lua aspects https://github.com/wesnoth/wesnoth/commit/3939d2a4f29c5cec92fb76ab8ab016bc1096f7ff
20160322 14:23:37< irker573> wesnoth: Celtic Minstrel wesnoth:master aa791cec196d / src/ai/lua/ (core.cpp core.hpp): Fix nested calls to AI action handlers clobbering the ai table https://github.com/wesnoth/wesnoth/commit/aa791cec196ddf2acbddd155f64c4b5aecdc9e9d
20160322 14:23:39< irker573> wesnoth: Celtic Minstrel wesnoth:master ef880c80c638 / src/ai/ (recruitment/recruitment.cpp recruitment/recruitment.hpp registry.cpp): Allow adding and removing recruitment jobs (and limits) with [modify_ai] https://github.com/wesnoth/wesnoth/commit/ef880c80c6380bb19d13c14bfedfd8ed85168791
20160322 14:23:41< irker573> wesnoth: Celtic Minstrel wesnoth:master cde7041b5f66 / src/ai/composite/ (aspect.hpp property_handler.hpp): Make all default components always have id "default_facet". https://github.com/wesnoth/wesnoth/commit/cde7041b5f660910c2b2d9bed5a36c66fab3ccf1
20160322 14:23:43< irker573> wesnoth: Celtic Minstrel wesnoth:master e97026b407f4 / src/ai/ (configuration.cpp registry.cpp): Double-register the recruitment_instructions aspect under the name recruitment. https://github.com/wesnoth/wesnoth/commit/e97026b407f4e72045646f804b1885bfa17007db
20160322 14:23:45< irker573> wesnoth: Celtic Minstrel wesnoth:master d00cc800768d / src/ai/ (12 files in 2 dirs): Safeguard against accidentally registering an AI component twice https://github.com/wesnoth/wesnoth/commit/d00cc800768d872d12e5bec5db2b194ad80e0d66
20160322 14:23:47< irker573> wesnoth: Celtic Minstrel wesnoth:master cb0fad078acd / / (4 files in 4 dirs): WML unit tests for simple aspects https://github.com/wesnoth/wesnoth/commit/cb0fad078acdf79591ca073b214a60d64cf068db
20160322 14:23:50< irker573> wesnoth: Celtic Minstrel wesnoth:master 895a326a70b0 / src/ai/configuration.cpp: Fix merging of default facets with composite values https://github.com/wesnoth/wesnoth/commit/895a326a70b0abee09fcb92f4977070348ac5d3a
20160322 14:23:51< irker573> wesnoth: Celtic Minstrel wesnoth:master b789391bfbfa / src/ai/lua/lua_object.hpp: Fix crash if a Lua avoid aspect returns an invalid value https://github.com/wesnoth/wesnoth/commit/b789391bfbfa0091e4f45a41e46ce8e7696543fc
20160322 14:23:53< irker573> wesnoth: Celtic Minstrel wesnoth:master 2ed5e7815f8f / data/ai/micro_ais/cas/ (ca_fast_attack_utils.lua ca_hang_out.lua): MicroAIs: Fix those that honour the avoid aspect improperly https://github.com/wesnoth/wesnoth/commit/2ed5e7815f8f45981c923a18c5644120b9c17007
20160322 14:24:04< mattsc> celticminstrel: because of the stupid Mac github App.  :(
20160322 14:24:52< celticminstrel> :/
20160322 14:25:00< mattsc> It told me that I am on master, so I did a sync to pull in the last commits.
20160322 14:26:05< mattsc> celticminstrel: http://imgur.com/Hsga1ha
20160322 14:26:29< mattsc> Clearly says master there (the second one, at the bottom)
20160322 14:26:47< celticminstrel> Yes, yes it does.
20160322 14:26:48< mattsc> Last time I was on your branch, it said PR615 there.
20160322 14:27:09< mattsc> So, I screwed up.  Very sorry for that.  But I don’t know why.
20160322 14:27:13< mattsc> Or how.
20160322 14:27:43< celticminstrel> Well, a few things were unfinished (mainly unit tests), but I don't think I had any fixups to apply, at least...
20160322 14:28:11< celticminstrel> It could be reset by someone with repo settings access, but it's probably not worth the effort.
20160322 14:28:15< mattsc> celticminstrel: yeah, everything I looked at looked good to me as well.  I was just going to do one more run through the Micro AIs.
20160322 14:28:24< celticminstrel> Are they working, then?
20160322 14:28:48< celticminstrel> You can checkout the pre-repo master with something like 'git checkout <commit>'
20160322 14:29:00< celticminstrel> Last commit was 8d948765f90f
20160322 14:29:19< celticminstrel> (If you wanted to test the Micro AIs prior to the AI branch still)
20160322 14:29:35< mattsc> The testing prior to the branch was done and all was working.
20160322 14:29:42< celticminstrel> Okay, that's good then.
20160322 14:30:18< mattsc> And the in-branch testing worked for some of them too, last time I tried, and the ones that caused errors were caused by the general problems in master, not in your brnach, IIRC.
20160322 14:30:37< mattsc> But I wanted to go over that again to be sure, and I certainly had not checked all of them in-brnach yet.
20160322 14:31:10< celticminstrel> One of the commit messages is wrong, but I did change [params] to [args].
20160322 14:31:24< mattsc> Okay, cool.
20160322 14:31:44< celticminstrel> I'll write up changelog and RELEASE_NOTES entries once I'm finished with the Lua-formula bridge.
20160322 14:31:57< celticminstrel> Hopefully later tofay.
20160322 14:32:02< mattsc> Sorry again for this.  But as I said, I have no idea what happened there.
20160322 14:32:06< mattsc> Great, thanks.
20160322 14:32:24< mattsc> And I’ll do the full testing of the MAIs as soon as possible.
20160322 14:32:29< celticminstrel> I can also revert the mutability of [default] later, if desired.
20160322 14:33:10< mattsc> celticminstrel: It’s fine by me to leave it like this.  I just wanted to know what your thoughts behind it were.
20160322 14:33:32< celticminstrel> I vaguely remember hearing a somewhat good reason to revert it, but I can't quite remember what it was.
20160322 14:33:47< celticminstrel> Or if it was good enough to go to the trouble of doing so.
20160322 14:34:04< celticminstrel> Maybe I'll search the logs later, though that's not exactly easy...
20160322 14:35:04< celticminstrel> I guess you're not doing the testing right now, or I'd ask you to check something.
20160322 14:35:50< mattsc> I’m updating Xcode at the moment ...
20160322 14:35:59< celticminstrel> ...oh wait, that would only work pre-AI-refactor though, even if it's still there it would become a no-op post-AI-refactor...
20160322 14:36:04< celticminstrel> I'll have to check the code then.
20160322 14:36:06< mattsc> Which always takes forever
20160322 14:36:40< mattsc> celticminstrel: 20160316 13:36:21 is where I ask the question about the [default] tag, if you want to read up in it again
20160322 14:37:10< celticminstrel> I'm not quite sure if it came up right away, might've been a day or two later, but thanks, that could still help.
20160322 14:39:00< irker573> wesnoth: Celtic Minstrel wesnoth:master cd2151ac1f4b / src/ai/formula/ai.cpp: Remove extraneous error message in FormulaAI https://github.com/wesnoth/wesnoth/commit/cd2151ac1f4b8a790dd2da0f62c43da27ba67dbd
20160322 14:39:48< celticminstrel> ^ That was what I was considering asking you to check. It should've been removed along with the recruitment stage since it was basically just a way to tell FormulaAI to follow the recruitment stage (and not actually the implementation of FormulaAI recruitment as I had originally thought).
20160322 14:40:47< vultraz> celticminstrel: that was your AI refactor?
20160322 14:41:07< celticminstrel> Yup.
20160322 14:41:14< vultraz> well that's one way to get it in :P
20160322 14:41:37-!- gfgtdf_ [~chatzilla@f054157159.adsl.alicedsl.de] has joined #wesnoth-dev
20160322 14:42:05< celticminstrel> Looks like an earlier copy of it, but I think the newer copy's only change was being rebased over a later master.
20160322 14:42:39< vultraz> [01:18:01]	gfgtdf	vultraz: the easycoding page suggested to add a seperator for different addons in the sceanriso list of the mp create dialog <- yeah not sure it's worth it, but I don't have a design yet
20160322 14:43:36-!- gfgtdf [~chatzilla@f054157159.adsl.alicedsl.de] has quit [Ping timeout: 276 seconds]
20160322 14:43:47-!- gfgtdf_ is now known as gfgtdf
20160322 14:44:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160322 14:44:35< vultraz> celticminstrel: you didn't add any new source files did you
20160322 14:44:56< celticminstrel> vultraz: Not for the AI refactor, no.
20160322 14:45:26< celticminstrel> vultraz: I've added one in the Lua-formula bridge though. :) (But I haven't even opened that PR yet.)
20160322 14:45:47< vultraz> getting compile errors
20160322 14:45:56< celticminstrel> I guess the next AI step (besides more unit tests) is removing ai::interface...
20160322 14:46:27< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\ai\testing\stage_rca.cpp|107|error: no match for 'operator<<' (operand types are 'std::basic_ostream<char>' and 'ai::candidate_action')|
20160322 14:46:42< celticminstrel> Oh good.
20160322 14:46:50< celticminstrel> That means perhaps those errors can finally be fixed somehow.
20160322 14:47:00< celticminstrel> They were occurring on Travis and I could not understand why.
20160322 14:47:21< mattsc> vultraz: again, sorry for that, but about the “getting it in:” I was very close to telling celticminstrel to go ahead anyway.
20160322 14:47:36< mattsc> Still, it’s very “bad style” for me to do so  :P
20160322 14:47:41< vultraz> mattsc: no problem 
20160322 14:47:47< vultraz> it's not the end of the world
20160322 14:47:51< celticminstrel> vultraz: There is a definition of an appropriate operator<< somewhere, probably in the same header as candidate_action.
20160322 14:48:04< mattsc> I’d still like to know what happened here, so that I can avoid doing that next time ...
20160322 14:48:27< mattsc> And why it didn’t happen the previous roughly 200 times I pressed that button while testing the branch
20160322 14:49:38< celticminstrel> vultraz: I'm going to re-merge the branch, it might fix one or two other compile errors, though not the candidate_action ones.
20160322 14:50:39< celticminstrel> vultraz: Or possibly not. Are you, in fact, getting wml_error issues in configuration.cpp?
20160322 14:50:58< vultraz> give me a sec
20160322 14:52:12< celticminstrel> Only doing this because I'm not sure which version mattsc merged, except that it wasn't the latest.
20160322 14:52:46< mattsc> See, that’s the other strange thing, because I thought I had the latest version.
20160322 14:52:56< mattsc> I did a pull on it yesterday after you told me about that.
20160322 14:53:23< celticminstrel> Well, it's possible that I'm wrong, then.
20160322 14:53:37< mattsc> But then, it told me that I was on master anyway, so who knows what I actually did …
20160322 14:53:43< celticminstrel> Considering that there's no merge commit, you might've pulled, rebased it over your master, and then pushed.
20160322 14:53:50< mattsc> In other words, I don’t believe anything that I am saying at the moment
20160322 14:54:07< celticminstrel> In which case it might actually be the latest after all.
20160322 14:54:23< celticminstrel> But the fact is that the commit hashes are different, so I'm just double-checking to be sure.
20160322 14:54:25-!- travis-ci [~travis-ci@ec2-54-226-206-80.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 14:54:26< travis-ci> wesnoth/wesnoth#9009 (master - 2ed5e78 : Celtic Minstrel): The build has errored.
20160322 14:54:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117718803
20160322 14:54:26-!- travis-ci [~travis-ci@ec2-54-226-206-80.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 14:54:36< mattsc> okay
20160322 14:54:52< celticminstrel> If vultraz doesn't get errors in configuration.cpp complaining about operator<< for lg::wml_error, then it was probably the latest.
20160322 14:55:02< vultraz> celticminstrel: I have part of a fix
20160322 14:55:09< celticminstrel> Because that fix is the last thing I remember doing.
20160322 14:56:15< vultraz> celticminstrel: ok I got everything built
20160322 14:56:17< celticminstrel> vultraz: Fix for what, the candidate_action error?
20160322 14:56:31< celticminstrel> Does it involve moving the operator<< into or out of a namespace?
20160322 14:56:32< vultraz> the << operator errors
20160322 14:56:43< celticminstrel> Did you get errors for lg::wml_error?
20160322 14:56:47< vultraz> celticminstrel: I had to include composite/rca.hpp and move the operator into the namespace
20160322 14:56:48< celticminstrel> The fix there is to add ()
20160322 14:56:50< vultraz> ai namespace
20160322 14:56:53< vultraz> no
20160322 14:56:58< vultraz> did not get errors with the log
20160322 14:56:59< celticminstrel> Okay, that makes sense regarding candidate_action.
20160322 14:57:07< vultraz> can I commit?
20160322 14:57:09< celticminstrel> Okay good, then it must've been the latest after all.
20160322 14:57:15< celticminstrel> Yeah, that seems fine.
20160322 14:58:10< irker573> wesnoth: Charles Dang wesnoth:master 34a0b8197b13 / src/ai/ (composite/rca.cpp composite/rca.hpp testing/stage_rca.cpp): Fixed compilation post-AI refactor https://github.com/wesnoth/wesnoth/commit/34a0b8197b134176e98b395004aaf4621fbb27d4
20160322 14:58:14< vultraz> there we go
20160322 14:58:38< vultraz> errors should be fixed
20160322 15:00:54< irker573> wesnoth: Charles Dang wesnoth:master bbc956998c97 / src/menu_events.cpp: Use a transient message for the 'cannot end turn yet' popup https://github.com/wesnoth/wesnoth/commit/bbc956998c97b6bae85cbd3de34a79edbffe6dd6
20160322 15:01:30< celticminstrel> When does that happen?
20160322 15:02:47< celticminstrel> Once I'm finished the Lua-formula bridge, I'll move on to removing ai::interface and the fallback stage.
20160322 15:03:02< vultraz> if you use [disallow_end_turn]
20160322 15:03:12< celticminstrel> But that disables the end turn button.
20160322 15:04:26< vultraz> No 
20160322 15:04:33< vultraz> doesn't
20160322 15:04:43< vultraz> should
20160322 15:04:43< celticminstrel> It's definitely greyed out in the tutorial.
20160322 15:04:44< vultraz> but doesn't
20160322 15:04:48< vultraz> it is?
20160322 15:06:09< vultraz> I'll look into it sometime
20160322 15:06:18< vultraz> celticminstrel: right now, I was considering a change to tooltips
20160322 15:06:27< celticminstrel> Maybe it happens if you press alt+space.
20160322 15:06:42< vultraz> celticminstrel: I think it might be better if they display at a location relative to the widget, not the mouse
20160322 15:07:04< celticminstrel> Maybe, but is that possible?
20160322 15:07:10< vultraz> I don't know
20160322 15:07:16< celticminstrel> Does it know anything about the widget it's attached to?
20160322 15:07:30< vultraz> don't know
20160322 15:07:39< celticminstrel> If not, this change would require changes to the GUI2 source, to add formula variables or whatever.
20160322 15:08:53< celticminstrel> Okay, I rebased AI onto master and now they're even.
20160322 15:16:22< celticminstrel> I think the handling of ai_algorithm may be a bit problematic in MP scenarios.
20160322 15:17:06< celticminstrel> Especially if you're using a custom stage (which just means any explicit [stage] tag).
20160322 15:17:36< celticminstrel> Thoguh actually this might affect non-MP scenarios to some extent too.
20160322 15:17:39< celticminstrel> ^Though
20160322 15:17:55-!- travis-ci [~travis-ci@ec2-54-158-81-19.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 15:17:56< travis-ci> wesnoth/wesnoth#9010 (master - cd2151a : Celtic Minstrel): The build has errored.
20160322 15:17:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117723145
20160322 15:17:56-!- travis-ci [~travis-ci@ec2-54-158-81-19.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 15:18:06< celticminstrel> mattsc: If I'm not mistaken, the old behaviour was that the RCA stage was inserted only if no stage was explicitly defined, right?
20160322 15:18:38< mattsc> I believe that is correct
20160322 15:19:11< celticminstrel> Okay, currently that's not the case, but I think I was planning to retain that behaviour in the event that ai_algorithm is not set.
20160322 15:20:05< mattsc> So it is not inserted unless specified, or it is always inserted?
20160322 15:20:28< celticminstrel> It is always inserted if ai_algorithm is not set.
20160322 15:20:50< celticminstrel> Then that still leaves the problem that MP scenarios inject the ai_algorithm key based on the AI selected from the dropdown menu.
20160322 15:20:55-!- Kwandulin [~Miranda@p200300760F191C4981C5ED18A18CD9C1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160322 15:21:26< mattsc> okay
20160322 15:22:00< celticminstrel> (My unit tests got around the issue by using ai_algorithm=idle_ai)
20160322 15:22:29< celticminstrel> (The general issue, not the MP-specific aspect.)
20160322 15:23:28< celticminstrel> Maybe I should add something like "allow_ai_override" to the [side] tag.
20160322 15:23:49< celticminstrel> If yes, it injects the ai_algorithm key at the top; if no, it injects it at the bottom.
20160322 15:24:11< celticminstrel> (Or, potentially, not at all.)
20160322 15:25:22< mattsc> So, at the moment, if I only want to use custom CAs, how do I do that?
20160322 15:25:37< mattsc> In the old version, I just defined a main_loop stage with only those CAs
20160322 15:25:49< celticminstrel> Just add ai_algorithm=idle_ai
20160322 15:25:55< celticminstrel> Consider this a temporary workaround though.
20160322 15:25:56< mattsc> It sounds like this would now add in the RCA stage also
20160322 15:26:01< mattsc> ok
20160322 15:27:15< celticminstrel> (That goes in the [ai] tag, of course.)
20160322 15:27:36< mattsc> right
20160322 15:31:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160322 15:34:09< mattsc> Xcode’s finally done updating.  I now get this error:
20160322 15:34:35< mattsc> src/gui/dialogs/lua_interpreter.cpp:202:5: error: use of undeclared identifier 'append_history'
20160322 15:34:51< celticminstrel> You need a newer version of readline.
20160322 15:35:08< mattsc> Ah.  Where’s that?
20160322 15:35:11< celticminstrel> I'm actually kind of surprised that that happens on newer OSX though.
20160322 15:35:19< celticminstrel> You can probably get it from Homebrew.
20160322 15:35:26< mattsc> Hmm.
20160322 15:35:31< celticminstrel> Just place it in libs/ and its header folder in Headers/
20160322 15:35:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160322 15:35:47< mattsc> okay
20160322 15:35:54< mattsc> will do (later)
20160322 15:36:06< celticminstrel> I guess we should get ancestral to add it to the Mac Compile Stuff, if even OSX 10.9/10/11 don't have a new enough version on the system.
20160322 15:36:21< mattsc> yeah
20160322 15:36:30< mattsc> This is new since when?
20160322 15:36:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160322 15:36:51< mattsc> because I compiled yesterday and did not have the problem
20160322 15:36:55< celticminstrel> I just added that to the project yesterday, but I don't know how long it's been an optional dependency of Wesnoth.
20160322 15:37:03< mattsc> okay
20160322 15:37:16< mattsc> so it likely has nothing to do with me just having updated Xcode then
20160322 15:37:19< celticminstrel> Yeah.
20160322 15:37:47< mattsc> celticminstrel: anything else you need or want from me right now
20160322 15:37:48< celticminstrel> Actually, what's the oldest SDK you have installed?
20160322 15:37:59< mattsc> I’ll have to take off for work shortly
20160322 15:38:04< mattsc> oldest …
20160322 15:38:10< mattsc> let me check
20160322 15:38:19< celticminstrel> If you're actually using the 10.6 or 10.7 SDK or whatever the project requests, that might be why readline is too old.
20160322 15:38:37< gfgtdf> vultraz: did you already port the recall dialog to gui2 ?
20160322 15:38:47< celticminstrel> Still, since we're supporting 10.7 at least, it's still a problem.
20160322 15:39:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160322 15:39:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160322 15:39:46< celticminstrel> I think I have all the SDKs from 10.4 up to (for some reason) 10.9.
20160322 15:40:00< mattsc> It only has the 10.11 SDKs 
20160322 15:40:12< gfgtdf> celticminstrel: hmm you can build wesnoth without readline
20160322 15:40:14< celticminstrel> Huh, okay.
20160322 15:40:31< celticminstrel> gfgtdf: I know, but why would you want to drop a useful feature like that?
20160322 15:40:34< mattsc> I do have the older SDKs on my computer, but Xcode does not use those unless forced
20160322 15:40:52< gfgtdf> celticminstrel: actually our plan is to remove the optional readline dependeny and use a own c++ impleentation.
20160322 15:41:33< celticminstrel> gfgtdf: That's nice, but it hasn't been done yet, so we still have to build with readline to get that functionality.
20160322 15:41:52< celticminstrel> For the record, mattsc, what this enables is history in the Lua console.
20160322 15:42:04< celticminstrel> So you can press the up key to see previous commands.
20160322 15:42:09< mattsc> … which is a really nice feature!
20160322 15:42:12< celticminstrel> Unfortunately it doesn't work in chat though. :/
20160322 15:43:03< celticminstrel> You could probably do all your Lua stuff in the console though - open it, type a command, close it, view the result. Slightly less convenient than using ;lua, but for history, maybe worth it.
20160322 15:44:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160322 15:44:52< mattsc> yeah
20160322 15:48:58-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 15:48:59< travis-ci> wesnoth/wesnoth#9011 (master - 34a0b81 : Charles Dang): The build has errored.
20160322 15:48:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117728542
20160322 15:48:59-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 15:53:08< vultraz> gfgtdf: not yet but I plan on working on it soon
20160322 16:00:31< vultraz> celticminstrel: actually, small change you could work on if you've got nothing else to do: I'd like to convert dialogs to use generally relative sizes
20160322 16:01:00< vultraz> so like, max_height = "(screen_height - 200)" or something
20160322 16:02:54< celticminstrel> That sound potentially broken.
20160322 16:03:04< celticminstrel> What if screen_height==480?
20160322 16:05:53< vultraz> max_height = "(if(screen_height < 600, 600, if(screen_height + 200 <800, 600, screen_height - 200) ))"
20160322 16:06:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 16:06:20< celticminstrel> So you want it to be taller than the screen?
20160322 16:06:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 16:06:24< vultraz> keep in mind this wouldn't be for all dialogs
20160322 16:06:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 16:06:31< celticminstrel> Which ones?
20160322 16:06:36< vultraz> just for ones like Recruit, Unit Create, Game Load
20160322 16:06:38< vultraz> etc
20160322 16:06:47< vultraz> campaign list, potentially
20160322 16:06:57-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160322 16:06:59< celticminstrel> Hmm, okay. Seems fine at least for the unit ones.
20160322 16:07:05< vultraz> if the screen is below a certain height, might as well let it fill the height
20160322 16:07:21< celticminstrel> Oh, if it's max_height I guess it's fine for those others too.
20160322 16:07:59< vultraz> that's just an example formula
20160322 16:08:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160322 16:08:07< celticminstrel> I'm on a beanch right now, anyway.
20160322 16:08:22< celticminstrel> ^branch
20160322 16:14:44-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 16:14:45< travis-ci> wesnoth/wesnoth#9012 (master - bbc9569 : Charles Dang): The build has errored.
20160322 16:14:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117729410
20160322 16:14:45-!- travis-ci [~travis-ci@ec2-54-198-16-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 16:31:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160322 16:31:40-!- atarocch [~atarocch@47.53.233.165] has joined #wesnoth-dev
20160322 16:55:22-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160322 16:58:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160322 16:58:55-!- wedge010 is now known as wedge009
20160322 17:03:07-!- gfgtdf [~chatzilla@f054157159.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]]
20160322 17:04:00-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 276 seconds]
20160322 17:11:55< shadowm> Elvish_Hunter: Done.
20160322 17:18:04< celticminstrel> Ugh, I forgot what I wanted to ask him...
20160322 17:18:15< celticminstrel> Maybe I'll remember by the time he shows up.
20160322 17:22:47-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection]
20160322 17:26:34 * celticminstrel blinkes.
20160322 17:26:37< celticminstrel> ^blinks
20160322 17:27:02< celticminstrel> Everything is suddenly bold.
20160322 17:27:12< celticminstrel> Is this what it's supposed to look like with DejaVu Sans?
20160322 17:27:50< shadowm> https://www.wesnoth.org/images/sshots/wesnoth-1.12.0-3.jpg <- What Wesnoth (1.12) is supposed to look like with DejaVu Sans.
20160322 17:28:37< celticminstrel> Okay, so this isn't right then.
20160322 17:29:04< celticminstrel> I'm assuming it's because I edited fonts.cfg though.
20160322 17:32:45< shadowm> And what did you do that for?
20160322 17:33:19< celticminstrel> Supposedly, removing everything except DVS makes it work on OSX, so I wanted to try it.
20160322 17:34:36< shadowm> Oh, okay, not the fonts.cfg I'm thinking of then, but rather the one that is part of the fontconfig library.
20160322 17:34:48< celticminstrel> The one in data/hardwired.
20160322 17:34:58< celticminstrel> Should I have changed the other one instead?
20160322 17:35:06 * celticminstrel is confused now.
20160322 17:37:51< shadowm> Never mind, I'm thinking of files named fonts.conf. :p
20160322 17:37:57< shadowm> Ignore all that rambling.
20160322 17:39:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 17:44:21-!- atarocch [~atarocch@47.53.233.165] has quit [Ping timeout: 244 seconds]
20160322 17:46:06-!- Kwandulin [~Miranda@p200300760F191C4981C5ED18A18CD9C1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160322 17:50:22< celticminstrel> What is side_engine::swap_sides_on_drop_target for?
20160322 17:51:27-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 276 seconds]
20160322 17:52:36< celticminstrel> It's moving ai_algorithm around in a way that seems superfluous.
20160322 17:58:27< vultraz> celticminstrel: I'm guessing it deals with the MP Players Join screen
20160322 17:58:37< celticminstrel> Oh.
20160322 17:58:38< vultraz> GUI1 has a 'drag and drop' widget that allows you to drag it around
20160322 17:58:45< celticminstrel> If that's the case, then it's not superfluous.
20160322 17:59:00< vultraz> You can reorder the sides by dragging and dropping them into a specific order
20160322 17:59:09< vultraz> Though I dunno why that should affect the AI engine
20160322 17:59:23< vultraz> the AI shouldn't be invoked until the game begins
20160322 17:59:39< celticminstrel> This isn't the AI engine, it's game_initialization/connect_engine.cpp
20160322 18:00:24-!- gfgtdf [~chatzilla@f054157159.adsl.alicedsl.de] has joined #wesnoth-dev
20160322 18:00:29< vultraz> ohh
20160322 18:00:31< vultraz> misread
20160322 18:00:52< gfgtdf> vultraz: how exactly can i see the gragdrop widget in gui1 ?
20160322 18:00:59< gfgtdf> vultraz: is this also in 1.12 ?
20160322 18:01:04< gfgtdf> dragdrop*
20160322 18:01:08< vultraz> gfgtdf: yes it's been there for years
20160322 18:01:19< vultraz> gfgtdf: create an mp game and go to the screen where you wait for players
20160322 18:01:25< vultraz> you can drag the controller boxes around
20160322 18:01:28< celticminstrel> You can do it in a local MP game too.
20160322 18:01:28-!- irker573 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160322 18:01:34< celticminstrel> No need to connect to a server.
20160322 18:02:27< gfgtdf> vultraz: indeed :O
20160322 18:02:33< gfgtdf> vultraz: i never knew this
20160322 18:02:40< vultraz> yeah it's not very obvious
20160322 18:03:14< vultraz> I dunno if it's something we'd want in GUI2
20160322 18:04:14< celticminstrel> Why is the lobby hardcoded to have four entries in the player/rooms list?
20160322 18:04:27< vultraz> What lobby?
20160322 18:04:33< vultraz> If you mean the GUI1 lobby, no idea
20160322 18:04:36< celticminstrel> Can't it dynamically add entries at runtime to the treeview?
20160322 18:04:37< celticminstrel> No, GUI2.
20160322 18:04:47< gfgtdf> vultraz: well, i dont think this shoudl stop us to make th lobby gui2. IF we want we cna add it after we changed it to gui2
20160322 18:05:04< gfgtdf> the drag combobox i mean
20160322 18:05:06< vultraz> gfgtdf: true
20160322 18:05:32< celticminstrel> I think there should be a special control for dragging the entry, rather than dragging the combobox.
20160322 18:05:34< vultraz> just that converting the MP Create stuff will be extremely daunting :(
20160322 18:06:21< vultraz> I don't want to just convert each screen directly to gui2
20160322 18:06:25< vultraz> we need to do a design overhaul
20160322 18:06:39< celticminstrel> Confused. Doesn't the GUI2 lobby use a treeview?
20160322 18:06:40< gfgtdf> vultraz: hmmso what woudl you change ?
20160322 18:06:47< celticminstrel> Oh, there it is.
20160322 18:06:55< gfgtdf> celticminstrel: it uses one for the player list afaik
20160322 18:07:10< celticminstrel> I don't understand this.
20160322 18:07:13< vultraz> gfgtdf: I'm not sure, I still haven't thought it through
20160322 18:07:56< vultraz> but like in the GUI1 lobby, a few elements should remain consistent throughout all screens
20160322 18:08:01< vultraz> ie, always have the chat area
20160322 18:08:16< vultraz> gfgtdf: speaking of which can you fix tlistbox::remove_row not working with horizontal listboxes?
20160322 18:08:20-!- melinath_ [~textual@71.37.44.32] has joined #wesnoth-dev
20160322 18:08:29< celticminstrel> "The tree view can contain multiple node sections. This part needs more documentation."
20160322 18:08:31< celticminstrel> Great.
20160322 18:09:14< gfgtdf> celticminstrel: hmm no afaik treeview can only have one selected node
20160322 18:09:15< vultraz> celticminstrel: as far as I know one node definition is like a 'type'
20160322 18:09:35< vultraz> gfgtdf: you can have more than one node open.. I think
20160322 18:09:46< vultraz> I dunno about different nodes of different types
20160322 18:09:50< gfgtdf> vultraz: yes but you can only have one node selected
20160322 18:09:59< vultraz> hm ok
20160322 18:10:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 18:11:06< celticminstrel> Wait a second...
20160322 18:13:30< celticminstrel> BTW vultraz, the lobby is a little bit too wide for 800x600.
20160322 18:13:48< vultraz> i supose it got that way after my changes
20160322 18:14:54< celticminstrel> We can probably create a totally separate definition for 800x480, at least...
20160322 18:15:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160322 18:16:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 18:18:22-!- melinath_ is now known as melinath
20160322 18:19:41-!- louis94 [~~louis94@91.178.240.41] has joined #wesnoth-dev
20160322 18:19:43< vultraz> celticminstrel: we're silently dropping that
20160322 18:19:50< vultraz> 800x600 new minimum 
20160322 18:20:00< celticminstrel> Not sure if that's really okay.
20160322 18:20:19< celticminstrel> But I personally don't care about 800x480.
20160322 18:20:22< vultraz> we'll need a separate smartphone theme anyway
20160322 18:21:58< celticminstrel> I'm trying to figure out what these listboxes are for, just about the treeview.
20160322 18:22:02< celticminstrel> (In the lobby.)
20160322 18:22:33< celticminstrel> At first glance it seems as though the player lists are in fact contained by those listboxes, but the debugger shows this seems to not be the case...
20160322 18:22:48< vultraz> look at the wml
20160322 18:23:00< celticminstrel> That's what I'm talking about.
20160322 18:23:22< celticminstrel> The row above the treeview contains a scrollbar panel with four listboxes.
20160322 18:24:18< vultraz> ehhh???
20160322 18:24:23< vultraz> I'll look after this game
20160322 18:34:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160322 18:38:43-!- louis94 [~~louis94@91.178.240.41] has quit [Quit: Konversation terminated!]
20160322 18:38:45< celticminstrel> So basically it seems that each node in the treeview is a listbox... or something...?
20160322 18:43:28< gfgtdf> celticminstrel: uhm no
20160322 18:44:18< celticminstrel> gfgtdf: So, do you understand how this works, then?
20160322 18:44:29< gfgtdf> celticminstrel: maybe its poissible to put listboxes in tewwview nodes. but i don't really see why one woudl want to do thtqa
20160322 18:44:39< gfgtdf> celticminstrel: treeviews in gerneral ?
20160322 18:44:48< celticminstrel> Treeviews in general is a good start.
20160322 18:45:03< gfgtdf> celticminstrel: hmm ok what do you want to know about the treeviews?
20160322 18:46:20-!- Kwandulin [~Miranda@p200300760F191C499917D37727E80751.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160322 18:47:52< gfgtdf> vultraz: did you work on the gui2 mp lobby? It seems to look better that last time i looked at it
20160322 18:48:33< celticminstrel> I just want to make a fairly simple tree structure that's generated at runtime. :/
20160322 18:49:30< gfgtdf> celticminstrel: hmm yes thats what treviews usually do
20160322 18:49:35< vultraz> gfgtdf: yes
20160322 18:49:39< vultraz> I did recently
20160322 18:49:46< vultraz> still some stuff to do
20160322 18:50:25< vultraz> once the remove_row issue is fixed I'll probably make it default
20160322 18:50:27< gfgtdf> s/that/than*
20160322 18:50:54< gfgtdf> vultraz: where are horizonal listboxes used in the mp lobby ?
20160322 18:51:32< vultraz> gfgtdf: the room tab bar
20160322 18:51:44< vultraz> gfgtdf: if you open a room and then click Close you get an assert
20160322 18:52:00< celticminstrel> Okay, but I don't know how to make them do it.
20160322 18:52:03< gfgtdf> vultraz: how do i open a room ?
20160322 18:52:06< vultraz> so "/join foo"
20160322 18:54:37< gfgtdf> vultraz: is there a way in the listbox to know whether it is hozizontal? If so we could just rmove the new code for those listboxes
20160322 18:55:01< vultraz> I don't think so
20160322 18:55:01< gfgtdf> disable*
20160322 18:55:31< vultraz> I don't even think it's two different classes
20160322 18:55:34< vultraz> just different wml
20160322 18:56:02< celticminstrel> Different builder.
20160322 18:56:07< celticminstrel> listbox.cpp, line 1008.
20160322 18:56:12< celticminstrel> Not sure if that helps.
20160322 18:58:35< gfgtdf> celticminstrel: hmm yes seem to be a parmeter to tgernerator_. Hmm t shoudl be possible to add a gettor fpor that in tgenerator_
20160322 18:58:49< celticminstrel> Huh?
20160322 18:59:41< celticminstrel> It's a parameter passed to the tlistbox constructor.
20160322 18:59:48< celticminstrel> A constant defined in tgenerator_
20160322 19:00:00< gfgtdf> celticminstrel: and and teh listbox passes it then to tgernerators constructor
20160322 19:00:11< celticminstrel> Well, to build(), but yeah.
20160322 19:00:55< vultraz> (keep in mind there is both tgenerator and tgenerator)
20160322 19:00:57< vultraz> er
20160322 19:00:59< vultraz> tgenerator_
20160322 19:01:10< celticminstrel> vultraz: This is tgenerator_
20160322 19:01:41< vultraz> either way
20160322 19:02:08< celticminstrel> What's with the highly obfuscated definition of tgenerator_::build? :|
20160322 19:02:31< vultraz> I think some of those aren't implemted
20160322 19:02:50< celticminstrel> I have no idea what "those" refers to here.
20160322 19:03:17< vultraz> generator builders
20160322 19:04:38< gfgtdf> vultraz: do you know why the tooltips in the choose mp server dialogs are different than the othe tooltips ?
20160322 19:05:23< vultraz> gfgtdf: which dialog?
20160322 19:05:44< gfgtdf> vultraz: th dialog with the 4 entries that appes when you click 'multiplayer' on tiltescreen
20160322 19:05:57< vultraz> yeah that's the new style gui2 tooltips
20160322 19:06:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 19:07:20< celticminstrel> I think you can use dynamic_cast to determine whether the list is horizontal.
20160322 19:08:19< celticminstrel> if(dynamic_cast<gui2::policy::placement::thorizontal_list*>(generator_))
20160322 19:08:32< celticminstrel> (Within the tlistbox class.)
20160322 19:08:41< celticminstrel> (Oh, probably &generator_)
20160322 19:09:37< celticminstrel> (Ah, no, the & is not required.)
20160322 19:09:59< gfgtdf> celticminstrel: yes but i dont this the tlistbox class has access to thorizontal_list and i dont want to include generator_private there.
20160322 19:11:19< celticminstrel> gfgtdf: You could probablt get away with just a declaration of thorizontal_list.
20160322 19:11:23< celticminstrel> ^probably
20160322 19:11:35< celticminstrel> I could be wrong though, since this is a dynamic_cast.
20160322 19:11:55< celticminstrel> Anyway, I don't see the problem with including generator_private.hpp in a random source file...
20160322 19:12:56< gfgtdf> celticminstrel: hmm well the name sugggests it shoudl be private
20160322 19:13:34< celticminstrel> True. I don't care about that myself, but whatever. >_>
20160322 19:16:16< gfgtdf> vultraz: hm i tried to fix it but it seems liek it was already broken before my commit https://github.com/wesnoth/wesnoth/commit/8b32fc20abd935e1354627b85ec6808ee38cad2d
20160322 19:22:39-!- atarocch [~atarocch@37.118.128.66] has joined #wesnoth-dev
20160322 19:24:08< gfgtdf> vultraz: hmm fixing this is harder then i thouight: eevery try to fix it casues assertion failures at othre places :/
20160322 19:24:51< vultraz> :(
20160322 19:31:52< zookeeper> gfgtdf, are there any other important details to note about [on_undo] and [on_redo] aside from variable substitution not being delayed?
20160322 19:32:12-!- irker734 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160322 19:32:12< irker734> wesnoth: gfgtdf wesnoth:master f759649349e1 / src/gui/widgets/ (listbox.cpp listbox.hpp): fix assertion failues on remove_row() for horizontal listboxes https://github.com/wesnoth/wesnoth/commit/f759649349e18ffadc4acf58e682710d627e3097
20160322 19:32:12< irker734> wesnoth: gfgtdf wesnoth:master 0ac0981ffee1 / src/ (6 files): remove unused cpp files. https://github.com/wesnoth/wesnoth/commit/0ac0981ffee14bcc16a390e5a96cea0c277c079d
20160322 19:32:15< gfgtdf> zookeeper: hmm not that i currently know of
20160322 19:32:19< gfgtdf> vultraz: ^
20160322 19:32:22< zookeeper> all right
20160322 19:33:35< zookeeper> i'll add them to the wiki then
20160322 19:33:38< gfgtdf> zookeeper: i'm still wondering whether we should remove [on_redo] and the redo specific code and just run the 'normal' code that is also use when doing the action the first time when redoing things.
20160322 19:34:16< zookeeper> gfgtdf, i'm not completely sure, but i'd lean towards keeping it
20160322 19:34:39< gfgtdf> zookeeper: so that when reoding things the actions just run thought the same code like when they were done for the first time
20160322 19:34:54< zookeeper> it makes sense to do that in some cases, but not necessarily in others
20160322 19:35:07< gfgtdf> zookeeper: afaik the onyl reason for the current code might a performance gain, not sure if its noticable
20160322 19:35:31< irker734> wesnoth: Celtic Minstrel wesnoth:master ee80e66f95be / changelog src/game_events/action_wml.cpp: Support delayed_variable_substitution= in [on_undo], [on_redo] https://github.com/wesnoth/wesnoth/commit/ee80e66f95be338ac1d8e1fb77197aadc23ef5fd
20160322 19:35:37< zookeeper> there's also the reason that it might be annoying in some situations if you undo/redo a lot and keep hitting the same stupid signpost message again and again every time
20160322 19:35:47< zookeeper> or something similar
20160322 19:36:00< zookeeper> celticminstrel, i can't see how you could have possibly had time to test that
20160322 19:36:12< celticminstrel> <_<
20160322 19:36:15< gfgtdf> zookeeper: nom fired event with first_time only=yes wtill wouldnt fire again
20160322 19:36:18< zookeeper> seeing you came up with the idea like 10 minutes ago. or did you? :x
20160322 19:36:31< zookeeper> gfgtdf, right, true
20160322 19:37:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 19:37:46< zookeeper> gfgtdf, i don't know, it's a possibility for sure, but it feels like it could have unexpected consequences
20160322 19:37:54-!- Nobun [~nobun@host186-52-dynamic.16-87-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160322 19:38:11< zookeeper> i'll try to give it some thought
20160322 19:38:39< gfgtdf> zookeeper: the main advantage is that wmlauthors wouldnt have to worry about on_redo anymore.
20160322 19:39:10< zookeeper> yeah
20160322 19:41:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160322 19:44:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160322 19:46:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 19:47:36< zookeeper> gfgtdf, so is adding delayed_variable_substitution as easy as in celticminstrel's commit?
20160322 19:48:37< vultraz> yes
20160322 19:48:39< celticminstrel> zookeeper: I just tested and confirmed it works. Code used: http://pastebin.com/eVG2Ntxf
20160322 19:48:40< gfgtdf> zoohmm most likeley yes, but note that you won't have any information about the current unit or event avaible in the undo code.
20160322 19:48:53< gfgtdf> if you use delayed_variable_substitution
20160322 19:49:32< irker734> wesnoth: Celtic Minstrel wesnoth:master 620f7833b732 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/620f7833b732fb4f5b96038e563ae5b702ec6b49
20160322 19:49:51< zookeeper> right, okay then
20160322 19:50:35< celticminstrel> Sorry, I thought it was so simple that it didn't really need testing. >_>
20160322 19:51:13< celticminstrel> Though I guess could also be taken to mean that testing is easy and should be done anyway.
20160322 19:51:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160322 19:51:33< vultraz> gfgtdf: ty for fixing the listbox thing :)
20160322 19:52:11< irker734> wesnoth: Charles Dang wesnoth:master e86cadfa72c7 / projectfiles/CodeBlocks/wesnoth.cbp: Update CB project https://github.com/wesnoth/wesnoth/commit/e86cadfa72c79ff0b439da346acf067b9b452f89
20160322 19:52:56< gfgtdf> hmm i wonder whether there are usecases for deleaed_variable_subsutution=yes becasue, like i said before, you won't have any information about the current event then.
20160322 19:53:36< celticminstrel> I think in simple events it probably wouldn't be needed.
20160322 19:55:40< celticminstrel> Suppose you want a message to appear when moving to a particular location, but the message is randomly chosen.
20160322 19:56:28< gfgtdf> celticminstrel: hmm ii don't see why i wouldnt want to use [on_undo] in that situation
20160322 19:56:32< celticminstrel> That said... if there's a way to get the event context information into the undo scope, I think that could be useful as well.
20160322 19:57:19< celticminstrel> gfgtdf: True, in that situation just [allow_undo] alone might be sufficient, but I think I can imagine a slightly more complex case of the same thing where it wouldn't be... not quite sure though...
20160322 19:57:59-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160322 19:58:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20160322 19:59:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 20:06:36< vultraz> I wonder if I should make a chat box widget 
20160322 20:06:51< celticminstrel> What would it do?
20160322 20:08:17< vultraz> basically just be a wrapper widget for the chat area in order to allow me to define a border
20160322 20:09:12< celticminstrel> Is it my imagination, or did WML_HANDLER_FUNCTION lose an argument at some point?
20160322 20:10:13< vultraz> yes
20160322 20:10:19< vultraz> gfgtdf: cleaned it out
20160322 20:10:25< vultraz> since it was unused
20160322 20:10:59< celticminstrel> Why was it unused? Were all the actions that used it ported to Lua?
20160322 20:11:04-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 20:11:05< travis-ci> wesnoth/wesnoth#9013 (master - 0ac0981 : gfgtdf): The build has errored.
20160322 20:11:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117797263
20160322 20:11:05-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 20:12:08< vultraz> no idea
20160322 20:13:58< celticminstrel> Or, was it actually never used?
20160322 20:14:20< celticminstrel> The only Lua WML tag that uses it is teleport...
20160322 20:14:30< gfgtdf> celticminstrel: the tags were used to lua
20160322 20:14:52< celticminstrel> Well, objectives or object might as well, they're in a different file.
20160322 20:15:05< celticminstrel> gfgtdf: Did you mean to say "moved"?
20160322 20:15:11< gfgtdf> celticminstrel: and teleport is not the one one that uses it
20160322 20:15:19< gfgtdf> celticminstrel: ye si mtent moved*
20160322 20:15:29< celticminstrel> gfgtdf: It does use it, I checked wml-tags.lua.
20160322 20:15:32< gfgtdf> celticminstrel: the [object] and [message] tags also use it afaik
20160322 20:15:44< gfgtdf> s/one one/only one
20160322 20:15:47< celticminstrel> Oh, right.
20160322 20:15:56< celticminstrel> message uses it for speaker=unit and such.
20160322 20:16:23< celticminstrel> Did you move teleport specifically so you could remove it?
20160322 20:17:23< gfgtdf> celticminstrel: hmm no i also removed it becasue i thought it would be easier if it had a better lua interface too.
20160322 20:17:36< celticminstrel> Huh?
20160322 20:17:44< gfgtdf> celticminstrel: note that teh lua function takesa unit whiel the wml tags takes a filter
20160322 20:18:17< celticminstrel> Oh, the teleport function.
20160322 20:18:34< celticminstrel> You said "removed' instead of "moved" so I thought you were talking about the event context.
20160322 20:19:23< gfgtdf> celticminstrel: yes i meant moved*
20160322 20:26:54< celticminstrel> I think it would be easy to pass on the event context to the undo handler, if you hadn't removed it.
20160322 20:36:50< vultraz> celticminstrel: do you have a minute?
20160322 20:36:58< celticminstrel> Yes.
20160322 20:37:29< vultraz> can you join the new lobby and say something in the lobby chat
20160322 20:40:21< vultraz> I just want to test the 'new message' indicator 
20160322 20:44:17< vultraz> celticminstrel: ok say something else
20160322 20:54:21< irker734> wesnoth: Charles Dang wesnoth:master 386762a6f281 / data/gui/widget/button_25x25.cfg: GUI2: added code for minimal buttons (buttons sans background) https://github.com/wesnoth/wesnoth/commit/386762a6f2810018488017026ca06a187541ed7a
20160322 20:54:24< irker734> wesnoth: Charles Dang wesnoth:master d79cdd50bcfa / / (4 files in 2 dirs): GUI2: added minimal Close button definition https://github.com/wesnoth/wesnoth/commit/d79cdd50bcfa88b437d2f40ed59deaf7be5b0931
20160322 20:54:27< irker734> wesnoth: Charles Dang wesnoth:master 6158ca73b91a / data/gui/window/lobby_main.cfg src/gui/dialogs/lobby/lobby.cpp: tlobby_main: implemented tab close buttons https://github.com/wesnoth/wesnoth/commit/6158ca73b91ab308c9c58064edf8935f5fb2606a
20160322 20:54:30 * vultraz dusts off hands
20160322 20:54:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 20:54:53< vultraz> The Close button has been exorcised!
20160322 20:57:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 20:59:31-!- aidanhs [~aidanhs@81.4.110.234] has quit [Ping timeout: 252 seconds]
20160322 20:59:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 21:00:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 21:01:58< vultraz> zookeeper: if you have free time some point in the future, is it possible you could produce an SVG of the wooden background graphic?
20160322 21:02:22-!- aidanhs [~aidanhs@81.4.110.234] has joined #wesnoth-dev
20160322 21:02:29< zookeeper> what... how... what?
20160322 21:02:46< zookeeper> how does anyone "produce an SVG" of a bitmap?
20160322 21:03:10< vultraz> I don't know how exactly you got that image, so that's why I'm asking
20160322 21:03:19< vultraz> is there any way we can get that image in SVG form
20160322 21:03:26< zookeeper> there isn't
20160322 21:03:26< celticminstrel> I doubt it.
20160322 21:03:39< celticminstrel> SVG is for geometric shapes, not arbitrary textures.
20160322 21:03:50< celticminstrel> (And paths, but that's still not arbitrary textures.)
20160322 21:04:31< vultraz> (or some other scalable format)
20160322 21:05:02< vultraz> I'm sure there exists a format for scalable textures
20160322 21:05:27< zookeeper> there's a format to everything
20160322 21:05:38< celticminstrel> I don't know of any.
20160322 21:05:49< zookeeper> that doesn't mean there's a magical way to convert one kind of thing to a completely different kind of thing
20160322 21:05:54< celticminstrel> I have my doubts that it's possible.
20160322 21:12:27< zookeeper> aside from someone creating a bigger/better one (whether vector or not), the only chance is to do manual image processing magic to produce a higher-res version which looks better than a simply upscaled one
20160322 21:14:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160322 21:16:03< zookeeper> my source material wasn't that great so i doubt i could redo it a lot better
20160322 21:18:16-!- louis94 [~~louis94@91.178.240.41] has joined #wesnoth-dev
20160322 21:19:14< zookeeper> namely, it was just one image: https://dl.dropboxusercontent.com/u/63964618/wesnoth/maps/textures/wood_source.jpg (scaled down to about 35% size here)
20160322 21:26:53< vultraz> yeah, that's not a great source
20160322 21:27:11-!- louis94 [~~louis94@91.178.240.41] has quit [Quit: Konversation terminated!]
20160322 21:30:16-!- travis-ci [~travis-ci@ec2-54-226-206-80.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 21:30:17< travis-ci> wesnoth/wesnoth#9015 (master - 620f783 : Celtic Minstrel): The build has errored.
20160322 21:30:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117800810
20160322 21:30:17-!- travis-ci [~travis-ci@ec2-54-226-206-80.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 21:30:59-!- mattsc_ [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160322 21:31:19-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: Not here much atm. Will check logs for my nick and forum PMs.]
20160322 21:31:19-!- mattsc_ is now known as mattsc
20160322 21:32:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Client Quit]
20160322 21:33:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 21:37:37-!- Nobun [~nobun@host186-52-dynamic.16-87-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160322 21:38:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160322 21:39:35-!- prkc [~prkc@catv-80-98-103-239.catv.broadband.hu] has joined #wesnoth-dev
20160322 21:40:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 21:40:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20160322 21:41:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 21:53:47-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 21:53:48< travis-ci> wesnoth/wesnoth#9016 (master - e86cadf : Charles Dang): The build has errored.
20160322 21:53:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117801560
20160322 21:53:48-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 21:54:41-!- Kwandulin [~Miranda@p200300760F191C499917D37727E80751.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160322 22:05:03-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160322 22:07:01< ancestral> I’m getting a build error
20160322 22:07:16< ancestral> git pulling first
20160322 22:09:14< mattsc> hi ancestral 
20160322 22:09:40< celticminstrel> Is it readline? Because you probably need to copy it to libs/ and Headers/.
20160322 22:09:40< mattsc> celticminstrel said we need to update readline; or put it into the “Mac Compile Stuff” collection in the first place
20160322 22:11:06< mattsc> I was going to try that, but I foolishly did an “update all” today and I am still not quite back up to speed with everything
20160322 22:11:52< celticminstrel> I feel that it doesn't really belong in Mac Compile Stuff since it's included with the system; however, it seems like the system possibly ships an old version of it.
20160322 22:11:57< ancestral> lua_interpreter.cpp:295
20160322 22:12:01< celticminstrel> So it might need to go in there anyway.
20160322 22:12:04< celticminstrel> Yeah, that's readline.
20160322 22:12:16< ancestral> hi mattsc
20160322 22:12:47< ancestral> Isn’t readline part of something?
20160322 22:12:59< ancestral> Part of OS X?
20160322 22:13:04< celticminstrel> Yeah, I think so.
20160322 22:13:17< ancestral> So… why the failure?
20160322 22:13:26< celticminstrel> Version mismatch?
20160322 22:13:39< celticminstrel> What's the version in the readline header that XCode is using?
20160322 22:13:49< ancestral> How do I find that out?
20160322 22:13:50< celticminstrel> Mine is 4.2, which is too old.
20160322 22:14:06< ancestral> And how new is new enough?
20160322 22:14:09< celticminstrel> Command-clicking the include statement should work, I think.
20160322 22:14:22< celticminstrel> I don't know how old is new enough. I threw 6.3 in and it worked.
20160322 22:14:36< celticminstrel> I couldn't find any kind of changelog for readline.
20160322 22:14:42< celticminstrel> Maybe I just didn't know where to look.
20160322 22:14:57< ancestral>  /*	$NetBSD: readline.h,v 1.33 2012/05/15 17:30:04 christos Exp $ */
20160322 22:15:13< ancestral> It’s part of editline
20160322 22:15:25-!- atarocch [~atarocch@37.118.128.66] has quit [Ping timeout: 248 seconds]
20160322 22:15:37< celticminstrel> Eh?
20160322 22:19:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160322 22:19:50< ancestral>  /usr/include/editline/readline. h
20160322 22:21:09< celticminstrel> Is that what XCode is including?
20160322 22:21:42< celticminstrel> Shouldn't be, the include is <readline/history.h>
20160322 22:23:57< ancestral> readline.h is the only include for editline
20160322 22:24:29< celticminstrel> Yeah, that's not what's being used here...
20160322 22:24:34< ancestral> I know
20160322 22:24:55< ancestral> It’s looking there as a failsafe probably, or as an alias
20160322 22:25:32< celticminstrel> That doesn't make any sense though... unless readling/history.h was symlinked to it, I suppose...
20160322 22:25:39< celticminstrel> ^readline
20160322 22:26:37-!- louis94 [~~louis94@91.178.240.41] has joined #wesnoth-dev
20160322 22:27:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160322 22:29:05< ancestral> Well, I’ll add 6.3 in
20160322 22:29:23< ancestral> Just curious what functions you’re using that are new
20160322 22:29:37< ancestral> to 6.3 that aren’t in the older versions
20160322 22:30:32< celticminstrel> append_history apparently. I think there was one other.
20160322 22:30:35< celticminstrel> I didn't write this.
20160322 22:30:38< ancestral> https://paste.ee/p/b78V6
20160322 22:31:56< celticminstrel> Not quite sure why you linked that.
20160322 22:32:19< celticminstrel> Apparently there's talk of removing the readline dependency, but I personally don't think it's good to just do without the history feature until then.
20160322 22:32:21< ancestral> I was just curious if append_history is necessary, if there was another way ro do ir
20160322 22:32:24< ancestral> *to do it
20160322 22:33:31< celticminstrel> Ah. I have no idea. I don't know anything about readline. My rudimentary searching suggested that append_history is used for saving history between sessions or something, so I guess you could maybe surround it in an #fe RL_READLINE_VERSION < whatever check.
20160322 22:33:35< celticminstrel> ^#if
20160322 22:34:18< ancestral> I’ll go find 6.3 and yeah, mayve we add that to MacCompileStuff
20160322 22:34:23< celticminstrel> I mean, saving between sessions is less important compared to having it at all.
20160322 22:39:37-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 22:39:38< travis-ci> wesnoth/wesnoth#9017 (master - 6158ca7 : Charles Dang): The build has errored.
20160322 22:39:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117815233
20160322 22:39:38-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 22:40:55< mattsc> ancestral: once you got it working, could you let me know what you did?
20160322 22:41:48< celticminstrel> What I did was just copy things from MacPorts into the projectfiles dir.
20160322 22:43:38< celticminstrel> Oh right, I have a changelog and release notes entry to write.
20160322 22:46:06< celticminstrel> Oh, also...
20160322 22:46:40< irker734> wesnoth: Celtic Minstrel wesnoth:master c7d1bd6ae49d / src/ai/configuration.cpp: Don't inject full RCA AI if ai_algorithm unspecified and a [stage] defined https://github.com/wesnoth/wesnoth/commit/c7d1bd6ae49d3cbcaf9da43a9762b6c28670aee5
20160322 22:47:50< mattsc> celticminstrel: that’s what I figured I’d do too, just that I first need to migrate my Macports installation after the upgrade (and haven’t had time to do that yet)
20160322 22:48:02< mattsc> actually, I’ll probably just wipe and reinstall
20160322 22:48:26< mattsc> and: cool on c7d1etcetc
20160322 22:48:50< celticminstrel> For a second there I thought, "Wait, did the commit hash really contain etcetc?"
20160322 22:49:03< mattsc> hehe
20160322 22:49:13-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160322 22:49:22< celticminstrel> In retrospect though, I don't think T is possible. I think it's hex.
20160322 22:50:16< celticminstrel> Did you ever test if that thing about Lua aspects is still an issue?
20160322 22:50:51< mattsc> That thing about Lua aspects …
20160322 22:51:05< celticminstrel> Uh, something about simple aspect syntax not working in some circumstance.
20160322 22:51:09< celticminstrel> Which involved Lua.
20160322 22:51:42< celticminstrel> Incidentally, while I think it's probably fixed, it would only be for key=value, not eg [avoid]filter[/avoid].
20160322 22:52:15< celticminstrel> Unless I misunderstood the problem.
20160322 22:52:23< mattsc> Oh that.  That’s not Lua aspects, but …  Anyway, just explaining why I was confused.
20160322 22:52:39< celticminstrel> No, it's not quite Lua aspects, you're right. Sorry.
20160322 22:52:54< mattsc> No, that’s been on my plan to do after I was done with the MAI testing.  Then I sabotaged myself (and you) this morning.  :P
20160322 22:53:00< celticminstrel> Ah, okay.
20160322 22:53:09< mattsc> But it’s still on the plan to do!
20160322 22:53:38< celticminstrel> Oh, my commit message still mentions "Recruitment can now be specified as a simple attribute", but I reverted that around the time I decided to remove the old recruitment.
20160322 22:53:46< mattsc> I’ll pay specific attention to key=value vs. [avoid] then also
20160322 22:53:56< celticminstrel> Whoops, inaccurate commit messages. >_>
20160322 22:54:09< celticminstrel> There's at least one other one too that still mentions [params].
20160322 22:54:27< mattsc> Yeah, sorry, you said you were going to clean those up.
20160322 22:54:45< mattsc> Nobody’s going to read the commit messages though, as long as we get the release notes right
20160322 22:54:50< mattsc> (and the wiki)
20160322 22:54:59< celticminstrel> Well, I'm not entirely sure I would've remembered to clean it up but yeah, I would've if I'd noticed it before merging.
20160322 22:56:05< celticminstrel> I'm classifying aspects as either "simple" (uses a value= key in the full syntax) or "complex" (uses a [value] key in the full syntax).
20160322 22:56:19< celticminstrel> The attacks aspect uses neither and thus counts as complex as well.
20160322 22:56:48< celticminstrel> This is separate from the "standard" / "composite" distinction and the "aspect" / "facet" distinction.
20160322 22:57:05< mattsc> Sounds good to me.
20160322 22:57:08< celticminstrel> Though in practice, [aspect] usually means "composite" and [facet] usually means "standard".
20160322 22:57:33< mattsc> And I know that nomenclature was used on at least one or two of the old wiki pages too
20160322 22:57:36< celticminstrel> However, there's two additional values for the "standard" / "composite" distinction - one is Lua, the other is the attacks aspect.
20160322 22:58:15< celticminstrel> My generalization of aspect syntax probably makes things possible that don't have much use, but I think one of the better ones is that [facet] can use Lua.
20160322 22:59:26< mattsc> ok
20160322 22:59:51< mattsc> My big question right now is whether I dare to hit the ‘sync’ button on the Github App.
20160322 23:00:07< mattsc> All that should do is to pull the most recent changes.
20160322 23:00:21< mattsc> Which is what I though it should do this morning also …
20160322 23:02:06< mattsc> Well, that’s what it did — but my blood pressure was a bit higher doing so than a ‘git pull’ should usually cause   :P
20160322 23:09:56< mattsc> ancestral, celticminstrel: I migrated Macports to the new version of OS X; it tells me:
20160322 23:09:58< mattsc> readline                       @6.3.003
20160322 23:10:07< mattsc> I assume that’s the same version celticminstrel installed
20160322 23:10:30< gfgtdf> mattsc; i somehow made teh expereince that the 'sync' button is notiabley slower than using tthe commandline
20160322 23:10:32< mattsc> ancestral: I can do that for my build unless you suggest something else
20160322 23:10:56< gfgtdf> mattsc: assuming that your github app is the same as github for windows.
20160322 23:11:09< mattsc> gfgtdf: I think the sync button does a whole lot more than just git pull
20160322 23:11:17< gfgtdf> noticeably*
20160322 23:11:34< mattsc> I have no idea whether the Mac and Windows versions are the same internally
20160322 23:11:51< ancestral> Sync does a push and a pull iirc
20160322 23:12:08< gfgtdf> mattsc: also is usuualy syncs it with your fork of wesnoth not with wesnoth/wesnoth at lest on my configuration
20160322 23:12:11< mattsc> I’ve noitced that, if I have local changed files that do not conflict with upstream, I can just hit sync and it will push or pull as needed
20160322 23:12:18< ancestral> mattsc: Sounds like an extra lib is what is required
20160322 23:12:23< mattsc> So I assume it also stashes and unstashes
20160322 23:13:04< gfgtdf> mattsc: i usually never use the sync button. I do sometimes use the publish button though becasue i don't know teh commanline command to publish a branch to the remote.
20160322 23:13:22< mattsc> gfgtdf: well, 
20160322 23:13:42< mattsc> I usually do not do anything “complicated”, so the sync button is all I need.
20160322 23:13:56< mattsc> I do like the graphical diff.
20160322 23:14:24< mattsc> But anyways, I do use the CL too at times; and probably will do so more often in the future
20160322 23:14:54< gfgtdf> mattsc: hmm maybe i wasn't clear: the main reason why i don't use teh sync button is that its rather slow here. I often get the imporession that it gets stuck inthe middle not knowing ehther it will ever proceed.
20160322 23:15:00< mattsc> ancestral: yeah; so should I just do that for me locally, or are you going to update the libraries archive?
20160322 23:15:33< mattsc> gfgtdf: hmm, I had not understood that it is that slow.  That does not happen for me.
20160322 23:23:27< ancestral> mattsc: We still have issues with Pango and Cairo
20160322 23:23:37< ancestral> Getting a version to work between multiple versions of OS X
20160322 23:23:37< mattsc> ancestral: what kind of issues?
20160322 23:23:43< ancestral> We tried this before
20160322 23:23:56-!- mjs-de [~mjs-de@x4db6282d.dyn.telefonica.de] has quit [Remote host closed the connection]
20160322 23:24:01< ancestral> One version seems to only work 10.10+ and another with other versions below this
20160322 23:24:23< mattsc> right; that problem …
20160322 23:24:27< ancestral> the static libs
20160322 23:24:31< ancestral> There’s a few things
20160322 23:24:38< ancestral> Those are all part of the MacCompileStuff
20160322 23:24:53< ancestral> I mean, I guess we could, in the mean time, provide both versions of it
20160322 23:25:28< ancestral> I need to spend more time for research on this
20160322 23:25:42< ancestral> Unless you know or know someone who knows how
20160322 23:26:08< mattsc> I don’t, unfortunately.
20160322 23:26:23< mattsc> What I can offer is that I have currently both a 10.9 and a 10.11 system.
20160322 23:26:35< mattsc> So I can do pre- and post-10.10 testing
20160322 23:28:29< mattsc> ancestral: also, I just built readline with Macports and threw both the dylib and the Headers in (as celticminstrel suggested) and everything built just fine after that.
20160322 23:28:40< ancestral> Cool
20160322 23:31:05-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160322 23:34:18< mattsc> Hmm, graphics are really slow though all of a sudden, with a bunch of jumpin back and forth though ...
20160322 23:34:58< mattsc> celticminstrel: also: http://pastebin.com/aqEDQTvA
20160322 23:35:37< mattsc> This is with the test scenario where I have the AI play side 1 of HttT:S1
20160322 23:36:24< mattsc> you can test with -t The_Elves_Besieged if you want.
20160322 23:36:39< mattsc> I’ll look into it more later, right now I am going to be afk for at least an hour.
20160322 23:37:31< mattsc> celticminstrel: the other MAIs I have tested so far work without problems, so it’s not a universal problem (but I’ve only done a few quick tests so far, given that I am only back in action for about 10 min)
20160322 23:37:36< mattsc> bye for now
20160322 23:40:30-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160322 23:40:31< travis-ci> wesnoth/wesnoth#9018 (master - c7d1bd6 : Celtic Minstrel): The build has errored.
20160322 23:40:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/117839708
20160322 23:40:31-!- travis-ci [~travis-ci@ec2-54-159-71-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160322 23:41:19-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160322 23:47:50-!- gfgtdf [~chatzilla@f054157159.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]]
20160322 23:48:42< celticminstrel> Hmm, interesting error.
20160322 23:49:10< celticminstrel> Normally the brackets in "name=[]" and "[] engine" would be filled with something, for example "lua_goal" and "cpp".
20160322 23:56:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
--- Log closed Wed Mar 23 00:00:13 2016