--- Log opened Thu Mar 31 00:00:14 2016
20160331 00:00:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160331 00:01:08< celticminstrel> Gah, why can't I configure my smart mailbox to include only messages from Sent and Inbox. ><
20160331 00:02:53< celticminstrel> Oh, wait, is it mysteriously working all of a sudden?
20160331 00:03:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 00:05:29-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160331 00:06:02< celticminstrel> Oh right, I think wedge009 was using MSVC 2013?
20160331 00:07:47-!- markus_ [~mjs-de@x4db53fea.dyn.telefonica.de] has joined #wesnoth-dev
20160331 00:08:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160331 00:08:28-!- wedge010 is now known as wedge009
20160331 00:09:48< vultraz> ok, only 5 lexical_cast uses left
20160331 00:10:10< vultraz> char, map_location, and tstring all can't use to_string
20160331 00:11:29-!- mjs-de [~mjs-de@x4db53e27.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160331 00:11:45< loonycyborg> celticminstrel: seems mingw64 cross-compiler gentoo's crossdev tool makes doesn't support std::thread
20160331 00:13:04< loonycyborg> so I'd lose ability to cross-compile if we used std::thread..
20160331 00:13:31< celticminstrel> I assume this would be bad.
20160331 00:14:17< loonycyborg> also it seems even in windows hosted gcc ports std::thread is available only from specialized releases
20160331 00:16:06< loonycyborg> I'd prefer to stay with boost::thread til mingw gets proper std::thread support. 
20160331 00:17:34< celticminstrel> So we need to announce this to the mailing list then.
20160331 00:18:07< loonycyborg> ok
20160331 00:19:10< celticminstrel> Who will do that?
20160331 00:19:28< irker509> wesnoth: Charles Dang wesnoth:master 876710af8c24 / src/ (79 files in 28 dirs): Use std::to_string() or equivalent wherever possible https://github.com/wesnoth/wesnoth/commit/876710af8c24191ded7d9b82e5ee667aca216832
20160331 00:20:02< vultraz> whoot whoot
20160331 00:21:18< loonycyborg> celticminstrel: gfgtdf maybe? He made that change :P
20160331 00:21:37< celticminstrel> I was thinking that too. :P
20160331 00:22:18< vultraz> for some reason I've been including thread in the codeblocks sdk
20160331 00:22:42< celticminstrel> The XCode project also included it already.
20160331 00:22:45< loonycyborg> we needed boost.thread when we had libANA..
20160331 00:23:15< loonycyborg> but direct use of asio does not require threads
20160331 00:24:05< loonycyborg> asio provides event loop that can run in several threads, but I run it only in one
20160331 00:24:43< loonycyborg> because most network code is small tasks executed in handlers
20160331 00:24:59< loonycyborg> most of time is spend waiting for network
20160331 00:25:26< loonycyborg> so one thread is enough
20160331 00:26:08< vultraz> celticminstrel: can I get rid of the #ifdef HAVE_CXX11 blocks or are you working on that?
20160331 00:26:19< celticminstrel> I was going to do that.
20160331 00:26:29< loonycyborg> asio itself doesn't need threads in implementation too, it uses poll/select/whatever-is-platform-appropriate
20160331 00:26:34< vultraz> ok I'll let you do that
20160331 00:26:36< celticminstrel> But I'm not currently working on it.
20160331 00:26:41< celticminstrel> So if you want to, feel free.
20160331 00:26:46< vultraz> ok
20160331 00:28:30< celticminstrel> vultraz: Did you remove the lexical_cast header?
20160331 00:29:03-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 240 seconds]
20160331 00:29:20< vultraz> celticminstrel: uh...
20160331 00:29:32< vultraz> you mean inclusions of util.hpp?
20160331 00:29:46< celticminstrel> Was lexical_cast defined in util.hpp?
20160331 00:30:06< vultraz> yes
20160331 00:30:17< celticminstrel> And it's still there?
20160331 00:30:23< vultraz> keep in mind there's still a lot of lexical_cast stuff that we still use
20160331 00:30:28< celticminstrel> I see.
20160331 00:30:30< vultraz> I only reduced the string cast to 5 cases
20160331 00:30:41< celticminstrel> Fair enough.
20160331 00:30:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160331 00:30:51< celticminstrel> It could be replaced by Boost at some point, but no hurry.
20160331 00:34:05< irker509> wesnoth: Charles Dang wesnoth:master 5afdb0f72a2a / data/gui/window/loadscreen.cfg: tloadscreen: better calculations for positioning spacers https://github.com/wesnoth/wesnoth/commit/5afdb0f72a2a743b2ca99b53c228fdd77568748c
20160331 00:34:08< irker509> wesnoth: Charles Dang wesnoth:master 7f1dd72c9321 / data/gui/window/loadscreen.cfg: tloadscreen: fixed another case of conflicting layout keys https://github.com/wesnoth/wesnoth/commit/7f1dd72c9321d21ade727d491e790799f7c27998
20160331 00:34:17< vultraz> ^ one less thing for travis to fail on
20160331 00:34:32< celticminstrel> Let's see if it helps.
20160331 00:36:39< vultraz> I'll deal with removing the c++11 ifdefs
20160331 00:37:38< celticminstrel> Once you've done that, I'll deal with nullptr.
20160331 00:37:50< celticminstrel> Best not to have two such things going on at the same time.
20160331 00:37:54< vultraz> right
20160331 00:38:05< celticminstrel> I may deal with range-for too.
20160331 00:38:23< vultraz> actually, could you expand FINAL, OVERRIDE, and AUTO first?
20160331 00:38:33< celticminstrel> Why?
20160331 00:38:43< celticminstrel> I thought you were expanding FINAL and OVERRIDE.
20160331 00:38:52< vultraz> oh, you want me to do that as well?
20160331 00:38:55< vultraz> I can do that with this, yes
20160331 00:39:01< celticminstrel> Well, it's related to the ifdefs, right?
20160331 00:39:11< vultraz> yeah
20160331 00:39:25< celticminstrel> As for AUTO, that's intrinsically linked to the range-for, so I can't really expand that without also doing range-for.
20160331 00:39:32< vultraz> alright
20160331 00:39:39< vultraz> seems FINAL isn't used anywhere, good
20160331 00:39:54< celticminstrel> Yeah, there's very little reason to ever use it.
20160331 00:40:20< celticminstrel> So, for some reason, I'm getting "Unknown type name 'version_info'" in addon/info.hpp.
20160331 00:40:44< celticminstrel> How does this make any sense?
20160331 00:41:12< vultraz> It does not
20160331 00:41:21< celticminstrel> Exactly. So why am I getting it?
20160331 00:41:25< vultraz> I'm not
20160331 00:41:33< celticminstrel> I'm building unit tests right now.
20160331 00:41:56< vultraz> ah
20160331 00:42:01< vultraz> probably a missing include?
20160331 00:42:11< celticminstrel> Well, the include is right there.
20160331 00:42:38< celticminstrel> That's why it doesn't make any sense.
20160331 00:43:19< celticminstrel> Oh my, "no viable conversion from const_iterator to const_iterator".
20160331 00:43:45< celticminstrel> Oh, hmm, I wonder if that one could be from incorrect headers...
20160331 00:45:05< celticminstrel> (I mean, I updated the Boost libs but not the Boost headers.)
20160331 00:45:30< celticminstrel> (That doesn't however explain why I got these errors in unit tests but not in ... wait... maybe unit tests doesn't have the include paths set...)
20160331 00:46:16-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160331 00:47:05-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 00:48:32-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 00:48:33< travis-ci> wesnoth/wesnoth#9124 (master - 876710a : Charles Dang): The build has errored.
20160331 00:48:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119689039
20160331 00:48:33-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 01:00:59< celticminstrel> So, bizarrely, it seems like it only works if the header (which it's including right there at the top of the file!) has already been included somewhere else... :|
20160331 01:01:44< celticminstrel> And I get "unknown type name" and "incomplete type" on the same line (from being included in different source files).
20160331 01:02:47< celticminstrel> Oh, I bet XCode is including desktop/version.hpp instead of version.hpp.
20160331 01:03:32-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 01:03:33< travis-ci> wesnoth/wesnoth#9125 (master - 7f1dd72 : Charles Dang): The build has errored.
20160331 01:03:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119690700
20160331 01:03:33-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 01:06:31-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has joined #wesnoth-dev
20160331 01:07:08< irker509> wesnoth: Charles Dang wesnoth:master cf6fa69d2724 / src/ (53 files in 6 dirs): Removed C++11 include guards https://github.com/wesnoth/wesnoth/commit/cf6fa69d27249640d27cac3fdeb99afcbb47e7a8
20160331 01:07:19< vultraz> celticminstrel: ^
20160331 01:08:10< celticminstrel> Blargh, perhaps I'll put the unit tests on hold for a bit, then.
20160331 01:08:34< vultraz> oh jeez
20160331 01:08:42< vultraz> travis REALLY doesn't like the to_string change O_O
20160331 01:08:52< celticminstrel> Eh?
20160331 01:10:13< vultraz> src/tests/test_lexical_cast.cpp:111:2: error: call of overloaded ‘to_string(const float*&)’ is ambiguous
20160331 01:10:16< vultraz> lot of stuff related to that
20160331 01:10:19< vultraz> and other errors..
20160331 01:10:43< celticminstrel> Huh? const float* sounds suspicious.
20160331 01:10:59< celticminstrel> Why are you calling to_string on a pointer?
20160331 01:11:42-!- markus_ [~mjs-de@x4db53fea.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20160331 01:11:46< vultraz> ahh
20160331 01:11:56< vultraz> I accidentally included the test in the conversion
20160331 01:12:22< celticminstrel> Firefox, why are you so slow.
20160331 01:12:27< vultraz> how do you revert changes to a single file..
20160331 01:12:54< celticminstrel> git checkout <revision> <file>
20160331 01:13:13< celticminstrel> Add -p if you want to select only certain changes in the file.
20160331 01:13:39< celticminstrel> ...though I don't know for sure if that actually works.
20160331 01:13:47< celticminstrel> -p does do that with several git commands, at least.
20160331 01:14:42< irker509> wesnoth: Charles Dang wesnoth:master 7a2955f05380 / src/tests/test_lexical_cast.cpp: Revert accidental conversion of lexical_cast test to to_string (from 876710af8c2 https://github.com/wesnoth/wesnoth/commit/7a2955f053806e7dc77d453d439687cb609d5dde
20160331 01:17:29< vultraz> ok, what else to do..
20160331 01:17:38< vultraz> you're taking care of nullptr and range-for
20160331 01:18:32< celticminstrel> So I was right, it's including src/desktop/version.hpp when it should be including src/version.hpp.
20160331 01:19:42< vultraz> can we use initializer lists?
20160331 01:20:35< celticminstrel> I think so? Might want to double-check compiler support tables first.
20160331 01:21:00< celticminstrel> Also, using initializer lists doesn't seem like an easy quick-fix to me.
20160331 01:21:27< vultraz> I only have the case in prefs in mind :P
20160331 01:21:38< vultraz> vs 2013 has it, so we should be good
20160331 01:21:43-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 244 seconds]
20160331 01:22:16< celticminstrel> There was at least one thing I wanted to switch to variadic templates, too.
20160331 01:22:22< vultraz> random question: are you allowed to initialize class member variables in the header
20160331 01:22:29< vultraz> and not the constructor
20160331 01:22:31< celticminstrel> I think so.
20160331 01:22:41< celticminstrel> Again though, that's not really an easy quick-fix situation.
20160331 01:23:49< gfgtdf> vultraz: hm it'd be news to be if you could initlize class memeber variabels in the header instead of the constructor.
20160331 01:24:26< celticminstrel> gfgtdf: It's definitely one of the new thigns in C++11.
20160331 01:24:29< celticminstrel> ^things
20160331 01:25:01< vultraz> gfgtdf, celticminstrel: it works :D
20160331 01:26:24< gfgtdf> vultraz: hmm i'm still not sure if this is good thing to do though. Its a nice feature to be able to find the default value for those varaibles always in the constructor without having to search in the header.
20160331 01:26:56-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160331 01:28:20< celticminstrel> gfgtdf: It's useful if you have several constructors and want the same default value for it in most of them.
20160331 01:29:08< mattsc> celticminstrel: do you mind if I add -Wno-inconsistent-missing-override to the Xcode project?
20160331 01:29:56< celticminstrel> mattsc: I have no objections to it, but I'm currently updating the XCode project with other stuff.
20160331 01:30:25< mattsc> celticminstrel: no worries, I can wait.
20160331 01:30:50< mattsc> Things are working after all, it’s just annoying getting 2029 warnings with each build.
20160331 01:31:01-!- gfgtdf_ [~chatzilla@f054149045.adsl.alicedsl.de] has joined #wesnoth-dev
20160331 01:33:24-!- gfgtdf [~chatzilla@f054057118.adsl.alicedsl.de] has quit [Ping timeout: 260 seconds]
20160331 01:33:26-!- gfgtdf_ is now known as gfgtdf
20160331 01:37:11-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has quit [Quit: Leaving]
20160331 01:40:43-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 01:43:43-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 01:43:44< travis-ci> wesnoth/wesnoth#9126 (master - cf6fa69 : Charles Dang): The build has errored.
20160331 01:43:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119695321
20160331 01:43:44-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 01:44:24-!- nos_ [~nos@208.91.185.104] has joined #wesnoth-dev
20160331 01:48:23-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 01:48:24< travis-ci> wesnoth/wesnoth#9127 (master - 7a2955f : Charles Dang): The build has errored.
20160331 01:48:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119696367
20160331 01:48:24-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 01:49:31-!- nos_ is now known as NosajIRL
20160331 02:01:02< celticminstrel> I'm actually finding myself manually editing the XCode project... :|
20160331 02:15:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 02:18:25< irker509> wesnoth: Charles Dang wesnoth:master 0acea0c5025c / src/tests/test_make_enum.cpp: Revert accidental conversion of make_enum test to to_string (from 876710af8c24) https://github.com/wesnoth/wesnoth/commit/0acea0c5025c27e5b39a91d5dcb58b38070efc7d
20160331 02:19:34-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has joined #wesnoth-dev
20160331 02:19:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160331 02:20:09-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has quit [Remote host closed the connection]
20160331 02:21:05< vultraz> apparently std::atoi returns 0 on fail and that's bad
20160331 02:21:52< vultraz> will see if I can convert to stoi
20160331 02:24:14< celticminstrel> I don't understand what's up with these errors, but I'm testing if changing filenames helps.
20160331 02:24:33-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160331 02:25:56< celticminstrel> Though, I suspect it won't help.
20160331 02:27:52< SigurdFD> somebody missed something recently, as of right now, under an mp local game the only game types you can start are campaign or sp campaign
20160331 02:28:33< celticminstrel> I wonder if that's similar to the issue I had where my test scenario is occasionally not recognized.
20160331 02:29:38< celticminstrel> Okay, since I have no idea what's going on, I think what I'll do is remove all sources from the unit tests and start over.
20160331 02:29:45-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 246 seconds]
20160331 02:30:07< celticminstrel> Or revert everything, if I've broken the main build...
20160331 02:32:53< mattsc> SigurdFD: confirmed; that’s how it is for me as well.  (at commit 7a2955f0538)
20160331 02:33:45 * celticminstrel wonders if anyone has time to bisect this.
20160331 02:36:43< SigurdFD> I have a guess as to which one, I think I'll try that.
20160331 02:38:07< mattsc> I can’t do that right now, so if you could, that would be great.
20160331 02:39:42-!- prkc [~prkc@192.40.89.17] has quit [Ping timeout: 268 seconds]
20160331 02:41:50< irker509> wesnoth: Celtic Minstrel wesnoth:master 486cf469930c / src/SConscript: scons: sort source file lists https://github.com/wesnoth/wesnoth/commit/486cf469930c4742f40737c49ae1463876d4bd2b
20160331 02:43:24< SigurdFD> it's a chance for me to play around with git gui :D
20160331 02:43:58< SigurdFD> recently got rid of tortisegit
20160331 02:44:22< vultraz> but tgit is awesome D:
20160331 02:44:52< celticminstrel> git gui is not "awesome" or anything, but it's surprisingly not-terrible.
20160331 02:45:01< SigurdFD> I found some stuff was non-intuitive, and is way more intuitive in git gui
20160331 02:46:19-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160331 02:48:40< SigurdFD> My current plan is to make it easy for more wml contributors to get on master to make pr’s to update campaigns. pr616 & a git gui recommendation are likely to be part of it.
20160331 02:52:24< celticminstrel> Sounds like a good plan.
20160331 02:53:46< SigurdFD> thanks
20160331 02:54:45-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has joined #wesnoth-dev
20160331 02:56:11-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 02:56:12< travis-ci> wesnoth/wesnoth#9128 (master - 0acea0c : Charles Dang): The build has errored.
20160331 02:56:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119703705
20160331 02:56:12-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 02:58:20< vultraz> crap
20160331 02:58:31< vultraz> wesnoth crashes :|
20160331 02:58:44< celticminstrel> ?
20160331 02:59:21< vultraz> I'm converting to stoi
20160331 02:59:26< vultraz> made wesnoth crash
20160331 02:59:32< celticminstrel> Ah.
20160331 03:02:41< vultraz> Wesnoth binary not found at .//wesnoth in travis
20160331 03:03:01< celticminstrel> Yeah, I was wondering about that too.
20160331 03:04:34< vultraz> terminate called after throwing an instance of 'std::invalid_argument'
20160331 03:04:35< vultraz>   what():  stoi
20160331 03:04:37< vultraz> blagh
20160331 03:04:41< vultraz> what does this mean
20160331 03:05:08< celticminstrel> Probably that you passed a string that doesn't contain the representation of an integer.
20160331 03:05:44< vultraz> but if atoi basically does the same thing, why did it work then
20160331 03:05:55< vultraz> (though I have been removing the .c_str() suffixes..)
20160331 03:06:08-!- gfgtdf [~chatzilla@f054149045.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]]
20160331 03:06:17< celticminstrel> Didn't you say atoi3 returns 0 in that case?
20160331 03:06:33< vultraz> apparently
20160331 03:11:16-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 03:11:17-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160331 03:11:17< travis-ci> wesnoth/wesnoth#9129 (master - 486cf46 : Celtic Minstrel): The build has errored.
20160331 03:11:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119706250
20160331 03:11:17-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 03:20:35< SigurdFD> celticminstrel, vultraz: it's '87671 - Use std::to_string() or equivalent wherever possible' or later
20160331 03:20:59< celticminstrel> I'll give that commit a review, then.
20160331 03:21:30< SigurdFD> testing 87671 now
20160331 03:21:36< celticminstrel> He already reverted two bits of it.
20160331 03:22:08 * celticminstrel has a push coming soon.
20160331 03:22:28< SigurdFD> the two bits reverted didn't fix it
20160331 03:22:50< celticminstrel> I wasn't expecting them to.
20160331 03:22:57< SigurdFD> ok
20160331 03:26:34-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 268 seconds]
20160331 03:26:53< SigurdFD> does anyone here use wmlindent on windows?
20160331 03:27:08< celticminstrel> I don't use it at all.
20160331 03:29:41< SigurdFD> celticminstrel: are you on windows?
20160331 03:29:51< celticminstrel> No.
20160331 03:30:13-!- ShikadiLord [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20160331 03:30:56< ancestral> loonycyborg maybe?
20160331 03:31:17< ancestral> (Or maybe I’m thinking of someone else)
20160331 03:31:18-!- esr1 [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20160331 03:32:56-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 246 seconds]
20160331 03:33:26-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 246 seconds]
20160331 03:33:27-!- Elsi [~Elsi@2001:41d0:2:d43b::1] has quit [Ping timeout: 246 seconds]
20160331 03:33:50-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20160331 03:36:59< celticminstrel> vultraz: The nullptr commit is going to be huge... :|
20160331 03:38:36< ancestral> Now I really will need to update the MacCompileStuff
20160331 03:38:43-!- oldlaptop [~quassel@50-37-53-169.mskg.mi.frontiernet.net] has quit [Ping timeout: 248 seconds]
20160331 03:39:15< celticminstrel> That makes it sound like you didn't already need to.
20160331 03:39:24< ancestral> I needed to
20160331 03:39:34< ancestral> I mean, I will need to update more parts of it
20160331 03:39:43< celticminstrel> Really?
20160331 03:39:48< celticminstrel> Okay then.
20160331 03:44:09-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 03:46:01< mattsc> ancestral: btw, don’t know if you saw that in the logs, since I don’t need to update the internal links for my local build, compiling the boost libs with Macports and putting them into the project directory was indeed trivial.
20160331 03:46:16< mattsc> Only caveat is that I now get 2,029 warning messages.  ;)
20160331 03:46:32< ancestral> Okay, thanks
20160331 03:47:09< mattsc> And I know what to do about the warnings, I’m just waiting for celticminstrel to be done with what he’s currently doing with the project file.
20160331 03:47:37< celticminstrel> Which is turning out to be bizzarely difficult.
20160331 03:49:24-!- oldlaptop [~quassel@50-37-53-169.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20160331 03:49:25< ancestral> mattsc: Glad to know you got it built!
20160331 03:50:48< SigurdFD> celticminstrel, vultraz: it's 87671
20160331 03:51:06< celticminstrel> You said that already.
20160331 03:51:28< SigurdFD> not quite, earlier I said it was that or later
20160331 03:51:40< celticminstrel> I assume you don't know specifically how to fix it.
20160331 03:53:03< SigurdFD> no, I don't
20160331 03:53:12< celticminstrel> Just checking.
20160331 03:53:31< celticminstrel> I'll review that commit and see if anything looks suspicious (other than the bits already reverted).
20160331 03:54:25< ancestral> SigurdFD: You’re on Windows?
20160331 03:54:35< ancestral> Do you have git on your computer?
20160331 03:56:56< SigurdFD> yes, yes
20160331 03:57:21< ancestral> SigurdFD: Would you like to try my branch? ancestral-lato
20160331 03:57:47< ancestral> I’m hoping to get a few more people to give their thoughts on a proposed font change
20160331 03:58:37< ancestral> Even better is if you wouldn’t mind taking some screenshots
20160331 03:58:51< SigurdFD> I think I'll give it a look, probabably next week.
20160331 03:59:01< ancestral> Great, thanks! :)
20160331 04:00:16< SigurdFD> hopefully straightening out the c11/depenency changes won't confuse me to much. But I guess that's a reason to practice git rebase :P
20160331 04:09:30-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160331 04:09:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160331 04:14:43-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160331 04:31:39-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 276 seconds]
20160331 04:44:06< irker509> wesnoth: Celtic Minstrel wesnoth:master 3ac7f8d970d9 / / (423 files in 52 dirs): NULL -> nullptr https://github.com/wesnoth/wesnoth/commit/3ac7f8d970d92f65f17c76e502c36a2a1240c438
20160331 04:45:50< celticminstrel> It's probably obvious, but that's not the XCode project update.
20160331 04:46:12-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has joined #wesnoth-dev
20160331 04:47:44-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160331 04:51:00-!- NosajIRL [~nos@208.91.185.104] has quit [Ping timeout: 244 seconds]
20160331 04:51:31-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160331 04:54:23-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160331 04:59:47-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has quit [Read error: Connection reset by peer]
20160331 05:00:30-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has joined #wesnoth-dev
20160331 05:00:30-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has quit [Client Quit]
20160331 05:00:39-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has joined #wesnoth-dev
20160331 05:12:25-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 05:12:35< travis-ci> wesnoth/wesnoth#9130 (master - 3ac7f8d : Celtic Minstrel): The build has errored.
20160331 05:12:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119718838
20160331 05:12:35-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 05:15:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 05:16:48-!- Kwandulin [~Miranda@p200300760F191CBA6C642741F35113A0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160331 05:20:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160331 05:22:30-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 268 seconds]
20160331 05:23:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160331 05:28:09-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Remote host closed the connection]
20160331 05:47:22-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 05:58:53-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160331 06:02:30< irker509> wesnoth: Charles Dang wesnoth:master 1ae22aa046db / src/gui/dialogs/preferences_dialog.cpp: tpreferences: use initializer list for accl speeds https://github.com/wesnoth/wesnoth/commit/1ae22aa046dbf4e2ccfb1515eb105d49fc0ed938
20160331 06:03:26< vultraz> ancestral: I'm a little concerned that &#10003; doesn't seem to display right in Lato
20160331 06:03:42< ancestral> What is 10003?
20160331 06:04:12< vultraz> checkmark
20160331 06:04:25< ancestral> \u10003?
20160331 06:05:10< vultraz> http://www.fileformat.info/info/unicode/char/2713/index.htm
20160331 06:05:15< ancestral> \u2713
20160331 06:06:46< vultraz> it displays as a box with 4 zeroes
20160331 06:06:49< vultraz> whatever that is
20160331 06:07:36< ancestral> Yeah it doesn’t have checkmark glyphs
20160331 06:08:02< ancestral> I mean, typically that’s what you would use dingbats (or images?) for
20160331 06:08:25< vultraz> that's unfortunate..
20160331 06:08:29< ancestral> Well
20160331 06:08:36< ancestral> You can use the square root
20160331 06:08:42< ancestral> √
20160331 06:09:25< vultraz> I wonder if there's somewhere we can file an FR for support for this character
20160331 06:09:39< ancestral> http://www.latofonts.com
20160331 06:11:04< ancestral> “To con­tact the team, e-​​mail team@​latofonts.​com”
20160331 06:11:19< ancestral> I don’t see a public project page
20160331 06:12:24< vultraz> I'll email them, then
20160331 06:13:58< irker509> wesnoth: Celtic Minstrel wesnoth:master 86b468037114 / src/ (7 files in 3 dirs): Use vector/templating for Lua-like bulk registration functions https://github.com/wesnoth/wesnoth/commit/86b468037114ac628f1d7db82f764cfe34064df7
20160331 06:14:00< irker509> wesnoth: Celtic Minstrel wesnoth:master 4c45683d4d6d / src/ (4 files in 2 dirs): Modernize luaW_getglobal https://github.com/wesnoth/wesnoth/commit/4c45683d4d6de4c938add9146eeed272fda33881
20160331 06:14:02< irker509> wesnoth: Celtic Minstrel wesnoth:master fb6031d6a14c / changelog src/scripting/game_lua_kernel.cpp: lua_function= in SUF now has limited support for non-global functions https://github.com/wesnoth/wesnoth/commit/fb6031d6a14c868914a91afd14fcd43c41faf9eb
20160331 06:17:20< ancestral> vultraz: Some cultures use O and X to mean “True” and “False”, or “OK” and “Cancel”
20160331 06:17:42< ancestral> But it may not be intuitive to everyone in other cultures
20160331 06:17:44< vultraz> well we were using the checkmarks in the Hotkeys list
20160331 06:17:57< vultraz> and the Features list in About
20160331 06:18:06< vultraz> (as well as he unicode x)
20160331 06:18:12< vultraz> the*
20160331 06:18:18< ancestral> Square root might be a workaround (unless you can specifically specify another font)
20160331 06:18:35< vultraz> (&#10005;)
20160331 06:18:48< ancestral> Are you sure that’s the syntax?
20160331 06:18:58< vultraz> that's the html syntax
20160331 06:21:00< ancestral> Yeah okay
20160331 06:21:06< ancestral> &#x2713; might work too
20160331 06:22:10< vultraz> doesn't
20160331 06:22:14< ancestral> vultraz: Do you have my fonts.cfg updated with the right codepoints?
20160331 06:22:25< vultraz> no, but this is gui2
20160331 06:22:29< vultraz> so it doesn't matter
20160331 06:23:24< vultraz> I'm still using Lato on master, not your branch
20160331 06:23:44< ancestral> Ah
20160331 06:29:43-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 268 seconds]
20160331 06:30:55-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 06:30:56< travis-ci> wesnoth/wesnoth#9131 (master - 1ae22aa : Charles Dang): The build has errored.
20160331 06:30:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119725497
20160331 06:30:56-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 06:42:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160331 06:46:48-!- fabi [~quassel@176.2.133.174] has joined #wesnoth-dev
20160331 06:46:48-!- fabi [~quassel@176.2.133.174] has quit [Changing host]
20160331 06:46:48-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160331 06:47:23-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 06:47:53-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 06:47:54< travis-ci> wesnoth/wesnoth#9132 (master - fb6031d : Celtic Minstrel): The build has errored.
20160331 06:47:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119726568
20160331 06:47:54-!- travis-ci [~travis-ci@ec2-54-158-176-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 06:48:02< fabi> hello
20160331 06:53:15< ancestral> Hi
20160331 06:55:10< fabi> hi ancestral
20160331 06:55:47< fabi> zookeeper: hi
20160331 06:56:10< fabi> zookeeper: Have you read my rant about the hewn terrain?
20160331 06:56:19< zookeeper> yes
20160331 06:56:29< fabi> Can it be brought back?
20160331 06:57:05< zookeeper> not in core, no. it's too awfully glitchy
20160331 06:57:13< zookeeper> and besides, it's not that different from the normal one anyway
20160331 06:57:56< fabi> What does glitchy mean?
20160331 06:59:30< zookeeper> that it has glitches? just look at it. disjointed convex/concave connections everywhere.
20160331 07:00:30< fabi> I can't look at it. It is gone.
20160331 07:01:06< fabi> I think that replacing a terrain with a complete different one (one that even has a different name) is not a good idea.
20160331 07:01:32< fabi> This is a kind of change that drives me mad.
20160331 07:10:22< vultraz> It drives you mad that we changed the look of a terrain??
20160331 07:11:21< fabi> yes
20160331 07:11:29< fabi> The new terrain is a complete different one.
20160331 07:11:43< fabi> And it also has a complete different name.
20160331 07:11:51< fabi> The old one is still a cave thing.
20160331 07:12:00< fabi> While the new one is a mine.
20160331 07:12:14< fabi> I need to overhaul my maps.
20160331 07:12:25< fabi> This kind of change produces work for umc designers.
20160331 07:13:15< fabi> It means that I would even need to change some dialogue.
20160331 07:15:10-!- Waste [~Cracker@blk-222-117-7.eastlink.ca] has quit [Quit: Leaving]
20160331 07:15:27< Soliton> is there a problem with putting the terrain in your addon?
20160331 07:20:43< zookeeper> i'm the last person to like removing stuff, but the hewn walls 1) looked horrible that no one ought to want to use them in the first place 2) were intended as placeholders for man/dwarf-made cave/mine walls in the first place
20160331 07:21:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160331 07:27:29-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 260 seconds]
20160331 07:35:27-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160331 07:43:52-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 07:44:06-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160331 07:49:03< fabi> zookeeper: Another issue. The new unit placed event. Maybe there is also a place for a unit removed event? One that fires no matte how and why a unit is removed from the field?
20160331 07:49:47< fabi> A third one: I have learned from a unit test that offmap coordinates in placed units makes them go to recall lists.
20160331 07:50:08< fabi> I think that is a bad thing. You can place them on recall lists deliberately with x,y=recall,recall.
20160331 07:50:26< fabi> Providing offmap coordinates should result in error message and fail.
20160331 07:57:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 08:01:27< Soliton> celticminstrel: https://github.com/wesnoth/wesnoth/commit/94d3d5aec66d79b4739eb5c3a6c53989e39e90d8 is bogus. [ "! ( -f $BinPath/wesnoth-debug -a -x $BinPath/wesnoth-debug )" ] is not a useful test. you're just giving it a (non-empty) string it's always going to be true.
20160331 08:02:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160331 08:03:16< Soliton> also testing for existence and executability is redundant. you may as well just test for executability. at least i assume that is what that test is supposed to mean.
20160331 08:04:54< Soliton> so to fix it i'd use: [ ! -x "$BinPath/wesnoth-debug" ]
20160331 08:05:19< zookeeper> fabi, yeah, a unit removed event might actually be a good thing
20160331 08:05:32< Soliton> (i don't think i can commit from here though.)
20160331 08:09:56-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160331 08:33:39-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 248 seconds]
20160331 08:47:53< zookeeper> gfgtdf, looks like your 7a8957e91 caused the starting locations breakage i mentioned. i reverted it locally and the problem disappeared.
20160331 08:50:49< zookeeper> (good thing that it was post-1.13.4)
20160331 08:50:50-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 09:01:18< Soliton> vultraz: https://github.com/wesnoth/wesnoth/commit/b98687147a864ced74a46b7d5dc02bd11c321af1 you really need that include in the header? i can't see anything in the header that could possible need it.
20160331 09:02:23< Soliton> vultraz: also for c++ it should be <cstdio> instead.
20160331 09:17:28-!- aquileia [5fd07d56@gateway/web/freenode/ip.95.208.125.86] has joined #wesnoth-dev
20160331 09:20:51< aquileia> celticministrel: Any particular reason to downgrade travis' gcc from 4.8.4 to 4.7.3? After all, we switched to the docker build to get Ubuntu Trusty with gcc 4.8...
20160331 09:22:35< Soliton> "Because in the ML post I said we'll be targeting 4.7, so this means that we can easily see if we accidentally add something that 4.7 doesn't support."
20160331 09:23:57< aquileia> Soliton: Thanks for the clarification
20160331 09:26:03< aquileia> I still think it's a regression, at lest I now know why
20160331 09:26:13< aquileia> *but
20160331 09:26:31< Soliton> can't you have several travis configs/builds?
20160331 09:28:01< aquileia> Yes, but my main point is that the apt-get install command frequently times out, ruining a build, and we explicitly switched to Trusty so we'd no longer have to get gcc that way
20160331 09:29:27< Soliton> and we can't have a build with whatever was before trusty? just several builds on trusty?
20160331 09:29:34< aquileia> We'll get a heap of false negatives to prevent a few false positives
20160331 09:30:00-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 276 seconds]
20160331 09:31:55< aquileia> We could in theory get separate docker environments for different OS, but docker only provides Trusty. The version before Trusty has gcc 4.6, so that's no option either
20160331 09:32:24< Soliton> ah, i see.
20160331 09:34:23< aquileia> By default you get 12.04 (with gcc 4.6) but as soon as you use docker it switches to 14.04 as that's the Ubuntu version the virtual machines are hosted on
20160331 09:36:23-!- aquileia [5fd07d56@gateway/web/freenode/ip.95.208.125.86] has quit [Quit: Page closed]
20160331 09:46:05-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160331 09:49:06-!- markus_ [~mjs-de@x4db53fea.dyn.telefonica.de] has joined #wesnoth-dev
20160331 10:05:05< vultraz> Soliton: It's needed for the implementation and only works if I include it before the header
20160331 10:05:13< vultraz> so I put it in the header
20160331 10:06:02< Soliton> that doesn't make any sense.
20160331 10:06:17< vultraz> I know
20160331 10:06:28< vultraz> It Works And I'm Not Questioning It
20160331 10:08:07< Soliton> do you think that way of solving problems is a good thing and helps wesnoth?
20160331 10:14:35< vultraz> No
20160331 10:14:39< vultraz> But do you have a better solution?
20160331 10:16:12< vultraz> Without that included before/in the header, it will tell me _wfreopen and _wrename aren't declared in that scope
20160331 10:16:49< Soliton> i don't have a solution since i don't know what's wrong. i would try different include orders to narrow the issue down though.
20160331 10:17:05< Soliton> different include orders in the cpp naturally.
20160331 10:17:44< Soliton> and i would actually move the cstdio include that is already there instead of adding a stdio.h include.
20160331 10:20:07< vultraz> that works, but again, only if included before the header
20160331 10:20:49< Soliton> then do that.
20160331 10:21:18< Soliton> better than polluting the header.
20160331 10:22:48< Soliton> also generally if you think you have no other way then to go with a solution you do not understand. make sure you document it properly! anyone (maybe your future self) looking for a proper solution later will need to know why you did what you did so they can properly fix it.
20160331 10:23:16< irker509> wesnoth: Charles Dang wesnoth:master 61cb45ac8c3b / src/ (log_windows.cpp log_windows.hpp): Fixup b98687147 https://github.com/wesnoth/wesnoth/commit/61cb45ac8c3b579bab41b47bf3ef21f2c54be57f
20160331 10:23:43< vultraz> thanks for pointing that out
20160331 10:24:02< Soliton> you're welcome.
20160331 10:24:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 10:28:44< Soliton> vultraz: http://sprunge.us/cdeP that should fix the build, btw. if you could commit that.
20160331 10:29:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160331 10:31:45-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160331 10:31:53< irker509> wesnoth: Charles Dang wesnoth:master 83dd965f9e2b / run_wml_tests: WML test fixup by Soliton https://github.com/wesnoth/wesnoth/commit/83dd965f9e2befffb853005c5f793138b3659063
20160331 10:32:24-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 246 seconds]
20160331 10:34:44-!- markus_ is now known as mjs-de
20160331 10:35:06-!- midzer [~quassel@p200300624E796C017994CA611A3D699B.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160331 10:36:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160331 10:40:32-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has quit [Remote host closed the connection]
20160331 10:48:03-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160331 10:59:24-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160331 11:10:36-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 11:10:37< travis-ci> wesnoth/wesnoth#9134 (master - 83dd965 : Charles Dang): The build has errored.
20160331 11:10:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119767578
20160331 11:10:37-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 11:13:22-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 11:13:23< travis-ci> wesnoth/wesnoth#9133 (master - 61cb45a : Charles Dang): The build has errored.
20160331 11:13:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119766104
20160331 11:13:23-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 11:20:09-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160331 11:22:47-!- AI0867_ [~ai@wesnoth/developer/ai0867] has joined #wesnoth-dev
20160331 11:22:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160331 11:22:50-!- AI0867 [~ai@wesnoth/developer/ai0867] has quit [Ping timeout: 244 seconds]
20160331 11:22:54-!- wedge010 is now known as wedge009
20160331 11:29:39-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 248 seconds]
20160331 11:41:47-!- Kwandulin [~Miranda@p200300760F191CBA6C642741F35113A0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160331 11:45:11-!- AI0867_ is now known as AI0867
20160331 11:47:19-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160331 12:05:28-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160331 12:08:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160331 12:08:36-!- wedge010 is now known as wedge009
20160331 12:33:53-!- Rhonda [~rhonda@anguilla.noreply.org] has quit [Changing host]
20160331 12:33:53-!- Rhonda [~rhonda@wesnoth/developer/rhonda] has joined #wesnoth-dev
20160331 12:59:24< irker509> wesnoth: Charles Dang wesnoth:master accbcd0466e9 / data/campaigns/Sceptre_of_Fire/_main.cfg: SoF: italicize description poem https://github.com/wesnoth/wesnoth/commit/accbcd0466e9902d99e60bcd11d9b7d011d70abb
20160331 13:05:15< vultraz> gfgtdf: can you fix the loadscreen showing up before the campaign dialog?
20160331 13:05:57-!- gfgtdf [~chatzilla@f054149045.adsl.alicedsl.de] has joined #wesnoth-dev
20160331 13:06:11< gfgtdf> vultraz: y i already hve a fix for that locally
20160331 13:06:15< vultraz> :D
20160331 13:10:11-!- Kwandulin [~Miranda@p200300760F191CFF857D91CAF749879B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160331 13:17:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160331 13:26:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160331 13:27:40< celticminstrel> Soliton: The reason I did -f and -x was because -x is also true if it it's a searchable directory.
20160331 13:30:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160331 13:31:17-!- travis-ci [~travis-ci@ec2-54-92-147-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 13:31:18< travis-ci> wesnoth/wesnoth#9135 (master - accbcd0 : Charles Dang): The build has errored.
20160331 13:31:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119795902
20160331 13:31:18-!- travis-ci [~travis-ci@ec2-54-92-147-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 13:32:43< celticminstrel> But maybe it's not really important to account for that case.
20160331 13:32:58< celticminstrel> vultraz: What's this about checkmarks? I can't find them.
20160331 13:42:03< vultraz> celticminstrel: Hotkeys
20160331 13:42:22< celticminstrel> Yes, I know that much. I can't find them.
20160331 13:42:38< celticminstrel> Where are they in the source?
20160331 13:42:53< vultraz> prefs dialog source file, at the beginning
20160331 13:43:05< vultraz> it's a label using the html code
20160331 13:43:10< celticminstrel> Oh, at the beginning.
20160331 13:45:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20160331 13:47:32< celticminstrel> Does anyone know how translatable strings are gathered from the C++ code?
20160331 13:47:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160331 13:49:18< vultraz> celticminstrel: I wonder if c++11 can do replace any uses of boost::tuple (std::tuple?) and boost::assign_list_of
20160331 13:49:41< vultraz> s/do//
20160331 13:51:23< mattsc> Starting test scenarios (except for the default one that only needs -t) is currently broken.
20160331 13:51:40< vultraz> how so?
20160331 13:52:05< mattsc> Give you a “file not found” to a bogus file name
20160331 13:52:12< mattsc> just try with ‘-t formula’
20160331 13:53:32< vultraz> works for me
20160331 13:53:59< celticminstrel> vultraz: assign::list_of could be replaced with initializer lists.
20160331 13:54:30< mattsc> Oh, who removed the space on OS X ???
20160331 13:54:41< celticminstrel> ?
20160331 13:54:43< mattsc> It works for me with ‘-tformula’ now.
20160331 13:55:00< celticminstrel> Hmm.
20160331 13:56:55< celticminstrel> Ooh! Unit tests reached link stage!
20160331 13:57:27< zookeeper> gfgtdf, <zookeeper> gfgtdf, looks like your 7a8957e91 caused the starting locations breakage i mentioned. i reverted it locally and the problem disappeared.
20160331 13:57:31< zookeeper> (in case you missed it)
20160331 13:58:03< celticminstrel> 200 linker errors though.
20160331 13:58:39< gfgtdf> zookeeper: yes i already assumed it was related, i just had no time to look at it becasue of the loadscreen thing. thx for veryfing it anyway.
20160331 14:08:55< Soliton> celticminstrel: using xgettext
20160331 14:09:22< celticminstrel> So do all strings need to be declared with _() or similar?
20160331 14:09:56< vultraz> celticminstrel: so something like
20160331 14:09:57< vultraz> static const std::set<std::string> allowed_tags = boost::assign::list_of("attack")("move")("recruit")("recall")("disband")("fire_event")("lua_ai");
20160331 14:09:59< vultraz> would become
20160331 14:10:00< vultraz> static const std::set<std::string> allowed_tags = {"attack", "move", "recruit", "recall", "disband", "fire_event", "lua_ai"}; ?
20160331 14:10:07< celticminstrel> vultraz: Yes.
20160331 14:10:49< Soliton> or similar, yes
20160331 14:12:09< celticminstrel> Hmm...
20160331 14:13:18< celticminstrel> Okay, so in the case of prefs, just making it non-static should work, I guess.
20160331 14:14:02< celticminstrel> And in the case of the loading screen... I'm still not sure...
20160331 14:14:40< celticminstrel> If there was a version of _() that returns a t_string instead of a string (ie, don't resolve the translation immediately), that would be helpful.
20160331 14:14:54< celticminstrel> I can construct a t_string that way, but I doubt xgettext would see it.
20160331 14:15:22< vultraz> well that does build
20160331 14:18:04< celticminstrel> I'm not yet seeing anything suspicious in the to_string commit...
20160331 14:20:42< celticminstrel> Ooh.
20160331 14:21:11< celticminstrel> vultraz: game_initialization/create_engine.cpp, line 1062 looks suspicious.
20160331 14:21:15< vultraz> celticminstrel: what about cases that use boost::assign::list_of().convert_to_container<>() ?
20160331 14:21:20< vultraz> celticminstrel: eh?
20160331 14:21:55< celticminstrel> I'm not sure on convert_to_container, but I suspect that's for when Boost wasn't able to correctly detect what type to return to, or something.
20160331 14:22:10< vultraz> hm
20160331 14:22:13< celticminstrel> vultraz: I'm not certain, but it looks like that's calling std::to_string on an enum.
20160331 14:22:25< vultraz> yes, it is
20160331 14:23:07< celticminstrel> See if that fixes the issue with scenarios not being listed in MP create.
20160331 14:23:13< vultraz> should probably be game_config_manager::get()->game_config().child_range(game_classification::CAMPAIGN_TYPE::enum_to_string(game_classification::CAMPAIGN_TYPE::MULTIPLAYER))
20160331 14:23:26< celticminstrel> Didn't need to paste the whole line. :P
20160331 14:23:40< vultraz> I wrote it in irc and will now copy it to my text editor :P
20160331 14:24:55< vultraz> random though
20160331 14:25:07< vultraz> MAKE_ENUM seems to emulate strictly-typed enums
20160331 14:25:24< celticminstrel> It does more than that, though.
20160331 14:25:32< vultraz> celticminstrel: does fix
20160331 14:25:38< celticminstrel> Yay.
20160331 14:25:45< vultraz> celticminstrel: please commit, I'm working on the assign::list_of conversion
20160331 14:25:56< celticminstrel> Okay.
20160331 14:26:31< vultraz> hmmm
20160331 14:26:33< vultraz> "boost::container::flat_set"
20160331 14:26:34< vultraz> what this
20160331 14:26:56< celticminstrel> I dunno, maybe an array used as a set.
20160331 14:27:55< gfgtdf> vultraz: that shodul just be .child_range("multiplayer")
20160331 14:28:04< vultraz> "flat_set is a Sorted Associative Container that stores objects of type Key. It is also a Unique Associative Container, meaning that no two elements are the same.
20160331 14:28:05< vultraz> flat_set is similar to std::set but it's implemented like an ordered vector. This means that inserting a new element into a flat_set invalidates previous iterators and references"
20160331 14:28:21< celticminstrel> In other words, exactly what I said.
20160331 14:28:36< celticminstrel> Might be faster for small sets.
20160331 14:28:48< vultraz> here it's used for a very big set
20160331 14:28:48< gfgtdf> celticminstrel: it is faster or iteration
20160331 14:28:57< celticminstrel> gfgtdf: Really?
20160331 14:29:22< gfgtdf> celticminstrel: well it mostlikeley both O(n) but yes.
20160331 14:29:30< celticminstrel> ...well, I suppose you could still do binary search on it, so I think both would be O(log n) or whatever...
20160331 14:29:34< gfgtdf> celticminstrel: becasue teh elements are less scattered in the mempry.
20160331 14:29:44< celticminstrel> Hmm, maybe.
20160331 14:30:02< celticminstrel> The flat set could be faster if paging happens.
20160331 14:31:00< celticminstrel> Oh, I was considering lookup when I said log, though.
20160331 14:31:09< celticminstrel> Obviously iteration is O(n).
20160331 14:31:14< celticminstrel> For anything.
20160331 14:31:25< celticminstrel> It can't be anything else.
20160331 14:31:33< celticminstrel> (Well, I suppose it could be worse in weird cases.)
20160331 14:33:46< vultraz> gfgtdf: do you know whether code that uses .to_container() can be converted to initializer lists?
20160331 14:33:58< vultraz> or convert_to_container
20160331 14:34:29< gfgtdf> vultraz: not sure. I doint think its important to move those to use inializer lists though.
20160331 14:34:53< vultraz> ok
20160331 14:35:04< vultraz> I'll just convert the plain list_of uses
20160331 14:35:09< celticminstrel> I think it probably can, but yeah, not important.
20160331 14:36:32< vultraz> celticminstrel: are you working on the loadscreen stage names?
20160331 14:36:47< celticminstrel> Not at the moment, but I was before I got distracted by unit tests.
20160331 14:36:59< vultraz> ok
20160331 14:37:00< celticminstrel> So I'll be going back to it.
20160331 14:37:09< celticminstrel> Unless of course someone else does something first...
20160331 14:37:13< vultraz> I was going to make the stage names better
20160331 14:38:49< celticminstrel> I was going to make them translatable.
20160331 14:39:12< vultraz> can you improve the text at the same time?
20160331 14:39:18< vultraz> ie 'load config' -> loading config
20160331 14:39:20< celticminstrel> Not sure.
20160331 14:39:27< celticminstrel> I might do so.
20160331 14:39:37< vultraz> and maybe clean up a few stages
20160331 14:39:42< celticminstrel> Hm?
20160331 14:39:46< vultraz> like, do we really need to keep the 'titlescreen' stage
20160331 14:39:48< vultraz> for example
20160331 14:39:52< celticminstrel> Good point, probably not.
20160331 14:43:44< mattsc> celticminstrel: btw, requiring ca_id= for deleting/changing MAIs won’t fix the bats problem, because currently the ca_id is automatically adjusted to match [data][micro_ai]ai_id=
20160331 14:44:29< mattsc> The only way I see around that at the moment that will work in all cases is to add both ca_id and ai_id to the CA cfg
20160331 14:44:48< mattsc> Which, most of the time, will be identical, but sometimes they won’t.
20160331 14:48:23< celticminstrel> ai_id is adjusted to avoid conflicts, right?.
20160331 14:48:50< mattsc> Yes; so that old information stored in [data] will not be used for a new MAI.
20160331 14:49:05< celticminstrel> Is ca_id not adjusted as well?
20160331 14:49:14< mattsc> Yes, it is, and that’s the problem.
20160331 14:49:19< celticminstrel> Hmm.
20160331 14:49:32< celticminstrel> Okay, why exactly are there two IDs?
20160331 14:49:45< mattsc> Because then the delete action might not know what the id of the CA to be removed is.
20160331 14:50:13< celticminstrel> I thought the CA ID was generated from the AI ID by appending a fixed suffix.
20160331 14:50:14< mattsc> One identifies the AI as a whole, and then you need one for each CA to be removed.
20160331 14:50:20< mattsc> Yes.
20160331 14:50:38< mattsc> The ca_id= key in [micro_ai] should really be called ai_id=
20160331 14:51:00< mattsc> But it used to be called ca_id= and changing that would break backward compatibility for everything.
20160331 14:51:05< mattsc> So I left it as it was.
20160331 14:51:23< celticminstrel> Okay, so... the ca_id is adjusted to avoid conflicts, but why is that necessary if the ai_id on which it was based is also adjusted?
20160331 14:51:40< mattsc> No, it’s the other way around.
20160331 14:51:56< mattsc> The ai_id is adjusted to avoid conflicts when reading stored data.
20160331 14:52:18< mattsc> In order to have only one parameter, the ca_id is adjusted accordingly.
20160331 14:52:35< mattsc> Let’s explain the problem with the bats example.  Let’s assume they have ca_id=bats
20160331 14:52:37< celticminstrel> Huh? One parameter?
20160331 14:52:54< mattsc> sorry?
20160331 14:53:04< celticminstrel> No, keep going for now...
20160331 14:53:24< mattsc> Btw, I have to go in 7 minutes at the latest, just FYI.
20160331 14:53:25< irker509> wesnoth: Charles Dang wesnoth:master a0ffdff8120f / src/ (17 files in 9 dirs): Convert plain usecases of boost::assign::list_of() to initializer lists https://github.com/wesnoth/wesnoth/commit/a0ffdff8120fe7b2e6475cf7fad3a8d94ab9fb91
20160331 14:53:36< celticminstrel> You were explaining bats.
20160331 14:53:57< mattsc> So, first time the AI is changed, it looks for id=bats in [data], which exist -> bot ai_id and the ids of the CAs are changed to bats
20160331 14:54:04< mattsc> *changed to bats1
20160331 14:54:13< mattsc> (hit return to quickly there)
20160331 14:54:35< celticminstrel> The id of the CA thus becomes bats1_goto, right?
20160331 14:54:57< mattsc> well, plus some suffix, yes
20160331 14:55:05< mattsc> (well, maybe not for goto)
20160331 14:55:39< mattsc> So next time, it tries to remove bats_goto again, which does not exist, because now it’s bats1_goto.
20160331 14:56:25< mattsc> When adding the new CAs, the now get added as bats2_goto, which is fine, just that bats1_goto still exists and takes preference (they have the same score)
20160331 14:57:14< celticminstrel> I think I sort of understand the issue...
20160331 14:57:31< vultraz> celticminstrel: I can commit that mp fix
20160331 14:57:31< mattsc> The problem is, how do I distinguish between that case, and one when I introduced both bats and bats1 intentiuonally.
20160331 14:57:36< vultraz> since you haven't
20160331 14:57:47< celticminstrel> vultraz: Sure, but perhaps the way gfgtdf suggested is better.
20160331 14:57:52< vultraz> indeed
20160331 14:58:24< mattsc> So, I might need a separate ai_id= to identify data stored in [data], and ca_id to indentify the CAs to be removed.
20160331 14:58:45< mattsc> This is internally only, it is not needed in the [micro_ai] tag.
20160331 14:58:45< celticminstrel> Separate in the [micro_ai] tag or...?
20160331 14:58:57< celticminstrel> So internally where?
20160331 14:59:10< mattsc> I believe it needs to be in the CA’s ‘cfg’ table.
20160331 14:59:20< celticminstrel> Oh, right, the [args].
20160331 14:59:22< mattsc> I haven’t thought it through yet though, and now I need to go.
20160331 14:59:26< celticminstrel> Okay.
20160331 14:59:37< mattsc> If you come up with a better solution, let me know.
20160331 14:59:50< mattsc> I’ll likely sleep over this for one night before actually doing something about it.
20160331 14:59:58< mattsc> Bye for now.
20160331 15:00:03< celticminstrel> I'll try to think about it too.
20160331 15:00:06< celticminstrel> Bye.
20160331 15:00:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160331 15:00:37< irker509> wesnoth: Charles Dang wesnoth:master 0936066bf3e6 / src/game_initialization/create_engine.cpp: Fixed initializing of mp scenarios https://github.com/wesnoth/wesnoth/commit/0936066bf3e670afad845cc0b9c96cd122505d0f
20160331 15:00:43< vultraz> celticminstrel: ^
20160331 15:04:02-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160331 15:08:52-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160331 15:12:01< vultraz> hm
20160331 15:12:16< vultraz> the lobby text box is growing..
20160331 15:12:25< vultraz> why
20160331 15:14:14< vultraz> I'll look at that sometime later
20160331 15:14:19< vultraz> let's see..
20160331 15:14:45< vultraz> boost::tuple cannot be converted easily to std::tuple, not doing anything there..
20160331 15:14:49< vultraz> just range-for left, I think
20160331 15:14:54< celticminstrel> Which I'm doing.
20160331 15:15:03< vultraz> oh yeah, I wanted to convert atoi
20160331 15:15:14< vultraz> I guess I need to use try/catch
20160331 15:15:32< celticminstrel> How often is it used?
20160331 15:15:47< vultraz> 93 times
20160331 15:15:54< celticminstrel> Oh, wow.
20160331 15:19:03-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 276 seconds]
20160331 15:20:58< celticminstrel> I wonder if any translations have issues with "Back to Turn N".
20160331 15:21:22< celticminstrel> I won't bother fixing it if no-one does, but I feel it should probably use vgettext.
20160331 15:24:04< vultraz> been working on this for a day or two
20160331 15:24:10< vultraz> minimal scrollbars v 2.0 https://drive.google.com/file/d/0B-mR9s8FduLLTjA0TlV4MXo3TGs/view?usp=sharing
20160331 15:24:26< celticminstrel> I can't click right now because Firefox is hanging.
20160331 15:24:40< vultraz> blah :P
20160331 15:24:55< celticminstrel> Uh, why am I getting quicklook...
20160331 15:25:12< celticminstrel> Huh, SourceTree supports quicklook. I did not know this.
20160331 15:25:23< vultraz> so you can see it?
20160331 15:25:25-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160331 15:25:32< celticminstrel> No, that was for something else.
20160331 15:25:37< vultraz> ah
20160331 15:26:39< vultraz> anyway, the minimal scrollbars look a lot better, I think
20160331 15:26:46< vultraz> and improve the aesthetic of the lobby
20160331 15:26:53< celticminstrel> I won't take your word for this.
20160331 15:27:40< celticminstrel> vultraz: The MP issue also exists in a unit test - test_mp_connect.cpp, line 85.
20160331 15:29:22< celticminstrel> units/frame.cpp:273 looks suspicious, but that may actually be a numeric constant...
20160331 15:29:32< celticminstrel> Ah, wait, it's subtracting it, so it must be numeric.
20160331 15:30:05< irker509> wesnoth: Charles Dang wesnoth:master f6452a3dd63a / src/tests/test_mp_connect.cpp: Small test fixup (same as 0936066bf3e6) https://github.com/wesnoth/wesnoth/commit/f6452a3dd63adecff28dd0e627a34cd2ec0cd77c
20160331 15:30:39< celticminstrel> ...why is there an ALIGNMENT_FEMALE_VARIATION type? o.o 
20160331 15:30:55< vultraz> who knows
20160331 15:31:11< celticminstrel> Oh, that's the end of the diff. Yay.
20160331 15:31:36< vultraz> celticminstrel: do I need to do something with unit/frame.cpp:273?
20160331 15:31:39< gfgtdf> vultraz: i see you sometimes used 'unit_type::ALIGNMENT::enum_to_string(u_.alignment())'
20160331 15:31:57< gfgtdf> vultraz: mostzlikeley this shoudl rather be u_.alignment().to_string()
20160331 15:32:03< celticminstrel> vultraz: I don't think so, but if you want you could double-check that those are numeric constants.
20160331 15:32:15< vultraz> gfgtdf: oh I didn't realize I could do that
20160331 15:32:17< vultraz> will fix
20160331 15:32:29< celticminstrel> gfgtdf: Does that apply to all cases of enum_to_string?
20160331 15:32:48< vultraz> celticminstrel: it's an enum member
20160331 15:33:13< celticminstrel> I know, but both exist, so maybe both have good reasons to be used.
20160331 15:33:41< celticminstrel> But maybe not, so I'm asking.
20160331 15:34:09< gfgtdf> celticminstrel: hmm, well the problem is that when you have MAKE_ENUM(T, (A, "a")(B, "b")) than T::A will be of type T::type  rather than T, to you unfortulateley cannot use T::A.to_string()
20160331 15:34:39< gfgtdf> celticminstrel: but when you have an object of type T you can always use to_string
20160331 15:34:52< celticminstrel> So enum_to_string is intended for when you're using a "literal" value.
20160331 15:36:00< gfgtdf> celticminstrel: ALIGNMENT_FEMALE_VARIATION is for translations
20160331 15:36:27< celticminstrel> I understand that, more or less, but why would you make a separate enum for it...
20160331 15:38:29< irker509> wesnoth: Celtic Minstrel wesnoth:master 4024e673f765 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: Make checkmark translatable https://github.com/wesnoth/wesnoth/commit/4024e673f7655afbe0cdb330697b756427b51678
20160331 15:38:38< vultraz> whut
20160331 15:38:45< vultraz> it's a checkmark :|
20160331 15:38:53< celticminstrel> Like ancestral said, checkmarks mean "no" in some places.
20160331 15:39:06< ancestral> celticminstrel: So actually
20160331 15:39:13< ancestral> Say, in Japan
20160331 15:39:14< celticminstrel> Well, not "no" precisely, but still sort of opposite to what we think of it as.
20160331 15:39:20< celticminstrel> Yes, I know.
20160331 15:39:20< ancestral> O means yes and X means no
20160331 15:39:25< ancestral> Check marks don’t exist
20160331 15:39:31< ancestral> They haven’t been invented yet ;-)
20160331 15:39:46< celticminstrel> I thought they used checkmarks for incorrect answers.
20160331 15:39:53< vultraz> I've seen O mean no
20160331 15:39:56< vultraz> and nothing for yes
20160331 15:40:16< gfgtdf> celticminstrel	: well it coudl also be done differently, but since thats just an implementation detail of units/types.cpp i wouldn't bother.
20160331 15:40:17< celticminstrel> So yeah, basically, the meaning of a checkmark is not universal. :)
20160331 15:41:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 15:41:24< ancestral> My personal opinion? Put a solid circle or square on a check box to indicate it’s on
20160331 15:41:53< celticminstrel> I'm used to square meaning "partially on".
20160331 15:41:59< irker509> wesnoth: Charles Dang wesnoth:master a0a8836bbe35 / src/ (6 files in 4 dirs): Used to_string() method instead of enum::enum_to_string() when possible https://github.com/wesnoth/wesnoth/commit/a0a8836bbe35ece3c2b310f85df3d04417c81986
20160331 15:42:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160331 15:42:10< ancestral> I’ve seen a dash on a box mean partially on too
20160331 15:42:11< celticminstrel> Which is also sometimes done with a hyphen.
20160331 15:42:13< vultraz> gfgtdf: ^
20160331 15:42:15< celticminstrel> Yes.
20160331 15:42:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 15:42:19< ancestral> Also, I would rely on LordBob for more awesome check boxes
20160331 15:42:54< ancestral> Maybe stop by his house, buy him dinner
20160331 15:43:00< celticminstrel> What. XD
20160331 15:43:04< ancestral> vultraz: You’d have an excuse to go to France
20160331 15:43:08< ancestral> France, right?
20160331 15:43:13< vultraz> Yes
20160331 15:43:16< celticminstrel> He's French?
20160331 15:43:21< ancestral> celticminstrel: Hey, vultraz is on a mission here!
20160331 15:43:27< ancestral> He’s the new sherrif in town!
20160331 15:43:36< vultraz> Bordeaux, IIRC.
20160331 15:43:41< ancestral> He’ll do whatever it takes
20160331 15:43:45< vultraz> :P
20160331 15:43:56< ancestral> And if that means a vacation… er, business trip…
20160331 15:44:00< vultraz> I'd happily go to France just for the bread 
20160331 15:44:09< ancestral> and WINE, sir
20160331 15:44:16< celticminstrel> Cheese.
20160331 15:44:20< celticminstrel> Don't forget the cheese.
20160331 15:44:22< ancestral> Mmm, cheese
20160331 15:44:37< vultraz> Oui oui
20160331 15:46:04< vultraz> I've been to France three times, don't think I had any cheese...
20160331 15:46:44< ancestral> Wow okay
20160331 15:46:51< ancestral> I’ve been 0 times
20160331 15:46:58< celticminstrel> I've been... twice, I think?
20160331 15:47:06< celticminstrel> Maybe three times.
20160331 15:47:11-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 15:47:12< travis-ci> wesnoth/wesnoth#9137 (master - 0936066 : Charles Dang): The build has errored.
20160331 15:47:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119828167
20160331 15:47:12-!- travis-ci [~travis-ci@ec2-54-196-34-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 15:47:19< ancestral> I guess you guys are just cooler than I am
20160331 15:47:51< celticminstrel> Once for Disneyland, once for Asterix, and not sure if there was another.
20160331 15:48:26< ancestral> Airport layover, perhaps?
20160331 15:48:36< celticminstrel> No, that's Belgium.
20160331 15:48:48< celticminstrel> Though that was more of a train station layover, but still.
20160331 15:48:56-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 15:48:57< travis-ci> wesnoth/wesnoth#9136 (master - a0ffdff : Charles Dang): The build has errored.
20160331 15:48:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119826354
20160331 15:48:57-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 15:49:03< celticminstrel> On the way back from Germany, because the flight was cancelled or something.
20160331 15:50:00< vultraz> Paris all three times for me, two of the times also down to a small down in southwestern France for a cultural festival thing (though one was just to arrange some matters from a group from the FSM)
20160331 15:50:13< celticminstrel> A small down, or a small town?
20160331 15:50:24< vultraz> derp
20160331 15:50:25< vultraz> town
20160331 15:50:25< celticminstrel> And why were you meeting the flying spaghetti monster?
20160331 15:50:33< vultraz> xD
20160331 15:52:04< vultraz> that was in 2014, then went again last summer.
20160331 15:52:31< vultraz> https://www.dropbox.com/s/efuih6iuzt3g5e3/IMG_1135.JPG?dl=0
20160331 15:52:48< celticminstrel> Oh right, Firefox stopped hanging and I forgot to click that.
20160331 15:53:17< celticminstrel> I dislike it. There are no arrows.
20160331 15:53:24< vultraz> the scrollbar?
20160331 15:53:29< celticminstrel> Yes.
20160331 15:53:33< celticminstrel> It needs arrows.
20160331 15:53:38< celticminstrel> I don't mind it being narrower.
20160331 15:53:41< celticminstrel> But it needs arrows.
20160331 15:53:53< vultraz> hm
20160331 15:54:03< vultraz> will need narrow arrows
20160331 15:54:21< vultraz> let's see what we have..
20160331 15:54:39< celticminstrel> Maybe make them non-square.
20160331 15:54:59< celticminstrel> ie, the up/down could be a little higher than wide, and the left/right a little wider than high.
20160331 15:55:16-!- mjs-de [~mjs-de@x4db53fea.dyn.telefonica.de] has quit [Remote host closed the connection]
20160331 15:55:18< celticminstrel> Like maybe a 2:3 ratio or something.
20160331 15:55:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160331 15:55:37< vultraz> perfect, the arrows can be cropped to 15 px exactly 
20160331 15:56:15< vultraz> (btw, that link above wasn't the arrows, it's a shot of me in Paris last summer :P The arrows are in Drive)
20160331 15:56:23< vultraz> (s/arrows/scrollbar)
20160331 15:56:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160331 15:57:33< celticminstrel> I assumed as much, but I wasn't planning on clicking it anyway.
20160331 15:57:46< celticminstrel> You've been more recently than I have.
20160331 15:58:17< celticminstrel> It might've actually been pre-2000...
20160331 15:58:21< vultraz> O_O
20160331 15:58:21< celticminstrel> Or in 2000...
20160331 15:58:46< celticminstrel> Oh, wait, it was probably more like somewhere in 2001-2003
20160331 15:58:58< celticminstrel> Still, several years ago.
20160331 16:03:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160331 16:08:39-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160331 16:11:03-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 16:11:04< travis-ci> wesnoth/wesnoth#9138 (master - f6452a3 : Charles Dang): The build has errored.
20160331 16:11:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119836094
20160331 16:11:04-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 16:11:27-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 244 seconds]
20160331 16:11:32< vultraz> celticminstrel: https://drive.google.com/file/d/0B-mR9s8FduLLR3BTX0VZcTkyaWc/view?usp=sharing
20160331 16:12:00< celticminstrel> Not bad! What did you think about the idea of non-square arrows, though?
20160331 16:12:37< vultraz> don't really like it
20160331 16:13:29< celticminstrel> I think it might be improved by a boundary between bar and arrow.
20160331 16:13:57< vultraz> most scrollbars don't have such a thing
20160331 16:14:20< celticminstrel> That doesn't mean it's a bad idea.
20160331 16:14:33< celticminstrel> I guess it's not necessary, though.
20160331 16:14:35< vultraz> I think it'd interrupt the background
20160331 16:14:42< celticminstrel> That's kinda the point.
20160331 16:15:44-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 16:15:45< travis-ci> wesnoth/wesnoth#9139 (master - 4024e67 : Celtic Minstrel): The build has errored.
20160331 16:15:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119838365
20160331 16:15:45-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 16:16:01< vultraz> ehhh
20160331 16:16:03< vultraz> nah
20160331 16:16:21< celticminstrel> Well, I don't feel very strongly about it, so whatever.
20160331 16:16:32< celticminstrel> I do think it would be a minor improvement.
20160331 16:17:00< vultraz> do you think i should commit this as new standard scrollbar
20160331 16:17:12< vultraz> (as soon as I replicate my work with horizontal bars, that is)
20160331 16:17:32< celticminstrel> Maybe wait until one or two more people give opinions? I'm personally okay with it, though.
20160331 16:22:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160331 16:22:04< vultraz> zookeeper: opinions on scrollbar design above?
20160331 16:23:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160331 16:23:36< zookeeper> current ones seem better
20160331 16:28:14-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 16:28:15< travis-ci> wesnoth/wesnoth#9140 (master - a0a8836 : Charles Dang): The build has errored.
20160331 16:28:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119839072
20160331 16:28:15-!- travis-ci [~travis-ci@ec2-54-147-169-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 16:39:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160331 16:39:16-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160331 16:41:09-!- Kwandulin [~Miranda@p200300760F191CFF857D91CAF749879B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160331 16:43:25-!- gfgtdf [~chatzilla@f054149045.adsl.alicedsl.de] has quit [Ping timeout: 252 seconds]
20160331 16:53:44-!- midzer [~quassel@p5B29692F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160331 16:53:52< celticminstrel> "use of undeclared identifier list_of"
20160331 16:54:47< vultraz> ehh?
20160331 16:55:05< celticminstrel> In test_filesystem.cpp
20160331 16:55:19< vultraz> blah
20160331 16:55:27< vultraz> readd the boost include
20160331 16:55:39< celticminstrel> You're asking me to fix it?
20160331 16:56:11< vultraz> yes
20160331 16:56:16< celticminstrel> 'kay
20160331 16:56:22< vultraz> I don't build the tests, so you can confirm it fixes it
20160331 16:56:39< celticminstrel> I normally don't either, but it's what I'm working on right now.
20160331 16:58:40< celticminstrel> Hmm, might as well switch it to an initializer list instead.
20160331 16:58:59< vultraz> I thought I converted all the cases that could be initializer lists..
20160331 17:00:43< celticminstrel> Why is it hanging again? All I did was add a brace or two...
20160331 17:01:05< celticminstrel> Oh, it's back now.
20160331 17:02:08< celticminstrel> Oh, Time Machine is still running. That might be part of why.
20160331 17:10:16< celticminstrel> BTW vultraz, did you fix the prefs persistence issue yet?
20160331 17:10:45< vultraz> no
20160331 17:17:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 17:18:49< vultraz> celticminstrel: random experiment: procedurally drawn buttons https://drive.google.com/file/d/0B-mR9s8FduLLZ2lqTmphRkxBMTA/view?usp=sharing
20160331 17:19:23< celticminstrel> Conceptually a good idea, since that means buttons can be any size...
20160331 17:20:39< celticminstrel> Doesn't look bad, but I feel like it's missing some shadow relative to the non-procedural ones.
20160331 17:20:40 * celticminstrel pokes zookeeper for additional opinion.
20160331 17:20:40< celticminstrel> Also, are the basic buttons perfect rectangles, or slightly rounded?
20160331 17:20:58< celticminstrel> I mean the non-procedural ones.
20160331 17:21:21< vultraz> slightly rounded at corners
20160331 17:21:37-!- Kwandulin [~Miranda@p200300760F191CFFB8C22CB0D621DBB9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160331 17:21:57< celticminstrel> So if we're really going to go with procedural buttons, we should add rounded rectangles.
20160331 17:22:26< celticminstrel> Hmm, gui::menu... where's that...
20160331 17:22:26< vultraz> I *think* know how I could do it
20160331 17:22:33< vultraz> widgets/menu
20160331 17:22:41< vultraz> src/widgets, not src/gui/widgets
20160331 17:22:50< celticminstrel> Yeah I know that's what you meant.
20160331 17:23:09< celticminstrel> I thought I already added the widgets...
20160331 17:23:18< celticminstrel> The GUI1 widgets I mean.
20160331 17:24:11< celticminstrel> Maybe I just missed that one.
20160331 17:24:19< zookeeper> why would you need to draw them procedurally? you can draw them based on bitmaps at any size, if you want to.
20160331 17:24:35< celticminstrel> I wonder which is actually faster...
20160331 17:24:54< vultraz> zookeeper: scaling
20160331 17:24:59< vultraz> the images are nice
20160331 17:25:02< vultraz> but look ugly scaled
20160331 17:25:08< zookeeper> not by scaling obviously
20160331 17:27:37< zookeeper> have two images, top left corner (includes top edge and left edge) and bottom right corner (includes bottom edge and right edge) which are reeeeeeally big, and then draw a button of arbitrary size by cropping them to the right size, and then filling the center.
20160331 17:28:29< celticminstrel> My only concern with that would be whether the top right and bottom left corners would look good...
20160331 17:28:30< vultraz> We do not have such an image
20160331 17:28:38< vultraz> Plus, it's not just size
20160331 17:28:40< vultraz> it's resolution
20160331 17:28:58< zookeeper> celticminstrel, they would because the images would be made with that in mind.
20160331 17:28:58< vultraz> I tried using the @2x images and scale them down to our current 'normal' size and it looks normal
20160331 17:29:16< vultraz> so if you draw a really big image... it still wouldn't look great at other resolutions
20160331 17:30:50< irker509> wesnoth: Celtic Minstrel wesnoth:master c8a71438ac2a / src/tests/ (test_commandline_options.cpp test_filesystem.cpp): Fix unit tests https://github.com/wesnoth/wesnoth/commit/c8a71438ac2a83597fae9d17e1597421980c5f87
20160331 17:32:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 17:33:54< zookeeper> what's this about resolutions? what would you do, if not draw images at their native size?
20160331 17:34:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160331 17:34:45-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 17:35:48< vultraz> retina?
20160331 17:35:57< zookeeper> what kind of question is that?
20160331 17:36:02< zookeeper> just say what you mean
20160331 17:36:24< vultraz> the @2x images we have are meant for eventual retina support
20160331 17:36:32< zookeeper> celticminstrel, oh, right, top right and bottom left. yeah, i guess instead you'd just need to have one image and cut away the centers of each edge instead.
20160331 17:36:35< vultraz> meaning they'll be drawn at 108x22 but their resolution is twice that
20160331 17:36:48< vultraz> however, they don't look good at that size
20160331 17:36:49< celticminstrel> Ah, yeah, that could work.
20160331 17:37:16< vultraz> I don't know if you could create a master image, because for things like retina displays, each element needs 2x the detail
20160331 17:37:37< celticminstrel> vultraz: You could still use separate images for normal and retina with zookeeper's proposal.
20160331 17:37:55< vultraz> we could
20160331 17:37:59< vultraz> I'd have to talk to lb
20160331 17:38:02< zookeeper> or scale them up with xbrzwhatever which ought to produce a decent result
20160331 17:38:17< celticminstrel> Maybe.
20160331 17:38:19< vultraz> right now im taking a break since ive been staring extremely hard at my screen trying to see pixel details 
20160331 17:38:22< vultraz> and my eyes hurt
20160331 17:39:10-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160331 17:39:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 17:41:16< zookeeper> also i hope that you're not taking us into a situation where you get lordbob to make us all sorts of fancy things to suit your designs, and then that gets used as an argument for said designs ("lordbob worked a lot for it, we can't throw it away" etc etc)
20160331 17:45:05< vultraz> ...what?
20160331 17:45:21< vultraz> the point of procedural drawing is that we wouldn't need the fancy art 
20160331 17:46:41< zookeeper> right
20160331 17:47:46< vultraz> The past few weeks I've actually removed a bunch of uses of image assets in favor of procedural drawing
20160331 17:48:03< celticminstrel> Have you removed the images themselves?
20160331 17:48:08< zookeeper> i don't have anything against procedural drawing as such, since our UI elements are relatively simple
20160331 17:48:19< vultraz> celticminstrel: no
20160331 17:48:39< celticminstrel> BTW, should I try implementing a round rectangle in [draw]?
20160331 17:48:53< celticminstrel> Should be fairly simple. I've done this before, kinda.
20160331 17:49:03< vultraz> https://drive.google.com/file/d/0B-mR9s8FduLLQTlmc21sTS1pTGc/view?usp=sharing
20160331 17:49:20-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160331 17:50:16< celticminstrel> Or just add corner_radius to [rectangle], but I think a new shape might be the better option.
20160331 17:53:37< vultraz> technically I can get a rounded button edge by doing this
20160331 17:53:54< vultraz> x1 = 0 y1 = 0 x2 = 0 y2 = 0 thickness = 1 color = "0, 0, 0, 0"
20160331 17:54:04< vultraz> on all four corners
20160331 17:54:15-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Quit: Konversation terminated!]
20160331 17:54:19< celticminstrel> Huh?
20160331 17:54:46< vultraz> hack using [line] for one pixel since [point] isn't a thing
20160331 17:54:51< vultraz> and set alpha to transparent
20160331 17:55:06< zookeeper> yeah, the corners should be rounded, and also the fill be that subtle gradient instead of a single flat color makes a pretty big difference
20160331 17:55:43 * zookeeper doesn't know what sentence he was forming first and foremost
20160331 17:55:58< vultraz> I have no idea what you just said
20160331 17:56:02< celticminstrel> Okay, but how does that round out the corners?
20160331 17:56:04< zookeeper> i'll retry
20160331 17:56:19< celticminstrel> You need to remove a pixel to round the corners.
20160331 17:56:21< celticminstrel> Not add one.
20160331 17:56:41< vultraz> the way the canvas works is not by layering
20160331 17:56:41< zookeeper> also it makes a pretty big difference whether the button is filled by that subtle blue gradient or a single flat color
20160331 17:56:45< celticminstrel> That version looks better with respect to the shadows, I think.
20160331 17:56:57< vultraz> it's a pixel grid and each successive operation sets a pixel's color value
20160331 17:57:05< celticminstrel> Well duh.
20160331 17:57:15< vultraz> so if i set it to transparent
20160331 17:57:18< vultraz> the pixel disappears
20160331 17:57:28< celticminstrel> Ohh, okay, that makes sense then.
20160331 17:58:18< celticminstrel> I accidentally just clicked "Skip This Version" in the Java popup...
20160331 17:58:25< vultraz> I do wish we had [point] for this
20160331 17:58:38< vultraz> celticminstrel: it'd be nice if you could implement gradient colors
20160331 17:58:43< celticminstrel> I could look at adding that, too.
20160331 17:59:01< celticminstrel> Both of them, even. Though gradients are not easy, probably. (I've never tried it, admittedly.).
20160331 17:59:42< vultraz> celticminstrel: https://drive.google.com/file/d/0B-mR9s8FduLLUV9ZRkp2LWI4aFU/view?usp=sharing
20160331 17:59:44< vultraz> rounded corners
20160331 18:01:37< celticminstrel> I'm a little dubious about it...
20160331 18:01:39< zookeeper> well, it doesn't look as rounded as the old buttons because the shading is more blocky, but in either case, might want to try one step bigger rounding
20160331 18:01:45< celticminstrel> I need to compare it to the old ones.
20160331 18:02:14-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160331 18:04:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160331 18:04:37< zookeeper> so considering that the button outlines consist of 1px thin lines, is that not they'd be drawn on retina too..?
20160331 18:04:49< zookeeper> "is that not how they'd"
20160331 18:08:33< zookeeper> like, it doesn't look any better if you draw a 1px procedural line than if you draw a 1px bitmap-based line, and so far i don't see you having said anything that'd imply that you're going to draw the lines any differently on retina.
20160331 18:08:50-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160331 18:10:05< celticminstrel> On retina everything needs to be twice as large in order to appear the same size.
20160331 18:10:11< celticminstrel> If I understand correctly.
20160331 18:10:28< celticminstrel> So I guess there'd be a retina version of the button with a 2px line.
20160331 18:12:54-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160331 18:13:42< vultraz> celticminstrel: if you add gradients, please do it for both [rectangle] and [line] and make it consider alpha
20160331 18:14:01< celticminstrel> What do you mean by "consider alpha"?
20160331 18:16:33-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 240 seconds]
20160331 18:17:10< zookeeper> celticminstrel, yeah, and if you have to make retina versions of every procedurally drawn element too, then drawing them procedurally doesn't really have any benefits vs drawing them with images and supplying two sets of images, does it? well, maybe a little bit.
20160331 18:17:58< celticminstrel> Well, either way you need two [resolution] tags in the widget definition.
20160331 18:18:11< celticminstrel> With non-procedural images you also need two image files.
20160331 18:19:36-!- travis-ci [~travis-ci@ec2-54-92-147-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 18:19:37< travis-ci> wesnoth/wesnoth#9141 (master - c8a7143 : Celtic Minstrel): The build has errored.
20160331 18:19:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119868448
20160331 18:19:37-!- travis-ci [~travis-ci@ec2-54-92-147-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 18:19:46< irker509> wesnoth: gfgtdf wesnoth:master 5d9e211b349a / src/game_config_manager.cpp: fix loadscreen always showing before campaigns menu. https://github.com/wesnoth/wesnoth/commit/5d9e211b349a8309e0176de4bea0811452749da5
20160331 18:19:48< irker509> wesnoth: gfgtdf wesnoth:master c01e5e8a39e0 / src/map/map.cpp: fix starting positions in gamemap::write() https://github.com/wesnoth/wesnoth/commit/c01e5e8a39e0efe2dfab8aec2346854cabe65924
20160331 18:19:55-!- gfgtdf [~chatzilla@f054149045.adsl.alicedsl.de] has joined #wesnoth-dev
20160331 18:20:01< gfgtdf> vultraz, zookeeper ^
20160331 18:20:10< zookeeper> great
20160331 18:21:01-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160331 18:21:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Disconnected by services]
20160331 18:21:03-!- celmin is now known as celticminstrel
20160331 18:21:51< fendrin> Hello
20160331 18:22:24< vultraz> gfgtdf: ty
20160331 18:23:00< vultraz> zookeeper: the main benefit is the lack of bad scaling and that we can then have them at any size
20160331 18:24:43< celticminstrel> Hi.
20160331 18:27:02< celticminstrel> Whoa, unit tests segfaulted?
20160331 18:27:14< celticminstrel> I guess I'll be able to fix that once I've got them to build in XCode.
20160331 18:35:08< fendrin> celticminstrel: Do you know how long Wesnoth takes to execute the wml test scenario suit?
20160331 18:40:27< zookeeper> vultraz, well as said you could have the same with images too. i'm not saying it'd be any simpler or better, though.
20160331 18:47:20< celticminstrel> fendrin: For me it takes quite awhile, maybe half an hour? I haven't recently run the whole thing though.
20160331 18:47:29< fendrin> half an hour?
20160331 18:47:44< celticminstrel> Not sure.
20160331 18:48:33< fendrin> That is magnitudes longer than I expected.
20160331 18:49:44< celticminstrel> There are 158 tests, so with a timeout of 10s (which is too short for my system - I usually set it to 30s) that means at least fifteen minutes in the worst case.
20160331 18:49:52< celticminstrel> (Worst case being that all tests fail to terminate.)
20160331 18:50:10< celticminstrel> Sixteen minutes, I guess - rounding up.
20160331 18:50:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160331 18:51:50< fendrin> 158 tests in data/test/scenarios ?
20160331 18:52:00< celticminstrel> (I counted the tests with "grep -v '#' wml_test_schedule | wc".)
20160331 18:52:26< celticminstrel> Many of the files in data/test/scenarios define multiple related tests.
20160331 18:53:52< celticminstrel> Hmm, down to 44 link errors. That must mean I'm almost finished.
20160331 18:56:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160331 19:00:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 19:03:11< celticminstrel> Does anyone know the purpose of src/tests/create_images.cpp?
20160331 19:06:09< zookeeper> doesn't it say?
20160331 19:06:29-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160331 19:06:33< celticminstrel> Maybe. I'll look at it more closely once I've gotten tests to build and work.
20160331 19:06:59-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has joined #wesnoth-dev
20160331 19:08:49< ScegfOd> anyone there?
20160331 19:09:09< celticminstrel> Maybe.
20160331 19:09:14< ScegfOd> xD
20160331 19:09:24< ScegfOd> I was looking at the easycoding page on the wesnoth website and I figured I could do the "Make a GUI method to activate loggers" thing
20160331 19:09:30< celticminstrel> Ooh.
20160331 19:09:35< ScegfOd> should I just fork it and start poking around?
20160331 19:09:37< celticminstrel> That would be nice.
20160331 19:09:46< celticminstrel> Sure.
20160331 19:10:15< celticminstrel> Possible places to start might be src/preferences.?pp and src/gui/dialogs/preferences_dialog.?pp.
20160331 19:10:27< ScegfOd> thanks ^_^
20160331 19:10:57< celticminstrel> And of course src/log.?pp.
20160331 19:11:41< ScegfOd> right xD
20160331 19:12:51-!- travis-ci [~travis-ci@ec2-54-92-147-78.compute-1.amazonaws.com] has joined #wesnoth-dev
20160331 19:12:52< travis-ci> wesnoth/wesnoth#9142 (master - c01e5e8 : gfgtdf): The build has errored.
20160331 19:12:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/119881188
20160331 19:12:52-!- travis-ci [~travis-ci@ec2-54-92-147-78.compute-1.amazonaws.com] has left #wesnoth-dev []
20160331 19:14:49-!- NosajIRL [~nos@208.91.185.104] has joined #wesnoth-dev
20160331 19:30:48< celticminstrel> Huh, weird... BOOST_TEST_DYN_LINK is not defined despire being in the target settings... wait... it's only defined in release builds. Wow, okay.
20160331 19:31:24< celticminstrel> 555 sources in the unit tests.
20160331 19:31:33< celticminstrel> Nice number. :P
20160331 19:34:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 19:34:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 19:35:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 19:52:36-!- NosajIRL [~nos@208.91.185.104] has quit [Read error: Connection reset by peer]
20160331 20:01:30-!- nos_ [~nos@208.91.185.104] has joined #wesnoth-dev
20160331 20:03:23-!- atarocch [~atarocch@206.229.16.238] has joined #wesnoth-dev
20160331 20:03:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160331 20:03:47< celticminstrel> :D
20160331 20:05:26< irker509> wesnoth: Celtic Minstrel wesnoth:master ec43700ff5bf / / (3 files in 2 dirs): XCode: Enable unit tests build https://github.com/wesnoth/wesnoth/commit/ec43700ff5bf062fddbf881e43077471466f09bd
20160331 20:09:13< celticminstrel> mattsc: Go ahead and add that warning suppression flag. (Preferably in project settings, not target settings.)
20160331 20:36:58-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160331 20:55:18-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160331 20:56:03-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit [Client Quit]
20160331 21:03:39-!- mjs-de [~mjs-de@x4db53fea.dyn.telefonica.de] has joined #wesnoth-dev
20160331 21:05:00-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160331 21:05:17-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160331 21:09:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160331 21:13:28< celticminstrel> Now that I've gotten them to build, I need to deal with all the dyld errors...
20160331 21:18:58-!- gfgtdf [~chatzilla@f054149045.adsl.alicedsl.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]]
20160331 21:22:49-!- atarocch [~atarocch@206.229.16.238] has quit [Remote host closed the connection]
20160331 21:23:32< celticminstrel> I got past the libs not loaded errors, now I'm getting symbols not found...
20160331 21:25:07< celticminstrel> Ooh.
20160331 21:25:13< celticminstrel> Why is it linking with libstdc++.
20160331 21:25:22< celticminstrel> It should be linking with libc++.
20160331 21:25:40-!- Kwandulin [~Miranda@p200300760F191CFFB8C22CB0D621DBB9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160331 21:25:40< celticminstrel> ...wait, it's linking with both? o.o
20160331 21:34:59< celticminstrel> So basically I doubt that's the cause.
20160331 21:36:13< celticminstrel> Mysteriously, copying Boost.ProgramOptions into the same folder as Boost.UnitTestFramework fixed it...
20160331 21:37:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160331 21:38:09< irker509> wesnoth: Celtic Minstrel wesnoth:master e7cb3f500c52 / projectfiles/Xcode/Wesnoth.xcodeproj/ (project.pbxproj xcshareddata/xcschemes/unit_tests.xcscheme): XCode: Fix dynamic link errors in unit tests https://github.com/wesnoth/wesnoth/commit/e7cb3f500c52becc0b4d45c71f0c6259c8656f51
20160331 21:38:22< celticminstrel> Now the segfault...
20160331 21:40:45-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20160331 21:41:00-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20160331 21:41:58< celticminstrel> It's segfaulting in path concatenation... :|
20160331 21:43:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20160331 21:44:15< celticminstrel> (Also, why is it using ~/.wesnoth1.13? Or does this get replaced later on?)
20160331 21:45:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160331 22:02:34-!- mjs-de [~mjs-de@x4db53fea.dyn.telefonica.de] has quit [Remote host closed the connection]
20160331 22:04:19-!- Appleman1234 [~Appleman1@KD106161153139.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20160331 22:28:21-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has left #wesnoth-dev []
20160331 22:35:16-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has quit [Read error: Connection reset by peer]
20160331 22:35:46-!- Crendgrim [~crend@wesnoth/forum-moderator/crendgrim] has joined #wesnoth-dev
20160331 22:39:53-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160331 22:39:53-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160331 22:51:27-!- nos_ [~nos@208.91.185.104] has quit [Ping timeout: 276 seconds]
20160331 23:01:06-!- Appleman1234 [~Appleman1@KD106161142006.au-net.ne.jp] has joined #wesnoth-dev
20160331 23:02:20-!- gfgtdf [~chatzilla@f054149045.adsl.alicedsl.de] has joined #wesnoth-dev
20160331 23:02:40< gfgtdf> celticminstrel: which clang version do you use and whats teh oldest supported clang version in wesnoth?
20160331 23:03:48< celticminstrel> $ clang --version
20160331 23:03:49< celticminstrel> Apple LLVM version 4.2 (clang-425.0.28) (based on LLVM 3.2svn)
20160331 23:03:50< celticminstrel> Target: x86_64-apple-darwin11.4.2
20160331 23:03:50< celticminstrel> Thread model: posix
20160331 23:04:17< celticminstrel> I have a newer version installed, but it doesn't play nice with XCode 4, I think.
20160331 23:04:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 23:04:57< gfgtdf> celticminstrel: this mens that you use clang 3.2 ?
20160331 23:07:26< gfgtdf> celticminstrel: ?
20160331 23:08:01< celticminstrel> I'm not actually sure how it compares to official clang versions.
20160331 23:09:39< celticminstrel> I do know it doesn't fully support C++11.
20160331 23:14:16< irker509> wesnoth: Celtic Minstrel wesnoth:master 9c442ebb4b1b / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Fix wesnothd build https://github.com/wesnoth/wesnoth/commit/9c442ebb4b1bcc7f7261f424f9d7bcaf5a84b638
20160331 23:18:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160331 23:24:12-!- nos_ [~nos@208.91.185.104] has joined #wesnoth-dev
20160331 23:26:06-!- nos_ [~nos@208.91.185.104] has quit [Read error: Connection reset by peer]
20160331 23:26:26-!- nos_ [~nos@208.91.185.104] has joined #wesnoth-dev
20160331 23:30:26-!- higgins [~higgins@2607:5300:100:200::160d] has quit [K-Lined]
20160331 23:31:19-!- higgins [~higgins@105.ip-167-114-152.net] has joined #wesnoth-dev
20160331 23:32:37-!- nos_ is now known as NosajIRL
20160331 23:35:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 23:35:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 23:35:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160331 23:45:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160331 23:45:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
--- Log closed Fri Apr 01 00:00:54 2016