--- Log opened Mon Apr 04 00:00:23 2016
20160404 00:16:37< ScegfOd> hmmmm, if I add a couple of logging.?pp files, where should I put the #include?
20160404 00:17:09< celticminstrel> Huh?
20160404 00:17:25< ScegfOd> the orbs menu has it's own cpp and hpp files
20160404 00:18:00< ScegfOd> but I don't know where those are linked into, is there a master header or something?
20160404 00:18:20< celticminstrel> Uhh... what?
20160404 00:18:33< celticminstrel> The hpp file is presumably included in the preferences_dialog.cpp...
20160404 00:18:51< celticminstrel> When adding a new cpp file you need to add it to scons and CMake.
20160404 00:19:05< celticminstrel> The relevant files are src/SConscript and src/CMakelists.txt
20160404 00:19:25< celticminstrel> If using a project, you'll also need to add both files to your project, of course.
20160404 00:19:32< ScegfOd> right
20160404 00:19:45< celticminstrel> You can generally leave other projects alone, people who use them will update them.
20160404 00:29:18< ScegfOd> I feel dumb, i was looking all over the hpp instead of the cpp x.x
20160404 00:30:12< ScegfOd> but it included it, thanks ^_^
20160404 00:30:25-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160404 00:39:09-!- NosajIRL [~nos@208.91.185.104] has quit [Ping timeout: 244 seconds]
20160404 00:54:25< celticminstrel> In general it's a good idea not to add a new include in a hpp if you can possibly avoid it.
20160404 00:59:57< celticminstrel> Hmm. It seems vultraz broke my build, but not the same way he broke Travis.
20160404 01:26:23-!- gfgtdf_ [~chatzilla@x4e36a6e9.dyn.telefonica.de] has joined #wesnoth-dev
20160404 01:28:27-!- gfgtdf [~chatzilla@x4e36a8ae.dyn.telefonica.de] has quit [Ping timeout: 268 seconds]
20160404 01:28:33-!- gfgtdf_ is now known as gfgtdf
20160404 01:37:09-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160404 01:42:07< vultraz> celticminstrel: hm?
20160404 01:47:58-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160404 01:55:10-!- irker155 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160404 01:58:31< vultraz> ancestral: new buttons have been committed
20160404 01:58:37< ancestral> Cool!
20160404 01:59:55< vultraz> the difference is striking
20160404 02:01:40-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160404 02:03:24< fabi> hello
20160404 02:04:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160404 02:05:19< gfgtdf> vultraz: you removed the 800x480 chekc form the gui2 tests
20160404 02:05:29< vultraz> gfgtdf: yes
20160404 02:05:40< vultraz> gfgtdf: shadowm said we could silently drop that resolution
20160404 02:05:45< gfgtdf> vultraz: you shoudlnt do this unless you want to remove suport for those resolutions, in which case you shodul change  all the other files accodingly
20160404 02:05:52< vultraz> plus I don't think the new buttons works at that resolution
20160404 02:07:02< gfgtdf> vultraz, yes like i said , update the oter files accordingly then.
20160404 02:08:34< vultraz> what other files reference that resolution?
20160404 02:09:04< gfgtdf> hmm not sure, just search for '480' i'd say.
20160404 02:11:24-!- irker584 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160404 02:11:24< irker584> wesnoth: Charles Dang wesnoth:master 5d28a2caa565 / src/preferences.cpp: Updated min_allowed_height to 600 https://github.com/wesnoth/wesnoth/commit/5d28a2caa565d16a3d6d9621247b6ca00900937b
20160404 02:11:25< irker584> wesnoth: Charles Dang wesnoth:master 0a7190c60567 / projectfiles/CodeBlocks/wesnoth.cbp: Updated cb projfile https://github.com/wesnoth/wesnoth/commit/0a7190c605677ccf6a79c7f1f0f8d861f04a3dd9
20160404 02:13:47< gfgtdf> hmm my mose just borke somehow is there a way to control wesnoh via keyboard ?
20160404 02:14:15< gfgtdf> hmm is the 480x800 also removed from the preverenced dialog ?
20160404 02:14:50< vultraz> hm
20160404 02:14:52< vultraz> it hasn't
20160404 02:15:02< vultraz> but I'm not sure how to remove it since it's not a hardcoded list
20160404 02:15:29< gfgtdf> hmm is there a way to close a shell window without the mouse? alt+F4 soesn'T seem to work
20160404 02:15:52< vultraz> I dunno
20160404 02:16:23< gfgtdf> hmm my ousewheel still works
20160404 02:16:31< gfgtdf> mayb i just have my mouse in some strange mode
20160404 02:17:06< vultraz> try turning it on and off again
20160404 02:17:13< celticminstrel> I've now forgotten what I wanted vultraz for... :/
20160404 02:17:20< vultraz> heh
20160404 02:17:35< vultraz> celticminstrel: can you remove boost_function_guarded from the xcode file
20160404 02:17:35< gfgtdf> hmm maybe you coudl check the list items agains the minimum resultion values and remove them if needed
20160404 02:17:48< vultraz> I guess replace it with function.hpp
20160404 02:18:14< celticminstrel> vultraz: Already did.
20160404 02:18:59< vultraz> not committed yet?
20160404 02:19:06< celticminstrel> Not pushed.
20160404 02:19:15< vultraz> ah
20160404 02:19:16< vultraz> ok
20160404 02:20:19-!- travis-ci [~travis-ci@ec2-54-145-99-145.compute-1.amazonaws.com] has joined #wesnoth-dev
20160404 02:20:20< travis-ci> wesnoth/wesnoth#9191 (master - 0a7190c : Charles Dang): The build is still failing.
20160404 02:20:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120525270
20160404 02:20:20-!- travis-ci [~travis-ci@ec2-54-145-99-145.compute-1.amazonaws.com] has left #wesnoth-dev []
20160404 02:20:51< vultraz> celticminstrel: were you also working on the placeholder conflict?
20160404 02:21:14< gfgtdf> celticminstrel: do you know how we can installa newer version of libstdc++ or libc++ on travis for the c++14 build ?
20160404 02:21:24< celticminstrel> vultraz: Yes.
20160404 02:21:32< celticminstrel> gfgtdf: Vaguely maybe?
20160404 02:23:44< gfgtdf> celticminstrel: maybe you coudl give it a try ?
20160404 02:23:51< celticminstrel> Possibly.
20160404 02:28:24< gfgtdf> celticminstrel: i just read that it migth be possible to use boost placeholder with std::bind by specializing std::is_placeholder for the boost placeholders
20160404 02:28:41< gfgtdf> celticminstrel: this might ab another arrpach to solve that problem
20160404 02:28:51< celticminstrel> Hmm, I'll consider that.
20160404 02:42:52-!- gfgtdf [~chatzilla@x4e36a6e9.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]]
20160404 04:15:50< vultraz> celticminstrel / ancestral : so I noticed we got tweeted this about two weeks ago (didn't see it before now) https://twitter.com/dbhaun/status/712344462177861632 does it mean anything?
20160404 04:16:11< ancestral> Working on it
20160404 04:17:22< vultraz> ah
20160404 04:17:47< celticminstrel> I didn't notice the tweet, but I recall hearing it from somewhere or other.
20160404 04:23:55< ancestral> vultraz: Are you going to update the front page to include dev releases, or is that a thing of the past?
20160404 04:36:12< celticminstrel> This is weird.
20160404 04:36:26< celticminstrel> src/gui/dialogs/editor/custom_tod.cpp:325
20160404 04:36:41< celticminstrel> What the heck is that line supposed to do?
20160404 04:36:58< celticminstrel> Because I'm pretty sure it doesn't do it right now.
20160404 04:52:02< celticminstrel> I'm actually beginning to think we should just revert the boost->std function stuff.
20160404 04:52:54< celticminstrel> Though I suppose it does have the minor advantage of revealing that the save button in custom_tod does nothing, but it's just causing too many problems.
20160404 04:58:15< celticminstrel> Hmm...
20160404 05:07:43< ancestral> Hmm
20160404 05:07:52< ancestral> SDL2 binaries on the web want to be 64-bit only
20160404 05:08:11< ancestral> Looks like I’ll need to homebrew my way
20160404 05:08:28< ancestral> vultraz, celticminstrel: 1.13.4 was SDL1 or SDL2 or both?
20160404 05:08:36< celticminstrel> SDL2 only.
20160404 05:08:43< ancestral> Thanks
20160404 05:11:49< ancestral> Looks like I should brew my own
20160404 05:12:00-!- irker584 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160404 05:17:01< vultraz> celticminstrel: it never did anything
20160404 05:17:08< vultraz> Save was never implemented
20160404 05:17:14< celticminstrel> I see,
20160404 05:17:43< celticminstrel> I was wondering what it should do though.
20160404 05:18:40< vultraz> I dunno
20160404 05:18:53< vultraz> I don't really like the design I did with that dialog anyway
20160404 05:19:36< vultraz> plus it's horribly broken
20160404 05:19:46< vultraz> dragging the sliders doesn't affect the screen
20160404 05:19:47< celticminstrel> You made that dialog?
20160404 05:19:57< vultraz> yes
20160404 05:20:02< vultraz> back when I was first learning c++
20160404 05:20:26< vultraz> it's buggy and ugly
20160404 05:20:41< celticminstrel> Buggly.
20160404 05:20:47< vultraz> heh
20160404 05:20:49< vultraz> yeah
20160404 05:20:59< vultraz> notice how holding down the slider will cause it to gradually move to the left
20160404 05:22:21< celticminstrel> I haven't actually tried it, I just noticed that in the code because it's a compile error.
20160404 05:22:40< vultraz> what's the error?
20160404 05:22:42< vultraz> I got no error
20160404 05:22:49< celticminstrel> I know.
20160404 05:23:47< celticminstrel> I'm getting several errors from attempts to bind non-void functions where a void function is expected. That's one of them.
20160404 05:24:13< vultraz> interesting
20160404 05:26:32< vultraz> I'd prefer not to revert the commit
20160404 05:26:40< celticminstrel> Me too.
20160404 05:26:45< vultraz> Since then I'll have to go through and redo the boost::functionN changes 
20160404 05:28:30< celticminstrel> Yeah, I'd want to keep that part at least.
20160404 05:29:08< vultraz> I should go and typedef some of the stuff in property_handler.hpp at some point
20160404 05:29:38< celticminstrel> I suppose it wouldn't hurt.
20160404 05:29:40< vultraz> so we don't have functions that take up two lines on my screen :|
20160404 05:30:10< celticminstrel> I think it might be three lines for me.
20160404 05:30:32< celticminstrel> Can't quite remember though. That might've just been in the git diff.
20160404 05:30:39< vultraz> first let's get the build working
20160404 05:31:05< celticminstrel> I also have something that should fix Travis.
20160404 05:31:21< vultraz> good, good
20160404 05:39:50-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160404 06:05:52-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160404 06:06:06-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has quit [Ping timeout: 250 seconds]
20160404 06:15:24-!- Kwandulin [~Miranda@p200300760F0D010C55E6B25ACF71D284.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160404 06:37:02-!- prkc [~prkc@46.166.188.234] has quit [Remote host closed the connection]
20160404 06:59:35-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160404 07:40:18-!- oldlaptop [~quassel@50-37-53-169.mskg.mi.frontiernet.net] has quit [Ping timeout: 268 seconds]
20160404 07:42:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160404 07:42:34-!- oldlaptop [~quassel@50-37-53-169.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20160404 07:51:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160404 08:10:16-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160404 08:33:02-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20160404 08:33:08-!- fendrin [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160404 08:52:26-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160404 08:57:29-!- mjs-de [~mjs-de@x4db6380b.dyn.telefonica.de] has joined #wesnoth-dev
20160404 08:59:24-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]]
20160404 08:59:37-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160404 09:10:03< zookeeper> include\boost/iterator/transform_iterator.hpp(51): error C2039: 'type' : is not a member of 'boost::iterators::detail::ia_dflt_help<Reference,boost::result_of<const UnaryFunc (const std::basic_string<char,std::char_traits<char>,std::allocator<char>> &)>>'
20160404 09:10:03< zookeeper> include\boost/iterator/transform_iterator.hpp(60): error C3203: 'type' : unspecialized class template can't be used as a template argument for template parameter 'T', expected a real type
20160404 09:15:17< vultraz> :/
20160404 09:23:21-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160404 09:27:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160404 09:27:43-!- wedge010 is now known as wedge009
20160404 09:33:09-!- Kwandulin [~Miranda@p200300760F0D010C55E6B25ACF71D284.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20160404 09:38:33-!- Kwandulin [~Miranda@p200300760F0D010C55E6B25ACF71D284.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160404 09:53:43-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: End Transmission.]
20160404 10:03:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160404 10:03:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160404 10:07:36-!- prkc [~prkc@46.166.138.165] has joined #wesnoth-dev
20160404 10:11:29 * Aginor is pleased
20160404 10:11:49< Aginor> I've broken the back of the renderpath update :)
20160404 10:17:07-!- mjs-de [~mjs-de@x4db6380b.dyn.telefonica.de] has quit [Ping timeout: 248 seconds]
20160404 10:26:42< zookeeper> oh?
20160404 10:35:15< zookeeper> vultraz, oh actually there was one helpful line in there: ..\..\src\tod_manager.cpp(96) : see reference to class template instantiation 'boost::range_detail::transformed_range<std::_Bind<true,To,To (__cdecl *const )
20160404 10:40:18< zookeeper> wth, why is the text in the campaign menu really big and bold?
20160404 10:40:43< zookeeper> wait, actually that's all white text everywhere
20160404 10:41:14< zookeeper> well, almost everywhere.
20160404 10:43:49-!- fendrin_ [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160404 10:47:39-!- fendrin [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 276 seconds]
20160404 10:52:51-!- irker754 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160404 10:52:51< irker754> wesnoth: Andreas Löf wesnoth:renderpath_redo ae16c900dcda / src/ (11 files in 3 dirs): Add a FPS counter that's invoked every time a draw call is made. https://github.com/wesnoth/wesnoth/commit/ae16c900dcda997a239441f6b8cdd6d60fcb2c5b
20160404 10:53:18< Aginor> I figured I'd better commit and push all of my changes so they're visible
20160404 10:53:31< Aginor> it's still WIP, but please have a look and comment
20160404 11:00:57-!- Kwandulin [~Miranda@p200300760F0D010C55E6B25ACF71D284.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160404 11:01:22-!- travis-ci [~travis-ci@ec2-54-147-240-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160404 11:01:22< travis-ci> wesnoth/wesnoth#9192 (renderpath_redo - ae16c90 : Andreas Löf): The build failed.
20160404 11:01:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120588249
20160404 11:01:22-!- travis-ci [~travis-ci@ec2-54-147-240-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160404 11:25:10< vultraz> zookeeper: I'll have to ask celticminstrel 
20160404 12:07:59-!- Kwandulin [~Miranda@p200300760F0D010C89FFDBDA87D28CB9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160404 12:37:17-!- Kwandulin [~Miranda@p200300760F0D010C89FFDBDA87D28CB9.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]
20160404 12:38:47-!- gfgtdf [~chatzilla@x4e36a6e9.dyn.telefonica.de] has joined #wesnoth-dev
20160404 12:41:04-!- gfgtdf [~chatzilla@x4e36a6e9.dyn.telefonica.de] has quit [Client Quit]
20160404 12:54:47-!- mjs-de [~mjs-de@x4db6380b.dyn.telefonica.de] has joined #wesnoth-dev
20160404 12:57:30-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 244 seconds]
20160404 13:10:47-!- Kwandulin [~Miranda@p200300760F0D012589FFDBDA87D28CB9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160404 13:15:09-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160404 13:48:21-!- NosajIRL [~nos@208.91.185.104] has joined #wesnoth-dev
20160404 13:53:14-!- irker754 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160404 13:59:02-!- NosajIRL [~nos@208.91.185.104] has quit [Remote host closed the connection]
20160404 14:15:58-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 250 seconds]
20160404 14:31:54-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160404 14:39:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160404 14:44:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20160404 15:23:10-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160404 15:24:15-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160404 15:28:27-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 246 seconds]
20160404 15:29:21-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 244 seconds]
20160404 15:30:37-!- prkc [~prkc@46.166.138.165] has quit [Ping timeout: 248 seconds]
20160404 15:37:30-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160404 15:43:45-!- Kwandulin_2 [~Miranda@p200300760F0D012589FFDBDA87D28CB9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160404 15:45:37-!- Kwandulin [~Miranda@p200300760F0D012589FFDBDA87D28CB9.dip0.t-ipconnect.de] has quit [Ping timeout: 268 seconds]
20160404 15:45:38-!- prkc [~prkc@46.166.190.216] has joined #wesnoth-dev
20160404 15:45:49-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160404 15:51:41-!- boucman_work [~boucman@193.56.60.161] has quit [Remote host closed the connection]
20160404 16:02:41< celticminstrel> I think I might've gotten an error in the same place as zookeeper - something using boost::copy?
20160404 16:03:11< celticminstrel> Not quite sure though...
20160404 16:05:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160404 16:07:12< celticminstrel> Ah, yes, I already fixed that one in my build.3
20160404 16:10:59-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160404 16:40:13-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has joined #wesnoth-dev
20160404 17:07:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160404 17:09:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160404 17:18:33-!- prkc [~prkc@46.166.190.216] has quit [Ping timeout: 240 seconds]
20160404 17:25:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160404 17:26:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160404 17:28:22-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160404 17:31:50-!- mjs-de [~mjs-de@x4db6380b.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160404 17:33:06-!- Kwandulin_2 [~Miranda@p200300760F0D012589FFDBDA87D28CB9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160404 17:33:57-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has joined #wesnoth-dev
20160404 17:36:10< celticminstrel> vultraz or someone: Does "set wesnothd path" in prefs currently work?
20160404 17:37:17< celticminstrel> The code looks like it asks you for a new path but then doesn't do anything with that path.
20160404 17:39:25< vultraz> uh...
20160404 17:39:30< vultraz> I actually didn't test..
20160404 17:41:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160404 17:41:30-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160404 17:43:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160404 17:55:06< celticminstrel> vultraz: If you have a moment and could test, that would be nice. I could test myself once it builds, of course.
20160404 17:55:23< celticminstrel> I think I've fixed all the errors now.
20160404 17:56:41< vultraz>  Yeah it doesn't save the new path
20160404 17:57:10< celticminstrel> 'kay
20160404 17:57:15< celticminstrel> I can probably fix this.
20160404 17:57:33< celticminstrel> I commented out that similar case in custom_tod, BTW.
20160404 17:57:49< vultraz> what?
20160404 17:57:56< celticminstrel> The save button or something.
20160404 17:58:00< celticminstrel> Which did nothing.
20160404 17:58:02< vultraz> oh, yeah
20160404 17:58:04< vultraz> good
20160404 17:58:17< vultraz> That will need to be implemented eventually
20160404 17:58:24< celticminstrel> It was causing a compile error and I didn't know how to fix it properly, so I just commented it out.
20160404 17:58:38< celticminstrel> functional.hpp is surprisingly large now. >_>
20160404 17:58:55< vultraz> what did you add?
20160404 17:59:06< celticminstrel> I had to implement a bind wrapper that ignores return values.
20160404 17:59:31< celticminstrel> Also the boilerplate to let std::bind use Boost placeholders.
20160404 18:00:54< vultraz> why would we want the latter?
20160404 18:01:04< celticminstrel> Because it should fix the Travis issues.
20160404 18:01:07< vultraz> ah
20160404 18:01:09< vultraz> I see
20160404 18:01:11< vultraz> :(
20160404 18:01:18< celticminstrel> While still allowing us to use unqualified placeholders.
20160404 18:03:22< vultraz> I wonder why travis has problems
20160404 18:03:25< vultraz> When I didn't
20160404 18:03:27< celticminstrel> We also can't completely switch to std::bind at the moment, mostly due to tdispatcher. I attempted to fix this by changing tdispatcher, but that didn't work out.
20160404 18:03:39< vultraz> eh?
20160404 18:03:44< celticminstrel> Maybe Travis uses a different version of Boost or something.
20160404 18:03:53< vultraz> I thought I changed every case
20160404 18:03:56< vultraz> What did you revert
20160404 18:04:03< celticminstrel> You did, and a few of them errored.
20160404 18:04:19< vultraz> I was going to suggest we use Lambdas in any such case
20160404 18:04:32< celticminstrel> I don't remember what I reverted. I'm going to review each one to make sure it was really necessary, though.
20160404 18:04:43< vultraz> Is there any reason to use a bind call over a lambda?
20160404 18:05:13< celticminstrel> For the ones I reverted to boost::bind I did consider this.
20160404 18:05:38< celticminstrel> However, I didn't like the fact that the lambda would've had four unused arguments.
20160404 18:06:55< vultraz> What case was this?
20160404 18:07:22< celticminstrel> Anything passed to connect_signal_* or tdispatcher.[dis]connect_signal
20160404 18:07:31< celticminstrel> I think.
20160404 18:07:46< celticminstrel> Though I don't understand why only a small subset of those actually produced errors.
20160404 18:08:25< vultraz> You could use the typedef?
20160404 18:08:36< celticminstrel> Not possible in a lambda.
20160404 18:08:43< celticminstrel> Or for that matter in a function definition.
20160404 18:08:49< vultraz> blah
20160404 18:08:59< vultraz> sucks
20160404 18:09:17< celticminstrel> Unless I can cast a no-args lambda to the typedef... but I doubt that would work...
20160404 18:09:27< celticminstrel> I'll give it a try though.
20160404 18:09:48< celticminstrel> Ultimately I think what we need to do is make tdispatcher more flexible.
20160404 18:09:59< vultraz> Optimally we shouldn't be mixing boost::bind and std::bind
20160404 18:10:08< vultraz> it will only cause headaches later down the road.
20160404 18:10:22< celticminstrel> Why do you think it will cause headaches?
20160404 18:10:43< celticminstrel> I mean, I agree we probably shouldn't mix them if we can avoid it, but I don't see much problem in doing so if necessary.
20160404 18:11:46< vultraz> Well, they provide slightly different functionality, so if we design bits of code around one, it would become non-portable to the other.
20160404 18:11:54< vultraz> (kinda like this situation)
20160404 18:12:04< celticminstrel> Yeah.
20160404 18:12:07< celticminstrel> That's true.
20160404 18:13:05< vultraz> Having code designed around two different similar systems isn't good
20160404 18:14:15< vultraz> It's like randomly handing out tofu burgers at a burger joint. Everyone comes in for burgers, but it's likely eventually someone who doesn't like tofu burgers or someone who doesn't like regular burgers will get one :P
20160404 18:16:48< celticminstrel> I now find myselt writing #ifndef HAVE_CXX14...
20160404 18:17:45< vultraz> Heh
20160404 18:17:55< vultraz> as soon as we switch to c++11 we want c++14
20160404 18:18:19< celticminstrel> C++14 has function return type deduction.
20160404 18:18:24< vultraz> I checked compiler support, though, and we'd need to use VC2015 as the minimum if we wanted that.
20160404 18:18:31< vultraz> Plus you said you can't build with it
20160404 18:18:39< celticminstrel> Yeah, I can't build with it in XCode.
20160404 18:18:49< celticminstrel> I could probably build with it if scons supported a Mac build.
20160404 18:18:57< celticminstrel> But I'd prefer to use XCode.
20160404 18:19:03-!- Kwandulin [~Miranda@p200300760F0D0125E88CBB08F594FAEE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160404 18:19:31< zookeeper> soo... the problem getting fixed sometime soon?
20160404 18:19:40< celticminstrel> Yeah, almost done.
20160404 18:19:49< celticminstrel> Hopefully that'll fix your build too.
20160404 18:20:08< celticminstrel> I've basically duplicated the entire body of the function twice, once in the actual function body and once in a decltype. :/
20160404 18:20:34< celticminstrel> (It's a one-line function, to be clear.)
20160404 18:23:06-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has quit [Remote host closed the connection]
20160404 18:23:43< zookeeper> well that was the problem i was referring to.
20160404 18:25:35< celticminstrel> The error in tod_manager, yes. I got an error there too, which I have fixed.
20160404 18:26:15< celticminstrel> I just hope this doesn't cause more errors for you. I wonder if MSVC supports trailing return types, maybe I should put the decltype in front instead.
20160404 18:26:22< celticminstrel> ^MSVC 2013
20160404 18:27:37< celticminstrel> Ah, looks like it does. Surprisingly, it seems even MSVC 2010 does.
20160404 18:29:12-!- fendrin_ [~quassel@wesnoth/developer/fendrin] has quit [Ping timeout: 244 seconds]
20160404 18:32:00-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160404 18:41:01-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has joined #wesnoth-dev
20160404 18:49:52< celticminstrel> Besides the aforementioned bind wrapper (which uses boost::bind), I think I only need four other boost::bind calls.
20160404 18:50:24< celticminstrel> I'll try reducing that a bit more with lambdas, but no promises.
20160404 18:51:06< celticminstrel> (And the tod_manager one I don't really want to deal with, so it's staying Boost unless someone changes it more drastically.)
20160404 18:52:01-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160404 18:52:13< celticminstrel> No wait, that's three, not four. I had six, but three of them were done due to return types, which doesn't work; I could use the wrapper, but the return type wasn't necessary so I removed it instead.
20160404 19:14:17< celticminstrel> Got it down to two.
20160404 19:15:03< celticminstrel> If tdispatcher is changed, the wrapper could probably also be switched to std::bind.
20160404 19:17:26< celticminstrel> The tod_manager case might need to switch away from boost::copy to allow std::bind, which might be less efficient. The screenshot case, I have no idea what the issue is.
20160404 19:28:02< vultraz> celticminstrel: what about std::copy
20160404 19:28:16< celticminstrel> Completely different idiom.
20160404 19:28:21< vultraz> ah
20160404 19:28:42< celticminstrel> Of course, it could be changed to std algorithms, but if I'm not mistaken, that would require additional temporary containers.
20160404 19:31:09< Elvish_Hunter> Hi all
20160404 19:31:30< Elvish_Hunter> For anyone interested, I just ported [set_variable] to Lua: https://github.com/wesnoth/wesnoth/pull/642
20160404 19:31:58< celticminstrel> Oh.
20160404 19:32:06< celticminstrel> I'll look at it in a bit.
20160404 19:33:17-!- Kwandulin [~Miranda@p200300760F0D0125E88CBB08F594FAEE.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]
20160404 19:35:30< vultraz> Elvish_Hunter: suggestion: move the random code to helper.rand and use that here
20160404 19:35:33< zookeeper> i hope you know what you're doing with that, seems like a can of worms
20160404 19:37:42< vultraz> (or would that make helper.rand non-safe_
20160404 19:37:46< vultraz> )*
20160404 19:38:00< vultraz> (damn dumb server protocols)
20160404 19:38:22< Elvish_Hunter> vultraz: I'm using wesnoth.random, which is synced.
20160404 19:39:29< Elvish_Hunter> zookeeper: yep, it *is* a can of worms. But I handled other can of worms in past, like [elseif].
20160404 19:39:52< Elvish_Hunter> This is why it's in a PR: because I must be absolutely sure that I got it right.
20160404 19:40:23< Elvish_Hunter> On the other hand, moving it to Lua will allow me to add a few new features to it.
20160404 19:41:35< Elvish_Hunter> Although I can add them even if it stays in C++.
20160404 19:42:00< celticminstrel> I'm curious what features now.
20160404 19:42:24< Elvish_Hunter> I was thinking of abs, power and sqrt.
20160404 19:45:26< celticminstrel> Though, it's actually possible to extend C++ WML tags in Lua, depending what you're trying to do.
20160404 19:46:04< Elvish_Hunter> BTW, I also found a Lua library, called 'lmathx', that adds support for the C99 math functions.
20160404 19:46:23< celticminstrel> You can actually do abs, power, and sqrt in [set_variable], I think.
20160404 19:46:25< Elvish_Hunter> It's available here: http://webserver2.tecgraf.puc-rio.br/~lhf/ftp/lua/#lmathx
20160404 19:46:38< celticminstrel> By using $(...) formula includes.
20160404 19:47:05< celticminstrel> Though I guess it doesn't hurt to support them more directly as well.
20160404 19:53:55< celticminstrel> And I think you can do that without porting the whole tag.
20160404 19:54:13< celticminstrel> Though I won't reject your work on that basis.
20160404 19:57:39-!- irker183 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160404 19:57:39< irker183> wesnoth: Celtic Minstrel wesnoth:master 38010fd99138 / src/ (3 files in 2 dirs): Revert "remove unused queued_event parameter from WML_HANDLER_FUNCTION" https://github.com/wesnoth/wesnoth/commit/38010fd991388895bcddf4830999370c34abef01
20160404 19:57:39< irker183> wesnoth: Celtic Minstrel wesnoth:master ff3e1bf83a32 / src/ (5 files in 4 dirs): Variadic config methods to combine remove_attribute or clear_children calls https://github.com/wesnoth/wesnoth/commit/ff3e1bf83a3253f99c97de1bdd831b0f9e2a32b4
20160404 19:57:39< irker183> wesnoth: Celtic Minstrel wesnoth:master ca6ec3b90010 / src/ (3 files in 2 dirs): NULL -> nullptr https://github.com/wesnoth/wesnoth/commit/ca6ec3b900105fa4bd07b3ef6ba58d98da3979f4
20160404 19:57:40< irker183> wesnoth: Celtic Minstrel wesnoth:master 4f2367648e00 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/4f2367648e00df9eff554807a3c73d488dfc9289
20160404 19:57:41< irker183> wesnoth: Celtic Minstrel wesnoth:master 1bdce5b93732 / src/ (16 files in 6 dirs): Fix build https://github.com/wesnoth/wesnoth/commit/1bdce5b937325de25ac9a9fd94fc52a8e665b5ab
20160404 19:57:43< irker183> wesnoth: Celtic Minstrel wesnoth:master 74fd5395a9b4 / src/preferences_display.cpp: Fix "set wesnothd path" preference https://github.com/wesnoth/wesnoth/commit/74fd5395a9b4cd08ec5001ce35f003c98396cfe2
20160404 19:57:58< celticminstrel> zookeeper: Let me know if your build is fixed with that push.
20160404 19:59:18< zookeeper> src\utils/functional.hpp(57): error C2061: syntax error : identifier 'P'
20160404 20:00:11< zookeeper> and a lot of stuff like src\utils/functional.hpp(58) : see reference to class template instantiation 'detail::function_base<Ret(P...)>' being compiled
20160404 20:00:32< celticminstrel> Ugh...
20160404 20:01:37< celticminstrel> That sounds like an "unrecognized identifier" class of errors, which makes no sense since it's declared two lines up... :|
20160404 20:04:40-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160404 20:07:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds]
20160404 20:08:03-!- prkc [~prkc@46.166.188.223] has joined #wesnoth-dev
20160404 20:16:10-!- travis-ci [~travis-ci@ec2-54-144-227-61.compute-1.amazonaws.com] has joined #wesnoth-dev
20160404 20:16:11< travis-ci> wesnoth/wesnoth#9196 (master - 74fd539 : Celtic Minstrel): The build is still failing.
20160404 20:16:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120715795
20160404 20:16:11-!- travis-ci [~travis-ci@ec2-54-144-227-61.compute-1.amazonaws.com] has left #wesnoth-dev []
20160404 20:16:44< celticminstrel> Ugh...
20160404 20:23:30-!- gfgtdf [~chatzilla@x4e36a6e9.dyn.telefonica.de] has joined #wesnoth-dev
20160404 20:23:37< gfgtdf> celticminstrel: what the reson for https://github.com/wesnoth/wesnoth/commit/38010fd991388895bcddf4830999370c34abef01 ?
20160404 20:24:41< celticminstrel> If that's the revert, two reasons.
20160404 20:25:06< celticminstrel> 1. I was planning to use event_info for something, but that's not yet committed because I haven't gotten it to work yet.
20160404 20:25:35< celticminstrel> 2. The queued_event is really an essential part of the WML action handlers and, in my opinion, should not have been removed even though it was unused.
20160404 20:26:31< gfgtdf> celticminstrel: well it is sureley not essensial if its not used. 
20160404 20:26:44< gfgtdf> celticminstrel: and if you want to use it at sometime you can reintroduce it then not now
20160404 20:26:50< celticminstrel> Maybe essential was the wrong word.
20160404 20:28:03< celticminstrel> It's part of the WML action mechanism.
20160404 20:29:09< gfgtdf> celticminstrel: well not is isnt, for the same reason
20160404 20:29:18-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has quit [Ping timeout: 250 seconds]
20160404 20:29:22< celticminstrel> No, it is.
20160404 20:29:36< celticminstrel> It's only unused because all the WML actions that used to use it have been ported to Lua.
20160404 20:29:56-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160404 20:30:17< celticminstrel> Something I'm working on will use it, though, so please don't revert the revert (at least not yet).
20160404 20:30:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160404 20:31:40< gfgtdf> celticminstrel: no the ony reason why thse parmeter was there is to suport default values to x1, y1 and similar
20160404 20:31:48< gfgtdf> celticminstrel: and this was only for backwards comabiltiy
20160404 20:32:00< gfgtdf> celticminstrel: we we woudl add tags now e shoudl never add such defauklt values
20160404 20:32:11< celticminstrel> Huh?
20160404 20:32:28< celticminstrel> "we should never add such default values" - I don't see why not?
20160404 20:33:12< gfgtdf> celticminstrel: beasue its nowdasy quite uncommon that you'd want them. it's better to report an error in case they were missing
20160404 20:33:39< celticminstrel> I'm not sure what cases we're talking about, so I can't really say whether I agree or not.
20160404 20:35:26-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20160404 20:39:33-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160404 20:48:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160404 21:01:01< irker183> wesnoth: Celtic Minstrel wesnoth:master 2d72d1512bb2 / .travis.yml src/utils/functional.hpp: Attempt to fix Travis build https://github.com/wesnoth/wesnoth/commit/2d72d1512bb23b429cfb88845d476df4628705b7
20160404 21:09:54< celticminstrel> zookeeper: Does it fix anything if you replace the instances of "using type = Ret(whatever)" with "typedef Ret type(whatever)"?
20160404 21:10:17< celticminstrel> In utils/functional.hpp
20160404 21:10:54< celticminstrel> Otherwise, I might ask for a pastebin of your entire error output, in case something else useful is in there...
20160404 21:16:01< gfgtdf> celticminstrel: which erros eaxactly are fixed by teh changes to functional.hpp ?
20160404 21:16:20< celticminstrel> In the latest commit, or before that?
20160404 21:16:47< celticminstrel> If you mean before that you can see most of them in the commit itself.
20160404 21:17:15< celticminstrel> The latest commit fixed errors on Travis related to specializing a template in a different namespace than it was declared.
20160404 21:17:24< celticminstrel> Or at least, I'm hoping it fixed them.
20160404 21:18:11-!- mjs-de [~mjs-de@x4db6380b.dyn.telefonica.de] has joined #wesnoth-dev
20160404 21:20:07< gfgtdf> hmm i really wondr why they added all thost inabilities to std::function std::bind
20160404 21:20:22< gfgtdf> i mean, there are based on their boost variants ai assume
20160404 21:20:28< celticminstrel> Yeah.
20160404 21:20:40< gfgtdf> so they must be areadon why tehy decided to make it 'worse'
20160404 21:20:44< gfgtdf> reason*
20160404 21:21:08< celticminstrel> Well, the specification is based on the Boost implementation, but perhaps the specification didn't catch all those details, or perhaps the implementers didn't quite meet the specification initially.
20160404 21:23:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160404 21:25:18< zookeeper> celticminstrel, still compiling, but it looks like it
20160404 21:26:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160404 21:26:44-!- wedge010 is now known as wedge009
20160404 21:33:16-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160404 21:33:17-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160404 21:43:04< gfgtdf> celticminstrel: hmm it seem liek c++14 or c++17 fixes the void return value issue in std::function
20160404 21:43:34< celticminstrel> gfgtdf: That's good to hear.
20160404 21:43:52< celticminstrel> The other difference in boost::bind isn't so important, I think.
20160404 21:44:13< celticminstrel> Though Wesnoth's GUI2 event system relies heavily on it.
20160404 21:44:28< celticminstrel> But that could be "fixed" in the event system somehow, I think.
20160404 21:44:40< gfgtdf> celticminstrel: you mena the overloading thing ?
20160404 21:45:02< celticminstrel> I mean how boost::bind returns a function that accepts an unlimited number of parameters.
20160404 21:45:30< celticminstrel> Whereas std::bind (possibly? I'm a little unsure on this actually) returns a function that accepts as many parameters as there are placeholders.
20160404 21:45:56< gfgtdf> celticminstrel: hmm this does actuall sounds bad to me
20160404 21:45:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160404 21:46:17< gfgtdf> celticminstrel: how does std::bind work on things like std::bind(&f, _1, _4) ?
20160404 21:46:24< celticminstrel> I think it could be fixed by making all the GUI2 events be something like void(tdispatcher& tevent_info).
20160404 21:46:33< celticminstrel> gfgtdf: That would return a 4-parameter function.
20160404 21:46:42< celticminstrel> I didn't describe it well, I guess.
20160404 21:46:53< celticminstrel> Based on the highest placeholder, not the total number.
20160404 21:47:24-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160404 21:48:14< gfgtdf> celticminstrel: hmm here it seems liek std::bind supports it http://stackoverflow.com/questions/13251976/why-do-objects-returned-from-bind-ignore-extra-arguments
20160404 21:48:49< celticminstrel> Yeah, it's a bit weird, somehow it seems like my build supports it in some cases and not in others... there might be some other factor here...
20160404 21:49:28< celticminstrel> It's still a reason to not use lambdas for GUI2 events, though.
20160404 21:49:38< celticminstrel> Since those definitely don't ignore extra arguments.
20160404 21:49:47< celticminstrel> So I think it's still worth changing tdispatcher.
20160404 22:00:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160404 22:02:00< zookeeper> celticminstrel, yeah it compiled
20160404 22:03:00< celticminstrel> You didn't change any other using lines, did you?
20160404 22:03:41< celticminstrel> There are four besides the ones of the form using type = Ret(whatever).
20160404 22:04:39-!- Appleman1234 [~Appleman1@KD106161144004.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20160404 22:18:24-!- gfgtdf [~chatzilla@x4e36a6e9.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160404 22:26:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160404 22:27:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160404 22:28:00-!- mjs-de [~mjs-de@x4db6380b.dyn.telefonica.de] has quit [Remote host closed the connection]
20160404 22:30:35< irker183> wesnoth: Celtic Minstrel wesnoth:master a79190954416 / data/lua/ (7 files in 2 dirs): Split the more complicated WML tags into separate Lua files https://github.com/wesnoth/wesnoth/commit/a791909544167ff07be82d02d16d54e05c9f9753
20160404 22:30:37< irker183> wesnoth: Celtic Minstrel wesnoth:master 19fe2aa8178a / src/utils/functional.hpp: using -> typedef in some cases https://github.com/wesnoth/wesnoth/commit/19fe2aa8178a33bd32a911011c0ec9dcd9d90f89
20160404 22:31:30< celticminstrel> ...oh, whoops, I think that other commit wasn't read to push. :/
20160404 22:31:35< celticminstrel> ^ready
20160404 22:33:40< celticminstrel> Yeah, definitely wasn't. I'll fix asap.
20160404 22:35:44< vultraz> celticminstrel: what's with all the extra includes to video.hpp in https://github.com/wesnoth/wesnoth/commit/1bdce5b937325de25ac9a9fd94fc52a8e665b5ab
20160404 22:39:39< celticminstrel> vultraz: std::bind (at least on my implementation) seems to break when a parameter is of incomplete type.
20160404 22:39:52< vultraz> :|
20160404 22:40:05< celticminstrel> It might be a bug in my implementation.
20160404 22:40:20< celticminstrel> But I didn't think it was a problem since they're all source files.
20160404 22:40:28< vultraz> I suppose
20160404 22:40:29< celticminstrel> Rather than headers.
20160404 22:41:17-!- travis-ci [~travis-ci@ec2-54-204-122-59.compute-1.amazonaws.com] has joined #wesnoth-dev
20160404 22:41:18< travis-ci> wesnoth/wesnoth#9198 (master - 19fe2aa : Celtic Minstrel): The build is still failing.
20160404 22:41:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120752866
20160404 22:41:18-!- travis-ci [~travis-ci@ec2-54-204-122-59.compute-1.amazonaws.com] has left #wesnoth-dev []
20160404 22:41:54< vultraz> hmm
20160404 22:42:07< vultraz> not sure I like what you did to the sound sliders..
20160404 22:42:23< celticminstrel> ?
20160404 22:42:30< vultraz> ah, wait, it's still passing the function
20160404 22:42:50< vultraz> nvm
20160404 22:43:23< vultraz> what's with the make_screenshot thing
20160404 22:45:40< vultraz> and why do we have two different screenshot() functions
20160404 22:46:00< celticminstrel> I have no idea.
20160404 22:46:12< celticminstrel> I changed the screenshot thing to avoid an additional boost::bind.
20160404 22:46:42< vultraz> oh, hmm
20160404 22:47:09< vultraz> seems display::screenshot() handles 'whole map screenshot' vs 'visible screen screenshot'
20160404 22:47:20< celticminstrel> Makes sense.
20160404 22:49:39< vultraz> gah
20160404 22:50:00< vultraz> sometimes I hate wesnoth's tendency to have 20 layers of functions for everything
20160404 22:51:33< vultraz> map_screenshot. screenshot (2x). make_screenshot. do_screenshot.
20160404 22:51:49< celticminstrel> Uh, okay.
20160404 22:56:54< vultraz> celticminstrel: I think we should split display::screenshot() into two functions and call each directly 
20160404 22:57:06< celticminstrel> Maybe.
20160404 23:00:50-!- Appleman1234 [~Appleman1@KD106161140090.au-net.ne.jp] has joined #wesnoth-dev
20160404 23:30:37< loonycyborg> celticminstrel: replace boost.bind with lambdas maybe? :P
20160404 23:33:32< celticminstrel> loonycyborg: With the current state of tdispatcher, using lambdas would actually be quite ugly. In other cases it might be okay though.
20160404 23:34:08< celticminstrel> tdispatcher signal connection requires functions that take up to seven parameters, and most of those are typically unused.
20160404 23:34:34< celticminstrel> With bind you don't need to worry about those extra parameters; with lambdas, you need every parameter declared.
20160404 23:44:04< celticminstrel> You could of course use bind and lambdas at the same time to get around that, but... that seems silly to me.
20160404 23:46:51< loonycyborg> maybe some unholy combination of variadic templates and aurto :P
20160404 23:46:58< loonycyborg> *auto
20160404 23:47:07< celticminstrel> I dunno.
20160404 23:49:02< celticminstrel> I was thinking tdispatcher could simply be changed so that it only accepts two-parameter functions - the widget itsel, and everything else bundled into one struct.
20160404 23:49:50< celticminstrel> ^itself
20160404 23:51:41< celticminstrel> The bigger buttons don't look good on 800x600.
20160404 23:51:57< celticminstrel> Removing "Cores" should help a bit.
20160404 23:52:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160404 23:52:56< celticminstrel> I'm thinking maybe reduce the margins around the buttons a bit, just for 800x600.
20160404 23:53:13< celticminstrel> (The issue is that the button section slightly overlaps the title.)
20160404 23:54:18< celticminstrel> Unrelated to screen size, it also feels like the text should be moved down a pixel or two on each button...
20160404 23:55:15< celticminstrel> That's all buttons, not just the bigger ones.
20160404 23:57:50< celticminstrel> This might be because I'm not using Lato, though.
20160404 23:59:36< celticminstrel> The new scrollbars are fine.
--- Log closed Tue Apr 05 00:00:04 2016