--- Log opened Tue Apr 05 00:00:04 2016 --- Day changed Tue Apr 05 2016 20160405 00:00:04< celticminstrel> Why does it scroll in such large steps though... I would expect it to scroll one list element into view with each click... 20160405 00:10:45< celticminstrel> BTW, before anyone complains that WML is broken or whatever, I've already got the fix committed, but want to run the WML unit tests before pushing it. 20160405 00:11:08< celticminstrel> And while they run I'm going to go cook/eat. 20160405 00:12:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20160405 00:14:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 00:34:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20160405 00:55:58< irker183> wesnoth: Celtic Minstrel wesnoth:master d3374d3670c3 / data/lua/ (6 files in 2 dirs): WML tags fixup https://github.com/wesnoth/wesnoth/commit/d3374d3670c3327a9f9456fe1aa77fb58627346c 20160405 00:56:00< irker183> wesnoth: Celtic Minstrel wesnoth:master a275f22ebee2 / data/lua/wml/message.lua: Fix potential "image is nil" error in [message] https://github.com/wesnoth/wesnoth/commit/a275f22ebee2c91b1a228dd136f42b8893488580 20160405 01:13:23-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 01:13:24< travis-ci> wesnoth/wesnoth#9199 (master - a275f22 : Celtic Minstrel): The build is still failing. 20160405 01:13:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120780641 20160405 01:13:24-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 01:22:49-!- LovCAPONE [~lovens@modemcable184.138-20-96.mc.videotron.ca] has quit [Quit: return 0;] 20160405 01:25:17-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Ping timeout: 248 seconds] 20160405 01:33:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20160405 01:42:12-!- Appleman1234 [~Appleman1@KD106161140090.au-net.ne.jp] has quit [Remote host closed the connection] 20160405 01:42:55-!- LovCAPONE [~lovens@modemcable184.138-20-96.mc.videotron.ca] has joined #wesnoth-dev 20160405 01:45:33< celticminstrel> Any opinions on PR643? Also, what version of Boost.Thread should I list as a minimum? 20160405 01:53:21< celticminstrel> Speaking of minimums, I wonder if the minimums listed in INSTALL are still reasonable. 20160405 01:59:16< celticminstrel> Does the "global variable" WML thing work as intended right now? I see it's marked experimental in the source. 20160405 02:08:59< vultraz> yeah 20160405 02:09:53< celticminstrel> I'm going to assume that means it does work. 20160405 02:16:58< celticminstrel> vultraz: I'm adding proper Lua API for [lift|reset_fog]'s functionality. Do you think it's better for it to take a single side parameter, or a list of sides? 20160405 02:46:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 02:50:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds] 20160405 02:53:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20160405 03:17:04 * celticminstrel opts for accepting both. 20160405 03:24:24-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20160405 03:57:27-!- irker183 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20160405 04:02:07-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has joined #wesnoth-dev 20160405 04:15:58-!- Kwandulin [~Miranda@p200300760F0D01255C638A42DC1F62F7.dip0.t-ipconnect.de] has joined #wesnoth-dev 20160405 04:20:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20160405 04:37:49-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev 20160405 04:53:00< celticminstrel> ...why does the storyscreen reimplement [if] and [switch]? :| 20160405 04:53:13< celticminstrel> And [deprecated_message] and [wml_message]... 20160405 04:54:58< celticminstrel> I guess it's kind of nontrivial to defer to the default implementation though... :/ 20160405 04:58:45< vultraz> [if] and such are reimplemented in the code as necessary, I believe 20160405 04:58:47< vultraz> I don't like it 20160405 04:59:26< celticminstrel> The logic of the [if] and [switch] are the same, but the valid contents are not. 20160405 04:59:33< celticminstrel> That is, they don't contain ActionWML. 20160405 04:59:42< celticminstrel> They contain storyscreen WML. 20160405 05:00:00< celticminstrel> is/are, whatever 20160405 05:00:26< celticminstrel> ...maybe I should add get_sound_source too... 20160405 05:08:16-!- Kwandulin [~Miranda@p200300760F0D01255C638A42DC1F62F7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20160405 05:11:00< celticminstrel> One random annoying thing about the Lua - there are two completely different ways of registering essential metatables. 20160405 05:11:43< celticminstrel> For some, the metatable is stored in the Lua registry using an arbitrary pointer key. For others, the auxiliary library mechanism is used, which I believe stores it as a string key. 20160405 05:17:31< celticminstrel> vultraz, aeth, anyone else who's interested: Any opinions on the Lua API for map location operations? They're defined in src/scripting/lua_map_location_ops.cpp and are currently undocumented (because they might be a bit rough around the edges or something) and unused in mainline. I can also try to explain the API if anyone doesn't want to look at the C++ implementations. 20160405 05:18:27< vultraz> What are these operations? 20160405 05:18:52< celticminstrel> Is that a request to describe them> 20160405 05:18:53< celticminstrel> ^? 20160405 05:19:17< vultraz> Generally, what do they do? 20160405 05:19:37< celticminstrel> Operations on locations - rotate, distance, adjacent, vector ops. 20160405 05:19:43< celticminstrel> Directions. 20160405 05:20:01< celticminstrel> I'm a little unsure why vector operations are included, honestly... 20160405 05:20:13< celticminstrel> Locations can be treated as vectors, but they aren't really vectors... 20160405 05:21:21< vultraz> Stuff like this? https://github.com/Vultraz/Shadows_of_Deception/blob/master/lua/hex.lua 20160405 05:21:25< celticminstrel> It's largely a direct translation of things defined in the map_location class. 20160405 05:21:49 * celticminstrel clicks. 20160405 05:21:58< vultraz> (code credit to mattsc) 20160405 05:22:11 * celticminstrel waits for Firefox to respond. Might take awhile. :/ 20160405 05:24:46< vultraz> SlowFox 20160405 05:24:51< celticminstrel> Heh. 20160405 05:25:09< celticminstrel> I'm not quite sure, but I think at least hex_facing is probably covered. 20160405 05:25:19 * celticminstrel checks. 20160405 05:25:56< celticminstrel> Hmm... not quite the same, but I think wesnoth.map_location.get_direction could be used to implement it in one or two lines. 20160405 05:26:06< celticminstrel> Or maybe it is the same... 20160405 05:26:39< celticminstrel> Ah, no, get_direction takes a location and a direction and returns the other hex; your hex_facing takes two hexes and returns the direction. 20160405 05:26:46< celticminstrel> Actually, that'd be something worth adding to this. 20160405 05:28:31< celticminstrel> I definitely think the API needs work. 20160405 05:33:36 * celticminstrel blinks at soundsource.cpp:111,116 20160405 05:33:46< celticminstrel> ^100-116 20160405 05:34:09< celticminstrel> Is it my imagination or is that writing all the sound sources and then only returing the first one? 20160405 05:34:30< celticminstrel> ^returning 20160405 05:34:33< vultraz> looks like you're right 20160405 05:35:17< vultraz> great job, whoever named that class simply 'manager' :( 20160405 05:35:39< vultraz> How do we check if that function is called anywhere 20160405 05:35:44< celticminstrel> Yeah, there's four or five classes called "manager", all in different namespaces. It seems to be a popular name. 20160405 05:36:11< celticminstrel> Here's how to determine if a function is called somewhere: comment out its declaration in the header, and try to build. :P 20160405 05:36:32< celticminstrel> (Could comment the definition too, just in case it's called in the same source file; this only really matters if it's not a class function though.) 20160405 05:38:26< vultraz> I just pulled your last commit to functional.hpp 20160405 05:38:39< celticminstrel> The one that fixed zookeeper's build? 20160405 05:38:43< vultraz> yes 20160405 05:39:08< celticminstrel> Is there any particular reason you're saying this? 20160405 05:39:53< vultraz> [09:31:29] celticminstrel ...oh, whoops, I think that other commit wasn't read to push. 20160405 05:39:54< vultraz> [09:31:34] celticminstrel ^ready 20160405 05:39:56< vultraz> [09:33:39] celticminstrel Yeah, definitely wasn't. I'll fix asap. 20160405 05:40:07< celticminstrel> That was about the WML tags commit. 20160405 05:40:13< vultraz> ah, ok 20160405 05:40:23< vultraz> I was going to ask if it would break stuff 20160405 05:40:31< celticminstrel> I split them into separate files but forgot to add the require lines at the top. 20160405 05:40:51< celticminstrel> I think I already pushed the fix, right? 20160405 05:41:04< vultraz> ah, yes, you did 20160405 05:41:06< vultraz> ok 20160405 05:41:16< vultraz> Going to see if that to_config function is used anywhere 20160405 05:42:15< vultraz> I'll work on the screenshot function consolidation later. 20160405 05:42:29< vultraz> Still pondering the best way to do it. 20160405 05:42:33< celticminstrel> Hopefully the save code calls write_sourcespecs instead of to_config. I think that would do the right thing, anyway. (Not sure what the load code looks like though.) 20160405 05:43:35< vultraz> write_sourcespecs() is called once 20160405 05:43:56< vultraz> in play_controller::to_config() 20160405 05:44:07< vultraz> (everyone loves the function name 'to_config' :P ) 20160405 05:44:14< celticminstrel> Yup. 20160405 05:45:39< vultraz> Note to self: make Language selection use a proper toggle panel 20160405 05:46:01< vultraz> It uses a listbox of toggle button right no 20160405 05:46:03< vultraz> w 20160405 05:46:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 05:47:00< vultraz> should check if other dialogs do that.. 20160405 05:50:58-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev 20160405 05:51:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds] 20160405 05:52:14 * vultraz groans 20160405 05:53:05< vultraz> celticminstrel: looks like to_config exists because of savegame::savegame_config::to_config(), which is pure virtual. 20160405 05:54:22< celticminstrel> I see... that just makes it harder to determine if it's called anywhere... :| 20160405 05:55:08< celticminstrel> Well, try removing the inheritance and see what happens, maybe? 20160405 05:57:16< celticminstrel> If that causes too many errors, I think what I would recommend is changing savegame::savegame_config so that it has "void write_config(config& cfg) const" instead of "config to_config() const". Then write_sourcespecs can be renamed to write_config and stuff. 20160405 06:04:53< vultraz> celticminstrel: commenting out the pure-virtual to_config in the class causes no errors 20160405 06:05:14< celticminstrel> vultraz: But it might cause problems if other classes overrode it. 20160405 06:05:26< celticminstrel> ^other subclasses 20160405 06:05:40< celticminstrel> Assuming there are other subclasses. 20160405 06:06:08 * celticminstrel greps on that. 20160405 06:06:40< vultraz> 8 classes inherited from that class 20160405 06:06:46< celticminstrel> Yeah. 20160405 06:06:59< vultraz> But since it was pure-virtual, does it matter? 20160405 06:07:20< celticminstrel> Hmm... do any classes inherit from subclasses of savegame_config? 20160405 06:07:42< celticminstrel> If the answer is no, then I'd say it doesn't matter. Though I still think it would make sense to switch it to write_config. 20160405 06:08:38< vultraz> so I'm guessing each inherited class had its own to_config member 20160405 06:08:52< celticminstrel> Presumably. 20160405 06:09:10< vultraz> hm, yes 20160405 06:09:16< vultraz> and they're useful in those cases 20160405 06:09:25< celticminstrel> I wonder why there are no calls to savegame_config::to_config though... 20160405 06:09:50< vultraz> I dunno.. 20160405 06:10:12< vultraz> what would you recommend we do 20160405 06:11:01< celticminstrel> What else does savegame_config define? 20160405 06:11:43< celticminstrel> I would think the point of having savegame_config would be so that you can just iterate over all saveable things... 20160405 06:11:45< vultraz> virtual destructor 20160405 06:11:51< celticminstrel> That's it? 20160405 06:11:53< vultraz> and that's it 20160405 06:12:08< celticminstrel> It doesn't even have a deserialization function... 20160405 06:12:21< vultraz> a virtual destructor and to_config 20160405 06:12:29< vultraz> I think we can remove this class, tbh 20160405 06:12:55< celticminstrel> Well, I was thinking that too, honestly, but I also kinda want to know if it could be made actually useful... 20160405 06:14:05< celticminstrel> Which means... finding all calls to to_config() that are overridden from savegame_config (and only those to_config() calls; there's also tons of other to_config(), I think). 20160405 06:14:39< celticminstrel> If these calls are all basically clustered in one place... 20160405 06:14:59< celticminstrel> Then the class can be made useful. If not... we might as well just remove it, honestly. 20160405 06:15:32< celticminstrel> (Well, they don't all have to be clustered in one place, but there should be at least one place that calls it on several subclasses of savegame_config.) 20160405 06:17:00< celticminstrel> I want to port the [get|set|clear_global_variable] tags to Lua so that Lua has a proper API to them, but... these look pretty messy... maybe later... 20160405 06:17:05< vultraz> no way to tell 20160405 06:17:18< vultraz> there are 173 cases of to_config 20160405 06:17:36< celticminstrel> Oh, that sounds like few enough to scan through the whole list. I'll grep it. 20160405 06:17:49< vultraz> ...few?? 20160405 06:18:10< celticminstrel> I can ignore anything in src/ai... 20160405 06:18:16< vultraz> apparently unit_filter_abstract_impl ALSO has a virtual to_config member :| 20160405 06:18:19< celticminstrel> ...which seems to have most of them... 20160405 06:18:35< vultraz> and wb::action.. 20160405 06:18:43< celticminstrel> I think I added that recently, can't remember why though. (In the unit filter.) 20160405 06:20:45< celticminstrel> Okay, I don't see anything that looks like a cluster of them (though I did skip through the AI code). Let's just remove the class. 20160405 06:21:05< celticminstrel> And of course remove the function altogether in the soundsource manager. 20160405 06:25:21-!- irker188 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20160405 06:25:21< irker188> wesnoth: Celtic Minstrel wesnoth:master ff618e7eb3ca / src/scripting/game_lua_kernel.cpp: Eliminate resources.hpp usage in game_lua_kernel https://github.com/wesnoth/wesnoth/commit/ff618e7eb3cac51cb723bf221ae577e687c49ae7 20160405 06:25:21< irker188> wesnoth: Celtic Minstrel wesnoth:master 5cf12798ce83 / / (11 files in 7 dirs): Port "trivial" WML tags to Lua https://github.com/wesnoth/wesnoth/commit/5cf12798ce832a270861bdbe02b339599b2cb9c5 20160405 06:25:34< celticminstrel> ...and now I forgot what I was going to do next... :| 20160405 06:26:12< celticminstrel> I feel like there was some trivial thing I wanted to do... oh well, I'll probably think of it again soon enough. 20160405 06:36:50-!- travis-ci [~travis-ci@ec2-54-92-198-131.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 06:36:51< travis-ci> wesnoth/wesnoth#9200 (master - 5cf1279 : Celtic Minstrel): The build is still failing. 20160405 06:36:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120821135 20160405 06:36:51-!- travis-ci [~travis-ci@ec2-54-92-198-131.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 06:37:06< celticminstrel> :/ 20160405 06:38:08-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has quit [Ping timeout: 250 seconds] 20160405 06:38:18< celticminstrel> Well, it's possible that src/gui/dialogs/addon/description.cpp is missing an include of or ... 20160405 06:38:58< celticminstrel> Oh, right, the strcpy issue is confusing clang. 20160405 06:41:47< vultraz> the hell?? 20160405 06:41:52< celticminstrel> ?? 20160405 06:42:46< irker188> wesnoth: Celtic Minstrel wesnoth:master ce7cd0191a81 / src/gui/dialogs/ (addon/description.cpp lua_interpreter.cpp): Attempt to fix Travis build https://github.com/wesnoth/wesnoth/commit/ce7cd0191a811a12c84f18debc7c1f2300e80ec1 20160405 06:42:55< vultraz> so I started IftU to test the soundsources, and this happened: http://pastebin.com/V98VxHMK 20160405 06:43:08< vultraz> then, when I saved and reloaded, wesnoth crashed :| 20160405 06:43:24< celticminstrel> Huh. 20160405 06:44:48< celticminstrel> Well, something clearly happened while it was trying to show a dialog, and it looks like the thing that happened is unrelated to the dialog... 20160405 06:45:21< vultraz> do we have any mainline scenarios with soundsources 20160405 06:46:06< celticminstrel> EI and LoW, apparently. 20160405 06:46:31< celticminstrel> And there's one in the test scenario. 20160405 06:46:45< celticminstrel> I don't know which scenarios in EI and LoW use them. They're in utility files. 20160405 06:49:58< vultraz> hm 20160405 06:50:04< vultraz> ok, so it's not a soundsource crash.. 20160405 06:50:29< celticminstrel> Might be GUI2 related, or might be some weird fluke. 20160405 06:50:30< vultraz> ok 20160405 06:50:36< vultraz> it's not a fluke 20160405 06:50:40< vultraz> it happens in my campaign too 20160405 06:50:44< celticminstrel> I see. 20160405 06:50:57< celticminstrel> Does that stack trace also contain show_dialog? 20160405 06:51:07< vultraz> sod, iftu, and ats all have dialogs that open when you start the campaign 20160405 06:51:17< vultraz> basically warning about 1.13 support not being good 20160405 06:51:30< celticminstrel> Given the boost thread mention in the error, I'd hazard a guess that the loading screen may be somehow related to the error. 20160405 06:51:34< vultraz> quite possible 20160405 06:51:38< celticminstrel> Unless Boost threads are used elsewhere too. 20160405 06:51:50< celticminstrel> Does the dialog appear in start or prestart? 20160405 06:52:13< vultraz> uhhh 20160405 06:52:42< celticminstrel> I was just thinking that perhaps prestart is fired before the loading screen is closed. 20160405 06:52:55< vultraz> neither 20160405 06:52:57< celticminstrel> During the "starting game" stage. 20160405 06:53:01< celticminstrel> Then, where? 20160405 06:53:44< vultraz> They're custom WML actions fired from lua files included in the main preprocessor chunk 20160405 06:53:59< celticminstrel> Huh? 20160405 06:54:10< vultraz> so I have #ifdef CAMPAIGN_SHADOWS_OF_DECEPTION 20160405 06:54:20< vultraz> then inside it, 20160405 06:54:22< vultraz> [lua] 20160405 06:54:23< vultraz> code="wesnoth.require '{NX_DIR}/lua/main.lua'" 20160405 06:54:25< vultraz> [/lua] 20160405 06:54:43< vultraz> and main.lua does wesnoth.require on another lua file 20160405 06:54:51< vultraz> which checks the game version 20160405 06:55:10< vultraz> and pops up a dialog if necessary 20160405 06:55:19< vultraz> before, it used to show up... before the storyscreen 20160405 06:55:21< vultraz> I think 20160405 06:55:31< celticminstrel> Okay, so what you're saying seems to be that the dialog is shown during Lua engine initialization. 20160405 06:55:40< vultraz> now it will flash onscreen for a second then vanish with that error 20160405 06:55:43< vultraz> yeah, basically 20160405 06:55:45< celticminstrel> Which would, indeed, be before the loading screen closes. 20160405 06:56:14< vultraz> I can change the behavior of this dialog in my campaign 20160405 06:56:17< celticminstrel> Can it be reproduced with one of the two simple-dialog functions? 20160405 06:56:28< vultraz> eh? 20160405 06:56:42< celticminstrel> The functions used by the [message] and [object] implementations. 20160405 06:56:57< vultraz> I have not tested 20160405 06:57:24-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20160405 06:57:37< celticminstrel> Travis didn't announce again... 20160405 06:57:39< celticminstrel> :/ 20160405 06:58:02< celticminstrel> Ah, it's still going, okay. Maybe that's a good sign then. 20160405 06:58:19< celticminstrel> Though the GCC and C++14 builds already failed... 20160405 06:58:49< celticminstrel> ...GCC is still complaining about out_of_range... :| 20160405 06:58:53< celticminstrel> ...oh, in a different file. 20160405 06:59:19< vultraz> Don't commit for a few minues 20160405 06:59:24< celticminstrel> Okay. 20160405 06:59:25< vultraz> I'm building then I'm going to push this 20160405 06:59:34< celticminstrel> I want to wait until the build finishes, anyway. 20160405 06:59:46< celticminstrel> In case clang also fails and I have to fix something else. 20160405 07:08:21 * vultraz wishes he had a faster PC 20160405 07:08:28< celticminstrel> Me too. 20160405 07:09:25< vultraz> I could buy a new one if I wanted, but I just got this one back in 2013 20160405 07:10:07< vultraz> so dropping ~$1k on a new one less than three years later would kinda be a waste 20160405 07:10:13< celticminstrel> I actually have a new one, just don't use it much because it's a little inconvenient... and also a different platform. 20160405 07:11:19< celticminstrel> Hmm, unit test failures. 20160405 07:11:46< celticminstrel> I think I probably broke [find_path]. 20160405 07:11:57< irker188> wesnoth: Charles Dang wesnoth:master 71b154b6e300 / / (15 files in 3 dirs): Refactored out savegame::savegame_config class https://github.com/wesnoth/wesnoth/commit/71b154b6e300aa3e6d2f1e0af20960d6dd5b2d3a 20160405 07:12:11< vultraz> might want to see if it was included in xcode 20160405 07:12:37< celticminstrel> The others are timeouts, so it could be a fluke that passes on the next build... 20160405 07:12:42< celticminstrel> Or it could be something else. 20160405 07:13:26< celticminstrel> Uh. What. I accidentally committed an older revision of [wml_message] somehow? 20160405 07:14:02< celticminstrel> Oh, I see. Whoops. 20160405 07:14:03< vultraz> good, that is not 20160405 07:14:12-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 07:14:13< travis-ci> wesnoth/wesnoth#9201 (master - ce7cd01 : Celtic Minstrel): The build is still failing. 20160405 07:14:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120823591 20160405 07:14:13-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 07:14:16< celticminstrel> Not exactly an older revision, but... 20160405 07:14:55< celticminstrel> All the unit test failures are the same cause. 20160405 07:15:03 * vultraz looks into this screenshot business 20160405 07:16:05< vultraz> make_screenshot is what spits out error dialogs.. 20160405 07:16:13< vultraz> I wonder if that should be handled by display::screenshot 20160405 07:16:21< vultraz> Probably 20160405 07:16:34< celticminstrel> Well, if display::screenshot is only called in that one place, then sure.3 20160405 07:17:21< vultraz> then again, what about command line.. 20160405 07:17:40< celticminstrel> Hmm, XCode is indexing hundreds of files again. I think I'll sleep before trying again to finish the [on_undo] thing. 20160405 07:18:43-!- celticminstrel is now known as celmin|sleep 20160405 07:19:56< vultraz> this is more complicated than I thought :| 20160405 07:20:58< celmin|sleep> Unsurprising. 20160405 07:21:25< irker188> wesnoth: Celtic Minstrel wesnoth:master 7ee37b6f84d1 / data/lua/wml-tags.lua src/gui/dialogs/addon/list.cpp: Attempt to fix Travis build https://github.com/wesnoth/wesnoth/commit/7ee37b6f84d1ccbb13253b991a1719864c304145 20160405 07:35:52-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has joined #wesnoth-dev 20160405 07:39:26-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 07:39:27< travis-ci> wesnoth/wesnoth#9202 (master - 71b154b : Charles Dang): The build has errored. 20160405 07:39:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120827415 20160405 07:39:27-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 07:45:08-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 07:45:09< travis-ci> wesnoth/wesnoth#9203 (master - 7ee37b6 : Celtic Minstrel): The build is still failing. 20160405 07:45:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120828695 20160405 07:45:09-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 08:17:15-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has quit [Ping timeout: 264 seconds] 20160405 08:29:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 08:33:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds] 20160405 08:52:09-!- mjs-de [~mjs-de@x4e35b410.dyn.telefonica.de] has joined #wesnoth-dev 20160405 08:59:42-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has joined #wesnoth-dev 20160405 09:12:06-!- mjs-de [~mjs-de@x4e35b410.dyn.telefonica.de] has quit [Remote host closed the connection] 20160405 09:12:10 * vultraz pings Aginor 20160405 09:17:53< vultraz> Aginor: so I'd like to do a little cleanup of display::screenshot() 20160405 09:18:31< vultraz> Aginor: I *think* I refactor out the class member variables map_screenshot_ and map_screenshot_surf_, but I'm not 100% sure 20160405 09:19:25< vultraz> Aginor: for the former, why is uses as an early-exit switch in map_area()? The screenshot function uses max_map_area(). 20160405 09:20:01< vultraz> Aginor: and why does it need to call draw() before saving the surface? 20160405 09:20:29< vultraz> Aginor: for that matter, why can't map_screenshot_surf_ be a function-local surface variable. It isn't used anywhere else. 20160405 09:20:48< vultraz> I dunno how this would conflict with your work, so I'm checking with you first. 20160405 09:23:18-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20160405 09:26:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds] 20160405 09:26:13-!- wedge010 is now known as wedge009 20160405 09:30:16-!- prkc [~prkc@46.166.188.223] has quit [Ping timeout: 244 seconds] 20160405 09:44:30-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has joined #wesnoth-dev 20160405 09:53:13-!- Appleman1234 [~Appleman1@KD106161139076.au-net.ne.jp] has joined #wesnoth-dev 20160405 09:59:13-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has quit [Ping timeout: 252 seconds] 20160405 10:05:18-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 248 seconds] 20160405 10:10:43-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev 20160405 10:13:00-!- prkc [~prkc@46.166.190.218] has joined #wesnoth-dev 20160405 10:19:44-!- Nobun [~nobun@5.170.194.128] has joined #wesnoth-dev 20160405 10:21:05< Nobun> loonycyborg: I developed the extra-tool 'wescheck.py' wich is helping me a lot to investigate the bugs you have reported, so here is a brief summary: 20160405 10:21:35-!- irker188 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20160405 10:22:09< Nobun> 1) The first bug you reported (sometimes there are missed translatable strings) were actually two different bugs, both now are solved 20160405 10:23:25< Nobun> 2) the second bug (some extra informations for translators dropped by python wmlxgettext) is still open, and I will work to solve it 20160405 10:23:45< loonycyborg> ok cool 20160405 10:24:02< Nobun> I have to report a thing around the second bug: 20160405 10:24:16< Nobun> the feature is also bugged in perl wmlxgettext 20160405 10:25:09< Nobun> the extra information, infact, should displayed only at the translatable string where the extra information make sense 20160405 10:25:51< Nobun> perl wmlxgettext fails on it since it writes the additional information also in strings where the additional information has no sense 20160405 10:26:18< Nobun> my wmlxgettext version, instead, at the moment, failed at all on collecting those additional information 20160405 10:27:49< Nobun> I will investigate why my code does not actually print this info 20160405 10:28:28< Nobun> in the meantime, if you want (but it is purely optional) you can try wescheck.py (it is published in wmlxgettext-unoff repository) 20160405 10:29:02< Nobun> it is slow but cool (more or less it emulates the pot-update target with perl wmlxgettext, python wmlxgettext, running poreorder.py and making diffs) 20160405 10:30:06< Nobun> well... I will let you know when the 'additional information for translator' bug will be solved :) 20160405 10:30:15< Nobun> thank again for bug reporting :) 20160405 10:35:49-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev 20160405 10:35:56-!- Nobun [~nobun@5.170.194.128] has quit [Quit: Salve a tutti] 20160405 10:55:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 11:00:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20160405 11:01:21-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV] 20160405 11:26:15-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds] 20160405 11:26:39-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev 20160405 11:26:39-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host] 20160405 11:26:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20160405 11:53:35-!- Kwandulin [~Miranda@p200300760F0D01251CD0DCF2FC6924D8.dip0.t-ipconnect.de] has joined #wesnoth-dev 20160405 12:34:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20160405 12:37:49-!- Kwandulin [~Miranda@p200300760F0D01251CD0DCF2FC6924D8.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds] 20160405 12:41:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds] 20160405 12:49:04-!- gfgtdf [~chatzilla@x4e3683e7.dyn.telefonica.de] has joined #wesnoth-dev 20160405 12:53:11< gfgtdf> vultraz: hmm yes we should give a error message instead of that crash when people attempt do so suhc things during lua initialitation 20160405 12:53:35< vultraz> gfgtdf: it is an error message 20160405 12:53:45< vultraz> gfgtdf: it crashes when realoding a save of the game 20160405 12:55:07< gfgtdf> vultraz: hm what error message you get ? 20160405 12:55:34< vultraz> http://pastebin.com/V98VxHMK 20160405 12:56:12< gfgtdf> vultraz: hmm yes thats clearny not a good error message :) 20160405 12:56:37< gfgtdf> vultraz: actually this erro mostlikeley shouldn't be swallowed by lua and mkae teh game quit instead 20160405 12:56:58< gfgtdf> vultraz: we shoudl give abetter message like 'you cannot use dialog now' or something 20160405 12:58:30< vultraz> yeah 20160405 12:58:35< vultraz> and it shouldn't corrupt saves 20160405 13:00:12< gfgtdf> celmin|sleep: you want to add event information in on_undo code ? 20160405 13:02:15-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has quit [Ping timeout: 264 seconds] 20160405 13:02:56-!- mjs-de [~mjs-de@x4e35b410.dyn.telefonica.de] has joined #wesnoth-dev 20160405 13:04:50-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has joined #wesnoth-dev 20160405 13:08:40< gfgtdf> celmin|sleep: did you fix http://gna.org/bugs/?24550 ? 20160405 13:09:13< gfgtdf> vultraz: i actually wonder why sp campaigns need to do version checks ? 20160405 13:09:32< vultraz> it's just a thing in mine and shadowms so people wouldn't play them on 1.13 20160405 13:13:25< gfgtdf> vultraz: is thata wesnoth.show_dialog dialog ? 20160405 13:13:28< vultraz> basically it inserted a prestart event that then quit the scenario 20160405 13:13:51< vultraz> yes 20160405 13:14:16< gfgtdf> vultraz: hmm it already inserts a prestart event is shouldnt be hard to mode teh dialog showing there too 20160405 13:15:17< vultraz> well it inserts the prestart event based on the result of the dialog 20160405 13:15:21< vultraz> but i can change that 20160405 13:19:27< vultraz> celmin|sleep: didn't you fix this https://gna.org/bugs/?24548 20160405 13:22:09-!- Netsplit *.net <-> *.split quits: zookeeper, Elsi 20160405 13:24:05-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev 20160405 13:24:05-!- Netsplit over, joins: Elsi 20160405 13:36:07< celmin|sleep> gfgtdf: Yes. 20160405 13:36:32< gfgtdf> celmin|sleep: there were multiple questions. 20160405 13:40:54< vultraz> celmin|sleep: I wonder if we can use strictly typed enums for anything.. 20160405 13:43:20< celmin|sleep> gfgtdf: Oh, I mistook the bug posting as being from vultraz, because he also posted one. 20160405 13:43:30< celmin|sleep> I haven't looked at either of the posted bugs yet. 20160405 13:45:05< celmin|sleep> ...wow, this whiteboard code really is broken. Why are the compilers accepting it... :| 20160405 13:45:10-!- zookeeper_ is now known as zookeeper 20160405 13:45:12-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host] 20160405 13:45:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20160405 13:45:41< vultraz> god, my WML for the custom TOD window is horrendous 20160405 13:45:45< vultraz> I was a noob back then 20160405 14:09:24< celmin|sleep> gfgtdf, vultraz: Why do we have to say "you can't use a dialog now"? 20160405 14:09:25-!- Kwandulin [~Miranda@p200300760F0D01AA0C310779DB880CD4.dip0.t-ipconnect.de] has joined #wesnoth-dev 20160405 14:10:06< vultraz> celmin|sleep: I think he means disabling dialogs before preshow (maybe preload?) 20160405 14:10:19< celmin|sleep> I know. 20160405 14:11:17-!- irker269 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20160405 14:11:17< irker269> wesnoth: Celtic Minstrel wesnoth:master e1534f068659 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/e1534f068659bf134888d470ebf44518da79e35f 20160405 14:11:17< irker269> wesnoth: Celtic Minstrel wesnoth:master 73739a1989f0 / / (4 files in 2 dirs): Attempt to fix Travis build... again https://github.com/wesnoth/wesnoth/commit/73739a1989f0e92d880904330f80c4fd04f1f589 20160405 14:11:24< vultraz> either that, or we'd have to delay any dialogs until the loadscreen thread is complete 20160405 14:12:14< celmin|sleep> Oh, I forgot I also had the XCode update pending. 20160405 14:14:57< celmin|sleep> gfgtdf: Can you confirm if the bug that vultraz posted has been fixed? 20160405 14:23:36-!- celmin|sleep is now known as celticminstrel 20160405 14:24:08-!- gfgtdf [~chatzilla@x4e3683e7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]] 20160405 14:24:09< irker269> wesnoth: Charles Dang wesnoth:master b7b8b1e213d1 / / (6 files in 4 dirs): tcustom_tod: cleaned up code and unused related preference keys https://github.com/wesnoth/wesnoth/commit/b7b8b1e213d1a176ad685d5205538639a127d679 20160405 14:24:16< vultraz> purely a cleanup commit 20160405 14:25:02< celticminstrel> It's impossible to see the diff. :( 20160405 14:25:21< vultraz> what do you mean? 20160405 14:25:34< celticminstrel> You changed all of the whitespace, so the diff is everything. 20160405 14:25:52< celticminstrel> ...actually, I can probably see the real diff in SourceTree. I can tell it to ignore whitespace. 20160405 14:26:00< vultraz> In the WML file only 20160405 14:26:09< celticminstrel> That's what I'm talking about. 20160405 14:26:21< celticminstrel> I didn't even get past that. 20160405 14:26:27< vultraz> ah 20160405 14:27:17< celticminstrel> The ignoring-whitespace-diff seems to imply that a row was removed. 20160405 14:27:51< celticminstrel> Or maybe two. I dunno. 20160405 14:28:29< celticminstrel> I guess the removed functions were unused. 20160405 14:28:35< vultraz> nested grids were removed 20160405 14:28:47< vultraz> basically 20160405 14:28:57-!- Kwandulin_2 [~Miranda@p200300760F0D01AA0C310779DB880CD4.dip0.t-ipconnect.de] has joined #wesnoth-dev 20160405 14:28:58< vultraz> yes, those pref functions were unused 20160405 14:29:06< vultraz> relics of the old Editor Preferences 20160405 14:29:16< vultraz> on whose code I originally coded this dialog 20160405 14:29:58< celticminstrel> And you removed the commented bit. 20160405 14:30:07< vultraz> yes 20160405 14:30:15< vultraz> better to do what I now have in post_show 20160405 14:30:25< celticminstrel> Which is currently nothing though. :P 20160405 14:30:29< vultraz> right :P 20160405 14:30:55< celticminstrel> Okay, back to [on_undo]. 20160405 14:31:17< vultraz> I still haven't figured out why holding down the sliders in this dialog specifically makes them continuously move leftwards 20160405 14:31:32-!- Kwandulin [~Miranda@p200300760F0D01AA0C310779DB880CD4.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds] 20160405 14:31:40< zookeeper> celticminstrel, what were you planning for it, again? 20160405 14:32:02< celticminstrel> zookeeper: Access to auto-stored variables as a "snapshot" of their state in the event. 20160405 14:32:32< zookeeper> right 20160405 14:35:12< celticminstrel> zookeeper: If I'm not mistaken, the $x1,$x2,$y1,$y2 variables are not scoped and thus leak out beyond the event they apply to. Should I change this? Do you think it would break a lot of things to do so? 20160405 14:43:32 * vultraz makes use of a strictly-typed enum 20160405 14:47:55< vultraz> hm 20160405 14:47:58< vultraz> maybe I'm doing this wrong 20160405 14:51:52< vultraz> celticminstrel: so I guess you can't use an enum value by its integral type without casting it? 20160405 14:52:08< celticminstrel> Yes. 20160405 14:52:26< celticminstrel> Enums cannot be implicitly cast to anything. 20160405 14:52:30< celticminstrel> Wait, no. 20160405 14:52:34< celticminstrel> From anything. 20160405 14:52:59< celticminstrel> They can be implicitly cast to integers, unless they're class enums, I think. 20160405 14:53:12< vultraz> heh 20160405 14:53:46< vultraz> ironically, in this case I want to use a class enum and implicitly cast it to ints. 20160405 14:54:07< celticminstrel> Then I'd say don't use a class enum, honestly. 20160405 14:54:21< celticminstrel> If you want the extra scoping you can wrap it in a namespace or something. 20160405 14:54:30< celticminstrel> What exactly do you want it for, BTW? 20160405 14:55:00< celticminstrel> (Actually, you can use scope qualification for non-class enums, it's just not compulsory.) 20160405 14:55:44< vultraz> I thought this could be made a class enum https://github.com/wesnoth/wesnoth/blob/master/src/editor/editor_preferences.hpp#L25 20160405 14:57:24< vultraz> but I can't, since I'd need to static_cast every call 20160405 14:58:42< celticminstrel> How are they used? 20160405 14:58:48< vultraz> (not sure how that renders strictly typed enums useful at all, except for comparing enum values...) 20160405 14:59:04< vultraz> as ints 20160405 14:59:07< celticminstrel> If they're not used for a bitfield, you can probably do it. 20160405 14:59:09< vultraz> for example, in a switch() block 20160405 14:59:48< celticminstrel> What's preventing you from changing function arguments or return types to the new scoped enum type? 20160405 14:59:58< celticminstrel> Is there anything? Does it use bitwise operators on them? 20160405 15:00:07< celticminstrel> Like | for example. 20160405 15:00:31< vultraz> hmm 20160405 15:00:35< vultraz> that's an idea 20160405 15:09:15-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20160405 15:17:33-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 15:17:34< travis-ci> wesnoth/wesnoth#9206 (master - 73739a1 : Celtic Minstrel): The build has errored. 20160405 15:17:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120900131 20160405 15:17:34-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 15:19:58< celticminstrel> Argh. Now I don't even know if it worked. 20160405 15:20:19< celticminstrel> The install phase failed. 20160405 15:21:28< celticminstrel> It couldn't find any of the packages... :| 20160405 15:21:42< celticminstrel> I hope that's just a weird fluke, like a network connection issue or something. 20160405 15:30:56< zookeeper> celticminstrel, i'm not sure. i can't see it breaking a lot, since one _should_ treat them as if they were scoped. 20160405 15:31:40< zookeeper> i don't see a reason to "fix" that unless it somehow clears up the code too 20160405 15:32:01< zookeeper> since it's not like it has any undesirable side-effects AFAICT 20160405 15:34:04< vultraz> what's % do again? 20160405 15:34:57< celticminstrel> Do you mean the modulus operator? 20160405 15:35:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 15:36:21< vultraz> ah, yes 20160405 15:36:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer] 20160405 15:36:23< vultraz> that 20160405 15:37:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 15:38:21-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has joined #wesnoth-dev 20160405 15:38:22< travis-ci> wesnoth/wesnoth#9207 (master - b7b8b1e : Charles Dang): The build is still failing. 20160405 15:38:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/120902964 20160405 15:38:22-!- travis-ci [~travis-ci@ec2-54-167-84-216.compute-1.amazonaws.com] has left #wesnoth-dev [] 20160405 15:38:30< vultraz> ugh 20160405 15:38:36 * vultraz checks travis 20160405 15:38:52< celticminstrel> Well, at least the error was a fluke. 20160405 15:38:59< celticminstrel> Oh, one build passed. That's an improvement. 20160405 15:39:40< celticminstrel> GCC build worked but broke unit tests somehow. 20160405 15:39:58< celticminstrel> Hmm. 20160405 15:40:11< celticminstrel> Maybe I broke unit tests with the whiteboard change; I think there are whiteboard unit tests... 20160405 15:51:20< vultraz> blah. 20160405 15:51:32< vultraz> I'm really bad at refactoring code that actually means changing things :P 20160405 15:54:57< vultraz> I'm not sure if there's supposed to be a hotkey that cycles through update modes.. 20160405 15:56:56-!- Kwandulin_2 [~Miranda@p200300760F0D01AA0C310779DB880CD4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20160405 16:00:35-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has quit [Ping timeout: 248 seconds] 20160405 16:04:12 * vultraz gives up 20160405 16:04:19< celticminstrel> Aww. 20160405 16:04:35< vultraz> Too many things touch the code 20160405 16:05:03< vultraz> Plus, I've been spoiled by our MAKE_ENUM enums and keep forgetting how actual enums work :| 20160405 16:05:04< celticminstrel> Argh, I might have to include config.hpp in another header... 20160405 16:06:09< vultraz> I thought I could use a class enum like an associative string value list :| 20160405 16:06:11< vultraz> you cannot 20160405 16:06:28< celticminstrel> Maybe you can, what exactly do you mean? 20160405 16:07:14< vultraz> something like enum class foo : std::string { A = "a" }; 20160405 16:07:30< vultraz> but that doesn't build, since std::string isn't an integer type 20160405 16:08:14< celticminstrel> Uh okay. 20160405 16:08:29 * celticminstrel never even thought of such a thing. 20160405 16:10:20< vultraz> this is what happens: error: underlying type 'std::__cxx11::string {aka std::__cxx11::basic_string}' of 'preferences::editor::foo' must be an integral type| 20160405 16:10:31< vultraz> error: enumerator value for 'A' is not an integer constant| 20160405 16:11:48< celticminstrel> Yeah, you can't do that. 20160405 16:12:20< vultraz> that's why I said I got spoiled by our MAKE_ENUM enums :P 20160405 16:19:57< celticminstrel> Okay, I managed to avoid including config.hpp in synced_context.hpp, but still need it in undo_action.hpp. I think that's a decent compromise. 20160405 16:20:10< celticminstrel> undo_action.hpp isn't included in as many places, I think. 20160405 16:20:31< celticminstrel> (And some of those probably already included config.hpp anyway.) 20160405 16:27:12-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev 20160405 16:33:42-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has joined #wesnoth-dev 20160405 16:35:00-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20160405 16:38:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20160405 16:55:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 17:00:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds] 20160405 17:05:27-!- Horus2 [~Horus2@91.83.136.81.pool.invitel.hu] has joined #wesnoth-dev 20160405 17:15:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 17:19:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds] 20160405 17:24:20-!- irker269 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20160405 17:35:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 17:50:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20160405 18:18:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20160405 18:35:24-!- Kwandulin [~Miranda@p200300760F0D01AA68120034D957BE10.dip0.t-ipconnect.de] has joined #wesnoth-dev 20160405 18:37:54-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20160405 18:37:56-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer] 20160405 18:37:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20160405 18:46:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20160405 19:00:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20160405 19:33:21-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV] 20160405 19:37:01-!- Horus2 [~Horus2@91.83.136.81.pool.invitel.hu] has left #wesnoth-dev [] 20160405 20:25:30-!- Kwandulin [~Miranda@p200300760F0D01AA68120034D957BE10.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20160405 20:47:35-!- prkc [~prkc@46.166.190.218] has quit [Ping timeout: 244 seconds] 20160405 21:00:45-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has joined #wesnoth-dev 20160405 21:07:40-!- gfgtdf [~chatzilla@x4e3683e7.dyn.telefonica.de] has joined #wesnoth-dev 20160405 21:23:14-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev 20160405 21:26:15-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds] 20160405 21:26:16-!- wedge010 is now known as wedge009 20160405 21:52:14-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Excess Flood] 20160405 21:52:26-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev 20160405 22:05:42-!- mjs-de [~mjs-de@x4e35b410.dyn.telefonica.de] has quit [Remote host closed the connection] 20160405 22:22:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20160405 22:38:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20160405 22:39:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20160405 22:41:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 248 seconds] 20160405 22:42:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20160405 22:42:50-!- gfgtdf [~chatzilla@x4e3683e7.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]] 20160405 22:47:31-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev 20160405 22:47:59< ancestral> vultraz, mattsc, celticminstrel: FYI I’ve had to prioritize my work here. 20160405 22:48:15< ancestral> I am making an updated release of 1.13.4 that should fix the library bugs 20160405 22:48:31< ancestral> I am currently rebuilding gettext as it appears libintl isn’t 32-bit 20160405 22:48:55< ancestral> Once that’s done, I’ll push an update out and see if I can grab a few people to test it out 20160405 22:49:18< ancestral> Work on the trailer will have to get pushed to Thursday/Saturday, when I have time off again 20160405 22:58:14< ancestral> vultraz: Still wondering, are you planning on having links to dev builds on the front page of wesnoth.org again? 20160405 23:02:23< ancestral> celticminstrel: Also, something curious 20160405 23:02:39< ancestral> When I click the ‘i’ in the main menu screen, it shows supported features 20160405 23:03:01< ancestral> It shows Growl notifications and Cocoa notifications with X’s (presuming, not supported) 20160405 23:03:45< ancestral> Yet, I can prove Cocoa notifications are indeed working (maybe Growl too, though I don’t know of a test for it) 20160405 23:04:10< celticminstrel> Uhh. 20160405 23:04:31< celticminstrel> I think that only shows what features were supported at compile time? 20160405 23:04:57< celticminstrel> Do other things have checkmarks? 20160405 23:06:22< ancestral> Yes 20160405 23:06:29< ancestral> One of them is Lua console :) 20160405 23:06:35< ancestral> (since I added readline in there) 20160405 23:07:02< celticminstrel> I think checkmark means it's supported? 20160405 23:07:03< ancestral> (I think it’s PNG screenshots and Lua console are the two) 20160405 23:07:07< ancestral> Right 20160405 23:07:24< ancestral> So Cocoa notifications are working, but there’s a red X 20160405 23:07:59< ancestral> If I make a 4 player game and make 3 AI’s, end my turn and switch out of the app, I’ll get a notification that it’s my turn 20160405 23:25:27-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20160405 23:27:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds] 20160405 23:54:26-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev --- Log closed Wed Apr 06 00:00:03 2016