--- Log opened Thu Apr 07 00:00:20 2016
20160407 00:02:22-!- Appleman1234 [~Appleman1@KD118156079165.au-net.ne.jp] has joined #wesnoth-dev
20160407 00:10:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 268 seconds]
20160407 00:13:36< celticminstrel> Okay, so, it would be nice if we could deal with PRs 616, 629, 631, 641, 641, 643, and 644 soon.
20160407 00:14:08< celticminstrel> I think 641 should probably be closed. 629 could be closed too, since it was jsut something I brewed up in half an hour or something, and there have been reasonable arguments against it.
20160407 00:15:21< celticminstrel> 642 is a little questionable, but not bad. 643 and 644 seem reasonable to me but need a bit more touch-up. I think someone's already watching 616, so maybe I didn't need to mention that one.
20160407 00:16:25< celticminstrel> Any other opinions?
20160407 00:18:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160407 00:27:33< SigurdFD> as far as 616, there's some reasearch/testing I'm doing, and I would like to hear more from Elvish Hunter.
20160407 00:27:43< celticminstrel> Elvish_Hunter: ^
20160407 00:27:54< celticminstrel> I think zookeeper should look at 643.
20160407 00:28:03< SigurdFD> I'm looking at the differences between it and 1.13.4
20160407 00:30:58< celticminstrel> Huh?
20160407 00:31:16< celticminstrel> We should also consider what to do with 559... gfgtdf?
20160407 00:33:56< celticminstrel> And 496, unless that's the same thing...
20160407 00:45:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160407 01:23:06-!- gfgtdf_ [~chatzilla@x50ab6d95.dyn.telefonica.de] has joined #wesnoth-dev
20160407 01:24:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 01:26:03-!- gfgtdf [~chatzilla@x4e36aa12.dyn.telefonica.de] has quit [Ping timeout: 246 seconds]
20160407 01:26:15-!- gfgtdf_ is now known as gfgtdf
20160407 01:33:27< gfgtdf> celticminstrel: i think disablign whiteboard i s good idea
20160407 01:33:40< celticminstrel> I thought you were the one in favour of keeping it.
20160407 01:34:06< gfgtdf> celticminstrel: whitreboard recuits i mean
20160407 01:34:18< celticminstrel> Oh.
20160407 01:34:18< gfgtdf> celticminstrel: if they relly casue crashes as said the bugreport
20160407 01:34:33< celticminstrel> Well, the alternative to disabling them is removing them, right? :P
20160407 01:34:56< celticminstrel> Wait, I think that's not what I meant to say...
20160407 01:35:07< gfgtdf> celticminstrel: what bother me about that code is that the recuit unit dialog still tried to figure out the recuitin location in  awhiteboard applied context (in re 559 that is)
20160407 01:35:12< celticminstrel> Oh, right, the alternative to disabling them is fixing them.
20160407 01:35:22< gfgtdf> celticminstrel: yes fixing woudl be better
20160407 01:35:41< celticminstrel> I basically have no idea how the whiteboard works though.
20160407 01:36:05< gfgtdf> celticminstrel: i don't fiing them is ver hard, but we just have noone who know that code very good
20160407 01:36:20< celticminstrel> Well, you could learn that code.
20160407 01:36:28< gfgtdf> celticminstrel: well it basically 'temporarily' moves the units aroud, withtout wureing evens or other things
20160407 01:36:42< gfgtdf> fireing*
20160407 01:37:40< gfgtdf> celticminstrel: and adds those 'fake units' to the map (for example fore recuitd ones)
20160407 01:40:21-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160407 01:51:22< irker084> wesnoth: Charles Dang wesnoth:master 7aa0f77837cc / images/icons/alignments/ (16 files): Proper full alignment icon set by LordBob https://github.com/wesnoth/wesnoth/commit/7aa0f77837cc1de41c5a6656fc0cf389b1535b08
20160407 01:57:44-!- gfgtdf [~chatzilla@x50ab6d95.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.1/20160315153207]]
20160407 02:23:15-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 264 seconds]
20160407 02:37:47-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160407 02:55:07< vultraz> celticminstrel: my poll shows that 81% of players never use the whiteboard
20160407 02:56:35< celticminstrel> vultraz: Fascinating. Please show me a detailed study of these results.
20160407 02:56:56< ancestral> I voted ‘no’ for the Whiteboard referrendum
20160407 02:57:05< celticminstrel> ?
20160407 02:57:07< vultraz> https://forums.wesnoth.org/viewtopic.php?f=6&t=43898
20160407 02:57:19 * ancestral jokes
20160407 02:57:41< ancestral> Oh, it’s an actual poll
20160407 02:57:41< celticminstrel> Ah, I see.
20160407 02:57:47 * ancestral votes for real
20160407 02:58:27< vultraz> celticminstrel: I literally meant that 81% of people voted 'never' :P
20160407 02:58:33< ancestral> vultraz: In real life, when there is a referrendum, lawyers get together to find the most “neutral” sounding statement
20160407 02:59:03< ancestral> “Removing planning mode” probably would get more “never/not much” votes rather than if you had “Save planning mode”
20160407 02:59:06< celticminstrel> So basically, there's no study, just a poll in a place where what percentage of the playerbase will actually see it?
20160407 02:59:19< ancestral> “Speak up if you are upset”
20160407 03:00:13< vultraz> celticminstrel: the comments are about as detailed as we'll get
20160407 03:00:17< ancestral> It’s like looking at ratings for apps — say, 5/4/3/2/1 ratings, an app could have 2000/1200/200/50/1500
20160407 03:00:27< vultraz> celticminstrel: I had it stickied in Users for awhile 
20160407 03:00:35< vultraz> so it would get the most exposure
20160407 03:00:48< celticminstrel> But what percentage of the playerbase has a forum account?
20160407 03:00:57< ancestral> “Asking it on the forums is a bad idea, because most of these players don't visit the forums.” May be true
20160407 03:00:58< celticminstrel> And what percentage of those actually visit the forums regularly?
20160407 03:01:13< vultraz> Where else do we ask?
20160407 03:01:21< vultraz> If we were on Steam we could put out a news post
20160407 03:01:23< vultraz> But we are not
20160407 03:01:39< celticminstrel> We have multiple places to put it.
20160407 03:01:52< celticminstrel> The banner in the multiplayer server. The front page. The Twitter account.
20160407 03:02:05< celticminstrel> They'd just link to the forum, of course, but that would increase exposure, at least.
20160407 03:02:14< ancestral> I for one think the front page gets under-utilized
20160407 03:02:30< celticminstrel> I think it's also significant that 18% of voters were against it.
20160407 03:02:47< celticminstrel> Also note that the sample size is very small. Only 45 people voted.
20160407 03:02:54< ancestral> It’s certainly more divisive than the main theme poll
20160407 03:03:16< celticminstrel> So that means that 8 people use it at least sometimes.
20160407 03:03:42< ancestral> Also, I think you have to wage, who/how is this feature designed?
20160407 03:03:53< vultraz> Huh, we have 1,214 followers.
20160407 03:03:56< vultraz> on Twitter
20160407 03:04:01< ancestral> Ask on Twitter
20160407 03:04:05< ancestral> Or on Reddit
20160407 03:04:12-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Ping timeout: 250 seconds]
20160407 03:04:14< celticminstrel> ancestral: I think the front page being under-utilized may be partly due to it not having any sort of automation. From what I've heard, it's just a plain HTML page. If it were set up to automatically display forum posts from the News forum, it would surely see more use.
20160407 03:04:15< vultraz> No one reads our subreddit
20160407 03:04:25< vultraz> celticminstrel: right
20160407 03:04:31< vultraz> it's a PITA to post anything new
20160407 03:04:35< celticminstrel> vultraz: Ask anyway, there could be a few people who care there.
20160407 03:04:46< ancestral> (For example, in Civ games, new players will not customize their citizens in the city, but advnaced users will. And that’s okay, the feature is there, it does get utilized, and can be ignored by everyone else.)
20160407 03:05:08< celticminstrel> How is the server banner set, anyway?
20160407 03:05:20< vultraz> No idea
20160407 03:05:28< ancestral> That
20160407 03:05:33< ancestral> We need to update that logo
20160407 03:05:45< celticminstrel> I mean the message shown when you join the MP server.
20160407 03:06:05< ancestral> Oh, sorry, I thought you meant w.org
20160407 03:06:18< celticminstrel> The Wesnoth host supports PHP, right? So the front page could be switched to a basic PHP page that fetches and displays forum posts.
20160407 03:07:10< celticminstrel> I kind of want to make a poll about FormulaAI too, but since that's not a player-visible feature I'm not sure if it'd be as useful as a properly-run whiteboard poll...
20160407 03:07:11< ancestral> I get the feeling shadowm probably had/has a million ideas on how to make the page amazing
20160407 03:07:30< vultraz> Tweeted and bumped the thread back to sticky.
20160407 03:07:42< vultraz> Actually, thought
20160407 03:07:44< ancestral> vultraz: I did like this: https://www.wesnoth.org/start/1.12/
20160407 03:07:53< ancestral> Honestly, if this was the front page, I wouldn’t mind
20160407 03:08:02< vultraz> shadowm and I designed that
20160407 03:08:05-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160407 03:08:09< ancestral> And you both did a great job
20160407 03:08:44< ancestral> Imagine if that was the page you went to the first time someone said, “hey, check out this free strategy game”
20160407 03:09:22< vultraz> Yeah
20160407 03:09:35< pydsigner> I agree, that page looks good
20160407 03:09:36< vultraz> Shadowm was working on a revamp of our frontpage
20160407 03:09:40< vultraz> It was looking good
20160407 03:09:45< vultraz> But I doubt he'll finish it any time soon
20160407 03:09:49< celticminstrel> The only problem with that page is that it's a "Here's what's new in 1.12" page.
20160407 03:10:10< vultraz> We need someone who knows web design well to do it
20160407 03:10:21< ancestral> That’s okay, I still have my bestiary in an incompleted state: http://wesnoth.io/
20160407 03:10:41< celticminstrel> I can do web programming... not sure on the design aspect...
20160407 03:10:46< ancestral> (that image I have looks more horrible than I remember)
20160407 03:11:05< ancestral> vultraz: If I didn’t have 15 things I’d love to do I would volunteer.
20160407 03:11:25< ancestral> But I am not a seasoned designer either.
20160407 03:12:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160407 03:12:37-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160407 03:13:25< celticminstrel> Why is the ID of the cancel command marked as translatable?
20160407 03:13:52< ancestral> Think I should change the season of the wesnoth reddit?
20160407 03:14:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20160407 03:15:01-!- VultCave is now known as vultraz
20160407 03:15:23-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160407 03:15:23-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160407 03:15:26< vultraz> TBH
20160407 03:15:33< vultraz> linking our forum poll is kinda bad
20160407 03:15:42< vultraz> since non-account holders can't vote
20160407 03:15:46< vultraz> I would make a twitter poll
20160407 03:15:52< vultraz> but I can't do that from tweetdeck
20160407 03:16:19< vultraz> I'll ask shadowm, maybe..
20160407 03:16:27< celticminstrel> Um...
20160407 03:16:41< ancestral> I had the same thoughts, about a Twitter poll instead
20160407 03:17:12< celticminstrel> I have nothing against running a Twitter poll, of course.
20160407 03:17:27< celticminstrel> But the problem is, there's probably forum users who lack a Twitter account.
20160407 03:17:40< vultraz> then hey vote on the forum poll
20160407 03:17:42< celticminstrel> So there's going to be people left out of both polls.
20160407 03:17:43< vultraz> they*
20160407 03:17:57< celticminstrel> So, you have to account for that when considering the results.
20160407 03:18:05< celticminstrel> Can you include multiple questions in the poll?
20160407 03:18:13< vultraz> Don't think so
20160407 03:18:32-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20160407 03:18:38-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20160407 03:18:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 03:18:43< celticminstrel> In other words, it would generate a completely separate dataset.
20160407 03:19:04< celticminstrel> You have to consider the results of both polls in isolation, unless you can think of a good statistical method of aggregating them.
20160407 03:19:12-!- Appleman1234 [~Appleman1@KD118156079165.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20160407 03:19:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 03:19:24< celticminstrel> For example, if you could establish the overlap between the two polls - the people who voted in both, essentially.
20160407 03:20:29< vultraz> I don't see why
20160407 03:20:40< vultraz> Oh, you want to filter out duplicate results?
20160407 03:21:07< celticminstrel> Yes.
20160407 03:21:41< celticminstrel> So many of the hotkeys have no tooltip... :|
20160407 03:23:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160407 03:28:00< celticminstrel> Is there any reason why hotkeys.cfg couldn't also define the description and tooltip in addition to the default?
20160407 03:28:54< celticminstrel> Maybe there is some good reason, I dunno...
20160407 03:32:28< celticminstrel> Maybe I should wait for the scrolling hotkey PR to be merged before working on hotkey stuff, though...
20160407 03:32:49< celticminstrel> But planning should be fine, at least. ancestral, any ideas for how to categorize hotjeys?
20160407 03:32:52< celticminstrel> ^hotkeys
20160407 03:33:07< ancestral> Yes! I have ideas
20160407 03:33:44< celticminstrel> I guess planning mode would be one category...
20160407 03:34:40< celticminstrel> So what're your ideas?
20160407 03:40:13< celticminstrel> There seem to be 185 hotkeys in total... having them all in one big list is just too much. (I'm not sure if every single one is listed, but still...)
20160407 03:42:16< celticminstrel> I wonder if it would break things to get rid of the null hotkey. It's not needed to terminate iteration as the comment suggets, at least.
20160407 03:46:44< celticminstrel> Geh, vultraz, you really should've called it "planning mode" in your tweet instead of "whiteboard".
20160407 03:47:50< ancestral> celticminstrel: Did I show you my simple hot keys?
20160407 03:48:16< celticminstrel> ancestral: Yes, I think so, but I was asking more about categorizing them into smaller lists in preferences.
20160407 03:48:22< ancestral> Oh
20160407 03:48:44< ancestral> I guessI don’t care too much how they’re displayed
20160407 03:49:35< celticminstrel> I was hoping you might have some ideas on how to group them.
20160407 03:52:27< vultraz> I guess I didn't specify to use 'planning mode'
20160407 03:52:29< vultraz> oh well
20160407 03:53:00< celticminstrel> You could clarify with another tweet. :P
20160407 03:54:07< celticminstrel> I'm going to assume that you'd prefer I don't vote in the Twitter poll.
20160407 04:02:08< vultraz> Doesn't matter
20160407 04:05:02< celticminstrel> You know, there should be a command to view the contents of the clipboard.
20160407 04:05:17< celticminstrel> Oh, wait, does it actually show them under the mouse cursor? I forget.
20160407 04:05:30< vultraz> it does
20160407 04:05:34< vultraz> I think?
20160407 04:05:36< vultraz> or maybe not
20160407 04:05:37< celticminstrel> Not just the outline?
20160407 04:05:38< vultraz> actually no
20160407 04:07:01< celticminstrel> So apparently the tooltip in the hotkeys list is actually for the editor. That explains why other keys don't have a tooltip, but I don't think I like this state of affairs...
20160407 04:07:53< celticminstrel> I think there should be a tooltip when you mouse over an entry in the list in prefs; or at least some way of getting an explanation for the less obvious ones.
20160407 04:09:31< vultraz> sure
20160407 04:13:27< ancestral> Okay, minor update of the subreddit
20160407 04:14:30< vultraz> It's sad how little activity it gets :(
20160407 04:14:39< celticminstrel> I still have no followers on Twitter, too.
20160407 04:14:48< celticminstrel> Not that I need any when I don't really tweet.
20160407 04:15:03< celticminstrel> All of my tweets are responses to someone or other.
20160407 04:15:29< celticminstrel> On the other hand, that's partly because I have no followers...
20160407 04:15:41< vultraz> I have 44 followers :D
20160407 04:15:47< celticminstrel> Good for you.
20160407 04:16:16< celticminstrel> I have two. One is my sister and one is someone I've never even heard of, so neither of them count.
20160407 04:17:05< vultraz> Heh
20160407 04:17:10< celticminstrel> I don't even know whether it's a real person.
20160407 04:18:02< celticminstrel> I should probably try to pay attention to the forums beyond just posts that I've posted in.
20160407 04:18:08< celticminstrel> ^threads that I've posted in
20160407 04:20:06< celticminstrel> Why is the poll limited to 6 days?
20160407 04:20:18< celticminstrel> I suppose it's not that big a deal since Twitter is fast-paced, but...
20160407 04:21:01< celticminstrel> If I had followers, I would retweet your twitterpost.
20160407 04:21:12< celticminstrel> But I don't, so it's not worth bothering.
20160407 04:21:23< vultraz> 7 is max length
20160407 04:21:48-!- Appleman1234 [~Appleman1@KD118156079165.au-net.ne.jp] has joined #wesnoth-dev
20160407 04:22:10< celticminstrel> Your forum one already has three retweets though.
20160407 04:22:37< vultraz> Probably bots
20160407 04:22:47< celticminstrel> Who knows.
20160407 04:23:05< celticminstrel> You can view the list, you know.
20160407 04:23:49< celticminstrel> Well, at least one is a bot.
20160407 04:24:07< celticminstrel> There are three listed that are bots, but I can't tell which ones retweeted and which ones liked.
20160407 04:24:30< celticminstrel> Probably could if I actually clicked, but meh.
20160407 04:26:17< celticminstrel> You know, given what Ravana_ said, I think wedge009's PR for planned recruits might be a bit of a problem...
20160407 04:36:55-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20160407 04:37:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160407 04:37:44-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160407 04:40:23< celticminstrel> Did Aginor review PR631 yet?
20160407 04:44:11-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 04:45:49-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160407 04:52:43-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160407 04:55:32-!- irker084 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160407 05:04:04-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160407 05:30:37-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160407 05:33:37-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160407 05:34:38-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Client Quit]
20160407 05:36:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160407 05:46:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 05:47:39-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160407 05:50:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160407 06:02:17-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160407 06:04:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160407 06:08:04< wedge009> celticminstrel: What did Ravana say? Skimming over the log I don't see references to planning mode. My disabling of planned recruits was only based on gfgtdf suggestion to remove them. I understand that whiteboard may well remain indefinitely.
20160407 06:08:21< Ravana_> I didn't find what he meant either
20160407 06:08:38< wedge009> Oh, okay. (:
20160407 06:19:28-!- Kwandulin [~Miranda@p200300760F0D018FE4963957B3051935.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160407 06:24:11-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160407 07:58:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 08:02:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160407 08:02:53-!- boucman_work [~boucman@230.204.154.77.rev.sfr.net] has joined #wesnoth-dev
20160407 08:45:36-!- Kwandulin [~Miranda@p200300760F0D018FE4963957B3051935.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160407 08:45:49-!- irker626 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160407 08:45:49< irker626> wesnoth: Charles Dang wesnoth:master 0e7f855be3c7 / images/buttons/scrollbars/ (scrollmid-active.png scrollmid-pressed.png scrollmid.png): Improved scrollbar graphics https://github.com/wesnoth/wesnoth/commit/0e7f855be3c7f78399f2c3738d0cf05bd0bffdb9
20160407 08:49:43-!- Appleman1234 [~Appleman1@KD118156079165.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20160407 09:08:59-!- boucman_work [~boucman@230.204.154.77.rev.sfr.net] has quit [Ping timeout: 260 seconds]
20160407 09:10:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 268 seconds]
20160407 09:21:11-!- Kwandulin [~Miranda@p200300760F0D018F71E894B1A54AA667.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160407 09:26:32-!- boucman_work [~boucman@145.21.90.92.rev.sfr.net] has joined #wesnoth-dev
20160407 09:31:03-!- boucman_work [~boucman@145.21.90.92.rev.sfr.net] has quit [Ping timeout: 264 seconds]
20160407 09:47:16-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160407 09:48:19-!- Appleman1234 [~Appleman1@KD059138164049.au-net.ne.jp] has joined #wesnoth-dev
20160407 09:50:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160407 09:50:48-!- wedge010 is now known as wedge009
20160407 10:02:32< Soliton> asking how often you use <insert mostly broken feature here> is fairly useless when you want to figure out if that feature would be considered useful were it working properly...
20160407 10:08:28< zookeeper> ^
20160407 10:21:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160407 10:25:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 10:29:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160407 10:32:21-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160407 10:46:40-!- boucman_work [~boucman@156.20.90.92.rev.sfr.net] has joined #wesnoth-dev
20160407 10:47:05-!- mjs-de [~mjs-de@x4db60f6a.dyn.telefonica.de] has joined #wesnoth-dev
20160407 10:48:27-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has joined #wesnoth-dev
20160407 10:55:32-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160407 10:57:58-!- mjs-de [~mjs-de@x4db60f6a.dyn.telefonica.de] has quit [Remote host closed the connection]
20160407 11:33:35-!- boucman_work [~boucman@156.20.90.92.rev.sfr.net] has quit [Remote host closed the connection]
20160407 11:40:00-!- boucman_work [~boucman@110.202.154.77.rev.sfr.net] has joined #wesnoth-dev
20160407 11:45:51-!- irker626 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160407 11:49:46-!- Kwandulin [~Miranda@p200300760F0D018F71E894B1A54AA667.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160407 12:13:30-!- Kwandulin [~Miranda@p200300760F0D018F99E0DF735B4BCE7B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160407 12:18:45-!- gfgtdf [~chatzilla@x50ab6d95.dyn.telefonica.de] has joined #wesnoth-dev
20160407 12:29:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160407 12:37:56-!- Kwandulin [~Miranda@p200300760F0D018F99E0DF735B4BCE7B.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160407 12:41:00-!- prkc [~prkc@catv-80-98-243-98.catv.broadband.hu] has quit [Remote host closed the connection]
20160407 12:52:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160407 12:53:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160407 13:05:40-!- irker811 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160407 13:05:40< irker811> wesnoth: Wedge009 wesnoth:master 717a762493ac / data/core/about.cfg: Add self to en_GB translators. https://github.com/wesnoth/wesnoth/commit/717a762493ac92d5457ccd7bec9aa14aaaabf6d9
20160407 13:14:55-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 244 seconds]
20160407 13:15:48-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160407 13:30:07< celticminstrel> wedge009: I was referencing something Ravana_ said in a linked forum thread.
20160407 13:31:29< celticminstrel> https://forums.wesnoth.org/viewtopic.php?f=6&t=43898
20160407 13:33:01-!- atarocch [~atarocch@151.64.94.62] has joined #wesnoth-dev
20160407 13:33:50< celticminstrel> Soliton: You have a point, though I was under the impression that it does work, mostly.
20160407 13:33:59< celticminstrel> Admittedly, I haven't actually tried it... >_>
20160407 13:34:12-!- travis-ci [~travis-ci@ec2-107-20-99-119.compute-1.amazonaws.com] has joined #wesnoth-dev
20160407 13:34:13< travis-ci> wesnoth/wesnoth#9220 (master - 717a762 : Wedge009): The build was broken.
20160407 13:34:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/121420562
20160407 13:34:13-!- travis-ci [~travis-ci@ec2-107-20-99-119.compute-1.amazonaws.com] has left #wesnoth-dev []
20160407 13:41:50< Soliton> celticminstrel: depends on how you define working. if it causes OOS in multiplayer even if it "mostly works" that make it unusable.
20160407 13:42:19< gfgtdf> Soliton: hmm i don't think it causes OOS in multiplayer.
20160407 13:42:31< gfgtdf> Soliton: it crashes wesnoth sometimes
20160407 13:42:52< Soliton> that's not particularly better. ;-)
20160407 13:42:56< gfgtdf> Soliton: i know
20160407 13:43:08< Soliton> players seem to disagree with your assessment though.
20160407 13:43:39< gfgtdf> Soliton: which assesment ?
20160407 13:43:53< Soliton> "i don't think it causes OOS in multiplayer."
20160407 13:43:55-!- boucman_work [~boucman@110.202.154.77.rev.sfr.net] has quit [Read error: Connection reset by peer]
20160407 13:44:20< gfgtdf> Soliton: well it makes teh mp server span 'ignoring illegal whiteboard message form player x' in the mp chat
20160407 13:44:34< gfgtdf> Soliton: which doesnt casue OOS but sureley scares people.
20160407 13:45:27< celticminstrel> That message could easily be silenced if it's not an actual problem.
20160407 13:45:48< celticminstrel> Actually, the server doesn't even need to know about the whiteboard, does it?
20160407 13:46:26< gfgtdf> celticminstrel: planned moves are sende  over teh nework so that you teammates knows what you are planning
20160407 13:46:37< celticminstrel> Ahh, okay.
20160407 13:46:52< gfgtdf> celticminstrel: so the server checks whether planned moves for side n ar actuall sensed by side n
20160407 13:47:11< gfgtdf> celticminstrel: for some unknonw reasons the game client resnends recived whiteboard masseages though
20160407 13:47:27< gfgtdf> celticminstrel: so that if side 1 and 2 are allied, and side 1 makes a move,
20160407 13:47:43< gfgtdf> celticminstrel: then  side 2 revices the whiteboard data and resends it to the mp server
20160407 13:48:08< celticminstrel> And that causes the illegal whiteboard messages?
20160407 13:48:09< gfgtdf> celticminstrel: then the mp server complains about recieveing whiteboard data about side 1 from player 2.
20160407 13:48:17< celticminstrel> I see.
20160407 13:48:23< celticminstrel> Can you fix it? :)
20160407 13:48:48< gfgtdf> celticminstrel: the correct way to fix it woudl obvously be the making the client not resned those packages
20160407 13:49:14< celticminstrel> Yeah.
20160407 13:49:25< gfgtdf> celticminstrel: i silenced the server wanring on the 1.12 mp server (so that such messages are now swalloed silently)
20160407 13:49:41< gfgtdf> celticminstrel: i don't think its in the 1.12 mp server yert though
20160407 13:49:57< celticminstrel> Did you leave the warning in on 1.13?
20160407 13:50:10< gfgtdf> Soliton: can you rebuidl the 1.12 mp server next time when there is less traffic ?
20160407 13:50:23< gfgtdf> celticminstrel: y, i still hvae teh hope that we can fix it before 1.14
20160407 13:50:42< gfgtdf> celticminstrel: and didsabling it is easy so that we can also do it shortly before relasing 1.14 is needed
20160407 13:50:52< gfgtdf> celticminstrel: in case we cannot fix it
20160407 13:52:23< gfgtdf> celticminstrel: but i actually think that the issues that make wesnoth crash are mor important, https://gna.org/bugs/?22527 in paritcular
20160407 13:52:36< celticminstrel> Yeah, agreed...
20160407 13:52:41< gfgtdf> celticminstrel: unfortunateley this crashes smehere in teh unit drawind code whcih i know nothing about
20160407 13:53:14< celticminstrel> I remember getting stuck in an animation once.
20160407 13:53:25< celticminstrel> Due to some code change I made, though.
20160407 13:53:31< celticminstrel> I can't remember exactly what it was.
20160407 13:54:12-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160407 14:02:55-!- Kwandulin [~Miranda@p200300760F0D017999E0DF735B4BCE7B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160407 14:10:38< Soliton> gfgtdf: rebuild is in progress...
20160407 14:15:07< Soliton> gfgtdf: do you know anything about a network message containing 'give_me_a_package="now"'?
20160407 14:16:09< Soliton> the server occasionally complains about receiving such messages and having no idea what do with them.
20160407 14:17:23< Soliton> (can't find 'give_me_a_package' anywhere in the source.)
20160407 14:19:11< gfgtdf> Soliton: hmm whihch wesnoth version ?
20160407 14:19:50< gfgtdf> Soliton: see this comment: https://github.com/wesnoth/wesnoth/blob/1.12/src/synced_context.cpp#L301
20160407 14:20:49< Soliton> ah, it's version 1.12.
20160407 14:21:01< Soliton> and i did just look in the sources of master.
20160407 14:24:05< Soliton> the name give_me_a_package is a bit misleading since you're not getting anything back but ok. ;-)
20160407 14:27:20< wedge009> celticminstrel: It's not a problem in the sense that one can still look at the recruit dialogue outside of his/her turn... but then the game crashes if he/she attempts to plan a recruit from that dialogue. ):
20160407 14:27:49< wedge009> Either way planned recruits are a problem. I'll see what I can do later, it's after midnight for me.
20160407 14:27:57< irker811> wesnoth: Ignacio R. Morelle wesnoth:asio_wesnothd 94454d587a70 / src/ (config_cache.cpp config_cache.hpp): config/cache: More cleanup https://github.com/wesnoth/wesnoth/commit/94454d587a70767eb97fc968de255d4bc3bf0016
20160407 14:28:00< irker811> wesnoth: Ignacio R. Morelle wesnoth:asio_wesnothd 5e6da3f9aadd / data/gui/default/window/preferences/04_multiplayer.cfg: gui2/tpreferences: Fix button labels case https://github.com/wesnoth/wesnoth/commit/5e6da3f9aadd92974fcff4c703564413b445c2d9
20160407 14:28:04< irker811> wesnoth: Ignacio R. Morelle wesnoth:asio_wesnothd 5f5f7a185fce / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): gui2/tpreferences: Correct copyright https://github.com/wesnoth/wesnoth/commit/5f5f7a185fcef888a6ffa0691d10d9555d11a6b7
20160407 14:28:06< irker811> wesnoth: Celtic Minstrel wesnoth:asio_wesnothd 534299e6454a / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/534299e6454a1894f247cdaadeca1fb0df56b9d8
20160407 14:28:08< irker811> wesnoth: Celtic Minstrel wesnoth:asio_wesnothd f4c3d97f5509 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project (again) https://github.com/wesnoth/wesnoth/commit/f4c3d97f5509659bd81938b5af0b3dc17125387d
20160407 14:28:10< irker811> wesnoth: Charles Dang wesnoth:asio_wesnothd 0537fc2391f1 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: fixed phantom entry remaining after removing last acquaintance fro https://github.com/wesnoth/wesnoth/commit/0537fc2391f19420f8a40e9acd8b46f5399aab71
20160407 14:28:13< irker811> wesnoth: Elvish_Hunter wesnoth:asio_wesnothd b9380e88c1b2 / data/tools/wesnoth/wmltools3.py: wmltools3: fixed a bug reported by Robertdebrus in PR #596 https://github.com/wesnoth/wesnoth/commit/b9380e88c1b21d3f08e7619ba9904830c53ba11c
20160407 14:28:15< irker811> wesnoth: Elvish_Hunter wesnoth:asio_wesnothd 4f2c15a0658b / / (4 files in 2 dirs): Updated DejaVu fonts to version 2.35 https://github.com/wesnoth/wesnoth/commit/4f2c15a0658b447a749d338eb1991ddeb1596981
20160407 14:28:18< irker811> wesnoth: gfgtdf wesnoth:asio_wesnothd 4e46c7cc287b / src/game_initialization/connect_engine.cpp: fix issues with [unit] in [side] in mp connect. https://github.com/wesnoth/wesnoth/commit/4e46c7cc287b72a02b1942c25ff6a7c7cc287b9a
20160407 14:28:19< irker811> wesnoth: gfgtdf wesnoth:asio_wesnothd c425e62a20b9 / src/ (4 files in 3 dirs): add support to search in border in wesnoth.find_path https://github.com/wesnoth/wesnoth/commit/c425e62a20b9134932fcad351aedb78f0b7e77e5
20160407 14:28:21< irker811> wesnoth: gfgtdf wesnoth:asio_wesnothd b753e54b0341 / src/scripting/mapgen_lua_kernel.cpp: fixup comment https://github.com/wesnoth/wesnoth/commit/b753e54b0341cb6329eaf5948fe6490f14ed848f
20160407 14:28:24< irker811> wesnoth: gfgtdf wesnoth:asio_wesnothd 6e0f8ed6d753 / src/actions/undo.cpp: fix assertion failure when loading mp saves https://github.com/wesnoth/wesnoth/commit/6e0f8ed6d753a88db49ddd147d2d16ebb5188b88
20160407 14:28:25< irker811> wesnoth: gfgtdf wesnoth:asio_wesnothd ba154d07b957 / src/mouse_events.cpp: fix assertion failure and OOS when attacking with DSU active https://github.com/wesnoth/wesnoth/commit/ba154d07b957f0dee38dc07a4c38c6b2910a916c
20160407 14:28:27< irker811> wesnoth: gfgtdf wesnoth:asio_wesnothd 3f681c14128d / src/variable_info.cpp: dont allow empty indexes in wml variables https://github.com/wesnoth/wesnoth/commit/3f681c14128dd52eadecd0f5889eda904d92bbbc
20160407 14:28:29-!- mode/#wesnoth-dev [+q *!*@uruz.ai0867.net] by ChanServ
20160407 14:28:29-ChanServ:#wesnoth-dev- loonycyborg quieted *!*@uruz.ai0867.net
20160407 14:29:26< loonycyborg> I wonder if github allows to create PRs between branches in same repository
20160407 14:30:48< celticminstrel> It does.
20160407 14:30:53< celticminstrel> Aginor did one for SDL2.
20160407 14:38:50< loonycyborg> anyway my asio_wesnothd branch could definitely use more review from someone who isn't me
20160407 14:43:39-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 264 seconds]
20160407 14:44:32-!- travis-ci [~travis-ci@ec2-23-22-203-252.compute-1.amazonaws.com] has joined #wesnoth-dev
20160407 14:44:33< travis-ci> wesnoth/wesnoth#9222 (asio_wesnothd - 94c8533 : loonycyborg): The build failed.
20160407 14:44:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/121441429
20160407 14:44:33-!- travis-ci [~travis-ci@ec2-23-22-203-252.compute-1.amazonaws.com] has left #wesnoth-dev []
20160407 14:45:46< celticminstrel> loonycyborg: So, does it basically work?
20160407 14:45:54< loonycyborg> yup
20160407 14:46:00-!- Kwandulin [~Miranda@p200300760F0D017999E0DF735B4BCE7B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160407 14:46:13< celticminstrel> Yay.
20160407 14:46:23< loonycyborg> can host games there and wesnothd doesn't depend on anything sdl
20160407 14:47:19< celticminstrel> lua_race.cpp needs to include <cstring>
20160407 14:47:58-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160407 14:48:22< celticminstrel> Though I'm not sure why that would fail on your branch and not on master...
20160407 14:49:14< loonycyborg> I didn't make changes to lua_race.cpp iirc
20160407 14:49:42< loonycyborg> though maybe it's because it depends on implicitly included header
20160407 14:50:25< loonycyborg> I for sure didn't get this error locally
20160407 14:58:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 15:00:21< loonycyborg> I had to drop SDL_types.h from some core files, this could reduce set of implicitly included headers :P
20160407 15:00:59< celticminstrel> Hmm, I could maybe see that doing it...
20160407 15:04:26< celticminstrel> loonycyborg: Did you unmute it yet?
20160407 15:04:54< loonycyborg> irker? I think it's still spamming
20160407 15:05:03< celticminstrel> Really? Wow.
20160407 15:05:25-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160407 15:05:47< vultraz> loonycyborg: you can umute it in about 30 seconds
20160407 15:05:52< vultraz> unmute 
20160407 15:06:17< loonycyborg> in the past I unmuted it when it left the channel
20160407 15:06:41< vultraz> that works too
20160407 15:07:07< celticminstrel> Doesn't compile for me.
20160407 15:07:24-!- irker811 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160407 15:07:30< celticminstrel> Maybe there are new source files though.
20160407 15:07:50< celticminstrel> That would likely explain the undeclared identifiers.
20160407 15:08:04< loonycyborg> there are new sourcefiles and some sourcefiles removed
20160407 15:08:29< celticminstrel> Proxy is removed, huh...
20160407 15:09:19< loonycyborg> only redirect is supported
20160407 15:09:30< loonycyborg> proxy wasn't used much anyway
20160407 15:10:14-!- mode/#wesnoth-dev [-q *!*@uruz.ai0867.net] by ChanServ
20160407 15:10:24< Soliton> yes, proxy removal is fine.
20160407 15:11:20< celticminstrel> Still not compiling... new source files outside src/server maybe...
20160407 15:11:58< celticminstrel> "send_to_one" unrecognized
20160407 15:12:29< loonycyborg> you're using xcode right?
20160407 15:12:31< celticminstrel> Several functions with no previous prototype, which for whatever reason is an error in the XCode project.
20160407 15:12:33< celticminstrel> Yeah.
20160407 15:13:17< celticminstrel> No conversion from vector::iterator to const vector::iterator or something...
20160407 15:13:51< celticminstrel> Oh, that's probably because the vector element type was unrecognized, so it substituted int to try and recover.
20160407 15:14:50< celticminstrel> I would assume socket_ptr is declared in asio.hpp though... (or included by it at least)
20160407 15:15:56< loonycyborg> no, it's a custom typedef
20160407 15:16:23< celticminstrel> Ah, so it is.
20160407 15:16:31< celticminstrel> Wow, asio has lots of namespaces.
20160407 15:16:51< loonycyborg> declared in player_connection.hpp
20160407 15:16:58< celticminstrel> I see it, yes.
20160407 15:17:19< celticminstrel> So where are send_to_one and send_to many? Or did you remove room.cpp and romm_manager.cpp?
20160407 15:17:48< celticminstrel> (From the sconscript at least, the files are obviously still there)
20160407 15:18:24< loonycyborg> room.cpp and room_manager.cpp no longer used in the built
20160407 15:18:57< celticminstrel> So are rooms no longer supported just as we're considering moving to the new lobby that supports them?
20160407 15:19:04< loonycyborg> I removed room support for now, it was only used by new lobby gui to which we didn't switch
20160407 15:19:29< celticminstrel> Okay...
20160407 15:19:39< celticminstrel> I'll just untick them from the build but not remove them from the project, then.
20160407 15:20:30< celticminstrel> I think it would be nice to re-enable room support, though, particularly since vultraz has been doing much work on the new lobby GUI.
20160407 15:20:57< loonycyborg> I could reimplement them later
20160407 15:21:09< celticminstrel> Hmm. For some reason, the build succeeded. I thought I would have to add asio to the build.
20160407 15:21:19< loonycyborg> asio is header only lib
20160407 15:21:23< celticminstrel> Ah.
20160407 15:21:28< celticminstrel> So I can remove SDL_net, right?
20160407 15:21:38< celticminstrel> Since there's no addons server target.
20160407 15:22:01< celticminstrel> (Does the addons server use it? I haven't looked.)
20160407 15:22:10< loonycyborg> you can try, but it may fail if you use some client specific files in build
20160407 15:22:27< loonycyborg> addon server uses sdl-net too
20160407 15:22:28< gfgtdf> loonycyborg: your branch seems to outcomment some stuff, are you pülanning to readd if before merging ?
20160407 15:22:46< loonycyborg> some of this stuff is left for reference only
20160407 15:23:06< loonycyborg> some I plan to re-enable
20160407 15:23:59< celticminstrel> There seems to be a src/network.cpp that references SDL_net.
20160407 15:24:03-!- Kwandulin [~Miranda@p200300760F0D017931250DF3462D357E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160407 15:24:14< celticminstrel> It's being included in both wesnothd and wesnoth.
20160407 15:24:24< celticminstrel> Is this an ancient relic that should just be deleted?
20160407 15:24:34< celticminstrel> ...I could grep the SConscript, I guess.
20160407 15:25:05< loonycyborg> it's still used by client
20160407 15:25:13< celticminstrel> ...why?
20160407 15:25:20< loonycyborg> my branch is only about server
20160407 15:25:25< celticminstrel> Okay.
20160407 15:25:46< gfgtdf> loonycyborg: there are some cases like in 'game::send_data_sides', 'game::send_history' or 'ban_manager::read' which look like it'd break stuff
20160407 15:25:48< fendrin> hi Kwandulin
20160407 15:25:49< celticminstrel> network_worker.cpp... I guess that's the same.
20160407 15:25:57< loonycyborg> yup
20160407 15:26:01< Kwandulin> hi fendrin
20160407 15:26:05< fendrin> Kwandulin: Are you the author of the khalifate campaign?
20160407 15:26:12< Kwandulin> yes
20160407 15:26:13< fendrin> oath of allignance or similar?
20160407 15:26:17< celticminstrel> Okay, it builds.
20160407 15:26:28< Kwandulin> fendrin: yeah
20160407 15:26:42< fendrin> Kwandulin: I played through it until the scenario after the besieged city.
20160407 15:26:44< celticminstrel> Did you unmute it, loonycyborg?
20160407 15:26:54< loonycyborg> yes
20160407 15:27:09< celticminstrel> Mind if I push the XCode update?
20160407 15:27:31< loonycyborg> ok
20160407 15:28:08< fendrin> So far it is much fun. Your maps all look very well made.
20160407 15:28:12-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 244 seconds]
20160407 15:28:33< loonycyborg> gfgtdf: break in what way?
20160407 15:29:16< loonycyborg> oh commenting
20160407 15:29:28< Kwandulin> fendrin: thanks!
20160407 15:29:37< loonycyborg> yes those are planned to be reenabled later
20160407 15:29:44< fendrin> Is the campaign still under development?
20160407 15:30:06< Kwandulin> yes i am working on it these days
20160407 15:30:29< fendrin> There is no Khalifate campaign in mainline yet.
20160407 15:31:01< celticminstrel> I don't think it should be included in mainline solely because it's the only Khalifate campaign around, though.
20160407 15:31:26< Kwandulin> i doubt the devs like this kind of campaign
20160407 15:31:40-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160407 15:31:45< celticminstrel> I haven't played it, so I don't know. I think my sister likes it.
20160407 15:32:09< fendrin> Kwandulin: What makes it different to other mainlines?
20160407 15:33:24< fendrin> So far I have not discovered a lot unusual gameplay mechanics. It looks rather classic.
20160407 15:33:49< Kwandulin> RPGish amla paths for the heroes, odd elevated terrain and some unusual gameplay things (e.g. the ravage ability of the desert bandit)
20160407 15:34:18 * celticminstrel thought UtBS had the first of those.
20160407 15:34:45< Kwandulin> and there are some magical khalifate units although the khalifate are originally intended to be non-magical
20160407 15:35:10< Kwandulin> (you will meet those wizards in the scenario after the siege)
20160407 15:35:17< fendrin> I see.
20160407 15:35:49< fendrin> And looking forward to it. I hate the Khalifate not using magic.
20160407 15:35:54-!- irker727 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160407 15:35:54< irker727> loonycyborg: if you could prefix the pattern with 'irker*\!' next time, you wouldn't also mute AI0867
20160407 15:36:06< irker727> loonycyborg: not that he was trying to speak
20160407 15:36:27< loonycyborg> whoops sorry :P
20160407 15:36:38< AI0867> =P
20160407 15:36:39< celticminstrel> I'm going to assume that was the bot owner.
20160407 15:36:44< celticminstrel> ^is
20160407 15:37:06< AI0867> anyone with an account on my server can do that
20160407 15:39:27< zookeeper> unusual mechanics alone don't make a campaign unsuitable for mainline, it's not like we don't have a bunch of weird stuff in mainline campaigns already.
20160407 15:40:17< loonycyborg> UtBS has a lot of custom mechanics like this for example
20160407 15:40:21< zookeeper> i mean, as long as the amount of unusual things is within some kind of reasonable limits :p
20160407 15:40:27< zookeeper> yeah
20160407 15:44:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 15:44:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160407 15:44:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 15:51:52< vultraz> OoA could potentially be mainline quality
20160407 15:52:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 248 seconds]
20160407 15:52:07-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160407 15:58:48< celticminstrel> vultraz: I don't think quality should be the only factor in deciding whether to mainline something.
20160407 16:01:37< celticminstrel> loonycyborg: I get a link error for filesystem::load_RWops in the client...
20160407 16:02:09< loonycyborg> celticminstrel: you need to add filesystem_sdl.cpp to project file I think
20160407 16:02:25< celticminstrel> It's odd that it's not already there though...
20160407 16:03:16< loonycyborg> during merge I had some conflict due to it, seems it got merged somewhere else during last large code reorganization
20160407 16:03:30< celticminstrel> Hmm...
20160407 16:03:41< loonycyborg> and I had to undo that change since having it separate is needed to make wesnothd sdlless
20160407 16:03:49< celticminstrel> I see.
20160407 16:06:34< celticminstrel> Why is writing not implemented...
20160407 16:07:27< loonycyborg> in filesystem_sdl.cpp?
20160407 16:07:33< celticminstrel> Yeah.
20160407 16:07:38< loonycyborg> probably because wesnoth doesn't need to write files
20160407 16:07:42< loonycyborg> only load them
20160407 16:08:03< celticminstrel> There's one commented line at image.cpp:1264
20160407 16:09:11< loonycyborg> iirc this sdl_rwops code is only needed to customize sdl_mixer to work with unicode paths
20160407 16:09:43< fendrin> vultraz: Is the editor maintained currently?
20160407 16:09:44< celticminstrel> But it's also used for images and fonts.
20160407 16:10:02< celticminstrel> fendrin Why do you ask?
20160407 16:10:11< celticminstrel> I don't know of anyone specifically maintaining it.
20160407 16:10:18< fendrin> there are some bugs
20160407 16:10:34< fendrin> And I would like to know to whom speak about them.
20160407 16:10:34< celticminstrel> Scenario editor is still pretty rough, too.
20160407 16:10:47< celticminstrel> You could open a bug report.
20160407 16:10:57< fendrin> yes
20160407 16:11:01< fendrin> and assign to whom?
20160407 16:11:27< celticminstrel> You don't need to assign it to anyone at creation time.
20160407 16:12:49-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160407 16:14:21< fendrin> Yes, I have heard about that.
20160407 16:15:14< irker727> wesnoth: loonycyborg wesnoth:asio_wesnothd 218869012060 / src/scripting/lua_race.cpp: Try to fix compiler error about strcmp on travis https://github.com/wesnoth/wesnoth/commit/21886901206004ee0b7b699711055c6cb1b6d801
20160407 16:18:22< irker727> wesnoth: Celtic Minstrel wesnoth:asio_wesnothd e7d254bce7de / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj src/server/server.cpp: Update XCode project https://github.com/wesnoth/wesnoth/commit/e7d254bce7de7d36c0d80205eac2ab64bf60bf56
20160407 16:18:24< irker727> wesnoth: Celtic Minstrel wesnoth:asio_wesnothd aaa91d39729a / src/ (filesystem_sdl.cpp game_launcher.cpp): Remove residual SDL1 support blocks https://github.com/wesnoth/wesnoth/commit/aaa91d39729a0c0d4e148e433ddbfd5c96d320e5
20160407 16:18:32< celticminstrel> ...oh, wait.
20160407 16:18:45< celticminstrel> I thought you said it was SDL-less?
20160407 16:19:24< celticminstrel> I removed SDL2 from the build and got SDL_thread link errors.
20160407 16:19:48< celticminstrel> Maybe I need to remove some other file from the build...
20160407 16:21:48< celticminstrel> Actually, I should probably remove that file altogether.
20160407 16:21:54< celticminstrel> But that's not something to do on a branch.
20160407 16:22:45< celticminstrel> I wonder how compatible Boost.Thread and src/thread.hpp are... I can see at least one incompatibility just by looking.
20160407 16:25:13< vultraz> aren't you supposed to include <cstring> not <string.h>
20160407 16:26:52< celticminstrel> Yes.
20160407 16:26:59< celticminstrel> Though it doesn't really make that much difference..
20160407 16:27:14< celticminstrel> It's just that <string.h> is the C way and <cstring> is the C++ way.
20160407 16:27:50< irker727> wesnoth: Celtic Minstrel wesnoth:asio_wesnothd d8d87b1a618f / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project (again) https://github.com/wesnoth/wesnoth/commit/d8d87b1a618f2e00fa46dd7ed9b82d6337ba72e4
20160407 16:28:02< vultraz> wouldn't <string.h> be the same as <string> though?
20160407 16:28:13< celticminstrel> No, those are two different headers.
20160407 16:28:22< vultraz> ah
20160407 16:28:27< vultraz> who'd have thought
20160407 16:28:34< celticminstrel> <string.h> is the same header as <cstring>, roughly.
20160407 16:28:52-!- Kwandulin [~Miranda@p200300760F0D017931250DF3462D357E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160407 16:30:13< loonycyborg> cstring provides those C symbols in std namespace, and can but not required to provide them in global ns
20160407 16:30:27< loonycyborg> while string.h will have them in global ns
20160407 16:30:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 16:30:51< loonycyborg> since that file uses strcmp from global ns string.h fits more
20160407 16:31:02< celticminstrel> Meh.
20160407 16:31:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160407 16:31:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160407 16:33:58< vultraz> celticminstrel: btw, was meaning to ask: why did we drop to travis to gcc 4.7 when we switched to c++11?
20160407 16:36:05-!- mjs-de [~mjs-de@x4db60f6a.dyn.telefonica.de] has joined #wesnoth-dev
20160407 16:40:21< celticminstrel> Because I said on the ML that that's what we're targeting.
20160407 16:40:25< celticminstrel> GCC-wise.
20160407 16:45:14-!- travis-ci [~travis-ci@ec2-23-22-203-252.compute-1.amazonaws.com] has joined #wesnoth-dev
20160407 16:45:15< travis-ci> wesnoth/wesnoth#9224 (asio_wesnothd - aaa91d3 : Celtic Minstrel): The build is still failing.
20160407 16:45:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/121470690
20160407 16:45:15-!- travis-ci [~travis-ci@ec2-23-22-203-252.compute-1.amazonaws.com] has left #wesnoth-dev []
20160407 16:46:12< celticminstrel> :|
20160407 16:46:19< celticminstrel> Same error, different file.
20160407 16:50:39< celticminstrel> Dugi's PR reminds me that I wanted to add a Lua interface to the name generator.
20160407 16:53:15-!- travis-ci [~travis-ci@ec2-23-20-39-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20160407 16:53:16< travis-ci> wesnoth/wesnoth#9225 (asio_wesnothd - d8d87b1 : Celtic Minstrel): The build is still failing.
20160407 16:53:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/121472767
20160407 16:53:16-!- travis-ci [~travis-ci@ec2-23-20-39-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20160407 17:06:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160407 17:23:10< irker727> wesnoth: Charles Dang wesnoth:master 2d0721185fa5 / src/actions/undo_action.cpp: Assigned some initial variable values to silence some warnings https://github.com/wesnoth/wesnoth/commit/2d0721185fa5722859dc24007731054fb3f35885
20160407 17:34:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160407 17:50:43-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160407 17:50:50-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160407 17:50:50-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160407 17:52:05< celticminstrel> Why is race.cpp included in libwesnoth?
20160407 18:10:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 18:14:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160407 18:18:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 18:20:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160407 18:24:00-!- ancestral [~ancestral@24.sub-70-197-200.myvzw.com] has joined #wesnoth-dev
20160407 18:29:06-!- ancestral [~ancestral@24.sub-70-197-200.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160407 18:30:58-!- ancestral [~ancestral@24.sub-70-197-200.myvzw.com] has joined #wesnoth-dev
20160407 18:38:29-!- ancestral [~ancestral@24.sub-70-197-200.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160407 18:39:02-!- ancestral [~ancestral@24.sub-70-197-200.myvzw.com] has joined #wesnoth-dev
20160407 18:41:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160407 18:41:24-!- gfgtdf [~chatzilla@x50ab6d95.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160407 18:45:00-!- ancestral [~ancestral@24.sub-70-197-200.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160407 18:54:26-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160407 18:59:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160407 19:07:02< zookeeper> hmh. on the minimap, your own villages don't show up under fog. they probably should.
20160407 19:12:20< celticminstrel> But what if one of them is taken?
20160407 19:13:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 19:14:37< zookeeper> well then you see that you don't have it
20160407 19:14:58< celticminstrel> That seems to sort of defeat fog a bit...
20160407 19:15:16< zookeeper> no. think.
20160407 19:15:34< zookeeper> fog doesn't hide whether you have a village or not.
20160407 19:16:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 19:16:12< celticminstrel> You mean like your total number of villages?
20160407 19:16:26< zookeeper> no
20160407 19:16:33 * celticminstrel confused
20160407 19:16:40 * zookeeper shrugs
20160407 19:17:07< zookeeper> fog does not affect your ability to see whether you own a village or not. the flag shows through fog, if it's yours.
20160407 19:17:16< zookeeper> hence why the minimap should show it as well
20160407 19:17:19< celticminstrel> Oh, it does? Okay then.
20160407 19:17:21< celticminstrel> Sure.
20160407 19:18:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160407 19:38:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 19:39:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160407 19:42:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160407 19:52:16-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 19:54:49-!- prkc [~prkc@46.166.137.245] has joined #wesnoth-dev
20160407 19:58:20< Aginor> loonycyborg: make a PR and I'm happy to help out with reviewing
20160407 19:59:02< loonycyborg> ok
20160407 20:11:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 20:23:13-!- irker727 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160407 20:37:31-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160407 20:40:05-!- atarocch [~atarocch@151.64.94.62] has quit [Remote host closed the connection]
20160407 20:59:14-!- mjs-de [~mjs-de@x4db60f6a.dyn.telefonica.de] has quit [Remote host closed the connection]
20160407 21:10:55-!- ancestral [~ancestral@75-168-27-21.mpls.qwest.net] has joined #wesnoth-dev
20160407 21:23:05-!- Nobun [~nobun@5.170.196.29] has joined #wesnoth-dev
20160407 21:33:43< Nobun> Hi all.... while I was trying to solve the last bug on my wmlxgettext reported by loonycyborg I noticed a thing I'd like to discuss with you
20160407 21:34:08< Nobun> the problem is: collecting additional information for translator written in # po: <addedinfo> comments
20160407 21:34:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160407 21:34:34< Nobun> the regexp I currently use assume you use AT LEAST one space between # and po
20160407 21:36:17< Nobun> but, as Elvish Hunter noticed, a lot of campaigns in the mainline doesn't use the spece between # and po:
20160407 21:37:21< Elvish_Hunter> Yep. BTW, no mainline content uses two or more spaces between # and po:
20160407 21:37:24< Nobun> It may sounds a very corner problem, but it is a metter of code style, and how you should expect that wmlxgettext work (after all I'm trying to purpose it to be added in mainline)
20160407 21:38:49< Nobun> yep, Elvish_Hunter... but if we allow this assumption for # po (#po and # po accepted) this involves also # wmlxgettext and all other special comments
20160407 21:39:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 21:39:02-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160407 21:39:51< Nobun> imho forcing the space is a good thing (so it can be easyer distinguished preprocessor instructions and special comments)
20160407 21:40:48< Nobun> bht I'd like your opinion.... since it is nothing difficult to change the regexp accordingly
20160407 21:40:52< Nobun> so we could:
20160407 21:41:30< Nobun> --- leave as it is now (even if most of mainline campaigns forgot space), and fix all those point in mainline add-ons
20160407 21:41:48< Nobun> --- allow ZERO or ONE space, as Elvish_Hunter implicitly suggested
20160407 21:42:21< Nobun> ---- allow from ZERO to arbitrary spaces between # and the special command name
20160407 21:42:45-!- gfgtdf [~chatzilla@x50ab6d95.dyn.telefonica.de] has joined #wesnoth-dev
20160407 21:43:29< gfgtdf> i think for most people having a süace after the # is unexpected, specially since we dont accept a space in #textdomain eigher afaik
20160407 21:43:34< gfgtdf> space*
20160407 21:44:05< Nobun> yep but #textdomain is a preprocessor directive, not a comment
20160407 21:44:30< Nobun> tecnically speaking, # po, # wmlxgettext, # wmllint and similar ar comments
20160407 21:44:36< Nobun> are *
20160407 21:44:45< gfgtdf> Nobun: hmm but i don't think most bveginner devs know the difference
20160407 21:44:54< Elvish_Hunter> It is worth noting that wmliterator already checks for 0 or 1 spaces...
20160407 21:45:31< Elvish_Hunter> elif text.startswith('#po:') or text.startswith('# po:'):
20160407 21:46:03< gfgtdf> Nobun: actually i personally never used those commeants in my addons code. So maybe i'm not the one who knows them best
20160407 21:46:54< Nobun> # po: is to add custom additional information to translator, so it will be added in the final .po file with the sentence
20160407 21:47:16-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160407 21:47:21< Nobun> # wmlxgettext: is, instead. required if you plan to write unbalanced tags on purpose
20160407 21:47:23< gfgtdf> Nobun: is that also supported in lua code?
20160407 21:47:30< gfgtdf> Nobun: like in -- po ?
20160407 21:47:37< Nobun> in my wmlxgettext yes
20160407 21:47:42< Nobun> it is supported
20160407 21:47:51< Nobun> both as -- # po: addedinfo
20160407 21:47:56< Nobun> and -- po: addedinfo
20160407 21:48:58< Nobun> I don't know if perl wmlxgettext (the one currently on wesnoth core) support # po in lua code, but I think so
20160407 21:49:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20160407 21:49:56-!- wedge010 is now known as wedge009
20160407 21:55:05-!- Nobun [~nobun@5.170.196.29] has quit [Quit: Salve a tutti]
20160407 22:13:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160407 22:14:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160407 22:14:29-!- ScegfOd [637f4b7c@gateway/web/freenode/ip.99.127.75.124] has joined #wesnoth-dev
20160407 22:15:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 22:20:12-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has left #wesnoth-dev ["Ciao!"]
20160407 22:22:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160407 22:32:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 22:51:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20160407 22:53:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160407 22:55:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 22:58:26-!- irker652 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160407 22:58:26< irker652> wesnoth: gfgtdf wesnoth:master 2b6442abc21d / src/ (ai/actions.cpp whiteboard/manager.cpp): attempt to fix whitboard crash during ai turn. https://github.com/wesnoth/wesnoth/commit/2b6442abc21dadf0655112c8288f6088bedb1626
20160407 22:58:39< gfgtdf> wedge009: can you test it ^ ?
20160407 23:00:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20160407 23:00:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160407 23:16:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160407 23:26:57-!- travis-ci [~travis-ci@ec2-23-20-39-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20160407 23:26:58< travis-ci> wesnoth/wesnoth#9227 (master - 2b6442a : gfgtdf): The build was broken.
20160407 23:26:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/121566965
20160407 23:26:58-!- travis-ci [~travis-ci@ec2-23-20-39-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20160407 23:47:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160407 23:49:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
--- Log closed Fri Apr 08 00:00:10 2016