--- Log opened Fri May 13 00:00:21 2016
--- Day changed Fri May 13 2016
20160513 00:00:21< shadowm> Yes.
20160513 00:00:37< mattsc> So it’s really an AI-only problem.  Hmm.
20160513 00:00:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 00:02:03< mattsc> And does the unit have other weapons that remain active, or are all of them disabled?
20160513 00:02:28< mattsc> I just want to know what I need to do to set up my own test case.
20160513 00:02:47< shadowm> There are other active weapons, yes.
20160513 00:04:13< mattsc> Okay.  I’ll see if I can reproduce and trouble-shoot it.
20160513 00:05:04< shadowm> I mean, I could give you an existing recipe for reproducing it, but it's very awkward.
20160513 00:05:24< mattsc> Yeah, let me try it in my AI test scenario first.
20160513 00:24:01< mattsc> shadowm: In my test the AI respects the disabled weapon.  I disabled the ranged attack for a Mage and made him attack a bat with his staff that way.
20160513 00:24:24< mattsc> I’ll be afk for a while now.  BBL.
20160513 00:31:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160513 00:32:54-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 00:34:54-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 00:39:25-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 00:39:37-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 00:39:52-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 00:42:08-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 265 seconds]
20160513 00:42:38-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 00:42:46-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 00:44:17-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 00:50:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 00:57:01< shadowm> loonycyborg: Have you asked Soliton if he's interested in reviewing PR #645?
20160513 00:57:26< shadowm> And why did filesystem_sdl.cpp lose its license header during the split?
20160513 00:58:17< shadowm> Oh, right, filesystem_common.cpp did it first when split from filesystem.cpp.
20160513 00:58:33< shadowm> That's... not great.
20160513 00:59:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160513 00:59:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160513 00:59:51< shadowm> I'll just say that it's exceedingly suspicious that we lose user-facing functionality for what's supposed to be a backend/network API change.
20160513 01:00:11< shadowm> No matter how underused or pointless that user-facing functionality may be considered these days.
20160513 01:01:49< shadowm> That's the end of my feedback since I won't be able to review it thoroughly any time soon.
20160513 01:03:28 * celticminstrel wonders if that's referring to the rooms.
20160513 01:03:34< shadowm> Addendum: The "reimplement this" and "reimplement that" commits don't really make a positive contribution to my opinion of the whole thing.
20160513 01:05:00< shadowm> There's also a stray SVN $Id$ line somewhere in a file's first line.
20160513 01:07:09< shadowm> celticminstrel: It doesn't really matter if that's what I'm referring to or not, my point still stands.
20160513 01:08:54< vultraz> I disagree, but you probably expected that.
20160513 01:09:35< celticminstrel> I'd like to be more clear about what vultraz is disagreeing with.
20160513 01:09:42< celticminstrel> There's two or three possibilities from context.
20160513 01:10:22< vultraz> I disagree with shadow.m's point
20160513 01:10:36< celticminstrel> Which point specifically?
20160513 01:11:44< vultraz> that an internal refactor need retain all user-facing functionality regardless of its usefulness
20160513 01:12:42< celticminstrel> Perhaps not "need", but I would say that it probably should retain all functionality if possible.
20160513 01:13:05< Aginor> a refactor, by its definition, shouldn't change the features, only the implementation thereof
20160513 01:13:14< celticminstrel> ^
20160513 01:13:27< celticminstrel> Also, I think part of his point might've been that something the devs consider useless might actually be seen as useful by someone else.
20160513 01:13:38< vultraz> Well now you're just arguing semantics :P
20160513 01:14:21< Aginor> no, a refactor shouldn't drop features just because, dropping features should be discussed and have agreement
20160513 01:14:32< celticminstrel> Definitely.
20160513 01:15:16< Aginor> which is different from refactoring
20160513 01:16:33-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20160513 01:19:01-!- stikonas [~stikonas@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 01:20:15-!- louis94 [~~louis94@91.178.242.163] has quit [Quit: Konversation terminated!]
20160513 01:48:53-!- gfgtdf [~chatzilla@x4e36a0b5.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]]
20160513 01:54:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160513 01:55:08-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160513 01:57:10< mattsc> shadowm: so, I cannot reproduce your problem with the information I have
20160513 01:58:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160513 02:00:19< shadowm> Okay, should we move on to the more elaborate case then?
20160513 02:04:48< mattsc> Unless you have another suggestion how I could test it.
20160513 02:05:17< shadowm> Not really, because I did try setting up an isolated case before and it didn't produce the expected results.
20160513 03:43:35-!- ancestral [~ancestral@67-4-254-184.mpls.qwest.net] has joined #wesnoth-dev
20160513 03:43:44-!- ancestral [~ancestral@67-4-254-184.mpls.qwest.net] has quit [Client Quit]
20160513 04:00:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160513 04:10:39-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160513 04:21:22-!- zhf [~zhf@121.63.196.9] has joined #wesnoth-dev
20160513 04:28:44-!- zhf_ [~zhf@45.63.59.147] has joined #wesnoth-dev
20160513 04:28:45-!- zhf [~zhf@121.63.196.9] has quit [Ping timeout: 246 seconds]
20160513 04:40:06-!- zhf__ [~zhf@45.63.59.147] has joined #wesnoth-dev
20160513 04:41:29-!- zhf_ [~zhf@45.63.59.147] has quit [Ping timeout: 260 seconds]
20160513 04:41:50-!- Kwandulin [~Miranda@p200300760F3949F7BC93C3C7EB190638.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160513 04:56:29-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160513 05:06:57-!- zhf__ [~zhf@45.63.59.147] has quit [Read error: Connection reset by peer]
20160513 05:17:28-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20160513 05:17:28-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20160513 05:17:28-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160513 05:21:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20160513 05:21:22-!- noy_ is now known as noy
20160513 05:31:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160513 05:33:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160513 05:43:17-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 05:48:03-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Ping timeout: 240 seconds]
20160513 05:59:31-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160513 06:18:31-!- louis94 [~~louis94@91.178.242.127] has joined #wesnoth-dev
20160513 06:21:00-!- louis94 [~~louis94@91.178.242.127] has quit [Client Quit]
20160513 06:35:49< vultraz> so, blurring in [message] seems to work fine now
20160513 06:35:59< vultraz> does anyone want it back
20160513 06:47:14-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160513 06:47:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160513 07:07:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160513 07:07:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160513 07:09:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160513 07:10:46< Soliton> shadowm: he asked me to review the asio branch a while ago. i've not gotten far though, need to take time to do that one day...
20160513 07:12:13< Soliton> he's also asked about whether it is worth to reimplement certain features so depending on what it's about i don't see losing user-facing functionality in a rewrite as an issue.
20160513 07:13:53< Soliton> i would also not be surprised to find todo notes about stuff that still needs reimplementation in a WIP PR.
20160513 07:14:51< zookeeper> vultraz, everyone
20160513 07:17:02-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20160513 07:17:17-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160513 07:19:03-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20160513 07:22:16-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160513 07:22:54< Aginor> zookeeper?
20160513 07:23:40< vultraz> zookeeper: how deep?
20160513 07:23:46< vultraz> 1 - 5
20160513 07:24:06< vultraz> where 5 is the level the objectives popup has
20160513 07:24:09< zookeeper> same as objectives
20160513 07:24:23< zookeeper> to start with anyway. maybe it's too high, i'm not sure.
20160513 07:24:59< zookeeper> Aginor, i guess i can file a simple report about it if you need it
20160513 07:30:17-!- irker336 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160513 07:30:17< irker336> wesnoth: Charles Dang wesnoth:master eb943e57af0c / data/gui/ (macros/_initial.cfg widget/panel_wml_message.cfg widget/window_default.cfg): Reapplied blur effect to [message]s https://github.com/wesnoth/wesnoth/commit/eb943e57af0cb0abd386334fba7bd0eb48f86f06
20160513 07:30:37< vultraz> zookeeper: see how that looks
20160513 07:32:29< shadowm> vultraz: wesnoth -dt, move the Druid to the Manual hex, look at the scrollbar.
20160513 07:32:39< shadowm> I think that's unrelated to this change anyway.
20160513 07:33:07< shadowm> OTOH, try hovering list items in an [option] choice dialog.
20160513 07:33:25< shadowm> The Drink hex, for example.
20160513 07:34:03< vultraz> what the hell is up with the scrollbar o_O
20160513 07:34:20< shadowm> Or clicking on the text boxes from the Parrot dialog.
20160513 07:34:51< vultraz> unrelated bug: I can't select the Wolf Rider because he has a selected event
20160513 07:36:11< vultraz> hmmmm
20160513 07:36:14< vultraz> this is interesting
20160513 07:36:16< loonycyborg> shadowm: actually it's more than just backend change, because it's also overall architecture shift from procedural to event based paradigm.
20160513 07:36:35< shadowm> It's the same stuff I alluded to the other day when zookeeper decided my words weren't simple enough.
20160513 07:36:53< vultraz> looks like Blur causes an unnecessary redraw
20160513 07:37:27< loonycyborg> and the reason I removed room support is because I switched to using boost.multi-index to keep track of users and games
20160513 07:37:35< vultraz> I'd have to test this on Aginor's branch :|
20160513 07:37:52< vultraz> dammit
20160513 07:38:04< loonycyborg> to prevent the possibility of having games without users, or games with inexistant users
20160513 07:38:14< vultraz> or maybe Aginor can test on his branch?
20160513 07:38:16< loonycyborg> according to comments this was a possible outcomebefore :P
20160513 07:39:03< shadowm> I've seen dead games before, indeed.
20160513 07:40:14< shadowm>     shadowm@nanacore ~/src/wesnoth-1.12 % scons -j6 cxxtool=g++-6
20160513 07:40:19 * shadowm crosses fingers.
20160513 07:43:12< shadowm> Oh huh, I found the Boost 1.60 all-dev metapackage. How come I didn't see it before...
20160513 07:45:40< irker336> wesnoth: Charles Dang wesnoth:master f32b10aa33ad / data/gui/ (4 files in 2 dirs): Fixed transparent scrollbar buttons https://github.com/wesnoth/wesnoth/commit/f32b10aa33adcca92df091644bae73785b14243e
20160513 07:45:42< vultraz> One thing fixed
20160513 07:46:02< zookeeper> vultraz, looks pretty good to me
20160513 07:46:58< shadowm> Eeek.
20160513 07:47:03< vultraz> zookeeper: ok, good. sadly some performance issues I didn't notice.
20160513 07:47:32< vultraz> but again, testing will have to be done on whatever branch Aginor has his fixes on now
20160513 07:47:35< shadowm> I can't link Wesnoth 1.12 using GCC 6 and Boost 1.58 for some reason.
20160513 07:48:27< shadowm> https://gist.githubusercontent.com/shikadilord/97a482ce72d63ef171b5bbb38197e473/raw/de8d4097282175a10f503fffdd0bebd193350c0f
20160513 07:50:16< shadowm> Any ideas?
20160513 07:51:14< shadowm> Oh actually, this is the test suite target, hm.
20160513 07:51:52< shadowm> Same thing with the game target.
20160513 07:55:16< shadowm> I doubt it will make a difference since 1) if the issue lies in Wesnoth, Wesnoth is still Wesnoth; 2) if it's a problem with Boost, both versions in Debian are built with GCC 5; but I'll see if I get better results with Boost 1.60.
20160513 07:56:13-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 07:59:23-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 07:59:59-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 08:00:34< shadowm>   /usr/include/boost/type_traits/detail/bool_trait_def.hpp:18:78: note: #pragma message: NOTE: Use of this header (bool_trait_def.hpp) is deprecated
20160513 08:00:50< shadowm> Okay, maybe I do not want Boost 1.60 after all. I had forgotten that its own headers cause it to complain.
20160513 08:01:05< shadowm>     src/tests/main.cpp:21:54: fatal error: boost/test/detail/unit_test_parameters.hpp: No such file or directory
20160513 08:01:08< shadowm> Yay.
20160513 08:01:25< loonycyborg> shadowm: most likely linker error is due to different gcc versions used to compile boost and wesnoth
20160513 08:03:18< shadowm> So, that big number change actually does mean that GCC doesn't do ABI compatibility anymore.
20160513 08:03:52< shadowm> I thought it was just that they decided to copy Microsoft/Mozilla/Google's nonsensical versioning scheme.
20160513 08:04:04< shadowm> loonycyborg: Is that what you are telling me?
20160513 08:04:25< loonycyborg> they're supposed to try
20160513 08:04:31< loonycyborg> but maybe it's a bug
20160513 08:05:13< shadowm> I can't find anything that explicitly says anything about compatibility breakage on all platforms/x86_64 in https://gcc.gnu.org/gcc-6/changes.html .
20160513 08:05:42< shadowm> Unlike https://gcc.gnu.org/gcc-5/changes.html .
20160513 08:05:48< loonycyborg> also it mentions cxx17/cxx11 abi, maybe that causes some sort of incompatibility
20160513 08:07:40< shadowm> Okay, hopefully someone else can provide me with a less probabilistic hypothesis.
20160513 08:07:46-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Ping timeout: 265 seconds]
20160513 08:08:33-!- Kwandulin [~Miranda@p200300760F3949F7BC93C3C7EB190638.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160513 08:10:53-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160513 08:17:31< shadowm> Hmph.
20160513 08:17:54< shadowm> I got Wesnoth to compile with Boost 1.60 by applying Aginor's ff29581baa74dbc6ce1923e1352f4fd6d423a67d on 1.12.
20160513 08:18:37< shadowm> Still can't link anything with GCC 6, though, so I guess I'll try again with GCC 5 and PR and eventually merge that if Aginor doesn't mind.
20160513 08:20:26< shadowm> (Well, not 'eventually' as in shadowm-eventually, but rather as in as soon as travis succeeds in testing the PR against an older version of Boost for me.)
20160513 08:38:16< shadowm> Oh right, GitHub has a "reactions" feature now.
20160513 08:38:54< shadowm> I should add a :( to everything in the pull requests tracker.
20160513 08:39:07< shadowm> Including PR #656 itself.
20160513 08:47:26< shadowm> aquileia: Maybe you should comment on https://gna.org/bugs/?24568 and assign it to yourself?
20160513 08:59:07< Aginor> I'll go and add a reaction to it
20160513 08:59:18< Aginor> shadowm: what's the GCC 6 issue?
20160513 09:01:35< shadowm> 04:48:28 <shadowm> https://gist.githubusercontent.com/shikadilord/97a482ce72d63ef171b5bbb38197e473/raw/de8d4097282175a10f503fffdd0bebd193350c0f
20160513 09:01:52< Aginor> you're up late/early
20160513 09:01:53< shadowm> As far as I could tell, it's the same with either Boost 1.58 or 1.60.
20160513 09:02:20< shadowm> Potentially because both were built with GCC 5 (even though the GCC 6 announcement doesn't say anything obvious about ABI breakage).
20160513 09:02:40< Aginor> hmmm
20160513 09:02:49< Aginor> it is a disinct possibility
20160513 09:03:33< Aginor> I would expect there to be more problems though
20160513 09:04:31-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 09:10:03-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Ping timeout: 240 seconds]
20160513 09:19:44-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has quit [Ping timeout: 260 seconds]
20160513 09:31:58-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Remote host closed the connection]
20160513 09:38:30-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has joined #wesnoth-dev
20160513 10:10:48-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20160513 10:11:02-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160513 10:38:56-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160513 10:56:56-!- esr [~esr@wesnoth/developer/esr] has quit [Ping timeout: 265 seconds]
20160513 10:58:20-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160513 11:01:33-!- stikonas [~stikonas@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20160513 11:02:22-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160513 11:06:54-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160513 11:07:25-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Client Quit]
20160513 11:08:00-!- Kwandulin [~Miranda@p200300760F3949F789EA08ED3C223FF2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160513 11:16:23-!- exciton_ [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160513 11:20:07-!- exciton [chuck-the-@89.208.170.132] has quit [Ping timeout: 260 seconds]
20160513 11:22:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 11:26:42-!- Duthlet [~Duthlet@p4FC92BE3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160513 11:30:40-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 11:30:50-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 11:33:01-!- Appleman1234 [~Appleman1@KD036012039112.au-net.ne.jp] has quit [Read error: Connection reset by peer]
20160513 12:07:13-!- irker336 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160513 12:15:31-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160513 12:17:52-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-xrdsdgjfwzejimgv] has quit [Ping timeout: 264 seconds]
20160513 12:23:41-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Remote host closed the connection]
20160513 12:25:00-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160513 12:30:32-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-ehxgdsfvuapagvlk] has joined #wesnoth-dev
20160513 12:30:55-!- matthiaskrgr is now known as Guest6584
20160513 12:46:49-!- prkc [~prkc@catv-89-133-36-138.catv.broadband.hu] has quit [Ping timeout: 260 seconds]
20160513 12:48:47-!- Kwandulin [~Miranda@p200300760F3949F789EA08ED3C223FF2.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160513 12:56:55-!- louis94 [~~louis94@91.178.242.127] has joined #wesnoth-dev
20160513 12:58:49-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160513 13:06:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160513 13:13:32-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 13:23:01-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 13:35:56-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 13:36:24-!- louis94 [~~louis94@91.178.242.127] has quit [Ping timeout: 260 seconds]
20160513 13:37:02-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 13:42:02-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 276 seconds]
20160513 13:44:09-!- Appleman1234 [~Appleman1@KD036012039112.au-net.ne.jp] has joined #wesnoth-dev
20160513 13:46:44-!- deathisundead [~quassel@c-68-48-230-245.hsd1.mi.comcast.net] has joined #wesnoth-dev
20160513 13:46:44-!- deathisundead [~quassel@c-68-48-230-245.hsd1.mi.comcast.net] has quit [Changing host]
20160513 13:46:44-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20160513 13:47:55-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 13:49:05-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 13:52:04-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 13:52:47-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 13:52:53-!- Greg-Boggs [~greg_bogg@12.6.60.227] has joined #wesnoth-dev
20160513 13:57:01-!- Greg-Boggs [~greg_bogg@12.6.60.227] has quit [Remote host closed the connection]
20160513 14:14:27-!- Kwandulin [~Miranda@p200300760F3949F778934DC45835C52B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160513 14:20:53-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Quit: Konversation terminated!]
20160513 14:23:04-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20160513 14:25:37-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-czyaimgzxgrqarpv] has joined #wesnoth-dev
20160513 14:27:30-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160513 14:28:26-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-czyaimgzxgrqarpv] has quit [Read error: No route to host]
20160513 14:28:41-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-ujwdnmznkfmynyup] has joined #wesnoth-dev
20160513 14:29:44-!- louis94 [~~louis94@91.178.242.127] has joined #wesnoth-dev
20160513 14:30:39-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-ujwdnmznkfmynyup] has quit [Remote host closed the connection]
20160513 14:30:50-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-smjmpczrifdhbkyl] has joined #wesnoth-dev
20160513 14:30:55-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-smjmpczrifdhbkyl] has quit [Remote host closed the connection]
20160513 14:32:16-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-qghsketkrwpojewt] has joined #wesnoth-dev
20160513 14:32:18-!- Kwandulin_2 [~Miranda@p200300760F39494978934DC45835C52B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160513 14:34:02-!- Kwandulin [~Miranda@p200300760F3949F778934DC45835C52B.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20160513 14:37:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160513 14:44:33-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-qghsketkrwpojewt] has quit [Remote host closed the connection]
20160513 14:45:51-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-dwujnjdvuzkypvxt] has joined #wesnoth-dev
20160513 14:51:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160513 15:04:20-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160513 15:05:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160513 15:18:07-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 260 seconds]
20160513 15:19:24-!- Appleman1234 [~Appleman1@KD036012039112.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20160513 15:32:38-!- prkc [~prkc@catv-89-133-36-138.catv.broadband.hu] has joined #wesnoth-dev
20160513 15:41:16-!- mjs-de [~mjs-de@x4e30ae40.dyn.telefonica.de] has joined #wesnoth-dev
20160513 15:52:59-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-dwujnjdvuzkypvxt] has quit [Read error: Connection reset by peer]
20160513 15:53:22-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-qtgcbvtsgsuwenvu] has joined #wesnoth-dev
20160513 15:57:26< mattsc> shadowm: I have figured out why the disabled weapon is used.  The fix is easy and I think that particular code path is only called from the AI, so it should not cause OOS error.
20160513 15:57:39< mattsc> But I am not 100% certain about that latter part yet.
20160513 15:58:01< mattsc> Let me know when you’re around and I’ll walk you through what is going on.
20160513 16:02:27-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20160513 16:07:51-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has quit [Read error: Connection reset by peer]
20160513 16:21:58-!- EdB [~edb@89.193.129.77.rev.sfr.net] has joined #wesnoth-dev
20160513 16:38:42-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-qtgcbvtsgsuwenvu] has quit [Remote host closed the connection]
20160513 16:39:15-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-qkbtnrsilcnurbfl] has joined #wesnoth-dev
20160513 16:44:41< zookeeper> Jetrel_bot, https://forums.wesnoth.org/viewtopic.php?f=9&t=44152
20160513 16:46:40-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-qkbtnrsilcnurbfl] has quit [Remote host closed the connection]
20160513 16:50:01-!- exciton_ [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20160513 16:50:15-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160513 16:50:26< EdB> isn't that info available from svn log?
20160513 16:51:44-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-xffjebhbpkgzjdob] has joined #wesnoth-dev
20160513 16:55:08-!- Greg-Bog_ [greg_boggs@conference/drupalcon/x-wnckvszgvwwirkdl] has joined #wesnoth-dev
20160513 16:56:23-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-jffqyyejslkoemsq] has quit [Remote host closed the connection]
20160513 16:56:51-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-xffjebhbpkgzjdob] has quit [Ping timeout: 276 seconds]
20160513 16:59:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160513 16:59:59-!- Greg-Bog_ [greg_boggs@conference/drupalcon/x-wnckvszgvwwirkdl] has quit [Ping timeout: 260 seconds]
20160513 17:02:56-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-hyfndilhqilnwdww] has joined #wesnoth-dev
20160513 17:03:31-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-hyfndilhqilnwdww] has quit [Read error: Connection reset by peer]
20160513 17:03:51-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-wliluntyuquqjsri] has joined #wesnoth-dev
20160513 17:04:12-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-wliluntyuquqjsri] has quit [Remote host closed the connection]
20160513 17:04:18-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-pqugbwjhynjcueao] has joined #wesnoth-dev
20160513 17:04:26-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-zgrfjgbxfgjggbsw] has joined #wesnoth-dev
20160513 17:04:30-!- Guest6584 [matthiaskr@gateway/shell/panicbnc/x-ehxgdsfvuapagvlk] has quit [Changing host]
20160513 17:04:30-!- Guest6584 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160513 17:04:30-!- Guest6584 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20160513 17:04:30-!- Guest6584 [matthiaskr@gateway/shell/panicbnc/x-ehxgdsfvuapagvlk] has joined #wesnoth-dev
20160513 17:05:19-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160513 17:05:19-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160513 17:05:36-!- Guest6584 is now known as matthiaskrgr
20160513 17:13:38-!- Greg-Boggs [greg_boggs@conference/drupalcon/x-pqugbwjhynjcueao] has quit [Remote host closed the connection]
20160513 17:26:49< celticminstrel> EdB: It's not in git log, because sprites and sounds are typically commited by zookeeper, vultraz, or other devs, rather than by their original creators.
20160513 17:27:16< celticminstrel> (At least nowadays. I suppose it could've been different in the past.)
20160513 17:30:51< EdB> celticminstrel: ah! tks
20160513 17:35:06< zookeeper> well, typically whoever commits them mentions the artist in the commit message
20160513 17:35:47< zookeeper> so if i need to find out the artist, i do always check the commit log first
20160513 17:35:51< celticminstrel> Ah, that's a good point.
20160513 17:36:26< celticminstrel> Still, I guess that's a convention rather than a hard rule...
20160513 17:36:40< zookeeper> and i wasn't prompting jetrel to tell him who the artist is, i was prompting him to reply as the artist in question :p
20160513 17:36:48< celticminstrel> Ah.
20160513 17:37:28-!- louis94 [~~louis94@91.178.242.127] has quit [Ping timeout: 250 seconds]
20160513 18:00:28-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160513 18:07:14-!- {V} [~V@105-70-ftth.on.nl] has quit [Quit: Leaving]
20160513 18:18:51-!- Kwandulin_2 [~Miranda@p200300760F39494978934DC45835C52B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160513 18:24:46-!- LovCAPONE [~lovens@modemcable184.138-20-96.mc.videotron.ca] has quit [Quit: C++ makes you go broke: no matter how much you invest the final return is always zero]
20160513 18:28:03-!- louis94 [~~louis94@91.178.242.127] has joined #wesnoth-dev
20160513 18:30:24-!- LovCAPONE [~lovens@modemcable184.138-20-96.mc.videotron.ca] has joined #wesnoth-dev
20160513 19:13:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160513 19:32:33-!- louis94 [~~louis94@91.178.242.127] has quit [Ping timeout: 240 seconds]
20160513 19:42:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160513 20:19:33< shadowm> mattsc: Why do I have to be around for that? :p
20160513 20:20:47< mattsc> It’s easier interactively in case I am not clear enough.
20160513 20:25:29< shadowm> Hm, we don't have a translation build job for 1.12 on Travis?
20160513 20:26:03< shadowm> Oh I see, translations are built as part of the clang and GCC jobs then.
20160513 20:27:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20160513 20:27:11-!- irker647 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160513 20:27:11< irker647> wesnoth: Andreas Löf wesnoth:1.12 64095e788817 / / (4 files in 3 dirs): Fix bug #24234: Add Boost 1.60.0 support to unit tests https://github.com/wesnoth/wesnoth/commit/64095e788817885647c021fab3994c5c4914866b
20160513 20:27:13< irker647> wesnoth: Ignacio R. Morelle wesnoth:1.12 8de39e81ae42 / / (4 files in 3 dirs): Merge pull request #656 from shikadilord/backport/1.12-Aginor-bug-24234 https://github.com/wesnoth/wesnoth/commit/8de39e81ae423a2abb3291f077a4811f2f6eabcc
20160513 20:35:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160513 20:46:06-!- shadowm changed the topic of #wesnoth-dev to: 1.12.6 ETA: May 18th 00:00 UTC | String freeze active on 1.12 | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160513 21:05:31-!- mjs-de [~mjs-de@x4e30ae40.dyn.telefonica.de] has quit [Remote host closed the connection]
20160513 21:24:06-!- EdB [~edb@89.193.129.77.rev.sfr.net] has quit [Quit: Konversation terminated!]
20160513 21:39:37-!- louis94 [~~louis94@91.178.242.127] has joined #wesnoth-dev
20160513 21:47:51-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160513 21:51:51-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Remote host closed the connection]
20160513 21:51:55< shadowm> mattsc: Okay, I'm here now.
20160513 21:59:11< mattsc> shadowm: Okay.  The other reason is that I want to talk this through with somebody, to figure out whether my arguments make sense.
20160513 21:59:16< mattsc> So, we start here: https://github.com/wesnoth/wesnoth/blob/master/src/actions/attack.cpp#L320
20160513 21:59:45< shadowm> Does it have to be master?
20160513 22:00:03< mattsc> Oh, no, of course not, but I think it’s all the same.  Hold on.
20160513 22:00:04-!- louis94 [~~louis94@91.178.242.127] has quit [Ping timeout: 250 seconds]
20160513 22:00:25< shadowm> It depends on which branch you used as reference for your research.
20160513 22:00:28< mattsc> 1.12:  https://github.com/wesnoth/wesnoth/blob/1.12/src/actions/attack.cpp#L319
20160513 22:00:47< mattsc> The relevant parts are the same between 1.12 and master, I mean.
20160513 22:00:54< shadowm> Hm, okay.
20160513 22:00:57< mattsc> The line numbers might be slightly different.
20160513 22:01:17< mattsc> So, 1.12 then, same file, l.333
20160513 22:01:28< shadowm> I'm in battle_context::battle_context().
20160513 22:01:58< shadowm> battle_context::battle_context(const unit_map&, const map_location& etc. etc.), to be specific.
20160513 22:01:59< mattsc> The AI provides -1 as weapon numbers, meaning “use best weapon”.
20160513 22:03:08< mattsc> As far as I know, -1 is passed _only_ by the AI  (that is not important for finding the problem, but might be for the fix)
20160513 22:03:48< mattsc> So, now we jump to battle_context::choose_attacker_weapon(), l.471
20160513 22:04:18< mattsc> Now, the problem happens in the for loop starting in l.509
20160513 22:04:48< shadowm> Yeah, that's what I found after adding some debug messages.
20160513 22:05:06< mattsc> The call to choose_defender_weapon() sometimes produces attack statistics, and sometimes not.
20160513 22:05:30< mattsc> (I didn’t bother with figuring out why and when it does, the important part is that it does sometimes, but not always)
20160513 22:06:21< mattsc> If it does not, attacker_combatant_ is not set, we enter the if statement in l.514, and it is checked whether the attack is disabled (l.521)
20160513 22:06:24< mattsc> All’s good.
20160513 22:07:05< mattsc> The problem is when choose_defender_weapon() does return the stats, then that block is skipped and no check for disabled attacker weapon is done.
20160513 22:07:19< mattsc> choose_defender_weapon() only checks for the defender weapon being disabled.
20160513 22:07:44< mattsc> So there are two potential easy fixes:
20160513 22:08:20< mattsc> l.531: add an else block that repeats the attacker_stats_->disable block
20160513 22:08:39< mattsc> or: in choose_defender_weapon() also check whether the attacker weapon is disabled.
20160513 22:09:45< mattsc> Now, I believe that choose_*_weapon are only called from AI functions and would therefore not cause OOS errors between 1.12 version with and without this fix, but I am not 100% certain of that.
20160513 22:10:17< mattsc> *and this fix would therefore … versionS ...
20160513 22:11:03< shadowm> Wouldn't those be used when selecting a defender's weapon in retaliation from a human player's action as well?
20160513 22:12:00< shadowm> For example, if my unit has one ranged and one melee attack, yours has four of each type, I believe the retaliation choices I get in the attack dialog are supposed to be your best options against my unit's attack choices.
20160513 22:12:20< mattsc> Ah, yes, I think that is true
20160513 22:13:18< mattsc> I had the feeling that I had missed something, but couldn’t come up with what.
20160513 22:13:54< shadowm> But more importantly, none of this code is unit tested, no-one currently active understands it in depth (AFAIK), and I definitely don't want to be the one to inadvertently break gameplay in stable, either in the general case, or in specific border cases like this.
20160513 22:14:58< shadowm> And considering that the trigger is already obscure enough to invoke statements like "this simulation sometimes yields a result and sometimes it doesn't , not sure when".
20160513 22:15:55< mattsc> Well, the same simulation always yields the same result.  And I could figure out the part up there where I said I haven’t investigated.
20160513 22:16:03< mattsc> But I agree with what you said.
20160513 22:19:08< shadowm> So perhaps I'd b more comfortable with filing a bug report including this analysis, so that someone with more time to parse the entire combat logic can decide how to go about fixing it in master. And leave 1.12 untouched.
20160513 22:20:29< shadowm> That said, I _think_ it wouldn't cause OOS regardless because AFAICT the replay format is such as the attack/defense weapon pair is specified by the replay commands themselves so that the game doesn't need to re-do the simulation.
20160513 22:21:16< shadowm> But I'm primarily concerned about the potential for breaking one of the cornerstones of the game engine in a stable series.
20160513 22:22:49< shadowm> (Re commands, for example, this is an attack command: https://gist.github.com/shikadilord/b803005b25c2c75998ad7934f20b0f97 )
20160513 22:23:12< mattsc> I just checked and that is indeed the case, both weapons are specified in the replay commands
20160513 22:23:31< mattsc> yes
20160513 22:24:41< mattsc> So, yes, I agree that it would probably not break anything, but probably isn’t good enough for within a stable series.
20160513 22:28:57< shadowm> :V The biggest issue is that I don't know what's needed to write an isolated test case that doesn't require a specific add-on at a specific version in a specific scenario with a specific set of unit states.
20160513 22:31:26< shadowm> For the record, your first proposed fix works (of course), although I didn't determine which objects need to be released and unset so it's not in a push-able state.
20160513 22:32:05< mattsc> Okay, great.  On the test case, I can have another look into that, but not right now (and probably not today).
20160513 22:33:09< shadowm> Side-note: I'm not happy about the fact that this code relies on memory being managed manually across scopes.
20160513 22:51:23-!- gfgtdf [~chatzilla@x4e36a0b5.dyn.telefonica.de] has joined #wesnoth-dev
20160513 22:52:04< gfgtdf> mattsc: iirc -1 is also passed for human attacks, so that for example when the attack unit dialog is opened the best weapon is preseleted
20160513 22:53:31< gfgtdf> mattsc: in replay both weapns are give, even the defender ones, this is mainly becasue thjere was one a OOS bug cuased by different floating points reults when the client chose their defpender wepons on their own
20160513 22:56:18< mattsc> gfgtdf: yeah, that makes sense, thanks
20160513 22:59:08-!- louis94 [~~louis94@91.178.242.127] has joined #wesnoth-dev
20160513 23:29:36-!- irker647 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160513 23:45:55-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Ping timeout: 252 seconds]
20160513 23:54:31-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20160513 23:54:45-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160513 23:55:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
--- Log closed Sat May 14 00:00:41 2016