--- Log opened Thu May 19 00:00:25 2016
20160519 00:02:25< SigurdFD> it was spelled correctly in my tests.
20160519 00:02:54< celticminstrel> Hmm, so there may be a problem in the [object] implementation...
20160519 00:04:23< celticminstrel> But it looks right to me...
20160519 00:06:25 * celticminstrel notes that the relevant code is data/lua/wml/object.lua, starting at line 30.
20160519 00:07:37< SigurdFD> teleport as an object doesn't work in 1.12.5 either
20160519 00:07:52< celticminstrel> ...huh.
20160519 00:08:01< celticminstrel> What's going on here...
20160519 00:08:19< celticminstrel> What's your WML look like?
20160519 00:08:31< SigurdFD> wait, forgot to add dvs in 1.12.5, let me test again
20160519 00:08:35< celticminstrel> I'm pretty sure I have a teleport object that was working in 1.12.5.
20160519 00:09:01< shadowm> https://gna.org/bugs/index.php?18893
20160519 00:09:53< celticminstrel> So I guess that means making dvs default to true is a bad idea?
20160519 00:10:07< celticminstrel> He doesn't mention what the severe problems were though. :/
20160519 00:12:18< celticminstrel> I dunno.
20160519 00:12:30< celticminstrel> That bug report is just kinda unclear in general...
20160519 00:12:45< SigurdFD> tested, adding dvs in the object doesn't make it work in 1.12.5
20160519 00:13:06< celticminstrel> Can I see your WML?
20160519 00:15:23< celticminstrel> I'm pretty sure this was working in 1.12.5: https://github.com/CelticMinstrel/DruidSiege/blob/master/utils/initiates.cfg#L397
20160519 00:15:40< SigurdFD> http://pastebin.com/yw6S6Dmw
20160519 00:15:59< celticminstrel> Oh.
20160519 00:16:08< celticminstrel> [modify_unit] doesn't support dvs, I think.
20160519 00:16:34< celticminstrel> Hmm.
20160519 00:16:49< SigurdFD> ...
20160519 00:17:21< celticminstrel> I think if you move the [filter] into the [object] and drop the outer [modify_unit] tags, it should work.
20160519 00:17:27< celticminstrel> But...
20160519 00:17:43< celticminstrel> Maybe [modify_unit] should honour dvs within [object]s.
20160519 00:18:22< celticminstrel> That should be pretty easy to implement.
20160519 00:18:26< SigurdFD> that's what I would think.
20160519 00:18:56< SigurdFD> I think in my case if modify_unit doesn't do dvs, I'd have to use store/unstore_unit
20160519 00:23:48< celticminstrel> SigurdFD: I think this patch should do it. http://pastebin.com/fquCDdm8
20160519 00:26:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160519 00:28:54< celticminstrel> Huh, it seems the *.user files ended up in the repo again for VC12. They should probably be removed.
20160519 00:29:36 * celticminstrel would poke wedge009 about it, but it seems he's not around for once.
20160519 00:30:15< SigurdFD> ok, I'll test it out in an hour or two, bbl
20160519 00:30:36< celticminstrel> ...good thing I set it to expire in a day instead of in an hour.
20160519 00:36:06< SigurdFD> was it for 1.12.5 or current master?
20160519 00:36:13< celticminstrel> Current master.
20160519 00:36:27< celticminstrel> Could be applied on 1.12.5 too, I think, but would be in a different place.
20160519 00:37:29 * vultraz thinks the folder should have been called VS2013 and not VC12
20160519 00:38:41< celticminstrel> Same thing.
20160519 00:41:40< vultraz> Former is more recognizable 
20160519 00:43:08< vultraz> since it names the IDE
20160519 00:43:26< vultraz> ya see
20160519 00:43:52< celticminstrel> Eh.
20160519 00:44:37< SigurdFD> celticminstrel: the patch worked
20160519 00:45:03< celticminstrel> So, with that patch, both teleport and leadership now work with dvs?
20160519 00:45:40< SigurdFD> tried leadership, let check teleport
20160519 00:46:07-!- gfgtdf [~chatzilla@x4e36346a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]]
20160519 00:47:30< SigurdFD> yes, they both work with the patch
20160519 00:49:21-!- irker155 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160519 00:49:21< irker155> wesnoth: Celtic Minstrel wesnoth:master af58b33acaa7 / changelog data/lua/wml/modify_unit.lua: [modify_unit] now supports dvs for modifications https://github.com/wesnoth/wesnoth/commit/af58b33acaa7ef4e0df6727808a098415a9ec835
20160519 00:49:31< celticminstrel> Not sure if that can count as a fix for your bug, but it's something, I guess.
20160519 00:49:50< SigurdFD> I'd say it's a fix
20160519 00:51:47< SigurdFD> as it makes modify_unit conform to the existing behavior of how ability_teleport works when applied as an object as outlined in the wiki
20160519 00:55:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160519 01:05:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 01:10:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160519 01:42:29< vultraz> if the bug is fixed do mark as closed
20160519 01:42:31< vultraz> er
20160519 01:42:32< vultraz> fixed
20160519 01:42:35< vultraz> not closed until a release
20160519 01:56:14< celticminstrel> I'm assuming the bug is in 1.13.5, so shouldn't be closed yet.
20160519 01:56:48< celticminstrel> (Well, it wouldn't affect leadership in 1.13.5, but it would affect teleport, I think.)
20160519 01:57:45< celticminstrel> For the time being, I'm going to mention leadership and backstab in the [object] documentation, too.
20160519 01:58:01< shadowm> 1.13.5.
20160519 01:58:19< celticminstrel> Was it 1.13.4?
20160519 01:58:29< celticminstrel> Whichever the latest release is.
20160519 01:58:29< shadowm> So tell me, who's the new release manager and why did they release 1.13.5 without telling anyone?
20160519 01:58:35< shadowm> Exactly.
20160519 01:58:38< celticminstrel> Sorry, my mistake.
20160519 02:00:48-!- aeth_ [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160519 02:01:26-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Disconnected by services]
20160519 02:01:38-!- aeth_ is now known as aeth
20160519 02:02:04< SigurdFD> hmmm... the bug was specificially applying leadership & teleport in an object using the modify_unit tag. 
20160519 02:02:35< celticminstrel> I added mention of [modify_unit] in the bug summary, yes.
20160519 02:03:18< SigurdFD> the cases of placing an object to be picked up and using store_unit/unstore_unit tags to apply the object, were not by me. I'm assuming they work
20160519 02:03:43< SigurdFD> not tested
20160519 02:04:23< celticminstrel> Works in 1.12.5 as far as I know, and the code enabling it in 1.13.x is pretty much the same as what I added in [modify_unit], so should work... but maybe I should test it to be sure.
20160519 02:04:56< celticminstrel> I guess one reason to use [modify_unit] is that it applies it to every unit matching the filter, rather than just a random unit matching the filter.
20160519 02:05:20< SigurdFD> it does not work in 1.12.5, that was part of my test (the [modify_unit] approach)
20160519 02:05:37< celticminstrel> I was referring to the [object] approach when I said that.
20160519 02:05:52< SigurdFD> ??? got confused.
20160519 02:05:54< celticminstrel> My campaign adds a teleport ability in an [object], so I think I would have noticed if it was broken/
20160519 02:06:13< celticminstrel> I'm not sure why you'd use store_unit/unstore_unit for this...
20160519 02:06:22< SigurdFD> I mean that the commit you did can be backported
20160519 02:06:45< celticminstrel> Yeah, it can be backported, though the code is in a different file in 1.12.x.
20160519 02:06:53< SigurdFD> okkkkkkkkkkkkkkkkkkkkk
20160519 02:07:25< celticminstrel> I moved [modify_unit] and some of the other larger tags to their own files in 1.13.x.
20160519 02:07:31< SigurdFD> ok
20160519 02:07:34< celticminstrel> Larger code-wise.
20160519 02:08:01< celticminstrel> I'm not sure why you'd use store/unstore to apply an object.
20160519 02:08:22< celticminstrel> Using object as ActionWML with a teleport ability is what I was saying works in 1.12.5.
20160519 02:08:28< celticminstrel> WIth dvs=yes.
20160519 02:08:36< SigurdFD> ok
20160519 02:08:43< celticminstrel> I think we both got confused somewhere. Sorry.
20160519 02:09:25< celticminstrel> I think this should be fixed "note: The syntax allowed is somehow vague".
20160519 02:11:30< SigurdFD> yeah. It seems to be able to handle everything about a unit.
20160519 02:12:39< celticminstrel> It should even be able to edit attacks and abilities and even modifications, though the latter probably isn't reliable since you can't really make any assumptions about the order that modifications appear in.
20160519 02:13:02< celticminstrel> I suppose it can't edit animations though. I think those might not be included in the unit WML when storing a unit.
20160519 02:14:16< celticminstrel> Anyone happen to know whether that's actually true?
20160519 02:14:56< SigurdFD> I think the animations statement is true.
20160519 02:15:55< SigurdFD> when I've done gender changes on a unit, all I had to adjust in addtion was the profile & small_profile keys. did not have to deal with different animations
20160519 02:16:30< celticminstrel> Hmm, maybe we should add [effect]apply_to=gender after all, then.
20160519 02:16:54< celticminstrel> I guess that would have to be handled in a way similar to variations - force it to be processed last, that is.
20160519 02:17:47< celticminstrel> Or, could add gender= key to [effect]apply_to=variation I suppose.
20160519 02:17:54< celticminstrel> Not sure if that would be better.
20160519 02:18:05< celticminstrel> I think genders are internally handled almost the same as variations.
20160519 02:18:11< celticminstrel> Maybe identically to variations.
20160519 02:19:52< SigurdFD> idk. 
20160519 02:20:29< SigurdFD> gender change is easy enough, change gender, clear profile keys, transform unit to same type as before.
20160519 02:20:46< celticminstrel> Does it work if you skip the profile part? Probably not, I guess.
20160519 02:21:04< SigurdFD> note that if unit in quesion is using a custom profile portrait, it will be lost in the process
20160519 02:21:25< celticminstrel> That's easy to fix.
20160519 02:21:41< SigurdFD> no, clearing profile was necssary, the why is outlined in the rules for profile key handling on the wiki somewhere
20160519 02:21:46< celticminstrel> Apply the custom profile as a modification instead of directly, with two effects, one for each possible gender.
20160519 02:24:29< SigurdFD> but most units using a custom profile are not made to be different genders to begin with.
20160519 02:24:50< celticminstrel> True, true.
20160519 02:25:00-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Read error: Connection reset by peer]
20160519 02:25:00< SigurdFD> though some are.
20160519 02:25:00< celticminstrel> But there could be situations in which you might want it.
20160519 02:25:13< celticminstrel> I don't actually know of any that are.
20160519 02:25:18-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160519 02:25:37< celticminstrel> Something like this should work, I think: http://pastebin.com/WAm0Yyqh
20160519 02:27:55< SigurdFD> thanks, though that's not the use-case I had.
20160519 02:29:11< SigurdFD> though others may find that it's what they need.
20160519 02:30:14< celticminstrel> Well, that expires 10 minutes from when I posted it though.
20160519 02:30:25< SigurdFD> I copied it.
20160519 02:30:33< celticminstrel> Ah.
20160519 02:31:31< SigurdFD> what I did above was for making a way for someone to change gender of a regular unit.
20160519 02:31:56< SigurdFD> after it has been placed
20160519 02:33:28< SigurdFD> as for modify_unit and changing modification subtags, that's just best done with lua.
20160519 02:36:09-!- louis94 [~~louis94@91.178.242.115] has quit [Ping timeout: 246 seconds]
20160519 02:36:23-!- louis94 [~~louis94@91.178.241.69] has joined #wesnoth-dev
20160519 02:55:56-!- louis94 [~~louis94@91.178.241.69] has quit [Remote host closed the connection]
20160519 03:02:45-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 260 seconds]
20160519 03:04:17-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160519 03:51:01-!- irker155 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160519 03:53:35-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 276 seconds]
20160519 03:58:30-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160519 04:30:42-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-176-151.zoominternet.net] has quit []
20160519 04:54:29-!- Duthlet [~Duthlet@p4FC92611.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 05:14:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 05:15:02-!- exciton [chuck-the-@89.208.170.132] has quit [Read error: Connection reset by peer]
20160519 05:15:16-!- exciton [chuck-the-@89.208.170.132] has joined #wesnoth-dev
20160519 05:19:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160519 05:32:18-!- Kwandulin [~Miranda@p200300760F3949637824A22EB51C8955.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 05:35:12-!- aquileia [~androirc@176.4.28.101] has joined #wesnoth-dev
20160519 05:37:26< aquileia> celticminstrel, gfgtdf: Guess I should've pinged you two as well - the .user files are needed
20160519 05:38:05< aquileia> celticminstrel, gfgtdf: Guess I should've pinged you two as well - the .user files are needed to specify the Run/Debug environment
20160519 05:38:54< celticminstrel> Huh?
20160519 05:39:16< celticminstrel> What do you mean?
20160519 05:42:44-!- aquileia [~androirc@176.4.28.101] has quit [Remote host closed the connection]
20160519 05:43:17-!- aquileia [~androirc@176.4.28.101] has joined #wesnoth-dev
20160519 05:43:59< aquileia> If you don't have it, wesnoth a) won't find its root directory and b) will have to restart to set an environment variable for openMP
20160519 05:44:50< celticminstrel> Ah, I see, so it's kinda similar to the reasons why I was going to add the xcscheme files into the repo...
20160519 05:45:02< celticminstrel> (Just haven't gotten around to it yet.)
20160519 05:46:29< aquileia> For personal settings there's a separate .<name>.user file
20160519 05:46:51< celticminstrel> ...which is also similar to how xcschemes work...
20160519 05:47:03< celticminstrel> Interesting...
20160519 05:48:13< aquileia> Send there aren't all that many ways to get build files compatible with VCS
20160519 05:49:13< celticminstrel> I feel like your first word doesn't fit.
20160519 05:49:41< aquileia> *seems
20160519 05:51:07-!- Sapient [~yourstrul@180.190.89.163] has joined #wesnoth-dev
20160519 05:51:07-!- Sapient [~yourstrul@180.190.89.163] has quit [Changing host]
20160519 05:51:07-!- Sapient [~yourstrul@wesnoth/developer/Sapient] has joined #wesnoth-dev
20160519 05:51:27 * aquileia writes on his smartphone
20160519 05:51:53-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160519 05:53:34< aquileia> Anyhow, I'm off again
20160519 05:54:35< Sapient> hmm... is wesnoth.org having some DNS issues at the moment?
20160519 05:54:47< aquileia> Jetrel: BTW, I'm reading the logs, so feel free to give your feedback on https://github.com/wesnoth/wesnoth/compare/master...aquileia:sprites anytime
20160519 05:55:00< Jetrel_bot> okay, will do soon
20160519 05:55:31< aquileia> Ah, you're online!
20160519 06:03:22< zookeeper> shadowm, celticminstrel, i didn't even remember that teleport bug existed -.-
20160519 06:14:43< zookeeper> i think it's fair to cite all this as an example of how much thought really needs to go into offloading stuff from the engine to WML :p
20160519 06:15:20< zookeeper> (which might very well be "more than anyone is able to give it")
20160519 06:26:55-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20160519 06:28:42< vultraz> celticminstrel: suggest [message] not scrolling if next unit is not within half of distance from center of visible hexes to edge of visible hexes 
20160519 06:29:17< celticminstrel> Sounds vaguely like a good idea. So, how does one determine using Lua whether a tile is visible onscreen?
20160519 06:29:32< celticminstrel> Or is new API needed for that?
20160519 06:30:09< vultraz> new API
20160519 06:30:14< vultraz> as far as I know
20160519 06:31:10< vultraz> then again, this might be difficult
20160519 06:31:27< vultraz> since messages would need to remember the location of the previous speakers..
20160519 06:31:32-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 276 seconds]
20160519 06:31:51< celticminstrel> Why would they?
20160519 06:31:58< celticminstrel> It doesn't matter who spoke last.
20160519 06:31:59-!- aquileia2 [~androirc@wlan132-206.wlan.uni-ulm.de] has joined #wesnoth-dev
20160519 06:32:07< celticminstrel> What matters is whether the current speaker is already onscreen.
20160519 06:32:45< vultraz> oh, I see what you're saying
20160519 06:32:48< vultraz> yes, that's simpler
20160519 06:32:50< Sapient> so the penchant for moving WML engine code from C++ to Lua contines
20160519 06:33:50< vultraz> It does
20160519 06:34:05< celticminstrel> I didn't do this one just because I could, though. There was a reason related to the new [break] and similar tags.
20160519 06:35:05< Sapient> right, because those were in Lua.
20160519 06:35:12-!- aquileia [~androirc@176.4.28.101] has quit [Ping timeout: 246 seconds]
20160519 06:35:32< celticminstrel> I ported [message] and [object] because they can both contain ActionWML subtags.
20160519 06:37:57< Sapient> I guess I've been out of the loop for a while but why does ActionWML subtag mean it must go the Lua route?
20160519 06:38:29-!- aquileia [~androirc@eduroam173-154.wlan.uni-ulm.de] has joined #wesnoth-dev
20160519 06:39:36 * vultraz does not see why moving things to lua should be a problem
20160519 06:39:45-!- aquileia2 [~androirc@wlan132-206.wlan.uni-ulm.de] has quit [Ping timeout: 246 seconds]
20160519 06:39:55< celticminstrel> Because the implementation of [break] and similar would have required jumping throgh C++ code otherwise.
20160519 06:40:00< celticminstrel> I think.
20160519 06:40:07< celticminstrel> Something like that.
20160519 06:40:41< celticminstrel> Basically, the thought was that if you use [return] in a [message][option][command] for example, then the event should terminate just like it would if you used [return] anywhere else in an event.
20160519 06:41:11< celticminstrel> I can't remember whether having [message] in Lua was required for that to work or if it just simplified it.
20160519 06:43:05< celticminstrel> It's not simply having ActionWML subtags that's the key point, it's how [break] or [return] should behave when encountered in that context.
20160519 06:43:25< Sapient> ok, thanks for that explanation celticminstrel. 
20160519 06:43:29< celticminstrel> So, [on_undo] doesn't need to be in Lua despite containing ActionWML, because it runs as a separate pseudo-event.
20160519 06:44:22< Sapient> wait... you mean [on_undo] doesn't support break/return ?
20160519 06:44:35< celticminstrel> No, it should support it.
20160519 06:44:46< celticminstrel> But a break or return within that doesn't affect the containing event.
20160519 06:44:58< Sapient> I see
20160519 06:45:58< celticminstrel> Which makes sense, because that code isn't run when the [on_undo] tag is encountered but instead stored to be run if the user uses undo.
20160519 06:46:06< Sapient> vultraz: I will refrain from commenting on the wisdom of various design choices which went against my philosophy because it is what it is now just gonna deal with it
20160519 06:46:32< vultraz> Ah, your philosophy
20160519 06:46:37 * celticminstrel doesn't think that moving things to Lua is a problem but also doesn't think it should be done solely for the sake of doing it.
20160519 06:46:48< vultraz> Let us not get into a debate of philosophy 
20160519 06:47:40< Sapient> My philosophy is one of incremental improvements rather than rewrites (thus GUI 1.5 and the construct_dialog)
20160519 06:48:04< Sapient> The idea was to gradually refactor as each needed functionality was added
20160519 06:48:28< vultraz> All I say about that is that's fine when the base is stable
20160519 06:48:46< celticminstrel> I think I ported a few other tags to Lua besides [object] and [message], but the Lua versions merely call new API functions, so it's more like an attempt to move towards using wesnoth.* functions instead of wesnoth.wml_actions.* functions.
20160519 06:49:04< vultraz> GUI1 is horribly designed and as such, refactoring it is necessary
20160519 06:49:08< vultraz> Or was, I should say
20160519 06:49:13< celticminstrel> It's not like I completely reimplemented the functionality in Lua - I just moved the C++ code around.
20160519 06:49:16< celticminstrel> More or less.
20160519 06:52:36< Sapient> it does mean that a WML engine developer now needs to know three languages rather than two, and an additional non-trivial layer of interface
20160519 06:53:05< vultraz> I never said it was an optimal solution :P
20160519 06:53:19< celticminstrel> Eh, that's been the case for longer than I've been around, I'm pretty sure.
20160519 06:53:19< vultraz> I would support a total revamp that gave us a single unified system
20160519 06:53:35< celticminstrel> ...though I'm not sure whether you're talking about ActionWML or GUI2.
20160519 06:53:43< shadowm> Our biggest technical debt sources lie in C++ land right now, so I don't see what all the fuss is about, really.
20160519 06:53:52< Sapient> as I said, I've made peace with those decisions. No point second guessing it now
20160519 06:54:48< Sapient> but I'm not sure which area I'm qualified to work on anymore. whether to learn GUI2 or Lua
20160519 06:55:18< zookeeper> still plenty of c++ things to work on :J
20160519 06:55:28< celticminstrel> Including GUI2. :|
20160519 06:55:42< celticminstrel> Or its replacement, if such a thing can be agreed on, I guess.
20160519 06:56:07< zookeeper> for example right now it'd be great if someone improved various ban-related things in wesnothd...
20160519 06:56:08< vultraz> Har
20160519 06:57:33< Sapient> zookeeper: yeah, feel free to send me a wishlist of bug/FR you think I can tackle and I'll use that as a starting point
20160519 07:03:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 07:03:04-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160519 07:03:10-!- atarocch [~atarocch@151.64.66.6] has joined #wesnoth-dev
20160519 07:05:17-!- atarocch [~atarocch@151.64.66.6] has quit [Client Quit]
20160519 07:05:28-!- atarocch [~atarocch@151.64.66.6] has joined #wesnoth-dev
20160519 07:07:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160519 07:08:15< zookeeper> Sapient, how about allowing top-level global [event]s? :x i'm trying to finally fix the stupidity of having the feeding ability event inside ABILITY_FEEDING.
20160519 07:08:44< zookeeper> i haven't really found the right entrypoint for hooking in something like that
20160519 07:12:07< Sapient> that's an interesting request. so where would the event be defined?
20160519 07:13:40< zookeeper> at top-level? or a dedicated top-level container, if it's easier that way.
20160519 07:15:05< Sapient> ok, I'll check for low hanging fruits in the bug reports as well
20160519 07:15:14-!- Sapient [~yourstrul@wesnoth/developer/Sapient] has quit [Quit: Have fun, cya!]
20160519 07:31:17-!- boucman_work [~boucman@247.37.0.109.rev.sfr.net] has joined #wesnoth-dev
20160519 08:07:35-!- aquileia2 [~androirc@eduroam173-154.wlan.uni-ulm.de] has joined #wesnoth-dev
20160519 08:07:35-!- aquileia [~androirc@eduroam173-154.wlan.uni-ulm.de] has quit [Read error: Connection reset by peer]
20160519 08:20:08-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160519 08:35:03-!- aquileia2 [~androirc@eduroam173-154.wlan.uni-ulm.de] has quit [Ping timeout: 240 seconds]
20160519 08:51:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 08:55:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160519 09:14:51-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20160519 09:20:03-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 246 seconds]
20160519 09:54:45-!- mjs-de [~mjs-de@p508C8D41.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 10:08:02< vultraz> zookeeper: didn't gfgtdf allow events in [campaign] or something?
20160519 10:13:14< zookeeper> yes
20160519 10:13:17-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160519 10:13:36-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160519 10:24:27-!- atarocch [~atarocch@151.64.66.6] has quit [Quit: Leaving]
20160519 10:25:12-!- atarocch [~atarocch@151.64.66.6] has joined #wesnoth-dev
20160519 10:25:24-!- atarocch [~atarocch@151.64.66.6] has quit [Remote host closed the connection]
20160519 10:25:49-!- atarocch [~atarocch@151.64.66.6] has joined #wesnoth-dev
20160519 10:36:30-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160519 10:39:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 10:44:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160519 10:51:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 10:51:24-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Read error: Connection reset by peer]
20160519 10:51:42-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20160519 10:55:54-!- Greywhind [~Greywhind@c-71-232-29-126.hsd1.ma.comcast.net] has quit [Ping timeout: 276 seconds]
20160519 10:56:23-!- Greywhind [~Greywhind@c-71-232-29-126.hsd1.ma.comcast.net] has joined #wesnoth-dev
20160519 10:57:03-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160519 11:06:36-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160519 11:11:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160519 11:12:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 11:12:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160519 11:13:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 11:38:15-!- louis94 [~~louis94@91.178.241.69] has joined #wesnoth-dev
20160519 11:52:46-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 11:54:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20160519 12:05:31-!- Kwandulin [~Miranda@p200300760F3949637824A22EB51C8955.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160519 12:27:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 12:31:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160519 12:33:44-!- gfgtdf [~chatzilla@x4e32b3a6.dyn.telefonica.de] has joined #wesnoth-dev
20160519 12:34:01-!- louis94 [~~louis94@91.178.241.69] has quit [Quit: Konversation terminated!]
20160519 12:35:07< gfgtdf> zookeeper: if we'd alllow event]s at toplevel it'd mostliekel still be included in every savefile, so the feedign code doesnt seem liek agood usecase for it
20160519 12:36:20< zookeeper> well there's not much alternatives, aside from creating a completely separate mechanism for global events inserted only in certain circumstances
20160519 12:37:49-!- stikonas_ is now known as stikonas
20160519 12:37:50< zookeeper> i don't know/recall that part of the code, but maybe they wouldn't need to even be included in every savefile?
20160519 12:38:08< zookeeper> if so then there wouldn't be a problem. but if they'd be included, it'd arguably be a bit awkward.
20160519 12:40:09< zookeeper> and maybe it's doable in lua? i don't know, but if someone can do so then great
20160519 12:48:57< vultraz> I think we need to have some sort of global namespace that the game always loads
20160519 12:49:13< vultraz> that can accept events, that is
20160519 12:49:57< zookeeper> yeah
20160519 12:50:20< vultraz> anything in here would not be included in any savefile
20160519 12:50:34< zookeeper> unless that could be avoided
20160519 12:50:49< vultraz> that = what?
20160519 12:50:57< zookeeper> the including
20160519 12:51:15< zookeeper> it's not like we include every unit type definition and terrain graphics rule in every savefile, so why couldn't we have events that aren't either?
20160519 12:51:25< vultraz> yes
20160519 12:51:33< vultraz> that's what I'm suggesting
20160519 12:51:37< zookeeper> ohh
20160519 12:51:44< zookeeper> i somehow skipped over the "not" in what you said
20160519 12:51:49< zookeeper> so, yes, agreed
20160519 12:52:36< vultraz> Hopefully addons would be able to use that too
20160519 12:52:40< vultraz> In the same manner
20160519 12:53:22< zookeeper> doesn't sound hard to allow
20160519 12:54:04< vultraz> I would prefer this to events in [campaign], I think
20160519 12:55:30< vultraz> though...
20160519 12:55:37< vultraz> actually I guess it'd be the same thing. nvm
20160519 12:55:59< vultraz> oh wait, no
20160519 12:56:23< vultraz> unit types are wrapped in an include... not [campaign]
20160519 12:56:30< vultraz> zookeeper: so I think we need something like [global_events]
20160519 12:56:39< vultraz> which functions like [units]
20160519 12:56:57< zookeeper> well functionally i think it'd be the same whether you have [campaign] [event] or #ifdef MYCAMPAIGN [+global_events] [event], no?
20160519 12:57:31< vultraz> I guess
20160519 12:57:39< vultraz> But I think it'd be better to keep [campaign] clean of events
20160519 12:58:15< vultraz> remember. [campaign]'s contents are always loaded
20160519 12:58:30< vultraz> so if you stuff a shitton of events in there, you increase initial loading times
20160519 12:58:33< vultraz> of the game itself
20160519 12:58:34< zookeeper> ah, true
20160519 12:58:35< vultraz> see?
20160519 12:59:12< zookeeper> although, can't you wrap stuff inside the [campaign] into its #ifdef to avoid that? :P
20160519 12:59:24< vultraz> you *could* but it's messy
20160519 12:59:30< zookeeper> it'd look fun
20160519 12:59:33< vultraz> better to keep [campaign] strictly metadata 
20160519 13:00:18< vultraz> gfgtdf: how complicated would it be to implement a [global_events] tag (functionality similar to [units])?
20160519 13:03:58-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160519 13:04:07< vultraz> (side note: since lua has its own global namespace it IS possible to inject events there, but it's not very neat)
20160519 13:05:20< gfgtdf> vultraz: well i don't know, the prpoblems are that you must also think about things like what happens when that even is removed by wml
20160519 13:05:38< gfgtdf> vultraz: if you dpn't want them to be in savefiles that is
20160519 13:06:22< vultraz> id say you shouldn't be able to remove events in the global namespace
20160519 13:06:31< vultraz> but there should be some way to "mute" them
20160519 13:07:26< zookeeper> or you can just allow them to be removed, even if they re-appear again on next load
20160519 13:08:28-!- prkc [~prkc@catv-89-133-36-138.catv.broadband.hu] has joined #wesnoth-dev
20160519 13:08:28-!- prkc [~prkc@catv-89-133-36-138.catv.broadband.hu] has quit [Client Quit]
20160519 13:08:40< vultraz> I think first we should get it working
20160519 13:08:46< vultraz> then decide about removal/muting
20160519 13:08:52< vultraz> we might decide not to allow either
20160519 13:08:59-!- prkc [~prkc@46.166.188.232] has joined #wesnoth-dev
20160519 13:10:49-!- Kwandulin [~Miranda@p200300760F394963D11530877CFAEC82.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 13:12:18< gfgtdf> i'd really vote for not allowing to remove them, and i pepel wanrt them motable they can just add asome check for some variables in the event
20160519 13:12:25< zookeeper> yeah i don't think removal is much of an issue regardless of what we do about it
20160519 13:12:46< gfgtdf> specialyl since i consider suhca  behaviour chagne on reload quet bad
20160519 13:13:15< gfgtdf> and alternative would be to have dummy event in the savefiles they just refecne the outer events
20160519 13:13:49< gfgtdf> but regatding the feeding event i think i'l just move it to lua
20160519 13:14:12< zookeeper> well let's not do both
20160519 13:14:43< zookeeper> if we're gonna have global events then let's keep feeding as the core example/testcase
20160519 13:14:57< zookeeper> if not, then sure moving it to lua is fine
20160519 13:16:30< vultraz> I support global events
20160519 14:20:43-!- molgrum [~molgrum@unaffiliated/molgrum] has left #wesnoth-dev ["ERC (IRC client for Emacs 24.5.1)"]
20160519 14:29:49-!- Appleman1234 [~Appleman1@KD036012044167.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20160519 14:34:35-!- Kwandulin [~Miranda@p200300760F394963D11530877CFAEC82.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20160519 14:45:42-!- Kwandulin [~Miranda@p200300760F3949253CEF445463E111B8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 15:26:38-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160519 15:31:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 15:32:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160519 15:33:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 15:41:30< gfgtdf> does store_unit also stores unit form the recall list by default ?
20160519 15:44:17-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160519 15:44:17< zookeeper> yes
20160519 15:50:16-!- Appleman1234 [~Appleman1@KD036012044167.au-net.ne.jp] has joined #wesnoth-dev
20160519 16:10:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20160519 16:26:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160519 16:29:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 16:32:25-!- mjs-de [~mjs-de@p508C8D41.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20160519 16:34:17-!- Kwandulin [~Miranda@p200300760F3949253CEF445463E111B8.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160519 16:40:19-!- mjs-de [~mjs-de@p508C8CFA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 16:49:37-!- louis94 [~~louis94@91.178.241.69] has joined #wesnoth-dev
20160519 17:03:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 17:06:30-!- Estradavi [~quassel@90.165.24.149] has joined #wesnoth-dev
20160519 17:16:35-!- Estradavi [~quassel@90.165.24.149] has quit [Remote host closed the connection]
20160519 17:35:45-!- Kwandulin [~Miranda@p200300760F39492574178E4487C1B741.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 17:58:48-!- gfgtdf [~chatzilla@x4e32b3a6.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]]
20160519 17:59:41-!- Duthlet [~Duthlet@p4FC92611.dip0.t-ipconnect.de] has quit [Quit: leaving]
20160519 18:15:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160519 18:18:52-!- louis94 [~~louis94@91.178.241.69] has quit [Ping timeout: 250 seconds]
20160519 18:23:53-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160519 18:23:59-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160519 18:26:40-!- Netsplit *.net <-> *.split quits: nurupo, iwaim, shadowm
20160519 18:26:48-!- Netsplit over, joins: shadowm, nurupo
20160519 18:27:00-!- Netsplit over, joins: iwaim
20160519 18:29:14-!- Kwandulin [~Miranda@p200300760F39492574178E4487C1B741.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160519 18:38:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20160519 18:50:38-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20160519 18:55:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 18:55:48-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 246 seconds]
20160519 18:56:02-!- louis94 [~~louis94@91.178.241.69] has joined #wesnoth-dev
20160519 19:00:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160519 19:01:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 19:05:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 19:05:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160519 19:20:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160519 19:39:24-!- Lath [a3ac2316@gateway/web/freenode/ip.163.172.35.22] has joined #wesnoth-dev
20160519 19:39:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160519 19:40:03-!- Lath [a3ac2316@gateway/web/freenode/ip.163.172.35.22] has quit [Client Quit]
20160519 19:41:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 19:41:26-!- mjs-de [~mjs-de@p508C8CFA.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20160519 19:45:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160519 19:57:15-!- deathisundead is now known as The_Unforgiven
20160519 20:00:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 20:27:39< shadowm> zookeeper: Have you considered removing the ellipses under the statues in Caves of the Basilisk?
20160519 20:30:02< zookeeper> i haven't, probably because i almost can't even see them, faint as they are
20160519 20:30:17< zookeeper> but seems like a good idea anyway
20160519 20:33:28< zookeeper> (it'd also be convenient if animations could specify whether to display the hp/xp bars or not... seeing how [animate_unit] can)
20160519 20:34:05< shadowm> It's more involved than you think, that much I can say.
20160519 20:34:38< zookeeper> oh i don't doubt it
20160519 20:36:36< zookeeper> i wonder if the hp bar should simply not be drawn if it's 1/1.
20160519 20:45:34< zookeeper> urgh, no way to turn off ellipses altogether without adding 2-6 blank images, i think
20160519 20:45:47< shadowm> Uh...
20160519 20:46:12< shadowm> [effect] apply_to=ellipse   ellipse=none
20160519 20:46:27< shadowm> Or ellipse=none directly in [unit] might work too.
20160519 20:46:46< zookeeper> doesn't that still lead to the lovely image not found image getting used?
20160519 20:47:09< shadowm> No, the 'none' special case was added by AI0867 in 1.11.1 (yes, in the middle of a feature freeze, who the hell knows why).
20160519 20:47:16< shadowm> *1.11.11
20160519 20:47:38< zookeeper> and left undocumented, apparently
20160519 20:47:39< zookeeper> handy
20160519 20:48:18< Aginor> morning
20160519 20:48:28< zookeeper> evening
20160519 20:52:21< zookeeper> shadowm, anyway, yeah, i'll turn them off then if/since that works
20160519 20:53:02< shadowm> I know for a fact it does work.
20160519 20:56:50< zookeeper> indeed it does
20160519 20:57:09< zookeeper> not that i doubted, but naturally i had to test for myself
20160519 20:59:27-!- irker130 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160519 20:59:27< irker130> wesnoth: ln-zookeeper wesnoth:master eaa7dac9c2c4 / data/multiplayer/scenarios/2p_Caves_of_the_Basilisk.cfg: Disabled ellipses of the statues https://github.com/wesnoth/wesnoth/commit/eaa7dac9c2c4459ecdddfcad128ee7e4593799c9
20160519 21:05:38< zookeeper> since i'm feeling energetic i'll even document the "none" magic value
20160519 21:17:47-!- louis94 [~~louis94@91.178.241.69] has quit [Ping timeout: 260 seconds]
20160519 21:31:46-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160519 21:32:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160519 21:37:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160519 21:52:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160519 21:52:00-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160519 21:55:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20160519 22:02:12-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160519 22:13:16-!- louis94 [~~louis94@91.178.241.69] has joined #wesnoth-dev
20160519 22:51:03-!- Appleman1234 [~Appleman1@KD036012044167.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160519 23:17:14-!- mjs-de [~mjs-de@p508C8CFA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160519 23:37:06-!- mjs-de [~mjs-de@p508C8CFA.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20160519 23:49:38-!- Appleman1234 [~Appleman1@KD036012032059.au-net.ne.jp] has joined #wesnoth-dev
20160519 23:50:52-!- Appleman1234 [~Appleman1@KD036012032059.au-net.ne.jp] has quit [Remote host closed the connection]
20160519 23:59:26-!- irker130 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
--- Log closed Fri May 20 00:00:12 2016