--- Log opened Mon Jun 06 00:00:03 2016
20160606 00:01:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160606 00:01:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Excess Flood]
20160606 00:02:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160606 00:27:36-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160606 00:27:44-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160606 00:45:02< celticminstrel> I would like to merge the following PRs: 651, 642, possibly 650 and 660. Does anyone have any objections?
20160606 00:45:15< celticminstrel> Elvish_Hunter: Was there anything else you forgot to add?
20160606 00:45:54< celticminstrel> loonycyborg: What about PR 653? 
20160606 00:46:11< celticminstrel> For PR 660 I'd actually like people to comment before I merge it.
20160606 00:49:22< celticminstrel> mattsc: You didn't update the XCode project for the SDL_net stuff, did you? I didn't see a commit to that effect.
20160606 00:57:12< loonycyborg> celticminstrel: pot-update now works so I don't mind merging
20160606 00:57:26< loonycyborg> with pr 653 that is
20160606 00:57:38< celticminstrel> Do you want to merge it?
20160606 00:57:51< celticminstrel> As opposed to me merging it.
20160606 01:00:38< loonycyborg> I see that some new strings starting at data/core/macros/names.cfg:101 are picked up now
20160606 01:01:50< loonycyborg> looks like the new message tag
20160606 01:01:59< celticminstrel> Well, that line does begin one of the generator grammars, though it's not the first in the file...
20160606 01:02:11< celticminstrel> New message tag?
20160606 01:02:53< loonycyborg> the _ << >> thing
20160606 01:04:57< loonycyborg> actually it starts fromline 20
20160606 01:05:59< loonycyborg> anyway it seems to work as it should, so you merge it
20160606 01:06:04< loonycyborg> and I need to go sleep
20160606 01:06:06< loonycyborg> good night
20160606 01:07:41-!- Bonobo [~Bonobo@2001:44b8:254:3200:dd9d:2c75:3e31:3e63] has joined #wesnoth-dev
20160606 01:11:26-!- LovCAPONE [~lovens@modemcable018.107-57-74.mc.videotron.ca] has quit [Quit: Leaving]
20160606 01:52:36< mattsc> celticminstrel: no, I didn’t do anything with the Xcode project
20160606 01:55:57-!- irker253 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160606 01:55:57< irker253> wesnoth: gfgtdf wesnoth:master f36c554bf15d / src/ (5 files in 3 dirs): fix custom faction not available for remote players if it was changed by the hos https://github.com/wesnoth/wesnoth/commit/f36c554bf15dd4de01c0e41ecc5ee415e6b7bc70
20160606 01:55:57< irker253> wesnoth: gfgtdf wesnoth:master 62a589e9ce83 / src/ (3 files in 2 dirs): remove duplicate leader_scroll_dialog code https://github.com/wesnoth/wesnoth/commit/62a589e9ce8334dedc152e0f755aac1ad8c088f9
20160606 01:55:58< irker253> wesnoth: gfgtdf wesnoth:master 80517e2ab55f / src/game_events/action_wml.cpp: remove an include https://github.com/wesnoth/wesnoth/commit/80517e2ab55f4232b0cbf41ea0069fbf7262c3f3
20160606 01:55:59< irker253> wesnoth: gfgtdf wesnoth:master 39b01d9518e8 / src/ (menu_events.cpp team.cpp team.hpp): also show allied human sides in sp in side overview. https://github.com/wesnoth/wesnoth/commit/39b01d9518e8592c9f03748b7dbd0bae588c5e6d
20160606 01:56:00< irker253> wesnoth: gfgtdf wesnoth:master 660b1c1adf8d / src/game_initialization/multiplayer.cpp: remove old simple_server code https://github.com/wesnoth/wesnoth/commit/660b1c1adf8d0ccf966529b897cff38fcf9e2f59
20160606 01:56:02< irker253> wesnoth: gfgtdf wesnoth:master 50a2357461b5 / src/ (dialogs.cpp dialogs.hpp): remove unused dialog::network_send_dialog https://github.com/wesnoth/wesnoth/commit/50a2357461b5a0c0c3468ab021d73c1133cf6972
20160606 01:56:04< irker253> wesnoth: gfgtdf wesnoth:master 52f0e3ecd65a / src/ (30 files in 6 dirs): refactor mp and menu_events code https://github.com/wesnoth/wesnoth/commit/52f0e3ecd65ac39f0a3304c13f752f62ef6c835d
20160606 01:56:06< irker253> wesnoth: gfgtdf wesnoth:master d27851801c56 / src/variable_info.cpp: fix [set_variables] https://github.com/wesnoth/wesnoth/commit/d27851801c562abd435cede8bd0b567f2b68dbbd
20160606 01:56:08< irker253> wesnoth: gfgtdf wesnoth:master c27a026608e5 / src/synced_context.cpp: add a comment https://github.com/wesnoth/wesnoth/commit/c27a026608e56cf464db96afbe6df94ccf94b222
20160606 01:56:10< irker253> wesnoth: gfgtdf wesnoth:master a6b114f6ae50 / src/ (38 files in 4 dirs): use boost asio on clientside wesnothd connection https://github.com/wesnoth/wesnoth/commit/a6b114f6ae50a5241951988616c4952983a7a516
20160606 01:56:12< irker253> wesnoth: gfgtdf wesnoth:master dca57bd5b0b3 / src/ (26 files in 4 dirs): remove uses of network::error and fix gui2 mp lobby https://github.com/wesnoth/wesnoth/commit/dca57bd5b0b3c44582d986b16bc8b0398c4c8245
20160606 01:56:14< irker253> wesnoth: gfgtdf wesnoth:master 033f3c97b34c / src/ (5 files in 2 dirs): allow to write multiple configs in a network package. https://github.com/wesnoth/wesnoth/commit/033f3c97b34c2aa36a9c5d6a6625287dc36dd4f7
20160606 01:56:16< irker253> wesnoth: gfgtdf wesnoth:master 8c4ca5318059 / src/tests/gui/test_gui2.cpp: fix gui2 tests https://github.com/wesnoth/wesnoth/commit/8c4ca5318059bc30970893b3fd8f3cac22706b0d
20160606 01:56:18< irker253> wesnoth: gfgtdf wesnoth:master a85170b691e9 / src/dialogs.cpp: fix dialogs::network_connect_dialog in nogui mode https://github.com/wesnoth/wesnoth/commit/a85170b691e98a6dedbedf181f4d2e405434b339
20160606 01:56:20< irker253> wesnoth: Nobun wesnoth:master bd78612320b4 / utils/ (pywmlx/state/wml_states.py wmlxgettext): wmlxgettext: added support for _ << translatable string >> on WML https://github.com/wesnoth/wesnoth/commit/bd78612320b4d9b61e72bea69b99f2997087a0d5
20160606 01:56:22< irker253> wesnoth: Nobun wesnoth:master a262ff7caa09 / utils/pywmlx/state/wml_states.py: fixed assertion error on wmlstr02 https://github.com/wesnoth/wesnoth/commit/a262ff7caa09c2193c981626e418d774d53be52e
20160606 01:56:24< irker253> wesnoth: Celtic Minstrel wesnoth:master cd8d5c24df0c / utils/ (pywmlx/state/wml_states.py wmlxgettext): Merge pull request #653 from AncientLich/master https://github.com/wesnoth/wesnoth/commit/cd8d5c24df0c885421e4cf6973413eb0d7518b84
20160606 01:56:26< irker253> wesnoth: Charles Dang wesnoth:master e96c31d577fb / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projfile https://github.com/wesnoth/wesnoth/commit/e96c31d577fb9bbb75eee7d5a10120fd94b08567
20160606 01:56:29< irker253> wesnoth: Charles Dang wesnoth:master 9af918b361c3 / src/ (leader_scroll_dialog.cpp leader_scroll_dialog.hpp): Removed empty files https://github.com/wesnoth/wesnoth/commit/9af918b361c35e89e0e278757df94f700bb2480e
20160606 01:56:32< irker253> wesnoth: Charles Dang wesnoth:master 7f3fee88c5d9 / projectfiles/CodeBlocks/wesnoth.cbp src/CMakeLists.txt src/SConscript: Updated build files for 9af918b361c3 https://github.com/wesnoth/wesnoth/commit/7f3fee88c5d9b24ebd55ce71437b79efab86a473
20160606 01:56:35< irker253> wesnoth: gfgtdf wesnoth:master 1dfc56fc0fe6 / src/game_initialization/multiplayer.cpp: fix login with registerd nick https://github.com/wesnoth/wesnoth/commit/1dfc56fc0fe62edca8172b6787bedec9653a9f38
20160606 01:56:44< irker253> wesnoth: Charles Dang wesnoth:1.12 30847b361bfa / data/multiplayer/scenarios/2p_Hornshark_Island.cfg: Hornshark: remove unit ids from Clockwork Boy units (bug #24722) https://github.com/wesnoth/wesnoth/commit/30847b361bfae3b555b23db59cc4101f93b50ef6
20160606 01:56:51< irker253> wesnoth: mattsc wesnoth:master 79015f03926b / data/campaigns/Legend_of_Wesmere/scenarios/chapter1/03_Kalian_under_Attack.cfg: LoW S3: adapt Urudin retreat AI to new Lua engine syntax https://github.com/wesnoth/wesnoth/commit/79015f03926b28b90f371d417b41b2290c1a48ab
20160606 01:56:53< irker253> wesnoth: mattsc wesnoth:master 71f1f4fadee1 / / (2 files in 2 dirs): LoW S3: fix bug which silently disabled Urudin retreat AI https://github.com/wesnoth/wesnoth/commit/71f1f4fadee14f072a0b4f9e8d9a6d1b1a990147
20160606 01:56:59< irker253> wesnoth: mattsc wesnoth:1.12 dd270816af34 / / (2 files in 2 dirs): LoW S3: fix bug which silently disabled Urudin retreat AI https://github.com/wesnoth/wesnoth/commit/dd270816af346a059448c400789f21b3f658f3f5
20160606 01:57:06< irker253> wesnoth: Charles Dang wesnoth:master 168313bed9da / src/ (4 files): Cleaned out some SDL_net-related detritus https://github.com/wesnoth/wesnoth/commit/168313bed9da570d3bf7d4b6bc7fc93db1e7935f
20160606 01:57:09< irker253> wesnoth: Charles Dang wesnoth:master c3d379e3941a / projectfiles/CodeBlocks/ (wesnoth.cbp wesnothd.cbp): Updated CB projfile so it no longer links with SDL_net https://github.com/wesnoth/wesnoth/commit/c3d379e3941a248d42a72d6916931b5c73240e76
20160606 01:57:13< irker253> wesnoth: Charles Dang wesnoth:master 2c98c00fe6ef / src/tests/test_commandline_options.cpp: Attempt to fix tests https://github.com/wesnoth/wesnoth/commit/2c98c00fe6ef8431eb5c9179a9d9a05eeb057b70
20160606 01:57:20< irker253> wesnoth: Charles Dang wesnoth:master 4603d8dcf641 / src/tests/test_commandline_options.cpp: Fixup test fixup https://github.com/wesnoth/wesnoth/commit/4603d8dcf6415200596d409808a9a6e2e67b9705
20160606 01:59:19-!- ugudu [7086511b@gateway/web/freenode/ip.112.134.81.27] has joined #wesnoth-dev
20160606 02:07:29-!- oldlaptop [~quassel@192.183.52.168] has joined #wesnoth-dev
20160606 02:14:10-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160606 02:14:20-!- ugudu [7086511b@gateway/web/freenode/ip.112.134.81.27] has quit [Ping timeout: 250 seconds]
20160606 02:17:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160606 02:28:56-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160606 02:34:39-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Remote host closed the connection]
20160606 02:35:13-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has joined #wesnoth-dev
20160606 02:47:22-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Leaving]
20160606 02:49:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160606 02:57:29-!- Sapient [~yourstrul@wesnoth/developer/Sapient] has joined #wesnoth-dev
20160606 03:02:07-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20160606 03:36:38-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has joined #wesnoth-dev
20160606 03:54:44-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160606 03:55:43-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160606 04:04:01-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20160606 04:07:40< Sapient> typing in the games lobby filter also echoes to the chat box
20160606 04:10:52-!- victorclf [~victorclf@187.181.129.74] has joined #wesnoth-dev
20160606 04:14:19-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160606 04:15:16-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160606 04:18:31< Sapient> based on current design, my expectation is that focus should go to the filter text after I turn on the apply filter checkbox, but it does not 
20160606 04:19:39< Sapient> I actually think popping up a modal dialog would be appropriate though. which would solve  bug #24481 as well
20160606 04:19:41-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20160606 04:20:33< shadowm> Sure, but that's not quite how it works in most list views taking some kind of filter these days, in other applications.
20160606 04:20:55-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160606 04:21:43< shadowm> Papering over performance issues by requiring additional interaction steps for a simple task isn't great.
20160606 04:22:24< celticminstrel> This is in the old lobby?
20160606 04:23:43< Sapient> 1) this isn't a typical list view... there's an expectation that typing at any time allows one to chat
20160606 04:24:19-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Read error: Connection reset by peer]
20160606 04:24:29< Sapient> 2) the user story I'm envisioning would be faster and more convenient with a modal dialog
20160606 04:25:00< Sapient> 3) I agree modal dialogs are clunky and generally it's great to get rid of them... IF there is a better alternative
20160606 04:25:28< shadowm> Input being processed by both boxes surely is a regression if it happens on master. It doesn't on 1.12.x for me.
20160606 04:25:54< shadowm> The user expectation you are talking about is perfectly valid and the solution is simply to make focused widgets more obvious.
20160606 04:27:16< Sapient> perhaps that would be best yes
20160606 04:32:00< Sapient> something like a golden rectangle around the filter textbox?
20160606 04:32:57< shadowm> Probably. vultraz might have some input as well since he's been in charge of UI design for the past while.
20160606 04:35:52< Sapient> the nice thing about the modal is, less mousing around. it pops up once you turn on the checkbox or click the currect filter text, you press excape or make changes then Enter, boom filter applied no extra lag and focus back to chat
20160606 04:36:30< celticminstrel> If there's a regression in the old lobby, it should probably be fixed for 1.13.6, since the new lobby probably still isn't ready.
20160606 04:36:46< shadowm> ... What happened to 1.13.5?
20160606 04:37:00< celticminstrel> Nothing, I just get confused about versions.
20160606 04:37:13< celticminstrel> I meant 1.13.5.
20160606 04:37:38< celticminstrel> I wonder if a modal dialog would help much with the possible performance issues in the new lobby.
20160606 04:37:42< shadowm> Sapient: So if I want to try different filter input multiple times in a row I need two more clicks (and increase of 2 over 0) per attempt.
20160606 04:38:43< shadowm> Potentially 1 instead of 2 if we are to assume that the player will press Enter instead of clicking OK on the modal box (big assumption with some people).
20160606 04:39:05< celticminstrel> Heh.
20160606 04:40:15< shadowm> vultraz: https://dl.dropboxusercontent.com/u/21371130/screenshots/elliptical-bullets.png
20160606 04:40:31< shadowm> Self-explanatory filename. I can't say this makes me any less displeased about Lato.
20160606 04:44:04< shadowm> Also, it looks like Lato bold and regular have considerably different metrics, comparing bold vs. non-bold labels. Either that or (hopefully) you have a mismatched font size in a label variant declaration.
20160606 04:44:04< celticminstrel> I can't even tell that that's elliptical unless I look very closely.
20160606 04:44:04< shadowm> I could at first glance, sadly. I had to check in an image editor to make sure I wasn't imagining things.
20160606 04:44:04< Sapient> shadowm: and your click-savings computation assumes they don't intend to chat between filterings
20160606 04:45:34< shadowm> It's a perfectly reasonable assumption.
20160606 04:46:06< Sapient> ok, I'll drop the idea for now then
20160606 04:46:17< shadowm> Can't say a modal box would be an improvement since as of the past 12 years, having a modal dialog up means that it's impossible for the caller to update its state.
20160606 04:46:28-!- fabi [~quassel@31.213.1.199] has joined #wesnoth-dev
20160606 04:46:28-!- fabi [~quassel@31.213.1.199] has quit [Changing host]
20160606 04:46:28-!- fabi [~quassel@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160606 04:47:06< shadowm> So while you are trying to input your filter, you wouldn't see any lobby activity.
20160606 04:48:54< Sapient> true. it just needs to shout at the user a little more loudly, what you are typing now will not chat. a dialog is just a convenient and existing way of making that super obvious
20160606 04:49:52< shadowm> So would a sufficiently visible focus indicator.
20160606 04:50:35-!- victorclf [~victorclf@187.181.129.74] has quit [Quit: Leaving]
20160606 04:51:14< shadowm> We've always opted for the path of least effort and I think it's become perfectly evident over the years that it doesn't make for great UX.
20160606 04:51:26-!- fabi [~quassel@wesnoth/developer/fendrin] has quit [Remote host closed the connection]
20160606 04:52:39< shadowm> The add-ons management UI is probably the best example of this situation (before I tried my hand at improving it a bit in 1.11.x anyway).
20160606 04:54:07< Sapient> currently in the game lobby I'm seeing two identical carets (neither blinking). the only indication that I'm in the Search box is an almost imperceptible background shift
20160606 04:54:50-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20160606 04:55:05-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has joined #wesnoth-dev
20160606 04:55:34< shadowm> Yep. That's the stuff I'm saying should be changed.
20160606 04:56:34< Sapient> the fancy fix would be to get your own separate thread for gathering the filtered contents I suppose, and only change the view once it's ready?
20160606 04:57:36< shadowm> I mean, we don't even know why it's so slow in the first place. For all I know there's 18 redundant copies of each found element involved in the filtering process.
20160606 04:58:45< shadowm> Maybe there's too much data to sift through. Maybe the data is stored in a format that doesn't allow fast searches. Maybe the bottleneck is the list view rendering step.
20160606 04:59:52< shadowm> Patching performance bottlenecks with threads isn't necessarily the best or worst solution.
20160606 05:00:53-!- Kwandulin [~Miranda@p200300760F3B0603FDF52881F2B7F087.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160606 05:02:33< shadowm> I don't know how quickly the server generally sends updates to the client but it wouldn't be great if the client's hypothetical game list filtering thread had to start over too often because the games list was updated while it was in the middle of searching it. The alternative being to assume it's always going to finish the search just in time before the games list updates and not come up with ...
20160606 05:02:39< shadowm> ... outdated data.
20160606 05:03:01 * shadowm goes back to working on less abstract stuff that doesn't involve master.
20160606 05:03:22< Sapient> well you've given me some food for thought, thanks
20160606 05:20:21-!- Sapient [~yourstrul@wesnoth/developer/Sapient] has quit [Quit: Have fun, cya!]
20160606 05:22:46-!- ugudu [7086511b@gateway/web/freenode/ip.112.134.81.27] has joined #wesnoth-dev
20160606 05:54:47-!- deathisundead [~quassel@unaffiliated/the-unforgiven/x-8713611] has quit [Ping timeout: 260 seconds]
20160606 05:54:52-!- The_Unforgiven [~quassel@unaffiliated/the-unforgiven/x-8713611] has joined #wesnoth-dev
20160606 06:09:23-!- Kwandulin [~Miranda@p200300760F3B0603FDF52881F2B7F087.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160606 06:47:44< celticminstrel> Oh right, I almost forgot I was going to merge some stuff.
20160606 06:49:08-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160606 06:49:14< celticminstrel> I guess I'll have to do it tomorrow.
20160606 06:51:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160606 06:51:31-!- wedge010 is now known as wedge009
20160606 06:56:35-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160606 07:05:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160606 07:14:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160606 07:14:19-!- ancestral [~ancestral@67-4-254-184.mpls.qwest.net] has joined #wesnoth-dev
20160606 07:14:26< ancestral> Okay, fixed things in iMovie
20160606 07:14:37< ancestral> Now I need at least one more video clip
20160606 07:45:25-!- ancestral [~ancestral@67-4-254-184.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160606 07:56:41-!- Appleman1234 [~Appleman1@KD036012038239.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160606 08:11:52< Elvish_Hunter> 00:45:15 < celticminstrel> Elvish_Hunter: Was there anything else you forgot to add?
20160606 08:13:01< Elvish_Hunter> Nothing that I can think of. If nobody else has any suggestion, PR #642 can be merged.
20160606 08:14:22-!- Elvish_Hunter [~elvish_hu@wesnoth/developer/elvish-hunter] has quit [Quit: Ciao!]
20160606 08:27:40-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has joined #wesnoth-dev
20160606 08:45:56-!- Elvish_Hunter_ [~elvish_hu@wesnoth/developer/elvish-hunter] has joined #wesnoth-dev
20160606 08:52:33-!- grzywacz [~karol@ip-94.124.0.122.s.net.pl] has joined #wesnoth-dev
20160606 08:54:05-!- Appleman1234 [~Appleman1@KD036012044004.au-net.ne.jp] has joined #wesnoth-dev
20160606 08:55:44-!- Elvish_Hunter_ is now known as Elvish_Hunter
20160606 08:59:43-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Ping timeout: 258 seconds]
20160606 09:01:40-!- ugudu [7086511b@gateway/web/freenode/ip.112.134.81.27] has quit [Ping timeout: 250 seconds]
20160606 09:17:06-!- atarocch [~atarocch@151.64.73.49] has quit [Remote host closed the connection]
20160606 09:25:09-!- edgrey [~edgrey@178.204.169.141] has joined #wesnoth-dev
20160606 09:51:07-!- gfgtdf [~chatzilla@x4e36a620.dyn.telefonica.de] has joined #wesnoth-dev
20160606 09:51:15< gfgtdf> shadowm: i cannot connect to wesnothd.org
20160606 09:51:34< gfgtdf> shadowm: it givs me error about explired certificate
20160606 09:51:38< shadowm> Well, there's your problem. There's no wesnothd.org.
20160606 09:52:16< gfgtdf> shadowm: i meant wesnoth.org
20160606 09:52:29< shadowm> Rhonda: I can't connect to wesnoth.org. It appears the certificate expired 50 minutes ago approx.
20160606 09:53:04< shadowm> And of course HSTS is helpfully preventing Firefox from using unencrypted http.
20160606 09:55:12< shadowm> Rhonda: Can't connect via https/http, that is. Forgot to clarify that.
20160606 09:55:14< Rhonda> whut
20160606 09:55:25< Rhonda> someone b0rked the wiki challenge somehow …
20160606 09:55:33< Elvish_Hunter> "wesnoth.org uses an invalid security certificate. The certificate expired on 06/06/2016 11:01. The current time is 06/06/2016 11:52."
20160606 09:55:46< Elvish_Hunter> This is what Firefox 46 says.
20160606 09:56:25< shadowm> Rhonda: Uh. Yeah, that was probably me when I did the last MediaWiki upgade.
20160606 09:56:57< shadowm> Rhonda: I was forced to move the previous install away because of an unreasonable upstream. Let me see if I can find the missing files...
20160606 09:57:57< Rhonda> fixed (me thinks)
20160606 09:58:18< Rhonda> wiki.wesnoth.org verified!
20160606 09:59:06< shadowm> Rhonda: Okay, so for the future it's mw/.well-known (a symlink to /srv/www/html/.well-known) that needs to be present, right?
20160606 09:59:23< Rhonda> Yes
20160606 09:59:31< Rhonda> apache restarted
20160606 09:59:46< shadowm> Okay, got it. Thanks for the help.
20160606 09:59:58< Rhonda> No worries. :)
20160606 10:00:05< Rhonda> (maybe I should check that log more regularly)
20160606 10:03:27< irker253> wesnoth: loonycyborg wesnoth:master 1bc9b423ba0b / src/server/server.cpp: Restore accidentally omitted compatibility code https://github.com/wesnoth/wesnoth/commit/1bc9b423ba0b83ea0303be3eec6bff24b5003a35
20160606 10:09:37-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has joined #wesnoth-dev
20160606 10:12:51-!- mjs-de [~mjs-de@x4e318622.dyn.telefonica.de] has joined #wesnoth-dev
20160606 10:16:51< gfgtdf> Elvish_Hunter: there are multipl isues noted in the discussion or your pr that you didnt repsond to yet, 1) my note about "i think a better way in this code implement this woudl be a clear defeintion which combinations are allowed. like in " 2) celims not about "move this code to helper.rand and call it from [set_variable]."
20160606 10:26:38< loonycyborg> gfgtdf: oh there's another reason I'm not reusing in wesnothd network abstraction from client
20160606 10:26:44< loonycyborg> namely simple_wml
20160606 10:27:27< loonycyborg> client abstraction is based on plain wml
20160606 10:27:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160606 10:27:39< loonycyborg> while server abstraction on simple_wml
20160606 10:28:03< loonycyborg> But old server still was using client wml in some places
20160606 10:28:32< loonycyborg> it seems it's causing issues
20160606 10:28:52< gfgtdf> loonycyborg: you know why here: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/network_transmission.cpp#L37 poll() is called even when the dialog is not showing() ?
20160606 10:28:53< loonycyborg> I wonder if I'll have to extend server to handle client wml too..
20160606 10:29:14< gfgtdf> loonycyborg: hmm why shoudl you
20160606 10:29:29< Soliton> the server should just use standard wml with its config file.
20160606 10:30:50< loonycyborg> yeah, and old server was using client wml to send some responses
20160606 10:30:54< gfgtdf> loonycyborg: i wonder whether we shoud, instead of reading tino simpl_wml, read the incomoing packets directly into c++ objects, so that we have one class/struct for each packet type.
20160606 10:31:01< loonycyborg> and I converted it to simple_wml
20160606 10:31:15< Soliton> which responses?
20160606 10:31:48< Soliton> sending simple_wml instead should not be an issue for the client though.
20160606 10:31:51< loonycyborg> Soliton: https://github.com/wesnoth/wesnoth/blob/1.12/src/server/server.cpp#L1017
20160606 10:32:30< Soliton> afaik simple_wml is just stricter so should be completely compatible in that direction.
20160606 10:33:13< Soliton> loonycyborg: looks like just an oversight.
20160606 10:33:20-!- gfgtdf [~chatzilla@x4e36a620.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160606 10:34:07< loonycyborg> yeah,  and I would be forced to correct all such oversights since my asio helpers don't support client wml
20160606 10:34:34< loonycyborg> I just hope clientside didn't rely on such an oversight
20160606 10:35:08< Soliton> i can't see how.
20160606 10:35:40< irker253> wesnoth: gfgtdf wesnoth:master 246f7f2995a7 / src/gui/dialogs/network_transmission.cpp: fix crash in addon network wait dialog https://github.com/wesnoth/wesnoth/commit/246f7f2995a7146733e59d76b3426252b4823bd6
20160606 10:35:52-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160606 10:37:01< loonycyborg> gfgtdf: what's wrong with calling poll without dialog shown?
20160606 10:39:49-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160606 10:42:30< vultraz> gfgtdf: confirmed crash when connecting to the addons server is fixed
20160606 10:48:45< vultraz> gfgtdf, loonycyborg: could "Connecting to server" be made a loadingscreen stage? Just curious
20160606 10:49:54< loonycyborg> hmm technically I don't see why not
20160606 10:50:16-!- gfgtdf [~chatzilla@x4e36a620.dyn.telefonica.de] has joined #wesnoth-dev
20160606 10:50:36< vultraz> I think it might look nicer than 3 or 4 'waiting' dialogs popping up 
20160606 10:51:14< vultraz> s/might/would
20160606 10:51:18< gfgtdf> loonycyborg: since my changes to that dialog to make it compatible with twesnothd_connection it doesnt takea  direct connection object anymore but a warapper and the warpper is deleted after the dialog was how so it caused a segfault.
20160606 10:52:06< gfgtdf> vultraz: well there is afaik no loadingscreen at that point, so we'd have to add one
20160606 10:53:35< gfgtdf> vultraz:  from what i saw in te code it seems liek previousl there there were no such dialogs, it just aborted when it didnt connect within 3 seconds and just did a while(true) {poll()} for waiting, do without ui involved
20160606 10:53:56< gfgtdf> vultraz: not sure if that's better
20160606 10:54:29< gfgtdf> vultraz: but iguess it coudl be, specially if we find out that builing that gui2 witing dialogs takes actually more time that the actual waiting-
20160606 10:55:01< vultraz> I don't think they take more time, it's just that I had intended to remove those waiting dialogs 
20160606 10:55:13< vultraz> when connecting to the server
20160606 10:55:39< loonycyborg> what asio's poll() does is run all pending handlers, it doesn't matter when exactly you run or don't run it as long as it's before you check results of those handlers
20160606 10:57:35< gfgtdf> loonycyborg: yes oibviosuly i meant while(!conn.receive_data(res)) {} asuming that recevei_Data calls poll intermally.
20160606 10:59:04< gfgtdf> or rather while(!(conn.receive_data(res) || end_time < get_current_time())) { /*sleep*/ } for that waiting code
20160606 11:00:24< loonycyborg> actually I'm pretty sure you're not supposed to ever sleep in gui
20160606 11:00:51< loonycyborg> it runs at particular fps and you check for events at each frame
20160606 11:01:22< loonycyborg> at least it was so when I worked on network transmission dialog
20160606 11:01:36< loonycyborg> the thread thing might have changed things
20160606 11:01:47< gfgtdf> loonycyborg: wellt he pint is that the network code previous didnt interact with the gui
20160606 11:02:12< gfgtdf> loonycyborg: so that it did freeze whiel waiting for the receveid packet
20160606 11:02:20< loonycyborg> the interaction was that gui was calling poll() at each frame
20160606 11:02:31< loonycyborg> and was reading data read etc from connection object
20160606 11:02:31-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160606 11:02:35< gfgtdf> loonycyborg: no poll() is interfacting with the connection
20160606 11:03:20< gfgtdf> loonycyborg: by poll i meant netowrk_connection->poll(), not events::pump or similar
20160606 11:04:48< gfgtdf> loonycyborg: just to be use, im talikng about this line: https://github.com/wesnoth/wesnoth/blob/ca382018b7a9b5b744f0669bf1442a30ead63c15/src/game_initialization/multiplayer.cpp#L338
20160606 11:05:39< gfgtdf> loonycyborg: which was replaced with a dalog: https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/multiplayer.cpp#L302
20160606 11:05:58< gfgtdf> s/use/sure
20160606 11:07:26< gfgtdf> with the new code, a non-dialog implementation would be implemented as "while(!(conn.receive_data(res) || end_time < get_current_time())) { /*sleep*/ }"
20160606 11:17:41-!- travis-ci [~travis-ci@ec2-54-205-226-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20160606 11:17:42< travis-ci> wesnoth/wesnoth#9575 (master - 246f7f2 : gfgtdf): The build has errored.
20160606 11:17:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/135557018
20160606 11:17:42-!- travis-ci [~travis-ci@ec2-54-205-226-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20160606 11:47:42-!- grzywacz [~karol@ip-94.124.0.122.s.net.pl] has quit [Ping timeout: 260 seconds]
20160606 11:52:00-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has joined #wesnoth-dev
20160606 11:56:24-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 276 seconds]
20160606 11:57:35-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160606 12:08:53-!- RatArmy [~RatArmy@om126229092144.12.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160606 12:20:51-!- grzywacz [~karol@89-70-181-125.dynamic.chello.pl] has joined #wesnoth-dev
20160606 12:21:06-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160606 12:21:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20160606 12:35:32-!- Nobun [~nobun@5.170.109.57] has joined #wesnoth-dev
20160606 12:39:33-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20160606 12:39:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160606 12:57:57-!- stikonas_ is now known as stikonas
20160606 13:01:54-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Ping timeout: 246 seconds]
20160606 13:15:07< irker253> wesnoth: loonycyborg wesnoth:master d3ed75d58a4b / src/server/server.cpp: Fixed simple_wml misuse leading to server trying to send invalid wml https://github.com/wesnoth/wesnoth/commit/d3ed75d58a4bdea747041a32223e4d8f91c95e6e
20160606 13:34:40-!- Nobun [~nobun@5.170.109.57] has quit [Ping timeout: 252 seconds]
20160606 13:40:30-!- grzywacz [~karol@89-70-181-125.dynamic.chello.pl] has quit [Ping timeout: 250 seconds]
20160606 13:48:38-!- travis-ci [~travis-ci@ec2-54-205-226-52.compute-1.amazonaws.com] has joined #wesnoth-dev
20160606 13:48:39< travis-ci> wesnoth/wesnoth#9576 (master - d3ed75d : loonycyborg): The build passed.
20160606 13:48:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/135588140
20160606 13:48:39-!- travis-ci [~travis-ci@ec2-54-205-226-52.compute-1.amazonaws.com] has left #wesnoth-dev []
20160606 13:48:58-!- edgrey [~edgrey@178.204.169.141] has quit [Quit: Konversation terminated!]
20160606 13:51:47-!- edgrey [~edgrey@178.204.169.141] has joined #wesnoth-dev
20160606 14:10:01-!- Bonobo [~Bonobo@2001:44b8:254:3200:dd9d:2c75:3e31:3e63] has quit [Quit: Leaving]
20160606 14:11:14-!- gfgtdf [~chatzilla@x4e36a620.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]]
20160606 14:14:47-!- oldlaptop [~quassel@192.183.52.168] has quit [Ping timeout: 244 seconds]
20160606 14:18:25-!- ugudu [708650ef@gateway/web/freenode/ip.112.134.80.239] has joined #wesnoth-dev
20160606 14:26:41-!- oldlaptop [~quassel@192.183.52.168] has joined #wesnoth-dev
20160606 14:29:16-!- ugudu [708650ef@gateway/web/freenode/ip.112.134.80.239] has quit [Ping timeout: 250 seconds]
20160606 14:30:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160606 14:37:17-!- grzywacz [~karol@89-70-181-125.dynamic.chello.pl] has joined #wesnoth-dev
20160606 14:40:24-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160606 14:51:05-!- mjs-de [~mjs-de@x4e318622.dyn.telefonica.de] has quit [Remote host closed the connection]
20160606 14:54:09< irker253> wesnoth: Charles Dang wesnoth:master 1d0e4fff417f / src/ (14 files in 10 dirs): Convert most usecases of atoi to std::stoi https://github.com/wesnoth/wesnoth/commit/1d0e4fff417fb5ddd8ceecf0948a9fcc6e65721a
20160606 14:54:54< vultraz> loonycyborg: ^ there are a few in server.cpp and campaign_server.cpp but I'll leave those for you to look at (and since you're working on the code in the former)
20160606 15:12:11-!- grzywacz [~karol@89-70-181-125.dynamic.chello.pl] has quit [Changing host]
20160606 15:12:11-!- grzywacz [~karol@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20160606 15:36:22-!- Duthlet [~Duthlet@p5485FEDF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160606 15:41:37< loonycyborg> vultraz: hmm and what's the exact rationale for the switch?
20160606 15:43:43-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160606 15:44:25< vultraz> Nothing, just small code cleanup
20160606 15:45:07< vultraz> Plus atoi has 0-on-fail behavior, which isn't really great to rely on
20160606 15:45:31< loonycyborg> and stoi throws?
20160606 15:45:43< vultraz> yes
20160606 15:53:34-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 16:00:57-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160606 16:10:10-!- esr [~esr@wesnoth/developer/esr] has quit [Read error: Connection reset by peer]
20160606 16:12:22< irker253> wesnoth: Charles Dang wesnoth:master 7b21849487fb / src/ (12 files in 6 dirs): Cleaned up cstdlib includes https://github.com/wesnoth/wesnoth/commit/7b21849487fb9ff1607a8ab6aca813bf1df05171
20160606 16:12:44< vultraz> Now let's see what travis says about that
20160606 16:13:25< vultraz> Not exactly sure why one or two files now build without that include, so I'm hoping it's not some fluke of my setup.
20160606 16:20:01< Soliton> if you're removing includes by trial-and-error that is not a good idea and a successful travis build is not much confirmation either.
20160606 16:27:33-!- atarocch [~atarocch@62.119.166.1] has joined #wesnoth-dev
20160606 16:30:46< loonycyborg> yup, sometimes there are include dependencies that are specific to particular compiler
20160606 16:34:23< Soliton> vultraz: i suggest to revert at least those includes that explicitely stated for which functions they're there (and those functions are indeed still used).
20160606 16:35:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160606 16:39:25-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160606 16:47:18< irker253> wesnoth: Elvish_Hunter wesnoth:master d6747f50986f / data/lua/wml-tags.lua src/game_events/action_wml.cpp: Ported [set_variable] to Lua https://github.com/wesnoth/wesnoth/commit/d6747f50986faa34d5f61455eaa57b0ee86301f2
20160606 16:47:20< irker253> wesnoth: Elvish_Hunter wesnoth:master d6308cc6f783 / data/lua/wml-tags.lua: Used helper.shallow_literal instead of cfg.__shallow_literal https://github.com/wesnoth/wesnoth/commit/d6308cc6f7832aaa8d1671dd073590d93087a235
20160606 16:47:22< irker253> wesnoth: Elvish_Hunter wesnoth:master 66ee2145446c / data/lua/wml-tags.lua: Allow executing multiple operations in the same [set_variable] tag https://github.com/wesnoth/wesnoth/commit/66ee2145446cd7bbb448397124bf5a330e3ca274
20160606 16:47:24< irker253> wesnoth: Elvish_Hunter wesnoth:master 3c6d3e93d771 / / (194 files in 47 dirs): Merged upstream/master https://github.com/wesnoth/wesnoth/commit/3c6d3e93d771f74d9189c3351f92c8890e64c9fc
20160606 16:47:26< irker253> wesnoth: Elvish_Hunter wesnoth:master a61d3704e9cb / data/lua/wml-tags.lua: Fixed a misplaced end https://github.com/wesnoth/wesnoth/commit/a61d3704e9cb1fa5d834391addf12048173ee274
20160606 16:47:28< irker253> wesnoth: Elvish_Hunter wesnoth:master 5eb17841955a / data/lua/wml-tags.lua: Re-evalutate the content of the variable in each operation https://github.com/wesnoth/wesnoth/commit/5eb17841955a178c19b7690cff40f3ee298618a2
20160606 16:47:30< irker253> wesnoth: Elvish_Hunter wesnoth:master 00525c340b67 / data/lua/wml-tags.lua: Implemented random ranges by using tables https://github.com/wesnoth/wesnoth/commit/00525c340b67eab66288ffb3f9298b91ad672b62
20160606 16:47:32< irker253> wesnoth: Elvish_Hunter wesnoth:master 8b82fb32481d / data/lua/wml-tags.lua: [set_variable]: do not iterate through all the elements of a random range https://github.com/wesnoth/wesnoth/commit/8b82fb32481d1b02424d5d3e85561e7fa9963b74
20160606 16:47:34< irker253> wesnoth: Celtic Minstrel wesnoth:master 3715c194c2e1 / data/lua/wml-tags.lua src/game_events/action_wml.cpp: Merge pull request #642 from Elvish-Hunter/set_variable_lua https://github.com/wesnoth/wesnoth/commit/3715c194c2e1bbe2174b82467880625a00bfd7a2
20160606 16:48:47< irker253> wesnoth: Jonathan Combs wesnoth:master 7d8a032589e6 / / (12 files in 7 dirs): gui2: new logging dialog https://github.com/wesnoth/wesnoth/commit/7d8a032589e67e22bfa16637bac98608124c2d89
20160606 16:48:49< irker253> wesnoth: Celtic Minstrel wesnoth:master 893607e077e7 / / (12 files in 7 dirs): Merge pull request #650 from ScegfOd/master https://github.com/wesnoth/wesnoth/commit/893607e077e7b34d9a81a2aff7ce763f367e4ef9
20160606 16:50:51< irker253> wesnoth: Pentarctagon wesnoth:master d22b15b19b2e / changelog data/core/about.cfg data/lua/wml/message.lua: Add color=value to [message] (#651) https://github.com/wesnoth/wesnoth/commit/d22b15b19b2e564526e138c250c725013236ccf8
20160606 16:51:41< celticminstrel> Could someone please comment on PR660...
20160606 16:52:03-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160606 16:54:47-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160606 16:57:28< celticminstrel> Do loonycyborg or gfgtdf have anything to say on PR666?
20160606 16:59:58< irker253> wesnoth: tranceitionalMynd wesnoth:1.12 d6a851debf7f / data/campaigns/Legend_of_Wesmere/scenarios/chapter4/14_Human_Alliance.cfg: Added death of Galtrid to defeat conditions for Human Alliance. (#527) https://github.com/wesnoth/wesnoth/commit/d6a851debf7fbc8dd40a5ad95f3d402f6de36b69
20160606 17:00:29< celticminstrel> ^ Some other commits were made to 1.12, so I thought I'd merge now that just in case a 1.12.7 happens.
20160606 17:01:51-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.3]
20160606 17:02:24< Soliton> PR666 looks good indeed. if it works properly that would be good to merge.
20160606 17:03:41< Soliton> PR660 seems fine if we're going to keep wfl.
20160606 17:09:24< vultraz> Aren't we?
20160606 17:11:25-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160606 17:12:16-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 17:13:39-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160606 17:22:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 17:34:33-!- oldlaptop [~quassel@192.183.52.168] has quit [Ping timeout: 246 seconds]
20160606 17:40:58< celticminstrel> We're keeping WFL.
20160606 17:41:07< celticminstrel> We may not be keeping FormulaAI.
20160606 17:42:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 17:43:48< celticminstrel> For PR660 I personally would prefer trunc() rather than int(), as int() may give the impression that it casts anything to integer.
20160606 17:47:25< Soliton> hmm yeah, that does seems to be a more common term for that function.
20160606 17:47:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 17:55:01-!- atarocch [~atarocch@62.119.166.1] has quit [Ping timeout: 240 seconds]
20160606 17:58:05-!- edgrey [~edgrey@178.204.169.141] has quit [Quit: Konversation terminated!]
20160606 17:59:55< Soliton> vultraz: you're really not going to revert your include "clean up"?
20160606 18:00:33< vultraz> waiting to see what travis says before I do anything. Dunno where it is.
20160606 18:00:49< Soliton> wow.
20160606 18:01:33-!- edgrey [~edgrey@178.204.169.141] has joined #wesnoth-dev
20160606 18:01:56< vultraz> "wow"?
20160606 18:03:22< Soliton> it is sometimes difficult to believe you want to improve the code you're working on.
20160606 18:03:34< vultraz> Why are you always so condescending.
20160606 18:05:23< Soliton> it's fairly frustrating to point out an obvious mistake, explain it and get ignored.
20160606 18:05:50< Soliton> not even a question in case something was not clear.
20160606 18:06:59< vultraz> I didn't say I wouldn't revert it.
20160606 18:07:09< vultraz> Or parts of it
20160606 18:07:18< vultraz> I just said I was waiting for the travis report
20160606 18:07:37< Soliton> and i said it is irrelevant.
20160606 18:07:50< Soliton> it might even compile fine.
20160606 18:07:52-!- oldlaptop [~quassel@50-107-119-188.adr02.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20160606 18:07:56< loonycyborg> but I wonder why did you decide to single out cstdlib?
20160606 18:08:01-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20160606 18:08:18< Soliton> just look at the very first chunk of the diff and explain why you removed that include?
20160606 18:08:53< Soliton> someone took the time and had even added a nice comment on why it was there.
20160606 18:08:57< loonycyborg> Like it says "abs" in comment
20160606 18:09:08< loonycyborg> and abs is used right in that source
20160606 18:09:37-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160606 18:09:47< loonycyborg> it costs us nothing to have #includes for symbols we're actually using
20160606 18:09:56< loonycyborg> even if they happen to be redundant
20160606 18:10:02< loonycyborg> because of include guards
20160606 18:10:36< loonycyborg> on the other hand
20160606 18:10:53< loonycyborg> different compilers may have different header interdependencies
20160606 18:11:48-!- gfgtdf [~chatzilla@x4e36a620.dyn.telefonica.de] has joined #wesnoth-dev
20160606 18:11:50-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160606 18:12:02< gfgtdf> 20160606 16:57:28< celticminstrel> Do loonycyborg or gfgtdf have anything to say on PR666?
20160606 18:12:10< vultraz> It's relevant to me because I'm curious 
20160606 18:12:24< gfgtdf> celticminstrel: i wonder whether we shoudl allow only resitered user as player or also as aobservers
20160606 18:13:42< gfgtdf> vultraz: even it travis pases it might also be needed for other build systems that tavis doesnt check.
20160606 18:13:50< Soliton> vultraz: then read up on the subject or even just ask here. using wesnoth as test object to see which packager can not build wesnoth anymore after the latest header clean up is not nice.
20160606 18:13:57< loonycyborg> like see cc8fcf81181b1d91c14d529465173468965a66a8
20160606 18:14:41< loonycyborg> people often need to add headers that aren't indirectly included on their compilers
20160606 18:15:08< zookeeper> WRT #666, i guess one might legitimately want it to affect observers as well... or not affect. hard to say which one would be more common.
20160606 18:15:19< gfgtdf> zookeeper: when commiting those fixed, it'd be nice you you wrote what exactly failed before so that we know when its save to remove that include
20160606 18:15:38< gfgtdf> loonycyborg: as in loonycyborgs link i meant
20160606 18:15:47< celticminstrel> Actually, I was half-planning to revert the cstdlib commit myself.
20160606 18:15:50< Soliton> if you're curious what particular includes your compiler does not need... i think esr wrote a tool that automates that.
20160606 18:16:07-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160606 18:16:14< vultraz> oh, I'm sure he did
20160606 18:17:12-!- Kwandulin [~Miranda@p200300760F3B060320A1D912E0152584.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160606 18:17:23< esr> It's called "deheader" and I wrote it for Wesnoth originally.
20160606 18:18:08< zookeeper> it lives
20160606 18:18:13< celticminstrel> ?
20160606 18:18:33< vultraz> he has been summoned
20160606 18:18:34< Soliton> it is just a starting point though. a human needs to go over the includes it wants to remove and verify that they're really not needed.
20160606 18:19:46< zookeeper> grzywacz, so do you recall the thinking or main usecase behind https://gna.org/bugs/?14138 and thus whether it should affect observers as well?
20160606 18:21:06< Ravana_> I assume it was to reduce chance of meeting with leaver
20160606 18:21:42< loonycyborg> celticminstrel: is pr666 is looking fine to me
20160606 18:21:54< celticminstrel> gfgtdf: Are network.?pp and network_worker.?pp still used somewhere? For example, maybe in the addons server?
20160606 18:22:08< gfgtdf> celticminstrel: afaik they are still se din the addon server
20160606 18:22:11< loonycyborg> whoops
20160606 18:22:13< Soliton> yeah, i would guess it should not affect observers.
20160606 18:22:16< gfgtdf> celticminstrel: unless loonycyborg handles this already that is
20160606 18:22:39< loonycyborg> I mean pr666 is looking fine to me
20160606 18:23:43-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160606 18:24:05< celticminstrel> Also gfgtdf: Can you please explain the logic behind the name "configr_of"?
20160606 18:24:30< zookeeper> Ravana_, Soliton, unless one wants to use it as a more general guard against trolls and other troublemakers.
20160606 18:25:08< Ravana_> mute all works for that though
20160606 18:25:43< Soliton> if the trouble maker is evading ignores and too lazy to register accounts that might work.
20160606 18:25:44< Ravana_> though not ideal, I think that way would be more useful
20160606 18:27:16< gfgtdf> celticminstrel: hmm irc ia answered you that in te pr
20160606 18:27:19< loonycyborg> There's already an option to disallow observers
20160606 18:27:38< celticminstrel> gfgtdf: I don't remember seeing that...
20160606 18:27:41< Ravana_> also, regardless of this question, is there GUI icon to show this setting?
20160606 18:27:48< gfgtdf> celticminstrel: i'm quire sure i did
20160606 18:28:13< gfgtdf> celticminstrel: nore that github doesnt showcomments abotu outdated code unless you manually unfold them
20160606 18:28:23< celticminstrel> Is it too complicated to repeat here?
20160606 18:29:26< gfgtdf> celticminstrel: well if i had to, i'd just open the page, and copypasete it here, so i'd think you could just open it aswell.
20160606 18:29:49-!- atarocch [~atarocch@88.131.217.34] has joined #wesnoth-dev
20160606 18:31:42< vultraz> going to grab some sleep. I'll revert some of those cstdlibs tomorrow.
20160606 18:31:57< Soliton> Ravana_: in the games' list you mean?
20160606 18:32:05< Ravana_> yes
20160606 18:32:07< celticminstrel> Only some?
20160606 18:32:22< vultraz> celticminstrel: I assume they're not ALL necessary
20160606 18:32:23< Soliton> i think that was not part of the PR.
20160606 18:32:36< celticminstrel> But how do you know which ones are and which ones are not?
20160606 18:33:08< gfgtdf> hmm at lest for those who haev explcitly stated why there are needed you can just remove them i the referenced usecases arent there namymore
20160606 18:33:15< vultraz> [03:34:20]	Soliton	vultraz: i suggest to revert at least those includes that explicitely stated for which functions they're there (and those functions are indeed still used).
20160606 18:33:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 18:33:32< celticminstrel> But how do you know the ones not stating that are not needed?
20160606 18:33:50< celticminstrel> In fact, the ones that do state the reason may also be needed for something else on some platforms.
20160606 18:34:19< vultraz> I'm still unsure about the one in random_new.hpp
20160606 18:34:22< gfgtdf> celticminstrel: hmm not sure, you coudl lookuo the content of cstdlib in http://www.cplusplus.com/reference/cstdlib/ and see if any of those function are ued in that file
20160606 18:34:51< vultraz> since RAND_MAX is used somewhere completely different
20160606 18:35:01< loonycyborg> celticminstrel: actually I'm not sure what should be behavior about unregistered observers with that option
20160606 18:35:05< Soliton> (what gfgtdf said is the only correct way.)
20160606 18:35:14< celticminstrel> I'm just saying it's easier to simply revert the whole commit, since I don't think it hurts to have extraneous <cxxx> includes.
20160606 18:35:18< gfgtdf> vultraz:  mostlikeley it aw used there bfore the rnadom code used boost::random i think you can remvoe it
20160606 18:35:37< celticminstrel> loonycyborg: Am I the person you meant to address there?
20160606 18:35:37< gfgtdf> was*
20160606 18:36:03< celticminstrel> Yeah, the ones used for rand and RAND_MAX are likely not needed anymore.
20160606 18:36:04< vultraz> gfgtdf: RAND_MAX?
20160606 18:36:10< loonycyborg> yes about pr666
20160606 18:36:18< gfgtdf> vultraz: yes
20160606 18:36:27< vultraz> that is, are you saying remove RAND_MAX or remove the cstdlib include related to it
20160606 18:36:32< Soliton> loonycyborg: let's see what grzywacz says. either way the PR is fine as is IMO.
20160606 18:36:39< celticminstrel> loonycyborg: Oh, right.
20160606 18:36:44< vultraz> (it's used in recruitment::do_randomness)
20160606 18:36:57< celticminstrel> vultraz: Filename please?
20160606 18:37:14< vultraz> celticminstrel: ai/default/recruitment.cpp
20160606 18:37:24< gfgtdf> rand() is still used in some places, in ai or animation code i think
20160606 18:37:31< celticminstrel> Hmm.
20160606 18:37:38< vultraz> should that be changed?
20160606 18:37:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 18:38:45< gfgtdf> vultraz: hmm well its not bad i'd say
20160606 18:39:00< gfgtdf> vultraz: its not liek there are for securitly or similar
20160606 18:39:05< gfgtdf> vultraz: what shodul be done
20160606 18:39:25< gfgtdf> vultraz: is not using rand() in addon/client.cpp for password generation
20160606 18:39:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160606 18:39:32< celticminstrel> It calls (static_cast<double>(rand()) / RAND_MAX) * get_recruitment_randomness()
20160606 18:39:49< celticminstrel> Is there any reason not to change it to rand() % get_recruitment_randomness()?
20160606 18:40:04< celticminstrel> Note that get_recruitment_randomness() is an int.
20160606 18:40:12< celticminstrel> (If it were a double, that would be a reason not to change it.)
20160606 18:41:15< gfgtdf> celticminstrel: hmm bt afaik the reuslt value is adouble
20160606 18:41:30< celticminstrel> That doesn't matter.
20160606 18:41:40< gfgtdf> celticminstrel: cahngi it to use % woill for exampel increase the change to have 2 values with the same result
20160606 18:41:52< celticminstrel> Huh?
20160606 18:42:05< gfgtdf> celticminstrel: so it depends on how the result is used later
20160606 18:42:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160606 18:42:46< celticminstrel> score += <that formula>
20160606 18:42:50< celticminstrel> score is a double.
20160606 18:43:58< Soliton> vultraz: btw, the time i spend on wesnoth is fairly limited and unfortunately i think a good use of it is to check your commits when i see them. it's nothing personal, the probability that there is some technical issue is just not that low. :->
20160606 18:44:20< celticminstrel> vultraz: About whether it should be changed, I'd say it doesn't really matter - as far as I know, the main reason for using the new random engine is to keep random results synchronized in MP games, but if I recall correctly, AI code doesn't need to be synchronized since it only runs on one client.
20160606 18:44:48< celticminstrel> Soliton: Thanks for that, then.
20160606 18:45:01< celticminstrel> Okay, XCode builds now.
20160606 18:45:14< vultraz> Soliton: that's great, but I dislike the way you always seem to talk down to me.
20160606 18:45:24< Soliton> vultraz: i'm always happy to explain further if you don't see the issue or i'm being cryptic or whatever.
20160606 18:46:01< vultraz> I always get the impression you're sitting there thinking "oh my god this guy is an idiot".
20160606 18:46:15< celticminstrel> Oh wait, the pull failed, so there's probably another file or two I need to add once it succeeds...
20160606 18:46:39< gfgtdf> celticminstrel: that code in rnadom_new is the fallback generator to be used in case that we are not in a synced context.
20160606 18:47:18< gfgtdf> rnadom_new.cpp that is
20160606 18:48:35< celticminstrel> Whoa! Giant cursors! O_O
20160606 18:48:43< Soliton> vultraz: i see. i'll try to work on my wording. i can assure you that's not even relevant to me. i'm more interested in improving wesnoth and i can appreciate that you're, too.
20160606 18:49:10-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160606 18:49:43< vultraz> Ah. Well, thanks :)
20160606 18:51:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 18:51:31-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160606 18:52:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Disconnected by services]
20160606 18:52:31-!- VultCave is now known as vultraz
20160606 18:52:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160606 18:52:57-!- wedge010 is now known as wedge009
20160606 18:53:10-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160606 18:53:10-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160606 18:53:13< vultraz> celticminstrel: what giant cursors?
20160606 18:53:24< celticminstrel> The new cursors are just huge compared to the old ones.
20160606 18:53:45< vultraz> ...you only just saw the new cursors? o_O
20160606 18:53:56< celticminstrel> I'm not sure.
20160606 18:54:10< vultraz> I committed them over a month ago
20160606 18:54:18< vultraz> (I think)
20160606 18:54:22< vultraz> (maybe longer?)
20160606 18:54:24< celticminstrel> Then it's possible.
20160606 18:54:31< gfgtdf> Soliton: does the master wesnothd server (hosted by wesnoth) already use boost asio ?
20160606 18:54:54< Soliton> loonycyborg: ^
20160606 18:55:30< gfgtdf> Soliton: the code alredy used boot_asio my question was about whether teh offical server is already rebuild to sue teh new coees
20160606 18:55:32< gfgtdf> codes*
20160606 18:55:42< gfgtdf> uses*
20160606 18:56:26< Soliton> i believe loonycyborg has already updated it.
20160606 18:56:45< Soliton> i was not involved in that though.
20160606 18:56:59< celticminstrel> Ugh, how to I unstage a deleted file?
20160606 18:57:16< celticminstrel> ^do
20160606 18:57:34< loonycyborg> gfgtdf: yes wesnoth.org:15000 is the asio one now
20160606 18:57:41< loonycyborg> so you can already do tests there
20160606 18:59:18< gfgtdf> loonycyborg: hmm are you planning to enable fifo for servers on windows too ?'
20160606 18:59:47< loonycyborg> that's impossible because windows has no such type of file
20160606 19:00:34< gfgtdf> loonycyborg: hmm then i's suggest ot remove the 'pragma message ("No FIFODIR set")' inside a #ifdef _MCS_VER. since this macro seens to be obnyl used in linux them
20160606 19:01:27< gfgtdf> loonycyborg: afaik that was also there before your refactor, so i doner whether it did support fifo in windows previousl
20160606 19:02:58< gfgtdf> loonycyborg: also windows also has named pipes afaik, evne though i nrever used them
20160606 19:03:47< loonycyborg> hmm
20160606 19:03:49< loonycyborg> maybe it does
20160606 19:04:52< loonycyborg> #  pragma message ("No FIFODIR set")
20160606 19:04:52< loonycyborg> #  define FIFODIR "d:/"
20160606 19:05:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Ping timeout: 264 seconds]
20160606 19:05:21< loonycyborg> I assumed it was unix only forgetting about this code :P
20160606 19:07:23< gfgtdf> loonycyborg: from readon the docuemntation it seems like 'boost::asio::windows::stream_handle' is the dinwos equivalent for 'boost::asio::posix::stream_descriptor '
20160606 19:08:21< gfgtdf> loonycyborg: or 'boost::asio::windows::pipe ' didnt really read te  codudmetaion yet
20160606 19:08:36-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160606 19:15:22< loonycyborg> gfgtdf: anyway there happen strange oos issues for observers with current version of client/server
20160606 19:15:33< loonycyborg> you could check those out
20160606 19:15:53< gfgtdf> loonycyborg: hmm whqt exqactly happens ?
20160606 19:16:06< loonycyborg> either oos or wml parse error
20160606 19:16:21< loonycyborg> doesn't happen always
20160606 19:16:33< gfgtdf> loonycyborg: you knows how to reproduce ?
20160606 19:16:41< loonycyborg> observing a game
20160606 19:16:56< loonycyborg> maybe it needs non-trivial replay
20160606 19:17:08< loonycyborg> that is some moves made that are replayed to client
20160606 19:17:54< gfgtdf> loonycyborg: ovservinf form tebeginning for kooining later ?
20160606 19:18:42< gfgtdf> observing*
20160606 19:18:55< loonycyborg> I reproduced it by starting 3 clients
20160606 19:19:05< loonycyborg> playing a game with two of them
20160606 19:19:10< loonycyborg> and observing with third
20160606 19:19:26< loonycyborg> it seems a bit non-deterministic
20160606 19:19:45< loonycyborg> doesn't happen always
20160606 19:20:24< loonycyborg> It could be my another messup with simple_wml, or it could be something clientside
20160606 19:21:37< gfgtdf> loonycyborg: the paring erro happen whe paring packes from the server ?
20160606 19:21:51< gfgtdf> loonycyborg: parsing*
20160606 19:22:55< loonycyborg> I think it's clientside wml parse error
20160606 19:23:39< gfgtdf> loonycyborg: yes but does it parse network pacjages or something from disk ?
20160606 19:24:19< loonycyborg> from network I think
20160606 19:31:16< gfgtdf> Aginor: i get 'unknown pramga' warning form text.cpp, this seems to e casued froma  commit you made
20160606 19:31:20< gfgtdf> Aginor: please fix that
20160606 19:33:39< loonycyborg> which pragma?
20160606 19:35:10< Soliton> there just appears to be one pragma in that file. looks like it is for gcc.
20160606 19:35:52< Soliton> can probably ifdef'd out for msvc.
20160606 19:36:11< Soliton> or msvc can be convinced to ignore unknown pragmas.
20160606 19:36:18< loonycyborg> yes
20160606 19:36:28< loonycyborg> it shouldn't emit warnings about gcc's pragmas
20160606 19:36:49-!- Kwandulin [~Miranda@p200300760F3B060320A1D912E0152584.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160606 19:38:03< loonycyborg> gfgtdf: #pragma GCC diagnostic are needed to control warnings for some files
20160606 19:38:32< gfgtdf> loonycyborg: yes, but you can wrap thne ina  #if GCC or similar
20160606 19:42:00< loonycyborg> the question is which define to check for?
20160606 19:42:20< loonycyborg> given that they should be used both for gcc and clang
20160606 19:43:15< loonycyborg> also, aren't pragmas supposed to be ignored if they're unknown?
20160606 19:43:37-!- horrowind [~Icedove@2a02:810a:83c0:1c18:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160606 19:45:18< lipkab> Technically, no. An unknown pragma can have arbitrary effects as per the standard.
20160606 19:45:32< loonycyborg> at least gcc emits no warning for #pragma warn
20160606 19:45:57< gfgtdf> loonycyborg: well its not liek we didnt have those prmgas before, push_check.hpp for exmaepl used a '#if defined(__GNUC__) && !defined(__clang__)'
20160606 19:46:52< gfgtdf> loonycyborg: i actually thought that gcc/clang also emints wanrings for unkown pragmas  because most msvc ignore wanring parmags are also warapped in #ifdefs.
20160606 19:47:16< gfgtdf> emits*
20160606 19:47:38< gfgtdf> so thats thought thats the reason why they were wrapped*
20160606 19:50:08< loonycyborg> seems __GNUC__ is the macro to use
20160606 19:51:03< gfgtdf> loonycyborg: can i also rpduce OOS with just 1 player and 1 observer?
20160606 19:51:28< loonycyborg> not sure, didn't try
20160606 19:54:11< gfgtdf> loonycyborg: you observed OOS on normal mp game withouth custom era/mods ?
20160606 19:54:23< loonycyborg> yup
20160606 19:55:45< gfgtdf> loonycyborg: hmm yes i also just got the parsing erro
20160606 19:55:58< gfgtdf> loonycyborg: unexpected char at line start: '1'
20160606 19:56:11< loonycyborg> I saw you in wesnothd log
20160606 19:56:51< loonycyborg> there was another potentially useful one in server log
20160606 19:56:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160606 19:57:10< loonycyborg> 20160606 19:54:57 warning server: <IP>  Received unknown data from: c (socket:0xd24600) in game: "bs Partie" (1)
20160606 19:57:10< loonycyborg> [refresh_lobby]
20160606 19:57:10< loonycyborg> [/refresh_lobby]
20160606 19:57:12< gfgtdf> loonycyborg: seems like it happens every second time i join a game
20160606 19:57:46< gfgtdf> loonycyborg: joining bs game with c i meant
20160606 19:57:55< gfgtdf> loonycyborg: also when i leave a game i don't see a gamelist
20160606 19:58:10< loonycyborg> yes that's probably due to warningI quoted
20160606 19:58:11< gfgtdf> loonycyborg: so i have to relog to join
20160606 19:58:39< loonycyborg> it seems that it also breaks up communication between client and server
20160606 19:58:50< loonycyborg> so server doesn't know client should be in lobby
20160606 19:59:31-!- ancestral [~ancestral@63.225.154.185] has joined #wesnoth-dev
20160606 19:59:38< gfgtdf> loonycyborg: also this seems to be unrelated to whether i just relog woir whethe ri restart the client application
20160606 20:00:00-!- irker253 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160606 20:00:19< gfgtdf> loonycyborg: also when i join a game it start immidiateley on the joining side, even if the host didnt start the game yet
20160606 20:05:45-!- grzywacz [~karol@wesnoth/developer/grzywacz] has quit [Ping timeout: 246 seconds]
20160606 20:06:00< loonycyborg> this doesn't happen for me
20160606 20:06:58< loonycyborg> in fact not sure how that even could happen..
20160606 20:09:32< gfgtdf> loonycyborg: hmm log netowrk shows that i recevie a [start_game]
20160606 20:24:03< gfgtdf> loonycyborg: hmm this seem to e related to whteher thehost had already opneed a game previously
20160606 20:25:21< gfgtdf> loonycyborg: try this: start 2 clients (a and b), start a game with client a, set player 2 to be a aswell, start game, close game, start a new game, now player b has problems joining
20160606 20:27:06-!- ancestral [~ancestral@63.225.154.185] has quit [Ping timeout: 250 seconds]
20160606 20:28:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 20:31:05-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20160606 20:31:30< gfgtdf> loonycyborg: this seem to be something beeing reall wrong on in server side, maybe it´s some older game not deleted yet messing things up.
20160606 20:32:34-!- Nobun [~nobun@5.170.107.73] has joined #wesnoth-dev
20160606 20:34:10-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160606 20:55:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 20:55:42< loonycyborg> gfgtdf: I'll look into it thoroughly later but could use any input
20160606 20:59:26< shadowm> vultraz: Any comments about the stuff I pointed out earlier?
20160606 21:10:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 21:10:51-!- edgrey [~edgrey@178.204.169.141] has quit [Ping timeout: 246 seconds]
20160606 21:13:39-!- mjs-de [~mjs-de@x4e318622.dyn.telefonica.de] has joined #wesnoth-dev
20160606 21:33:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 21:34:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160606 21:39:51-!- Nobun [~nobun@5.170.107.73] has quit [Quit: Salve a tutti]
20160606 21:43:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160606 21:44:00-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160606 21:59:34-!- gfgtdf [~chatzilla@x4e36a620.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 46.0.1/20160502172042]]
20160606 22:10:17-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160606 22:11:10-!- mjs-de [~mjs-de@x4e318622.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20160606 22:14:00-!- Duthlet [~Duthlet@p5485FEDF.dip0.t-ipconnect.de] has quit [Quit: leaving]
20160606 22:30:01-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160606 22:30:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160606 22:35:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160606 22:36:28-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20160606 22:59:49-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 23:03:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160606 23:28:43-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160606 23:30:51-!- atarocch [~atarocch@88.131.217.34] has quit [Remote host closed the connection]
20160606 23:34:42-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 23:35:15-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 264 seconds]
20160606 23:35:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 23:38:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 23:38:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160606 23:40:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160606 23:45:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
--- Log closed Tue Jun 07 00:00:13 2016