--- Log opened Mon Jul 18 00:00:01 2016
20160718 00:00:40< vultraz> but I guess it works
20160718 00:00:44< celticminstrel> So is that an objection to merging? I was about to start working on that.
20160718 00:00:59< vultraz> I wish we had a cleaner syntax for the whole generator thing
20160718 00:01:05< celticminstrel> What?
20160718 00:01:10< celticminstrel> It seems pretty clean to me.
20160718 00:01:32< vultraz> mountain_anonymous_name_generator= _ << "main=$base{!}ham|$base{!}bury|$base{!}ton|$base{!}mont|$base{!}mont|$base{!}cliff|$base}cliff >>
20160718 00:01:33< vultraz> not really
20160718 00:01:42< celticminstrel> ...wait, what?
20160718 00:02:01< vultraz> it's a change in the PR :|
20160718 00:11:54< bumbadadabum> *:{!}
20160718 00:12:02< celticminstrel> ?
20160718 00:12:11< bumbadadabum> just making a little joke
20160718 00:24:10-!- Appleman1234 [~Appleman1@KD036012050155.au-net.ne.jp] has quit [Ping timeout: 258 seconds]
20160718 00:29:02< gfgtdf> bumbadadabum: there i a bugreport (woith a suggestion on how to fix it) for the loti issue: http://gna.org/bugs/?24719
20160718 00:29:34< gfgtdf> bumbadadabum: well its not exactly about that but but that bug was also  discussed there
20160718 00:30:50< bumbadadabum> ok
20160718 00:31:39< bumbadadabum> gfgtdf: this is a different error message though
20160718 00:32:14< gfgtdf> bumbadadabum: i don't think  i said the exact error mesage there so it cannot be a different error message.
20160718 00:32:41< bumbadadabum> oh ok
20160718 00:32:44< bumbadadabum> mb
20160718 00:33:04< gfgtdf> bumbadadabum: see the latest post by dugi in that thread
20160718 00:33:13< bumbadadabum> none of the three things you posted there are my problem though
20160718 00:33:25-!- prkc [~prkc@catv-80-98-46-199.catv.broadband.hu] has quit [Ping timeout: 244 seconds]
20160718 00:33:37< bumbadadabum> oh I see now
20160718 00:35:00< gfgtdf> bumbadadabum: the only important message by me about your issue on that thread is "I wasn't able to reproduce this bug in 1.13.4+dev becasue the game crashes (somehere in the the name generation code) when starting Loti chapter 2"
20160718 00:35:34< bumbadadabum> ok but dugi's comment does explain things
20160718 00:36:27< bumbadadabum> I was curious why specifically LotI crashed wesnoth
20160718 00:36:32< bumbadadabum> but I'm NOT looking through its code
20160718 00:36:45< bumbadadabum> I doubt I'd understand what's going on
20160718 00:37:12-!- stikonas_ is now known as stikonas
20160718 00:37:57-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20160718 00:38:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160718 00:39:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 00:41:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160718 00:41:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 00:42:07-!- Appleman1234 [~Appleman1@KD036012050155.au-net.ne.jp] has joined #wesnoth-dev
20160718 00:42:28< bumbadadabum> ok it seems like I can't have more than 1 side with the rusher recruit microai
20160718 00:45:02< gfgtdf> bumbadadabum: hmm why that ?
20160718 00:45:39< celticminstrel> I'm pretty sure that should not be the case...
20160718 00:45:48-!- prkc [~prkc@46.166.138.139] has joined #wesnoth-dev
20160718 00:45:58< celticminstrel> Though maybe it was never tested on multiple sides simultaneously? I dunno.
20160718 00:47:04< bumbadadabum> gfgtdf: it gives a lua error
20160718 00:47:07< bumbadadabum> saying the recruit failed
20160718 00:49:15< gfgtdf> bumbadadabum: hmm unfortunateley i don't really know anything about the ai code.
20160718 00:50:36< celticminstrel> Almost done fiddling with spixi's PR, but need to take a break for eating.
20160718 00:50:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160718 00:51:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 00:52:56-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160718 00:53:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 00:56:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160718 00:56:11< Aginor> celticminstrel: did you have a chance to review that PR?
20160718 00:56:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 01:01:22-!- gfgtdf [~chatzilla@x4e3630e0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160718 01:16:52-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160718 01:16:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160718 01:24:42-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160718 01:28:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160718 01:31:43< celticminstrel> Aginor: Which one?
20160718 01:33:14< vultraz> the events one
20160718 01:33:56< celticminstrel> I don't think I've reviewed it in full since the last few commits, though I think I did look at those commits.
20160718 01:34:05< celticminstrel> Was the splice put back, BTW?
20160718 01:34:26< vultraz> don't think so
20160718 01:34:29< vultraz> I think it should
20160718 01:34:36< vultraz> but shrugs
20160718 01:41:36< bumbadadabum> celticminstrel: Is there anything lua-related that can be done for wesnoth
20160718 01:41:44< bumbadadabum> I want to get back to coding lua
20160718 01:41:49< bumbadadabum> forgot how fun this language is
20160718 01:44:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160718 01:45:09< bumbadadabum> oh mattsc I narrowed down the problem with the 3004 error on the mai I had earlier
20160718 01:45:21< bumbadadabum> and apparently it messes up when you have multiple sides using the rushers ai
20160718 01:45:25< mattsc> bumbadadabum: using the rusher recruiting MAI on both sides of the recruiting test scenario works just fine, I just tried that
20160718 01:45:32< bumbadadabum> oh
20160718 01:45:34< bumbadadabum> that's odd
20160718 01:45:35< vultraz> bumbadadabum: you can move more tags to lua
20160718 01:45:55< mattsc> so it’s not that simple, there must be some other condition happening that I have not encountered before
20160718 01:46:11< bumbadadabum> I can probably send you the [side] tags I use later
20160718 01:46:47< mattsc> I won’t have time to do anything about it before Wed anyway.  At the earliest.
20160718 01:47:13< mattsc> I just thought I run the test quickly.  Also made sure the sides have different recruit lists, just in case.
20160718 01:47:32< bumbadadabum> vultraz: give me some examples
20160718 01:47:47< bumbadadabum> I was actually trying to move some macros to lua before my break from wesnoth
20160718 01:47:53< bumbadadabum> I think I did put_to_recall_list
20160718 01:47:57< vultraz> bumbadadabum: just look at what tags are implemented in c++ and move those
20160718 01:49:01-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160718 01:49:18< vultraz> bumbadadabum: so, one of the things I think should be done is not just move the c++ implementation to the lua layer, give it a function called wesnoth.foo and then call that from Lua.
20160718 01:49:38< vultraz> bumbadadabum: but instead, expose certain internal logic things to lua to allow the actual implementations to be in Lua
20160718 01:50:44< mattsc> bumbadadabum: I’m off again.  I’ll check the logs, just make sure that you use my nick.  I often don’t have time to read everything.
20160718 01:52:08-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160718 02:02:51-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit []
20160718 02:03:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160718 02:05:05< celticminstrel> vultraz: Please don't suggest that people do pointless things like porting tags to Lua solely for the sake of porting them to Lua.
20160718 02:05:28< celticminstrel> Isn't there already a tag to put to recall list?
20160718 02:05:28< vultraz> its not pointless
20160718 02:05:49< celticminstrel> It is pointless, because it potentially introduces bugs and gives no benefit.
20160718 02:06:54< vultraz> The long term benefit is it moved the implementation of tags out of C++ and into a more easily tweakable medium.
20160718 02:07:13< celticminstrel> Mind you, if it's a tag that you think could be logically broken down into more than one API call, then porting it would not be pointless, because it would create new API calls. (But that requires knowledge of C++.)
20160718 02:10:47< vultraz> It also reduces this disparity we have between tags implemented in lua and those in c++
20160718 02:11:04< vultraz> Tell me you think it's great that half our stuff is over here and half is over there
20160718 02:11:14< celticminstrel> I don't think it matters that much?
20160718 02:11:29< celticminstrel> It's true it's a little easier to mod tags if they're all in WML, though.
20160718 02:11:53< celticminstrel> I actually think on_undo and on_redo possibly shouldn't be ported.
20160718 02:12:43< celticminstrel> I don't mind people porting them if they want to go to the effort, but I don't think it's something that should be prioritized.
20160718 02:13:19< vultraz> Well, what else can he work on related to lua?
20160718 02:13:38< celticminstrel> I'm sure there are plenty of things.
20160718 02:13:56< celticminstrel> Though off the top of my head, I can't think of anything.
20160718 02:16:16< celticminstrel> I forget, did Elvish_Hunter ever move the implementation of [set_variable]random over to helper.random?
20160718 02:17:19< celticminstrel> Hmm, all the Lua ideas in my list involve C++ work.
20160718 02:17:39< vultraz> not that I can see
20160718 02:21:53< vultraz> random thing I think would be useful: give each scenario a metadata table 
20160718 02:22:04< celticminstrel> What do you mean?
20160718 02:25:42< vultraz> well, each level would have a config with its map data, id, etc. maybe some other stuff too, like units on board. and then if you wanted to replace the map, you could just access the table and replace the map_data value.
20160718 02:25:51< vultraz> obv such a thing would be accessible from Lua
20160718 02:26:22< celticminstrel> I don't think I like the example.
20160718 02:26:36< vultraz> why not?
20160718 02:26:57< celticminstrel> I don't think a simple way of accessing the map as a string is useful. (We already have a way to replace it from a file, right?)
20160718 02:27:07< celticminstrel> A way of accessing it as a 2D array could be useful.
20160718 02:27:16< vultraz> I was thinking that
20160718 02:28:10< vultraz> the general idea is having "level data"
20160718 02:28:13< celticminstrel> We already have a way to get all units on board.
20160718 02:28:47< vultraz> yes
20160718 02:28:49< celticminstrel> Though I'm not quite sure if it's maximally efficient (since it involves an empty unit filter?)
20160718 02:29:11< celticminstrel> A way to access the scenario's info, such as ID and such, isn't a bad idea.
20160718 02:29:38< vultraz> basically,you'd enter a scenario, the level data gets updated
20160718 02:30:11< vultraz> and functions that currently fetch data like map size and stuff (wesnoth.get_map_size, for one) would look there
20160718 02:30:36< ancestral> http://www.phoronix.com/scan.php?page=news_item&px=FreeType-2.7-Rendering
20160718 02:32:09< vultraz> might even consider having stuff like the sides table be subtables
20160718 02:32:11< vultraz> so
20160718 02:32:13< vultraz> level.sides
20160718 02:32:14< vultraz> or something
20160718 02:32:52< vultraz> (if you must know, I'm drawing inspiration from the way anura has things)
20160718 02:34:53< celticminstrel> I think moving sides into level isn't worthwhile.
20160718 02:35:38< celticminstrel> The ability to do something like wesnoth.map.width or wesnoth.map.height or wesnoth.map[4][4].terrain would be great, though.
20160718 02:36:20< vultraz> yes, I was thinking of that
20160718 02:37:11< vultraz> a nice thing about this is it would remove certain api calls directly to the engine
20160718 02:37:37< celticminstrel> Of course it would be a proxy table.
20160718 02:37:52< celticminstrel> So anything is looked up only as it's requested.
20160718 02:38:06< vultraz> yes
20160718 02:38:40< vultraz> maybe map_data could be the string data, and map could be the 2d array
20160718 02:38:56< celticminstrel> I suppose if you really wanted you could have tostring(wesnoth.map) return the string form.
20160718 02:39:06< vultraz> that also sounds good
20160718 02:39:18< celticminstrel> It's not unlike how tostring(compiled_formula) currently returns the WFL code.
20160718 02:39:24< bumbadadabum> I was thinking more high-level stuff
20160718 02:39:40< bumbadadabum> Did mostly C and C++ the past year I'm kinda done with that lol
20160718 02:39:42< vultraz> bumbadadabum: see if you can make set_variable use helper.rand
20160718 02:39:47< bumbadadabum> sure
20160718 02:39:54< celticminstrel> bumbadadabum: Most of what we've been discussing would involve C++ work.
20160718 02:39:58< bumbadadabum> yeah
20160718 02:40:09< bumbadadabum> I'll just focus on making some WML macros into lua
20160718 02:40:11< celticminstrel> bumbadadabum: What vultraz describes means moving the logic into set_variable.
20160718 02:40:26< vultraz> wait, what?
20160718 02:40:35< celticminstrel> Currently helper.rand calls set_variable, and set_variable performs the logic of generating a random number.
20160718 02:40:38< bumbadadabum> I feel like that's definitely possible and a lot of WML macros are awful
20160718 02:40:46< vultraz> celticminstrel: shouldn't it be the other way around
20160718 02:40:53< celticminstrel> The idea was to reverse that - move the logic of generating a number into helper.rand, and have set_variable call that.
20160718 02:40:53< bumbadadabum> has anyone ever thought about making a [foreach] tag?
20160718 02:40:57< vultraz> move the logic into helper.rand?
20160718 02:41:04< vultraz> bumbadadabum: celticminstrel did 
20160718 02:41:08< celticminstrel> vultraz: The reason it was that way in the first place is probably because set_variable was implemented in C++.
20160718 02:41:10< bumbadadabum> oh he did?
20160718 02:41:11< bumbadadabum> damn
20160718 02:41:21< celticminstrel> bumbadadabum: Yes, it's in data/lua/wml-flow.lua
20160718 02:41:33< vultraz> celticminstrel: right, but now don't you mean the logic should be moved tohelper.rand not into set_variable
20160718 02:41:33< bumbadadabum> what version was this first in
20160718 02:41:43< bumbadadabum> I'm going to never use {FOREACH} ever again
20160718 02:41:45< celticminstrel> vultraz: Yes, that's what I said, isn't it?
20160718 02:41:45< bumbadadabum> fuck that noise
20160718 02:41:50< celticminstrel> bumbadadabum: I think it's first in 1.13.4.
20160718 02:41:51< vultraz> [13:40:11]	celticminstrel	bumbadadabum: What vultraz describes means moving the logic into set_variable.
20160718 02:42:06< celticminstrel> Though there have been fixes to it since then. It was a little broken at that point, if I recall correctly.
20160718 02:42:10< celticminstrel> vultraz: Oh, whoops, typo.
20160718 02:43:45< vultraz> bumbadadabum: there's also [for]
20160718 02:44:06< celticminstrel> And [repeat]
20160718 02:44:22< vultraz> IIRC I wanted you to drop a [do] subtag from that but you didn't
20160718 02:44:40< celticminstrel> I figured it was good to be consistent across all looping tags.
20160718 02:44:53< celticminstrel> It's required in [while], and cannot be dropped.
20160718 02:51:37-!- irker911 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160718 03:04:01-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:406b:476:2f67:9d44] has joined #wesnoth-dev
20160718 03:05:44-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:406b:476:2f67:9d44] has quit [Remote host closed the connection]
20160718 03:11:21-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160718 03:11:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160718 03:49:24-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:406b:476:2f67:9d44] has joined #wesnoth-dev
20160718 03:57:36< bumbadadabum> celticminstrel, vultraz: what exactly needs to be moved to helper.rand?
20160718 03:58:08< vultraz> bumbadadabum: wml_tags.lua:1140 to 1204
20160718 04:02:30< celticminstrel> The implementation of the random generation.
20160718 04:09:46-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:406b:476:2f67:9d44] has quit [Remote host closed the connection]
20160718 04:17:10-!- edgrey [~edgrey@178.204.86.66] has quit [Ping timeout: 252 seconds]
20160718 04:24:14-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160718 04:27:49-!- JyrkiVesterinen [~jyrki@87-100-194-225.bb.dnainternet.fi] has joined #wesnoth-dev
20160718 04:31:45< bumbadadabum> ahh
20160718 04:31:46< bumbadadabum> ok
20160718 04:31:53< bumbadadabum> yeah I'll try to work on that tomorrow
20160718 04:32:57< bumbadadabum> celticminstrel: so it'd basically be np.random.choice() from python?
20160718 04:43:34-!- Appleman1234 [~Appleman1@KD036012050155.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20160718 04:50:19< celticminstrel> I suppose it would be similar to that?
20160718 04:50:34-!- Appleman1234 [~Appleman1@KD036012043061.au-net.ne.jp] has joined #wesnoth-dev
20160718 04:51:30< celticminstrel> helper.rand should select a random element from the input list (which could be passed either as a comma-separated string or as an array-like table), and also support numeric ranges expanding to multiple options. I think that's all there is to it, but can't quite remember.
20160718 04:51:54< celticminstrel> The implementation is already there in set_variable.
20160718 05:01:01-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160718 05:01:03-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160718 05:07:55< celticminstrel> I just remembered PR 670.
20160718 05:08:49< celticminstrel> We should probably merge that.
20160718 05:11:20-!- irker988 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160718 05:11:20< irker988> wesnoth: Spixi wesnoth:master f96f86245e64 / / (17 files in 9 dirs): Improvements in the map and name generators https://github.com/wesnoth/wesnoth/commit/f96f86245e6448df9314bc0ac9b00d562b79967a
20160718 05:11:22< irker988> wesnoth: Celtic Minstrel wesnoth:master 649b50d93b92 / data/english.cfg src/generators/default_map_generator_job.cpp: Shorten one of the map name generator keys https://github.com/wesnoth/wesnoth/commit/649b50d93b922bb0b4657acd6645d89e470ab55d
20160718 05:11:24< irker988> wesnoth: Celtic Minstrel wesnoth:master 275adafa86d2 / src/ (3 files in 2 dirs): Style https://github.com/wesnoth/wesnoth/commit/275adafa86d2a57cf2405d98724b0836598f5774
20160718 05:11:26< irker988> wesnoth: Celtic Minstrel wesnoth:master 01e9f11cfb48 / src/utils/ (name_generator.hpp name_generator_factory.cpp): Eliminate string_utils include in name_generator.hpp https://github.com/wesnoth/wesnoth/commit/01e9f11cfb489df89548a151a8abee3ec84adca5
20160718 05:11:28< irker988> wesnoth: Celtic Minstrel wesnoth:master ab504f4458d0 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/ab504f4458d01f19c6b7070b7ff4798cbd0b03b7
20160718 05:11:30< irker988> wesnoth: Celtic Minstrel wesnoth:master 7286ea8e0f3c / / (18 files in 10 dirs): Merge pull request #661 from spixi/name_and_map_generator https://github.com/wesnoth/wesnoth/commit/7286ea8e0f3cd9a0e8917337d0abbb4f453225b3
20160718 05:14:08< celticminstrel> bumbadadabum: When you have time, could you try to reproduce that name generator assertion failure? If it's still an issue I can probably fix that next.
20160718 05:15:54< bumbadadabum> apparently it's a thing if you try to generate a name for a unit with a race without a namegen
20160718 05:16:09< bumbadadabum> so only if the unit has no race
20160718 05:16:21< celticminstrel> Eh? It's possible for a unit to not have a race?
20160718 05:16:56< celticminstrel> So, wait, in theory, commenting out the name generators in some preset race would cause it to happen with that race?
20160718 05:18:55< bumbadadabum> idk
20160718 05:19:16< bumbadadabum> gfgtdf linked a bug report
20160718 05:19:25< bumbadadabum> where dugi says something about the cause
20160718 05:19:42-!- edgrey [~edgrey@178.204.166.136] has joined #wesnoth-dev
20160718 05:19:43< bumbadadabum> I skimmed it
20160718 05:19:43< celticminstrel> I saw, but didn't click it until just now.
20160718 05:19:54< bumbadadabum> don't know the EXACT problem
20160718 05:20:29< celticminstrel> Hmm.
20160718 05:20:58< celticminstrel> Might be fixed with that PR, not sure. I'll try some things.
20160718 05:22:11< celticminstrel> Oh, wait, is the null race an actual race instance...
20160718 05:22:41< celticminstrel> The answer is yes.
20160718 05:22:45< bumbadadabum> no matter what you're doing in WML it shouldn't crash wesnoth
20160718 05:22:50< celticminstrel> Agreed.
20160718 05:25:48< celticminstrel> Did you say it happened when starting LotI?
20160718 05:25:59< celticminstrel> I don't really want to download LotI to test something...
20160718 05:26:22< bumbadadabum> it's not THAT big
20160718 05:26:55< Aginor> vultraz: feel free to put that splice back in if you want to
20160718 05:27:16-!- mjs-de [~mjs-de@x4e31a31f.dyn.telefonica.de] has joined #wesnoth-dev
20160718 05:27:51< Aginor> I don't think I'll be doing any wesnoth work today, I've had 7h of meetings and am pretty tired
20160718 05:28:03< celticminstrel> I think this should fix it.
20160718 05:28:17< celticminstrel> Given what dugi said would fix it, this should have the same effect.
20160718 05:29:11< bumbadadabum> celticminstrel: I can give you the [unit_type] of the unit he uses to load events
20160718 05:29:24< celticminstrel> Okay, sure.
20160718 05:29:50< bumbadadabum> http://hastebin.com/izeteheqon.coffee
20160718 05:29:55< bumbadadabum> minus macro to load events
20160718 05:30:03< bumbadadabum> this SEEMS to be the unit causing the problems
20160718 05:32:18< celticminstrel> Now I just have to wait for Wesnoth to build.
20160718 05:32:27< bumbadadabum> always fun
20160718 05:32:44< celticminstrel> Since I just merged that PR, it's almost a full rebuild.
20160718 05:33:52-!- mjs-de [~mjs-de@x4e31a31f.dyn.telefonica.de] has quit [Remote host closed the connection]
20160718 05:37:03< bumbadadabum> we can rebuild it
20160718 05:37:07< bumbadadabum> we have the technology
20160718 05:37:18< celticminstrel> Huh?
20160718 05:38:51< bumbadadabum> n-nothing
20160718 05:40:00< vultraz> meme
20160718 05:40:23< celticminstrel> Oh
20160718 05:41:50< Aginor> it's pronounced meme, not meme
20160718 05:42:16< Aginor> :D
20160718 05:42:20 * Aginor disappears
20160718 05:42:34< celticminstrel> That doesn't get the intent across at all...
20160718 05:48:37-!- Kwandulin [~Miranda@p200300760F2D81F2E80551A296FCAF15.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160718 06:03:47< celticminstrel> Okay, it built, but it's not launching. Or maybe it's just being really slow.
20160718 06:04:08< celticminstrel> Either way, annoying.
20160718 06:04:57< celticminstrel> Oh, the pause button is finally enabled, that has to be a good sign.
20160718 06:05:43< celticminstrel> Forgot to disable exception breakpoints.
20160718 06:06:19< bumbadadabum> lol
20160718 06:06:32< celticminstrel> Oh, that wasn't the cause of the slowness.
20160718 06:06:43< celticminstrel> More like a sign that things are finally moving.
20160718 06:06:47< celticminstrel> I have a window now.
20160718 06:06:59< celticminstrel> Alright, to test this.
20160718 06:07:55< celticminstrel> Replicated, I think.
20160718 06:08:19< celticminstrel> Yup, crash in unit_race::generate_name.
20160718 06:08:31< celticminstrel> EXC_BAD_ACCESS
20160718 06:08:46< celticminstrel> Which is equivalent to SIGSEGV or whatever.
20160718 06:09:17< celticminstrel> Now test the probably fix...
20160718 06:09:44< celticminstrel> ^probable
20160718 06:10:56< celticminstrel> I'm not clear on whether the bug gfgtdf linked is specifically about this or if it's about something else and someone just happened to talk about this in its discussion.
20160718 06:13:56< bumbadadabum> he mentioned he couldn't test it because LotI didn't run for him
20160718 06:14:09< bumbadadabum> and some things about that crash were discussed as well
20160718 06:18:56< celticminstrel> Seems to work.
20160718 06:19:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160718 06:19:11< celticminstrel> The unit went to the recall list, huh.
20160718 06:21:06< celticminstrel> It still crashes if I recall it, for a completely different reason...?
20160718 06:21:15< celticminstrel> Unless it crashed because I tried to interrupt it.
20160718 06:21:19< celticminstrel> Sometimes that happens.
20160718 06:21:24< celticminstrel> It's annoying.
20160718 06:22:17< celticminstrel> So I guess unit_img is nullptr, which I guess makes sense since the unit didn't specify an image.
20160718 06:40:58< irker988> wesnoth: Celtic Minstrel wesnoth:master da30504945ef / src/units/race.cpp: Fix issue when generating a name for a raceless unit https://github.com/wesnoth/wesnoth/commit/da30504945ef7367b7cbfc08d97f64777dea46ca
20160718 06:41:00< irker988> wesnoth: Celtic Minstrel wesnoth:master 2d7d6a0dde2a / src/units/drawer.cpp: Fix crash when trying to draw a unit with no image https://github.com/wesnoth/wesnoth/commit/2d7d6a0dde2a7426f99d3502f959cf82b2fda93f
20160718 06:41:03-!- celticminstrel is now known as celmin|sleep
20160718 06:52:10-!- Kwandulin [~Miranda@p200300760F2D81F2E80551A296FCAF15.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160718 06:54:53-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160718 07:03:05-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160718 07:06:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160718 07:09:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160718 07:09:12-!- wedge010 is now known as wedge009
20160718 07:23:25-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has joined #wesnoth-dev
20160718 07:29:31-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160718 07:49:44-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160718 08:01:33-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160718 08:32:39-!- Kwandulin [~Miranda@p200300760F2D81F2C1F679E260406049.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160718 08:43:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160718 08:44:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160718 09:29:48-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has quit [Quit: Leaving]
20160718 10:09:25-!- gfgtdf [~chatzilla@x4e36386c.dyn.telefonica.de] has joined #wesnoth-dev
20160718 10:10:40< gfgtdf> bumbadadabum: you could port the map generation code of Httt sceanrio17 to lua
20160718 10:11:28< gfgtdf> bumbadadabum: there as alreadaa a lua code that comes close to that but it still doesnt bheve exactly the same
20160718 10:11:55-!- JyrkiVesterinen [~jyrki@87-100-194-225.bb.dnainternet.fi] has quit [Quit: Konversation terminated!]
20160718 10:18:32< zookeeper> of course the most useful option would be to convince yourself to do something other than just port things from one language to another
20160718 10:20:08< zookeeper> but that might be tricky
20160718 10:22:30-!- Kwandulin [~Miranda@p200300760F2D81F2C1F679E260406049.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160718 10:22:51< gfgtdf> if we had a better bugtracker we could just list all bugs tagged with 'lua'
20160718 10:31:34-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160718 10:51:41-!- molt [~molt@cable-178-148-179-151.dynamic.sbb.rs] has joined #wesnoth-dev
20160718 10:53:17-!- Appleman1234 [~Appleman1@KD036012043061.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160718 11:02:32-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160718 11:06:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 11:12:18-!- irker988 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160718 11:38:18-!- JyrkiVesterinen [~jyrki@87-92-31-136.bb.dnainternet.fi] has joined #wesnoth-dev
20160718 11:43:46-!- Appleman1234 [~Appleman1@KD036012035057.au-net.ne.jp] has joined #wesnoth-dev
20160718 11:50:35-!- irker907 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160718 11:50:35< irker907> wesnoth: Charles Dang wesnoth:master 61ccf2fc1623 / src/ (events.cpp events.hpp): WIP: some refactoring of event handling w/ celticminstrel https://github.com/wesnoth/wesnoth/commit/61ccf2fc1623d4effea9360ef5e8940faf1db387
20160718 11:50:36< irker907> wesnoth: Andreas Löf wesnoth:master fb02c3442f4c / src/ (events.cpp events.hpp): Merge branch 'event_handling_fixes' of https://github.com/Vultraz/wesnoth into V https://github.com/wesnoth/wesnoth/commit/fb02c3442f4cb61f228430720f27a76ba8b25344
20160718 11:50:37< irker907> wesnoth: Andreas Löf wesnoth:master 90b6b58aa43e / src/ (events.cpp events.hpp): Fix crashes in the focus cycling code. https://github.com/wesnoth/wesnoth/commit/90b6b58aa43ea58dc0b4cb3b6f45b01e6ffc1a8a
20160718 11:50:38< irker907> wesnoth: Charles Dang wesnoth:master a399a0071711 / src/ (events.cpp events.hpp): Use emplace_back when adding new event_contexts member https://github.com/wesnoth/wesnoth/commit/a399a0071711691abc0aabe1ff22048516f47d00
20160718 11:50:39< irker907> wesnoth: Andreas Löf wesnoth:master 75632003efef / src/ (events.cpp events.hpp preferences.cpp): Add a destructor to the context class. https://github.com/wesnoth/wesnoth/commit/75632003efef78b1d2fe9f47c6a7e4dabc47de22
20160718 11:50:41< irker907> wesnoth: Andreas Löf wesnoth:master 6964aa2ba7aa / src/ (events.cpp events.hpp): Change const_iterator to iterator in an attempt to appease travis. https://github.com/wesnoth/wesnoth/commit/6964aa2ba7aaee99823c9bdd7b3fc40ba8d9c5eb
20160718 11:50:43< irker907> wesnoth: Andreas Löf wesnoth:master 516daccbba37 / src/ (events.cpp wesnoth.cpp): Move the global event context onto the general event queue. https://github.com/wesnoth/wesnoth/commit/516daccbba373716fafd0acc58e224e1b927ac14
20160718 11:50:45< irker907> wesnoth: Andreas Löf wesnoth:master 501eb6074391 / src/ (events.cpp events.hpp): Fix crash in context destructor https://github.com/wesnoth/wesnoth/commit/501eb6074391f87bdfe5d670ef77450465e15499
20160718 11:50:47< irker907> wesnoth: Andreas Löf wesnoth:master 9550c3636ba8 / src/events.cpp: Ensure that focus handling stays the same as before the fix https://github.com/wesnoth/wesnoth/commit/9550c3636ba826991ef9e23a0ba7dc2ad4d9ac7a
20160718 11:50:49< irker907> wesnoth: Andreas wesnoth:master 5e7d558228ec / src/ (events.cpp events.hpp preferences.cpp wesnoth.cpp): Merge pull request #696 from wesnoth/Vultraz-event_handling_fixes https://github.com/wesnoth/wesnoth/commit/5e7d558228ec664681fd3df0906eab9138dca62b
20160718 11:56:37< vultraz> \o/
20160718 11:57:00< Aginor> I left the splice out
20160718 11:57:24< Aginor> because I couldn't be bothered to re-test properly if I changed it
20160718 11:57:27< Aginor> ;)
20160718 11:57:41< Aginor> feel free to change it yourself, but then it's on your head if it breaks ;)
20160718 12:08:23< vultraz> just nice that it's merged
20160718 12:08:33< vultraz> and a crash was fixed
20160718 12:08:46< vultraz> imagine if we had released with such a prominent crash
20160718 12:49:51< celmin|sleep> The point of the splice was so that the handler that just lost focus is the next one up to take back focus.
20160718 12:50:06< celmin|sleep> I have no idea whether this is important.
20160718 12:50:24< celmin|sleep> BTW, what about the stoi branch?
20160718 12:50:31-!- celmin|sleep is now known as celticminstrel
20160718 12:53:19< vultraz> PR
20160718 12:53:31< vultraz> I guess I need to implement your suggestions
20160718 12:53:34< celticminstrel> Yeah, whatever. I mean, will it be merged soon?
20160718 12:53:36< celticminstrel> Ah, I see.
20160718 13:11:40< irker907> wesnoth: Celtic Minstrel wesnoth:master 7b83343b3611 / data/english.cfg: fixup https://github.com/wesnoth/wesnoth/commit/7b83343b3611d83ba260253007d313364a7d586f
20160718 13:16:38-!- Kwandulin [~Miranda@p200300760F2D81F2F0CD0F62B6238357.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160718 13:24:57-!- Duthlet [~Duthlet@dslb-188-106-027-209.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20160718 13:34:28< celticminstrel> gfgtdf: Is there a list somewhere of what the end level data contains? I'd guess next_scenario and the various carryover attributes, at least?
20160718 13:34:41< celticminstrel> Is it just everything that's valid in an [endlevel] tag?
20160718 13:34:51< celticminstrel> Or is there other stuff too?
20160718 13:35:45< gfgtdf> celticminstrel: if you mean the end_level_data struct, then you can simpyl look up its memeber in th header https://github.com/wesnoth/wesnoth/blob/master/src/game_end_exceptions.hpp#L93
20160718 13:36:18-!- molt [~molt@cable-178-148-179-151.dynamic.sbb.rs] has quit [Quit: Leaving]
20160718 13:36:42< celticminstrel> So basically I was totally wrong.
20160718 13:37:33< celticminstrel> Hmm.
20160718 13:39:00< gfgtdf> celticminstrel: this are more or less the keys that wesnoth.end_level() supports
20160718 13:39:47< celticminstrel> wesnoth.end_level doesn't seem to be documented?
20160718 13:40:45< celticminstrel> Most of these end-level attributes seem like things that aren't very useful for a Lua script to access. Really, only is_victory (and proceed_to_next_level) seem useful.
20160718 13:41:16< gfgtdf> celticminstrel: hmm maybe not, ist just used in the lua implementation of [endlevel]
20160718 13:41:37< celticminstrel> If it was writable, the transient_end_level data also seems useful.
20160718 13:42:08< celticminstrel> Whether to show carryover report, invoke linger mode, and reveal map, and the music to play.
20160718 13:42:33< vultraz> all of this is stuff that would be generally useful in a level table
20160718 13:42:52< celticminstrel> How are these things normally set?
20160718 13:43:54< gfgtdf> celticminstrel: with wesnoth.end_level ([endlevel]) or by automactic endlevel via victory_when_eemoed_defated=yes(default)
20160718 13:45:11< celticminstrel> So, for example, linger mode is normally disabled in [endlevel]?
20160718 13:46:26< vultraz> uhh
20160718 13:46:52< vultraz> dunno
20160718 13:46:57< celticminstrel> I see that is supported there, at least, so I guess that's probably right.
20160718 13:47:08< celticminstrel> Oh, the saves stuff is also supported there, huh.
20160718 13:47:09< vultraz> it's a bool key
20160718 13:47:12< vultraz> dunno what the default is
20160718 13:47:20< celticminstrel> Default is yes, I assume.
20160718 13:47:30< celticminstrel> Given that linger mode normally does happen.
20160718 13:47:59< vultraz> true
20160718 13:51:10< gfgtdf> celticminstrel: i guess we coudl move some of these attributes out of the end:levle_data struct (so that they can aslo be set diectory in [scearnio]) and add lua getter/setters for them
20160718 13:51:34< gfgtdf> celticminstrel: not sure if thats'D make sense though
20160718 13:51:40< celticminstrel> gfgtdf: Is the end level data not available when the scenario isn't currently ending?
20160718 13:51:54< vultraz> gfgtdf: my idea was to have a level table accessible for each scenario
20160718 13:52:24< gfgtdf> celticminstrel: no its onyl avaiable after the scnario has ended (or after wesnoth.endlevel) was called
20160718 13:52:30< celticminstrel> vultraz: I think that's a misleading way to say it. "for the current scenario" might be better? Otherwise it might imply that you can access other scenarios too.
20160718 13:52:34< celticminstrel> I see.
20160718 13:52:42< vultraz> celticminstrel: right
20160718 13:54:21< celticminstrel> Hmm.
20160718 14:14:55< vultraz> I swear, one of these files in my PR is included somewhere it should not be..
20160718 14:15:26< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/pull/692/files
20160718 14:15:50< vultraz> celticminstrel: I took Soliton's suggestion and printed out the original problem values in the error messages
20160718 14:16:13< celticminstrel> Good idea.
20160718 14:16:39< vultraz> see if you think I need to change anything else
20160718 14:18:27< celticminstrel> Just two minor cases of overzealousness.
20160718 14:19:18< vultraz> That it?
20160718 14:19:35< celticminstrel> I think so.
20160718 14:20:09< vultraz> ok, once my build finishes ill fix that and push
20160718 14:23:34-!- JyrkiVesterinen [~jyrki@87-92-31-136.bb.dnainternet.fi] has quit [Quit: Konversation terminated!]
20160718 14:24:30 * celticminstrel is currently working on making wesnoth.get_end_level_data() return something mutable.
20160718 14:39:03< irker907> wesnoth: Charles Dang wesnoth:master dd88d4906e35 / src/ (10 files in 8 dirs): Appropriately handle std::stoi exceptions https://github.com/wesnoth/wesnoth/commit/dd88d4906e35bc8b1839960b570913761f92e872
20160718 14:39:03-!- gfgtdf [~chatzilla@x4e36386c.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20160718 14:49:54< celticminstrel> Okay, I think this is done.
20160718 14:50:03< celticminstrel> Need to think of a way to test it now.
20160718 14:50:17< vultraz> celticminstrel: please try to get any new things you're adding/fixing in earlier rather than later
20160718 14:50:46< vultraz> zookeeper: please try to review those campaign PRs before the release date
20160718 14:50:54< celticminstrel> I forget, do we do a feature freeze for unstable releases?
20160718 14:51:13< celticminstrel> I do seem to remember that we don't do a string freeze.
20160718 14:51:14< vultraz> uhh
20160718 14:51:35< vultraz> I think not if we're not in RC
20160718 14:51:56< celticminstrel> I'd like something more than "I think". :P
20160718 14:52:40< vultraz> I'm not going to impose a hard feature freeze, but I'd prefer if you're adding anything that you do it sooner rather than later
20160718 14:52:50< celticminstrel> Hey, why don't we allow [lua] as a conditional tag?
20160718 14:53:20< vultraz> no idea
20160718 14:53:32< celticminstrel> Should I add it? It's practically copy-paste.
20160718 14:53:43< celticminstrel> Or actually I could local-function it.
20160718 14:53:48< vultraz> as long as you conform it works
20160718 14:53:53< celticminstrel> So as not to duplicate things.
20160718 14:54:16< vultraz> confirm
20160718 14:55:03< celticminstrel> What should be the behaviour if it returns something that's not a boolean?
20160718 14:55:15< celticminstrel> Error, or behave as true (or false on nil)?
20160718 14:55:41< vultraz> follow Lua's boolean rules.
20160718 14:55:49< celticminstrel> That's the latter, yes.
20160718 14:56:58< celticminstrel> nil and false are the only falsy values in Lua; everything else is truthy, even 0.
20160718 14:57:21< celticminstrel> Well, it's done, will test eventually.
20160718 14:58:08< celticminstrel> You know, I could probably actually just use the exact same implementation for the action and conditional form, since the action form will just ignore return values... but maybe it's slightly safer this way.
20160718 14:58:41< celticminstrel> Or even slightly more efficient, not that that's worth worrying about.
20160718 15:04:10< celticminstrel> I don't suppose anyone remembers if there was a solution settled on for the issue of desyncing when units are created in victory events...
20160718 15:06:01< vultraz> afaik there was not
20160718 15:06:18< vultraz> i still support syncing actions regardless of the syncability of an event
20160718 15:06:26< celticminstrel> I do too.
20160718 15:07:29-!- JyrkiVesterinen [~jyrki@87-92-31-136.bb.dnainternet.fi] has joined #wesnoth-dev
20160718 15:08:57< celticminstrel> I've reverted the SP end-scenario events back to victory (except some that don't actually depend on victory, eg those that only clear variables). I didn't touch Legend of Wesmere.
20160718 15:09:10< celticminstrel> I'd like to actually fix the underlying issue too, though.
20160718 15:09:21< celticminstrel> But I'm not sure where to look.
20160718 15:09:45< celticminstrel> If I recall correctly, the issue was that replays could desync if units were created?
20160718 15:10:13< vultraz> something like that
20160718 15:10:17< celticminstrel> Come to think of it, is it only if units are created? Because, if so, I think many of these events didn't actually need the treatment.
20160718 15:10:54< celticminstrel> Though some are quite long so I can't really tell from the diff context...
20160718 15:13:19< celticminstrel> vultraz: Please look at HoT05, at the bottom of the file.
20160718 15:13:26< irker907> wesnoth: Charles Dang wesnoth:master 2a86c6ec463e / src/ (4 files in 3 dirs): Cleaned up a few halo.hpp includes https://github.com/wesnoth/wesnoth/commit/2a86c6ec463ef26912d86e406fb40b43eeeebca4
20160718 15:13:41< celticminstrel> Is it my imagination, or is the result of that loop reverted by the following CLEAR_VARIABLE?
20160718 15:14:03< celticminstrel> I mean, it seems like it's just doing a lot of nothing.
20160718 15:14:55< vultraz> since we don't have glob matching for variable names, it constructs a string list of variable names and clears each one
20160718 15:15:13< celticminstrel> Huh?
20160718 15:15:27< celticminstrel> Oh, I think I get it.
20160718 15:15:37< vultraz> that scenario has village_X_Y_cleared variables
20160718 15:15:39< celticminstrel> It's clearing $village_var, not village_var.
20160718 15:15:45< vultraz> we cannot just clear village_*
20160718 15:15:53< vultraz> sadly
20160718 15:15:56< celticminstrel> Okay, so ultimately, it's clearing a ton of variables.
20160718 15:16:05< vultraz> yes
20160718 15:16:18< vultraz> how hard would implementing such a thingbe?
20160718 15:16:21< celticminstrel> Globbing would be convenient. Maybe I'll try adding that.
20160718 15:16:39< celticminstrel> I'm not sure how hard it would be. I think the variables can be accessed as a config?
20160718 15:16:50< celticminstrel> So, if that's the case, it can be iterated over.
20160718 15:18:37< vultraz> auto is very convenient 
20160718 15:18:48< celticminstrel> Yes.
20160718 15:19:38< celticminstrel> Oh, XCode finally finished indexing.
20160718 15:21:39< celticminstrel> 232 files to build.
20160718 15:21:51< celticminstrel> Probably stoi's fault, largely.
20160718 15:22:05< celticminstrel> Oh wait, that's just a few. Maybe it's the headers then.
20160718 15:22:21< celticminstrel> 10 files changed with stoi
20160718 15:22:27< vultraz> for some reason, while working on the stoi thing I kept having to rebuild a ton of files
20160718 15:22:31< vultraz> no idea why
20160718 15:22:46< celticminstrel> That's weird.
20160718 15:23:12< vultraz> Indeed
20160718 15:23:13< celticminstrel> I wonder if there's an example of a Lua map generator anywhere.
20160718 15:23:46-!- prkc [~prkc@46.166.138.139] has quit [Ping timeout: 272 seconds]
20160718 15:23:52< celticminstrel> Should I push the scenario_end->victory reversions now or wait and try to fix the underlying issue as well?
20160718 15:27:25< celticminstrel> Hmm, [clear_variable] is implemented in Lua. This makes it harder to add globbing, since I can't access the variables as a config.
20160718 15:34:09< vultraz> does lua not have any?
20160718 15:34:20< celticminstrel> Any what?
20160718 15:34:36< celticminstrel> Can you also answer the question? Even if it's "I dunno".
20160718 15:34:46< vultraz> oh, that question
20160718 15:34:50< vultraz> uhh
20160718 15:34:51< vultraz> push
20160718 15:34:58< celticminstrel> 'kay
20160718 15:35:23< celticminstrel> I'll push it together with the endlevel stuff I'm doing and the lua conditionalWML.
20160718 15:35:32< vultraz> and I was asking if lua did not have glob pattern matching
20160718 15:35:49< vultraz> but then I realized that's not the issue
20160718 15:35:58< celticminstrel> I think it has regex rather than glob.
20160718 15:36:08< celticminstrel> The issue is getting a list of all variables. :P
20160718 15:36:24< vultraz> (if we needed glob utilities this exists https://github.com/davidm/lua-glob-pattern )
20160718 15:36:53< vultraz> celticminstrel: add level.variables? :P
20160718 15:37:03< celticminstrel> I don't think we need glob utilities. I can easily convert a glob to a regular expression.
20160718 15:37:17< celticminstrel> Replace '?' with '.' and replace '*' with '.*'.
20160718 15:37:29< celticminstrel> [...] can be left as-is.
20160718 15:37:35< JyrkiVesterinen> Lua has its own pattern syntax. (it doesn't support full regex because that would have required too much code.)
20160718 15:37:52< celticminstrel> Sanitize all other regex special characters by escaping them.
20160718 15:38:17< celticminstrel> JyrkiVesterinen: I'm pretty sure that's wrong. Lua has full regex support, though with some slightly different syntax (using % instead of \).
20160718 15:38:27-!- prkc [~prkc@catv-80-98-46-199.catv.broadband.hu] has joined #wesnoth-dev
20160718 15:38:31< vultraz> if scenario variabkles are kept in a table im sure you could add a proxy table in lua?
20160718 15:38:33< vultraz> or idk
20160718 15:38:39< celticminstrel> It does not support certain things that disqualify the regex as a regular expression, such as backreferences, I believe.
20160718 15:38:50< JyrkiVesterinen> celticminstrel: http://www.lua.org/pil/20.1.html
20160718 15:39:00< JyrkiVesterinen> "Unlike several other scripting languages, Lua does not use POSIX regular expressions (regexp) for pattern matching. The main reason for this is size: A typical implementation of POSIX regexp takes more than 4,000 lines of code. This is bigger than all Lua standard libraries together."
20160718 15:39:21< celticminstrel> I think what that means is that it has its own implementation of regex.
20160718 15:39:35< celticminstrel> Ugh, I can't click the link because Firefox is being dumb.
20160718 15:39:50< celticminstrel> This often happens while I'm building, and it's really annoying.
20160718 15:39:58< celticminstrel> I think swapping is probably at fault.
20160718 15:40:12< JyrkiVesterinen> As I said, it's a custom pattern-matching syntax. It supports less features than full regular expressions.
20160718 15:40:32< celticminstrel> As far as I can recall, it's very similar to standard regex and certainly qualifies as a reguler expression language.
20160718 15:41:07< celticminstrel> And as for "less features", I think that's only if you compare it to crazy ones like Perl regex. If you compare to POSIX regex you'd probably find it has more features.
20160718 15:41:38< celticminstrel> Bleh, I want to check your link so that I can be more sure of what I'm saying...
20160718 15:41:49< celticminstrel> Oh, Firefox's beachball disappeared.
20160718 15:42:22< celticminstrel> Now it's back.
20160718 15:43:03< JyrkiVesterinen> The page also says "Of course, the pattern matching in Lua cannot do all that a full POSIX implementation does."
20160718 15:43:22< JyrkiVesterinen> Although my original point was really about the syntax being different.
20160718 15:43:41< celticminstrel> I'll continue this conversation when I actually have the page in front of me.
20160718 15:49:02-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160718 15:52:36< celticminstrel> Okay, so basically it supports anything you can do with a POSIX regex (except maybe matching on word boundaries), but the POSIX character classes (eg [:alnum:]) are not available, and {} qualifiers would need to be expanded. And % instead of \ is used as the escape character. The most basic elements have the same syntax. It looks like negated character classes may not be supported though (eg %W for "non-alphanumeric characters").
20160718 15:53:04< celticminstrel> It doesn't support any extended functions provided by flavours such as Perl regex - in particular, no named patterns or other (?...) extensions.
20160718 15:53:22< celticminstrel> It does have a non-greedy *, curiously.
20160718 15:54:26< celticminstrel> But, yeah, I guess there are enough differences in syntax that it's a little dubious to call it "regex" even though it has the full power of regular expressions (in the technical term).
20160718 15:54:56< celticminstrel> Oh, wait, does it seriously not support alternation? I don't see this mentioned on the page.
20160718 15:56:30< JyrkiVesterinen> The book explains that they introduced their own pattern engine due to size. It would be unrealistic to explain that the Lua pattern engine (500 lines) would match POSIX regex (4000 lines).
20160718 15:56:43< JyrkiVesterinen> *expect
20160718 15:57:05< celticminstrel> I'm not sure if that's realistic or not.
20160718 15:59:39< celticminstrel> It does pretty much have all the same features as POSIX though, with the possible exception of word boundary anchors and alternation.
20160718 15:59:52< celticminstrel> (I guess alternation could be simulated by the Lua or operator.)
20160718 16:00:13< celticminstrel> So I'm thinking maybe it is realistic?
20160718 16:00:31< celticminstrel> Oh right, it doesn't support the {} syntax either.
20160718 16:01:27< celticminstrel> Still, x{5} is the same as xxxxx, x{5,} is the same as xxxxxx*, and x{n,m} is the same as... hmm, I can't think of anything here.
20160718 16:01:36-!- TC01 [~quassel@london.acm.jhu.edu] has quit [Remote host closed the connection]
20160718 16:01:47< celticminstrel> Well, x{5,7} would be the same as xxxxx|xxxxxx|xxxxxxx I guess...
20160718 16:02:01< celticminstrel> Or... xxxxx(|x|xx)
20160718 16:03:08< JyrkiVesterinen> I guess we can see the 80/20 rule in effect here. Apparently most lines of the "typical POSIX regex implementation" are needed for features almost no one uses, and thus Lua pattern matching can achieve almost the same power with a fraction of the size.
20160718 16:04:33< celticminstrel> Ooh, turns out I was wrong - it does support word boundary anchors.
20160718 16:04:53-!- TC01 [~quassel@128.220.251.37] has joined #wesnoth-dev
20160718 16:04:54< celticminstrel> Using the syntax %f[a-zA-Z_]
20160718 16:05:02< celticminstrel> Not sure if %f%w also works...
20160718 16:05:22< celticminstrel> Oh right, you'd add 0-9 in there too.
20160718 16:05:57< celticminstrel> %f%w does not work.
20160718 16:06:48< celticminstrel> It even has one non-regular feature with %b()
20160718 16:06:59< celticminstrel> (Or %b[] or %b{} etc)
20160718 16:07:16< celticminstrel> Wait, it actually does support backreferences?
20160718 16:07:35< celticminstrel> I thought it didn't.
20160718 16:08:15< celticminstrel> Actually, I quite like the concept of %f - real regex libraries should adopt that.
20160718 16:08:30-!- Kwandulin [~Miranda@p200300760F2D81F2F0CD0F62B6238357.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160718 16:09:21< celticminstrel> Apparently you don't need to escape ^ and $ unless they're at the beginning or end of the string, respectively. I suppose that's handy - if they were anywhere else the regex would never match anything, anyway.
20160718 16:09:52< celticminstrel> For the record, the full syntax is described here: http://www.lua.org/manual/5.2/manual.html#6.4.1
20160718 16:10:16 * celticminstrel switches the 5.2 to 5.3 out of curiosity.
20160718 16:10:34< celticminstrel> Nothing new, huh.
20160718 16:11:45< celticminstrel> Right, so, with a set of Lua regexs you can express anything a POSIX regex can (though will be a little more verbose in some rare cases), and a bit more besides (%b() and backreferences).
20160718 16:11:55< celticminstrel> (Oh and the non-greedy .-)
20160718 16:12:18< celticminstrel> ^regexes
20160718 16:12:30< celticminstrel> It's kinda weird that it doesn't support alternation, though.
20160718 16:12:54< celticminstrel> It also only supports nine backreferences.
20160718 16:15:33< celticminstrel> I want to break up the game_lua_kernel file. It's ridiculously huge. But ... all those static functions do need to be accessible in that one place...
20160718 16:20:49< JyrkiVesterinen> Well, a large "API for Lua" file is common. A couple commercial games I have worked on had the same problem.
20160718 16:20:55< celticminstrel> Some of the functions are member functions, so I suppose those could be moved to another file...
20160718 16:21:18< celticminstrel> Common does not mean it's okay. :/
20160718 16:21:36< celticminstrel> Wesnoth does split portions of its API out into other files.
20160718 16:21:55< celticminstrel> Mainly portions related to a specific type of object, such as "race" or "unit type".
20160718 16:22:01< JyrkiVesterinen> Maybe the Lua API could be split to smaller tables, and each table could have its own .cpp file.
20160718 16:22:08-!- mjs-de [~mjs-de@x4e3055a4.dyn.telefonica.de] has joined #wesnoth-dev
20160718 16:22:19< celticminstrel> I dunno if that would be sensible.
20160718 16:23:31< celticminstrel> Finally it compiles, time to test it... somehow...
20160718 16:28:03-!- prkc [~prkc@catv-80-98-46-199.catv.broadband.hu] has quit [Quit: Leaving]
20160718 16:28:18-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160718 16:35:19< celticminstrel> Well, it works, so yay.
20160718 16:35:26-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160718 16:36:02< celticminstrel> Tested by putting a wesnoth.show_lua_console() in the scenario end event and fiddling around with the end level data.
20160718 16:36:24< celticminstrel> Setting linger_mode to false caused it to skip linger mode and jump straight to the main menu!
20160718 16:38:58< celticminstrel> Somebody broke commands.
20160718 16:39:22< celticminstrel> Ah, I see what's wrong though.
20160718 16:39:48< celticminstrel> When I press ;, a semicolon appears in the command box that pops up, which I need to remove before typing a command.
20160718 16:39:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160718 16:40:04< celticminstrel> What was the shortcut to bring up chat...
20160718 16:41:07< celticminstrel> vultraz: Should a condition return true or false if the Lua code fails to compile?
20160718 16:41:23< celticminstrel> Currently seems to be true for whatever reason.
20160718 16:47:11-!- louis94 [~~louis94@91.178.241.227] has joined #wesnoth-dev
20160718 16:54:50< bumbadadabum> good morning
20160718 17:05:10-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 17:05:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 252 seconds]
20160718 17:05:45-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-pkujqgjnnjpajjwg] has quit [Ping timeout: 272 seconds]
20160718 17:06:22-!- Elsi [~Elsi@luwin.ulrar.net] has quit [Ping timeout: 272 seconds]
20160718 17:11:00-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20160718 17:12:21< Shiki> Hi
20160718 17:14:30-!- louis94 [~~louis94@91.178.241.227] has quit [Ping timeout: 250 seconds]
20160718 17:15:32-!- stikonas_ is now known as stikonas
20160718 17:19:07< bumbadadabum> does anyone know what wesnoth.create_unit() actually puts in the proxy unit?
20160718 17:23:52-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:406b:476:2f67:9d44] has joined #wesnoth-dev
20160718 17:24:27-!- Appleman1234 [~Appleman1@KD036012035057.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160718 17:26:23-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-fmjvbgeokuzxajtx] has joined #wesnoth-dev
20160718 17:26:46-!- matthiaskrgr is now known as Guest80655
20160718 17:27:15-!- Guest80655 [matthiaskr@gateway/shell/panicbnc/x-fmjvbgeokuzxajtx] has quit [Changing host]
20160718 17:27:15-!- Guest80655 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160718 17:27:16-!- Guest80655 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20160718 17:27:16-!- Guest80655 [matthiaskr@gateway/shell/panicbnc/x-fmjvbgeokuzxajtx] has joined #wesnoth-dev
20160718 17:27:53-!- Guest80655 is now known as matthiaskrgr_
20160718 17:34:08-!- Kwandulin [~Miranda@p200300760F2D81F258007C878A1EF64E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160718 17:36:57-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:406b:476:2f67:9d44] has quit [Remote host closed the connection]
20160718 17:39:39-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160718 17:55:48-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160718 18:13:43-!- irker907 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160718 18:24:53-!- Appleman1234 [~Appleman1@KD036012035057.au-net.ne.jp] has joined #wesnoth-dev
20160718 18:25:12-!- louis94 [~~louis94@91.178.241.227] has joined #wesnoth-dev
20160718 18:40:21-!- gfgtdf [~chatzilla@x4e36386c.dyn.telefonica.de] has joined #wesnoth-dev
20160718 18:43:53-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160718 18:49:39< gfgtdf> 20160718 14:52:50< celticminstrel> Hey, why don't we allow [lua] as a conditional tag?
20160718 18:49:54< gfgtdf> celticminstrel: well we can already defeine custom conditional tags in lua
20160718 18:50:30< celticminstrel> True.
20160718 18:51:12< celticminstrel> I would expect this to be used for single-use complex conditions where defining a new tag may not be worth the extra work.
20160718 18:51:31< celticminstrel> But it's true that it's not really needed.
20160718 18:54:06< gfgtdf> 20160718 16:15:33< celticminstrel> I want to break up the game_lua_kernel file. It's ridiculously huge. But ... all those static functions do need to be accessible in that one place...
20160718 18:54:24< gfgtdf> celticminstrel: i think hte main issue here is that most of thoese functions are member of the game_lua_kernel class
20160718 18:54:47< celticminstrel> Why is that an issue?
20160718 18:55:09< gfgtdf> 20160718 17:19:07< bumbadadabum> does anyone know what wesnoth.create_unit() actually puts in the proxy unit?
20160718 18:55:14< gfgtdf> bumbadadabum:  not sure what you mean here
20160718 18:55:47< gfgtdf> celticminstrel: becasue we usually want teh member function definition in the <classname>.cpp file othewise t'd be quiet hard to find them
20160718 19:00:19< celticminstrel> Not true, and already violated by units.
20160718 19:01:07< gfgtdf> celticminstrel: i perosnallythink its rather annyoing that for every lua callback you add you have  you have to add it in the header, then do the definition and then add it in the callback table, I think it'd be better if we had something similar to the WML_HANDLER_FUNCTION  that'd just take a game_lua_kernel& as parameter but the problme is that it wouldnt have access to game_lua_kernels...
20160718 19:01:09< gfgtdf> ...private memebers
20160718 19:01:33< gfgtdf> celticminstrel: you mena lua units?
20160718 19:01:39< celticminstrel> No, the unit class.
20160718 19:02:05< celticminstrel> You don't need to add all callbacks to the game_lua_kernel class - only if they need to access those private members. Many of them are simply file-static functions.
20160718 19:02:06< gfgtdf> celticminstrel: hmm yes and it's its quite annying of you have too look for a unit class function.
20160718 19:02:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160718 19:02:25< celticminstrel> Uhh, right-click the name and click "jump to definition"?
20160718 19:03:21< gfgtdf> celticminstrel: at least on msvc that takes some seconds.
20160718 19:03:42< celticminstrel> So does manually opening the file?
20160718 19:04:05< gfgtdf> celticminstrel: hmm opeing a file goes usuualy instantly
20160718 19:07:23< celticminstrel> Moving your mouse to the required file and clicking it.
20160718 19:08:12< gfgtdf> celticminstrel: still less than 1 second
20160718 19:22:14-!- mjs-de [~mjs-de@x4e3055a4.dyn.telefonica.de] has quit [Remote host closed the connection]
20160718 19:27:40-!- gfgtdf [~chatzilla@x4e36386c.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160718 19:32:31-!- louis94 [~~louis94@91.178.241.227] has quit [Ping timeout: 240 seconds]
20160718 19:39:32-!- Kwandulin [~Miranda@p200300760F2D81F258007C878A1EF64E.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160718 19:41:33-!- Kwandulin [~Miranda@p200300760F2D8127E4882233A6C5A516.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160718 19:44:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160718 20:07:35-!- mjs-de [~mjs-de@x4e3055a4.dyn.telefonica.de] has joined #wesnoth-dev
20160718 20:15:14-!- Kwandulin [~Miranda@p200300760F2D8127E4882233A6C5A516.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160718 20:19:10-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has joined #wesnoth-dev
20160718 20:19:24-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has left #wesnoth-dev []
20160718 20:21:44-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has joined #wesnoth-dev
20160718 20:25:45-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has joined #wesnoth-dev
20160718 20:28:08-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-58.zoominternet.net] has joined #wesnoth-dev
20160718 20:28:41-!- louis94 [~~louis94@91.178.241.227] has joined #wesnoth-dev
20160718 20:30:03< SigurdFD> celticminstrel: https://gna.org/bugs/index.php?24864
20160718 20:30:10-!- SigurdFD [SigurdFD@dynamic-acs-72-23-110-58.zoominternet.net] has quit [Client Quit]
20160718 20:40:17-!- louis94 [~~louis94@91.178.241.227] has quit [Ping timeout: 260 seconds]
20160718 20:44:14-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160718 20:47:36-!- gfgtdf [~chatzilla@x4e36386c.dyn.telefonica.de] has joined #wesnoth-dev
20160718 20:48:11-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20160718 20:48:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160718 20:48:28-!- wedge010 is now known as wedge009
20160718 20:50:12-!- gfgtdf [~chatzilla@x4e36386c.dyn.telefonica.de] has quit [Client Quit]
20160718 21:03:29-!- prkc [~prkc@catv-80-98-46-199.catv.broadband.hu] has joined #wesnoth-dev
20160718 21:09:10-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20160718 21:09:41< Aginor> 00:49 < celmin|sleep> The point of the splice was so that the handler that just  lost focus is the next one up to take back focus.
20160718 21:10:15< Aginor> celticminstrel: I am happier to preserve the original behaviour though as we don't quite know how GUI1 relies on it
20160718 21:10:55< Aginor> someone should also spend some time looking at the buttons/sliders in the gui to see if they can figure out what's going on there
20160718 21:11:27< Aginor> the action/menu buttons are also looking a bit bad, and they've got inconsistent looks depending on how bit the window is
20160718 21:11:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160718 21:12:02< Aginor> vultraz: check the logs :)
20160718 21:21:31-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160718 21:29:37-!- louis94 [~~louis94@91.178.241.227] has joined #wesnoth-dev
20160718 21:49:48-!- JyrkiVesterinen [~jyrki@87-92-31-136.bb.dnainternet.fi] has quit [Quit: Konversation terminated!]
20160718 22:12:49-!- mjs-de [~mjs-de@x4e3055a4.dyn.telefonica.de] has quit [Remote host closed the connection]
20160718 22:30:41-!- Duthlet [~Duthlet@dslb-188-106-027-209.188.106.pools.vodafone-ip.de] has quit [Quit: leaving]
20160718 22:36:57< vultraz> dammit, the fix to that random map things is now gone
20160718 22:40:28-!- louis94 [~~louis94@91.178.241.227] has quit [Ping timeout: 258 seconds]
20160718 22:44:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20160718 22:46:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160718 22:48:06< celticminstrel> Was there a fix? I don't even remember.
20160718 22:55:31-!- edgrey [~edgrey@178.204.166.136] has quit [Remote host closed the connection]
20160718 22:56:06-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160718 22:56:07-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160718 23:01:18< vultraz> celticminstrel: isn't that the thing I fixed
20160718 23:01:33< celticminstrel> I don't think so? That was something else, I think.
20160718 23:01:55< celticminstrel> This one was introduced by PR661, I think, probably.
20160718 23:01:57< vultraz> well gfgtdf said my fix had been remoced by 661
20160718 23:05:11< vultraz> hmm
20160718 23:05:21< vultraz> ok, I can stop the crash... but it break UAM
20160718 23:05:22< vultraz> breaks
20160718 23:05:35< celticminstrel> UAM?
20160718 23:06:11< vultraz> ultimate random maps
20160718 23:08:26-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has quit [Quit: Leaving]
20160718 23:11:57< celticminstrel> Methinks you mispelled the acronym.
20160718 23:13:12< vultraz> er
20160718 23:13:13< vultraz> yes
20160718 23:13:16< vultraz> URM
20160718 23:30:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160718 23:30:47-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160718 23:43:03-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20160718 23:44:14< vultraz> celticminstrel: seems to be a problem with whatever generator is listed at the end of default_map_generator_job.cpp:777
20160718 23:54:06 * vultraz can't figure out what's wrong here..
20160718 23:54:49< celticminstrel> What's up at line 777?
20160718 23:55:10< vultraz> hm?
20160718 23:55:25< celticminstrel> What's the problem at that line?
20160718 23:55:57< vultraz> I dunno
20160718 23:56:03< vultraz> 'swamp' is listed last in the list
20160718 23:56:13< celticminstrel> So what exactly is the problem?
20160718 23:56:18< vultraz> if I add a check for the swamp generator being a nullptr, the game doesn't crash
20160718 23:56:41< vultraz> if I move say, mountain to the end of list and check for that, doesn't crash.
20160718 23:56:50< vultraz> why should the end of the list matter
20160718 23:57:00< celticminstrel> No idea.
20160718 23:57:28< celticminstrel> He used an iterator-loop. See if it's fixed by changing to range-for? (src/utils/name_generator_factory.cpp:30)
20160718 23:57:47< celticminstrel> Though, where does it actually crash? On construction?
20160718 23:58:09< vultraz> https://gna.org/bugs/index.php?24864
20160718 23:58:33< celticminstrel> That's really hard to read.
20160718 23:58:53< vultraz> it is
20160718 23:58:58< celticminstrel> Line 1079 though...
20160718 23:59:29< vultraz> range for doesn't help
--- Log closed Tue Jul 19 00:00:12 2016