--- Log opened Tue Jul 19 00:00:12 2016
--- Day changed Tue Jul 19 2016
20160719 00:00:12< celticminstrel> Maybe it's coincidence that the crash is at 1079 instead of any of the other calls to generate()...
20160719 00:00:39< celticminstrel> Indeed, the previous two calls are conditional.
20160719 00:01:15< celticminstrel> So that would seem to suggest either that there's a problem with generate() or that the generator is null.
20160719 00:01:25< vultraz> generate()?
20160719 00:01:30< vultraz> in what class?
20160719 00:01:52< celticminstrel> Wait. The generator totally could be null...?
20160719 00:02:27< vultraz> let's see
20160719 00:02:53< celticminstrel> Yeah, that must be the problem. The other calls are conditional on misc_labels != nullptr, and if that condition is false, the generator is also null.
20160719 00:04:24< celticminstrel> Ugh, what the heck is going on here.
20160719 00:04:30< vultraz> so shouldn't that be set outside the check?
20160719 00:04:40< celticminstrel> Hmm?
20160719 00:04:47< celticminstrel> It shouldn't be, no.
20160719 00:04:54< vultraz> I mean, returning if base_name_generator is null does stop the crash, but then the map isn't generated
20160719 00:05:01< celticminstrel> If misc_labels is null, no name generation should happen.
20160719 00:05:12< celticminstrel> So rather than setting it outside the check, this specific call needs to be guarded.
20160719 00:05:59< vultraz> which specific call?
20160719 00:06:08< celticminstrel> Line 1079.
20160719 00:06:14< celticminstrel> This is much easier said than done.
20160719 00:07:01< vultraz> ya know, there are 8 calls to generate() there
20160719 00:07:10< celticminstrel> ???
20160719 00:08:21< vultraz> 847, 872, 1079, 1143, 1235, 1247, 1435
20160719 00:08:33< vultraz> why does only 1079 need a guard
20160719 00:08:43< celticminstrel> They all need a guard. Some of them already have it.
20160719 00:09:41< celticminstrel> There are more calls than that, too.
20160719 00:11:40< celticminstrel> I guess you only looked for base_name_generator->generate(), but non-base generate() calls also need to be guarded.
20160719 00:13:41 * vultraz groans
20160719 00:13:55< celticminstrel> Probably most of them are already.
20160719 00:14:07< vultraz> we need to fix this today
20160719 00:14:13< vultraz> or tomorrow latest
20160719 00:14:14< celticminstrel> I have an idea.
20160719 00:14:16< vultraz> else we're reverting 661
20160719 00:19:17< celticminstrel> That's the only unguarded use.
20160719 00:19:56< celticminstrel> Any suggestions for which map to try loading?
20160719 00:20:34< vultraz> do you have URM installed?
20160719 00:20:39< vultraz> basically any if affected
20160719 00:20:41< vultraz> is
20160719 00:20:44< celticminstrel> Can I copy it from 1.12?
20160719 00:20:59< celticminstrel> Or is it on the 1.13 addon server?
20160719 00:21:25< celticminstrel> Which map did you try?
20160719 00:21:44< vultraz> im not even loading maps
20160719 00:22:02< vultraz> this is just about getting to MP Create and having the URM maps not be empty
20160719 00:22:19< vultraz> (mp create seems to save your previous selection when you exit and return to that category/selection)
20160719 00:22:38< celticminstrel> Ah, I see.
20160719 00:22:54< vultraz> I think URM is on 1.12
20160719 00:22:58< vultraz> else there's a copy here https://gna.org/bugs/index.php?24709
20160719 00:23:07< celticminstrel> I have the 1.12 copy.
20160719 00:33:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160719 00:57:20< celticminstrel> So vultraz, I've started a Citadel map, no crashes.
20160719 00:57:50< celticminstrel> That means it's fixed, right?
20160719 00:58:16< vultraz> I guess
20160719 00:58:25< vultraz> commit your fix and I'll confirm
20160719 00:58:26< celticminstrel> You're not sure?
20160719 00:58:32< celticminstrel> Well, I'll push it, anyway.
20160719 01:00:22-!- irker576 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160719 01:00:22< irker576> wesnoth: Celtic Minstrel wesnoth:master 93c9d7e55795 / data/campaigns/ (14 files in 8 dirs): Revert SP uses of end_scenario directly tied to victory https://github.com/wesnoth/wesnoth/commit/93c9d7e55795b9ca523f3a55354b83fd6a295988
20160719 01:00:22< irker576> wesnoth: Celtic Minstrel wesnoth:master be2a613fffa0 / src/scripting/game_lua_kernel.cpp: Move Lua dispatch shim to top of file https://github.com/wesnoth/wesnoth/commit/be2a613fffa04d72e6c136e206b34c7b72d2b614
20160719 01:00:23< irker576> wesnoth: Celtic Minstrel wesnoth:master a824d880797d / src/ (4 files in 2 dirs): Lua API: Make end level data mutable https://github.com/wesnoth/wesnoth/commit/a824d880797da212e8b43a5c9eedea2be1d84032
20160719 01:00:24< irker576> wesnoth: Celtic Minstrel wesnoth:master 465ca498b6d6 / src/generators/default_map_generator_job.cpp: mapgen: Fix erroneously trying to generate road names https://github.com/wesnoth/wesnoth/commit/465ca498b6d62abaab8a02a1848d3c6a0c078c0e
20160719 01:07:15-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160719 01:10:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160719 01:32:13< vultraz> celticminstrel: fix confirmed 
20160719 01:32:49< vultraz> celticminstrel: i'll close the bug
20160719 01:33:54< vultraz> thanks
20160719 01:36:11< vultraz> at some point that whole function could probably be cleaned up
20160719 01:41:47-!- solvents [~quassel@69-196-152-213.dsl.teksavvy.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20160719 01:47:09-!- Shiki [~Shiki@141.39.226.227] has quit [Quit: Verlassend]
20160719 02:07:27< irker576> wesnoth: Charles Dang wesnoth:master fbcf4943b111 / data/gui/widget/window_default.cfg: Use darker window border color https://github.com/wesnoth/wesnoth/commit/fbcf4943b111275ae1cf56dea8a96ac5a4c3d5a0
20160719 02:20:02< celticminstrel> Yay!
20160719 03:16:51-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 04:02:55-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160719 04:11:32-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160719 04:28:24< Aginor> I need to change my github notification settings, I'm getting too many emails :D
20160719 04:29:18< celticminstrel> Heh.
20160719 04:29:45< celticminstrel> How much of that is my fault... >_>
20160719 04:34:22< celticminstrel> Unrelatedly, I wonder if there's a place on the wiki where it would make sense to say "report syntax highlighting bugs here".
20160719 04:34:42-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 276 seconds]
20160719 04:43:52-!- Appleman1234 [~Appleman1@KD036012035057.au-net.ne.jp] has quit [Ping timeout: 258 seconds]
20160719 04:48:52-!- iwaim_ [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20160719 04:52:38< bumbadadabum> celticminstrel: so what did you want done to set_variable.rand again?
20160719 04:52:49< bumbadadabum> just make it call helper.rand() and let that figure out the rest?
20160719 04:53:10< celticminstrel> Yeah. Currently helper.rand() calls [set_variable], but it should be the other way around.
20160719 04:53:50< bumbadadabum> so helper.rand() accepts a string
20160719 04:53:56< celticminstrel> Yes.
20160719 04:53:58< bumbadadabum> that it comma-separates
20160719 04:54:00< bumbadadabum> and parses
20160719 04:54:05< bumbadadabum> and it returns a random value
20160719 04:54:09< bumbadadabum> ok I can make that happen
20160719 04:54:15< celticminstrel> You could make it accept an array-like table as well (in that case it skips the splitting step).
20160719 04:54:25< bumbadadabum> I'll probably get that done tomorrow
20160719 04:55:51< celticminstrel> (I suppose if you allowed it to accept an array-like table you might also want to skip parsing ranges and instead have some other format for them, eg {'abc',1,{5,12}} might end up being equivalent to "abc,1,5-12"?)
20160719 05:26:05< vultraz> celticminstrel: we should fix this before the release https://gna.org/bugs/index.php?24712
20160719 05:26:40< celticminstrel> Hmm.
20160719 05:27:15-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 250 seconds]
20160719 05:28:23< celticminstrel> This reminds me of a thing I fixed in the tutorial.
20160719 05:28:54< celticminstrel> https://github.com/wesnoth/wesnoth/commit/308cd8b34f02ef2397a5bcc881b86eec2640130f
20160719 05:29:13< celticminstrel> vultraz: Sooo... maybe the fix is to actually do the equivalent of that after triggering the event?
20160719 05:29:17< celticminstrel> Do you want to try it?
20160719 05:30:28< vultraz> that might fix that one instance in the code, but what about in general/
20160719 05:30:29< vultraz> ?
20160719 05:30:41< celticminstrel> That's what I was saying.
20160719 05:31:01< celticminstrel> In the C++ code, after calling the select event, reselect the unit without triggering another event.
20160719 05:31:10< vultraz> oh
20160719 05:31:15< celticminstrel> (Unless the unit no longer exists, I guess.)
20160719 05:31:41< celticminstrel> (Though I would expect that to be very unlikely.)
20160719 05:38:11< vultraz> random, but does config support initializer lists?
20160719 05:38:27< celticminstrel> I tried to implement it awhile back and failed.
20160719 05:38:36< celticminstrel> But config_of works quite well, honestly.
20160719 05:38:43< vultraz> so it does not?
20160719 05:38:48< celticminstrel> That's correct.
20160719 05:41:26-!- Appleman1234 [~Appleman1@KD036012045012.au-net.ne.jp] has joined #wesnoth-dev
20160719 06:00:17-!- Kwandulin [~Miranda@p200300760F2D8127E4883F50C0D3AED9.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160719 06:00:30-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 276 seconds]
20160719 06:07:41 * vultraz is taking a shot at cleaning up the mapgen function we were working on earlier
20160719 06:08:21< celticminstrel> Oh my.
20160719 06:08:41< celticminstrel> That should not enter 1.13.5.
20160719 06:09:41< vultraz> out of curiosity, is there any way these two lines can be merged 
20160719 06:09:41< vultraz> 	config naming;
20160719 06:09:43< vultraz> 	naming.append_children(game_config_, "naming");
20160719 06:10:48< celticminstrel> Yes.
20160719 06:11:01< celticminstrel> Wait...
20160719 06:11:12< celticminstrel> No, probably not.
20160719 06:11:18< vultraz> ok
20160719 06:11:52< celticminstrel> Hmm...
20160719 06:12:09< celticminstrel> What exactly did append_children do again...
20160719 06:12:19< celticminstrel> Those lines are consecutive in the source?
20160719 06:13:08< vultraz> yes
20160719 06:13:28-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 06:13:37< celticminstrel> Does it merge the contents of game_config.get_child("naming") into that config?
20160719 06:13:56< celticminstrel> Because if so, then it could be simplified to config naming = game_config.get_child("naming");
20160719 06:14:07< celticminstrel> (Not quite sure if that's the right function name, but you should get the idea.)
20160719 06:14:11< vultraz> I believe that is the intention, yes
20160719 06:14:25< celticminstrel> Being careful not to add &, of course, since a copy is what you want.
20160719 06:14:37< vultraz> right
20160719 06:15:42-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160719 07:00:06-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has joined #wesnoth-dev
20160719 07:09:14< vultraz> god, this function is long
20160719 07:10:53< celticminstrel> You're not going to push whatever you're doing to 1.13.5, I hope.
20160719 07:11:33< vultraz> right now not doing anything major
20160719 07:11:42< vultraz> just the obvious cleanup
20160719 07:12:38< celticminstrel> Obvious cleanup?
20160719 07:14:36< vultraz> yes. formatting, placement, range-for, better log messages
20160719 07:14:38< vultraz> etc
20160719 07:15:05< celticminstrel> Placement?
20160719 07:16:00< vultraz> moving blocks around if they could be placed better
20160719 07:16:43< celticminstrel> That sounds dubious...
20160719 07:17:28< vultraz> I'll run it by you before I push anythig
20160719 07:18:34-!- JyrkiVesterinen [~JyrkiVest@87-100-232-27.bb.dnainternet.fi] has joined #wesnoth-dev
20160719 07:19:25< celticminstrel> 'kay
20160719 07:19:25-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160719 07:19:30< celticminstrel> Hi
20160719 07:19:36-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has joined #wesnoth-dev
20160719 07:22:07< JyrkiVesterinen> Hello.
20160719 07:30:12-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160719 07:34:17< vultraz> celticminstrel: is the use of goto acceptable?
20160719 07:34:36< celticminstrel> Somewhat.
20160719 07:34:41< celticminstrel> What's the situation?
20160719 07:35:14< celticminstrel> It's always acceptable if used to exit multiple loops in a single jump.
20160719 07:35:24< celticminstrel> (multiple nested loops)
20160719 07:36:40< vultraz> I think some of these massive levels of indent can be reduced with goto
20160719 07:37:00< celticminstrel> Can you give a concrete example?
20160719 07:38:17< vultraz> well, for example, if there's a huge block wrapped in if(village_labels != nullptr), couldn't I just use goto to head to the next stage if it's a nullptr instead of wrapping the whole block in a conditional that makes sure it's not?
20160719 07:38:55< celticminstrel> You could, but this is exactly the sort of use of goto that I would consider highly questionable.
20160719 07:39:26< celticminstrel> BTW, what happens after the block? I seem to recall it's not much.
20160719 07:39:57< vultraz> in this particular case, nothing
20160719 07:40:43< celticminstrel> Looks like it's in a loop, so go ahead and do what you suggest but with continue instead of goto.
20160719 07:41:32< vultraz> ah
20160719 07:42:03< celticminstrel> That section is pretty crazily indented, huh...
20160719 07:42:17< celticminstrel> Two for-loops and four if-statements.
20160719 07:42:40< celticminstrel> And all that's within an if-statement as well.
20160719 07:43:40< vultraz> indeed
20160719 07:44:26< vultraz> celticminstrel: couldn't I also do the same with the convert_to != "" check?
20160719 07:44:31< vultraz> ie, convert_to == "" continue
20160719 07:44:36< celticminstrel> Maybe all four if-statements could be inverted into a continue.
20160719 07:44:43< vultraz> :D
20160719 07:44:48< vultraz> this I like
20160719 07:44:52< celticminstrel> But careful with the first one.
20160719 07:45:05< celticminstrel> Oh, hmm.
20160719 07:45:21< celticminstrel> The second one is not trivially invertible.
20160719 07:45:52< vultraz> well, reducing by two levels is a good start
20160719 07:46:00< celticminstrel> I guess you could pull the declaration out of the if statement and then if should work... I wonder what config::operator bool does anyway...
20160719 07:46:18< celticminstrel> The first if statement is easily indentable.
20160719 07:46:41< celticminstrel> You just have to be careful with it. I guess wrapping it in !(...) would work, though...
20160719 07:47:17-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 07:47:26< celticminstrel> Or you can apply DeMorgan's Law.
20160719 07:47:33< celticminstrel> That's when you need to be careful.
20160719 07:47:37< vultraz> whose law?
20160719 07:47:45< celticminstrel> The &&'s become || and each subcondition is inverted.
20160719 07:48:05< celticminstrel> https://en.wikipedia.org/wiki/De_Morgan%27s_laws
20160719 07:48:37-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 07:49:02< celticminstrel> Eh, I got distracted and it's now almost 4am...
20160719 07:50:58< vultraz> geez
20160719 07:51:00< vultraz> get some sleep
20160719 07:51:06< vultraz> I'll bug you about this tomorrow :P
20160719 07:51:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160719 07:54:11-!- boucman_work1 [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160719 07:55:28-!- celticminstrel is now known as celmin|sleep
20160719 07:55:39-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 264 seconds]
20160719 07:56:39-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160719 08:00:11-!- matthiaskrgr_ is now known as matthiaskrgr
20160719 08:21:09-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160719 08:25:16< irker576> wesnoth: Gregory A Lundberg wesnoth:master 7ec73660e29f / data/campaigns/An_Orcish_Incursion/ (5 files in 2 dirs): AOI Fix missing speakers, use new [role] features https://github.com/wesnoth/wesnoth/commit/7ec73660e29fdf213b3f3030dff74edbd5a2c75d
20160719 08:25:18< irker576> wesnoth: Lari Nieminen wesnoth:master a09f0ed6a9e3 / data/campaigns/An_Orcish_Incursion/ (5 files in 2 dirs): Merge pull request #689 from GregoryLundberg/GL_AOI_fixes https://github.com/wesnoth/wesnoth/commit/a09f0ed6a9e3e8e7d1e9e4d5f7cc0d50b11a794b
20160719 08:38:52< zookeeper> so... is it against protocol to merge PR's with a failed travis check?
20160719 08:44:12-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160719 08:44:22-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160719 08:44:34-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has joined #wesnoth-dev
20160719 08:47:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160719 08:47:31-!- wedge010 is now known as wedge009
20160719 09:01:28-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160719 09:04:36-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has quit [Ping timeout: 272 seconds]
20160719 09:19:55-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 09:27:53< vultraz> zookeeper: not if it's obviously something that shouldn't affect travis, like campaign code
20160719 09:39:48-!- Kwandulin [~Miranda@p200300760F2D8127E4883F50C0D3AED9.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160719 09:40:28< zookeeper> right, good
20160719 09:42:57< vultraz> celmin|sleep: I have merged two of the checks :D
20160719 09:42:59< vultraz> 					const std::string& convert_to = cfg.find_child("village", "terrain", str)["convert_to"].str();
20160719 09:43:01< vultraz> 					if(convert_to.empty()) {
20160719 10:18:04-!- prkc [~prkc@catv-80-98-46-199.catv.broadband.hu] has quit [Ping timeout: 272 seconds]
20160719 10:28:41-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160719 10:39:17-!- edgrey [~edgrey@178.204.10.103] has quit [Remote host closed the connection]
20160719 10:39:40-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 10:48:02-!- gfgtdf [~chatzilla@x4e36aec1.dyn.telefonica.de] has joined #wesnoth-dev
20160719 10:49:15< gfgtdf> celmin|sleep: why did you revert the victor event changes? They did fix bugs as mentioned in the commit message, and your commit might reintroduce them for no real reason.
20160719 10:52:20< vultraz> we should fix the underlying cause in this case
20160719 10:53:36< gfgtdf> celmin|sleep, bumbadadabum: note that currently helper.rand alaso converts strings to which hapens as a side effects of the config readwrite
20160719 10:55:32< gfgtdf> vultraz: well, feel free to provide a better fix, but just reverting those things doesnt seem like a good idea specialyl when we want to make a release soon.
20160719 10:57:11< gfgtdf> celmin|sleep, bumbadadabum: sintrsings to integers, liek in rand("1,1,1,3")
20160719 10:57:41-!- Duthlet [~Duthlet@dslb-188-106-027-209.188.106.pools.vodafone-ip.de] has joined #wesnoth-dev
20160719 10:59:40< vultraz> i still think we should sync individual actions
20160719 11:00:18-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has joined #wesnoth-dev
20160719 11:02:03-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160719 11:02:54< zookeeper> i have nothing against the scenario_end events (which should usually be written without the underscore, just like other event types), but of course that [proceed_to_next_scenario] hack is quite terrible.
20160719 11:04:44< gfgtdf> zookeeper: any onion in changing the condition of when victory even is fired to "when any human is victorious" ? This woudl only effect non-coop mp games that use victory events.
20160719 11:05:10< gfgtdf> zookeeper: which i know noe of.
20160719 11:05:52< gfgtdf> nonwe*
20160719 11:06:18< zookeeper> i don't really understand the underlying issue enough
20160719 11:07:23< gfgtdf> zookeeper: well yes i dont liek it that muhc eigher, but id'd rather whip 1.13.5 with some hacky campaign code than with posible bugs in them..
20160719 11:07:33< gfgtdf> zookeeper: well i think i'll just do what i suggested above
20160719 11:15:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160719 11:15:43< zookeeper> well, now that i re-read parts of the previous discussion, maybe i understand it again
20160719 11:16:22< irker576> wesnoth: gfgtdf wesnoth:master 084dfc9887c9 / src/playsingle_controller.cpp: make victory event fire on proceed_to_nextlevel https://github.com/wesnoth/wesnoth/commit/084dfc9887c96b3bc1f238123a97356af1659751
20160719 11:17:27< zookeeper> and i'm inclined to say that the underlying issue of different numbers of units created on different clients necessarily leading to OOS needs to be fixed sooner or later
20160719 11:17:50< irker576> wesnoth: gfgtdf wesnoth:master d43e5ad8bc32 / src/playsingle_controller.cpp: fix compilation https://github.com/wesnoth/wesnoth/commit/d43e5ad8bc3233935c146068cf3f739a1aa982ac
20160719 11:17:56< vultraz> yes, I keep saying just sync actions like [unit]!
20160719 11:19:56< gfgtdf> zookeeper, vultraz coudl you give a concrete example of code that currently doesnt work but that should work ?
20160719 11:20:10-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160719 11:23:45< zookeeper> hmh.
20160719 11:23:47 * zookeeper tries
20160719 11:27:51-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20160719 11:34:32< zookeeper> gfgtdf, well, this is via a menu item, but i think that shouldn't matter in this case... http://pastebin.com/ADHCcZsQ
20160719 11:34:46< zookeeper> incidentally, i get an assert when i trigger that, undo, and then redo
20160719 11:35:41< zookeeper> i only tried it in SP, but since it's undoable, it should presumably OOS in MP
20160719 11:37:13< gfgtdf> zookeeper: hmm i currently dont see why it shodul give assertio failures or OOS (note that the unit id cpunter is reset when undoing a move), what exactly does the assertion message say?
20160719 11:37:33< zookeeper> oh, right, i didn't realize it gets reset
20160719 11:37:41< zookeeper> in that case i guess it wouldn't OOS after all
20160719 11:38:33< zookeeper> replay.cpp:484 expression: dst.empty()
20160719 11:38:40< zookeeper> (and it actually required undo, redo, undo)
20160719 11:38:54-!- travis-ci [~travis-ci@ec2-107-22-44-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20160719 11:38:55< travis-ci> wesnoth/wesnoth#9855 (master - 084dfc9 : gfgtdf): The build was broken.
20160719 11:38:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/145793623
20160719 11:38:56-!- travis-ci [~travis-ci@ec2-107-22-44-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20160719 11:43:09< zookeeper> so, i guess a proper example would need a select or preload event
20160719 11:43:27-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160719 11:44:20< gfgtdf> zookeeper: hmm but then the unit id counter wouldnt be used at all since the unsynced it counter woudl be used.
20160719 11:45:52< zookeeper> right
20160719 11:46:36< irker576> wesnoth: gfgtdf wesnoth:master ca1811228a23 / src/actions/undo_action.hpp: fix asserion failure when redoing and undoing menu actions. https://github.com/wesnoth/wesnoth/commit/ca1811228a2383acce85565fe89c6c7beb0bee24
20160719 11:46:40< gfgtdf> zookeeper: try that ^
20160719 11:46:54< zookeeper> i can't
20160719 11:47:04< gfgtdf> zookeeper: why?
20160719 11:47:07< zookeeper> i can't compile
20160719 11:47:31< gfgtdf> zookeeper: hmm did you you try to cmpile boost yourself?
20160719 11:48:15< zookeeper> no, bound to be too complicated
20160719 11:50:43< gfgtdf> zookeeper: actuall i dont think its that complicated
20160719 11:50:44-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160719 11:56:29< zookeeper> regarding "fire victory event when any human is victorious", i can't really say whether it's better or worse than just keeping it unsynced and telling MP campaign authors to use the scenario end event instead for things that should be synced
20160719 11:57:08< zookeeper> what about defeat, though? if victory events will now fire even for defeated human players, do defeat events _not_ fire for them? (or did they ever?)
20160719 12:02:34< gfgtdf> zookeeper: defat event is fireren when the gane ends and teh victory event is not fired
20160719 12:02:56< zookeeper> right, okay
20160719 12:04:42< zookeeper> i don't see a problem with that as long as the events are documented accordingly, if we actually stick with that behavior and not change it again
20160719 12:11:39-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 276 seconds]
20160719 12:18:03-!- Kwandulin [~Miranda@p200300760F2D8127B5989835C4F4D5B6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160719 12:31:33-!- travis-ci [~travis-ci@ec2-54-242-124-15.compute-1.amazonaws.com] has joined #wesnoth-dev
20160719 12:31:34< travis-ci> wesnoth/wesnoth#9857 (master - ca18112 : gfgtdf): The build was fixed.
20160719 12:31:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/145799502
20160719 12:31:34-!- travis-ci [~travis-ci@ec2-54-242-124-15.compute-1.amazonaws.com] has left #wesnoth-dev []
20160719 12:49:41-!- gfgtdf [~chatzilla@x4e36aec1.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160719 13:24:59-!- Kwandulin [~Miranda@p200300760F2D8127B5989835C4F4D5B6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160719 13:26:13-!- edgrey [~edgrey@178.204.10.103] has quit [Remote host closed the connection]
20160719 13:26:37-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 13:28:33-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has quit [Ping timeout: 240 seconds]
20160719 13:30:55< irker576> wesnoth: Gregory A Lundberg wesnoth:master a83912483916 / data/campaigns/An_Orcish_Incursion/scenarios/ (7 files): AOI Linaera should recruit Mages, not Elves https://github.com/wesnoth/wesnoth/commit/a83912483916f1dd3fcb546cd764a32c6cc85ce2
20160719 13:30:57< irker576> wesnoth: Gregory A Lundberg wesnoth:master 13737dc10fde / data/campaigns/An_Orcish_Incursion/ (3 files in 2 dirs): AOI Move extra_recruit to character macros https://github.com/wesnoth/wesnoth/commit/13737dc10fde7fc9353c45d75a7ceff827e0b130
20160719 13:30:59< irker576> wesnoth: Gregory A Lundberg wesnoth:master 4e75868bf655 / changelog: AOI Update changelog https://github.com/wesnoth/wesnoth/commit/4e75868bf655877f2459046b5480e3e28675bb18
20160719 13:31:01< irker576> wesnoth: Lari Nieminen wesnoth:master b02e08406475 / / (9 files in 3 dirs): Merge pull request #690 from GregoryLundberg/GL_AOI_recruit_mages https://github.com/wesnoth/wesnoth/commit/b02e084064752b224595bad94fa8c1d64fcc2296
20160719 13:31:55< irker576> wesnoth: Gregory A Lundberg wesnoth:master 5bb6aa553668 / data/campaigns/Liberty/ (7 files in 2 dirs): L Fix bugs and tidy up a bit https://github.com/wesnoth/wesnoth/commit/5bb6aa55366883daa21652208931ab128fad1906
20160719 13:31:57< irker576> wesnoth: Gregory A Lundberg wesnoth:master 3818fe232687 / data/campaigns/Liberty/scenarios/08_Glory.cfg: L Illogical conversation https://github.com/wesnoth/wesnoth/commit/3818fe232687ce3d1d336c565f31a1de3e1af02c
20160719 13:31:59< irker576> wesnoth: Gregory A Lundberg wesnoth:master dad9d8f6c8cf / data/campaigns/Liberty/scenarios/ (02_Civil_Disobedience.cfg 03_A_Strategy_Of_Hope.cfg 04_Unlawful_Orders.cfg): L Fix the Advisor role https://github.com/wesnoth/wesnoth/commit/dad9d8f6c8cf2679c5389a2f5fd888e29153b0c2
20160719 13:32:01< irker576> wesnoth: Lari Nieminen wesnoth:master 849cacceb16f / data/campaigns/Liberty/ (8 files in 2 dirs): Merge pull request #699 from GregoryLundberg/GL_L_final https://github.com/wesnoth/wesnoth/commit/849cacceb16f017186c36d4cd55e2cda8940ee4e
20160719 13:34:01-!- edgrey [~edgrey@178.204.10.103] has quit [Ping timeout: 258 seconds]
20160719 13:36:45-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 13:37:22-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160719 13:53:29-!- edgrey [~edgrey@178.204.10.103] has quit [Remote host closed the connection]
20160719 13:55:58-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 14:02:52< irker576> wesnoth: Charles Dang wesnoth:master 34d78f2a2a46 / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projfile https://github.com/wesnoth/wesnoth/commit/34d78f2a2a464953bedd1d9ee3bb236f9fc559b5
20160719 14:03:37< vultraz> celmin|sleep: https://github.com/Vultraz/wesnoth/commit/c0ddc51cde8c279422bef5133ad724813efa54f7
20160719 14:04:50< vultraz> celmin|sleep: leave github comments, as usual
20160719 14:06:23< vultraz> (you'll probably want to look at it with split view)
20160719 14:07:03-!- louis94 [~~louis94@91.178.241.209] has quit [Ping timeout: 264 seconds]
20160719 14:07:45-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 14:11:56-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160719 14:24:58-!- gfgtdf [~chatzilla@x4e36aec1.dyn.telefonica.de] has joined #wesnoth-dev
20160719 14:25:25< gfgtdf> vultraz: if ou are alread at it, i think it might make sense to remove the 'typedef map_location location;' line and just use map_location directly
20160719 14:26:05< vultraz> hm, yes
20160719 14:35:45< vultraz> gfgtdf: done
20160719 14:35:51< vultraz> gfgtdf, celmin|sleep: made this a PR https://github.com/wesnoth/wesnoth/pull/704
20160719 14:49:36-!- louis94 [~~louis94@91.178.241.209] has quit [Ping timeout: 276 seconds]
20160719 14:58:48-!- edgrey [~edgrey@178.204.10.103] has quit [Ping timeout: 250 seconds]
20160719 15:02:35-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 15:12:02-!- JyrkiVesterinen [~JyrkiVest@87-100-232-27.bb.dnainternet.fi] has quit [Quit: .]
20160719 15:40:01-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160719 15:42:16-!- edgrey [~edgrey@178.204.10.103] has quit [Remote host closed the connection]
20160719 15:44:29-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 16:01:00-!- gfgtdf [~chatzilla@x4e36aec1.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160719 16:01:21-!- edgrey [~edgrey@178.204.10.103] has quit [Quit: Konversation terminated!]
20160719 16:02:38-!- mjs-de [~mjs-de@x4e314456.dyn.telefonica.de] has joined #wesnoth-dev
20160719 16:09:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160719 16:11:23-!- edgrey [~edgrey@178.204.10.103] has joined #wesnoth-dev
20160719 16:11:44-!- JyrkiVesterinen [~JyrkiVest@87-92-25-109.bb.dnainternet.fi] has joined #wesnoth-dev
20160719 16:37:43-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 16:49:07< bumbadadabum> vultraz, celmin|sleep: I tried the helper.rand thing
20160719 16:49:16< bumbadadabum> can either of you look and see if I'm being very sloppy with the code
20160719 16:49:22< bumbadadabum> my lua is rusty as balls
20160719 17:01:11-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 17:02:56-!- irker576 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160719 17:06:17-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 17:06:43-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 17:08:23< celmin|sleep> Ugh, gfgtdf added that ridiculous local_victory event.
20160719 17:08:39< celmin|sleep> bumbadadabum: Where do I look?
20160719 17:09:18< bumbadadabum> celmin|sleep: http://hastebin.com/ayecilutim.lua
20160719 17:09:22< bumbadadabum> mostly copied from set_variable
20160719 17:12:01< celmin|sleep> Oh right, ranges were indicated by .. not -
20160719 17:14:38-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160719 17:16:57< celmin|sleep> It seems to look fine.
20160719 17:18:09-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 17:24:21< bumbadadabum> ok I'll test it more
20160719 17:24:23< bumbadadabum> and push if it works
20160719 17:24:44-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 17:25:12< bumbadadabum> I'm currently tackling a problem in my own lua code though
20160719 17:33:04-!- louis94 [~~louis94@91.178.241.209] has quit [Ping timeout: 250 seconds]
20160719 17:33:49-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160719 17:42:49-!- iwaim_ [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 252 seconds]
20160719 17:43:11-!- iwaim_ [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20160719 17:46:10< bumbadadabum> celmin|sleep: Oops I forgot arrays in lua start with [1]
20160719 17:46:44-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 17:48:59< bumbadadabum> tested, it works now
20160719 17:49:00-!- irker291 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160719 17:49:00< irker291> wesnoth: Bär Halberkamp wesnoth:master 1d8d843a80ef / data/lua/ (helper.lua wml-tags.lua): move set_variable.rand's logic to helper.rand https://github.com/wesnoth/wesnoth/commit/1d8d843a80efe3285ae586d52514cd0afe87c6c5
20160719 17:49:24< bumbadadabum> now to figure out why the fuck my if-statement isn't working
20160719 17:50:02-!- celmin|sleep is now known as celticminstrel
20160719 17:50:19-!- Shiki [~Shiki@141.39.226.227] has quit [Ping timeout: 244 seconds]
20160719 17:50:46-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160719 17:51:32< bumbadadabum> celticminstrel: if string.find(wesnoth.get_terrain(tile[1], tile[2]), '^F')
20160719 17:51:36< bumbadadabum> this is always false
20160719 17:51:53< bumbadadabum> even if there's "^F" in the terrain string
20160719 17:51:54< celticminstrel> ?
20160719 17:51:57< bumbadadabum> well, nil rather
20160719 17:52:01< bumbadadabum> do you know why
20160719 17:52:20< celticminstrel> Does find use the pattern syntax? Try searching '%^F' instead.
20160719 17:52:48< celticminstrel> A pattern beginning with ^ means "match the following only at the beginning".
20160719 17:53:14< celticminstrel> % is the escape character.
20160719 17:54:47-!- Kwandulin [~Miranda@p200300760F2D81274C2CF7AAE933B3CE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160719 17:56:59-!- gfgtdf [~chatzilla@x4e36aec1.dyn.telefonica.de] has joined #wesnoth-dev
20160719 17:58:00< bumbadadabum> that... makes a lot of sense
20160719 18:00:01< celticminstrel> JyrkiVesterinen: If you fixup the VS file as per gfgtdf's comment, I can merge it right away.
20160719 18:01:24< JyrkiVesterinen> OK, I'll fix it. (Too bad that it's not as easy as merely adding the new source code files in the Visual Studio GUI...)
20160719 18:01:56< celticminstrel> I assume you can get the effect in the GUI, maybe by going to file properties or something.
20160719 18:07:50< celticminstrel> vultraz: I'm commenting on your PR right now.
20160719 18:08:15< JyrkiVesterinen> gfgtdf's comment addressed.
20160719 18:08:56< irker291> wesnoth: Jyrki Vesterinen wesnoth:master a8c3bac31f80 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project files (#706) https://github.com/wesnoth/wesnoth/commit/a8c3bac31f803023715fa89fdb61d369dd134988
20160719 18:10:35< JyrkiVesterinen> On closer look, you're right. The object file path can be set in Properties -> C/C++ -> Output Files -> Object File Name.
20160719 18:10:48< JyrkiVesterinen> I'll use that method in the future if I don't forget.
20160719 18:20:18-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160719 18:22:27< celticminstrel> vultraz: It's kinda hard to review your PR due to reindentation and moving chunks around...
20160719 18:26:57-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 260 seconds]
20160719 18:27:34< celticminstrel> vultraz: I think the biggest issue stems from trying to pack too many changes into one commit.
20160719 18:28:02< celticminstrel> The reindentation issue is easily solved, but the solution makes my comments disappear, so I'll re-review it a second time with that.
20160719 18:30:32< celticminstrel> (For reference, the solution is adding ?w=1 to the end of the URL.)
20160719 18:32:20< celticminstrel> Heh, it drastically reduces the diff size, too.
20160719 18:33:17< celticminstrel> But I can't make comments on that form, unfortunately...
20160719 18:41:14-!- prkc [~prkc@46.166.188.222] has joined #wesnoth-dev
20160719 18:42:01-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 18:47:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160719 18:47:13-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 18:51:56-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Ping timeout: 250 seconds]
20160719 18:59:03-!- louis94 [~~louis94@91.178.241.209] has quit [Ping timeout: 240 seconds]
20160719 19:01:31-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 19:06:03-!- louis94 [~~louis94@91.178.241.209] has quit [Ping timeout: 240 seconds]
20160719 19:23:08-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160719 19:24:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160719 19:25:41-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has joined #wesnoth-dev
20160719 19:32:20-!- molt [~molt@46.161.114.253] has joined #wesnoth-dev
20160719 19:33:20-!- molt [~molt@46.161.114.253] has quit [Client Quit]
20160719 19:33:40-!- molt [~molt@46.161.114.253] has joined #wesnoth-dev
20160719 19:40:06-!- Kwandulin [~Miranda@p200300760F2D81274C2CF7AAE933B3CE.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160719 19:49:38< celticminstrel> Anyone have objections to me merging PR705?
20160719 19:50:25< gfgtdf> celticminstrel: that function shoudol write to the outtream argument and not to std:cout
20160719 19:50:43< celticminstrel> gfgtdf: Oh wow, you're right.
20160719 19:50:59< celticminstrel> However, that was already an issue, and I was asking because I planned to do additional changes there.
20160719 19:52:59< celticminstrel> So it shouldn't be a blocker for merging.
20160719 19:53:10-!- molt [~molt@46.161.114.253] has quit [Quit: Leaving]
20160719 19:59:17-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 20:04:44-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Ping timeout: 250 seconds]
20160719 20:08:57-!- JyrkiVesterinen [~JyrkiVest@87-92-25-109.bb.dnainternet.fi] has quit [Quit: Going to bed]
20160719 20:15:58-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 20:19:41-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160719 20:19:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160719 20:34:51< celticminstrel> ...I just noticed this, but why the heck are the translatable directions "North East" instead of "Northeast" and similar?
20160719 20:36:01-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Read error: Connection reset by peer]
20160719 20:38:10-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 20:44:14-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160719 20:47:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160719 20:47:37-!- wedge010 is now known as wedge009
20160719 20:48:27-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 20:55:43-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160719 20:56:33-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 21:09:24-!- irker291 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160719 21:09:48-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160719 21:20:55-!- atarocch [~atarocch@151.64.77.13] has quit [Remote host closed the connection]
20160719 21:22:18-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 21:23:51-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 264 seconds]
20160719 21:26:03-!- louis94 [~~louis94@91.178.241.209] has quit [Ping timeout: 240 seconds]
20160719 21:27:38< Aginor> everything still looking good in terms of stability after we merged the event handling changes?
20160719 21:27:51< Aginor> stability and focusing :D
20160719 21:28:10< celticminstrel> Aginor: Okay if I merge PR7505
20160719 21:28:13< celticminstrel> ^?
20160719 21:28:20< celticminstrel> ^705
20160719 21:28:33< celticminstrel> I see, I forgot to account for the ? when pressing backspace. Whoops.
20160719 21:32:00 * celticminstrel impatience
20160719 21:35:39< Aginor> celticminstrel: I haven't looked at it
20160719 21:35:44-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has quit [Ping timeout: 272 seconds]
20160719 21:35:58< Aginor> celticminstrel: and I'm at work now, etc
20160719 21:36:04< celticminstrel> Blargh.
20160719 21:36:12< Aginor> celticminstrel: I'll try to remember to look tonight
20160719 21:36:24< celticminstrel> If it's not already merged.
20160719 21:36:27 * celticminstrel pokes vultraz 
20160719 21:36:41< celticminstrel> It's nothing big, I just want at least a second approval first.
20160719 21:36:56< celticminstrel> Mainly because release could be close.
20160719 21:37:15< celticminstrel> I guess it's code mainly meant for debugging, so maybe I don't need to worry so much...
20160719 21:37:43< Aginor> celticminstrel: assign it to me and I'll look tonight
20160719 21:37:55< Aginor> celticminstrel: and I can merge it if I'm happy
20160719 21:38:11< Aginor> I thought we're targeting release for this weekend anyway
20160719 21:38:22< celticminstrel> I already merged it to my local copy and added more tweaks to the same code area.
20160719 21:40:05-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 21:40:27< Aginor> celticminstrel: should those same tweaks be added to the PR?
20160719 21:40:28-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: ancestral]
20160719 21:40:46< Aginor> celticminstrel: if you're running different code locally, you're not really testing that code either ;)
20160719 21:40:54< Aginor> you may have fixed or introduced new bugs in it
20160719 21:41:08< celticminstrel> The PR was mainly about compiler warnings, and it just got me (and gfgtdf) to notice other things that could be done there.
20160719 21:41:32< Aginor> if you think it's good, add it all to the PR ;)
20160719 21:41:51< celticminstrel> It's not my PR, so I can't.
20160719 21:42:15< Aginor> right
20160719 21:42:24< Aginor> raise a new PR?
20160719 21:42:48< celticminstrel> That seems kinda silly for this... I suppose I could though...
20160719 21:42:49< Aginor> the original author should still have the committs in your branch unless you went and squashed them
20160719 21:44:56< celticminstrel> Sigh, fine.
20160719 21:46:38< Aginor> hmm
20160719 21:47:00-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 21:47:04< celticminstrel> I guess you do have a point, anyway.
20160719 21:47:11< Aginor> I should take the time to play some wesnoth tonight too
20160719 21:47:23< Aginor> pre-release testing and all of that
20160719 21:52:17-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160719 21:52:33< celticminstrel> So it's now 707.
20160719 21:52:53-!- edgrey [~edgrey@178.204.10.103] has quit [Remote host closed the connection]
20160719 21:54:37-!- louis94 [~~louis94@91.178.241.209] has joined #wesnoth-dev
20160719 21:57:11-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160719 21:58:33< Aginor> thanks celticminstrel 
20160719 21:58:39< Aginor> and sorry ;)
20160719 21:58:45< Aginor> (I'm not really)
20160719 21:58:59< celticminstrel> Probably for the best.
20160719 21:59:54< Aginor> uff, lots of changes
20160719 22:00:04-!- Shiki [~Shiki@141.39.226.227] has left #wesnoth-dev ["Verlassend"]
20160719 22:00:09< celticminstrel> ?
20160719 22:02:16< Aginor> I looked at the notification email ;)
20160719 22:02:38< celticminstrel> It's not that much, is it?
20160719 22:03:01< celticminstrel> Oh right, there was the MAKE_ENUM thing which cascaded into quite a few places.
20160719 22:05:06-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 22:15:28-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160719 22:15:45-!- mjs-de [~mjs-de@x4e314456.dyn.telefonica.de] has quit [Remote host closed the connection]
20160719 22:19:09< Aginor> I haven't looked at the code at all
20160719 22:19:25< Aginor> the email just listed some numbers that added up to 300loc or so
20160719 22:19:54< Aginor> which reminds me that I was meaning to look at the monte carlo simulation too
20160719 22:21:05< celticminstrel> Good idea.
20160719 22:23:22< vultraz> celticminstrel: yes?
20160719 22:25:15< vultraz> celticminstrel: just saw your comments
20160719 22:25:17< vultraz> thanks
20160719 22:26:11-!- Appleman1234 [~Appleman1@KD036012045012.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160719 22:36:50-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has joined #wesnoth-dev
20160719 22:44:05< vultraz> celticminstrel: pushed another commit addressing some of your issues
20160719 22:47:58-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160719 22:51:09-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 22:57:02-!- RatArmy [~RatArmy@om126229088073.12.openmobile.ne.jp] has quit [Ping timeout: 260 seconds]
20160719 23:01:38-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160719 23:03:44-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160719 23:14:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20160719 23:17:23-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 23:21:05< Aginor> vultraz: "\t" is the tab-character
20160719 23:21:12< vultraz>  I see
20160719 23:23:39< celticminstrel> Well, I guess there's no new problems. The goto is as dubious as before though.
20160719 23:24:59-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 23:25:57-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 23:28:02-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 23:31:15-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has joined #wesnoth-dev
20160719 23:32:46-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18a2:ee84:98b7:2bb6] has quit [Remote host closed the connection]
20160719 23:45:57< gfgtdf> vultraz: what was teh reason for that goto change in the first place?
20160719 23:46:12< vultraz> reduce a level of indent
20160719 23:46:35< celticminstrel> I think I did mention an alternate way to achieve that.
20160719 23:46:52< gfgtdf> vultraz: i think thats sureley not enough reason to use such things.
20160719 23:47:44< Aginor> I'm unhappy about gotos
20160719 23:47:53< vultraz> why does everyone hate gotos 
20160719 23:48:04< Aginor> I don't, but they have a time and place
20160719 23:48:11< Aginor> in c++, mostly not
20160719 23:48:25< Aginor> in plan c, sure, they are useful for error-handling and cleanup
20160719 23:48:26< vultraz> I mean, I'll probably just make it a function or wrap it in the if block again, but I'm curious why such a feature is considered bad practice
20160719 23:49:08< Aginor> http://stackoverflow.com/questions/3517726/what-is-wrong-with-using-goto
20160719 23:49:37< Aginor> and the possible duplicates
20160719 23:51:18< celticminstrel> One person says goto can jump between functions. I'm pretty sure this is not true.
20160719 23:52:23< iceiceice> yes, that is definitely not true
20160719 23:52:30< gfgtdf> celticminstrel: c has longjmp which can do simethign similar
20160719 23:52:47< celticminstrel> I know gfgtdf, but it's not the same, only similar.
20160719 23:52:50< iceiceice> the only time i ever saw a reason to use goto, is when dealing with longjmp
20160719 23:53:14< iceiceice> when you use longjmp you need to make sure there are no automatic objects on the stack
20160719 23:53:22< iceiceice> because it will skip the destructors
20160719 23:53:32< iceiceice> and you can work around that by using goto to jump away from them
20160719 23:53:37< iceiceice> but its prettyugly
20160719 23:53:39< celticminstrel> Naturally this is not a problem in C.
20160719 23:53:43< iceiceice> yeah
20160719 23:53:55< iceiceice> i dont think you should ever use goto for actual flow control
20160719 23:54:06< celticminstrel> Wait, you mean you can use goto to force destructor calls?
20160719 23:54:07< iceiceice> you should probably just refactor your function if you are tempted to do that
20160719 23:54:13< iceiceice> yeah
20160719 23:54:15< iceiceice> you can have like
20160719 23:54:21< celticminstrel> I think goto for exiting nested loops is acceptable.
20160719 23:54:45< celticminstrel> It's the one case that Java and some other languages allow, after all.
20160719 23:54:46< iceiceice> if (auto ptr = some_smart_ptr()) { do a bunc h of stuff; if (time_to_long_jump) { goto end; } }
20160719 23:54:52< iceiceice> end: longjmp(...)
20160719 23:55:08< iceiceice> you can jump out of the scope but you cant jump out of the function
20160719 23:55:18< celticminstrel> Makes sense.
20160719 23:55:26< iceiceice> i think usually you should use "break" for that
20160719 23:55:34< celticminstrel> Nested loops.
20160719 23:55:44< iceiceice> idk
20160719 23:55:49< iceiceice> i guess i would prefer to do an early return
20160719 23:55:51< iceiceice> rather than a goto
20160719 23:56:05< celticminstrel> Like for(...) { for(..) { do_stuff(); goto end;} do_more_stuff(); } end: whatever
20160719 23:56:18< celticminstrel> Obviously with conditionals too.
20160719 23:56:33< celticminstrel> Early return can have the same effect if the loop is the sole content of a function, sure.
20160719 23:56:39< iceiceice> yeah,
20160719 23:56:41< celticminstrel> ^loops are
20160719 23:56:56< iceiceice> i guess usually i find that whatever it is i'm doing, i can refactor it into two funcitons, one of which uses early return
20160719 23:56:57< vultraz> I should probably write a utility function that handles the double x/y looping that happens a lot..
20160719 23:57:19< iceiceice> idk
20160719 23:57:31< iceiceice> goto is not that bad but it can make it harder to reason about the code, just slightly
20160719 23:58:07< vultraz> celticminstrel: ok, I removed the goto
20160719 23:58:09< vultraz> anything else?
--- Log closed Wed Jul 20 00:00:28 2016