--- Log opened Tue Jul 26 00:00:34 2016
20160726 00:02:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160726 00:14:10-!- gfgtdf [~chatzilla@x4e36ae7a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160726 00:17:21-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160726 00:18:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 00:21:39 * vultraz pings Aginor
20160726 00:21:53< vultraz> Aginor: any change that icon overlay issue could be fixed for the release?
20160726 00:21:56< vultraz> chance*
20160726 00:24:39< vultraz> celticminstrel: I saw you accepted the friend invite, but could you confirm that you indeed did so? Just to be safe.
20160726 00:24:52< celmin> Huh?
20160726 00:25:03< vultraz> The friend invite from wesnoth yesterday
20160726 00:25:04< celmin> I accepted it awhile ago.
20160726 00:25:10< vultraz> Ok, just wanted to be sure.
20160726 00:25:51< vultraz> I'll add you as a collab now
20160726 00:26:30-!- travis-ci [~travis-ci@ec2-54-91-68-140.compute-1.amazonaws.com] has joined #wesnoth-dev
20160726 00:26:31< travis-ci> wesnoth/wesnoth#9948 (boost_trimming - 9be7a6d : Charles Dang): The build was fixed.
20160726 00:26:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/147333746
20160726 00:26:31-!- travis-ci [~travis-ci@ec2-54-91-68-140.compute-1.amazonaws.com] has left #wesnoth-dev []
20160726 00:26:54< vultraz> YAY 
20160726 00:27:59< celmin> That's a lot of fixup commits.
20160726 00:28:33< vultraz> I'll merge them
20160726 00:29:15-!- vultraz changed the topic of #wesnoth-dev to: Feature freeze in effect. 1.13.5 scheduled for 7/31 or earlier pending blocker fixes | Greenlight Votes: 2901 Yes, 738 No, 62 AML | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160726 00:30:13< vultraz> added you as a collab
20160726 00:30:33< celmin> Was that just a votes update?
20160726 00:30:53< vultraz> Yes
20160726 00:41:45< irker879> wesnoth: Charles Dang wesnoth:boost_trimming 771936ad9544 / src/tests/ (test_commandline_options.cpp test_formula_core.cpp test_mp_connect.cpp): Update unit tests https://github.com/wesnoth/wesnoth/commit/771936ad954428569b328eb5cdf9d0437bd88aa5
20160726 01:05:46-!- Bonobo [~Bonobo@2001:44b8:254:3200:25e6:fb8b:4b0b:900c] has joined #wesnoth-dev
20160726 01:07:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 01:10:44< bumbadadabum> when was the UI for the help changed actualy
20160726 01:10:46< bumbadadabum> *actually
20160726 01:11:09< bumbadadabum> er... I don't want to sound mean but I don't think it looks by far as good as it is in 1.12
20160726 01:11:17< bumbadadabum> it looks very... alpha
20160726 01:11:19< celmin> Huh? Isn't Help UI one of the few things that wasn't changed?
20160726 01:11:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160726 01:11:45< celmin> I guess the font did change...
20160726 01:13:33< bumbadadabum> well it's probably been looooong ago?
20160726 01:13:40< bumbadadabum> but I've been out for a while
20160726 01:13:49< celmin> You were just comparing to 1.12 though.
20160726 01:14:08< bumbadadabum> yeah, but since 1.12 there have been years of changes
20160726 01:14:28< celmin> Wasn't 1.12 like a year ago?
20160726 01:14:34< bumbadadabum> 2014
20160726 01:15:01< bumbadadabum> like the oversized sprite kinda looks placeholder
20160726 01:15:12< bumbadadabum> the lack of borders on the portraits make everything way more chaotic
20160726 01:15:16< celmin> Okay, so two years ago.
20160726 01:15:18< bumbadadabum> traits don't get autogenerated help topics
20160726 01:15:26< bumbadadabum> I might try to look at it myself
20160726 01:15:26< celmin> Oh, right, some changes were made to how portraits are shown in help.
20160726 01:15:53< celmin> I don't know any reason why trait topics would've vanished.
20160726 01:16:19< celmin> The oversized sprite seems to be deliberate. I dunno why.
20160726 01:16:25< celmin> That wasn't me.
20160726 01:17:13< bumbadadabum> https://github.com/wesnoth/wesnoth/blob/master/data/core/help.cfg#L31
20160726 01:17:13< bumbadadabum> hm
20160726 01:17:30< bumbadadabum> this does make it so UMC traits don't show up
20160726 01:17:36< bumbadadabum> and have deadlinks in the unit topics
20160726 01:17:56< celmin> Oh.
20160726 01:18:42< celmin> Was that not originally the case?
20160726 01:19:24< bumbadadabum> no
20160726 01:19:26< celmin> It appears that the trait topics are hard-coded into that file, which is pretty silly.
20160726 01:20:16 * celmin wonders how the text was unsuitable
20160726 01:26:15< bumbadadabum> yeah idk either
20160726 01:26:20< bumbadadabum> they're generated in the tooltip, right?
20160726 01:26:59< bumbadadabum> I'll look more into in over the course of the next few weeks
20160726 01:28:18< celmin> There was something I planned to do that would also touch that area, though it's not directly related.
20160726 01:35:45< bumbadadabum> I'll look at the portraits and sprites in the help as well
20160726 01:35:49< bumbadadabum> upscaling is never good imo
20160726 01:57:09< Aginor> vultraz: I haven't looked at it
20160726 02:18:13-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160726 02:32:55< ancestral> vultraz: Okay, I should have a binary that fixes that problem
20160726 02:35:02< celmin> Oh?
20160726 02:35:18< celmin> Earlier someone suggested changing the offending bind statements to use lambdas instead of bind.
20160726 02:35:20< ancestral> With the library crash on startup
20160726 02:35:27< celmin> Oh, something else.
20160726 02:35:37< ancestral> I don’t have any insight on the bind issue
20160726 02:35:41< ancestral> I’m afraid
20160726 02:36:01< celmin> Like I just said, you could try changing them to lambdas.
20160726 02:36:17< ancestral> Sure?
20160726 02:36:32< ancestral> Sorry, I’m not very helpful when it comes to coding tasks even of the easiest kind
20160726 02:36:49< celmin> Well, if you repost the list of offending statements, I suppose I could do it...
20160726 02:38:26< ancestral> Or tell me the exact syntax
20160726 02:39:00< ancestral> I’m uploading the current binary
20160726 02:39:03< ancestral> For test
20160726 02:39:16< ancestral> Once that is done, I’ll git pull and then we’ll try this over again
20160726 02:39:39< ancestral> vultraz: Seems like we’re solidly 4:1 Yes to No
20160726 02:39:45< celmin> The syntax for a lambda is [](arguments) {content}
20160726 02:39:55< ancestral> Which is fantastic, given it’s probably in people’s queues
20160726 02:39:59< celmin> Stuff can go in the square brackets too.
20160726 02:40:37< celmin> To convert bind to lambda you'd need to look up the definition of the function being bound.
20160726 02:41:37< celmin> eg, for std::bind(&some_function, some_value, _1, _2) you would need to look up some_function and take its second and third parameters, making those the first and second parameters of the lambda. Then the body of the lambda would be some_fuction(some_value, arg1, arg2);
20160726 03:04:47< ancestral> Our bot doesn’t monitor changes to Gna, eh?
20160726 03:05:29< ancestral> celmin: Can you try running this please? https://gna.org/bugs/index.php?24541#comment6
20160726 03:30:47-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Remote host closed the connection]
20160726 03:31:03-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160726 03:34:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160726 03:39:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 03:40:44< celmin> Almost finished...
20160726 03:40:58< celmin> Took ~10 minutes to download and forever to extract.
20160726 03:44:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160726 03:45:01-!- edgrey [~edgrey@178.204.239.170] has quit [Ping timeout: 252 seconds]
20160726 03:45:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160726 03:45:54< celmin> Bad libcairo.
20160726 03:46:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160726 03:46:21< celmin> It's referencing CoreGraphics with an incorrect path.
20160726 03:47:10< ancestral> Thank you
20160726 03:47:17< ancestral> Baf libcairo interesting
20160726 03:47:20< celmin> I expect it'll work on newer systems.
20160726 03:47:26< celmin> Like 10.9 or so and up.
20160726 03:47:38< ancestral> Can you give me the crash report?
20160726 03:47:46< ancestral> Or the dyld line error?
20160726 03:48:00< ancestral> With the paths
20160726 03:48:13< celmin> Yeah
20160726 03:49:46< celmin>   Library not loaded: /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
20160726 03:49:47< celmin>   Referenced from: /Users/USER/Downloads/Wesnoth.app/Contents/MacOS/../Frameworks/libcairo.2.dylib
20160726 03:50:15< ancestral> Interesting
20160726 03:50:37< ancestral> Is there a line before or after those?
20160726 03:51:01< celmin> Before is just "Dyld Error Message:", after is "  Reason: image not found"
20160726 03:51:53< ancestral> Do you have /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics
20160726 03:52:46< celmin> No, for me it's at /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworls/CoreGraphics.framework/Versions/A/CoreGraphics
20160726 03:52:59< ancestral> Hmmm
20160726 03:53:03< celmin> CoreText is also in that place.
20160726 03:53:17< celmin> Oh, I misspelled Frameworks in the path.
20160726 03:53:25< ancestral> np
20160726 03:53:56< ancestral> Okay
20160726 03:54:04< ancestral> So that aliases to my location
20160726 03:54:10< celmin> Hm?
20160726 03:54:11< ancestral> So that means I should ref it to here
20160726 03:54:25< celmin> So using the old path would still work on the latest OSX?
20160726 03:54:30< ancestral> Correct
20160726 03:54:33< celmin> Convenient...
20160726 03:55:10< ancestral> Do you have /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit ?
20160726 03:55:30< celmin> I have AppKit.framework there, lemme dig into it...
20160726 03:55:43< celmin> Yeah, I have it.
20160726 03:56:10< ancestral> And: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
20160726 03:56:20< ancestral> And finally: /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
20160726 03:57:09< celmin> I have those.
20160726 03:57:21< celmin> I think it's only CoreGraphics and CoreText that have moved.
20160726 03:59:25< ancestral> celmin: Perhaps you can do me another favor?
20160726 03:59:30< celmin> Maybe.
20160726 03:59:43< ancestral> If you can navigate to that Frameworks directory in that bundle
20160726 03:59:50< ancestral> in the Terminal
20160726 03:59:58< ancestral> And then run this:
20160726 04:00:00< ancestral> sudo install_name_tool -change /System/Library/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics libcairo.2.dylib
20160726 04:00:38< celmin> …why sudo?
20160726 04:00:47< ancestral> Not sure, might not be necessary
20160726 04:01:11< ancestral> I was following instructions from somewhere online
20160726 04:01:46< ancestral> Okay, and CoreText…
20160726 04:01:52-!- JyrkiVesterinen [~JyrkiVest@87-100-222-225.bb.dnainternet.fi] has joined #wesnoth-dev
20160726 04:01:59< celmin> Might have to rerun that with CoreText or on other libs too… I'll let you know.
20160726 04:02:45< celmin> I'm getting missing CoreText from libpangocairo
20160726 04:03:26< ancestral> install_name_tool -change /System/Library/Frameworks/CoreText.framework/Versions/A/CoreText /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText libpangocairo-1.0.0.dylib
20160726 04:03:32< ancestral> That should fix that
20160726 04:03:37< celmin> Yeah, I'm ahead of you here. :P
20160726 04:03:47 * ancestral is crossing his fingers
20160726 04:04:02< celmin> Working now.
20160726 04:04:22< ancestral> Fantastic
20160726 04:04:23< celmin> Window showed, but then it "quit unexpectedly".
20160726 04:04:28< ancestral> Bah
20160726 04:04:44< ancestral> Relaunch, same thing, or?
20160726 04:04:46< celmin> Eh, this one looks super-annoying.
20160726 04:04:59< celmin> Dyld Error Message:
20160726 04:05:00< celmin>   Symbol not found: ___sincos_stret
20160726 04:05:01< celmin>   Referenced from: /Users/USER/Downloads/Wesnoth.app/Contents/MacOS/../Frameworks/libcairo.2.dylib
20160726 04:05:02< celmin>   Expected in: /usr/lib/libSystem.B.dylib
20160726 04:05:09< ancestral> Ooof
20160726 04:05:14< ancestral> So
20160726 04:05:21< ancestral> Maybe I need to revuild libcairo
20160726 04:05:23< ancestral> *rebuild
20160726 04:05:49< ancestral> This was from the last Mac Compile Stuff
20160726 04:06:08< celmin> Oh, you're using the same libcairo from that still?
20160726 04:06:17< ancestral> Well, I was starting clean
20160726 04:06:21< ancestral> “clean”
20160726 04:06:38< ancestral> Alright, I’ll rebuild more libraries
20160726 04:06:56< celmin> I hope this works out...
20160726 04:07:23< celmin> I imagine you'd ideally want to build it against 10.7 SDK, but I suppose you don't have that.
20160726 04:07:35< ancestral> I could maybe find one around somewhere
20160726 04:07:43 * celmin actually has SDKs from 10.4 up to 10.8… could probably delete most of those...
20160726 04:07:46< ancestral> Otherwise, if you have a working library set, I’ll take yours
20160726 04:07:55< celmin> Hmm.
20160726 04:08:09< celmin> I'm probably using the MacPorts version of libcairo.
20160726 04:08:16 * ancestral nods
20160726 04:08:30< celmin> And the same for pango.
20160726 04:09:14< celmin> I could try sending them to you. Not sure if they're viable for a "clean" system, but they do at least work on my computer.
20160726 04:10:17< ancestral> I’ll try rebuilding them, if you want to post them at some point somewhere, I wouldn’t say no
20160726 04:10:19< celmin> Speaking of pango, are there still binary libraries committed to the repo?
20160726 04:10:22< ancestral> Thanks for your help celmin
20160726 04:12:06< celmin> There are. Those shoud probably be removed.
20160726 04:12:23< celmin> projectfiles/XCode/Resources/pango/1.8.0/modules/
20160726 04:12:25< celmin> ^should
20160726 04:12:39< celmin> And included in the Mac Compiler package instead.
20160726 04:13:07< ancestral> Yeah
20160726 04:13:09< ancestral> Good point
20160726 04:13:14< celmin> vultraz: What the heck does AML mean?
20160726 04:13:22< ancestral> Ask Me Later?
20160726 04:13:33< celmin> Oh. That was an option?
20160726 04:13:48< ancestral> So there’s a queue in Steam
20160726 04:13:54< ancestral> Where you can see new stuff
20160726 04:14:10< celmin> Right, I've only looked at that a couple of times.
20160726 04:14:12< ancestral> And decide if you want to like it or not. I’m assuming it’s in that queue?
20160726 04:16:23< celmin> I just saw it now in the topic.
20160726 04:35:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 04:38:57-!- ggeneral [~ggeneral@46.211.1.127] has joined #wesnoth-dev
20160726 04:39:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160726 04:44:02-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: ancestral]
20160726 04:47:12-!- ggeneral [~ggeneral@46.211.1.127] has quit [Read error: Connection reset by peer]
20160726 04:49:27-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160726 04:52:44< vultraz> celticminstrel: yes, Ask Me Later
20160726 05:05:44-!- vultraz changed the topic of #wesnoth-dev to: Feature freeze in effect. 1.13.5 scheduled for 7/31 or earlier pending blocker fixes | Greenlight Votes: 3010 Yes, 770 No, 87 AML | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160726 05:05:53< vultraz> #29
20160726 05:10:12-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160726 05:31:37-!- Kwandulin [~Miranda@p200300760F6062875D7D006001871C2D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160726 05:39:12-!- Kwandulin [~Miranda@p200300760F6062875D7D006001871C2D.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160726 05:40:59-!- mjs-de [~mjs-de@x4e314a31.dyn.telefonica.de] has joined #wesnoth-dev
20160726 05:44:46-!- Kwandulin [~Miranda@p200300760F606287E4177E0300BE3E19.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160726 05:45:57-!- mjs-de [~mjs-de@x4e314a31.dyn.telefonica.de] has quit [Remote host closed the connection]
20160726 05:49:01< wedge009> vultraz: That's great!
20160726 05:51:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160726 06:21:03-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160726 06:23:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 06:27:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160726 06:38:11-!- ggeneral [~ggeneral@46.211.114.90] has joined #wesnoth-dev
20160726 06:49:55-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160726 06:58:30-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160726 07:03:12-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160726 07:18:18-!- celticminstrel is now known as celmin|sleep
20160726 07:18:48-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160726 07:29:13-!- JyrkiVesterinen [~JyrkiVest@87-100-222-225.bb.dnainternet.fi] has quit [Quit: .]
20160726 07:38:52-!- ggeneral [~ggeneral@46.211.114.90] has quit [Ping timeout: 260 seconds]
20160726 07:42:43-!- edgrey [~edgrey@178.204.47.221] has joined #wesnoth-dev
20160726 07:51:58-!- Appleman1234 [~Appleman1@KD036012033008.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20160726 07:52:40-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160726 07:53:55-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Read error: Connection reset by peer]
20160726 08:04:58< wedge009> Oath of Allegiance looks like a really fun way to introduce the Khalifate so far. Up to third scenario (playing normally), non-debug.
20160726 08:05:56-!- Duthlet [~Duthlet@dslb-188-105-122-010.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20160726 08:08:13< Kwandulin> wedge009: Urgh, I am close to releasing a big overhaul
20160726 08:08:25< wedge009> Kwandulin: Oh, should I have waited?
20160726 08:08:42< wedge009> Overhaul in what sense? Story? Game play? Both/neither?
20160726 08:08:45< Kwandulin> Yes, maybe 2-3 weeks
20160726 08:09:01< wedge009> Okay, I'll stop playing for now.
20160726 08:09:14< Kwandulin> There's many things that change
20160726 08:09:25< wedge009> I thought it was being considered for main-line release.
20160726 08:09:44< Kwandulin> I am just waiting for the release of 1.13.5 that'll fix some things I use in the overhaul
20160726 08:09:54< wedge009> No worries.
20160726 08:10:18< wedge009> I didn't encounter any bugs other than a warning after the first scenario 
20160726 08:10:31< wedge009> '<lua> Repeated [endlevel] execution, ignoring.'
20160726 08:11:01< Rhonda> Where do I find the greenlight thing in steam?
20160726 08:11:09< wedge009> Plus 'can not' is usually spelled as one word in English, unless the 'not' is supposed to be associated with a following word, rather than the 'can'.
20160726 08:11:42< Kwandulin> wedge009, alright I'll take these up into the to-do list
20160726 08:11:43< wedge009> Rhonda: I just found it from Community -> Greenlight -> Recent Submissions (View All)
20160726 08:11:54< wedge009> I don't know if there's a direct link.
20160726 08:11:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 08:12:11< Kwandulin> https://steamcommunity.com/sharedfiles/filedetails/?id=729138129 Rhonda
20160726 08:12:20< wedge009> There you go.
20160726 08:12:55< wedge009> vultraz: What's the Greenlight status now
20160726 08:12:57< wedge009> ?
20160726 08:13:26< Rhonda> voted. :)
20160726 08:13:31< wedge009> Whee!
20160726 08:14:00< wedge009> Kwandulin: Narfi is typical stubborn elf. Doesn't even think that there could be a reason for Ilriel wanting to stay with her captors. XD
20160726 08:14:06-!- vultraz changed the topic of #wesnoth-dev to: Feature freeze in effect. 1.13.5 scheduled for 7/31 or earlier pending blocker fixes | Greenlight Votes: 3079 Yes, 790 No, 87 AML | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160726 08:14:10< vultraz> #28
20160726 08:14:18< wedge009> Those riders made for good XP, though!
20160726 08:14:24< wedge009> Yay, thanks vultraz.
20160726 08:16:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160726 08:16:52< Rhonda> hmm, don't we have a donate option?  https://steamcommunity.com/workshop/filedetails/discussion/729138129/352788917756063293/
20160726 08:17:24< vultraz> No
20160726 08:17:27< Rhonda> Ah right, was a response already anyway. :)
20160726 08:17:36< Rhonda> Well, we have a paypal account, don't we.
20160726 08:18:16< vultraz> Dave said we could set up a Patreon
20160726 08:18:20< wedge009> Wonder what they don't like about the UI and whether 1.13.x helps any with their opinion.
20160726 08:18:28< Kwandulin> wedge009: Yes, that's something that'll change for example. In the current state, Ilriel leaves her elves too easily
20160726 08:18:45< wedge009> So story change too. No worries.
20160726 08:19:28< wedge009> Maybe the lady elves are just too compassionate. The same portrait is used for Cleodil so it reminds me of her.
20160726 08:19:49< wedge009> I haven't played campaigns for a while.
20160726 08:20:14< Kwandulin> I made a whole set of new portraits for the campaign
20160726 08:20:50< Kwandulin> They don't reach the high quality portraits of mainline, though
20160726 08:27:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160726 08:36:33< wedge009> Oh, that's all right. I suppose that was the other thing that seemed odd - without dedicated portraits, I think the tiny sprite icons were used by default. 
20160726 08:38:41-!- irker879 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160726 08:41:37-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160726 08:45:30-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160726 08:48:26-!- Appleman1234 [~Appleman1@KD036012036118.au-net.ne.jp] has joined #wesnoth-dev
20160726 09:05:05-!- JyrkiVesterinen [~JyrkiVest@87-100-151-187.bb.dnainternet.fi] has joined #wesnoth-dev
20160726 09:09:36-!- Kwandulin [~Miranda@p200300760F606287E4177E0300BE3E19.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160726 09:47:30-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160726 09:51:47-!- Kwandulin [~Miranda@p200300760F60622AADDEBE447F56FF44.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160726 09:56:56-!- kalfat [~kalfat@pc7-236.btk.net.pl] has joined #wesnoth-dev
20160726 10:00:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 10:05:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160726 10:29:50-!- gfgtdf [~chatzilla@x4e36a676.dyn.telefonica.de] has joined #wesnoth-dev
20160726 10:31:03-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160726 10:32:05-!- kalfat [~kalfat@pc7-236.btk.net.pl] has quit [Read error: Connection reset by peer]
20160726 10:34:18-!- ideuler [~textual@0.213.62.94.rev.vodafone.pt] has joined #wesnoth-dev
20160726 10:37:41-!- nkr [Elite14718@gateway/shell/elitebnc/x-mewjwqyuuwvwivvh] has left #wesnoth-dev ["Leaving..."]
20160726 11:02:06-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160726 11:04:35-!- ideuler [~textual@0.213.62.94.rev.vodafone.pt] has quit [Quit: Chakalaka.]
20160726 11:08:53-!- Nobun [~nobun@host75-49-dynamic.21-87-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160726 11:09:24-!- Appleman1234 [~Appleman1@KD036012036118.au-net.ne.jp] has quit [Read error: Connection reset by peer]
20160726 11:48:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 11:52:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160726 11:59:15-!- ggeneral [~ggeneral@46.211.154.213] has joined #wesnoth-dev
20160726 11:59:31-!- ggeneral [~ggeneral@46.211.154.213] has quit [Client Quit]
20160726 12:00:10-!- ggeneral [~ggeneral@46.211.154.213] has joined #wesnoth-dev
20160726 12:13:57-!- ggeneral [~ggeneral@46.211.154.213] has quit [Read error: Connection reset by peer]
20160726 12:15:26-!- ideuler [~textual@0.213.62.94.rev.vodafone.pt] has joined #wesnoth-dev
20160726 12:45:25-!- Appleman1234 [~Appleman1@KD036012036118.au-net.ne.jp] has joined #wesnoth-dev
20160726 12:58:13-!- Kwandulin [~Miranda@p200300760F60622AADDEBE447F56FF44.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160726 13:06:43-!- JyrkiVesterinen [~JyrkiVest@87-100-151-187.bb.dnainternet.fi] has quit [Quit: Rebooting]
20160726 13:15:35-!- JyrkiVesterinen [~JyrkiVest@87-100-151-187.bb.dnainternet.fi] has joined #wesnoth-dev
20160726 13:50:58-!- Nobun [~nobun@host75-49-dynamic.21-87-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160726 13:55:57-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160726 13:59:49-!- Kwandulin [~Miranda@p200300760F60622AF45B5BF2A85C8F1A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160726 14:01:36-!- atarocch [~atarocch@93.56.160.28] has quit [Quit: Leaving]
20160726 14:05:54-!- Bonobo [~Bonobo@2001:44b8:254:3200:25e6:fb8b:4b0b:900c] has quit [Ping timeout: 250 seconds]
20160726 14:07:11-!- vultraz changed the topic of #wesnoth-dev to: Feature freeze in effect. 1.13.5 scheduled for 7/31 or earlier pending blocker fixes | Greenlight Votes: 3211 Yes, 851 No, 87 AML | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160726 14:51:04-!- JyrkiVesterinen [~JyrkiVest@87-100-151-187.bb.dnainternet.fi] has quit [Quit: Going somehere, I'll return after about an hour]
20160726 14:54:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160726 15:02:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160726 15:24:27-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160726 15:26:25-!- Yaiyan [~yaiyan@46.101.48.31] has quit [Quit: ZNC - 1.6.0 - http://znc.in]
20160726 15:27:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160726 15:30:14< vultraz> celticminstrel: any objections to merging #713?
20160726 15:30:33< celticminstrel> I have no idea what that is.
20160726 15:30:41< vultraz> https://github.com/wesnoth/wesnoth/pull/713
20160726 15:30:47< celticminstrel> RIght...
20160726 15:31:05< celticminstrel> It'll take a few minutes for Firefox to launch.
20160726 15:31:28< vultraz> a few *minutes*? o_O
20160726 15:32:26< celticminstrel> Well, I guess that's a slight exaggeration. One minute seems to be enough.
20160726 15:33:13< celticminstrel> Maybe two.
20160726 15:33:49< vultraz> WELL WELL WELL well well
20160726 15:34:06< vultraz> I just got an email that we've been Greenlit :D
20160726 15:34:13-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20160726 15:35:05< Kwandulin> vultraz: Congratulations!
20160726 15:35:30-!- vultraz changed the topic of #wesnoth-dev to: Feature freeze in effect. 1.13.5 scheduled for 7/31 or earlier pending blocker fixes | Greenlight Votes: 3244 Yes, 865 No, 87 AML | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160726 15:35:36< vultraz> and that was the total votes :D
20160726 15:35:46< vultraz> #28 rank overall
20160726 15:36:59< vultraz> jeez, how long did that take
20160726 15:37:01< vultraz> 3 days?
20160726 15:39:15-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160726 15:39:51-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 276 seconds]
20160726 15:41:11-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20160726 15:41:24-!- gfgtdf [~chatzilla@x4e36a676.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160726 15:42:38-!- yaiyan is now known as Yaiyan
20160726 15:44:48< celticminstrel> I'm shocked that tfloat was actually used somewhere.
20160726 15:45:26-!- irker627 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160726 15:45:26< irker627> wesnoth: Jyrki Vesterinen wesnoth:boost_trimming c2abe3a6220b / / (8 files in 5 dirs): Kill floating_point_emulation.hpp with fire (#713) https://github.com/wesnoth/wesnoth/commit/c2abe3a6220b00b39b0238057af8734c6cc80fc6
20160726 15:46:08-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160726 15:47:12-!- ggeneral [~ggeneral@46.211.113.75] has joined #wesnoth-dev
20160726 15:48:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160726 15:48:25-!- wedge010 is now known as wedge009
20160726 15:50:06-!- ggeneral [~ggeneral@46.211.113.75] has quit [Client Quit]
20160726 15:50:44-!- ggeneral [~ggeneral@46.211.113.75] has joined #wesnoth-dev
20160726 15:50:55-!- JyrkiVesterinen [~JyrkiVest@87-92-4-238.bb.dnainternet.fi] has joined #wesnoth-dev
20160726 16:13:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 16:14:33-!- molt [~molt@46.161.114.253] has quit [Quit: Leaving]
20160726 16:16:03< bumbadadabum> celticminstrel: around?
20160726 16:16:12< celticminstrel> Yeah?
20160726 16:18:44< irker627> wesnoth: Charles Dang wesnoth:master 2826881eefab / data/gui/ (macros/_initial.cfg widget/button_default.cfg): Bumped button text size by 1 point and fixed text centering. https://github.com/wesnoth/wesnoth/commit/2826881eefab5ff0d186f111ab93b1bd349f0184
20160726 16:19:12-!- travis-ci [~travis-ci@ec2-54-158-95-135.compute-1.amazonaws.com] has joined #wesnoth-dev
20160726 16:19:13< travis-ci> wesnoth/wesnoth#9950 (boost_trimming - c2abe3a : Jyrki Vesterinen): The build has errored.
20160726 16:19:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/147511871
20160726 16:19:13-!- travis-ci [~travis-ci@ec2-54-158-95-135.compute-1.amazonaws.com] has left #wesnoth-dev []
20160726 16:19:16< vultraz> bumbadadabum: ^
20160726 16:20:08< bumbadadabum> vultraz: I already had a commit for it
20160726 16:20:08< bumbadadabum> ffs
20160726 16:20:32< bumbadadabum> not a big deal I can just make that magically disappear
20160726 16:20:46-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160726 16:20:50< vultraz> You might not have done it correctly
20160726 16:20:55< celticminstrel> ...
20160726 16:20:58< bumbadadabum> I did exactly that
20160726 16:21:43< vultraz> And did you fix centering?
20160726 16:24:13< irker627> wesnoth: Charles Dang wesnoth:boost_trimming fcd90d05333a / projectfiles/CodeBlocks/wesnoth.cbp: Removed floating_point_emulation.hpp from CB projfile https://github.com/wesnoth/wesnoth/commit/fcd90d05333aa8f714dd98b8e927677bf13ea758
20160726 16:32:10-!- ggeneral [~ggeneral@46.211.113.75] has quit [Read error: Connection reset by peer]
20160726 16:38:21-!- Kwandulin [~Miranda@p200300760F60622AF45B5BF2A85C8F1A.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160726 16:41:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 16:42:19-!- Rodi [5d56bcaf@gateway/web/freenode/ip.93.86.188.175] has joined #wesnoth-dev
20160726 16:47:28-!- Rodi [5d56bcaf@gateway/web/freenode/ip.93.86.188.175] has quit [Quit: Page closed]
20160726 16:51:06-!- ideuler [~textual@0.213.62.94.rev.vodafone.pt] has quit [Read error: Connection reset by peer]
20160726 16:52:04-!- travis-ci [~travis-ci@ec2-54-158-129-129.compute-1.amazonaws.com] has joined #wesnoth-dev
20160726 16:52:05< travis-ci> wesnoth/wesnoth#9951 (master - 2826881 : Charles Dang): The build was broken.
20160726 16:52:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/147520928
20160726 16:52:05-!- travis-ci [~travis-ci@ec2-54-158-129-129.compute-1.amazonaws.com] has left #wesnoth-dev []
20160726 16:56:08-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160726 16:58:59< celmin> It'd be nice if Steam users could authenticate to the MP server using their Steam account rather than a forum account...
20160726 16:59:17< celmin> We should see if that's viable.
20160726 17:01:17< vultraz> Indeed we should
20160726 17:02:53< vultraz> We have until next year to work out how all this stuff works.
20160726 17:03:10 * celmin imagines some sort of HTTP-type authentication like what Minecraft uses.
20160726 17:03:28-!- gfgtdf [~chatzilla@x4e36a676.dyn.telefonica.de] has joined #wesnoth-dev
20160726 17:04:40< gfgtdf> why did you remove the floatign point emulation?
20160726 17:04:55< vultraz> See PR 
20160726 17:05:01< celmin> Technically haven't yet, but anyway, the commit message explains it all.
20160726 17:05:36< gfgtdf> celmin: the text in the commit message is just wrong, specially when you notice that this code was added in 2012
20160726 17:05:55< celmin> Why was it added and by whom?
20160726 17:06:14< gfgtdf> celmin: my mordante, to improve speed.
20160726 17:06:22< gfgtdf> by*
20160726 17:06:45< celmin> And does it improve speed?
20160726 17:06:47< vultraz> we're improving speed by shipping our own floating point implementation?
20160726 17:07:04< gfgtdf> vultraz: yes beacsue it basiacally does integer artemotic
20160726 17:07:08< vultraz> it's not even used
20160726 17:07:23< celmin> It was used in one of the image scaling algorithms and that's it.
20160726 17:07:37< celmin> So, given how little it was used, I don't think removing it is going to affect speed.
20160726 17:08:19-!- ggeneral [~ggeneral@46.211.113.95] has joined #wesnoth-dev
20160726 17:08:22< celmin> Anyway, why would simulating floating-points be any faster than relying on the hardware floating-point arithmetic?
20160726 17:08:56< gfgtdf> vultraz: yes it seems liek the code currently uses the floating point emulation cde in util.hpp
20160726 17:09:07< gfgtdf> vultraz: mostlikely it was made to replace that
20160726 17:09:10< celmin> Yes, in scale_surface_sharp.
20160726 17:09:22< celmin> And where is scale_surface_sharp used?
20160726 17:09:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 17:10:01< gfgtdf> celmin: becasue integer atethmetic is faster than float arethmetic
20160726 17:10:04< vultraz> few blaces
20160726 17:10:19< JyrkiVesterinen> I verified that scale_surface_sharp is used if I switch the scaling algorithm to nearest neighbor scaling in advanced settings.
20160726 17:10:26< celmin> gfgtdf: But we're not talking about integer arithmetic, we're talking about floating-point arithmetic.
20160726 17:10:39< JyrkiVesterinen> (In order to verify that the scaling still works correctly with hardware floating point arithmetic)
20160726 17:10:47-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160726 17:11:08< gfgtdf> celmin: but the float emnulation uses integers internally
20160726 17:11:10< JyrkiVesterinen> I didn't do any more checking than that, though. Such as if it's called even with the default scaling algorithm.
20160726 17:11:16< celmin> But it's still doing floating-point arithmetic.
20160726 17:11:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 17:11:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 17:11:54< celmin> I don't understand the code, so I suppose in theory it could have been emulating some sort of non-IEEE float for which arithmetic is faster.
20160726 17:11:57< gfgtdf> celmin: emulating it
20160726 17:12:14< celmin> But it's still doing floating-point arithmetic.
20160726 17:13:07< JyrkiVesterinen> If floating point emulation was used for speed, it would have been nice if there was a comment in the code about it. I had no idea. :/
20160726 17:13:52< gfgtdf> JyrkiVesterinen: idf you dont know why a code exiyts you shoudl look ath the git history to see see the commit message of the code that introrced it.
20160726 17:14:51< gfgtdf> JyrkiVesterinen: in this case, the commit histpry https://github.com/wesnoth/wesnoth/commits/master/src/floating_point_emulation.hpp or the git blame https://github.com/wesnoth/wesnoth/blame/master/src/floating_point_emulation.hpp will point to this commit https://github.com/wesnoth/wesnoth/commit/b2c0dfa7dfbe740e849b1d9aa3f342433e7ab9f4
20160726 17:15:49< celmin> What's Pandora, anyway?
20160726 17:16:13< gfgtdf> celmin: some type if linux based game console i think
20160726 17:16:27< JyrkiVesterinen> gfgtdf: Hmm, I see.
20160726 17:16:27< JyrkiVesterinen> https://en.wikipedia.org/wiki/Pandora_(console)
20160726 17:16:54< celmin> Oh wait, is it actually a fixed-point format?
20160726 17:17:23< gfgtdf> celmin: yes it is
20160726 17:17:23< JyrkiVesterinen> Although I figure the Wesnoth project probably doesn't care about Pandora any more (in which case fixed-point support isn't that important anyway).
20160726 17:18:16< celmin> Sounds like a successor is upcoming.
20160726 17:18:17< gfgtdf> JyrkiVesterinen: well we currently dont suport pandora becasue we cannot build boost for it but it not impossible that we still want to suport similar consoles or even succesros fo pandora
20160726 17:18:41< celmin> Maybe the successor would have better floating-point hardware.
20160726 17:19:27< vultraz> I say we don't bother with the Pandora right now.
20160726 17:20:04< gfgtdf> vultraz: well is there any reaso for deleting this code ?
20160726 17:20:06< celmin> Anyway, since it was barely used, I don't think there's any reason to keep the floating-point emulation. If we later find that we want to support a platform with poor floating-point hardware, it can always be resurrected from the commit history.
20160726 17:20:22< vultraz> ^
20160726 17:20:26< vultraz> what celmin said
20160726 17:20:51-!- travis-ci [~travis-ci@ec2-184-73-120-92.compute-1.amazonaws.com] has joined #wesnoth-dev
20160726 17:20:52< travis-ci> wesnoth/wesnoth#9952 (boost_trimming - fcd90d0 : Charles Dang): The build passed.
20160726 17:20:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/147522491
20160726 17:20:52-!- travis-ci [~travis-ci@ec2-184-73-120-92.compute-1.amazonaws.com] has left #wesnoth-dev []
20160726 17:20:54< celmin> (Though rolling custom floating-point emulation code is not what I would call a good idea in the first place - better to find a library that does it.)
20160726 17:22:37< gfgtdf> i really dont understand you you ware doign the boost trimmins stuff in the first place, are there any advatgaes?
20160726 17:26:03< vultraz> it cleaner to use stdlib stuff when possible
20160726 17:27:38< celmin> Speaking of which, I think there are still some boost::ref or similar somewhere.
20160726 17:27:39< vultraz> it reduced the use of boost to the boost-exclusive stuff
20160726 17:28:02< vultraz> celmin: 2 in server.cpp
20160726 17:28:02< gfgtdf> vultraz: well whetehr you write boost:: or std::before your function doesnt realy amke your code more or less clean.
20160726 17:28:21< celmin> I probably should've nuked those along with the boost::bind in there.
20160726 17:29:11< JyrkiVesterinen> gfgtdf: More people are familiar with the C++ standard library than with Boost.
20160726 17:29:34-!- ggeneral2 [~ggeneral@46.211.154.1] has joined #wesnoth-dev
20160726 17:29:39-!- ggeneral [~ggeneral@46.211.113.95] has quit [Read error: Connection reset by peer]
20160726 17:34:07< gfgtdf> JyrkiVesterinen: but im most cases that were replaced boost stuff behaves exactly the same as the std:: stuff.
20160726 17:34:51< celmin> Actually, the std versions are typically at least a little different from the boost versions.
20160726 17:35:00< celmin> For example, boost::bind has subtle differences from std::bind.
20160726 17:35:17< celmin> I doubt trivial things like std::ref or std::move are different, mind you.
20160726 17:35:38< celmin> boost::enable_if is quite different from std::enable_if
20160726 17:35:55< celmin> And in fact I think std::enable_if is simpler for complex conditions.
20160726 17:36:16< celmin> I don't know if there's any differences between std::tuple and boost::tuple.
20160726 17:37:00< celmin> boost::thread provides additional features relative to std::thread.
20160726 17:37:17< celmin> The same might be true of boost::shared_ptr (but I might be making that up)
20160726 17:37:18< celmin> Basically though, it's not true in general that the Boost versions are exactly the same as the std versions.
20160726 17:37:23< JyrkiVesterinen> And when we're already replacing Boost with the standard library where there are differences, we can just as well replace Boost with stdlib whenever we can.
20160726 17:38:01< celmin> (For the record, we're not replacing Boost.Thread, though less because of the extra features and more because of MinGW. Though I did use the extra features in the SpiritPo branch.)
20160726 17:38:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160726 17:42:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 17:42:32< gfgtdf> celmin: does boost::bind just haev more features or is there also code with works with std::bind but not with boost::bind ?
20160726 17:43:21< celmin> I don't know.
20160726 17:43:40< celmin> I don't know of any such code.
20160726 17:44:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 17:44:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 17:44:41< gfgtdf> hmm ok
20160726 17:44:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 17:44:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 17:45:03-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 17:45:17< celmin> Hmm, so, the game doesn't prevent a unit from having multiple abilities with the same ID.
20160726 17:46:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160726 17:48:43< zookeeper> i don't see much reason why it should
20160726 17:49:57< celmin> It seems like the current use of ID may be incompatible with my idea of using the ID to apply abilities to the unit - with the current use, it would make sense to have two logically separate abilities that nevertheless have the same ID so that they are not cumulative with each other.
20160726 17:50:22< celmin> (Logically separate here means that they appear to the player as separate abilities.)
20160726 17:50:52< celmin> I could use [ability] tags that contain an ID and a set of ability tags...
20160726 17:51:54< zookeeper> i believe you've talked about that before
20160726 17:52:06< celmin> Probably.
20160726 17:52:19< zookeeper> and i'm pretty sure i asked how would you dynamically modify a single unit's ability contents then. i just don't remember what the answer was... :p
20160726 17:52:47< celmin> I don't remember what the answer was then, but I can think of two possible answers now.
20160726 17:53:42< celmin> 1. You can't do it. 2. The new syntax is just a shortcut, so once a unit is fully built it has the same old-format ability tags rather than the new-format list of ability IDs.
20160726 17:54:01< celmin> I think #1 would be preferable, but #2 is probably more likely.
20160726 17:59:12< zookeeper> well, if it's #2 then what exactly is the point of the change, when units end up simply using the old syntax anyway?
20160726 18:00:16-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160726 18:01:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Read error: Connection reset by peer]
20160726 18:03:40< gfgtdf> celmin: alsothe game doesn't prevent you from having multiple [attack]s with the same id. so you only have the index of an attack to identify it, this can be püroblematic when for exampel an attack is inserted in the middle, i had this problem once in my addon.
20160726 18:08:07< zookeeper> uh... attacks don't have id's
20160726 18:08:32< zookeeper> i presume you meant ability in all instances
20160726 18:11:46-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160726 18:19:57< celmin> You have a point.
20160726 18:21:00-!- Kwandulin [~Miranda@p200300760F60622AB0CEAFBC7CFF8FAB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160726 18:21:04< celmin> The point of the change is mainly to reduce macro usage, but it would be nice to also avoid needing to transfer tons of boilerplate across networks.
20160726 18:21:27< celmin> Which would require that the ability definitions are never actually included in the unit WML.
20160726 18:29:45-!- ggeneral [~ggeneral@46.211.155.74] has joined #wesnoth-dev
20160726 18:32:12-!- ggeneral2 [~ggeneral@46.211.154.1] has quit [Ping timeout: 260 seconds]
20160726 18:34:21-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160726 18:38:04< zookeeper> ability definitions are a rather vanishingly small part of the overall unit WML, i'd think
20160726 18:38:26< celmin> Well, animations are far larger, certainly.
20160726 18:39:00< celmin> Other than animations and variations, I think abilities and weapon specials are probably the biggest part.
20160726 18:39:02< zookeeper> well, that's why they don't go over the network or to savefiles, i'd imagine :P
20160726 18:39:10< celmin> Yeah.
20160726 18:39:37< bumbadadabum> ok pulled some hairs out trying to fix something
20160726 18:39:53< bumbadadabum> text in unit help can go outside of the screen
20160726 18:40:05< bumbadadabum> and I can't see where it goes wrong
20160726 18:46:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160726 18:46:56-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160726 18:47:06-!- bumba is now known as bumbadadabum
20160726 19:06:55< gfgtdf> zookeeper: no i meant the name= attribute in attacks, whihc is basically an id, note that the displayed name is in the description attribute
20160726 19:17:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160726 19:19:27-!- ggeneral [~ggeneral@46.211.155.74] has quit []
20160726 19:24:26-!- irker627 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160726 19:30:12-!- Jozrael [c05b9010@gateway/web/freenode/ip.192.91.144.16] has joined #wesnoth-dev
20160726 19:30:16< Jozrael> Heyyyyy greenlit!
20160726 19:31:39-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160726 19:32:51< Jozrael> Congrats guys
20160726 19:39:20-!- Jozrael [c05b9010@gateway/web/freenode/ip.192.91.144.16] has quit [Quit: Page closed]
20160726 19:51:58-!- JyrkiVesterinen [~JyrkiVest@87-92-4-238.bb.dnainternet.fi] has quit [Quit: Going to bed]
20160726 19:57:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160726 20:00:20-!- mjs-de [~mjs-de@x4db6dc26.dyn.telefonica.de] has joined #wesnoth-dev
20160726 20:13:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160726 20:16:06-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160726 20:16:27-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160726 20:18:12-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160726 20:20:52-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160726 20:26:28< lipkab> Congratulations everyone on Greenlight!
20160726 20:26:51< pydsigner> Hiya lipkab 
20160726 20:26:59< lipkab> I'm hoping for a similarly successful Steam release.
20160726 20:27:38< lipkab> So much that I'm actually considering coming back from my wesbreak and doing some work.
20160726 20:28:48< pydsigner> \o/
20160726 20:28:53< lipkab> Is there a list somewhere on what needs to be done for the launch?
20160726 20:29:13< lipkab> I'm not really up to date on the current issues, frankly.
20160726 20:29:25-!- esr [~esr@wesnoth/developer/esr] has quit [Read error: Connection reset by peer]
20160726 20:29:26< pydsigner> IDK, I've actually been away from Wesnoth for a while myself
20160726 20:29:36< celmin> There's the EasyCoding and NotSoEasyCoding pages on the wiki, but those are probably not comprehensive.
20160726 20:29:45-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160726 20:30:35< lipkab> I do know about that pages but I'm looking for priority tasks.
20160726 20:31:15< celmin> Priority, huh...
20160726 20:31:26< celmin> I'm not quite sure.
20160726 20:31:28 * celmin pokes vultraz 
20160726 20:31:35< pydsigner> celmin: Here is your chance to get that one thing you want done accomplished!
20160726 20:31:41< vultraz> hm?
20160726 20:32:09< gfgtdf> lipkab: the recall/recruit dialogs need to be worked on since the recruit dialog was moves to gui tey look quite different
20160726 20:32:15 * celmin points vultraz at lipkab
20160726 20:32:43< vultraz> gfgtdf, lipkab: yes, you could convert the recall dialog to gui2
20160726 20:32:44< gfgtdf> moved to gui2*
20160726 20:32:47< celmin> One thing I wanted to do but wasn't sure how is to add a key to [multiplayer] that prevents the user from changing the AI algorithm assigned to that side.
20160726 20:32:59< vultraz> lipkab: or you could convert the game creation screen in mp to GUI2
20160726 20:33:38< celmin> Another thing I was trying to do is break the hotkeys panel in the preferences into categories.
20160726 20:33:41< vultraz> lipkab: or you can fix this bug: https://gna.org/bugs/index.php?24703
20160726 20:33:53< vultraz> lipkab: or you can add functionality to the gui2 addons manager
20160726 20:33:56< celmin> So for example there'd be one category for "whiteboard commands", maybe one for "unit commands", etc
20160726 20:35:21< lipkab> celmin, gfgtdf, vultraz: Cool, thanks, I'll write these down and see what I can do.
20160726 20:36:08< celmin> At one point someone claimed that unit animations are iterated through every frame, but I haven't even tried to verify that yet...
20160726 20:36:57< celmin> I also wanted to add hotkeys for diagonal scrolling and for temporary acceleration, now that there are hotkeys for regular scrolling.
20160726 20:37:04< celmin> But that's not really high priority.
20160726 20:37:19< gfgtdf> lipkab: http://gna.org/bugs/?22918 http://gna.org/bugs/?23111 are also annoying to me
20160726 20:37:53< gfgtdf> lipkab: at lest thre is also the 'create scenario' option in the edtior which is currently incplete/broken we still need a way on how toi handle this
20160726 20:37:55< lipkab> celmin: There's Shift for speeding up animations... if that is what you mean.
20160726 20:38:06< celmin> lipkab: Yeah, I meant making it rebindable.
20160726 20:38:14< lipkab> Ah.
20160726 20:38:31< gfgtdf> lipkab: and ofc there is the 'move form gna to a new and better bugtracker' task
20160726 20:38:35< gfgtdf> from*
20160726 20:38:50< celmin> Since orthogonal scrolling keys are now rebindable, I think it should be possible to make that use of Shift rebindable too.
20160726 20:39:17< lipkab> gfgtdf: Whoah, I'm afraid the scenario editor is off-limits for now :)
20160726 20:39:45< pydsigner> lipkab: In other words, everything is priority if the letters G U and I are involved heh
20160726 20:39:48< celmin> BTW gfgtdf, you added lua_function to location filters but not to side or weapon filters, any partiular reason for that?
20160726 20:40:33< lipkab> pydsigner: Yeah, especially with an added '2' :P
20160726 20:40:34< gfgtdf> celmin: uhm i just neede a way to use lua fitlers in a the [set_menu_item] filter_location
20160726 20:40:43< celmin> Ah.
20160726 20:41:26< celmin> Maybe I'll do that later. It should be pretty easy, I think.
20160726 20:42:33< celmin> Someone wanted a way to control whether you can see through a [tunnel].
20160726 20:42:44< pydsigner> lipkab: I think one of the main goals for 1.14 is finishing conversion from gui1 to gui2
20160726 20:42:51< celmin> Yeah.
20160726 20:43:06< celmin> And then maybe after 1.14 we'll see if we can find something to replace GUI2. >_>
20160726 20:43:44-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 20:44:12< celmin> Oh, speaking of GUI2, I think the slider implementation still needs improvement? The thumb moves smoothly rather than snapping to valid locations, which might be fine for scrollbars and some sliders but is confusing for discrete sliders.
20160726 20:46:14< gfgtdf> celmin: i agree
20160726 20:46:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 20:47:39< celmin> On the sliders, replacing GUI2, or the lua_function thing?
20160726 20:48:47< gfgtdf> celmin: the gui2 sliders
20160726 20:48:59< gfgtdf> celmin: but im not opposed on the lua_function thing eigher
20160726 20:53:33-!- Aginor_ [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20160726 20:55:23-!- Aginor [~andreas@apollo.alternating.net] has quit [Ping timeout: 250 seconds]
20160726 20:55:30-!- Aginor_ is now known as Aginor
20160726 20:55:38-!- Aginor [~andreas@apollo.alternating.net] has quit [Client Quit]
20160726 20:55:46-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20160726 20:57:49-!- edgrey [~edgrey@178.204.47.221] has quit [Remote host closed the connection]
20160726 20:58:45< bumbadadabum> woah lipkab 
20160726 21:01:55< lipkab> Woah bumbadadabum!
20160726 21:02:04< bumbadadabum> long time no see
20160726 21:02:05< lipkab> How are you?
20160726 21:02:12< bumbadadabum> good
20160726 21:02:18< bumbadadabum> trying to get back into wesnoth myself as well
20160726 21:02:41< bumbadadabum> getting frustrated at trying to solve bugs in the UI code
20160726 21:02:55-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20160726 21:03:06< lipkab> Nice, nice.
20160726 21:03:55< lipkab> Do you work with C++ already?
20160726 21:05:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20160726 21:06:42-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160726 21:06:55< iceiceice> bumbadadabum, 
20160726 21:07:11< iceiceice> the "oversized sprites" in the help was basically an experiment
20160726 21:07:15< iceiceice> since this commit: https://forums.wesnoth.org/viewtopic.php?f=12&t=41109&hilit=xBRZ
20160726 21:07:18< bumbadadabum> lipkab: not with wesnoth that much
20160726 21:07:24< bumbadadabum> but I've been doing a lot of C++ for uni
20160726 21:07:25< bumbadadabum> iceiceice: ah
20160726 21:07:33< iceiceice> i think you are not the only one who didn't like it in the help
20160726 21:07:45< iceiceice> it was just an experiment, idk, you guys do whatever you want about it
20160726 21:07:57< bumbadadabum> I might revert it
20160726 21:07:59< iceiceice> i thought it was a good idea to use larger sprites in the help than you see in the game
20160726 21:08:06< bumbadadabum> and change the scaling of portraits
20160726 21:08:15< bumbadadabum> maybe make it 2x only when the screen is big enough
20160726 21:08:33< iceiceice> yeah it shouldn't look "alpha"
20160726 21:08:50< bumbadadabum> on my screen at least, the sprites look bad
20160726 21:08:55-!- ideuler [~textual@bl13-229-95.dsl.telepac.pt] has joined #wesnoth-dev
20160726 21:08:58< iceiceice> the xbrz thing is also used when zoom in the view now iirc
20160726 21:09:06-!- ideuler [~textual@bl13-229-95.dsl.telepac.pt] has quit [Remote host closed the connection]
20160726 21:09:12< iceiceice> like if you zoom in 2x then the terrain and sprites get scaled using this algorithm
20160726 21:09:20< iceiceice> instead of just like making them blocky
20160726 21:09:29< celmin> Isn't there actually a preference for that?
20160726 21:09:33< iceiceice> yeah there is a preference
20160726 21:09:39< iceiceice> i think the default is xbrz now but maybe not
20160726 21:09:41< iceiceice> i dont remember actually
20160726 21:09:55< celmin> If it's not the default then maybe it should be.
20160726 21:09:56< lipkab> bumbadadabum: Oh, so you started university in the meantime! Which one?
20160726 21:10:26< celmin> BTW, who implemented [random_placement]?
20160726 21:10:42< iceiceice> i guess could try tweaking the algorithm also
20160726 21:10:45< iceiceice> i dont think i really attempted that
20160726 21:10:55< iceiceice> oh maybe i did
20160726 21:11:01< iceiceice> i think i used a custom distance function or something at some point
20160726 21:11:12< iceiceice> idk it was a while ago
20160726 21:11:17< iceiceice> i think its documented in the xbrz file
20160726 21:13:45-!- Kwandulin [~Miranda@p200300760F60622AB0CEAFBC7CFF8FAB.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160726 21:14:38< bumbadadabum> lipkab: I started studying CS years ago lol
20160726 21:14:59< bumbadadabum> I study at the university of amsterdam
20160726 21:16:58< lipkab> bumbadadabum: Ouch, must have missed that. I thought you were a high school student for some reason.
20160726 21:17:53< celmin> Oh yeah, there should be a Lua function that waits for the player to select a hex and returns the chosen location.
20160726 21:17:59< lipkab> I was secretly hoping for Leuven since that is a partner institution of my university, and then we would have been cousins or whatever :P
20160726 21:18:03< celmin> By select I mean "click on".
20160726 21:18:19< celmin> And with a way to cancel, in which case it returns nil.
20160726 21:18:20< lipkab> ...but Amsterdam is not bad either.
20160726 21:18:33< celmin> I think that might be on one of those wiki pages, not sure.
20160726 21:20:53< bumbadadabum> Leuven is in belgium
20160726 21:20:55< bumbadadabum> wrong country
20160726 21:21:16< bumbadadabum> I do know someone at that uni however
20160726 21:21:19< lipkab> Whoops...
20160726 21:25:23< bumbadadabum> anyway, vultraz iceiceice: I was thinking about making the sprite previews scale if width >=1600 and have the portraits be 200x200 for <=1366, and 300 for <=1600
20160726 21:25:27< celmin> https://forums.wesnoth.org/viewtopic.php?f=5&t=44175&view=unread&sid=f327ef0d455a24bdafc0d6ff10348fb9#unread
20160726 21:25:32< bumbadadabum> does that sound reasonable?
20160726 21:26:13< lipkab> 'night everyone!
20160726 21:26:15-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160726 21:26:26< celmin> I think I was the one who decided the current portrait sizes…
20160726 21:26:33< celmin> But I forget what they are.
20160726 21:26:33< pydsigner> Currently the portraits are 205x205 right?
20160726 21:26:46< celmin> pydsigner: Eh? I don't think so?
20160726 21:26:52< celmin> They're like 500x500 usually, right?
20160726 21:26:53< pydsigner> in the help
20160726 21:26:53< bumbadadabum> currently they're 400x400
20160726 21:26:57< bumbadadabum> in the help
20160726 21:27:08< bumbadadabum> and 200 if width < 1024
20160726 21:27:12< iceiceice> bumbadadabum, you definitely already thought about it more than i did :)
20160726 21:27:12< bumbadadabum> iirc
20160726 21:27:16< celmin> Ah.
20160726 21:27:17< pydsigner> So that's changed in 1.13
20160726 21:27:31< celmin> Yeah, we removed all the scaled-down portraits.
20160726 21:27:42< celmin> Now the transparent ones are scaled down as needed.
20160726 21:28:24< celmin> Well, I don't have any objections to your amendment to portrait sizes.
20160726 21:28:37< celmin> Though 1366 seems a weird number.
20160726 21:29:17< vultraz> he has a weird-ass screen
20160726 21:29:18< bumbadadabum> my laptop is 1366x768
20160726 21:29:21< bumbadadabum> and a lot of laptops are
20160726 21:29:35< bumbadadabum> I could change it to 1440
20160726 21:29:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160726 21:29:54< celmin> As long as it still looks good at that size, I don't really have a problem with it.
20160726 21:30:25< mattsc> 20160726 20:42:33< celmin> Someone wanted a way to control whether you can see through a [tunnel].
20160726 21:30:55< mattsc> I assume that is not referring to what I said a couple days ago but to somethign else?  (because that is not at all what I said)
20160726 21:31:12< celmin> I think it was DeFender who said it.
20160726 21:31:18< celmin> If I recall correctly.
20160726 21:31:39< mattsc> okay; just wanted to make sure
20160726 21:32:36< mattsc> What I meant was the bug/feature Dan Beetlenaut emailed to the ML about earlier today.
20160726 21:32:58< bumbadadabum> anyway, does anyone else have an idea what the largest resolution is we'd call "small"
20160726 21:33:18< bumbadadabum> idk what tiny laptops use
20160726 21:33:46< celmin> I think the lowest supported is currently either 800x600 or 1024x768, right?
20160726 21:33:51< celmin> Probably the former.
20160726 21:34:04< celmin> I think it was something-480 that was removed.
20160726 21:34:27< vultraz> yes
20160726 21:34:42< vultraz> 800x600 is the official smallest supported resolution
20160726 21:34:51< vultraz> official 
20160726 21:34:59< bumbadadabum> where is the cutoff between small and medium
20160726 21:35:36< celmin> I don't really know.
20160726 21:35:46< celmin> Why did you say official twice?
20160726 21:37:18< pydsigner> 1280x800 is the smallest you'll see on any non-ancient laptop
20160726 21:38:45< Aginor> 800x600 has value for mobile platforms too
20160726 21:38:47< celmin> And what's the largest common resolution?
20160726 21:39:09< Aginor> there's a version of wesnoth in the google app store of 1.12.6
20160726 21:39:24< celmin> Oh nice, I guess?
20160726 21:39:35< Aginor> it's free, so I think it is ;)
20160726 21:39:36< celmin> Ah, right, that would be the Android port, right?
20160726 21:39:48< Aginor> I think this is different
20160726 21:39:58< celmin> Oh. Okay then.
20160726 21:40:05< Aginor> but I didn't look much
20160726 21:40:52-!- zookeeper_ is now known as zookeeper
20160726 21:40:54-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20160726 21:40:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160726 21:42:08-!- Bonobo [~Bonobo@2001:44b8:254:3200:7458:235:19f3:9084] has joined #wesnoth-dev
20160726 21:42:47-!- Bonobo [~Bonobo@2001:44b8:254:3200:7458:235:19f3:9084] has quit [Client Quit]
20160726 21:42:53< bumbadadabum> I'm just trying to detemine at which resolution I'm going to start scaling the sprites
20160726 21:45:31< Aginor> I think it might make sense to investigate font scaling though
20160726 21:45:49< bumbadadabum> also I kinda prefer having a black background for the portraits
20160726 21:45:57< Aginor> I feel ancestral's pain ;)
20160726 21:45:59< bumbadadabum> but the new scaling makes it so the image is not always a square
20160726 21:46:09< bumbadadabum> so that's off the table as well
20160726 21:50:28< vultraz> just leave the sprites scaled 
20160726 21:50:33< vultraz> you can check their size
20160726 21:50:39< vultraz> like maybe we don't want to scale the dragon
20160726 21:54:32< Aginor> better to scale mountains than dragons
20160726 21:55:03< iceiceice> celmin, i guess that many games use fixed-point rather than floating point
20160726 21:55:09< iceiceice> because it lets them force portability
20160726 21:55:22< iceiceice> i mean technically any time you do floating point arithmetic in WML
20160726 21:55:24< iceiceice> it could cause an OOS
20160726 21:55:31< iceiceice> but its usually not relevant
20160726 21:55:38< celmin> I don't think it can cause OOS?
20160726 21:55:48< iceiceice> i mean if you did goofy stuff
20160726 21:55:54< celmin> Unless it's actually using a different float type.
20160726 21:55:57< iceiceice> like divid some numbers
20160726 21:56:00< iceiceice> until round off happens
20160726 21:56:02< celmin> But that shouldn't be the case.
20160726 21:56:05< iceiceice> then multiply it by like 1000000
20160726 21:56:10< iceiceice> and see what the lowest order bit is
20160726 21:56:14< celmin> And it does attempt to set the rounding mode.
20160726 21:56:23< iceiceice> then you could make an integer that will be different on different architectures
20160726 21:56:41< celmin> Can that be done in Lua?
20160726 21:56:47< iceiceice> yeah probably
20160726 21:56:51< celmin> Huh.
20160726 21:57:04< iceiceice> i think it doesn't really matter
20160726 21:57:18< iceiceice> at least i never saw a bug report like this
20160726 21:57:24< iceiceice> and clearly a lot of games use lua
20160726 21:57:25< bumbadadabum> vultraz: ALL scaled sprites look bad imo on a smaller monitor
20160726 21:57:33< iceiceice> but i think its technically a thing
20160726 21:58:20< iceiceice> iiuc IEEE floating point was basically designed with like, people doing numerical experiments in mind
20160726 21:58:34< iceiceice> who care about speed mostly and not that much about portability
20160726 21:58:52< pydsigner> celmin: Define common resolution
20160726 21:59:01< pydsigner> But 4 or 5k
20160726 22:04:21< Aginor> bumbadadabum: I think it would be reasonable to want scaling to maintain aspect ratio though
20160726 22:04:32< bumbadadabum> yes definitely
20160726 22:04:46-!- mjs-de [~mjs-de@x4db6dc26.dyn.telefonica.de] has quit [Remote host closed the connection]
20160726 22:10:07-!- Duthlet [~Duthlet@dslb-188-105-122-010.188.105.pools.vodafone-ip.de] has quit [Ping timeout: 258 seconds]
20160726 22:19:59< bumbadadabum> http://imgur.com/a/nagou
20160726 22:20:11< bumbadadabum> anyway, the bugs with text I was talking about and trying (I failed) to fix
20160726 22:22:13< celmin> Missing portrait? :S
20160726 22:22:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160726 22:22:37< celmin> Oh, shadow mage.
20160726 22:25:17< bumbadadabum> no the text
20160726 22:26:47< celmin> Oh.
20160726 22:27:04< celmin> About how much is missing?
20160726 22:30:10< bumbadadabum> few words
20160726 22:30:17< bumbadadabum> also the overlap on the DS portrait
20160726 22:35:35< bumbadadabum> celmin: I pinpointed it and it seems to be font::word_wrap_text that doesn't work
20160726 22:36:46< celmin> I see
20160726 22:37:26< celmin> That'll probably be removed with GUI1 eventually, but could be fixed in the meantime
20160726 22:39:59< bumbadadabum> yeah
20160726 22:48:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160726 22:50:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160726 22:50:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160726 22:50:27-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Read error: Connection reset by peer]
20160726 22:50:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160726 22:51:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Read error: Connection timed out]
20160726 22:52:44-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160726 22:54:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160726 23:05:35-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160726 23:05:50< ancestral> Fixed the blocker bug
20160726 23:06:16< ancestral> We just need to figure out the bind issue
20160726 23:06:30< ancestral> I expired last night pretty suddenly
20160726 23:06:40< celmin> I already forgot what the blocker bug was.
20160726 23:07:40< celmin> Anyway, the bind issue should be solvable by switching those instances to lambdas, like I mentioned earlier; I don't like this solution, but at least it should work. Alternatively, if there are several instances in the same function, you could try adding "using namespace std::placeholders" in that function.
20160726 23:09:19< bumbadadabum> vultraz: ok my main problem with the portraits is that they extend too far down
20160726 23:09:29< bumbadadabum> like past the unit description even for a lot of units
20160726 23:09:31-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Remote host closed the connection]
20160726 23:09:32< bumbadadabum> if they have a female variant
20160726 23:10:08< bumbadadabum> I think that's actually my main reason for wanting them to be 200x200
20160726 23:17:20< bumbadadabum> ok another idea
20160726 23:17:42< bumbadadabum> if the unit has a single portrait, don't downscale it (unless the screen is really small), and if the unit has 2 portraits, downscale them
20160726 23:18:09< celmin> Worth a try.
20160726 23:22:23< bumbadadabum> http://imgur.com/a/OCa6I
20160726 23:22:59< celmin> Wait, why is the text on top of the portrait?
20160726 23:23:16< bumbadadabum> <bumbadadabum> anyway, the bugs with text I was talking about and trying (I failed) to fix
20160726 23:23:58< bumbadadabum> pretend there is no overlapping text
20160726 23:29:53< bumbadadabum> celmin: should I commit this or no?
20160726 23:30:10< celmin> Let's see what vultraz thinks as well. I don't really have a problem with it.
20160726 23:30:20< bumbadadabum> vultraz has a 1920x1080 monitor
20160726 23:30:24< bumbadadabum> NOTHING will change for him
20160726 23:30:27< bumbadadabum> :p
20160726 23:30:43< celmin> Oh, okay.
20160726 23:30:53 * celmin shrug.
20160726 23:31:33< bumbadadabum> has the generator for traits been re-enabled?
20160726 23:31:37< bumbadadabum> else I might do that as well
20160726 23:31:42< celmin> Go for it.
20160726 23:31:57< celmin> (And, I guess, delete the help topics for specific traits.)
20160726 23:32:23< celmin> Maybe move some of the help topic info into the trait descriptions.
20160726 23:34:05-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Ex-Chat]
20160726 23:41:00< vultraz> bumbadadabum: 1600x900
20160726 23:41:09< bumbadadabum> oh ok
20160726 23:41:25-!- bumbadadabum changed the topic of #wesnoth-dev to: Feature freeze in effect. 1.13.5 scheduled for 7/31 or earlier pending blocker fixes | Greenlight Votes: 3244 Yes, 865 No, 87 AML | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160726 23:41:37< bumbadadabum> anyway, click my link and tell me if you think that's ok
20160726 23:41:39< bumbadadabum> also gre0gjegjegor
20160726 23:41:41< vultraz> what did you just do
20160726 23:41:43< bumbadadabum> accidentally clicked the topic
20160726 23:41:55< vultraz> what am I looking at?
20160726 23:41:59< vultraz> i see non-scaled portraits
20160726 23:42:01< vultraz> er
20160726 23:42:03< vultraz> sprites
20160726 23:42:21< bumbadadabum> only for <1600 wide that is
20160726 23:42:34< bumbadadabum> I made the portraits slightly smaller if there's both a male and female one
20160726 23:44:29< vultraz> how come when I run wesnoth at your resolution stuff looks fine for me https://drive.google.com/file/d/0B-mR9s8FduLLQzZtUmZYdEp3N2M/view?usp=sharing
20160726 23:45:12< celmin> If you mean the text, I think he was fiddling with that or something?
20160726 23:45:27< vultraz> just general layout
20160726 23:45:42< vultraz> he said everything looked too small
20160726 23:46:09< bumbadadabum> what?
20160726 23:46:13< bumbadadabum> I said everything looks too big
20160726 23:46:35< vultraz> oh
20160726 23:46:40< vultraz> well i don't really see it
20160726 23:46:46< vultraz> honestly, in your shot things seem too small
20160726 23:46:51< celmin> Looking at your screenshot, I'd agree with him.
20160726 23:47:01< celmin> The portraits are quite large there.
20160726 23:47:06< vultraz> maybe the portraits could be reduced, though
20160726 23:47:10< vultraz> but bigger than he has
20160726 23:47:22< bumbadadabum> right now it's
20160726 23:47:52< bumbadadabum> if width <= 1366 it's 200 for 2 portraits and 300 for one
20160726 23:48:10< bumbadadabum> for 1366 < x < 1600 it's 400 for a single one and 300 if there are 2
20160726 23:48:30< bumbadadabum> and for 1600+ it's 400 even if there are 2
20160726 23:48:38-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20160726 23:48:45< bumbadadabum> or 1920, that might be better
20160726 23:49:22< vultraz> make it 250
20160726 23:49:58< vultraz> dunno why the text is overlapping for you
20160726 23:50:01< vultraz> it doesn't for me
20160726 23:50:19< bumbadadabum> might be a linux thing?
20160726 23:50:34< bumbadadabum> I like the 200 more since even at 800x600 both portraits fit on the screen
20160726 23:51:20< bumbadadabum> I need to go now, but I'll work on this later (as well as writing a generator for trait descriptions)
20160726 23:51:30< bumbadadabum> I'll probably add a help_text= key to traits
20160726 23:51:37< celmin> Eh? It needs to be written?
20160726 23:51:46< bumbadadabum> it's not there
20160726 23:51:51< celmin> Huh, okay.
20160726 23:52:20< bumbadadabum> yeah idk what happened but it's not there for me
20160726 23:52:35< bumbadadabum> I need to figure out what generates a trait's effect in the sidebar
20160726 23:52:41< bumbadadabum> anyway, bll
20160726 23:52:46< bumbadadabum> *bbl
20160726 23:52:50< celmin> That would be the effects.
20160726 23:52:59< celmin> unit::add_modification or thereabouts.
20160726 23:53:15< celmin> Actually apply_default_effect, I guess
20160726 23:53:34< celmin> Maybe it was builtin not default
20160726 23:55:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
--- Log closed Wed Jul 27 00:00:18 2016