--- Log opened Sat Jul 30 00:00:59 2016
20160730 00:01:25< celmin> Same way.
20160730 00:02:23< vultraz> operator()(class) = delete; or something? 
20160730 00:02:46< celmin> No, that'd be a deleted function call operator. Also it needs a return type.
20160730 00:05:09 * vultraz googles
20160730 00:05:31< vultraz> class& operator=(const class7) = delete;?
20160730 00:05:36< vultraz> s/7/&
20160730 00:05:36< celmin> Yes yes.
20160730 00:05:43< celmin> Technically the return type doesn't matter here.
20160730 00:05:50< celmin> It could be anything really.
20160730 00:05:59< celmin> But that's the standard return type for an assignment operator.
20160730 00:06:16< vultraz> blah
20160730 00:06:28< vultraz> im thinking it might be more convenient to stick with noncopyable
20160730 00:06:37< celmin> I'll leave this one up to you.
20160730 00:06:46-!- fabi [~fabi@wesnoth/developer/fendrin] has quit [Quit: Konversation terminated!]
20160730 00:12:55< vultraz> blah
20160730 00:13:00< vultraz> I'll leave it for another time
20160730 00:13:13< vultraz> i'm too lazy to go through again and do the assignment operators
20160730 00:14:43< celmin> If you want to come back to it later, you can do a stash.
20160730 00:15:43< vultraz> nah, I'll redo it later
20160730 00:16:06< vultraz> btw, what is this about constexpr that you keep saying doesn't work on 2013?
20160730 00:17:11< celmin> What about it?
20160730 00:18:16< vultraz> i noticed a note in config.hpp: TODO: Fix this in c++11 using constexpr types.
20160730 00:18:50< celmin> constexpr isn't a type qualifier.
20160730 00:19:02< celmin> It's a… I think the term is storage specifier?
20160730 00:19:06< celmin> Similar to static.
20160730 00:19:13< celmin> Or virtual I guess.
20160730 00:19:23< celmin> Anyway, it means something can be evaluated at compile-time.
20160730 00:24:41< vultraz> so is it something that could be used in that case?
20160730 00:25:10< celmin> Maybe?
20160730 00:25:16< celmin> I haven't looked at that place.
20160730 00:28:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160730 00:30:36< irker680> wesnoth: Bär Halberkamp wesnoth:master 07d365b9b541 / src/units/unit.cpp: Separate the description and generated description with a newline https://github.com/wesnoth/wesnoth/commit/07d365b9b54156dc081beab268fafdb9b1723feb
20160730 00:32:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160730 00:41:49< irker680> wesnoth: Charles Dang wesnoth:boost_trimming 071eee1d8014 / src/ (5 files in 3 dirs): Convert gui2::tvisible and gui2::tredraw_action to scoped enums https://github.com/wesnoth/wesnoth/commit/071eee1d801408a802755e37ab03e2addfd16c73
20160730 00:42:17-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160730 00:42:56< iceiceice> vultraz, what does that code even do
20160730 00:43:02< vultraz> hm?
20160730 00:43:06< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/config.hpp#L324
20160730 00:43:18< vultraz> I don't know :P
20160730 00:43:43< iceiceice> its very hard to understand
20160730 00:43:46< iceiceice> it seems to be doing string to enum
20160730 00:43:52< iceiceice> but the enum is passed by const reference
20160730 00:43:57< iceiceice> so the enum is not modified ?
20160730 00:44:03< iceiceice> so then what is happening
20160730 00:44:26< celmin> It's converting the attribute value to an enum.
20160730 00:44:30< celmin> And returning the result.
20160730 00:45:03< iceiceice> what is the role of v?
20160730 00:45:03< celmin> I don't know why it takes an argument though...
20160730 00:45:20< iceiceice> what does string_to_enum even do when you pass it a const & as second parameter?
20160730 00:45:41< celmin> Oh! It must be the default.
20160730 00:45:44-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 00:45:45< travis-ci> wesnoth/wesnoth#10002 (boost_trimming - e8b4b44 : Charles Dang): The build is still failing.
20160730 00:45:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148457777
20160730 00:45:45-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 00:45:54< celmin> So it returns v if there wasn't a valid enum of that type.
20160730 00:45:57< vultraz> bumbadadabum: don't forget to mark the FR as fixed
20160730 00:46:28< iceiceice> its just an ignored argument?
20160730 00:46:29< iceiceice> https://github.com/wesnoth/wesnoth/blob/master/src/utils/make_enum.hpp#L45
20160730 00:46:41< iceiceice> oh
20160730 00:46:42< iceiceice> yeah you are right
20160730 00:46:45< celmin> I don't see how it could be made constexpr though...
20160730 00:46:53< iceiceice> it mgiht not be about constexpr
20160730 00:46:54< vultraz> ugh
20160730 00:47:02< vultraz> we're back to the regex crap in travis :|
20160730 00:47:03< iceiceice> celmin: maybe its a place for trailing return type?
20160730 00:47:09< iceiceice> like, make the return type auto
20160730 00:47:22< iceiceice> so that the template parameter can be deduced from teh default value
20160730 00:47:50< celmin> But it's using enable_if… I suppose the enable_if could be in the parameter though…
20160730 00:48:09< iceiceice> i thin kthe enable_if is just confirming that the second value is an enum
20160730 00:48:20< iceiceice> but it might not really be necessary to use sfinae for this
20160730 00:48:22< vultraz> iceiceice: any idea about the errors travis is throwing?
20160730 00:48:31< iceiceice> since hte body is going to call an enum-specific function anyways
20160730 00:48:33< vultraz> I'm thinking it could be a 4.7 thing this time...
20160730 00:49:00< celmin> Then how do you explain clang getting the same error>
20160730 00:49:02< celmin> ^?
20160730 00:49:21< celmin> At least, it looks the same as what you described, I didn't actually look at the GCC output.
20160730 00:49:28< iceiceice> vultraz, i think its linker errors
20160730 00:49:37< celmin> Yes, it's linker errors.
20160730 00:49:44< iceiceice> because the gcc c++ standard library does not have regex
20160730 00:49:46< iceiceice> unti llike fairly late
20160730 00:49:56< celmin> Hmm.
20160730 00:49:58-!- fabi [~fabi@176.5.22.173] has joined #wesnoth-dev
20160730 00:50:09< celmin> And even clang is building against that, huh.
20160730 00:50:10< iceiceice> http://stackoverflow.com/questions/12530406/is-gcc-4-8-or-earlier-buggy-about-regular-expressions
20160730 00:50:27< iceiceice> if you want to use std::regex then you need to use gcc 4.9
20160730 00:50:28< iceiceice> i guess
20160730 00:50:38< vultraz> blah!
20160730 00:50:46< iceiceice> in that answer, johnathan wakely is the lead developer of libstdc++
20160730 00:50:48< vultraz> well I guess we could do that
20160730 00:50:51< iceiceice> so thats about as authoritative as it gets
20160730 00:51:36< vultraz> you recommended 4.9, after all
20160730 00:52:07< celmin> Could try using libc++ instead, I suppose, but I dunno if that might be annoying for packagers.
20160730 00:52:13< iceiceice> 4.9 is a good compiler
20160730 00:52:34< iceiceice>  celmin, i dont think you can use gcc with libc++
20160730 00:52:37< iceiceice> at least i never heard of that
20160730 00:52:48< iceiceice> i know clang is supposed to work with both
20160730 00:52:54< iceiceice> but i dont think gcc works with clang's stdlib
20160730 00:52:59< iceiceice> idk
20160730 00:53:10< celmin> We said on the ML that support was to be for 4.7, so I'm reluctant to change that, but not fully opposed to it.
20160730 00:53:51< vultraz> let's bump travis and see if it works
20160730 00:53:57< celmin> Bump what?
20160730 00:54:04< vultraz> its compiler
20160730 00:54:07< vultraz> er
20160730 00:54:09< vultraz> the one it uses
20160730 00:54:24< iceiceice> i mean you probably dont need to use std::regex either
20160730 00:54:27< celmin> It might be best to just revert to boost::regex.
20160730 00:54:46< celmin> Though I think we should keep the raw strings change. Untangling those might take a bit of work.
20160730 00:55:32< vultraz> is there any disadvantage to bumping min compiler support to 4.9?
20160730 00:56:09< celmin> It means certain platforms won't be supported.
20160730 00:57:08< celmin> https://wiki.wesnoth.org/User:Celtic_Minstrel/WesnothCxx11Support
20160730 00:57:31< celmin> Mint might be a problem?
20160730 00:58:07< celmin> And 4.8's regex is buggy, so let's revert to Boost's regex.
20160730 00:58:08< iceiceice> isnt there a new version of mint?
20160730 00:58:15< celmin> I think so, yes.
20160730 00:58:27< celmin> Wait, I was looking at the wrong row.
20160730 00:58:30< celmin> No idea, then.
20160730 00:58:34< iceiceice> i guess its very new
20160730 00:58:40< iceiceice> since june they have an ubuntu 16.04 one
20160730 00:59:11< vultraz> graph looks alright
20160730 00:59:15< vultraz> for 4.9
20160730 00:59:16< iceiceice> they took too long for me and i migrated to ubuntu :p
20160730 00:59:23< celmin> What looks alright?
20160730 00:59:33< iceiceice> gtg
20160730 00:59:36-!- iceiceice [~chris@wesnoth/developer/iceiceice] has quit [Quit: Ex-Chat]
20160730 01:00:13< vultraz> debian, ubuntu, and steamos have support for 4.9
20160730 01:01:01< celmin> And the BSDs too. And Fedora, but that was probably a given,
20160730 01:01:43< vultraz> I consider the three I mentioned most important
20160730 01:02:11< celmin> On what grounds?
20160730 01:02:33< vultraz> first two are major distros and the last is steam-related.
20160730 01:02:54< celmin> Pretty sure all the ones on that table could be called "major distros".
20160730 01:03:06< celmin> Excepting maybe CentOS.
20160730 01:03:19< celmin> Which is more for server-type things, not for end-users.
20160730 01:04:14< vultraz> at the very least i'd like us to go to 4.8
20160730 01:04:23< vultraz> the question is whether we can go to 4.9
20160730 01:05:03< celmin> Talk to Aginor?
20160730 01:07:18-!- enchi [~aeonchild@defocus/yummy/enchilado] has quit [Ping timeout: 250 seconds]
20160730 01:09:55-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160730 01:22:31-!- gfgtdf_ [~chatzilla@x4e363799.dyn.telefonica.de] has joined #wesnoth-dev
20160730 01:23:12< gfgtdf_> celmin, iceiceice: config.hpp#L324 converts config attributes to enums generated with make_enum, the problem it currently has is that just writing like cfg["random_faction_mode"].to_enum(RANDOM_FACTION_MODE::DEFAULT) doesnt work becasue RANDOM_FACTION_MODE::DEFAULT is of type RANDOM_FACTION_MODE::type and not RANDOM_FACTION_MODE so you need to write celmin, iceiceice: config.hpp#L324...
20160730 01:23:14< gfgtdf_> ...converts config attributes to enums generated with make_enum, the problem it currently has is that just writing like cfg["random_faction_mode"].to_enum(RANDOM_FACTION_MODE::DEFAULT) doesnt work becasue RANDOM_FACTION_MODE::DEFAULT is of type RANDOM_FACTION_MODE::type and not RANDOM_FACTION_MODE, so you need to write cfg["random_faction_mode"].to_enum<RANDOM_FACTION_MODE>(RANDOM_FACTION_MODE::DE
20160730 01:23:15< gfgtdf_> FAULT)
20160730 01:23:44< gfgtdf_> celmin, iceiceice: wait some bas copying was goin on here lte me try again
20160730 01:24:04< celmin> gfgtdf_: Seems to me that could be fixed by making the argument type "typename T::type" instead of "T".
20160730 01:24:12< gfgtdf_> celmin, iceiceice: the problem it currently has is that just writing like cfg["random_faction_mode"].to_enum(RANDOM_FACTION_MODE::DEFAULT) doesnt work becasue RANDOM_FACTION_MODE::DEFAULT is of type RANDOM_FACTION_MODE::type and not RANDOM_FACTION_MODE so you need to write cfg["random_faction_mode"].to_enum<RANDOM_FACTION_MODE>(RANDOM_FACTION_MODE::DEFAULT)
20160730 01:24:12-!- gfgtdf [~chatzilla@x4e36ada5.dyn.telefonica.de] has quit [Ping timeout: 240 seconds]
20160730 01:24:25-!- gfgtdf_ is now known as gfgtdf
20160730 01:24:28< celmin> Though that would require you to pass blah.v in the case that the default is in another variable.
20160730 01:25:22-!- Bonobo [~Bonobo@2001:44b8:254:3200:cc57:56a5:da52:6bc] has joined #wesnoth-dev
20160730 01:26:27< gfgtdf> celmin: so the though how to fix that was to make RANDOM_FACTION_MODE::type a custom type (that coantains a reference to RANDOM_FACTION_MODE) and thigs like RANDOM_FACTION_MODE::DEFAULT constexpr variables
20160730 01:26:48< gfgtdf> celmin: well im unsure whether it can deduce TYPE that way
20160730 01:26:55< gfgtdf> celmin	Though that would require you to pass blah.v in the case that the default is in another variable.
20160730 01:27:17< gfgtdf> celmin: so solve this we coudl maybe just use 2 overloads for t::type and one for just T
20160730 01:27:42< celmin> Oh right, you're not passing the template arguments explicitly...
20160730 01:28:27< celmin> That said, if the compiler can deduce from that, it'd be great.
20160730 01:34:22-!- gfgtdf [~chatzilla@x4e363799.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]]
20160730 01:35:18-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160730 01:53:18< mattsc> S!eekogel
20160730 01:53:31< mattsc> grmp@#%#$
20160730 02:05:06-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160730 02:06:26-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160730 02:07:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160730 02:07:39-!- wedge010 is now known as wedge009
20160730 02:13:22-!- travis-ci [~travis-ci@ec2-54-211-101-95.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 02:13:23< travis-ci> wesnoth/wesnoth#10005 (boost_trimming - 071eee1 : Charles Dang): The build is still failing.
20160730 02:13:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148467311
20160730 02:13:23-!- travis-ci [~travis-ci@ec2-54-211-101-95.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 02:24:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160730 02:54:02< irker680> wesnoth: Gregory A Lundberg wesnoth:master b06432810259 / data/lua/wml-tags.lua: New features for [role] https://github.com/wesnoth/wesnoth/commit/b064328102594473965a2b884d5795d551bc163c
20160730 02:54:04< irker680> wesnoth: Gregory A Lundberg wesnoth:master a72c68547fd0 / src/game_events/action_wml.cpp: Add a comment to the C++ https://github.com/wesnoth/wesnoth/commit/a72c68547fd0941274e329e0b0fcbf26a30d5572
20160730 02:54:06< irker680> wesnoth: Gregory A Lundberg wesnoth:master 585412a22239 / data/campaigns/An_Orcish_Incursion/utils/macros.cfg: AOI Update macros for new auto_recall sub-tag https://github.com/wesnoth/wesnoth/commit/585412a222393d7487af4462a575fcf03776fe26
20160730 02:54:08< irker680> wesnoth: Gregory A Lundberg wesnoth:master 346d8ceac5bb / data/campaigns/Liberty/scenarios/04_Unlawful_Orders.cfg: L S04 Update for new auto_recall sub-tag https://github.com/wesnoth/wesnoth/commit/346d8ceac5bb101d25b81360db75b51fc067379f
20160730 02:54:10< irker680> wesnoth: Gregory A Lundberg wesnoth:master 2a3a3fdd7ba8 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/2a3a3fdd7ba824a619a8756924d8a6fca9fa0cb9
20160730 02:54:12< irker680> wesnoth: Celtic Minstrel wesnoth:master e8d148bec4c2 / / (5 files in 5 dirs): Merge pull request #698 from GregoryLundberg/GL_role https://github.com/wesnoth/wesnoth/commit/e8d148bec4c2749d8ab094411405b5f48e9fc3f1
20160730 02:54:48< celticminstrel> So vultraz, what was the status on the Boost stuff?
20160730 02:55:10< celticminstrel> Oh, the build's still failing, huh...
20160730 02:55:36< celticminstrel> ...right, the regex issue.
20160730 02:55:43< celticminstrel> Shall we go back to Boost regex?
20160730 02:56:02< celticminstrel> At least for now.
20160730 02:56:05< vultraz> only if you think bumping to 4.9 is worse
20160730 02:56:12< vultraz> then please revert the commit
20160730 02:56:24< vultraz> also could you deal with the squashing while youre at it
20160730 02:56:28-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20160730 02:56:36-!- shadowm_laptop [~ignacio@wesnoth/developer/shadowm] has quit [Client Quit]
20160730 02:57:26< celticminstrel> I think bumping to 4.9 isn't something to do on the spur of the moment.
20160730 02:57:45< celticminstrel> Especially not when the primary motivation is so that we can use std::regex.
20160730 03:02:08-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160730 03:03:25< tad_> In HttT I noticed Li'sar lost her ellipsis when she took the scepter. Digging in, I can't see any issue. So I tried 'unit advances=1
20160730 03:04:02< tad_> Same thing, lost ellipsis. So I repeated on Kalenz and he, too, lost his ellipsis on advance=1
20160730 03:04:44< celticminstrel> Weird...
20160730 03:04:51< celticminstrel> Is this on master?
20160730 03:04:56< celticminstrel> Or 1.13.5?
20160730 03:05:12< celticminstrel> Though I guess there's not yet much difference between them.
20160730 03:05:16< tad_> sync'd about 2 hours ago .. just after I did the changelog push 
20160730 03:05:22< celticminstrel> So master?
20160730 03:05:29< tad_> YEs
20160730 03:05:48< celticminstrel> We should check if it's in 1.13.5 and put it in release notes if so, then.
20160730 03:06:11< tad_> I and in S17, debug mode, shroud off, turn 1 start.
20160730 03:06:31< celticminstrel> "unit advances=1" isn't quite the same as getting the sceptre though... that'd be an effect probably...?
20160730 03:06:41< celticminstrel> What about getting storm tridents?
20160730 03:06:43< tad_> I noticed the issue a couple days ago but am only digging in today.
20160730 03:07:16< celticminstrel> Or holy water or other items.
20160730 03:07:27< tad_> Storm tridents I see no visual changes. But they're just Loyal, not Heros.
20160730 03:07:39< celticminstrel> Oh, so it only happens on heros?
20160730 03:07:44< tad_> nods
20160730 03:07:57< celticminstrel> So, what about giving a hero the holy water?
20160730 03:08:05< tad_> That's why I tried Kalenz. He is L2 as I'm testing so has a step to go.
20160730 03:08:45< celticminstrel> Wait, he's L2, so he becomes L3, so it's not an AMLA...
20160730 03:08:54< tad_> Correct.
20160730 03:09:05< tad_> Same for Li'sar. L2 to L3 no ALMA
20160730 03:09:21< celticminstrel> I assume they do initially show the correct hero ellipses.
20160730 03:09:25< tad_> Delfador is L5 and ALMA and no effect if I advance=1 he still has ellipsis
20160730 03:09:31< tad_> Yes.
20160730 03:09:50< celticminstrel> If you go into the inspector after they've lost the ellipse, what's the value of the ellipse key for that unit?
20160730 03:10:14< tad_> I thought that was it but when Li'sar canges from canrecruit/side=2 to hero/side=1 she gets loyal band and hero ellipsis .. only goes if she takes scepter or advances.
20160730 03:10:16< celticminstrel> I don't know exactly how heroness is handled actually...
20160730 03:10:50< tad_> All I see is an attribute for the ellipsis.
20160730 03:10:57< celticminstrel> So, empty?
20160730 03:11:05< tad_> The macro sets Loyal band overlay and Hero ellispsis\
20160730 03:11:19< celticminstrel> Which file?
20160730 03:11:37< tad_> It is pointy on screen (hero elipsis) and after the change (Scepter or advance) goes to empty/default ""
20160730 03:11:38< celticminstrel> Found it.
20160730 03:11:41< tad_> i sec
20160730 03:11:52< celticminstrel> Ah, right, so ellipse is a prefix.
20160730 03:12:22< tad_> Let me check 1.12.5 .. need a few mins to run up to the point where I can test.
20160730 03:12:42< celticminstrel> Okay. So, customizations to ellipse are not kept on level-up.
20160730 03:13:21< celticminstrel> When they lose the ellipse, does it mean they have no ellipse, or the default ellipse?
20160730 03:13:21< tad_> That is my theory. Don't see any WML for it. HAve not looked at Lua, yet.
20160730 03:13:53< tad_> When I say "lost" I mean the inspect showed a pathname then it showed an empty string
20160730 03:14:10< celticminstrel> I was asking about what it looks like.
20160730 03:14:28< tad_> On screen, the hero is a star. Normal a ring
20160730 03:14:30< Aginor> 10:23 < iceiceice> maybe the graphics pipeline is thread safe in some way
20160730 03:14:36< Aginor> It most definitively isn't
20160730 03:14:46< celticminstrel> So after level-up, the hero's ellipse becomes a normal ring?
20160730 03:15:22< tad_> Correct.
20160730 03:15:39< Aginor> 10:28  * vultraz wishes we could throw many moniez at Aginor
20160730 03:15:49< Aginor> Wouldn't work, this is just a hobby ;)
20160730 03:16:06< celticminstrel> I want to say "ellipse changes should be applied via effects", but that means breaking compatibility.
20160730 03:16:22< celticminstrel> So I guess something needs to be tweaked in the unit rebuild code.
20160730 03:16:41< celticminstrel> I suppose AMLAs don't do a full rebuild. No need for it after all.
20160730 03:16:53< tad_> that's my guess. let me finish checking 1.12.5 so we know it it's a regression problem
20160730 03:17:03< celticminstrel> Alternatively, something could be tweaked in the unit creation code...
20160730 03:17:17< celticminstrel> Rebuild's probably better overall...
20160730 03:17:25< celticminstrel> Since the other way wouldn't support modify_unit.
20160730 03:19:14< tad_> There is a macro {ISHERO} which is commonly used to set it. data/core/macros
20160730 03:20:00< celticminstrel> The reason it would break backwards compatibility is because of addons that might have defined similar macros for other similar effects.
20160730 03:20:53< tad_> OK. Problem was introduced after 1.12.5.  unit advances=1 on Kalenz does not remove hero ellipsis.
20160730 03:21:10< tad_> Still running in to Li'sar takes scepter to confirm there.
20160730 03:23:24< celticminstrel> The scepter is done with [object], right?
20160730 03:23:35< tad_> Sorta
20160730 03:23:36< celticminstrel> And just adds an attack or so?
20160730 03:23:41< tad_> it's just a unit variation
20160730 03:23:51< celticminstrel> Oh, that explains why there's a rebuild.
20160730 03:24:10< tad_> confirmed, 1.12.5 does NOT lose hero ellipsis under either case I've noted.
20160730 03:24:43< celticminstrel> To make sure it's not forgotten, it would be good to file this on GNA.
20160730 03:24:55< tad_> Getting the scepter event just changes the profile pic and the object jsut sets the unit variation.
20160730 03:25:59< tad_> I don't have a GNA account and have been really resisting getting one.
20160730 03:26:04< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming fc9783862630 / src/ (4 files in 4 dirs): Use raw string literals for regex https://github.com/wesnoth/wesnoth/commit/fc97838626306bffca834636bb641bf3d53cf0ea
20160730 03:26:06< celticminstrel> Ah.
20160730 03:26:06< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming ad7daee4a820 / src/gui/ (auxiliary/field.hpp core/event/dispatcher_private.hpp): Remove a few more uses of Boost type traits and enable_if https://github.com/wesnoth/wesnoth/commit/ad7daee4a820b8828f99e8d0da8ad3543d9a3250
20160730 03:26:08< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming d1728ea0c57e / src/ (config.cpp gui/dialogs/lobby/lobby.cpp server/server.cpp): Remove some instances of boost::ref https://github.com/wesnoth/wesnoth/commit/d1728ea0c57ecdefb726c95edd4c76080b53a14a
20160730 03:26:10< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming 8fa73053b872 / src/ (6 files in 3 dirs): Remove a couple more MSVC 2008 workarounds https://github.com/wesnoth/wesnoth/commit/8fa73053b872dbccc4b0a8387a56857ab865c918
20160730 03:26:12< irker680> wesnoth: Charles Dang wesnoth:boost_trimming d778db8af628 / src/ (38 files in 10 dirs): Convert uses of boost integer types to their stdlib equivalents https://github.com/wesnoth/wesnoth/commit/d778db8af62897f76d5ca942b52d4b2fc87ef486
20160730 03:26:15< irker680> wesnoth: Charles Dang wesnoth:boost_trimming 0ecaa7851396 / src/ (8 files in 4 dirs): Use initializer lists in place of remaining boost::asign::list_of cases https://github.com/wesnoth/wesnoth/commit/0ecaa78513961b05a582972555c7a25f2afb0df4
20160730 03:26:18< irker680> wesnoth: Charles Dang wesnoth:boost_trimming 649b65d2aebf / src/tools/sdl2/window.cpp: Convert remaining boost::lexical_cast cases to our own implementation (extension https://github.com/wesnoth/wesnoth/commit/649b65d2aebf3ba1b7406cc62ea67a157b4ed075
20160730 03:26:21< irker680> wesnoth: Charles Dang wesnoth:boost_trimming 7ccbd53a7aa6 / src/ (serialization/string_utils.hpp server/server.cpp): Convert cases of boost::next to std::next https://github.com/wesnoth/wesnoth/commit/7ccbd53a7aa665fde793fb974d1a912568558203
20160730 03:26:23< celticminstrel> vultraz: Shall we merge that now?
20160730 03:26:24< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming 7212e5963dff / src/ (3 files in 3 dirs): Replace boost map_list_of with C++11 initializers https://github.com/wesnoth/wesnoth/commit/7212e5963dffde27fbcaa1c5c7c11b06db5f1227
20160730 03:26:26< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming ad4fe895e9b7 / src/ (7 files in 5 dirs): Remove use of boost::unordered_map https://github.com/wesnoth/wesnoth/commit/ad4fe895e9b71e8336584e1eb73d8dc9fad42174
20160730 03:26:28< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming b54ea23774bf / src/ (4 files in 3 dirs): Remove uses of boost::array https://github.com/wesnoth/wesnoth/commit/b54ea23774bf2b03444bc460523499a751805e76
20160730 03:26:30< irker680> wesnoth: Celtic Minstrel wesnoth:boost_trimming 38d7f7169ff6 / src/ (map/location.cpp units/unit.cpp variable_info_detail.hpp): Remove a few other miscellanous Boost uses https://github.com/wesnoth/wesnoth/commit/38d7f7169ff678f6acb1c183fca0247841b7ef9d
20160730 03:26:32< irker680> wesnoth: Charles Dang wesnoth:boost_trimming 8a8316a9b8c2 / src/ (game_events/conditional_wml.cpp play_controller.cpp team.cpp team.hpp): Convert uses of boost::flat_set to std::set https://github.com/wesnoth/wesnoth/commit/8a8316a9b8c28093a3009152a9d6697e99f16206
20160730 03:26:35< irker680> wesnoth: Charles Dang wesnoth:boost_trimming 82973000a0fa / src/ (5 files in 3 dirs): Convert gui2::tvisible and gui2::tredraw_action to scoped enums https://github.com/wesnoth/wesnoth/commit/82973000a0fa3dae5e1949988d34377f152117b8
20160730 03:26:39< celticminstrel> Maybe mute the bot first...
20160730 03:26:54< celticminstrel> Since merging'll just result in a duplicate of what it just sent.
20160730 03:27:08< celticminstrel> Plus all the other stuff in the branch.
20160730 03:31:13< celticminstrel> Oh right, you should double-check that it still builds first.
20160730 03:32:17< tad_> Nah, commit with 12,327 errors and freak us all out when we sync
20160730 03:32:58< celticminstrel> The only possible errors would be conflict resolution errors, which would be more like 5 or 6 at most.
20160730 03:36:33-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160730 03:40:25< tad_> OK, for now, I'm noting the problem in my fork issues. I think I'll work the problem for a couple hours and see if I can find the problem.
20160730 03:40:38-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160730 03:58:14-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 03:58:15< travis-ci> wesnoth/wesnoth#10007 (boost_trimming - 8297300 : Charles Dang): The build was fixed.
20160730 03:58:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148481177
20160730 03:58:15-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 04:17:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160730 04:22:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160730 04:29:50-!- Kwandulin [~Miranda@p200300760F60623348A1CC32B4C49A52.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160730 04:44:31-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160730 04:47:41< vultraz> celticminstrel: let us merge :D
20160730 04:48:11< celticminstrel> Okay.
20160730 04:48:25< celticminstrel> Are you muting the bot first or not?
20160730 04:48:37< vultraz> not sure how to
20160730 04:48:44< vultraz> shadowm: around to mute bots?
20160730 04:49:48-!- mode/#wesnoth-dev [+q irker*!*@*] by ChanServ
20160730 04:50:30< vultraz> ty ty
20160730 04:52:57< celticminstrel> I've thrown the regex commit into the boost_trimming branch.
20160730 04:53:30< celticminstrel> It might potentially make things easier later if we want to switch to std::regex... assuming anyone remembers it's there.
20160730 04:53:46< vultraz> alright
20160730 04:53:48< vultraz> thanks
20160730 04:54:19< celticminstrel> So should we merge spixi's now, or await further discussion?
20160730 04:54:29< vultraz> this was certainly productive code cleanup
20160730 04:54:35< vultraz> thousands of lines removed
20160730 04:55:02< vultraz> bot can be unquieted now
20160730 04:55:13< celticminstrel> Huh? Thousands of lines removed? o.o
20160730 04:55:57< vultraz> yeah, boost_trimmings was +1,403 −4,252 
20160730 04:57:00< vultraz> don't the conflicts have to be fixed in spixi's PR?
20160730 04:57:03< celticminstrel> Oh wow, you're right.
20160730 04:57:15< celticminstrel> Yeah, the conflicts need to be fixed, but I could do that myself.
20160730 04:57:23< vultraz> oh, that reminds me
20160730 04:57:27< celticminstrel> The wow as at the diffstat.
20160730 04:57:46< vultraz> that commit where I clamped font scaling
20160730 04:57:51< vultraz> it's in my fork
20160730 04:58:01< vultraz> I wonder if it's possible to pull a single commit from there
20160730 04:58:13< celticminstrel> git cherry-pick id_of_commit
20160730 04:59:24< celticminstrel> Of course the commit needs to exist in your repo first, but since it's your commit it presumably does.
20160730 04:59:31< vultraz> and indeed, the diff for b_t is huge
20160730 04:59:45< vultraz> so much cleanup was done; it's very satisfying
20160730 05:00:00< vultraz> shadowm: could you -q the bot?
20160730 05:01:43< celticminstrel> Oh, three files were deleted. That's why the LoC is so high.
20160730 05:02:15< vultraz> they weren't huge files, though
20160730 05:02:51< vultraz> anyway, if you can fix the conflicts feel free to merge spixi's pr
20160730 05:03:08< ancestral> Crap I might have made a mistake
20160730 05:03:20< ancestral> I thought I was only pushing one file… grrrr
20160730 05:03:30< vultraz> what have you done
20160730 05:03:35< ancestral> I don’t know
20160730 05:04:09< ancestral> I did a dry-run and it said only one file
20160730 05:04:42< vultraz> merge commit
20160730 05:05:46< vultraz> ancestral: should be alright
20160730 05:05:50-!- mode/#wesnoth-dev [-q irker*!*@*] by ChanServ
20160730 05:06:07< celticminstrel> Merging spixi's now.
20160730 05:06:17< ancestral> vultraz: I didn’t screw anything up?
20160730 05:06:27< celticminstrel> Accidentally tried with 610 instead of 710. Fortunately that was already merged.
20160730 05:06:30< vultraz> ancestral: nah, merge commits are pretty standard
20160730 05:06:36< ancestral> phew
20160730 05:06:43< celticminstrel> I don't know what's going on with ancestral so I have no idea.
20160730 05:06:53< ancestral> https://github.com/wesnoth/wesnoth/commits/master
20160730 05:07:15< celticminstrel> I see.
20160730 05:07:17< ancestral> I meant to push a change to the RELEASE_NOTES
20160730 05:07:23< vultraz> celticminstrel: I think his HEAD wasn't up-to-date, so he pulled, generated a merge commit, then pushed his commit + the merge commit
20160730 05:07:28< celticminstrel> Yeah.
20160730 05:07:37< celticminstrel> Would prefer not to have that kind of merge commit, honestly.
20160730 05:07:45< vultraz> yes
20160730 05:07:56< celticminstrel> Ah, but it's already on master, huh?
20160730 05:07:57< vultraz> but then again, we generate them every time we merge PRs through the web interface
20160730 05:08:04< celticminstrel> That's different.
20160730 05:08:08< celticminstrel> It's the direction.
20160730 05:08:24< celticminstrel> Oh well.
20160730 05:08:29< vultraz> really, it's NBD
20160730 05:08:35< celticminstrel> Huh?
20160730 05:08:36< ancestral> So how would I do this in the future? If I have a change to a file but the branch gets changed?
20160730 05:08:47< celticminstrel> git pull --rebase if using command-line.
20160730 05:08:51< ancestral> Okay
20160730 05:09:00< ancestral> I’ll remember that
20160730 05:09:06< celticminstrel> That requires you to stash or commit any outstanding changes first.
20160730 05:09:12< ancestral> It does
20160730 05:09:17< ancestral> I hate stashing
20160730 05:09:22< celticminstrel> https://github.com/wesnoth/wesnoth/commit/17edeed0291997584592e80fc0eabbb38bed57e8
20160730 05:09:23< ancestral> Ah well
20160730 05:09:44< celticminstrel> Comitting works too. You could always delete the commit afterwards (with git reset HEAD^)
20160730 05:09:55 * celticminstrel is just posting that because the bot is still muted.
20160730 05:09:58-!- JyrkiVesterinen [~JyrkiVest@87-100-205-123.bb.dnainternet.fi] has joined #wesnoth-dev
20160730 05:10:07< vultraz> the bot was umuted..
20160730 05:10:09< vultraz> where is it :/
20160730 05:10:11< celticminstrel> Ah, that wasn't the commit I wanted to post.
20160730 05:10:25< celticminstrel> Oh, it was? I don't get the messages when things are muted or unmuted.
20160730 05:10:36< vultraz> [16:05:45]	=-=	Mode #wesnoth-dev -q irker*!*@* by ChanServ
20160730 05:10:39< celticminstrel> My client swallows them because it doesn't know what they are.
20160730 05:10:52< vultraz> you have not pushed
20160730 05:10:56< celticminstrel> Me?
20160730 05:11:04< vultraz> i just pulled, only ancestral's change came through
20160730 05:11:09< celticminstrel> Yes, I haven't/
20160730 05:11:21< ancestral> I have nothing else to push right now
20160730 05:11:32< ancestral> Except maybe the Xcode project file, but I’ll wait until after 1.13.5
20160730 05:11:44< celticminstrel> I have an edit to push for that actually.
20160730 05:11:48< vultraz> why wait?
20160730 05:11:52< celticminstrel> Discovered a missing file.
20160730 05:12:11< vultraz> we release on the tag, not master
20160730 05:12:25< celticminstrel> ancestral: What are the XCode changes?
20160730 05:13:01< celticminstrel> vultraz: Plus the release is already done, apart from packaging.
20160730 05:13:09< vultraz> yes
20160730 05:13:28< ancestral> Renamed wesnoth libraries for libboost and using latest SDK instead of 10.7
20160730 05:13:36< celticminstrel> Ah.
20160730 05:13:54< celticminstrel> I guess you reverted the template backtrace then. (Which is fine.)
20160730 05:13:58< ancestral> libboost_iostreamw.dylib -> libboost_iostream-mt.dylib or some such thing
20160730 05:14:05< vultraz> celticminstrel: are you about to push?
20160730 05:14:10< vultraz> I have a commit here
20160730 05:14:30< celticminstrel> vultraz: Go ahead.
20160730 05:14:41< celticminstrel> I've already aborted the merge due to ancestral's push.
20160730 05:14:52< ancestral> :-(
20160730 05:14:53< celticminstrel> So you might as well push now while I still haven't pulled.
20160730 05:15:03< irker680> wesnoth: Charles Dang wesnoth:master 13da8dac077c / src/ (preferences.cpp preferences.hpp video.cpp): Slight refactoring of default prefs value storage, and clamp font scaling https://github.com/wesnoth/wesnoth/commit/13da8dac077cf371a8411551f9338c39c73baf42
20160730 05:15:55< celticminstrel> I aborted because I needed to update the base for the merge, because "git pull --rebase" when there's a merge commit is a bad idea.
20160730 05:16:19< celticminstrel> Here's the commit I meant to link, BTW: https://github.com/wesnoth/wesnoth/commit/3a428e8adfb43d20ef219992b4f345ae3786eb22
20160730 05:16:36< vultraz> ah, I saw that
20160730 05:16:51< vultraz> I think it's awesome we've fixed most of the long-standing bugs :)
20160730 05:17:06< celticminstrel> Okay, initiating the merge now, please don't push anything.
20160730 05:17:36< celticminstrel> (Oh, when I said it's a bad idea with a merge commit, that's when the merge commit is on your side. No problem with merge commits being pulled.)
20160730 05:17:56< ancestral> Hey, my change!
20160730 05:18:00< celticminstrel> ?
20160730 05:18:03< ancestral> You found it :-P
20160730 05:18:20< celticminstrel> Yeah, by clicking github's convenient "parent commit" link.
20160730 05:18:55< ancestral> Yeah the trackpad clicking I totally get
20160730 05:19:05< celticminstrel> Hmm, is <memory> currently included in game_events/handlers.hpp, or was that added in the merge...
20160730 05:19:23< ancestral> Not sure what the fix for that is, but it’s probably some sort of setting. SDL2 thing, perhaps?
20160730 05:19:36< celticminstrel> No idea what you're talking about...
20160730 05:19:44< vultraz> ancestral: can you close this if it's fixed https://gna.org/bugs/index.php?23559
20160730 05:20:30< celticminstrel> Well, it should've probably been included in the first place, so whatever, I'll leave it.
20160730 05:20:51< celticminstrel> Though people looking at the diff might wonder why there are random added <memory>.
20160730 05:20:54< ancestral> I really hate Gna’s authentication
20160730 05:21:00< ancestral> I can’t be signed in for liek more than 4 hours
20160730 05:21:06< vultraz> heh
20160730 05:21:13< ancestral> Even when I click that box that says forever
20160730 05:21:15< celticminstrel> Really?
20160730 05:21:16< vultraz> I'm working to move us to GH's tracker
20160730 05:21:33< celticminstrel> vultraz: Didn't GH's tracker lack some essential features?
20160730 05:21:54< vultraz> Attachments are varied enough now.
20160730 05:22:21< celticminstrel> Is that the only thing?
20160730 05:22:26< ancestral> vultraz: Closed
20160730 05:22:56< ancestral> vultraz: Does GH support images and attachments?
20160730 05:23:07< irker680> wesnoth: Spixi wesnoth:master 5588642c81f8 / / (14 files in 7 dirs): Allow firing an event by id instead of name. https://github.com/wesnoth/wesnoth/commit/5588642c81f84ea3c2e24e597eb9b69dce7e5ccb
20160730 05:23:09< irker680> wesnoth: Celtic Minstrel wesnoth:master dc3d22a5e468 / / (14 files in 7 dirs):  Merge pull request #710 from spixi/call_events_by_id https://github.com/wesnoth/wesnoth/commit/dc3d22a5e468c66aa537f4b7f2bfd89f7ee0d179
20160730 05:23:10< vultraz> yes
20160730 05:23:33 * celticminstrel likes mimicking github's merge commit message format. >_>
20160730 05:23:36< vultraz> at least, of certain types
20160730 05:23:37< ancestral> I remember that being something shadowm said was a reason for not switching in the past
20160730 05:23:48< celticminstrel> I guess he never fixed the bad indent, but whatever.
20160730 05:25:17< celticminstrel> I personally have no problem with switching to github's tracker, but if it makes other people less interested in submitting bugs, then that would be bad.
20160730 05:25:42< vultraz> I think it's a great balance between that and GNA's 2000 interface
20160730 05:26:02< celticminstrel> GNA is pretty dated-looking, yeah.
20160730 05:26:16< vultraz> using GH will make everything easier
20160730 05:26:26< celticminstrel> For devs, yes.
20160730 05:26:32< celticminstrel> For reporters, though?
20160730 05:26:58< celticminstrel> ...well, I guess we know one person who'd be more likely to file bugs if it was on github.
20160730 05:26:59< vultraz> ancestral: https://gna.org/bugs/index.php?24578 resolved?
20160730 05:27:15< celticminstrel> Speaking of filing bugs, does anyone want to file the one he reported?
20160730 05:27:21< vultraz> which one?
20160730 05:27:32< celticminstrel> Losing custom ellipses on level-up.
20160730 05:27:44< celticminstrel> When they were set via [unit]ellipse
20160730 05:27:51< vultraz> hm
20160730 05:27:52< ancestral> Ah yes, a reminder to myself! Thank goodness
20160730 05:27:55< vultraz> yes, that is a bug
20160730 05:28:02< celticminstrel> Though it might be very easy to fix, not sure.
20160730 05:28:36< ancestral> I was thinking about that earlier today. I forgot I made a bug for myself.
20160730 05:28:45< celticminstrel> You don't need to tell me it's a bug. I already knew that. :P
20160730 05:29:00< celticminstrel> ancestral: Are you saying you noticed the ellipses too?
20160730 05:29:09< vultraz> no, the cocoa notifications thng
20160730 05:29:12< vultraz> I think
20160730 05:29:25< ancestral> Correct
20160730 05:30:38< ancestral> celticminstrel: Actually, if you have an idea how to fix https://gna.org/bugs/index.php?24578 that’d be nice. Maybe it’s just a variable scope thing?
20160730 05:30:49< celticminstrel> I forgot where the missing file was in XCode...
20160730 05:30:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160730 05:31:46< vultraz> celticminstrel: oh, btw, did the attack dialog look better for you after those changes
20160730 05:31:52< celticminstrel> Haven't looked yet.
20160730 05:32:00< vultraz> k
20160730 05:32:03< celticminstrel> I won't be looking tonight, most likely.
20160730 05:32:21< vultraz> pretty sure it does
20160730 05:32:53< celticminstrel> I expect it to as well.
20160730 05:33:48< vultraz> as soon as the build finishes, I'll commit that change to make the lua console fullscreen
20160730 05:34:30< celticminstrel> Might actually be nice for the Lua console to be semitransparent, but that's not something to do at this time.
20160730 05:35:06< vultraz> why not?
20160730 05:35:21< celticminstrel> I dunno...
20160730 05:35:32< celticminstrel> I feel like it might be slow or something?
20160730 05:35:39< celticminstrel> Maybe I'm just making this up.
20160730 05:35:46 * vultraz shrugs
20160730 05:35:54< vultraz> it'd take a bit of coding on my part
20160730 05:36:58-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 05:36:59< travis-ci> wesnoth/wesnoth#10009 (boost_trimming - b61e042 : Charles Dang): The build was broken.
20160730 05:36:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148487344
20160730 05:36:59-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 05:37:21< vultraz> aww
20160730 05:37:42< vultraz> y u do dis travis
20160730 05:40:09< JyrkiVesterinen> 20160729 22:57:45< celmin> The mute PR was supposed to be changed to pause instead...
20160730 05:40:09< JyrkiVesterinen> 20160729 22:57:56< celmin> (Or I suppose, offering both options? I dunno.)
20160730 05:40:15< JyrkiVesterinen> I did that back in June 30.
20160730 05:40:26< celticminstrel> Whoa, I guess I missed it...
20160730 05:40:32< celticminstrel> Sorry.
20160730 05:41:06< JyrkiVesterinen> Not a big deal. It doesn't matter too much to me when my PRs are merged (as long as they're merged in the end). :)
20160730 05:42:49< vultraz> oh wait, that's on b_t
20160730 05:42:51< vultraz> derp
20160730 05:42:55< vultraz> of course it broke
20160730 05:42:56< celticminstrel> ?
20160730 05:42:59< celticminstrel> Oh, right.
20160730 05:43:10< celticminstrel> Yeah, that is indeed expected then.
20160730 05:45:08< vultraz> ahhh
20160730 05:45:13< vultraz> I've just discovered something awesome
20160730 05:45:16< celticminstrel> ?
20160730 05:45:16< vultraz> in n++
20160730 05:45:22< vultraz> if you use tab/shift+tab
20160730 05:45:27< vultraz> it converts spaces to tabs 
20160730 05:45:30-!- JyrkiVesterinen [~JyrkiVest@87-100-205-123.bb.dnainternet.fi] has quit [Read error: Connection reset by peer]
20160730 05:45:40< celticminstrel> Uh, okay.
20160730 05:46:45-!- JyrkiVesterinen [~JyrkiVest@87-100-205-123.bb.dnainternet.fi] has joined #wesnoth-dev
20160730 05:47:45< irker680> wesnoth: Charles Dang wesnoth:master fbef58a29ae6 / data/gui/window/lua_interpreter.cfg: Lua console: made window fullscreen and cleaned up layout code https://github.com/wesnoth/wesnoth/commit/fbef58a29ae6eee3c98490582b861b50a5735e5c
20160730 05:48:46< vultraz> celticminstrel: are we merging 674?
20160730 05:48:52< celticminstrel> Which?
20160730 05:48:57< vultraz> the sound pr
20160730 05:49:05< celticminstrel> Sure.
20160730 05:49:16 * vultraz does so
20160730 05:49:23< irker680> wesnoth: Jyrki Vesterinen wesnoth:master bf510e788632 / src/ (game_launcher.cpp game_launcher.hpp sound.cpp sound.hpp): Pause the music when the game loses focus https://github.com/wesnoth/wesnoth/commit/bf510e78863202222bb67d4cc4f210bc908381be
20160730 05:49:25< irker680> wesnoth: Jyrki Vesterinen wesnoth:master 31871daa7168 / src/ (preferences.cpp preferences.hpp sound.cpp): Make it a preference whether music should be muted in background https://github.com/wesnoth/wesnoth/commit/31871daa71681a23549764bb02d9a9dcdeea9f15
20160730 05:49:27< irker680> wesnoth: Jyrki Vesterinen wesnoth:master b7b6531a6f0a / data/gui/window/preferences/04_sound.cfg src/gui/dialogs/preferences_dialog.cpp: Add a checkbox for the "stop music in background" preference https://github.com/wesnoth/wesnoth/commit/b7b6531a6f0aec67ad2613de5714e31ca016adce
20160730 05:49:29< irker680> wesnoth: Charles Dang wesnoth:master 56e2a733e50e / / (8 files in 3 dirs): Merge pull request #674 from jyrkive/mute-in-background https://github.com/wesnoth/wesnoth/commit/56e2a733e50e70d0132d4310c3363132d5c3298f
20160730 05:49:49< celticminstrel> Does it have a changelog entry?
20160730 05:49:57< celticminstrel> (And players_changelog.)
20160730 05:50:09< vultraz> doesn't look like that
20160730 05:50:21< celticminstrel> And spixi's?
20160730 05:50:30< vultraz> I think that one did
20160730 05:50:52< celticminstrel> Make sure it didn't accidentally add it to 1.13.4.
20160730 05:51:22< celticminstrel> Or I can do that I guess.
20160730 05:51:25< celticminstrel> If you don't want to.
20160730 05:51:37< vultraz> there's no changelog change in the commits
20160730 05:51:41< vultraz> no need to check
20160730 05:51:42< celticminstrel> Okay.
20160730 05:52:01< celticminstrel> Thinking back, was there anything else we merged that needed one...
20160730 05:52:12< celticminstrel> Tad's had one, and it was in the right place because it was only just added today.
20160730 05:53:23< celticminstrel> Found it. game_version.hpp
20160730 05:53:43< vultraz> how many things has JyrkiVesterinen done now?
20160730 05:54:02< celticminstrel> Go to wesnoth page, click Commits, and then his name.
20160730 05:54:19< celticminstrel> That'll answer your question.
20160730 05:54:45< JyrkiVesterinen> Or you can view my PRs: https://github.com/wesnoth/wesnoth/pulls?q=is%3Apr+is%3Aclosed+author%3Ajyrkive
20160730 05:54:56< celticminstrel> Sure.
20160730 05:55:25< vultraz> I think I'll give him push access
20160730 05:55:36< celticminstrel> You mean offer him push access.
20160730 05:55:46< vultraz> Eh, right
20160730 05:56:23< vultraz> JyrkiVesterinen: would you like push access?
20160730 05:56:36< JyrkiVesterinen> Of course. :)
20160730 05:56:52< irker680> wesnoth: Celtic Minstrel wesnoth:master 7caad3d10776 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Add missing header https://github.com/wesnoth/wesnoth/commit/7caad3d107761005476187d578294b8530a73f15
20160730 05:57:31< celticminstrel> I'll fix the crash tomorrow. Probably sleep now.
20160730 05:57:37-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160730 05:57:37-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160730 05:57:54-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 05:57:54< vultraz> JyrkiVesterinen: invite sent
20160730 05:57:55< travis-ci> wesnoth/wesnoth#10010 (master - 17edeed : ancestral): The build has errored.
20160730 05:57:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148488044
20160730 05:57:55-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 05:58:31< celticminstrel> BTW, do credits need any rearranging?
20160730 05:58:40< vultraz> hm?
20160730 05:58:48< celticminstrel> Exactly what I said.
20160730 05:58:55< celticminstrel> But I suppose I can spell it out a bit more.
20160730 05:59:01< vultraz> out of order?
20160730 05:59:06< vultraz> dunnno
20160730 05:59:09< vultraz> who was added recently?
20160730 05:59:11< JyrkiVesterinen> Invite accepted. Thank you! :)
20160730 05:59:14< celticminstrel> Does anyone need to be moved from "Miscellaneous Contributors" to a different section?
20160730 05:59:18< ancestral> JyrkiVesterinen: Congratulations, and thank you for your good work :)
20160730 05:59:50< vultraz> JyrkiVesterinen: indeed. thanks for all your commits. especially fixing that mage of light halo thing.
20160730 06:00:04< celticminstrel> Oh, he was the one who fixed that? I'd forgotten.
20160730 06:01:30< JyrkiVesterinen> I wonder why such a highly visible bug could persist for over half an year in the first place. Did no one just feel like fixing it?
20160730 06:01:47< celticminstrel> That might actually be the case.
20160730 06:02:14< vultraz> JyrkiVesterinen: or no one could figure out how
20160730 06:02:25< celticminstrel> Or no-one was playing anything involving a mage of light.
20160730 06:03:16< vultraz> wesnoth has a sad history of having high-profile bugs sit unresolved for a long time :P
20160730 06:03:34< celticminstrel> Though game-breaking bugs not so much?
20160730 06:03:36< celticminstrel> Usually?
20160730 06:03:39< celticminstrel> I guess sometimes.
20160730 06:06:17< irker680> wesnoth: Charles Dang wesnoth:master db5f497fd7a0 / data/gui/window/logging.cfg: Logging: fixed placement of title https://github.com/wesnoth/wesnoth/commit/db5f497fd7a03458ab9ef707f9ad240cd30751bf
20160730 06:06:33< celticminstrel> So is that a no about the credits?
20160730 06:06:49< celticminstrel> Or did you miss my clarification altogether?
20160730 06:07:11< vultraz> I'll need to check
20160730 06:07:16< celticminstrel> Okay. No hurry.
20160730 06:07:30< celticminstrel> The deadline is the 1.14 release, in my opinion.
20160730 06:07:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160730 06:08:16< celticminstrel> The core author guy doesn't yet have a credits entry, actually...
20160730 06:08:49< vultraz> we need to move cores to prefs at some point
20160730 06:08:56< celticminstrel> At some point, yeah.
20160730 06:09:04< celticminstrel> Oh right, I could update the changelog.
20160730 06:11:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160730 06:12:09< celticminstrel> Though if JyrkiVesterinen wants to update it for the sound thing that would be fine. Normally people add their own changes to the changelog, after all.
20160730 06:12:46< JyrkiVesterinen> Yes, I can add the changelog entry for the sound change.
20160730 06:14:26-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160730 06:14:45< celticminstrel> Pushing my change now.
20160730 06:15:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20160730 06:15:55-!- wedge010 is now known as wedge009
20160730 06:16:54< irker680> wesnoth: Celtic Minstrel wesnoth:master 0b313e8dda2c / changelog: Fix changelog for #710 https://github.com/wesnoth/wesnoth/commit/0b313e8dda2cca725430fbc13f25eafc845a5cb6
20160730 06:17:53< celticminstrel> That reminded me that I dislike his function naming sense. Maybe I'll do something about that later.
20160730 06:20:18< irker680> wesnoth: Jyrki Vesterinen wesnoth:master ed8a9c223b38 / changelog players_changelog: Mention the 'mute music in background' preference in changelog https://github.com/wesnoth/wesnoth/commit/ed8a9c223b3868e9f3d9fd151c064363919de15e
20160730 06:20:41< JyrkiVesterinen> Feels good to push directly. 8-)
20160730 06:21:42< celticminstrel> For a moment the diff confused by the fact that there were no other changes. Then I realized that that was the players_changelog.
20160730 06:23:16-!- celticminstrel is now known as celmin|sleep
20160730 06:27:51-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has quit [Excess Flood]
20160730 06:28:16-!- Jetrel_bot [~Jetrel@ec2.happyspork.com] has joined #wesnoth-dev
20160730 06:46:41-!- mjs-de [~mjs-de@x4e3157fd.dyn.telefonica.de] has joined #wesnoth-dev
20160730 06:58:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 07:01:44-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Ping timeout: 260 seconds]
20160730 07:02:45-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160730 07:02:50-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Client Quit]
20160730 07:05:55-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160730 07:31:09-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160730 07:46:46-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 07:52:48-!- Appleman1234 [~Appleman1@KD036012034015.au-net.ne.jp] has quit [Ping timeout: 276 seconds]
20160730 07:52:57-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160730 07:56:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160730 07:59:11-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160730 08:00:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160730 08:08:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160730 08:18:29-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160730 08:18:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160730 08:20:04-!- Appleman1234 [~Appleman1@KD036012037194.au-net.ne.jp] has joined #wesnoth-dev
20160730 08:20:41-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160730 08:21:30-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 08:23:54-!- zookeeper [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20160730 08:23:54-!- zookeeper [~lmsnie@37.35.27.57] has quit [Changing host]
20160730 08:23:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160730 08:24:50-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160730 08:26:46-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Client Quit]
20160730 08:28:05-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160730 08:30:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 264 seconds]
20160730 08:34:11-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 08:34:12< travis-ci> wesnoth/wesnoth#10016 (master - db5f497 : Charles Dang): The build passed.
20160730 08:34:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148492395
20160730 08:34:12-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 09:04:04-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160730 09:06:00-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160730 09:07:28-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 09:07:29< travis-ci> wesnoth/wesnoth#10017 (master - 0b313e8 : Celtic Minstrel): The build passed.
20160730 09:07:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148493061
20160730 09:07:29-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 09:09:28-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 244 seconds]
20160730 09:17:13-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160730 09:24:12-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 09:24:13< travis-ci> wesnoth/wesnoth#10018 (master - ed8a9c2 : Jyrki Vesterinen): The build passed.
20160730 09:24:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148493510
20160730 09:24:13-!- travis-ci [~travis-ci@ec2-54-167-197-164.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 09:29:10-!- Kwandulin [~Miranda@p200300760F60623348A1CC32B4C49A52.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160730 09:31:46-!- Kwandulin [~Miranda@p200300760F6062A548A1CC32B4C49A52.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160730 09:41:52-!- Kwandulin [~Miranda@p200300760F6062A548A1CC32B4C49A52.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160730 09:44:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160730 09:45:17-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160730 09:48:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160730 09:57:04-!- JyrkiVesterinen [~JyrkiVest@87-100-205-123.bb.dnainternet.fi] has quit [Quit: .]
20160730 10:28:23-!- Kwandulin [~Miranda@p200300760F6062A5B863850D5C2AB109.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160730 10:55:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160730 11:00:42-!- Kwandulin [~Miranda@p200300760F6062A5B863850D5C2AB109.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160730 11:07:34-!- Bonobo [~Bonobo@2001:44b8:254:3200:cc57:56a5:da52:6bc] has quit [Ping timeout: 250 seconds]
20160730 11:16:24< lipkab> Who's good with gettext?
20160730 11:17:06< lipkab> Whoever you are, I've got a bug for you: https://gna.org/bugs/index.php
20160730 11:17:15< shadowm> That's a lot of bugs.
20160730 11:17:33< lipkab> Oh dammit.
20160730 11:17:44< lipkab> https://gna.org/bugs/?24887
20160730 11:18:02< lipkab> ^Here's the correct URL.
20160730 11:23:03< Aginor> that's disenhartening :/
20160730 11:23:47< lipkab> I'm sorry.
20160730 11:24:01< lipkab> I didn't mean to ruin your day.
20160730 11:24:22< Aginor> I'm not feeling terribly summoned, I don't know enough about gettext ;)
20160730 11:25:41< lipkab> :)
20160730 11:25:56< Aginor> your hypothesis seems plausible though
20160730 11:29:06< Aginor> is there an example hello-world like addon I can look at somewhere?
20160730 11:29:45< Aginor> I want to prod some wml with as little effort in learning to set it up as possible, and I don't want to modify the core game files ;)
20160730 11:32:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160730 11:37:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160730 11:58:55-!- Kwandulin [~Miranda@p200300760F6062A504F82161CC687F92.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160730 11:58:59-!- irker680 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160730 12:04:09-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160730 12:04:17< ChipmunkV> crank axes
20160730 12:04:37< Aginor> ChipmunkV?
20160730 12:05:28< ChipmunkV> Aginor: wrong window. Googling how to fix my bike.
20160730 12:05:50< Aginor> I approve of the use of axes
20160730 12:07:24-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160730 12:15:33-!- JyrkiVesterinen [~JyrkiVest@87-100-213-255.bb.dnainternet.fi] has joined #wesnoth-dev
20160730 12:16:04-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160730 12:33:04-!- irker258 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160730 12:33:04< irker258> wesnoth: Charles Dang wesnoth:master 4f7ae24d1b6e / src/ (4 files in 4 dirs): Cleaned up a few useless typedefs I noticed https://github.com/wesnoth/wesnoth/commit/4f7ae24d1b6ebada6635de41587e3079785b6ed0
20160730 12:36:30< vultraz> Aginor: I realized recently that because of a change of mine a few months ago, a brand new install of wesnoth will start in a maximized window. In your opinion, is this acceptable?
20160730 12:37:24< vultraz> (for reference, it used to start in a 1024x768 window)
20160730 12:40:39< loonycyborg> vultraz: For me it's the favorite mode :P
20160730 12:40:57< vultraz> loonycyborg: what do you mean?
20160730 12:41:08< loonycyborg> maximized window
20160730 12:41:28< loonycyborg> only I noticed one thing
20160730 12:41:44< loonycyborg> maximizing will crash wesnoth if screen size is too small
20160730 12:42:01< loonycyborg> that is REALLY small
20160730 12:42:15< loonycyborg> I got that only because I was running it in virtualbox
20160730 12:42:22< vultraz> well that's not the fault of it being maximized, that's the fault of the screen being tiny
20160730 12:44:41< vultraz> JyrkiVesterinen: I have a small task for you, if you're up to it: make it so music fades out (such as when you toggle it off, or a scenario ends) instead of stopping abruptly.
20160730 12:46:05< JyrkiVesterinen> OK, I'll add it to my todo list. :)
20160730 12:52:33< Aginor> vultraz: I think it'd probably be better if it simply remembered what it was the last time
20160730 12:52:44< vultraz> Aginor: brand new install
20160730 12:53:12< Aginor> brand new install makes sense with maximised
20160730 12:53:18< vultraz> ok
20160730 12:53:26< vultraz> good :)
20160730 12:54:01< Aginor> and with that, I bid you good night
20160730 13:06:06-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160730 13:07:30-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 13:07:31< travis-ci> wesnoth/wesnoth#10019 (master - 4f7ae24 : Charles Dang): The build was broken.
20160730 13:07:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148526200
20160730 13:07:31-!- travis-ci [~travis-ci@ec2-54-198-60-9.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 13:24:33< mattsc> zookeeper: in your opinion, are the high XP attacks something the AI should do by default, or should it be added to scenarios as needed?
20160730 13:25:02< zookeeper> i don't really see a reason why it shouldn't be by default
20160730 13:25:37< zookeeper> only some scenarios allow you to cheese your way through them by abusing the problem, but it can arise pretty much anywhere on smaller scale
20160730 13:25:50< zookeeper> s/on/in
20160730 13:25:55< mattsc> Yeah, I’d agree.
20160730 13:27:13< mattsc> I’m asking because the approach is slightly different.  In that case, we want something that works pretty well only the time (it can still be customizable, but the default setting should work at least decently in most any setting)
20160730 13:27:43< mattsc> If it were another MAI, we could make it much more configurable and leave the details to the scenario author.
20160730 13:27:58< mattsc> s/only the time/all the time
20160730 13:29:38< zookeeper> right
20160730 13:30:34< mattsc> I agree though that I would like to see it in the default AI.  I personally consider it one of the biggest problems of the current AI.
20160730 13:32:03< zookeeper> personally, it doesn't seem like the kind of problem that needs a fix with lots of knobs to tweak. as long as it solves the problem by just making some AI units attack anyway, and it doesn't consistently choose the absolutely worst unit for that task, then it should be fine.
20160730 13:33:13< mattsc> yeah, probably
20160730 13:33:58< zookeeper> could it logically be tied to some of the existing AI settings like aggression?
20160730 13:34:12< mattsc> I am worried about some of the conditions in the current implementation like only attack when at least 2 units can attack the enemy or when you have at least 4 units
20160730 13:34:21< mattsc> yes, I think it should be
20160730 13:34:47< mattsc> but then we need to make sure that it is at least generally consistent with those
20160730 13:35:22< mattsc> none of that is fundamentally a problem, just thinking out loud about the things to consider
20160730 13:38:29< irker258> wesnoth: Wedge009 wesnoth:master db248e17745b / src/game_events/pump.cpp: MSVC whinges about named operators and I believe it's convention to use && opera https://github.com/wesnoth/wesnoth/commit/db248e17745b2c678f621becd717f64237de33b2
20160730 13:38:50< zookeeper> mattsc, by current implementation you mean..?
20160730 13:39:17< mattsc> the code in the thread to which I linked yesterday
20160730 13:41:18< zookeeper> got it
20160730 13:42:04< mattsc> I’m specifically worried about the “need two units to attack” and single-hex passages
20160730 13:42:19< zookeeper> yeah i suppose that could be a problem
20160730 13:42:26< mattsc> I don’t particularly like single-hex passages, but they are all over Wesnoth
20160730 13:42:30-!- Kwandulin [~Miranda@p200300760F6062A504F82161CC687F92.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160730 13:43:24< mattsc> I’m sure there are ways around that, like relaxing that condition when the single-unit limit is imposed by terrain rather than other enemy units; or something
20160730 13:44:33< mattsc> zookeeper: do you know off the top of your head a good map to use for a test scenario that has lots of passages of different widths?
20160730 13:44:47< mattsc> I could create one easily, but if it already exists …
20160730 13:45:06< mattsc> And I never remember which mainline scenario is which, with a few exceptions  :P
20160730 13:45:09< zookeeper> the last THoT scenario maybe? not that i've played it myself, but i recall people complaining about a huge map with narrow passages :p
20160730 13:45:25< mattsc> cool, I’ll look at that
20160730 13:47:07< zookeeper> you recall what the rationale for the two-unit rule?
20160730 13:47:11< zookeeper> +was
20160730 13:47:36< vultraz> the last THOT scenario is a pain in the ass
20160730 13:47:39< mattsc> yeah, that scenario will do nicely
20160730 13:47:46< mattsc> map, I mean
20160730 13:47:47< zookeeper> to make sure the AI waits until more units are around to deal some damage after the levelup too?
20160730 13:47:52-!- mjs-de [~mjs-de@x4e3157fd.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160730 13:48:14< mattsc> I think so.  Mostly so that you’d actually cause some damage to the player, rather than just helping the unit level up.
20160730 13:48:26-!- mjs-de [~mjs-de@x4db69e37.dyn.telefonica.de] has joined #wesnoth-dev
20160730 13:48:27-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 264 seconds]
20160730 13:49:22< mattsc> But I actually consider leveling up in a no-danger situation a disadvantage (most of the time, at least), so maybe that argument doesn’t apply
20160730 13:49:40-!- Kwandulin [~Miranda@p200300760F6062A5CD34D0F3A594E02C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160730 13:50:06< zookeeper> okay. i'd think it's probably safer to just remove that rule, because of the no-danger thing. if you imagine being the AI, then it's not really a disadvantage to trigger the player's levelup sooner rather than later
20160730 13:50:29< mattsc> yes
20160730 13:50:40< zookeeper> i mean sure maybe the unit will level up into something that can deal big ranged damage to your melee units or something, but that's a super minor consideration in this case
20160730 13:50:49< mattsc> but should there still be reasons when we do not want to attack?
20160730 13:50:58< zookeeper> humm...
20160730 13:51:03< zookeeper> if the unit is poisoned? :P
20160730 13:51:06< mattsc> because if not, we can just use the simple_attack MAI
20160730 13:51:18< mattsc> heh
20160730 13:51:23< zookeeper> because if it is poisoned... you want to wait until it drops to low enough HP to kill it
20160730 13:52:33< mattsc> right
20160730 13:52:44< mattsc> that could be done with the SA MAI as well
20160730 13:53:51< mattsc> I think I like some of the mechanics of the current test code though, like attack with the strongest unit if there is a kill chance, but with the weakest otherwise
20160730 13:53:53< zookeeper> other than that i can't really think of any reasons, unless you can somehow tell that a unit which would have CTK will make it there in X turns
20160730 13:54:03< mattsc> and that couldn’t be done with the simple attack
20160730 13:54:28< mattsc> I could do that, but I think that’s getting too complex
20160730 13:54:36< zookeeper> but that would still fail in 1-hex passages because presumably that CTK unit couldn't actually get in position
20160730 13:54:47< mattsc> right
20160730 13:55:14< mattsc> I can do move-adjacent unit out of the way tricks though, those are always neat  :)
20160730 13:55:56< mattsc> anyways, I’ll work on it a little, but I’d say let’s keep it simple and throw it out there sooner rather than later and see what people say
20160730 13:55:59-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160730 13:56:13< mattsc> we still have a few 1.13 release left to tweak things
20160730 13:57:16< zookeeper> so... 1) if any unit has CTK, try that 2) but if not, check if the unit is poisoned and if it is, do nothing 3) but if it's not poisoned, attack with cheapest and weakest unit but give absolute priority to taking the least retaliation damage?
20160730 13:58:38-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160730 13:58:47< mattsc> something like that sounds good
20160730 13:59:33< mattsc> The last point includes the attack a melee-only unit with a ranged weapon you mentioned yesterday, I presume
20160730 13:59:50< zookeeper> yes
20160730 14:00:18< mattsc> I’ll get cranking at setting up a test scenario then
20160730 14:00:57< zookeeper> or maybe instead of "cheapest and weakest" you could just choose the unit/attack which results in least damage received as % of current hp? so it'd rather attack with a full health grunt and take 20% damage rather than sacrifice a 1hp gobbo
20160730 14:01:24< mattsc> yes, sure
20160730 14:01:36< mattsc> chance-to-die in the attack needs to figure in somehow
20160730 14:01:48< mattsc> esp. if we want to take aggression and caution into account
20160730 14:03:09< zookeeper> pick the unit with least chance to die, and if there's units which can attack without chance to die, pick the one which will take the least damage?
20160730 14:03:41-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160730 14:04:20< zookeeper> again that could theoretically result in the AI taking a 30% risk of getting a valuable unit killed instead of a 40% risk of a useless unit killed, but...
20160730 14:04:49< mattsc> right
20160730 14:05:05-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160730 14:05:06< zookeeper> maybe weigh that by whatever unit worth value/formula there is?
20160730 14:05:25< mattsc> what I do in my own AIs is a weighted sum of CTD and percentage damage done
20160730 14:05:35< mattsc> usually multiplied by the cost of the unit or something
20160730 14:06:03< mattsc> right (I wrote that before I read your last line)
20160730 14:06:05< zookeeper> but really, i think anything along those lines will work reasonably well as long as it ensures that _some_ unit will attack
20160730 14:06:17< mattsc> exactly
20160730 14:09:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160730 14:09:19-!- wedge010 is now known as wedge009
20160730 14:10:10< wedge009> celmin|sleep: I don't know if it's related to your removal of VC2008 stuff, but I'm getting a few compilation errors relating to the template stuff in gui/core/event/dispatcher_private.hpp now (using VC2015, lines 200-204).
20160730 14:10:46-!- travis-ci [~travis-ci@ec2-54-166-218-240.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 14:10:47< travis-ci> wesnoth/wesnoth#10020 (master - db248e1 : Wedge009): The build is still failing.
20160730 14:10:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148532726
20160730 14:10:47-!- travis-ci [~travis-ci@ec2-54-166-218-240.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 14:11:33< zookeeper> mattsc, i hope that someone somewhere will encounter a nasty surprise when they try to utilize the XP trick they've been using for the last decade... :>
20160730 14:11:51< mattsc> hehe, yeah
20160730 14:12:23< zookeeper> that's probably a big thing in some survivals, i'd imagine
20160730 14:12:44< mattsc> possibly, I don’t know
20160730 14:13:15-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160730 14:13:32< Ravana_> I have tried to compensate it by giving ai stackable bonuses so eventually they will attack
20160730 14:13:58< zookeeper> anyway, i think i'll be off to work on my lasagne...
20160730 14:14:14< mattsc> It’s funny though, I don’t care about reloading or even using debug mode to get myself through a scenario (when I am in no mood to do it “cleanly”; I don’t do that as a general rule), but I don’t use the 1-XP from leveling thing when I play.
20160730 14:15:02< mattsc> Ravana_: how do you do that?
20160730 14:15:22< mattsc> zookeeper: bon appetit
20160730 14:16:11< Ravana_> all side 1 units alive at certain point get something https://github.com/ProditorMagnus/OrociaRandomMod/blob/master/utils/wave_modifications.cfg#L144
20160730 14:16:27< mattsc> Ravana_: I have added the simple_attack MAI to some scenarios (even a couple mainline scenarios IIRC) to avoid this behavior
20160730 14:17:09< mattsc> Ah, so they eventually become strong enough that they consider the attack worth it?
20160730 14:17:48< Ravana_> yes
20160730 14:17:56< mattsc> cool
20160730 14:18:02< mattsc> the second example here  https://wiki.wesnoth.org/Micro_AIs#Simple_Attack_specific_keys_for_the_.5Bmicro_ai.5D_tag:
20160730 14:18:11< mattsc> shows how one can use that MAI to do that
20160730 14:18:35< irker258> wesnoth: Charles Dang wesnoth:master 2c09e6a7c0db / src/campaign_server/blacklist.cpp: Fixup 4f7ae24d1b6e https://github.com/wesnoth/wesnoth/commit/2c09e6a7c0dbaeaf24ac87a7ac13b42bd858f33a
20160730 14:19:20< mattsc> one could make the filter function much more complex, of course
20160730 14:27:27< zookeeper> hmh, i actually just figured that it could have been invisible worked around in WML already
20160730 14:27:48< zookeeper> apparently i never seriously considered doing so before
20160730 14:28:59< zookeeper> namely, you could during AI turns give units invisible weapon specials which would increase damage dealt by the AI against player units, and then remove those in an attack event so the AI only thinks it has a CTK
20160730 14:31:52< mattsc> zookeeper: sure, that might work
20160730 14:35:00< mattsc> zookeeper: a very simple way to work in ‘aggression’: if chance-to-die in the attack is greater than aggression, don’t do it.
20160730 14:35:53< zookeeper> well that means that with low enough aggression, the trick would still work, right?
20160730 14:36:13< mattsc> only if the unit has a chance to die in the attack
20160730 14:36:20< zookeeper> right
20160730 14:36:30< mattsc> so any unit attacking a grunt with a ranged weapon would always do it
20160730 14:36:42< mattsc> but it is also consistent with other AI behevaior
20160730 14:36:48< mattsc> Behavior
20160730 14:37:21< zookeeper> i guess it'd be a very rare case that _all_ units would have a CTD and low aggression
20160730 14:37:23< mattsc> if you set aggression very low, the AI does not attack strong groups of enemies
20160730 14:37:31< mattsc> yep
20160730 14:37:32< zookeeper> yeah, sounds okay i guess
20160730 14:38:08< mattsc> I like it for its simplicity and the fact that it gives some control, albeit not much, over the behavior
20160730 14:39:32< mattsc> If you have only peasants with an Ancient Lich blocking a passage, there’s not really a point in attacking, whether the Lich is 1XP from leveling or not.  :P
20160730 14:51:11-!- travis-ci [~travis-ci@ec2-54-163-65-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160730 14:51:12< travis-ci> wesnoth/wesnoth#10021 (master - 2c09e6a : Charles Dang): The build was fixed.
20160730 14:51:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/148537060
20160730 14:51:12-!- travis-ci [~travis-ci@ec2-54-163-65-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160730 15:01:08< zookeeper> sure... but if it's anything else that doesn't have drain, then it does make sense provided that you have enough peasants lined up :p
20160730 15:02:18< zookeeper> and even infinite peasants can kill an ancient lich provided that it's not standing on 60% defense :p although i do wonder where the tipping point is, statistically
20160730 15:02:48< vultraz> ugh
20160730 15:02:56< vultraz> I need to write the announcement
20160730 15:04:29-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160730 15:04:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160730 15:05:51-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 264 seconds]
20160730 15:07:20< mattsc> zookeeper: we can calculate that some other time.
20160730 15:07:34< mattsc> And you’ll just set aggression=1 and they run themselves to death
20160730 15:12:27< Ravana_> lich has amla 100 times I think, so after that point peasants can freely ranged suicide themselves
20160730 15:12:31-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160730 15:12:46< mattsc> :D
20160730 15:20:07-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Ping timeout: 260 seconds]
20160730 15:33:35-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20160730 15:35:42-!- Kwandulin [~Miranda@p200300760F6062A5CD34D0F3A594E02C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160730 15:39:33< JyrkiVesterinen> [17:10:14] <wedge009> celmin|sleep: I don't know if it's related to your removal of VC2008 stuff, but I'm getting a few compilation errors relating to the template stuff in gui/core/event/dispatcher_private.hpp now (using VC2015, lines 200-204).
20160730 15:40:13< JyrkiVesterinen> I'm getting a compilation error there as well (using MSVC2013). Looks like it was indeed caused by removal of onve MSVC2008 workaround. I'll restore it.
20160730 15:47:06< vultraz> well that's odd
20160730 15:47:46< JyrkiVesterinen> Well, to be fair it's definitely quite strange function call syntax.
20160730 15:47:47< JyrkiVesterinen> return functor.template operator()<item>(event);
20160730 15:48:36< vultraz> GUI2's code is weird
20160730 15:49:43< JyrkiVesterinen> The code in question appears to perform a compile-time lookup for event handlers.
20160730 15:50:04< JyrkiVesterinen> It would be a thousand times more clear with C++14 extended constexpr.
20160730 15:50:23< JyrkiVesterinen> (Unfortunately, MSVC doesn't support it, even the 2015 version.)
20160730 15:51:22< vultraz> Microsoft says constexpr is supported in 2015
20160730 15:51:43< JyrkiVesterinen> C++11 constexpr is, but not the C++14 extensions.
20160730 15:52:21< vultraz> ah
20160730 15:53:30< irker258> wesnoth: Jyrki Vesterinen wesnoth:master c44419d460cd / src/gui/core/event/ (dispatcher.cpp dispatcher_private.hpp): Restore one MSVC2008 workaround removed in commit 8fa73053 https://github.com/wesnoth/wesnoth/commit/c44419d460cdbe074c27af1c9a4f300ed88fb92d
20160730 16:10:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160730 16:10:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160730 16:10:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160730 16:16:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160730 16:18:09-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160730 16:18:18-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Remote host closed the connection]
20160730 16:18:21< celmin|sleep> vultraz: Those typedefs you removed aren't useless...
20160730 16:18:44< celmin|sleep> I would've preferred using a different name than "oper" there, but whatever... it's done now and I don't feel like changing it again.
20160730 16:19:45< vultraz> celmin|sleep: how so?
20160730 16:19:49-!- celmin|sleep is now known as celticminstrel
20160730 16:20:07< celticminstrel> They give additional information about the meaning of the value.
20160730 16:28:52< vultraz> shrug
20160730 16:29:08< vultraz> that's true
20160730 16:32:04< vultraz> though i think the names are enough
20160730 16:42:36-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160730 16:59:15-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160730 17:09:22< vultraz> oh hey, a fix for the ellipse bug
20160730 17:10:06< vultraz> someone will have to confirm if it's the proper fix
20160730 17:10:13< vultraz> (I'm talking of PR 718)
20160730 17:15:31< celticminstrel> Getting a warning in Spixi's event code.
20160730 17:15:40< celticminstrel> I think it's innocuous, bot not quite sure.
20160730 17:17:22 * vultraz wants to work on porting Recall to gui2, but is feeling too lazy
20160730 17:17:30< vultraz> disadvantage of working with c++ >_>
20160730 17:19:10< celticminstrel> What?
20160730 17:19:48< vultraz> it's such a pain to create new files, write the class, add them to the project, write the WML... 
20160730 17:21:41< vultraz> I have been spoiled by anura
20160730 17:24:03-!- Kwandulin [~Miranda@p200300760F6062A5483BE268E87AD184.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160730 17:30:26< vultraz> blah
20160730 17:31:45-!- mjs-de [~mjs-de@x4db69e37.dyn.telefonica.de] has quit [Remote host closed the connection]
20160730 17:31:56-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20160730 17:32:21< vultraz> need to give the unit preview pane the  ability to deal with single units
20160730 17:32:25-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160730 17:32:45< celticminstrel> That shouldn't be too hard.
20160730 17:33:21< vultraz> it's not
20160730 17:35:26< vultraz> just need to figure out the logistics
20160730 17:41:28-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 17:48:39-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20160730 18:04:37< celticminstrel> vultraz, zookeeper: If there's an error in [filter_condition], should it be treated as if the conditional passed or failed?
20160730 18:04:50-!- iceiceice [~chris@wesnoth/developer/iceiceice] has joined #wesnoth-dev
20160730 18:05:31< vultraz> failed
20160730 18:05:38< zookeeper> celticminstrel, well the individual condition where the error is should be ignored
20160730 18:06:45< zookeeper> i don't really see what sort of error you could have that should mean the whole [filter_condition] should pass/fail
20160730 18:07:34< celticminstrel> Well, basically the erroneous condition could be treated as [true] or as [false].
20160730 18:08:18< zookeeper> yes, but does it need to be treated as anything?
20160730 18:08:44< zookeeper> if you really need to, then certainly false is the right default
20160730 18:08:45< celticminstrel> Well... what happens with an empty [filter_condition]? Or an empty [and] within one.
20160730 18:09:05< fabi> maybe it should get the neutral element of the context
20160730 18:09:13< fabi> meaning true in and 
20160730 18:09:20< fabi> and false in or
20160730 18:09:25< zookeeper> presumably an empty condition doesn't fail, so it passes
20160730 18:09:39-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160730 18:10:17< celticminstrel> So ignoring it (treating it as if it weren't there) would suggest letting it pass, but you said letting it fail makes more sense.
20160730 18:11:11< zookeeper> so which one are you talking about, errors or empty conditions?
20160730 18:11:18< celticminstrel> Errors.
20160730 18:11:43< celticminstrel> If you treat an error as if it's not there though, that would give an effectively empty condition.
20160730 18:12:23< zookeeper> well, yes, that's why i said that erroneous conditions should be ignored, and that it should default to failing only if you really need to default to either passing or failing
20160730 18:12:46< celticminstrel> So you'd prefer that it be ignored, yielding an empty condition and thus passing?
20160730 18:12:53< zookeeper> yeah
20160730 18:13:17< zookeeper> of course i don't know what sort of errors you even have in mind.
20160730 18:13:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 18:13:43< celticminstrel> I'm mainly thinking about using an invalid conditional tag.
20160730 18:13:54< fabi> hi bumbadadabum
20160730 18:13:58< celticminstrel> eg, [filter_condition][error]
20160730 18:14:08< celticminstrel> Because that currently causes the game to crash.
20160730 18:14:15< zookeeper> it does? O.o
20160730 18:14:22< celticminstrel> Yes.
20160730 18:14:32< celticminstrel> (I think only in [filter_condition], not in eg [if].)
20160730 18:16:04< zookeeper> i'd be inclined to say that you should, without any problems and with the game simply ignoring them, be able to write arbitrary tags in any context except of course those where arbitrary tag names are explicitly expected ([set_variables] stuff, etc etc)
20160730 18:17:19< lipkab> What? No. Just no.
20160730 18:17:23< celticminstrel> ConditionalWML is sort of a place where arbitrary tag names are explicitly expected, like ActionWML.
20160730 18:17:33< zookeeper> maybe there's other exceptional places like that that i'm not recalling, but in general tags should just be ignored unless they're part of the spec
20160730 18:17:47< lipkab> This is a terrible idea, zookeeper.
20160730 18:17:58< zookeeper> lipkab, how so? that's how it's always worked
20160730 18:18:02 * zookeeper is afk for 10mins
20160730 18:18:19< celticminstrel> Incidentally, the conditionalwml implementation looks somehow strange...
20160730 18:18:22< lipkab> Then it always has been terrible.
20160730 18:19:03< celticminstrel> Oh, I see. It's like there's no need for [and] at all.
20160730 18:19:19< celticminstrel> Though I guess that's only if you're not using [or] either.
20160730 18:19:34< celticminstrel> Basically, "and" is implicit when multiple conditions are used.
20160730 18:20:18< celticminstrel> lipkab: So what do you think should happen with [filter_condition][error]?
20160730 18:20:50< lipkab> zookeeper: You benefit nothing from being able to write random tags everywhere, and it makes WML more prone to errors.
20160730 18:21:14< celticminstrel> lipkab: At the very least, arbitrary tags in unexpected places shouldn't crash the game.
20160730 18:21:27< lipkab> That's right.
20160730 18:22:11< lipkab> If it's a choice between crashing and ignoring, then go for ignoring.
20160730 18:22:40< vultraz> there should be an error 
20160730 18:23:01< lipkab> But if we can warn the WML writer about insesible code, then we should do it.
20160730 18:23:29< vultraz> this is why wml is bad for scripting
20160730 18:23:37< bumbadadabum> fabi: hi
20160730 18:26:22< bumbadadabum> I agree with having a warning or error there
20160730 18:26:47< vultraz> shadowm: could you possibly add two or three screenshots to the announcement?
20160730 18:26:57< celticminstrel> There's already an error, it's just that sometimes conditionals are evaluated in an unprotected context (to use the Lua terminology).
20160730 18:27:08< celticminstrel> I suspect menu-items may also be affected.
20160730 18:27:19< celticminstrel> Maybe storyscreens as well.
20160730 18:28:14< celticminstrel> I suppose I could just print the error and return true, instead of calling luaL_argerror.
20160730 18:28:35< celticminstrel> That means that an [if] with an invalid conditional would no longer cause the script to terminate (but would still print an error).
20160730 18:29:11< celticminstrel> Does that seem acceptable to everyone?
20160730 18:29:16 * celticminstrel back after food.
20160730 18:30:42< zookeeper> lipkab, sure i agree that the benefits are very minor and changing it would prevent people from always doing the same kind of [if] [filter] mistakes or whatnot. so yeah in that sense it's always been terrible, but as said it's also how everything works so changing it in one specific location out of hundreds would be rather pointless and inconsistent.
20160730 18:32:24< lipkab> zookeeper: Hmm, okay. You convinced me. Almost.
20160730 18:32:40< lipkab> celticminstrel: Sounds good to me.
20160730 18:32:48< vultraz> are you saying we have no way to change this behavior globally?
20160730 18:33:48< lipkab> We surely have.
20160730 18:34:00< lipkab> It just takes a lot of work.
20160730 18:34:10 * vultraz curses
20160730 18:35:22< lipkab> Someone needs to write a syntax validator for WML and integrate it into the engine.
20160730 18:35:25< zookeeper> yeah, my half-assed impression of how it works is that there's no single place where you can just put some "unrecognized" tag code. there'd need to be some kind of WML validation thingy that'd check through the whole WML tree and compare it to a spec.
20160730 18:36:06< lipkab> vultraz: You've been cursing a lot lately!
20160730 18:36:08< zookeeper> i have no idea if the existing validation-related thingys are of any help with that
20160730 18:36:26< vultraz> lipkab: because this codebase is so shitty it's incredibly, sometimes
20160730 18:36:45< vultraz> despite all our best efforts
20160730 18:36:54 * lipkab shrugs
20160730 18:36:59< lipkab> So what?
20160730 18:37:10< vultraz> so that's why I've been cursing :P
20160730 18:37:43< bumbadadabum> I've seen worse
20160730 18:37:45< lipkab> Well, if it helps... :P
20160730 18:38:06< fabi> bumbadadabum: worse cursing or worse code?
20160730 18:38:12< bumbadadabum> both
20160730 18:38:21< fabi> :-)
20160730 18:38:53< zookeeper> the codebase is suddenly shitty because it's architecturally hard to fix a problem that after years of experience, seems to have only started bothering you 30 minutes ago because someone else said it's bad? :p
20160730 18:41:04< bumbadadabum> wesnoth's code is obviously not one entity
20160730 18:41:07-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Quit: ChatZilla 0.9.92-rdmsoft [XULRunner 35.0.1/20150122214805]]
20160730 18:41:10< bumbadadabum> I'd say thats the biggest "problem"
20160730 18:41:18< bumbadadabum> but that's obvious
20160730 18:41:26< bumbadadabum> since it's an open-sourse project
20160730 18:41:54< bumbadadabum> *source
20160730 18:45:05< bumbadadabum> I don't get why vultraz is so negative about it tbh
20160730 18:45:49< bumbadadabum> then again I've seen vultraz bitch about wesnoth's code for as long as I've known him
20160730 18:45:52< bumbadadabum> so /shrug
20160730 18:52:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160730 18:52:48-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160730 18:53:50< vultraz> zookeeper: no, because it
20160730 18:53:52< vultraz> s a reminder how much better things could be
20160730 18:54:28-!- irker258 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160730 19:03:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 276 seconds]
20160730 19:04:32< iceiceice> well it was built a long time ago
20160730 19:04:37< iceiceice> and architecture was made for a certain thing
20160730 19:04:44< iceiceice> and now when you want to extend it, it becomes pretty hard
20160730 19:05:19< iceiceice> i dont know anyone who is happy about their 300 kloc + legacy c++ codebase :p
20160730 19:05:52< iceiceice> takes a lot of work just to update to new standards
20160730 19:06:45< iceiceice> it woudl be nice if the code base were not one monolithic entity
20160730 19:07:06< iceiceice> but idk if its worth at this point to try to factor it into small libraries or sometihng
20160730 19:10:32< celticminstrel> ConditionalWML is always evaluated in the order have_unit, have_location, variable, custom tags. Any objections to changing this so that it's evaluated in order of appearance instead?
20160730 19:13:14< celticminstrel> BTW, the attack dialog does look much better now.
20160730 19:14:41< zookeeper> celticminstrel, hmh, isn't the order irrelevant WRT the results?
20160730 19:15:33< celticminstrel> zookeeper: Hmm, I think it's not, because there's short-circuiting.
20160730 19:15:42-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 19:15:57< celticminstrel> That is, it returns false as soon as any tag fails.
20160730 19:16:31< zookeeper> celticminstrel, yeah but i mean the evaluations don't have side-effects, unless you use a lua_function= or something and for some unfathomably reason rely on the undocumented evaluation order in some bizarre fashion
20160730 19:17:17< celticminstrel> Yeah, no side-effects in have_unit, have_location, or variable. (Custom tags are evaluated in order of appearance after those three are handled, so changing this wouldn't affect those.)
20160730 19:18:25< zookeeper> so, i can't really think of any objections
20160730 19:19:33< celticminstrel> I could do this either by moving those three tags to a Lua implementation, or by simply shuffling around the C++ code...
20160730 19:19:51< fabi> celticminstrel: please do the lua way 
20160730 19:20:17< celticminstrel> fabi: I'm seriously considering it, but I'd like multiple opinions.
20160730 19:20:41< celticminstrel> Even though I'm seriously considering it, it kinda feels like a bad idea.
20160730 19:23:50< zookeeper> so why are you seriously considering it in the first place? why does that code need to be shuffled around one way or another?
20160730 19:24:02< zookeeper> aren't there like bugs to fix and cool things to do
20160730 19:24:16< celticminstrel> Probably.
20160730 19:25:15< fabi> celticminstrel: Can you please notice me when you work on some lua related stuff? I sometimes miss stuff getting ported to lua resulting in duplicate work.
20160730 19:25:39< celticminstrel> fabi: Huh?
20160730 19:25:49< celticminstrel> You were working on porting something to Lua?
20160730 19:25:58< fabi> yes
20160730 19:26:07< celticminstrel> What was it, out of curiosity?
20160730 19:26:12< fabi> everything
20160730 19:26:20< fabi> I port everything into lua
20160730 19:26:23< celticminstrel> Well, that's not very helpful.
20160730 19:27:19< fabi> I have lost a little the overview. Who is nowadays working on the Lua stuff in Wesnoth?
20160730 19:28:20< celticminstrel> Well, I, vultraz (I think), and Elvish_Hunter have done some, and bumbadadabum has offered to do some.
20160730 19:28:41< celticminstrel> That's not a comprehensive list.
20160730 19:28:52< fabi> Nice. I really would like to know about stuff getting done on that front.
20160730 19:29:30< celticminstrel> E_H ported [set_variable]. I ported [message] and [object] with a bit of help, as well as sound source and fog tags.
20160730 19:29:47< fabi> nice
20160730 19:30:03< fabi> I have already looted your set_variable, message and object ports
20160730 19:30:13< fabi> but sound_source and fog is news to me.
20160730 19:30:50< celticminstrel> zookeeper: Interestingly, the presence of a [true] means that the condition immediately succeeds, even if there were other tags that you might have expected to make it fail.
20160730 19:31:05< celticminstrel> fabi: I also did one more... [wml_messag] I think it was.
20160730 19:31:10< celticminstrel> With an E
20160730 19:31:23< celticminstrel> Sound source and fog are both tag pairs rather than individual tags.
20160730 19:32:14< celticminstrel> E_H said he was going to extend [set_variable], but he hasn't done so yet.
20160730 19:36:43< fabi> Has the lua api been altered to implement them?
20160730 19:37:04< celticminstrel> Of course?
20160730 19:37:39< fabi> maybe I used the wrong word
20160730 19:37:44< celticminstrel> How else would they be ported?
20160730 19:37:46< fabi> s/altered/modified
20160730 19:38:21< fabi> well, maybe the capacity of the old api was already enough?
20160730 19:38:38< celticminstrel> Ah, fair enough.
20160730 19:38:50< celticminstrel> But yes, API functions were added.
20160730 19:39:01< celticminstrel> Those are in the changelog.
20160730 19:39:11< celticminstrel> And also documented on the wiki.
20160730 19:39:32< celticminstrel> Speaking of documenting on the wiki, I'm pretty sure there's still a couple of things missing, like [message]image_pos...
20160730 19:55:32-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160730 19:57:53< celmin> Thinking about it, I suspect it would actually be slower to implement have_unit in Lua.
20160730 19:58:32< celmin> Though… that's assuming identical logic flow...
20160730 19:58:52< celmin> The C++ code constructs the filter and tests it on every unit with hp > 0.
20160730 19:59:47< shadowm> vultraz: Yes, if you give them to me.
20160730 20:00:10< celmin> On the other hand, the only other option I can see is to iterate over all units that match the filter, which means no short-circuiting if you only need a single unit.
20160730 20:01:16< celmin> iceiceice: I think some factoring into libraries would be useful. The WML parser and writer, for example.
20160730 20:01:32< iceiceice> yeah that would be cool
20160730 20:01:52< iceiceice> if there were like a "libWML" :)
20160730 20:01:59< celmin> Yeah.
20160730 20:02:10< iceiceice> i made a wml parser in boost spirit last year some time
20160730 20:02:22< iceiceice> but its tricky
20160730 20:02:26< celmin> Oh?
20160730 20:02:28< iceiceice> depending on how you want to handle macros
20160730 20:02:33< celmin> What do you mean?
20160730 20:02:53< iceiceice> in wesnoth it does something similar to what a C preprocessor does
20160730 20:02:59< iceiceice> where it expands all the macros textually
20160730 20:03:08 * celmin gives up on trying to figure out what shadowm was responding to.
20160730 20:03:09< iceiceice> and inserts all these extra tokens for debugging purpsoses
20160730 20:03:30< celmin> Right, it's basically a C preprocessor with different syntax.
20160730 20:03:34< iceiceice> like if you compile code using gcc with -E
20160730 20:03:42< iceiceice> you'll get all these "line" and "file" annotations i guess
20160730 20:03:44< iceiceice> well not quite but
20160730 20:03:50< iceiceice> sort of like what happens in wesnoth
20160730 20:03:55< iceiceice> and then we have to use that info to do error handling
20160730 20:03:58< shadowm> celticminstrel: I honestly have no idea why you'd go through that effort in the first place, but the answer is trivial if you look for the last message vultraz has spoken in this channel that contains my username.
20160730 20:04:18< iceiceice> celmin, in my parser, the goal was to preserve the macros wtihin the structure
20160730 20:04:26< iceiceice> so it works more like how libclang parser works
20160730 20:04:35< iceiceice> because my goal was to be able to transpile wml :)
20160730 20:04:53< celmin> It's just curiosity, which is why I gave up.
20160730 20:04:54< iceiceice> so it could like rewrite macros in some other format
20160730 20:05:07< celmin> "transpile"?
20160730 20:05:20< iceiceice> like rewrite a large body of wml in a different programming language
20160730 20:05:30< fabi> trans compile
20160730 20:05:45< iceiceice> but my parser was also a bit janky, i think that was the first spirit program i wrote
20160730 20:05:47< iceiceice> or maybe the second
20160730 20:06:01< iceiceice> if you only want to parse wml with no macros then its trivial i guess
20160730 20:06:19< fabi> iceiceice: call me crazy but I am back on a per line approach for the transcompiler.
20160730 20:07:21< iceiceice> idk, you can do what you like
20160730 20:07:54< shadowm> celticminstrel: I don't know, if you are going to visibly announce this then that means you probably care in some meaningful way.
20160730 20:14:07< celmin> zookeeper: So about what I said about [true], do you consider that desirable behaviour?
20160730 20:18:04< vultraz> shadowm: https://drive.google.com/file/d/0B-mR9s8FduLLVzFaNExfUWZEZEk/view?usp=sharing
20160730 20:21:03< shadowm> Wrong dimensions, and get rid of the window decorations.
20160730 20:21:26< vultraz> what is the right dimension?
20160730 20:21:54< shadowm> The ones you gave me in the first place.
20160730 20:22:31< vultraz> uh?
20160730 20:22:32< shadowm> https://www.wesnoth.org/images/sshots/wesnoth-1.12.0-2.jpg
20160730 20:24:44< vultraz> for the record, I didn't take that
20160730 20:24:52< celmin> So 1280x768?
20160730 20:25:05< vultraz> seem so
20160730 20:25:06< shadowm> You gave me the dimensions, vultraz.
20160730 20:26:19< shadowm> Oh, correction. I gave myself the dimensions after a poll following a discussion which we had because you weren't happy with the previous numbers: https://forums.wesnoth.org/viewtopic.php?f=16&t=41090
20160730 20:28:11< vultraz> shadowm: https://drive.google.com/file/d/0B-mR9s8FduLLVzFaNExfUWZEZEk/view?usp=sharing
20160730 20:28:40< vultraz> these are 1282 x 769. I hope that is acceptable.
20160730 20:29:22< shadowm> No.
20160730 20:29:33< celmin> …why?
20160730 20:29:53< celmin> vultraz: BTW, isn't there a Wesnoth-specific screenshot key combo that might work? Not for the loading screen though, I guess.
20160730 20:30:04< shadowm> Because that's not a standard resolution.
20160730 20:30:06 * vultraz curses
20160730 20:30:23< vultraz> it's the goddamn window borders, do I *really* need to purge 2 pixels
20160730 20:30:25< celmin> (Why is it slightly different anyway? Cropping issues?)
20160730 20:30:39< shadowm> Don't expect me to do it for you.
20160730 20:30:42< vultraz> 2 rows*
20160730 20:30:53< shadowm> All I am supposed to do here is rename the files and run a script in them to generate the thumbnais.
20160730 20:30:56< celmin> And one column.
20160730 20:30:56< shadowm> ls.
20160730 20:31:07< shadowm> And then conveniently drag them into a folder.
20160730 20:31:21< shadowm> On them, not in them.
20160730 20:31:44< vultraz> I'm not asking you to do it for me, I'm asking you to ignore the extra pixels
20160730 20:31:52< shadowm> I can't.
20160730 20:32:29< shadowm> I have no idea how to tell ImageMagick to do so and I don't want to have to do it because it sets a bad precedent on the part of the screenshotter.
20160730 20:33:23< shadowm> Ideally you'd do just like me and use a tool that only captures the window client area, but apparently your precious OS that made me waste a whole night messing around with profiles can't do that or you can't be bothered to figure out how (I'm not sure which is worse).
20160730 20:36:29< vultraz> shadowm: https://drive.google.com/file/d/0B-mR9s8FduLLbndBZkVWcDQ0Q2c/view?usp=sharing
20160730 20:37:55-!- Kwandulin [~Miranda@p200300760F6062A5483BE268E87AD184.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160730 20:38:29< shadowm> Much better. Thank you.
20160730 20:38:35< vultraz> You're welcome.
20160730 20:40:16< shadowm> They are all up now.
20160730 20:40:45< vultraz> Thank you.
20160730 20:41:01< shadowm> Also, I apologize. I mixed you up with the actual person who originally complained about the original format. Probably because I'm senile and you're getting a bit hard to tell apart.
20160730 20:41:52-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160730 20:45:59< shadowm> You've got excessive spacing between collapsible blocks in the draft.
20160730 20:46:15< shadowm> Compare with: https://forums.wesnoth.org/viewtopic.php?f=5&t=44175
20160730 20:46:47< celmin> Oh, the draft is up?
20160730 20:46:47< shadowm> You also have a superfluous heading.
20160730 20:46:56< celmin> I'll look in a few minutes.
20160730 20:47:43< shadowm> Also, WML and Lua have never been spelled in all-lowercase letters.
20160730 20:47:44< vultraz> Editing as we speak
20160730 20:49:19-!- Nobun [~nobun@host216-19-dynamic.50-82-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160730 20:49:37< shadowm> And make sure you actually edited all instances of 1.13.4 to point to 1.13.5 where desirable.
20160730 20:51:49< celmin> vultraz: Finished editing yet?
20160730 20:52:00< vultraz> yes
20160730 20:52:18< celmin> "features a several" in the first sentence
20160730 20:52:29 * vultraz curses
20160730 20:52:46< celmin> …do you want me to just fix any errors I find myself?
20160730 20:52:55< vultraz> Fixed
20160730 20:54:21< celmin> Oh right, I wanted to move the name generator thing to "new features" instead of "compatibility breaks". Not quite sure though.
20160730 20:56:10< celmin> mattsc: When should we open the currently-nonexistent thread mentioned in the AI section?
20160730 20:57:55< celmin> vultraz: Should we mention those two bugs that were just fixed?
20160730 20:58:04< celmin> …well, I haven't pushed the fix for the second yet, though.
20160730 20:58:07< vultraz> which ones?
20160730 20:58:16< celmin> Uh, what was it again...
20160730 20:59:04< celmin> …or was it fixed in the release?
20160730 20:59:18< celmin> Anyway, the other one is the crash on invalid ConditionalWML.
20160730 20:59:27< celmin> Maybe that's too obscure to be worth mentioning...
20160730 20:59:36< vultraz> yeah, no need
20160730 20:59:47< vultraz> oh, I should mention that stray ; character in commands
20160730 20:59:53< celmin> I'm not quite sure, but the first one I was thinking of might've been the EOF thing, for which the fix is in the release.
20160730 21:00:02< celmin> Oh right, the ; problem. That's probably what I was thinking of then.
20160730 21:00:19< celmin> I guess I was wrong about it being fixed.
20160730 21:02:42< celmin> vultraz: The MacOS package isn't actually available yet, right?
20160730 21:02:58< vultraz> don't think so
20160730 21:03:06< vultraz> download links and hashes need to be filled in
20160730 21:03:28< celmin> I'll test it, so if it works we might be able to mark it as 10.7+.
20160730 21:03:44< vultraz> ok
20160730 21:04:42< celmin> Other than the name generator, I don't see any problems.
20160730 21:05:07< celmin> Oh right, "New lua/wml features" needs capitalization I guess.
20160730 21:05:16< celmin> That's probably gfgtdf's fault.
20160730 21:06:39< celmin> So, about the name generator thing… vultraz, do you think that should be moved to "new features"?
20160730 21:06:53< celmin> I think it should also be expanded.
20160730 21:07:03< celmin> I can do this if you don't want to.
20160730 21:09:57< vultraz> please do
20160730 21:10:01< vultraz> but refresh the page beforehand
20160730 21:15:15< celmin> Done.
20160730 21:15:35< celmin> Whoops, something went wrong. I think I misplaced it.
20160730 21:16:14< celmin> There.
20160730 21:24:44< celmin> BTW, is there a page somewhere about account registration for the MP server?
20160730 21:30:29-!- irker189 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160730 21:30:29< irker189> wesnoth: Celtic Minstrel wesnoth:master 1e93e7309e35 / src/game_events/pump.cpp: Fix compiler warning and restore debug message https://github.com/wesnoth/wesnoth/commit/1e93e7309e35ff5ee38e7d6bf9aeba16012ffe97
20160730 21:30:29< irker189> wesnoth: Celtic Minstrel wesnoth:master 4a668e0ec497 / src/scripting/game_lua_kernel.cpp: Fix crash on invalid ConditionalWML tag in some contexts https://github.com/wesnoth/wesnoth/commit/4a668e0ec497d8907fab9208b86747c79f567716
20160730 21:30:30< irker189> wesnoth: Celtic Minstrel wesnoth:master 4889fd7534a3 / src/game_events/conditional_wml.cpp: Execute all ConditionalWML tags in order of apperance https://github.com/wesnoth/wesnoth/commit/4889fd7534a3b6aa766878783cfaaec89725005e
20160730 21:30:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160730 21:32:27< lipkab> Hahaha.
20160730 21:32:37< lipkab> Working on this bug: https://gna.org/bugs/?24846
20160730 21:32:49< lipkab> I found the cause.
20160730 21:33:09< lipkab> I'm actually surprised that Wesnoth works at all :P
20160730 21:34:22< celmin> So what's the cause?
20160730 21:34:56< lipkab> It's cool.
20160730 21:35:25< lipkab> Here's a line from the Valgrind log the reporter attached:
20160730 21:35:26< lipkab> ==26604==    by 0x9787D4E: __cxa_pure_virtual (pure.cc:50)
20160730 21:35:44< celmin> Calling an unimplemented pure virtual function?
20160730 21:35:44< lipkab> This implies a pure virtual function is being called somewhere.
20160730 21:35:48< lipkab> Yup.
20160730 21:35:50< celmin> An unimplemented one.
20160730 21:35:55< lipkab> Yes.
20160730 21:36:02< celmin> (It's possible to implement pure virtual functions, though rarely done.)
20160730 21:36:18< celmin> Explict super() call?
20160730 21:36:26< lipkab> Nope, better.
20160730 21:36:57< lipkab> for(auto handler : event_handlers) {
20160730 21:36:57< lipkab> 				handler->handle_event(event);
20160730 21:36:57< lipkab> 			}
20160730 21:37:04< lipkab> This is it.
20160730 21:37:22< lipkab> Hmm.
20160730 21:37:30< lipkab> Heck, no.
20160730 21:37:34< celmin> What does the auto expand to>
20160730 21:37:35< celmin> ^?
20160730 21:37:53< celmin> (Also, shouldn't it be auto&?)
20160730 21:37:59< lipkab> I thought it would expand to event_handler.
20160730 21:38:24< lipkab> ...but actually it's event_handler*.
20160730 21:38:35< lipkab> So I spoke too soon.
20160730 21:38:40< celmin> Ah.
20160730 21:39:05< lipkab> Yes, it should be auto& or even better, const auto& by the way.
20160730 21:39:19< celmin> If it expanded to event_handler you'd probably get errors about copy constructors or something, wouldn't you?
20160730 21:39:27< celmin> vultraz: Take note of that BTW
20160730 21:39:54< lipkab> I have no idea.
20160730 21:40:16< lipkab> It would be a very bad thing for sure.
20160730 21:40:51< celmin> So do you know what the pure virtual function being called actually is?
20160730 21:41:53< lipkab> Nah, unfortunately the log doesn't tell that.
20160730 21:42:20< lipkab> We only now that it's being called from somewhere within evets::pump.
20160730 21:43:30< lipkab> I have to fall back in the way duller dangling pointer hypothesis which also makes this bug way harder to fix...
20160730 21:43:58< lipkab> *to the
20160730 21:44:09< celmin> I suppose you could add temporary implementations of all the pure virtual functions that it could be and set a breakpoint in each one.
20160730 21:45:10< lipkab> Yeah.
20160730 21:45:19< lipkab> If I could reproduce the error.
20160730 21:45:26< lipkab> But I can't.
20160730 21:45:29< celmin> Ah.
20160730 21:45:40< lipkab> That Valgrind log is all we have.
20160730 21:47:59-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 21:50:01< mattsc> celmin: I don’t know.  Now; or not at all?  I’m wondering whether it’s worth keeping that statement…
20160730 21:50:12< celmin> I dunno.
20160730 21:50:34< celmin> We need to decide by the time the announcement goes public, though.
20160730 21:51:09< mattsc> Yeah; right this moment I’d say let’s just delete that sentence from the announcement.
20160730 21:51:31< celmin> Okay.
20160730 21:51:32-!- fabi [~fabi@176.5.22.173] has quit [Read error: Connection reset by peer]
20160730 21:51:41< celmin> I'll do that then.
20160730 21:52:19< mattsc> sounds good to me
20160730 21:53:08< celmin> I don't think I like get_ability_bool.
20160730 22:02:05-!- JyrkiVesterinen [~JyrkiVest@87-100-213-255.bb.dnainternet.fi] has quit [Quit: .]
20160730 22:05:37-!- trewe [~trewe@2001:8a0:d131:8801:b3b6:cbaf:33e3:7418] has joined #wesnoth-dev
20160730 22:11:52< zookeeper> celmin, i don't know, as i don't even know what the purpose or rather usecases of [true] and [false] is.
20160730 22:12:16< celmin> They probably aren't used much, huh...
20160730 22:16:28< zookeeper> i presume they were added for some extremely niche usecase that i can't think of
20160730 22:18:45< zookeeper> anyway, unless i'm missing something, according to spec [true] should just do nothing. the whole condition shouldn't pass simply because there's a [true].
20160730 22:19:44-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160730 22:25:40< celmin> That's what I would've expected too.
20160730 22:25:48< celmin> But it's not what actually happens.
20160730 22:26:16< zookeeper> might want to ask whoever added it
20160730 22:26:21< celmin> Maybe.
20160730 22:31:09< Ravana_> I noticed that when writing to lobby chat, then pressing screenshot hotkey, it will trigger, and then insert the symbol too (1.12.6)
20160730 22:31:46< celmin> I think this is the same bug as the semicolon on opening the command line.
20160730 22:31:56< celmin> Wait, 1.12.6?
20160730 22:32:05< celmin> Maybe it's not the same?
20160730 22:32:21< celmin> Sounds similar though...
20160730 22:32:24< Ravana_> might be my fault for assigning it on "8"
20160730 22:32:28< celmin> Heh.
20160730 22:36:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 276 seconds]
20160730 22:37:27< celmin> vultraz: PR 718?
20160730 22:37:46< celmin> vultraz: Also, should that bug be in the announcement post?
20160730 22:38:07< celmin> Note that "ellipse is lost" just means the hero ellipse is replaced with regular ellipse, not that there's no ellipse at all.
20160730 22:45:42-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160730 22:53:05-!- Nobun [~nobun@host216-19-dynamic.50-82-r.retail.telecomitalia.it] has quit [Quit: Salve a tutti]
20160730 23:07:51< iceiceice> lipkab: how can that even happen O_o
20160730 23:10:04< iceiceice> i thought that usually should result in a linker error rather than a broken binary
20160730 23:10:33< iceiceice> maybe its like an ODR violation or something?
20160730 23:22:59< Aginor> hey again
20160730 23:24:52< Aginor> is there some sort of simple hello-world like addon that I could use as a template?
20160730 23:24:59< iceiceice> there is
20160730 23:25:06< iceiceice> i think its called "a simple campaign"
20160730 23:25:11< iceiceice> it was made by anonymissimus
20160730 23:25:18< iceiceice> to be the template hello-world like campaign
20160730 23:25:31< iceiceice> idk if it was ported to 1.12 
20160730 23:25:54< iceiceice> if not that should be easy anyway
20160730 23:41:49< Ravana_> modification should be more simple, but I realise most people expect campaign
20160730 23:42:21< Aginor> iceiceice: I read through it last night and it felt way more complicated than a simple addon that does a "hello world" on load of a campaign map or multiplayer game
20160730 23:42:48< iceiceice> yeah maybe hello world is not quite appropriate
20160730 23:42:54< iceiceice> description for it
20160730 23:42:54< Aginor> I spent half an hour or so on it last night before giving up in disgust ;)
20160730 23:42:57< iceiceice> hehe
20160730 23:43:18< iceiceice> i think it was more like, dummy campaign that demonstrates a bunch of basic features
20160730 23:43:29< Aginor> all I want to do is to play with wml and lua in the same context as something that lives on the addon server ;)
20160730 23:43:48< iceiceice> i think i made an addon like that once
20160730 23:43:54< iceiceice> liek an AI demo addon
20160730 23:44:03< iceiceice> lets see how many downloads i got, i'm curious now
20160730 23:44:24< iceiceice> "silly ai example"
20160730 23:53:07< Aginor> iceiceice: I can use that as a starting point
20160730 23:53:26< Aginor> iceiceice: will it just activate in any multiplayer game?
20160730 23:54:56< iceiceice> no you have to select the era
20160730 23:55:03< iceiceice> in my _main.cfg there is an era definition
20160730 23:55:13< Aginor> ah, right
20160730 23:55:48< iceiceice> aginor i guess you might want to read the page about top level WML, maybe thats the most helpful thing
20160730 23:56:09< iceiceice> hmm maybe its not called that anymore
20160730 23:56:43-!- mjs-de [~mjs-de@x4db69e37.dyn.telefonica.de] has joined #wesnoth-dev
20160730 23:56:44< iceiceice> i thought there was supposed to be  a special page that lists all the things that can appear at "top level" and have a special meaning
20160730 23:56:59< Aginor> I don't think I found that
20160730 23:57:08< iceiceice> maybe i'm making it up or i forgot :p
20160730 23:57:19< Aginor> :D
20160730 23:57:40< celmin> Aginor: What about monte carlo?
20160730 23:57:53< Aginor> celmin: I haven't had time to go through it properly yet
20160730 23:58:18< celmin> I guess there's no hurry
--- Log closed Sun Jul 31 00:00:49 2016