--- Log opened Fri Aug 05 00:00:03 2016
--- Day changed Fri Aug 05 2016
20160805 00:00:03< celmin> And there's ellipse_red
20160805 00:00:06< celmin> And an unused blue one.
20160805 00:00:10< celmin> (Which is commented out.)
20160805 00:00:22< celmin> (Could maybe be used for recolouring water.)
20160805 00:00:23< vultraz> but unit.team_color() would still give magenta
20160805 00:00:24< celmin> (But isn't.)
20160805 00:01:28-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160805 00:01:35< celmin> Yes.
20160805 00:01:44< celmin> Unless a unit was set to use flag_green.
20160805 00:01:56< celmin> Or ellipse_red.
20160805 00:02:01< celmin> Which is unlikely but not impossible.
20160805 00:02:21< vultraz> then it shouldn't be called team_color()!
20160805 00:02:53< celmin> Maybe not, but there's little point in changing the name. Still, if you want to change it anyway, be my guest.
20160805 00:03:14< celmin> (It shouldn't be flag_rgb either - flag_rgb should be a [side] key defaulting to flag_green.)
20160805 00:03:15-!- Bonobo [~Bonobo@2001:44b8:254:3200:d001:5f9f:89be:a9dd] has joined #wesnoth-dev
20160805 00:03:30< vultraz> I feel it might be bad to encourage sprites to use anything but magenta.
20160805 00:03:31< vultraz> wait
20160805 00:03:33< vultraz> what?
20160805 00:03:53< celmin> (There should probably be ellipse_rgb too somewhere.)
20160805 00:03:58< vultraz> what???
20160805 00:04:09 * celmin doesn't really understand your reaction.
20160805 00:04:20 * vultraz doesn't really understand what you're saying
20160805 00:04:23< celmin> ellipse_rgb would also fit best in [side]
20160805 00:04:47< vultraz> why are we encouraging custom colors
20160805 00:04:58< celmin> Who says we're encouraging them?
20160805 00:05:14< vultraz> by allowing specifying them
20160805 00:05:20< celmin> Allowing is encouragement?
20160805 00:05:40< fabi_> vultraz: You need to use a different palette if your unit is magenta
20160805 00:05:57< fabi_> imaging some purple worm
20160805 00:06:24< vultraz> ok, look
20160805 00:06:30< vultraz> celmin: let's keep this simple for now
20160805 00:06:41< vultraz> we add unit_rgb to [game_config]
20160805 00:06:46< vultraz> we make it "magenta"
20160805 00:06:47< celmin> Agreed.
20160805 00:07:02< vultraz> we remove all cases of MAGENTA_IS_THE_TEAM_COLOR from mainline and deprecate that macro
20160805 00:07:10< vultraz> we still allow flag_rgb in unit_typ
20160805 00:07:11< vultraz> e
20160805 00:07:15< celmin> Agreed.
20160805 00:07:21< vultraz> if empty, it's set to game_config::unit_rgb
20160805 00:07:25 * celmin nod
20160805 00:08:08< vultraz> we also rename unit::team_color() to unit::team_color_source()
20160805 00:08:20< celmin> If you want, I guess.
20160805 00:08:31< vultraz> then we can remove checks for the validation of flag_rgb/unit_rgb
20160805 00:08:34< vultraz> since it's always valid now
20160805 00:08:39< celmin> Huh?
20160805 00:08:45< vultraz> like my commit above
20160805 00:08:58< vultraz> it wouldn't be needed if unit_rbg is always set to a value
20160805 00:09:01< celmin> Oh, yeah, it'd never be empty unless explicitly set to empty.
20160805 00:09:16< vultraz> if it were set to empty we'd make it magenta
20160805 00:09:30< celmin> I think that's a bad idea.
20160805 00:09:56< vultraz> why??
20160805 00:09:58< celmin> Oh, by the way, before removing MAGENTA_IS_THE_TEAM_COLOR from mainline units, we should check if there are any units that don't use it.
20160805 00:10:00< fabi_> How do you disable team coloring?
20160805 00:10:10< celmin> Because you might want to set it to empty to prevent team colour completely.
20160805 00:10:11< vultraz> you make a unit without magenta pixels
20160805 00:10:26< celmin> Maybe your unit is a psychedelic thing that requires every colour. :P
20160805 00:10:32 * vultraz groan
20160805 00:10:33< vultraz> s
20160805 00:10:50< vultraz> please stop constructing strawmen 
20160805 00:10:53-!- Duthlet [~Duthlet@dslb-178-005-055-087.178.005.pools.vodafone-ip.de] has quit [Quit: leaving]
20160805 00:11:17< celmin> I doubt there'd be problems with applying flag_rgb to mainline units that previously didn't use it, but it wouldn't hurt to double-check.
20160805 00:11:24< vultraz> we have a convention
20160805 00:11:25< vultraz> magenta
20160805 00:11:27< vultraz> is tc
20160805 00:11:36< vultraz> it's not up to us to enable users who want to violate that
20160805 00:12:01< celmin> This isn't a strawman BTW. A strawman is intentionally weak so it can be knocked over.
20160805 00:12:13< vultraz> tell that to the GoP..
20160805 00:12:22< celmin> And it's not up to us to declare that users must absolutely follow our conventions, either.
20160805 00:12:47< vultraz> iti s
20160805 00:12:49< vultraz> it is
20160805 00:12:56< fabi_> sigh
20160805 00:13:00< celmin> Not really.
20160805 00:13:40< celmin> I suppose, even if an empty flag_rgb became magenta, you could disable TC.
20160805 00:13:40-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 00:13:41< travis-ci> wesnoth/wesnoth#10126 (master - 1bb78a1 : Charles Dang): The build has errored.
20160805 00:13:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/149906021
20160805 00:13:41-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 00:13:57< celmin> Pick any single colour that is unused in your unit sprite, and set that as the flag_rgb.
20160805 00:14:05< celmin> So for example, flag_rgb=000000
20160805 00:14:12< vultraz> well that's even more hacky :|
20160805 00:14:14< celmin> If your sprite doesn't use any black.
20160805 00:14:37 * celmin shrug.
20160805 00:14:56< celmin> Or if you don't use 50% grey? flag_rgb=808080
20160805 00:14:57< vultraz> I guess we can assign a special value to "none"
20160805 00:15:00< vultraz> or something
20160805 00:15:04< celmin> I suppose you could.
20160805 00:15:05< vultraz> I dunno
20160805 00:15:17< celmin> Actually...
20160805 00:15:20< vultraz> but then we have to add checks all over for that value :|
20160805 00:15:38< celmin> Try setting it to none in some unit type, without any code changes.
20160805 00:15:44< celmin> It might Just Work already.
20160805 00:16:08< celmin> After all, flag_rgb, magenta, and ellipse_red are looked up in a WML table.
20160805 00:16:18< celmin> So if you look up a key that doesn't exist in that table, you'd get an empty string.
20160805 00:17:06< vultraz> oh yeah
20160805 00:17:07< vultraz> that does work
20160805 00:18:18< vultraz> so that solves that
20160805 00:18:24< vultraz> do you want me to implement this or you?
20160805 00:19:10< celmin> Well, I don't mind doing it, I suppose. (However, I'm absolutely not gonna bother changing the name of that one function.)
20160805 00:19:39< vultraz> I'm actually probably just gonna remove the function
20160805 00:19:45< vultraz> it's used in 2 places
20160805 00:19:54< celmin> What are they?
20160805 00:20:00< vultraz> one of which I'm removing and replacing with unit::TC_image_mods()
20160805 00:20:14< vultraz> other is in Scenario Settings
20160805 00:20:20< vultraz> which I'll convert to GUI2
20160805 00:20:25< vultraz> and I noticed a TC bug there anyway
20160805 00:20:39< celmin> So scenario settings will also end up using TC_image_mods?
20160805 00:20:44< vultraz> yes
20160805 00:20:53< celmin> Can that be done before converting it to GUI2?
20160805 00:20:56< vultraz> yes
20160805 00:20:58-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160805 00:21:00< celmin> I see.
20160805 00:21:02< celmin> Oh, tad.
20160805 00:21:23< vultraz> I can do it right now
20160805 00:21:38< celmin> zookeeper said something about a png thing.
20160805 00:22:46< tad_> OK so I run **ALL** 13000+ PNG files through imagemagick and/or pngcrush. I can make the 'known incorrect' errors go away. But several 1000 files get larger (a lot) and many 1000s get smaller.
20160805 00:23:01< tad_> I'm loath to do a PR on 13000 image files.
20160805 00:23:07< celmin> Heh.
20160805 00:23:14< vultraz> holy fuck O_O
20160805 00:23:26< celmin> Zookeeper suggested something about a tool that can compress better.
20160805 00:23:30< celmin> What was it called again?
20160805 00:23:31< vultraz> maybe I'll just give you push access...
20160805 00:23:42< tad_> I suppose I'll have to write a program to scan them and find the ones with the outdated 8-bit sRGB profiles.  *sigh**
20160805 00:23:52< vultraz> celmin: last time we tried a tool that could "compress better" we had disastrous results.
20160805 00:23:55< celmin> You could check the IRC logs.
20160805 00:23:59< celmin> vultraz: Huh?
20160805 00:24:05< vultraz> yes
20160805 00:24:07< vultraz> it was horrible
20160805 00:24:08< celmin> Explain.
20160805 00:25:04< tad_> Some of the files are compressed one way, some another. And when I run them through the filters I have, some expand, many contract.
20160805 00:25:21 * celmin pokes vultraz 
20160805 00:25:26< tad_> And this is PNG .. changing the compression changes the qualirty. That may be bad.
20160805 00:25:27< vultraz> hang on
20160805 00:25:47< celmin> Why does changing the compression change the quality?
20160805 00:26:00< tad_> This is PNG we're talking about. 
20160805 00:26:00< vultraz> tad_: doubt it's anything noticeable  
20160805 00:26:19< celmin> Right, png. In other words, deflate.
20160805 00:26:47< celmin> We're not talking about JPEG here.
20160805 00:27:00< celmin> This is generic data compression.
20160805 00:27:06< vultraz> can't find the commit anymore
20160805 00:27:14< tad_> Filter (there are 6 different styles) lose some bits, then compress/deflate zLib compress Huffman-encode .. all SORTs of options for PING (150 in all)
20160805 00:27:15< vultraz> actually I think it was force-pushed out of existance 
20160805 00:27:19< vultraz> existence 
20160805 00:27:26< celmin> Hmm.
20160805 00:27:47< celmin> vultraz: If it touched 13,000 files and made things worse, then it definitely should be force-pushed out of existence.
20160805 00:28:04< celmin> Speaking of which, why the heck are there 13,000 images? That's utterly crazy.
20160805 00:28:23< vultraz> it made this happen https://www.dropbox.com/s/hec50blqq04xdpz/wesnoth1.13%2Bdev%20post-image%20compress.png?dl=0
20160805 00:28:47< vultraz> oh, you can't see that :|
20160805 00:28:53< tad_> I really only want to make the known-bad (that is, outdated) sRGB profiles go away and not push 12,000 files which don't need changing.
20160805 00:29:03< celmin> I can see it
20160805 00:29:05< celmin> Apparently
20160805 00:29:10< vultraz> ah
20160805 00:29:12< vultraz> well then
20160805 00:29:14< vultraz> now you know
20160805 00:29:14< shikadibot> And knowing is half the battle!
20160805 00:29:15< celmin> How?
20160805 00:29:47< celmin> How did that happen?
20160805 00:30:12< tad_> Yep .. hit the wrong PNG compression options. All those almost-equal became black or white and nothing in between.
20160805 00:31:06< vultraz> celmin: it was a commit aimed at better compression 
20160805 00:31:22< celmin> That doesn't answer the question.
20160805 00:31:46< vultraz> I don't remember the tool
20160805 00:32:23< celmin> I'm not sure remembering the tool would answer the question either.
20160805 00:32:47< vultraz> then what do you want to hear?
20160805 00:33:04< celmin> I don't know, but I suppose you don't know the answer anyway...?
20160805 00:33:17< vultraz> I do not
20160805 00:34:09< celmin> I suppose the best way to make that kind of tool would be - for each image, compress using each possible algorithm in turn, then decompress and compare pixel-by-pixel to make sure it's the same.
20160805 00:34:30< vultraz> optipng does a check to make sure images are unchanged
20160805 00:34:40< vultraz> tad_: could edit that to strip the sRBG profiles
20160805 00:34:47< tad_> Good thing is, if I can do this properly (that is, hit only where I need to) the issue should not recur unless one of the artists is using ANCIENT (like last millenium) graphics software
20160805 00:35:05< celmin> Pffft.
20160805 00:36:11< tad_> pngcrush tests all 150 ways to compress and chooses the one which makes things the smallest. I can adjust the lossiness. But it's still an all-or-nothing PR and I want to avoid that if I can
20160805 00:37:46< celmin> If it chooses the one that makes things the smallest, how do some of them end up bigger?
20160805 00:38:16< celmin> Maybe you can identify exactly which images have bad sRGB profiles using a search function...
20160805 00:38:16< irker679> wesnoth: Charles Dang wesnoth:master a0c4b38f5276 / src/ (gui/widgets/unit_preview_pane.cpp menu_events.cpp): Make use of unit::TC_image_mods() https://github.com/wesnoth/wesnoth/commit/a0c4b38f5276e0bcb937bfb3acd5bdef028517dc
20160805 00:38:33< celmin> If I recall correctly, PNG chunks begin with a four-letter code or something?
20160805 00:38:49< celmin> Maybe it was more arbitrary four-byte or something.
20160805 00:38:59< tad_> Its possible to have a PNG where you don't have all the pixels in the file. The rest goes black/transparent. I'm thinking it fills in the blanks to make it strictly compliant.
20160805 00:39:12< celmin> I see.
20160805 00:39:44< celmin> Can you configure pngcrush to only strip the profiles and not recompress?
20160805 00:39:59< tad_> There's a contest to see who can make the smallest 1x1 transparent/black PNG. They're down to about 25  bytes and think they can do it in less.
20160805 00:40:47< tad_> pngcrush? no. imagemagick, yes. But that, too, is making some images quite a bit larger. Probably the same trick .. pixels not really stored.
20160805 00:41:32< celmin> …wait, I might've been confusing PNG and GIF when I mentioned chunks.
20160805 00:41:51< celmin> I had to manually parse a GIF files awhile back to extract comment chunks.
20160805 00:41:58< celmin> ^-a
20160805 00:42:01< tad_> I think my best bet is to see if I can target just the files I need to change. (PNG is GIF-redo to eliminate patented code). 
20160805 00:42:38-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 00:42:49< celmin> Right, so you want to efficiently identify which files actually have a bad sRGB profile chunk (or any sRGB profile?) and strip that out.
20160805 00:43:43< irker679> wesnoth: Charles Dang wesnoth:master 7154a587b891 / src/units/unit.cpp: Small code cleanup to unit::TC_image_mods() and unit::image_mods() https://github.com/wesnoth/wesnoth/commit/7154a587b891cf98442d8468fdabf5a9b2bddb67
20160805 00:43:54< tad_> yep. so I'm gonna have to write a quick C proram to scan master for PNG files, load each with libpng and see if the error pops up. If so, note the filename and contine.
20160805 00:44:21< tad_> Really was hoping to find that somewhere but no joy so far on googling it.
20160805 00:44:24< vultraz> praise iceiceice and his change to formatter()
20160805 00:44:59< celmin> vultraz: Speaking of his change to formatter, I think he didn't change all the uses of formatter to take advantage of it.
20160805 00:45:28< vultraz> t'is true
20160805 00:45:42< celmin> Oh right, the PR did auto-close, right?
20160805 00:46:29< Aginor> tad_: it sounds like imagemagick might already be able to do
20160805 00:46:55< celmin> Looks like it did, good.
20160805 00:47:36< tad_> I asked 'identify' and it says all the data/core/.../arch-mage-*png files were "8 bit sRGB" with no differences. but i **know** the idle anims have the issue.
20160805 00:49:04< tad_> I'll keep at it. It's a solvable problem. I just wanted to carp about it. and .. WOW 13000+ images!!! And there's still a bazillion more needed.
20160805 00:49:31< celmin> I think we need to reduce that number.
20160805 00:49:47< celmin> It wouldn't be all that hard to reduce it to one sheet per unit, for example.
20160805 00:50:06< vultraz> wesnoth 2 already does this
20160805 00:50:11< vultraz> but we don't have spritesheet support
20160805 00:50:20< tad_> use 72x72 cells and sprite it .. yep
20160805 00:50:24-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 258 seconds]
20160805 00:51:25< celmin> Technically we do have spritesheet support, it'd just be ugly.
20160805 00:51:27< celmin> ~CROP()
20160805 00:51:41< vultraz> not efficient enough
20160805 00:51:50< tad_> I think a better option would be to have a base set in the disto and use http to fetch and cache everything else. but that requires a connection so probably not optimum solution
20160805 00:51:52< celmin> It's already done that way for the 24-hour schedule as well.
20160805 00:51:58< celmin> Yeah, efficiency is also an issue.
20160805 00:52:54< celmin> Though caching may be able to alleviate the inefficiency of ~CROP()? Not sure.
20160805 00:53:36< vultraz> blah
20160805 00:53:42< vultraz> the bare formatter doesn't work with log macros
20160805 00:53:49< celmin> Example?
20160805 00:53:59< celmin> I feel like that's a place where you shouldn't need it.
20160805 00:54:06< celmin> But maybe I'm missing something.
20160805 00:54:26< vultraz> 	DBG_RND << (formatter() << "Seeded random with " << std::hex << random_seed_ << " with "
20160805 00:54:28< vultraz> 		<< random_calls_ << " calls.").str() << std::endl;
20160805 00:54:41< celmin> Yeah, uh, just remove the formatter altogether.
20160805 00:54:47< tad_> On graphics issues of another sort. fake move unit has two issues. my notes on them are in my fork's issues. both are visual artifacts seen in HttT
20160805 00:54:49< vultraz> yeah just realized that
20160805 00:55:11< celmin> Someone should probably take a look at tad's fork's issues at some point.
20160805 00:55:18< celmin> Oh yeah, speaking of issues, I said I would do a thing didn't I.
20160805 00:55:23< vultraz> did you?
20160805 00:55:52< tad_> Not a lot of them there yet.
20160805 00:56:00< celmin> "at some point"?
20160805 00:56:07< vultraz> ok, only one case still needs the .str() method
20160805 00:56:23< celmin> Someone wants to make recruiting cheaper.
20160805 00:56:30< vultraz> 			column["label"] = (formatter() << "(" << player_pos.x + 1 << ", "
20160805 00:56:31< vultraz> 										   << player_pos.y + 1 << ")").str();
20160805 00:56:34< vultraz> which is obvious
20160805 00:56:37< celmin> Why not just give people more gold instead?
20160805 00:56:37< vultraz> since that's a config value
20160805 00:57:06< celmin> Oh heh, that was gfgtdf.
20160805 00:57:24< celmin> Okay, so, his proposal isn't identical to giving more gold, I guess.
20160805 00:57:31< celmin> Still… meh...
20160805 00:59:14< irker679> wesnoth: Charles Dang wesnoth:master 6130c668c4b5 / src/ (11 files in 7 dirs): Use cleaner format for formatter() when possible https://github.com/wesnoth/wesnoth/commit/6130c668c4b5754c651a08a0f080dca133799266
20160805 00:59:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160805 00:59:23 * vultraz is noticing a noticeable lag when opening TGit windows after updating his windows 10
20160805 00:59:59< celmin> Eh, I forget my GNA password, so I'll do it later when I'm on the computer where I'm logged in.
20160805 01:00:25< tad_> See, I'm not the only GNA-challenged one here :)
20160805 01:00:28< vultraz> are you going to implement the unit_rgb thing?
20160805 01:00:37< celmin> Probably.
20160805 01:00:43< vultraz> ok
20160805 01:01:16< celmin> What was it again… [game_config]unit_rgb, and make that the default for [unit_type]flag_rgb… deprecate MAGENTA_IS_THE_TEAM_COLOR… was there something else?
20160805 01:01:44< tad_> ok. wife is up. need to feed her (and me, I guess) .. I'm work on the sRGB thing after dinner. hopefully libpng won't beat me up too badly .. l8trz
20160805 01:01:49-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160805 01:01:54< celmin> vultraz: variant.cpp:519 doesn't need a formatter.
20160805 01:02:03< celmin> Sorry, 643.
20160805 01:02:07< celmin> 519 does need it.
20160805 01:02:17< celmin> A few more like that as well.
20160805 01:02:54< celmin> I like it when people change code in comments.
20160805 01:03:14< celmin> slider.cpp:150 looks like it doesn't need a formatter.
20160805 01:03:35< celmin> So, that one and a bunch in variant.cpp.
20160805 01:09:35-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160805 01:10:36< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\widgets\slider.cpp|150|error: invalid conversion from 'int' to 'const char*' [-fpermissive]|
20160805 01:11:10< vultraz> guess I can't use to_string here
20160805 01:14:01< irker679> wesnoth: Charles Dang wesnoth:master 086a903dfa9a / src/formula/variant.cpp: Removed a few formatter() usecases that aren't actually needed https://github.com/wesnoth/wesnoth/commit/086a903dfa9a491570a85e28a8d370811951217c
20160805 01:19:13< irker679> wesnoth: Charles Dang wesnoth:master 6b5f7929d86d / src/ (gui/widgets/unit_preview_pane.cpp menu_events.cpp): Change a0c4b38f5276 to use image_mods() instead of TC_image_mods() https://github.com/wesnoth/wesnoth/commit/6b5f7929d86d6cbfaa1336da19e9078a3c9e523d
20160805 01:20:28< vultraz> ^ means it includes stuff like custom unit TC applied by [effect]
20160805 01:24:07-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 01:24:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160805 01:33:52< celmin> Huhwhat? Int to string? Why?
20160805 01:34:30-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 244 seconds]
20160805 01:38:52< vultraz> dunno
20160805 01:40:44-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Quit: Leaving]
20160805 01:46:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 01:49:10-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20160805 01:49:35< iceiceice> re: image compressions,
20160805 01:49:45< iceiceice> it would be really cool imo if we could somehow get the images into thier own repo
20160805 01:50:13< iceiceice> or like, use "resources" repo as a submodule or something
20160805 01:50:31< iceiceice> because then when you want to do mass image changes, it doesn't all go into the history
20160805 01:50:45< celmin> Yeah.
20160805 01:50:47< iceiceice> and poeple can do shallow clone of the image repo
20160805 01:50:53< celmin> Yeah.
20160805 01:50:53< iceiceice> and deep clone of the code repo
20160805 01:50:56< celmin> Indeed.
20160805 01:51:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160805 01:51:25< celmin> (Though complicating the initial clone process is not necessarily a good thing.)
20160805 01:51:32< iceiceice> yeah...
20160805 01:51:58< iceiceice> idk exactly what i am advocating
20160805 01:52:22< iceiceice> i guess it would be like, a script or something that clones an images repo into your data folder for dev builds
20160805 01:52:29< iceiceice> but that script would have to be cross-platform
20160805 01:52:40< iceiceice> idk if its worth
20160805 01:52:59< celmin> Ooh, a script in the repo that finishes the checkout could be helpful...
20160805 01:53:12< iceiceice> it might be that
20160805 01:53:17< celmin> Actually, maybe it wouldn't have to be cross-platform.
20160805 01:53:19< iceiceice> the repo is so big already that changes like this are marignally
20160805 01:53:22< iceiceice> *are marginal
20160805 01:53:36< celmin> I know Windows will run xyz.bat or xyz.exe if you just type xyz.
20160805 01:53:39< iceiceice> i doubt that we would rewrite the main repo
20160805 01:53:52< celmin> I wonder what it'd do if there was an xyz and an xyz.bat.
20160805 01:54:01< iceiceice> i guess i dont know
20160805 01:54:06< celmin> It probably wouldn't think of the former as something executable...
20160805 01:54:21< iceiceice> when i made the wml-tests bash script, people said that's not portable
20160805 01:54:23< celmin> Or that would be my guess anyway…
20160805 01:54:28< celmin> run_wml_tests?
20160805 01:54:29< irker679> wesnoth: Charles Dang wesnoth:master 6d298803fafc / src/gui/widgets/unit_preview_pane.cpp: Don't need to make minimal unit type name small, the label is already small. https://github.com/wesnoth/wesnoth/commit/6d298803fafcdec0d6b581cdeca82aab92f5b736
20160805 01:54:29< iceiceice> even though i guess windows can use bash
20160805 01:54:40< celmin> Mmhm.
20160805 01:54:41< iceiceice> celmin, probably the most portable thing is a python script i guess
20160805 01:54:46< celmin> True, true.
20160805 01:54:52< iceiceice> or lua :)
20160805 01:55:59-!- jamit [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has joined #wesnoth-dev
20160805 02:01:37< vultraz> no ancestral to be found
20160805 02:01:50< celmin> Seems like it.
20160805 02:02:03< celmin> Maybe he won't show up until Saturday.
20160805 02:02:14< vultraz> I'm gonna announce the release
20160805 02:08:32-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160805 02:09:38< tad_> oh am I glad I did that. out of over 13,000 PNG images, only 60 have the known incorrect sRGB .. and it comes from Photoshop .. and the person doing it MUST specifically tell photoshop to do it.
20160805 02:10:07< vultraz> :D
20160805 02:13:11< tad_> So now I need to find which 60 specifically. Clear the error and make a PR. The End Is Nigh.
20160805 02:13:58-!- vultraz changed the topic of #wesnoth-dev to: Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160805 02:14:53-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160805 02:17:12-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160805 02:23:45-!- vultraz changed the topic of #wesnoth-dev to: ancestral we need that package | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160805 02:27:34< Aginor> vultraz: I'm sure he's aware of that
20160805 02:27:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 02:27:57< Aginor> and if it's really a hurry, why don't you drop him an email? :)
20160805 02:29:37< vultraz> not that much of a hurry
20160805 02:31:42< vultraz> Aginor: I am compiling a GH gist checklist of the things we need to do for 1.14
20160805 02:31:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160805 02:32:41< vultraz> i figured I'd take your advice 
20160805 02:33:27< vultraz> make us a TODO list
20160805 02:37:18-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160805 02:42:57< Aginor> then you can assign milestones to it too
20160805 02:43:17< Aginor> see if you can talk people into some dates
20160805 02:43:30< Aginor> and suddenly you start to have a project plan
20160805 02:43:31< celticminstrel> So, the kraken doesn't use MAGENTA_IS_THE_TEAM_COLOR...
20160805 02:43:44< Aginor> and thne you cans tart to worry about risk management
20160805 02:43:55-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 02:43:57< Aginor> and then you can start to worry about risk management
20160805 02:46:53< celticminstrel> Heh, somehow the kraken looks like it's wearing sunglasses.
20160805 02:47:30< irker679> wesnoth: Charles Dang wesnoth:master a6dd6c668c94 / data/ (8 files in 6 dirs): Ran wmlindent and fixed badly formatted code https://github.com/wesnoth/wesnoth/commit/a6dd6c668c94ef0b75ca0c5108b3ca7caf7bd0d5
20160805 02:48:01< vultraz> Kraken?
20160805 02:48:12< vultraz> You mean the Cuttlefish?
20160805 02:48:29< celticminstrel> No, the kraken.
20160805 02:48:33< celticminstrel> In Dead Water.
20160805 02:49:25< vultraz> oh huh'
20160805 02:49:27< vultraz> it does
20160805 02:49:31< celticminstrel> Malin's sister doesn't use team colour either.
20160805 02:50:01< vultraz> they have no TC
20160805 02:50:13< vultraz> so no need to have specified MAGENTA_IS_THE_TEAM_COLOR
20160805 02:50:34< celticminstrel> Yeah, looks like it.,
20160805 02:52:17< celticminstrel> Konrad and whatshername as well.
20160805 02:52:34< vultraz> Li'sar?
20160805 02:52:41< celticminstrel> No, the queen.
20160805 02:52:51< celticminstrel> Li'sar does have TC.
20160805 02:53:00< vultraz> Oh that
20160805 02:53:02< celticminstrel> Maybe cause she changes sides.
20160805 02:53:04< vultraz> *hideous* sprite
20160805 02:53:19< vultraz> DEM LEGS THO
20160805 02:53:40< celticminstrel> Konrad has an obvious TC candidate, huh?
20160805 02:53:57< celticminstrel> Doesn't fit the ellipse palette though.
20160805 02:54:28< vultraz> just leave him non-tc
20160805 02:54:52< celticminstrel> What I mean is there's a part of the sprite that's an obvious candidate for being TCed, but isn't.
20160805 02:55:08< celticminstrel> I think it'd actually be good to TC him.
20160805 02:55:28< vultraz> then we should make those parts magenta
20160805 02:55:39< celticminstrel> Well, not high priority though.
20160805 02:55:57< celticminstrel> BTW, do you want me to explicitly disable TC on units that don't need it?
20160805 02:56:26< vultraz> No
20160805 02:56:31< celticminstrel> 'kay
20160805 02:56:37< vultraz> Or... ehh...
20160805 02:56:51< vultraz> I guess it doesn't matter either way
20160805 02:56:56< celticminstrel> Hmm. fabi_, why do I have two Great Ogres in LoW?
20160805 02:57:10< celticminstrel> I suppose one could be a remnant of something and not in the repo, I dunno.
20160805 02:59:40-!- Bonobo [~Bonobo@2001:44b8:254:3200:d001:5f9f:89be:a9dd] has quit [Ping timeout: 250 seconds]
20160805 03:00:01-!- Bonobo [~Bonobo@2001:44b8:254:3200:b0c8:86be:234c:a8a4] has joined #wesnoth-dev
20160805 03:00:19< celticminstrel> Haldric II is another who could be recoloured for TC.
20160805 03:01:17< celticminstrel> The Dwarvish Witness line.
20160805 03:01:36< celticminstrel> These basically look like they have the default TC (red) hard-coded.
20160805 03:01:56< vultraz> I AM A WITNESS 
20160805 03:02:13< celticminstrel> 9_9
20160805 03:02:30< celticminstrel> ...why is there a vampire in RoW?
20160805 03:03:07< vultraz> there's a vampire i think
20160805 03:03:14< celticminstrel> Why does the Autumn Shyde not extend the base one? Is it just for a cutscene or something?
20160805 03:03:28-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 03:03:29< travis-ci> wesnoth/wesnoth#10132 (master - 6b5f792 : Charles Dang): The build has errored.
20160805 03:03:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/149926453
20160805 03:03:29-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 03:03:31< vultraz> base what?
20160805 03:03:40< celticminstrel> Shyde.
20160805 03:04:04< vultraz> cutscene I think
20160805 03:04:27< celticminstrel> Whoa, a flying skull. o.o
20160805 03:05:05< vultraz> TRoW is one of our higher-quality campaigns
20160805 03:05:24< celticminstrel> Feels like nearly all the units in TRoW have hard-coded TC. The vampire is an exception though.
20160805 03:05:44< vultraz> the sprites are older
20160805 03:06:07< celticminstrel> I suppose that makes sense.
20160805 03:06:16< celticminstrel> And they're used in a way that makes it not really matter.
20160805 03:07:29< celticminstrel> I'm gonna skip checking out UtBS. It has too many custom units.
20160805 03:08:34< celticminstrel> Pirate ship should be TCed, I think.
20160805 03:10:28< vultraz> no, that's for the regular ship
20160805 03:10:44< celticminstrel> Both could be.
20160805 03:11:05< celticminstrel> Though I dunno if pirate ships are used on non-black sides.
20160805 03:12:00< vultraz> pirate flags are black
20160805 03:12:02< vultraz> by definition
20160805 03:12:31< celticminstrel> Shrug.
20160805 03:12:38< celticminstrel> I don't see why they have to be though.
20160805 03:13:25< celticminstrel> Most of the monsters are not TCed, huh.
20160805 03:15:05< celticminstrel> Bah.
20160805 03:15:36< celticminstrel> Bash can't handle a long argument list.
20160805 03:16:37< celticminstrel> Uhh. Something went wrong. It opened files that don't even contain MAGENTA_IS_THE_TEAM_COLOR.
20160805 03:18:16< celticminstrel> ...
20160805 03:18:33 * celticminstrel sigh.
20160805 03:18:55< celticminstrel> -L is the opposite of -l, huh...
20160805 03:29:25< celticminstrel> For ancestral, whenever he shows up: "Fontconfig warning: line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf"
20160805 03:31:09< celticminstrel> Also, TC works in his build! \o/ But is still broken in mine for some reason.
20160805 03:31:33< vultraz> your build hates you
20160805 03:31:47-!- jamit [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has quit [Read error: Connection reset by peer]
20160805 03:34:08-!- jamit1 [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has joined #wesnoth-dev
20160805 03:34:11< celticminstrel> Meh.
20160805 03:34:24-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 260 seconds]
20160805 03:39:56-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 03:41:43-!- RatArmy [~RatArmy@133.15.175.65] has quit [Client Quit]
20160805 03:41:57-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 03:42:36-!- jamit1 [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has left #wesnoth-dev []
20160805 03:45:10-!- JyrkiVesterinen [~JyrkiVest@87-100-133-107.bb.dnainternet.fi] has joined #wesnoth-dev
20160805 03:45:10< celticminstrel> Okay vultraz, I've done it. Now it's your job to test it and, if it works, merge it.
20160805 03:45:29< celticminstrel> (Once I push, of course.)
20160805 03:52:05< vultraz> should I merge 725?
20160805 03:52:15< celticminstrel> I dunno, what is it?
20160805 03:52:24< vultraz> the png fixes
20160805 03:52:31< celticminstrel> From Tad?
20160805 03:52:39< vultraz> ya
20160805 03:52:39-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Ping timeout: 264 seconds]
20160805 03:52:52< celticminstrel> Sure I guess, but let's deal with this TC thing first.
20160805 03:54:49< vultraz> *waits*
20160805 03:57:08< irker679> wesnoth: Celtic Minstrel wesnoth:tc_deprecate 54d6af42ca24 / / (320 files in 45 dirs): Deprecate {MAGENTA_IS_THE_TEAM_COLOR} https://github.com/wesnoth/wesnoth/commit/54d6af42ca24c87ca0382aec1870d97ca5d6e821
20160805 03:57:20< celticminstrel> Go Vultraz!
20160805 03:57:43< celticminstrel> (It's on a branch in case you missed that detail.)
20160805 04:02:51-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 258 seconds]
20160805 04:10:51 * celticminstrel waits to delete the branch
20160805 04:11:02< vultraz> you forgot to move the macro into deprecated-utils
20160805 04:11:08< vultraz> still building
20160805 04:11:09< celticminstrel> ah.
20160805 04:11:22< celticminstrel> Well, you could do that and amend the commit, I suppose.
20160805 04:11:39< vultraz> I assume you're going to push directly to master
20160805 04:11:42< vultraz> so I'll let you
20160805 04:11:48< celticminstrel> Well, I could.
20160805 04:11:59< celticminstrel> I was assuming you would, but it really makes no difference either way.
20160805 04:12:31< JyrkiVesterinen> celticminstrel: Git master builds fine with MSVC2013.
20160805 04:12:41< celticminstrel> Yay!
20160805 04:12:57< celticminstrel> I assume you know what to look for, right vultraz?
20160805 04:13:08< vultraz> just check that everyone has tc? :P
20160805 04:13:14 * celticminstrel nod
20160805 04:13:26< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\units\unit.cpp|1028|error: 'unit_rgb' is not a member of 'game_config'|
20160805 04:13:29< vultraz> blah
20160805 04:13:54< celticminstrel> ...blah indeed, because I did add it...
20160805 04:14:08< vultraz> not in the header
20160805 04:14:12< celticminstrel> Ohh.
20160805 04:14:26< celticminstrel> Will fix.
20160805 04:14:37< vultraz> I just realized why you can't test this
20160805 04:14:39< vultraz> you don't have tc
20160805 04:14:43< celticminstrel> Yes.
20160805 04:14:55< vultraz> you sure you aren't building with LOW_MEM
20160805 04:14:59< celticminstrel> Pretty sure.
20160805 04:15:03< vultraz> do check
20160805 04:15:19< celticminstrel> Well, it's not enabled in the XCode project, otherwise ancestral would also be missing TC.
20160805 04:15:52< vultraz> true
20160805 04:16:55< vultraz> i suppose any checks for flag_rgb not being empty could be removed.. but that's something that can be done seperately 
20160805 04:17:04< vultraz> separately 
20160805 04:17:08< celticminstrel> I dunno.
20160805 04:17:13< celticminstrel> I suppose they could be, sure.
20160805 04:17:34< vultraz> that's something i could deal with
20160805 04:18:13< celticminstrel> Go Vultraz!
20160805 04:18:17< irker679> wesnoth: Celtic Minstrel wesnoth:tc_deprecate 8fcc0033f524 / / (322 files in 45 dirs): Deprecate {MAGENTA_IS_THE_TEAM_COLOR} https://github.com/wesnoth/wesnoth/commit/8fcc0033f524384c43dde361c2d7ab3f0ccad820
20160805 04:18:23< vultraz> :|
20160805 04:18:24< celticminstrel> reset HEAD^ --hard first or something
20160805 04:18:29< vultraz> i'm still building
20160805 04:18:38< vultraz> I hope that just adds the thing to the header
20160805 04:18:45< celticminstrel> It does, and the macro move.
20160805 04:18:49< vultraz> ok
20160805 04:18:53< vultraz> I don't need to pull then
20160805 04:19:10< celticminstrel> Well, if you added it to the header yourself, then no, you don't need to pull.
20160805 04:20:57< celticminstrel> Who's in charge of updating the front page?
20160805 04:22:18< vultraz> I asked shadowm to do so
20160805 04:23:30< vultraz> We really need to automate that
20160805 04:23:55< celticminstrel> Automating it is pretty easy to do. I think someone said there was a reason not to though. I dunno.
20160805 04:25:58< celticminstrel> How's the build going?
20160805 04:26:08< vultraz> it's in units/
20160805 04:29:43< vultraz> no-one is TC-ed in Create unit
20160805 04:30:04< vultraz> or help
20160805 04:30:26< vultraz> so it's something to do with plain types
20160805 04:30:52< celticminstrel> What about on the map, or leaders in MP setup?
20160805 04:31:17< vultraz> celticminstrel: you handled the fallback in the wrong place
20160805 04:31:22< vultraz> it should be in unit_type not unit
20160805 04:31:28< celticminstrel> Oh, right.
20160805 04:31:31< celticminstrel> Okay.
20160805 04:33:19< vultraz> changed, building again
20160805 04:34:38< celticminstrel> Still expecting me to push the final result?
20160805 04:34:49< vultraz> yes
20160805 04:35:03< celticminstrel> Just to be sure, what you changed is that unit_type::flag_rgb now returns what I had unit::team_color return?
20160805 04:35:26< vultraz> yes
20160805 04:37:41-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 04:37:42< travis-ci> wesnoth/wesnoth#10136 (tc_deprecate - 54d6af4 : Celtic Minstrel): The build has errored.
20160805 04:37:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/149949040
20160805 04:37:42-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 04:48:02< vultraz> celticminstrel: yup, stuff's good if you put it in unit type
20160805 04:49:16< celticminstrel> If you're on master, make sure to reset to HEAD^. (If you're also on a branch, naturally that's not necessary.)
20160805 04:49:21< vultraz> branch
20160805 04:49:48< celticminstrel> Okay, sleepytime then.
20160805 04:49:54< celticminstrel> (As soon as I push it.)
20160805 04:50:12< vultraz> thanks
20160805 04:50:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 04:50:30< vultraz> you do good work :)
20160805 04:54:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160805 04:57:13< irker679> wesnoth: Celtic Minstrel wesnoth:master b295aab4ba75 / / (324 files in 45 dirs): Deprecate {MAGENTA_IS_THE_TEAM_COLOR} https://github.com/wesnoth/wesnoth/commit/b295aab4ba75ef8dfe6568f427c96cb6838f62f0
20160805 04:57:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160805 04:59:19-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 04:59:20< travis-ci> wesnoth/wesnoth#10137 (tc_deprecate - 8fcc003 : Celtic Minstrel): The build passed.
20160805 04:59:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/149951974
20160805 04:59:20-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 05:09:59< shadowm> vultraz: In the future, make sure you link to the thread, not the first post.
20160805 05:10:48< shadowm> The topic link points to https://forums.wesnoth.org/viewtopic.php?f=5&p=599754 . That's actually a post link, not a thread link.
20160805 05:11:14< shadowm> This is the thread link: https://forums.wesnoth.org/viewtopic.php?f=5&t=44428
20160805 05:11:24< shadowm> Or just https://forums.wesnoth.org/viewtopic.php?t=44428 .
20160805 05:11:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 05:11:55-!- Kwandulin [~Miranda@p200300760F6062A865041814C5E4EA25.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160805 05:13:45< shadowm> Also, whoever made the OS X download links both "previous version", I think we'd all prefer if you just commented out one of them.
20160805 05:13:54< shadowm> <!-- this is a HTML comment. MediaWiki knows what it means -->
20160805 05:14:19< vultraz> Ah
20160805 05:14:21< vultraz> Sorry
20160805 05:14:51< Kwandulin> vultraz: you linked to the changelogs for 1.13.4: https://forums.wesnoth.org/viewtopic.php?f=5&t=44428
20160805 05:15:00< vultraz> wha?
20160805 05:15:33< Kwandulin> Also congratulations on getting the new version out, it feels like a nice step forward once again
20160805 05:15:34< vultraz> I knew I forgot something :|
20160805 05:15:54< vultraz> fixed
20160805 05:15:59< vultraz> thanks
20160805 05:16:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160805 05:18:00< shadowm> The front page is now in touch with the current state of events.
20160805 05:18:12< vultraz> thanks
20160805 05:18:24< shadowm> Has been for the past 5 minutes it apparently took me to go fetch a cup of tea.
20160805 05:18:58< vultraz> thanks for fixing the post
20160805 05:24:23-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-58.zoominternet.net] has quit []
20160805 05:29:38-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160805 05:33:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160805 05:33:30-!- wedge010 is now known as wedge009
20160805 05:44:14< irker679> wesnoth: Jyrki Vesterinen wesnoth:master a74f1054cace / / (20 files in 12 dirs): Always use underscores in event names https://github.com/wesnoth/wesnoth/commit/a74f1054caceb2fb32afe1b48fa841955273c202
20160805 06:14:10-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 252 seconds]
20160805 06:24:03-!- Nobun [~nobun@host6-245-dynamic.249-95-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160805 06:33:36-!- Nobun1 [~nobun@95.232.242.148] has joined #wesnoth-dev
20160805 06:34:35-!- Nobun1 [~nobun@95.232.242.148] has quit [Client Quit]
20160805 06:36:32-!- Nobun [~nobun@host6-245-dynamic.249-95-r.retail.telecomitalia.it] has quit [Ping timeout: 240 seconds]
20160805 06:44:29-!- atarocch [~atarocch@194.127.9.104] has joined #wesnoth-dev
20160805 07:03:09-!- TC02 [~quassel@venus.arosser.com] has quit [Ping timeout: 265 seconds]
20160805 07:27:25-!- boucman_work [~boucman@229.29.205.77.rev.sfr.net] has joined #wesnoth-dev
20160805 07:41:42-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 07:41:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160805 07:54:15< zookeeper> vultraz, wth are you planning now WRT TC?
20160805 08:06:21< zookeeper> anyone: explain b295aab4ba7
20160805 08:08:26< zookeeper> so it's really only about making magenta the default, making MAGENTA_IS_THE_TEAM_COLOR unnecessary?
20160805 08:09:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 08:12:40< zookeeper> JyrkiVesterinen, the underscore thing should have only been done for the engine code :|
20160805 08:13:04< JyrkiVesterinen> Why? Is it a problem to use underscores in WML?
20160805 08:13:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160805 08:13:39< JyrkiVesterinen> (A lot of existing scenarios *do* use underscores. I noticed that when looking for fire_event actions in them.)
20160805 08:14:03< zookeeper> it's not a technical problem but if there can be said to be a convention, then i'd say it would be to use spaces unless one needs to avoid them for some reason.
20160805 08:14:49< JyrkiVesterinen> I prefer underscores because it makes debugging easier for new developers who want to find where an event is sent.
20160805 08:15:01< zookeeper> the event names are documented without spaces, and practically always written without spaces. whether one uses the same names in an [event] or [fire_event] shouldn't make any difference.
20160805 08:16:27< JyrkiVesterinen> Well, the I could change the documentation as well. Spaces and underscores are interchargeable anyway.
20160805 08:16:29< JyrkiVesterinen> *then
20160805 08:16:42< zookeeper> but since it only touches the latter uses and there's not that many of them, it's not a big deal, just introduces a slight unexplainable inconsistency
20160805 08:17:10< zookeeper> (unexplainable by just looking at the WML, that is)
20160805 08:20:46< vultraz> zookeeper: in a nutshell
20160805 08:24:06< zookeeper> okay
20160805 08:33:29< JyrkiVesterinen> Event documentation changed.
20160805 08:34:24-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 244 seconds]
20160805 08:35:29-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 08:36:59-!- edgrey [~edgrey@178.204.120.31] has joined #wesnoth-dev
20160805 08:37:26< zookeeper> what what what
20160805 08:37:48< zookeeper> why
20160805 08:37:49< zookeeper> what
20160805 08:38:12< zookeeper> no, please revert that
20160805 08:40:07< JyrkiVesterinen> The documentation change?
20160805 08:40:15< zookeeper> yeah
20160805 08:40:41< JyrkiVesterinen> Reverted.
20160805 08:42:20< zookeeper> great, thanks. i mean, you can run a grep for "last breath" in data/campaigns/ or something if you're not convinced that spaces are the usual convention
20160805 08:43:38< zookeeper> and UMC is no different in that regard, so changing documentation to match the much more rarely used form doesn't really make sense
20160805 08:45:53< JyrkiVesterinen> I can just as well run such a search.
20160805 08:46:14< JyrkiVesterinen> (Also, I wonder why the event code went to change spaces to underscores and not the other way around.)
20160805 08:46:16< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/game_events/pump.hpp#L47-L52
20160805 08:47:48< JyrkiVesterinen> (That's the reason why the event names are spelled with underscores when I look at them in a debugger. Had the code replaced underscores with spaces instead, there would only have been trouble with events spelled with underscores, i.e. the "much more rarely used form".)
20160805 08:48:12 * zookeeper doesn't know
20160805 08:50:46-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 250 seconds]
20160805 08:53:14< JyrkiVesterinen> Search "last breath" (297 hits in 133 files)
20160805 08:53:20< JyrkiVesterinen> Search "last_breath" (3 hits in 2 files)
20160805 08:53:37< JyrkiVesterinen> Indeed, the space form is much more common when listening for events.
20160805 08:54:17< JyrkiVesterinen> Custom events seem to be spelled with underscores more often, though. For example, LoW scenario 2 has events like "dwarves_watch_the_show".
20160805 08:54:30< zookeeper> yeah
20160805 08:54:51-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160805 08:55:10< Aginor> I think it's unfortunate that we have two different spellings for the same event
20160805 08:56:06< JyrkiVesterinen> Yes, and it's even more unfortunate that the code that normalizes event name spelling chose the less common option.
20160805 08:56:51< JyrkiVesterinen> I think I'll revert the changes to scenarios I did in commit a74f1054.
20160805 08:58:27< zookeeper> Aginor, well i don't really see the problem, swapping spaces to underscores or vice versa is a rather super-simple operation after all
20160805 08:59:01-!- Kwandulin [~Miranda@p200300760F6062A865041814C5E4EA25.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160805 08:59:27< zookeeper> IIRC the support for underscores was basically added just so you would have an easy workaround if you need to name a space-containing event in WML in a place where spaces would otherwise cause a problem
20160805 08:59:53< JyrkiVesterinen> The problem is just yet another debugging gotcha: that the event may be spelled at the firing site in a different way than in the debugger.
20160805 09:03:19< Aginor> zookeeper: I think it's unfortunate because it adds complexity all around, it's not a simple matter of string comparison any longer unless the engine enforces a standard internally
20160805 09:05:00< Aginor> but I also recognise this is one of those things that's hard to change because it would involve chaning every piece of UMC ;D
20160805 09:07:58< zookeeper> yeah, but still it really seems like a very minor issue to me. was all this prompted by someone actually stumbling on the space/underscore thing in some way, or is that still a hypothetical debugging problem?
20160805 09:08:30< Aginor> I'm just weighing in on something that's not really my purview ;)
20160805 09:09:42-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 09:10:39< JyrkiVesterinen> It was just me wasting too much time trying to figure out where the enemies_defeated event was sent.
20160805 09:10:53< Aginor> hmmm
20160805 09:10:55< Aginor> error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
20160805 09:11:54< irker679> wesnoth: Jyrki Vesterinen wesnoth:master 1e2b6ba92d06 / data/ (12 files in 8 dirs): Revert the campaign changes of commit a74f1054 https://github.com/wesnoth/wesnoth/commit/1e2b6ba92d0680749713773c3016ac900ee0e5c8
20160805 09:12:01< Aginor> if (i>0) std::cout << ','; i++;
20160805 09:13:23< Aginor> looks like GCC has added more checks
20160805 09:22:15-!- JyrkiVesterinen [~JyrkiVest@87-100-133-107.bb.dnainternet.fi] has quit [Quit: Going somewhere]
20160805 09:24:59-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160805 09:33:25-!- Kwandulin [~Miranda@p200300760F6062B511080A5C8F89E755.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160805 09:34:52< irker679> wesnoth: Andreas Löf wesnoth:bug24553fix 0205a9b59c12 / src/storyscreen/render.cpp: Ensure that the buttons are redrawn when the bigmap is drawn on top https://github.com/wesnoth/wesnoth/commit/0205a9b59c12eb7c020afcbe0076a8a11175ef01
20160805 09:40:30-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 276 seconds]
20160805 09:41:12-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160805 09:46:27-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 09:46:28< travis-ci> wesnoth/wesnoth#10141 (master - 1e2b6ba : Jyrki Vesterinen): The build has errored.
20160805 09:46:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/149999936
20160805 09:46:28-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 09:52:02-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160805 09:53:19< vultraz> I never understood why we just didn't enforce either spaces or underscores years ago
20160805 09:53:50< vultraz> what purpose was to be gained by allowing both
20160805 09:56:02< vultraz> I guess it's one of those little quirk in WML that were never changed bc "le backwards compatibility"
20160805 09:56:30< zookeeper> go and find out, i'm sure the rationale was mentioned at the time.
20160805 09:56:40< vultraz> which is when?
20160805 09:56:48< zookeeper> you have to find that out too
20160805 09:57:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 09:59:08< zookeeper> ...if you're especially interested in it in the first place, that is.
20160805 10:00:58< irker679> wesnoth: Gregory A Lundberg wesnoth:master ee8778a6d7f4 / data/lua/wml/objectives.lua: objectives.lua show_turn_counter in white https://github.com/wesnoth/wesnoth/commit/ee8778a6d7f43ccaff6fe4152eeef6cf071bf706
20160805 10:01:00< irker679> wesnoth: Charles Dang wesnoth:master 7b22051c3cc4 / data/lua/wml/objectives.lua: Merge pull request #721 from GregoryLundberg/GL_lua_objectives https://github.com/wesnoth/wesnoth/commit/7b22051c3cc4ea4f8011d194d1e20769d70734ae
20160805 10:01:32< irker679> wesnoth: Gregory A Lundberg wesnoth:master 140cc946bb18 / data/ (60 files in 5 dirs): Fix bug: libpng warning: iCCP: known incorrect sRGB profile https://github.com/wesnoth/wesnoth/commit/140cc946bb18eee103cc4be8868de2d6dfed1083
20160805 10:01:34< irker679> wesnoth: Charles Dang wesnoth:master c0a06e3af8f3 / data/ (60 files in 5 dirs): Merge pull request #725 from GregoryLundberg/GL_update_images https://github.com/wesnoth/wesnoth/commit/c0a06e3af8f3145b007b21e06fc297f823b9f8fa
20160805 10:02:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160805 10:06:15-!- JyrkiVesterinen [~JyrkiVest@87-100-133-107.bb.dnainternet.fi] has joined #wesnoth-dev
20160805 10:06:53< vultraz> I didn't test that myself but Gregory/tad already demonstrated it was a fix.
20160805 10:09:22-!- Duthlet [~Duthlet@dslb-178-005-055-087.178.005.pools.vodafone-ip.de] has joined #wesnoth-dev
20160805 10:15:27-!- iceiceice [~chris@ext-74.ias.edu] has quit [Ping timeout: 264 seconds]
20160805 10:35:35-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160805 10:53:23-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160805 11:05:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160805 11:11:38-!- travis-ci [~travis-ci@ec2-54-234-146-129.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 11:11:39< travis-ci> wesnoth/wesnoth#10143 (master - 7b22051 : Charles Dang): The build passed.
20160805 11:11:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150010192
20160805 11:11:39-!- travis-ci [~travis-ci@ec2-54-234-146-129.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 11:23:22< irker679> wesnoth: Andreas Löf wesnoth:master 15ff7e7d1a1e / src/ (events.cpp storyscreen/render.cpp): Fix bug #24553: Prevent the display (and others) from drawing over the storyscre https://github.com/wesnoth/wesnoth/commit/15ff7e7d1a1e726b0e6d03196453a7d8efc0a61c
20160805 11:23:24< irker679> wesnoth: Andreas Löf wesnoth:master 0205a9b59c12 / src/storyscreen/render.cpp: Ensure that the buttons are redrawn when the bigmap is drawn on top https://github.com/wesnoth/wesnoth/commit/0205a9b59c12eb7c020afcbe0076a8a11175ef01
20160805 11:23:26< irker679> wesnoth: Andreas wesnoth:master 037a767ada41 / src/ (events.cpp storyscreen/render.cpp): Merge pull request #717 from wesnoth/bug24553fix https://github.com/wesnoth/wesnoth/commit/037a767ada4136e0c20e0e3078cad911a9ed315b
20160805 11:27:26< irker679> wesnoth: Andreas Löf wesnoth:master e24115088a15 / changelog: Add fix of bug #24553 to changelog https://github.com/wesnoth/wesnoth/commit/e24115088a15c1e32d51bf3bae3b49c55933eefd
20160805 11:28:32-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20160805 11:29:04< Aginor> I always seem to forget adding stuff to the changelog :/
20160805 11:31:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160805 11:37:58-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 11:37:59< travis-ci> wesnoth/wesnoth#10144 (master - c0a06e3 : Charles Dang): The build passed.
20160805 11:37:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150010371
20160805 11:37:59-!- travis-ci [~travis-ci@ec2-54-226-18-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 11:45:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 11:45:59-!- gfgtdf [~chatzilla@x4e363ba4.dyn.telefonica.de] has joined #wesnoth-dev
20160805 11:46:18< gfgtdf> vultraz: 6130c668c4b5754c651a08a0f080dca133799266 removed a fomatter in src/mt_rng.cpp
20160805 11:46:30< Aginor> for those interested, I've got a steam controller on order now
20160805 11:46:41< gfgtdf> vultraz: this is quite bad sicne it might cause all other error message to be printed in hex.
20160805 11:47:15< gfgtdf> vultraz: same in game_lua_kernel.cpp
20160805 11:47:27< gfgtdf> vultraz: please revert those changes in those files
20160805 11:50:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160805 11:57:18< gfgtdf> vultraz: if you dont know why some code is done in a certain way, you can use git blame to find the ommit that made that code. In the case go to https://github.com/wesnoth/wesnoth/blame/1.13.5/src/mt_rng.cpp, go to the line where the formatte is (84) and it will point you to this commit https://github.com/wesnoth/wesnoth/commit/548c5d74ae710647734ec1a906c50d595e3365c1
20160805 11:58:38-!- JyrkiVesterinen [~JyrkiVest@87-100-133-107.bb.dnainternet.fi] has quit [Quit: .]
20160805 12:56:34-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160805 12:56:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 12:58:13-!- RatArmy [~RatArmy@om126212092091.11.openmobile.ne.jp] has joined #wesnoth-dev
20160805 13:01:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160805 13:03:45-!- JyrkiVesterinen [~JyrkiVest@87-92-52-100.bb.dnainternet.fi] has joined #wesnoth-dev
20160805 13:06:15-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20160805 13:07:04-!- Kwandulin [~Miranda@p200300760F6062B511080A5C8F89E755.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160805 13:10:39-!- Bonobo [~Bonobo@2001:44b8:254:3200:b0c8:86be:234c:a8a4] has quit [Ping timeout: 250 seconds]
20160805 13:22:03-!- Appleman1234 [~Appleman1@KD036012024194.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160805 14:04:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20160805 14:08:10-!- Kwandulin [~Miranda@p200300760F6062B5AC5CCD73488C64A5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160805 14:15:17-!- JyrkiVesterinen [~JyrkiVest@87-92-52-100.bb.dnainternet.fi] has quit [Quit: .]
20160805 14:17:11-!- atarocch [~atarocch@194.127.9.104] has quit [Remote host closed the connection]
20160805 14:18:30-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160805 14:27:28-!- irker679 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160805 14:31:42-!- iceiceice [~chris@ext-74.ias.edu] has quit [Quit: Ex-Chat]
20160805 14:31:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160805 14:38:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160805 14:42:49-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160805 14:44:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160805 14:49:34-!- Kwandulin [~Miranda@p200300760F6062B5AC5CCD73488C64A5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160805 14:58:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160805 14:59:32-!- RatArmy [~RatArmy@om126212092091.11.openmobile.ne.jp] has quit [Ping timeout: 240 seconds]
20160805 15:01:35-!- Duthlet [~Duthlet@dslb-178-005-055-087.178.005.pools.vodafone-ip.de] has quit [Ping timeout: 250 seconds]
20160805 15:16:32 * celmin discovers git log --graph
20160805 15:16:45-!- Kwandulin [~Miranda@p200300760F6062B579256CCBD6417D02.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160805 15:20:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160805 15:28:19-!- gfgtdf [~chatzilla@x4e363ba4.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160805 15:48:29-!- boucman_work [~boucman@229.29.205.77.rev.sfr.net] has quit [Remote host closed the connection]
20160805 15:51:52-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160805 15:58:50< ancestral> celmin: I saw you had success with MacPorts libs
20160805 15:59:09< celmin> I pinged you a couple of times in the logs, actually.
20160805 15:59:14< ancestral> I thoguht later, geez, I coulda done that, but, maybe you being on 10.7 might have resulted in a different build than mine
20160805 15:59:21< celmin> Probably.
20160805 15:59:29< ancestral> celmin: Anyway, how can I obtain these from you?
20160805 15:59:35< celmin> Unfortunately, to get it to work I had to add libgmodule amd libpcre.
20160805 15:59:44< ancestral> Hmm, weird
20160805 15:59:45< celmin> Even though I'm pretty sure PCRE is not used anywhere.
20160805 15:59:50< celmin> Is that a problem?
20160805 15:59:54< ancestral> Probably not
20160805 16:00:02< celmin> The libs are under http://celmin.pwcsite.com/wesnoth
20160805 16:00:07< ancestral> Thanks
20160805 16:00:16< celmin> I didn't include the fixed Boost libs since I assumed you had already fixed those.
20160805 16:00:21-!- SigurdFD [~SigurdFD@dynamic-acs-72-23-110-58.zoominternet.net] has joined #wesnoth-dev
20160805 16:00:23< ancestral> Yes, I did fix them
20160805 16:00:39< celmin> It'd be good to see if you can build with my libs as well as running with them, though I guess the latter is the priority here.
20160805 16:01:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 16:01:57< ancestral> I have libgmodule already so that is not surprising
20160805 16:02:12< celmin> It wasn't included in the package though.
20160805 16:02:23< ancestral> Hmm
20160805 16:02:27< celmin> PCRE is still a bit weird however. It seems to be a dependency of my glib.
20160805 16:02:44< ancestral> Well, we’ll see what happens
20160805 16:03:43< ancestral> Cleaning and building. First without PCRE, next with it.
20160805 16:04:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: No route to host]
20160805 16:04:32-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160805 16:07:29< fabi_> celmin: I have cleaned all the mainline campaigns regarding FOREACH now.
20160805 16:07:45< celmin> Fun.
20160805 16:08:01< fabi_> I am a bit unsure to make it a big commit.
20160805 16:08:03< celmin> ancestral: Shouldn't need PCRE for building, maybe for bundling though.
20160805 16:08:27< celmin> fabi_: I don't mind it being a big commit, but if you don't like it, you could do one commit per campaign or something.
20160805 16:08:46< celmin> Or, one commit for each campaign that has a lot of uses, and another commit for all the rest.
20160805 16:08:48< celmin> Or something!
20160805 16:08:54< fabi_> okay
20160805 16:09:00< celmin> I dunno, split it up however you want as long as it's not totally nonsensical. :P
20160805 16:09:35< fabi_> celmin: It would be nice if you or others read all or each one a part of it. Testing all of them is just not an option.
20160805 16:10:23< celmin> Not quite sure what you said, but if you mean you'd like me to review it, then yes, I will.
20160805 16:10:43< fabi_> Indeed, that was my request.
20160805 16:11:08< celmin> Did you change [foreach]variable to [foreach]array?
20160805 16:11:28< fabi_> Yes
20160805 16:11:40< fabi_> The commit will include the change to the syntax
20160805 16:23:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 258 seconds]
20160805 16:24:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160805 16:29:35< fabi_> celmin: There is no other unbalanced wml left then, right?
20160805 16:29:56< celmin> No idea.
20160805 16:30:28< celmin> Do Dead Water or UtBS use unbalanced WML for the stun ability? (That'll be removed when I rework abilities though, if they do.)
20160805 16:30:54< fabi_> LoW is also free of it.
20160805 16:31:16< fabi_> And aOI
20160805 16:31:31< celmin> You could do a search for those magic comments that unbalanced WML is usually annotated with.
20160805 16:31:54< fabi_> wmllint directives?
20160805 16:33:44-!- Greg-Bog_ is now known as Greg-Boggs
20160805 16:33:48< celmin> Yeah, or wmlscope directives.
20160805 16:43:03-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160805 16:44:24< celmin> My XCode index must be broken. :( Jump to Definition no longer works in game_lua_kernel.cpp.
20160805 16:48:35< fabi_> "{VARIABLE_OP random sub tents[i].y}"
20160805 16:48:51< fabi_> Must be a bug, right?
20160805 16:48:52< celmin> What about it?
20160805 16:48:58< celmin> Must it?
20160805 16:48:59< celmin> I dunno.
20160805 16:49:01< fabi_> tents[i]
20160805 16:49:07< fabi_> can't be valid
20160805 16:49:19< fabi_> since i is not a valid array access?
20160805 16:49:22< celmin> Ah, I see, missing $
20160805 16:49:34< fabi_> I have found some of them
20160805 16:49:43< fabi_> or similar bugs
20160805 16:50:19< celmin> Hmm, I wonder how widely used wesnoth.place_shroud and wesnoth.remove_shroud are...
20160805 16:50:34< celmin> Probably a lot...
20160805 16:50:43 * celmin wants to change their interface.
20160805 16:50:50-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160805 16:51:23< celmin> Currently it's wesnoth.*_shroud(cfg). I'd rather it be more like wesnoth.*_shroud(side_list, cfg_or_shroud_data_string)
20160805 16:51:45< celmin> Hmm, maybe the second param should be loc_list_or_shroud_data_string
20160805 16:51:58-!- Kwandulin [~Miranda@p200300760F6062B579256CCBD6417D02.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160805 16:52:34< celmin> Well, I guess I could add a definition to backward-compatibility.lua if necessary to support both.
20160805 16:52:54-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160805 16:55:33< ancestral> I get errors running scons translations
20160805 16:55:42< celmin> Uh. What kind of errors?
20160805 16:55:49< ancestral> OSError: [Errno 2] No such file or directory: '/usr/include':
20160805 16:56:28< ancestral> https://paste.ee/p/vGaKX
20160805 16:56:50< ancestral> I tried translations earlier, then translate (I always forget which is right)
20160805 16:56:56< ancestral> Regardless, same errors
20160805 16:57:14-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160805 16:57:22< celmin> Uhhhh...
20160805 16:57:35< celmin> If /usr/include doesn't exist then something is seriously broken.
20160805 16:57:47-!- JyrkiVesterinen [~JyrkiVest@87-92-45-153.bb.dnainternet.fi] has joined #wesnoth-dev
20160805 16:58:05< celmin> So I doubt that's the problem...
20160805 16:58:32< ancestral> I suppose I can nab the translations from the 1.13.5 Win package
20160805 16:58:55< celmin> I suppose...
20160805 16:59:02< celmin> Weird that it's not working...
20160805 16:59:35< celmin> Maybe that error could result from /usr not having read permissions or something, but that shouldn't be the case.
20160805 16:59:50< ancestral> Dumping a folder called translationis
20160805 16:59:58< ancestral> Nop
20160805 17:00:02< celmin> ?
20160805 17:00:22< ancestral> I thought maybe if I deleted the translations dir
20160805 17:00:24< ancestral> In the project
20160805 17:00:30< ancestral> Wrong perms or something
20160805 17:00:40< ancestral> No difference
20160805 17:00:45< celmin> Ah.
20160805 17:01:23< ancestral> Tried scons with sudo, no change
20160805 17:01:37< ancestral> iceiceice: If you have any ideas, let me know :)
20160805 17:02:21< ancestral> Hmm, I have a space in the wesnoth dir, could that make a difference?
20160805 17:02:43< ancestral> Nope
20160805 17:09:10-!- edgrey [~edgrey@178.204.120.31] has quit [Ping timeout: 244 seconds]
20160805 17:11:32< ancestral> celmin: AFK for about 30 minutes. Upload will finish in about 15 minutes.
20160805 17:11:42< celmin> Is that for me to test?
20160805 17:11:44< ancestral> When you have time, see if this works for you: http://mproud.com/wesnoth/Wesnoth_1.13.5_en.dmg (when upload is done)
20160805 17:11:45< ancestral> Yeah
20160805 17:11:47< celmin> Or the final … okay.
20160805 17:12:05< ancestral> It’s the final package minus the translations, which I’m going to steal from the Win package
20160805 17:12:17< ancestral> After lunch
20160805 17:16:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160805 17:22:34-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160805 17:29:39-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160805 17:32:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160805 17:32:19-!- wedge010 is now known as wedge009
20160805 17:32:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160805 17:34:05-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160805 17:35:45-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Client Quit]
20160805 17:36:37-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160805 17:36:37< fabi_> celmin: The runtime var of [for] must not be cleared?
20160805 17:36:51< fabi_> s/must/needs
20160805 17:38:02-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160805 17:38:27< celticminstrel> It should be cleared.
20160805 17:38:40< celticminstrel> Using end_var_scope
20160805 17:47:58< celticminstrel> Anyone know if there's a way to clear shroud from the entire map in C++?
20160805 18:04:39< loonycyborg> ancestral: it seems "scons translations" error is due to use of os.path.samefile. Maybe that function doesn't work on macos? It should though..
20160805 18:06:26< zookeeper> fabi_, what are you doing and why?
20160805 18:07:41-!- Kwandulin [~Miranda@p200300760F6062B5F0ED2FB449779272.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160805 18:08:22< fabi_> hi zookeeper
20160805 18:08:37< fabi_> replacing {FOREACH}
20160805 18:09:24< fabi_> ask celticminstrel, he wanted to do that, I am just giving him a helping hand.
20160805 18:10:33< ancestral> loonycyborg: The problem is there is no /usr/include in macOS
20160805 18:12:11< fabi_> zookeeper: By the way, what are you doing and why are you doing it?
20160805 18:12:18< celticminstrel> ...
20160805 18:12:25< celticminstrel> ancestral: That's not true.
20160805 18:12:31< celticminstrel> There is a /usr/include, but it's hidden.
20160805 18:12:40< celticminstrel> (Unless that was changed in later releases, I suppose.)
20160805 18:12:45< celticminstrel> Or, well, there's at least /usr.
20160805 18:12:48< ancestral> -bash: cd: /usr/include: No such file or directory
20160805 18:13:00< celticminstrel> So /usr exists and /usr/include does not?
20160805 18:13:03< ancestral> Correct
20160805 18:13:11< celticminstrel> Well, I have /usr/include though.
20160805 18:13:26< celticminstrel> Weird.
20160805 18:13:34< ancestral> There is a /usr/local/include
20160805 18:13:39< celticminstrel> But, why is scons looking for /usr/include anyway?
20160805 18:14:11< ancestral> I don’t know, did someone edit the script recently?
20160805 18:14:31< ancestral> Maybe Line 781
20160805 18:15:04< zookeeper> celticminstrel, i figured i wouldn't need to ask after what fabi said, but what's this foreach thing? just converting code to work exactly like with the macro, but without it?
20160805 18:15:54< ancestral> (No, probably not that simple. I think it’s in the scons directory.)
20160805 18:16:28< celticminstrel> Yeah.
20160805 18:16:47< ancestral> Yeah, boost.py
20160805 18:16:51< ancestral> Line 73
20160805 18:17:59< ancestral> loonycyborg: Your change probably broke it for me
20160805 18:18:03< ancestral> https://github.com/wesnoth/wesnoth/commit/35b9d7d5ed786007a6ce673ca6771ec3156405f2
20160805 18:18:17< ancestral> But I don’t know for sure
20160805 18:19:01< loonycyborg> ancestral: it's definitely this line of code
20160805 18:23:46< ancestral> So maybe throw in a os.path.isdir("/usr/include")?
20160805 18:23:54< ancestral> Maybe something like this
20160805 18:23:56< ancestral> if sys.platform == "win32" or (os.path.isdir("/usr/include") and not os.path.samefile(boostdir, "/usr/include")):
20160805 18:24:19< loonycyborg> I'll drop samefile altogether and will compare using os.path.normpath instead
20160805 18:24:37< loonycyborg> usng samefile was too smartass move on my parth
20160805 18:24:39< loonycyborg> *part
20160805 18:24:58< ancestral> Cool
20160805 18:25:19< ancestral> For now I’ve just copied the translations from your package
20160805 18:27:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160805 18:28:48< celticminstrel> Yay, rain suddenly.
20160805 18:29:28< fabi_> celticminstrel: Is there some kind of water shortage?
20160805 18:30:26< celticminstrel> Dunno. I was told a few days ago that we have a drought or something, so maybe?
20160805 18:30:39< ancestral> If you live in California, the answer is yes
20160805 18:30:42< celticminstrel> But more importantly, it's been pretty hot.
20160805 18:30:50< celticminstrel> My CA is not california, sorry.
20160805 18:31:20< fabi_> Okay
20160805 18:32:04< fabi_> so I don't touch the FOREACH in scenario-test.cfg and not in the unit tests to make sure it works for UMC
20160805 18:34:44< fabi_> celticminstrel: ^
20160805 18:35:53< celticminstrel> Sure?
20160805 18:36:09< fabi_> No
20160805 18:36:14< celticminstrel> I think I have unit tests specifically for [for] at least
20160805 18:36:15< fabi_> That is why I ask.
20160805 18:36:33< celticminstrel> So it seems fine to leave any that use {FOREACH} for now.
20160805 18:36:54< fabi_> yes
20160805 18:36:54< celticminstrel> Not sure about scenario-test. Most people wouldn't ever see that anyway, though.
20160805 18:37:01< fabi_> Well
20160805 18:37:27< fabi_> The purpose to keep it in scenario-test is to make sure the macro still works.
20160805 18:37:43< celticminstrel> Sure.
20160805 18:38:01< fabi_> Okay
20160805 18:38:20< fabi_> I mean, it can be replaced later when the Macro is removed completely if that ever happens.
20160805 18:39:27< fabi_> vultraz: Do you like to deprecate the {FOREACH ?
20160805 18:41:10-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160805 18:44:48< fabi_> celticminstrel: I am also going to change item_var to variable.
20160805 18:45:37< fabi_> Again to make sure the syntax of foreach and for is similar.
20160805 18:47:46< fabi_> So both tags have array and variable attributes. Both with roughly the same function.
20160805 18:48:33-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160805 18:52:21-!- irker708 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160805 18:52:21< irker708> wesnoth: loonycyborg wesnoth:master 4b536bb0bcc1 / scons/boost.py: scons: compare paths in a different way to avoid error about /usr/include on mac https://github.com/wesnoth/wesnoth/commit/4b536bb0bcc1924fa3a7865efd2ecec1b4a913e3
20160805 18:52:35< loonycyborg> ancestral: should be fixed now
20160805 18:52:39-!- mjs-de [~mjs-de@x4db5df20.dyn.telefonica.de] has joined #wesnoth-dev
20160805 18:53:08< fabi_> celticminstrel: The numerical for loop, have you ever thought about it starting with 1? To match how lua loops work?
20160805 18:53:32< celticminstrel> That would be a mistake, because WML variables start at 0.
20160805 18:54:01< fabi_> I see.
20160805 18:54:01< celticminstrel> So no, I haven't ever thought about it.
20160805 19:13:39< Kwandulin> Huh, a drake stops flying when moving onto a lava+lightray tile
20160805 19:14:10< celticminstrel> Oh my, poor drake. :P
20160805 19:15:42< fabi_> Kwandulin: It enjoys a lave bath, don't worry.
20160805 19:25:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160805 19:27:52< ancestral> Kwandulin: Sounds like a bug
20160805 19:30:49< irker708> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 2a18e68c9a61 / / (9 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/2a18e68c9a611e1f8bfe70fd1d9d5c9e08174664
20160805 19:30:50< celticminstrel> ^ Should be finished now, but is still untested.
20160805 19:30:51-!- fabi_ [~fabi@176.7.56.172] has quit [Read error: Connection reset by peer]
20160805 19:31:13-!- fabi_ [~fabi@176.4.88.77] has joined #wesnoth-dev
20160805 19:31:45< celticminstrel> I guess I'll try modify_ai next.
20160805 19:33:03< celticminstrel> BTW, does anyone use wesnoth.modify_ai()? I'm told by mattsc that wesnoth.modify_ai_wml() or wesnoth.wml_actions.modify_ai() is recommended instead.
20160805 19:33:16< celticminstrel> Well... in any case, I'm deprecating both of those.
20160805 19:35:15< mattsc> I said that?
20160805 19:35:46< mattsc> I knew that I was getting old …
20160805 19:36:47-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160805 19:37:46< celticminstrel> I think you said something like that? Not sure if you said it to me or if it was a comment in LuaAI code somewhere.
20160805 19:39:04< ancestral> vultraz: I’m getting errors uploading to Sourceforge
20160805 19:39:14< ancestral> Just tried sftp and failed :(
20160805 19:39:50< ancestral> Well
20160805 19:39:55< ancestral> Maybe it was successful
20160805 19:40:18< celticminstrel> Oh right, I was supposed to test it wasn't I.
20160805 19:40:46< celmin> Doing that now...
20160805 19:41:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160805 19:42:02< ancestral> sha1 checks out
20160805 19:42:25< ancestral> I have a dmg up on sf.net with all translations
20160805 19:42:45< ancestral> But yeah, whichever version if it loads for you it's probably good
20160805 19:42:57< celmin> Argh, it doesn't work. :(
20160805 19:43:08< celmin> Missing pcre error.
20160805 19:43:19< ancestral> Okay
20160805 19:43:28< ancestral> If you throw that lib in, does it work?
20160805 19:43:30< celmin> Did it run on your machine, then?
20160805 19:43:32< celmin> Checking.
20160805 19:43:36< ancestral> It did
20160805 19:44:45< celmin> Copying off the dmg says it'll take 2 minutes.
20160805 19:47:57< celmin> Yes, it works with libpcre added.
20160805 19:51:10< celticminstrel> Sorry about not noticing this until after you'd uploaded, ancestral.
20160805 19:52:14< ancestral> That's okay
20160805 19:52:21< ancestral> Alright, I'll add the libpcre
20160805 19:52:36< ancestral> Also, you're running that as a 64-bit app, right?
20160805 19:52:38< ancestral> I assume
20160805 19:52:58< celmin> No idea.
20160805 19:53:03< celmin> How do I check?
20160805 19:53:46< ancestral> While it's open, you can bring up Activity Monitor
20160805 19:54:01< ancestral> I think it should tell you if it's 32 or 64
20160805 19:54:35< ancestral> My understanding is it's 64-bit. I can strip the 32-bit stuff from the libs and frameworks and save ~10 MB (not much, but something)
20160805 19:54:40< celmin> Oh, I guess I can't check unless I redownload. Bleh.
20160805 19:54:44< ancestral> Eh
20160805 19:54:49< ancestral> Don't worry about it
20160805 19:54:57< celmin> Well anyway, my computer is 64-bit capable, so it likely was.
20160805 19:55:33< ancestral> I'll leave it as-is, don't want to break anything.
20160805 19:56:11< ancestral> Also, going to figure out a better way to add in the changelog
20160805 19:56:17< ancestral> Currently, it's like pulling teeth out
20160805 19:56:36-!- Kwandulin [~Miranda@p200300760F6062B5F0ED2FB449779272.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160805 20:01:20-!- gfgtdf [~chatzilla@x4e363ba4.dyn.telefonica.de] has joined #wesnoth-dev
20160805 20:05:05-!- travis-ci [~travis-ci@ec2-54-163-165-190.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 20:05:06< travis-ci> wesnoth/wesnoth#10151 (wml_tag_porting - 2a18e68 : Celtic Minstrel): The build is still failing.
20160805 20:05:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150139892
20160805 20:05:06-!- travis-ci [~travis-ci@ec2-54-163-165-190.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 20:11:00-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160805 20:13:00-!- mjs-de [~mjs-de@x4db5df20.dyn.telefonica.de] has quit [Remote host closed the connection]
20160805 20:25:59-!- gfgtdf [~chatzilla@x4e363ba4.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160805 20:29:07< ancestral> Reuploading
20160805 20:33:01< irker708> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 7501d4a834bd / / (9 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/7501d4a834bd96d8a0718b1b2ada2b2656e24141
20160805 20:33:03< celmin> ^ Should fix the unit tests. Other than that, still untested.
20160805 20:44:25< ancestral> vultraz: done
20160805 20:44:38< celmin> Should I edit the post, or wait for him to do it?
20160805 20:45:43< ancestral> Can you edit it?
20160805 20:45:51< ancestral> Isn’t it this thing: https://wiki.wesnoth.org/Template:DevDownload
20160805 20:46:20< ancestral> Need to get rid of the red sentence
20160805 20:46:28< celmin> Oh that. I was thinking of the forum post, but I guess that needs to be updated too.
20160805 20:46:38< ancestral> Also need to change macOS (10.10) to Apple macOS (10.7 and later)
20160805 20:47:09< fabi_> celmin: You haven't answered yet regarding my second suggested syntax change.
20160805 20:47:15< ancestral> Hmm: https://forums.wesnoth.org/viewtopic.php?p=599793#p599793
20160805 20:48:33< celmin> fabi_: I thought I did? I didn't really see a problem with it in any case.
20160805 20:48:41< celmin> ancestral: Why hmm?
20160805 20:48:49< ancestral> Guy had a crash on startup is all
20160805 20:48:50< celmin> ancestral: Also, what's the URL and SHA?
20160805 20:49:04< ancestral> Working on it
20160805 20:49:10-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160805 20:49:26< ancestral> https://sourceforge.net/projects/wesnoth/files/wesnoth/wesnoth-1.13.5/Wesnoth_1.13.5.dmg/download
20160805 20:49:31< ancestral> Hi vultraz!
20160805 20:49:49< celmin> Oh, should I leave it to vultraz after all then? I was just about to edit the forum post.
20160805 20:49:54< ancestral> dbea9776d9a01694a0ade31ff7b7e9013c0eccc0
20160805 20:50:22< ancestral> Lemme connect to the wesnoth server
20160805 20:50:27< vultraz> ah hello
20160805 20:50:38< vultraz> am I right on time?
20160805 20:50:43< ancestral> Exactly
20160805 20:50:46< vultraz> is that the sha?
20160805 20:50:47< vultraz> or a commit
20160805 20:50:51< ancestral> sha
20160805 20:50:53< celmin> That's the SHA for the download.
20160805 20:51:07< celmin> vultraz: Shall I let you update the post and the wiki? Or I could do one and you do the other.
20160805 20:51:25< vultraz> celmin: you do the wiki, I'll do the post
20160805 20:51:42< celmin> Oh wait, the page is protected, so I can't.
20160805 20:51:50< celmin> On the wiki, I mean.
20160805 20:52:25-!- RatArmy [~RatArmy@om126212092091.11.openmobile.ne.jp] has joined #wesnoth-dev
20160805 20:52:40< vultraz> ah
20160805 20:52:42< vultraz> ok, I'll do both
20160805 20:53:07< vultraz> ancestral: what is the size of the file?
20160805 20:53:18< vultraz> ancestral: and is it 10.10+ or 10.7+
20160805 20:53:19< ancestral> 402.3 MB
20160805 20:53:22< ancestral> 10.7+
20160805 20:53:25< vultraz> k
20160805 20:53:36< ancestral> ancestral: Also need to change macOS (10.10) to Apple macOS (10.7 and later)
20160805 20:55:24< vultraz> needs 'Apple'?
20160805 20:55:44 * celmin wonders why ancestral included his name in that.
20160805 20:55:50< ancestral> I did?
20160805 20:55:52< ancestral> Grrr
20160805 20:55:57< ancestral> Hang on
20160805 20:55:58< celmin> ...?
20160805 20:56:08< celmin> I mean in the message here on IRC.
20160805 20:56:27< ancestral> What are you talking about?
20160805 20:56:33< ancestral> I meant to copy the timestamp
20160805 20:56:41< celmin> [Aug 05@4:53:36pm] ancestral: ancestral: Also need to change macOS (10.10) to Apple macOS (10.7 and later)
20160805 20:56:46< vultraz> [07:53:34]	ancestral	ancestral: Also need to change macOS (10.10) to Apple macOS (10.7 and later)
20160805 20:56:53< ancestral> vultraz: shadowm mentioned this before. If you want to say Microsoft Windows, you should say Apple macOS
20160805 20:57:01< ancestral> Or just say Windows and macOS
20160805 20:57:05< celmin> Yeah, that makes sense.
20160805 20:57:16< ancestral> I don’t care what convention you use
20160805 20:57:21< vultraz> I like Windows and macOS better
20160805 20:57:32< ancestral> You’re the boss! (so to speak)
20160805 21:00:12< Aginor> morning guys
20160805 21:00:18< celmin> Hi
20160805 21:00:33< Aginor> silly question, the bit where there's text and a portrait, is that a [message /]?
20160805 21:00:51< vultraz> yes
20160805 21:00:55< celmin> In the report in the release thread? Yes.
20160805 21:01:41< vultraz> ancestral: are you sure that's the full sha256
20160805 21:02:13< celmin> Is it too short?
20160805 21:02:17< vultraz> yes
20160805 21:02:22< vultraz> I suspect it might be sha1
20160805 21:02:38< ancestral> Oops alright
20160805 21:04:49< ancestral> cc0bb33c480a0ae01ce49aa52efc310347a483d7191ed17f2b789a885612c96e
20160805 21:05:28< ancestral> Fixed
20160805 21:05:37< ancestral> on sf.net
20160805 21:05:53< vultraz> ok, done
20160805 21:06:22< ancestral> Thanks
20160805 21:12:07< ancestral> Trying to connect to wesnoth.org to upload the sha, just forgetting how to change my key identities
20160805 21:15:52< ancestral> There we go
20160805 21:18:00< irker708> wesnoth: Charles Dang wesnoth:master d545cd34b566 / src/gui/dialogs/game_load.cpp: tgame_load: only enable Change Difficulty toggle if selection is a start-of-scen https://github.com/wesnoth/wesnoth/commit/d545cd34b5668fb59fb39fcc5597a837fef67f48
20160805 21:23:01< vultraz> celmin: might wanna look into this https://gna.org/bugs/?24924
20160805 21:23:12< vultraz> since you handled the leadership refactor
20160805 21:23:33< celmin> Sounds like you're showing abilities that should be hidden.
20160805 21:23:46< ancestral> Okay
20160805 21:24:24< ancestral> Alright I'll get the md5 too
20160805 21:24:42< vultraz> celmin: I iterate over get_ability_list()
20160805 21:28:24< celmin> Where is this?
20160805 21:29:08< ancestral> vultraz: Thanks for you help.
20160805 21:29:16< ancestral> I think the only thing to do is update the front page
20160805 21:30:06< vultraz> celmin: unit
20160805 21:30:14< vultraz> ah, yes
20160805 21:30:39< celmin> Huh? Where?
20160805 21:30:50< celmin> Oh, I mean where you iterate over it.
20160805 21:30:56< celmin> Not where it's defined.
20160805 21:31:05< vultraz> gui/widgets/unit_preview_pane.cpp:322
20160805 21:31:25< celmin> Ah, unit preview pane. No wonder I couldn't find it in unit recall.
20160805 21:31:52< celmin> Hmm...
20160805 21:31:56< vultraz> shadowm: can you remove the notice of the macOS package's unavailability from the front page?
20160805 21:32:14< vultraz> shadowm: and can you update the text in the top box to say 'macOS' instead of OS X?
20160805 21:32:38< celmin> I think get_ability_list() is not good for display purposes.
20160805 21:34:47< celmin> It returns non-translatable strings.
20160805 21:35:33< vultraz> what should i use?
20160805 21:35:45< celmin> Not sure. How is it done in other places?
20160805 21:35:48< celmin> Like the sidebar for instance.
20160805 21:36:03< celmin> Ultimately you want the name key from each ability, not the id.
20160805 21:36:22< vultraz> looks like an iterator over abilities()
20160805 21:37:38< vultraz> wait
20160805 21:37:41< vultraz> where is that?
20160805 21:37:46< celmin> Where is what?
20160805 21:38:30< vultraz> oh
20160805 21:38:46< vultraz> that was an implementation detail of the gui1 UPP
20160805 21:38:49< vultraz> 	const std::vector<std::tuple<t_string,t_string,t_string> > &abilities = u.ability_tooltips();
20160805 21:38:51< vultraz> 	for(auto a : abilities) {
20160805 21:38:52< vultraz> 		det.abilities.push_back(std::get<1>(a));
20160805 21:38:54< vultraz> 	}
20160805 21:38:55< vultraz> whaaa??
20160805 21:39:30< celmin> Ah.
20160805 21:39:42-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160805 21:39:46< celmin> That seems like it would be about right.
20160805 21:39:46< vultraz> do I have to use this method?
20160805 21:40:38< celmin> I'd move the ability_tooltips() call into the for header.
20160805 21:40:46< celmin> Then you don't need the complicated type declaration.
20160805 21:40:58< celmin> (That's probably like that due to pre-auto stuff.)
20160805 21:42:48< vultraz> seems to work
20160805 21:43:04< vultraz> i need a unit with leadership to test
20160805 21:51:44-!- travis-ci [~travis-ci@ec2-54-163-165-190.compute-1.amazonaws.com] has joined #wesnoth-dev
20160805 21:51:45< travis-ci> wesnoth/wesnoth#10153 (master - d545cd3 : Charles Dang): The build passed.
20160805 21:51:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150161658
20160805 21:51:45-!- travis-ci [~travis-ci@ec2-54-163-165-190.compute-1.amazonaws.com] has left #wesnoth-dev []
20160805 21:51:52< shadowm> Has an OS X version branded macOS been released yet?
20160805 21:52:37< celmin> According to Wikipedia, it's the upcoming release.
20160805 21:52:45< shadowm> Then the answer is no.
20160805 21:53:40-!- RatArmy [~RatArmy@om126212092091.11.openmobile.ne.jp] has quit [Ping timeout: 250 seconds]
20160805 21:53:53< ancestral> shadowm: Do you feel like changing this in ~2 months?
20160805 21:54:37< shadowm> Yes. I also feel like in 2 months we'll have another development release.
20160805 21:54:47< celmin> Very possibly.
20160805 21:55:26< fabi_> Please make sure it is one with wml* tools run before.
20160805 21:55:29< shadowm> Why was I told to update the front page to remove the allusion to the OS X package's nonexistence yet the channel topic still implies that it's still something that is true?
20160805 21:55:50< celmin> Because vultraz forgot to update the channel topic.
20160805 21:56:16-!- shadowm changed the topic of #wesnoth-dev to: Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160805 21:56:19 * celmin has no idea what fabi_ is talking about.
20160805 21:56:27< shadowm> Okay, just making sure because I didn't look at the downloads page.
20160805 21:56:42< celmin> He updated the downloads page and the forum thread.
20160805 21:57:35< fabi_> celmin: vultraz told me yesterday that he thinks someone fixed some wmllint errors not that long ago. It sounds it is no more part of the release process to make sure the wml is wmllint and wmlscope clean.
20160805 21:57:54< fabi_> I suggested to fix that travis thing and let it run wmllint and scope as well.
20160805 21:58:20< celmin> I don't think it's really necessary for it to be part of the release process for dev releases.
20160805 21:58:23< fabi_> You should not let the project's infrastructure die away.
20160805 21:58:36< celmin> It should definitely be done before releasing 1.14
20160805 21:58:47< shadowm> Before releasing any beta or RC.
20160805 21:59:34< celmin> Sure, I was thinking of saying before release candidates.
20160805 21:59:43-!- gfgtdf [~chatzilla@x4e363ba4.dyn.telefonica.de] has joined #wesnoth-dev
20160805 22:00:00< celmin> Of course, wmllint itself also needs to be up-to-date for that to work.
20160805 22:00:08 * celmin isn't sure whether or not it's currently up-to-date.
20160805 22:00:11< gfgtdf> 20160805 00:57:06< celmin> Oh heh, that was gfgtdf.
20160805 22:00:22< gfgtdf> celmin: what wewre you talking about there ?
20160805 22:00:30< gfgtdf> vultraz: did you see my message easrlier ?
20160805 22:00:38< celmin> gfgtdf: Pretty sure I mentioned it a line or two before.
20160805 22:00:50< celmin> It was an issue report I found on GNA about recruit lists.
20160805 22:01:07< celmin> Well, feature request.
20160805 22:01:41< gfgtdf> celmin: hmm ok i rmember that one
20160805 22:04:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20160805 22:04:08< gfgtdf> celmin: the point is just that sometimes you want to adjust the recuit cost because the unit a is more effective on one map than on another, or for other balance issues.
20160805 22:05:20< gfgtdf> celmin: or for examepl you might want that one mp faction can recruit a unit for less gold than another.
20160805 22:08:14< gfgtdf> celmin: the way Utbs does it (createing one unit types for each costs) is just hacky (you eigher have diffent types types of each unit on the map, or have to use soem recruit events to change type) inflexible (you have the know the costs at wml prasing time) and resource heavy (you are creating a bunch of dummy unit types).
20160805 22:10:41-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160805 22:10:41-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160805 22:10:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160805 22:10:58< gfgtdf> vultraz: did you see my comment above ?
20160805 22:11:32< vultraz> [09:10:42]	gfgtdf	celmin: the way Utbs does it (createing one unit types for each costs) is just hacky (you eigher have diffent types types of each unit on the map, or have to use soem recruit events to change type) inflexible (you have the know the costs at wml prasing time) and resource heavy (you are creating a bunch of dummy unit types).
20160805 22:11:33< vultraz> this?
20160805 22:11:40< irker708> wesnoth: Charles Dang wesnoth:master feb64ddbfe05 / src/gui/widgets/unit_preview_pane.cpp: tunit_preview_pane: use correct method for displaying unit abilities https://github.com/wesnoth/wesnoth/commit/feb64ddbfe059ea9f8f1517965d8a0913849a80f
20160805 22:12:00< gfgtdf> vultraz: no
20160805 22:12:02< gfgtdf> 20160805 11:46:18< gfgtdf> vultraz: 6130c668c4b5754c651a08a0f080dca133799266 removed a fomatter in src/mt_rng.cpp
20160805 22:12:05< gfgtdf> vultraz: and following
20160805 22:12:16< vultraz> oh
20160805 22:13:14< mattsc> Talking about wmllint, it does not take #ifver directives into account, does it?
20160805 22:13:20< vultraz> you want me to re-add the header where it uses std::hex?
20160805 22:14:25< vultraz> er
20160805 22:14:27< vultraz> formatter
20160805 22:14:33< celmin> I see, so there's already a use-case for it, huh...
20160805 22:15:12< gfgtdf> vultraz: yes, the point is that otherwise the std::hex will also casue all following number outut to our logger to be in hexadecimal format.
20160805 22:15:29< celmin> mattsc: Good question.
20160805 22:15:44< gfgtdf> vultraz: as soon that std::hex is out in the logger.
20160805 22:15:56< celmin> Hang on.
20160805 22:15:58< gfgtdf> put*
20160805 22:16:01< celmin> That's not the proper solution.
20160805 22:16:14< celmin> The proper solution is to output std::dec once you've finished with hex numbers.
20160805 22:16:40< celmin> Don't create a separate formatter just because you want to set numerical format flags.
20160805 22:17:05< mattsc> celmin: well, I tried and wmllint from 1.13 complains about the lines from 1.12 behind ‘#ifver WESNOTH_VERSION >= 1.13.0
20160805 22:17:06< mattsc> ‘
20160805 22:17:18< mattsc> well, those bhind the #else, of course
20160805 22:17:30-!- Appleman1234 [~Appleman1@KD036012025251.au-net.ne.jp] has joined #wesnoth-dev
20160805 22:17:40< gfgtdf> celmin: well i don't rally care how in detail this is fixed, both seems like fine solution to me.
20160805 22:18:29< celmin> I guess that means Elvish_Hunter has something to do.
20160805 22:18:38-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160805 22:19:33< vultraz> tfw we throw an exception to load a game within a game
20160805 22:19:35< vultraz> whyyy
20160805 22:19:44< celmin> Huh?
20160805 22:19:50< mattsc> I guess my question was whether it is supposed to work …
20160805 22:20:05< celmin> In my personal opinion? Yes.
20160805 22:20:11< gfgtdf> vultraz: well we also throw an exeception to exit the gaejm normally
20160805 22:20:17< vultraz> :|
20160805 22:20:19< vultraz> whyyyy
20160805 22:20:26< mattsc> celmin: yes, it would be nice; agreed
20160805 22:20:29< gfgtdf> vultraz: loading a gme is basically exiting the current game+starting a new game
20160805 22:20:30-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160805 22:20:32< celmin> …you're not telling me you didn't know that, surely?
20160805 22:20:46< vultraz> I knew on exit
20160805 22:20:47< gfgtdf> loaiding a game during a game i meant*
20160805 22:20:49< vultraz> not on-load
20160805 22:21:15< gfgtdf> vultraz: ?
20160805 22:21:36< vultraz> I didn't know it threw an exception when loading from inside a game
20160805 22:21:54< celmin> Hmm.
20160805 22:22:05< vultraz> it's ridiculous that we need exceptions to end games.
20160805 22:22:36< vultraz> should be refactored
20160805 22:22:55< celmin> mattsc: Do you know if wesnoth.modify_ai is used anywhere? (The [modify_ai] tag uses modify_ai_wml._
20160805 22:23:00< celmin> ^)
20160805 22:23:57< mattsc> celmin: I am not aware of it being used anywhere,
20160805 22:24:29 * celmin is debating between two possibilities: 1. change wesnoth.modify_ai to be modify_ai(side, path, cfg_if_add_or_change) 2. add wesnoth.add_ai_component, wesnoth.delete_ai_component, wesnoth.change_ai_component, taking the same arguments (without cfg in the case of delete_ai_component).
20160805 22:25:01< celmin> (Also, the cfg would be the content of a [facet] etc tag, rather than a config containing said tag.)
20160805 22:27:42< mattsc> The first option it make the syntax consistent with the tag, I presume?
20160805 22:27:50< mattsc> Trying to look up the current syntax …
20160805 22:28:47< celmin> It takes a config the same as [modify_ai], but only supports side= instead of a side filter, as far as I can see.
20160805 22:29:15< celmin> I prefer the Lua API functions to not just take a config identical to the WML, though.
20160805 22:29:40< mattsc> ok
20160805 22:29:43< celmin> If a WML tag's implementation consists of simply forwarding its config to a WML function, I think that's a bad thing.
20160805 22:29:56< gfgtdf> celmin: git search gives me ths line https://github.com/wesnoth/wesnoth/blob/1.13.4/data/ai/scenarios/scenario-lua-ai.cfg#L297
20160805 22:30:03< celmin> If necessary, I can always provide backwards compatibility for modify_ai even if I change its interface.
20160805 22:30:10< celmin> (Since the number of arguments changes.)
20160805 22:30:40< celmin> gfgtdf: But it's commented out, so doesn't really count?
20160805 22:31:07< celmin> I'll edit that file to remove/fix it though anyway.
20160805 22:31:16< gfgtdf> celmin: don't know what the intention was of having an outcommented line there :s
20160805 22:31:22-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160805 22:31:25< gfgtdf> celmin: itz is already removed in curent master afaik
20160805 22:31:31< celmin> Then I won't bother.
20160805 22:31:48< gfgtdf> celmin: (that link was 1.13.4)
20160805 22:31:58< celmin> I saw that.
20160805 22:32:50< celmin> …I wonder if wesnoth.place_shroud and wesnoth.clear_shroud are used anywhere...
20160805 22:32:51< irker708> wesnoth: Charles Dang wesnoth:master 7fae63e47132 / src/savegame.cpp: Fix difficulty dialog not showing when loading from within a game (bug #24925) https://github.com/wesnoth/wesnoth/commit/7fae63e47132387809864738c80ce6531c5c5d39
20160805 22:33:07< celmin> …well, I provided backwards compat for those though, so whatever.
20160805 22:35:58< gfgtdf> celmin: remove/place_shroud are added in 1.13 and are nto metioned in the wiki afaik, so no need to worry about backwards compabiltiy here
20160805 22:36:04< gfgtdf> not*
20160805 22:36:19< celmin> Really? Okay then. I'll double-check, but if you're right then I won't worry about it.
20160805 22:38:56< celmin> Well, they're not on LuaWML main page, anyway.
20160805 22:39:58< celmin> mattsc: So do you think it's better to have a single wesnoth.modify_ai function, or one for each action (delete, add, change)?
20160805 22:40:45< mattsc> celmin: good question; I can’t really come up with a good argument for one or the other
20160805 22:41:15< mattsc> in other words, whichever you prefer is fine by me
20160805 22:41:20-!- gfgtdf [~chatzilla@x4e363ba4.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160805 22:41:47< irker708> wesnoth: Charles Dang wesnoth:master 62f3502cf379 / src/ (mt_rng.cpp scripting/game_lua_kernel.cpp): Add std::dec after std::hex when necessary https://github.com/wesnoth/wesnoth/commit/62f3502cf3799c7234d85cdef7f218b56850966d
20160805 22:41:50< irker708> wesnoth: Charles Dang wesnoth:master e34775c6654e / src/addon/manager_ui.cpp: Change a reference to a copy on the advice of @cbeck88 https://github.com/wesnoth/wesnoth/commit/e34775c6654eb9ab91868370f5b53bae1bcb8852
20160805 22:47:19-!- JyrkiVesterinen [~JyrkiVest@87-92-45-153.bb.dnainternet.fi] has quit [Quit: .]
20160805 22:50:52-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160805 22:55:07< vultraz> huh
20160805 22:55:45< vultraz> i just noticed a side with allow_player=no still appearing in mp creat
20160805 22:55:46< vultraz> e
20160805 22:56:02< shadowm> Are you in debug mode perhaps?
20160805 22:56:08< vultraz> ah, yes
20160805 22:56:09< vultraz> I am
20160805 23:07:33< celmin> …outputting this? Why?
20160805 23:07:50< celmin> That'll call the void* overload of operator<<
20160805 23:08:10 * celmin referring to 62f350
20160805 23:08:10< vultraz> don't ask me
20160805 23:08:42< vultraz> it was like that
20160805 23:09:07< celmin> fabi_, vultraz: Any opinion on what I asked of mattsc above?
20160805 23:09:22< vultraz> i wasn't paying attention
20160805 23:09:32< celmin> …then… scroll up and look?
20160805 23:10:48< vultraz> I have no opinion, really
20160805 23:11:02< celmin> 'kay
20160805 23:12:04< vultraz> do whichever is simplest and makes the most sense
20160805 23:12:09< fabi_> hihi
20160805 23:13:54< vultraz> celmin: can you look into this guy's issue: https://forums.wesnoth.org/viewtopic.php?p=599791#p599791
20160805 23:14:01< vultraz> about [message] image size
20160805 23:14:07< vultraz> before it was scaled down by screen size
20160805 23:14:17< vultraz> I suspect you didn't port that when converting it to Lua
20160805 23:14:22< celmin> Huh?
20160805 23:14:31< celmin> It's possible, I suppose?
20160805 23:15:05< celmin> Was that not part of the dialog implementation?
20160805 23:15:31< celmin> If it was, it shouldn't be my fault, probably… >_>
20160805 23:15:35< vultraz> hm
20160805 23:15:38< vultraz> good point
20160805 23:16:30< fabi_> vultraz, celmin: Do you agree that [command] and [do] serve the same purpose? Maybe they can be merged into [dommand] :-)
20160805 23:16:36< celmin> No.
20160805 23:16:41 * vultraz facepalms
20160805 23:16:44< celmin> ^
20160805 23:17:01< fabi_> rofl
20160805 23:18:17-!- RatArmy [~RatArmy@om126212092091.11.openmobile.ne.jp] has joined #wesnoth-dev
20160805 23:18:22< fabi_> Well, then I suggest to keep only [do] since [command] is already used in replay WML.
20160805 23:18:39< vultraz> next you'll advocate abbreviating all WML tags. [modify_unit] -> [mounit]
20160805 23:19:17< fabi_> Oh yes.
20160805 23:19:18< celmin> It'd be trivial to support [do] instead of [command] as ActionWML.
20160805 23:19:33< fabi_> I think so.
20160805 23:19:35< celmin> Might be slightly harder to ensure it works in [set_menu_item], but only slightly.
20160805 23:19:45< vultraz> [do] does make more sense than [command], I will admit.
20160805 23:19:56< celmin> For ActionWML, all you need to do is add one line to wml-flow.lua
20160805 23:20:05< celmin> wml_actions["do"] = wml_actions.command
20160805 23:20:54< celmin> …well, in actual practice you'd do it slightly differently.
20160805 23:20:55< vultraz> could be worth it
20160805 23:21:10< celmin> do would be a copy of command, but command would add a deprecation message.
20160805 23:21:51< irker708> wesnoth: Charles Dang wesnoth:master 96453a3e9c99 / data/gui/window/unit_recruit.cfg: Unit Recruit: layout tweaks to display more recruits before needing to scroll https://github.com/wesnoth/wesnoth/commit/96453a3e9c99740234366221e2d081b17cbc66f2
20160805 23:22:07< celmin> With uh… probably wesnoth.log("wml", "some string")
20160805 23:22:24< vultraz> I wish I could make dialogs fixed size
20160805 23:22:29< vultraz> but still have automatic placement
20160805 23:22:34< vultraz> or at least fix the manual palcement
20160805 23:22:38< celmin> Or maybe using wml_action.deprecated_message or whatever it's called.
20160805 23:22:53< celmin> I bet you can make dialogs fixed size.
20160805 23:23:00< vultraz> I know where the code to make this happen is, but I can't figure out how to change it properly..
20160805 23:23:04< celmin> Or is the problem that you can't have both fixed size and auto placement?
20160805 23:23:09< vultraz> ^
20160805 23:23:15< celmin> Hmm. I dunno.
20160805 23:23:23< vultraz> for some goddamn reason mordante thought that was the right way to do things
20160805 23:24:36< vultraz> celmin: gui/widgets/window.cpp:1123 to 1190
20160805 23:24:50< vultraz> if you can figure that out, kudos on you.
20160805 23:24:52-!- fabi [~fabi@176.4.92.152] has joined #wesnoth-dev
20160805 23:24:59< vultraz> at first glance it looks simple, right?
20160805 23:25:08< vultraz> well, change it and you get assertions
20160805 23:25:18< vultraz> weirder:
20160805 23:25:36< celmin> Well, if you can find a replacement for GUI2 that has all the widgets we need and doesn't have a file format of its own...
20160805 23:25:56< fabi> celmin: I have an opinion about what you asked mattsc. But only a more general not one specific to modify_ai.
20160805 23:26:05< celmin> fabi: Uh. Okay?
20160805 23:26:15< vultraz> you can center a dialog horizontally with x = "(screen_width - window_width) / 2" but you cannot get it centered vertically with y ="(screen_height - window_height) / 2"
20160805 23:26:21< vultraz> GO FIGURE
20160805 23:26:23< celmin> fabi: So, what is it?
20160805 23:27:37< fabi> Nowadays I think when it comes to actionWML (or WML tags in genaral) as Lua tables. The wesnoth lua api is used to implement the functions that are handling those tables.
20160805 23:27:50< fabi> So WML are functions which take only one table.
20160805 23:28:15< fabi> While the wesnoth lua api should provide an interface that uses multiple arguments.
20160805 23:28:23-!- fabi_ [~fabi@176.4.88.77] has quit [Ping timeout: 244 seconds]
20160805 23:28:28< celmin> I feel the same way, which is why I'm doing this.
20160805 23:28:49-!- jamit [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has joined #wesnoth-dev
20160805 23:29:02< celmin> But that argument does not distinguish the two ways I mentioned. (Actually, I misspoke when I mentioned them - way #1 would require a fourth "action" argument.)
20160805 23:29:19< celmin> However, if you don't have a strong opinion on that, I guess I'll go with #2.
20160805 23:29:58-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Quit: ChipmunkV]
20160805 23:30:55< jamit> Hello Wesnoth!
20160805 23:31:03< celmin> Hi
20160805 23:31:51 * celmin just now noticed fabi's PM. Sorry!
20160805 23:33:32< fabi> celmin: No problem. 
20160805 23:34:57< fabi> vultraz: I just noticed that this terrible ai side persistent macro vanished? If it was that you talked about to mattsc yesterday, I am glad it is gone.
20160805 23:35:41< vultraz> ai side persistent macro?
20160805 23:35:56< celmin> [Aug 05@7:24:36pm] vultraz: celmin: gui/widgets/window.cpp:1123 to 1190
20160805 23:36:01< celmin> Where do you get asserts?
20160805 23:36:23< vultraz> uhh...
20160805 23:36:26< irker708> wesnoth: Charles Dang wesnoth:master 806c5b1b8bb9 / data/gui/widget/unit_preview_pane.cfg: Unit Preview Pane: force minimum size for details area https://github.com/wesnoth/wesnoth/commit/806c5b1b8bb95d5d9cd9ac62b1818995a43b11eb
20160805 23:36:35< celmin> The assert(false) or the size assert? Or something elsewhere?
20160805 23:36:40< vultraz> something about size.x
20160805 23:36:44< vultraz> somewhere else
20160805 23:36:48< vultraz> can't remember exactly where
20160805 23:36:50< celmin> So not the one on line 1126?
20160805 23:36:55< vultraz> none there
20160805 23:37:01< celmin> There's an assert there.
20160805 23:37:20< vultraz> I mean none of the asserts there assert
20160805 23:37:24< celmin> I see.
20160805 23:38:04< celmin> I keep amending that modify_side commit. >_>
20160805 23:38:15< fabi> MAKE_AI_SIDE_PERSISTENT
20160805 23:39:51< fabi> vultraz: Ah, no. It was just wishful thinking.
20160805 23:39:52 * celmin wonders if anyone noticed that I introduced an emoticon in global.hpp
20160805 23:39:57< celmin> <_<
20160805 23:40:03< vultraz> fabi: where is this macro now?
20160805 23:40:25< celmin> I think MAKE_AI_SIDE_PERSISTENT is something that could be greatly simplified using new features?
20160805 23:40:35< fabi> vultraz: side-utils.cfg
20160805 23:41:01< vultraz> why..does this macro exist
20160805 23:41:08< fabi> vultraz: It is not used in mainline. And ugly as hell. Notice how the parameter is not used but suggests that it works everywhere in the code.
20160805 23:41:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160805 23:41:42< vultraz> not used?
20160805 23:41:59< fabi> let me grep again
20160805 23:42:10< vultraz> it's not even related to AI sides specifically
20160805 23:42:20< vultraz> if anything it should be called MAKE_SIDE_PERSISTENT 
20160805 23:42:31< fabi> Yes
20160805 23:42:39< celmin> mattsc: Do we even need [modify_ai]action=try_delete? It's not like delete throws an error if it didn't exist (just prints a warning).
20160805 23:42:40< vultraz> but since it's one key why is it even a macro
20160805 23:42:50< mattsc> vultraz: I think we should add another macro like that, called MAKE_PLAYER_SIDE_PERSISTENT
20160805 23:43:00< vultraz> mattsc: there's no difference... 
20160805 23:43:02< celmin> vultraz: Maybe it already was simplified, then.
20160805 23:43:12< mattsc> We could also add more for other side characteristics
20160805 23:43:15< celmin> vultraz: I vaguely recall it being some complicated monstrosity.
20160805 23:43:15< fabi> Of course it was.
20160805 23:43:18< vultraz> mattsc: unless you mean that should have a save_id?
20160805 23:43:26< fabi> Why should it otherwise have an unused parameter.
20160805 23:43:26< vultraz> this is its contents:
20160805 23:43:29< vultraz>     [+side]
20160805 23:43:30< vultraz>         persistent=yes
20160805 23:43:32< vultraz>     [/side]
20160805 23:43:41< vultraz> ah, right
20160805 23:43:44< vultraz> unused parameter
20160805 23:43:46< celmin> fabi, vultraz: It should probably be moved to deprecated-utils.cfg
20160805 23:43:48< vultraz> DEPRECATION TRAIN INCOMING
20160805 23:44:12< celmin> I wonder if wmllint uses deprecated-utils.cfg to determine whether a macro is deprecated.
20160805 23:44:17< mattsc> How about MAKE_AI_SIDE_HAVE_NO_LEADER ?
20160805 23:44:28< celmin> mattsc: That exists?
20160805 23:44:31< irker708> wesnoth: JaMiT wesnoth:master 53f6ec19c04c / images/cursors/ (18 files): Remove color information from transparent pixels https://github.com/wesnoth/wesnoth/commit/53f6ec19c04ce2726dc040a76326ea5198f6861a
20160805 23:44:33< irker708> wesnoth: JaMiT wesnoth:master 44e00362e33d / images/cursors/ (18 files): Remove color information from transparent pixels https://github.com/wesnoth/wesnoth/commit/44e00362e33d293b83b06f2ce632ae64da605cda
20160805 23:44:36< celmin> mattsc: Also, did you miss what I just asked?
20160805 23:44:42< mattsc> not yet,I think we should add it.
20160805 23:44:49< celmin> Huh, jamit already has access.
20160805 23:44:55< celmin> mattsc: Why?
20160805 23:45:02< vultraz> yes, jamit was around ages ago
20160805 23:45:02< mattsc> hi jamit, long time no see
20160805 23:45:07< jamit> I was around before. :)
20160805 23:45:09 * celmin vaguely wonders who jamit is now.
20160805 23:45:22< celmin> [Aug 05@7:42:39pm] celmin: mattsc: Do we even need [modify_ai]action=try_delete? It's not like delete throws an error if it didn't exist (just prints a warning).
20160805 23:45:28< vultraz> not sure why he has two commits the same, though
20160805 23:45:34< mattsc> celmin: because I think it would be fun and would annoy vultraz  ;)
20160805 23:45:43< jamit> I got back on the latest version and saw problems with the cursors. Thought I'd revive my account to help with that.
20160805 23:46:01< mattsc> do I need to come up with even more ridiculous examples before it become obvious that I am kidding?  ;)
20160805 23:46:21< celmin> vultraz: Looks like some sort of merge artifact. One of the commits is actually a merge commit.
20160805 23:46:24< mattsc> celmin: I did miss that
20160805 23:46:47< mattsc> I’ve been wondering that myself; maybe there was a reason for it once, but it does not seem to exist any more
20160805 23:47:08< jamit> Sorry, it's been a while since I used git. I'll figure out what I should have done.
20160805 23:47:40< vultraz> jamit: is that bug fixed now?
20160805 23:47:43< vultraz> the one you mentioned
20160805 23:47:56< vultraz> I mean, it's still an upstream issue
20160805 23:48:07< vultraz> but does it affect us anymore?
20160805 23:48:18< jamit> It's fixed for me. Probably for others as well. Since it's related to hardware, it's tough to be sure.
20160805 23:48:29< irker708> wesnoth: Charles Dang wesnoth:master ea1bb2b31c43 / data/core/macros/ (deprecated-utils.cfg side-utils.cfg): Deprecate MAKE_AI_SIDE_PERSISTENT https://github.com/wesnoth/wesnoth/commit/ea1bb2b31c430d02a3a1176bb9754d4a0e5c5bf5
20160805 23:48:33< vultraz> fabi: ^
20160805 23:48:51< fabi> vultraz: Oh yes! :-)
20160805 23:49:01< mattsc> I got a good one for vultraz:  MAKE_AI_SIDE_BE_SIDE_2
20160805 23:49:16< vultraz> *twitch*
20160805 23:50:24< celmin> I was supposed to be looking into the debug_ai problem but instead got distracted with WML tags… >_>
20160805 23:50:31< vultraz> jamit: ok, posted an update on the bug to that effect
20160805 23:50:34< vultraz> thanks :D
20160805 23:50:49< mattsc> vultraz: I’ll leave you alone now, I’ll be afk for quite some while  :)
20160805 23:50:57< celmin> BTW, if my modify_side rewrite works properly, then [modify_side][ai][goal] and [modify_side][ai][stage] will work.
20160805 23:51:08< mattsc> cool!
20160805 23:51:19 * vultraz wishes we could burn AI_CONTROLLER_ALLOW_LEADER_CONTROL with fire
20160805 23:51:19< jamit> vultraz: thanks. I was just seeing if I could still log into Gna.
20160805 23:51:22< celmin> Speaking of the modify_side rewrite, I think I missed something in the changelog when amending...
20160805 23:52:11< celmin> I imagine AI_CONTROLLER_ALLOW_LEADER_CONTROL could be rewritten.
20160805 23:53:14< vultraz> I don't even know why we introduced such a mechanic 
20160805 23:53:49< celmin> I don't think it's a bad mechanic though.
20160805 23:54:24< jamit> Any pressing issues that need someone to look at? I don't know how much time I'll have, but I think I'll start making some for Wesnoth development.
20160805 23:54:35< fabi> vultraz: I wonder if you want to deprecate FOREACH as well. I just prepare a commit that replaces every mainline appearance of it. 
20160805 23:55:05< fabi> I think it is especially bad since it is unbalancing the wml.
20160805 23:55:26< fabi> Thus {NEXT} would be on the list as well.
20160805 23:56:40< celmin> Pressing issues? Hmm...
20160805 23:57:21< vultraz> jamit: https://gna.org/bugs/index.php?24780
20160805 23:57:36< celmin> Oh my, GUI2 issues.
20160805 23:58:17< celmin> Oh yeah, there's that ; issue
20160805 23:58:56< celmin> When you press ; to type in a command, the ; is inserted into the command line, and you have to delete it before you can do anything. Might happen in other contexts too (gfgtdf reported it with ` for opening the Lua console, if I recall correctly).
20160805 23:59:10< celmin> Is there a GNA report for that? I'm not sure.
20160805 23:59:46< jamit> Gna reports are easier to bookmark.
20160805 23:59:47< vultraz> jamit: ^ either of those is fairly pressing
--- Log closed Sat Aug 06 00:00:05 2016