--- Log opened Sun Aug 07 00:00:48 2016
20160807 00:01:30< gfgtdf> celmin: i think we shoudl change the [side] so thats its enogh to moit type= to not make it create e a leaser unti from sides attributes
20160807 00:02:59< gfgtdf> celmin: also when you want to change sides not us use inline leaders, note that there are some attributes ahred by teh unit and the side, specaill save_id= which defaults to id=, and side_name= which defaults to name=
20160807 00:04:09 * vultraz doesn't know what we'd do without wedge009
20160807 00:04:25< wedge009> Uh... why?
20160807 00:04:43< Aginor> wedge009: your sheer pure awesomeness
20160807 00:04:52< vultraz> I don't think anyone else has every been as diligent as he in commenting on and testing and confirming bugs
20160807 00:04:53< Aginor> it gives us an example to try to live up to
20160807 00:05:46< wedge009> Oh, well, it's the one thing I can do. I'm glad I can help. (:
20160807 00:05:51-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 00:05:57-!- Bonobo [~Bonobo@2001:44b8:254:3200:915e:16cf:c8e:a962] has joined #wesnoth-dev
20160807 00:06:13< celmin> Opposite of me who dislikes testing things… >_>
20160807 00:07:09< gfgtdf> s/moit/omit
20160807 00:08:30< celmin> So abolish no_leader altogether. Good idea.
20160807 00:09:27< vultraz> maybe just make an empty or absent [leader] AND empty type= mean no leader
20160807 00:10:06-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Ping timeout: 250 seconds]
20160807 00:10:42< vultraz> or we could just enforce [leader][/leader] for empty leader
20160807 00:11:53< gfgtdf> vultraz: hm i dont like that, i men its like writing [unit][/unit] if you dont want to place a unit.
20160807 00:12:00< vultraz> ok
20160807 00:12:05< vultraz> good point
20160807 00:12:06< celmin> No, empty [leader] should be invalid.
20160807 00:13:03-!- Bonobo [~Bonobo@2001:44b8:254:3200:915e:16cf:c8e:a962] has quit [Ping timeout: 264 seconds]
20160807 00:13:59-!- Bonobo [~Bonobo@2001:44b8:254:3200:a826:eb87:1478:9a0a] has joined #wesnoth-dev
20160807 00:14:39 * vultraz is still working his way down the list of bugs wedge gave him to close
20160807 00:19:02< celmin> Seems like teambuilder.cpp already properly handles getting the leader either way, but it doesn't know about the no_leader key.
20160807 00:19:08< Aginor> wedge009: seriously, all the testing and triaging is a great contribution
20160807 00:19:18< Aginor> wedge009: so stop talking yourself down :)
20160807 00:20:05< gfgtdf> celmin: i think the (mp) connect code now handles the no_leader key sicne the sp code also rns through that
20160807 00:20:44-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160807 00:20:49< celmin> Hi
20160807 00:22:33< celmin> gfgtdf: It's referenced once each in map_context, game_board, game_config_manager, connect_engine, and flg_manager...
20160807 00:22:52< celmin> Kinda all over the place...
20160807 00:23:33< gfgtdf> celmin: game_board only writed it to savefiles, map_context is part of the editor
20160807 00:24:03< celmin> Hmm.
20160807 00:24:29< celmin> Ah, I missed that map_context was part of the editor though. It's obvious when I look again.
20160807 00:25:23< gfgtdf> celmin: hmm from looking at the code it seems like alrady changed it to the behviour i suggested above.
20160807 00:25:34< celmin> Which part of the code?
20160807 00:25:42-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160807 00:26:10< gfgtdf> celmin: so that its now enogh to just omit the type= in [side] if you dont want a leader to be generated.
20160807 00:26:43< gfgtdf> celmin: that is unless in [multiplayer] where you still have to use no_leader=yes otherwise the mpo connect code will generate a leader from that faction
20160807 00:27:04< celmin> gfgtdf: What if you have a [leader] tag but no type attribute?
20160807 00:27:20< gfgtdf> celmin: then it will creat e aleader from the [leader]
20160807 00:27:38< celmin> Hmm, let's see then...
20160807 00:27:41< gfgtdf> celmin: well if you aheva  [leader] abnd that [leader] has no type= then you'll get an error liek previously
20160807 00:27:49< celmin> Well, obviously.
20160807 00:36:12-!- gfgtdf [~chatzilla@x4e32b210.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160807 00:51:42-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 00:54:13-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 01:00:34-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160807 01:11:44< celmin> Incidentally, whatever caused the test scenario to crash awhile back wȧs fixed at some point.
20160807 01:20:01< celmin> How does the game currently know when to replace the leader with a leader from the recall list?
20160807 01:26:51< vultraz> dunno
20160807 01:28:11-!- iceiceice [~chris@ext-74.ias.edu] has joined #wesnoth-dev
20160807 01:28:11-!- iceiceice [~chris@ext-74.ias.edu] has quit [Changing host]
20160807 01:28:11-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20160807 01:32:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160807 01:32:36< celmin> So helpful. :P
20160807 01:33:47< vultraz> i strive 
20160807 01:34:21< celmin> Please don't
20160807 01:40:05< iceiceice> burn
20160807 01:40:06< iceiceice> :p
20160807 01:41:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160807 01:41:22< iceiceice> wha??
20160807 01:41:32< iceiceice> in #llvm i randomly saw this chat line:
20160807 01:41:44< iceiceice> >  build #32015 of llvm-hexagon-elf is complete:
20160807 01:42:02< iceiceice> from llvm build bot: http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/32015
20160807 01:42:51< iceiceice> damn i so wish that was a wesnoth reference :)
20160807 01:43:03< iceiceice> i think its... hexagon is a company that sponsored a build bot or something?
20160807 01:43:08< iceiceice> and elf refers to elf format?
20160807 01:43:27< celmin> Oh yeah, the ELF executable format, huh...
20160807 01:43:46< celmin> …I wonder if the F in ELF stands for "format".
20160807 01:44:32< iceiceice> hmm apparently its something different from what I said: http://llvm.org/docs/doxygen/html/HexagonELFObjectWriter_8cpp_source.html
20160807 01:44:37-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160807 01:45:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160807 01:45:44< iceiceice> i think hexagon refers to this: https://en.wikipedia.org/wiki/Qualcomm_Hexagon
20160807 01:46:03-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 264 seconds]
20160807 01:56:50-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160807 02:08:45< Aginor> celmin: it does
20160807 02:08:58< Aginor> Extensible Linking Format
20160807 02:09:18< Aginor> or Exucutable and Linkable Format ;)
20160807 02:12:01< vultraz> Aginor: do you have a status report on the renderpathredo/fixes branch?
20160807 02:13:40-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160807 02:24:30-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 276 seconds]
20160807 02:25:31-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160807 02:27:21-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160807 02:27:32< iceiceice> how come wesnoth does not use appveyor as well as travis?
20160807 02:37:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160807 02:42:57-!- irker763 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160807 02:46:29-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has joined #wesnoth-dev
20160807 02:48:33-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 276 seconds]
20160807 02:50:52-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has quit [Ping timeout: 250 seconds]
20160807 02:58:55< celticminstrel> ...how the heck did a Drake Flare get into my tutorial?
20160807 02:59:58< celticminstrel> Well, anyway, it does show that the presence of [leader] is not taken the same way as the presence of a type key, I think?
20160807 03:00:41-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20160807 03:09:55-!- hay207 [~hay207@41.34.47.179] has joined #wesnoth-dev
20160807 03:11:50-!- hay207__ [~hay207@41.34.1.11] has quit [Ping timeout: 258 seconds]
20160807 03:19:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160807 03:51:12-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160807 03:55:55-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 252 seconds]
20160807 04:07:09-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160807 04:45:06-!- JyrkiVesterinen [~JyrkiVest@87-100-165-60.bb.dnainternet.fi] has joined #wesnoth-dev
20160807 04:46:11-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160807 04:54:08< vultraz> blagh
20160807 04:54:11< vultraz> constness
20160807 04:57:03-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 240 seconds]
20160807 04:57:32-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160807 05:03:45-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 276 seconds]
20160807 05:10:27< ancestral> Okay, I forget how to fix this
20160807 05:10:53< ancestral> NLS tools are not present...
20160807 05:11:00< ancestral> When trying to run scons translations
20160807 05:11:06< ancestral> Nothing gets built
20160807 05:11:12< ancestral> iceiceice: Suggestions?
20160807 05:13:54< ancestral> `scons: `translations' is up to date.` but then nothing is generated
20160807 05:23:12-!- Kwandulin [~Miranda@p200300760F314EF94DC723E6FFAA59EE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 05:29:40-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160807 05:33:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160807 05:33:28-!- wedge010 is now known as wedge009
20160807 05:36:34-!- Kwandulin [~Miranda@p200300760F314EF94DC723E6FFAA59EE.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160807 05:36:48-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160807 06:08:40-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160807 06:08:44< vultraz> holy mother of PRs
20160807 06:10:35< ancestral> HttT PRs?
20160807 06:12:16< vultraz> mhm
20160807 06:13:41< vultraz> gaaahhh GUI2 LIMITATIONS 
20160807 06:14:31< ancestral> https://github.com/wesnoth/wesnoth/pull/729/commits/915fe087e8b2a30fe53a6c5659ed821766fff206
20160807 06:14:39-!- RatArmy [~RatArmy@om126212084061.11.openmobile.ne.jp] has joined #wesnoth-dev
20160807 06:14:51< ancestral> Don’t we have English US and English GB for a reason, to avoid this kind of thing?
20160807 06:15:23< vultraz> not sure
20160807 06:15:30< ancestral> I think he’s being presumptive
20160807 06:15:31< vultraz> I thought Sceptre was right
20160807 06:15:44< vultraz> maybe I'm thinking of Spectre
20160807 06:15:50< ancestral> Might depend if it’s referring to the proper noun, the Sceptre of Fire?
20160807 06:16:15< ancestral> I feel like shadowm, Espreon or someone else is a better authority on this sort of thing
20160807 06:17:16< ancestral> PR #729: “Moved the player’s chamber up 3 hex” hmm
20160807 06:48:21< jamit> Looks like the British spelling of "scepter" is intentional for the SoF campaign: http://wiki.wesnoth.org/NotSpellingMistakes -- was there a decision to extend this to HttT?
20160807 06:51:24< vultraz> in the cases where it refers to the same object the spelling should be consistent
20160807 06:55:20< Aginor> 14:12 < vultraz> Aginor: do you have a status report on the  renderpathredo/fixes branch?
20160807 06:55:37< Aginor> I am not going to touch/merge it before 1.14
20160807 06:56:13< vultraz> whuuutt?
20160807 06:56:18< vultraz> really?
20160807 06:56:26< vultraz> how come
20160807 06:57:02< Aginor> too much risk, no gain
20160807 06:57:11< jamit> I could see an argument that if enough time had passed between the two campaigns (SoF and HttT), the spelling could change. But whatever the writers want.
20160807 06:57:16< Aginor> I don't want to have stabilised the GUI just to break it again before 1.14
20160807 06:58:18< vultraz> Aginor: last I tested it there was *significant* improvement in the responsiveness of guii2
20160807 06:59:49< vultraz> That's the element I'm interested in
20160807 07:00:18< vultraz> At the very least, that is some gain.
20160807 07:01:21< Aginor> and significant increase in cpu usage and significant breakage
20160807 07:04:12< vultraz> fair enough
20160807 07:05:18< vultraz> Aginor: so is your plan more minor fixes and optimizations for 1.14?
20160807 07:05:38< Aginor> yeah, primarily try not to break things
20160807 07:05:42< Aginor> fix bugs
20160807 07:05:50< Aginor> look into fullscreen mode again
20160807 07:06:04< Aginor> maybe add steam controller support when I get the hardware
20160807 07:07:21< Aginor> I might also look at removing SDL_ttf as a dependency
20160807 07:07:32< vultraz> Ok.
20160807 07:07:35< vultraz> Sounds good
20160807 07:07:39< vultraz> Will you remove SDL_GPU?
20160807 07:07:55< Aginor> but not introduce any major changes across the entire engine as it'll take too long to stabilise
20160807 07:07:59< Aginor> yeah
20160807 07:09:16< Aginor> I might also make a branch to play around with hardware acceleration in
20160807 07:09:25< Aginor> but that'll be something long-lived
20160807 07:11:42< Aginor> basically, I'm not confident in my approach on renderpath_redo and it blew up in my face, and more importantly, I lost momentum
20160807 07:11:55< vultraz> Aginor: so, no chance for hardware acceleration at all (native SDL or otherwise) for 1.14
20160807 07:12:19< Aginor> I'm not going to say never, but don't bet on it
20160807 07:12:20< vultraz> ?
20160807 07:12:40< Aginor> there's too many things in the engine that really isn't using a friendly approach for it ;)
20160807 07:12:50< vultraz> yes, I see..
20160807 07:13:12< Aginor> introducing hardware support is most likely going to break things for a lot of platforms/configurations
20160807 07:13:24< Aginor> so it'll take extensive testing and debugging to fix
20160807 07:13:30< vultraz> I'm just slightly worried that people on Steam will download the game and see the lag from SW acceleration and go blagh.
20160807 07:13:39< vultraz> rendering*
20160807 07:13:46< Aginor> too bad
20160807 07:14:52< vultraz> alright
20160807 07:15:32< vultraz> I guess if we want 1.14 in early 2017 as opposed to early 2018 we need to make that sacrifice.
20160807 07:16:02-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160807 07:17:44< vultraz> Right now I'm tentatively aiming for January for 1.14.
20160807 07:17:54< vultraz> March at the latest.
20160807 07:22:12< vultraz> In general, I think we need to focus on porting dialogs to GUI2, fixing bugs, and improving usability 
20160807 07:53:20< Aginor> mmm
20160807 07:53:38< Aginor> someone adding copy-paste support, url handlers and the like would be nice
20160807 07:53:46-!- Kwandulin [~Miranda@p200300760F314EF9EDA54CBA46403194.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 07:54:14< vultraz> Aginor: to what?
20160807 07:54:39< Aginor> * adding better copy-paste support
20160807 07:54:44< Aginor> vultraz: wesnoth
20160807 07:55:00< vultraz> :|
20160807 08:00:11-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has joined #wesnoth-dev
20160807 08:04:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160807 08:05:01-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has quit [Ping timeout: 250 seconds]
20160807 08:11:41< zookeeper> "scepter" the noun. "Sceptre of Fire" the proper noun. that's all there is to it.
20160807 08:16:08-!- RatArmy [~RatArmy@om126212084061.11.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160807 08:16:18< Bonobo> And now I know American English spells sceptre differently
20160807 08:16:27-!- RatArmy [~RatArmy@om126212084061.11.openmobile.ne.jp] has joined #wesnoth-dev
20160807 08:16:38< Aginor> there's plenty of differences
20160807 08:16:57< Aginor> but if the word ends in "er"/"re", be way
20160807 08:16:58< Bonobo> I've only ever seen it spelled sceptre
20160807 08:17:06< Aginor> wary even
20160807 08:17:44< Aginor> "ou" is also a danger sign ;)
20160807 08:17:52< Aginor> neighbour vs neighbor
20160807 08:18:08-!- Kwandulin [~Miranda@p200300760F314EF9EDA54CBA46403194.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160807 08:20:02< vultraz> We Americans dislike the excess 'u'
20160807 08:20:59< Aginor> real vs american english :D
20160807 08:21:54< vultraz> You mean real vs everyone else's English
20160807 08:22:09< vultraz> American is not the variant :)
20160807 08:22:24< Aginor> sure :D
20160807 08:29:07< Aginor> hmm
20160807 08:29:12< Aginor> 2 days until no mans sky
20160807 08:29:42< Aginor> and I've just comitted to a whole pile of consulting :/
20160807 08:30:19< vultraz> What is it you do, exactly
20160807 08:30:37< Aginor> for what?
20160807 08:30:50< vultraz> Your job.
20160807 08:34:15< Aginor> which one of them? :D - I have a main job and I do a bit of consulting on the side
20160807 08:34:39< vultraz> : o
20160807 08:35:02< vultraz> busy, you are
20160807 08:35:18< Aginor> yes
20160807 08:40:01-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20160807 08:40:43 * vultraz is playing around with ttext
20160807 08:45:22-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160807 08:46:04-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160807 09:11:40-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Read error: Connection reset by peer]
20160807 09:12:00-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160807 09:43:56-!- Kwandulin [~Miranda@p200300760F314EF9E582CAA817E46557.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 09:44:26-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20160807 09:50:30-!- RatArmy [~RatArmy@om126212084061.11.openmobile.ne.jp] has quit [Read error: Connection reset by peer]
20160807 09:51:47-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160807 09:55:10-!- Kwandulin [~Miranda@p200300760F314EF9E582CAA817E46557.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160807 09:56:08-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20160807 09:58:49-!- irker461 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160807 09:58:49< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor_WITH_RADIO_FIX ed4a3fffc062 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: generalize the radio group setup and callback functions https://github.com/wesnoth/wesnoth/commit/ed4a3fffc06222ce267b6dc7d3dc33ad79b9a128
20160807 09:58:52< irker461> wesnoth: Charles Dang wesnoth:gui2_addon_manager_refactor 7915c0843ed4 / / (4 files in 3 dirs): Enable GUI2 dialog blah blah https://github.com/wesnoth/wesnoth/commit/7915c0843ed4bc11b5f8e884c5fe92acf43306df
20160807 09:58:55< irker461> wesnoth: Charles Dang wesnoth:gui2_addon_manager_refactor aacbc807c3d8 / data/gui/default/window/addon_list.cfg: More progress, better layout https://github.com/wesnoth/wesnoth/commit/aacbc807c3d81c12e1d9c5414324ada5b697b04b
20160807 09:58:58< irker461> wesnoth: Charles Dang wesnoth:gui2_addon_manager_refactor 9f0a36f9532d / / (3 files in 2 dirs): More work on getting the details dynamically populated https://github.com/wesnoth/wesnoth/commit/9f0a36f9532ddcca218a83b3fa0827b57a1b6b8f
20160807 09:59:01< irker461> wesnoth: Charles Dang wesnoth:gui2_addon_manager_refactor f15aea7b844c / data/gui/default/window/addon_list.cfg src/gui/dialogs/addon_list.cpp: progress https://github.com/wesnoth/wesnoth/commit/f15aea7b844c1c6bc1e154e31023ab0677d1a432
20160807 09:59:04< irker461> wesnoth: Charles Dang wesnoth:lua5.3 609a4a841731 / / (65 files in 3 dirs): Updated embedded Lua library to 5.3.1 https://github.com/wesnoth/wesnoth/commit/609a4a841731de96665c95aec5b75532ef21c23f
20160807 09:59:07< irker461> wesnoth: Charles Dang wesnoth:lua5.3 b881e824990b / src/lua/luaconf.h: Enable 5.2 compatibility mode https://github.com/wesnoth/wesnoth/commit/b881e824990ba803f1a164c5fd19bf8bde916f4b
20160807 09:59:10< irker461> wesnoth: Charles Dang wesnoth:lua5.3 e1f004192eb9 / src/scripting/lua_kernel_base.cpp: Remove loading of bit32 library and add utf8 library https://github.com/wesnoth/wesnoth/commit/e1f004192eb9833bdd630cf8867c84fa8b03b71b
20160807 09:59:13< irker461> wesnoth: Charles Dang wesnoth:ttext_tweaks c91b200b7a10 / src/text.cpp: ttext: tweaks to rendering, especially on Windows https://github.com/wesnoth/wesnoth/commit/c91b200b7a10bf82fb13417a1267fcdf0fc4b2c1
20160807 09:59:16< irker461> wesnoth: Ignacio R. Morelle wesnoth:Branch_prefs_dialog_refactor 21183f19f353 / / (5 files in 3 dirs): gui2/tpreferences: Early WIP https://github.com/wesnoth/wesnoth/commit/21183f19f353fe42ad4fd3a0e332df323e47e3c6
20160807 09:59:19< irker461> wesnoth: Ignacio R. Morelle wesnoth:Branch_prefs_dialog_refactor fa54cec01df9 / / (9 files in 3 dirs): gui2/tpreferences: More WIP with some initial layouts https://github.com/wesnoth/wesnoth/commit/fa54cec01df9d92877de91ef8cc95533bfd7e6f0
20160807 09:59:22< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 0f94b1015783 / projectfiles/CodeBlocks/wesnoth.cbp src/CMakeLists.txt src/SConscript: Add prefs files to build lists https://github.com/wesnoth/wesnoth/commit/0f94b10157838a741069a4a048f307d1e600cda5
20160807 09:59:25< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 2bf86d4e205e / data/gui/default/window/preferences/01_general.cfg: tpreferences: removed Paths button https://github.com/wesnoth/wesnoth/commit/2bf86d4e205eb641d03b6fee5cfeed87a7f9ef6d
20160807 09:59:28< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor e8409c919c90 / src/ (3 files in 2 dirs): Progress on implementing GUI2 preferences dialog https://github.com/wesnoth/wesnoth/commit/e8409c919c9036a1f666df8f120ceb56bad4d2e7
20160807 09:59:31< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 36effcebd4f5 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: unify sound panel callbacks https://github.com/wesnoth/wesnoth/commit/36effcebd4f588441a895e43a6786a5046ba087e
20160807 09:59:31< vultraz> oh shit
20160807 09:59:33< vultraz> :|
20160807 09:59:34< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor a513d27c8d9a / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: added callbacks for sound panel sliders https://github.com/wesnoth/wesnoth/commit/a513d27c8d9af285296760c119b62aad59ecf99c
20160807 09:59:35< vultraz> what have I done
20160807 09:59:37< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor e09c2e526f53 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: make most of Display panel functional https://github.com/wesnoth/wesnoth/commit/e09c2e526f53a3f3248d68df8e6e323e8fd09336
20160807 09:59:40< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor b59de327e57e / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: generalize slider/button functions https://github.com/wesnoth/wesnoth/commit/b59de327e57e3ac8c26f3d3eb26f4f9bb198d078
20160807 09:59:43< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor b57529db09fa / src/ (3 files in 2 dirs): tpreferences: remove dependency on display https://github.com/wesnoth/wesnoth/commit/b57529db09fa4a95a19bc3b8c96df40169bf7eca
20160807 09:59:46< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor b0d2e1b8ed00 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: discard bool retval in setters https://github.com/wesnoth/wesnoth/commit/b0d2e1b8ed00f219437e7a62cd5e2846b8f62416
20160807 09:59:49< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 7bce47601643 / data/gui/default/window/preferences/01_general.cfg: tpreferences: split composite slider label text and values https://github.com/wesnoth/wesnoth/commit/7bce476016437af16d1fda4dde7285fb7c863985
20160807 09:59:52< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor d95fd0ffac4b / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: implement most of General panel https://github.com/wesnoth/wesnoth/commit/d95fd0ffac4b501cea3381dc4fde2ecf36639cb0
20160807 09:59:55< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor e264cdbccb7e / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: removed some test code https://github.com/wesnoth/wesnoth/commit/e264cdbccb7e05125e9f2629a8851d5177745721
20160807 09:59:58< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 6b3ac77a4ff7 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: implement most of Multiplayer tab https://github.com/wesnoth/wesnoth/commit/6b3ac77a4ff72f59e78e31f6cc58012c1aacfea3
20160807 09:59:58< vultraz> have I accidentally pushed my local branches to origin agai 
20160807 10:00:01< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 1e22417756d3 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: made use of lexical_cast https://github.com/wesnoth/wesnoth/commit/1e22417756d34baf41bb276671312bdd38fbc18c
20160807 10:00:01< vultraz> shadowm: halp
20160807 10:00:04< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 44980ba9e33c / src/preferences_display.cpp: Comment out a problem line https://github.com/wesnoth/wesnoth/commit/44980ba9e33c47e5f8e43970b362ffc0a310e31f
20160807 10:00:07< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 712d06f0f6f8 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: implement button callbacks with functionality immediately availabl https://github.com/wesnoth/wesnoth/commit/712d06f0f6f8dcc74aa434e3bb04dccabb98c912
20160807 10:00:10< vultraz> can someone mute irker
20160807 10:00:10< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor da84de5fac17 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: cleaned up function naming https://github.com/wesnoth/wesnoth/commit/da84de5fac179c3568851066f678e1e071efc6d2
20160807 10:00:13< vultraz> so i can delete these
20160807 10:00:13< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 90b432f5efdb / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: added hacky specialized functionality for lobby join radio group https://github.com/wesnoth/wesnoth/commit/90b432f5efdb99793c0c42545e154bd17bed0511
20160807 10:00:14< vultraz> :|
20160807 10:00:16< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor b2275fdec5a4 / / (3 files in 2 dirs): tpreferences: implemented Accelerated Speed handling https://github.com/wesnoth/wesnoth/commit/b2275fdec5a4311700ee13517666f245eecfc953
20160807 10:00:18< vultraz> haaalppp
20160807 10:00:19< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 6634d6b7919f / src/gui/dialogs/preferences_dialog.cpp: tpreferences: fixed an incorrectly set up entry https://github.com/wesnoth/wesnoth/commit/6634d6b7919fba6bd336bdd94181da73a5bd971d
20160807 10:00:21< vultraz> not agaiaannn
20160807 10:00:22< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor c4d7c23b3857 / / (2 files in 2 dirs): tpreferences: used scroll type for custom slider value labels https://github.com/wesnoth/wesnoth/commit/c4d7c23b3857e5d937be87b69c9a0e987b67a27d
20160807 10:00:25< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 240cc8245642 / src/ (3 files in 2 dirs): tpreferences: removed CVideo argument https://github.com/wesnoth/wesnoth/commit/240cc8245642119eae93cf16c71469c0dbc51d2c
20160807 10:00:28< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 27a42204970b / data/gui/default/window/preferences/ (01_general.cfg 02_display.cfg 04_multiplayer.cfg): tpreferences: added tooltips for buttons missing them https://github.com/wesnoth/wesnoth/commit/27a42204970bbbb4100a07f281690fff64379032
20160807 10:00:31< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor a54ad0a67899 / src/gui/dialogs/simple_item_selector.cpp: tsimple_item_selector: allowed markup by default https://github.com/wesnoth/wesnoth/commit/a54ad0a67899fbaf6598042b8b98a824ff04f32c
20160807 10:00:33< vultraz> hhaaalllppppppppp
20160807 10:00:34< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor e8008f4f2e78 / src/preferences_display.cpp: Added some formatting to res chooser dialog https://github.com/wesnoth/wesnoth/commit/e8008f4f2e788b0ce60b79fe377651556c5f7f5b
20160807 10:00:37< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 88d802f5bfcf / src/game_preferences_display.cpp: Reduced wednothd filechooser case title length https://github.com/wesnoth/wesnoth/commit/88d802f5bfcf782996fa3c7a3dc73f8a54b3eb7a
20160807 10:00:40< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 8450afa57ebe / src/gui/dialogs/helper.hpp: Added additional dialog callback helper function by iceiceice https://github.com/wesnoth/wesnoth/commit/8450afa57ebeba01dac2ae7ad9201f54b73a1492
20160807 10:00:43< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 5fbc4d3b7c9d / data/advanced_preferences.cfg src/display.cpp src/display.hpp: Removed the option to turn off Local ToD lighting. It is now always on. https://github.com/wesnoth/wesnoth/commit/5fbc4d3b7c9d807a4133f6ef642f7cf2e473bf47
20160807 10:00:45-!- lipkab [~the_new_l@apn-185-10-124-230.vodafone.hu] has joined #wesnoth-dev
20160807 10:00:46< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor e653974d7123 / / (4 files in 2 dirs): Remove Reverse Time Graphics option https://github.com/wesnoth/wesnoth/commit/e653974d7123fc7e2ad2e2d9a0a8e3cc43225290
20160807 10:00:49< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor d0154d6fa406 / / (7 files in 5 dirs): Removed Titlescreen Animation option and related code https://github.com/wesnoth/wesnoth/commit/d0154d6fa406da0f7cca73f65948be6b750f1d2b
20160807 10:00:52< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 818b070d2fa9 / data/gui/default/widget/ (label_default.cfg scroll_label_default.cfg): Added definition for small-size scroll label https://github.com/wesnoth/wesnoth/commit/818b070d2fa9403bbde1f69da2b8ce520b3e3376
20160807 10:00:55< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor 811d7f8449a2 / / (7 files in 3 dirs): Cleaned up window layout and implement tabs for MP page (not functional yet) https://github.com/wesnoth/wesnoth/commit/811d7f8449a2726048848c99ae99572737f12390
20160807 10:00:58< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor b095c56a84c9 / src/ (preferences.cpp preferences.hpp): Added another prefs getter method that takes a string default https://github.com/wesnoth/wesnoth/commit/b095c56a84c97fac152eda4903867eef6472d1e2
20160807 10:01:01< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor f9169d90d7cb / / (4 files in 3 dirs): tpreferences: imported advanced prefs into class and added preliminary display https://github.com/wesnoth/wesnoth/commit/f9169d90d7cba31a5e7d91f90f81c98c2c7c3177
20160807 10:01:04< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 326d2e50333d / src/unit_filter.cpp: use parse() instead of string_to_enum(). https://github.com/wesnoth/wesnoth/commit/326d2e50333dc0faa1743ccb985cb70459215e14
20160807 10:01:05-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has joined #wesnoth-dev
20160807 10:01:06< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 0f794321c40b / src/make_enum.hpp: add a comment https://github.com/wesnoth/wesnoth/commit/0f794321c40ba8763029b95cbc4d6d7f3b599d25
20160807 10:01:08< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor ae5608d22770 / src/gui/ (5 files in 2 dirs): attempt to fix 'moseover' state not beeing selected.. https://github.com/wesnoth/wesnoth/commit/ae5608d22770c45375141b61eb6d89d319bd9dcf
20160807 10:01:10< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 64faa776a98c / / (12 files in 7 dirs): comboboxes for gui2 https://github.com/wesnoth/wesnoth/commit/64faa776a98ccffe0d2579d67078676a4ada9102
20160807 10:01:12< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor c880d82e51c2 / data/gui/default/window/drop_down_list.cfg: make dropdown list width at least the width of the combobox https://github.com/wesnoth/wesnoth/commit/c880d82e51c2b340cf0d9d8934cc1dadfbe80b7e
20160807 10:01:14< vultraz> fuck
20160807 10:01:14< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 3284e5b32a95 / src/scripting/lua_gui2.cpp: lua gui get/set_dialog_value take numbers for tselectable_ https://github.com/wesnoth/wesnoth/commit/3284e5b32a95420662ec9b8fc5a890fdd59b09fb
20160807 10:01:16< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 225506650da8 / data/gui/default/window/title_screen.cfg: testing combobox widget on titltescreen https://github.com/wesnoth/wesnoth/commit/225506650da8a191ab02e04f9bcc192bb82194b1
20160807 10:01:18< vultraz> fuck fuck fuck
20160807 10:01:18< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor eb4b8eab7392 / src/gui/widgets/combobox.hpp: fixup https://github.com/wesnoth/wesnoth/commit/eb4b8eab73921bf5c4eff0ca19a2c29dbcc878ed
20160807 10:01:19< vultraz> :|
20160807 10:01:20< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 8471d1c79a61 / src/gui/widgets/ (combobox.cpp combobox.hpp): fixup https://github.com/wesnoth/wesnoth/commit/8471d1c79a61a14eda1891f2a140900f5fab1f02
20160807 10:01:22< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor af8fac0780ae / / (23 files in 10 dirs): Merge branch 'gui2_combobox' of git://github.com/gfgtdf/wesnoth-old into Branch_ https://github.com/wesnoth/wesnoth/commit/af8fac0780aea6c6d74d4a7216cb1b5f21b37b36
20160807 10:01:24< vultraz> CAN SOMEONE SHUT THIS BOT UP
20160807 10:01:25< irker461> wesnoth: gfgtdf wesnoth:Branch_prefs_dialog_refactor 4dd204b8828c / src/gui/dialogs/drop_down_list.cpp: fixup 3 https://github.com/wesnoth/wesnoth/commit/4dd204b8828cf81c9520b6cc9015d67fc3d6d2f5
20160807 10:01:27< irker461> wesnoth: Charles Dang wesnoth:Branch_prefs_dialog_refactor b3b503733cec / src/gui/dialogs/drop_down_list.cpp: Merge branch 'gui2_combobox' of git://github.com/gfgtdf/wesnoth-old into Branch_ https://github.com/wesnoth/wesnoth/commit/b3b503733cec72ebef04b40a526dfcf69c400a86
20160807 10:01:29< JyrkiVesterinen> Oh no...
20160807 10:01:30< irker461> wesnoth: Ignacio R. Morelle wesnoth:prefs_dialog_refactor c04b0ddc66c4 / / (5 files in 3 dirs): gui2/tpreferences: Early WIP https://github.com/wesnoth/wesnoth/commit/c04b0ddc66c4eb6141a50cb089e512ca02089645
20160807 10:01:33< irker461> wesnoth: Ignacio R. Morelle wesnoth:prefs_dialog_refactor 3ed2e1f5044d / / (9 files in 3 dirs): gui2/tpreferences: More WIP with some initial layouts https://github.com/wesnoth/wesnoth/commit/3ed2e1f5044d616717676e3b9e14fe33d105eca0
20160807 10:01:36< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 305e11bcd74e / projectfiles/CodeBlocks/wesnoth.cbp src/CMakeLists.txt src/SConscript: Add prefs files to build lists https://github.com/wesnoth/wesnoth/commit/305e11bcd74ef7634d6098c4db620516c6361684
20160807 10:01:39< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 03788d64afa6 / data/gui/default/window/preferences/01_general.cfg: tpreferences: removed Paths button https://github.com/wesnoth/wesnoth/commit/03788d64afa64fc9dd49a02377ee6c9042be7307
20160807 10:01:42< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor ee375a3e8b24 / src/ (3 files in 2 dirs): Progress on implementing GUI2 preferences dialog https://github.com/wesnoth/wesnoth/commit/ee375a3e8b24fdd0a9a89540729c4fdaea174fc8
20160807 10:01:45< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor cb31adae0d2c / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: unify sound panel callbacks https://github.com/wesnoth/wesnoth/commit/cb31adae0d2c6c5e8f5bd3c09b5b73d0d34d61e5
20160807 10:01:46< vultraz> JyrkiVesterinen: I seem to have accidently pushed my local branches to origin and not my fork
20160807 10:01:48< vultraz> accidentally 
20160807 10:01:48< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor a198e160d2a5 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: added callbacks for sound panel sliders https://github.com/wesnoth/wesnoth/commit/a198e160d2a527a90cd6de61cf4e4281d141945e
20160807 10:01:51< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor be57fa7b89d8 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: make most of Display panel functional https://github.com/wesnoth/wesnoth/commit/be57fa7b89d8ed5d38e1fb4639b08a487519d67c
20160807 10:01:54< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 779f748134db / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: generalize slider/button functions https://github.com/wesnoth/wesnoth/commit/779f748134db951795d9b556f6b5457f8a77cf9a
20160807 10:01:57< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 2aebf575ee02 / src/ (3 files in 2 dirs): tpreferences: remove dependency on display https://github.com/wesnoth/wesnoth/commit/2aebf575ee02a6691d7bdfcbaf5beef3056c4695
20160807 10:02:00< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 71c7956dbbbe / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: discard bool retval in setters https://github.com/wesnoth/wesnoth/commit/71c7956dbbbe82dffdf076fa4f7fe5e136bc80c9
20160807 10:02:03< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 90d121a599fb / data/gui/default/window/preferences/01_general.cfg: tpreferences: split composite slider label text and values https://github.com/wesnoth/wesnoth/commit/90d121a599fb59680501518abade83285012f05d
20160807 10:02:06< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 4032df927664 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: implement most of General panel https://github.com/wesnoth/wesnoth/commit/4032df927664f587747535e040b615f01820f22d
20160807 10:02:09< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor cf4ca9a3ec89 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: removed some test code https://github.com/wesnoth/wesnoth/commit/cf4ca9a3ec89e30d47b67c293437d5e890f08366
20160807 10:02:12< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor ff934f253c07 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: implement most of Multiplayer tab https://github.com/wesnoth/wesnoth/commit/ff934f253c07effd44acd2a70a0bbbcab9c6b462
20160807 10:02:14< vultraz> JyrkiVesterinen: I can delete them but irker will continue to spam :|
20160807 10:02:15< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 1fe1c2665e71 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: made use of lexical_cast https://github.com/wesnoth/wesnoth/commit/1fe1c2665e716539e445c3b2376fdac67deedc96
20160807 10:02:18< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 4f2b6c616d79 / src/preferences_display.cpp: Comment out a problem line https://github.com/wesnoth/wesnoth/commit/4f2b6c616d79dd4e225ee3ac3034477cf27bd483
20160807 10:02:21< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor a5345a15e309 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: implement button callbacks with functionality immediately availabl https://github.com/wesnoth/wesnoth/commit/a5345a15e309f11ae99cb6f9e75dddbb41201327
20160807 10:02:23< vultraz> :(
20160807 10:02:24< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 71e934e0c479 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: cleaned up function naming https://github.com/wesnoth/wesnoth/commit/71e934e0c4798ff452ee9916df62b84d8f1531a7
20160807 10:02:27< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor bfacc0ef5b58 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: added hacky specialized functionality for lobby join radio group https://github.com/wesnoth/wesnoth/commit/bfacc0ef5b58edc0e13f8e71d826debe5caadc64
20160807 10:02:30< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor fbf4c91f272d / / (3 files in 2 dirs): tpreferences: implemented Accelerated Speed handling https://github.com/wesnoth/wesnoth/commit/fbf4c91f272d9bb422164c823ecfa43958a689b7
20160807 10:02:33< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor b6cd2f8007c8 / src/gui/dialogs/preferences_dialog.cpp: tpreferences: fixed an incorrectly set up entry https://github.com/wesnoth/wesnoth/commit/b6cd2f8007c8a99f043b7fee064bb6ad5854e846
20160807 10:02:36< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 56ecf5d6c223 / / (2 files in 2 dirs): tpreferences: used scroll type for custom slider value labels https://github.com/wesnoth/wesnoth/commit/56ecf5d6c223abad61664b8f01d90090c3680546
20160807 10:02:39< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 4cae897f7089 / src/ (3 files in 2 dirs): tpreferences: removed CVideo argument https://github.com/wesnoth/wesnoth/commit/4cae897f708942fb6f1b1ddb7d57cba024a27afe
20160807 10:02:42< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 0743e821872d / data/gui/default/window/preferences/ (01_general.cfg 02_display.cfg 04_multiplayer.cfg): tpreferences: added tooltips for buttons missing them https://github.com/wesnoth/wesnoth/commit/0743e821872d769363e90daefa9346d7bce43f4e
20160807 10:02:45< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 03857b9846ff / src/gui/dialogs/simple_item_selector.cpp: tsimple_item_selector: allowed markup by default https://github.com/wesnoth/wesnoth/commit/03857b9846ff1903d583e9d4821e97fbf18f6ad5
20160807 10:02:48< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 84a91015ee28 / src/preferences_display.cpp: Added some formatting to res chooser dialog https://github.com/wesnoth/wesnoth/commit/84a91015ee283756b8a23d5879dc35d4d5729e94
20160807 10:02:51< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 9940d4afc529 / src/game_preferences_display.cpp: Reduced wednothd filechooser case title length https://github.com/wesnoth/wesnoth/commit/9940d4afc5295d86cfda7cfe3c494d3bb86d4576
20160807 10:02:54< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 5c7d88560321 / src/gui/dialogs/helper.hpp: Added additional dialog callback helper function by iceiceice https://github.com/wesnoth/wesnoth/commit/5c7d885603212b580f169ffb46d8ce805f35a297
20160807 10:02:57< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor a0f2032051a0 / data/advanced_preferences.cfg src/display.cpp src/display.hpp: Removed the option to turn off Local ToD lighting. It is now always on. https://github.com/wesnoth/wesnoth/commit/a0f2032051a00f2df085910e42d279d93352d6ce
20160807 10:02:59< JyrkiVesterinen> Are there any channel operators who could kick the bot out of this channel?
20160807 10:03:00< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor fe19c9f79044 / / (4 files in 2 dirs): Remove Reverse Time Graphics option https://github.com/wesnoth/wesnoth/commit/fe19c9f79044e1d665a917168d1c8959c56708c6
20160807 10:03:03< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 9f003b733967 / / (7 files in 5 dirs): Removed Titlescreen Animation option and related code https://github.com/wesnoth/wesnoth/commit/9f003b733967979affc8a4db8aa756db2390d5f2
20160807 10:03:06< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 4eb3dcbfc014 / data/gui/default/widget/ (label_default.cfg scroll_label_default.cfg): Added definition for small-size scroll label https://github.com/wesnoth/wesnoth/commit/4eb3dcbfc014ca9ad068f1e4c34436487440f5d3
20160807 10:03:09< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 04b1d3e9eea1 / / (7 files in 3 dirs): Cleaned up window layout and implement tabs for MP page (not functional yet) https://github.com/wesnoth/wesnoth/commit/04b1d3e9eea136b67f3ee07d589b68e53b1ef27a
20160807 10:03:12< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor ee8ae4af0d28 / src/ (preferences.cpp preferences.hpp): Added another prefs getter method that takes a string default https://github.com/wesnoth/wesnoth/commit/ee8ae4af0d28d975016d9966266f51f703416b98
20160807 10:03:15< vultraz> JyrkiVesterinen: nope
20160807 10:03:15< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor e26e5676b16d / / (4 files in 3 dirs): tpreferences: imported advanced prefs into class and added preliminary display https://github.com/wesnoth/wesnoth/commit/e26e5676b16d27e3e2d31687a32d0317dd5d1071
20160807 10:03:18< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor ece5eaf133a3 / / (8 files in 3 dirs): tpreferences: reimplement resolution selection using a combobox https://github.com/wesnoth/wesnoth/commit/ece5eaf133a316dc08516195dbf56f80aa33a3be
20160807 10:03:21< JyrkiVesterinen> :(
20160807 10:03:21< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor a4b753a74ed2 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): tpreferences: removed unnecessary private member https://github.com/wesnoth/wesnoth/commit/a4b753a74ed24645eb7c90d028ba7d987832e71d
20160807 10:03:24< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 402b5ef84bcf / / (4 files in 3 dirs): tpreferences: much progress on Advanced panel https://github.com/wesnoth/wesnoth/commit/402b5ef84bcfcd1bab392a24ef93ac6f2146bebb
20160807 10:03:27< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor c0564563280c / / (2 files in 2 dirs): Cleanup https://github.com/wesnoth/wesnoth/commit/c0564563280c83b78f89695038feee3362b42291
20160807 10:03:30< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 20ea2cdc26f7 / / (4 files in 3 dirs): tpreferences: major progress on dialog. Advanced panel almost complete https://github.com/wesnoth/wesnoth/commit/20ea2cdc26f7046ef154472ffbf7186756485452
20160807 10:03:33< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor e07fcbb077b7 / data/advanced_preferences.cfg: Added advanced preferences for Adv. Graphics and Orb Colors https://github.com/wesnoth/wesnoth/commit/e07fcbb077b7de021e0a75c291b29cb4667e7efa
20160807 10:03:36-!- mode/#wesnoth-dev [+o vultraz] by ChanServ
20160807 10:03:36< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 06a2035ee1a3 / src/game_preferences_display.cpp: Cleaned up show_theme_dialog() a bit https://github.com/wesnoth/wesnoth/commit/06a2035ee1a3319373bdae3f473ab4d3183db582
20160807 10:03:39<@vultraz> oh
20160807 10:03:39< irker461> wesnoth: Charles Dang wesnoth:prefs_dialog_refactor 625c6bc844dc / / (6 files in 4 dirs): tpreferences: added friends list functionality https://github.com/wesnoth/wesnoth/commit/625c6bc844dced69cd493a5800e2b3ed6e1aebbc
20160807 10:03:40-!- irker461 was kicked from #wesnoth-dev by vultraz [irker461]
20160807 10:03:48<@vultraz> I HAVE THE POWER
20160807 10:03:49< JyrkiVesterinen> Phew. Thank you.
20160807 10:04:16<@vultraz> now thank god these are all branches
20160807 10:04:24<@vultraz> and I can delete them
20160807 10:05:28< zookeeper> oh lol.
20160807 10:05:29-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has quit [Ping timeout: 250 seconds]
20160807 10:06:24<@vultraz> I should delete these locally
20160807 10:06:27<@vultraz> so this never happens again
20160807 10:06:35< zookeeper> next time you can also try highlighting me to mute it
20160807 10:07:15<@vultraz> you can do that?
20160807 10:07:18< zookeeper> yes
20160807 10:10:39<@vultraz> think I got them all
20160807 10:10:44-!- mode/#wesnoth-dev [-o vultraz] by vultraz
20160807 10:13:50-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 10:13:51< travis-ci> wesnoth/wesnoth#10201 (lua5.3 - e1f0041 : Charles Dang): The build has errored.
20160807 10:13:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394459
20160807 10:13:51-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 10:15:20< vultraz> and all that because I wanted to open a PR
20160807 10:23:38-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 10:23:39< travis-ci> wesnoth/wesnoth#10202 (Lua5.2.4 - b512ad2 : Charles Dang): The build has errored.
20160807 10:23:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394472
20160807 10:23:39-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 10:27:51-!- jamit [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has left #wesnoth-dev []
20160807 10:29:07-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 10:29:08< travis-ci> wesnoth/wesnoth#10201 (prefs_dialog_refactor_WITH_RADIO_FIX - ed4a3ff : Charles Dang): The build has errored.
20160807 10:29:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394486
20160807 10:29:09-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 10:33:06-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160807 10:34:50-!- lipkab [~the_new_l@apn-185-10-124-230.vodafone.hu] has quit [Ping timeout: 244 seconds]
20160807 10:37:00-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 10:37:01< travis-ci> wesnoth/wesnoth#10200 (gui2_addon_manager_refactor - f15aea7 : Charles Dang): The build failed.
20160807 10:37:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394451
20160807 10:37:01-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 10:38:23-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 10:38:24< travis-ci> wesnoth/wesnoth#10202 (ttext_tweaks - c91b200 : Charles Dang): The build has errored.
20160807 10:38:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394477
20160807 10:38:24-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 10:51:33-!- hay207 [~hay207@41.34.47.179] has quit [Ping timeout: 240 seconds]
20160807 10:51:47-!- hay207 [~hay207@41.34.52.87] has joined #wesnoth-dev
20160807 11:01:43-!- ChipmunkV [~vova@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Ping timeout: 244 seconds]
20160807 11:06:40-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160807 11:08:35-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 11:08:36< travis-ci> wesnoth/wesnoth#10203 (display_cleanup - a6f35e5 : Charles Dang): The build passed.
20160807 11:08:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394493
20160807 11:08:36-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 11:20:37-!- JyrkiVesterinen [~JyrkiVest@87-100-165-60.bb.dnainternet.fi] has quit [Quit: .]
20160807 11:22:25-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 11:22:26< travis-ci> wesnoth/wesnoth#10204 (prefs_dialog_refactor - 819156d : Charles Dang): The build has errored.
20160807 11:22:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394513
20160807 11:22:26-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 11:30:37-!- Appleman1234 [~Appleman1@KD036012021004.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20160807 11:33:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160807 11:33:58-!- ggeneral [~ggeneral@nat58.opti.net.ua] has joined #wesnoth-dev
20160807 11:37:30-!- ggeneral [~ggeneral@nat58.opti.net.ua] has left #wesnoth-dev []
20160807 11:47:00-!- Appleman1234 [~Appleman1@KD036012021004.au-net.ne.jp] has joined #wesnoth-dev
20160807 11:56:12-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 11:56:13< travis-ci> wesnoth/wesnoth#10204 (event_handling_fixes - 61ccf2f : Charles Dang): The build has errored.
20160807 11:56:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394519
20160807 11:56:15-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 12:15:37-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 12:15:38< travis-ci> wesnoth/wesnoth#10204 (prefs_dialog_refactor_FINAL - 0ff4830 : Charles Dang): The build has errored.
20160807 12:15:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394530
20160807 12:15:39-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 12:26:13-!- lipkab [~the_new_l@apn-185-10-124-230.vodafone.hu] has joined #wesnoth-dev
20160807 12:37:34-!- JyrkiVesterinen [~JyrkiVest@78-27-104-3.bb.dnainternet.fi] has joined #wesnoth-dev
20160807 12:38:05-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 12:38:07< travis-ci> wesnoth/wesnoth#10204 (tc_deprecate - 54d6af4 : Celtic Minstrel): The build was broken.
20160807 12:38:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394532
20160807 12:38:07-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 12:49:28-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 12:49:29< travis-ci> wesnoth/wesnoth#10204 (CelticMinstrel-prefs_stuff - 7cf2840 : Charles Dang): The build has errored.
20160807 12:49:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394524
20160807 12:49:29-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 12:53:50-!- Kwandulin [~Miranda@p200300760F314EFA15E52414013C70BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 12:54:19-!- lipkab [~the_new_l@apn-185-10-124-230.vodafone.hu] has quit [Ping timeout: 260 seconds]
20160807 13:00:44-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:00:45< travis-ci> wesnoth/wesnoth#10204 (unit_preview_pane - 42816df : Charles Dang): The build has errored.
20160807 13:00:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394564
20160807 13:00:45-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:02:10-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:02:11< travis-ci> wesnoth/wesnoth#10204 (renderpath_redo - 70a9845 : Andreas Löf): The build was broken.
20160807 13:02:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394523
20160807 13:02:11-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:04:34-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:04:35< travis-ci> wesnoth/wesnoth#10204 (gui1_simplification - 5f732c3 : Charles Dang): The build has errored.
20160807 13:04:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394560
20160807 13:04:35-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:25:45-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:25:46< travis-ci> wesnoth/wesnoth#10204 (slight_prefs_refactor - 534b38c : Charles Dang): The build has errored.
20160807 13:25:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394584
20160807 13:25:46-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:27:10-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:27:11< travis-ci> wesnoth/wesnoth#10204 (Lua5.3.2 - 2ffa1ff : Charles Dang): The build has errored.
20160807 13:27:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394575
20160807 13:27:11-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:28:32-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:28:33< travis-ci> wesnoth/wesnoth#10203 (Branch_prefs_dialog_refactor - b3b5037 : Charles Dang): The build has errored.
20160807 13:28:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394522
20160807 13:28:33-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:28:52-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:28:53< travis-ci> wesnoth/wesnoth#10204 (small_gui2_cleanup - 23f9cde : Charles Dang): The build has errored.
20160807 13:28:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394592
20160807 13:28:53-!- travis-ci [~travis-ci@ec2-54-90-233-55.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:35:01-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:35:02< travis-ci> wesnoth/wesnoth#10204 (display_to_cvideo - 5e6f0e1 : Charles Dang): The build has errored.
20160807 13:35:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394611
20160807 13:35:02-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:36:23-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:36:24< travis-ci> wesnoth/wesnoth#10204 (gui2_widget_groups - 6d883e1 : Charles Dang): The build has errored.
20160807 13:36:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394613
20160807 13:36:24-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:36:40-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:36:41< travis-ci> wesnoth/wesnoth#10204 (guifixes - 2ad8939 : Andreas Löf): The build has errored.
20160807 13:36:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394572
20160807 13:36:41-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:39:21-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 13:39:22< travis-ci> wesnoth/wesnoth#10204 (prefs_to_display - 4ab959f : Charles Dang): The build has errored.
20160807 13:39:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394618
20160807 13:39:22-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 13:42:43-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160807 13:47:57-!- mjs-de [~mjs-de@p508C888A.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 13:51:18-!- Kwandulin [~Miranda@p200300760F314EFA15E52414013C70BF.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160807 14:02:48-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has joined #wesnoth-dev
20160807 14:03:18-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 14:03:19< travis-ci> wesnoth/wesnoth#10204 (boost_trimming - 071eee1 : Charles Dang): The build is still failing.
20160807 14:03:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150394625
20160807 14:03:19-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 14:07:17-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b193:4133:2b77:fda4] has quit [Ping timeout: 250 seconds]
20160807 14:13:55-!- Kwandulin [~Miranda@p200300760F314EFA15E52414013C70BF.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 14:17:09< wedge009> Aginor: Thanks for the encouragement. I wasn't talking myself down, just reflecting on the fact that you and many others seem to have a much better grasp of the code than I do, at least at this point.
20160807 14:19:03< wedge009> vultraz: The term 'English' itself suggests something about what is the original and what is the variant. ;) In all seriousness, though, there are dialectal differences in English all around the world, nothing to be concerned about. It does irk me that the American version is what dominates the 'net, but it is what it is. That's why we have an en_GB localisation. (:
20160807 14:19:12< wedge009> Oh, and that's an impressive amount of spam from irker. :p
20160807 14:49:08-!- Kwandulin [~Miranda@p200300760F314EFA15E52414013C70BF.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160807 14:55:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160807 14:56:07-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 14:56:08< travis-ci> spixi/wesnoth#10 (name_generator_beautification - 529b768 : Spixi): The build passed.
20160807 14:56:08< travis-ci> Build details : https://travis-ci.org/spixi/wesnoth/builds/150423613
20160807 14:56:08-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 15:04:14-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160807 15:13:33-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160807 15:14:15-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160807 15:14:40-!- Kwandulin [~Miranda@p200300760F314EFA2803BB1BDF4E80DA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 15:17:59< celticminstrel> Someone should probably run valgrind on Wesnoth...
20160807 15:26:34-!- mjs-de [~mjs-de@p508C888A.dip0.t-ipconnect.de] has quit [Remote host closed the connection]
20160807 15:29:07< celticminstrel> Why does toplevel [time_area] not support SLF? Is there a technical limitation of some kind? Map not yet constructed or something?
20160807 15:30:27-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 15:30:42 * zookeeper doesn't know
20160807 15:31:23< celticminstrel> If I recall correctly, [item] has the same limitation...
20160807 15:46:41< iceiceice> celticminstrel, you could also try clang ubsan
20160807 15:47:00< iceiceice> debug mode wesnoth is pretty slow, and valgrind is really slow
20160807 15:47:16< iceiceice> i guess gcc has ubsan also nowadays
20160807 15:48:00< celticminstrel> ubsan?
20160807 15:48:04-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20160807 15:48:12< celticminstrel> ...
20160807 15:50:29< JyrkiVesterinen> Ubsan is the "undefined behavior sanitizer". It inserts code to codepaths which trigger undefined behavior, making the game crash and print information in such a situation.
20160807 15:51:08< JyrkiVesterinen> There is also the address sanitizer, asan. It's an alternative to Valgrind.
20160807 15:51:52< JyrkiVesterinen> Asan can detect some memory problems that Valgrind can't, in particular use-after-return.
20160807 15:55:12-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 15:57:15-!- irker903 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160807 15:57:15< irker903> wesnoth: Jyrki Vesterinen wesnoth:fade-out-music d4e6d0bf2b9b / changelog data/core/macros/sound-utils.cfg players_changelog src/sound.cpp: Fade out music on scenario start and on disabling it https://github.com/wesnoth/wesnoth/commit/d4e6d0bf2b9bff1c748920167eec0d0ed334364f
20160807 15:57:49< JyrkiVesterinen> (^ just a rebase, no actual changes from before)
20160807 15:58:18< celticminstrel> Is that the same as what XCode calls the "static analyzer"?
20160807 15:58:29< celticminstrel> Or something different?
20160807 15:58:42< JyrkiVesterinen> No. Both ubsan and asan perform dynamic analysis.
20160807 15:59:01< celticminstrel> I could run the static analyzer, but I imagine it would likely take hours and most of what it would turn up would be hard to fix. >_>
20160807 15:59:06< celticminstrel> I see.
20160807 15:59:11< JyrkiVesterinen> A static analyzer, by definition, operates by only examining source code.
20160807 15:59:16< celticminstrel> Yeah.
20160807 16:01:06< celticminstrel> I have no idea whether I have this ubsan or asan or, if I do, how it would be used.
20160807 16:04:34< JyrkiVesterinen> They're both Clang features, so I'm positive you have them.
20160807 16:05:02< JyrkiVesterinen> I think you'd be able to use them by telling XCode to insert additional command-line parameters to the compiler command line.
20160807 16:05:43< JyrkiVesterinen> http://clang.llvm.org/docs/AddressSanitizer.html#usage
20160807 16:05:58< JyrkiVesterinen> Likewise, -fsanitize=undefined for ubsan.
20160807 16:08:58< celticminstrel> I see.
20160807 16:09:08< celticminstrel> (I'm basically using clang 3.2 or so, though.)
20160807 16:09:37< celticminstrel> (Maybe I can get the newer version to work with XCode 4, but I'm not sure it would work as well.)
20160807 16:11:36< JyrkiVesterinen> According to the page I linked: "AddressSanitizer is fully functional on supported platforms starting from LLVM 3.1."
20160807 16:12:23< JyrkiVesterinen> You don't have ubsan though. It arrived in LLVM 3.3.
20160807 16:12:33< celticminstrel> Ah.
20160807 16:13:21< celticminstrel> My MacPorts clang version is 3.8...
20160807 16:13:45< celticminstrel> But I don't know how to use that with XCode and not sure if it'll work with scons (and besides I don't really want to use scons for compiling).
20160807 16:14:10< celticminstrel> I guess trying the address sanitizer is a good idea though.
20160807 16:19:13-!- Kwandulin [~Miranda@p200300760F314EFA2803BB1BDF4E80DA.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160807 16:30:13-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160807 16:32:55-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 16:32:56< travis-ci> wesnoth/wesnoth#10207 (fade-out-music - d4e6d0b : Jyrki Vesterinen): The build passed.
20160807 16:32:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150436270
20160807 16:32:56-!- travis-ci [~travis-ci@ec2-54-158-93-56.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 16:40:50-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 16:46:24-!- Bonobo [~Bonobo@2001:44b8:254:3200:a826:eb87:1478:9a0a] has quit [Quit: Leaving]
20160807 16:54:01-!- iceiceice [~chris@50.245.222.235] has joined #wesnoth-dev
20160807 16:54:01-!- iceiceice [~chris@50.245.222.235] has quit [Changing host]
20160807 16:54:01-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20160807 17:04:08-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has joined #wesnoth-dev
20160807 17:08:16< vultraz> wedge009: since you're on windows, could you do a test of https://github.com/wesnoth/wesnoth/pull/738/files when you have time
20160807 17:08:40< vultraz> (and perhaps a non-windows person should also test it)
20160807 17:08:44-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 17:09:10< celticminstrel> I'll consider it.
20160807 17:09:49< celticminstrel> ...wait, no I won't. It changes nothing for non-Windows people.
20160807 17:10:08< celticminstrel> Oh, hold on, it does change the three calls to pango_cairo_show_layout.
20160807 17:10:25< celticminstrel> BTW, what's with the removal of a blank line at the end?
20160807 17:10:51< vultraz> nothing, just a removal of a blank line.
20160807 17:10:56< celticminstrel> Oh, never mind, that ifdef was reversed, so it again only affects Windows.
20160807 17:11:25< vultraz> well, not exactly, since cairo_font_options_set_antialias is now called on all platforms
20160807 17:12:04< celticminstrel> I'm guessing that's a vacuous call though.
20160807 17:12:12-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160807 17:14:43< vultraz> alright
20160807 17:14:53< vultraz> well I still want another windows user to test it.
20160807 17:19:25-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20160807 17:24:35< vultraz> huh, looks like gfgtdf already ran the same test as I did
20160807 17:29:43-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160807 17:32:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160807 17:32:07-!- wedge010 is now known as wedge009
20160807 17:34:21-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 17:35:23-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160807 17:37:09< irker903> wesnoth: Charles Dang wesnoth:master 9c683576d951 / / (7 files in 5 dirs): Added GUI2 Unit List dialog (unused yet) https://github.com/wesnoth/wesnoth/commit/9c683576d951d857441e71c7fc044a293069c0e6
20160807 17:37:42< vultraz> unused because of a shitty GUI2 issues
20160807 17:37:54< vultraz> can't have more than 1 image per image widget
20160807 17:40:24< celticminstrel> Stack.
20160807 17:40:41< celticminstrel> (Wait, why do you need more than one in this case?)
20160807 17:42:02< vultraz> the dialog uses status icons 
20160807 17:43:10< celticminstrel> And ~BLIT() won't work?
20160807 17:43:24-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160807 17:44:04< vultraz> hmm
20160807 17:44:21< vultraz> hadn't thought of that, but then I need a blank image at least the size of 4 icons
20160807 17:44:24< vultraz> wich I don't like
20160807 17:44:26< vultraz> which
20160807 17:44:47< celticminstrel> Yeah, okay.
20160807 17:45:06< celticminstrel> Tad keeps replying to my comments, heh.
20160807 17:45:20< vultraz> I wanted to add something where you can blit onto a generated blank surface
20160807 17:45:24< vultraz> but i never got to it
20160807 17:46:56< vultraz> I wonder how hard that would be
20160807 17:48:32< celticminstrel> Creating a new surface of a given size is pretty easy.
20160807 17:50:49< irker903> wesnoth: Jyrki Vesterinen wesnoth:fade-out-music f87f09a341f9 / / (4 files in 3 dirs): Fade out previous music on playing new storyscreen music https://github.com/wesnoth/wesnoth/commit/f87f09a341f967466725174f9118b3f51c6b7206
20160807 17:56:55< JyrkiVesterinen> vultraz: PR719 implements now everything you asked explicitly. You may merge it if you don't need more changes.
20160807 17:58:10< vultraz> celticminstrel: any objections?
20160807 18:09:23< JyrkiVesterinen> vultraz: I fetched and compiled the ttext_tweaks branch, and I personally consider it a huge improvement.
20160807 18:09:31< vultraz> oh?
20160807 18:09:44< JyrkiVesterinen> I have disabled font smoothing in Windows preferences: I prefer fully aliased rendering.
20160807 18:09:46-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 18:09:47< travis-ci> wesnoth/wesnoth#10208 (master - 9c68357 : Charles Dang): The build was broken.
20160807 18:09:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150452751
20160807 18:09:47-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 18:10:08< JyrkiVesterinen> In ttext_tweaks branch, Wesnoth respects that preference. Nearly all text is aliased. :)
20160807 18:11:31< vultraz> ahh
20160807 18:11:34< vultraz> this is a good thing
20160807 18:12:21< celticminstrel> To the fading? I didn't really look closely, but I have nothing against the idea.
20160807 18:12:32< vultraz> ok
20160807 18:12:32< celticminstrel> You presumably forgot to add your new dialog to the tests.
20160807 18:12:42< vultraz> I did add it :/
20160807 18:12:53< celticminstrel> Then something else went wrong?
20160807 18:12:56< irker903> wesnoth: Jyrki Vesterinen wesnoth:master d4e6d0bf2b9b / changelog data/core/macros/sound-utils.cfg players_changelog src/sound.cpp: Fade out music on scenario start and on disabling it https://github.com/wesnoth/wesnoth/commit/d4e6d0bf2b9bff1c748920167eec0d0ed334364f
20160807 18:12:58< irker903> wesnoth: Jyrki Vesterinen wesnoth:master f87f09a341f9 / / (4 files in 3 dirs): Fade out previous music on playing new storyscreen music https://github.com/wesnoth/wesnoth/commit/f87f09a341f967466725174f9118b3f51c6b7206
20160807 18:13:00< irker903> wesnoth: Charles Dang wesnoth:master 413443ca3d35 / / (6 files in 4 dirs): Merge pull request #719 from wesnoth/fade-out-music https://github.com/wesnoth/wesnoth/commit/413443ca3d358d3bd450fab79867f47e83caa76f
20160807 18:14:22< vultraz> unused parameter
20160807 18:14:33< celticminstrel> Ah.
20160807 18:14:51< celticminstrel> Probably not worth fixing then if the parameter is going to be used in a later commit.
20160807 18:15:05< celticminstrel> Unless of course that later commit isn't expected for several days.
20160807 18:15:47< vultraz> eh, I had commented out some code that I probably want uncommented
20160807 18:15:49< vultraz> I shall do so
20160807 18:17:54< irker903> wesnoth: Charles Dang wesnoth:master 75aad9c350c5 / src/gui/dialogs/unit_list.cpp: tunit_list: fixed unused parameter https://github.com/wesnoth/wesnoth/commit/75aad9c350c53e422580209505cdd93c9cfba2cd
20160807 18:19:35< irker903> wesnoth: Charles Dang wesnoth:master c91b200b7a10 / src/text.cpp: ttext: tweaks to rendering, especially on Windows https://github.com/wesnoth/wesnoth/commit/c91b200b7a10bf82fb13417a1267fcdf0fc4b2c1
20160807 18:19:38< irker903> wesnoth: Charles Dang wesnoth:master 25fb5393780c / src/text.cpp: Merge pull request #738 from Vultraz/ttext_tweaks https://github.com/wesnoth/wesnoth/commit/25fb5393780c2cca1dc39e65db01a9fc882a88c5
20160807 18:20:08< celticminstrel> I thought you wanted wedge009 to test that first.
20160807 18:20:17< vultraz> any windows user was fine
20160807 18:20:36< celticminstrel> Oh, so JyrkiVesterinen tested it, I guess.
20160807 18:20:41< vultraz> I had forgotten about JyrkiVesterinen 
20160807 18:21:04< vultraz> brb restarting router
20160807 18:21:14< celticminstrel> You shouldn't forget about him. Besides zookeeper, he's the only one on MSVC 2013.
20160807 18:21:33< JyrkiVesterinen> Hey, just call me with my first name. I don't want to feel that distant.
20160807 18:22:02< JyrkiVesterinen> (I have also set both my IRC clients to notify me even if only my first name is mentioned.)
20160807 18:22:07< zookeeper> using just the first name takes 5 keypresses, using the whole takes only 3 :p
20160807 18:22:26< celticminstrel> Jyrki: It's just easier to type jyr<tab> to complete the name. :P But I'll try to type out the extra two letters. (Pretty sure I sometimes have already.)
20160807 18:22:39< celticminstrel> Yeah, jy<tab> works too, true.
20160807 18:22:41-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 18:23:23-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 18:23:34-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 18:23:52< irker903> wesnoth: Charles Dang wesnoth:master bd189c5e15cb / changelog: Changelog entry for c91b200b7a10 https://github.com/wesnoth/wesnoth/commit/bd189c5e15cb25580c636d2e9e3f73fd52f8953c
20160807 18:24:45< vultraz> always interesting when IRC manages to maintain a connection through router reboots
20160807 18:25:21< zookeeper> yeah it's pretty cool
20160807 18:27:56< celticminstrel> I've seen it maintain connection when disabling and re-enabling wireless.
20160807 18:29:27-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160807 18:40:53-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160807 18:46:35-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160807 18:47:40-!- DeFender1031 [~DeFender1@46-116-114-128.bb.netvision.net.il] has joined #wesnoth-dev
20160807 18:50:26-!- Kwandulin [~Miranda@p200300760F314EFAED353012C0489B1D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160807 18:51:08-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160807 19:03:43-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 19:03:44< travis-ci> wesnoth/wesnoth#10210 (master - 413443c : Charles Dang): The build is still failing.
20160807 19:03:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150457989
20160807 19:03:44-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 19:07:46-!- Kwandulin [~Miranda@p200300760F314EFAED353012C0489B1D.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160807 19:28:05-!- travis-ci [~travis-ci@ec2-54-226-124-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 19:28:06< travis-ci> wesnoth/wesnoth#10211 (master - 75aad9c : Charles Dang): The build was fixed.
20160807 19:28:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150458668
20160807 19:28:06-!- travis-ci [~travis-ci@ec2-54-226-124-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 19:32:35< celticminstrel> Took forever, but I finally finished reviewing Tad's HTTT stuff.
20160807 19:37:50< zookeeper> i didn't do it yet because... they all have all the same stuff according to the commit list
20160807 19:42:09< zookeeper> i presume he's going to fix it or something
20160807 19:43:22< celticminstrel> You could review just the HTTT Errors one and ignore the rest for the time being?
20160807 19:47:18< zookeeper> well it's still 41 commits...
20160807 19:47:39< celticminstrel> True.
20160807 19:48:03-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160807 19:53:44-!- ancestral [~ancestral@209.181.254.220] has joined #wesnoth-dev
20160807 19:56:57-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 19:56:59< travis-ci> wesnoth/wesnoth#10212 (master - 25fb539 : Charles Dang): The build was fixed.
20160807 19:56:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150458844
20160807 19:56:59-!- travis-ci [~travis-ci@ec2-54-158-174-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 20:00:37-!- JyrkiVesterinen [~JyrkiVest@78-27-104-3.bb.dnainternet.fi] has quit [Quit: .]
20160807 20:01:30-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160807 20:07:40-!- mjs-de [~mjs-de@x4db65744.dyn.telefonica.de] has joined #wesnoth-dev
20160807 20:08:30< zookeeper> if this is accurate (and not just due to a missing result=) then that seems like a problem in [endlevel]: https://forums.wesnoth.org/viewtopic.php?p=599883#p599883
20160807 20:08:45< zookeeper> maybe
20160807 20:11:59< celticminstrel> That Lua message is printed if wesnoth.check_end_level_disabled() returns true...
20160807 20:13:03< celticminstrel> The API function forwards to play_controller::is_regular_game_end...
20160807 20:13:48< celticminstrel> Which is the same function used when determining whether the end level data is available in wesnoth.get_end_level_data.
20160807 20:13:52< celticminstrel> Hmm...
20160807 20:14:21< celticminstrel> And wesnoth.end_level also does nothing if it's true...
20160807 20:14:33< celticminstrel> This is kind of ridiculous.
20160807 20:14:44< celticminstrel> Hmmm...
20160807 20:15:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160807 20:16:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160807 20:18:41< celticminstrel> I think I can see a way to fix this.
20160807 20:19:13< celticminstrel> Basically, [endlevel] shouldn't be doing nothing if the level has already ended, right?
20160807 20:19:51< celticminstrel> If the level has already ended, it should override previous settings.
20160807 20:19:58< celticminstrel> Except result, probably.
20160807 20:20:55-!- travis-ci [~travis-ci@ec2-54-226-124-25.compute-1.amazonaws.com] has joined #wesnoth-dev
20160807 20:20:56< travis-ci> wesnoth/wesnoth#10213 (master - bd189c5 : Charles Dang): The build was fixed.
20160807 20:20:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/150459442
20160807 20:20:56-!- travis-ci [~travis-ci@ec2-54-226-124-25.compute-1.amazonaws.com] has left #wesnoth-dev []
20160807 20:21:15< zookeeper> well if you use [endlevel] in a victory event, i'd be inclined to say it should just completely supercede the previous one
20160807 20:21:23< zookeeper> even if it has result=defeat
20160807 20:21:38< celticminstrel> Not quite sure if I can do that as easily as the rest.
20160807 20:21:54< celticminstrel> And it would mean that both victory and defeat are fired, which seems weird to me.
20160807 20:22:54< zookeeper> it seems a very niche usecase and if anyone relied on that kind of behavior i'd give them a weird stare
20160807 20:23:15< celticminstrel> What the heck is all this logic about in [endlevel]...
20160807 20:23:25-!- ancestral [~ancestral@209.181.254.220] has quit [Quit: i go nstuf kthxbai]
20160807 20:23:35< zookeeper> but, all the other attributes should replace the ones of previous calls
20160807 20:24:10< celticminstrel> I don't really know if this logic would be necessary for subsequent calls, so I guess I'll just leave it in.
20160807 20:25:11< iceiceice> celticminstrel, there was some wierd stuff i remember about endlevel,
20160807 20:25:25< iceiceice> i think it was added for compatibility reasons
20160807 20:25:36< iceiceice> basically when [endlevel] is read the level doesn't end immediately
20160807 20:25:43< iceiceice> you read at least to the end of the event queue
20160807 20:26:02< iceiceice> i dont remember if a scenario can be "resurrected" after [endlevel]
20160807 20:26:14< iceiceice> it can be resurrected from "time over", i remember that
20160807 20:26:40< iceiceice> like basically, if there is an event that is registered to the "time is up" event, that adds more turns for the player to try to complete the mission, the scenario continues
20160807 20:26:43< zookeeper> i don't recall ever seeing a resurrection like that. from time over, it makes sense.
20160807 20:26:50< celticminstrel> iceiceice: The logic I'm referring to seems to be something about figuring out carryover stuff.
20160807 20:26:59< celticminstrel> Also whether to set proceed_to_next_level.
20160807 20:27:23< iceiceice> yeah as i recall its sort of a mess
20160807 20:27:42< celticminstrel> Looks like the carryover data needs to be updated in the actual team object.
20160807 20:27:55< iceiceice> end of scenario is pretty complicated. there's all this stuff about, any units on the map need to get moved into recall list
20160807 20:28:01< iceiceice> and this happens basically before linger mode
20160807 20:28:17< celticminstrel> But linger mode still shows the units.
20160807 20:28:21< iceiceice> but somehow once in the linger mode, it still shows the units
20160807 20:28:25< iceiceice> yeah i think thats because of some strange hack
20160807 20:28:33< iceiceice> if you save the game while in linger mode and reload though,
20160807 20:28:36< iceiceice> sometimes you get interesting results
20160807 20:29:00< iceiceice> also it might have changed in the year + of dev since my info was current
20160807 20:29:06< celticminstrel> I remember at one point saving and reloading at that point cancelled linger mode and allowed further moves to be made. I think that was fixed though.
20160807 20:30:32< iceiceice> celticminstrel, i think there is a unit test related to, what happens if WML calls [endlevel] like 50 times
20160807 20:30:36< iceiceice> but i dont remember what is supposed to happen
20160807 20:30:48< zookeeper> welll... still all things considered, linger mode remains one of the great additions to the game :P
20160807 20:31:05< iceiceice> yeah its clearly needed
20160807 20:31:15< iceiceice> but the implementation leaves something to be desired :p
20160807 20:32:03< zookeeper> it was really annoying back in the day before it existed. had to perform all the ending ceremonies in MP matches before killing the enemy leader, etc.
20160807 20:32:31< celticminstrel> Ending ceremonies?
20160807 20:33:00< zookeeper> you know, the things people say and comment at the end of matches.
20160807 20:33:20< celticminstrel> Ah.
20160807 20:34:32< iceiceice> zookeeper, i'm not sure it actually works right now in mp though
20160807 20:34:45< iceiceice> because the server handles linger mode games a bit strangely
20160807 20:35:22< zookeeper> eh?
20160807 20:35:22< iceiceice> i guess it works for the final words
20160807 20:35:27< iceiceice> i remember having some strange experiences like,
20160807 20:35:40< iceiceice> if the game is in linger mode and the host leaves,
20160807 20:35:46< iceiceice> the server sends a message "the game has ended"
20160807 20:35:58< iceiceice> and any remaining observers / the other player will still be in the game,
20160807 20:36:05< iceiceice> but they will get chat messages corresponding to the lobby
20160807 20:36:58< zookeeper> urgh. that's not good.
20160807 20:38:03< celticminstrel> I should probably test this, any suggestions?
20160807 20:38:09< celticminstrel> (The endlevel change, I mean.)
20160807 20:39:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160807 20:40:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160807 20:40:25< zookeeper> iceiceice, any chance you could be persuaded to add a bugreport about that?
20160807 20:40:48< iceiceice> maybe
20160807 20:40:52< iceiceice> i dont think i reported it ever
20160807 20:40:56-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 20:41:20< iceiceice> i would want to test agian though, i dont remember when i last saw that
20160807 20:41:31< iceiceice> i think it has affected all versions of wesnoth that i remember
20160807 20:41:40< Ravana_> I thought it was intentional, to let people know that server thinks they are in lobby already
20160807 20:41:40< iceiceice> not sure though
20160807 20:42:03< iceiceice> Ravana_, i think ideally the server would keep the game running as like a private chat room
20160807 20:42:10< iceiceice> since it actually has support for chat rooms
20160807 20:42:12< Ravana_> though, it only happens when host leaves through end game
20160807 20:42:16< Ravana_> usually they just exit
20160807 20:42:25< celticminstrel> I don't think loonycyborg reimplemented chat rooms yet.
20160807 20:42:43< celticminstrel> Which, come to think of it, probably should have been done before releasing. Oh well.
20160807 20:43:17< iceiceice> i mean in linger mode the server doesn't need to write any more data to the game log
20160807 20:43:22< iceiceice> there doesn't even really need to be a host
20160807 20:43:26< zookeeper> yeah linger mode could arguably be treated as it everyone was in the lobby already (i don't think it _sounds_ like a good idea though), but it should have nothing to do with the host leaving
20160807 20:43:54< iceiceice> the only messages the players send while in linger mode are like
20160807 20:43:56< iceiceice> chat messages
20160807 20:44:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160807 20:44:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160807 20:44:04< iceiceice> or, "time for next scenario of campaign"
20160807 20:44:31< iceiceice> but i guess it would take extra logic to support a no-host mode
20160807 20:44:50-!- oldlaptop [~quassel@50.36.241.195] has quit [Ping timeout: 250 seconds]
20160807 20:46:56< celticminstrel> Hmm, come to think of it, I guess I don't really need to change [endlevel] quite this much - just make wesnoth.end_level work when the level has already ended and remove the same check from [endlevell].
20160807 20:46:57-!- oldlaptop [~quassel@50.36.241.195] has joined #wesnoth-dev
20160807 20:47:02< zookeeper> obviously i've not thought about it for long, but to me it seems like the ideal way to do it would be for the server to end the game (and save the replay) only when the last player actually leaves, so linger mode chat is included in replays and there's no weird lobby/lingermode blend.
20160807 20:47:13< celticminstrel> None of the logic of wesnoth.end_level relies on the level not having yet ended.
20160807 20:48:14< celticminstrel> It literally just replaces some data.
20160807 20:50:14< celticminstrel> Although...
20160807 20:50:32< celticminstrel> There's a difference between the two ways.
20160807 20:50:57< celticminstrel> If [endlevel] just forwards to wesnoth.end_level, then defaults will be used.
20160807 20:51:08< celticminstrel> If I do it the other way, then previously set values will be used.
20160807 20:51:55-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 20:52:23< celticminstrel> (That doesn't apply to everything though - end text, whether to show credits, carryover stuff other than whether to show the report, and next scenario are separate from the end level data and would not be reverted to default values.)
20160807 20:55:08-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 20:58:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160807 20:58:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160807 21:02:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160807 21:04:08-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160807 21:24:11-!- irker903 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160807 21:24:12< zookeeper> celticminstrel, WRT the endlevel thing, should at least check who changed it and why
20160807 21:24:24< celticminstrel> That's kinda hard.
20160807 21:24:28< celticminstrel> But I can try,
20160807 21:24:37< zookeeper> well what file is it?
20160807 21:24:56< celticminstrel> It's hard because I split [endlevel] from wml-tags.lua into wml/endlevel.lua at some point.
20160807 21:25:11< celticminstrel> I think I can blame from a specified commit somehow, though...
20160807 21:27:25< zookeeper> well the repeated execution message has been there since the beginning...
20160807 21:29:15-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160807 21:29:45< celticminstrel> The check and message was added in e73c57ea by iceiceice.
20160807 21:30:13< zookeeper> and then 91943451 added a lot of stuff which might be related
20160807 21:30:59< celticminstrel> Could be...
20160807 21:36:19-!- gfgtdf [~chatzilla@x4e368789.dyn.telefonica.de] has joined #wesnoth-dev
20160807 21:37:48< gfgtdf> celticminstrel: i in case of multiple [endlevel] the second endlevel was aleays ignores, in 1.12 it was maybe possible to use [endlevel] in a  victroey even if the sceanrio was not ended with [endlevel] (if it was ended by defeating all enemy leaders)
20160807 21:38:13< celticminstrel> Why should it be ignored?
20160807 21:38:59< celticminstrel> As far as I can see, all it does is set some data. I don't see any reason why you shouldn't be able to reset that data later.
20160807 21:40:03-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 21:40:28< gfgtdf> celticminstrel: well if you for examepl have two events, an 'attacker hits' event and a 'attack end' event, and both use [endlevel] independly form each other, then the idea its to use the endlevel that ended the scenario first. (here the one form the attack_hits event)
20160807 21:40:34< gfgtdf> celticminstrel: that just a guess though.
20160807 21:41:39< iceiceice> celticminstrel, why do you want to change it?
20160807 21:41:41< gfgtdf> celticminstrel: here the commit that introduced the ignoirn gbahviour found with git blame: https://github.com/wesnoth/wesnoth/commit/e79533dffd2184ae49fec25219385908e214802f
20160807 21:42:33< celticminstrel> gfgtdf: Already found that commit, thanks.
20160807 21:43:24-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20160807 21:43:58-!- Appleman1234 [~Appleman1@KD036012021004.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20160807 21:44:56< celticminstrel> To me it makes more sense for the last [endlevel] to take precedence.
20160807 21:45:29< zookeeper> i agree, _but_ if that's the way it's been since 1.10 then yeah maybe it's not worth changing. the wiki should totally mention it though.
20160807 21:45:36< celticminstrel> Oh, huh, that commit is different than I though... just happened to share a common prefix by coincidence...
20160807 21:46:17< zookeeper> however didn't you say the main problem was something about the standard firing of for example victory events messing with an [endlevel] in that victory event?
20160807 21:46:24< celticminstrel> I don't really get the explanation in that commit. How does it prevent recursion? Or did something significant change since then...
20160807 21:46:36< celticminstrel> I don't know what the main problem was.
20160807 21:47:36< celticminstrel> The disabled key added by commit e79533d no longer exists in master.
20160807 21:48:13< celticminstrel> I'm not sure how to use git blame to determine when something was deleted.
20160807 21:48:24< zookeeper> well, your forum post said that "[...]  or implicitly, which in victory/defeat events would always be the case"
20160807 21:49:09< celticminstrel> That might be an assumption on my part...
20160807 21:51:01< zookeeper> ok, well, if it's not an actually the problem, and aldarisvet had simply caused his victory event to fire by use of [endlevel] elsewhere, then there's much less of an issue
20160807 21:52:31 * zookeeper tests
20160807 21:52:55< celticminstrel> The code for firing the victory event assumes that the endlevel data is already set.
20160807 21:53:17< celticminstrel> This is slightly different from actually using [endlevel], but it's what [endlevel] checks for to see if it has been called before.
20160807 21:53:27< zookeeper> oh yeah it's a real bug
20160807 21:53:53< celticminstrel> What'd you do to test it?
20160807 21:56:31< zookeeper> just a scenario with nothing but a victory event that [endlevel]s; the contents are ignored
20160807 21:56:44< celticminstrel> Okay.
20160807 21:57:12< celticminstrel> So, should [endlevel] still be ignored if it has already been called once?
20160807 21:57:29< celticminstrel> But work in victory events as well?
20160807 21:57:30< zookeeper> unless someone has specifically eliminated [endlevel] use in victory events, i'd expect there to be broken scenarios in mainline due to that
20160807 21:57:55< zookeeper> i'm fine with it being ignored if it's already been called, but it has to work even in victory events if not previously called
20160807 21:58:01-!- lipkab [~the_new_l@host-91-147-210-58.biatv.hu] has quit [Quit: Leaving]
20160807 21:58:15< celticminstrel> I could do this with a file-local variable, I think.
20160807 21:58:26< celticminstrel> Lua state is destroyed between scenarios, so that should work.
20160807 21:59:17< celticminstrel> Doing it that way could still leave the way open for someone to directly call wesnoth.end_level to override previous data.
20160807 21:59:36< celticminstrel> Or wesnoth.get_end_level_data() and mutate the result.
20160807 22:00:15-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20160807 22:00:27< celticminstrel> I think neither of those functions are currently documented, actually.
20160807 22:00:37< celticminstrel> The latter certainly isn't.
20160807 22:02:12< zookeeper> i could be sympathetic to the limitation of "you can't call [endlevel] in a victory event" if it was due to some technical necessity and was documented appropriately, but i see nothing to that effect in the wiki so i must assume it's just a bug
20160807 22:02:32< celticminstrel> Yeah, pretty sure there's no technical necessity for it.
20160807 22:09:06< zookeeper> looks like discussions about [endlevel] in victory events have occurred a couple of times before in 2008-2009 :p
20160807 22:13:58< zookeeper> _if_ it turns out that it's hard to make it work right in victory events, we can of course just opt to clearly documenting the limitation.
20160807 22:14:40< celticminstrel> Testing now...
20160807 22:16:14-!- irker305 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160807 22:16:14< irker305> wesnoth: Spixi wesnoth:master 529b76854a26 / data/english.cfg: Beautified name generation https://github.com/wesnoth/wesnoth/commit/529b76854a26b4bbdbcd8db19be368e7e58b88d0
20160807 22:16:14< irker305> wesnoth: Charles Dang wesnoth:master 45ac2dc802bf / data/english.cfg: Merge pull request #739 from spixi/name_generator_beautification https://github.com/wesnoth/wesnoth/commit/45ac2dc802bf83ee16136a7c457edf56485a46ef
20160807 22:19:28-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 22:22:02< irker305> wesnoth: Gregory A Lundberg wesnoth:master 09e124aa8e0b / data/core/macros/items.cfg: Unique items: don't be a pig https://github.com/wesnoth/wesnoth/commit/09e124aa8e0b0fed5bfea02cb66a3ec0157a7c6e
20160807 22:22:04< irker305> wesnoth: Charles Dang wesnoth:master 7bfd1ab9732b / data/core/macros/items.cfg: Merge pull request #722 from GregoryLundberg/GL_unique_items https://github.com/wesnoth/wesnoth/commit/7bfd1ab9732b863a8301a0645bd49052b391e375
20160807 22:23:09< celticminstrel> Wesnoth is taking its time to start.
20160807 22:25:54< vultraz> so I discovered a rather nice use of utils::join from looking at gui1
20160807 22:26:11< celticminstrel> Oh?
20160807 22:26:19< vultraz> one can use it to construct comma-separated lists without a loop
20160807 22:26:36< celticminstrel> Yes... that's kinda what it's for...
20160807 22:26:49< vultraz> Perhaps
20160807 22:26:55< vultraz> But I had totally forgotten it existed
20160807 22:27:54-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 22:30:29-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has joined #wesnoth-dev
20160807 22:33:26< celticminstrel> Looks like this works.
20160807 22:33:54< celticminstrel> It does treat a missing result key as result=victory, so there might be unexpected results using [endlevel] in a loss event...
20160807 22:34:24< celticminstrel> Works fine in victory event though.
20160807 22:38:31< irker305> wesnoth: Charles Dang wesnoth:master 019361805268 / src/gui/widgets/unit_preview_pane.cpp: tunit_preview_pane: made use of utils::join for minimal labels https://github.com/wesnoth/wesnoth/commit/01936180526841299ce170e3fd4e8a9233dee327
20160807 22:41:26-!- Appleman1234 [~Appleman1@KD036012021048.au-net.ne.jp] has joined #wesnoth-dev
20160807 23:02:05-!- jamit [~jamit@97-87-12-18.dhcp.mdsn.wi.charter.com] has joined #wesnoth-dev
20160807 23:06:52-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160807 23:12:17-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 260 seconds]
20160807 23:13:25< celticminstrel> Okay, so I'm attempting to pull out the whole no_leader thing altogether.
20160807 23:13:30< celticminstrel> Not sure if this will work.
20160807 23:13:45-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20160807 23:15:49< celticminstrel> If one of the following things is true, the game should not attempt to generate a leader:
20160807 23:15:59< celticminstrel> 1. A type key is present.
20160807 23:16:07< celticminstrel> 2. A [leader] tag is present.
20160807 23:16:15< celticminstrel> 3. No faction key is present.
20160807 23:16:32< celticminstrel> I think that probably covers all cases...
20160807 23:16:55< vultraz> should *not* attempt?
20160807 23:16:58< celticminstrel> #3 could possibly instead be "faction is Custom".
20160807 23:17:02< celticminstrel> Yeah.
20160807 23:17:20< celticminstrel> Basically, it shouldn't generate a leader if there already is one.
20160807 23:17:33< celticminstrel> And it shouldn't generate a leader for the custom faction.
20160807 23:17:46< celticminstrel> I think.
20160807 23:19:43< celticminstrel> Maybe the MP survival scenario would be a good test case for a factionless, leaderless side...
20160807 23:20:32-!- Greg-Boggs [~greg_bogg@host-200-188.pubnet.pdx.edu] has quit [Remote host closed the connection]
20160807 23:27:28< celticminstrel> GUI2 grids are incomprehensibly rigid. ><
20160807 23:27:45< vultraz> #JustGUI2Things
20160807 23:27:48< vultraz> what are you trying to do
20160807 23:28:12< celticminstrel> Just remove a single cell from a grid.
20160807 23:28:40-!- mjs-de [~mjs-de@x4db65744.dyn.telefonica.de] has quit [Remote host closed the connection]
20160807 23:28:47< celticminstrel> Seems to be a 2x2 grid.
20160807 23:28:48< vultraz> where?
20160807 23:29:04< vultraz> you need to swap that cell with something, I think
20160807 23:29:17< vultraz> or hide it
20160807 23:29:19< celticminstrel> I wonder if removing the assert will cause problems. Otherwise yeah, that.
20160807 23:30:07< vultraz> it's funny
20160807 23:30:17< celticminstrel> Apparently it does cause problems - other things that should be in the missing column are ignored.
20160807 23:30:19< vultraz> I used to think GUI1 was so horrible for allowing explicit distances
20160807 23:30:32< vultraz> then I used anura and I realized how good that can be
20160807 23:31:22< celticminstrel> If we replace GUI2 it should be with something lightweight that doesn't require configuration files.
20160807 23:31:42< vultraz> anuuurraaaaa
20160807 23:31:46< celticminstrel> (So that we can adapt the existing GUI2 configuration files. Less work porting to the new system.)
20160807 23:32:37< celticminstrel> Swing was pretty great when I used it, maybe there's a C++ GUI modelled after it.
20160807 23:32:39< vultraz> what ended up happening with AA and W2 is the UI is all made up of objects
20160807 23:32:59< vultraz> certain objects take the form of gui widgets 
20160807 23:33:18-!- hay207 [~hay207@41.34.52.87] has quit [Ping timeout: 276 seconds]
20160807 23:33:18< vultraz> so you want a button you spawn a button object
20160807 23:33:39< vultraz> i think this is especially interesting since it doesn't rely on third party GUI systems.
20160807 23:33:46-!- hay207 [~hay207@41.34.13.116] has joined #wesnoth-dev
20160807 23:33:47< celticminstrel> Mind you, I said lightweight, but we do want layout managers.
20160807 23:33:59< celticminstrel> Because the screen is of unknown size.
20160807 23:34:19< vultraz> the UI is part of the core system itself
20160807 23:34:34< celticminstrel> So is GUI2, technically.
20160807 23:34:37< Aginor> 11:32 < celticminstrel> Swing was pretty great when I used it, maybe there's a  C++ GUI modelled after it.
20160807 23:34:42< Aginor> QT ;)
20160807 23:34:47< vultraz> nnuuuuuuuuuuuuuuu
20160807 23:34:50< vultraz> not QT :(
20160807 23:34:53< Aginor> it would seriously do all we need
20160807 23:34:55< celticminstrel> That's the furthers you can possibly get from lightweight.
20160807 23:34:58< celticminstrel> ^furthest
20160807 23:35:02< vultraz> it's too heavy!
20160807 23:35:09< Aginor> bah
20160807 23:35:13< celticminstrel> qt isn't just a GUI, it reimplements half the standard library too.
20160807 23:35:52< Aginor> by the time we we can have qt apps that are more responsive on a gumstix pc than GUI2 in wesnoth I think that argument about heavy vs lightweight is rubbish
20160807 23:35:52< celticminstrel> Things like strings or (guessing here) files.
20160807 23:36:08< Aginor> yeah, it's a whole ecosystem
20160807 23:36:14< celticminstrel> (I also don't like that it requires an extra build step.)
20160807 23:36:15< Aginor> which is not really what we want
20160807 23:36:59< celticminstrel> vultraz: What was the empty widget type called again?
20160807 23:37:06< vultraz> spacer
20160807 23:38:12< Aginor> we might have some success with wx or somesuch framework otherwise
20160807 23:39:12< celticminstrel> I don't think a full GUI sytem like wx is what we need. We want a more game-oriented GUI system, where everything is done within the main window.
20160807 23:39:30< vultraz> As much as GUI2 is evil and obscure and should be purged from existence, I dunno if replacing it is worth the effort
20160807 23:39:39< Aginor> celticminstrel: but that's not what we do though
20160807 23:39:41< vultraz> Let W2 have the better GUI
20160807 23:39:47< celticminstrel> Why is the ERA_HEROES macro defined twice?
20160807 23:39:47< Aginor> celticminstrel: we have dialogs all over the place
20160807 23:40:00< celticminstrel> Aginor: But they're all in the main window.
20160807 23:41:03< vultraz> at some point you have to stop and realize it isn't worth it.
20160807 23:41:32< Aginor> celticminstrel: that's just the application style though
20160807 23:41:35< vultraz> especially if you insist on compatibility with existing layout files.
20160807 23:41:46< Aginor> wesnoth is basically and MDI application
20160807 23:42:21< celticminstrel> No, it's not multiple-document interface at all.
20160807 23:43:00< celticminstrel> ...well, I suppose the map editor could be called that.
20160807 23:43:19< vultraz> the simple fact is we can't implement something better than gui2 AND keep compatibility 
20160807 23:44:12< celticminstrel> Not true.
20160807 23:44:54< vultraz> and if we're gonna rip out gui2 and NOT keep compatibility, then let's go all the way and reimplement BfW in Anura.
20160807 23:45:21< Aginor> vultraz: nobody is stopping you
20160807 23:45:43< celticminstrel> It's totally possible to replace GUI2 with something better and still maintain compatibility.
20160807 23:46:00< vultraz> Aginor: the plan is to do so eventually anyway
20160807 23:46:02< celticminstrel> Maintaining compatibility primarily means reading the same GUI2 configuration files to define dialogs
20160807 23:46:16< celticminstrel> Your plan, sure. No-one else's, as far as I know.
20160807 23:46:47< vultraz> I don't think it's viable to as a *replacement*
20160807 23:46:50< vultraz> As I've said before
20160807 23:47:00< vultraz> Nor worth it
20160807 23:47:36< vultraz> Erasing W1's current state from existence means destroying too much work by UMC people
20160807 23:47:59< vultraz> It's like if Bethedsa replaced all copies of Morrowind with Skywind.
20160807 23:48:17< vultraz> Sure, Skywind looks better, but all the Morrwind mods wouldn't work anymore.
20160807 23:48:27< celticminstrel> Skyrim, you mean.
20160807 23:48:36< vultraz> No
20160807 23:48:48< Aginor> vultraz: you're contradicting yourself
20160807 23:49:04< vultraz> Skywind is a project by people not affiliated with Bethedsa to design Morrowind in Skyrim's engine.
20160807 23:49:17< celticminstrel> Weird.
20160807 23:49:31< vultraz> Apparently people have worked years on it for no pay.
20160807 23:49:44< celticminstrel> Morrowind still works, doesn't it?
20160807 23:49:54< vultraz> As its own game, yes.
20160807 23:49:56< celticminstrel> If it was like Riven where the original no longer runs, I could understand it...
20160807 23:50:19< vultraz> Dunno exactly how Skywind is supposed to run.
20160807 23:50:28< vultraz> I think it piggybacks off a Skyrim install.
20160807 23:51:02< TC01> (Skywind is a skrim mod that reads Morrowind assets, and imports them into Skyrim. you need both in order to use it, because they can't legally redistribute morrowind assets)
20160807 23:51:08< celticminstrel> Hmm. Why did side_.has_child("leader") return false...
20160807 23:51:26 * celticminstrel notes that RivenX works the same way.
20160807 23:51:42 * celticminstrel except for not being a mod of some other engine.
20160807 23:52:41< vultraz> My point is it'd be less work for everyone to release Bfw: Special Edition in Anura than to do something like replace GUI2
20160807 23:52:52< vultraz> Especially since any system would also need to be grid-based.
20160807 23:52:58< vultraz> And read WML...
20160807 23:53:39< vultraz> It's not impossible
20160807 23:53:45< vultraz> It could be done if we really wanted to
20160807 23:53:53< vultraz> But I question if it's worth the effort.
20160807 23:53:58< vultraz> If it is, sure, let's do it.
20160807 23:54:21< vultraz> see my point?
20160807 23:54:34< celticminstrel> Oh, it did return true, but leader lock is false so it's going anyway...
20160807 23:54:42< celticminstrel> Hmm, what's leader lock really for, anyway?
20160807 23:54:46< vultraz> Aginor: how so?
20160807 23:54:53< celticminstrel> Maybe that can replace no_leader for MP purposes.
20160807 23:54:53< TC01> Is Wesnoth 2 going to be an officially sanctioned replacement to Wesnoth or simply another game in the same setting using a different engine made by some of the same people?
20160807 23:55:00< TC01> (or is this something still under discussion?)
20160807 23:55:07< celticminstrel> TC01: Supposedly it's supposed to be some sort of sequel/successor.
20160807 23:55:11< Aginor> vultraz: "the plan is to reimplement everything in anura" "we are not going to reimplement everything"
20160807 23:55:44< vultraz> Aginor: oh, yes, I should clarify.
20160807 23:56:17< vultraz> Aginor: dave and co want to eventually do a BfW clone after W2.
20160807 23:56:21< vultraz> in Anura.
20160807 23:56:45< vultraz> Aginor: what I'm trying to say here is I think such a thing is less effort than replacing the mess that is GUI2.
20160807 23:56:59< vultraz> Aginor: if that is not the case, then sure, let us replace GUI2
20160807 23:57:10< vultraz> (if we can agree on a replacement :P )
20160807 23:57:14< Aginor> they can do whatever they want though
20160807 23:57:19< Aginor> there's no stopping them
20160807 23:57:33< vultraz> Exactly.
20160807 23:57:37< Aginor> nor do I think we would want to
20160807 23:57:43< Aginor> but what they do don't affect us
20160807 23:57:47< celticminstrel> People wanting to make a clone of BfW has no bearing on the BfW project.
20160807 23:58:07< vultraz> I think the problem here is I look at this as connected projects.
20160807 23:58:16< vultraz> Game 1, game 2.
20160807 23:58:35< Aginor> I see them as completely unrelated things, apart from sharing some commonality in the name
20160807 23:58:43< celticminstrel> ^
20160807 23:58:47< vultraz> I would like them to become a series. 
20160807 23:59:12< Aginor> vultraz: I think that's a different goal from a lot of people here
20160807 23:59:12< celticminstrel> How do I activate leader lock?
20160807 23:59:17< vultraz> to answer TC01's question, it is *supposed* to be a sequel.
20160807 23:59:19< celticminstrel> Is it a [side] key or a scenario key?
20160807 23:59:21< celticminstrel> What's the key?
20160807 23:59:25< vultraz> no idea
--- Log closed Mon Aug 08 00:00:35 2016