--- Log opened Wed Aug 10 00:00:00 2016
--- Day changed Wed Aug 10 2016
20160810 00:00:00< celmin> It won't help.
20160810 00:00:27< celmin> Maybe it's not the 300px specifically that's the problem. I dunno if it reached 300px.
20160810 00:00:51< vultraz> SCREENSHOT!
20160810 00:00:59< vultraz> bring forth
20160810 00:01:02< vultraz> the SCREENSHOTS!
20160810 00:01:11< celmin> I'll get you one once I have the dialog fixed. There's at least one bug still.
20160810 00:05:59< celmin> Okay, so there is indeed a topic on advancement.
20160810 00:06:24< celmin> The help text is cut off...
20160810 00:13:14< vultraz> OK
20160810 00:13:21< vultraz> just need to add SORTING
20160810 00:13:26< vultraz> and im done
20160810 00:15:43< celmin> I have no idea why this shaman has ambush.
20160810 00:18:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160810 00:19:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160810 00:21:02< vultraz> hmmm
20160810 00:21:06< vultraz> but what.. do I sort on
20160810 00:21:10< vultraz> I don't have a table this time :|
20160810 00:22:28< celmin> I have no idea what you're working on
20160810 00:22:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160810 00:24:06< vultraz> celmin: https://drive.google.com/file/d/0B-mR9s8FduLLV2FoV29mV1JtLUE/view?usp=sharing
20160810 00:24:42< vultraz> (that cutoff is a listbox bug that I've raised to blocker for the next release)
20160810 00:25:24< celmin> I thought you said you don't have a table.
20160810 00:25:37< vultraz> I don't have a simple vector...
20160810 00:25:44< celmin> What do you have?
20160810 00:25:54< vultraz> I'm thinking I'll need to filter on board_.teams()[i].element :|
20160810 00:26:13< vultraz> celmin: the bare teams...container.
20160810 00:26:18< vultraz> (dunno if it's a vector)
20160810 00:26:26< celmin> Does it matter if it's a vector?
20160810 00:26:59< vultraz> no
20160810 00:27:10< celmin> I don't see your issue here. Obviously the sorting applies to teams, so use the teams array, right?
20160810 00:27:27< celmin> Or is the problem that your sorting mutates the array?
20160810 00:27:41< vultraz> the data is processed before being displayed
20160810 00:27:44< celmin> (Which you can't do if you're using the teams array.)
20160810 00:27:46< celmin> Huh?
20160810 00:27:58< vultraz> for example
20160810 00:27:59< vultraz> through utils::signed_value
20160810 00:28:05< celmin> Huh?
20160810 00:28:07< vultraz> or utils::half_signed_value
20160810 00:28:17< celmin> What are you talking about now?
20160810 00:28:52< vultraz> The raw data in the teams array might be different from what's displayed in the table
20160810 00:29:27< celmin> You probably want to sort on the raw data, not the formatted data.
20160810 00:29:35< celmin> Unless you've actually performed calculations.
20160810 00:29:45< vultraz> eh, I'll try and see how it goes
20160810 00:32:07< celmin> vultraz: Why are traits and abilities shown one per line instead of comma-separated?
20160810 00:32:34< vultraz> they are comma-seperated
20160810 00:32:52< celmin> I'm looking at it now, they're clearly one per line...
20160810 00:33:03< vultraz> oh
20160810 00:33:10< celmin> In the advance dialog's unit preview pane.
20160810 00:33:13< vultraz> right
20160810 00:33:18< vultraz> stylistic choice
20160810 00:33:22< celmin> I don't like it.
20160810 00:33:50< vultraz> Why?
20160810 00:33:52< vultraz> :|
20160810 00:33:56< celmin> Takes up a lot more space.
20160810 00:34:21< vultraz> it could get too long, horizontally, otherwise
20160810 00:35:21< vultraz> it;s also consustent with the old preview pane
20160810 00:35:23< vultraz> consistent
20160810 00:35:51< celmin> I have the old advance dialog open right now, too. They're comma-separated.
20160810 00:36:22< vultraz> the hell?
20160810 00:36:24< vultraz> screenshot
20160810 00:37:40< celmin> For the old one, try it yourself?
20160810 00:37:55< celmin> http://celmin.pwcsite.com/wesnoth/unit_advance.tiff
20160810 00:38:35< vultraz> oh god that layout :|
20160810 00:38:40< celmin> What?
20160810 00:38:41< vultraz> scrollbars
20160810 00:38:43< vultraz> everywhere
20160810 00:38:46< celmin> Oh, yeah.
20160810 00:39:50< celmin> I don't seriously need to give you a screenshot of the old advance dialog for comparison, do I?
20160810 00:39:53< vultraz> your text rendering is still nicer than mine :(
20160810 00:39:57< vultraz> celmin: no, I have it
20160810 00:40:01< celmin> 'kay
20160810 00:40:04< vultraz> yes, I see what you mean
20160810 00:40:06< vultraz> ...
20160810 00:40:09< vultraz> I shall consider this
20160810 00:40:14< celmin> I'm going to push this now.
20160810 00:40:22< celmin> Unless you have objections or comments or anything.
20160810 00:40:45< vultraz> I shall of course do some layout tweaks
20160810 00:40:58< celmin> I was expecting you to.
20160810 00:42:07< celmin> Once I push this I need to make supper.
20160810 00:42:26< vultraz> ugly c++ Line of the Day
20160810 00:42:28< vultraz> std::string name = (*board_.units().find_leader(board_.teams()[i].side()).get_shared_ptr()).name();
20160810 00:44:16< vultraz> ugh
20160810 00:44:33-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160810 00:44:36< vultraz> some of the raw data needs to come from calculate_team_data
20160810 00:44:41< vultraz> in display_context
20160810 00:44:47< vultraz> will need to find a better way to do this
20160810 00:45:53< vultraz> because this is a ridiculous way to count units.
20160810 00:46:11< vultraz> and income and upkeep
20160810 00:47:49< vultraz> so I can either set up a local vector of this data...
20160810 00:48:00< vultraz> yeah that's most efficient
20160810 00:48:43-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has joined #wesnoth-dev
20160810 00:49:24-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Ping timeout: 260 seconds]
20160810 00:50:03< irker747> wesnoth: Celtic Minstrel wesnoth:master a8477e3ce0fc / src/gui/ (7 files in 2 dirs): Use references instead of pointers in unit_preview_pane https://github.com/wesnoth/wesnoth/commit/a8477e3ce0fccfc7a31e3c468388e07a63ef183a
20160810 00:50:05< irker747> wesnoth: Celtic Minstrel wesnoth:master febb34cfbb62 / / (6 files in 5 dirs): Convert unit advancement dialog to GUI2 https://github.com/wesnoth/wesnoth/commit/febb34cfbb62342c09666e040999f2e3f54a2100
20160810 00:50:42< celmin> …oh right, I forgot to add it to tests. Oh well, I'll do that a bit later.
20160810 00:51:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160810 00:54:26< vultraz> else assert(false)?
20160810 00:54:28< vultraz> what?
20160810 00:54:30< vultraz> why
20160810 00:54:48< vultraz> why would you assert if someone canceled
20160810 00:54:51< celmin> There's no cancel button, so that code path should be impossible.
20160810 00:54:59< vultraz> ESC
20160810 00:55:17< celmin> Escape should be disabled.
20160810 00:55:26< vultraz> did you explicitly do so?
20160810 00:55:26< celmin> Not sure if I need to do something special for that though.
20160810 00:56:06< celmin> I did not.
20160810 00:56:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160810 00:56:40< vultraz> you need to call window.set_escape_disabled(true)
20160810 00:56:53< celmin> Okay.
20160810 00:57:06< celmin> I can do that when I update the tests, I guess?
20160810 00:59:34< vultraz> what in the world are you douing with this loop..
20160810 00:59:36< vultraz> doing
20160810 00:59:45< celmin> Which one?
20160810 01:00:01< vultraz> specifically the if(i >= real_) { part
20160810 01:00:04< vultraz> what even is real_
20160810 01:00:48< celmin> It's the number of sample units that resulted from taking a unit type advancement.
20160810 01:01:05< vultraz> sample units?
20160810 01:01:23< celmin> The advancement dialog is passed the list of possible advancement results, as a vector of units.
20160810 01:03:29< vultraz> what have you done
20160810 01:03:46< vultraz> you've made the game freeze when attacking :|
20160810 01:03:51< celmin> Eh?
20160810 01:04:04< vultraz> I try to attack, the game freezes
20160810 01:05:28< celmin> Is that my fault?
20160810 01:05:54< vultraz> hm
20160810 01:06:01< vultraz> reverting a8477e3ce0fc doesn't fix it..
20160810 01:06:21< celmin> Is that HEAD^^?
20160810 01:06:32< celmin> The unit preview references one
20160810 01:07:00< vultraz> second to latest commit
20160810 01:07:19< celmin> Okay, probably not my fault then.
20160810 01:07:52< vultraz> was working before I pulled your changes
20160810 01:07:58< vultraz> I pull your changes, and it stop working
20160810 01:08:23< celmin> So does reverting unit_advance fix it?
20160810 01:09:03< vultraz> testing
20160810 01:10:06< fabi__> hi
20160810 01:10:11< fabi__> hi
20160810 01:11:06< vultraz> hi
20160810 01:18:35< celmin> Well?
20160810 01:19:44< vultraz> it still seems broken...
20160810 01:19:54< vultraz> even if i revert
20160810 01:20:03< vultraz> can't do a hard reset since I have local changes
20160810 01:20:27< vultraz> let me get them committed
20160810 01:25:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160810 01:25:34< vultraz> Gonna use one case of resources::
20160810 01:31:40< vultraz> ok, only oneee more thing to do.
20160810 01:36:55< celmin> Just tried attacking, no freeze.
20160810 01:37:22< vultraz> P_P
20160810 01:52:01< vultraz> might use a goto for something
20160810 01:52:54< irker747> wesnoth: Charles Dang wesnoth:master bb49be8428d4 / / (10 files in 5 dirs): Convert Scenario Status/Settings dialog pair to GUI2 https://github.com/wesnoth/wesnoth/commit/bb49be8428d4226b7a6fa7343f0d45af4558c3ed
20160810 01:53:58< vultraz> er
20160810 01:54:00< vultraz> shit
20160810 01:54:10< vultraz> I might have ovewritten unit_advance's header
20160810 01:54:53< vultraz> yes..
20160810 01:54:55< vultraz> I appear to
20160810 01:54:57< vultraz> how
20160810 01:54:58< vultraz> ??
20160810 01:55:15< celmin> Not in your commit though.
20160810 01:55:29< vultraz> yes
20160810 01:55:30< vultraz> in my commit
20160810 01:55:36< celmin> I don't see it?
20160810 01:55:38< vultraz> look, it says it was renamed with the contents of mine
20160810 01:55:54< celmin> …oh
20160810 01:56:42< celmin> Shouldn't be hard to fix.
20160810 01:56:46< vultraz> lemme make sure it builds
20160810 01:56:50< vultraz> and ill repush the file
20160810 01:56:53< vultraz> don't push anything
20160810 01:57:06< celmin> Okay sure.
20160810 01:57:20< vultraz> might take awhile so ima run to the post office
20160810 02:01:37< irker747> wesnoth: Celtic Minstrel wesnoth:master 8a9a466a2989 / / (10 files in 5 dirs): Revert "Convert Scenario Status/Settings dialog pair to GUI2" https://github.com/wesnoth/wesnoth/commit/8a9a466a2989063a08dad53b127858e6f93074bb
20160810 02:01:39< irker747> wesnoth: Charles Dang wesnoth:master 79de5a8ae81e / / (9 files in 5 dirs): Convert Scenario Status/Settings dialog pair to GUI2 https://github.com/wesnoth/wesnoth/commit/79de5a8ae81ea00251f4479d31fa4418f9332d78
20160810 02:06:55< irker747> wesnoth: Celtic Minstrel wesnoth:master fbf87ca797e8 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/fbf87ca797e8e4cfc8a3b286975af40d60a909f6
20160810 02:07:44< celmin> Sorry, didn't want to wait while you ran to the post office.
20160810 02:08:15-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 02:08:16< travis-ci> wesnoth/wesnoth#10264 (master - bb49be8 : Charles Dang): The build is still failing.
20160810 02:08:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151099461
20160810 02:08:16-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 02:17:03< celmin> I'm going to do something with the failing unit test as well.
20160810 02:17:17< vultraz> back
20160810 02:19:03< irker747> wesnoth: Charles Dang wesnoth:master ebf90fbd94df / projectfiles/CodeBlocks/wesnoth.cbp: Update CB projectfile https://github.com/wesnoth/wesnoth/commit/ebf90fbd94dfef5225a133b9fe79c1e01014a939
20160810 02:22:30< vultraz> ok I can attack fine again
20160810 02:22:40< vultraz> something was scewed up with that particular savegame Iguess
20160810 02:40:21< irker747> wesnoth: Charles Dang wesnoth:master 5398980ac058 / / (4 files in 3 dirs): Unit Advance: some layout improvements, code cleanup and clarification, and a mi https://github.com/wesnoth/wesnoth/commit/5398980ac058aea0f3feb2e6b7aed713a6c4e2cb
20160810 02:40:22< vultraz> celticminstrel: ^
20160810 02:40:39< celmin> Gah!
20160810 02:41:01< celmin> Oh, whoops, I forgot to remove all the comments.
20160810 02:41:05< celmin> Commented headers I mean.
20160810 02:41:27< celmin> Why'd you join that into one line? I liked it split up.
20160810 02:41:36< celmin> Also I was in the middle fo doing stuff there.
20160810 02:41:55< celmin> The esc thing and stuff. I already did it.
20160810 02:42:06< celmin> I even said I'd do it.
20160810 02:42:18< vultraz> But you said you expected me to do layout cleanups
20160810 02:42:24 * celmin is referring to line 79 BTW.
20160810 02:42:29< vultraz> SO I figured I'd do it at once
20160810 02:42:32< celmin> Layout cleanups yes.
20160810 02:42:36< vultraz> celmin: much easier to read, IMO
20160810 02:42:37< celmin> Layout cleanups means the cfg, right?
20160810 02:42:45< vultraz> I couldn't figure out what it was doing at first
20160810 02:42:49< vultraz> and yes
20160810 02:42:57< vultraz> but I figured I'd save you the trouble
20160810 02:42:59 * celmin sigh.
20160810 02:43:11< celmin> Even though I said I would do it.
20160810 02:43:22< celmin> Well, I guess I delete that commit then.
20160810 02:43:41< celmin> Oh, I hadn't quite committed it yet.
20160810 02:43:54-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has quit [Quit: Konversation terminated!]
20160810 02:43:54< vultraz> now I shall go and add a goto statement
20160810 02:44:00< celmin> Please don't.
20160810 02:44:04< vultraz> :|
20160810 02:44:11-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has joined #wesnoth-dev
20160810 02:44:13< celmin> Why? Where?
20160810 02:44:34< vultraz> so the dialog actually involves two lists
20160810 02:44:38< vultraz> I have them stacked
20160810 02:44:48< vultraz> they both display team info
20160810 02:44:58< celmin> What?
20160810 02:45:07< vultraz> however, one of them had this check:
20160810 02:45:10< vultraz> // We don't spare more info (only name) so let's go on next side ...
20160810 02:45:12< vultraz> if(!known && !game_config::debug) {
20160810 02:45:13< vultraz> continue;
20160810 02:45:15< vultraz> }
20160810 02:45:23< vultraz> but in the GUI1 dialog, the *other* list did *not*
20160810 02:45:28< vultraz> Here, I fill out both lists in the same loop
20160810 02:45:53< vultraz> so using 'continue' prevents filling out the second list when only the first list should be restricted
20160810 02:46:12< vultraz> I guess I could put the stuff in functions
20160810 02:46:20< vultraz> or just an if block
20160810 02:46:36< celmin> What're the list names?
20160810 02:46:49< vultraz> what... does that have to do with anything
20160810 02:47:02< celmin> I guess stats_names and settings_names?
20160810 02:47:11< celmin> Sorry, list not names
20160810 02:48:12-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has quit [Ping timeout: 240 seconds]
20160810 02:48:33< vultraz> eh
20160810 02:48:35< vultraz> hm
20160810 02:48:42< vultraz> actually, my dialog seems bugged
20160810 02:48:43< celmin> I think inverting the condition and indenting some code would be better.
20160810 02:48:46< vultraz> it shows sides you shouldn't have info on..
20160810 02:50:04< vultraz> oh wait im in debug mode
20160810 02:50:34< vultraz> I thought it was supposed to display the sides as unknown..?
20160810 02:50:40 * vultraz checks 1.12
20160810 02:52:03< vultraz> yeah, they're supposed to be shown as Unknown..
20160810 02:53:39-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 02:53:40< travis-ci> wesnoth/wesnoth#10266 (master - fbf87ca : Celtic Minstrel): The build is still failing.
20160810 02:53:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151101098
20160810 02:53:40-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 02:54:37< vultraz> ah, got it
20160810 03:01:51< irker747> wesnoth: Charles Dang wesnoth:master ba6486eef442 / src/gui/dialogs/game_stats.cpp: tgame_stats: fixed a few issues with displaying unknown sides https://github.com/wesnoth/wesnoth/commit/ba6486eef442bbc960cfa4af05f90f8f4fa2343b
20160810 03:01:54< vultraz> Cleanly solves a bunch of issues without using goto :D
20160810 03:07:23< vultraz> celmin: do you mind if i remove utils/shared_object
20160810 03:07:25< vultraz> it's unused
20160810 03:07:29< celmin> What is it?
20160810 03:08:19< vultraz> I can't tell
20160810 03:10:35< vultraz> something with << and >> operators
20160810 03:12:13< celmin> Where do you get that idea from...
20160810 03:12:29< celmin> I get the impression that it's some sort of pointer/handle type thing, but not sure what it's for.
20160810 03:12:40< celmin> If it's unused, I don't think there's any reason to keep it around.
20160810 03:12:49< celmin> BTW, is the GUI1 unit preview pane still used anywhere?
20160810 03:13:02< celmin> In dialogs.?pp
20160810 03:13:24< vultraz> don't think so
20160810 03:13:28< vultraz> feel free to remove
20160810 03:23:45< vultraz> celmin: you can move animate_unit_advancement out of dialogs.cpp
20160810 03:24:24< celmin> That's obvious.
20160810 03:24:31< celmin> What's not obvious is where to move it to.
20160810 03:30:50< vultraz> what is this leader_scroll_dialog thing
20160810 03:30:52< vultraz> it's unused
20160810 03:31:13< celmin> Dunno.
20160810 03:31:26< celmin> Sounds potentially important though.
20160810 03:31:51< vultraz> but it's unused
20160810 03:32:02< celmin> So you said.
20160810 03:33:55-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 03:33:56< travis-ci> wesnoth/wesnoth#10268 (master - 5398980 : Charles Dang): The build is still failing.
20160810 03:33:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151104633
20160810 03:33:56-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 03:34:01< vultraz> celmin: should i not commit anything?
20160810 03:34:04< vultraz> are you working?
20160810 03:34:12< celmin> What?
20160810 03:34:24< celmin> I'm doing stuff, but probably not related to what you're doing.
20160810 03:34:30< celmin> I'm doing test stuff.
20160810 03:36:15< irker747> wesnoth: Charles Dang wesnoth:master 09b116c6a708 / src/menu_events.cpp: Removed some unused GUI1 code https://github.com/wesnoth/wesnoth/commit/09b116c6a708b31e9d63d620c92a6a30d4edc68a
20160810 03:40:40< vultraz> oh, that was used in the stuff I just removed
20160810 03:41:11< celmin> Huh?
20160810 03:41:50< vultraz> ah, it was the actual gui1 representation of the old status dialog
20160810 03:41:53< vultraz> so it is indeed useless
20160810 03:42:12-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160810 03:47:59< irker747> wesnoth: Charles Dang wesnoth:master 55b81f626443 / src/ (menu_events.cpp menu_events.hpp): Removed unused parameter from status_table() https://github.com/wesnoth/wesnoth/commit/55b81f62644339f73b57c1c9e7874d662827f434
20160810 03:50:04-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 03:50:05< travis-ci> wesnoth/wesnoth#10269 (master - ba6486e : Charles Dang): The build is still failing.
20160810 03:50:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151106835
20160810 03:50:05-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 03:50:40< irker747> wesnoth: Charles Dang wesnoth:master c09937674990 / src/ (menu_events.cpp menu_events.hpp): Removed some more unused code https://github.com/wesnoth/wesnoth/commit/c0993767499053098e35dd55b3597f9895638b8a
20160810 03:54:04< vultraz> statistics_dialog.*pp should be the next thing we convert
20160810 03:55:05< vultraz> I think that's the last "minor" GUI1 dialog
20160810 03:55:22< vultraz> Then there's just MP Create, Help, and the Addons Manager
20160810 03:55:35< celmin> MP create is really three dialogs. Maybe four?
20160810 03:55:46< celmin> I dunno how [option] is handled.
20160810 03:57:14< vultraz> true
20160810 03:57:35< vultraz> at least the Addons Manager is at least 70% done, though.
20160810 03:57:56< vultraz> oh
20160810 03:58:03< vultraz> let us not forget right click menus
20160810 03:58:20< celmin> Those are practically done already.
20160810 03:58:50< vultraz> the framework is there
20160810 03:59:00< vultraz> but it all needs to be brought together
20160810 03:59:08< celmin> The required dialog already exists.
20160810 03:59:37< vultraz> yes
20160810 03:59:48< vultraz> i seem to recall there was something that was needed, though...
20160810 03:59:50< vultraz> regardign clicks?
20160810 03:59:52< celmin> Not just right-click menus, BTW. Also the top menus, and submenus.
20160810 03:59:52< vultraz> perhaps not
20160810 03:59:55< celmin> I dunno.
20160810 03:59:56< celmin> Maybe?
20160810 04:00:22< celmin> If I recall correctly, aren't the menus defined by ThemeWML?
20160810 04:00:35< vultraz> I think i wanted to make the dropdown menu behavior of dismissal standard
20160810 04:00:37< vultraz> or something
20160810 04:00:52< celmin> Huh?
20160810 04:01:05< vultraz> i dunno
20160810 04:01:10< vultraz> something about generalizing it
20160810 04:01:25< vultraz> but yes, the framework is there
20160810 04:01:30< vultraz> just need a version with checkboxes
20160810 04:01:39< vultraz> and icons
20160810 04:02:16< vultraz> and yes, it has something to do with themewml
20160810 04:02:38< celmin> I think for the menus it only defines the contents, not layout.
20160810 04:05:14< vultraz> yes
20160810 04:05:18< vultraz> i think so
20160810 04:12:03-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 04:12:04< travis-ci> wesnoth/wesnoth#10270 (master - 09b116c : Charles Dang): The build is still failing.
20160810 04:12:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151110576
20160810 04:12:05-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 04:17:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160810 04:21:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160810 04:32:38-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 04:32:39< travis-ci> wesnoth/wesnoth#10271 (master - 55b81f6 : Charles Dang): The build is still failing.
20160810 04:32:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151111604
20160810 04:32:39-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 04:37:39< vultraz> i'l leave that to you
20160810 04:37:50< celmin> The failing build?
20160810 04:37:55< vultraz> yes
20160810 04:37:57< celmin> I was working on that, yes.
20160810 04:48:17-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160810 04:52:49-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 252 seconds]
20160810 04:55:17-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 04:55:18< travis-ci> wesnoth/wesnoth#10272 (master - c099376 : Charles Dang): The build is still failing.
20160810 04:55:18< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151111982
20160810 04:55:18-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 05:01:26-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160810 05:11:49-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160810 05:16:06-!- JyrkiVesterinen [~JyrkiVest@87-100-129-71.bb.dnainternet.fi] has joined #wesnoth-dev
20160810 05:24:16-!- oldlaptop [~quassel@50.36.241.195] has quit [Quit: No Ping reply in 180 seconds.]
20160810 05:26:41-!- oldlaptop [~quassel@50.36.241.195] has joined #wesnoth-dev
20160810 05:32:09-!- Bonobo [~Bonobo@2001:44b8:254:3200:7d95:e9a:7fe8:9e3b] has joined #wesnoth-dev
20160810 05:34:04-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160810 05:36:06-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160810 05:38:04-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160810 05:42:18-!- Kwandulin [~Miranda@p200300760F35BF107831B3393B893E19.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160810 05:57:49< irker747> wesnoth: Charles Dang wesnoth:master b5ec03c81bbd / src/gui/dialogs/ (7 files): Cleaned up some unnecessary make_pair calls in recent dialogs https://github.com/wesnoth/wesnoth/commit/b5ec03c81bbd6dd9e00db730ed47bb02f366103d
20160810 06:05:12< JyrkiVesterinen> vultraz: A little tip. std::map::emplace() is an even clearer alternative.
20160810 06:05:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160810 06:05:43< JyrkiVesterinen> http://en.cppreference.com/w/cpp/container/map/emplace
20160810 06:06:33< vultraz> huh
20160810 06:07:11< vultraz> actually, there also is a row_data["widget"]["label"] way to do it
20160810 06:07:38< vultraz> but I decided not to use that since I find it convenient to specify use_markup only once
20160810 06:07:46< celticminstrel> I need to find out what you guys are talking about.
20160810 06:08:00< JyrkiVesterinen> It's the commit above.
20160810 06:08:11< celticminstrel> Yeah, I guessed as much, but ...
20160810 06:08:21< vultraz> tldr: instead of this
20160810 06:08:23< vultraz> column["label"] = unit->type_name();
20160810 06:08:24< vultraz> row_data.insert({"unit_type", column});
20160810 06:08:26< vultraz> one can do this
20160810 06:08:39< celticminstrel> Ah, yeah.
20160810 06:08:43< vultraz> row_data["unit_type"]["label"] = unit->type_name();
20160810 06:08:47< vultraz> BUT
20160810 06:08:54< vultraz> then for every widget you want to use markup on
20160810 06:09:10< vultraz> one needs row_data["unit_type"]["use_markup"] = "true";
20160810 06:09:29< vultraz> by doing it the former way, I can simply have one case of column["use_markup"] = "true";
20160810 06:09:49< celticminstrel> Hang on, fetching so I can see the context...
20160810 06:09:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160810 06:09:52< vultraz> and since column is used for ever insert() call, that setting persists
20160810 06:10:07< JyrkiVesterinen> And I was simply suggesting: row_data.emplace("unit_type", column);
20160810 06:10:15< JyrkiVesterinen> Which would eliminate the braces at least.
20160810 06:10:23< vultraz> oh
20160810 06:10:32< vultraz> I like
20160810 06:12:52< celticminstrel> Whee...
20160810 06:13:02< celticminstrel> This is taking forever.
20160810 06:13:54< vultraz> I shall use this
20160810 06:14:39< celticminstrel> MSVC project needs updating BTW
20160810 06:15:23< JyrkiVesterinen> If no one does it before that, I'll update it in the evening (about ten hours from now).
20160810 06:15:38< celticminstrel> Ah.
20160810 06:28:04< celticminstrel> Okay, this appears to be working...
20160810 06:28:47-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 06:28:48< travis-ci> wesnoth/wesnoth#10273 (master - b5ec03c : Charles Dang): The build is still failing.
20160810 06:28:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151125826
20160810 06:28:48-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 06:34:41-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160810 06:36:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160810 06:37:11< irker747> wesnoth: Charles Dang wesnoth:master bf734e32894e / src/gui/dialogs/ (24 files in 5 dirs): Use std::map::emplace in all dialogs when applicable https://github.com/wesnoth/wesnoth/commit/bf734e32894e64e7d767cbb02ee11724355a92ae
20160810 06:38:10< celticminstrel> Hmm, I forgot to add the new dialog to scons and CMake...
20160810 06:49:21-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 265 seconds]
20160810 06:52:51< irker747> wesnoth: Charles Dang wesnoth:master ce5cb51c571c / data/gui/window/language_selection.cfg src/gui/dialogs/language_selection.cpp: Language Selection: use a proper toggle panel list instead of toggle buttons https://github.com/wesnoth/wesnoth/commit/ce5cb51c571c6041c9bf25d83e68a4ba7d67ab4d
20160810 06:53:06< vultraz> been meaning to do that for ages
20160810 06:53:30< vultraz> interestingly enough, the text looks better there too
20160810 06:53:35< vultraz> now*
20160810 06:58:10< vultraz> seems gui2::ttext text looks worse than gui2::tcontrol's
20160810 06:59:39< celticminstrel> I guess I won't finish this tonight. I'll fix the build tomorrow then.
20160810 07:00:10< irker747> wesnoth: Charles Dang wesnoth:master 650f0c0912cd / data/gui/window/unit_list.cfg: Unit List: removed a duplicate border definition https://github.com/wesnoth/wesnoth/commit/650f0c0912cd7ac02baa926292a5268e68478293
20160810 07:00:21< vultraz> can I remove the gui1 preview pane stuff or have you already
20160810 07:00:35< celticminstrel> I have not done so. Feel free to do so if it's not used anymore.
20160810 07:01:15< celticminstrel> I did update scons and CMake just now though.
20160810 07:01:39< vultraz> do push that
20160810 07:01:57< celticminstrel> I will.
20160810 07:02:49< vultraz> ya know, gui2 may be evil and rage-inducing
20160810 07:03:05< vultraz> but at least dialogs can be coded in a much clearer fashion.
20160810 07:03:26 * vultraz awaits your push before he commits
20160810 07:03:31< celticminstrel> ...I just realized that game_board is actually quite a light class.
20160810 07:03:53< celticminstrel> It'd be entirely possible to instantiate one for the unit tests.
20160810 07:04:10< celticminstrel> Oh, it does contain a gamemap though...
20160810 07:05:06< vultraz> btw, much thanks for doing the advance unit dialog
20160810 07:05:10< celticminstrel> That might be a bit problematic.
20160810 07:05:26< celticminstrel> I have to rebase stuff before pushing, so it'll take a few minutes.
20160810 07:05:28< vultraz> s/much/many
20160810 07:06:46< celticminstrel> This push won't fix the Travis build BTW, though it'll at least get it to compile.
20160810 07:07:24-!- travis-ci [~travis-ci@ec2-54-226-3-194.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 07:07:25< travis-ci> wesnoth/wesnoth#10274 (master - bf734e3 : Charles Dang): The build is still failing.
20160810 07:07:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151130619
20160810 07:07:25-!- travis-ci [~travis-ci@ec2-54-226-3-194.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 07:09:47< irker747> wesnoth: Celtic Minstrel wesnoth:master 75cde5ee02aa / projectfiles/Xcode/Wesnoth.xcodeproj/ (project.pbxproj xcshareddata/xcschemes/unit_tests.xcscheme): XCode: Fix unit tests build https://github.com/wesnoth/wesnoth/commit/75cde5ee02aa11577dc263305caafda93545f9b9
20160810 07:09:49< irker747> wesnoth: Celtic Minstrel wesnoth:master 8c54a3735053 / projectfiles/Xcode/Wesnoth.xcodeproj/xcshareddata/xcschemes/unit_tests.xcscheme: XCode: Fix runpaths for unit tests https://github.com/wesnoth/wesnoth/commit/8c54a37350538f945c62226139aecf8b0334e9f9
20160810 07:09:51< irker747> wesnoth: Celtic Minstrel wesnoth:master 5a5ecc98c208 / src/tests/main.cpp: Unit tests: make global fixture a bit more readable https://github.com/wesnoth/wesnoth/commit/5a5ecc98c208a497435f7ffcfcea468f1750ca46
20160810 07:09:53< irker747> wesnoth: Celtic Minstrel wesnoth:master 41f3547fe483 / src/ (CMakeLists.txt SConscript): Update scons and CMake https://github.com/wesnoth/wesnoth/commit/41f3547fe4832dde88aad201264ee9d565e01da3
20160810 07:09:55< irker747> wesnoth: Celtic Minstrel wesnoth:master 50c0c56fdf5b / src/ (dialogs.cpp gui/dialogs/game_stats.hpp gui/dialogs/unit_advance.hpp): Minor cleanup https://github.com/wesnoth/wesnoth/commit/50c0c56fdf5b00a809782ab13a51d7202f8bb329
20160810 07:13:40< irker747> wesnoth: Charles Dang wesnoth:master fc0235d6750e / src/ (dialogs.cpp dialogs.hpp): Removed GUI1 unit preview pane code (finally!) https://github.com/wesnoth/wesnoth/commit/fc0235d6750eb56535615e524a4dd266a1caf779
20160810 07:13:44< celticminstrel> ...oh, the game_board also extends display_context, so it's more complicated than it looks at first glance.
20160810 07:13:52< vultraz> Aginor: ^ a huge and very ugly piece of GUI1 is now gone :D
20160810 07:14:01< vultraz> GUI1 useage*
20160810 07:17:36-!- celticminstrel is now known as celmin|sleep
20160810 07:24:11-!- boucman_work [~boucman@229.29.205.77.rev.sfr.net] has joined #wesnoth-dev
20160810 07:28:54-!- Kwandulin [~Miranda@p200300760F35BF107831B3393B893E19.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160810 07:34:56< vultraz> ah, let us not forget the filechooser dialog
20160810 07:35:02-!- Kwandulin [~Miranda@p200300760F35BF05A4843FF48A5E1196.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160810 07:35:07< vultraz> shadowm: I'm still hoping you finish that soon
20160810 07:44:09-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 07:44:10< travis-ci> wesnoth/wesnoth#10275 (master - ce5cb51 : Charles Dang): The build is still failing.
20160810 07:44:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151132654
20160810 07:44:10-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 07:44:55< vultraz> hmm
20160810 07:45:11< vultraz> using the stats dialog in utbs causes an assert
20160810 07:48:49< vultraz> hmmm
20160810 07:49:02< vultraz> continuing on no_leader() works for that..why
20160810 07:53:49< vultraz> huh
20160810 07:54:17< vultraz> not sure what the problem is here
20160810 07:54:29< vultraz> it seems to be something with getting the leader..
20160810 07:54:38< vultraz> but why should that be a problem for utbs
20160810 07:54:39-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 07:54:40< travis-ci> wesnoth/wesnoth#10276 (master - 650f0c0 : Charles Dang): The build is still failing.
20160810 07:54:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151133778
20160810 07:54:40-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 07:58:24< vultraz> ok, I think the dialog breaks if a side has no leader
20160810 07:59:43-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160810 08:01:25< vultraz> yes
20160810 08:01:33< vultraz> guess I have to use the method the old dialog did
20160810 08:02:17-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160810 08:09:31-!- JyrkiVesterinen [~JyrkiVest@87-100-129-71.bb.dnainternet.fi] has quit [Remote host closed the connection]
20160810 08:11:56-!- JyrkiVesterinen [~JyrkiVest@87-100-129-71.bb.dnainternet.fi] has joined #wesnoth-dev
20160810 08:21:47< shadowm> Saying that won't somehow magically make me stop feeling ill when looking at Wesnoth.
20160810 08:22:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160810 08:22:08< vultraz> Then give me the code.
20160810 08:22:26< shadowm> Yeah, thanks for your support.
20160810 08:22:28-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 08:22:29< travis-ci> wesnoth/wesnoth#10277 (master - 50c0c56 : Celtic Minstrel): The build is still failing.
20160810 08:22:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151135267
20160810 08:22:29-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 08:22:45< shadowm> I was going to say other stuff too but never mind I guess.
20160810 08:22:58< vultraz> That means give me the code so you don't have to feel ill by trying to work on it :|
20160810 08:23:13< vultraz> Not give me the code bc I only care about the bottom line.
20160810 08:25:43< shadowm> It'd be like handing a militarist government the blueprints for a galaxy annihilation device.
20160810 08:28:32< vultraz> *Is now known as The First Order*
20160810 08:29:38< zookeeper> ohh, galaxy annihilation device.
20160810 08:29:45 * zookeeper salivates
20160810 08:31:04< shadowm> Oh I was referencing something much older.
20160810 08:31:54< shadowm> The point is I stopped working on it because I couldn't solve a chicken-and-egg issue of sorts with GUI2.
20160810 08:32:13< vultraz> I.. thought you solved that
20160810 08:32:24< vultraz> I distinctly remember you saying method D worked.
20160810 08:32:51< shadowm> Yeah, I'm sure you'd be the only human being in existence to think that.
20160810 08:33:33< shadowm> You obviously don't remember my meltdown after realizing the big flaw in my plan.
20160810 08:34:24< shadowm> My solution was to call the list rebuilding method from each row-clicked callback. So far so good, right?
20160810 08:34:35< shadowm> But guess what the list rebuilding method does.
20160810 08:34:46< shadowm> It rebuilds the list.
20160810 08:35:07< shadowm> That entails destroying the rows.
20160810 08:35:24< shadowm> That happens to include destroying the row whose callback is being invoked.
20160810 08:35:55< shadowm> The GUI2 event pipeline isn't designed to prevent UB when returning to it from such a situation.
20160810 08:36:27< vultraz> D:
20160810 08:37:40< shadowm> I came up with an alternate idea of extracting the row out of the layout for garbage collection at a later time when events for that row have stopped being processed (i.e. next rebuild or post_show) but that 1) goes against my principles; 2) created new problems that I couldn't understand.
20160810 08:39:50< shadowm> And since then I've been in this ultimate creative block where I can't code, write or draw anything.
20160810 08:42:22< vultraz> Hmmm...
20160810 08:42:24< vultraz> I have no ideas :/
20160810 08:42:45< vultraz> Sounds like something that will require delving deep into GUI2
20160810 08:44:11< shadowm> The gist of it is that the event processing code needs to be made to consider the possibility that a widget may be destroyed during event handling, and stop immediately.
20160810 08:45:00< shadowm> But you and I both know that the GUI2 events code belongs in some crappy knockoff Lovecraftian horror novel, not a project full of beginner-to-intermediate C++ coders.
20160810 08:46:15< shadowm> And I cannot guarantee that there are more issues yet to be found with code making assumptions about a widget's lifecycle that need to be reconsidered for this dialog's functionality.
20160810 08:46:21< shadowm> *there aren't
20160810 08:48:06< irker747> wesnoth: Charles Dang wesnoth:master 11162e02e753 / / (3 files in 2 dirs): Game Stats: fixed handling and display of leaderless, non-hidden sides https://github.com/wesnoth/wesnoth/commit/11162e02e7536c0aa70bc1215eac58b2495083d1
20160810 08:49:58< vultraz> shadowm: well, I hope you feel more up to looking deeper onto the pit that is GUI2 event handling in the future. For now, focus on something that doesn't include illness.
20160810 08:50:58-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 08:50:59< travis-ci> wesnoth/wesnoth#10278 (master - fc0235d : Charles Dang): The build is still failing.
20160810 08:50:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151135799
20160810 08:50:59-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 08:53:12< shadowm> I don't think I'll ever feel like that because, as I've said countless times before in different situations, it's way beyond my skill level.
20160810 08:55:35< shadowm> Inheritance chains put a strain on my ability to keep track of things. I can barely manage multiple inheritance. If you mix that AND template overuse, my brain simply shuts down.
20160810 08:55:39 * Aginor gives shadowm a cup of tea
20160810 08:58:52-!- JyrkiVesterinen [~JyrkiVest@87-100-129-71.bb.dnainternet.fi] has quit [Quit: Rebooting]
20160810 08:59:15< Aginor> shadowm: event handling isn't fun
20160810 08:59:33< vultraz> Aginor: this is GUI2 event handling. It's worse :|
20160810 09:00:27< Aginor> I've read through it and debugged through it
20160810 09:00:33< Aginor> it's not very fun
20160810 09:01:24-!- JyrkiVesterinen [~JyrkiVest@87-100-129-71.bb.dnainternet.fi] has joined #wesnoth-dev
20160810 09:03:57-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160810 09:04:56< Aginor> can someone whoäs comfortable with the campaignserver_client please have a look at the Fedora packager's problem at http://gna.org/bugs/?23897 ?
20160810 09:05:03< Aginor> Please help me to ping the right people
20160810 09:05:08< shadowm> That'd be elias.
20160810 09:05:27< Aginor> elias: ping ^
20160810 09:05:45< Aginor> elias: your input would be much appreciated
20160810 09:06:42< shadowm> It looks like they're trying to compile it using Python 2 but I'm fairly sure _all_ of our Python scripts by now use Python 3.
20160810 09:06:57-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has joined #wesnoth-dev
20160810 09:07:18< shadowm> Maybe adding the correct shebang to data/tools/wesnoth/campaignserver_client.py (which normally wouldn't need one since it's supposed to be imported by a script, not executed on its own) would help?
20160810 09:07:46< Aginor> not if the problem is with bytecompiling
20160810 09:07:53< Aginor> but yeah
20160810 09:07:59< Aginor> I'll post that as an intermediate
20160810 09:08:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160810 09:08:04-!- wedge010 is now known as wedge009
20160810 09:08:07< shadowm> I'd assume whatever script they're using for that is assuming Python 2 unless the file says otherwise.
20160810 09:08:10< Aginor> I might also see if I can find the .spec file
20160810 09:08:15< shadowm> *I presume
20160810 09:09:35< shadowm> I mean, if there was a way to force it without patching the upstream files (i.e. data/tools/wesnoth/campaignserver_client.py itself) I'd expect the packager to have tried it already before posting in the tracker, but you can never be sure.
20160810 09:12:20< Aginor> also, do we want rawhide picking up the development version?
20160810 09:12:30< Aginor> it'd be better if they upgraded to 1.12.6
20160810 09:13:01< Aginor> otherwise fedora 25 will contain a development release
20160810 09:13:47< Aginor> I'll let whoever talks to packagers deal with that one
20160810 09:13:58< shadowm> Maybe they can block it from releases like Debian people do with certain packages in Unstable (e.g. firefox as built from the Release branch).
20160810 09:14:14< Aginor> I have no idea
20160810 09:14:15< shadowm> No idea who talks with packagers these days. This stuff is supposedly the domain of the release manager.
20160810 09:14:40< Aginor> I haven't played with building rpms for 10+ years and much have changed in that time
20160810 09:14:45< Aginor> probably closer to 15
20160810 09:18:30-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160810 09:22:34< shadowm> I replied.
20160810 09:25:04-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has quit [Ping timeout: 252 seconds]
20160810 09:35:27-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 09:35:28< travis-ci> wesnoth/wesnoth#10279 (master - 11162e0 : Charles Dang): The build has errored.
20160810 09:35:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151153470
20160810 09:35:28-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 09:43:44< Aginor> thanks shadowm
20160810 10:09:04-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 252 seconds]
20160810 10:09:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160810 10:09:47< Aginor> it looks like the python modules that actually have a python shebang in the header uses /usr/bin/env python, which is likely to yield python2 on almost all systems
20160810 10:10:48< Aginor> there's also no mention at all about the python dependencies in either README.md or INSTALL
20160810 10:11:44< Aginor> scons install-pytools will put it into $destdir/python/site-packages/wesnoth, which is going to be wrong in every system
20160810 10:17:16< vultraz> BTW, to anyone looking for bugs to fix, I've raised https://gna.org/bugs/index.php?24780 to blocker for the next release.
20160810 10:17:38< vultraz> It seriously affects the new game stats dialog
20160810 10:19:38-!- Kwandulin [~Miranda@p200300760F35BF05A4843FF48A5E1196.dip0.t-ipconnect.de] has quit [Quit: Kwandulin]
20160810 10:19:57-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160810 10:22:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20160810 10:22:19-!- VultCave is now known as vultraz
20160810 10:22:29-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160810 10:22:29-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160810 10:22:49-!- Bonobo [~Bonobo@2001:44b8:254:3200:7d95:e9a:7fe8:9e3b] has quit [Ping timeout: 260 seconds]
20160810 10:22:57-!- Nobun [~nobun@host123-44-dynamic.20-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20160810 10:23:05-!- Nobun [~nobun@host123-44-dynamic.20-79-r.retail.telecomitalia.it] has quit [Client Quit]
20160810 10:23:33< irker747> wesnoth: Charles Dang wesnoth:master 34d6df9e4330 / src/tests/gui/test_gui2.cpp: Exclude Unit Advance from tests https://github.com/wesnoth/wesnoth/commit/34d6df9e433041a24b02f2d88bc3172929161e33
20160810 10:23:51-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160810 10:33:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160810 10:38:37-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160810 10:47:22-!- gfgtdf [~chatzilla@x4e369e4d.dyn.telefonica.de] has joined #wesnoth-dev
20160810 10:47:23< gfgtdf> 20160810 03:30:50< vultraz> what is this leader_scroll_dialog thing
20160810 10:47:46< gfgtdf> vultraz: isnt this exactly the unit list or side overwiew dialog (rthat you ported to gui2) ?
20160810 10:47:56< vultraz> gfgtdf: yeah i realized that
20160810 10:47:58< vultraz> and removed it
20160810 10:48:10< gfgtdf> 20160810 03:24:31< celmin> What's not obvious is where to move it to.
20160810 10:48:38< gfgtdf> celmin|sleep: since this is always calleed by actions/attack.cpp you could just move it there
20160810 10:49:06< gfgtdf> same for dialogs::advance_unit_dialog
20160810 10:53:01-!- ggeneral [~ggeneral@nat58.opti.net.ua] has joined #wesnoth-dev
20160810 10:53:30< gfgtdf> celmin|sleep: or you coudl split a actions/advancement.cpp/hpp out of actions/attack.cpp/hpp and move it there
20160810 10:56:17< zookeeper> gfgtdf, about the ANL gold: no, i'm not going to lower it. i'd rather err on the side of too easy than too hard, but having two difficulty levels for it would be good of course.
20160810 10:56:58< zookeeper> (so if you for example want to look into doing that, feel free to assign it away from me)
20160810 11:00:38-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 11:00:39< travis-ci> wesnoth/wesnoth#10280 (master - 34d6df9 : Charles Dang): The build passed.
20160810 11:00:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151173674
20160810 11:00:39-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 11:00:53< gfgtdf> zookeeper: hmm currently i have no such plan.
20160810 11:03:36< gfgtdf> vultraz: the gui2 unti attack diag seems to create a temprary gui1 button here https://github.com/wesnoth/wesnoth/blob/bf734e32894e64e7d767cbb02ee11724355a92ae/src/gui/dialogs/unit_attack.cpp#L181
20160810 11:03:47< gfgtdf> vultraz: and then calls click on it manually
20160810 11:04:17< gfgtdf> vultraz: i'td be better if attack_prediction_displayer::button_presseds content was moved there and attack_prediction_displayer deleted
20160810 11:05:11< vultraz> ok
20160810 11:05:22-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has quit [Ping timeout: 250 seconds]
20160810 11:05:57-!- Bonobo [~Bonobo@2001:44b8:254:3200:9965:8522:5ad5:7ab5] has joined #wesnoth-dev
20160810 11:07:04< gfgtdf> lets check which dialogs are still gui1.
20160810 11:07:49< vultraz> gfgtdf: Statistics, File Chooser, Help, Addons Manager, the various MP Create stuff, and menus.
20160810 11:10:12-!- Kwandulin [~Miranda@p200300760F35BF05F580DD92D3224732.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160810 11:14:06< gfgtdf> i'll do what suggested above and plit the advancement stuf intoa new file actions/advancements.cpp any opinions ?
20160810 11:15:55< vultraz> could be worth it
20160810 11:17:57< vultraz> if it makes things clearer
20160810 11:19:32-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has joined #wesnoth-dev
20160810 11:29:40< irker747> wesnoth: Charles Dang wesnoth:master c3f07f1f73c8 / src/ (3 files in 2 dirs): tunit_attack: simplify damage calc callback by calling gui::show_dialog directly https://github.com/wesnoth/wesnoth/commit/c3f07f1f73c89f8ff7f1fedaf500c0d05f84583c
20160810 11:29:42< vultraz> gfgtdf: ^
20160810 11:31:22< vultraz> thanks for pointing that out
20160810 11:35:55< vultraz> huh
20160810 11:36:07< vultraz> so, there's actually a small prototype for gui2 mp create
20160810 11:37:54< gfgtdf> vultraz: hmm i want to remove dialogs.cpp but i dont know ehere to put the network and the objectived dialog
20160810 11:38:44< gfgtdf> i guess i cano move the network dialog to gui2::tnetwork_transmissions file
20160810 11:38:55< vultraz> gfgtdf: actually we want to remove those network dialog calls and use loading screen stages
20160810 11:39:23< gfgtdf> vultraz: any opinion on whre to put the objctived dialog ?
20160810 11:39:59< gfgtdf> objectives*
20160810 11:40:08< vultraz> not sure no
20160810 11:41:14< gfgtdf> vultraz: play_controller.hpp seems liek agood place sinceple people have to use playcontoller::get_scenario_name() anywya as the first parmaeter.
20160810 11:41:31< vultraz> sure
20160810 11:55:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160810 12:11:22-!- ggeneral [~ggeneral@nat58.opti.net.ua] has quit [Ping timeout: 258 seconds]
20160810 12:32:16-!- Bonobo [~Bonobo@2001:44b8:254:3200:9965:8522:5ad5:7ab5] has quit [Ping timeout: 264 seconds]
20160810 13:16:31-!- gfgtdf [~chatzilla@x4e369e4d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160810 13:19:28-!- Kwandulin [~Miranda@p200300760F35BF05F580DD92D3224732.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160810 13:41:12-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160810 13:41:52< celmin> You know, I said I was working on it… you didn't need to exclude unit_advance from tests...
20160810 13:42:15< celmin> gfgtdf: I dunno, maybe objectives could go in team.?pp?
20160810 13:44:26< celmin> I seem to have a Steam friend invite from someone I don't know who seems to share no friends with me… :|
20160810 13:45:09< celmin> Unless it was someone from here or something...
20160810 13:58:12-!- celmin|sleep is now known as celticminstrel
20160810 14:07:58< irker747> wesnoth: gfgtdf wesnoth:master a20f221e837e / src/ (34 files in 9 dirs): remove dialogs.cpp https://github.com/wesnoth/wesnoth/commit/a20f221e837e9f064484179dc7b092168fcaa18e
20160810 14:09:02-!- louis94 [~~louis94@91.178.241.79] has joined #wesnoth-dev
20160810 14:10:36< celmin> Hmm, guess I need to update the XCode project soon then.
20160810 14:10:44< celmin> After I finish the unit tests, I guess.
20160810 14:11:56< celmin> Huh, why does that advancement choice use rand()?
20160810 14:12:15-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160810 14:14:57-!- gfgtdf [~chatzilla@x4e369e4d.dyn.telefonica.de] has joined #wesnoth-dev
20160810 14:15:11< gfgtdf> celmin: the comment in the code says 'note that it doesn't matter whether we call random_new::generator->next_random() or rand().'
20160810 14:15:33< celmin> The former is probably "more random" though.
20160810 14:16:57< celmin> But I guess that doesn't matter, yeah.
20160810 14:18:27< celmin> Thanks for removing dialogs.cpp, anyway. I was thinking of doing it but not sure where to put stuff.
20160810 14:24:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160810 14:24:20< gfgtdf> i wonder whether i shodul change the interface of advance_unit to take a variant
20160810 14:24:30< celmin> Oh hi
20160810 14:24:41< gfgtdf> instead of having 2 argument which which exactly one must be non empty
20160810 14:24:55< celmin> gfgtdf: Is this function in advancement.cpp?
20160810 14:25:09< gfgtdf> celmin: yes
20160810 14:26:01< celmin> Ah, I see.
20160810 14:26:28< celmin> Why not variant?
20160810 14:26:54< gfgtdf> celmin: less conifg copying
20160810 14:27:00< celmin> I guess that's true...
20160810 14:28:08< celmin> Maybe you could just make it take a config?
20160810 14:29:01< celmin> AMLAs would pass the [advancement] contents, and regular advancements would pass something like config_of("type", new_type)
20160810 14:31:19< celmin> …seriously? You just copied attack.cpp and didn't bother to update the comment, didn't you...
20160810 14:31:38< gfgtdf> celmin: which comment ?
20160810 14:32:04< celmin> Top of file comment, attacks.hpp and advancements.hpp (sorry, it was hpp not cpp)
20160810 14:32:44< gfgtdf> hmm i didnt see that comment, wil update it later
20160810 14:33:38-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 14:33:39< travis-ci> wesnoth/wesnoth#10282 (master - a20f221 : gfgtdf): The build was broken.
20160810 14:33:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151225605
20160810 14:33:39-!- travis-ci [~travis-ci@ec2-54-166-58-160.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 14:37:56< celmin> Yay const-correctness.
20160810 14:48:25-!- Kwandulin [~Miranda@p200300760F35BF058D28EC6123BBC597.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160810 14:49:24-!- JyrkiVesterinen [~JyrkiVest@87-100-129-71.bb.dnainternet.fi] has quit [Quit: .]
20160810 14:58:42< irker747> wesnoth: gfgtdf wesnoth:master 16d522193475 / src/ (3 files in 2 dirs): fixup a20f221e83 and improve advance_unit() interface https://github.com/wesnoth/wesnoth/commit/16d522193475caa352de5c0c26b3007de6ed44f3
20160810 14:59:12< celmin> …why does it need the global scope qualifier anyway… guess it's not important...
20160810 15:00:40< celmin> gfgtdf: Is there no comment to update in attack.hpp?
20160810 15:10:00< celmin> For some reason I have failing tests.
20160810 15:26:35-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 15:26:36< travis-ci> wesnoth/wesnoth#10283 (master - 16d5221 : gfgtdf): The build is still failing.
20160810 15:26:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151239816
20160810 15:26:36-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 15:27:45< celmin> Ambiguous conditional expression, huh...
20160810 15:30:02< gfgtdf> celmin: hmm it compiled fine on my pc
20160810 15:30:33< celmin> What has that got to do with it?
20160810 15:30:37< irker747> wesnoth: gfgtdf wesnoth:master 869d5a1b789c / src/play_controller.cpp: fix travis build https://github.com/wesnoth/wesnoth/commit/869d5a1b789c964a04e17d72b8b4859b9ee14209
20160810 15:31:11< celmin> Well, looks like unit tests are working. \o/
20160810 15:31:22-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has joined #wesnoth-dev
20160810 15:35:48-!- gfgtdf [~chatzilla@x4e369e4d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160810 15:37:53< celmin> Need to make sure I didn't break unit generation or anything.
20160810 15:39:06< celmin> I wish XCode gave a third option ("Queue") when complaining that a build is already running.
20160810 15:40:47< celmin> Does Boost.UnitTest not give a summary of how many tests failed? :|
20160810 15:46:33-!- boucman_work [~boucman@229.29.205.77.rev.sfr.net] has quit [Ping timeout: 240 seconds]
20160810 15:52:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160810 15:52:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160810 15:53:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160810 16:06:47-!- fabi__ [~fabi@176.5.34.179] has quit [Ping timeout: 258 seconds]
20160810 16:08:51-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 16:08:52< travis-ci> wesnoth/wesnoth#10284 (master - 869d5a1 : gfgtdf): The build has errored.
20160810 16:08:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151250262
20160810 16:08:52-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 16:11:20-!- JyrkiVesterinen [~JyrkiVest@78-27-104-228.bb.dnainternet.fi] has joined #wesnoth-dev
20160810 16:12:50-!- fabi__ [~fabi@176.5.34.179] has joined #wesnoth-dev
20160810 16:14:39-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160810 16:19:40-!- Kwandulin [~Miranda@p200300760F35BF058D28EC6123BBC597.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160810 16:21:56-!- TC01 [~quassel@venus.arosser.com] has quit [Quit: http://quassel-irc.org - Chat comfortably. Anywhere.]
20160810 16:22:04-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20160810 16:22:25-!- TC01_ is now known as TC01
20160810 16:35:32< irker747> wesnoth: Jyrki Vesterinen wesnoth:master 8259e160d021 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/8259e160d0210e3207b11b81ee6527788bf44acc
20160810 16:55:59-!- fabi__ [~fabi@176.5.34.179] has quit [Ping timeout: 244 seconds]
20160810 16:58:55< celmin> I accidentally lost my unit_attack unit tester… now I have to rewrite it...
20160810 16:59:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160810 16:59:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160810 17:00:36-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160810 17:12:54-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160810 17:12:55< travis-ci> wesnoth/wesnoth#10285 (master - 8259e16 : Jyrki Vesterinen): The build passed.
20160810 17:12:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151267547
20160810 17:12:55-!- travis-ci [~travis-ci@ec2-54-198-12-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160810 17:27:50-!- boucman_work [~boucman@2a02-8428-034f-f800-e4d0-c0c3-1b2b-5bdc.rev.sfr.net] has joined #wesnoth-dev
20160810 17:33:12-!- louis94 [~~louis94@91.178.241.79] has quit [Ping timeout: 240 seconds]
20160810 17:34:14-!- Kwandulin [~Miranda@p200300760F35BF05AD06A382A5262154.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160810 17:38:20-!- boucman_work [~boucman@2a02-8428-034f-f800-e4d0-c0c3-1b2b-5bdc.rev.sfr.net] has left #wesnoth-dev []
20160810 18:03:52< celmin> Argh, resources is evil.
20160810 18:07:40< celmin> Someone please try to eliminate it. Even if it just means reducing the usage of it.
20160810 18:09:58-!- louis94 [~~louis94@91.178.241.79] has joined #wesnoth-dev
20160810 18:26:42-!- louis94 [~~louis94@91.178.241.79] has quit [Ping timeout: 258 seconds]
20160810 18:33:48-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160810 18:38:46< vultraz> celmin: I excluded it as an immediate\ fix. If you're working on a proper test for the dialog no harm done.
20160810 18:39:08< celmin> True.
20160810 18:39:30< celmin> I can't make a test for unit_attack, because the battle_context accesses resources.
20160810 18:46:33-!- gfgtdf [~chatzilla@x4e369e4d.dyn.telefonica.de] has joined #wesnoth-dev
20160810 18:46:42< gfgtdf> celmin: can't just just set the resoruces then ?
20160810 18:47:00-!- mjs-de [~mjs-de@x4db5a58f.dyn.telefonica.de] has joined #wesnoth-dev
20160810 18:47:01< gfgtdf> celmin: in the tests i mean
20160810 18:47:26< celmin> Theoretically yes...
20160810 18:47:39< irker747> wesnoth: Charles Dang wesnoth:master e04be90254ea / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/e04be90254ea729cfb46b4bca8b80caa7d062da0
20160810 18:47:45< celmin> I think it was accessing gameboard.
20160810 18:47:55< celmin> Which is a display_context.
20160810 18:48:07< celmin> I'm not sure what's needed to construct one of those.
20160810 18:48:48< irker747> wesnoth: Charles Dang wesnoth:master 89246cd47366 / data/gui/window/mp_create_game.cfg src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: minor progress, mostly bringing the existing content to a semi-proper https://github.com/wesnoth/wesnoth/commit/89246cd4736614e5ace6d59f5f7610ba32e08f6a
20160810 18:48:56< gfgtdf> celmin: gameboard is afaik map + units + teams
20160810 18:49:15< vultraz> gfgtdf: you said we could remove resources::teams?
20160810 18:49:20< celmin> gfgtdf: Plus display_context.
20160810 18:49:24-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160810 18:49:26< vultraz> and use resources::gameboard->teams()?
20160810 18:49:52< gfgtdf> celmin: display_context is just adn interface
20160810 18:49:55< gfgtdf> an*
20160810 18:50:42< tad_> I just hit a show-stopping bug in HttT S14 and am going to need some assistance. I have localized the issue to [teleport] within a [event]name=sighted and it causes an infinite look on the sighted event
20160810 18:50:48< gfgtdf> vultraz: i see no reason against it, but maybe oin will appear when we try it.
20160810 18:50:48< celmin> Anyway, I think the map is the hard part.
20160810 18:51:11< gfgtdf> tad_: loop ?
20160810 18:51:13< vultraz> tad_: sounds serious
20160810 18:51:29< tad_> Very. fires the event in a loop.
20160810 18:51:46< celmin> gfgtdf: Oh you're right.
20160810 18:51:51< celmin> It's just an interface.
20160810 18:51:56< tad_> Battle for Wesnoth v1.13.5+dev (c3f07f1-Clean)
20160810 18:51:59< celmin> Still, the map is the hard part.
20160810 18:52:03< gfgtdf> tad_: no the question was whther 'look ' in your post actually meant 'loop'
20160810 18:52:14< zookeeper> tad_, uh oh. that's bad.
20160810 18:52:16< tad_> yes. infinte loop
20160810 18:52:47< tad_> It came up after syncing to master. Was OK last sync, a few days ago.
20160810 18:53:08< tad_> IIRC there was work on [endlevel] and that's where I'm thinking to start looking
20160810 18:53:57< zookeeper> so when does it loop?
20160810 18:54:00< gfgtdf> tad_ you rmember the commit when it worked?
20160810 18:54:12< zookeeper> immediately after the teleport? or does the whole event run first, and then repeats?
20160810 18:54:17< tad_> If you pull up S14 WML .cfg I can kill the loop by removing the three [teleport]s
20160810 18:54:33< tad_> Rememer? No. but I can check my fork.
20160810 18:54:38< celmin> Seems odd that it would be affected by the endlevel thing… unless it's triggering an endlevel...
20160810 18:54:41< tad_> I've not pushed yet
20160810 18:54:50< irker747> wesnoth: Celtic Minstrel wesnoth:master 1a5ce49bf6a7 / src/ (7 files in 3 dirs): Re-enable unit map and recall list tests https://github.com/wesnoth/wesnoth/commit/1a5ce49bf6a71b330a7f1a621055ff7aea64479b
20160810 18:54:52< irker747> wesnoth: Celtic Minstrel wesnoth:master f40925beabc6 / src/tests/gui/test_gui2.cpp: Neaten the list of test-excluded dialogs https://github.com/wesnoth/wesnoth/commit/f40925beabc65629f93bee7d3c9e086dd8f18b85
20160810 18:55:51-!- RatArmy [~RatArmy@om126212249091.14.openmobile.ne.jp] has quit [Ping timeout: 244 seconds]
20160810 18:56:00< tad_> My fork is 8 commits behind master. Which leads me to think it was not tested. sigh.
20160810 18:56:09< tad_> My testing, that is.
20160810 18:56:53< celmin> What was not tested?
20160810 18:56:56< tad_> Ah. But my PRs are 69 commits behind and it was working then, IIRC
20160810 18:57:12< tad_> I try to do a run-through after I sync just in case of something like this.
20160810 18:57:26< zookeeper> so when/how does it loop?
20160810 18:57:27< tad_> Was doing that today and boom.
20160810 18:58:13< tad_> In HttT S14 under shroud, sighted event. Loops if you run clean. Comment out the three [teleport] and it completes to victory
20160810 18:59:00< zookeeper> immediately after the teleport? or does the whole event run first, and then repeats?
20160810 18:59:34< tad_> Runs the event to the [endlevel] and on next loop through you get the new warning on screen about ignoring the duplicated endlevel
20160810 18:59:50< zookeeper> all right, it's endlevel-related then
20160810 18:59:54< zookeeper> (surely)
20160810 18:59:56< tad_> So it seems to be exiting the event and re-firing.
20160810 19:00:08< celmin> Ah, okay.
20160810 19:00:25< tad_> And I check with inspect before and after the endlevel. the sighted event is not showing in inspect either place.
20160810 19:01:06< celmin> So, just to check, no WML-based loop is running here?
20160810 19:01:14< zookeeper> correct
20160810 19:01:23< gfgtdf> celmin: is there a reason why you removed the id_managers ctor ?
20160810 19:01:33< celmin> Because it was pointless?
20160810 19:01:35< tad_> My final [inspect] is immed. before [/event]
20160810 19:01:50< celmin> It was only used for that private static instance, after all.
20160810 19:02:34< gfgtdf> celmin: hmm yrs my bad
20160810 19:03:47< vultraz> gfgtdf: ok it looks like gameboard::teams is const, so that causes problems in some places.
20160810 19:04:06< gfgtdf> vultraz: you can add a non-const version i think
20160810 19:05:01-!- fabi__ [~fabi@176.5.34.179] has joined #wesnoth-dev
20160810 19:05:36< gfgtdf> vultraz: i mean, i know at least one place where i explcitly used resrouces::unit instead game_board_.units() becasue the later onyl returns const, and i dont really think that cna be the proper solution.
20160810 19:05:52< tad_> I'm going to try moving the [endlevel] to a custom event. If it's the culprit that may get me out of the loop.
20160810 19:06:39< vultraz> gfgtdf: maybe a non-const version of that too?
20160810 19:07:34< gfgtdf> tad_ usualyl the content of endlevel_ should'nt have an effect before the current action has finished (which impled that all events have finished event is finished), so i think think its quite unlikeley that its caused by the changes to [endlevel]
20160810 19:07:43< gfgtdf> vultraz: 'that'?
20160810 19:07:50< vultraz> (do the const and non-const versions need to be named differently or are overloads file?)
20160810 19:07:57< vultraz> gfgtdf: gameboard::units
20160810 19:08:15< gfgtdf> vultraz: thats what i awas suggesting, add a non const version
20160810 19:08:30< gfgtdf> vultraz: you can just give it the same name
20160810 19:08:39< fabi__> hi
20160810 19:09:07< gfgtdf> vultraz: you you currently wrking onthe resources::teams change ?
20160810 19:09:11< celmin> vultraz: Like I did in one of my recent commits.
20160810 19:09:18< vultraz> yes
20160810 19:09:27< celmin> Though that was adding a const version of something.
20160810 19:09:30< celmin> Modifications I think.
20160810 19:11:04< tad_> OK. I moved [endlevel] to a custom event. All that did was stop the repeated [endlevel] still looping on the sighted event.
20160810 19:11:08< gfgtdf> vultraz: i think think we shodul add a get_team() to game_board that takes teams by their number so that all board.teams()[num - 1] can be replaced with board.get_team(num), so that board.teams() will onyl be used when iterating over all temas
20160810 19:11:23< celmin> So it's not caused by the endlevel?
20160810 19:11:29< celmin> gfgtdf: Yes.
20160810 19:11:32< tad_> Apparently not.
20160810 19:11:55< celmin> gfgtdf: Change board.teams() to return std::make_pair(teams.begin(), teams.end())
20160810 19:12:38< tad_> I am going to take the [endlevel] out completely. I do knowif I remove the three [teleport] it does not look. I'm going to try just [teleport] and nothing else.
20160810 19:13:21< gfgtdf> well i personalyl woudl prefer to return aboost::iterator_ragne, then you coudl still use board_.teams().size() to get the number of teams
20160810 19:13:34< celmin> gfgtdf: Sure, whatever.
20160810 19:14:07 * celmin didn't know that iterator_range had a size method.
20160810 19:15:04< zookeeper> so has anyone done anything related to event firing recently?
20160810 19:15:37< celmin> The only thing I remember is Spixi's firing by ID…
20160810 19:15:55< zookeeper> i'd double-check that then
20160810 19:16:08< celmin> Is that recent enough?
20160810 19:16:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160810 19:16:21< zookeeper> dunno
20160810 19:16:29< celmin> Well, doesn't hurt to try reverting it.
20160810 19:16:33< zookeeper> but IIRC it involved a bit of refactoring
20160810 19:17:25< vultraz> so for some reason the editor_controller was manually setting the value of resources::teams
20160810 19:17:32< tad_> OK. It's the [teleport]. I have JUST [inspect] and [teleport] along with the [filter] and [filter-second] and it loops.
20160810 19:17:53< vultraz> dunno if that's still needed
20160810 19:18:09< celmin> The fire-by-id merge commit is dc3d22a if you want to test reverting it.
20160810 19:18:23< celmin> vultraz: Might be.
20160810 19:18:32< vultraz> celmin: might be needed?
20160810 19:18:36< celmin> Yeah
20160810 19:18:44< celmin> Does the editor have a game_board available?
20160810 19:18:59< celmin> If it does, then I guess the separate teams probably isn't needed.
20160810 19:19:56< tad_> If will pull the patch and reverse it. It may take a while if I have to recompile. Sometimes it's fast, sometimes it takes a couple hours ... be back when I finish
20160810 19:20:00< gfgtdf> zookeeper: https://github.com/wesnoth/wesnoth/commit/18d773619021a926c42416ebde0e952efc86c407 migth also be related
20160810 19:20:29-!- Kwandulin [~Miranda@p200300760F35BF05AD06A382A5262154.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160810 19:20:31< zookeeper> gfgtdf, yeah could be, i dunno
20160810 19:20:41< tad_> If that's not it, I support I could try git's feature to find the culprit.
20160810 19:20:48< celmin> bisect, yeah
20160810 19:21:07< tad_> Hate that. bisect. wait 2 hours. rinse and repeat
20160810 19:21:33< vultraz> celmin: does not seem to
20160810 19:21:49< tad_> OK. Off to try dc3d22a revser first.
20160810 19:21:57-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160810 19:35:20< gfgtdf> hmm from looking at the code i feel like its too complateced, i mean we use smart_list to store share_ptr which both do refcounting
20160810 19:35:41< vultraz> if possible we should remove smart_list
20160810 19:35:56< celmin> If possible, indeed.
20160810 19:36:04< celmin> So go and figure out if it's possible. :P
20160810 19:36:33-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160810 19:36:57< irker747> wesnoth: Celtic Minstrel wesnoth:master 9c64028dd222 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/9c64028dd2224a13eaee86329006cfb52bc790e4
20160810 19:37:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160810 19:37:46< tad_> Just out of curiosity: I touched ONE .cpp file and it wants to make all of target wesnoth. Is there a way to stop that? I'm guessing it's a header being changed to reflect it's not a clean master.
20160810 19:39:18< vultraz> celmin: hey, I'm busy cleaning up resources! :P
20160810 19:39:39< celmin> What're you building with?
20160810 19:39:48< celmin> vultraz: Oh, nice.
20160810 19:40:06< celmin> vultraz: But are you actually working on removing uses of it, or just removing resources::teams?
20160810 19:40:20< vultraz> latter first
20160810 19:40:32< tad_> um 'make' not that scons thing iirc.
20160810 19:40:40< celmin> CMake?
20160810 19:40:54< tad_> lotsa those so I'm guessing yes
20160810 19:41:15< tad_> [ 82%] Building CXX object src/CMakeFiles/wesnoth.dir/ai/simulated_actions.cpp.o
20160810 19:41:28< celmin> Yeah okay, CMake.
20160810 19:41:45< celmin> Are you sure only one cpp file was touched though?
20160810 19:42:02< tad_> I checked with a git diff HEAD .
20160810 19:42:15< celmin> Ah.
20160810 19:42:32< celmin> Did you revert that commit as well and rebuild afterwards?
20160810 19:42:33< vultraz> celmin: realistically there's some stuff that could be converted to take a gameboard argument
20160810 19:42:42< celmin> vultraz: Good to hear/
20160810 19:42:54 * celmin wonders if the game_board class is actually needed though.
20160810 19:43:10< celmin> …though it is the display_context...
20160810 19:43:11< tad_> Yep. only diff is game_events/handlers.cpp
20160810 19:43:27< celmin> I have no idea why it's rebuilding everything then.
20160810 19:44:02-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160810 19:44:21< tad_> That was rebuilt as only change to target wesnoth-code, then three files for wesnoth-game and now everything in target wesnoth
20160810 19:44:33-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160810 19:45:20< tad_> Like maybe every .cpp -> .o part of wesnoth has a dependancy on wesnoth-game.a ???
20160810 19:45:27< celmin> I dunno.
20160810 19:46:03< tad_> It's been ages since I played with makefiles and these cmake and scons are all new to me.
20160810 19:46:55< tad_> Well, I noted a patch after yours : commit 18d773619021a926c42416ebde0e952efc86c407 Author: gfgtdf Date: Mon Aug 8 17:35:16 2016 +0200 less config copying when executing events.
20160810 19:47:02< tad_> Trying that first.
20160810 19:47:48< celmin> …why'd you paste the entire commit info...
20160810 19:48:12< tad_> It is a one-liner and deleted what looks like a destruct-ish thing. I'm going to try three event-specific changes from the past month before I resort to bisect.
20160810 19:49:35< tad_> That is the one I'm trying to reverse first. And sorry about the long line. My mouse jumps sometimes and I don't notice it's grabbed too much
20160810 19:51:37-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160810 19:52:26< celmin> BTW vultraz, I'm looking at const_cast.
20160810 19:52:31< celmin> Just so you know.
20160810 19:52:34< vultraz> purge! purge!
20160810 19:52:55< celmin> Not sure, need to analyze all sorts of code.
20160810 19:55:36< vultraz> aw, I broke wesnoth
20160810 19:55:41< celmin> Yay! :P
20160810 19:55:57< fabi__> Finally :-)
20160810 19:56:09 * celmin flicks fabi__
20160810 19:59:27-!- JyrkiVesterinen [~JyrkiVest@78-27-104-228.bb.dnainternet.fi] has quit [Quit: .]
20160810 20:04:05< vultraz> well this is nice
20160810 20:04:17< celmin> Struggling through actions/attack.cpp
20160810 20:04:29< celmin> Trying to figure out whether this const_cast is actually necessary.
20160810 20:04:51< vultraz> wesnoth literally crashes before even appearing
20160810 20:05:05< celmin> dll errors?
20160810 20:05:15< celmin> I suppose that's unlikely...
20160810 20:05:29< celmin> Try debugging.
20160810 20:06:28< vultraz> #0 0x117b506 ) [clone .constprop.322] () (??:??)
20160810 20:06:29< vultraz> #1 0xcbf05a __do_global_ctors () (??:??)
20160810 20:06:30< vultraz> #2 0x4010dc __mingw_CRTStartup () (??:??)
20160810 20:06:35< vultraz> well this tells me nothing
20160810 20:06:53< gfgtdf> vultraz: sounds like an error during static initilisation
20160810 20:07:46< gfgtdf> vultraz: although not very iformative, did you ty adebug build ?
20160810 20:08:02< vultraz> hm I have an idea
20160810 20:10:40-!- louis94 [~~louis94@91.178.241.79] has joined #wesnoth-dev
20160810 20:11:53< vultraz> team.cpp was keeping a static vector of teams
20160810 20:12:37< vultraz> but is that the problem..
20160810 20:12:58-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160810 20:12:59< celmin> So it's crashing in a static constructor.
20160810 20:13:12< celmin> It could be?
20160810 20:13:18< celmin> Why does it need a static vector of teams?
20160810 20:13:36< tad_> @gtftdf: PR is up to 'fix' the infinite loop.
20160810 20:13:41< vultraz> it accesses it
20160810 20:13:45< vultraz> used to be static std::vector *&teams = resources::teams;
20160810 20:14:03< vultraz> i changed it to static std::vector &teams = resources::gameboard->teams();
20160810 20:14:04< celmin> Is it file-static or class-static?
20160810 20:14:07< vultraz> not sure how that could break tho..
20160810 20:14:09< vultraz> file
20160810 20:14:17< celmin> Why does it need it?
20160810 20:14:31< celmin> I guess the problem is that the gameboard isn't initialized yet.
20160810 20:14:47< celmin> So why does it need a static vector?
20160810 20:15:00-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160810 20:15:23< vultraz> bunch of functions use it, but then why can't they use resources::gameboard->teams() directly..
20160810 20:15:44< irker747> wesnoth: Gregory A Lundberg wesnoth:master 200b2da5381b / src/game_events/handlers.cpp: Reverse commit 18d7736 https://github.com/wesnoth/wesnoth/commit/200b2da5381b7240831392efa38d8aab45f7c91d
20160810 20:15:46< irker747> wesnoth: gfgtdf wesnoth:master 65a8c4449533 / src/game_events/handlers.cpp: Merge pull request #741 from GregoryLundberg/GL_snub_infinite_loop https://github.com/wesnoth/wesnoth/commit/65a8c44495331de127b331f6cb1229f886b158ee
20160810 20:16:22< vultraz> yeah that's the problem
20160810 20:16:27< gfgtdf> tad_ you can just use git revert ot revert a commit (i asumed you didnt do it liek this because the commti message says reverse instead of revert)
20160810 20:16:27< vultraz> that line
20160810 20:16:47< gfgtdf> vultraz: which line ?
20160810 20:16:50< celmin> gfgtdf: git revert --edit maybe?
20160810 20:16:54< vultraz> static std::vector &teams = resources::gameboard->teams();
20160810 20:17:03< vultraz> that's what was causing the crash
20160810 20:17:16< celmin> Yes, presumably the gameboard isn't yet initialized.
20160810 20:17:21< vultraz> right
20160810 20:17:22< celmin> But why does it need that static vector?
20160810 20:17:25< gfgtdf> vultraz: where is that line
20160810 20:17:25< vultraz> I don't know
20160810 20:17:30< vultraz> gfgtdf: team.cpp
20160810 20:17:31< gfgtdf> vultraz: i'd say rmeove that line
20160810 20:17:35< celmin> Try removing it altogether.
20160810 20:17:52< gfgtdf> vultraz: and replace all usecases of 'teams ' with resources::gameboard->teams()
20160810 20:17:58< vultraz> ok
20160810 20:21:03-!- louis94 [~~louis94@91.178.241.79] has quit [Ping timeout: 250 seconds]
20160810 20:26:05< vultraz> ok, everything seems ok
20160810 20:26:57< celmin> Okay, I found the commit that introduced the const_cast...
20160810 20:27:20< celmin> "Fixed segmentation fault when WML modified and killed attacker and defender in battle"
20160810 20:28:04< vultraz> sounds like const_cast is a hack
20160810 20:28:23< irker747> wesnoth: Charles Dang wesnoth:master 6235e18bbd12 / src/ (62 files in 17 dirs): Replace resources::teams with resources::gameboard->teams() https://github.com/wesnoth/wesnoth/commit/6235e18bbd12751631df0d6d457b8a358354e183
20160810 20:28:37< celmin> So, how should I test this...
20160810 20:28:46< celmin> An attack_start event that kills one of the units?
20160810 20:28:52< vultraz> I guess so
20160810 20:28:55< celmin> Or an attacker_hits event or something?
20160810 20:29:16< vultraz> yeah
20160810 20:29:35< celmin> Think I'll go with the latter...
20160810 20:29:50< vultraz> someone should do resources::units next
20160810 20:30:13< celmin> Removing it, you mean?
20160810 20:30:27< vultraz> convert it to resources::gameboard->units()
20160810 20:34:46< celmin> ...
20160810 20:34:58< celmin> I can't seem to select a unit...
20160810 20:35:18< celmin> Maybe it's just VNC being weird...
20160810 20:36:26< celmin> Was it already selected? Didn't see like it, but who knows.
20160810 20:46:58-!- Shiki [~Shiki@141.39.226.227] has quit [Quit: Verlassend]
20160810 20:47:49< celmin> ^seem
20160810 20:49:04-!- louis94 [~~louis94@91.178.241.79] has joined #wesnoth-dev
20160810 20:49:48< celmin> Can someone else make sure it's not just me?
20160810 20:49:57< celmin> I can select with n and similar, but not by clicking.
20160810 20:50:37< celmin> Hmm, if I totally remove that const_casting code, I don't get a segfault.
20160810 20:51:13< celmin> Buuut, I'm not sure if that's because the code has changed or just because of circumstance...
20160810 20:52:07< celmin> Incidentally, it was added back in 1.5.2.
20160810 20:54:34< celmin> Apparently EliDupree helped track the bug down, but who knows if he'd remember something that long ago.
20160810 20:55:02< EliDupree> Oh hey, what's up?
20160810 20:55:18< celmin> Hi.
20160810 20:56:41< celmin> Roughly speaking, I want to undo a bugfix commit from 1.5.2, but I need to verify that it doesn't reintroduce the bug.
20160810 20:57:48< celmin> [Aug 10@4:27:20pm] celmin: "Fixed segmentation fault when WML modified and killed attacker and defender in battle"
20160810 20:58:04< celmin> I guess 1.5.3, actually.
20160810 20:58:07< EliDupree> Line number?
20160810 20:58:26< celmin> As in, the current location of the relevant code?
20160810 20:58:31< EliDupree> yes
20160810 20:58:44< gfgtdf> vultraz: does the gui1 sidde overwie not work pererly with hidden sides ?
20160810 20:59:01< celmin> src/actions/attack.cpp:867-874
20160810 20:59:08< vultraz> gfgtdf: hm?
20160810 20:59:17< gfgtdf> vultraz: also i think stats is a bad name f thats really the side overwiew, dialog, stats sounds like stattics dialog to me.
20160810 20:59:42< vultraz> gfgtdf: the statistics dialog if different
20160810 20:59:47< gfgtdf> vultraz: does the gui1 sides overwie dialog now work prperly with hidden sides ?
20160810 21:00:00< vultraz> gfgtdf: it never displayed hidden sides
20160810 21:00:02-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has quit [Ping timeout: 258 seconds]
20160810 21:00:08< vultraz> that's the point of them being hidden
20160810 21:00:12< gfgtdf> vultraz: yes i know
20160810 21:00:27< vultraz> the gui2 dialog doesn't display them either
20160810 21:00:41< vultraz> gfgtdf: if you mean sides with no leader, I fixed that
20160810 21:01:23< gfgtdf> vultraz: i mean hidden side, from looking at the code i wonder how sorting cn aork correctly with hidden side if you use the row index to lookup in teams()
20160810 21:01:44< vultraz> gfgtdf: oh
20160810 21:01:46< vultraz> hm
20160810 21:01:49< vultraz> I hadn't considered that
20160810 21:02:00< vultraz> celmin: I can select units by click fine
20160810 21:02:13< celmin> Okay, that's good.
20160810 21:02:13< gfgtdf> vultraz: but i didnt test so i aske you
20160810 21:02:52< vultraz> gfgtdf: I guess it doesn't matter where the hidden sides would be sorted into because they never display on the table
20160810 21:03:24< vultraz> so even if it's like 1 visible, 2 hidden, 3 visible, you still see only 1 and 3 and it doesn't matter where 2 is
20160810 21:03:56-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160810 21:04:19< vultraz> yeah that seems to be thecase
20160810 21:04:36< gfgtdf> vultraz: but the question si wteher teh sort will still be correct
20160810 21:05:06< vultraz> seems so, yes
20160810 21:05:17< gfgtdf> vultraz: so like if side2gold < side1gold < side3gold
20160810 21:05:25< gfgtdf> vultraz: and team 2 is hidden and you sort by gold
20160810 21:05:47< vultraz> you'll still see S1gold < S2gold
20160810 21:05:52< vultraz> er
20160810 21:05:54< vultraz> S3*
20160810 21:06:01< vultraz> because S2 doesn't have a row
20160810 21:06:41< gfgtdf> vultraz: but team 3 has how index 1
20160810 21:06:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160810 21:06:49-!- wedge010 is now known as wedge009
20160810 21:07:02< vultraz> hmmm
20160810 21:07:32< celmin> So EliDupree, do you remember anything?
20160810 21:07:40< EliDupree> celmin: Okay, I have no idea what the const_cast is for, but the attack code has historically had a lot of bugs related to removing the units during the attack, and it looks like the code has not been cleaned up much since that time. Ideally you would run some sort of a test suite that covers the cases of removing the attacker only, the defender only, and both the attacker and defender, in every possible combat event.
20160810 21:07:58< celmin> Hmm, okay. That sounds doable.
20160810 21:08:59< vultraz> gfgtdf: it seems to work regardless
20160810 21:09:03< EliDupree> The trouble is that that still doesn't cover everything that could possibly go wrong (like leaving the unit there but removing or replacing the attack they are using)
20160810 21:09:57 * celmin nods.
20160810 21:10:02< gfgtdf> vultraz: i just tested
20160810 21:10:30< gfgtdf> vultraz: start httt, hide side 1, and then sort by gold in side overwie dialog
20160810 21:10:39< gfgtdf> vultraz: it doesnt work
20160810 21:11:07< EliDupree> In some of those cases, it's not obvious what the correct behavior WOULD be, but at least the code should guarantee that it doesn't crash or anything. For that, what should really be done is to rewrite the code in a more thorough way so that it doesn't use so many potentially-unsafe pointers
20160810 21:11:54< vultraz> gfgtdf: with hidden sides?
20160810 21:12:10< gfgtdf> vultraz: liek i said hide side1
20160810 21:12:26< gfgtdf> vultraz: i did that with wesnoth.sides[1].hidden=true in lua console
20160810 21:12:49< EliDupree> Like, do things in a more C++ way with std::shared_ptr or std::unique_ptr as appropriate
20160810 21:13:22< celmin> Maybe some std::weak_ptr
20160810 21:13:30< EliDupree> Since I suppose no one would take my favorite option, which is to rewrite the entire wesnoth code base from scratch :-P
20160810 21:13:40< celmin> No-one but fabi, yeah.
20160810 21:13:47< vultraz> EliDupree: fabi__ would love that :P
20160810 21:14:02 * celmin had deliberately not pinged him.
20160810 21:14:05< celmin> :/
20160810 21:14:20 * celmin assuming he pings only by his exact nick, which isn't always the case.
20160810 21:14:22< EliDupree> I don't know much about fabi but I like them already :D
20160810 21:15:02< celmin> Okay, so I'll come back to the attack one a bit later.
20160810 21:15:16< vultraz> gfgtdf: it seems to be working for me..
20160810 21:15:28< fabi__> EliDupree: :-) We know each other since ages. You did "Unrest in Elfland".
20160810 21:15:30< celmin> This const_cast in the config class seems to be a direct result of all_children_iterator() returning const iterators...
20160810 21:15:33< gfgtdf> vultraz: can you give a sceenshow ?
20160810 21:16:03< gfgtdf> screenshot*
20160810 21:16:28< celmin> If I think about it… this is internal to the config class, so there's no particular reason it needs to use the iterators at all...
20160810 21:16:40< vultraz> gfgtdf: oh wait you're right
20160810 21:16:46< vultraz> gfgtdf: i was mistaken :(
20160810 21:16:51< vultraz> gfgtdf: how would one fix this?
20160810 21:17:16< vultraz> i suppose i could return low default values if a side is hidden
20160810 21:17:21< EliDupree> I remember a few people from the old days of wesnoth, but that was, like, half my lifetime ago :-)
20160810 21:17:35< vultraz> half your lifetime? interesting
20160810 21:18:58< EliDupree> Yeah, I think I was 13 when I joined the forums, and I am almost 26 now
20160810 21:19:08< celmin> Huh, config::child_list is a vector instead of a vector ...
20160810 21:19:42 * vultraz was also 13 when he joined the forums
20160810 21:20:08 * EliDupree makes the sign against the evil raw pointer
20160810 21:20:31< EliDupree> I've recently started coding a major project in Rust, so all these unsafe pointers look REALLY old-fashioned to me
20160810 21:20:54< celmin> I don't see why it needs to be a pointer at all.
20160810 21:21:02< vultraz> so, are we not supposed to use raw pointers now? :P
20160810 21:21:22< celmin> vultraz: As little as possible, yes. shared_ptr, unique_ptr, whatever.
20160810 21:21:27< EliDupree> Well, if something else keeps pointers to config, then you resize the vector, they need to be pointers
20160810 21:21:36< celmin> (Those are fine, BTW).
20160810 21:21:38< celmin> Hmm.
20160810 21:21:55< vultraz> so is that why you make the UPP use references
20160810 21:21:57< EliDupree> Boost even has a type specifically for that: stable_vector
20160810 21:22:13< vultraz> of course it does *eyeroll*
20160810 21:22:43< celmin> EliDupree: Nice thought, but remove_child deletes the pointer.
20160810 21:23:07< celmin> I suppose it ensures that pointers to elements still work if the vector chooses to reallocate.
20160810 21:23:09< EliDupree> So? Adding new elements breaks old iterators as well
20160810 21:23:17< EliDupree> Exactly
20160810 21:23:20< celmin> Okay.
20160810 21:23:26< celmin> So that's the point of that, I guess.
20160810 21:23:34< vultraz> this makes no sense to me
20160810 21:23:42< celmin> What doesn't?
20160810 21:23:58< vultraz> all this stuff about pushing pointers around
20160810 21:25:54< EliDupree> It's not that complicated. If you accidentally use a invalid pointer, your program might crash and/or have security vulnerabilities. With the standard smart pointers, that can't happen
20160810 21:26:42< EliDupree> Because they guarantee that the memory is not freed until after there are no more pointers to it
20160810 21:27:21< vultraz> then why aren't we using smart pointers everywhere
20160810 21:27:29< celmin> Provided that you always use only the standard smart pointers.
20160810 21:27:47< EliDupree> Literally because we aren't very good coders.
20160810 21:27:49< celmin> vultraz: They probably weren't around when Wesnoth started (except auto_ptr which was problematic).
20160810 21:28:10< EliDupree> (Or because we are working with legacy code, yes)
20160810 21:28:22< vultraz> I like to think the quality of coder has increased
20160810 21:29:02< vultraz> probably is the codebase
20160810 21:29:39< celmin> As expected, removing the config const_cast was easy - just iterate through the private members instead of using the public iterator interface.
20160810 21:29:51< celmin> (Though ideally a non-const version of that interface would be provided, but whatever.)
20160810 21:30:01< EliDupree> In Rust you're not even ALLOWED to use raw pointers unless you explicitly mark that part of the code "unsafe {}"
20160810 21:30:11< EliDupree> And you are required to use smart pointers for everything
20160810 21:30:19< EliDupree> Because it's just better
20160810 21:30:45< vultraz> BfW Presents: The Tyranny of the Raw Pointer. A tragedy in 3 acts.
20160810 21:31:12< EliDupree> In the third act, the raw pointer gets impaled upon its own point!
20160810 21:31:22< EliDupree> Come see it today!
20160810 21:32:41< gfgtdf> hmm but in c++ shared_ptr are rather slow, most newer languages have a gc so that basically everything is 'shared' and doesnt even need a refcount.
20160810 21:33:00< celmin> Hmm, the const_casts in config.hpp look probably safe...
20160810 21:33:12< celmin> They're implementing const methods in terms of non-const methods.
20160810 21:33:39< celmin> Is there a better way to do this though...
20160810 21:33:45< celmin> Beyond duplicating the whole method.
20160810 21:34:07< EliDupree> Rust doesn't have a garbage collector, but it does use a slightly better shared pointer type
20160810 21:34:26< celmin> I'm not sure I like the indeterminacy of a garbage collector.
20160810 21:34:38< celmin> Maybe that's why I keep using C++ instead of Java or similar.
20160810 21:35:16< celmin> I suppose Rust might be worth checking out some day.
20160810 21:35:56< vultraz> i was thinking of checking out Haskell
20160810 21:36:10< celmin> That's a totally different paradigm - functional programming.
20160810 21:36:16< vultraz> every time I hear Rust I think of the game :|
20160810 21:36:20< celmin> Maybe it'd help you understand binds and lambdas though. :P
20160810 21:36:41< celmin> (I dunno if it would or not.)
20160810 21:36:44< vultraz> I understand binds and lambdas, what're you talking about
20160810 21:36:46< EliDupree> Haskell is wonderful, but it's not great for things that need to be high-performance. Rust is both efficient AND modern and memory-safe
20160810 21:36:50< celmin> (Don't really know Haskell myself.)
20160810 21:37:16< vultraz> you are thinking of 2014!vultraz
20160810 21:37:25< vultraz> 2014!vultraz had no idea what binds and lambdas did
20160810 21:37:28< EliDupree> I used C++ for years and years, but now I wouldn't bother writing anything in C++ if I can write it in Rust instead – Rust serves basically the same purposes as C++, but better
20160810 21:37:31< celmin> I heard Rust had n! runtime for something (they fixed it though).
20160810 21:37:33< fabi__> EliDupree: I like Haskell very much as well.
20160810 21:37:55< vultraz> EliDupree: including gamedev?
20160810 21:38:22< EliDupree> Yes definitely, in fact my current project is a game backend thing
20160810 21:38:23< celmin> Hmm, src/ai/contexts.cpp:366 uses a const_iterator… why?
20160810 21:38:34< vultraz> hmm
20160810 21:38:37< vultraz> interesting
20160810 21:38:50< vultraz> Rust has a similar syntax to c++, it looks like
20160810 21:38:51< celmin> If I made it non-const iterator I could remove the const_cast… should I?
20160810 21:39:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160810 21:39:37< celmin> Actually, maybe I should refactor the const_cast into the unit_movement_resetter class...
20160810 21:40:01< EliDupree> Rust takes a little getting used to as a C++ programmer, because some things that look very similar actually behave differently, but it was certainly worth it from my perspective
20160810 21:40:58-!- iwaim__ [~iwaim@2001:2c0:40e:2002:0:4:14:80] has joined #wesnoth-dev
20160810 21:41:34< vultraz> reminds me a little of FFL
20160810 21:42:23< celmin> FFL is kinda a functional language too, more like Haskell.
20160810 21:42:36< vultraz> yes
20160810 21:42:59< celmin> I dunno if FFL has first-class functions yet though. I know WFL doesn't, but FFL might.
20160810 21:43:25< celmin> (Also, I doubt FFL has higher-order functions like "compose".)
20160810 21:43:33-!- Appleman1234 [~Appleman1@KD036012028174.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160810 21:43:35< vultraz> honestly, I've never really paid much attention to the functional vs oo thing
20160810 21:43:46< fabi__> celmin: Speaking about WFL, any news regarding its grammar?
20160810 21:43:48< celmin> Shrug
20160810 21:44:01< celmin> fabi__: What, are you saying you want a WFL grammar too?
20160810 21:44:18< celmin> I can probably write up a WML or WFL grammar if you want. Maybe put it on the wiki or something?
20160810 21:44:32< celmin> Using EBNF or something.
20160810 21:44:42 * vultraz ponders moving everything to le github wiki.
20160810 21:44:48< celmin> No.
20160810 21:44:55 * vultraz is angry with mediawiki
20160810 21:44:57-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160810 21:44:59< celmin> Why?
20160810 21:45:12< fabi__> celmin: PEG notation would be cool.
20160810 21:45:17< celmin> Moving to github wiki would lose everything.
20160810 21:45:18< vultraz> annoying-ass platform doesn't even give admins control over user metadata without extensions
20160810 21:45:33< celmin> fabi__: No idea what that is, link?
20160810 21:45:35< vultraz> celmin: (I'm only being slightly serious :P )
20160810 21:45:47< celmin> Okay, not everything.
20160810 21:46:25< celmin> I used to like MediaWiki more, but since discovering Markdown I think it'd be better (for new wikis) to use wiki software that uses that.
20160810 21:46:31< vultraz> for one, we wouldn't get spam
20160810 21:46:49< celmin> You need a github account to edit the github wiki, right?
20160810 21:46:51< fabi__> celmin: https://en.wikipedia.org/wiki/Parsing_expression_grammar
20160810 21:47:08< vultraz> you need an account to edit our wiki
20160810 21:47:20< celmin> vultraz: But not a github account.
20160810 21:47:23< celmin> :P
20160810 21:47:43< celmin> fabi__: So, you want WML, or WFL, or both?
20160810 21:48:00< fabi__> both, please :-)
20160810 21:48:04< vultraz> honestly, the reason this won't happen is absolutely no one will want to sort through the mountain of garbage our wiki has.
20160810 21:48:11< vultraz> I tried once :|
20160810 21:48:13< vultraz> I failed
20160810 21:48:21< celmin> Okay, I don't know how soon I can do it, but I'll let you know.
20160810 21:48:44< celmin> vultraz: From what I heard, you didn't fail at all.
20160810 21:48:59< celmin> Also, most of that garbage is "off the beaten track" anyway./
20160810 21:49:09< celmin> Orphaned pages, for example.
20160810 21:49:26< vultraz> heh, thanks
20160810 21:49:31< fabi__> celmin: I already have a grammar that is good enough to parse the first scenario of AoI. In a line by line approach.
20160810 21:50:10< vultraz> anyway, I'm looking at the gui2 mp create screen
20160810 21:50:16< celmin> Not sure I'll end up with a good normalized grammar either - like avoiding left-recursion or whatever.
20160810 21:50:33< vultraz> need to ponder a layout here
20160810 21:52:07< celmin> I prefer using | rather than / as alternation...
20160810 21:52:22< celmin> And this !() and &() syntax seems weird, so I'd probably just avoid it...
20160810 21:52:32< celmin> Also, not a fan of the left arrow...
20160810 21:52:50 * celmin commenting on the PEG link from fabi__
20160810 21:53:54< celmin> Anyway, back to const_cast… unit_movement_resetter is by definition meant to temporarily violate constness, so I think moving the const_cast there is better.
20160810 21:54:17< celmin> Though I don't know if it's called in other places with a const unit.
20160810 21:54:55< celmin> Alright, next up is Lua unique registry keys...
20160810 21:55:22< celmin> Using the example method from PIL works in C, but in C++ it requires a const_cast...
20160810 21:55:49< fabi__> celmin: Lua unique registry keys?
20160810 21:55:58< vultraz> celmin: do you think mp create needs to keep the chat area
20160810 21:55:59< celmin> On the other hand, it's not like Lua does anything with the key except store it…
20160810 21:56:23< vultraz> waiting for loaders certainly does
20160810 21:56:42< celmin> fabi__: https://www.lua.org/pil/27.3.1.html
20160810 21:57:01< celmin> vultraz: The third screen, where you set factions and leaders and such, certainly does.
20160810 21:57:09< vultraz> yes
20160810 21:57:12< vultraz> that's what I said
20160810 21:57:13< celmin> Not sure if the other two screens do.
20160810 21:57:18< vultraz> two?
20160810 21:57:29< celmin> 1) Select scenario. 2) Set scenario settings.
20160810 21:57:38< vultraz> that's one screen..
20160810 21:57:45< celmin> No, it's two.
20160810 21:57:51< vultraz> eh
20160810 21:57:52< vultraz> ?
20160810 21:57:58< vultraz> OH
20160810 21:58:00< vultraz> derp
20160810 21:58:11< vultraz> yeah that can be made one.
20160810 21:58:22< vultraz> in fact this protype was already leaning that way
20160810 21:58:24< vultraz> prototype
20160810 21:58:30< celmin> I'm dubious about making it one screen.
20160810 21:58:36< celmin> I don't think it would fit very well.
20160810 21:58:42< vultraz> well if I remove the chat area
20160810 21:58:48< vultraz> and that unused space on the side
20160810 21:58:53< vultraz> I have a LOT more space to work with
20160810 21:58:54< celmin> Hmm...
20160810 21:59:17< vultraz> (it doesn't have a chat area yet)
20160810 21:59:37< celmin> I'm really not sure on whether it needs a chat area...
20160810 22:00:29 * celmin wonders if fabi__ actually had something to say there
20160810 22:07:02-!- Appleman1234 [~Appleman1@KD036012028079.au-net.ne.jp] has joined #wesnoth-dev
20160810 22:12:12-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160810 22:12:24< fabi__> celmin: ? About what?
20160810 22:12:40< celmin> I said something, you asked a question, I responded with a link.
20160810 22:13:32< fabi__> Well, I mostly code in Lua space. I have not yet done any (c++) host stuff.
20160810 22:13:56< celmin> Ah, okay, so you probably wouldn't have anything to say then.
20160810 22:13:57< fabi__> But ice³ is very firm when it comes to the lua host.
20160810 22:53:45< vultraz> blah
20160810 22:53:48< vultraz> gui2 y u do dis
20160810 22:56:47< vultraz> I wonder how hard it wold be to implement fixed sizes for widgets
20160810 22:57:05-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20160810 22:57:05-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Client Quit]
20160810 22:57:05< Aginor> vultraz: don't, fixed sizes is evil
20160810 22:57:12< vultraz> eh?
20160810 22:57:22< Aginor> vultraz: fixed sizes look shite when you resize
20160810 22:59:12< vultraz> granted
20160810 22:59:47< vultraz> I shall just have to play around with grow factors :)
20160810 23:03:12< gfgtdf> Aginor: well it is already possible to specify a min size of widgets.
20160810 23:03:21< vultraz> it is?
20160810 23:03:57< gfgtdf> Aginor: also there are situations that teh current layout algo cannot handle very well, specialyl when the size changes during the dialog (withotu window resizing)
20160810 23:04:04< gfgtdf> vultraz: there isa force min size macro
20160810 23:04:09< vultraz> oh yeah
20160810 23:04:11< vultraz> I use that
20160810 23:04:39< gfgtdf> vultraz: GUI_FORCE_WIDGET_MINIMUM_SIZE i think
20160810 23:04:43< vultraz> yeah
20160810 23:06:08< Aginor> gfgtdf: min size != fixed size
20160810 23:06:31< Aginor> gfgtdf: the layout code needs all kinds of fixing and improving, it's dog slow
20160810 23:07:47< vultraz> duh
20160810 23:08:17< vultraz> ok, let's see here..
20160810 23:08:34< vultraz> there needs to be a list for Eras
20160810 23:08:37< vultraz> and Modifications
20160810 23:08:47< vultraz> Eras can use the sexy combobox.
20160810 23:09:48< celmin> And a list for scenarios etc.
20160810 23:09:53< celmin> And a description area.
20160810 23:09:57< vultraz> added that
20160810 23:10:08< vultraz> and a Load Game button
20160810 23:10:12< celmin> Note that the list for modifications is multi-select, whereas the others are single-select.
20160810 23:10:27< vultraz> checkboxes
20160810 23:10:33< vultraz> i mean
20160810 23:10:41< vultraz> technically we might have multi-select listboxes
20160810 23:10:50< celmin> I think we do, actually.
20160810 23:10:51< vultraz> but such a thing is blah
20160810 23:10:56-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20160810 23:11:13< vultraz> very possibly broken
20160810 23:11:18< celmin> Worth trying.
20160810 23:11:19< vultraz> in the clusterfuck that is tlistbox
20160810 23:11:22< vultraz> and tgenerator
20160810 23:11:25< vultraz> and tgenerator_
20160810 23:11:31< celmin> I think it's better than checkboxes.
20160810 23:11:50< celmin> Although using checkboxes does have one advantage.
20160810 23:12:08< celmin> You can select a modification to view its description without affecting which modifications are active.
20160810 23:12:18< vultraz> yes
20160810 23:12:20< vultraz> exactly
20160810 23:12:59< gfgtdf> you coudl also just show teh desctiption ina toltip
20160810 23:15:49< vultraz> gfgtdf: do you want to work on making rightclick and theme menues display a gui2 dropdown dialog?
20160810 23:15:52< vultraz> menus
20160810 23:16:22< gfgtdf> vultraz: i currently have no such plan.
20160810 23:16:37< gfgtdf> vultraz: is this related to the mp screen stuff ?
20160810 23:16:43< vultraz> no
20160810 23:23:07< vultraz> god, it's so annoying to have to restart wesnoth for gui changes to take effect
20160810 23:24:08< vultraz> praise anura's immediate object-reload system.
20160810 23:24:24< gfgtdf> vultraz: well its still better than recompoiling wesnoth for c++ changes to have an effect
20160810 23:24:33< vultraz> true
20160810 23:25:03< celmin> I don't want to praise Anura's anything.
20160810 23:25:11< gfgtdf> vultraz: also i guess its not imposible to add a gui-debug mode where it always relads it from disk
20160810 23:26:24< vultraz> that would be amazing
20160810 23:26:48< Aginor> a graphical editor would be nice
20160810 23:27:01< vultraz> a million dollars would also be nice
20160810 23:27:18 * celmin flicks vultraz
20160810 23:27:28< celmin> Aginor: You mean for GUI WML?
20160810 23:27:31< vultraz> though if we had that million dollars we could also have the graphical editor
20160810 23:28:26< Aginor> celmin: yes, something where you can drag and drop components and it generates wml for you
20160810 23:28:39< celmin> Would be helpful, yeah...
20160810 23:28:42-!- irker747 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160810 23:29:08< vultraz> even anura doesn't have that
20160810 23:29:13< vultraz> well, it does for the level editor
20160810 23:29:16< vultraz> but not object editing
20160810 23:31:03< Aginor> vultraz: also, throwing bile at everything gui2 or mordante won't do anything but to foster negativism and make people unmotivated. It's not helping with making the situation better :)
20160810 23:31:19< vultraz> Aginor: I know
20160810 23:31:39< vultraz> but what's so frustrating for me is I can't *do* anything about it.
20160810 23:31:50< vultraz> Like, take this GUI1 -> GUI2 converstion
20160810 23:32:07< vultraz> I can actually see GUI1 sucks and replace its dialogs with something better
20160810 23:32:16< Aginor> vultraz: you can, you're just choosing not to :)
20160810 23:32:16< vultraz> But for GUI2's own flaws... I can't do shit
20160810 23:32:37< vultraz> Aginor: I'm not the amazing coder you or gfgtdf or celticminstrel is :|
20160810 23:32:47< vultraz> I don't *understand* the gui2 internals.
20160810 23:32:48< celmin> Huh? I'm an amazing coder?
20160810 23:32:52< celmin> Okay sure whatever.
20160810 23:33:06< celmin> I can't say I really understand the GUI2 internals either though.
20160810 23:33:16< celmin> Maybe I understand a little better than you, I dunno.
20160810 23:33:46< Aginor> vultraz: but what you can do is to motivate people to help out
20160810 23:33:57< Aginor> negativism is having the exact opposite effect
20160810 23:34:12 * celmin is probably part of that too...?
20160810 23:34:30 * Aginor throws the same arguments at celmin
20160810 23:34:53< Aginor> we could get this sorted if we wanted to, and worked together on it
20160810 23:35:11< vultraz> Aginor should be a life coach
20160810 23:35:19< vultraz> (no sarcasm)
20160810 23:35:43< celmin> I don't even know what that means.
20160810 23:35:54< Aginor> but that would involve changes in what/how we work on it and what we prioritise
20160810 23:36:12< Aginor> and attitude adjustments ;)
20160810 23:36:19< fabi__> hmmm
20160810 23:36:19< celmin> BTW, while I wouldn't mind swapping GUI2 out for something else, I also wouldn't mind keeping it if it gets fixed up nicely.
20160810 23:36:23< Aginor> not just from you two, but me too ;)
20160810 23:36:35< celmin> For example, cleaning out all the asserts.
20160810 23:36:35< vultraz> I agree with celmin
20160810 23:36:42< vultraz> GUI2 has a kernel of a good idea
20160810 23:37:09< vultraz> when it works it can be enjoyable to work with.
20160810 23:37:24< vultraz> But then you come across issues that SHOULD be simple to fix but aren't
20160810 23:37:58< vultraz> The best analogy I can draw here is to my designing of the tgroup class a few months back.
20160810 23:38:01< Aginor> but we could probably simplify/fix things if we actually made a coordinated, focused, effort
20160810 23:38:22< vultraz> I thought it needed all kinds of setters and getters and members in twindow
20160810 23:38:31< Aginor> it wouldn't be instant gratification, it would probably be a slow, tough, haul
20160810 23:38:35< vultraz> until celmin pointed out it really needed none of that
20160810 23:38:38< Aginor> but with substantial long term efforts
20160810 23:39:28< gfgtdf> wasn't there soemone on teh forum who wrote a graphical editor for gui2 ?
20160810 23:39:32< vultraz> Aginor: coordination and long-term effort requires a leader
20160810 23:39:56< vultraz> I'm supposed to be that leader, but I do feel bad telling people what they should work on :/
20160810 23:42:05< Aginor> vultraz: don't tell people what to work on, motivate them to work on something instead
20160810 23:42:53< fabi__> How many active developers do you still have?
20160810 23:42:56< Aginor> vultraz: read a few books on leadership as well, it'll serve you well in all kinds of situations
20160810 23:43:02< celmin> Maybe … five or so?
20160810 23:43:31< vultraz> fabi__: gfgtdf, celticminstrel, myself, and Aginor.
20160810 23:43:50< celmin> I feel like you're missing one… oh well.
20160810 23:43:57< celmin> Maybe I'm imagining it.
20160810 23:44:17< vultraz> oh, wedge009
20160810 23:44:23< Aginor> I'm not sure I should be counted, I'm not intending to do much about anything at the moment and I'm still trying to decide what to do in liu of the situation re wesnoth.inc
20160810 23:44:23< fabi__> zookeeper?
20160810 23:44:37< vultraz> but he's more quality control
20160810 23:44:49< fabi__> rofl
20160810 23:44:50< vultraz> zookeeper doesn't develop anything
20160810 23:44:59< Aginor> wedge009 has been crucial to what we've been doing lately
20160810 23:45:08< vultraz> that is true
20160810 23:45:10< Aginor> he's improved things immensely
20160810 23:45:18< fabi__> What is he on?
20160810 23:45:26< vultraz> windows.
20160810 23:45:33< fabi__> working on
20160810 23:45:45< fabi__> what has improved immesely?
20160810 23:46:07< vultraz> he focuses on testing and making sure stuff doesn't break.
20160810 23:46:35< fabi__> Aginor: The wesnoth.inc situation is concerning me as well.
20160810 23:46:47< vultraz> so, if you strip out Aginor and the non-main C++ coders... you have 3 people :|
20160810 23:46:48< vultraz> pretty grim
20160810 23:46:51< fabi__> s/concerning/bothering
20160810 23:47:16< celmin> Did both of you listen to what zookeeper said about it?
20160810 23:47:31< fabi__> ?
20160810 23:47:35< celmin> The wesnoth inc thing.
20160810 23:47:38< Aginor> celmin: when?
20160810 23:47:39< vultraz> I hope jyrk...whathisname does more stuff.
20160810 23:47:58< fabi__> celmin: Please tell us what he said or where to find it.
20160810 23:48:00< celmin> Vultraz was going on about it, Aginor said it bugged him, and then zookeeper chimed in.
20160810 23:48:17< celmin> Something like that.
20160810 23:48:50< celmin> I dunno when exactly, but it wasn't that long after Aginor said something about "bait-and-switch", I think?
20160810 23:49:02< Aginor> so in the last week
20160810 23:49:06< celmin> Yeah.
20160810 23:49:11 * Aginor shrugs
20160810 23:49:21< celmin> I dunno if it'd change how you feel about it.
20160810 23:49:36< Aginor> I still think it needs to be clarified somewhere more official than on a logged irc channel
20160810 23:49:50 * celmin shrugs
20160810 23:49:58< Aginor> celmin: transparency, financial statements, election processes, meeting minutes would change how I feel about it
20160810 23:50:10< Aginor> oh, and a governing constitution
20160810 23:50:35< vultraz> election processes?
20160810 23:50:38< vultraz> what election processes
20160810 23:50:46< vultraz> there are no election processes
20160810 23:51:14< celmin> I think the idea is something like, it's related to FOSS so it should be democratic, or something? I dunno really.
20160810 23:51:32< celmin> Mind you, election doesn't necessarily say anything about who does the electing...
20160810 23:51:33< vultraz> none of us have any say who "heads" the company.
20160810 23:51:53< Aginor> vultraz: exactly
20160810 23:52:01< vultraz> it exists, dave is on top, period.
20160810 23:52:15 * celmin is pretty sure that nothing vultraz says can make this better.
20160810 23:52:16< vultraz> there are no official meetings either
20160810 23:52:31< Aginor> it could be benign, or it could be dave's "skim off cream" scheme, we won't no and we cannot tell
20160810 23:53:09< vultraz> that is true
20160810 23:54:00< Aginor> therein lies a large part of the problem
20160810 23:54:09< vultraz> indeed
20160810 23:54:25< Aginor> I'm all for contributing to a FOSS project, let's so to someone's vacation in bahamas
20160810 23:54:43< Aginor> or random hobby projects
20160810 23:54:54< fabi__> ^
20160810 23:55:05< vultraz> Pretty sure dave makes enough at Valve to not need wesnoth inc's funds :P
20160810 23:55:21< vultraz> also, our total budget isn't nearly enough to fund such extravagant lifestyles.
20160810 23:55:42< Aginor> vultraz: that argument is irrelavant
20160810 23:55:54< vultraz> It is.
20160810 23:55:57< vultraz> But it has to be said.
20160810 23:56:30< Aginor> he could be a billionaire for the sake of the argument and it wouldn't change a single thing
20160810 23:57:13< fabi__> There has been art payed from the Wesnoth founds for a different game.
20160810 23:57:22< fabi__> And I have not even been ask or informed about out.
20160810 23:57:27< fabi__> That makes me angry.
20160810 23:57:42< vultraz> Why would *you* specifically be asked or informed?
20160810 23:57:50< celmin> I don't see how Wesnoth could be called anything other than a FOSS project - it's indisputably released under GPL, right?
20160810 23:58:03< fabi__> Because I was a major contributor for the last 9 years.
20160810 23:58:12< Aginor> celmin: FOSS != free as in beer
20160810 23:58:13< vultraz> you've been gone for the past 2 years
20160810 23:58:17< vultraz> :|
20160810 23:58:23< celmin> So even if Dave wanted to disown it or something, he can't really prevent people from working on it. At most he could maybe force it to be renamed.
20160810 23:58:42< celmin> Aginor: I know, but GPL.
20160810 23:58:49< Aginor> celmin: or he could just keep it and skim off any income
20160810 23:59:04< Aginor> celmin: GPL == free as in freedom, GPL != free as in beer
20160810 23:59:17< celmin> …I know.
20160810 23:59:27< fabi__> vultraz: When was the 1.12 release?
20160810 23:59:29< celmin> And Wesnoth is indisputably GPL.
20160810 23:59:34< vultraz> in 2014
20160810 23:59:36< vultraz> October.
--- Log closed Thu Aug 11 00:00:30 2016