--- Log opened Fri Aug 12 00:00:57 2016
20160812 00:04:51< vultraz> ahh got it
20160812 00:04:54< vultraz> wrong widget definition
20160812 00:07:19-!- louis94 [~~louis94@91.178.242.169] has quit [Ping timeout: 260 seconds]
20160812 00:10:31< vultraz> celmin: so it seems if you try to access a config child that doesn't exist, you get an "mandatory wml child missing yet untested for. please report" error and I think an exception is thrown.
20160812 00:10:48< celmin> vultraz: Check has_child first.
20160812 00:10:56< celmin> Not sure if that takes the index though.
20160812 00:11:05< vultraz> right
20160812 00:11:12< celmin> You could also use child_or_add or child_or_empty.
20160812 00:11:12< vultraz> but this was more about the behavior in general
20160812 00:11:18< vultraz> why does it need to throw an exception
20160812 00:11:35< celmin> I dunno. Seems to make sense though somehow.
20160812 00:17:58< vultraz> hmmm
20160812 00:18:04< vultraz> I wonder if something like this works..
20160812 00:18:38< vultraz> oh wait, it wouldn't
20160812 00:18:46< vultraz> but still, would be nice if it did
20160812 00:19:18< vultraz> std::vector<std::string> = { cfg.children("option")["name"].str() }
20160812 00:19:29< vultraz> I guess one cannot even hack that with child_range
20160812 00:22:40< celmin> Well, you could do it with std::transform.
20160812 00:22:47< celmin> And a lambda.
20160812 00:22:56< celmin> Is it worth it
20160812 00:22:58< celmin> ^?
20160812 00:23:10< celmin> You don't need only the names, do you?
20160812 00:23:26< vultraz> to set up the combobox, yes
20160812 00:23:41< vultraz> haven't figured out how to handle the value= key
20160812 00:23:49< vultraz> right now im just getting stuff to show up
20160812 00:24:01< vultraz> then comes worrying about how to make it actually work :P
20160812 00:25:17-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Ping timeout: 265 seconds]
20160812 00:30:39< vultraz> ok, two down, two to go
20160812 00:35:32< celmin> Finally almost finished with this.
20160812 00:35:55< celmin> Maybe I should actually put it in a branch so it can be better tested, since it's turned into a fairly significant refactor.
20160812 00:38:00-!- pydsigner_ is now known as pydsigner
20160812 01:02:01< vultraz> shadowm, gfgtdf, celmin: https://drive.google.com/file/d/0B-mR9s8FduLLMGh0QmRNZUVCbFk/view?usp=sharing
20160812 01:02:43< celmin> So where do you select the era and modifications?
20160812 01:02:48< vultraz> General
20160812 01:02:56< celmin> Oh, okay.
20160812 01:05:49-!- gfgtdf_ [~chatzilla@x4e369c08.dyn.telefonica.de] has joined #wesnoth-dev
20160812 01:06:25< vultraz> i actually think the use of the treeview turned out pretty well
20160812 01:06:40< vultraz> since you can also collapse the options f
20160812 01:06:42< vultraz> s/f//
20160812 01:06:51< gfgtdf_> vultraz: does it also work on 800x600 ?
20160812 01:06:58< vultraz> probably not
20160812 01:07:49< vultraz> i think there's something about the way GUI2 handles the way that FORCE_MINIMUM_SIZE macro is implemented that causes it to go on the fritz.
20160812 01:08:50-!- gfgtdf [~chatzilla@x4e368369.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160812 01:08:59-!- gfgtdf_ is now known as gfgtdf
20160812 01:10:59< gfgtdf> vultraz: also the gui1 ersion had a button for each adon with option to reset its options to default
20160812 01:11:21< vultraz> hm, yes
20160812 01:11:24< vultraz> easy enough to add
20160812 01:11:56-!- irker830 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160812 01:16:22< vultraz> hmm
20160812 01:16:26< vultraz> where to place it, though
20160812 01:16:28< vultraz> so it looks best
20160812 01:16:31< vultraz> i guess at the end
20160812 01:16:49< vultraz> or maybe in the node header
20160812 01:18:26< vultraz> nah
20160812 01:22:47-!- irker685 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160812 01:22:47< irker685> wesnoth: Charles Dang wesnoth:master 62a299d1eb98 / / (3 files in 2 dirs): Mp Create: further progress, including adding a page for custom Options https://github.com/wesnoth/wesnoth/commit/62a299d1eb984439943d63726159218b4bfde434
20160812 01:25:12< vultraz> not fully satisfied with the placement of that Defaults button
20160812 01:35:51< celmin> There's still the problem of 800x600, you know.
20160812 01:36:21 * vultraz ignores this problem
20160812 01:36:29< celmin> Bad vultraz 
20160812 01:36:51< celmin> Is it possible to set it up so that you have two tabs visible simultaneously?
20160812 01:37:26< vultraz> what do you mean?
20160812 01:38:53< celmin> So that the left panel is logically a tab in the same group as those in the right panel, but it's still laid out roughly as you have it there.
20160812 01:39:16< vultraz> No
20160812 01:39:53< celmin> When you use find_widget, how often do you pass something other than the window as the base to search from?
20160812 01:40:31< vultraz> in dialogs, it's probably 98% of the time window.
20160812 01:40:37< vultraz> in dialogs in general*
20160812 01:40:45< vultraz> 99% even
20160812 01:40:57< celmin> I suppose listbox or treeview nodes are the remaining 1-2%?
20160812 01:41:35< vultraz> yeah
20160812 01:41:52< vultraz> there are a few other edge cases but that's basically it.
20160812 01:42:26< vultraz> why?
20160812 01:43:14< celmin> Well, the use of find_widget would constrain the extent to which the dialog can be redesigned without touching the code.
20160812 01:43:50< vultraz> and..?
20160812 01:44:15< celmin> And I would need to know that if I start fiddling with it.
20160812 01:44:32< celmin> …wait, what's that filter box on the top left?
20160812 01:45:29 * celmin was going to fiddle with the MP lobby too, but never got around to it...
20160812 01:45:47< vultraz> what do you mean what's the filter box
20160812 01:45:49< celmin> BTW, what's the resolution in that screenshot?
20160812 01:45:50< vultraz> it's a filter box
20160812 01:45:57< celmin> What does it filter?
20160812 01:46:02< vultraz> 1600x860
20160812 01:46:05< vultraz> what are you doing :|
20160812 01:46:07< celmin> There's nothing there for it to filter.
20160812 01:46:12< vultraz> don't change the layout
20160812 01:46:24< vultraz> celmin: it's going to filter the games list
20160812 01:46:25< celmin> I'm sorry, but that's almost certainly impossible.
20160812 01:46:33< celmin> Games list?
20160812 01:46:37< celmin> There is no games list?
20160812 01:46:43< vultraz> the list of scenarios
20160812 01:46:52< celmin> Then it should be with the scenario list.
20160812 01:46:57< celmin> Not off to the side randomly.
20160812 01:47:14< vultraz> I'd rather you let me handle the layout
20160812 01:47:24< celmin> It's quite clear that that's impossible.
20160812 01:47:31< vultraz> Why?
20160812 01:47:38< celmin> Your attitude is not suitable for handling the layout.
20160812 01:47:48< vultraz> What do you want to do?
20160812 01:48:00< celmin> [Aug 11@9:35:51pm] celmin: There's still the problem of 800x600, you know.
20160812 01:48:02< celmin> [Aug 11@9:36:21pm] • vultraz ignores this problem
20160812 01:48:03< vultraz> I don't want to rushing in and making random changes while I'm in the middle of working on it
20160812 01:48:07< vultraz> you*
20160812 01:48:17< celmin> I won't do anything soon.
20160812 01:48:28< celmin> I'll at least let your layout be mostly finalized first.
20160812 01:48:52< vultraz> the layout is mostly finished
20160812 01:49:08< celmin> BTW, is it enabled by the same MP lobby advanced pref?
20160812 01:49:19< vultraz> not yet
20160812 01:49:30< vultraz> because it doesn't actually create a game yet
20160812 01:51:34< celmin> Ah, makes sense, I guess.
20160812 01:55:21< vultraz> simply put, there is *no* way this dialog will fit on screen at 800x600
20160812 01:55:25< vultraz> no matter what you do
20160812 01:55:33< vultraz> absolutely no way
20160812 01:55:40< celmin> Then you need to redesign it.
20160812 01:55:43< vultraz> now, if you make the left panel a tab, maybe
20160812 01:55:48< celmin> Because it needs to fit on screen at 800x60.
20160812 01:55:51< celmin> ^600
20160812 01:55:57< vultraz> why do we even support that >_>
20160812 01:56:29< celmin> There's no particular reason not to.
20160812 01:56:52< celmin> I'm not sure you're right that it would be impossible though.
20160812 01:57:11< celmin> Which is why I said I'd fiddle with it later to see if I can get something that works.
20160812 01:57:29< vultraz> look at the information
20160812 01:57:36< vultraz> HOW do you intend tosquash that
20160812 01:57:43< vultraz> without making everything tiny as hell
20160812 01:57:50< celmin> I don't know yet.
20160812 01:59:36-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 01:59:37< travis-ci> wesnoth/wesnoth#10309 (master - 62a299d : Charles Dang): The build has errored.
20160812 01:59:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151688377
20160812 01:59:37-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 02:02:02< celmin> You might be right that it's impossible, but I want to try it before concluding that.
20160812 02:02:20< celmin> Feel free to continue designing without worrying about that though.
20160812 02:02:52< celmin> At least it'll work with scrollbars even on 800x600, presumably.
20160812 02:03:15< vultraz> of course it works with scrollbars..
20160812 02:03:19< vultraz> it doesn't crash wesnoth
20160812 02:06:04< vultraz> oh come on, can I not pass a formula to GUI_FORCE_WIDGET_MINIMUM_SIZE
20160812 02:06:07< vultraz> this is ridiculous 
20160812 02:06:21< celmin> It depends on the underlying WML.
20160812 02:21:39< irker685> wesnoth: Charles Dang wesnoth:master 7cf6df59107c / data/gui/window/mp_create_game.cfg: MP Create: fixed some layout issues on smaller resolutions https://github.com/wesnoth/wesnoth/commit/7cf6df59107cc86bc0c0ed0de5006b9a1a1482da
20160812 02:22:04< vultraz> celmin: ^ you'll still have dialog scrollbars but at least stuff is now positioned properly
20160812 02:22:10< celmin> Fun.
20160812 02:22:19< vultraz> I reduced the minimum minimap size on smaller resolutions
20160812 02:29:16< Aginor> why do we even support 800x600? Mobile devices comes to mind
20160812 02:29:46< vultraz> mobile devices should get their own specialized ui
20160812 02:29:55< Aginor> besides, it we were adament that things should work for 800x600 a few weeks ago we shouldn't change our minds now because it's inconvenient for someone else ;)
20160812 02:30:43< celmin> vultraz: With GUI2 I think we can do that, which is what the fiddling was supposed to be about.
20160812 02:31:23< Aginor> 14:29 < vultraz> mobile devices should get their own specialized ui
20160812 02:31:51< Aginor> vultraz: we have NO separation between UI and gamestate and logic. It's impossible to have several different UIs
20160812 02:34:40< irker685> wesnoth: Charles Dang wesnoth:master cf4f4883ab29 / src/gui/widgets/ (tree_view.cpp tree_view.hpp): ttree_view: added a clear() function https://github.com/wesnoth/wesnoth/commit/cf4f4883ab29ff074dbb065b77e2e32cf9436b86
20160812 02:37:11< vultraz> true
20160812 02:38:32< Aginor> it'd be nice to separate those things though
20160812 02:46:53< vultraz> hmm...
20160812 02:47:06< vultraz> what distinguishes the random matps.
20160812 02:47:08< vultraz> maps
20160812 02:47:10< vultraz> a [generator] tag?
20160812 02:47:35< celmin> No idea.
20160812 02:50:09-!- gfgtdf [~chatzilla@x4e369c08.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160812 02:55:14-!- travis-ci [~travis-ci@ec2-54-82-73-21.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 02:55:15< travis-ci> wesnoth/wesnoth#10310 (master - 7cf6df5 : Charles Dang): The build failed.
20160812 02:55:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151695248
20160812 02:55:15-!- travis-ci [~travis-ci@ec2-54-82-73-21.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 03:11:14< vultraz> shame we can't use lambdas for signal connectors
20160812 03:19:23-!- JyrkiVesterinen [~JyrkiVest@87-100-155-106.bb.dnainternet.fi] has joined #wesnoth-dev
20160812 03:20:26-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 03:20:27< travis-ci> wesnoth/wesnoth#10311 (master - cf4f488 : Charles Dang): The build failed.
20160812 03:20:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151696556
20160812 03:20:27-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 03:25:00-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160812 03:26:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160812 03:28:45-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160812 03:50:53< vultraz> gah
20160812 03:51:03< vultraz> where is the code that fills the games list...
20160812 03:58:17< shadowm> vultraz: I don't know what's going on in the last screenshot you linked to me.
20160812 03:58:32< celmin> vultraz: Error on line 310.
20160812 03:58:46< vultraz> that's the tab for the whole custom [options] thing
20160812 03:58:55< shadowm> Oh okay, I know nothing about it still.
20160812 03:59:07< vultraz> where mp creators can have custom checkboxes/sliders/text boxes/comboboxes
20160812 03:59:18< celmin> If I'm lucky, maybe you have a warning there.
20160812 03:59:29< shadowm> I've never bothered to learn how or why MP modifications are supposed to work since my interest in MP content is near to nonexistent.
20160812 04:00:02< shadowm> That's probably why someone thought it'd be a great idea to shove them into our faces in the SP UI.
20160812 04:00:21< vultraz> celmin: I have no warnings
20160812 04:00:35< shadowm> Like some kind of desperate political propaganda campaign for the aspect of Wesnoth that deals with gaming with multiple human-controlled entities.
20160812 04:00:50< celmin> vultraz: Alright, I guess I'll have to fix this myself then.
20160812 04:01:07< vultraz> celmin: i have local changes
20160812 04:01:17< shadowm> But yeah. Tabbed dialogs. Awesome. I can def approve of anything that has tabs in it.
20160812 04:01:26< celmin> vultraz: It's add_child(something, {})
20160812 04:01:35< vultraz> add child...?
20160812 04:01:39< celmin> In a tree view.
20160812 04:01:48< vultraz> oh
20160812 04:01:49< vultraz> option_node.add_child("options_default_button", {});
20160812 04:01:56< celmin> Yeah that.
20160812 04:01:58< vultraz> I just wanted to pass an empty object
20160812 04:02:00< vultraz> :|
20160812 04:02:08< celmin> Not quite sure why, but my compiler doesn't like it.
20160812 04:02:25 * vultraz groans
20160812 04:02:32< vultraz> v _ v
20160812 04:03:41< celmin> Maybe it's related to the fact that it's a reference… though a const one...
20160812 04:04:10< celmin> Ah, it seems like it's interpreting {} as a comparator somehow?
20160812 04:04:31< celmin> That's weird.
20160812 04:06:03< celmin> The easiest fix is probably to declare an empty map on the previous line and pass that...
20160812 04:07:01< celmin> (Isn't it a little weird to pass an empty map though?)
20160812 04:07:41< celmin> Ugh, the dialog is called "tmp_create_game".
20160812 04:07:59< celmin> Yet another example of the terribleness of mordante's naming style.
20160812 04:08:15< celmin> The obvious meaning of that is, of course, "temporary create game">
20160812 04:08:18< vultraz> we also have terror, I think :D
20160812 04:08:23< celmin> Yeah
20160812 04:11:50< vultraz> gah, this code is confusing
20160812 04:11:50< shadowm> Since mordante isn't coming back I'd say no-one would complain if someone took their time to rename all those types.
20160812 04:12:02< vultraz> create_engine::init_all_levels() exists...
20160812 04:18:33< vultraz> gah
20160812 04:20:30< vultraz> wait
20160812 04:26:48< vultraz> yyeesss
20160812 04:28:41< vultraz> the magic get_levels_by_type
20160812 04:51:46< shadowm> Are you people aware that Wesnoth fails to build using scons strict=true and GCC 6?
20160812 04:52:26< vultraz> No
20160812 04:54:43< shadowm> http://pastebin.com/raw/QJEBu0bY
20160812 04:55:04< shadowm> Forgot to mention that g++ is GCC 6.1.1.
20160812 04:57:44< shadowm> That was last night. There's new issues now.
20160812 04:58:35-!- Kwandulin [~Miranda@p200300760F35BFBDA0403C2C38FDAB46.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160812 05:01:21< shadowm> http://pastebin.com/raw/y4JDiaN5
20160812 05:13:48< Aginor> 16:51 < shadowm> Are you people aware that Wesnoth fails to build using scons  strict=true and GCC 6?
20160812 05:13:52< Aginor> yes
20160812 05:14:00< Aginor> I pointed it out a couple of weeks ago
20160812 05:14:14< Aginor> but I don't think anyone cared
20160812 05:14:30< Aginor> I didn't see a point in fixing it unless we also added it to travis
20160812 05:23:45-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160812 05:24:29-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160812 05:35:08-!- irker685 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160812 06:33:36< shadowm> Okay, so enlighten me here.
20160812 06:34:23< shadowm> Someone (celticminstrel?) was asking the other day why we name every single member variable in constructor initializer lists.
20160812 06:35:32< shadowm> I'm reading C++14 right now and if I'm interpreting §12.6.2 point 8 correctly, any member variables that are not specified in the initializer lists (including the case where there's no such list) are default-constructed.
20160812 06:36:48< shadowm> According to §8.5 point 7, default-constructing an object that isn't a class or array type means *it's not initialized at all*.
20160812 06:36:58< shadowm> Hence the series of warnings in that paste.
20160812 06:37:41< shadowm> So unless I failed to understand something, naming all member variables in constructor init lists isn't redundant in the least.
20160812 06:38:42< shadowm> (Also, specifying an empty initializer should result in value initialization -- zero initialization for non class/array types, which is what we want pretty much always with primitive types.)
20160812 06:40:20< shadowm> (And seriously, this crap is so contrived, how is anyone supposed to recommend C++ as a programming language for anything at all.)
20160812 06:42:15-!- irker729 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160812 06:42:15< irker729> wesnoth: Ignacio R. Morelle wesnoth:master 69332b14ec2b / src/xBRZ/xbrz.cpp: Fix warnings about uninitialized struct members with GCC 6 https://github.com/wesnoth/wesnoth/commit/69332b14ec2b8e37597840e3c1b776d7b831d767
20160812 06:42:23< vultraz> so should I are should I not initialize all members
20160812 06:42:49< shadowm> That's a sentence and a half.
20160812 06:42:55< shadowm> Aginor: ^ commit.
20160812 06:43:10< vultraz> s/are/or
20160812 06:43:22< vultraz> Because recently I made a commit where i did not do so
20160812 06:43:24< shadowm> Oh em gee turns out shadowm still has the ability to write a trivial patch after all this time.
20160812 06:43:43< shadowm> I don't know. I'm asking why people apparently suddenly decided otherwise.
20160812 06:44:24< shadowm> I'm trying to make sure I'm not interpreting C++14 wrong.
20160812 06:44:55< vultraz> someone mentioned it..
20160812 06:45:05< vultraz> someone else mentioned mordante had a thing for doing it
20160812 06:45:09< shadowm> (Note that this stuff is unchanged from C++98, C++03, C++11 other than the addition of some new syntax.)
20160812 06:45:19< vultraz> yet someone else mentioned it's not really necessary
20160812 06:45:40< shadowm> Yes, that's what I'm asking because it seems to contradict the reality of the spec.
20160812 06:46:22< shadowm> You never want uninitialized memory being read or returned from a function.
20160812 06:46:51< shadowm> That's how you get inexplicable bugs that only reproduce when the phase of the moon and ambient temperature are right.
20160812 06:48:06< shadowm> And the fact that C++ ensures that this kind of thing will happen any time you get lazy with your code, rather than making it opt-in, is probably my biggest beef with the language in general.
20160812 06:48:28< shadowm> Sure performance etc. I know zero-filling an arbitrarily-sized chunk of memory isn't a trivial task.
20160812 06:49:24< shadowm> But these are usually word-sized allocations ffs. And if you really need performance that badly why not be required to explicitly ask your compiler to not give a crap about safety?
20160812 06:49:50< shadowm> This is what happens when you retrofit high-level stuff into a systems programming language. >.<
20160812 06:50:09< JyrkiVesterinen> I was the one who said that member variables don't need to be mentioned in initializer lists *if you're happy with default-initialization*.
20160812 06:50:32< shadowm> And as far as I understand default-initialization for integer types is BAD.
20160812 06:50:36< JyrkiVesterinen> In particular, with member variables of class types. Their default constructors will be called in that case.
20160812 06:50:53< shadowm> And guess what types are the most commonly used in any codebase?
20160812 06:51:20< shadowm> Maybe embedded several layers deep in wrapper class types, but they're still there.
20160812 06:51:34< JyrkiVesterinen> Hmm, I don't know. I recall that most member variables I have added to existing classes have been of class types.
20160812 06:51:53< JyrkiVesterinen> Like a std::set I added yesterday for fixing the ; bug.
20160812 06:52:05< shadowm> Well, this is a game, and a game needs to keep track of a lot of numbers, and numbers aren't usually known for being class types.
20160812 06:53:11< shadowm> And since most contributors aren't going to bother with language lawyering, we might as well make it a preemptive rule that they must initialize all the things so that they don't get confused later when they shoot themselves in the foot.
20160812 06:53:11-!- sanaris [5eb52cea@gateway/web/freenode/ip.94.181.44.234] has joined #wesnoth-dev
20160812 06:53:25-!- sanaris [5eb52cea@gateway/web/freenode/ip.94.181.44.234] has left #wesnoth-dev []
20160812 06:54:05< JyrkiVesterinen> Yes, I agree. I have been adding the member variables I create into the initializer lists.
20160812 06:55:23< shadowm> So yeah, this is probably why mordante used to run cppcheck on the codebase periodically.
20160812 06:55:24< JyrkiVesterinen> When other developers have already spent the effort to explicitly initialize all member variables, throwing that effort away by not adding new variables into initializer lists wouldn't be wise.
20160812 06:57:25< vultraz> guess i need to go back and add them where i didn't
20160812 06:59:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160812 07:01:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160812 07:03:38< shadowm> vultraz: Shame on you for not reminding me to update the server configuration when you announced 1.13.5.
20160812 07:04:47< shadowm> Also, I haev a suspicion that the part of my paste that deals with unit tests code is relevant to you.
20160812 07:04:50< shadowm> have
20160812 07:05:04< shadowm> Singular you. You vultraz.
20160812 07:05:27< vultraz> hmm>
20160812 07:05:29< vultraz> ?
20160812 07:05:52< shadowm> <shadowm> http://pastebin.com/raw/QJEBu0bY
20160812 07:06:10< shadowm> You should be able to tell what I'm referring to from there.
20160812 07:06:56< vultraz> it's all xbrz :|
20160812 07:07:30< shadowm> No, it's not.
20160812 07:07:36< shadowm> Ugh.
20160812 07:07:41< shadowm> Not that paste. The second paste.
20160812 07:08:06< shadowm> We could've avoided all this if you had been paying attention to the links I pasted a couple of hours ago.
20160812 07:08:10< vultraz> oh yea,
20160812 07:08:12< vultraz> that
20160812 07:08:14< vultraz> yeah, my fault
20160812 07:08:38< vultraz> I'll need to disable the test for now, since the dialog now needs a connect_engine object
20160812 07:08:59< shadowm> OK so from now on please make sure I've updated the MP server configuration after you announce a development (DEVELOPMENT) release.
20160812 07:12:29< shadowm> Upon releasing the first beta (BETA) the dev server should be made to accept all dev versions starting from that one until an incompatible change is made (which is always supposed to be a last-resort option).
20160812 07:13:09< shadowm> Upon releasing the first release candidate (RELEASE CANDIDATE) the dev server should be made to accept all dev versions starting from that one until blah blah blah.
20160812 07:14:21< shadowm> Upon releasing the first stable (STABLE) version I'm supposed to try to remember the instance switcheroo we normally do. And it's supposed to accept all compatible RCs and all stable versions from that series.
20160812 07:15:12< shadowm> I'm saying this here for future reference. Even though I know no-one will care to remember any of this.
20160812 07:15:27-!- travis-ci [~travis-ci@ec2-54-80-121-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 07:15:28< travis-ci> wesnoth/wesnoth#10312 (master - 69332b1 : Ignacio R. Morelle): The build is still failing.
20160812 07:15:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151723354
20160812 07:15:28-!- travis-ci [~travis-ci@ec2-54-80-121-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 07:15:41< shadowm> But you know, the hit-by-a-bus principle.
20160812 07:16:53< irker729> wesnoth: Charles Dang wesnoth:master 9598d30f5dd1 / / (4 files in 3 dirs): MP Create: progress and disabled test for now https://github.com/wesnoth/wesnoth/commit/9598d30f5dd1e3df73af6121d7b261de3d6d2c70
20160812 07:18:58< vultraz> I'm making good progress on the dialog
20160812 07:26:49-!- Kwandulin_2 [~Miranda@p200300760F35BF2A3911E38B29C8ED77.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160812 07:26:53-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160812 07:29:04-!- Kwandulin [~Miranda@p200300760F35BFBDA0403C2C38FDAB46.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160812 07:32:20< shadowm> The Preferences → Advanced → Logging Options dialog should be using the radio variant of checkboxes instead of the default.
20160812 07:32:39< shadowm> And maybe, just maybe, column headers.
20160812 07:33:11< shadowm> I wonder if this stuff is supposed to persist across sessions now? If not then maybe mention that somewhere.
20160812 07:33:25< irker729> wesnoth: Charles Dang wesnoth:master 6441165187db / data/gui/window/logging.cfg: Logging: use radio buttons https://github.com/wesnoth/wesnoth/commit/6441165187dbeff2be88d3c1539e55f5d77d70b7
20160812 07:34:24< shadowm> It's also important to note that setting some domains to debug has a major performance impact depending on what stderr is connected to.
20160812 07:35:29< shadowm> In particular, if stderr is a pseudotty connected to a X11 terminal emulator and you set one of the GUI2 domains to debug, IME the whole thing becomes nigh unusable.
20160812 07:35:42< shadowm> (I don't remember which one. Maybe all of them.)
20160812 07:38:20< shadowm> I miss the option descriptions I lovingly added to the Compress Saved Games option for 1.12.x.
20160812 07:38:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160812 07:38:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160812 07:39:05< shadowm> In hindsight maybe I should've said "extremely large" instead of just "large" there.
20160812 07:40:08-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160812 07:49:38-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 07:49:39< travis-ci> wesnoth/wesnoth#10313 (master - 9598d30 : Charles Dang): The build is still failing.
20160812 07:49:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151728321
20160812 07:49:39-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 07:53:43-!- boucman_work [~boucman@229.29.205.77.rev.sfr.net] has joined #wesnoth-dev
20160812 07:53:48-!- Bonobo [~Bonobo@2001:44b8:254:3200:50a5:3a37:aad5:f29] has joined #wesnoth-dev
20160812 08:17:13-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 08:17:14< travis-ci> wesnoth/wesnoth#10314 (master - 6441165 : Charles Dang): The build is still failing.
20160812 08:17:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151731054
20160812 08:17:14-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 08:22:07< irker729> wesnoth: ln-zookeeper wesnoth:master 4d39da6d2d8a / data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg: Commented out the trap event for now https://github.com/wesnoth/wesnoth/commit/4d39da6d2d8a42d7c0cd4a23c35f346d449da9aa
20160812 08:23:49-!- Kwandulin_2 [~Miranda@p200300760F35BF2A3911E38B29C8ED77.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160812 08:29:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160812 08:33:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160812 08:33:28-!- wedge010 is now known as wedge009
20160812 08:55:36-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 08:55:36< travis-ci> wesnoth/wesnoth#10315 (master - 4d39da6 : ln-zookeeper): The build is still failing.
20160812 08:55:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151739448
20160812 08:55:37-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 08:59:57-!- Kwandulin [~Miranda@p200300760F35BF2ABC44D978DEE5B6BE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160812 09:15:30< irker729> wesnoth: Wedge009 wesnoth:master f1be140bb48b / / (4 files in 2 dirs): Change WML condition equals=true to boolean_equals=true (bug #24951) https://github.com/wesnoth/wesnoth/commit/f1be140bb48b5a178ae02833425dc379f8ff98c9
20160812 09:25:04-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160812 09:27:31-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160812 09:34:18< vultraz> wedge009: should i mark as fixed?
20160812 09:35:22< wedge009> Yes, please.
20160812 09:36:09< wedge009> Unless you want to wait for someone else to test and confirm.
20160812 09:39:15-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160812 10:24:53-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160812 10:50:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160812 11:12:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160812 11:40:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160812 11:41:24-!- gfgtdf [~chatzilla@x4e369c08.dyn.telefonica.de] has joined #wesnoth-dev
20160812 11:41:32< gfgtdf> 20160812 03:11:14< vultraz> shame we can't use lambdas for signal connectors
20160812 11:41:41< gfgtdf> vultraz: is there  specific erro when you tryy that ?
20160812 11:42:11< vultraz> signature doesn't match. it expects event::tsignal_function or something and lambdas aren't compatible with it
20160812 11:43:55< gfgtdf> vultraz: hm since std::function is just a function a labda shoudl be vompatible if the parameterlist is correct
20160812 11:44:19< vultraz> hm
20160812 11:44:35< vultraz> i assume the parameter list would be tsignal_function?
20160812 11:46:12< gfgtdf> vultraz: the parmaeter list is 'tdispatcher& dispatcher, const tevent event, bool& handled, bool& halt' like in the definition of tsignal_function
20160812 11:46:27< vultraz> hm
20160812 11:46:36< vultraz> yeah writing that all out isn't worth it
20160812 11:48:23< gfgtdf> vultraz: well you dont hav to write the variableames if you dotn want to them obviousl like 'tdispatcher&, const tevent event, bool& handled, bool&' 
20160812 11:49:26< gfgtdf> vultraz: if you are wrtiing c++14 code you can mostliklley just write auto specially for the ohnored parmereter like 'auto, const tevent event, bool& handled, auto'
20160812 12:12:13-!- Kwandulin [~Miranda@p200300760F35BF2ABC44D978DEE5B6BE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160812 12:15:52-!- irker729 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160812 12:53:15-!- irker343 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160812 12:53:15< irker343> wesnoth: Gregory A Lundberg wesnoth:master 4b9e60196e34 / data/campaigns/Delfadors_Memoirs/utils/sides.cfg: DM S08 Fix bug: Units in poor shape (bug #24952) https://github.com/wesnoth/wesnoth/commit/4b9e60196e341ce5320bdc05135c75d0d7b2a7d8
20160812 12:53:15< irker343> wesnoth: Wedge009 wesnoth:master 7b7eb810814f / changelog: Update change log. https://github.com/wesnoth/wesnoth/commit/7b7eb810814fe7de4f27981aec86292af0b92a65
20160812 12:54:17< gfgtdf> vultraz: if you want to fix the listbox headers thing, my firt attempt woudl here https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/scrollbar_container.cpp#L307 to add something like if(auto* header= find_widget("_header_grid")) {  result.x += header.get_best_size().x} or similar
20160812 12:54:43< gfgtdf> vultraz: that migzht be not a very pretty solution but we can stillmake it prettier later
20160812 12:58:30< vultraz> ill try it
20160812 12:59:59-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 13:00:00< travis-ci> wesnoth/wesnoth#10324 (master - f1be140 : Wedge009): The build is still failing.
20160812 13:00:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151749401
20160812 13:00:00-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 13:07:21-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160812 13:50:48-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 13:50:49< travis-ci> wesnoth/wesnoth#10326 (master - 7b7eb81 : Wedge009): The build has errored.
20160812 13:50:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151792578
20160812 13:50:49-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 13:59:39-!- ChipmunkV [~chatter@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160812 14:00:40-!- ChipmunkV [~chatter@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Remote host closed the connection]
20160812 14:03:17-!- ChipmunkV [~chatter@d0017-2-88-172-31-68.fbx.proxad.net] has joined #wesnoth-dev
20160812 14:03:33-!- ChipmunkV [~chatter@d0017-2-88-172-31-68.fbx.proxad.net] has quit [Remote host closed the connection]
20160812 14:07:52-!- JyrkiVesterinen [~JyrkiVest@87-100-155-106.bb.dnainternet.fi] has quit [Quit: .]
20160812 14:16:52-!- Kwandulin [~Miranda@p200300760F35BF2A5841765D5147B935.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160812 14:26:08< gfgtdf> celmin: i just played your campaign and teh healing potions in scenario 2 doesnt seem to work (while the haste potions do work)
20160812 14:52:03-!- Bonobo [~Bonobo@2001:44b8:254:3200:50a5:3a37:aad5:f29] has quit [Ping timeout: 264 seconds]
20160812 14:55:34-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160812 15:10:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160812 15:27:16-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160812 15:36:23-!- Kwandulin [~Miranda@p200300760F35BF2A5841765D5147B935.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160812 15:45:38< zookeeper> gfgtdf, <nore> I've got a bug with Legend of Wesmere in multiplayer: at the beginning of chapter 3, Kalenz is turned into a Fighter again, is controlled by ai and starts recruiting undead. Is this known?
20160812 15:45:54< zookeeper> (from #wesnoth, but he's here too, so...)
20160812 15:46:10< gfgtdf> zookeeper: sounds like a typical LoW bug :)
20160812 15:46:17< zookeeper> yeah
20160812 15:46:18< gfgtdf> zookeeper: is this on latest master ?
20160812 15:46:33< zookeeper> i don't know. ask him :p
20160812 15:46:55< gfgtdf> nore: did that happen on latest master ?
20160812 15:47:04-!- boucman_work [~boucman@229.29.205.77.rev.sfr.net] has quit [Ping timeout: 260 seconds]
20160812 15:48:55< gfgtdf> nore: also sple say how you stated that scenario: 1) By advaning from  a previous scenario, 2) By loading a start-of-scenario savefile, 3) But using the chapter-entry feature in the mp configure screen, 4) somehing else
20160812 15:52:00< gfgtdf> vultraz: is tzhere  a reaon why there are 3 unit_preview_pane_definition ?
20160812 15:52:16< celticminstrel> Yes.
20160812 15:52:39< celticminstrel> (I don't know what the reason is though.)
20160812 15:53:19-!- irker343 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160812 15:53:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 15:53:47< gfgtdf> ok i just sw, the miniamal defeintions are used for the attak dialog
20160812 15:57:28-!- mjs-de [~mjs-de@x4db5be47.dyn.telefonica.de] has joined #wesnoth-dev
20160812 16:12:42< DeFender1031> gfgtdf, if that's a "typical" LoW bug, how badly is LoW coded?
20160812 16:13:09< celticminstrel> I don't think it's that LoW is badly coded exactly... 
20160812 16:15:55< zookeeper> it's the campaign that has all sorts of leader and recall list changing _and_ was originally a SP campaign which was later converted to also work as a MP campaign. so that explains a lot. :p
20160812 16:16:40< fabi> No, the campaign with all sorts of leader and recall list changing is DM.
20160812 16:16:48< fabi> LoW does that only slightly.
20160812 16:16:52-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160812 16:16:58< zookeeper> right. yeah, i guess
20160812 16:17:44< zookeeper> it's also split into chapters, the point of which IIRC is to allow it to be started as a MP campaign from any chapter, not always from the beginning... right?
20160812 16:18:02< fabi> right
20160812 16:18:40< fabi> Also note that LoW worked perfectly fine before that summer of code where all went wrong with the projects.
20160812 16:19:27< fabi> But changes to the transition between scenario system introduced bugs.
20160812 16:20:03< fabi> LoW is more a proof of a project failing to get MP support working since 1.4 than a badly coded campaign.
20160812 16:21:08-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160812 16:22:50-!- DeFender1031 [~DeFender1@46-116-114-128.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20160812 16:25:05< nore> sorru, answering your questions now:
20160812 16:25:12< nore> it was on 1.12.6
20160812 16:25:28< nore> advancing from previous scenario
20160812 16:25:48< nore> I was the host and was asked to choose a player controlling the dwarf, which I did
20160812 16:26:14< nore> (I chose myself, the other player was controlling Landar and Cleodil)
20160812 16:27:03< nore> I saw this problem happen; however, the other player had a problem advancing to that scenario as well, so we had to save & restore
20160812 16:27:09< nore> this of course did not fix the problem
20160812 16:28:19< nore> if that can help, we won the previous scenario before Olurf even arrived to our help (which I seem to recall is supposed to happen sometime, while I did not see what would trigger that in the scenario)
20160812 16:29:10< fabi> nore: Olurf is supposed to arrive in mp always when the scenario already ended.
20160812 16:29:16< nore> after victory of the previous scenario, there is supposed to be some text when Olurf arrives: however, I did not see him arrive, and his lines were missing
20160812 16:29:24< nore> fabi: ok, that was what I was supposing
20160812 16:29:35< nore> but anyway, he did not arrive even at the end
20160812 16:32:01< nore> if that can help, I edited the save file from a previous scenario to remove the advances added by "Era of more units" which I had installed but not the player I was playing with; however, at the time we got this problem, no-one had this add-on installed
20160812 16:32:50< fabi> It is not an era problem.
20160812 16:33:11< nore> that's what I was thinking
20160812 16:33:49< nore> (probably unrelated: during the campaign, I had translation problems such as units having the trait "female^dextrous")
20160812 16:34:25< fabi> That sounds like missing #textdomain 
20160812 16:34:51< nore> and I saw this error after I quit, which is probably related to the problem:
20160812 16:34:53< nore> 20160812 16:58:50 error engine: wrong side in [unit] tag - no such side: 8 ( number of teams :7)
20160812 16:34:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160812 16:35:25< nore> (I think this happened at the moment where the units of Olurf should have been created)
20160812 16:36:03< nore> and I got that a bit later (this time I think unrelated): 20160812 17:06:25 error config: Multiple [unit_type]s with id=Adamantine encountered.
20160812 16:36:41< nore> (yeah, unrelated, I get that every time I start wesnoth it looks like)
20160812 16:37:23< fabi> Well, zookeeper and gfgtdf seem to like to solve LoW issues between them. And that suits me regarding 1.12 since I don't collaborate with it's release manager under any cirumstances.
20160812 16:37:24< nore> zookeeper, gfgtdf: see above
20160812 16:40:31< nore> I can reproduce the problem
20160812 16:45:02-!- louis94 [~~louis94@91.178.241.1] has joined #wesnoth-dev
20160812 16:45:14-!- mjs-de [~mjs-de@x4db5be47.dyn.telefonica.de] has quit [Remote host closed the connection]
20160812 16:51:32-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160812 16:55:54< celticminstrel> I suddenly realize that, the way I'm doing this, the metatable keys will be eg "unit\0" instead of "unit".
20160812 16:55:58< celticminstrel> ^realized
20160812 16:56:23< celticminstrel> I suppose it technically doesn't matter that much since they're just a key to look up the value in the registry.
20160812 17:00:13-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160812 17:00:13-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160812 17:02:43< fabi> vultraz, celticminstrel: Iirc you talked about redisigning [side] and the setup.
20160812 17:04:03-!- boucman_work [~boucman@221.86.207.77.rev.sfr.net] has joined #wesnoth-dev
20160812 17:04:44< celticminstrel> Is it my imagination, or does fetching attacks from a unit type in Lua not work?
20160812 17:05:02 * celticminstrel noticed this in the code and started addressing it.3
20160812 17:05:14< fabi> Any results?
20160812 17:05:21< celticminstrel> I don't remember.
20160812 17:05:26< gfgtdf> nore: so 1.12.6 ?
20160812 17:05:30< celticminstrel> Was that the stuff about [leader]?
20160812 17:05:36< fabi> yeah
20160812 17:05:43< nore> gfgtdf: yes
20160812 17:05:56< celticminstrel> The MP setup process is so complicated that I gave up for the time being.
20160812 17:06:03< celticminstrel> I'll probably come back to it later.
20160812 17:06:05< fabi> oh yes
20160812 17:06:22< gfgtdf> nore: one issue is that currently cutscene scenario hare not handles preerly in 1.12.6 so to fix the kanez-reset issue the best fix is mostlieky to skip the scroyreeen issue in m, that is changing next_scneario in teh scenario before teh cutscene
20160812 17:06:29< shadowm> Yes, other people have been doing a pretty sloppy job at maintaining LoW ever since its original maintainer decided to put his personal vendetta against a certain release manager above his responsibility.
20160812 17:06:56 * celticminstrel would like it if someone could test these possible Lua problems I'm mentioning, both the unit_type attacks one and the put_unit one.
20160812 17:07:14< nore> gfgtdf: hm, ok, I will try to see if that fixes it then
20160812 17:07:15< gfgtdf> nore: to fix unit beeing able to recuit undead it might hel to add some faction=Custom in those [side]s
20160812 17:07:15< shadowm> That's certainly a thing that's been happening and that's not good for anyone at all.
20160812 17:07:39< gfgtdf> nore: both bugs sshoudl be fixed in 1.13.5 engine
20160812 17:07:52< nore> Well, the problem was mainly it became controlled by side 4 and not 1
20160812 17:08:08< fabi> I hope all the [side] setup including [unit] and [leader] can be simplified a lot.
20160812 17:08:08< nore> Ok, thanks
20160812 17:08:12< gfgtdf> nore: i dont know whether 1.13.5 has other major bugs but it migth be worth to play LoW on 1.13.5 mp server
20160812 17:08:25< fabi> This is even related to the map format.
20160812 17:09:50< nore> Well, since I intend to play singleplayer campaign on a mp server, I'll need to update as well to get synchronized victory events, so I might do that now as well
20160812 17:10:11< nore> I'll tell you if I still have a problem after that
20160812 17:10:46< celticminstrel> How do you propose to simplify [unit]? o.o
20160812 17:10:57< celticminstrel> How is it related to the map format?
20160812 17:11:14< fabi> The map gives a possible starting position.
20160812 17:12:28< fabi> Assuming the map provides a starting position the setup can happen without much extra WML.
20160812 17:13:19< gfgtdf> fabi: in the 1.13.5 edito you can also specirfy exctra locations that can be used in placement so like [unit] placement=guard_1
20160812 17:13:40< gfgtdf> in the map format that is, without the scenario editor
20160812 17:13:53< fabi> Oh
20160812 17:14:05-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160812 17:14:07< fabi> My hope was that those extra stuff would be removed.
20160812 17:14:16< fabi> Not used more extensively.
20160812 17:14:25< celticminstrel> gfgtdf: Are those locations stored in the map format?
20160812 17:14:28< celticminstrel> Or in the scenario?
20160812 17:14:34< gfgtdf> celticminstrel: yes
20160812 17:14:37-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160812 17:14:38< fabi> damn
20160812 17:14:41< gfgtdf> celticminstrel: map data
20160812 17:14:58 * celticminstrel doesn't see the problem with this.
20160812 17:15:49< fabi> I don't want to explain.
20160812 17:17:43< celticminstrel> I think it's better this way, actually.
20160812 17:17:59< celticminstrel> Because if you decide to rework the map, you don't need to update as many location references in the scenario.
20160812 17:19:11< gfgtdf> celticminstrel: yes that what the reason why it was added.
20160812 17:19:26< gfgtdf> i added it*
20160812 17:23:02< fabi> Do you plan to add more stuff into the map format?
20160812 17:23:09< fabi> Who did it?
20160812 17:23:33-!- louis94 [~~louis94@91.178.241.1] has quit [Ping timeout: 240 seconds]
20160812 17:23:39< fabi> There was a consens in the past to not make the map format more complex but reduce complexity.
20160812 17:24:04< celticminstrel> I think special locations is a good thing to have in the map format though.
20160812 17:24:09< fabi> no
20160812 17:24:12< fabi> Not at all.
20160812 17:24:31< celticminstrel> That's not very convincing.
20160812 17:25:10< fabi> I am tired explaining obivious things.
20160812 17:25:11 * zookeeper wonders if it's desirable for all ambushers to become visible in linger mode
20160812 17:25:28< zookeeper> (because apparently they do)
20160812 17:25:29< celticminstrel> If I don't get it, it's not obvious.
20160812 17:25:38< celticminstrel> (If anyone doesn't get it, it's not obvious.)
20160812 17:25:56< celticminstrel> Anyway, I already explained why I thought it was a good thing.
20160812 17:26:14< celticminstrel> It's not just some nebulous "oh that seems like a good idea" feeling.
20160812 17:27:01< fabi> okay
20160812 17:27:52< fabi> The complete side setup including the position of potential leaders and other units should be done in WML and WML only.
20160812 17:28:02< fabi> That WML can come from the map file.
20160812 17:28:08< fabi> But not inside the map string.
20160812 17:28:20< fabi> We try to clean that map string since ages.
20160812 17:28:26-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160812 17:28:27< fabi> Don't work backwards.
20160812 17:28:28< celticminstrel> Frankly, positional data is best included in the map string in my opinion.
20160812 17:28:55< fabi> And why?
20160812 17:29:10< celticminstrel> Also, your explanation is just a statement of your position, no reasons given.
20160812 17:29:17-!- JyrkiVesterinen [~JyrkiVest@87-92-21-10.bb.dnainternet.fi] has joined #wesnoth-dev
20160812 17:29:19< fabi> no
20160812 17:29:35< fabi> I explained what we agreed on when I last worked at the editor.
20160812 17:29:56< fabi> But I don't care.
20160812 17:30:06< celticminstrel> I can give a reason for my position - by including the data in the map string, you don't need to worry about the actual coordinates. If you move the special location, it doesn't need to be synched with the WML.
20160812 17:30:25< fabi> Okay
20160812 17:30:46< celticminstrel> (Actually, gfgtdf, now that we have special locations, what about supporting them in [item], [label], SUF, and SLF?)
20160812 17:31:45< gfgtdf> celticminstrel: we support them in SUF, and since there is a lua interface for it (wesnth.special_locations i think), it's also possible to use them in lua defined wml tags.
20160812 17:31:59< celticminstrel> What about SLF?
20160812 17:32:10< gfgtdf> i meant SLF
20160812 17:32:14< celticminstrel> I can add them to [item] and [label] if those are Lua-defined (I think they are).
20160812 17:32:18< celticminstrel> So then, what about SUF?
20160812 17:32:20< gfgtdf> SUF support them by filter_location
20160812 17:32:27-!- Bonobo [~Bonobo@2001:44b8:254:3200:1482:204a:cd0c:e3b2] has joined #wesnoth-dev
20160812 17:32:34< celticminstrel> Hmm, I guess that's sufficient.
20160812 17:32:39< gfgtdf> which is a SLF
20160812 17:33:05< celticminstrel> A [filter][filter_location]x,y=2,2 is equivelent to [filter]x,y=2,2 right?
20160812 17:33:12< fabi> So you introduced another location related thing beside [area]? Why?
20160812 17:35:04< celticminstrel> gfgtdf: What happens if the same special location is set in two different places?
20160812 17:35:33< gfgtdf> celticminstrel: the edito only allows one location per id currently.
20160812 17:35:44< celticminstrel> Okay, that's probably not a bad thing.
20160812 17:35:53< celticminstrel> How does the map reader handle it?
20160812 17:36:48< gfgtdf> fabi: area was quiet complacted and also it was only accesible to with the 'scenario editor', and the 'scenario editor' is useless when you want to edti an existing scneairo file sicne it discards all handwritten changes.
20160812 17:37:33< fabi> gfgtdf: When you read your newly spoiled map format, translate the result into areas. 
20160812 17:37:36< celticminstrel> To work properly the scenario editor probably needs to not parse the file as WML.
20160812 17:38:27< gfgtdf> celticminstrel: it sotes it ina  map stirng ->location, which just prelcaes teh previosu int ->location map for starting locatio, really wat is did was just to extnd that to also allow strign keys.
20160812 17:38:28< fabi> There is no need for the concept special_location
20160812 17:38:39< fabi> at least not at the WML end of the thing.
20160812 17:38:54< celticminstrel> Even if it parses the file as WML it shouldn't take the next step and use that config to construct unit objects and so on.
20160812 17:39:06< celticminstrel> It should just manipulate it as plain WML.
20160812 17:39:32< celticminstrel> (I suppose if a unit object is needed for display, then it could have a cache of unit objects or something.)
20160812 17:40:12< celticminstrel> gfgtdf: So I guess the last one takes precedence? It'd be nice if there were a warning though.
20160812 17:41:45< gfgtdf> celticminstrel: i dont know whether there is curnetly a warning, but like i said the editor doesnt allwo you to place multipel locations with the same id,  so since one usualyl doenst edtiro map files by hand, i don't think warnign is that important
20160812 17:42:09< celticminstrel> Not high priority, no, but good to have just in case.
20160812 17:42:32< celticminstrel> In particular, if someone is using version control on their maps, a merge conflict could accidentally create a duplicate ID.
20160812 17:42:56< celticminstrel> If it is incorrectly resolved.
20160812 17:48:56< fabi> gfgtdf: The editor was never meant to open scenario files. 
20160812 17:49:36< celticminstrel> That's kinda why the scenario editor doesn't work very well.
20160812 17:49:46< fabi> The file outputed in scenario mode should be included with  {}
20160812 17:49:55< fabi> into the handwritten scenario.
20160812 17:50:15< celticminstrel> Well, that's certainly a thing that is possible.
20160812 17:51:31< gfgtdf> celticminstrel: i just looked and it does give a warning see terrain/translation.cpp#L305
20160812 17:51:43< celticminstrel> Nice.
20160812 17:56:54< Espreon> zookeeper: Done. I added a comment to the PR.
20160812 17:58:12< celticminstrel> vultraz: Finally got my const_cast stuff committed, after a rather significant Lua-related refactor; so I'm going to push it to a branch instead of master for now.
20160812 18:01:33< celticminstrel> I might revisit const_cast again later. There are still several uses which might be possible to eliminated (mainly cases where const versions of a getter are implemented in terms of the non-const version).
20160812 18:02:00< celticminstrel> 35 uses remain.
20160812 18:02:09< celticminstrel> I don't remember how many there were before?
20160812 18:04:34< celticminstrel> I suggest giving it at least a week before merging.
20160812 18:04:48-!- irker712 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160812 18:04:48< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 597089bf0e38 / src/scripting/ (lua_api.cpp lua_kernel_base.cpp): Refactor some duplicate code in Lua API https://github.com/wesnoth/wesnoth/commit/597089bf0e38989cb988ff97b1cedcccdf930dba
20160812 18:04:48< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor fadec83d83bf / / (17 files in 4 dirs): Move Lua unit wrapper to own file https://github.com/wesnoth/wesnoth/commit/fadec83d83bf845b0dc6191c0b6f1cadcf518e09
20160812 18:04:48< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 116c69752813 / src/scripting/ (8 files): Implement Lua placement new https://github.com/wesnoth/wesnoth/commit/116c6975281390e4009ecbb2d6501d3fc91d8ebf
20160812 18:04:49< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor aa11ab412029 / src/ (5 files in 2 dirs): Extract Lua unit push code into a function https://github.com/wesnoth/wesnoth/commit/aa11ab412029afd6677c05a744ec7680b255711a
20160812 18:04:51< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 70ea4932f537 / src/scripting/ (game_lua_kernel.cpp game_lua_kernel.hpp lua_unit.cpp lua_unit.hpp): Avoid luaW_hasmetatable when checking for units https://github.com/wesnoth/wesnoth/commit/70ea4932f5372289a447a54fb1ec09b41b2cf601
20160812 18:04:53< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor f6c738b61388 / src/scripting/game_lua_kernel.cpp: Fix bug in wesnoth.put_unit https://github.com/wesnoth/wesnoth/commit/f6c738b61388c9c48ba905419e505b591876dd1f
20160812 18:04:55< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 013b58b2e8a6 / src/scripting/ (game_lua_kernel.cpp lua_unit.cpp lua_unit.hpp): Move unit metatable stuff into lua_unit file https://github.com/wesnoth/wesnoth/commit/013b58b2e8a698d566addb4477684769cf3db5ae
20160812 18:04:57< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 7e1fbc6d6d32 / / (6 files in 2 dirs): Move Lua unit attacks metatable to own file https://github.com/wesnoth/wesnoth/commit/7e1fbc6d6d3265a6dc5122f97e8039a078ef6aba
20160812 18:04:59< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 7ce8424811ef / src/scripting/lua_unit_attacks.cpp: Fix Lua attacks metatable not working for attacks obtained from unit_type https://github.com/wesnoth/wesnoth/commit/7ce8424811ef461de84faa8c810cf640de32a811
20160812 18:05:01< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor 4bb5d2c1a7e4 / src/scripting/game_lua_kernel.cpp: Use luaW_pushunit when getting lists of units https://github.com/wesnoth/wesnoth/commit/4bb5d2c1a7e4046abf78f9bb6b994417828a1def
20160812 18:05:03< irker712> wesnoth: Celtic Minstrel wesnoth:lua_refactor de72becbe5dd / / (25 files in 9 dirs): Reduce use of const_cast https://github.com/wesnoth/wesnoth/commit/de72becbe5dd98bbe87c0dcb786308d2f5dcdede
20160812 18:06:52-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160812 18:10:16< celticminstrel> vultraz, wedge009, anyone else: the above push is PR 744. I did some testing in the Lua console and things still seemed to work, but I'm not sure if that was sufficiently extensive.
20160812 18:17:29< gfgtdf> i get an error about resources::gameboard bein nullptr when loaidng  saefile in current master
20160812 18:19:22< celticminstrel> Blame vultraz and his resources::team removal.
20160812 18:19:36< celticminstrel> Or better, find a way to fix it.
20160812 18:20:56< irker712> wesnoth: Gregory A Lundberg wesnoth:master 652c5b9b0de7 / data/lua/wml/object.lua: Do not select unit in silent object https://github.com/wesnoth/wesnoth/commit/652c5b9b0de7f88cbaead990dd5814b3d5cbb8e1
20160812 18:20:58< irker712> wesnoth: Celtic Minstrel wesnoth:master 70131ec7f102 / data/lua/wml/object.lua: Merge pull request #745 from GregoryLundberg/GL_do_not_select_unit_in_silent_obj https://github.com/wesnoth/wesnoth/commit/70131ec7f102e032e6a14f905194db9fb8703be9
20160812 18:27:06< zookeeper> so doesn't that mean that unit selection is lost whenever any unit gets an object?
20160812 18:27:45-!- louis94 [~~louis94@91.178.241.1] has joined #wesnoth-dev
20160812 18:28:01< celticminstrel> No? How would it mean that?
20160812 18:28:30-!- fabi [~fabi@176.7.89.74] has quit [Ping timeout: 276 seconds]
20160812 18:28:54< zookeeper> humm. right, i misread the code
20160812 18:29:51< zookeeper> Espreon, okay, cool
20160812 18:32:57< irker712> wesnoth: Gregory A Lundberg wesnoth:master 5f9a711dab0b / data/lua/wml/object.lua: Fix the fix (#746) https://github.com/wesnoth/wesnoth/commit/5f9a711dab0b6c7024e03fe37e92281b5f21e6a7
20160812 18:34:48< celticminstrel> Not sure why I didn't mention the point that wedge009 brought up. I seem to recall noticing it too.
20160812 18:37:15-!- Kwandulin [~Miranda@p200300760F35BF2A9C8FA12C6DB651DE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160812 18:48:09-!- louis94 [~~louis94@91.178.241.1] has quit [Ping timeout: 258 seconds]
20160812 18:49:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160812 18:51:27-!- Bonobo [~Bonobo@2001:44b8:254:3200:1482:204a:cd0c:e3b2] has quit [Ping timeout: 264 seconds]
20160812 18:51:54-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160812 18:55:22< gfgtdf> im somehow unable to adda tooltip to a [label] does anyone know where to find a examepl (in mainline )where that i done succesfully ?
20160812 18:57:56< gfgtdf> vultraz: ^ any ideas ?
20160812 18:59:20-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160812 19:02:52-!- travis-ci [~travis-ci@ec2-54-80-121-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 19:02:53< travis-ci> wesnoth/wesnoth#10331 (master - 70131ec : Celtic Minstrel): The build failed.
20160812 19:02:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151879785
20160812 19:02:53-!- travis-ci [~travis-ci@ec2-54-80-121-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 19:06:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160812 19:07:12< irker712> wesnoth: Jyrki Vesterinen wesnoth:master 265e41dbdad3 / src/ (attack_prediction_display.cpp attack_prediction_display.hpp mouse_events.cpp): Damage calculation dialog: use existing battle prediction https://github.com/wesnoth/wesnoth/commit/265e41dbdad3ece6ae45374dcf2174bdc0f385cc
20160812 19:08:50-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160812 19:20:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 19:24:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160812 19:25:53-!- Kwandulin [~Miranda@p200300760F35BF2A9C8FA12C6DB651DE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160812 19:28:21-!- gfgtdf [~chatzilla@x4e369c08.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160812 19:29:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160812 19:29:24-!- travis-ci [~travis-ci@ec2-54-80-121-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 19:29:26< travis-ci> wesnoth/wesnoth#10333 (master - 5f9a711 : Gregory A Lundberg): The build failed.
20160812 19:29:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151882836
20160812 19:29:26-!- travis-ci [~travis-ci@ec2-54-80-121-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 19:29:26-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160812 19:31:39< celticminstrel> Oh, that's just the MP create test failure because vultraz added a new argument. Alright then.
20160812 19:57:19-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 19:57:20< travis-ci> wesnoth/wesnoth#10334 (master - 265e41d : Jyrki Vesterinen): The build is still failing.
20160812 19:57:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/151893730
20160812 19:57:20-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 19:57:38-!- mjs-de [~mjs-de@x4db5be47.dyn.telefonica.de] has joined #wesnoth-dev
20160812 20:01:03< vultraz> celticminstrel: I disabled the test but it's still failigng
20160812 20:01:22< vultraz> gfgtaf prefs has them
20160812 20:03:26< celticminstrel> vultraz: It's not failing because the dialog wasn't tested.
20160812 20:03:39< celticminstrel> vultraz: You should re-enable the test and actually fix it.
20160812 20:03:51< vultraz> how?
20160812 20:03:59< celticminstrel> vultraz: Look for twrapper<tmp_create_game>
20160812 20:04:07< vultraz> yes I know
20160812 20:04:24< vultraz> can the tests have a create_engine object?
20160812 20:04:27< celticminstrel> What's the constructor for... what was it... create_engine?
20160812 20:05:39-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160812 20:05:57< vultraz> it need a cvideo and a saved_game objec
20160812 20:05:59< vultraz> t
20160812 20:06:33< celticminstrel> I think you can get a fake cvideo somehow.
20160812 20:06:42< celticminstrel> You can probably construct a saved_game too?
20160812 20:07:38< vultraz> plus the dialog is in flux right now, it doesn't make sense to test it
20160812 20:08:09< celticminstrel> Sure it does.
20160812 20:08:23< vultraz> It does not
20160812 20:08:32< celticminstrel> Sure it does.
20160812 20:09:14< vultraz> :|
20160812 20:13:28-!- gfgtdf [~chatzilla@x4e369c08.dyn.telefonica.de] has joined #wesnoth-dev
20160812 20:13:52< gfgtdf> 20160812 20:01:22< vultraz> gfgtaf prefs has them
20160812 20:13:56< gfgtdf> vultraz: whwew i cannot find it
20160812 20:14:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 20:14:19< vultraz> do you mean from wml or c++?
20160812 20:14:52< celticminstrel> Prefs has what?
20160812 20:15:07< gfgtdf> vultraz: doesnt matter, important is that it has to be a [label] (not a [checkbok] or other eidgets that have text asiciated to it)
20160812 20:15:21< vultraz> come to think of it, i think perhaps labels with tooltips are broken...
20160812 20:17:00< vultraz> yeah I think labels for tcontrol objects are broken
20160812 20:17:24< gfgtdf> vultraz: i assume you mean tooltips for tlable objects ?
20160812 20:17:36< vultraz> labels inherit from tcontrol
20160812 20:17:40< vultraz> as does timage
20160812 20:17:41< gfgtdf> vultraz: i'm tying to add the tooltips to unit_previe_pane traits & abiltites
20160812 20:17:52< vultraz> where ive also observed tooltips not working
20160812 20:17:53< gfgtdf> checboxes also inherti form tcontrol
20160812 20:18:52-!- mjs-de [~mjs-de@x4db5be47.dyn.telefonica.de] has quit [Remote host closed the connection]
20160812 20:19:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160812 20:19:56< vultraz> and tselectable_
20160812 20:22:22< gfgtdf> vultraz: no tselectable_ doesnt inherit from tcontrol
20160812 20:22:39< vultraz> no i mean toggle buttons inherit from tselectable_
20160812 20:23:17-!- JyrkiVesterinen [~JyrkiVest@87-92-21-10.bb.dnainternet.fi] has quit [Quit: Going to bed]
20160812 20:23:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 20:24:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160812 20:24:19< vultraz> gfgtdf: btw scrollbar container doesn't seem the place to put that header hack.
20160812 20:24:42< vultraz> since it doesn't really have any place to search besides the content_grid_...
20160812 20:25:47< gfgtdf> vultraz: it has grid() which is a memebr of tcontrol
20160812 20:29:18-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160812 20:32:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 20:33:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160812 20:33:57-!- wedge010 is now known as wedge009
20160812 20:36:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160812 20:45:41< vultraz> gfgtdf: seems to works :O
20160812 20:45:55< vultraz> just need a non-const version of grid()
20160812 20:46:45< gfgtdf> vultraz: i think we dont want to get the size, and if we just want to get soemthing const shodul be suficient
20160812 20:47:07-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160812 20:47:12< vultraz> gfgtdf: no, find_widget doesn't  take a const first argument for some reason
20160812 20:47:42< vultraz> if(tgrid* header = find_widget<tgrid>(&grid(), "_header_grid", false, false)) doesn't build
20160812 20:47:54< vultraz> if(tgrid* header = find_widget<tgrid>(const_cast<tgrid*>(&grid()), "_header_grid", false, false)) DOES build, but obviously I'm not going to use that
20160812 20:47:56< gfgtdf> vultraz: did you try find_widget<const tgrid>  .. ?
20160812 20:48:15< vultraz> gfgtdf: wait, you can use const in template specifications?
20160812 20:48:18< vultraz> O_O
20160812 20:48:33< celmin> vultraz: Why are you looking so surprised?
20160812 20:48:40< celmin> const is part of a type.
20160812 20:48:45< celmin> It can be used anywhere you use a type.
20160812 20:49:00< celmin> (That's not quite the same as places where you use a type name, like after :: )
20160812 20:49:02< vultraz> I just...never realized this :|
20160812 20:49:21< vultraz> but yeah, that works!
20160812 20:49:24< celmin> That's not a template specification, either.
20160812 20:49:28< celmin> It's template arguments.
20160812 20:49:30< vultraz> jeez if I had known this before
20160812 20:49:48< celmin> BTW, did you see my pings?
20160812 20:50:28< vultraz> which ones?
20160812 20:51:14< vultraz> gfgtdf: huge thanks for finding the right place to fix this bug :)
20160812 20:52:08< gfgtdf> vultraz: well since tscrollbar_container shodultn realyl know about hreader, this is still quite hacky, a better solution woudl be to somehow add some flexibiity in tscrollbar_container and thne use tehta in tlistbox
20160812 20:52:29< vultraz> yeah
20160812 20:52:33< irker712> wesnoth: ln-zookeeper wesnoth:1.12 87defca699fd / data/campaigns/Descent_Into_Darkness/scenarios/11_Descent_into_Darkness.cfg: Commented out the trap event https://github.com/wesnoth/wesnoth/commit/87defca699fd0906576bfdec9ba354e84fb3a5f3
20160812 20:52:37< vultraz> but for now, this is good enough
20160812 20:52:55< celmin> vultraz: Earlier today.
20160812 20:53:03< celmin> Like, a few hours ago.
20160812 20:53:08< vultraz> now, we need to figure out why tooltips are broken in labels and images
20160812 20:53:34< vultraz> celmin: you said you committed the const_cast stuff
20160812 20:53:43< celmin> To a branch.
20160812 20:54:42< gfgtdf> vultraz: in label.hpp replace 'bool can_mouse_focus() const override { return false; }' with 'bool can_mouse_focus() const override { return !tooltip().empty(); }'
20160812 20:54:58< celmin> And PR 744.
20160812 20:55:48< irker712> wesnoth: Charles Dang wesnoth:master f5210fa39d28 / src/gui/widgets/scrollbar_container.cpp: Workaround for bug #24780, courtesy of gfgtdf https://github.com/wesnoth/wesnoth/commit/f5210fa39d284e44654e7e6be719bb8b9a262df3
20160812 20:56:08< celmin> Workaround? Not fix?
20160812 20:56:20< vultraz> It's not a clean fix
20160812 20:56:22< celmin> Oh, that was the other one.
20160812 20:56:28< celmin> Not what he just said now.
20160812 20:56:31< vultraz> Yes
20160812 21:01:05< celmin> So anyway, if you could review and/or test PR744, that'd be great.
20160812 21:02:08< vultraz> gfgtdf: that fixes it
20160812 21:05:22< vultraz> hm
20160812 21:05:22< celmin> I want to get back to the abilities refactor, but I keep getting lost with how to handle [unit][abilities]...
20160812 21:05:31< vultraz> images still seem intent on ignoring tooltips..
20160812 21:06:05< celmin> Though, SingleUnitWML doesn't mention [abilities] as I recall.
20160812 21:06:21< celmin> So maybe [unit][abilities] is only there for save-file support?
20160812 21:06:38< celmin> Still, even if that's the case, someone might have relied on it...
20160812 21:10:29-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160812 21:10:53< gfgtdf> vultraz: teh same fix is mostlileley  applicable to image.hpp
20160812 21:11:15< celmin> vultraz: It should be obvious that changing label.hpp won't affect images.
20160812 21:14:09< vultraz> ok also fixed
20160812 21:14:19< vultraz> gfgtdf: should i commit this?
20160812 21:14:42< zookeeper> celmin, i'm not sure why you seem so adamant about pushing through with that
20160812 21:14:59< gfgtdf> vultraz: yes, i also have this locally but i can handle the mergign clict easily.
20160812 21:15:15< gfgtdf> zookeeper: i think this is about savefilesize reduction.
20160812 21:15:38< celmin> zookeeper: You mean the abilities refactor?
20160812 21:15:46< zookeeper> yes
20160812 21:16:02< celmin> Maybe because I dislike macros.
20160812 21:16:11< irker712> wesnoth: Charles Dang wesnoth:master 450f16ffb811 / src/gui/widgets/ (image.hpp label.hpp): Fix for tooltips not showing on labels and images, courtesy of gfgtdf https://github.com/wesnoth/wesnoth/commit/450f16ffb811d86edf1b98e34b926e3b5df95e66
20160812 21:17:32< zookeeper> celmin, i'd suggest you think of some much better reason :>
20160812 21:17:45< zookeeper> it'd reduce savefile size, but it seems like it'd be very marginal
20160812 21:17:59< celmin> It would reduce savefile size, yeah.
20160812 21:18:08< celmin> But you're likely right that it's a small change in that respect.
20160812 21:19:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160812 21:23:22< zookeeper> not to sound like a broken record, but that seems like a change that would break a huge amount of code (eventually, even if not immediately) and inadvertently but inevitably introduce a big pile of new bugs, all for marginal benefits in savefile size or to satisfy some kind of aesthetic preferences.
20160812 21:23:39-!- louis94 [~~louis94@91.178.241.1] has joined #wesnoth-dev
20160812 21:26:08< shadowm> El sigh.
20160812 21:27:26< shadowm> Sure, there's some value in enforcing the status quo if you're running low on human resources, but the same argument could be made in favor of improving the less savory aspects of WML.
20160812 21:29:24< shadowm> There's nothing wrong with introducing 50 new bugs that will be reduced to less than 5 in two dev releases' time. OTOH there's a lot wrong with introducing bugs that will never be fixed because the person who did so leaves the project or moves onto other tasks.
20160812 21:31:24< shadowm> I don't even know what this is about and I am not really interested. All I'm saying is that the potential for new bugs tends to be used as a blanket argument to shoot down anything that changes anything.
20160812 21:31:35< zookeeper> well in this case i'm for status quo because i don't consider it unsavoury or as making anyone's life difficult. it's simple and straightforward, and doesn't seem to be an inconvenience to anyone.
20160812 21:32:00< shadowm> The fact that save files are colossal hasn't stopped being a thing that is true or anything.
20160812 21:32:26< shadowm> Sure, you don't notice most of the time because you use compression on hosts with decent specs.
20160812 21:32:42< shadowm> And never try parsing saves with external tools or anything of the sort.
20160812 21:32:51< zookeeper> i'll reserve judgement on the savefile size issue until i actually see some kind of comparison of how much filesize would be saved
20160812 21:33:33< celmin> That's surprisingly hard to do. I did do a comparison back when I was trying to make units use a prototypal model, though some things got in the way of accurate results.
20160812 21:34:15< zookeeper> eh? that's easy to do. just take a normal savefile of decent size and edit the abilities to look like how you'd make them look like. then compare filesizes.
20160812 21:34:19< celmin> (That never ended up in master because gfgtdf did something that conflicted a lot, possibly sort of a similar thing, and I gave up.)
20160812 21:34:22< zookeeper> i mean how else would you do it?
20160812 21:35:10< celmin> Well, the hardest part is getting the save file. Once I have a save file, I would load it in Wesnoth, re-save it under a different name, and compare the size.
20160812 21:35:39-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 21:35:40< travis-ci> spixi/wesnoth#11 (chart_engine - b77d36d : Spixi): The build is still failing.
20160812 21:35:40< travis-ci> Build details : https://travis-ci.org/spixi/wesnoth/builds/151925981
20160812 21:35:40-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 21:35:43< celmin> Though, editing it with a text editor as a mock-up could certainly produce the same result (and without having to implement it first)...
20160812 21:35:45< irker712> wesnoth: Charles Dang wesnoth:master 312a77c075e7 / src/editor/map/context_manager.cpp: Fixed crash on entering the editor (bug #24964) https://github.com/wesnoth/wesnoth/commit/312a77c075e7abedb7b5e358827f10f7e7501b28
20160812 21:35:59< shadowm> Also, reducing usage of macros is usually a step in the right direction simply because of the fact that it decreases the parsed tree's size (decreased load times, decreased RAM usage, decreased disk cache usage).
20160812 21:36:17< shadowm> Or at the very least shrinking those macros.
20160812 21:36:20< zookeeper> using a text editor is kind of what i meant by "edit"
20160812 21:36:31< celmin> I know
20160812 21:37:19-!- prkc [~prkc@192.40.89.71] has quit [Remote host closed the connection]
20160812 21:37:30< zookeeper> i can't come up with any plausible interpretations of what you might have meant by "the hardest part is getting the save file"
20160812 21:38:06< celmin> Well, I can't just start a game, save it, and use that.
20160812 21:38:15< zookeeper> ...why?
20160812 21:38:43< celmin> That won't give useful results, because it's not that close to an "average" save file.
20160812 21:39:09< celmin> It might be sufficient to play through one scenario and save just before the end.
20160812 21:39:39< zookeeper> so are you actually saying that you think it's hard to come up with a wesnoth savefile that contains a set of units even vaguely representative of what you might typically see in a campaign?
20160812 21:39:39< celmin> Though that won't leave you with recall units, and you probably won't have that many higher-level units either.
20160812 21:39:50< celmin> Yeah.
20160812 21:39:57< celmin> That sounds about right.
20160812 21:40:20< celmin> My test case was playing through AToTB. I dunno if it's average though.
20160812 21:40:24< zookeeper> i... i don't know what to say
20160812 21:41:37< celmin> Ideally you'd want to compare more than just one pair of save files.
20160812 21:44:15-!- Appleman1234 [~Appleman1@KD036012020177.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160812 21:51:22-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 21:54:57-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160812 21:55:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160812 22:02:16-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160812 22:03:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160812 22:10:07< tad_> @zookeeper: CM and I found the bug in [object] and I've pushed a new HttT errors without that workaround. Took out the save=no stuff earlier.
20160812 22:11:54< zookeeper> cool
20160812 22:13:59< tad_> I'm working on AToTB atm. My plans for HttT are to let it simmer to see if anyone has anything else. When errors merges, if needed, I'll push rebased updates to reduce the clutter everywhere else.
20160812 22:14:48< zookeeper> i'm inclined to just merge it now to finally get it out of the way
20160812 22:14:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160812 22:15:00< tad_> Your call.
20160812 22:15:27-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160812 22:15:43< gfgtdf> vultraz: does treeview::clear() work properly ?
20160812 22:15:54< vultraz> gfgtdf: it seems to
20160812 22:15:55< tad_> I saw earlier discussion about DM and all the leader/recall list changing. If anyone is looking at that mess, my DM PR has a lot of cleanup for all the errors/warning it causes.
20160812 22:17:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160812 22:18:37< tad_> My plan is to get back to DM when I've finished AToTB, then TSG to get my current PRs up-to-date before I head into new territory.
20160812 22:19:49< zookeeper> ok, i'm gonna merge it. brace yourselves for commit spam (not gonna mute irker because there aren't needless noise).
20160812 22:19:50-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 22:19:51< travis-ci> spixi/wesnoth#12 (chart_engine - 79afa1a : Spixi): The build is still failing.
20160812 22:19:51< travis-ci> Build details : https://travis-ci.org/spixi/wesnoth/builds/151935811
20160812 22:19:51-!- travis-ci [~travis-ci@ec2-54-226-47-38.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 22:19:57< zookeeper> s/there/these
20160812 22:20:38< irker712> wesnoth: Gregory A Lundberg wesnoth:master 55065088a184 / data/campaigns/Heir_To_The_Throne/utils/httt_utils.cfg: HttT Remove unused macro https://github.com/wesnoth/wesnoth/commit/55065088a1848bafaffa458d3786a3f7681bb3ff
20160812 22:20:40< irker712> wesnoth: Gregory A Lundberg wesnoth:master 74786a219bf7 / data/campaigns/Heir_To_The_Throne/scenarios/ (11 files): HttT Remove macro artifacts https://github.com/wesnoth/wesnoth/commit/74786a219bf7d7a6b03eedb4af4a0ff90f265096
20160812 22:20:42< irker712> wesnoth: Gregory A Lundberg wesnoth:master a2811dd620f7 / data/campaigns/Heir_To_The_Throne/ (17 files in 2 dirs): HttT Remove variable artifacts https://github.com/wesnoth/wesnoth/commit/a2811dd620f73e05469ed7aaf1435cecd205bca3
20160812 22:20:44< irker712> wesnoth: Gregory A Lundberg wesnoth:master 2cf5c075ca10 / data/campaigns/Heir_To_The_Throne/scenarios/ (10_Gryphon_Mountain.cfg 19b_Swamp_Of_Dread.cfg 19c_Cliffs_of_Thoria.cfg): HttT [else][if] s/b [elseif]; [if] requires conditional https://github.com/wesnoth/wesnoth/commit/2cf5c075ca10b0ac0cce181072423c251843897d
20160812 22:20:46< irker712> wesnoth: Gregory A Lundberg wesnoth:master 66a68bccdeb5 / data/campaigns/Heir_To_The_Throne/scenarios/04_The_Bay_of_Pearls.cfg: HttT Filters should go first https://github.com/wesnoth/wesnoth/commit/66a68bccdeb524a8c1fc5c4b9da31adb07ada28e
20160812 22:20:48< irker712> wesnoth: Gregory A Lundberg wesnoth:master af1ca672a409 / data/campaigns/Heir_To_The_Throne/scenarios/02_Blackwater_Port.cfg: HttT S02 Fix bug: Missing objective https://github.com/wesnoth/wesnoth/commit/af1ca672a40933b5aa105b6b618d69c653c0c519
20160812 22:20:50< irker712> wesnoth: Gregory A Lundberg wesnoth:master be881db8797e / data/campaigns/Heir_To_The_Throne/scenarios/02_Blackwater_Port.cfg: HttT S02 Fix bux: Simyr inconsistent https://github.com/wesnoth/wesnoth/commit/be881db8797e7454515b2ca43ed660ee774a6fc3
20160812 22:20:52< irker712> wesnoth: Gregory A Lundberg wesnoth:master 372932ffb4e7 / data/campaigns/Heir_To_The_Throne/scenarios/02_Blackwater_Port.cfg: HttT S02 Fix typo: Missing comma https://github.com/wesnoth/wesnoth/commit/372932ffb4e7d1695aaa433d6694f7859265db47
20160812 22:20:54< irker712> wesnoth: Gregory A Lundberg wesnoth:master 9cc6eb7deb80 / data/campaigns/Heir_To_The_Throne/scenarios/04_The_Bay_of_Pearls.cfg: HttT S04 Fix bug: Remove ford artifact on HARD https://github.com/wesnoth/wesnoth/commit/9cc6eb7deb80232d64b0f04617245dbb92a2efab
20160812 22:20:56< irker712> wesnoth: Gregory A Lundberg wesnoth:master 0c6aae0b3849 / data/campaigns/Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg: HttT S05b Fix bug: No special bonus https://github.com/wesnoth/wesnoth/commit/0c6aae0b384934932fb0f537668267d88d99976c
20160812 22:20:58< irker712> wesnoth: Gregory A Lundberg wesnoth:master cd995390f323 / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S06 Fix bug: Advisor may be dead https://github.com/wesnoth/wesnoth/commit/cd995390f3231cd49db1ab453e59393ffba70e3e
20160812 22:21:00< irker712> wesnoth: Gregory A Lundberg wesnoth:master 2d75dca42efc / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S06 Fix bug: Thieves' Ford wipes out a pier https://github.com/wesnoth/wesnoth/commit/2d75dca42efc678cf16749dce5cf5001368604d8
20160812 22:21:02< irker712> wesnoth: Gregory A Lundberg wesnoth:master 28404e922fea / data/campaigns/Heir_To_The_Throne/scenarios/06_The_Siege_of_Elensefar.cfg: HttT S06 Fix bug: Adjust time area https://github.com/wesnoth/wesnoth/commit/28404e922fea266d94527921f47ed2d0af87087f
20160812 22:21:04< irker712> wesnoth: Gregory A Lundberg wesnoth:master 738307b5cef7 / data/campaigns/Heir_To_The_Throne/scenarios/07_Crossroads.cfg: HttT S07 Fix bug: Units not hiding https://github.com/wesnoth/wesnoth/commit/738307b5cef705d5728161cab6ec9c6c96ecf4d8
20160812 22:21:06< irker712> wesnoth: Gregory A Lundberg wesnoth:master a3c9ca1fa3eb / data/campaigns/Heir_To_The_Throne/scenarios/07_Crossroads.cfg: HttT S07 Fix bug: Overlapped areas https://github.com/wesnoth/wesnoth/commit/a3c9ca1fa3eb5ca1dcfd4fc7aad5218abe8119a6
20160812 22:21:08< irker712> wesnoth: Gregory A Lundberg wesnoth:master c6542da477ba / data/campaigns/Heir_To_The_Throne/scenarios/08_The_Princess_of_Wesnoth.cfg: HttT S08 Fix bug: Advisor may be dead https://github.com/wesnoth/wesnoth/commit/c6542da477ba596a3a50152ebd4b8b59fa731b85
20160812 22:21:10< irker712> wesnoth: Gregory A Lundberg wesnoth:master b3fed9db8948 / data/campaigns/Heir_To_The_Throne/scenarios/08_The_Princess_of_Wesnoth.cfg: HttT S08 Fix bug: Objective footnote https://github.com/wesnoth/wesnoth/commit/b3fed9db8948e4a4900fe87a12a54f2d543a11da
20160812 22:21:12< irker712> wesnoth: Gregory A Lundberg wesnoth:master 73da0aa4a428 / data/campaigns/Heir_To_The_Throne/scenarios/10_Gryphon_Mountain.cfg: HttT S10 Fix bug: Does not meet objectives https://github.com/wesnoth/wesnoth/commit/73da0aa4a42891879d26bd5849da3c905c345a96
20160812 22:21:14< irker712> wesnoth: Gregory A Lundberg wesnoth:master f16e67434d2b / data/campaigns/Heir_To_The_Throne/scenarios/11_The_Ford_of_Abez.cfg: HttT S11 Fix bugs: No reinforcements https://github.com/wesnoth/wesnoth/commit/f16e67434d2b8f21e171cd1ab395311f9934a964
20160812 22:21:16< irker712> wesnoth: Gregory A Lundberg wesnoth:master 9f7933defa23 / data/campaigns/Heir_To_The_Throne/scenarios/11_The_Ford_of_Abez.cfg: HttT S11 Fix bug: Does not meet objectives https://github.com/wesnoth/wesnoth/commit/9f7933defa23b44d7c477be977e230bfbea5b13e
20160812 22:21:18< irker712> wesnoth: Gregory A Lundberg wesnoth:master 8bdd07cd4d8b / data/campaigns/Heir_To_The_Throne/scenarios/12_Northern_Winter.cfg: HttT S12 Fix bug: Divide by zero https://github.com/wesnoth/wesnoth/commit/8bdd07cd4d8beed15f0e5a2a9a045bfb948b3110
20160812 22:21:20< irker712> wesnoth: Gregory A Lundberg wesnoth:master f719bc06f9a6 / data/campaigns/Heir_To_The_Throne/scenarios/12_Northern_Winter.cfg: HttT S12 Fix bug: No human to complain https://github.com/wesnoth/wesnoth/commit/f719bc06f9a667e588e768a4cfa8cd6795b99ddb
20160812 22:21:22< irker712> wesnoth: Gregory A Lundberg wesnoth:master fd37c8aa3815 / data/campaigns/Heir_To_The_Throne/scenarios/13_The_Dwarven_Doors.cfg: HttT S13 Fix bug: No rider https://github.com/wesnoth/wesnoth/commit/fd37c8aa3815b4aaf4c9427960c29c33d1647a20
20160812 22:21:24< irker712> wesnoth: Gregory A Lundberg wesnoth:master 76c35da543e2 / data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg: HttT S17 Fix bug: Hide sides https://github.com/wesnoth/wesnoth/commit/76c35da543e2c7ad81ba5b38e2b88282848ba2d9
20160812 22:21:26< irker712> wesnoth: Gregory A Lundberg wesnoth:master f319d58cff33 / data/campaigns/Heir_To_The_Throne/utils/httt_utils.cfg: HttT S17 Fix bug: Castles not removed https://github.com/wesnoth/wesnoth/commit/f319d58cff3310237425507a0123fb330a28732b
20160812 22:21:28< irker712> wesnoth: Gregory A Lundberg wesnoth:master 49047381a6e9 / data/campaigns/Heir_To_The_Throne/scenarios/17_Scepter_of_Fire.cfg: HttT S17 Fix bug: Unusable castle hex https://github.com/wesnoth/wesnoth/commit/49047381a6e9d5d04a6459609590a9f44fbb101c
20160812 22:21:30< irker712> wesnoth: Gregory A Lundberg wesnoth:master 71217cd98607 / data/campaigns/Heir_To_The_Throne/scenarios/19b_Swamp_Of_Dread.cfg: HttT S19b Fix bug: Objectives wrong https://github.com/wesnoth/wesnoth/commit/71217cd986077423d6a002915971b594d400da96
20160812 22:21:32< irker712> wesnoth: Gregory A Lundberg wesnoth:master 0db307d9e25a / data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: HttT S19c Fix bug: Wrong objectives https://github.com/wesnoth/wesnoth/commit/0db307d9e25a58ee9e4f61de453f04c3565316f6
20160812 22:21:34< irker712> wesnoth: Gregory A Lundberg wesnoth:master 3a42f3968025 / data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: HttT S19c Fix bug: Merman advisor may be dead https://github.com/wesnoth/wesnoth/commit/3a42f3968025398b231e835cf38b7c28eef16c1e
20160812 22:21:36< irker712> wesnoth: Gregory A Lundberg wesnoth:master 8f09ac74adc5 / data/campaigns/Heir_To_The_Throne/scenarios/19c_Cliffs_of_Thoria.cfg: HttT S19c Fix bug: Clear fog https://github.com/wesnoth/wesnoth/commit/8f09ac74adc57ef93e77863c85b5afb20ff300ef
20160812 22:21:38< irker712> wesnoth: Gregory A Lundberg wesnoth:master 8f20715f9a6e / data/campaigns/Heir_To_The_Throne/scenarios/20a_North_Elves.cfg: HttT S20a Fix bug: El'rien might be dead https://github.com/wesnoth/wesnoth/commit/8f20715f9a6e1f200d94c20c27a76b144ffc1bf4
20160812 22:21:40< irker712> wesnoth: Gregory A Lundberg wesnoth:master 901deee49f66 / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b Fix bug: Victory zone https://github.com/wesnoth/wesnoth/commit/901deee49f66c3bbe994d3cea6cb23c54c794a42
20160812 22:21:42< irker712> wesnoth: Gregory A Lundberg wesnoth:master 1f7bb04cba84 / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b Fix bug: Bona-Melodia may be dead https://github.com/wesnoth/wesnoth/commit/1f7bb04cba845f80267505a556295146b87ba87d
20160812 22:21:44< irker712> wesnoth: Gregory A Lundberg wesnoth:master 9251d449dcec / data/campaigns/Heir_To_The_Throne/scenarios/20b_Underground_Channels.cfg: HttT S20b Fix bug: Unused side https://github.com/wesnoth/wesnoth/commit/9251d449dcec301da597efc58aca139a2fcd81a9
20160812 22:21:46< irker712> wesnoth: Gregory A Lundberg wesnoth:master a9e381730e29 / data/campaigns/Heir_To_The_Throne/scenarios/22_Return_to_Wesnoth.cfg: HttT S22 Fix bug: Malatus dies first https://github.com/wesnoth/wesnoth/commit/a9e381730e291b4155ea73596f38e3280182b91f
20160812 22:21:48< irker712> wesnoth: Gregory A Lundberg wesnoth:master 9b56cb103b67 / data/campaigns/Heir_To_The_Throne/scenarios/24_Battle_for_Wesnoth.cfg: HttT S24 Fix bug: Missing journey map https://github.com/wesnoth/wesnoth/commit/9b56cb103b6703a887b008bc8f57b88a1ee647f8
20160812 22:21:50< irker712> wesnoth: Gregory A Lundberg wesnoth:master c3d74c5726dd / data/campaigns/Heir_To_The_Throne/scenarios/25_HttT_Epilogue.cfg: HttT S25 Fix bug: Comment wrong https://github.com/wesnoth/wesnoth/commit/c3d74c5726dd3859228deb773a62acd41353ffea
20160812 22:21:52< irker712> wesnoth: Gregory A Lundberg wesnoth:master 4da8f20d0c8b / data/campaigns/Heir_To_The_Throne/ (13 files in 3 dirs): HttT Fix typo: Sceptre vs scepter https://github.com/wesnoth/wesnoth/commit/4da8f20d0c8b5589019fa742fbb5546ba4dbc507
20160812 22:21:54< irker712> wesnoth: Lari Nieminen wesnoth:master 12f710704765 / data/campaigns/Heir_To_The_Throne/ (33 files in 3 dirs): Merge pull request #729 from GregoryLundberg/GL_HttT_errors https://github.com/wesnoth/wesnoth/commit/12f710704765c7e119aa7883d213b9ee8dc45c66
20160812 22:21:57< vultraz> MANY MUCH COMMITS
20160812 22:21:59< vultraz> :D
20160812 22:23:37< tad_> OK. Github didn't adjust so I'll push to clear the clutter in a bit. Gotta sync then re-test and update my notes.
20160812 22:24:17-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160812 22:25:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160812 22:28:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160812 22:33:20-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160812 22:34:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 22:36:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160812 22:36:28-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has quit [Ping timeout: 250 seconds]
20160812 22:36:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 22:37:57-!- Appleman1234 [~Appleman1@KD036012030225.au-net.ne.jp] has joined #wesnoth-dev
20160812 22:40:52< gfgtdf> vultraz: hmm i now  have a problem with label: somehow wrap=yes doestn sork, when the text is increased it still does only increase the width although it shodul increase the height.
20160812 22:41:14< gfgtdf> work*
20160812 22:41:21< gfgtdf> vultraz: you know how to work around it
20160812 22:41:29< vultraz> gfgtdf: it prioritizes width over height, unless you use characters_per_line
20160812 22:41:37< vultraz> or force space with a spacer
20160812 22:42:04< wedge009> celticminstrel: What did you notice that I noticed? Plus I'll try to have a look at / test of PR #744 later though the details will be lost on me.
20160812 22:42:13< gfgtdf> vultraz: the point is that it then resizes then the whole dialog whcih it shouldn't
20160812 22:42:38< vultraz> what do you mean?
20160812 22:42:39< gfgtdf> vultraz: (i'm again at implementing tooltips for trait adn abilities in the unit_previw_pane)
20160812 22:42:54< vultraz> hmmm
20160812 22:43:02< vultraz> gfgtdf: does it resize the dialog the preview pane is in?
20160812 22:43:08< gfgtdf> vultraz: yes
20160812 22:43:11< vultraz> hmm
20160812 22:43:14< vultraz> can I see your code?
20160812 22:43:18< gfgtdf> vultraz: with my now code with tooltips, (that uses one [label] for each line)
20160812 22:43:29< celmin> wedge009: Sorry, I've forgotten the context of that question.
20160812 22:43:35< vultraz> one label for each line... 
20160812 22:43:43< vultraz> yeah I can see how that would cause problems :|
20160812 22:43:51< wedge009> celmin: Okay, no worries.
20160812 22:44:06< celmin> wedge009: Did I mention it here or on a PR?
20160812 22:44:08< gfgtdf> vultraz: well i need a widgets for each line if i want to show different tooltips for each line.
20160812 22:44:15< vultraz> yes
20160812 22:44:19< vultraz> I can see that
20160812 22:44:34< vultraz> or one could just make a giant tooltip with all the trait and ability descriptions :P
20160812 22:45:09< celmin> No.
20160812 22:45:09< wedge009> 4:34:37 am (18:34 UTC) - celticminstrel: Not sure why I didn't mention the point that wedge009 brought up. I seem to recall noticing it too.
20160812 22:45:29< celmin> wedge009: Oh I remember now, that was about your comment on the description updates PR.
20160812 22:45:43< celmin> About "on
20160812 22:45:47< celmin> " vs "in"
20160812 22:45:55< wedge009> Oh okay, cool. Glad I'm not the only one. (:
20160812 22:46:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160812 22:46:21< celmin> I think I noticed it, but for some reason didn't say anything. Unless I'm just imagining that I noticed it. I dunno.
20160812 22:46:23< vultraz> celmin: what about a tooltip with only all trait descriptions and another for all ability descriptions
20160812 22:46:48< celmin> vultraz: That's sorta what the sidebar does already, though admittedly only if it runs out of space for all the traits.
20160812 22:47:14< celmin> vultraz: Not ideal, but maybe acceptable.
20160812 22:47:16< vultraz> using one label for each line..
20160812 22:47:26< vultraz> I honestly dont know how gfgtdf is managing that
20160812 22:47:40< gfgtdf> vultraz: i put them in a treeview
20160812 22:47:46< vultraz> I see
20160812 22:47:59< celmin> Oh, gfgtdf is refactoring the unit preview widget?
20160812 22:48:36< vultraz> yes :/
20160812 22:48:58< celmin> You don't seem happy about this somehow.
20160812 22:49:25< vultraz> I dunno, it's always been "my" piece of code, it feels weird to have someone else poke around at it.
20160812 22:49:35< vultraz> But this is irrelevant 
20160812 22:49:40< celmin> That's the point of open source.
20160812 22:52:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160812 22:52:24< gfgtdf> vultraz: this is my current code: https://github.com/gfgtdf/wesnoth-old/commit/f9774ce2ecb2a0891977b4f719db25ff6ddceeb2
20160812 22:53:15< celmin> gfgtdf: There's something very wrong with your commit message. :P
20160812 22:53:56< vultraz> why did you make if(label_details_) an 'else if'?
20160812 22:54:00< gfgtdf> celmin: yes i have toi redo it later anyway so i wasn't  very careful.
20160812 22:54:55< celmin> …wait what?
20160812 22:54:58< gfgtdf> vultraz: accidently it first i changed the set_displayed_type but then i deciden to bedin my work with set_displayed_unit() since i mainyl care abotu the recall list
20160812 22:55:02< celmin> Tree view folding was broken?
20160812 22:55:23< celmin> Why'd you comment out is_root_node()?
20160812 22:56:13< vultraz> gfgtdf: I'd like to do some cleanup on this after you commit
20160812 22:56:14< gfgtdf> celmin: it didnt make sense to me and it fixed some at some piint , but i want 100% sure will test that later again.
20160812 22:56:48< celmin> vultraz's question is legitimate too - there seems no reason for an else on line 149.
20160812 22:57:20< vultraz> gfgtdf: eg, there's no need for calls to unfold(). Just set unfoded = true in the WML.
20160812 22:57:23< vultraz> unfolded*
20160812 22:57:58< gfgtdf> vultraz: hmm i tied but it sindt seen to have any effect, mabye i added it at the worn position
20160812 22:58:07< vultraz> and I already had a function for printing out attacks... edits should be done there so they affect both types and units.
20160812 22:58:13< vultraz> gfgtdf: it goes in [node] IIRC
20160812 22:59:03< celmin> Yeah, it looks like you added attack handling in the wrong place...
20160812 23:00:01< gfgtdf> ?
20160812 23:00:23< vultraz> attack details should be handled in tunit_preview_pane::print_attack_details
20160812 23:00:28< celmin> Line 344 in your commit.
20160812 23:00:36< celmin> That's handling attacks, right?
20160812 23:00:44< celmin> But you shouldn't be doing it there, as vultraz just said.
20160812 23:00:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 23:01:12< celmin> BTW, is the label_details_ still necessary if you have a tree_details_?
20160812 23:01:20< gfgtdf> vultraz: it seems like unfolded onyl work if teh node also has a user accesible way to toggle it
20160812 23:01:32< vultraz> I see
20160812 23:01:36< vultraz> that sounds like a bug
20160812 23:01:38< celmin> ^
20160812 23:02:42< gfgtdf> vultraz function didn't work for the treeview way.
20160812 23:02:48< vultraz> ugh
20160812 23:03:09< vultraz> ok, I'll be doing cleanup anyway.
20160812 23:03:15< vultraz> just commit what you have if it works
20160812 23:03:16< gfgtdf> and i never said its complatee
20160812 23:03:39< gfgtdf> in patrticular the unti type code still doesnt show the tooltips
20160812 23:05:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160812 23:05:56< celmin> vultraz: Don't say that
20160812 23:06:04< vultraz> what?
20160812 23:06:30< celmin> [Aug 12@7:03:15pm] vultraz: just commit what you have if it works
20160812 23:06:55< celmin> Encouraging people to commit poor-quality code is not a good thing.
20160812 23:07:13< celmin> But I understand that this is poor-quality mainly because it's a work in progress.
20160812 23:07:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160812 23:07:26< celmin> So I'm sure gfgtdf will clean it up before committing.
20160812 23:07:39< celmin> Don't say you'll do cleanup until you see the final result.
20160812 23:08:12< irker712> wesnoth: Charles Dang wesnoth:master 0526808f7d26 / data/gui/window/game_stats.cfg: Game Stats: bumped max height a bit https://github.com/wesnoth/wesnoth/commit/0526808f7d265e155858aa4792988829e2402415
20160812 23:08:16< celmin> ...
20160812 23:08:39< celmin> All your little "minor adjustment" commits kind of irritate me.
20160812 23:09:06< zookeeper> celmin, shadowm, a very non-representative filesize test: i started TB, created so many units (each one with at least one ability or special) that i had 58 units total. savefile size 328kb. then i took out all [specials] and [abilities] tags. savefile size dropped to 276kb.
20160812 23:09:07< zookeeper> but i'd like to stress that that's a very artificial usecase. with an actual SotBE S04 turn 3 save the numbers were 847kb and 830kb.
20160812 23:09:39< celmin> zookeeper: Which compression mode? Gzip, bzip2, or none?
20160812 23:09:44< vultraz> celmin: that's so the scrollbar doesn't appear in HTTT :|
20160812 23:09:46< vultraz> geez
20160812 23:09:48< zookeeper> uncompressed of course.
20160812 23:09:52< vultraz> not every "minor adjustment" is useless
20160812 23:10:03< celmin> vultraz: It's not about whether it's useless or not.
20160812 23:10:24< celmin> TB = tale of two brothers?
20160812 23:10:27< zookeeper> yes
20160812 23:11:16< vultraz> celmin: then what, pray tell, is the problem
20160812 23:11:48< celmin> Something about quantity, I guess?
20160812 23:12:17< vultraz> Well I could be like dave and commit a million things at once
20160812 23:12:19< vultraz> in one commit
20160812 23:12:21< vultraz> :)
20160812 23:12:36< celmin> If they're all minor adjustments, I wouldn't mind that.
20160812 23:13:07< vultraz> shadowm (or someone else, but i think shadowm) always used to tell me one set of related changes per commit
20160812 23:13:10< vultraz> and I adhere to that
20160812 23:13:25< vultraz> now, if I had "adjust heights on several dialogs", sure
20160812 23:13:27< vultraz> that'd be together
20160812 23:13:42< vultraz> I don't microcommit like tad used to.
20160812 23:13:53< celmin> Yeah okay.
20160812 23:14:27< celmin> "one set of related changes per commit" is basically how I think too
20160812 23:21:21< vultraz> quick q
20160812 23:21:45< vultraz> if i have an object of type std::vector<const unit_type*>&
20160812 23:21:48< vultraz> and i wanted to sort it
20160812 23:21:59< vultraz> what would be the arguments for the lambda 
20160812 23:22:08< vultraz> 	std::sort(recruit_list_.begin(), recruit_list_.end(), [this](const int i1, const int i2) {
20160812 23:22:10< vultraz> 		return recruit_list_[i1]->type_name().str() < recruit_list_[i2]->type_name().str();
20160812 23:22:11< vultraz> 	});
20160812 23:22:13< vultraz> doesn't work
20160812 23:24:19< celmin> Imagine the lambda being called as f(v[n], v[m]).
20160812 23:24:53< celmin> Where f is the lambda and v is the vector. (Though that's probably obvious.)
20160812 23:25:06-!- travis-ci [~travis-ci@ec2-54-227-209-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20160812 23:25:07< travis-ci> gfgtdf/wesnoth-old#679 (master - f9774ce : gfgtdf): The build was broken.
20160812 23:25:08< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/151949346
20160812 23:25:08-!- travis-ci [~travis-ci@ec2-54-227-209-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20160812 23:25:22< vultraz> I see
20160812 23:26:01< vultraz> so we'd want..
20160812 23:26:05< vultraz> well, it'd be
20160812 23:26:23< vultraz> just type->type name().str() or something
20160812 23:26:34< celmin> Yes. BTW, why pointers here?
20160812 23:29:21< vultraz> can't remember
20160812 23:31:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160812 23:31:46< celmin> You should probably always question it when you see pointers.
20160812 23:31:52< celmin> That doesn't mean they're wrong here.
20160812 23:32:12< celmin> Maybe they're the right choice in this case.
20160812 23:33:06< irker712> wesnoth: Charles Dang wesnoth:master 63c1b7f7a629 / src/gui/dialogs/unit_recruit.cpp: Unit Recruit: ensure recruit list is always sorted by name https://github.com/wesnoth/wesnoth/commit/63c1b7f7a6294c66263fbc19ee9193e6fb51fb3e
20160812 23:33:31< shadowm> vultraz: Well, you are microcommitting.
20160812 23:34:26< shadowm> Most of the time with a single file/module/unit/whatever, you commit every change you come up with in the spur of the moment instead of queueing them up and seeing how they add up or how they may even cancel each other out.
20160812 23:34:41< shadowm> I've seen you do this primarily in your campaign, but also here.
20160812 23:35:01< vultraz> yes, well
20160812 23:35:10< vultraz> with my campaign it sometimes was to make it look like i was busy
20160812 23:35:16< vultraz> so you'd think i was making progress
20160812 23:35:18< celmin> Pfffft...
20160812 23:35:24< shadowm> No-one needs to know that at time t you decided to make a button wider, and at time t+24 minutes you decided to make it taller.
20160812 23:35:44< shadowm> You can just combine both changes into a single commit where you make the button larger.
20160812 23:36:10< shadowm> This is a generic example, but I'm sure you get the idea (I hope so at least).
20160812 23:37:20< vultraz> you always were so busy i felt like i needed to be too :|
20160812 23:37:26< vultraz> in hindsight, it was stupid
20160812 23:37:44< vultraz> i try not to microcommit too much in master.
20160812 23:37:58< vultraz> but i'll cut back
20160812 23:38:52< gfgtdf> does anyone knows how to activeate markup in tooltips ?
20160812 23:39:10< celmin> Is it any different than other places?
20160812 23:45:36< gfgtdf> celmin: tooltips  are no wigets to i cannot simple use widget-Yuse_markup(true)
20160812 23:45:44< celmin> Oh...
--- Log closed Sat Aug 13 00:00:31 2016