--- Log opened Sun Aug 14 00:00:56 2016
20160814 00:13:16-!- RatArmy [~RatArmy@om126229084035.12.openmobile.ne.jp] has joined #wesnoth-dev
20160814 00:14:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20160814 00:33:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 00:44:05-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 00:47:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 250 seconds]
20160814 00:47:49-!- noy_ is now known as noy
20160814 01:00:28-!- gfgtdf [~chatzilla@x4e36920b.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160814 01:03:22-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has joined #wesnoth-dev
20160814 01:04:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 265 seconds]
20160814 01:08:24-!- Bonobo [~Bonobo@2001:44b8:254:3200:d11b:3bfd:7ec5:f550] has joined #wesnoth-dev
20160814 01:15:44-!- louis94 [~~louis94@91.178.241.1] has quit [Ping timeout: 265 seconds]
20160814 01:25:16< celmin> I guess we need to mail the list about bumping minimum Boost version...
20160814 01:27:43< celmin> Did Travis break or something?
20160814 01:33:27-!- Bonobo [~Bonobo@2001:44b8:254:3200:d11b:3bfd:7ec5:f550] has quit [Ping timeout: 264 seconds]
20160814 01:34:23-!- Bonobo [~Bonobo@2001:44b8:254:3200:8c9b:2fb9:235a:865c] has joined #wesnoth-dev
20160814 01:35:50< Aginor> celmin: yes, and we need to make it clear which versions we support and don't
20160814 01:36:05< Aginor> for example, I don't think the unit tests compiles on 1.59
20160814 01:36:40< Aginor> which reminds me, can someone please respond to the fedora packages queries? http://gna.org/bugs/?23897
20160814 01:36:53< Aginor> I'm not the right person to field questions about our python scripts
20160814 01:36:57< vultraz> I have still not been able to use 1.6x
20160814 01:39:16< celmin> I'm not sure if my fix actually fixes it for Travis, but it does compile for me.
20160814 01:56:15< Espreon> I keep getting this: https://pastebin.com/63n2cqrn
20160814 01:56:55< Espreon> Clearing everything doesn't seem to help at all. CCache, SCons cache, build/, ...
20160814 01:57:04< celmin> I'm using Boost 1.58. Apparently drop_front() was added in 1.56.
20160814 01:57:11< Espreon> Ah.
20160814 01:57:35< Espreon> Let's see what I have...
20160814 01:57:40< celmin> Which is why we talked about bumping Boost requirements, though according to gfgtdf, advance_begin(1) would do the same thing.
20160814 01:58:01< celmin> I'd rather just bump the requirement though (1.48 must be super-old by now).
20160814 01:58:51< Espreon> I seem to have 1.54 and 1.55. I don't have anything higher available for installation. I don't think this is outdated, but let me check. It's been a while since I tended to this machine.
20160814 01:59:19 * Espreon needs to get back in the swing of things
20160814 02:01:30< Espreon> Yeah, my version of Mint is based on an LTS version of Ubuntu released in 2011, intended to be supported till 2019.
20160814 02:01:53< celmin> I see.
20160814 02:02:08< Espreon> It's too bad I never got to know the general criteria for deciding on whether or not to bump dependencies.
20160814 02:02:26< celmin> I don't think there's an official decision on whether or not to bump it yet.
20160814 02:02:35< celmin> Or what to bump it to.
20160814 02:05:41< Espreon> No, but I do recall people taking into account what certain versions of certain distros had available.
20160814 02:06:02< celmin> For compilers, yeah.
20160814 02:06:22-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160814 02:06:55< Espreon> I really don't remember the details, so beyond this, I can't really say much, so... blah.
20160814 02:07:51< celmin> If you just want it to build so you can do stuff or check things out, I guess changing it to advance_begin(1) is an option (assuming that's how that works).
20160814 02:08:23< Espreon> Changing what to that?
20160814 02:08:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160814 02:08:44< celmin> Well, gfgtdf said changing drop_front() to advance_begin(1) should work.
20160814 02:08:54< celmin> I'm not that familiar with that part of Boost though.
20160814 02:08:55< Espreon> Ah.
20160814 02:09:52-!- RatArmy [~RatArmy@om126229084035.12.openmobile.ne.jp] has quit [Ping timeout: 265 seconds]
20160814 02:31:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160814 02:34:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 02:35:15< irker978> wesnoth: Charles Dang wesnoth:master 176f96251837 / data/gui/widget/unit_preview_pane.cfg src/gui/widgets/unit_preview_pane.cpp: Minor cleanup https://github.com/wesnoth/wesnoth/commit/176f9625183787702b21786e40ef2486521f5eb3
20160814 02:35:29< celmin> Sudden vultraz 
20160814 02:35:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 264 seconds]
20160814 02:36:00< vultraz> Allos
20160814 02:36:28< celmin> That's a pretty big chunk rewritten, does it really count as minor
20160814 02:36:29< celmin> ?
20160814 02:36:49< vultraz> actually, it just removed an unnecessary grid
20160814 02:37:04< celmin> Why'd you change the comment type? That was totally pointless.
20160814 02:37:37< vultraz> consistency with other comments
20160814 02:37:44< celmin> Pointless.
20160814 02:37:50< vultraz> do you scrutinize ALL my commits? :|
20160814 02:38:14< celmin> I try to scrutinize all commits, not just yours, though… I don't actually scrutinize all of them...
20160814 02:38:37< celmin> My point is, it's not really about you?
20160814 02:39:18-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 02:39:23< celmin> Oh hi.
20160814 02:41:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160814 02:41:18< tad_> Duh. Got an error. Came to ask about it. Remembered I forgot to rebase the branch. Did that and error is gone. *sigh*
20160814 02:41:32< celmin> Heh...
20160814 02:41:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160814 02:42:09< tad_> Checking [option] value= per your suggestion for [message] PR I have up.
20160814 02:42:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160814 02:42:33< celmin> I seem to recall not responding to your response on that.
20160814 02:42:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160814 02:43:38< tad_> That's OK. I'm trying to add it. Decided it's not a bad suggestion for the use case where you just want to set values non-numeric for each option.
20160814 02:44:12< tad_> Grr. pure virtual method called terminate called without an active exception Aborted (core dumped)
20160814 02:44:25< tad_> I suppose I need to sync and make to be sure it's a real error.
20160814 02:44:47< celmin> It's pretty rare for a pure virtual method to be called.
20160814 02:45:29< celmin> Probably the only way to do it is by bypassing virtual dispatch.
20160814 02:45:38< celmin> (ie, the object.ClassName::function() syntax)
20160814 02:46:16< tad_> It's been a long time since I C++'d but I remember hitting a pure virtual too work.
20160814 02:46:29< celmin> Huh?
20160814 02:47:37< tad_> I'm probably remembering wrong or crossing languages up in my memory.
20160814 02:48:08< celmin> I wasn't quite sure what you said.
20160814 02:48:31< tad_> Anyway. Once again a change to one or two files is causing a make to build a lot of targets and link is gonna fail because Chrome is a pig and I run without swap.
20160814 02:48:42< celmin> Weird.
20160814 02:48:49< celmin> And why would you run without swap?
20160814 02:49:18< tad_> It's a VM .. and I have 8G physical ram so it seemed unneeded.
20160814 02:49:44< tad_> Except for linking wesnoth with Chrome running.
20160814 02:50:15-!- Bonobo [~Bonobo@2001:44b8:254:3200:8c9b:2fb9:235a:865c] has quit [Ping timeout: 264 seconds]
20160814 02:50:47-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160814 02:52:53< tad_> Actually I use the lag-and-crash to tell when the make is done. Browse google news and reddit until it lags to a halt, when it un-lags, quit chrome, make to link and I'm off and running.
20160814 02:53:06< celmin> Pffft...
20160814 02:56:01< tad_> Isn't a 'pure virtual function' a virtual function which has no implementation? It's been about 15 or 20 years since I did any C++ so I'm very rusty :P
20160814 02:57:22< celmin> Not quite.
20160814 02:57:30< celmin> In practice it usually doesn't have an implementation, yes.
20160814 02:57:39< celmin> But it's possible to implement a pure virtual function.
20160814 02:58:06< celmin> (I don't think I've ever found the need to do so.)
20160814 02:58:25-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160814 03:01:01< celticminstrel> I guess it's not a bad way to think of it though.
20160814 03:01:11< celticminstrel> It's also a function that must be overridden.
20160814 03:01:22< celticminstrel> Otherwise the containing class is considered abstract.
20160814 03:01:30< tad_> right. I remember that now
20160814 03:01:48< tad_> so to call it you have to do some casting which is probably a bad idea
20160814 03:02:06< celticminstrel> I don't think you need to do any casting.
20160814 03:02:11< tad_> Like up-casting from a base to a child class.
20160814 03:02:16< celticminstrel> In fact, I'm pretty sure casing would not make it possible.
20160814 03:02:48< celticminstrel> Even if you cast it to the base class, it still goes through virtual dispatch. To call it, you would need to bypass virtual dispatch.
20160814 03:04:24< tad_> I like C. You say "Shoot my foot, please" and it says "Right away, sir!" but C++ says "Do you mean right or left foot?" then you pick one and it fires.
20160814 03:04:25< celticminstrel> One way you might accidentally do that is if the method is the sort of method where overridden versions of it defer partially or wholly to the superclass version.
20160814 03:05:01< celticminstrel> If you're calling a virtual method, and there are double colons, beware.
20160814 03:05:29< celticminstrel> I doubt anyone would do it by accident from an external function.
20160814 03:06:37< tad_> Most likely it's a mismatch which caused the issue here. Y'all been working a lot on .cfg files for the UI and I probably have a newer .cfg and outdated engine.
20160814 03:07:13< celticminstrel> Not sure how that could happen...
20160814 03:07:26< tad_> Easy, sync master and not make./
20160814 03:07:38< celticminstrel> Oh. Good point.
20160814 03:08:07< celticminstrel> I don't suppose the error gave any clue about exactly which pure virtual method was called? Like a stack trace or something.
20160814 03:08:28< tad_> Well, it dumped core so sure, I could get one. But what'
20160814 03:08:41< tad_> what's the point .. make will almost certainly fix it.
20160814 03:09:10< celticminstrel> Maybe.
20160814 03:09:17< celticminstrel> (About the lack of a point)
20160814 03:10:30< tad_> If not, then I'll grab a stack trace from the core file.
20160814 03:22:24-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160814 03:33:04< Espreon> celticminstrel: OK, yeah. It compiles. Let's hope nothing explodes.
20160814 03:45:32-!- Kwandulin [~Miranda@p200300760F35BFDD5CBB3324979580BA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160814 03:49:29-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 03:51:00-!- RatArmy [~RatArmy@om126229084035.12.openmobile.ne.jp] has joined #wesnoth-dev
20160814 03:51:03-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160814 03:52:41-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 03:53:09< tad_> (bbb547d-Clean) --> pure virtual method called terminate called without an active exception Aborted (core dumped)
20160814 03:53:22< tad_> OK. Now I gotta get that stack trace
20160814 03:57:13< tad_> in events::pump () at /home/lundberg/wesnoth/src/events.cpp:55
20160814 03:57:57< tad_> grr .. line 550
20160814 03:59:16< tad_> We just has a commit dealing with events for the ';' problem. Maybe I should reverse it and see if the issue clears.
20160814 03:59:22-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160814 04:00:12-!- travis-ci [~travis-ci@ec2-54-80-253-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 04:00:13< travis-ci> wesnoth/wesnoth#10387 (master - 176f962 : Charles Dang): The build is still failing.
20160814 04:00:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152138894
20160814 04:00:13-!- travis-ci [~travis-ci@ec2-54-80-253-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 04:05:32-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 04:11:13< Espreon> Trying to launch the editor segfaults
20160814 04:11:25< Espreon> https://pastebin.com/U5peseuc
20160814 04:11:36-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160814 04:11:43< Espreon> Gah
20160814 04:13:23-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160814 04:17:02-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 04:23:12< vultraz> confirmed
20160814 04:24:50< tad_> I'm getting a sigabt on a pure virtual function called in the game engine. I'm working on the theory it came from the ';' fix merged a while ago and trying a revert on that commit.
20160814 04:26:58-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160814 04:29:14-!- oldlaptop [~quassel@50.36.241.195] has quit [Ping timeout: 250 seconds]
20160814 04:35:46-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160814 04:36:56< tad_> Checked my logs from earlier today. Was working at commit 3cc2d09. Not a lot of choices since then for the culprit.
20160814 04:37:13-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160814 04:39:39-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160814 04:40:38-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 04:44:08< irker978> wesnoth: Espreon wesnoth:master 66134e040014 / / (122 files in 6 dirs): Replaced remnant instances of "don't" with "do not" https://github.com/wesnoth/wesnoth/commit/66134e040014fd8cb457d246ac3761ccb6bd3a52
20160814 04:44:10< irker978> wesnoth: Espreon wesnoth:master 8b87a29b1803 / / (60 files in 2 dirs): Ran pofix on LoW https://github.com/wesnoth/wesnoth/commit/8b87a29b18038bc5b75b87f70cbd3855189cbe2d
20160814 04:52:03-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160814 04:53:14-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 04:53:36-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160814 04:54:08< tad_> Confirmed f621d7f caused sigabrt on calling a pure virtual function. PR is up to revert it.
20160814 05:03:43-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 05:03:44< travis-ci> wesnoth/wesnoth#10388 (master - 8b87a29 : Espreon): The build is still failing.
20160814 05:03:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152148027
20160814 05:03:44-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 05:26:30-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 05:39:05-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 05:39:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 05:53:28< vultraz> tad_: probably don't need a revert, just need to wait for the fix
20160814 05:55:38< Espreon> Here a segfault, there a segfault, everywhere a segfault...
20160814 05:55:56< vultraz> Espreon: I see you've been busy purging contractions.
20160814 05:56:26< Espreon> Yeah, like three instances thereof.
20160814 05:56:31< Espreon> So, not really busy...
20160814 05:56:45-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160814 05:56:48< tad_> Well I put the stacktrace in the PR. As it is, I either need the revert or to roll back before the commit to be able to run the engine.
20160814 05:57:54-!- RatArmy [~RatArmy@om126229084035.12.openmobile.ne.jp] has quit [Ping timeout: 276 seconds]
20160814 05:58:14< Espreon> And I still have to do all this crap for teh Catalan translation...
20160814 05:58:18 * Espreon is lazy as fuck
20160814 05:58:53< Espreon> (And I actually reverted some of the work I recently did by accident... yay...)
20160814 06:01:45-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 06:01:51< Espreon> Yeah, the latest one I ran into happens when I attempt to switch add-on views in the add-ons manager: https://pastebin.com/gJwHP3kN
20160814 06:02:18< Espreon> Python exception...
20160814 06:02:20< Espreon> ... wut?
20160814 06:02:36< Espreon> I guess that has to do with gdb
20160814 06:07:31-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 06:11:04< Espreon> And "dwarfs" was introduced
20160814 06:11:05< Espreon> Lovely
20160814 06:19:19< vultraz> what's wrong with dwarfs?
20160814 06:20:00< tad_> Choose one dwarves or dwarfs but don't use both?
20160814 06:20:22< vultraz> tad_: btw, you sure you don't want commit access after your many campaign patches?
20160814 06:20:33< Espreon> vultraz: What tad said.
20160814 06:20:44< vultraz> Espreon: which is more... American 
20160814 06:20:48< tad_> Nah. I'd make too many errors.
20160814 06:21:04< Espreon> vultraz: ...
20160814 06:21:08< Espreon> Neither.
20160814 06:21:13< tad_> I don't know there is a 'more american' but I prefer dwarves.
20160814 06:21:26< vultraz> ok, if neither is more american, stick with whatever we used before
20160814 06:21:27< Espreon> Ditto.
20160814 06:21:39 * Espreon rolls his eyes
20160814 06:22:01< irker978> wesnoth: Espreon wesnoth:master e5888160d011 / data/core/terrain.cfg: No more 'dwarfs'! https://github.com/wesnoth/wesnoth/commit/e5888160d01153f759ffacb57bcd6c21559ce774
20160814 06:22:36< vultraz> ah, that was fabi's work
20160814 06:24:18< Espreon> It should be noted that "dwarves" is an invention, but since it is one of Tolkien's or at least used by him and since we follow that tradition... yeah.
20160814 06:24:24< Espreon> *...
20160814 06:25:00< vultraz> It should also be noted that excessive use of ellipses is Espreon's invention
20160814 06:26:28< Espreon> Well, some people believe that just because it's irregular it must have a longer tradition or be ancient or whatever.
20160814 06:26:33< Espreon> Now, enough!
20160814 06:31:44< tad_> Well, grep says that was the only use of 'dwarfs' other than a single comment in northern rebirth 05a_01_The_Pursuit
20160814 06:31:52< Espreon> Right.
20160814 06:31:57< Espreon> Hmm, how to say "Morogor"?
20160814 06:32:21< Espreon> Mo-RO-gor?
20160814 06:34:06< vultraz> i assume so
20160814 06:34:28< tad_> City of Morogoro is mo-rogo-ro
20160814 06:35:18< Espreon> Right, but I need to know where to put the stress.
20160814 06:35:29< Espreon> I guess I'll have it be Morògor
20160814 06:35:55< Espreon> ... causing lots of Catalans to think of a place called "moo-RAW-goo"
20160814 06:36:17< tad_> In my head it comes out moro-GOR but dunno if that means anything
20160814 06:36:32< Espreon> Hmm.
20160814 06:36:34< tad_> I usually misread it as mordor anyway
20160814 06:36:59< Espreon> That would be written "Morogor", but I think the final accent would be weird in Catalan, as would initial accent
20160814 06:37:39< Espreon> So, then the question is: Morógor or Morògor? Guess I'll have to ask jordà.
20160814 06:38:04< tad_> huh. dwarves was not an invention? Tolkien said it was a typo
20160814 06:38:14< Espreon> The difference translates to: moo-RO-goo vs. moo-RAW-goo, in case you're curious.
20160814 06:38:37< Espreon> As one who has never actually read anything of his, I stand corrected! :D
20160814 06:39:33< Espreon> Though, out of curiosity, where did he say it was a typo?
20160814 06:41:18< tad_> I'd have to pull it back up. OED says no such word, so I'm liking it more
20160814 06:41:41-!- travis-ci [~travis-ci@ec2-54-81-199-43.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 06:41:42< travis-ci> wesnoth/wesnoth#10394 (master - e588816 : Espreon): The build is still failing.
20160814 06:41:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152154477
20160814 06:41:42-!- travis-ci [~travis-ci@ec2-54-81-199-43.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 06:41:45< Espreon> https://en.wikipedia.org/wiki/Dwarf_(mythology)#Etymology_and_usage ... Hmm, it's claimed that there was such a "minority" plural as "dwarves".
20160814 06:42:03< tad_> http://www.oed.com/search?searchType=dictionary&q=dwarfs&_searchBtn=Search
20160814 06:42:09< tad_> Wrong
20160814 06:42:35< tad_> https://jakubmarian.com/dwarves-or-dwarfs-which-spelling-is-correct/
20160814 06:42:39< tad_> Tha's better
20160814 06:43:22< Espreon> Meh, they cite roof, roofs without mentioning that roof, rooves is actually a real thing.
20160814 06:45:57< vultraz> ROOVES???
20160814 06:46:11< Espreon> Yes.
20160814 06:46:28< tad_> Odd it's not made it into OED. They have some really obscure words there cited solely because they appear in one really old English book and never used again and no dwarves .. 
20160814 06:46:42< tad_> And tolkien taught at oxford
20160814 06:47:07-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 06:47:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 265 seconds]
20160814 06:47:47-!- noy_ is now known as noy
20160814 06:47:52< Espreon> Well, if they have regular forms from weird, non-Anglian varieties of English, then that's one thing.
20160814 06:47:58< Espreon> If they don't, then meh.
20160814 06:49:50< Espreon> 1818   W. Taylor in Monthly Mag. 46 26   The history of Laurin, king of the dwarves.
20160814 06:50:57< Espreon> Whether this corresponds to anything that actually is spontaneously produced in any variety of English, who knows?
20160814 06:51:06< Espreon> I guess Wikipedia was talking about this occurence, though.
20160814 06:52:14< Espreon> The etymology section does not mention it being subject to the abstract "Middle English voicing" rule, so I assume that the answer is that it does not.
20160814 06:53:17< Espreon> Etymologically speaking, it should not be subject to that rule anyway. So, whatever.
20160814 06:54:16< tad_> OED - acang, v.: "to act foolishly, lose self-control" 1200 (St. Katherine manuscript) “Hu nu, dame, dotestu? Cwen, acangestu nu mid alle þes oðre?”
20160814 06:54:43< tad_> And the quote is "english" 
20160814 06:54:47< tad_> ?
20160814 06:54:54< Espreon> Looks like someone got a good dose of Early Middle English.
20160814 06:55:15< Espreon> ... very Early Middle English...
20160814 06:55:40-!- mjs-de [~mjs-de@x4db5911b.dyn.telefonica.de] has joined #wesnoth-dev
20160814 06:57:19< Espreon> At least the OED mentions good ol' "rooves"
20160814 06:57:39< Espreon> (though, too bad it is but a mere import in my speech)
20160814 06:58:14< Espreon> (Though, I can say that I naturally say hou[z]es, with two Z sounds... anything else sounds unnaturally aberrant to me...)
20160814 06:59:35< tad_> Well, I'm slowly loosing the ability to speak proper English since I moved to Louisiana. I call it a 'ditch' and they say, no, it's "coulee". I guess french is close enough to english.
20160814 06:59:51< Espreon> Oh yes, definitely...
20160814 07:01:08< tad_> That came up today with all the rain. I said "The water hasn't filled the ditch." and got jumped on because it's a "coulee" and I better learn
20160814 07:01:16-!- mjs-de [~mjs-de@x4db5911b.dyn.telefonica.de] has quit [Remote host closed the connection]
20160814 07:01:49-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 07:02:06< Espreon> Yeah, you better...
20160814 07:02:15 * Espreon rolls his eyes
20160814 07:04:20< Espreon> http://www.merriam-webster.com/dictionary/roof ... also ˈrüvz, ˈru̇vz\
20160814 07:04:29< Espreon> Yet the spelling "rooves" isn't offered.
20160814 07:04:30< Espreon> Well...
20160814 07:04:33< Espreon> pffft.
20160814 07:04:34-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160814 07:05:01< vultraz> praise le dynamic_cast
20160814 07:05:22< tad_> *sigh* I suppose I'm going to have to break down and set up a swap partition one of these days if I'm going to keep compiling wesnoth so often.
20160814 07:05:24< Espreon> I guess this gives us license to call that one Canadian hockey team the "Maple Leaves" (just in speech...)
20160814 07:06:48< Espreon> Well, I must be going now.
20160814 07:06:53< Espreon> Good night, everyone!
20160814 07:08:49< tad_> You asked about commit rights to master, what I told wedge009 was I think too many have it already, and more stuff should go through PRs for review.
20160814 07:09:05< tad_> So I'm going to refuse up until you all gang up on me and insist.
20160814 07:09:11< vultraz> heh
20160814 07:09:19< vultraz> about 50 people have commit access, yes
20160814 07:09:24< vultraz> but a fraction are active
20160814 07:09:42< vultraz> and even people who DO have commit access will PR major changes
20160814 07:09:51< vultraz> so we can review
20160814 07:09:52< tad_> I can see that when I check GitHub.
20160814 07:11:22< tad_> Well, only 700 or so PRs .. how long has wesnoth been on github?
20160814 07:11:46< vultraz> since around 2013 or 14.
20160814 07:14:54-!- fabi_ [~fabi@176.4.53.88] has joined #wesnoth-dev
20160814 07:15:35< tad_> Well, OI
20160814 07:15:39< tad_> I'm off, too.
20160814 07:15:47-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160814 07:16:49-!- fabi [~fabi@176.0.89.115] has quit [Read error: Connection reset by peer]
20160814 07:28:52-!- Kwandulin [~Miranda@p200300760F35BFDD5CBB3324979580BA.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160814 07:33:18-!- Kwandulin [~Miranda@p200300760F35BFFF9111758D011FB323.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160814 07:46:28-!- mjs-de [~mjs-de@x4db5911b.dyn.telefonica.de] has joined #wesnoth-dev
20160814 07:50:31-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160814 07:50:32-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160814 08:02:36-!- Kwandulin [~Miranda@p200300760F35BFFF9111758D011FB323.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160814 08:29:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160814 08:32:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160814 08:32:55-!- wedge010 is now known as wedge009
20160814 08:47:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160814 08:47:44< irker978> wesnoth: Jyrki Vesterinen wesnoth:master 927b8aa7d534 / src/events.cpp: Fixed crash caused by failing to remove an event handler https://github.com/wesnoth/wesnoth/commit/927b8aa7d53453a6533b92d87a3e8af776ba8bda
20160814 08:48:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160814 08:50:15< vultraz> :D
20160814 08:52:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160814 08:54:06-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160814 08:56:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160814 08:56:10-!- wedge010 is now known as wedge009
20160814 08:56:14< irker978> wesnoth: Jyrki Vesterinen wesnoth:master 336bcda82a80 / src/mouse_events.cpp: Fix the unit attack dialog pre-selecting a wrong attack https://github.com/wesnoth/wesnoth/commit/336bcda82a80883656acc78c12e05e83fdd902ed
20160814 09:01:21-!- Kwandulin [~Miranda@p200300760F35BFFFF9A3D25061021ED0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160814 09:06:10< wedge009> vultraz: We should gang up on tad_ and insist. :D
20160814 09:06:16< vultraz> :P
20160814 09:06:41< wedge009> I told him before just what you told him a couple of hours ago.
20160814 09:08:38-!- travis-ci [~travis-ci@ec2-54-80-253-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 09:08:39< travis-ci> wesnoth/wesnoth#10395 (master - 927b8aa : Jyrki Vesterinen): The build is still failing.
20160814 09:08:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152169340
20160814 09:08:39-!- travis-ci [~travis-ci@ec2-54-80-253-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 09:16:47-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 09:16:48< travis-ci> wesnoth/wesnoth#10396 (master - 336bcda : Jyrki Vesterinen): The build is still failing.
20160814 09:16:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152169905
20160814 09:16:48-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 09:51:15-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160814 09:55:18-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160814 10:12:00-!- DeFender1031 [~DeFender1@46-116-114-128.bb.netvision.net.il] has joined #wesnoth-dev
20160814 10:15:43< Aginor> but out of the 50 people who have access, how many actually commit?
20160814 10:16:15< vultraz> that's the point
20160814 10:16:34< Aginor> s/commit/currently contribute/
20160814 10:42:48-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160814 10:43:07< vultraz> not many
20160814 10:53:57< vultraz> blagh
20160814 10:54:10< vultraz> class member control flags
20160814 10:56:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160814 10:57:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160814 11:05:05-!- louis94 [~~louis94@91.178.242.159] has joined #wesnoth-dev
20160814 11:05:14-!- mjs-de [~mjs-de@x4db5911b.dyn.telefonica.de] has quit [Remote host closed the connection]
20160814 11:15:33< vultraz> ahh
20160814 11:15:36< vultraz> finally
20160814 11:15:44< vultraz> found the data to check
20160814 11:15:49< vultraz> instead of using flags
20160814 11:15:52< vultraz> praise be!
20160814 11:20:55 * vultraz tries to use as few control flags as possible
20160814 11:25:18-!- louis94 [~~louis94@91.178.242.159] has quit [Quit: Konversation terminated!]
20160814 11:26:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160814 11:26:40-!- louis94 [~~louis94@91.178.242.159] has joined #wesnoth-dev
20160814 11:37:52-!- louis94 [~~louis94@91.178.242.159] has quit [Ping timeout: 240 seconds]
20160814 11:45:24-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has joined #wesnoth-dev
20160814 11:46:31< gfgtdf> vultraz: i wonder why you remvoed the  marked-up_text.hpp include whehn i included it it was needed font::span_color() which is afaik still used there
20160814 11:46:43< vultraz> gfgtdf: it was already inclided
20160814 11:46:57< gfgtdf> vultraz: ah ok sry then
20160814 11:53:18-!- oldlaptop [~quassel@50-37-41-79.mskg.mi.frontiernet.net] has joined #wesnoth-dev
20160814 11:53:21-!- atomicbomb [~atomicbom@36.84.64.61] has joined #wesnoth-dev
20160814 11:54:17-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160814 11:54:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160814 11:57:30< vultraz> atomicbomb? o_O
20160814 11:57:42< atomicbomb> Woo
20160814 11:57:43< atomicbomb> Hi
20160814 11:57:46< vultraz> you return
20160814 11:57:49< atomicbomb> Yes
20160814 11:59:51-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has joined #wesnoth-dev
20160814 12:05:54-!- irker978 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160814 12:49:40-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has quit [Ping timeout: 250 seconds]
20160814 12:57:28-!- Kwandulin [~Miranda@p200300760F35BFFFF9A3D25061021ED0.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160814 13:06:10-!- louis94 [~~louis94@91.178.242.159] has joined #wesnoth-dev
20160814 13:08:30-!- irker038 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160814 13:08:31< irker038> wesnoth: Charles Dang wesnoth:master 05340bb81f66 / / (4 files in 3 dirs): timage: allowed use of width/height keys for specific image size https://github.com/wesnoth/wesnoth/commit/05340bb81f661806fb6cc853be292738fabda1fe
20160814 13:08:50< vultraz> dunno if that's a better alternative to just feeding an image with ~SCALE
20160814 13:11:34-!- louis94 [~~louis94@91.178.242.159] has quit [Quit: Konversation terminated!]
20160814 13:28:22-!- travis-ci [~travis-ci@ec2-54-80-253-247.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 13:28:23< travis-ci> wesnoth/wesnoth#10397 (master - 05340bb : Charles Dang): The build is still failing.
20160814 13:28:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152197400
20160814 13:28:23-!- travis-ci [~travis-ci@ec2-54-80-253-247.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 13:32:54-!- JyrkiVesterinen [~JyrkiVest@87-100-160-253.bb.dnainternet.fi] has joined #wesnoth-dev
20160814 13:45:46-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160814 13:50:39< irker038> wesnoth: gfgtdf wesnoth:master 16f5980a3cb2 / src/ (13 files in 4 dirs): config::all_children_range(), attribute_range() now return iterator_range https://github.com/wesnoth/wesnoth/commit/16f5980a3cb201c90a770c228d09da610d8e1872
20160814 13:54:52< vultraz> hmm
20160814 13:55:02-!- Kwandulin [~Miranda@p200300760F35BFFF4C1CAF24705E639B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160814 13:55:18< vultraz> am looking for way to stop listboxes resizing if you replace their content..
20160814 14:00:11-!- atomicbomb [~atomicbom@36.84.64.61] has quit [Quit: Leaving]
20160814 14:11:45-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 14:11:46< travis-ci> wesnoth/wesnoth#10398 (master - 16f5980 : gfgtdf): The build is still failing.
20160814 14:11:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152203521
20160814 14:11:46-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 14:23:53< irker038> wesnoth: gfgtdf wesnoth:master cf16c6c787a5 / src/ (display.cpp scripting/game_lua_kernel.cpp): fixup 16f5980a3cb20 'config...  ...now return return iterator_range.' https://github.com/wesnoth/wesnoth/commit/cf16c6c787a52fc3fed8aea24cf9f1a88f3bab7a
20160814 14:24:37-!- oldlaptop [~quassel@50-37-41-79.mskg.mi.frontiernet.net] has quit [Ping timeout: 250 seconds]
20160814 14:25:58-!- molt [~molt@dynamic-213-198-235-143.adsl.eunet.rs] has quit [Quit: Leaving]
20160814 14:39:53-!- Shiki [~Shiki@HSI-KBW-149-172-220-18.hsi13.kabel-badenwuerttemberg.de] has joined #wesnoth-dev
20160814 14:55:59-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160814 15:12:14-!- Shiki [~Shiki@HSI-KBW-149-172-220-18.hsi13.kabel-badenwuerttemberg.de] has quit [Remote host closed the connection]
20160814 15:16:32-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 15:17:59-!- travis-ci [~travis-ci@ec2-54-205-94-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 15:18:00< travis-ci> wesnoth/wesnoth#10399 (master - cf16c6c : gfgtdf): The build has errored.
20160814 15:18:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152208084
20160814 15:18:00-!- travis-ci [~travis-ci@ec2-54-205-94-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 15:18:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 244 seconds]
20160814 15:18:39-!- noy_ is now known as noy
20160814 15:25:24-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160814 15:32:17< irker038> wesnoth: Charles Dang wesnoth:master 2c6b4b9ee994 / data/gui/widget/combobox_default.cfg: Gray out borders of a disabled combobox https://github.com/wesnoth/wesnoth/commit/2c6b4b9ee994bf1478486c4e9145c2b864394b97
20160814 15:32:20< irker038> wesnoth: Charles Dang wesnoth:master 338fd6e00ccd / / (3 files in 2 dirs): Mp Create: further progress https://github.com/wesnoth/wesnoth/commit/338fd6e00ccde1b684a902269d358201a97cfa61
20160814 15:38:52-!- Kwandulin [~Miranda@p200300760F35BFFF4C1CAF24705E639B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160814 15:39:47< vultraz> coming along, coming along..
20160814 15:54:23-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20160814 16:29:17-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160814 16:33:20-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160814 16:45:09-!- ancestral [~ancestral@67-4-224-82.mpls.qwest.net] has joined #wesnoth-dev
20160814 16:45:53-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160814 16:51:36-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160814 16:51:50-!- travis-ci [~travis-ci@ec2-54-205-94-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 16:51:51< travis-ci> wesnoth/wesnoth#10400 (master - 338fd6e : Charles Dang): The build has errored.
20160814 16:51:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152216623
20160814 16:51:51-!- travis-ci [~travis-ci@ec2-54-205-94-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 17:11:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 260 seconds]
20160814 17:16:12< irker038> wesnoth: Gregory A Lundberg wesnoth:master f0ad54000141 / changelog data/lua/wml/message.lua: Add result variable to [message] tag https://github.com/wesnoth/wesnoth/commit/f0ad5400014167ac6f8b8bc441431f01ccf2c615
20160814 17:16:14< irker038> wesnoth: Celtic Minstrel wesnoth:master 413a4caa7f81 / changelog data/lua/wml/message.lua: Merge pull request #747 from GregoryLundberg/GL_message_option_variable https://github.com/wesnoth/wesnoth/commit/413a4caa7f811ec9727f3bb735e799a4e3fda168
20160814 17:22:49< celmin> "timage"… sounds like some weird sort of timer.
20160814 17:27:05< zookeeper> sounds like a synonym for "timing"
20160814 17:27:21< celmin> Yeah. But it actually represents an image widget.
20160814 17:29:21< celmin> Macro naming conventions in GUI2 are ridiculous.
20160814 17:29:49< celmin> All those leading underscores for no reason, and the GUI prefix even though (as far as I know) GUI2 WML is read in a separate context so the names will never conflict with UMC.
20160814 17:33:10< aeth> that's one advantage of some of the newer programming languages... very opinionated naming conventions
20160814 17:33:29< celmin> That's not an advantage.
20160814 17:33:50< aeth> well, it's better than names that follow the fortran tradition of using one character length
20160814 17:34:02< celmin> Marginally.
20160814 17:34:08< aeth> or hungarian notation or something...
20160814 17:35:01< aeth> The best coding standard I think for one character variable names is that it should be very limited in scope (basically just loops) or directly from the math equation if it's math... I *think* parts of Wesnoth violate this
20160814 17:35:17< celmin> They do.
20160814 17:35:25< celmin> i is often used for iterator variables.
20160814 17:35:32< celmin> u is often used for unit variables.
20160814 17:35:37< aeth> even names like "cfg" are quite cryptic if you're not used to the Wesnoth codebase
20160814 17:35:45< aeth> celmin: i/j passes the rule
20160814 17:35:48< aeth> u does not
20160814 17:35:55< celmin> I disagree.
20160814 17:36:10< celmin> i should be an index variable, not an iterator.
20160814 17:36:17< aeth> oh, iterator, I read that wrong
20160814 17:36:19< aeth> you're right
20160814 17:36:30< aeth> too many languages have too many different names for things
20160814 17:36:59< aeth> I got burned yet again by a Lua-uses-1-index bug yesterday that ate up about an hour to debug... Lua will helpfully return nil for [0] if you treat it like a normal language
20160814 17:37:03< celmin> Well, iterator isn't really one of them...
20160814 17:37:30< celmin> Lua iterators still confuse me actually.
20160814 17:38:05-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20160814 17:39:10< aeth> Another issue I have with Lua is that Lua's like Scheme... it favors minimalism a bit too much for idealistic reasons, which does cause some issues.
20160814 17:39:13< celmin> So, does anyone know how to tell CMake to include additional source files when running on Mac?
20160814 17:52:06-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160814 18:10:24-!- travis-ci [~travis-ci@ec2-54-205-94-118.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 18:10:25< travis-ci> wesnoth/wesnoth#10401 (master - 413a4ca : Celtic Minstrel): The build has errored.
20160814 18:10:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152230188
20160814 18:10:25-!- travis-ci [~travis-ci@ec2-54-205-94-118.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 18:46:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160814 18:46:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160814 18:49:33-!- wsnevol [~lovens@modemcable018.107-57-74.mc.videotron.ca] has joined #wesnoth-dev
20160814 18:57:10-!- wsnevol [~lovens@modemcable018.107-57-74.mc.videotron.ca] has quit [Quit: Leaving]
20160814 19:01:23-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160814 19:02:44-!- oldlaptop [~quassel@50.36.231.26] has joined #wesnoth-dev
20160814 19:13:34-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160814 19:24:27-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has joined #wesnoth-dev
20160814 19:35:29-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160814 19:39:55-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160814 19:55:04-!- mjs-de [~mjs-de@x4db68913.dyn.telefonica.de] has joined #wesnoth-dev
20160814 20:00:01-!- JyrkiVesterinen [~JyrkiVest@87-100-160-253.bb.dnainternet.fi] has quit [Quit: .]
20160814 20:11:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160814 20:16:34-!- irker038 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160814 20:24:25-!- travis-ci [~travis-ci@ec2-54-81-199-43.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 20:24:26< travis-ci> gfgtdf/wesnoth-old#680 (master - e0bec39 : gfgtdf): The build has errored.
20160814 20:24:26< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/152247266
20160814 20:24:26-!- travis-ci [~travis-ci@ec2-54-81-199-43.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 20:55:47-!- mjs-de [~mjs-de@x4db68913.dyn.telefonica.de] has quit [Remote host closed the connection]
20160814 21:05:46-!- gfgtdf [~chatzilla@x4e36ad0f.dyn.telefonica.de] has joined #wesnoth-dev
20160814 21:06:44< gfgtdf> accorign to https://github.com/wesnoth/wesnoth/blob/master/INSTALL#L22 boost 1.48 i needed to build wesnoth any opinions aginst removing all pre-boost-1.48 workarounds ?
20160814 21:11:28-!- daMarc [5439acb4@gateway/web/freenode/ip.84.57.172.180] has joined #wesnoth-dev
20160814 21:14:48-!- daMarc [5439acb4@gateway/web/freenode/ip.84.57.172.180] has left #wesnoth-dev []
20160814 21:15:21-!- irker658 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160814 21:15:21< irker658> wesnoth: gfgtdf wesnoth:master 8741d38c5544 / src/campaign_server/campaign_server.cpp: fix campaign server https://github.com/wesnoth/wesnoth/commit/8741d38c554488eca217eaee369a7d2b8213906b
20160814 21:15:21< irker658> wesnoth: gfgtdf wesnoth:master 7434533b4653 / src/ (commandline_options.cpp filesystem_boost.cpp network_asio.cpp seed_rng.cpp): remove all pre boost 1.48 workarounds https://github.com/wesnoth/wesnoth/commit/7434533b4653defc082e262ab3459a18dcc9f898
20160814 21:21:31< celmin> Speaking of the campaign server, when is the asio upgrade going to be merged?
20160814 21:22:38< vultraz> dunno
20160814 21:22:56 * vultraz ponders removing gui2::tpoint
20160814 21:23:03< celmin> Why?
20160814 21:23:16< vultraz> it seems it'd be better as a typdef for a pair
20160814 21:23:39< celmin> No, no, points are not pairs.
20160814 21:23:47< celmin> Pairs have first and second. Points have x and y.
20160814 21:23:58< celmin> Don't replace structs with tuples.
20160814 21:24:19 * vultraz rubs eyes
20160814 21:24:27 * vultraz has literally *just* woken up
20160814 21:24:32 * vultraz rereads line
20160814 21:24:34< vultraz> hm, yes
20160814 21:24:46< celmin> Pairs are a tuple, point is a struct. Essentially.
20160814 21:26:07< vultraz> i guess
20160814 21:26:18< vultraz> i should at least make it default-constructable 
20160814 21:26:25< celmin> What? It's not?
20160814 21:26:31< celmin> Obviously it should be default-constructible.
20160814 21:26:37< celmin> To do otherwise is incomprehensible.
20160814 21:27:22< vultraz> tpoint foo doesn't work. one needs tpoint foo = tpoint(0, 0) or {0, 0},. I guess.
20160814 21:27:42< celmin> Yeah, you should fix that.
20160814 21:28:14< celmin> If I were doing GUI2 stuff I would've fixed it the moment I found a need for it.
20160814 21:28:49< vultraz> question, tho
20160814 21:29:06< vultraz> since I don't really understand this
20160814 21:30:02< vultraz> for, say, strings, one can do this: if str == "". But in tpoint, the == operator takes another tpoint, meaning I see uses like this: if(foo == tpoint(0,0))
20160814 21:30:10< vultraz> but that doesn't seem right
20160814 21:30:32< vultraz> so the question is, what is it about string that one can do ""
20160814 21:31:21< celmin> That's sort of hard to answer.
20160814 21:31:24< gfgtdf> vultraz: you can just add a method bool isnull() if you want
20160814 21:31:32< celmin> gfgtdf: What, no.
20160814 21:31:52< celmin> The point (0,0) isn't so special as to be called "null".
20160814 21:32:03< gfgtdf> celmin: then call si differnet
20160814 21:32:16< celmin> Huh?
20160814 21:32:17< gfgtdf> celmin: is_origin() for example
20160814 21:32:30< celmin> No, I think == is better.
20160814 21:33:05< celmin> So, when the compiler sees something like "a == b", it converts that into a function call, "operator==(a, b)" and uses regular overload mechanisms to resolve it.
20160814 21:33:29< celmin> If you write 'str == ""', that becomes 'operator==(str, "")', and a temporary string is constructed from "".
20160814 21:33:45< gfgtdf> celmin: so how is that an arguemnt against adding such a method ?
20160814 21:33:51< celmin> If you write "point == {0,0}", that becomes operator==(point, {0,0})
20160814 21:33:58< celmin> And a temporary tpoint is constructed.
20160814 21:34:22< gfgtdf> celmin: actuall tis is an agrument against using == "" and using .empty() instead, creating a teporary string migth be slow.
20160814 21:34:36-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160814 21:35:01< celmin> gfgtdf: Sorry, I can't figure out how to explain it, but I feel that adding is_origin or whatever to tpoint is just filling it with useless clutter.
20160814 21:35:11< celmin> gfgtdf: And yeah, that is indeed an argument against using str == ""
20160814 21:35:25< celmin> Constructing a temporary string could be slow.
20160814 21:35:34< celmin> That shouldn't apply with tpoint, though.
20160814 21:35:49< celmin> Still, if you were worried you could instead do "foo.x == 0 && foo.y == 0".
20160814 21:37:00< gfgtdf> celmin: im quite sure that every compiler s god enough to omit the same assmely code in == {0,0}, is_orirgin() and x ==0 && y == 0
20160814 21:37:18< gfgtdf> celmin: that is assuming that operatoir == is given inline in teh header
20160814 21:37:38< celmin> gfgtdf: Pretty sure it assumes no such thing.
20160814 21:38:06< celmin> But, if the compiler is good enough to emit the same code, then you should choose the one that looks best, and in my opinion that's ==
20160814 21:38:40< gfgtdf> celmin: i mena the statmenet aboeve is wirrten wit the assumption that operator == is defeined in te headr file.
20160814 21:40:02< celmin> I suppose I can see why it might need to assume that… though a good linker could probably inline things too...
20160814 21:42:33< gfgtdf> celmin: at least on my ide i have 'link-time-inlining' deactivated for normal builds since it incresases the wesnoth buidl time by >10 mins even if i just change one cpp file
20160814 21:42:50< celmin> For debug builds, sure.
20160814 21:43:08< celmin> But if you were building a release package, you'd probably want the best optimization enabled.
20160814 21:43:39< celmin> …which reminds me, I was wondering if ancestral actually builds a release build or if he just uses the default debug build.
20160814 21:43:56< ancestral> I do a release build
20160814 21:44:00-!- Appleman1234 [~Appleman1@KD036012012154.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20160814 21:44:15< ancestral> Probably is a little leaner as it strips some things out I assume
20160814 21:44:26< celmin> So you have an extra scheme or something that's not committed?
20160814 21:44:34< celmin> Or temporarily edit the scheme?
20160814 21:44:44< celmin> …oh right, the only scheme currently committed is the unit tests one anyway.
20160814 21:44:53< celmin> Since it seems to require some environment variable.
20160814 21:45:03< celmin> ^+s
20160814 21:45:23< celmin> Probably better that way since I have a bunch of temporary edits to my scheme.
20160814 21:46:11< vultraz> hm
20160814 21:47:04< vultraz> I assume even if you have a default-constructable object, one must still provide a default argument for a function argument of that type if you want to not have to specify it?
20160814 21:48:09 * vultraz is also trying to decide whether to use 'return tpoint()' or 'return {0,0}'
20160814 21:48:33< gfgtdf> vultraz: i think the seonc is clearer
20160814 21:48:40< gfgtdf> second*
20160814 21:48:57< gfgtdf> vultraz: well you add a parameterless construcotr and then set the x and y in the initilizer list to 0
20160814 21:49:00< celmin> I don't get what you're asking.
20160814 21:52:42< vultraz> celmin: tcontrol has this function: tpoint get_best_text_size(const tpoint& minimum_size, const tpoint& maximum_size = tpoint(0, 0)) const; As you can see, the default argument value for the second argument is the same as the default value for tpoint
20160814 21:54:21< ancestral> celmin: Yeah I go into the scheme and change the targets from debug to release
20160814 21:54:26< ancestral> Something like that
20160814 21:54:26< celmin> Yeah, you still need to specify it like that (or as {0,0}).
20160814 21:54:27< vultraz> my question is whether one now has to still use const tpoint& maximum_size = tpoint()
20160814 21:54:45< celmin> Oh right, you could also write tpoin()
20160814 21:54:47< celmin> ^+t
20160814 21:55:22< celmin> You should never, ever write "const tpoint& maximum_size = tpoint()".
20160814 22:00:40-!- Appleman1234 [~Appleman1@KD036012022057.au-net.ne.jp] has joined #wesnoth-dev
20160814 22:09:27-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20160814 22:09:28< travis-ci> wesnoth/wesnoth#10402 (master - 7434533 : gfgtdf): The build has errored.
20160814 22:09:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/152262952
20160814 22:09:28-!- travis-ci [~travis-ci@ec2-54-146-12-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20160814 22:09:49 * celmin pokes vultraz to ensure he notices preceding statement.
20160814 22:12:18< vultraz> yea
20160814 22:12:20< vultraz> brb car problems
20160814 22:19:29 * Aginor can just about imagine vultraz shouting at people to stop stealing his car
20160814 22:34:15-!- Bonobo [~Bonobo@2001:44b8:254:3200:14d2:cac6:2190:470c] has joined #wesnoth-dev
20160814 22:41:31< vultraz> lmao xD
20160814 22:41:32< vultraz> nah
20160814 22:41:34< vultraz> it wouldn't start
20160814 22:44:24< pydsigner> So someone else is driving it?
20160814 22:44:53< vultraz> no, im back now
20160814 22:49:30 * Aginor is now imagining vultraz sorting out his car to get it to start so that it can sit outside the house, idling
20160814 22:49:48 * vultraz facedesks
20160814 22:50:00< Aginor> trolling away, contributing to global warming
20160814 22:50:04-!- un214 [~un214@104.220.56.173] has joined #wesnoth-dev
20160814 22:50:13< celmin> So you don't need to ask why you shouldn't write that?
20160814 22:50:57< vultraz> who should you never write that?
20160814 22:52:09< celmin> Because it's a reference to a temporary, which is fine if you're dealing with some sort of complex object, but totally pointless for a default-constructed tpoint.
20160814 23:07:35< vultraz> yay for -Wnarrowing :|
20160814 23:07:57< celmin> Why yay?
20160814 23:08:29< vultraz> it's sarcasm
20160814 23:09:06< celmin> Okay, so why?
20160814 23:10:22< vultraz> because now i have to fix these errors
20160814 23:11:25< celmin> Are they errors?
20160814 23:11:35< vultraz> warnings
20160814 23:11:44< celmin> So, are they errors?
20160814 23:12:03< vultraz> warnings
20160814 23:12:06< vultraz> :|
20160814 23:12:19< vultraz> what does this even mean
20160814 23:12:21< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\widgets\image.cpp|187|warning: narrowing conversion of '(unsigned int)w' from 'unsigned int' to 'int' inside { } [-Wnarrowing]|
20160814 23:12:23< celmin> That's why I'm asking if they're errors.
20160814 23:12:51< celmin> You could fix that by writing {0u,0u} instead of {0,0}
20160814 23:13:20< celmin> That's only if you have literals, of course.
20160814 23:13:33< vultraz> they're not
20160814 23:13:40< celmin> Well, you didn't show the code.
20160814 23:13:46 * vultraz will push this to his fork first
20160814 23:14:06< vultraz> hm, scratch that
20160814 23:14:12< vultraz> totally broke something
20160814 23:16:39< vultraz> i guess by trying if point = 0,0
20160814 23:17:23< vultraz> gah, Wnarrowing is back
20160814 23:18:13-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 265 seconds]
20160814 23:20:29< vultraz> celmin: code https://github.com/Vultraz/wesnoth/commit/c982878af0f7d1965c78b294862ea746048e241f
20160814 23:20:34< vultraz> still trying to find what's breaking
20160814 23:20:36< vultraz> but you can browse
20160814 23:21:45< vultraz> ignore the excess changes to tcontrol, I'll get rid of those in the final commit
20160814 23:21:51< gfgtdf> vultraz: 'tpoint(const int x_ = 0, const int y_ = 0) ' you shoudlnt do this.
20160814 23:21:58< vultraz> hm?
20160814 23:22:04< gfgtdf> vultraz: instead have a seocnd construcot that just takes no arguemnts
20160814 23:22:10< vultraz> oh
20160814 23:22:26< celmin> I accidentally did a reset --hard instead of checkout again.
20160814 23:22:27< gfgtdf> vultraz: you code also allows you to onyl specify one parmaeter which is kinda silly.
20160814 23:22:37< Aginor> celmin: how? :D
20160814 23:22:48< celmin> Makes me really glad I've been using git add -p lately instead of a GUI.
20160814 23:22:57< celmin> Aginor: Good question.
20160814 23:24:28-!- un214 [~un214@104.220.56.173] has quit [Remote host closed the connection]
20160814 23:25:50< gfgtdf> vultraz: even worse, your code mostlilley allows code like 'tpoint a = 5;'
20160814 23:26:26-!- oldlaptop [~quassel@50.36.231.26] has quit [Ping timeout: 258 seconds]
20160814 23:31:48< vultraz> ok, now it doesn't like the 0,0 stuff
20160814 23:31:50< vultraz> good
20160814 23:32:14< vultraz> i guess I'll do foo == tpoint()
20160814 23:32:26< celmin> ou,ou
20160814 23:32:30< celmin> I mean, 0u,0u
20160814 23:32:50< celmin> Or you could define a constructor taking ints instead of unsigned ints, I suppose...
20160814 23:33:19< celmin> vultraz: That's not really the right way to define the default constructor.
20160814 23:33:30< vultraz> mine or gfgtdf's way? :
20160814 23:33:34< celmin> Yours.
20160814 23:33:41< vultraz> right
20160814 23:33:52< celmin> The problem gfgtdf said can be solved by making it explicit, but that would still allow tpoint(6).
20160814 23:33:55< celmin> Which is silly.
20160814 23:34:03< vultraz> ok, so the thing is I cannot do maximum_size == {0u, 0u}
20160814 23:34:20< celmin> Better to just have a separate no-args constructor.
20160814 23:34:35< celmin> Oh, I somehow missed that it was == rather than =
20160814 23:35:18< celmin> That line in gui/dialogs/tip.cpp was pretty ridiculous even before - mouse_ is a tpoint, right? So mouse_(0,0) should've been sufficient.
20160814 23:35:52< vultraz> i always get confused by such syntax.
20160814 23:36:06< vultraz> it makes sense... but..
20160814 23:36:32< celmin> Which syntax?
20160814 23:37:10< vultraz> a foo = a(c, d)
20160814 23:37:14< celmin> vultraz: You've broken tscrollbar_container.
20160814 23:37:17< vultraz> i guess that's for constructing an object..
20160814 23:37:44< celmin> The proper syntax for constructing an object BTW is a foo(c,d)
20160814 23:37:51< vultraz> right
20160814 23:37:53< vultraz> but
20160814 23:37:54< vultraz> UGH
20160814 23:38:05< celmin> Anyway, you've broken tscrollbar_container.
20160814 23:38:08< vultraz> a lot of times I'll see something = obj(stuff)
20160814 23:38:18< vultraz> and I've always been confused as to when to use ()
20160814 23:38:20< vultraz> and when to use =
20160814 23:38:32< vultraz> i can't really explain myself better
20160814 23:38:35< celmin> Huh?
20160814 23:38:53< celmin> I don't think those are things you'd choose between?
20160814 23:39:02< celmin> Oh, I suppose when declaring an object...
20160814 23:39:04< vultraz> gahhh
20160814 23:39:09< celmin> I'd avoid = when it's not needed.
20160814 23:39:19< celmin> So anyway, you've broken tscrollbar_container.
20160814 23:39:59< vultraz> im fixing stuff
20160814 23:40:10< vultraz> i should find a syntax example of what I'm talking about
20160814 23:40:50< vultraz> ok so like
20160814 23:40:51< celmin> Actually, the brokenness in tscrollbar_container probably compiles perfectly fine due to the way you implemented the default constructor.
20160814 23:41:05< celmin> In fact, it may even "coincidentally" compile to the desired behaviour.
20160814 23:41:13< vultraz> are these the same: const std::string foo = "string"; const std::string bar("string");
20160814 23:41:15< celmin> It's still wrong, though.
20160814 23:41:32< celmin> You did it in spacer.cpp, too.
20160814 23:41:46< celmin> And tree_view.cpp
20160814 23:41:57< celmin> And tree_view_node.cpp
20160814 23:42:31< celmin> In src/gui/widgets/widget.cpp in the constructor initialization list, pick either braces or parentheses, not both.
20160814 23:42:52< celmin> (Or just use the no-args constructor.)
20160814 23:43:05< celmin> Gah, you did that stupid thing again here.
20160814 23:43:14< vultraz> I HAVE A FIXUP COMMIT COMING
20160814 23:43:20< celmin> Okay good.
20160814 23:46:32< vultraz> celmin: this seems to work https://github.com/Vultraz/wesnoth/commit/cfbed6c63ce192e5030fd741ea60b1218f37c1f8
20160814 23:47:16< vultraz> might be able to tidy it up a bit
20160814 23:48:02< vultraz> return tpoint() instead of return {0,0} and such.
20160814 23:54:19< vultraz> celmin: https://github.com/Vultraz/wesnoth/commit/6b822be5e2c031b289e6b02af1b414d502a3aa73 should i merge that with previous
20160814 23:54:36-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160814 23:54:53< celmin> Yeah sure
20160814 23:55:49 * vultraz builds final time to test
20160814 23:56:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160814 23:56:37-!- wedge010 is now known as wedge009
--- Log closed Mon Aug 15 00:00:35 2016