--- Log opened Thu Aug 18 00:00:44 2016
20160818 00:04:38< vultraz> blah
20160818 00:04:57< vultraz> can't get characters_per_line to work in scroll_labels
20160818 00:09:47< vultraz> not sure why... maybe the scrollbars override that
20160818 00:15:30< celmin> characters_per_line is terrible anyway
20160818 00:15:59< celmin> That's not the right way to decide when to wrap.
20160818 00:16:05< celmin> (Unless you're using a monospace font.)
20160818 00:17:48-!- gfgtdf [~chatzilla@x4e36a380.dyn.telefonica.de] has joined #wesnoth-dev
20160818 00:18:41< gfgtdf> celmin: it actual justs sets the max text length to 'averate chacter length' * characters_per_line  where 'averate chacter length' is independnet on the text
20160818 00:21:33< celmin> So it internally specifies the max text length in pixels anyway?
20160818 00:21:42< celmin> Then why the heck is it even needed?
20160818 00:22:03< celmin> If max text length is in pixels, then it can be calculated from the widget's dimensions.
20160818 00:22:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 00:23:00< gfgtdf> celmin: yes but it might still be dependent on the font or the text size, not sure though.
20160818 00:23:28< celmin> Obviously pixel length would take that into account.
20160818 00:27:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160818 00:36:08< vultraz> well, I'd be happy to have another way to force a maximum widget width
20160818 00:37:29-!- travis-ci [~travis-ci@ec2-54-159-114-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20160818 00:37:30< travis-ci> wesnoth/wesnoth#10439 (master - b8f0921 : Charles Dang): The build has errored.
20160818 00:37:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153132620
20160818 00:37:30-!- travis-ci [~travis-ci@ec2-54-159-114-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20160818 00:39:09< vultraz> hmm
20160818 00:39:14< vultraz> there's widget's max_width...
20160818 00:39:16< vultraz> but..
20160818 00:40:04< vultraz> yeah that's not what we want
20160818 00:42:39< celmin> What's the best way to associate a callback with each node...
20160818 00:43:49< celmin> I suppose I could have a map node_path->callback… though I don't think vector has operator<
20160818 00:46:20< celmin> Ah, I was wrong. It does have operator<
20160818 00:48:02< vultraz> ok, let's try preventing listboxes from shrinking..
20160818 00:48:44< vultraz> it's a huge usability issue
20160818 00:48:54< celmin> I kinda wonder if I should merge the view and controller.
20160818 00:52:12< vultraz> well this doesn't work
20160818 00:52:36 * vultraz mutters darkly
20160818 00:52:38< vultraz> HACK TIME
20160818 00:58:24< vultraz> good god this doesn't work either
20160818 00:58:43< vultraz> I NEED to make that scroll label wrap somehow
20160818 00:59:00< celmin> MP create?
20160818 00:59:06< vultraz> yes
20160818 00:59:28< vultraz> this *)@#&*(&#())*(U@#*(&*(@#&*^)&*(@#*(@(&*(_@#&_**+()*@ scroll label
20160818 01:14:55< vultraz> if one uses a label, everything works great
20160818 01:15:00< vultraz> except there's no scroll on overflow
20160818 01:18:57< vultraz> using a scrollbar_panel doesn't help either
20160818 01:19:24< vultraz> it alleviates the label getting wides, yes, but even if the label overflows it doesn't activate the scrollbar :|
20160818 01:19:56 * vultraz is furious
20160818 01:26:10< vultraz> ahhh!
20160818 01:26:13< vultraz> i'm getting somewhere
20160818 01:32:46< vultraz> oh look
20160818 01:32:50< vultraz> actual gotos!
20160818 01:33:04< vultraz> there's code that uses goto! :O
20160818 01:33:48-!- iceiceice [~chris@cpe-24-161-53-115.hvc.res.rr.com] has joined #wesnoth-dev
20160818 01:33:48-!- iceiceice [~chris@cpe-24-161-53-115.hvc.res.rr.com] has quit [Changing host]
20160818 01:33:48-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20160818 01:34:59< vultraz> wow there are actually quite a few goto uses
20160818 01:35:05< iceiceice> gah C++ is stupid
20160818 01:35:08< iceiceice> http://stackoverflow.com/questions/39005700/list-initialization-of-aggregates-when-can-it-invoke-copy-constructor
20160818 01:35:56< celmin> Where are these gotos?
20160818 01:36:00< iceiceice> apparently --std=c++11 doesn't mean, do what C++11 standard says... it means C++11 + all defect reports approved by comittee
20160818 01:36:33< vultraz> celmin: multiple places
20160818 01:36:48< celmin> Like?
20160818 01:38:26-!- iceiceice [~chris@unaffiliated/iceiceice] has left #wesnoth-dev []
20160818 01:39:56< vultraz> display.cpp, filesystem_boost.cpp, gui/widgets/scrollbar_container.cpp, language.cpp, many in lua/, scripting/game_lua_kernel.cpp, scripting/lua_common.cpp, scripting/lua_gui2.cpp, serialization/parser.cpp, serialization/tokenizer.cpp, server/simple_wml.cpp, and wesnoth.cpp
20160818 01:40:07< celmin> And there was a flyby iceiceice, apparently.
20160818 01:40:46-!- Bonobo [~Bonobo@2001:44b8:254:3200:9c9c:fa5:25b8:2bb9] has joined #wesnoth-dev
20160818 01:41:21< vultraz> that's all the files they're in
20160818 01:41:29< vultraz> (one case in SDL_gpu too but ignore that)
20160818 01:42:02< celmin> It's not even SDL_gpu.
20160818 01:42:05< celmin> It's stb_image.
20160818 01:42:12< celmin> Which I guess is a dependency of SDL_gpu.
20160818 01:42:37< celmin> The ones in lua/ don't count either, BTW
20160818 01:43:00< vultraz> yes
20160818 01:43:04< vultraz> but everything else is ours
20160818 01:43:20< celmin> What sorts of things are they used for?
20160818 01:43:30< celmin> grep isn't very helpful even if I request context.
20160818 01:44:51< vultraz> looks like mostly skipping past blocks
20160818 01:45:22< celmin> So, not breaking out of multiple loops simultaneously...
20160818 01:47:26< vultraz> some are even to exit a switch block
20160818 01:47:49< celmin> Huh? That's weird.
20160818 01:48:27< vultraz> yes
20160818 01:48:34< vultraz> i sense.. CLEANUP :D
20160818 01:48:39< celmin> BTW, how'd you get the list? If you just grep goto there are a lot of false positives.
20160818 01:49:04< vultraz> I grepped "goto "
20160818 01:49:07< vultraz> note the space
20160818 01:49:21< vultraz> then manually went down the list of 80-some matches for the valid ones
20160818 01:49:26< celmin> I see.
20160818 01:52:05< vultraz> all valid matches are in the files listed above
20160818 01:52:21< vultraz> (save lua/)
20160818 01:54:30< celmin> Whoooa, display.cpp has a massive preprocessor switch on SDL_GPU...
20160818 01:55:09< vultraz> Aginor said he's remove SDL_gpu eventually
20160818 01:56:03< celmin> The ones in game_lua_kernel are the "C exceptions" idiom.
20160818 01:57:04-!- gfgtdf_ [~chatzilla@x4e3690f8.dyn.telefonica.de] has joined #wesnoth-dev
20160818 01:57:29< celmin> I think the second one in lua_common also fits that.
20160818 01:58:19< celmin> lua_gui2 is also like that.
20160818 01:59:12-!- gfgtdf [~chatzilla@x4e36a380.dyn.telefonica.de] has quit [Ping timeout: 265 seconds]
20160818 01:59:14-!- gfgtdf_ is now known as gfgtdf
20160818 01:59:21< celmin> The parser ones are the multi-level break thing, so justified.
20160818 02:00:57< celmin> I'm not sure it's worth eliminating any of them, honestly.
20160818 02:03:47< celmin> BTW, do we actually have two different WML parsers?
20160818 02:03:58< celmin> I've been wondering about this for awhile.
20160818 02:05:23< celmin> There's serialization/parser.hpp, and there's server/simple_wml.hpp.
20160818 02:21:29< vultraz> i seem to be stumped by something so simple, here
20160818 02:22:02< celmin> I haven't really made progress since the last time I talked about the inspector, either.
20160818 02:22:22< vultraz> http://pastebin.com/5Et3Ca1H
20160818 02:22:36< vultraz> am I just stupid, or is my logic for the h modification stupid?
20160818 02:22:42< vultraz> wrong*
20160818 02:26:38< vultraz> as is, it never completely reduces the height when not needed
20160818 02:37:13< celmin> I don't really understand what's going on there.
20160818 02:37:30< celmin> content_resize_request in particular
20160818 02:38:07< vultraz> it takes a w/h modification
20160818 02:38:12< vultraz> meaning what to add/sub from the height
20160818 02:38:19< celmin> So, a delta.
20160818 02:38:47< celmin> The goal is to reach the best size?
20160818 02:39:10< vultraz> yes
20160818 02:39:19< vultraz> if the label needs overflow, give it a scrollbar..
20160818 02:39:22< vultraz> if not, remove it
20160818 02:39:38< vultraz> for some reason, no mtter what I do, on a smaller content the scrollbar will reduce but not go away :|
20160818 02:39:47< vultraz> even if the text fits
20160818 02:39:59< celmin> I feel like you don't need an if statement then...
20160818 02:40:29< celmin> I guess the delta is added to the height?
20160818 02:40:45< vultraz> yes
20160818 02:40:46< celmin> So then, best_size.y - content_visible_area().h is the delta.
20160818 02:41:17< celmin> Aren't you actually requesting it to get larger when the best size is smaller?
20160818 02:42:07< celmin> If content_visible_area().h >= best_size.y, then (best_size.y - content_visible_area().h) <= 0
20160818 02:42:23< celmin> So -(best_size.y - content_visible_area().h) >= 0
20160818 02:42:39< celmin> Which means a height increase, right?
20160818 02:43:09< vultraz> uhh..
20160818 02:43:14< celmin> If I understand the situation correctly, the formula for the delta is the same in both cases.
20160818 02:43:42< celmin> I'm assuming here that content_resize_request literally adds its argument to the height.
20160818 02:43:45< vultraz> i guess it could be, yes
20160818 02:43:56< celmin> Meaning you pass a negative number to decrease the height.
20160818 02:44:10< celmin> (Presumably it takes int, not unsigned int.)
20160818 02:44:36< celmin> If that's so, all you need is content_resize_request(0, best_size.y - content_visible_area().h), no if statement.
20160818 02:45:27< vultraz> but then the scrollbar doesn't appear at all
20160818 02:45:33< vultraz> which is what's been so infuriating
20160818 02:45:42< celmin> Huh?
20160818 02:46:41< vultraz> it WILL appear if you inverse that
20160818 02:46:47< vultraz> but then never go away if not needed :)
20160818 02:46:54< celmin> Invert what?
20160818 02:47:06< celmin> You mean content_resize_request(0, content_visible_area().h - best_size.y)?
20160818 02:48:23< vultraz> no, -()
20160818 02:48:33< celmin> That's the same thing.
20160818 02:48:40< vultraz> yes
20160818 02:48:43< celmin> -(x - y) == y - x
20160818 02:48:49< vultraz> but I'm just saying what I did
20160818 02:48:57< vultraz> I know it's the same :|
20160818 02:49:04< celmin> Then you could've just said yes.
20160818 02:49:59< vultraz> so, if it's inverted, the scrollbar will appear when needed... once. and then never go away if it's not and cause glithces
20160818 02:50:06< vultraz> but if it's not inverted, it never appears at all :|
20160818 02:50:39< celmin> Maybe content_resize_request doesn't work like I though.
20160818 02:50:41< celmin> ^+t
20160818 02:50:47< vultraz> im trying to figure out what this content_resize_request overload does differently from the other..
20160818 02:50:54< celmin> What are they?
20160818 02:51:27< vultraz> look in gui/widgets/scrollbar_container.cpp:540 and 615
20160818 02:52:31< vultraz> it used to just call the former
20160818 02:52:37< vultraz> but i don't want it to change width
20160818 02:53:00< celmin> So wait, you copied the code of the former into the latter?
20160818 02:53:21< vultraz> no :|
20160818 02:53:28< vultraz> i haven't touched those functions
20160818 02:53:37< celmin> You said it used to call the former...
20160818 02:54:32 * Aginor revenge-highlights vultraz 
20160818 02:54:43< vultraz> celmin: https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/scroll_label.cpp#L60
20160818 02:54:47< vultraz> is what I'm talking about
20160818 02:55:10< celmin> …revenge-highlight?
20160818 02:55:30< celmin> Oh, I see.
20160818 02:55:33< vultraz> you see the scroll labels called the first overload before
20160818 02:55:37< vultraz> the bool version
20160818 02:55:44< vultraz> but now, I need the second overload
20160818 02:55:51< vultraz> and for some reason I can't get it to behave correctly
20160818 02:59:37< vultraz> any thoughts?
20160818 03:00:32< Aginor> celmin: for when someone hightlighs you in passing
20160818 03:05:37< vultraz> if i remove the width-related block from the bool overload.. the text doesn't go to a new line
20160818 03:07:46< vultraz> it's clear I need the other overload
20160818 03:11:46-!- un214 [~un214@104.220.56.173] has joined #wesnoth-dev
20160818 03:17:28-!- gfgtdf [~chatzilla@x4e3690f8.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160818 03:23:57< irker986> wesnoth: Charles Dang wesnoth:master 162126026ac6 / src/gui/widgets/scroll_label.cpp: WIP: make scroll labels not change width when setting a new value https://github.com/wesnoth/wesnoth/commit/162126026ac6dd55e660dd7421589ebe401fbbcd
20160818 03:24:00< vultraz> gfgtdf: ^ maybe you could look at that later or something
20160818 03:24:06< vultraz> it's really driving me nuts :|
20160818 03:24:18< celmin> :/
20160818 03:24:26< celmin> Why is it WIP when it's on master.
20160818 03:24:47< vultraz> it half works
20160818 03:35:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 03:39:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160818 03:56:51-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has quit [Ping timeout: 264 seconds]
20160818 04:01:28-!- JyrkiVesterinen [~JyrkiVest@87-100-141-164.bb.dnainternet.fi] has joined #wesnoth-dev
20160818 04:16:38-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 244 seconds]
20160818 04:18:01-!- travis-ci [~travis-ci@ec2-54-197-110-242.compute-1.amazonaws.com] has joined #wesnoth-dev
20160818 04:18:02< travis-ci> wesnoth/wesnoth#10440 (master - 1621260 : Charles Dang): The build has errored.
20160818 04:18:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153160695
20160818 04:18:02-!- travis-ci [~travis-ci@ec2-54-197-110-242.compute-1.amazonaws.com] has left #wesnoth-dev []
20160818 04:22:28-!- un214 [~un214@104.220.56.173] has quit [Remote host closed the connection]
20160818 04:24:05-!- Kwandulin [~Miranda@p200300760F35BF32ACB3E63FE98909B2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160818 04:26:12< irker986> wesnoth: Charles Dang wesnoth:master adeefd724894 / data/gui/window/unit_attack.cfg: Unit Attack: don't allow range column to grow so much https://github.com/wesnoth/wesnoth/commit/adeefd724894500bce711034cc16ccdbab828d90
20160818 04:28:14< celmin> Tiny.
20160818 04:29:26< vultraz> But relevant
20160818 04:29:29< vultraz> To an open bug
20160818 04:31:10< vultraz> anyway
20160818 04:31:36< vultraz> part of the reason i committed that scroll label thing wip is so mp create's list wouldn't keep resizing
20160818 04:31:44< vultraz> it was a major usability problem
20160818 04:40:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160818 04:41:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 05:16:36< vultraz> celmin: I've decided for the dropdown list i shall use a vector of configs
20160818 05:16:55< celmin> Eh?
20160818 05:17:12< vultraz> easier than a vector of tuples or something
20160818 05:17:35< celmin> So just for reference, what types of rows does it need to support?
20160818 05:17:56< vultraz> what do you mean?
20160818 05:18:20-!- mjs-de [~mjs-de@x4db58dca.dyn.telefonica.de] has joined #wesnoth-dev
20160818 05:19:33< vultraz> it should support a checkbox, an icon, a label, and a tooltip for said label
20160818 05:19:50< vultraz> in each row
20160818 05:20:15-!- travis-ci [~travis-ci@ec2-54-205-121-205.compute-1.amazonaws.com] has joined #wesnoth-dev
20160818 05:20:16< travis-ci> wesnoth/wesnoth#10441 (master - adeefd7 : Charles Dang): The build has errored.
20160818 05:20:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153167187
20160818 05:20:16-!- travis-ci [~travis-ci@ec2-54-205-121-205.compute-1.amazonaws.com] has left #wesnoth-dev []
20160818 05:20:24< celmin> I don't think it needs to support both an icon and a checkbox. One or the other should be fine.
20160818 05:20:55< celmin> Do we use any checked menuitems that are mutually exclusive?
20160818 05:21:03< celmin> (For that matter, do we use any checked menuitems at all?)
20160818 05:21:13< celmin> I mean in the main game menus.
20160818 05:21:20< vultraz> one
20160818 05:21:25< vultraz> planning mode, I think
20160818 05:21:26< celmin> Planning mode?
20160818 05:21:28< celmin> Okay.
20160818 05:21:38< vultraz> still, im only doing the icon right now
20160818 05:21:41< celmin> So radio-button behaviour isn't needed. That makes things simpler.
20160818 05:21:41< vultraz> and tooltip
20160818 05:21:57< vultraz> no, we don't need radio buttons
20160818 05:22:01< celmin> If you have the icon, replacing it with a checkbox should be easy.
20160818 05:22:33< vultraz> first getting icons working
20160818 05:22:41< vultraz> and i figured it'd be best to just use a vector of configs
20160818 05:23:24< celmin> Actually, if you did need radiobutton behaviour, you could just place an icon on the currently selected one.
20160818 05:23:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 05:23:57< celmin> In fact, come to think of it, wouldn't that also be fine for checkbox behaviour?
20160818 05:24:09< celmin> Maybe you don't need an actual checkbox.
20160818 05:24:23< vultraz> again, first getting icons working :|
20160818 05:24:28< celmin> After all, the menu closes once a selection is made.
20160818 05:24:57< celmin> Doesn't the resolution dropdown have a means of showing the currently selected value?
20160818 05:25:01< vultraz> no, it still allows you to make checkbox selections
20160818 05:25:11< celmin> What?
20160818 05:25:40< vultraz> if you add a checkbox to the rows of the dropdown dialog, you can check it without closing the dialog
20160818 05:26:01< celmin> But I don't think that's the expected behaviour for a menu with checkable items.
20160818 05:26:16< celmin> eg, planning mode.
20160818 05:26:18< vultraz> why do you keep focusing on checkboxes
20160818 05:26:24< vultraz> I'm not doing checkboxes right now :|
20160818 05:26:35< celmin> I'm saying maybe we don't need them at all.
20160818 05:27:15< celmin> Using a vector of configs should be convenient when we expose the combobox to Lua (it's not right now, right?)
20160818 05:27:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160818 05:27:46< vultraz> no
20160818 05:30:42< vultraz> are you kidding me... :|
20160818 05:30:58< vultraz> it thinks 'config' is gui2::tcontrol::config
20160818 05:31:08< vultraz> how the hell do I tell it what I mean
20160818 05:31:39< celmin> ::config
20160818 05:32:01< vultraz> ahh
20160818 05:32:03< vultraz> thanks
20160818 05:33:29< vultraz> hmm
20160818 05:33:31< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\widgets\combobox.cpp|49|error: converting to 'std::vector<config>::value_type {aka config}' from initializer list would use explicit constructor 'config::config(const string&)'|
20160818 05:34:07< vultraz> what does this mean
20160818 05:34:36< celmin> What's the code?
20160818 05:35:00< vultraz> values_.push_back({["label"] = this->label()});
20160818 05:35:06< vultraz> something tells me this is wrong
20160818 05:35:17< celmin> Uh. What?
20160818 05:35:50< celmin> What are you even trying to do there.
20160818 05:36:09< celmin> I'm shocked it doesn't complain about unexpected [ or something.
20160818 05:36:28< vultraz> hm wait, I don't need []..
20160818 05:36:36< celmin> Though, I guess it's GCC, so it might be trying to parse it as C99 initializers… but then it'd complain about a string...
20160818 05:36:59< celmin> Oh, wait, are you thinking in Lua here?
20160818 05:37:10< vultraz> i'm trying to add an entry at the end with its label key = set to label()
20160818 05:37:15< celmin> Right, right.
20160818 05:37:20< celmin> You want config_assign.hpp
20160818 05:37:30< celmin> config_of("label", this->label())
20160818 05:37:57< celmin> For multiple keys you'd do config_of(key1, val1)(key2, val2) etc
20160818 05:38:03< vultraz> I see
20160818 05:38:04< celmin> The value can be another config, as well.
20160818 05:38:08< vultraz> how is it I'm thinking in lua?
20160818 05:38:36< celmin> Well, {["label"] = value} is a Lua table literal.
20160818 05:38:36-!- mjs-de [~mjs-de@x4db58dca.dyn.telefonica.de] has quit [Remote host closed the connection]
20160818 05:39:05< vultraz> I did not know this
20160818 05:39:14< celmin> You've surely used them all the time.
20160818 05:39:21< celmin> Admittedly, the shorthand without quotes and brackets.
20160818 05:39:27< celmin> {label = value}
20160818 05:39:38< celmin> You need the quotes and brackets if the key is not a valid identifier, I think.
20160818 05:39:45< vultraz> I see
20160818 05:39:47< celmin> eg {["hello world"] = value}
20160818 05:40:22< celmin> Even without knowing about the brackets part though, the general {x = y} structure is still Lua-ish but will not work in C++.
20160818 05:40:22< vultraz> oh, yes, I've done that
20160818 05:40:46< celmin> Also need brackets if the key is not a string, eg {[4] = value}
20160818 05:40:47< vultraz> or more specifically, it's in my code
20160818 05:41:36< celmin> config_of is actually a bit more convenient that Lua table literals, since you add children with the same syntax as you add attribtues.
20160818 05:41:39< celmin> ^attribtues
20160818 05:41:41< celmin> ...
20160818 05:41:43< celmin> ^attributes
20160818 05:44:30-!- celticminstrel is now known as celmin|sleep
20160818 05:46:55-!- afre_ [63f485be@gateway/web/freenode/ip.99.244.133.190] has joined #wesnoth-dev
20160818 05:48:42-!- JyrkiVesterinen [~JyrkiVest@87-100-141-164.bb.dnainternet.fi] has quit [Quit: .]
20160818 05:57:00-!- afre_ [63f485be@gateway/web/freenode/ip.99.244.133.190] has quit [Quit: Page closed]
20160818 06:20:32< irker986> wesnoth: Charles Dang wesnoth:master 119e095ccd24 / / (9 files in 4 dirs): Added support for icons/entry tooltips in drop down dialogs/comboboxes https://github.com/wesnoth/wesnoth/commit/119e095ccd24dd3fc40a24069899ebc3f3a75b69
20160818 06:20:36< vultraz> that was easier than i thought
20160818 06:21:22< vultraz> using a config also means it's really easy to add new things to the dropdown
20160818 06:26:42-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160818 06:28:10< tad_> Just synced to master and I'm getting errors on stderr
20160818 06:28:24< tad_>  error validation: Invalid key 'tooltip=' in tag [option]
20160818 06:32:26< vultraz> oh
20160818 06:33:42< irker986> wesnoth: Charles Dang wesnoth:master 245a7cc3d58b / data/gui/schema.cfg: Updated schema for 119e095ccd24 https://github.com/wesnoth/wesnoth/commit/245a7cc3d58be0291937697c0ad3bcd64a2f2f80
20160818 06:33:44< vultraz> tad_: fixed ^
20160818 06:33:47< tad_> Three tooltips in a combobox. mp_create_
20160818 06:33:53< tad_> game.cfg
20160818 06:34:33< vultraz> yeah, the above commit fixes it
20160818 06:35:59< tad_> Yep. That did it.
20160818 06:41:48-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160818 07:03:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 07:06:39-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160818 07:08:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160818 07:11:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160818 07:14:31-!- travis-ci [~travis-ci@ec2-54-197-110-242.compute-1.amazonaws.com] has joined #wesnoth-dev
20160818 07:14:32< travis-ci> wesnoth/wesnoth#10442 (master - 119e095 : Charles Dang): The build has errored.
20160818 07:14:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153180933
20160818 07:14:32-!- travis-ci [~travis-ci@ec2-54-197-110-242.compute-1.amazonaws.com] has left #wesnoth-dev []
20160818 07:17:05-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160818 07:29:18-!- Kwandulin [~Miranda@p200300760F35BF32ACB3E63FE98909B2.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160818 07:49:57-!- Kwandulin [~Miranda@p200300760F35BF02ACB3E63FE98909B2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160818 07:51:06-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Remote host closed the connection]
20160818 07:56:38-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160818 07:57:14-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Ping timeout: 260 seconds]
20160818 08:00:56-!- travis-ci [~travis-ci@ec2-54-159-114-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20160818 08:00:57< travis-ci> wesnoth/wesnoth#10443 (master - 245a7cc : Charles Dang): The build has errored.
20160818 08:00:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153182848
20160818 08:00:57-!- travis-ci [~travis-ci@ec2-54-159-114-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20160818 08:03:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 08:06:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160818 08:07:13-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160818 08:07:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160818 08:29:42-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160818 08:34:05-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160818 09:03:02-!- Kwandulin [~Miranda@p200300760F35BF02ACB3E63FE98909B2.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160818 09:19:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 09:21:37 * vultraz mutters darkly at gui2
20160818 09:23:01< vultraz> I think this scroll label thing is a lot more complicated than I thought
20160818 09:23:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160818 09:31:01-!- Kwandulin [~Miranda@p200300760F35BF025D645453B78DEF5F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160818 09:38:56-!- Duthlet [~Duthlet@dslb-188-105-138-092.188.105.pools.vodafone-ip.de] has joined #wesnoth-dev
20160818 09:43:55-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160818 09:49:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 09:55:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160818 09:57:22-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160818 09:57:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160818 09:57:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 10:49:37-!- irker986 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160818 10:53:24-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: JyrkiVesterinen]
20160818 10:58:18-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160818 11:07:53-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160818 11:27:28< loonycyborg> I can't repro that assert with earlier versions of native compilers, 4.8 and 4.9
20160818 11:27:53< loonycyborg> for some reason it happens only with debian's mingw-w64 package crosscompiler
20160818 11:28:23< loonycyborg> perhaps it's a compiler bug that got patched even in earlier branches?
20160818 11:29:44-!- gfgtdf [~chatzilla@x4e3690f8.dyn.telefonica.de] has joined #wesnoth-dev
20160818 11:31:28< gfgtdf> loonycyborg: boost has onyl code depenent on the the compiler version
20160818 11:31:41< gfgtdf> loonycyborg: so fr examepl it oynl uses conxtepr with compiler with cull constepr supprt
20160818 11:32:09< loonycyborg> but I'd expect 4.9 on mingw will have same set of features as native 4.9?
20160818 11:32:53< gfgtdf> loonycyborg: hmm ye thats what i'D thinkaswell
20160818 11:33:25< gfgtdf> i'd
20160818 11:35:07< loonycyborg> oh derp
20160818 11:35:52< loonycyborg> I was on campaignd_asio branch
20160818 11:36:49< loonycyborg> on master it happens with 4.8 and 4.9
20160818 11:36:53< loonycyborg> but not with 5.4
20160818 11:39:58< gfgtdf> loonycyborg: but on that branch it oynl happenw on mingw ?
20160818 11:40:12< loonycyborg> no
20160818 11:40:26< gfgtdf> loonycyborg: ok
20160818 11:40:32< loonycyborg> debian vm compiles master
20160818 11:40:56< loonycyborg> it just happens to use gcc 4.9
20160818 11:41:16< gfgtdf> loonycyborg: you did a examepl case already?
20160818 11:41:26< loonycyborg> nope
20160818 11:41:34< loonycyborg> was about to look into it
20160818 11:42:19< gfgtdf> loonycyborg: when ancestral first had the is arror i got the impression tha it onl happened on some std::bind cases in wesntho cource and i couldnt really see what distingueses them from the others, so itight not be tht easy.
20160818 11:43:21< gfgtdf> others = othes in wsnoth soruce
20160818 12:09:06< loonycyborg> eh that was so easy
20160818 12:10:48< loonycyborg> gfgtdf: https://gist.github.com/loonycyborg/f8b994789353d2d142cf9f2d835231ff
20160818 12:11:04< loonycyborg> this succeeds with 5.4 and fails with4.9
20160818 12:11:48< gfgtdf> hmm didnt think it'd be that easy.
20160818 12:12:54< gfgtdf> loonycyborg: you'll post in the bugreport ?
20160818 12:13:00< loonycyborg> yes
20160818 12:17:21-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: Rebooting]
20160818 12:18:05-!- Bonobo [~Bonobo@2001:44b8:254:3200:9c9c:fa5:25b8:2bb9] has quit [Quit: Leaving]
20160818 12:18:28< loonycyborg> gfgtdf: done
20160818 12:19:19< gfgtdf> loonycyborg: ok
20160818 12:21:28-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160818 12:36:55-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160818 12:47:55-!- Kwandulin [~Miranda@p200300760F35BF025D645453B78DEF5F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160818 12:48:34-!- fabi_ [~fabi@176.4.53.205] has joined #wesnoth-dev
20160818 12:59:32-!- Bonobo [~Bonobo@2001:44b8:254:3200:90d5:7ce5:4bc1:1bbf] has joined #wesnoth-dev
20160818 13:30:24-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Read error: No route to host]
20160818 13:43:21-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160818 13:57:32-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160818 14:19:52-!- Kwandulin [~Miranda@p200300760F35BF02C5E60D21DDBC104B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160818 14:53:16-!- Bonobo [~Bonobo@2001:44b8:254:3200:90d5:7ce5:4bc1:1bbf] has quit [Quit: Leaving]
20160818 14:59:21-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160818 15:06:39-!- celmin|sleep is now known as celticminstrel
20160818 15:33:51< fabi_> hi
20160818 15:44:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160818 15:45:00-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160818 15:45:31-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 15:45:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160818 15:46:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 15:47:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160818 15:47:24-!- JyrkiVesterinen [~JyrkiVest@87-92-51-153.bb.dnainternet.fi] has joined #wesnoth-dev
20160818 15:50:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 15:51:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160818 15:53:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 15:55:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 15:55:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160818 15:56:09-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160818 15:56:39-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Read error: Connection reset by peer]
20160818 15:56:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 15:56:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160818 15:58:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160818 16:00:27< bumbadadabum> hey guys
20160818 16:00:43< bumbadadabum> sorry for my absence the past few weeks
20160818 16:00:56< bumbadadabum> my computer is being repaired at the moment
20160818 16:01:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 16:01:41< fabi_> hi bumbadadabum
20160818 16:21:13-!- JyrkiVesterinen [~JyrkiVest@87-92-51-153.bb.dnainternet.fi] has quit [Quit: .]
20160818 16:21:36-!- ggeneral [~ggeneral@nat58.opti.net.ua] has joined #wesnoth-dev
20160818 16:42:51-!- mjs-de [~mjs-de@x4db60187.dyn.telefonica.de] has joined #wesnoth-dev
20160818 16:47:34-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Connection reset by peer]
20160818 17:01:59-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 17:03:53-!- Duthlet [~Duthlet@dslb-188-105-138-092.188.105.pools.vodafone-ip.de] has quit [Quit: leaving]
20160818 17:04:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160818 17:08:58-!- Shiki_ [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160818 17:19:22-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160818 17:21:09-!- JyrkiVesterinen [~JyrkiVest@87-92-51-153.bb.dnainternet.fi] has joined #wesnoth-dev
20160818 17:26:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 17:33:26-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160818 17:40:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160818 17:43:14-!- Kwandulin [~Miranda@p200300760F35BF02C5E60D21DDBC104B.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160818 17:47:18-!- ggeneral [~ggeneral@nat58.opti.net.ua] has left #wesnoth-dev []
20160818 17:50:01-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160818 17:54:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 264 seconds]
20160818 17:55:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 17:59:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160818 18:02:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160818 18:31:38-!- Kwandulin [~Miranda@p200300760F35BF0224950A9B3FEA8C32.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160818 18:56:42-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Read error: Connection reset by peer]
20160818 18:56:59-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20160818 19:02:12-!- timotei [~timotei@wesnoth/developer/timotei] has quit [Ping timeout: 250 seconds]
20160818 19:03:26-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20160818 20:01:32-!- JyrkiVesterinen [~JyrkiVest@87-92-51-153.bb.dnainternet.fi] has quit [Quit: .]
20160818 20:11:06-!- Shiki_ [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160818 20:17:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160818 20:17:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 20:29:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160818 20:29:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 20:32:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160818 20:36:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 20:42:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160818 20:43:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160818 20:54:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160818 21:07:53-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160818 21:11:40-!- irker257 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160818 21:11:40< irker257> wesnoth: Charles Dang wesnoth:master 835bfa646f44 / data/gui/window/unit_attack.cfg: Unit Attack: reduced weapon label size and disabled max width (bug #24988) https://github.com/wesnoth/wesnoth/commit/835bfa646f44ef2b2c064d7730b2fc5fc44834e6
20160818 21:13:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160818 21:13:00-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160818 21:15:33-!- Appleman1234 [~Appleman1@KD036012017069.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160818 21:34:09< vultraz> celticminstrel: how's the inspector
20160818 21:34:11< vultraz> ?
20160818 21:34:51< celmin> I decided to take a break from coding and do some writing, so no progress today, but… maybe at 80% now?
20160818 21:35:11-!- mjs-de [~mjs-de@x4db60187.dyn.telefonica.de] has quit [Remote host closed the connection]
20160818 21:35:31< vultraz> ok
20160818 21:35:41< vultraz> could you commit the tweaks to mp create?
20160818 21:36:13< celmin> BTW, about WML tag porting, even though I think it's a bit pointless, I'm not strongly oppose either, so if anyone wants to port a tag in the branch, feel free.
20160818 21:36:31< celmin> I could commit the tweaks to MP create. Is it that important?
20160818 21:37:46-!- Kwandulin [~Miranda@p200300760F35BF0224950A9B3FEA8C32.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160818 21:40:25< vultraz> Not that important, I guess
20160818 21:40:41< celmin> They're very minor changes, anyway.
20160818 21:41:03< celmin> There was a compile error with the array key (which is probably a bug in my libc++ or something, but still).
20160818 21:43:31< vultraz> anyway, i might have to revert the scroll label thing
20160818 21:43:41< vultraz> it looks like it's more complicated than i thought
20160818 21:44:16< celmin> That should be no surprise. :P
20160818 21:44:53< vultraz> invalidate_layout recalculates the label wrapping and size correctly.. but we don't want to call that
20160818 21:45:10< vultraz> or at the very least, we want to, but don't want the widget to grow
20160818 21:45:15< vultraz> and I can't figure this out
20160818 22:05:57-!- travis-ci [~travis-ci@ec2-174-129-131-190.compute-1.amazonaws.com] has joined #wesnoth-dev
20160818 22:05:58< travis-ci> wesnoth/wesnoth#10444 (master - 835bfa6 : Charles Dang): The build has errored.
20160818 22:05:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153402480
20160818 22:05:58-!- travis-ci [~travis-ci@ec2-174-129-131-190.compute-1.amazonaws.com] has left #wesnoth-dev []
20160818 22:23:27-!- Appleman1234 [~Appleman1@KD036012021122.au-net.ne.jp] has joined #wesnoth-dev
20160818 22:25:24< gfgtdf> vultraz: i currently think it migth be best to calculate the child label wiget and the size chagne manually in  the scorll_label code
20160818 22:27:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Quit: Leaving]
20160818 22:28:05< gfgtdf> vultraz: maybe it as simple as calling widget->request_reduce_width(widget.get_size().x) after widget->set_label(label); in https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/scroll_label.cpp#L59
20160818 22:40:47-!- Appleman1234 [~Appleman1@KD036012021122.au-net.ne.jp] has quit [Read error: Connection reset by peer]
20160818 23:01:35-!- Appleman1234 [~Appleman1@KD036012021122.au-net.ne.jp] has joined #wesnoth-dev
20160818 23:07:48-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160818 23:08:12-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160818 23:39:06< vultraz> gfgtdf: holy crap that works
20160818 23:44:50< celmin> Yay?
20160818 23:46:07< irker257> wesnoth: Charles Dang wesnoth:master 5bac12a53e40 / src/gui/widgets/scroll_label.cpp: tscroll_label: proper implementation of 162126026ac (thanks to gfgtdf) https://github.com/wesnoth/wesnoth/commit/5bac12a53e40c8a31c68d7a5985d129c879100f7
20160818 23:46:21< vultraz> I can't believe I spent a day on that and the fix was one line :|
20160818 23:46:38< vultraz> #just programmer things
20160818 23:47:04< celmin> This is not Twitter. :(
20160818 23:47:23< vultraz> I screwed up the hashtag anyway
20160818 23:47:26< celmin> That too.
20160818 23:47:29< vultraz> #JustProgrammerThings
20160818 23:47:34< celmin> Still not Twitter.
20160818 23:47:40< celmin> That's actually a link to join a new chatroom.
20160818 23:47:46< vultraz> I am aware :P
20160818 23:47:51< celmin> :/
20160818 23:48:27< vultraz> but hashtags are appropriate anywhere 
20160818 23:48:36< celmin> Not really.
20160818 23:50:03-!- Appleman1234 [~Appleman1@KD036012021122.au-net.ne.jp] has quit [Ping timeout: 276 seconds]
20160818 23:51:17< vultraz> now I need to decide if I should embed difficulty selection directly into the dialog
20160818 23:51:30< celmin> Huhwhat?
20160818 23:51:45< vultraz> right now, the campaign difficulty selection displays in post show
20160818 23:52:06< celmin> I thought you were working on MP Create.
20160818 23:52:10< vultraz> yes
20160818 23:52:21< vultraz> you forget about mp campaigns? :P
20160818 23:52:52< celmin> So you're proposing duplicating the difficulty selecting?
20160818 23:53:02< vultraz> right now, it pops up in post show
20160818 23:53:18< vultraz> because of the design of gui2, you cannot abort the dialog closing from post show
20160818 23:53:41< vultraz> i added a hack to allow post_show to override the retval in the case you cancel difficulty selection
20160818 23:54:05< vultraz> and put the dialog display call in a loop that causes it to reopen if you cancel the difficulty dialog
20160818 23:54:14< vultraz> it's a suboptimal solution
20160818 23:54:53< celmin> You can set the retval and close the dialog programmatically, right?
20160818 23:55:10< vultraz> but not from post_show
20160818 23:55:16< celmin> I mean from a dialog callback.
20160818 23:55:36< vultraz> yes
20160818 23:55:41< vultraz> but that makes no difference
20160818 23:55:42< celmin> Then change the ID of the OK button.
20160818 23:55:53< celmin> And/or bind a custom callback to it.
20160818 23:56:03< celmin> So that it doesn't immediately close the dialog.
20160818 23:56:05< vultraz> I considered going through a custom callback for the Create button, yes
20160818 23:56:27< celmin> Instead, it shows the difficulty dialog if necessary, and doesn't close the dialog if they cancel that.
20160818 23:56:33< vultraz> but I forgot that one can doubleclick the game listbox in lieu of the Create button
20160818 23:57:03< celmin> That's also a bound callback, right? So you should be able to do the same thing from there.
20160818 23:57:25< vultraz> hooking into the doubleclick events is something shadowm had problems with when doing the filesystem dialog
20160818 23:57:45< vultraz> I think the clicks are bound to the toggle panel not the listbox itself...
20160818 23:57:57< celmin> Find the place where the double-click is bound?
20160818 23:58:22< celmin> I would've assumed the MP Create dialog had explicitly bound it though.
20160818 23:58:33< vultraz> it is not
20160818 23:58:37< vultraz> why would you assume that?
20160818 23:58:57< celmin> Well, where else would it be bound?
20160818 23:59:10< vultraz> it's bound directly into the toggle_panel
20160818 23:59:13< celmin> Double-clicking a listbox item to close the dialog is not a general behaviour that you'd want of all listboxes.
20160818 23:59:31< celmin> Or all toggle panels, probably.
20160818 23:59:43< celmin> So the dialog should be responsible for binding that, right?
20160818 23:59:52< celmin> I suppose the listbox could be responsible for it.
20160818 23:59:55< vultraz> by means of return_value_id  = "ok"
20160818 23:59:59< celmin> ?
--- Log closed Fri Aug 19 00:00:00 2016