--- Log opened Sat Aug 20 00:00:32 2016
20160820 00:01:42< celmin> I have the rewritten inspector at a state where it builds, so once I test and add page buttons I can push it.
20160820 00:01:49< celmin> BTW, there's a way to hide widgets, right>
20160820 00:01:51< celmin> ^?
20160820 00:02:56< celmin> (Though I expect the testing to take awhile.)
20160820 00:03:51< vultraz> widget.set_visible(tcontrol::tvisible::invisible) OR twidget::tvisible::invisble
20160820 00:03:56< vultraz> there's also ::hidden
20160820 00:04:05< vultraz> which preserves the space of the widget
20160820 00:04:08< vultraz> just hides it
20160820 00:04:11< celmin> Can I make them initially hidden?
20160820 00:04:17< vultraz> invisible makes it as if it's not there
20160820 00:04:21< celmin> Or would I need to hide them in pre_show?
20160820 00:04:26< vultraz> (sadly, border space is still preserved)
20160820 00:04:30< vultraz> hide them in pre_show, yes
20160820 00:04:44< celmin> I should probably also make sure it splits on a line break...
20160820 00:07:41< vultraz> still working the inspector?
20160820 00:07:51< celmin> Yeah, I mentioned it just a few lines up.
20160820 00:08:27< vultraz> [10:49:04]	celmin	Apparently "boost_trimming" is not fully merged… what was the command to compare it to master...
20160820 00:08:35< vultraz> there's one commit you stashed there
20160820 00:08:46< celmin> Oh, right.
20160820 00:08:59< vultraz> std::...something didn't work with travis
20160820 00:09:18< celmin> I wonder what's a good way to find an inspector value that needs paging...
20160820 00:09:32< celmin> I suppose temporarily lowering the page limit to 1000 characters would help...
20160820 00:09:49< celmin> Do we have arrow buttons?
20160820 00:09:53< vultraz> yes
20160820 00:10:00< celmin> Left and right?
20160820 00:10:29< celmin> I guess up and down would also work, but I think I prefer left and right for this.
20160820 00:10:48< Aginor> hey everyone
20160820 00:10:51< celmin> Hi
20160820 00:10:58< vultraz> definition = "left_arrow" / "right_arriw"
20160820 00:10:58< fabi__> hi Aginor
20160820 00:11:00< vultraz> arrow*
20160820 00:11:13< Aginor> my steam controller arrived yesterday, we shouldn't need to do *anything* inside wesnoth to support it
20160820 00:11:24< vultraz> o_O
20160820 00:11:33< Aginor> instead, we should supply an official profile for the controller to use with the game
20160820 00:11:53< shadowm> Even if Wesnoth does not optimally support any controllers of any sort yet?
20160820 00:12:03< Aginor> the controller loads different configurations for different appliations, and maps buttons/trackpads to keyboard/mouse
20160820 00:12:06< shadowm> (Or at all in master since 1.13.2, IIRC.)
20160820 00:12:36< Aginor> so instead of trying to make controller support to work for it, we should make a keyboard/mouse profile for the controller with sensible bindings
20160820 00:12:58< vultraz> ahh
20160820 00:13:39< Aginor> I spent some time playing civ5 with it yesterday and civ 5 doesn't have *any* controller support
20160820 00:13:51< fabi__> Aginor: Well, not exactly but I agree mostly.
20160820 00:14:22< fabi__> Aginor: The controller needs to be adressed in some mixed mode. Scrolling the screen with the analog stick is really nice to have.
20160820 00:14:40< Aginor> fabi__: that gets bound to the arrow-keys ;)
20160820 00:14:49< fabi__> Well yes.
20160820 00:14:56< fabi__> But analog sticks are far better.
20160820 00:15:01< fabi__> Just try it.
20160820 00:15:08< fabi__> I have coded the support for it already.
20160820 00:15:31< shadowm> Wasn't it removed?
20160820 00:15:35< vultraz> disabled
20160820 00:15:48< Aginor> afaik, it wasn't finished
20160820 00:15:52< shadowm> It was originally hidden, not disabled.
20160820 00:16:03< shadowm> So is it disabled now?
20160820 00:16:05< fabi__> Aginor: It was. The gui to configure it wasn't.
20160820 00:16:05< celmin> I thought it can be enabled in prefs?
20160820 00:16:12< Aginor> shadowm: I removed the hotkey bindings for gamepad, I can reinstate that quickly enough
20160820 00:16:19< celmin> fabi__: Well, that's a very important part of it though.
20160820 00:16:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 240 seconds]
20160820 00:16:42< fabi__> celmin: Maybe, but still Aginor can test it.
20160820 00:16:44< Aginor> my point is, sateam controller != any other controller on the market
20160820 00:16:54< vultraz> I'm not sure why we care about any other controller right now
20160820 00:17:01< vultraz> we're talking about the Steam Controller
20160820 00:17:05< vultraz> not an Xbox 1 controller
20160820 00:17:06< Aginor> vultraz: market penetration
20160820 00:17:10< vultraz> not a PS4 controller
20160820 00:17:39< celmin> Some people like using other controllers (I assume)>
20160820 00:18:25< shadowm> vultraz: People may already own other controllers.
20160820 00:18:34< vultraz> but we're not focusing on that right now
20160820 00:18:41< shadowm> And TBH I have no idea how I'd go about purchasing the Steam controller in the first place.
20160820 00:18:42< vultraz> we're talking about the Steam Controller :|
20160820 00:18:51< shadowm> Which is a controller.
20160820 00:21:14< celmin> Huh? Indentation step size isn't a thing? Why is it existing commented out in places if it's not a thing?
20160820 00:21:30< vultraz> what?
20160820 00:21:33< vultraz> what are you talking about :|
20160820 00:21:38< celmin> In tree views.
20160820 00:22:19< vultraz> it is a thing
20160820 00:22:34< vultraz> but it's called indention_step_size
20160820 00:22:37< vultraz> not indentation 
20160820 00:22:46< celmin> Oh right, I should've disabled new lobby. Looks like MP Create is crashing… or I forgot to disable exception breakpoints.
20160820 00:22:57< vultraz> don't ask me why
20160820 00:22:59< celmin> But… if it was that I would've hit a breakpoint earlier, I'm sure...
20160820 00:26:37< vultraz> feel free to rename the key
20160820 00:27:44< Aginor> shadowm: I got mine off amazon in the us because they're not released in my country yet
20160820 00:27:58< celmin> Will do
20160820 00:28:51< Aginor> I already own 4 logitech controllers that are xbox360 compatible so I wouldn't have bought the steam controller unless I had a a decent reason to
20160820 00:29:07< Aginor> it helped that it's pretty cheap compared to proper controllers
20160820 00:29:35< celmin> Hmm, on_mod_select crashing.
20160820 00:29:54< celmin> Well, unless you have a good idea why, I'll look into it after I finish with the inspector.
20160820 00:31:03< vultraz> I do not
20160820 00:31:05< vultraz> and I
20160820 00:31:11< vultraz> m working on the saved games list
20160820 00:31:41< fabi__> Aginor, vultraz: I don't see a reason why not every controller can be supported in 1.14. Only a mapping of axis to functions is missing. That is not a very complicated dialog. It pretty much can reuse the hotkey one.
20160820 00:32:34< vultraz> then do so
20160820 00:32:39< vultraz> if you can, please :)
20160820 00:32:40< fabi__> okay
20160820 00:33:00< fabi__> I need some help with gui2 dialog coding.
20160820 00:33:10< fabi__> The wml part of gui2 is just hell.
20160820 00:34:20< vultraz> it is
20160820 00:34:27< vultraz> I can help, since I'm the best at it
20160820 00:35:35< fabi__> cool
20160820 00:36:17< fabi__> I would also like to have some presets for common controllers.
20160820 00:36:22< fabi__> Like steam or xbox one.
20160820 00:42:18-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has left #wesnoth-dev []
20160820 00:43:09-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160820 00:46:11 * Aginor disappears fort the rest of the day
20160820 00:46:51-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:44b9:a76c:708a:bb84] has joined #wesnoth-dev
20160820 00:51:17-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:44b9:a76c:708a:bb84] has quit [Ping timeout: 250 seconds]
20160820 01:08:51-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:44b9:a76c:708a:bb84] has joined #wesnoth-dev
20160820 01:13:05-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 01:13:06< travis-ci> wesnoth/wesnoth#10457 (master - 4dbf5b0 : Lari Nieminen): The build has errored.
20160820 01:13:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153708415
20160820 01:13:06-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 01:18:51-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has quit [Ping timeout: 276 seconds]
20160820 01:30:31-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160820 01:30:34-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160820 01:30:56 * tad_ arrives with a bug question. Everyone groans.
20160820 01:32:09< tad_> So, testing [message] about the sword and armor in HttT. It uses speaker=$unit.id fine. But it always uses message=, never male_message= or female_message=
20160820 01:33:08< tad_> And caption= does, in fact, suppress the unit's name.
20160820 01:33:10< celmin> :(
20160820 01:33:39< tad_> So just need to find the bug in the Lua and get male and female messages working.
20160820 01:34:32< celmin> I think I see it.
20160820 01:34:51< celmin> Line 214, change cfg.message to msg_cfg
20160820 01:35:08< tad_> Hang on and I'll test that.
20160820 01:35:31< celmin> Probably broke when the formatting feature was added.
20160820 01:36:44< tad_> 	msg_cfg.message = add_formatting(cfg, cfg.message) --> msg_cfg.message = add_formatting(cfg, msg_cfg) ???
20160820 01:38:01-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:44b9:a76c:708a:bb84] has quit [Remote host closed the connection]
20160820 01:39:35< celmin> msg_cfg.message
20160820 01:39:42< celmin> Sorry for being unclear.
20160820 01:40:03< tad_> Figured that out. Fixed it .. do you want to commit or me a PR?
20160820 01:41:15-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has quit [Ping timeout: 264 seconds]
20160820 01:41:40< celmin> You can PR if you want, otherwise I'll push it along with the new inspector, hopefully in a couple of hours.
20160820 01:42:23< tad_> OK. I'll put a PR up in a moment. Have the no_turn_limit PR for zookeeper up, too, if you wanna merge it at the same time ...
20160820 01:43:08< celmin> no_turn_limit? I thought he was asking you to add a macro...
20160820 01:44:44< celmin> The point being to include the translatable string in core.
20160820 01:44:48< tad_> Yep. Did it. PR is up, with changelog (I remembered this time).
20160820 01:44:52< celmin> Ah.
20160820 01:45:50-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160820 01:46:22< tad_> OK. At your leasure on those two PR. I'm fixing HTTT General Improvements to use the messages as you suggested now that its working
20160820 01:47:32< celmin> Blargh, new inspector doesn't work at all...
20160820 01:48:46< celmin> vultraz: Do I need to do something to prevent multiselection in the treeview?
20160820 01:58:10< vultraz> what?
20160820 01:58:17< vultraz> I don't know if that's possible
20160820 01:59:28< irker885> wesnoth: Gregory A Lundberg wesnoth:master 15c761ec7599 / changelog data/core/macros/objective-utils.cfg: HAS_NO_TURN_LIMIT objectives macro https://github.com/wesnoth/wesnoth/commit/15c761ec759917501781e216832939794e85e386
20160820 01:59:30< celmin> Of course it's possible.
20160820 01:59:30< irker885> wesnoth: Charles Dang wesnoth:master 1591ecef66be / changelog data/core/macros/objective-utils.cfg: Merge pull request #752 from GregoryLundberg/GL_no_turn_limit https://github.com/wesnoth/wesnoth/commit/1591ecef66be32b3920635e2346705879c0298ed
20160820 01:59:40< celmin> What I want to know is if it can be done from the WML.
20160820 01:59:43< irker885> wesnoth: Gregory A Lundberg wesnoth:master 9d44a45f88e4 / data/lua/wml/message.lua: Fix bug with gender-specific messages in [message] https://github.com/wesnoth/wesnoth/commit/9d44a45f88e4a1044fbb02ea3ef3b572da5a70ca
20160820 01:59:45< irker885> wesnoth: Charles Dang wesnoth:master 7fab08508f6a / data/lua/wml/message.lua: Merge pull request #753 from GregoryLundberg/GL_gender_messages_fix https://github.com/wesnoth/wesnoth/commit/7fab08508f6a868fc8232af0b56f6b8b03c6129c
20160820 01:59:56< vultraz> likely not
20160820 02:00:25< celmin> Don't existing treeviews only allow single selection? The campaign menu for instance.
20160820 02:00:42< vultraz> what..?
20160820 02:00:56< vultraz> it's really hard to understand you sometimes
20160820 02:01:17< celmin> When you select a campaign, the previously selected one is deselected.
20160820 02:01:22< celmin> (The toggle panel, I guess.)
20160820 02:01:30< vultraz> yes
20160820 02:01:34< vultraz> that's a toggle panel
20160820 02:03:15< vultraz> gaaahhhhhhh
20160820 02:03:21< vultraz> i cannot get this save list to work :|
20160820 02:09:36< vultraz> ahhhhhh
20160820 02:09:38< vultraz> got it
20160820 02:10:07< vultraz> ok, I've gotten the list to print
20160820 02:10:24< vultraz> now comes the gargantuan task of making it work with the dialog
20160820 02:15:44< celmin> BTW
20160820 02:15:49< celmin> [Aug 19@10:00:56pm] vultraz: it's really hard to understand you sometimes
20160820 02:15:57< celmin> I could say the same of you too. :P
20160820 02:16:00< vultraz> heh
20160820 02:16:13< vultraz> well, the problem is you say stuff without appropriate context
20160820 02:16:15< vultraz> is that likewise
20160820 02:16:27-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160820 02:16:33< celmin> Think so, yeah
20160820 02:17:36< vultraz> ah
20160820 02:17:38< celmin> Hmm, so it seems that ttree_view::set_selection_change_callback isn't working somehow...
20160820 02:18:27< celmin> Unless my breakpoints are broken.
20160820 02:19:56< celmin> The breakpoint is resolved, so that means it's not being hit, so the callback isn't being called.
20160820 02:22:38< celmin> The else of the (new_widgets || true) blocks should probably be removed in the campaign list, don't you think?
20160820 02:23:19< vultraz> yes
20160820 02:23:24< vultraz> but don't do it
20160820 02:23:34< vultraz> I'll deal with it
20160820 02:23:39< celmin> Wasn't really planning to do it.
20160820 02:23:46< vultraz> I'm pondering reverting the campaign dialog to a listbox
20160820 02:23:48< celmin> (I did remove the comments in dropdown list.)
20160820 02:23:50< vultraz> with a combobox underdeath
20160820 02:23:54< vultraz> with checkboxes in the dropdown
20160820 02:23:56< celmin> I see.
20160820 02:24:03< celmin> So that's why it's still there, huh.
20160820 02:24:42< celmin> I don't see anything different about what the campaign selection is doing… unless...
20160820 02:25:22< vultraz> look at mp create for a slightly cleaner reference
20160820 02:25:39< celmin> I'm not sure I want to look at MP Create… but I'll consider it anyway.
20160820 02:25:50< vultraz> btw, as i'm sure you've realized, tree views have a mandatory id for their toplevel node toggles and labels
20160820 02:26:03< celmin> Hmm.
20160820 02:26:17< vultraz> they MUST be called tree_view_node_toggle and tree_view_node_label
20160820 02:26:32< celmin> What?
20160820 02:26:47< celmin> So the toggle_panel needs id=tree_view_node_toggle?
20160820 02:26:59< vultraz> if you have a collapsible node, the toggle button must have the id tree_view_node_toggle
20160820 02:27:03< vultraz> not a toggle panel
20160820 02:27:09-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160820 02:27:11< vultraz> and the label next to it must be called tree_view_node_label
20160820 02:27:22< celmin> Hmm.
20160820 02:27:27< vultraz> i suppose technically any toggleable widget would work
20160820 02:27:38< vultraz> preferences uses a toggleable toggle panel
20160820 02:27:42< vultraz> now that i think of it
20160820 02:28:04< vultraz> so if you give the toggle panel the id tree_view_node_toggle it should work
20160820 02:28:23< vultraz> in which case the label inside it should be called tree_view_node_label
20160820 02:28:25< vultraz> iirc
20160820 02:28:41< celmin> Testing with just the panel having an ID.
20160820 02:29:12< vultraz> do you understand?
20160820 02:29:32< celmin> Sort of?
20160820 02:30:29< celmin> Still not working though...
20160820 02:31:33< celmin> There are no instances of tree_view_node_toggle in the source.
20160820 02:32:35< celmin> So I think you must be wrong about this.
20160820 02:32:53< celmin> No instances in data, either.
20160820 02:35:17< celmin> I see, it's icon rather than toggle.
20160820 02:36:40< celmin> …now the treeview is empty for some reason. :|
20160820 02:36:58< vultraz> oh
20160820 02:36:59< vultraz> icon?
20160820 02:37:01< vultraz> blah
20160820 02:37:04< vultraz> sorry
20160820 02:37:12< vultraz> it really should be called toggle :|
20160820 02:37:25< celmin> Maybe
20160820 02:39:01< vultraz> anyway, besides the name, everything i said above should apply
20160820 02:39:23< celmin> So for some reason, now that I added the ID, the nodes are not showing up.
20160820 02:39:48< vultraz> let me see the code
20160820 02:40:08< celmin> WML or C++, or both?
20160820 02:40:23< celmin> Showing the C++ would be hard though, there's kinda a lot of it.
20160820 02:41:02< vultraz> wml first
20160820 02:43:02< celmin> http://pastebin.com/YNTkak7M
20160820 02:43:22< celmin> Oh, missing an N there though. Meh.
20160820 02:45:26-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160820 02:49:10< vultraz> celmin: does it work with the 'n'?
20160820 02:50:30< vultraz> also, you probably want
20160820 02:50:32< vultraz>  vertical_grow = "true"
20160820 02:50:34< vultraz>                 horizontal_grow = "true"
20160820 02:50:37< vultraz> in the column with the tree view
20160820 02:50:45< vultraz> if you don't have them there already
20160820 02:51:25< vultraz> celmin: also, try added 'unfolded = true' in [node]
20160820 03:03:03< celmin> No, it's with the N that it doesn't work
20160820 03:04:17< celmin> horx_grow was false...
20160820 03:04:20< celmin> ^horz
20160820 03:04:34-!- Bonobo [~Bonobo@2001:44b8:254:3200:c43c:2c44:8c53:7c77] has joined #wesnoth-dev
20160820 03:05:37< vultraz> hmm
20160820 03:05:47< celmin> Testing with it and vert_grow true.
20160820 03:05:52< celmin> Then will try unfolded
20160820 03:06:12-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:44b9:a76c:708a:bb84] has joined #wesnoth-dev
20160820 03:07:44< celmin> No luck, nodes still not showing.
20160820 03:07:51< vultraz> ok
20160820 03:07:54< celmin> I don't see any console errors or anything.
20160820 03:08:01< celmin> Like "failed to place xyz"
20160820 03:08:06< vultraz> revery to a toggle button and see what happens
20160820 03:08:10< vultraz> revert*
20160820 03:08:16< celmin> Can a toggle button contain a grid?
20160820 03:08:23< vultraz> no
20160820 03:08:25< vultraz> wait...
20160820 03:08:27< vultraz> why do you need a grid?
20160820 03:08:44< vultraz> just have two columns, a toggle button and a label
20160820 03:08:50< vultraz> with the appropriate ids
20160820 03:08:52< vultraz> anyway
20160820 03:08:54< vultraz> off to lunch
20160820 03:09:03< Polsaker> it needs more gremlins
20160820 03:09:19< celmin> The toggle can be any tselectable_
20160820 03:10:00< celmin> So toggle panel qualifies
20160820 03:10:52< celmin> Oh, I see. Maybe if I change it to label instead of icon.
20160820 03:11:02< celmin> (The toggle is initially hidden by the tree_view_node code.)
20160820 03:12:23< celmin> Looks like that works.
20160820 03:12:53< celmin> Might need to do something about it having an initial selection...
20160820 03:13:19< celmin> Whoops, markup wasn't enabled somewhere it should be...
20160820 03:13:35< celmin> Also, I think I probably don't want horizontal grow after all.
20160820 03:14:29-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 03:14:30< travis-ci> wesnoth/wesnoth#10460 (master - 1591ece : Charles Dang): The build has errored.
20160820 03:14:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153722230
20160820 03:14:30-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 03:15:49-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160820 03:16:20< celmin> Cause I did "uses_markup" instead of "use_markup"
20160820 03:19:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20160820 03:19:25-!- wedge010 is now known as wedge009
20160820 03:21:42< celmin> I suppose I can't set border_size on rows...
20160820 03:30:15-!- hk238 [~kvirc@85.157.175.224] has joined #wesnoth-dev
20160820 03:35:03-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:44b9:a76c:708a:bb84] has quit [Remote host closed the connection]
20160820 03:36:33< celmin> Hmm. Now it seems that inspector text isn't being set...
20160820 03:37:40< celmin> Even though I called set_label, the text isn't showing up...
20160820 03:41:20< celmin> Okay, when a node is selected, I need to fold all other nodes on the same level...
20160820 03:43:13-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 03:43:14< travis-ci> wesnoth/wesnoth#10461 (master - 7fab085 : Charles Dang): The build has errored.
20160820 03:43:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153722273
20160820 03:43:14-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 03:49:21< celmin> vultraz: Any idea why the label may not be working?
20160820 03:51:13< celmin> Hmm, getting placement failures now for some reason...
20160820 03:52:46< celmin> Ugh, I need to implement twalker_.
20160820 03:54:08< celmin> Or an alternative.
20160820 04:07:19< celmin> That was surprisingly easy.
20160820 04:07:36< celmin> (I just copied the grid walker and tweaked it.)
20160820 04:10:51-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160820 04:15:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160820 04:15:57< vultraz> celticminstrel: what's the problem bow?
20160820 04:16:06< vultraz> now*
20160820 04:16:15< vultraz> btw, any labels should have horizontal_grow = "true"
20160820 04:17:05< celticminstrel> Probably already does, since that label hasn't changed from the old inspector.3
20160820 04:17:16< celticminstrel> (Though I guess it's a scroll label.)
20160820 04:18:28-!- Kwandulin [~Miranda@p200300760F35BFE1F1398612D30D5CD4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 04:19:08< vultraz> could you commit what you have so I can take a look
20160820 04:19:15< celticminstrel> No.
20160820 04:19:24< celticminstrel> I'm not going to commit something totally broken.
20160820 04:20:54< vultraz> you do have a fork, right? 
20160820 04:22:34< vultraz> push to your fork 
20160820 04:22:48< vultraz> obv don't commit something totally broken to master :|
20160820 04:24:15< celticminstrel> Heh, I just wrote border_sides instead of border_size.
20160820 04:24:45< celticminstrel> Hmm... I just thought, is a scroll label a tlabel? Maybe that's why it's not working.
20160820 04:25:48< vultraz> tcontrol
20160820 04:25:57< celticminstrel> Hmm, I was using tcontrol as the template argument though, so it should be fine...
20160820 04:26:14< vultraz> tscroll_label and tlabel both inherit from tcontrol
20160820 04:26:23< vultraz> you can use them as the template argument for find_widget
20160820 04:26:27< vultraz> s/them/it
20160820 04:26:37< celticminstrel> Yeah, it turns out that tcontrol is what I used there.
20160820 04:44:18< celticminstrel> I'm getting a grid placement failed error, but I don't see anything wrong in the dialog. Maybe it's innocuous?
20160820 04:44:33-!- JyrkiVesterinen [~JyrkiVest@87-100-223-63.bb.dnainternet.fi] has joined #wesnoth-dev
20160820 04:45:06< vultraz> can I see the code :|
20160820 04:45:13< celticminstrel> Maybe.
20160820 04:45:35< celticminstrel> Hmm, a different format for ID events might be good...
20160820 04:45:42< vultraz> :|
20160820 04:46:09< celticminstrel> I get the feeling the walker is not working...
20160820 04:47:15< celticminstrel> Ah, no, I've just got the wrong continue condition.
20160820 04:47:27< celticminstrel> Hopefully that's it.
20160820 04:47:54< vultraz> ok, i think...
20160820 04:48:01< vultraz> I only want mp saves in this dialog
20160820 04:48:19< celticminstrel> You know, I could use covariant return types in this walker.
20160820 04:48:25< vultraz> i should handle that condition in-dialog
20160820 04:48:37< vultraz> or should I handle it in the create engine?
20160820 04:48:38< celticminstrel> Though I guess that won't actually help, since I only get a pointer to the base class...
20160820 04:49:03< celticminstrel> I think it's better to only show the MP-compatible saves in the first place, rather than an error if you try to load one that isn't.
20160820 04:49:47< vultraz> right
20160820 04:55:25-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160820 04:55:44-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160820 04:56:32< celticminstrel> Whoa! The scroll label updated! :O
20160820 04:56:41< celticminstrel> Or uhhh.
20160820 04:56:45< celticminstrel> Not quite, I guess.
20160820 04:56:53< celticminstrel> Something was updated with its text though...
20160820 04:57:13< celticminstrel> Okay, the walker thing works.
20160820 04:57:40< vultraz> you really like the walkers
20160820 04:58:02< celticminstrel> I wouldn't say I particularly like them, but they're useful for some things.
20160820 04:58:39< celticminstrel> Now, let me see if I can determine why the wrong label is being set...
20160820 05:00:39 * vultraz attempts to determine why wesnoth is crashing
20160820 05:01:30< vultraz> jesus christ, we need to stop scrollbars throwing exceptions >_>
20160820 05:01:58< vultraz> well... this is useful
20160820 05:02:24< vultraz> wesnoth crashes and the debugger says it existed cleanly :|
20160820 05:02:35< celticminstrel> Ooh, I see. I got the two labels swapped.
20160820 05:02:44< celticminstrel> I'm setting the name to the content and the content to the name.
20160820 05:03:02< vultraz> that would be a problem :|
20160820 05:03:12< celticminstrel> Yup.
20160820 05:04:31< celticminstrel> Also, I just remembered that the inspector lets you set a custom title...
20160820 05:16:08< celticminstrel> Hmm, I wonder how I can programmatically deselect the initial item...
20160820 05:23:28< vultraz> node.fold
20160820 05:23:29< vultraz> ()
20160820 05:23:36< celticminstrel> Eh?
20160820 05:23:46< vultraz> do you want to fold the node?
20160820 05:23:55< vultraz> if not, why would you not want the initial entry selected
20160820 05:24:09< celticminstrel> When the dialog opens, the first item is selected (outlined), so clicking on it does not trigger the callback.
20160820 05:24:26< celticminstrel> I'd rather it be not outline, and have clicking it trigger the callback.
20160820 05:24:30< celticminstrel> ^+d
20160820 05:24:34< vultraz> manually call the callback
20160820 05:24:37< vultraz> in pre_show
20160820 05:24:44< vultraz> that's how every dialog does it
20160820 05:24:45< celticminstrel> I guess I could... :/
20160820 05:24:54< vultraz> that's how every dialog does it
20160820 05:24:59< celticminstrel> That does mean that the list of variables will be initially visible though.
20160820 05:25:14< vultraz> fine
20160820 05:25:17< vultraz> that's fine
20160820 05:25:47< celticminstrel> It's a little problematic though since it means you might miss the other items.
20160820 05:26:01< vultraz> ...what?
20160820 05:26:25< vultraz> where will be a scrollbar :|
20160820 05:26:33< celticminstrel> True.
20160820 05:27:45< vultraz> there*
20160820 05:28:27< celticminstrel> I'd prefer them all to be initially collapsed, but I suppose that'll do...
20160820 05:29:12< vultraz> i still can't understand why wesnoth is exiting and not crashsing :|
20160820 05:29:20< vultraz> it shouldn't exit
20160820 05:29:36< vultraz> an expected exit should always be a crash
20160820 05:31:30< celticminstrel> Unexpected, you mean.
20160820 05:31:46< vultraz> unexpected
20160820 05:31:48< vultraz> ys
20160820 05:31:49< vultraz> yes
20160820 05:36:53< JyrkiVesterinen> I guess it catches the exception somewhere.
20160820 05:37:13< JyrkiVesterinen> Maybe you can turn on breaking on first-chance exceptions in your debugger.
20160820 05:37:38< JyrkiVesterinen> (First-chance exception means an exception that has just been thrown, before it's even known if it will be catched.)
20160820 05:40:02< vultraz> not sure how to turn that on
20160820 05:41:19< celticminstrel> Nice, paging works.
20160820 05:41:26< celticminstrel> Needs to be saner though.
20160820 05:41:52< celticminstrel> vultraz: Was there a function to clamp a value into a given range?
20160820 05:42:00< vultraz> no
20160820 05:42:08< vultraz> not until c++17
20160820 05:42:22< celticminstrel> No, I mean like a utility function defined somewhere in Wesnoth.
20160820 05:42:29< vultraz> not relly
20160820 05:42:46< vultraz> there's one locally in one of the files but not globally 
20160820 05:42:58< celticminstrel> I guess I can just use min+max then.
20160820 05:43:08< vultraz> yes
20160820 05:47:26< vultraz> hmmmmmmmmm
20160820 05:47:41< vultraz> saved games might be more complicated than I thought
20160820 05:47:46< vultraz> since...
20160820 05:47:54< vultraz> technically, they can be of any ttype
20160820 05:47:57< vultraz> type*
20160820 05:48:21< vultraz> and needs the proper consideration
20160820 05:52:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160820 06:34:56< celticminstrel> I think the inspector is essentially done now.
20160820 06:35:25< celticminstrel> Could still use some tweaks. The tree view sometimes gets too wide, proportionally.
20160820 06:35:46< celticminstrel> Though it's probably not really a problem except on 800x600, and it's not too bad even there.
20160820 06:40:21< celticminstrel> The page indicator doesn't expand as needed and instead gives an ellipse...should I give it a grow factor or something?
20160820 06:40:30< celticminstrel> If I give it grow factor 0, does it still expand?
20160820 06:41:48< celticminstrel> Ah, but I also need right alignment, and that's ignored if I have horizontal grow set to true...
20160820 06:42:26< celticminstrel> Well, it's probably not that important in practice - I reduced the max page size so I could test it, but I doubt there will ever be more than five or so pages, and generally there'll only be one.
20160820 06:43:02< celticminstrel> I'll commit as soon as I solve a crash.
20160820 06:46:07< celticminstrel> Also, somehow it seems like the page buttons aren't disappearing when they should.
20160820 06:47:09-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Disconnected by services]
20160820 06:47:39-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160820 06:47:41< celticminstrel> The crash seems to be inconsistent, so maybe I'll commit without resolving that...
20160820 06:48:24< celticminstrel> Ah, the buttons are disappearing after all, with one exception.
20160820 06:50:09< vultraz> celticminstrel: I'll fix the page label thing
20160820 06:50:12-!- Aginor_ [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20160820 06:50:47< celticminstrel> You'll probably have to edit the static constant max page length to reproduce it.
20160820 06:50:54< celticminstrel> (Make sure not to commit that. :P )
20160820 06:51:03< vultraz> the what now?\
20160820 06:51:20< celticminstrel> There's a constant in the code defining the maximum length of a page.
20160820 06:51:30< vultraz> I see
20160820 06:51:33< celticminstrel> It's normally 20,000, but I reduced it to 1000 for the purpose of testing.
20160820 06:51:39< vultraz> I see
20160820 06:52:26 * vultraz is finding himself wondering if MVC would be appropriate for mp create
20160820 06:52:38< irker885> wesnoth: Celtic Minstrel wesnoth:master 43f5deaaf0d1 / src/ (4 files in 3 dirs): Rename potentially ambiguous function https://github.com/wesnoth/wesnoth/commit/43f5deaaf0d1ee46b00b71b4b9d62f1938598acf
20160820 06:52:40< irker885> wesnoth: Celtic Minstrel wesnoth:master 5bcc7a07f7d2 / src/ (display_context.cpp display_context.hpp game_board.hpp): Add get_team() to display_context for 1-indexed lookup https://github.com/wesnoth/wesnoth/commit/5bcc7a07f7d291623734cb122864daf08344dfcd
20160820 06:52:42< irker885> wesnoth: Celtic Minstrel wesnoth:master ba8c3b97b7eb / src/gui/dialogs/drop_down_list.cpp: Dropdown list: Honour the request for markup https://github.com/wesnoth/wesnoth/commit/ba8c3b97b7ebff80591e71682a4c54aac2eb75c6
20160820 06:52:44< irker885> wesnoth: Celtic Minstrel wesnoth:master 178ef3118a7b / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): MP Create: Minor cleanup https://github.com/wesnoth/wesnoth/commit/178ef3118a7bae104193b30229edeabd0f33bc85
20160820 06:52:45-!- Kwandulin_2 [~Miranda@p200300760F35BFE1F1398612D30D5CD4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 06:52:46< irker885> wesnoth: Celtic Minstrel wesnoth:master f5acf47a19f6 / / (9 files in 4 dirs): Rename indention -> indentation https://github.com/wesnoth/wesnoth/commit/f5acf47a19f62224b2be215155e2a32c528bbf5d
20160820 06:52:48< irker885> wesnoth: Celtic Minstrel wesnoth:master cef1674ce4a2 / / (6 files in 4 dirs): Implment tree node walker https://github.com/wesnoth/wesnoth/commit/cef1674ce4a25f1efb1160b2c75fe2bf81e8942e
20160820 06:52:50< irker885> wesnoth: Celtic Minstrel wesnoth:master d5a78dfcd059 / / (6 files in 5 dirs): Redesign gamestate inspector window https://github.com/wesnoth/wesnoth/commit/d5a78dfcd0593c0335762d3dfa0b0a9702fb016c
20160820 06:53:58< vultraz> i kinda forgot saved games are supposed to skip configuration
20160820 06:54:07< irker885> wesnoth: Celtic Minstrel wesnoth:team_index_refactor 184a316a4e88 / src/ (76 files in 18 dirs): Refactor team indexing to avoid using 0-based indices as much as possible https://github.com/wesnoth/wesnoth/commit/184a316a4e883b27f70ebaa58fcc9e68b0188bd6
20160820 06:54:09< vultraz> so I'd just want to display the info, but not allow changing it
20160820 06:54:23< celticminstrel> ^ That commit's on a branch because it's huge and requires sanity checks.
20160820 06:54:38-!- Netsplit *.net <-> *.split quits: Yaiyan, new_one, Aginor, Kwandulin
20160820 06:54:38-!- yaiyan_ [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20160820 06:56:27< vultraz> eh.
20160820 06:56:29< vultraz> hm
20160820 06:56:41< vultraz> actually, display of data should be irrelevant right now
20160820 06:57:30< vultraz> celticminstrel: your copyright statement is wrong
20160820 06:57:56< celticminstrel> That's because I just copied the walker_grid files and tweaked them.
20160820 06:59:11< vultraz> "Honour "
20160820 06:59:16< vultraz> . . . . . . . . . .
20160820 06:59:18< vultraz> :|
20160820 06:59:30< celticminstrel> ?
20160820 06:59:40< vultraz> your commit message
20160820 06:59:43< vultraz> uses
20160820 06:59:45< vultraz> excessive
20160820 06:59:47< vultraz> 'u'
20160820 06:59:48< vultraz> :|
20160820 06:59:53< celticminstrel> Of course it does.
20160820 07:00:02< celticminstrel> That's the normal spelling around here.
20160820 07:00:14< celticminstrel> Anyway, it's just a commit message.
20160820 07:00:29< vultraz> I'm gonna assume you are not 'Murican, now
20160820 07:00:42< celticminstrel> I'd assumed you already knew that, but okay.
20160820 07:03:31< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\gamestate_inspector.cpp||In member function 'int gui2::tgamestate_inspector::model::count_pages()':|
20160820 07:03:36< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\gamestate_inspector.cpp|129|error: no matching function for call to 'max(std::vector<std::pair<unsigned int, int> >::size_type, long unsigned int)'|
20160820 07:03:48< celticminstrel> Bah.
20160820 07:03:51< vultraz> is that supposed to be count_children
20160820 07:04:18< celticminstrel> I was hoping 1ul would suffice, but I guess you can drop the ul and use explicit <int>
20160820 07:04:23< celticminstrel> max<int> that is.
20160820 07:04:33< celticminstrel> Or max<size_t>. Match the return type.
20160820 07:05:06< vultraz> the return type is int..
20160820 07:05:44< vultraz> lmao
20160820 07:05:46< vultraz> "repaginate"
20160820 07:05:55< celticminstrel> What's funny about that?
20160820 07:05:57-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160820 07:06:17< vultraz> it's a funny word
20160820 07:09:40 * vultraz wonders how this code makes sense to you bu mp create does not
20160820 07:11:28< vultraz> you know you could have implemented a close_all method or something instead of using a walker
20160820 07:11:50< celticminstrel> Meh.
20160820 07:12:23< vultraz> meh?
20160820 07:14:23-!- Kwandulin_2 [~Miranda@p200300760F35BFE1F1398612D30D5CD4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160820 07:14:31< vultraz> wesnoth y u just crash
20160820 07:17:40< vultraz> what is this "content_title" label?
20160820 07:17:43< vultraz> I see no titles
20160820 07:18:52-!- hk238 [~kvirc@85.157.175.224] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160820 07:19:04< vultraz> celticminstrel: 
20160820 07:20:11< vultraz> ugh, you've done this coding style of putting .stuff() on multiple lines.
20160820 07:21:48< vultraz> no borders...
20160820 07:22:08< celticminstrel> That's because it's construct-by-chained-calls idiom.
20160820 07:22:29< vultraz> yes, but it's still easier to read on one line
20160820 07:22:30< celticminstrel> So it's like each .stuff(xyz) is a stuff = xyz3
20160820 07:22:44< celticminstrel> No, it's absolutely not easier to read on one line.
20160820 07:22:47< vultraz> anyway, why did you use toggle panels here
20160820 07:22:52< celticminstrel> Please don't go and put it on one line.
20160820 07:22:52< vultraz> and not toggle buttons
20160820 07:22:58< vultraz> i'm curious
20160820 07:23:01< celticminstrel> Because they're panels and not buttons?
20160820 07:23:15< vultraz> there's no reason to not use buttons
20160820 07:23:27< celticminstrel> I disagree.
20160820 07:23:31< vultraz> also
20160820 07:23:34< vultraz> [18:17:38]	vultraz	what is this "content_title" label?
20160820 07:23:36< vultraz> [18:17:41]	vultraz	I see no titles
20160820 07:23:37< vultraz> there's never any title
20160820 07:23:44< celticminstrel> I have no idea what's up with that.
20160820 07:23:52< vultraz> is there SUPPOSED to be a title?
20160820 07:24:03< celticminstrel> The idea was to replace the word "Contents" with a string representing what was actually being shown, but...
20160820 07:24:13< celticminstrel> I suppose that could be removed and just left as "Contents".
20160820 07:24:21< vultraz> good, I can do that
20160820 07:24:23< celticminstrel> I'm not sure why it doesn't work.
20160820 07:24:29< vultraz> makes life much simpler anyway
20160820 07:24:34< vultraz> since then I can fix the page label
20160820 07:24:46< celticminstrel> (That was my intention originally, but I'm not all that attached to it.)
20160820 07:25:04< celticminstrel> Please don't put the .stuff() all on one line.
20160820 07:25:13< vultraz> fine, fine
20160820 07:25:23< vultraz> you absolutely must use smaller labels in some places, though
20160820 07:25:43< vultraz> (don't actually go do it, leave it to me)
20160820 07:26:05< celticminstrel> If it was a case like the last one where each .stuff() returned a different object, that would be one thing, but here it's the chaining idiom where each method returns the same object.
20160820 07:26:19< celticminstrel> Anyway, I'll probably sleep soon.
20160820 07:26:29< vultraz> border_size = 6
20160820 07:26:33 * vultraz sputtters
20160820 07:26:36< celticminstrel> What?
20160820 07:26:41< celticminstrel> That's probably a typo. I probably meant 5.
20160820 07:26:45< celticminstrel> Unless it wasn't me.
20160820 07:28:08< vultraz> possibly
20160820 07:31:20< vultraz> hmm
20160820 07:31:26< vultraz> you use three columns of rows
20160820 07:31:42< vultraz> er, rows of columns
20160820 07:31:52< vultraz> acceptable
20160820 07:33:05-!- new_one [~new_one@2604:a880:1:20::22e:d001] has joined #wesnoth-dev
20160820 07:43:20-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160820 07:46:59-!- Kwandulin [~Miranda@p200300760F35BF19C0B0341B93FC3B1D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 07:47:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160820 07:54:22-!- Kwandulin [~Miranda@p200300760F35BF19C0B0341B93FC3B1D.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160820 08:08:31-!- Kwandulin [~Miranda@p200300760F35BF19787EB8F4FB9A2FF1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 08:19:43< JyrkiVesterinen> I have a possible fix for the MP tests getting stuck in Travis.
20160820 08:19:53< JyrkiVesterinen> I'll try to first test locally if it helps.
20160820 08:46:18< irker885> wesnoth: Jyrki Vesterinen wesnoth:master 61a22556ceaa / src/events.cpp: Fix multiplayer tests getting stuck in Travis CI https://github.com/wesnoth/wesnoth/commit/61a22556ceaaebcf9cc1d43d0702d02835acc6ee
20160820 08:46:32< JyrkiVesterinen> Fixed. I was able to verify the fix locally. :)
20160820 08:51:41< irker885> wesnoth: Jyrki Vesterinen wesnoth:master 0dfb36528702 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/0dfb3652870298abf708214c5adc3216c86d638c
20160820 09:04:32-!- mjs-de [~mjs-de@x4e318ae9.dyn.telefonica.de] has joined #wesnoth-dev
20160820 09:05:10< vultraz> JyrkiVesterinen: ah, sweet! :D
20160820 09:27:42-!- mjs-de [~mjs-de@x4e318ae9.dyn.telefonica.de] has quit [Remote host closed the connection]
20160820 09:40:13< irker885> wesnoth: Wedge009 wesnoth:master 7cc7e70a8330 / src/gui/dialogs/gamestate_inspector.cpp: Prevent MSVC complaint about type mismatch. https://github.com/wesnoth/wesnoth/commit/7cc7e70a8330be7646728ae04161d1a237e3865f
20160820 09:43:07-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160820 09:43:56< wedge009> Has anyone tried the game inspector? Today's changes seem to break it.
20160820 09:48:55< wedge009> celticminstrel: An error due to possibly invalid WML occurred
20160820 09:48:55< wedge009> The error message is :
20160820 09:48:55< wedge009> Unknown builder id for tree view node.
20160820 09:48:55< wedge009>  
20160820 09:48:55< wedge009> When reporting the bug please include the following error message :
20160820 09:48:55< wedge009> Condition 'false' failed at ..\..\src\gui\widgets\tree_view_node.cpp:122 in function 'gui2::ttree_view_node::ttree_view_node'.
20160820 09:49:25< wedge009> Happens even with a fresh campaign start.
20160820 10:05:20< vultraz> not happening for me
20160820 10:05:43< vultraz> btw, i already had 7cc7e70a8330 fixed locally differently
20160820 10:17:20-!- Kwandulin [~Miranda@p200300760F35BF19787EB8F4FB9A2FF1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160820 10:26:13-!- JyrkiVesterinen [~JyrkiVest@87-100-223-63.bb.dnainternet.fi] has quit [Quit: .]
20160820 10:31:19-!- Duthlet [~Duthlet@dslb-188-104-254-170.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20160820 10:41:14-!- grzywacz [~grzywacz@89-70-181-125.dynamic.chello.pl] has joined #wesnoth-dev
20160820 10:41:14-!- grzywacz [~grzywacz@89-70-181-125.dynamic.chello.pl] has quit [Changing host]
20160820 10:41:14-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has joined #wesnoth-dev
20160820 10:52:00-!- travis-ci [~travis-ci@ec2-54-145-247-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 10:52:01< travis-ci> wesnoth/wesnoth#10471 (team_index_refactor - 184a316 : Celtic Minstrel): The build failed.
20160820 10:52:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153745689
20160820 10:52:01-!- travis-ci [~travis-ci@ec2-54-145-247-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 10:52:19-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 10:52:20< travis-ci> wesnoth/wesnoth#10470 (master - d5a78df : Celtic Minstrel): The build has errored.
20160820 10:52:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153745589
20160820 10:52:20-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 10:56:47< irker885> wesnoth: Charles Dang wesnoth:master b672c24ccbb4 / / (3 files in 2 dirs): Gamestate Inspector: further design improvements https://github.com/wesnoth/wesnoth/commit/b672c24ccbb44d4409c5a002ea36c027d752eda5
20160820 10:56:49< vultraz> celticminstrel ^
20160820 10:57:18< vultraz> celticminstrel: I actually tweaked the layout to be consistent with the Lua console
20160820 11:05:31< wedge009> vultraz: Linux is okay but even after that last commit I'm still having trouble in Windows. Maybe I need to do a full recompile.
20160820 11:05:51< vultraz> :/
20160820 11:07:29-!- Appleman1234 [~Appleman1@KD036012024020.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20160820 11:16:58-!- Kwandulin [~Miranda@p200300760F35BF19D1531F38715B5ED0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 11:19:18< irker885> wesnoth: Charles Dang wesnoth:master fae6da9ad1d1 / / (5 files in 3 dirs): MP Lobby: added a game status icon for Registered Users Only https://github.com/wesnoth/wesnoth/commit/fae6da9ad1d16662ad5e0ebbdba77cae0e532022
20160820 11:23:39< irker885> wesnoth: Charles Dang wesnoth:master ae7ed76b5852 / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): MP Create: implement savegame loading via Load Game button https://github.com/wesnoth/wesnoth/commit/ae7ed76b5852154cdd82cef989e98c9197adebf8
20160820 11:24:29< vultraz> Still working on the 'list appropriate savegames as another category' thing, but that at least allows game loading for now
20160820 11:34:33< irker885> wesnoth: Charles Dang wesnoth:master df5d33fa3778 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: fix difficulty dialog not showing when loading appropriate game https://github.com/wesnoth/wesnoth/commit/df5d33fa377839fcddc833ff046ddb2a2efd9a58
20160820 11:34:50< vultraz> I think Create is fully functional now, actually
20160820 11:39:40-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160820 11:41:29< vultraz> wedge009: can you confirm if Create is working alright for you?
20160820 11:41:41< vultraz> anything seem to be missing/broken?
20160820 11:44:03< wedge009> I was about to go to bed.
20160820 11:44:40< wedge009> Compiler complains about savegame not being a class or namespace (line 530).
20160820 11:44:47-!- Appleman1234 [~Appleman1@KD036012024020.au-net.ne.jp] has joined #wesnoth-dev
20160820 11:45:15< wedge009> 'template mp' = 'tmp'? Looks like temp.
20160820 11:45:22< wedge009> (orary)
20160820 11:47:12-!- travis-ci [~travis-ci@ec2-54-145-247-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 11:47:13< travis-ci> wesnoth/wesnoth#10473 (master - 61a2255 : Jyrki Vesterinen): The build failed.
20160820 11:47:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153755354
20160820 11:47:13-!- travis-ci [~travis-ci@ec2-54-145-247-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 11:49:37< vultraz> eh?
20160820 11:49:43< vultraz> I'll look into it...
20160820 11:49:50< vultraz> might have committed something I didn't want to
20160820 11:50:02< vultraz> wedge009: if it's late there's no rush :)
20160820 11:50:04< vultraz> do it some other time
20160820 12:02:37-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160820 12:03:15< irker885> wesnoth: Charles Dang wesnoth:master 71d15850f434 / src/gui/dialogs/multiplayer/mp_create_game.cpp: Fixup compilation https://github.com/wesnoth/wesnoth/commit/71d15850f434837779ff229bd08d927688a72e91
20160820 12:03:21< vultraz> wedge009: ^ should fix 
20160820 12:08:38-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160820 12:09:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20160820 12:10:17-!- VultCave is now known as vultraz
20160820 12:12:43-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160820 12:12:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160820 12:32:09-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 12:32:10< travis-ci> wesnoth/wesnoth#10475 (master - 7cc7e70 : Wedge009): The build failed.
20160820 12:32:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153761269
20160820 12:32:10-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 12:33:54< vultraz> probably won't pass until it reaches my last commit
20160820 12:35:16-!- grzywacz [~grzywacz@wesnoth/developer/grzywacz] has quit [Quit: Ex-Chat]
20160820 12:42:23< fabi__> hi
20160820 12:56:00-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 12:56:01< travis-ci> wesnoth/wesnoth#10476 (master - b672c24 : Charles Dang): The build failed.
20160820 12:56:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153769054
20160820 12:56:01-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 13:13:29-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160820 13:25:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160820 13:32:16-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 13:32:17< travis-ci> wesnoth/wesnoth#10478 (master - ae7ed76 : Charles Dang): The build failed.
20160820 13:32:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153772189
20160820 13:32:17-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 13:46:19-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 13:46:20< travis-ci> wesnoth/wesnoth#10479 (master - df5d33f : Charles Dang): The build failed.
20160820 13:46:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153773175
20160820 13:46:20-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 13:55:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160820 13:56:26-!- JyrkiVesterinen [~JyrkiVest@87-100-208-118.bb.dnainternet.fi] has joined #wesnoth-dev
20160820 14:02:24< irker885> wesnoth: Jyrki Vesterinen wesnoth:master 173618b7ec7f / src/tests/gui/test_gui2.cpp: Attempted fix for unit tests failing to compile https://github.com/wesnoth/wesnoth/commit/173618b7ec7f0a80471031cd3c02cafe3ed463a0
20160820 14:03:04< zookeeper> Jetrel_bot, https://forums.wesnoth.org/viewtopic.php?p=600855#p600855
20160820 14:03:43< Jetrel_bot> zookeeper:  thanks
20160820 14:08:30-!- fabi [~fabi@176.0.124.156] has joined #wesnoth-dev
20160820 14:08:42-!- fabi__ [~fabi@176.4.53.65] has quit [Read error: Connection reset by peer]
20160820 14:08:56-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 14:08:57< travis-ci> wesnoth/wesnoth#10480 (master - 71d1585 : Charles Dang): The build is still failing.
20160820 14:08:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153776259
20160820 14:08:57-!- travis-ci [~travis-ci@ec2-54-211-216-191.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 14:21:26-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:1cae:d165:785:cbc3] has joined #wesnoth-dev
20160820 14:25:56-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:1cae:d165:785:cbc3] has quit [Ping timeout: 250 seconds]
20160820 14:31:59-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:1cae:d165:785:cbc3] has joined #wesnoth-dev
20160820 14:32:15-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160820 14:32:15-!- Bonobo [~Bonobo@2001:44b8:254:3200:c43c:2c44:8c53:7c77] has quit [Ping timeout: 264 seconds]
20160820 14:36:46-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:1cae:d165:785:cbc3] has quit [Ping timeout: 250 seconds]
20160820 14:39:39-!- travis-ci [~travis-ci@ec2-54-145-247-115.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 14:39:40< travis-ci> wesnoth/wesnoth#10481 (master - 173618b : Jyrki Vesterinen): The build is still failing.
20160820 14:39:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153790028
20160820 14:39:40-!- travis-ci [~travis-ci@ec2-54-145-247-115.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 14:41:44< JyrkiVesterinen> Now the tests compile, but they crash...
20160820 14:41:46< JyrkiVesterinen> unknown location(0): fatal error in "test_gui2": memory access violation at address: 0x00000000: no mapping at fault address
20160820 14:41:46< JyrkiVesterinen> src/tests/gui/test_gui2.cpp(170): last checkpoint
20160820 14:43:26< vultraz> o_O
20160820 14:43:30< vultraz> I've never seen that address
20160820 14:59:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160820 14:59:38-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:706e:6e43:dd07:2c46] has joined #wesnoth-dev
20160820 14:59:51-!- mjs-de [~mjs-de@x4e3051be.dyn.telefonica.de] has joined #wesnoth-dev
20160820 15:00:11-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:706e:6e43:dd07:2c46] has quit [Remote host closed the connection]
20160820 15:14:00-!- Kwandulin [~Miranda@p200300760F35BF19D1531F38715B5ED0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160820 15:15:51-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160820 15:18:04-!- hk238 [~kvirc@t224.ip7.netikka.fi] has joined #wesnoth-dev
20160820 15:19:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20160820 15:19:53-!- wedge010 is now known as wedge009
20160820 15:24:14< irker885> wesnoth: Charles Dang wesnoth:master e2631f5322f0 / / (3 files in 2 dirs): MP Create: bunch of bug fixes and QoL improvements https://github.com/wesnoth/wesnoth/commit/e2631f5322f0a8e933586badfddfb192e5c17b58
20160820 15:24:32< vultraz> celtiminstrel: I took your suggestion and moved the filter box. turns out it's actually a good idea since it forces a minimum size for the listbox
20160820 15:24:59< vultraz> celticminstrel: anyway, see my comment in the header file
20160820 15:36:21-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160820 15:54:15-!- Kwandulin [~Miranda@p200300760F35BF19440862D3A308BEC0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 15:59:31-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160820 16:00:08-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 16:00:09< travis-ci> wesnoth/wesnoth#10482 (master - e2631f5 : Charles Dang): The build is still failing.
20160820 16:00:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153800009
20160820 16:00:09-!- travis-ci [~travis-ci@ec2-54-80-229-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 16:08:20< celticminstrel> That gamestate inspector diff is pretty difficult to understand.
20160820 16:08:27< vultraz> it is
20160820 16:08:32< vultraz> just look at it in-game
20160820 16:09:16< celticminstrel> BTW, is the MVC easier to understand now?
20160820 16:09:24< vultraz> MVC is never easy to understand for me :)
20160820 16:09:38< celticminstrel> Nor for me, but compared to before?
20160820 16:10:02< vultraz> i couldn't say
20160820 16:11:44< celticminstrel> Oh, I just thought of something I could do.
20160820 16:11:57< celticminstrel> Your password is currently saved in plaintext in the preferences, as I recall.
20160820 16:12:08< celticminstrel> At least, that's what it tells you in the login screen.
20160820 16:13:08< celticminstrel> Tangentially: Do you think it's silly to make another (dummy) forum account in order to reserve my nickname on the MP server?
20160820 16:14:02< vultraz> rather, yes
20160820 16:14:26< celticminstrel> So is there a better way to do it?
20160820 16:15:44< vultraz> not as of now
20160820 16:16:04< celticminstrel> So should I make a dummy account then?
20160820 16:16:17< celticminstrel> Why did you remove all the options from the random_faction_node combobox?
20160820 16:17:00< vultraz> [02:24:57]	vultraz	celticminstrel: anyway, see my comment in the header file
20160820 16:17:06< celticminstrel> ???
20160820 16:17:15< vultraz> wait
20160820 16:17:20< vultraz> what are we talking about?
20160820 16:17:27< celticminstrel> MP Create
20160820 16:17:35< vultraz> inspect or create?
20160820 16:17:36< vultraz> oh
20160820 16:17:42< vultraz> I didn't
20160820 16:17:47< vultraz> I added them from wml
20160820 16:17:55< vultraz> wjkhfjk
20160820 16:17:56< vultraz> c++
20160820 16:18:03< vultraz> and I added a long comment in the header explaining why
20160820 16:18:33< celticminstrel> wedge009: Do you know what exactly triggered that assert?
20160820 16:18:40< celticminstrel> vultraz: Ah, okay.
20160820 16:18:54< vultraz> celticminstrel: would appreciate if you gave your thoughts on the reasoning
20160820 16:19:02< celticminstrel> Will do when I get there.
20160820 16:20:36< celticminstrel> Why the heck did you add a config attribute_value constructor in MP Create...
20160820 16:21:15< vultraz> I did not :|
20160820 16:21:20< vultraz> I moved it up the file
20160820 16:21:24< vultraz> it was there before
20160820 16:21:27< celticminstrel> Ah.
20160820 16:21:28< vultraz> gfgtdf added it
20160820 16:21:39< celticminstrel> The question still stands, anyway.
20160820 16:21:49< vultraz> dunno why it's needed
20160820 16:22:05< celticminstrel> Probably isn't.
20160820 16:22:09< celticminstrel> I dunno though.
20160820 16:22:37< zookeeper> i don't think it's silly to reserve a different MP name if it's really the one you're going to primarily be using there.
20160820 16:23:26< celticminstrel> So you think I should create a dummy forum account then?
20160820 16:23:37< celticminstrel> In order to reserve it, I mean.
20160820 16:23:53< zookeeper> no, but i don't think it's silly if you do :p
20160820 16:24:20< celticminstrel> So you think I shouldn't, or you have no opinion on it?
20160820 16:25:24< zookeeper> i have no opinion on whether you should do it, correct
20160820 16:25:28< zookeeper> that depends on what you want to do
20160820 16:29:07 * vultraz waits patiently
20160820 16:30:09< celticminstrel> What? Were you waiting for me to comment on your comment?
20160820 16:30:17< vultraz> yes
20160820 16:30:29< celticminstrel> Uh, I didn't really have anything to say. It kinda makes sense.
20160820 16:30:45< vultraz> then you approve?
20160820 16:31:01< celticminstrel> Sure?
20160820 16:31:15< vultraz> ok
20160820 16:31:25< vultraz> and you approve of the placement of the filters above the list?
20160820 16:31:51< celticminstrel> Of course.
20160820 16:32:14< vultraz> OK
20160820 16:34:51< vultraz> I didn't know c++ had a 'register' keyword
20160820 16:35:01< celticminstrel> Yup.
20160820 16:35:14< celticminstrel> It's a storage specifier, like "static".
20160820 16:35:31< celticminstrel> It means the variable is allocated on the stack.
20160820 16:35:40< celticminstrel> Since that's the default anyway, you never need to use it.
20160820 16:35:53< celticminstrel> (I assume it's not allowed in a class or global context.)
20160820 16:36:32< JyrkiVesterinen> The register specifier is deprecated. It will be removed in C++17.
20160820 16:36:45< celticminstrel> Ah, really?
20160820 16:37:01< JyrkiVesterinen> And it's not too useful anyway. Compilers can make a better job at deciding which variables to store in registers.
20160820 16:37:04< celticminstrel> Is it used in the Wesnoth source? If it is we should purge all uses.
20160820 16:37:09< JyrkiVesterinen> See here: http://en.cppreference.com/w/cpp/language/storage_duration
20160820 16:37:12< shadowm> > stack
20160820 16:37:27< shadowm> The default storage (local) uses the stack.
20160820 16:37:50< shadowm> `register` is supposed to tell the compiler to prefer CPU registers if possible.
20160820 16:37:51< celticminstrel> The register keyword doesn't mean that anyway since C++11, as I recall - it replaced the old meaning of the auto keyword.
20160820 16:38:16< vultraz> it is not used in wesnoth
20160820 16:38:20< celticminstrel> Yah.
20160820 16:38:22< celticminstrel> ^Yay
20160820 16:39:11< shadowm> s/local/automatic/
20160820 16:42:06< vultraz> should markup be enabled for the description area in mp create?
20160820 16:42:26< celticminstrel> Did the GUI1 version support markup?
20160820 16:42:29< vultraz> it's not in gui1, but that breaks sp campaign descriptions with markup
20160820 16:42:47< celticminstrel> Well, we don't really need to support SP campaign descriptions.
20160820 16:43:04< celticminstrel> That said... if SP campaign descriptions support markup, it makes sense for MP scenario descriptions to support it too...
20160820 16:44:50< irker885> wesnoth: Charles Dang wesnoth:master 75c5bea5819f / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): MP Create: indicate if no description is available https://github.com/wesnoth/wesnoth/commit/75c5bea5819f90b86684744e3d896fd42d518dd0
20160820 16:45:49< vultraz> honestly, i might even have room for the chat box if i were widget-ized
20160820 16:46:16< celticminstrel> A vultraz widget? Good idea! :P
20160820 16:46:23< vultraz> er... :P
20160820 16:46:24< vultraz> it*
20160820 16:48:42< vultraz> btw, do you approve of my inspector changes?
20160820 16:48:51-!- Greg-Boggs [~greg_bogg@70.42.240.24] has joined #wesnoth-dev
20160820 16:48:51< celticminstrel> Compiling, so haven't seen yet.
20160820 16:48:56< vultraz> ah
20160820 16:48:58< vultraz> fyi
20160820 16:48:59< celticminstrel> Someone made changes that affect the server.
20160820 16:49:02< vultraz> we have a text_alignment key
20160820 16:49:05< vultraz> just saying
20160820 16:49:09< celticminstrel> Hm?
20160820 16:49:48< vultraz> you don't necessarily have to align a widget to the right to make it sit on the right :)
20160820 16:49:57< vultraz> a/widget/label
20160820 16:50:11< celticminstrel> Oh! The page count, right?
20160820 16:50:22< vultraz> yes
20160820 16:50:26< vultraz> but I moved it anyway, so
20160820 16:50:39< vultraz> irreverent now
20160820 16:50:40-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160820 16:50:42< vultraz> but keep it in mind
20160820 16:51:11< celticminstrel> Irreverent, huh.
20160820 16:51:14< celticminstrel> :P
20160820 16:51:16< vultraz> RKLJIOJOIEJR@J#()RU@()#U()U@()
20160820 16:51:31< vultraz> IRRELEVANT 
20160820 16:55:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160820 17:07:10-!- Greg-Boggs [~greg_bogg@70.42.240.24] has quit [Remote host closed the connection]
20160820 17:08:13-!- Greg-Boggs [~greg_bogg@70.42.240.24] has joined #wesnoth-dev
20160820 17:20:39-!- travis-ci [~travis-ci@ec2-107-21-165-7.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 17:20:40< travis-ci> wesnoth/wesnoth#10483 (master - 75c5bea : Charles Dang): The build is still failing.
20160820 17:20:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153811349
20160820 17:20:40-!- travis-ci [~travis-ci@ec2-107-21-165-7.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 17:31:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160820 17:31:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160820 17:38:37-!- Greg-Boggs [~greg_bogg@70.42.240.24] has quit [Remote host closed the connection]
20160820 17:39:17-!- Greg-Boggs [~greg_bogg@70.42.240.24] has joined #wesnoth-dev
20160820 17:42:18-!- Greg-Boggs [~greg_bogg@70.42.240.24] has quit [Remote host closed the connection]
20160820 17:43:52-!- Greg-Boggs [~greg_bogg@70.42.240.24] has joined #wesnoth-dev
20160820 17:44:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160820 17:50:47-!- DeFender1031 [~DeFender1@46-116-114-128.bb.netvision.net.il] has joined #wesnoth-dev
20160820 17:54:11< celticminstrel> Line 592 of events.cpp.
20160820 17:54:23< celticminstrel> Did vultraz ignore that comment and change that to a range-for?
20160820 17:54:32< vultraz> what?
20160820 17:54:41< celticminstrel> It says there's some reason not to use iterators there.
20160820 17:54:47< celticminstrel> But it's clearly using iterators.
20160820 17:55:00< vultraz> uh..
20160820 17:55:02< celticminstrel> (Range-for implicitly uses iterators.)
20160820 17:55:29< vultraz> was that me?
20160820 17:55:34< celticminstrel> Didn't you go through and convert many things to range-for? Or did we decide not to do that?
20160820 17:55:41< vultraz> I didn't do that..
20160820 17:55:47< celticminstrel> I see.
20160820 17:55:52< celticminstrel> I dunno if it was you then.
20160820 17:56:01< celticminstrel> Just happened to notice it while debugging here.
20160820 17:56:26< vultraz> any comment on the inspector design changes?
20160820 17:56:32< celticminstrel> Not yet.
20160820 17:56:46< celticminstrel> Got distracted by something else, sorry.
20160820 17:57:38< celticminstrel> Why do all these event handlers have a null handle_event method?
20160820 17:58:26< celticminstrel> video_event_handler (video.hpp), music_muter (sound.hpp), prefs_event_handler (preferences.cpp)
20160820 17:58:37< celticminstrel> Their handle_event functions do nothing.
20160820 17:59:01< celticminstrel> Is handle_window_event called separately?
20160820 17:59:38< vultraz> I don't know
20160820 18:02:09-!- Greg-Boggs [~greg_bogg@70.42.240.24] has quit [Remote host closed the connection]
20160820 18:03:37< celticminstrel> I don't know why, but the login dialog is unusable.
20160820 18:03:42< vultraz> what?
20160820 18:03:55< celticminstrel> It won't respond to input.
20160820 18:04:23< vultraz> huh
20160820 18:04:43< vultraz> this is rather ridiculous... the minimap images are scaled down.. then up
20160820 18:05:24-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160820 18:05:43< vultraz> ah, I think I see why
20160820 18:05:45< vultraz> performance
20160820 18:05:54< vultraz> since this is all sw 
20160820 18:05:57< vultraz> *rolls eyes*
20160820 18:06:32< vultraz> let's triple the working scale
20160820 18:06:43< vultraz> see how that works
20160820 18:08:00-!- hk238 [~kvirc@t224.ip7.netikka.fi] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160820 18:08:54< vultraz> this seems acceptable
20160820 18:11:23< JyrkiVesterinen> celticminstrel: Regarding the comment not to use iterators in events.cpp, it's outdated.
20160820 18:11:34< celticminstrel> I see.
20160820 18:11:42< JyrkiVesterinen> Std::list iterators remain valid when the list is modified, so iterating is safe.
20160820 18:11:51< celticminstrel> So that's why the comment was there, okay.
20160820 18:12:08< vultraz> ah, right
20160820 18:12:12< JyrkiVesterinen> (Unless an event handler removes itself, because removing an item still invalidates the iterator to the said event.)
20160820 18:12:15< vultraz> that was the whole reason of making it a list :P
20160820 18:13:08< JyrkiVesterinen> Regarding the empty implementations of handle_event, handle_event and handle_window_event are both pure virtual functions and all implementations of sdl_handler must provide both functions.
20160820 18:13:41< JyrkiVesterinen> Those event handlers (in particular, I created music_muter) have no need for handle_event but still need handle_window_event.
20160820 18:14:24< celticminstrel> So it is called separately, okay.
20160820 18:19:04< irker885> wesnoth: Charles Dang wesnoth:master 41c3e028f182 / src/minimap.cpp: Increase minimap detail https://github.com/wesnoth/wesnoth/commit/41c3e028f1823f5106a55cd6b8082a11e0557363
20160820 18:19:33< vultraz> Yay for small-sized maps no longer having minimaps that look like absolute shit! :D
20160820 18:23:39< vultraz> Before: https://drive.google.com/file/d/0B-mR9s8FduLLZ091Ny16dU5Iems/view?usp=sharing
20160820 18:23:58< vultraz> After: https://drive.google.com/file/d/0B-mR9s8FduLLc0FpNHpTU09ZaVU/view?usp=sharing
20160820 18:24:09< vultraz> talk about the difference of one line
20160820 18:24:19< vultraz> nay, one number
20160820 18:25:11-!- Kwandulin [~Miranda@p200300760F35BF19440862D3A308BEC0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160820 18:25:34< zookeeper> any chance you could make the minimap also draw the half-hexes? that's fix the terribly ugly border jaggies.
20160820 18:26:52< vultraz> I'll take a look, but no promises
20160820 18:37:17< celticminstrel> Aw, '•' is not a char.
20160820 18:38:04< vultraz> that kinda makes sense?
20160820 18:39:06< celticminstrel> Why does it make sense?
20160820 18:39:42< vultraz> eh.. I thought perhaps it had something to do with its utf8 id
20160820 18:39:50< celticminstrel> Probably.
20160820 18:40:02< celticminstrel> BTW, utf8 id is not a thing, I think.
20160820 18:40:16< vultraz> whatever you call "U+2022"
20160820 18:40:39< JyrkiVesterinen> Char is an 8-bit datatype and can only really represent ASCII characters.
20160820 18:40:42< celticminstrel> Somehow I thought • was in the "extended ascii" range.
20160820 18:41:04< JyrkiVesterinen> The bullet character requires three bytes to express in UTF-8.
20160820 18:41:05< JyrkiVesterinen> http://unicode-table.com/en/2022/
20160820 18:41:49< vultraz> anyway, why are you asking about dots?
20160820 18:42:17< celticminstrel> I'm rewriting the password widget.
20160820 18:42:23< JyrkiVesterinen> A C++11 UTF-8 string literal would probably work. Something like: u8'•'
20160820 18:42:36< JyrkiVesterinen> But, they're not supported by MSVC2013. :(
20160820 18:42:41< celticminstrel> That would require using C++11 UTF-8 strings, too.
20160820 18:42:48< celticminstrel> But it's just using regular strings.
20160820 18:43:08< celticminstrel> As far as I know, my compiler doesn't support the extended strings either, though I've never actually tried.
20160820 18:43:17< vultraz> and is there a reason you can't use a string?
20160820 18:43:28< celticminstrel> I wanted to use the string fill constructor.
20160820 18:43:37< celticminstrel> But I can't for this purpose.
20160820 18:46:07< celticminstrel> I have to use a string in any case, the difficulty was just in constructing the string when it's more than one character (for pasting).
20160820 18:46:41-!- Sirp [~Sirp@u17402953.onlinehome-server.com] has joined #wesnoth-dev
20160820 18:56:35-!- travis-ci [~travis-ci@ec2-107-21-165-7.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 18:56:36< travis-ci> wesnoth/wesnoth#10484 (master - 41c3e02 : Charles Dang): The build is still failing.
20160820 18:56:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153824484
20160820 18:56:36-!- travis-ci [~travis-ci@ec2-107-21-165-7.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 19:11:21< vultraz> zookeeper: can you commit doofus's floor transitions?
20160820 19:12:14-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160820 19:12:29< celmin> Anyone think it's a good idea to support password managers in Wesnoth?
20160820 19:16:16< midzer> celmin: there are already good password managers which are standalone
20160820 19:16:55< celmin> How does that work?
20160820 19:18:42< midzer> i suggest you read https://en.wikipedia.org/wiki/Password_manager for example
20160820 19:23:48< celmin> Also, can anyone else confirm login dialog problems?
20160820 19:28:00< celmin> That page doesn't help.
20160820 19:38:14< vultraz> dialog seems fine for me
20160820 19:43:06< vultraz> huh, one can indeed pass a bool as a int argument
20160820 19:53:06< celmin> Duh
20160820 19:57:10-!- JyrkiVesterinen [~JyrkiVest@87-100-208-118.bb.dnainternet.fi] has quit [Quit: .]
20160820 19:57:28< Aginor_> celmin: what do you mean by "supporting password managers"?
20160820 19:57:33-!- Aginor_ is now known as Aginor
20160820 19:57:45-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20160820 19:57:45-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20160820 20:00:40< celmin> Aginor: Interfacing with a password manager to store server passwords, instead of storing them in plaintext in the preferences file.
20160820 20:02:17< celmin> In particular the OSX keychain.
20160820 20:08:11< celmin> vultraz: When you say it works, you mean you can type in a password and continue, right?
20160820 20:08:20< celmin> And no performance issues?
20160820 20:15:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160820 20:30:25< celmin> Anyone else?
20160820 20:32:21< fabi> hi
20160820 20:32:45< celmin> When I go into the debugger, it seems to be in a loop of handling draw events .
20160820 20:33:05< celmin> It doesn't seem to even be receiving the mouse and keyboard events.
20160820 20:35:15-!- Appleman1234 [~Appleman1@KD036012024020.au-net.ne.jp] has quit [Ping timeout: 264 seconds]
20160820 20:42:08-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160820 20:43:47< celmin> It really seems to be flooded with draw events...
20160820 20:46:36< celmin> I have a breakpoint on the switch in events::pump, and I've been pressing continue over and over and still the only event that comes out is a draw event (event.type == 0x8003).
20160820 20:55:36< celmin> Aginor, Jyrki: It works with this patch, but feels hacky. http://pastebin.com/DWB9KML4
20160820 20:56:00< celmin> I can commit it anyway if you want, though.
20160820 20:58:01< celmin> (I'd think a better solution would be to not post so many draw events in the first place.)
20160820 20:58:55< Aginor> celmin: a draw_event is raised by a timer
20160820 20:59:09< Aginor> I think it's every 12 ms or somesuch
20160820 21:00:31< Aginor> celmin: I don't like that patch, it's fixing the problem in the wrong place :/
20160820 21:00:57< Aginor> the draw events should be handled by the UI, at the appropriate time
20160820 21:01:16< celmin> Yeah.
20160820 21:01:30< celmin> I won't commit that then.
20160820 21:01:45< celmin> I'll just leave it in for now though so I can make the password box work again.
20160820 21:01:51< Aginor> hmm
20160820 21:01:52< Aginor> ok
20160820 21:02:07< Aginor> it's most likely the password box being broken instead ;)
20160820 21:02:18< celmin> Could be, I suppose...
20160820 21:03:45 * Aginor shrugs
20160820 21:04:04< Aginor> maybe I should carve off some time and do a fresh start on my rendering branch
20160820 21:04:33< celmin> The old version was setting the text box's text to the password, then setting it to a string of stars… thus laying out text that would never be rendered.
20160820 21:04:51< Aginor> that's not ideal
20160820 21:05:05< celmin> Yeah, that's why I decided to redo it.
20160820 21:05:20< celmin> I thought that might be the cause of the performance issue.
20160820 21:05:29< celmin> But changing that doesn't seem to have helped.
20160820 21:05:39< Aginor> what performance issue?
20160820 21:05:59< celmin> The one I've been mentioning, where the login box doesn't respond to input.
20160820 21:06:16< celmin> Or responds very slowly, if at all.
20160820 21:06:30< Aginor> ah
20160820 21:06:47< Aginor> because you think it's busy rendering instead of processing other events?
20160820 21:06:53< Aginor> is it gui2?
20160820 21:06:57< celmin> It is.
20160820 21:07:40< celmin> The timer adding a draw event wouldn't add more than one if more than the specified time had elapsed, would it?
20160820 21:07:49< Aginor> no
20160820 21:08:05< Aginor> but if a draw cycle takes longer than the timer interval, you're in for fun
20160820 21:08:27< Aginor> I don't think it checks to see if there's already an event in the queue before enqueing
20160820 21:08:36< celmin> That's pretty much a guaranteed state if you've entered the debugger though.
20160820 21:09:13< Aginor> yeah
20160820 21:09:35< Aginor> I'd go look for SDL_Timer in the gui2 tree and have a look there to see what it does
20160820 21:09:59< celmin> Okay.
20160820 21:10:13 * Aginor is about to disappear
20160820 21:14:29< Aginor> celmin: you might also want to have a look at what I was doing in renderpath_redo, it might be relevant
20160820 21:14:40< Aginor> but most likely not for your immediate needs
20160820 21:19:10-!- irker885 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160820 21:19:18-!- Appleman1234 [~Appleman1@KD036012024020.au-net.ne.jp] has joined #wesnoth-dev
20160820 21:42:45-!- mjs-de [~mjs-de@x4e3051be.dyn.telefonica.de] has quit [Remote host closed the connection]
20160820 21:44:03-!- Appleman1234 [~Appleman1@KD036012024020.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160820 21:47:27-!- Appleman1234 [~Appleman1@KD036012029168.au-net.ne.jp] has joined #wesnoth-dev
20160820 21:49:14< celmin> vultraz: Not sure whether I like the inspector always having bullet points, though admittedly it does help a little with distinguishing boundaries between items (mainly for events with an ID). That aside, the changes look fine to me.
20160820 21:58:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160820 22:03:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Ping timeout: 252 seconds]
20160820 22:03:37-!- Appleman1234 [~Appleman1@KD036012029168.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20160820 22:03:38-!- coproduit [~coproduit@hott.coq.sexy] has quit [Ping timeout: 252 seconds]
20160820 22:03:39-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 252 seconds]
20160820 22:04:04-!- coproduit [~coproduit@hott.coq.sexy] has joined #wesnoth-dev
20160820 22:07:52-!- midzer [~quassel@p5B296F88.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160820 22:08:15-!- midzer [~quassel@p57B4536C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160820 22:08:41-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20160820 22:24:58-!- Appleman1234 [~Appleman1@KD036012029168.au-net.ne.jp] has joined #wesnoth-dev
20160820 22:25:09< wedge009> vultraz: Experimental MP looks like what you've shown before. Was there anything specific you wanted me to look into? Is it ready for testing - maybe I'll recheck those old bug reports on the experimental lobby?
20160820 22:26:09< wedge009> celmin: Not at all. ): I rebuilt everything under src/gui/ and am still getting the error in my Windows build. Presumably you're not getting this issue? When I tested in Linux it seems fine.
20160820 22:29:24< celmin> wedge009: The issue was an assert somewhere?
20160820 22:30:04< celmin> wedge009: Also, you're aware that experimental MP create and experimental lobby are different things, right?
20160820 22:30:21< wedge009> celmin: It always complains about line 122 of gui/widgets/tree_view_node.cpp
20160820 22:30:50< wedge009> No? vultraz told me the new MP interface is the experimental lobby... :S
20160820 22:33:10< wedge009> 2016-08-16 11:27:35 UTC - vultraz: wedge009: it IS the experimental lobby :P
20160820 22:34:48< celmin> wedge009: Can you open the inspector at all, or does the assertion trigger on merely attempting to do so?
20160820 22:36:02< wedge009> Can't open at all:
20160820 22:36:02< wedge009> 1. Type debug
20160820 22:36:02< wedge009> 2. Type inspect
20160820 22:36:02< wedge009> 3. Assertion failure on tree_view_node.cpp:122 (error message as printed earlier)
20160820 22:36:02< wedge009> 4. Thrown back to the main menu.
20160820 22:36:18< wedge009> Compiling debug mode now.
20160820 22:40:27< celmin> The commit I just pushed should make it give a slightly better error message.
20160820 22:41:00< celmin> Could also be helpful to have a stack trace.
20160820 22:41:13-!- Duthlet [~Duthlet@dslb-188-104-254-170.188.104.pools.vodafone-ip.de] has quit [Quit: leaving]
20160820 22:41:15< celmin> Though I guess it's an exception, so that's nontrivial.
20160820 22:41:26< celmin> If you set a breakpoint in the wml_exception function though...
20160820 22:41:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160820 22:42:05< wedge009> Still compiling. Which function is that?
20160820 22:42:12< celmin> Uhh...
20160820 22:43:00< celmin> Seems to be defined in src/wml_exception.cpp on lines 33 and 92.
20160820 22:43:24< celmin> That's the function that handles showing this error and dumping you to the menu.
20160820 22:43:32< celmin> Or something like that.
20160820 22:44:01< wedge009> Oh, okay. I already had the breakpoint on the VALIDATE macro.
20160820 22:44:33< celmin> Ah, well, that would also work, of course.
20160820 22:44:55< celmin> Basically either a stack trace or knowledge of the value of the id variable would be helpful.
20160820 22:45:59< wedge009> Heh. Now the whole game crashes when attempting to inspect. XD
20160820 22:46:12< celmin> Eh?
20160820 22:46:33< wedge009> Just tried the release mode to see what the error message would be and I get a crash.
20160820 22:50:30 * wedge009 is confuzzled
20160820 22:50:46< wedge009> Debug mode doesn't trigger the breakpoint but the same error message is given.
20160820 22:51:16< celmin> Huh.
20160820 22:51:51< wedge009> Breaking at the actual wml_exception() function...
20160820 22:51:51< celmin> If it's called from somewhere else, a breakpoint in wml_exception should work, though I'd doubt that error message is triggered in more than one place...
20160820 22:52:42< celmin> Unless you're experiencing the sort of problem I sometimes get, where some functions are unknown to the debugger.
20160820 22:52:45< wedge009> I wonder if there's anyone else with Windows who can confirm this because I seem to be the only one at the moment.
20160820 22:53:22< celmin> For Windows, I think there's Jyrki and gfgtdf. Also zookeeper maybe.
20160820 22:53:47< celmin> Also vultraz, but he's not using MSVC.
20160820 22:54:01< wedge009> Oh I see, I hadn't rebuilt debug mode with the last change you just mentioned.
20160820 22:54:44< celmin> Not sure if just adding the id as the dev message is good, maybe there should be some formatter() stuff there.
20160820 23:02:34< wedge009> The crash seems to be from dev_message not being defined (or at least it looks like gibberish in the debugger).
20160820 23:03:02< wedge009> >	wesnoth.exe!wml_exception(const char * cond, const char * file, int line, const char * function, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & message, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & dev_message) Line 51	C++
20160820 23:03:02< wedge009>  	wesnoth.exe!gui2::ttree_view_node::ttree_view_node(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & id, const std::vector<gui2::implementation::ttree_node,std::allocator<gui2::implementation::ttree_node> > & node_definitions, gui2::ttree_view_node * parent_node, gui2::ttree_view & parent_tree_view, const std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char>
20160820 23:03:02< wedge009> >,std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,t_string,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,t_string> > >,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<cha
20160820 23:03:02< wedge009> ,std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,t_string,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,t_string> > > > > > & data) Line 122	C++
20160820 23:03:02< wedge009>  	wesnoth.exe!gui2::ttree_view_node::add_child(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & id, const std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,t_string,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::c
20160820 23:03:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Excess Flood]
20160820 23:03:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160820 23:03:18< wedge009> Uh, okay.
20160820 23:03:27< wedge009> >	wesnoth.exe!wml_exception(const char * cond, const char * file, int line, const char * function, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & message, const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & dev_message) Line 51	C++
20160820 23:03:35< wedge009>  	wesnoth.exe!gui2::ttree_view_node::ttree_view_node(const std::basic_string<char,std::char_traits<char>,std::allocator<char> > & id, const std::vector<gui2::implementation::ttree_node,std::allocator<gui2::implementation::ttree_node> > & node_definitions, gui2::ttree_view_node * parent_node, gui2::ttree_view & parent_tree_view, const std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char>
20160820 23:03:35< wedge009> >,std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,t_string,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,t_string> > >,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<cha
20160820 23:03:35< wedge009> ,std::map<std::basic_string<char,std::char_traits<char>,std::allocator<char> >,t_string,std::less<std::basic_string<char,std::char_traits<char>,std::allocator<char> > >,std::allocator<std::pair<std::basic_string<char,std::char_traits<char>,std::allocator<char> > const ,t_string> > > > > > & data) Line 122	C++
20160820 23:03:37< celmin> Whia.
20160820 23:04:01< wedge009> Hmm.
20160820 23:04:33< celmin> ^Whoa
20160820 23:04:43< celmin> Might help if you pastebin that.
20160820 23:04:57< celmin> So anyway...
20160820 23:05:10< celmin> You're saying the value of dev_message is gibberish?
20160820 23:06:51< wedge009> https://gna.org/bugs/?25000
20160820 23:07:44< wedge009> Looks like the id is no good?
20160820 23:07:56< celmin> Yeah, I guess?
20160820 23:08:01< wedge009> ttree_view_node::add_child() line 151.
20160820 23:08:20< wedge009> id is given as "\f\n \x1¼Î8"
20160820 23:09:28< wedge009> Nice name. stuff_list_adder o.o
20160820 23:09:55< celmin> What?
20160820 23:10:11< celmin> That was me.
20160820 23:10:38< celmin> So, ID should be "basic".
20160820 23:11:03< wedge009> Just not immediately obvious what 'stuff' is.
20160820 23:11:22< wedge009> Looks like it's line 163 of gamestate_inspector.cpp.
20160820 23:11:26< celmin> Well, "stuff_list" is a remnant from the previous version of the inspector.
20160820 23:11:36< wedge009> defn_ is gibberish.
20160820 23:11:43< wedge009> "\f\n \x1¼Î8"
20160820 23:12:04< wedge009> I'll try to see what defn_ is when it's constructed.
20160820 23:12:09< celmin> Maybe the reference expired earlier than it should have.
20160820 23:12:13< wedge009> When stuff_list_adder is constructed.
20160820 23:12:20< celmin> Line 447 then
20160820 23:12:36< celmin> Or I guess the definition of stuff_list_entry...
20160820 23:12:45< celmin> Wherever that was.
20160820 23:13:50-!- travis-ci [~travis-ci@ec2-107-21-165-7.compute-1.amazonaws.com] has joined #wesnoth-dev
20160820 23:13:51< travis-ci> wesnoth/wesnoth#10485 (master - d110790 : Celtic Minstrel): The build is still failing.
20160820 23:13:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/153856501
20160820 23:13:51-!- travis-ci [~travis-ci@ec2-107-21-165-7.compute-1.amazonaws.com] has left #wesnoth-dev []
20160820 23:14:29< wedge009> Yeah, it seems to be constructed as 'basic'.
20160820 23:16:30< wedge009> Isn't defn_ defined as a reference, not a copy of the string object?
20160820 23:17:20< wedge009> Line 176 of gamestate_inspector.cpp
20160820 23:17:45< celmin> Yeah.
20160820 23:18:04< celmin> I think making a copy instead should fix it.
20160820 23:20:02< wedge009> Yep, it looks like it's all around Line 446 of gamestate_inspector.cpp as you said. I just stepped through everything, it constructs defn_ as 'basic', but when it goes to add the entry defn_ is no longer defined.
20160820 23:20:44< celmin> There seems to be a null pointer access in the GUI somewhere, judging from that test failure...
20160820 23:21:55< celmin> Not sure whether that's the same issue, or something in MP Create.
20160820 23:23:21< wedge009> celmin: Just gave it a test, seems okay now. Shall I push the correction?
20160820 23:23:26< celmin> Sure.
20160820 23:26:28< wedge009> Looks like someone killed irker.
20160820 23:26:36< wedge009> Or at least shut it up.
20160820 23:30:13< celmin> Yeah
20160820 23:31:05< celmin> New inspector design look good?
20160820 23:31:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20160820 23:31:32< wedge009> I don't use it much, but it seems okay to me.
20160820 23:32:43< wedge009> I suppose it's more intuitive to have the child items as part of the main selection.
20160820 23:42:28-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18fb:11ca:235d:dfd] has joined #wesnoth-dev
20160820 23:47:05-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:18fb:11ca:235d:dfd] has quit [Ping timeout: 250 seconds]
--- Log closed Sun Aug 21 00:00:22 2016