--- Log opened Mon Aug 22 00:00:08 2016
20160822 00:25:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160822 01:00:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160822 01:06:32-!- Appleman1234 [~Appleman1@KD036012021144.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20160822 01:51:09-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:c413:b1fc:374b:83d8] has joined #wesnoth-dev
20160822 02:08:15-!- Appleman1234 [~Appleman1@KD036012021144.au-net.ne.jp] has joined #wesnoth-dev
20160822 02:11:28< vultraz> celticminstrel: idea, I have
20160822 02:11:48< vultraz> perhaps I shall take your advise of a 'data' map.
20160822 02:11:58< vultraz> advice 
20160822 02:13:00< vultraz> celticminstrel: what I was thinking was the data map won't be cleared unless the Defaults button is uses
20160822 02:13:08< vultraz> it'd be initially empty, though
20160822 02:13:29-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160822 02:14:27< vultraz> so every time you select an option, if there's not a key with the same id in the data node, one is added
20160822 02:14:35< celmin> I don't get it...
20160822 02:14:37< vultraz> and the default= value is used to set the widget
20160822 02:14:45< vultraz> s/node/map
20160822 02:16:01< vultraz> but if data is found, that sets the widget
20160822 02:16:14< vultraz> make sense?
20160822 02:18:24< celmin> Not sure.
20160822 02:18:38< celmin> Theoretically, what would be the type of this map?
20160822 02:19:50< celmin> One thing I recall thinking was that a data map could be used in conjunction with register_field or whatever.
20160822 02:20:51< celmin> (So the data map would be map<option_source, config::attribute_value> instead of map<option_source, function<config::attribute_value()>).
20160822 02:23:06< vultraz> I was considering that
20160822 02:23:29< celmin> Not quite sure if register_field can attach to an attribute_value.
20160822 02:23:51< celmin> …well, the more generic forms probably can, at least.
20160822 02:31:42-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160822 02:32:12-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160822 02:33:25< vultraz>  where is register_field
20160822 02:33:39< celmin> I dunno.
20160822 02:33:47< celmin> It's something to do with tfield?
20160822 02:35:03< vultraz> well you're useful :|
20160822 02:38:45< vultraz> i suppose i could use the specialized field setters
20160822 02:39:23< vultraz> but then again, if the tree node disappears the field becomes invalid
20160822 02:39:26< vultraz> better to find by ID
20160822 02:40:25< vultraz> celmin: for the data map I was just thinking... std::map<std::string, std::vector<config>>
20160822 02:41:23< celmin> I think you misunderstood something.
20160822 02:41:27< celmin> Anyway, what's the string key then?
20160822 02:42:24< vultraz> game id
20160822 02:42:30< celmin> ...eh?
20160822 02:42:41< vultraz> the id argument of display_custom_options
20160822 02:42:55< celmin> Confused. Lemme go look.
20160822 02:42:59< vultraz> (which might be able to be removed, anyway, actually)
20160822 02:44:49< celmin> Eh?
20160822 02:45:20< celmin> Why can it be removed?
20160822 02:45:20< vultraz> cfg["id"] might be able to replace it, I mean
20160822 02:45:41< vultraz> but maybe not, because of mods
20160822 02:46:00< celmin> So why string instead of option_source as the key?
20160822 02:46:32< vultraz> i dunno
20160822 02:46:40< vultraz> no reason, really
20160822 02:46:46< celmin> And what's the contents of the configs in that vector?
20160822 02:47:09< vultraz> the 'cfg' argument
20160822 02:47:31< celmin> Which is?
20160822 02:48:18< celmin> Is that the [option] subtag defining the option?
20160822 02:48:32< celmin> Ah wait, no, that's the entire level.
20160822 02:48:43< celmin> You probably don't want the whole scenario contents stored in your data map. :P
20160822 02:49:00< vultraz> oh
20160822 02:49:02< vultraz> right
20160822 02:49:08< celmin> I think actually a map<option_source, config> would work.
20160822 02:49:16-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:c413:b1fc:374b:83d8] has quit [Remote host closed the connection]
20160822 02:49:17< vultraz> oh, yeah
20160822 02:49:22< celmin> Since that's pretty close to the current visible_options_
20160822 02:49:32< vultraz> I'm gonna assume only one [options] tag is present
20160822 02:49:34-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160822 02:49:46< celmin> You're already not assuming that, is there really any reason to change it?
20160822 02:50:28< vultraz> well, then I'd need to loop over [options] :|
20160822 02:50:33< tad_> Getting sigmentation fault on map editor after a bunch of macro errors on stderr. Gimme a sec to get a backtrace if you need it...
20160822 02:50:33< celmin> But it's already doing that.
20160822 02:50:36< vultraz> instead of just cfg.child["options"]
20160822 02:50:45< celmin> But it's already doing that.
20160822 02:50:48< vultraz> well, yes
20160822 02:51:21< vultraz> so, what
20160822 02:51:37< vultraz> map_data_[id].second.append(option);?
20160822 02:51:39< vultraz> or something?
20160822 02:51:52< celmin> Huh?
20160822 02:52:08< celmin> What's the type of map_data_[id].second?
20160822 02:52:17< vultraz> [13:49:06]	celmin	I think actually a map<option_source, config> would work.
20160822 02:52:21< vultraz> you just said config
20160822 02:52:23< vultraz> :|
20160822 02:52:28< celmin> Config has an append method?
20160822 02:52:34< vultraz> it should..
20160822 02:52:45< vultraz> it does
20160822 02:52:54< celmin> And what's option in that example?
20160822 02:53:01< tad_> Thread 1 "wesnoth" received signal SIGSEGV, Segmentation fault. 0x00000000010c8b49 in display::redraw_everything() ()
20160822 02:53:36< vultraz> celmin: it's the value in the range-for loop that iterates over all [options] tags..
20160822 02:54:14< celmin> I'm completely lost now.
20160822 02:54:21 * vultraz groans
20160822 02:54:42< vultraz> mp_create_game.cpp:437
20160822 02:54:47< vultraz> assuming you pulled
20160822 02:54:48< celmin> Why do you want to store the entire set of option definitions in the data map?
20160822 02:55:10< Aginor> tad_: that looks like something has updated references that the display class doesn't expect to be updated
20160822 02:55:25< celmin> No, sorry, I do understand now what you meant by option in the example. What I'm lost on is the reasoning behind the example, because given that it makes no sense whatsoever to me.
20160822 02:55:36< vultraz> oh
20160822 02:55:37< vultraz> hm
20160822 02:55:39< vultraz> you're right..
20160822 02:55:52< tad_> Just checked: sync'd to current master
20160822 02:56:01< celmin> My thought was that the config stores the current values of the options.
20160822 02:56:08< vultraz> yes...
20160822 02:56:17< vultraz> ok
20160822 02:56:48< celmin> So if there's an option with id=kumquat, then you'll have .second["kumquat"] = option["default"]
20160822 02:56:54< vultraz> maybe we need map<option_source, map<std::string, std::string>>
20160822 02:57:07< celmin> Except not quite, because you only want to do that if !.has_attribute("kumquat")
20160822 02:57:10< vultraz> or that
20160822 02:57:30< vultraz> I guess both examples would be the same in any case
20160822 02:57:49< celmin> Using a map<string,string> means you lose the type information, which may or may not be a problem.
20160822 02:57:57< celmin> For a slider it could be annoying, though.
20160822 02:58:16< vultraz> why
20160822 02:58:25< celmin> Because sliders are logically numeric?
20160822 02:58:39< vultraz> stoi
20160822 02:58:51< celmin> If you use map<string,string> you may need to convert back and forth. If you use config, you don't need to worry about that.
20160822 02:59:01-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160822 02:59:28< celmin> Checkboxes are logically boolean.
20160822 02:59:42< celmin> And gfgtdf probably used attribute_value originally for this reason.
20160822 03:01:02< vultraz> true..
20160822 03:01:11< vultraz> why not map<sting, attribute_value> then?
20160822 03:01:26< celmin> Because you need one attribute_value for each possible option.
20160822 03:01:38< celmin> You could do map<string, map<string, attribute_value>> if you really want.
20160822 03:01:52< celmin> Since you don't need config child tags.
20160822 03:01:57< vultraz> yes that's what I meant
20160822 03:01:59< vultraz> sorry
20160822 03:02:02< celmin> Ah.
20160822 03:02:41-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160822 03:03:50-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160822 03:05:45< tad_> I don't understand this make system, I guess. 9 hours ago a commit appeared I wanted to test if it fixed a problem I'd seen. Pulled/make'd and all was fine. So do some work on a branch, come back to master and check something on a map and poof. So check, sync'd fine, make? Nope doing a make/all and nothing changed. **sigh**
20160822 03:09:10< vultraz> confirmed the crash in the editor 
20160822 03:09:43< tad_> Should I be using separate local copies for each branch instead of using a common local repository for all of 'em?
20160822 03:12:08< celticminstrel> Probably not?
20160822 03:12:13< celticminstrel> Though you can if you want.
20160822 03:12:55< vultraz> tad_: if a branch deviates from another branch and you switch branches, yes, it will cause a large rebuild
20160822 03:15:04< tad_> I try to rebase to master on the ones I'm working on. But still switching back causes a massive rebuild.
20160822 03:15:39< shadowm> Probably because the file timestamps change.
20160822 03:15:51-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160822 03:17:51< shadowm> make at its most basic level just looks at the target file(s), checks if its older than the source file(s), and rebuilds it/them in that case. Frameworks like CMake and GNU autotool add a few other checks on top (like file inclusion chains) but that's about it.
20160822 03:17:57< shadowm> *autotools
20160822 03:18:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160822 03:18:12-!- wedge010 is now known as wedge009
20160822 03:18:47< shadowm> If you want to avoid the full rebuild you could look into using ccache.
20160822 03:19:23< tad_> What is ccache?
20160822 03:20:12-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Remote host closed the connection]
20160822 03:20:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160822 03:21:28< shadowm> It's a wrapper for compilers. It caches the compiler's output for a certain state of a file and its inclusion chain (it checksums the preprocessor output IIRC) so that the generated emited code is used instead of having to build the file again every time.
20160822 03:22:50< shadowm> The recommended way to use it is to make the compiler executables (cc/gcc, c++/g++, cpp) symbolic links to the ccache binary.
20160822 03:23:04< shadowm> Though prepending ccache to the command line works as well.
20160822 03:24:31< shadowm> The SCons recipe has an option that does the latter.
20160822 03:25:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160822 03:25:35< tad_> I could not get scons to work but maybe that's changed.
20160822 03:26:14< tad_> I'll look at the symlink solution. It'll probably break when gcc updates but I'll probably remember it.
20160822 03:26:49< shadowm> I just keep the symbolic links in $HOME/bin and make sure that goes first in $PATH.
20160822 03:28:25< tad_> That would do it.
20160822 03:30:32-!- Appleman1234 [~Appleman1@KD036012021144.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160822 03:32:33< tad_> Well, I guess I'll forget about the map question and fiddle with ccache while voltraz works on the crash.
20160822 03:41:05< tad_> that was painless
20160822 03:51:47< tad_> turns out 1.12.6 map editor works for what I needed to know .. which is that I need to speak to zookeeper about what he's doing ..
20160822 03:52:15< vultraz> what did you need?
20160822 03:54:07< tad_> To understand if what I'm seeing in TSG Long March is what he intended. Probably, but when I compare the underlying map to the results when running there's some chagnes I'd like to be sure he inteded to have happen.
20160822 03:58:43-!- irker711 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160822 03:58:43< irker711> wesnoth: Charles Dang wesnoth:master 0a0caf9104f9 / src/display.cpp: Fix crash when starting editor introduced in 8816dc9cd9e8 https://github.com/wesnoth/wesnoth/commit/0a0caf9104f98a9afa7a25ff2556c2511466ebce
20160822 03:58:48< vultraz> tad_: ^
20160822 03:59:30< tad_> Specifically, when the road reaches the river, it's cutting water up/down into the embankments and adding a causeway, where the underlying map has beach. I can see where it's doing it and could change it but this is Dragon Country and he's said stay out of Dragon County :
20160822 04:00:02< Aginor> tad_: I'm using ccache with cmake and it's very fast for me if I'm just switching branches
20160822 04:01:12< vultraz> for 1.13.7 I'd like to experiment with gui2 for the main game themes
20160822 04:02:04< tad_> I've added ccache and did the symlink thing as they suggested. makeing now of that last commit. hopefulyl things will get a lot better
20160822 04:02:44< tad_> WOW did they. two files and it's done. far better than ever before
20160822 04:02:48< Aginor> (I also use cmake)
20160822 04:03:40< tad_> And thank you, voltraz, the map editor is working again. (Now, when you get time, maybe you could make all those stderr messages go away ...)
20160822 04:04:21< vultraz> My nick is 'vultraz' with a u, not an o, just saying :)
20160822 04:04:59< tad_> And my fingers say they're gonna typo where they're gonna typo.
20160822 04:06:27-!- JyrkiVesterinen [~jyrki@87-100-205-138.bb.dnainternet.fi] has joined #wesnoth-dev
20160822 04:06:43< Aginor> vultraz: just add highlighting for both
20160822 04:07:09-!- EliDupree [~quassel@idupree.com] has quit [Remote host closed the connection]
20160822 04:07:10< vultraz> JyrkiVesterinen: I fixed a crash introduced in your last commit 
20160822 04:09:11-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev
20160822 04:11:53< JyrkiVesterinen> Yes, I saw that in the log. Thanks. :)
20160822 04:31:00-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160822 04:33:26-!- Appleman1234 [~Appleman1@KD036012021144.au-net.ne.jp] has joined #wesnoth-dev
20160822 04:34:39-!- travis-ci [~travis-ci@ec2-54-161-88-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 04:34:40< travis-ci> wesnoth/wesnoth#10497 (master - 0a0caf9 : Charles Dang): The build is still failing.
20160822 04:34:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154049594
20160822 04:34:40-!- travis-ci [~travis-ci@ec2-54-161-88-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 04:46:43-!- Bonobo [~Bonobo@2001:44b8:254:3200:4179:6caf:7b02:7146] has joined #wesnoth-dev
20160822 05:01:32-!- JyrkiVesterinen [~jyrki@87-100-205-138.bb.dnainternet.fi] has quit [Quit: Konversation terminated!]
20160822 05:12:47< celticminstrel> Annoying how text fields don't respond to standard shortcuts like "next word" or "previous word".
20160822 05:15:04< shadowm> tad_: You can tab-complete nicks in most IRC clients.
20160822 05:16:48< tad_> cool. yes works. how do you get it to be red what you talk to me?
20160822 05:18:12< shadowm> I mention your nick. It's up to your client to decide how to/whether to present that as a highlight.
20160822 05:18:32< celticminstrel> Some people (eg me) are highlighted by other keywords besides their nick.
20160822 05:18:46< shadowm> Same, but I won't reveal my list.
20160822 05:18:50< celticminstrel> eg, celmin or celticminstrel will both highlight me, regardless of my current nick.
20160822 05:18:59< celticminstrel> I won't reveal my full list either. :P
20160822 05:19:35< tad_> Well, I'm using the web interface because I look at the features in the clients and my mind boggles. Back when I last used IRC is was type, read and that's it.
20160822 05:19:56< Aginor> I highlight on less than what people might assume, the only safe one is to use my nick at the start of a line
20160822 05:21:15< Aginor> I'm only stating this because it's caught me out in the past :)
20160822 05:21:58< Aginor> tad_: you could consider using a console client like irssi or the like, it's pretty much what you're used to
20160822 05:22:08< Aginor> or ircii if you want to go proper oldschool
20160822 05:22:08< tad_> The last time I used IRC it was on a Hercules monitor on one of my spare servers. I think it was Linux 0.96
20160822 05:25:13< tad_> Talk about blast-from-past, it seems some on /r/programming just last week learned about Gopher and decided to implement it. I wonder what they'll do if they discover the old NCP docs from before it became the Internet; but that's going back to when I was an undergrad .. just a year or two after the dinsaurs died off.
20160822 05:27:50< Aginor> it's hometime for me
20160822 05:27:55< Aginor> laters
20160822 05:52:58< tad_> I am learning to hate "error gui/draw: Image: '~RC(magenta>1)' not found and won't be drawn." .. it appears, I know exactly the keystrokes I took .. I repeat and it does not appear.
20160822 06:02:05-!- Kwandulin [~Miranda@p200300760F35BFC3816C46A440806BDE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160822 06:03:23< vultraz> HERM HERM HERM.
20160822 06:03:28< vultraz> this won't do :|
20160822 06:11:31< vultraz> celticminstrel: I think i got it working
20160822 06:12:35< celticminstrel> Oh?
20160822 06:12:38< wedge009> You sound like Dolores Umbridge.
20160822 06:12:46< celticminstrel> Your previous comment seems to say otherwise.
20160822 06:13:09< shadowm> 8 minutes passed between both lines.
20160822 06:13:23< celticminstrel> True, I guess. Whatever.
20160822 06:17:42< vultraz> ill probably push to my fork once I'm done so you can look at it
20160822 06:22:46-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160822 06:24:48< tad_> celticminstrel: oh, before I head off for the night you said something about doing a modify_ai in the [side][ai] .. is it just put the modify tag there to delete the candidate action?
20160822 06:25:16< celticminstrel> Yeah, [modify_ai] works in [side][ai] exactly the same as it does as an ActionWML.
20160822 06:25:30< celticminstrel> (Doesn't work in [modify_side][ai].)
20160822 06:26:22< tad_> ok. I'll make the change. I do like it in the [side][ai] better
20160822 06:32:00< celticminstrel> I think putting it in [side][ai] is roughly equivalent to putting it in the "side n turn 1" event, except that it could execute earlier if you use the inspector or something.
20160822 06:33:22< tad_> Well, it's a cleaner patch and puts both halves of the issue right next to each other. So I like it.
20160822 06:34:00< tad_> I'm off. I think I see why Zookeeper did what he did with the map in TSG but I'll look for him another time.
20160822 06:34:06-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160822 06:45:18< vultraz> hm hm hm
20160822 06:46:06< vultraz> hm hm hm
20160822 06:48:53< vultraz> celticminstrel: I guess it's not acceptable to change the [options][combo][item] name= key to label=
20160822 06:48:55< vultraz> ?
20160822 06:49:45< celticminstrel> Why?
20160822 06:49:59< celticminstrel> Doesn't seem like a good idea, anyway.
20160822 06:50:37< vultraz> because then the [item] config can be passed directly to the combobox
20160822 06:50:49< vultraz> meaning umc authors will also be able to specify tooltip= and icon=
20160822 06:51:03< celticminstrel> Just do cfg["label"] = cfg["key"]
20160822 06:51:14< celticminstrel> (If label is not already set, I guess.)
20160822 06:52:29< vultraz> that works
20160822 06:52:31-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160822 06:52:47< celticminstrel> I dunno if [combo] exists in 1.12, likely not.
20160822 06:53:05< celticminstrel> Actually, if it doesn't exist in 1.12, we should probably change it, because it's not a combobox.
20160822 06:53:21< vultraz> I think it does
20160822 06:53:22< celticminstrel> A combo box is a text box that also has a dropdown list of preset options.
20160822 06:53:53< celticminstrel> I was assuming it doesn't because gfgtdf only just added the combobox... but I guess GUI1 probably had one already.
20160822 06:53:55< vultraz> well our gui2 comboboxes don't do that :P
20160822 06:54:08< celticminstrel> You know, I think I could very easily implement a real combobox now...
20160822 06:54:11< vultraz> yes, the gui1 had one that wasn't a 'proper' combobox either
20160822 06:54:44< celticminstrel> We have a text box, and we have a dropdown. Just combine them, and boom, combobox.
20160822 06:55:58< celticminstrel> I suppose you could do something like treating [menu] as equivalent to [combo] with the intent of deprecating the old use of [combo].
20160822 06:56:27< vultraz> celticminstrel: https://github.com/Vultraz/wesnoth/commit/4501384bf64e77eba5ebf9d1da728e0102cfb3c7
20160822 06:56:45< vultraz> still needs cleanup (and a bugfix) but do look over it
20160822 06:57:04< vultraz> (the bugfix is that checkboxes need get_value_bool() and not get_value :|
20160822 06:57:36< celticminstrel> What's the branch name for that?
20160822 06:57:56< celticminstrel> Master, or something else?
20160822 06:58:03< vultraz> it's on my fork's master branch
20160822 06:58:28< vultraz> anyway, I'm thinking visible_options_ could maybe be simplified...
20160822 06:58:36< vultraz> the std::function removed
20160822 06:58:46< vultraz> then maybe the twos maps merged
20160822 06:58:48< vultraz> but I dunno
20160822 06:58:58< vultraz> need advice
20160822 06:59:29-!- irker711 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160822 07:00:01< celticminstrel> You commented out the checkbox set_label
20160822 07:00:25< vultraz> wasn't needed
20160822 07:00:46< celticminstrel> Your options_data_ looks different than expected.
20160822 07:01:19< celticminstrel> Oh right, you're ignoring the type in the key. What if you had an era and a modification with the same ID?
20160822 07:01:53< vultraz> that's not supported anyway
20160822 07:03:11< celticminstrel> Are you sure?
20160822 07:03:41< vultraz> how could it be? :|
20160822 07:03:49< celticminstrel> I don't see why it couldn't be.
20160822 07:04:24< vultraz> the wiki even says they need to be unique
20160822 07:04:48< celticminstrel> Obviously they need to be unique within a given tag, at least.
20160822 07:06:17< celticminstrel> But are you sure it's unsupported to have an era with id=xyz and also a modification with id=xyz?
20160822 07:08:18< vultraz> hm
20160822 07:08:24< vultraz> that might be a problem
20160822 07:08:43< celticminstrel> Guessing that's why gfgtdf used an array key (which I changed to option_source).
20160822 07:11:12< vultraz> anyway, is my overall method sound?
20160822 07:11:39< vultraz> do you think I can remove the option_getter
20160822 07:11:48< vultraz> if i ensure the data_map always has a value?
20160822 07:12:14< celticminstrel> Somewhat questioning the use of string rather than option_source, but I guess it seems fine. Also, I feel like this has rendered visible_options_ redundant.
20160822 07:12:36< vultraz> indeed
20160822 07:12:39< vultraz> as do I
20160822 07:12:43< celticminstrel> (When I say "it seems fine" I mean in general, not specifically the use of string rather than option_source.)
20160822 07:13:25< celticminstrel> You should .find() on the data map and set it to the default if you get back .end().
20160822 07:13:48< celticminstrel> ...or do you know how maps work by now?
20160822 07:13:59< celticminstrel> Maybe I didn't have to say that in so much detail.
20160822 07:16:16< vultraz> well you said earlier maps use pairs
20160822 07:17:03< celticminstrel> Hm?
20160822 07:20:01< vultraz> are you saying i should use maps.find instead of .empty() ?
20160822 07:20:18< celticminstrel> ...why would you use .empty()?
20160822 07:20:32< vultraz> ... ok what section are you talking about?
20160822 07:20:50< celticminstrel> I'm talking about populating the data map with the option's default value.
20160822 07:20:54< vultraz> ah
20160822 07:21:43< vultraz> (ot for a sec
20160822 07:22:18< vultraz> nvm)
20160822 07:22:42< vultraz> ok so
20160822 07:23:26< vultraz> if(!data_map.find(widget_id)) {  data_map[widget_id] = option["default"]; } 
20160822 07:23:27< vultraz> ?
20160822 07:23:31< vultraz> is this what you mean?
20160822 07:23:44< celticminstrel> Close.
20160822 07:23:56< celticminstrel> find returns an iterator, so test if it == end()
20160822 07:24:43< vultraz> ah
20160822 07:27:01< celticminstrel> And at least consider using option_source instead of string as the first key.
20160822 07:27:37< celticminstrel> Not really sure how important it is, but...
20160822 07:27:50< celticminstrel> If there's a possibility of an era and a mod sharing the same ID...
20160822 07:28:37< celticminstrel> (Disclaimer: I might be slightly pushy about this because I did the option_source thing in the first place. >_> Though it was gfgtdf who started it, really...)
20160822 07:29:36-!- Kwandulin [~Miranda@p200300760F35BFC3816C46A440806BDE.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160822 07:32:06< vultraz> will do
20160822 07:32:30< vultraz> i was going to anyway, but there was something about key name access that made me use a string 
20160822 07:33:17< vultraz> updated commit coming in a few minutes
20160822 07:34:56-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160822 07:35:56< vultraz> celticminstrel: btw, what should I do about the fact that toggle_buttons (checkboxes) need get_value_bool?
20160822 07:36:34< celticminstrel> I doubt they need get_value_bool?
20160822 07:36:39< celticminstrel> Don't they have get_value too?
20160822 07:36:54< celticminstrel> Though even if they do it's better to use get_value_bool.
20160822 07:37:03< celticminstrel> I suppose you could dynamic_cast.
20160822 07:37:06< vultraz> they do but it doesn't work without _bool
20160822 07:37:21< celticminstrel> What doesn't work?
20160822 07:37:48< vultraz> the value doesn't save/get reapplied properly
20160822 07:37:49< vultraz> but hm
20160822 07:37:51< vultraz> I have
20160822 07:37:52< vultraz> an idea
20160822 07:38:38< JyrkiVesterinen> Just create a template specialization for checkboxes.
20160822 07:38:39< JyrkiVesterinen> http://www.cprogramming.com/tutorial/template_specialization.html
20160822 07:39:09< vultraz> celticminstrel: oh, this is why I didn't use option_source.. I can't do this: options_data_[game_id]. 
20160822 07:39:33< celticminstrel> Why do you need to?
20160822 07:39:49< celticminstrel> You can't do options_data_[{game_type, game_id}]?
20160822 07:40:16< vultraz> that.. works?
20160822 07:40:36< celticminstrel> Well, that's what's done in display_custom_options, is it not?
20160822 07:40:38< vultraz> you can access a map member by the values of a struct?
20160822 07:40:44< celticminstrel> What?
20160822 07:40:48< celticminstrel> No, the key is the struct.
20160822 07:41:11< vultraz> right
20160822 07:41:23< vultraz> but how does it know to check if the members are alike?
20160822 07:41:33< vultraz> is that what
20160822 07:41:36< vultraz> 		friend bool operator<(const option_source& a, const option_source& b) {
20160822 07:41:37< vultraz> 			return a.level_type < b.level_type && a.id < b.id;
20160822 07:41:41< vultraz> does?
20160822 07:41:42< vultraz> or what
20160822 07:41:47< vultraz> i guess not, since that's <..
20160822 07:42:11< celticminstrel> Oh, it assumes they're equal if a < b and b < a are both false, I believe.
20160822 07:42:21< vultraz> I see
20160822 07:45:32< celticminstrel> Except in rare cases, that's a correct assumption, anyway.
20160822 07:48:48< vultraz> hmm
20160822 07:48:57< vultraz> how do we check if options are visible..
20160822 07:49:09< vultraz> I think I might need visible_options_ still
20160822 07:49:14< vultraz> but as a vector of string ids
20160822 07:49:21< celticminstrel> When do you need to check if options are visible?
20160822 07:49:27< vultraz> post_show
20160822 07:49:39< celticminstrel> Why?
20160822 07:49:49< vultraz> because...only visible options are passed to the new game :|
20160822 07:50:01< vultraz> since visible options correspond to selected games
20160822 07:50:07< vultraz> games/era/mods
20160822 07:50:08< celticminstrel> But, you know exactly which eras, mods, etc are selected, right?
20160822 07:50:15< celticminstrel> So isn't that your list of visible options?
20160822 07:50:44< vultraz> not if I use option_source
20160822 07:50:52< celticminstrel> What? Why not?
20160822 07:51:12< vultraz> because then I can no longer access the id directly..
20160822 07:51:15< vultraz> I need a game_type too :|
20160822 07:51:23< celticminstrel> What?
20160822 07:51:37< celticminstrel> I'm confused.
20160822 07:51:49< vultraz> not to mention more than 1 mod may be selected
20160822 07:51:55< celticminstrel> Is it not true that you can easily look up the currently selected mods, eras, etc?
20160822 07:51:55< vultraz> and I don't want to loop over mods
20160822 07:52:21< vultraz> I'd rather handle visible options in one loop
20160822 07:52:48< celticminstrel> You would need to loop over mods?
20160822 07:52:53< vultraz> then again, the vector would need to be a vector of option_source..
20160822 07:53:12< vultraz> celticminstrel: yes, to get the id of every active one and plug it into the data_map :|
20160822 07:53:47< celticminstrel> How do you know if a mod is active then?
20160822 07:54:06< vultraz> that's a little complicated
20160822 07:54:10< vultraz> and handled already elsewhere
20160822 07:54:15< vultraz> let's not duplicate it in post_show
20160822 07:54:30< celticminstrel> This sounds really confusing.
20160822 07:55:14< celticminstrel> Okay, so why exactly does using option_source specifically create a problem?
20160822 07:55:36< vultraz> because i always need a type :|
20160822 07:56:02< celticminstrel> Type meaning... game type?
20160822 07:56:05< vultraz> for eras and mods it's just "era" and "modification", yes
20160822 07:56:17< vultraz> but for games it can be either "campaign" or "multiplayer"
20160822 07:56:19< vultraz> see:
20160822 07:56:23< vultraz> create_engine_.current_level_type() == ng::level::TYPE::CAMPAIGN ? "campaign" : "multiplayer",
20160822 07:57:44< celticminstrel> What exactly is it that you do in post_show that works with a string id but not with option_source?
20160822 07:59:09< vultraz> now that I think of it, perhaps not such a good idea anyway
20160822 07:59:17< celticminstrel> Huh?
20160822 07:59:25< vultraz> i figured i could just get the current game id, era id, and loop over active mods and use each id..
20160822 07:59:34< vultraz> but i dunno, as i said, would be nicer to do this in one loop
20160822 07:59:37< celticminstrel> Huh?
20160822 08:01:24< vultraz> nevermind :|
20160822 08:02:47< celticminstrel> Currently it's looping over visible_options_, huh...
20160822 08:03:00< celticminstrel> Well, you could use twalker and loop through the tree view. ;)
20160822 08:03:15< celticminstrel> Not 100% sure if that'll give you the needed info...
20160822 08:06:27< vultraz> NO
20160822 08:06:29< vultraz> NO WALKERS
20160822 08:06:37< vultraz> :|
20160822 08:06:39< celticminstrel> It's really easy though.
20160822 08:06:47< celticminstrel> Still, I'm not sure if it would actually work...
20160822 08:07:00< celticminstrel> The nodes might not actually store the data you need.
20160822 08:09:26< celticminstrel> You could store a vector<option_source>.
20160822 08:09:31< celticminstrel> And call it visible_options_
20160822 08:09:58< celticminstrel> Maybe
20160822 08:10:29< vultraz> that's what I'm doing
20160822 08:12:03-!- Kwandulin [~Miranda@p200300760F35BFCE645B690D56B7AFE1.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160822 08:12:15< vultraz> celticminstrel: correct me if i'm wrong, but..
20160822 08:12:27< vultraz> in the loop over visible_options_ in post_show...
20160822 08:12:38< vultraz> doesn't the data never actually get pushed to "options"?
20160822 08:12:46< vultraz> and never passed to config_engine_->set_options
20160822 08:12:48< vultraz> ?
20160822 08:13:20< celticminstrel> Looks like you're right. It was probably supposed to be options.add_child?
20160822 08:13:58< vultraz> likely
20160822 08:14:17< vultraz> or..
20160822 08:14:29< vultraz> yeah I guess?
20160822 08:14:43< vultraz> oh wait, no
20160822 08:14:46< vultraz> mod is a reference
20160822 08:14:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160822 08:16:33< vultraz> so that means anything added to mod is added to options too, right?
20160822 08:17:36< celticminstrel> Ah, you're right.
20160822 08:17:47< celticminstrel> Missed that.
20160822 08:20:03< vultraz> we should really combat this get_value/get_value_bool thing at its source
20160822 08:21:56< celticminstrel> ?
20160822 08:22:07< celticminstrel> You could dynamic_cast.
20160822 08:22:14< vultraz> into..?
20160822 08:22:18< celticminstrel> Or simply assign a different callback if it's a checkbox.3
20160822 08:22:21< JyrkiVesterinen> I recommend template specialization instead.
20160822 08:22:23< celticminstrel> Uhh, ttogglebutton I guess?
20160822 08:22:55< celticminstrel> Template specialization or function overload or whatever, sure.
20160822 08:24:17< vultraz> still, I dunno why get_value doesn't return a bool value anyway
20160822 08:24:24< vultraz> what other value could it have :|
20160822 08:24:38< celticminstrel> Well, it does return a bool value, probably.
20160822 08:24:42< celticminstrel> But, as an integer.
20160822 08:24:52< celticminstrel> Because get_value returns integer, and the override cannot change that.
20160822 08:25:24< vultraz> so why does config::to_bool not convert that
20160822 08:26:19< JyrkiVesterinen> I threw together an example of the template specialization option: https://gist.github.com/jyrkive/ba7a12241f92619a5494564051cb7f06
20160822 08:27:03< vultraz> that's what I'm doing but it's not building :|
20160822 08:27:04< vultraz> ah
20160822 08:27:10< vultraz> template<> shouldn't be in the header
20160822 08:28:38< vultraz> celticminstrel: but really, it doesn't explain why config::to_bool doesn't convert the 0/1 to a bool
20160822 08:29:57-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has quit [Ping timeout: 276 seconds]
20160822 08:30:54 * vultraz inspects what value is coming out
20160822 08:30:55< celticminstrel> Might be a good reason, I dunno.
20160822 08:32:02< vultraz> interesting
20160822 08:32:30< vultraz> so I added these debug lines:
20160822 08:32:35< vultraz> 			std::cerr << "stored checkbox value is " << data_map[widget_id] << std::endl;
20160822 08:32:36< vultraz> 			std::cerr << "stored checkbox value (to_bool) is " << data_map[widget_id].to_bool() << std::endl;
20160822 08:32:56< vultraz> console output, for two checkboxes, not checked and checked
20160822 08:33:01< vultraz> 1
20160822 08:33:03< vultraz> 0
20160822 08:33:04< vultraz> yes
20160822 08:33:06< vultraz> 1
20160822 08:33:07 * vultraz ponders
20160822 08:34:12-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160822 08:35:47-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160822 08:36:53< vultraz> if I don't use to_bool, options are saved correctly 
20160822 08:37:04< vultraz> but initial states (ie, the value of default= are not respected
20160822 08:37:13< vultraz> celticminstrel: is this a bug
20160822 08:37:24< celticminstrel> I'm not sure.
20160822 08:38:35< vultraz> I think it's  question of whether to_bool is supposed to return a boolean value or a WML 'boolean' value (ie, "yes", "no", "true", or "false")
20160822 08:38:59< celticminstrel> Pretty sure it returns bool.
20160822 08:39:22< vultraz> hm, itdoes
20160822 08:40:59< vultraz> celticminstrel: commit https://github.com/Vultraz/wesnoth/commit/5be866242f4fd05edc9cb06b2093f3feb25f8bb6
20160822 08:42:35< celticminstrel> Preferably don't leave in the commented-out line.
20160822 08:42:39< celticminstrel> Just remove it.
20160822 08:42:47< vultraz> what?
20160822 08:42:55< vultraz> where
20160822 08:42:55< celticminstrel> checkbox->set_label
20160822 08:43:11< celticminstrel> I don't have precise line numbers. Around line 455.
20160822 08:43:20< vultraz> I did
20160822 08:43:29< celticminstrel> I assume just now.
20160822 08:44:01< vultraz> in that commit
20160822 08:44:04< vultraz> it's removed
20160822 08:46:10-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160822 08:46:17< celticminstrel> Oh, you're right, sorry.
20160822 08:46:21< celticminstrel> Duh.
20160822 08:46:24< celticminstrel> I'm tired.
20160822 08:46:47< vultraz> anyway, anything you want to add?
20160822 08:49:31< celticminstrel> Pretty sure you're missing something very important somewhere...
20160822 08:49:42< celticminstrel> I don't see any removing from visible_options_?
20160822 08:50:58< vultraz> that's still cleared every time options are updated
20160822 08:51:05< vultraz> 	visible_options_.clear();
20160822 08:51:07< vultraz> 	options_tree.clear();
20160822 08:54:11< celticminstrel> When they're updated, does the game reconsider every active era, mod, etc?
20160822 08:54:23< vultraz> yes
20160822 08:54:37 * vultraz just needs to implement the Defaults button now
20160822 08:54:40< celticminstrel> Okay, then that's fine.
20160822 08:54:50< vultraz> should be easy enough, just delete the thing from the map
20160822 08:55:07< celticminstrel> Maybe call it option_map instead of option_data_map. :P
20160822 08:55:12< celticminstrel> Not important I guess.
20160822 08:56:22< celticminstrel> No more comments.
20160822 08:56:28< vultraz> ok
20160822 08:57:52< vultraz> is this correct?
20160822 08:57:54< vultraz> options_data_[source].clear();
20160822 08:58:16< celticminstrel> That would clear any saved values for that option source.
20160822 08:59:36< vultraz> yeah, guess that works
20160822 08:59:40< vultraz> no need to use erase+find
20160822 08:59:56< celticminstrel> Erase+find?
20160822 09:00:08< celticminstrel> You could use options_data.erase(source), I think.
20160822 09:00:22< vultraz> ah
20160822 09:00:25< vultraz> which would you recommend?
20160822 09:00:46< celticminstrel> Is this for resetting defaults?
20160822 09:00:59< vultraz> yes
20160822 09:01:15< celticminstrel> And it's suppose to reset them just for one source?
20160822 09:01:20< celticminstrel> I think clear() is probably better.
20160822 09:01:28< celticminstrel> Since the expectation is that it'll soon be repopulated.
20160822 09:02:05< vultraz> yeah, I'm going to clear and then call update_options_list
20160822 09:09:53-!- celticminstrel is now known as celmin|sleep
20160822 09:15:42-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160822 09:21:05-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has quit [Ping timeout: 244 seconds]
20160822 09:42:35-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160822 09:43:35-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160822 09:50:08-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160822 09:50:39-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160822 10:02:17-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160822 10:03:41< vultraz> I think I might've come across that bug shadowm did
20160822 10:04:06< vultraz> the gui2 dispatcher cannot handle a widget clearing itself :/
20160822 10:16:11-!- Kwandulin [~Miranda@p200300760F35BFCE645B690D56B7AFE1.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160822 10:17:54-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160822 10:20:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20160822 10:20:34-!- wedge010 is now known as wedge009
20160822 10:45:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160822 10:53:08-!- Kwandulin [~Miranda@p200300760F35BFCE7DCC8BBA05D0562D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160822 11:04:16-!- JyrkiVesterinen_ [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160822 11:05:17-!- JyrkiVesterinen_ [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Client Quit]
20160822 11:07:03-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Ping timeout: 264 seconds]
20160822 11:10:19-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160822 11:11:11-!- irker368 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160822 11:11:11< irker368> wesnoth: Charles Dang wesnoth:master af340e6ae39e / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): MP Create: preserve options value when selecting new game/era/mods https://github.com/wesnoth/wesnoth/commit/af340e6ae39ee433e4e7b1a634ed7d31ba17c6eb
20160822 11:15:41-!- Bonobo [~Bonobo@2001:44b8:254:3200:4179:6caf:7b02:7146] has quit [Read error: Connection reset by peer]
20160822 11:16:14-!- Kwandulin [~Miranda@p200300760F35BFCE7DCC8BBA05D0562D.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160822 11:16:22-!- Bonobo [~Bonobo@2001:44b8:254:3200:4179:6caf:7b02:7146] has joined #wesnoth-dev
20160822 11:18:01-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has quit [Ping timeout: 244 seconds]
20160822 11:21:12-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160822 11:24:07-!- Kwandulin [~Miranda@p200300760F35BFCE39CCA5492D4CBCBD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160822 11:30:19-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160822 11:35:04-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 244 seconds]
20160822 11:40:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160822 11:43:08-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160822 11:45:17-!- travis-ci [~travis-ci@ec2-54-144-95-39.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 11:45:18< travis-ci> wesnoth/wesnoth#10499 (master - af340e6 : Charles Dang): The build is still failing.
20160822 11:45:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154116598
20160822 11:45:19-!- travis-ci [~travis-ci@ec2-54-144-95-39.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 12:15:22-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160822 12:38:06-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has quit [Ping timeout: 244 seconds]
20160822 12:57:44-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Ping timeout: 244 seconds]
20160822 13:01:57-!- fabi_ [~fabi@176.0.69.141] has joined #wesnoth-dev
20160822 13:03:49-!- fabi_ [~fabi@176.0.69.141] has quit [Client Quit]
20160822 13:04:14-!- fabi_ [~fabi@176.0.69.141] has joined #wesnoth-dev
20160822 13:05:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 13:06:14-!- fabi_ is now known as fabi
20160822 13:06:37-!- fabi [~fabi@176.0.69.141] has quit [Changing host]
20160822 13:06:37-!- fabi [~fabi@wesnoth/developer/fendrin] has joined #wesnoth-dev
20160822 13:06:59< fabi> hi
20160822 13:07:35< vultraz> hi
20160822 13:12:35-!- Bonobo [~Bonobo@2001:44b8:254:3200:4179:6caf:7b02:7146] has quit [Quit: Leaving]
20160822 13:16:05-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160822 13:31:19-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20160822 13:35:34-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160822 13:40:20-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20160822 13:50:41< vultraz> can someone tell me why the xbrz scaling in help suddenly looks better than it did before? o_O
20160822 13:51:01-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160822 13:52:30< JyrkiVesterinen> Maybe because of this? https://github.com/wesnoth/wesnoth/commit/69332b14ec2b8e37597840e3c1b776d7b831d767
20160822 13:52:57< JyrkiVesterinen> It might be that the xBRZ scaler was really using uninitialized data before that commit.
20160822 13:53:06< vultraz> Huh
20160822 13:53:30< vultraz> Well, it looks markedly better :D
20160822 13:56:16< vultraz> talk about a fix in an unexpected place
20160822 13:57:01< JyrkiVesterinen> Praise GCC developers. ;)
20160822 13:58:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160822 13:59:43< fabi> Hmmmm, I just trans-compiled the first scenario successfully.
20160822 14:02:21< vultraz> huh, GUI2 is full of little surprises 
20160822 14:02:30< vultraz> [slider] minimum/maximum_value_label is a thing
20160822 14:04:52-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20160822 14:08:59< irker368> wesnoth: Charles Dang wesnoth:master 0a94e6848422 / data/gui/window/mp_create_game.cfg src/gui/dialogs/multiplayer/mp_create_game.cpp: Used minimum_value_label for player number filter slider https://github.com/wesnoth/wesnoth/commit/0a94e6848422d789e3334d782f95a3cf8c7500aa
20160822 14:09:34-!- Kwandulin [~Miranda@p200300760F35BFCE39CCA5492D4CBCBD.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160822 14:16:32-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160822 14:22:30-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160822 14:26:00< irker368> wesnoth: Gregory A Lundberg wesnoth:master e1c39430de07 / data/lua/wml-tags.lua: Remove dead code https://github.com/wesnoth/wesnoth/commit/e1c39430de07023c3734b28527374628b9a79766
20160822 14:26:02< irker368> wesnoth: Charles Dang wesnoth:master 9ee24aeab1d7 / data/lua/wml-tags.lua: Merge pull request #756 from GregoryLundberg/GL_wml_logger https://github.com/wesnoth/wesnoth/commit/9ee24aeab1d7f78f18c5d578c221a7f388401e99
20160822 14:29:20-!- boucman_work1 [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160822 14:30:42-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 276 seconds]
20160822 14:34:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160822 14:35:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160822 14:43:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 14:49:56-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 14:49:57< travis-ci> wesnoth/wesnoth#10500 (master - 0a94e68 : Charles Dang): The build is still failing.
20160822 14:49:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154160439
20160822 14:49:57-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 14:52:12-!- louis94 [~~louis94@91.178.242.249] has quit [Read error: Connection reset by peer]
20160822 14:52:28-!- boucman_work1 [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20160822 14:52:41-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160822 14:54:36-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160822 15:01:32-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160822 15:02:03< irker368> wesnoth: Charles Dang wesnoth:master ab61fb8952d2 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: fixed unlimited turns not being properly set https://github.com/wesnoth/wesnoth/commit/ab61fb8952d2c50f6e4f88db2be0a974aab28f41
20160822 15:02:49-!- Shiki [~Shiki@141.57.58.245] has joined #wesnoth-dev
20160822 15:08:12-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160822 15:10:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160822 15:12:38-!- travis-ci [~travis-ci@ec2-54-144-95-39.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 15:12:39< travis-ci> wesnoth/wesnoth#10502 (master - 9ee24ae : Charles Dang): The build is still failing.
20160822 15:12:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154164567
20160822 15:12:39-!- travis-ci [~travis-ci@ec2-54-144-95-39.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 15:18:02-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 265 seconds]
20160822 15:19:10-!- Kwandulin [~Miranda@p200300760F35BFCEB8D474AE373AA429.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160822 15:33:45-!- louis94 [~~louis94@91.178.242.249] has quit [Read error: Connection reset by peer]
20160822 15:34:10-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160822 15:34:21-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160822 15:38:18-!- travis-ci [~travis-ci@ec2-54-161-88-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 15:38:19< travis-ci> wesnoth/wesnoth#10503 (master - ab61fb8 : Charles Dang): The build is still failing.
20160822 15:38:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154174570
20160822 15:38:19-!- travis-ci [~travis-ci@ec2-54-161-88-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 15:39:27-!- louis94 [~~louis94@91.178.242.249] has quit [Read error: Connection reset by peer]
20160822 15:40:37-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160822 15:48:35-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 250 seconds]
20160822 15:48:35-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160822 15:48:57-!- VultCave is now known as vultraz
20160822 15:50:14-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160822 15:50:14-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160822 15:51:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 15:54:08< vultraz> celmin|sleep: what would you advise to do about resetting options to default?
20160822 15:54:46-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has quit [Quit: No Ping reply in 180 seconds.]
20160822 15:55:32< celmin|sleep> Where is reset_whatever called?
20160822 15:55:45-!- celmin|sleep is now known as celticminstrel
20160822 15:56:12< vultraz> it's called as a callback to the Defaults button in each node
20160822 15:56:39-!- Shiki [~Shiki@141.57.58.245] has quit [Remote host closed the connection]
20160822 15:57:21-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has joined #wesnoth-dev
20160822 15:57:40< celticminstrel> Hmm... a vague idea is forming...
20160822 15:59:32< vultraz> does it involve walkers? :P
20160822 15:59:45< celticminstrel> Not sure. Too vague still.
20160822 15:59:56< celticminstrel> But likely not.
20160822 16:04:05< irker368> wesnoth: Charles Dang wesnoth:master 223f742a508f / src/storyscreen/render.cpp: Increase size of storyscreen text, as requested by feedback https://github.com/wesnoth/wesnoth/commit/223f742a508fe757fe26fbf49c3058e62a6054dc
20160822 16:05:06< celticminstrel> Once I fix these problems in the const_cast branch, I'll investigate the idea.
20160822 16:05:16< vultraz> I see
20160822 16:05:28< vultraz> a good idea would be to fix the bug in the gui2 event pipeline :P
20160822 16:05:51-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 264 seconds]
20160822 16:05:51< celticminstrel> What bug?
20160822 16:06:19< vultraz> well, it shouldn't crash :/
20160822 16:06:32< vultraz> though come to think of it, I should get a stacktrace of that crash
20160822 16:09:14< vultraz> yeah, it's in the event pipeline
20160822 16:09:18< vultraz> #0 0x5	?? () (??:??)
20160822 16:09:19< vultraz> #1 0xe80780	bool gui2::event::implementation::fire_event<std::function<void (gui2::event::tdispatcher&, gui2::event::tevent, bool&, bool&)>, gui2::event::ttrigger>(gui2::event::tevent, std::vector<std::pair<gui2::twidget*, gui2::event::tevent>, std::allocator<std::pair<gui2::twidget*, gui2::event::tevent> > >&, gui2::twidget*, gui2::twidget*, gui2::event::ttrigger) () (??:??)
20160822 16:09:21< vultraz> #2 0x15eaba5	?? () (??:??)
20160822 16:09:55< vultraz> tl'dr, I think the pipeline cannot handle a call that destroys itself
20160822 16:10:35< celticminstrel> Makes sense.
20160822 16:12:18< vultraz> yeah
20160822 16:12:23< vultraz> but this is still a bug
20160822 16:12:44< vultraz> maybe we can put JyrkiVesterinen on it
20160822 16:12:55< celticminstrel> I dunno.
20160822 16:13:24< vultraz> this bug also prevents the creation of the gui2 file chooser dialog, just saying
20160822 16:14:15< vultraz> I think the fix would be to avoid invalidating any pointers until the event has run its course 
20160822 16:15:01< celticminstrel> I'll look at it after this, but not sure if I'll do anything.
20160822 16:15:22-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160822 16:15:43< celticminstrel> By "look at" I mean get the crash and enter the debugger and poke around a little.
20160822 16:16:00< vultraz> I'm building a debug build to get a more detailed stacktrace
20160822 16:16:18< celticminstrel> Shouldn't you always be building a debug build?
20160822 16:16:28< vultraz> good god no
20160822 16:16:39< vultraz> it takes almost 2 minutes to link alone
20160822 16:16:52< vultraz> vs 10 seconds or so for a Release build
20160822 16:16:59< vultraz> not to mention it takes much longer to launch :|
20160822 16:27:15< celticminstrel> I think my const_cast broke a lot of Lua things without realizing it, because I just naively changed pushlightuserdata to pushstring.
20160822 16:27:39< celticminstrel> Although...
20160822 16:28:04< celticminstrel> I dunno, I feel like it should've worked still anyway,,,
20160822 16:28:14< celticminstrel> Maybe it's something else?
20160822 16:30:48< celticminstrel> Still, I tested after the Lua refactor steps, but not after the final const_cast commit.
20160822 16:36:06-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160822 16:38:11-!- louis94 [~~louis94@91.178.242.249] has quit [Ping timeout: 244 seconds]
20160822 16:39:19-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 16:39:20< travis-ci> wesnoth/wesnoth#10504 (master - 223f742 : Charles Dang): The build is still failing.
20160822 16:39:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154193837
20160822 16:39:20-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 16:41:28< vultraz> celticminstrel: http://pastebin.com/WMVZ6aHA
20160822 16:41:29-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b01d:7dbd:5d82:c3ee] has joined #wesnoth-dev
20160822 16:41:57< vultraz> JyrkiVesterinen too ^
20160822 16:42:04< celticminstrel> Good timing, any longer and I would've quite Firefox.
20160822 16:42:38< celticminstrel> Doesn't really help me though...
20160822 16:43:06< vultraz> hey, it's GUI2's event pipeline :P
20160822 16:43:14< vultraz> were you expecting a LOOK HERE FOR BUG sign?
20160822 16:44:17-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 16:44:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20160822 16:46:00< celticminstrel> Okay, killing Firefox.
20160822 16:46:21< celticminstrel> (Though I can technically still view pastebins without it, using curl.)
20160822 16:49:49-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b01d:7dbd:5d82:c3ee] has quit [Remote host closed the connection]
20160822 16:49:52< celticminstrel> BTW, you know I started a WML tag porting branch, right?
20160822 16:50:03< vultraz> what?
20160822 16:50:24-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160822 16:50:32< celticminstrel> I'm not going to port any tags on that branch (I'v focusing on tags that were lazily ported), but if anyone else wants to port one and push to the branch, I won't (strongly) object.
20160822 16:51:02-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160822 16:52:54< celticminstrel> You know, add-ons already have a dependency system, right?
20160822 16:53:03< vultraz> I think anything above break #4 is where the issues is..
20160822 16:53:06< vultraz> celticminstrel: hm?
20160822 16:53:09< celticminstrel> Would it be a good idea to also make it possible for them to claim dependency on built-in campaigns?
20160822 16:53:32< vultraz> the addons dependency system is in desperate need of refactoring
20160822 16:53:41< celticminstrel> Since some distros ship the campaigns separately, it would at least enable a warning message if the dependency is not satisfied.
20160822 16:54:02< celticminstrel> Well, I do want to look into some stuff related to the addons server, but waiting on the asio merge first.
20160822 16:54:10< vultraz> ah yes
20160822 16:54:12< vultraz> that
20160822 16:54:43-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 244 seconds]
20160822 16:54:44< celticminstrel> So do you have an answer to the question?
20160822 16:54:58< vultraz> I don;t think it's worth it
20160822 16:55:11< celticminstrel> Why?
20160822 16:55:19< vultraz> one should not depend on mainline campaigns
20160822 16:55:22< vultraz> let's not encourage it
20160822 16:55:30< celticminstrel> Eh.
20160822 16:56:11-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160822 16:59:03< vultraz> ughh
20160822 16:59:16< vultraz> mordante's horrible indentation system makes the code hard to read
20160822 16:59:49< celticminstrel> Oh?
20160822 17:00:05< celticminstrel> You could make a commit that does nothing but fix indentation.
20160822 17:00:10< vultraz> well, more like annoying to read 
20160822 17:00:16< celticminstrel> Though that'd conflict with things like team index refactor probably.
20160822 17:00:29< vultraz> yeah not now
20160822 17:00:37< vultraz> while we have major branches awaiting merge
20160822 17:00:53< celticminstrel> Makes sense.
20160822 17:01:09< vultraz> I'll let jyrki look into this
20160822 17:01:19< vultraz> I suspect it's those widget pointers in gui2::event::implementation::fire_event being invalidated
20160822 17:01:20< celticminstrel> The event thing?
20160822 17:01:37< celticminstrel> Note that I'm also going to look into it at least briefly, if I can get this Lua thing fixed.
20160822 17:01:53< vultraz> anyone who can fix it is great :P
20160822 17:02:22< vultraz> I wonder if smart pointers guard against invalidation
20160822 17:02:25< vultraz> (do they?)
20160822 17:02:29< celticminstrel> No.
20160822 17:03:13< celticminstrel> However, if all references can be traced to an original smart pointer, you shouldn't have to worry about invalidation.
20160822 17:03:22< celticminstrel> Because it won't invalidate until all smart pointers are destroyed.
20160822 17:03:59< vultraz> I see
20160822 17:04:19< celticminstrel> If something else invalidates it though, the smart pointer won't know about it.
20160822 17:04:30< vultraz> (I do appreciate mordante leaving a giant-ass design doc here, though, describing how the event system works)
20160822 17:07:35-!- Kwandulin [~Miranda@p200300760F35BFCEB8D474AE373AA429.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160822 17:07:42-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160822 17:07:46< celticminstrel> Hmm, when I get the metatable, it seems that it correctly has the name "unit", yet testudata is returning false...
20160822 17:08:29< celticminstrel> Well, null; but whatever.
20160822 17:10:13< celticminstrel> I wonder if if statements have always allowed declarations in them, and if not, when that happened.
20160822 17:10:23< celticminstrel> ...wow, the debugger crashed XCode.
20160822 17:14:27< celticminstrel> Force-push coming.
20160822 17:14:39< celticminstrel> Figured I'd get that over with early.
20160822 17:15:33< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 797613f760d0 / src/scripting/ (lua_api.cpp lua_kernel_base.cpp): Refactor some duplicate code in Lua API https://github.com/wesnoth/wesnoth/commit/797613f760d0c84afefa39b305bb512f4a574479
20160822 17:15:35< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 1521f326df7a / / (17 files in 4 dirs): Move Lua unit wrapper to own file https://github.com/wesnoth/wesnoth/commit/1521f326df7a04feae7b1f7f56ffbce736a58c02
20160822 17:15:37< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 4dd99b881f3d / src/scripting/ (8 files): Implement Lua placement new https://github.com/wesnoth/wesnoth/commit/4dd99b881f3de9a31af86214eb9d1d23a675c594
20160822 17:15:39< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 6d38c77aab3e / src/ (5 files in 2 dirs): Extract Lua unit push code into a function https://github.com/wesnoth/wesnoth/commit/6d38c77aab3ed3e52e158b548e2e1a826c7ce8be
20160822 17:15:41< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 3804027d100f / src/scripting/ (game_lua_kernel.cpp game_lua_kernel.hpp lua_unit.cpp lua_unit.hpp): Avoid luaW_hasmetatable when checking for units https://github.com/wesnoth/wesnoth/commit/3804027d100fc02328a6829997792b8ef0587303
20160822 17:15:43< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 4dcba0c3cdec / src/scripting/game_lua_kernel.cpp: Fix bug in wesnoth.put_unit https://github.com/wesnoth/wesnoth/commit/4dcba0c3cdec6cb535206f8c23f0beb866db737f
20160822 17:15:45< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor fa0e63e3a346 / src/scripting/ (game_lua_kernel.cpp lua_unit.cpp lua_unit.hpp): Move unit metatable stuff into lua_unit file https://github.com/wesnoth/wesnoth/commit/fa0e63e3a3462dd3dabcdff5c2aecbc1fa213dbc
20160822 17:15:47< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 22a39d0bb4d9 / / (6 files in 2 dirs): Move Lua unit attacks metatable to own file https://github.com/wesnoth/wesnoth/commit/22a39d0bb4d9f1b756cfdc43e7ff63565b580c04
20160822 17:15:49< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 2dd19b7d15a5 / src/scripting/lua_unit_attacks.cpp: Fix Lua attacks metatable not working for attacks obtained from unit_type https://github.com/wesnoth/wesnoth/commit/2dd19b7d15a5f2997907c0b48649b28d0910b46c
20160822 17:15:51< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor bb43fa29c46b / src/scripting/game_lua_kernel.cpp: Use luaW_pushunit when getting lists of units https://github.com/wesnoth/wesnoth/commit/bb43fa29c46b41e52c3169f72a2dcaad94618778
20160822 17:15:53< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 30b7ab8b2dc7 / / (25 files in 9 dirs): Reduce use of const_cast https://github.com/wesnoth/wesnoth/commit/30b7ab8b2dc7a3a7d19372216307255327ce5b19
20160822 17:17:19< celticminstrel> Hmm, so the crash wasn't just a fluke...
20160822 17:18:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160822 17:24:51-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160822 17:26:06-!- Kwandulin [~Miranda@p200300760F35BFCEC91FABB18F7EFCE4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160822 17:32:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160822 17:34:39-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 17:34:40< travis-ci> wesnoth/wesnoth#10505 (lua_refactor - 30b7ab8 : Celtic Minstrel): The build is still failing.
20160822 17:34:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154214064
20160822 17:34:40-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 17:37:14< celticminstrel> So seemingly luaL_getmetatable is yielding nil... maybe adding the metatable to the registry was skipped?
20160822 17:37:28< celticminstrel> Wait, but if that was so, then how could it even have that metatable..
20160822 17:38:08-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160822 17:39:40< celticminstrel> Oh, I think I get it.
20160822 17:39:58< celticminstrel> luaL_getmetatable is looking for "unit" but the key is actually "unit\0".
20160822 17:41:00-!- JyrkiVesterinen [~jyrki@87-92-22-4.bb.dnainternet.fi] has joined #wesnoth-dev
20160822 17:41:16< JyrkiVesterinen> I saw the logs about the GUI2 event system crash.
20160822 17:41:45< JyrkiVesterinen> I added that to my todo list. I'll have a look if celticminstrel doesn't fix it first.
20160822 17:41:59< JyrkiVesterinen> Any steps to reproduce the crash?
20160822 17:42:24< celticminstrel> I think it involves uncommenting a line in MP Create, going to eg A New Land, and clicking the Defaults button.
20160822 17:42:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160822 17:42:40< celticminstrel> (This also means enabling new lobby in prefs.)
20160822 17:43:43< celticminstrel> I wonder if there's anything I can set in git config to say "please never search the po directory".
20160822 17:43:51< vultraz> JyrkiVesterinen: first, ensure you have the Experimental Mp Lobby preference enabled, since it controls the new MP Create too.
20160822 17:44:02< vultraz> JyrkiVesterinen: then, uncomment this line https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_create_game.cpp#L446
20160822 17:44:47< JyrkiVesterinen> I see. As I said, the bug is in my todo list.
20160822 17:44:52< vultraz> JyrkiVesterinen: then, go to Multiplayer -> Local Game, choose 'Dark Forecast (Survival)' (or any game/era/mod/ with options, really, but that one has an option built-in), go to the Custom Options tab, and click Defaults
20160822 17:45:17< celticminstrel> Does ANL not have options then? I guess I misremembered the one with options.
20160822 17:45:39< vultraz> ANL does not, no
20160822 17:46:34< celticminstrel> ...what the heck does "" s mean.
20160822 17:46:41< celticminstrel> Oh.
20160822 17:47:06< celticminstrel> I guess it's a way of ensuring that the macro argument is a string constant.
20160822 17:47:18< celticminstrel> (Not relevant to anything, since this is in lua.h.)
20160822 17:49:45< celticminstrel> String literal, that is.
20160822 17:55:14-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160822 18:03:10-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 258 seconds]
20160822 18:03:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160822 18:10:30< celticminstrel> So if I just use lauxlib everywhere, it should work, right?
20160822 18:12:04< celticminstrel> I reduced push_error_handler from six lines to two. \o/
20160822 18:19:19< irker368> wesnoth: Celtic Minstrel wesnoth:lua_refactor 39477b40a727 / src/ (6 files in 2 dirs): Fix Lua metatables by using lauxlib to manage them https://github.com/wesnoth/wesnoth/commit/39477b40a727ed4aa4d717475331553e7176f7e1
20160822 18:19:24< celticminstrel> wedge009: ^ That should fix the Lua errors in PR744, I think. It fixed the one I got with add_modification, at least.
20160822 18:21:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 265 seconds]
20160822 18:22:03-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has joined #wesnoth-dev
20160822 18:22:24-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160822 18:24:19-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160822 18:24:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 18:30:27-!- louis94 [~~louis94@91.178.242.249] has quit [Ping timeout: 264 seconds]
20160822 18:31:51-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160822 18:33:40-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160822 18:36:25< celticminstrel> vultraz: Still working on MP Create?
20160822 18:37:07< celticminstrel> Hmm, I need some dummy modifications to test it...
20160822 18:44:47< celticminstrel> It doesn't seem to remember my last used scenario...
20160822 18:46:44< celticminstrel> The menu option doesn't honour the default value. In fact, I feel like none of them are?
20160822 18:46:57< celticminstrel> Maybe I'm doing it wrong, because it works for Dark Forecast.
20160822 18:48:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 276 seconds]
20160822 18:52:40< celticminstrel> Adding tooltips to the custom options now.
20160822 18:53:16-!- Kwandulin [~Miranda@p200300760F35BFCEC91FABB18F7EFCE4.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160822 18:57:38< irker368> wesnoth: Jyrki Vesterinen wesnoth:master 8716d3f78490 / / (4 files in 2 dirs): Make wesnothd build with Visual Studio https://github.com/wesnoth/wesnoth/commit/8716d3f784904c230c5e84948ceb8f1139155d64
20160822 18:57:40< irker368> wesnoth: Jyrki Vesterinen wesnoth:master f79b707dc409 / / (4 files in 2 dirs): Merge pull request #751 from jyrkive/wesnothd-msvc https://github.com/wesnoth/wesnoth/commit/f79b707dc409e3ad9c4c7e6f7d1474313ac9bf81
20160822 19:12:56< celticminstrel> I got the menu default to work, but it doesn't make sense.
20160822 19:13:18< celticminstrel> So, checking wiki.
20160822 19:16:20< celticminstrel> The wiki doesn't specify how default works for [combo].
20160822 19:19:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160822 19:21:26-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b01d:7dbd:5d82:c3ee] has joined #wesnoth-dev
20160822 19:21:57-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:b01d:7dbd:5d82:c3ee] has quit [Remote host closed the connection]
20160822 19:24:46< celticminstrel> Okay, in the GUI1 version it works as I would expect.
20160822 19:27:42-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160822 19:37:59-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160822 19:43:53< celticminstrel> Making the GUI2 version do the same is quite easy with std::find_if.
20160822 19:54:01-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160822 19:55:17< celmin> Somehow an invalid default causes the modification's whole [options] to be ignored.
20160822 20:03:24-!- JyrkiVesterinen [~jyrki@87-92-22-4.bb.dnainternet.fi] has quit [Quit: Konversation terminated!]
20160822 20:05:07-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160822 20:05:35< tad_> vultraz: Comment on the Statistics panel "Scenario" button.
20160822 20:06:55< tad_> When first displayed, it says "Scenario". If you select the current scenario from the list, it remains "Scenario" but if you select another it changes to that other; THEN if you select the current, it display the name rather than "Scenario" .. seems a little odd to sometimes change and sometimes not change.
20160822 20:07:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160822 20:07:33-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160822 20:08:38< celmin> Is there a validation stage somewhere that I don't know of? What's going on here...
20160822 20:10:25< celmin> vultraz: Sometimes the map description seems to disappear.
20160822 20:13:15< celmin> Which is actually sort of helpful for my testing, since it also doesn't wrap, but should still be fixed.
20160822 20:18:37< celmin> I think the bizarre cache error is probably to blame for the missing options...
20160822 20:19:03-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160822 20:22:47< celticminstrel> Guess not.
20160822 20:23:06< shadowm> Why do you keep switching clients?
20160822 20:24:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160822 20:24:48< celticminstrel> Usually it's because it's too hot to bear upstairs, so I go downstairs with my laptop.
20160822 20:24:57< celticminstrel> That's the most common reason.
20160822 20:25:17< celticminstrel> Okay, so I figured out the issue.
20160822 20:25:39< celticminstrel> The modifications checkbox doesn't actually correctly reflect the modification's enabled status.
20160822 20:26:02< celticminstrel> It was remembering it had been enabled in the GUI1 interface, so it's enabled if I leave it unchecked and disabled if I check it.
20160822 20:26:55< celticminstrel> However, if I don't touch it, it's also disabled. If I check it and uncheck it, it's enabled.
20160822 20:37:01< celticminstrel> BTW, your layout doesn't work even on 1024x768, though at least it's usable there (unlike in 800x600).
20160822 20:45:24-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 250 seconds]
20160822 20:49:52-!- mjs-de [~mjs-de@wh.Uni-Dortmund.DE] has quit [Remote host closed the connection]
20160822 20:50:40-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160822 20:58:29< celticminstrel> Accidentally replaced mod list with an era list. Whoops!
20160822 21:11:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 21:11:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160822 21:12:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160822 21:14:35< Shiki> Oh, nice, so you have two era lists ? ^^
20160822 21:14:49< celticminstrel> No, it's not nice.
20160822 21:15:03< celticminstrel> Ugh, I can't seem to get this to work...
20160822 21:18:16-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160822 21:27:45-!- mjs-de [~mjs-de@x4db5d7e3.dyn.telefonica.de] has joined #wesnoth-dev
20160822 21:28:17< celticminstrel> vultraz: Another thing that needs to be done before switching to the new lobby by default is enabling the Lua plugins context.
20160822 21:35:19-!- RatArmy [~RatArmy@om126212092082.11.openmobile.ne.jp] has joined #wesnoth-dev
20160822 21:37:13-!- Dugi [5866ba5f@gateway/web/freenode/ip.88.102.186.95] has joined #wesnoth-dev
20160822 21:37:48< celticminstrel> Oh hi.
20160822 21:38:12< Dugi> Hello.
20160822 21:40:12< celticminstrel> What's this? "The currently chosen scenario is not compatible with your setup. Please select a compatible one."
20160822 21:42:59< Dugi> Grep the source, find the condition...
20160822 21:43:16-!- Appleman1234 [~Appleman1@KD036012021144.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20160822 21:43:30< celticminstrel> It's a dialog, grep won't help.
20160822 21:43:41< celticminstrel> I did try entering the debugger, but didn't look too closely.
20160822 21:48:29-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160822 21:48:30-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160822 21:48:53< Dugi> I have searched the whole source code of Wesnoth and that error message wasn't present anywhere there. My version is a bit outdated, though.
20160822 21:49:09< celticminstrel> Like I said, it's a dialog.
20160822 21:49:19< celticminstrel> The message itself is probably somewhere in data/gui.
20160822 21:49:48< celticminstrel> Anyway, it's not really important anymore.
20160822 21:51:06< Dugi> I mean I have searched everything in the git repository. Including data.
20160822 21:52:50< Dugi> So it had to be a recent change.
20160822 21:53:06< celticminstrel> It can't have been a recent change.
20160822 21:53:56< celticminstrel> Ah, it's constructed piecemeal, that's why you couldn't find it. Actually, this is very bad.
20160822 21:54:44< celticminstrel> Oh, hmm. Maybe it's fine. It's not constructed piecemeal after all, just broken across multiple lines.
20160822 21:57:25< celticminstrel> I would expect the gettext collector to understand that adjacent C string literals are concatenated by the compiler.
20160822 21:57:37< celticminstrel> xgettext or whatever it's called
20160822 21:57:46-!- irker368 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160822 21:59:15< Dugi> Congrats on finding it.
20160822 22:00:18< celticminstrel> I was wrong about it being in data, as you might have guessed.
20160822 22:01:06-!- mjs-de [~mjs-de@x4db5d7e3.dyn.telefonica.de] has quit [Remote host closed the connection]
20160822 22:11:50< celticminstrel> Blah, it still doesn't work. :(
20160822 22:12:51< shadowm> vultraz: You wouldn't happen to have an image comparison of before and after I fixed that warning, would you?
20160822 22:13:36< shadowm> Not that I need it, I'm just mildly curious.
20160822 22:14:52< Dugi> Bye.
20160822 22:14:54-!- Dugi [5866ba5f@gateway/web/freenode/ip.88.102.186.95] has left #wesnoth-dev []
20160822 22:37:07-!- Shiki [~Shiki@141.39.226.227] has quit [Quit: Verlassend]
20160822 22:40:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160822 22:42:35-!- Appleman1234 [~Appleman1@KD036012028006.au-net.ne.jp] has joined #wesnoth-dev
20160822 22:42:47< celticminstrel> This is harder than I thought, so I'm gonna push the other stuff.
20160822 22:44:58-!- irker616 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160822 22:44:58< irker616> wesnoth: Celtic Minstrel wesnoth:master 3c84f98808aa / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: Show custom option descriptions as tooltips https://github.com/wesnoth/wesnoth/commit/3c84f98808aa103d82691a283e3021609b95c6ee
20160822 22:44:58< irker616> wesnoth: Celtic Minstrel wesnoth:master af80ddbb2cf2 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: Fix incorrectly selecting menu option current value https://github.com/wesnoth/wesnoth/commit/af80ddbb2cf2145e86cd557587d81423511516b2
20160822 22:50:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160822 22:53:12< vultraz> ah nice
20160822 22:53:28< celticminstrel> Working on memory right now.
20160822 22:54:08< vultraz> memory?
20160822 22:54:15< celticminstrel> Remembering your selections.
20160822 22:55:01< vultraz> of?
20160822 22:55:09< celticminstrel> Mod, era, level
20160822 22:55:12< vultraz> ah
20160822 22:55:14< celticminstrel> ^+s
20160822 22:55:30< vultraz> including active status of mod?
20160822 22:55:35< celticminstrel> Yes.
20160822 22:55:38< vultraz> I recall in sp it does remember
20160822 22:55:51< celticminstrel> It remembers in MP too.
20160822 22:55:53< vultraz> I thought it didn't work in mp so I didn't add that
20160822 22:56:06< celticminstrel> It works with the GUI1 version.
20160822 22:56:28-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160822 22:56:57< vultraz> then by all means, implement
20160822 22:57:07< celticminstrel> Just got it working.
20160822 22:57:14< celticminstrel> At least, the loading side.
20160822 23:02:13< celticminstrel> Saving is far easier.
20160822 23:02:24< vultraz> loading?
20160822 23:02:26< vultraz> ah
20160822 23:02:36< celticminstrel> Loading from prefs to dialog; saving from dialog to prefs.
20160822 23:03:05< vultraz> the create_engine_ has a list, I think
20160822 23:03:12< celticminstrel> Yeah.
20160822 23:03:36< irker616> wesnoth: Celtic Minstrel wesnoth:master 59e83355a702 / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): MP Create: Remember level, era, & mod selections https://github.com/wesnoth/wesnoth/commit/59e83355a70243c56c7a9d0a2aeaddb41a802658
20160822 23:05:14< vultraz> do clean up formatting before committing...
20160822 23:05:19< celticminstrel> Hm?
20160822 23:05:32< vultraz> randomly inserted indentation 
20160822 23:05:42< celticminstrel> Oh, you mean empty-line indentation?
20160822 23:05:46-!- horrowind [~Icedove@2a02:810a:83c0:404:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160822 23:06:09< vultraz> that, and the fact that you randomly indented a line for no reason
20160822 23:06:13< celticminstrel> Did I?
20160822 23:06:37< vultraz> yes
20160822 23:06:42< celticminstrel> Where?
20160822 23:06:52< celticminstrel> I don't see it.
20160822 23:07:04< vultraz> 309
20160822 23:07:15< vultraz> no worries, I shall deal with it in my cleanup commit
20160822 23:07:21< vultraz> i had some stuff pending locally anyway
20160822 23:07:40< celticminstrel> Oh, I see it now. No idea how that happened.
20160822 23:07:58< celticminstrel> Might be something to do with how XCode re-indents the current line whenever I type a colon.
20160822 23:08:12< celticminstrel> (I can disable it, but I find it helpful at least as often as not.)
20160822 23:08:31< celticminstrel> (I guess mainly it's helpful in switch statements.)
20160822 23:09:32< vultraz> now what is this about a lua plugin context?
20160822 23:10:04< celticminstrel> Those lines at the end of the GUI1 MP Create constructor. (Presumable MP Configure has its own set as well.)
20160822 23:10:54< vultraz> and those do...?
20160822 23:11:19< vultraz> I have no idea  what they actually do
20160822 23:11:31< celticminstrel> They enable Lua plugins to control the dialog.
20160822 23:11:37< celticminstrel> Which is required for the MP test, at least.
20160822 23:12:01< vultraz> I see
20160822 23:13:12< vultraz> should we only save selection if you click OK?
20160822 23:13:29< celticminstrel> I think that's how it works in GUI1, though mods seemed to save even if you clicked cancel.
20160822 23:14:30< celticminstrel> BTW, do you have any idea what the matrix widget is for or if it's used anywhere?
20160822 23:14:55< vultraz> No
20160822 23:15:00< irker616> wesnoth: Charles Dang wesnoth:master db167c0cb4b3 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: small cleanup https://github.com/wesnoth/wesnoth/commit/db167c0cb4b3145d96403a034848e25745823275
20160822 23:15:04< vultraz> I was wondering just that myself last night
20160822 23:15:43< vultraz> I thought it might be a 2x2 grid of visible grids or something, but that didn't make much sense
20160822 23:15:59< celticminstrel> I wonder if it could be used for that suggestion in your thread where I said "actually this is probably possible".
20160822 23:16:21< vultraz> I honestly do not recommend it in any case
20160822 23:16:38< vultraz> gui2 would break epically, not to mention it's bad ux.
20160822 23:17:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160822 23:17:44-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160822 23:19:46-!- travis-ci [~travis-ci@ec2-54-227-23-16.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 23:19:47< travis-ci> wesnoth/wesnoth#10510 (master - af80ddb : Celtic Minstrel): The build is still failing.
20160822 23:19:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154302689
20160822 23:19:47-!- travis-ci [~travis-ci@ec2-54-227-23-16.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 23:19:52< vultraz> one feature gui2 mp create is missing is entry points
20160822 23:21:39< celticminstrel> I've decided that tcombobox should be renamed tmenu_button, any objections?
20160822 23:23:10< vultraz> but it's not a menu button, really
20160822 23:23:37< celticminstrel> How is it not a menu button? It's a button that you click to bring down a menu.
20160822 23:23:46< vultraz> eh, granted
20160822 23:23:48< vultraz> no objection
20160822 23:26:09< celticminstrel> I was thinking it would be fairly simple to implement a tmultimenu_button which is similar but doesn't allow icons and supports multiple selections.
20160822 23:28:09< vultraz> uh....
20160822 23:28:33< celticminstrel> Not sure if it's worth it though - the listbox works well for mod selection, right?
20160822 23:29:25< vultraz> yes
20160822 23:32:42< vultraz> downside of a gui2 mp connect dialog will be we don't have those nice draggable boxes 
20160822 23:32:51< celticminstrel> We can probably make it work.
20160822 23:33:28< vultraz> might be slightly difficulty
20160822 23:33:36< celticminstrel> Might be.
20160822 23:37:57< vultraz> I still need to make turns '100' say 'unlimited'
20160822 23:38:05< vultraz> sadly, not enough space there :/
20160822 23:38:29< vultraz> I could move it to a label on top, but that would require custom events and stuff..
20160822 23:38:54< vultraz> I wanted to maybe use a grid for sliders, but i don't know how that would interface with sliders
20160822 23:39:05< vultraz> and the fact they're a generalization of scrollbars
20160822 23:39:30< celticminstrel> Scrollbars and sliders are pretty much the same thing, behaviour-wise.
20160822 23:40:07-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160822 23:40:21< vultraz> except sliders should snap to options, maybe :P
20160822 23:40:33< celticminstrel> True.
20160822 23:40:33< vultraz> and scrollbars should have smooth scrolling
20160822 23:40:54< celticminstrel> That could be debatable.
20160822 23:41:05< vultraz> smooth scrolling best scrolling
20160822 23:41:06< vultraz> :P
20160822 23:43:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 258 seconds]
20160822 23:43:34-!- wedge010 is now known as wedge009
20160822 23:43:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160822 23:43:51< vultraz> but yeah, I really don't know how the slider would function using a grid...
20160822 23:43:59< vultraz> for one, I'd have to use a [drawing]...
20160822 23:43:59-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has joined #wesnoth-dev
20160822 23:44:00< travis-ci> wesnoth/wesnoth#10511 (master - 59e8335 : Celtic Minstrel): The build is still failing.
20160822 23:44:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/154306384
20160822 23:44:00-!- travis-ci [~travis-ci@ec2-54-234-211-210.compute-1.amazonaws.com] has left #wesnoth-dev []
20160822 23:44:19< celticminstrel> Why?
20160822 23:44:48< vultraz> to make the canvas respect the grid?
20160822 23:45:17< irker616> wesnoth: Celtic Minstrel wesnoth:master 396f5dfc4c7f / / (22 files in 12 dirs): Rename combobox -> menu_button https://github.com/wesnoth/wesnoth/commit/396f5dfc4c7f03468d85bb1df917f90c13789761
20160822 23:45:19< celticminstrel> No idea what you're getting at there.
20160822 23:45:53< celticminstrel> ^ that was basically mass find&replace with a few tweaks.
20160822 23:46:02< celticminstrel> XCode for the source and sed for the data.
20160822 23:46:27< celticminstrel> (Of course I verified that it still works as well.)
20160822 23:48:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160822 23:48:56< vultraz> right now, sliders are basically a line, an image, and some text all drawn on a canvas
20160822 23:49:02< vultraz> they don't use grids or labels
20160822 23:49:15< vultraz> that's always been left up to the dialogs using them..
20160822 23:50:50< celticminstrel> I see.
20160822 23:51:23< vultraz> I suppose I could add a set_value_output(tcontrol* widget) function
20160822 23:52:28< celticminstrel> Don't you already have something like that?
20160822 23:52:33< celticminstrel> Possibly local to prefs though.
20160822 23:52:38< irker616> wesnoth: Charles Dang wesnoth:master 14752e1bdbed / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/14752e1bdbed55a230ac4acf5f94c4ccb36bc595
20160822 23:52:51< vultraz> yeah, in prefs I think
20160822 23:55:20< celticminstrel> After I push this next commit, could you try fixing MP Create for 1152x864 and 1280x720? There's just a slight scrollbar in each.
20160822 23:55:41< celticminstrel> No problems whatsoever at 1280x960.
20160822 23:56:04< celticminstrel> I'll work on a different layout for smaller resolutions than those.
20160822 23:56:14< celticminstrel> Starting with 1024x768.
20160822 23:56:34< vultraz> the hell is 1152x864
20160822 23:56:43< celticminstrel> I dunno, it's one of the presets, so I tried it.
20160822 23:57:03< celticminstrel> I expect there's some reason for it to exist.
20160822 23:57:50< celticminstrel> Actually, are the presets set by Wesnoth or provided by SDL?
20160822 23:57:56< vultraz> sdl, I think
20160822 23:58:28< celticminstrel> Well, if you can make it require a little less space though, that'd be good. 
20160822 23:58:37< celticminstrel> Not a huge issue if you can't, I suppose...
20160822 23:58:50< celticminstrel> The 1024x768 layout could be extended to those larger resolutions too.
--- Log closed Tue Aug 23 00:00:41 2016