--- Log opened Sun Aug 28 00:00:25 2016
20160828 00:09:10< zookeeper> tad_, in case you read the logs: there's some matches for name.*\$\(\$ in mainline campaigns. for example name="turn $($turn_number+3)" seems to be used successfully in UtBS... unless someone has broken something regarding it.
20160828 00:10:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160828 00:10:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160828 00:12:47-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160828 00:15:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160828 00:25:04-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160828 00:26:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 244 seconds]
20160828 00:47:04-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160828 01:03:24< celmin> Found an interesting TODO at unit.cpp:2434 (remove_attacks_ai)
20160828 01:03:30< celmin> …why is that underlined.
20160828 01:25:02< mattsc> hmm ...
20160828 01:26:16< mattsc> celticminstrel: Thinking about it, the only computation time intensive AI I use regularly is Fred, and I do all that in 1.12.  So no, definitely no objections from my side.
20160828 01:54:22-!- RatArmy [~RatArmy@om126212248171.14.openmobile.ne.jp] has joined #wesnoth-dev
20160828 02:06:49-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 260 seconds]
20160828 02:10:44-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160828 02:12:39-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has joined #wesnoth-dev
20160828 02:32:19< celmin> I could probably write unit tests for these...
20160828 03:13:49-!- RatArmy [~RatArmy@om126212248171.14.openmobile.ne.jp] has quit [Ping timeout: 255 seconds]
20160828 03:20:37-!- mattsc_ [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160828 03:22:20-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160828 03:24:30-!- midzer_ [~quassel@p57B4536C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160828 03:25:58-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 258 seconds]
20160828 03:26:00-!- midzer [~quassel@p57B4536C.dip0.t-ipconnect.de] has quit [Ping timeout: 258 seconds]
20160828 03:26:04-!- mattsc_ is now known as mattsc
20160828 03:42:19-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160828 03:42:42-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160828 03:55:00-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160828 04:01:14-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160828 04:13:35-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160828 04:15:19-!- midzer_ is now known as midzer
20160828 04:38:22< irker956> wesnoth: Celtic Minstrel wesnoth:master b5c5e21895da / src/ (5 files in 2 dirs): Fix Lua unit types table and add variations subtable to each type https://github.com/wesnoth/wesnoth/commit/b5c5e21895dabbdd0e239968d0d8697c626b72f7
20160828 04:38:24< irker956> wesnoth: Celtic Minstrel wesnoth:master 27b0fe6d7b6e / src/scripting/ (lua_cpp_function.cpp lua_rng.cpp): Lua placement new fixups https://github.com/wesnoth/wesnoth/commit/27b0fe6d7b6e6bbe00316b47c4afe7ad1467d288
20160828 04:38:26< irker956> wesnoth: Celtic Minstrel wesnoth:master 36bced059b39 / src/scripting/ (lua_team.cpp lua_team.hpp): Make Lua team references comparable with == https://github.com/wesnoth/wesnoth/commit/36bced059b393efdc504087b23808a62a8359d01
20160828 04:38:28< irker956> wesnoth: Celtic Minstrel wesnoth:master 144ce315c3ab / src/scripting/ (lua_gui2.cpp lua_gui2.hpp lua_kernel_base.cpp lua_kernel_base.hpp): Lua GUI2: Support stacked widgets and unit preview pane, and add show_menu funct https://github.com/wesnoth/wesnoth/commit/144ce315c3ab8e61c7e31ea99f080530b2def1fd
20160828 04:38:30< irker956> wesnoth: Celtic Minstrel wesnoth:master 89f7525f06cb / src/ (5 files in 3 dirs): Fixup Lua unit attack referencing and allow them to be compared with == https://github.com/wesnoth/wesnoth/commit/89f7525f06cbc059fe7f27c232150b85a772553e
20160828 04:38:32< irker956> wesnoth: Celtic Minstrel wesnoth:master 945fea0c0ed4 / src/scripting/lua_unit_attacks.cpp: Fixup indentation https://github.com/wesnoth/wesnoth/commit/945fea0c0ed464dfe86f4b6c0a13e65a4d53caf4
20160828 04:38:34< irker956> wesnoth: Celtic Minstrel wesnoth:master f1978b13f1fa / src/ (scripting/lua_unit_attacks.cpp units/attack_type.hpp): Allow changing unit attack ID through Lua https://github.com/wesnoth/wesnoth/commit/f1978b13f1fa852ad835a7ab43829ec97c024fe2
20160828 04:38:36< irker956> wesnoth: Celtic Minstrel wesnoth:master 496a523fa20f / src/scripting/lua_common.cpp: Fix crash when starting a campaign https://github.com/wesnoth/wesnoth/commit/496a523fa20f692dd50d79ea56b067dd19acf5f3
20160828 04:38:38< irker956> wesnoth: Celtic Minstrel wesnoth:master b143ea4397f5 / src/ (17 files in 7 dirs): Use intrusive pointers for unit attacks https://github.com/wesnoth/wesnoth/commit/b143ea4397f5caa9a4ec34c5a9b1dbbaae5181bf
20160828 04:38:40< irker956> wesnoth: Celtic Minstrel wesnoth:master 4d0d27138344 / src/ (3 files in 2 dirs): Enable Lua attack references to outlive their owning unit https://github.com/wesnoth/wesnoth/commit/4d0d27138344efdc0fb51aa2da61ac0e57b1331f
20160828 04:38:42< irker956> wesnoth: Celtic Minstrel wesnoth:master 31f783b86dd6 / src/ (scripting/lua_unit_attacks.cpp units/unit.cpp units/unit.hpp): Enable adding, removing, and replacing unit attacks through the Lua unit attacks https://github.com/wesnoth/wesnoth/commit/31f783b86dd6d4e5134b6046ccb261f5b95e0b4b
20160828 04:38:44< irker956> wesnoth: Celtic Minstrel wesnoth:master f376bbc2c125 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/f376bbc2c125f9719c4315d581fc9f59020fe13a
20160828 04:39:26< celmin> Whee!
20160828 04:45:37-!- kahootbird [~kahootbir@c-76-23-72-30.hsd1.tn.comcast.net] has joined #wesnoth-dev
20160828 05:08:25-!- Kwandulin [~Miranda@p200300760F4241EC08CC15510975CDF5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160828 05:11:32-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 05:11:33< travis-ci> wesnoth/wesnoth#10573 (master - f376bbc : Celtic Minstrel): The build was broken.
20160828 05:11:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155679876
20160828 05:11:33-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 05:12:30< celmin> Wait, did the sign of size() suddenly change when it became an iterator range? :|
20160828 05:39:39< vultraz> I have decided I was over-engineering shit earlier 
20160828 05:39:48< celmin> Oh fun.
20160828 05:40:11< vultraz> there's a much simpler way
20160828 05:41:50< shadowm> I'm curious, exactly how does one overengineer fecal matter?
20160828 05:42:15< vultraz> :|
20160828 05:43:01< pydsigner> Extra fiber content
20160828 05:44:01< shadowm> Does it count as engineering when it's an unconscious process driven by autonomous structures bOCOCOCOCOCOCOCOCOCOCODuilt into your own body?
20160828 05:44:05< vultraz> :|
20160828 05:44:07< shadowm> *built
20160828 05:44:24< pydsigner> Considering that you can choose what food you eat, maybe
20160828 05:44:40< shadowm> But you don't really choose how it gets processed.
20160828 05:45:03< pydsigner> Right, but you don't really choose how your concrete reacts to the environment either
20160828 05:45:09< shadowm> Unless you deliberately cause yourself abdominal trauma in order to induce vomit and/or diarrhea.
20160828 05:45:38< shadowm> Well, you do choose how concrete reacts to the environment.
20160828 05:46:10< shadowm> You make design decisions around environmental factors and produce or select the best materials to be actively manipulated by people under your command.
20160828 05:46:12< pydsigner> You can tweak your ratios and in some cases the environment
20160828 05:46:18< shadowm> That's a wholly voluntary set of actions.
20160828 05:46:47< pydsigner> "Hmm, I'm going to be running a lot in an hour, I think I'll hold off on the burger and fries"
20160828 05:46:59< shadowm> Whereas you are not usually in control of your stool.
20160828 05:56:56< irker956> wesnoth: Charles Dang wesnoth:master e8ca1439be55 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create: always ensure the validity of saved selected type game type https://github.com/wesnoth/wesnoth/commit/e8ca1439be555c9caee37de4429b4b4f0e75fc17
20160828 05:56:59< vultraz> celticminstrel: ^
20160828 05:58:42< celmin> I see.
20160828 06:00:01-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160828 06:01:21< irker956> wesnoth: Charles Dang wesnoth:master cfed64dd4f42 / src/gui/dialogs/lobby/ (data.cpp info.cpp): Some cleanup to GUI2 MP Lobby auxiliary code https://github.com/wesnoth/wesnoth/commit/cfed64dd4f426c45f8bfb88aab72680484a99c4d
20160828 06:01:31< vultraz> still dunno if I fully optimized that sort 
20160828 06:02:24< vultraz> that's what I was asking you about earlier
20160828 06:05:02< celticminstrel> What exactly is that sort?
20160828 06:05:08< celticminstrel> Player list sorting?
20160828 06:05:11< vultraz> yes
20160828 06:05:19< vultraz> by relation, name, or both
20160828 06:05:33< celticminstrel> Hmm.
20160828 06:05:52< celticminstrel> There's no unsorted option, I suppose.
20160828 06:06:13< celticminstrel> I guess it wouldn't make sense to sort first my name and secondarily by relation, either.
20160828 06:06:15< celticminstrel> ^by
20160828 06:06:26< celticminstrel> Well, I guess it's fine probably...
20160828 06:07:55< vultraz> (btw, is your above fix related to the thing where starting positions crash?)
20160828 06:09:19< celticminstrel> The commit mentioning campaigns is, yes.
20160828 06:09:24< vultraz> ah, good
20160828 06:18:42-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 06:18:43< travis-ci> wesnoth/wesnoth#10574 (master - e8ca143 : Charles Dang): The build is still failing.
20160828 06:18:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155684759
20160828 06:18:43-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 06:23:16< irker956> wesnoth: Charles Dang wesnoth:master 1bd83cc65eb0 / src/gui/dialogs/multiplayer/mp_create_game.cpp: Attempt to fixup e8ca1439be55 for travis https://github.com/wesnoth/wesnoth/commit/1bd83cc65eb0f95d914ad680c7b8efe2e5482718
20160828 06:31:57-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 06:31:58< travis-ci> wesnoth/wesnoth#10575 (master - cfed64d : Charles Dang): The build is still failing.
20160828 06:31:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155685087
20160828 06:31:58-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 06:36:37-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160828 06:40:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160828 06:40:33-!- wedge010 is now known as wedge009
20160828 06:41:39< celticminstrel> ...why on earth was that 0 on its own line? o.o
20160828 06:42:05< celticminstrel> And why can't to_int be used there?
20160828 06:42:12< vultraz> what?
20160828 06:42:18< celticminstrel> https://github.com/wesnoth/wesnoth/commit/cfed64dd4f426c45f8bfb88aab72680484a99c4d#diff-f520320be93eb7f5aa82b8ac479e56baR179
20160828 06:42:53< vultraz> probably perceived space restrictions 
20160828 06:42:55< celticminstrel> Some people seem to like to randomly put newlines in the middle of statements.
20160828 06:43:04< vultraz> which is dumb, since it actually went far further out
20160828 06:43:10< celticminstrel> Pfffft.
20160828 06:43:36< vultraz> indeed
20160828 06:43:57< celticminstrel> Did you do something to break Travis too?
20160828 06:44:05< vultraz> yes
20160828 06:44:10< celticminstrel> I apparently somehow introduced a signed-unsigned comparison.
20160828 06:44:18< vultraz> it couldn't detect the lambda return value
20160828 06:44:24< celticminstrel> Ah.
20160828 06:44:33< vultraz> long int vs int
20160828 06:45:44< celticminstrel> So cf2d64dd is all formatting?
20160828 06:45:46< vultraz> as for the to_int, no idea
20160828 06:45:54< vultraz> no
20160828 06:46:01< vultraz> there's some minor simplification
20160828 06:46:07< celticminstrel> Example?
20160828 06:46:10< vultraz> besides the removing of the struct sorters
20160828 06:46:25< vultraz> there's one part where i removed a use of a bare iterator 
20160828 06:46:37< celticminstrel> You mixed formatting and semantic changes in the same commit? :/
20160828 06:46:59< vultraz> of course
20160828 06:47:05< celticminstrel> That's not good.
20160828 06:47:48< vultraz> (the change was in sync_games_display_status )
20160828 06:47:58< celticminstrel> Still not good.
20160828 06:48:14< celticminstrel> Espcially when the commit is mainly formatting.
20160828 06:48:26< vultraz> I said cleanup, not formatting
20160828 06:48:29< celticminstrel> A few formatting changes mixed in with a mainly semantic commit is fine, but the reverse is terrible.
20160828 06:48:41< celticminstrel> You said cleanup, but looking at it, it seems to be mainly formatting.
20160828 06:48:51< Aginor> celticminstrel: explain why it's a bad thing, not just that it's bad :)
20160828 06:49:08< vultraz> formatting is included in cleanup, by my definition
20160828 06:49:22< celticminstrel> It makes it very difficult to see the real changes.
20160828 06:49:26< celticminstrel> Formatting is not a real change.
20160828 06:49:38< celticminstrel> It's just making the code look nicer.
20160828 06:49:58< celticminstrel> By mixing in a few semantic changes with a mainly formatting commit, you make it very difficult for people to pick out what actually changed.
20160828 06:50:15< vultraz> I see
20160828 06:50:43< celticminstrel> I won't deny that formatting can be counted as cleanup, but I'd think of it as a separate category of cleanup.
20160828 06:56:44-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160828 07:01:31< vultraz> next we need to fix that filter issue
20160828 07:06:02< vultraz> btw, you don't object to my use of boost::replace_all, do you
20160828 07:06:49< celticminstrel> Remind me what that was about again?
20160828 07:07:24< vultraz> replacing all newlines in a string with " - " (except where - was an em-dash)
20160828 07:07:41< celticminstrel> Oh, yeah, replace_all is probably a good choice for that sort of thing.
20160828 07:11:29-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 07:11:30< travis-ci> wesnoth/wesnoth#10576 (master - 1bd83cc : Charles Dang): The build is still failing.
20160828 07:11:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155686780
20160828 07:11:30-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 07:15:03< vultraz> ok, we're down to one build failing
20160828 07:15:18< vultraz> src/synced_commands.cpp: In function ‘bool synced_command_func_attack(const config&, bool, bool, synced_command::error_handler_function)’:
20160828 07:15:20< vultraz> src/synced_commands.cpp:195:46: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
20160828 07:15:21< vultraz>   if (size_t(weapon_num) >= u->attacks().size()) {
20160828 07:15:23< vultraz>                                               ^
20160828 07:15:49< vultraz> do fix, please
20160828 07:16:11< celticminstrel> That's presumably my fault. I'm assuming that removing "size_t" (and the cast parentheses) will fix it, but XCode is currently closed because I was rebasing another branch, so I can't confirm.
20160828 07:17:56< celticminstrel> Well okay, the XCode project is closed. XCode itself is still running.
20160828 07:28:10< celticminstrel> XCode might decide to do a full rebuild...
20160828 07:28:20< celticminstrel> Hope not though.
20160828 07:31:07< celticminstrel> Oh yeah, hotkey categorization. Maybe I'll work on that next. The primary alternative is [animate_unit], though there are a bunch of other things too...
20160828 07:31:20< celticminstrel> Huh, I actually have some things listed twice here.
20160828 07:33:46< celticminstrel> Looks like it's not quite doing a full rebuild. Only 495 files instead of over 500.
20160828 07:43:25-!- JyrkiVesterinen [~JyrkiVest@87-92-28-216.bb.dnainternet.fi] has joined #wesnoth-dev
20160828 08:16:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160828 08:17:51-!- celticminstrel is now known as celmin|sleep
20160828 08:31:19-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160828 08:55:51-!- mjs-de [~mjs-de@x4e31a4f9.dyn.telefonica.de] has joined #wesnoth-dev
20160828 08:58:23< irker956> wesnoth: Charles Dang wesnoth:master ca8c944f522f / data/campaigns/Heir_To_The_Throne/ (7 files in 2 dirs): Further Battle Princess animations by doofus-01 https://github.com/wesnoth/wesnoth/commit/ca8c944f522f29293cb6f9a27bd93cc22c367b16
20160828 09:02:26-!- JyrkiVesterinen [~JyrkiVest@87-92-28-216.bb.dnainternet.fi] has quit [Quit: .]
20160828 09:29:11-!- mjs-de [~mjs-de@x4e31a4f9.dyn.telefonica.de] has quit [Remote host closed the connection]
20160828 10:04:20-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 10:04:21< travis-ci> wesnoth/wesnoth#10578 (master - ca8c944 : Charles Dang): The build is still failing.
20160828 10:04:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155700365
20160828 10:04:21-!- travis-ci [~travis-ci@ec2-54-234-78-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 10:46:29< irker956> wesnoth: Charles Dang wesnoth:master eb2cff007b7a / src/synced_commands.cpp: Attempt to appease travis https://github.com/wesnoth/wesnoth/commit/eb2cff007b7ad15039b900c78ac8060f44eaeb62
20160828 10:53:18< fabi> hi
20160828 10:55:26< vultraz> hi
20160828 10:58:36< irker956> wesnoth: Charles Dang wesnoth:master b09bd5bbb5e7 / src/save_index.cpp: Attempt to fix multiple leaders appearing in save_index https://github.com/wesnoth/wesnoth/commit/b09bd5bbb5e7d4f879e54503350381b18050f61d
20160828 11:16:51-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.3]
20160828 11:19:39-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20160828 11:19:39-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20160828 11:19:39-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160828 11:22:06-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 11:22:07< travis-ci> wesnoth/wesnoth#10579 (master - eb2cff0 : Charles Dang): The build has errored.
20160828 11:22:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155711671
20160828 11:22:07-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 11:27:13-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160828 11:43:34< irker956> wesnoth: Charles Dang wesnoth:master 4180a36d330f / src/gui/dialogs/lobby/info.cpp: Fix issue in cfed64dd4f42 pointed out by @jyrkive https://github.com/wesnoth/wesnoth/commit/4180a36d330f60e74c264dd4c87ae7edb775dedc
20160828 11:45:49-!- Kwandulin [~Miranda@p200300760F4241EC08CC15510975CDF5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160828 11:53:27-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 11:53:28< travis-ci> wesnoth/wesnoth#10580 (master - b09bd5b : Charles Dang): The build was fixed.
20160828 11:53:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155712921
20160828 11:53:28-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 11:53:38< vultraz> celmin|sleep: ^
20160828 12:13:21-!- JyrkiVesterinen [~JyrkiVest@78-27-120-22.bb.dnainternet.fi] has joined #wesnoth-dev
20160828 12:22:47-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 12:22:48< travis-ci> wesnoth/wesnoth#10581 (master - 4180a36 : Charles Dang): The build passed.
20160828 12:22:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155717337
20160828 12:22:48-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 12:25:00< vultraz> tfw you find out the 't' prefix is actually hardcoded for dialogs and gui2 won't build if it's not the beginning of the class name
20160828 12:29:04-!- JyrkiVesterinen [~JyrkiVest@78-27-120-22.bb.dnainternet.fi] has quit [Quit: Going somewhere]
20160828 12:38:18-!- Kwandulin [~Miranda@p200300760F4241EC79429277339857F5.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160828 12:47:42< fabi> vultraz: Really? Mordante used it because he liked pascal or delphi objects have a "t" as name prefix.
20160828 12:47:54< fabi> t for type
20160828 12:48:08< vultraz> well, specifically the REGISTER_DIALOG macro
20160828 12:48:09< fabi> s/objects/class
20160828 12:48:12< vultraz> inserts a 't'
20160828 12:48:25< vultraz> #define REGISTER_DIALOG(window_id) REGISTER_DIALOG2(t##window_id, window_id)
20160828 12:48:27< vultraz> :|
20160828 12:48:38< fabi> yeah, that is funny.
20160828 12:49:04< vultraz> #JustMordanteThings
20160828 12:51:50< vultraz> I thought it was just a silly naming convention, but no, he hardcoded it into the framework
20160828 12:53:21< fabi> well, it is funny. But not a problem.
20160828 12:56:28< DeFender1031> ugh
20160828 13:11:46-!- JyrkiVesterinen [~JyrkiVest@78-27-120-22.bb.dnainternet.fi] has joined #wesnoth-dev
20160828 13:13:33< JyrkiVesterinen> Regarding naming conventions, a more common convention is that type names start with a capital letter.
20160828 13:13:44< JyrkiVesterinen> In particular, Ruby enforces that.
20160828 13:15:47< vultraz> huh
20160828 13:32:45< fabi> JyrkiVesterinen: It's also a convention in Java but not enforced iirc. But Jave enforces the filename matching the class one.
20160828 13:41:43< fabi> There are ~9.5MiB WML in data. Sounds a lot.
20160828 13:42:33< fabi> Not counting the maps.
20160828 14:15:57-!- Kwandulin [~Miranda@p200300760F4241EC79429277339857F5.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160828 14:26:16< celmin|sleep> REGISTER_DIALOG could easily be changed though. Or removed in favour of REGISTER_DIALOG2.
20160828 14:29:35< vultraz> or the latter renamed and replace the former
20160828 14:30:18 * vultraz is working to convert the FLG dialog to GUI2
20160828 14:30:23< vultraz> (Faction Select)
20160828 14:30:45< celmin|sleep> That was oon my todo list. Guess I'll remove it.
20160828 14:31:11< celmin|sleep> I actually think it's sensible for dialog classes to all have a common prefix though. Just, not t.
20160828 14:31:49< vultraz> I'll leave the Random Map settings dialog to you
20160828 14:43:51-!- irker956 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160828 14:45:52< celmin|sleep> I would've preferred factions to random map if I had to choose one, but whatever. Doesn't matter that much.
20160828 14:46:01< celmin|sleep> Factions might have a plugins context, right?
20160828 14:47:03< vultraz> factions is part of mp wait which has a plugins context
20160828 14:51:24-!- celmin|sleep is now known as celticminstrel
20160828 14:51:25-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160828 14:51:27< vultraz> mp wait/connect has yet to be converted to gui2
20160828 14:51:42< vultraz> to do so, first we need to widget-ize the chat area
20160828 14:51:47< vultraz> i believe that's on your todo list?
20160828 14:51:54< celticminstrel> What is MP wait anyway?
20160828 14:52:12< vultraz> in other games it'd be called a lobby
20160828 14:52:16< vultraz> it's where you wait for other players
20160828 14:52:39< celticminstrel> That doesn't really explain anything.
20160828 14:53:18< vultraz> you connect to the game, pick your leader
20160828 14:53:19< vultraz> etc
20160828 14:53:23< vultraz> pick player slot
20160828 14:53:32< celmin> Isn't that MP Connect?
20160828 14:53:50< vultraz> yes but it appears slightly different if you're not the host IIRC
20160828 14:54:12< celmin> I wonder if they really need to be separate then.
20160828 14:54:35< celmin> They could probably at least share the same WML.
20160828 14:54:50< celmin> Like the WML Message dialogs do.
20160828 14:54:59< celmin> And maybe even a base class.
20160828 14:55:19< celmin> BTW, Mordante seems to use postfix _ to indicate an abstract base class.
20160828 14:55:19< vultraz> likely
20160828 14:55:27< celmin> Which I think is really silly.
20160828 14:55:29< vultraz> i haven't looked into the implementation
20160828 14:55:57< vultraz> right now im just working on the faction dialog
20160828 14:56:24< celmin> BTW, do the MP tests work on your machine yet?
20160828 14:56:54< vultraz> haven't tried since that damn crash on join
20160828 14:57:17< celmin> I see.
20160828 14:57:31< celmin> Did I say I might look into that, or was that something else?
20160828 14:57:50< vultraz> you did
20160828 14:59:14< celmin> Why does GUI2 WML always quote its trues and falses?
20160828 14:59:35< vultraz> dunno
20160828 14:59:36< celmin> Does horizontal listbox need a [header]?
20160828 14:59:50< vultraz> no, not really
20160828 15:00:38< celmin> Hmm...
20160828 15:00:47 * celmin checks the available toggle panel definitions.
20160828 15:01:46< celmin> Just default and wml_message, nothing special then, okay.
20160828 15:03:43< vultraz> ok, just need to get the gender selection working..
20160828 15:04:30< celmin> Uh, which file is prefs actually defined in? I need to add another [linked_group].
20160828 15:04:38< vultraz> what?
20160828 15:04:47< vultraz> toplevel prefs?
20160828 15:04:53< vultraz> it's in gui/dialogs/preferences.cfg
20160828 15:05:40< celmin> Oh, I suppose I should've guessed it wouldn't be in the subdir.
20160828 15:05:56< vultraz> :P
20160828 15:06:28< celmin> What's {_GUI_INFO_TAB_PADDING} for?
20160828 15:07:13< vultraz> padding around the labels in tabs
20160828 15:13:25 * vultraz makes note to add a mass-callback setter to tgroup
20160828 15:14:28-!- Kwandulin [~Miranda@p200300760F4241EC6526DBFA838AA937.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160828 15:14:41< celmin> What's the type for a horizontal listbox?
20160828 15:14:47< celmin> Mass-callback setter?
20160828 15:15:52< vultraz> yes, a function to set callbacks for all members
20160828 15:16:04< vultraz> thorizontal_listbox
20160828 15:16:32-!- midzer_ [~quassel@p5B2969B8.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160828 15:16:38< celmin> Duh, the error was something else then. Like maybe the lack of a semicolon.
20160828 15:16:51< celmin> What about a "selection change" callback?
20160828 15:17:07< celmin> Wait, no. It's not included?
20160828 15:17:29< celmin> How is thorizontal_listbox not defined in prefs? Wasn't it used for tab bars?
20160828 15:17:50-!- midzer [~quassel@p57B4536C.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160828 15:18:47< vultraz> I was mistaken
20160828 15:18:51< vultraz> it's a plain tlistbox
20160828 15:19:36< vultraz> the distinction is internally handled in generator somewhere
20160828 15:19:46< celmin> Ah.
20160828 15:22:39-!- gfgtdf [~chatzilla@x50abb183.dyn.telefonica.de] has joined #wesnoth-dev
20160828 15:24:35< gfgtdf> i alos think the mp wait and mp connect shoudl share more code, that coudl also make it possible for non-hosts to change their factions/leader
20160828 15:24:48< gfgtdf> instead of only beeing able to do this directly after joining
20160828 15:25:30< vultraz> hm
20160828 15:25:40< vultraz> maybe this dialog I'm working on isn't necessary, then? :P
20160828 15:25:53< vultraz> (the Select Faction dialog)
20160828 15:26:11< vultraz> if we're gonna allow selection once people are connected
20160828 15:26:27< gfgtdf> hmm maybe,
20160828 15:26:42< vultraz> blah
20160828 15:26:53< vultraz> wish you'd said this 4 hours ago :P
20160828 15:26:57< vultraz> oh well
20160828 15:26:59< vultraz> I'll finish it
20160828 15:27:14< vultraz> if we don't use it then, it's no big deal
20160828 15:27:42< gfgtdf> well it still possible that there appear other issues with the 'allow to change faster later' appraoch to we might have to use them still.
20160828 15:27:50< gfgtdf> s/faster/faction
20160828 15:28:33< vultraz> true
20160828 15:28:48< vultraz> either way, this will also clean some crud from the FLG manager
20160828 15:29:16< vultraz> some bright soul decided to put ui-related stuff in there :|
20160828 15:29:36< celmin> Oh my.
20160828 15:32:08< vultraz> hmmm
20160828 15:32:16< vultraz> gender toggle not working...
20160828 15:32:30< celmin> Toggle?
20160828 15:32:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160828 15:33:07< celmin> Well, I suppose there's no reason to ever expect non-binary gender, but how do you deal with the case where you don't have a choice of gender?
20160828 15:33:27< vultraz> disable one, of course
20160828 15:33:50< celmin> Oh, I thought we were talking about a checkbox.
20160828 15:34:07< vultraz> oh wait, it is working
20160828 15:34:11< celmin> Which in retrospect doesn't really make much sense.
20160828 15:34:15-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160828 15:34:29< vultraz> i just need to disable the invalid options
20160828 15:35:54< vultraz> celmin: preview https://drive.google.com/file/d/0B-mR9s8FduLLU2V5TURBTzlsUnM/view?usp=sharing
20160828 15:36:20< celmin> Did it always show your recruit list?
20160828 15:36:35< vultraz> yes
20160828 15:36:45< celmin> I haven't seen that dialog for years, except in aeth's mod.
20160828 15:36:48< vultraz> but as a continuous comma-separated list that wrapped 
20160828 15:36:58< celmin> Yeah, bulleted is better.
20160828 15:37:48< vultraz> btw, i think i finally understand what mordante was working on with the tlist class
20160828 15:38:08< vultraz> it wasn't exactly a new implementation of tlistbox
20160828 15:38:16< vultraz> it was supposed to be a general list class
20160828 15:38:30< celmin> vultraz: Do you think unknown linked groups should just be ignored with a warning, instead of asserting?
20160828 15:39:02< vultraz> that could be used for more than the listbox does
20160828 15:39:09< vultraz> which only accepts toggle buttons and panels
20160828 15:39:10< gfgtdf> celmin: aserting is sureley the wrong way to handle invalid wml
20160828 15:39:18< celmin> gfgtdf: Yes, obviously.
20160828 15:39:23< vultraz> celmin: yes
20160828 15:39:43< vultraz> anyway, completing the tlist class would really be good, i think
20160828 15:40:03< vultraz> it'd save us from hacking tree views :)
20160828 15:40:20< celmin> Another possibility would be to implicitly add the linked group.
20160828 15:40:38< vultraz> anyway
20160828 15:40:41< vultraz> ill finish this tomorrow
20160828 15:41:06< celmin> Though that would leave the question of what defaults to give it, so I won't do that now.
20160828 15:42:48< celmin> I wish XCode wouldn't delete the executable at the start of compilation.
20160828 15:42:54< celmin> It should only delete it when the link stage begins.
20160828 15:43:07< celmin> Maybe even only when it's successful (put it in a temp location first.)
20160828 15:43:09< celmin> ^).
20160828 15:46:32-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160828 15:54:42< celmin> Hmm, has_maximum=false doesn't seem to have worked.
20160828 15:55:08< celmin> It won't let me select more than one.
20160828 15:56:00< celmin> Huh? Crash on quit?
20160828 15:57:20< celmin> Ah, the linked group again.
20160828 16:04:14< celmin> vultraz: Were you aware that listboxes support [list_data]?
20160828 16:06:33< celmin> Also, I figured out why has_maximum=false didn't work. Horizontal listboxes didn't support it yet.
20160828 16:06:43< celmin> I suppose that also means I need to update the schema...
20160828 16:10:44< celmin> I get the impression that tmatrix is like Swing's BorderLayout.
20160828 16:11:02-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160828 16:13:51-!- Bonobo [~Bonobo@ppp118-210-92-241.lns20.adl2.internode.on.net] has quit [Quit: Leaving]
20160828 16:20:28-!- Kwandulin [~Miranda@p200300760F4241EC6526DBFA838AA937.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160828 16:23:08-!- fabi [~fabi@176.5.22.123] has quit [Read error: No route to host]
20160828 16:23:26-!- fabi [~fabi@176.5.22.123] has joined #wesnoth-dev
20160828 16:26:35< vultraz> celmin: [list_data], eh?
20160828 16:26:46< vultraz> I vaguely recall something about that..
20160828 16:26:56< celmin> Well, this works, but I wonder if I can really manage it like this...
20160828 16:27:02< celmin> There's a small label definition right.
20160828 16:29:02< vultraz> default_small
20160828 16:29:07< vultraz> default_tiny is also a thing
20160828 16:29:09< celmin> [list_data] might make a lot of sense for tab bars.
20160828 16:30:11< celmin> Although...
20160828 16:30:29< celmin> I'm not sure I like the format.
20160828 16:31:02 * vultraz still thinks we should finish tlist
20160828 16:31:05< vultraz> eventually
20160828 16:31:09< celmin> Its contents are [row] and [column].
20160828 16:31:23< celmin> And the contents of [column] are the keys you'd put in the map passed to add_row.
20160828 16:31:56< celmin> What's unfinished about tlist? I haven't looked at it at all.
20160828 16:32:22< vultraz> i dunno
20160828 16:32:28< vultraz> all I know is it crashes
20160828 16:32:43< vultraz> it hasn't been touched in years, so that's to be understood
20160828 16:33:07< vultraz> plus it's missing a lot of stuff we added to tlistbox
20160828 16:38:49-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160828 16:39:15-!- Shiki [~Shiki@141.39.226.227] has quit [Client Quit]
20160828 16:48:23-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160828 16:51:29< celmin> With default_tiny, five categories barely fit at 800x600.
20160828 16:51:32< celmin> This isn't going to work.
20160828 16:51:37< vultraz> what are you doing?
20160828 16:51:42< celmin> I think I need the matrix generator...
20160828 16:51:46< vultraz> it sounds suspicious 
20160828 16:51:49< celmin> Which means bleh.
20160828 16:51:56< celmin> Hotkey categories.
20160828 16:52:03< celmin> As a filter type thing.
20160828 16:52:12< vultraz> uh... what?
20160828 16:52:50< celmin> It's hard to find hotkeys in that giant list.
20160828 16:53:10< celmin> So I want to be able to filter it by categories.
20160828 16:53:19< celmin> For example, planning mode or replay hotkeys.
20160828 16:53:21< vultraz> you can sort 
20160828 16:53:26< celmin> That doesn't help.
20160828 16:53:31< celmin> Because the names aren't always consistent.
20160828 16:53:46< celmin> It's not always obvious where to look even when they're sorted.
20160828 16:55:01< vultraz> I see
20160828 16:55:40 * vultraz cannot sleep, so he's finishing the dialog
20160828 17:03:24-!- fabi [~fabi@176.5.22.123] has quit [Ping timeout: 260 seconds]
20160828 17:04:43< celmin> tvertical_list::create_item is unimplemented… o.o
20160828 17:06:27< vultraz> was probably intended to go with tlist
20160828 17:06:47< vultraz> from the comment in that file, I gather tlist was supposed to be a generic list widget
20160828 17:07:22< celmin> Oh, tlist also uses the generator system?
20160828 17:07:48< celmin> tvertical_list and thorizontal_list look identical at first glance, so maybe implementing tmatrix wouldn't be that hard...
20160828 17:07:48< vultraz> i guess
20160828 17:07:57< vultraz> what exactly is tmatrix
20160828 17:08:48< celmin> There are two.
20160828 17:09:04< celmin> gui2::policy::placement::tmatrix is supposed to be a generator that lays out items in a grid.
20160828 17:11:24< celmin> "FIXME should we look at grow factors???"
20160828 17:11:29< celmin> In the list generators.
20160828 17:12:30-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160828 17:13:15< vultraz> blah, can't clean this crud out of the flg manager yet
20160828 17:13:25< vultraz> mp connect still uses it
20160828 17:14:31< celmin> So yeah, the horizontal and vertical list generators are almost identical.
20160828 17:15:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20160828 17:15:43< vultraz> if you can complete the generic list class AND make matrix generation work you'll have made gui2 25% more complete
20160828 17:15:44< vultraz> :P
20160828 17:15:51< celmin> BTW, gui2::tmatrix seems to be a five-pane layout similar to Swing's BorderLayout (though I haven't actually tried it out).
20160828 17:16:26< celmin> Adding defines to my build is kind of a pain, so I dunno if I'll do that.
20160828 17:17:13< vultraz> i don't recommend you do
20160828 17:17:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160828 17:17:25< vultraz> i recommend you remove said defines from bits of code you want to test
20160828 17:17:30-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160828 17:17:35< celmin> Well, that's possible, certainly.
20160828 17:17:49< vultraz> enabling the GUI2_EXPERIMENTAL_LISTBOX define breaks shit spectacularly 
20160828 17:17:59< vultraz> even worse if new_widgets is enabled
20160828 17:18:10< vultraz> though speaking of which, we should be able to remove that soon
20160828 17:18:14< celmin> What is new_widgets, anyway?
20160828 17:18:24-!- fabi [~fabi@176.5.22.123] has joined #wesnoth-dev
20160828 17:19:01-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160828 17:19:36< zookeeper> <zookeeper> tad_, in case you read the logs: there's some matches for name.*\$\(\$ in mainline campaigns. for example name="turn $($turn_number+3)" seems to be used successfully in UtBS... unless someone has broken something regarding it.
20160828 17:19:40< vultraz> enabled experimental stuff
20160828 17:19:44< vultraz> like the gui2 addons manager
20160828 17:19:46< tad_> vultraz: Just tested your change for Load panel. At first blush, looks good.
20160828 17:19:51< vultraz> and gui2 load dialog
20160828 17:19:58< vultraz> tad_: sweet
20160828 17:20:06< vultraz> celmin: it's not needed much anymore
20160828 17:20:11< vultraz> mostly internal controls
20160828 17:20:13< celmin> Hmm, how to calculate best size for a matrix...
20160828 17:20:18< vultraz> related to tlist, I think
20160828 17:21:47< tad_> celmin: Didn't you recently make changes to title screen redraw on size change? Bug: if the window is maximized by window manager on clean start (no configs or cache) the default size is used instead of the WM-provided size. Need to Restore then Maxmize again to get full-windows display.
20160828 17:22:26< celmin> tad_: No, it already redrew on size change. What I did is make it rebuild on size change.
20160828 17:23:14< tad_> celmin: OK. Well it needs to force a 'size change' when it comes up for the very-first time, I guess.
20160828 17:23:36< celmin> What do you mean by "the default size is used"?
20160828 17:24:28< tad_> celmin: looked to me to be 800x600 and the rest of the window was frozen snapshot of what was below the window.
20160828 17:24:44< celmin> Weird.
20160828 17:24:56< vultraz> ...oh deer
20160828 17:24:59< vultraz> not that :|
20160828 17:26:24< tad_> Prior to clearing cache/config and local/share I was running Maximized (Arch Linux, lxdm) .. the display manager remembers Maximized but BfW went with Normal window at some smaller size.
20160828 17:26:54< vultraz> wesnoth also memorizes maximized
20160828 17:27:02< vultraz> internally
20160828 17:27:17< vultraz> but..
20160828 17:28:36< vultraz> let's call it an odd corner case and forget about it
20160828 17:29:03< tad_> zookeeper: I got it working. Needed $($($value + const)). I'm in a nested event creating an event which contains a nested event which is me. "At this turn, plus 4, do an event which, if fired, repeats itself at that-turn, plus 2"
20160828 17:29:36< zookeeper> oh, right, _that_ nested
20160828 17:30:04< celmin> tad_: You can delay substitution with $|(…) or $||(…) etc if needed.
20160828 17:30:23< celmin> If using delayed_variable_substitution=yes at all levels is not an options.
20160828 17:30:25< zookeeper> what exactly do you need 4 levels of depth for?
20160828 17:30:25< tad_> vultraz: I deleted all .cache, .config and ./local/share/.../1.13 so wesnoth should not be remembering a darned thing
20160828 17:30:25< celmin> ^option
20160828 17:30:31< vultraz> hm
20160828 17:30:33< vultraz> true
20160828 17:30:40< vultraz> why do you keep deleting your files? :P
20160828 17:31:39< tad_> vultraz: First time: I wanted to get to a known-clean state to test your Load panel and be sure it wasn't residuals before telling you about it.
20160828 17:32:01< tad_> vultraz: That tickled a bug which Celmin has corrected.
20160828 17:32:07< vultraz> ah
20160828 17:32:15< tad_> vultraz: So, today, testing both at once ..
20160828 17:32:52-!- Kwandulin [~Miranda@p200300760F4241EC58C10909B6FEF74E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160828 17:33:08< vultraz> alright, dialog done
20160828 17:33:11< vultraz> will commit it later
20160828 17:33:22< celmin> So, $|($|value + const) delays the substitution to happen in the event at the first level of nesting, $||($||value + const) makes it happen at the second level, etc.
20160828 17:34:38< tad_> zookeeper: I was playing around with TSG S05 and decided the Water Serpent was "boring" and gave it "motivation" by declaring it "her" and the island village her "nest" and wanting to see if I could trigger a spawn at "moveto-now, plus 4 .. and every other, thereafter, unless stopped" actually works well and is clean code, once I figured out the delayed substitutions and evals to make it work.
20160828 17:35:31-!- midzer_ is now known as midzer
20160828 17:37:34< tad_> zookeeper: If you're interested I can push it to TSG-elven but I'm partway through refactoring the dialogs in the direction I think you wanted it to go.
20160828 17:37:34< celmin> Maybe make island village ruined, then? Since it'd be a bit weird for a water serpent to be nesting in a normal village.
20160828 17:37:58< zookeeper> tad_, okay. i'd think that it'd be more comfortable to just use [filter_condition]ed events instead of nesting several levels deep, but if it works...
20160828 17:38:14< tad_> zookeeper: In fact, maybe I should do that so you can stop me before I go too far afield on the rewrite...
20160828 17:40:00< tad_> zookeeper: gimme a few to pay attention to the wife and I'll push the WIP as a new branch
20160828 17:40:16< zookeeper> no hurry
20160828 17:47:46-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160828 17:47:51< tad_> zookeeper: TSG-S05rewrite .. the water serpent stuff is at end .. the dialog I'm working on is in "The Lich" section and I've only done the "Urza alive and allied when we killed" side and done a quick run-through. 
20160828 17:48:17< tad_> zookeeper: it's a major change right now .. "View" as full file might be best. diff will be a mess.
20160828 17:59:24< celmin> I suddenly had a vague idea about how to prevent listboxes from expanding too much.
20160828 17:59:58< celmin> Add max_visible_rows=; if present, it generator only considers up to that many rows when calculating its best size.
20160828 18:01:12< tad_> celmin: And add min_visible_rows= and don't forget to handle min>max case ...
20160828 18:01:20< celmin> Yeah.
20160828 18:01:26< celmin> Not sure if it's a good idea, but it's a thought.
20160828 18:02:04< tad_> celmin: in general, when given min and max for a listbox, I tend to use both as set them equal ...
20160828 18:03:06< celmin> I don't think I'd want that in general.
20160828 18:04:29< tad_> That goes to "things I don't like" .. such as leaning on the Delete button in Load Saved Game panel and having the button move because I'm getting close to having deleted them all. At least, when it moves, what moves in under my mouse cursor is blank space. Things would get messy if it were a button to "Uninstall Wesnoth" ...
20160828 18:05:10< celmin> Well, that's a separate issue from what I'm thinking about though.
20160828 18:05:41< celmin> That's listbox rows not expanding to fill the available width.
20160828 18:05:45< tad_> celmin: sure buts it's all "UX" and I tend to be very conservative when it comes to UX
20160828 18:12:05-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20160828 18:13:13< zookeeper> huh... does this actually work right? id=Deoran,Ethiliel,"Minister Hylas"
20160828 18:13:26< zookeeper> the quoting, that is
20160828 18:13:35< tad_> Yep. id= there is an implied "or" relationship
20160828 18:13:45< tad_> Oh, yes, too.
20160828 18:14:06< tad_> I'll re-check to be sure, though.
20160828 18:15:12< tad_> My problem is I really REALLY dislike the "everything is a string thing. To my mind, an ID should be like a programming language identifier .. leading alpha followed by only alpha numeric and underscore
20160828 18:16:10< tad_> So I'm trying to en-quote the identifiers I don't like so I know to be careful with ' vs ´ and spaces
20160828 18:17:26< celmin> vultraz: About that problem, does putting the list row's root toggle panel in a linked group help?
20160828 18:17:34< vultraz> what?
20160828 18:17:45< celmin> The problem of rows not filling the listbox width.
20160828 18:18:13< vultraz> uh
20160828 18:18:19< vultraz> gfgtdf fixed that
20160828 18:18:25< celmin> Oh, did he? Okay then.
20160828 18:19:59< vultraz> if you're referring to the issue in the lobby where listbox rows would shrink
20160828 18:20:01< vultraz> than yes
20160828 18:20:03< vultraz> then
20160828 18:20:14< tad_> celmin:  are you speaking of columns not filling the width? rows not filling the height? Does the width change if I arrow down and find a columm which was wider or all the displayed columns become narrower (I truly hate that behavior)? Does the height change if I do something to add or remove rows (dislike that, too)
20160828 18:20:35< celmin> I've kinda lost that train of thought no….
20160828 18:20:39< vultraz> what...
20160828 18:20:51< celmin> What exactly were we talking about?
20160828 18:21:05< vultraz> ok for the record, someone should look into removing the calls to invalidate_layout in the set_row_shown functions
20160828 18:21:11< vultraz> dunno if that's relevant
20160828 18:21:26< celmin> The initial thing I was bringing up was that it's hard to lay out things around a list box because they greedily consume too much space.
20160828 18:21:32< vultraz> and i have no idea what tad_ is on about
20160828 18:21:49< vultraz> that is true
20160828 18:22:00< tad_> vultraz: ok I'll quiet down
20160828 18:22:18< tad_> zookeeper: re-testing that id= now
20160828 18:24:07< celmin> tad_: I do know that rows out of view are considered as if they were visible. Rows hidden by a filter or similar are not though.
20160828 18:24:38< celmin> Height or width may change if new rows are added.
20160828 18:24:47< celmin> Not quite sure about height though.
20160828 18:25:26< vultraz> of course height may change if rows are added..
20160828 18:26:32< tad_> celmin: I like some of the dialog designers with flexible areas. But once the major elements (such as buttons) are drawn I **really** dislike them moving. I don't mind a listbox growing and shrinking if all that moves are the scrollbar buttons but having the element I'm using moving when I'm using it really bites.
20160828 18:27:32< celmin> Yeah, GUI2 maybe is a little too flexible in that regard...
20160828 18:28:11 * vultraz shakes head
20160828 18:30:41< tad_> zookeeper: according to inspect id=name,name,"name" becomes id="name,name,name"
20160828 18:31:38< celmin> I'd guess it also works without any quotes at all.
20160828 18:31:44< zookeeper> yes, it would
20160828 18:32:16< celmin> Things don't need to be quoted just because they have spaces.
20160828 18:32:25< celmin> I think unquoted text does have the whitespace collapsed though.
20160828 18:32:29< tad_> zookeeper: and testing actual play it works as expected
20160828 18:33:50-!- irker378 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160828 18:33:50< irker378> wesnoth: Charles Dang wesnoth:master 2bffd4af5632 / / (10 files in 6 dirs): Convert Select Faction (FLG) dialog to GUI2 https://github.com/wesnoth/wesnoth/commit/2bffd4af563296308a485ff404b74fb048d6955a
20160828 18:33:55< vultraz> inb4 travis breaks
20160828 18:34:15< zookeeper> tad_, yeah, i'd advice against it thought because it's just... wrong :p
20160828 18:34:37< zookeeper> s/thought/though
20160828 18:35:20< tad_> zookeeper: matter of personal preference. I've been thinking of using " a lot more .. so the code I write looks more like what I see when I inspect, actually.
20160828 18:36:48< celmin> Did you utterly remove the GUI1 version this time?
20160828 18:37:01< vultraz> yes
20160828 18:37:05-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160828 18:37:44< celmin> Do you want me to add the test? It'll have to wait until I get the matrix working though.
20160828 18:37:53< celmin> (The implementation is done, but no idea if it'll work.)
20160828 18:38:02< celmin> (Well, done except for arrow keys.)
20160828 18:38:15< irker378> wesnoth: Charles Dang wesnoth:master 3d59b753c9eb / data/gui/window/drop_down_list.cfg: Drop Down List: provided a reasonable max height https://github.com/wesnoth/wesnoth/commit/3d59b753c9eba5d20000960ea79676bf44cd09a2
20160828 18:38:18< irker378> wesnoth: Charles Dang wesnoth:master d2191297c58f / data/gui/widget/image_default.cfg: Image: center drawn image on available space https://github.com/wesnoth/wesnoth/commit/d2191297c58f61fce9899dc5cf9559da55c7296f
20160828 18:39:23< vultraz> celmin: feel free if you can make one
20160828 18:39:38< celmin> Unless there's something weird in the flg_manager, it should be trivial.
20160828 18:40:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160828 18:40:06-!- wedge010 is now known as wedge009
20160828 18:40:10< zookeeper> tad_, if you want to quote identifiers more than usual then sure that's fine. it's just the kind-of-wrong-but-happens-to-work id=name,name,"name" form i'm referring to.
20160828 18:42:45< tad_> zookeeper: I understood that. I did notice elsewhere (HttT, I think, maybe DM) someone had gone through type= lists and (a) quoted the entire list, and (b) removed unneeded whitespace .. which caused me to start thinking about the issues and flopping about for a way to express it clearly and consistently.
20160828 18:44:11< tad_> zookeeper: Note that my normal work-flow is to make huge changes then read the diff output and try to reduce the actual effect to the minimum needed before I make a final commit for an "idea" .. what you're viewing there is my "and the kitchen sink" free-flow ideas phase.
20160828 18:44:52-!- gfgtdf [~chatzilla@x50abb183.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160828 18:45:27< vultraz> tad_: I'd say that's similar to most workflows
20160828 18:46:03< zookeeper> tad_, all right. i presume the ifdefs for the serpent and similar are part of that phase?
20160828 18:46:53< tad_> zookeeper: actually the #idndefs are really there so I can code-fold cleanly. Yes, they'll probably go away. But they're tested and working if we want to keep 'em.
20160828 18:47:31< tad_> zookeeper: In serpents it allows me to fold and compare to the original and see it's just additions and no omissions.
20160828 18:50:04< tad_> An example of where it changes for this phase and will certainly change back: the map change for side 3/4 swap. I wanted that so I could eliminate the zombies and sepents for testing but I consider that a "spurious" change and will not commit it when I clean up.
20160828 18:51:03< zookeeper> well, if they were kept then sooner or later someone would just remove them and the commit message would say something like "cleanup code by removing unnecessary preprocessoring"
20160828 18:51:40< vultraz> zookeeper: you know me so well
20160828 18:52:09< zookeeper> yes
20160828 18:52:51< tad_> zookeeper: yep. I do try to carefully read my diffs .. I hate even a white-space change like a blank line suddenly getting a number of spaces. to my mind a diff should be just the changes and nothing unrelated or spurious.
20160828 18:53:24< vultraz> tidy tad_ is tidy
20160828 18:54:15< celmin> tad_: +10
20160828 18:54:21< vultraz> celmin: i'm unsure how to add that multi-member setter thing...
20160828 18:54:25< celmin> I agree 100%
20160828 18:54:32< celmin> vultraz: The what thing?
20160828 18:54:43< vultraz> adding a mass-callback setter to tgroup
20160828 18:55:43< celmin> Oh, to tgroup.
20160828 18:55:49< celmin> What's the motivation?
20160828 18:56:22< vultraz> to avoid having to set the same callback on multiple widgets manually
20160828 18:56:47< celmin> Somehow I feel like that doesn't answer my question.
20160828 18:57:34< zookeeper> tad_, yes, that's a good approach to diffs
20160828 18:57:49< vultraz> celmin: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/faction_select.cpp#L71
20160828 18:58:02< vultraz> it'd be nice if that could be done with one statement instead of 3
20160828 18:58:27< celmin> Right.
20160828 18:58:42< celmin> You'd want the selection event for that, I think, same as a listbox.
20160828 18:58:56< vultraz> ..what?
20160828 18:59:13< celmin> At least, unless something prevents it.
20160828 18:59:19< vultraz> what's wrong with set_callback_state_change
20160828 18:59:20< tad_> zookeeper: years (decades) ago I was lead maintained for a core protocol reference implementation. I can't count the number of patches I got by email which I disapproved pending cleanup because there was no reason to remove those blank lines and they muddied up the diff making it harder to see what actually changed.
20160828 18:59:26< celmin> Nothing?
20160828 18:59:34< vultraz> right
20160828 18:59:52< vultraz> im just unsure how to pass a reference to a function from another class
20160828 19:00:00< celmin> ...
20160828 19:00:03< celmin> Seriously.
20160828 19:00:10< vultraz> syntax :|
20160828 19:00:25< celmin> There's no difference?
20160828 19:01:11 * tad_ is old-school "C" .. cast to (void *) and run for cover when the "C++" geeks see what you did!
20160828 19:01:26 * vultraz chases tad_ away
20160828 19:01:38< celmin> Okay, so I need a definition for the new widget...
20160828 19:02:49< vultraz> celmin: does this look alright? http://pastebin.com/QkdAY8BP
20160828 19:03:26< celmin> That accepts a function returning function_class.
20160828 19:03:32< celmin> And taking no arguments.
20160828 19:03:43< vultraz> oh
20160828 19:03:44< celmin> So probably not what you want.
20160828 19:03:51< celmin> Line 7 is fine though.
20160828 19:04:02< celmin> Well no, actually it isn't.
20160828 19:04:24< celmin> It would be fine if that was what you passed to set_member_callbacks to begin with.
20160828 19:04:37< celmin> BTW, set_member_callbacks is a terrible name.
20160828 19:04:58< celmin> What was the function for setting a callback when the list selection changes? A name more similar to that seems better.
20160828 19:05:13< vultraz> set_callback_value_change
20160828 19:05:22< celmin> Oh you're using dialog_callback huh.
20160828 19:05:36< celmin> I don't remember its type-params.
20160828 19:05:56< vultraz> now that you mention that, I probably don't need that here.
20160828 19:06:02< vultraz> but at the call site..
20160828 19:07:38< vultraz> as for why I use state_change, that's what I always use for toggle button callbacks
20160828 19:07:48< vultraz> i don;t think value_change works
20160828 19:07:56< vultraz> different widgets have different callback names
20160828 19:08:02< vultraz> and different formats for how they're used
20160828 19:08:06< celmin> I'm talking about the name of your group function, not the function that you set on each member.
20160828 19:08:11< vultraz> oh
20160828 19:09:13< vultraz> how does set_callback_on_state_change sound
20160828 19:09:44< celmin> Well, from the group's perspective, isn't it "the selected item has changed"? State change doesn't seem to reflect that.
20160828 19:10:14< celmin> Actually, you should probably wrap the passed callback so that it only triggers when the state is set to "yes".
20160828 19:10:29< celmin> Looks like my matrix crashed. Fun!
20160828 19:10:34 * vultraz groans
20160828 19:10:46< vultraz> you make life complicated for me
20160828 19:10:50< celmin> Right, I'll comment that assert and see if it works.
20160828 19:11:16< celmin> It's just leftover from the vertical listbox after all, so maybe it doesn't apply for the matrix.
20160828 19:12:01< vultraz> i'm interested in seeing what this magic matrix looks like
20160828 19:12:36< celmin> Me too.
20160828 19:12:36< tad_> vultraz: I just played into TSG S05 turn 1 to test the id= for zookeeper .. restarted and went to Load .. it shows "?" for Deoran. So I loaded and immediately did Ctrl-O to check the Load again .., and now it shows his icon.
20160828 19:12:40-!- gfgtdf [~chatzilla@x50abb183.dyn.telefonica.de] has joined #wesnoth-dev
20160828 19:12:48< tad_> vultraz: But at least there's just one of him!
20160828 19:12:49< celmin> I'm also interested in seeing what the other matrix looks like.
20160828 19:13:08< vultraz> tad_: what your describe is expected
20160828 19:13:20< vultraz> tad_: it shows ? if it cannot find the image
20160828 19:13:27< vultraz> tad_: once you load TSG, it can
20160828 19:13:53< tad_> vultraz: Well what's the point of the image if you can only see it AFTER you've loaded that save?
20160828 19:13:58< vultraz> this isn't a problem on new saves created in-game, though
20160828 19:14:13< vultraz> so you'll only end up with ? if you clear your save_index or something
20160828 19:14:28< celmin> Thinking about it logically, the matrix would sort of make sense on the titlescreen, but it's not used there.
20160828 19:14:38< tad_> No .. I cleared .. played in .. quit .. started and it was "?"
20160828 19:15:09< vultraz> is this save from before you cleared?
20160828 19:15:22< celmin> [matrix] is used in the debug clock and nowhere else, huh...
20160828 19:15:41< vultraz> the debug clock is totally broken, for the record
20160828 19:15:59< celmin> Didn't seem like it when I tried it awhile back.
20160828 19:16:07< vultraz> the layout is
20160828 19:16:25< celmin> Do you know what tpopup is BTW?
20160828 19:16:29< vultraz> ok, this seems to be working
20160828 19:16:31< vultraz> uhh
20160828 19:16:34< vultraz> has to do with tooltips
20160828 19:16:36< gfgtdf> vultraz: do you know why we have a GUI2_EXPERIMENTAL_LISTBOX macro instad of just 2 different classes tlist and tlistbox than have a be used at the same time?
20160828 19:16:37< vultraz> i think..
20160828 19:16:42< celmin> I see.
20160828 19:16:46< vultraz> dunno
20160828 19:16:53< vultraz> the tooltips are rather over-engineered
20160828 19:16:55< vultraz> gfgtdf: i do not
20160828 19:17:03< gfgtdf> hmm ok
20160828 19:17:06< celmin> gfgtdf: Probably because the macro swaps out listboxes for lists in a million places.
20160828 19:17:12< vultraz> gfgtdf: tlist is supposed to be used in the new implementation of tlistbox after the former is done
20160828 19:17:24< vultraz> it's not supposed to replace 
20160828 19:17:36< celmin> Bleh.
20160828 19:17:54< vultraz> but in the cases with the macro, i think the 'experimental' code should probably be used 
20160828 19:19:25< celmin> Hmm, come to think of it, maybe a matrix would simplify things like MP create a bit - put the title in [top], the buttons in [bottom], everything else in [main]...
20160828 19:19:27< vultraz> gfgtdf: are you looking into tlist?
20160828 19:19:50< vultraz> celmin: ...what?
20160828 19:20:21< celmin> Well, the grid listbox works… sort of. I think the placement algorithm is a bit off.
20160828 19:20:31< vultraz> ...what?
20160828 19:20:46< tad_> zookeeper: yuck. S05 rewrite plays OK for the changed part but is really buggy elsewhere .. well, I did just snapshot the WIP and have a lot more to go through but I didn't think I'd broken it so badly.  **sighs**
20160828 19:21:02< celmin> vultraz: gui2::tmatrix appears to be a widget that has a central grid, plus optional grids anchored on any of the four sides.
20160828 19:21:03< vultraz> also
20160828 19:21:04< vultraz> [06:10:12]	celmin	Actually, you should probably wrap the passed callback so that it only triggers when the state is set to "yes".
20160828 19:21:06< vultraz> i don't know how to do this
20160828 19:21:34< vultraz> celmin: how does it handle corners?
20160828 19:21:45< celmin> No idea, haven't tried it.
20160828 19:21:48< vultraz> top/bot overflow or left/right?
20160828 19:22:02< celmin> Something like [](tselectable_& w) {if(w.get_value_bool())(callback());}
20160828 19:22:18< celmin> Details may differ a lot, but that's the basic idea.
20160828 19:22:43< celmin> As for what I said about the grid listbox, it looks like it's reserving space for a second row, but instead the final element is cut off at the right.
20160828 19:22:54< celmin> So, placement is wrong for end-of-row elements.
20160828 19:23:34< celmin> Or set_origin? One or both of those.
20160828 19:24:07< celmin> Not sure how to fix though… will probably take some time...
20160828 19:24:18< celmin> So I'm gonna take a break and come back to it later.
20160828 19:25:10< celmin> Incidentally, it probably wouldn't be too hard to have a GUI2 widget that lets you place child widgets at arbitrary spatial locations.
20160828 19:25:21< celmin> Not that we'd want such a thing.
20160828 19:27:38-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 19:27:39< travis-ci> wesnoth/wesnoth#10582 (master - 2bffd4a : Charles Dang): The build has errored.
20160828 19:27:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155772957
20160828 19:27:39-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 19:27:42< vultraz> hmm
20160828 19:27:48< vultraz> how do i get an argument for callback..
20160828 19:28:07< celmin> I don't know what you're asking.
20160828 19:35:15 * vultraz doesn't know what he's doing
20160828 19:37:09< celmin> That doesn't help either.
20160828 19:37:59< vultraz> celmin: can you help me out :| http://pastebin.com/bE2jpsSF
20160828 19:38:58< celmin> I think I'd capture func by value there.
20160828 19:39:06< celmin> Anyway, what's the problem?
20160828 19:39:45< vultraz> (for the record, earlier when I said I was confused, I was mostly confused about making this interact with gui2's weirdness... I had forgotten i should use dialog_callback at the call site)
20160828 19:39:52< vultraz> ..\..\src\gui\widgets\group.hpp|130|error: conversion from 'gui2::tgroup<T>::set_callback_on_value_change(const std::function<void(gui2::twidget&)>&) [with T = std::__cxx11::basic_string<char>]::<lambda(gui2::tselectable_*)>' to non-scalar type 'const std::function<void(gui2::twidget&)>' requested|
20160828 19:41:21< celmin> What line is that in the paste?
20160828 19:42:09< vultraz> points me to 10 for some reason
20160828 19:42:36< celmin> What if you use auto instead of std::function?
20160828 19:44:44< celmin> The std::function and the lambda have different, incompatible signatures.
20160828 19:44:57< celmin> void(twidget&) vs void(tselectable_*)
20160828 19:45:37< vultraz> ..\..\src\gui\widgets\group.hpp|134|error: no matching function for call to 'gui2::tselectable_::set_callback_state_change(const gui2::tgroup<T>::set_callback_on_value_change(const std::function<void(gui2::twidget&)>&) [with T = std::__cxx11::basic_string<char>]::<lambda(gui2::tselectable_*)>&)'|
20160828 19:45:47< celmin> Probably same problem.
20160828 19:45:59< celmin> First problem is pointer vs reference.
20160828 19:46:16< celmin> The fact that twidget and tselectable_ are unrelated is also a problem though.
20160828 19:47:52< celmin> Oh wait, callback() is supposed to correct for the second problem, I bet.
20160828 19:52:36< fabi> There is no more "end turn" in the context menu.
20160828 19:53:53< vultraz> celmin: ok, this works
20160828 19:53:55< vultraz> 		const auto callback = [func](twidget& widget)->void {
20160828 19:53:56< vultraz> 			if(dynamic_cast<tselectable_*>(&widget)->get_value_bool()) {
20160828 19:53:58< vultraz> 				func(widget);
20160828 19:53:59< vultraz> 			}
20160828 19:54:01< vultraz> 		};
20160828 19:54:48< vultraz> fabi: yeah IIRC I removed that
20160828 19:55:02< celmin> Yay.
20160828 19:55:15< vultraz> celmin: is it acceptable?
20160828 19:55:26< celmin> Though note that dynamic_cast can return nullptr when its template argument is a pointer.
20160828 19:55:41< fabi> vultraz: You removed the "end turn" from the context menu deliberately?
20160828 19:55:48< vultraz> fabi: iirc yes
20160828 19:56:13< celmin> May be logically impossible in this case though? I dunno.
20160828 19:56:33< vultraz> likely, yes
20160828 19:58:23< celmin> Which means you could assert it if you want, though I guess not required.
20160828 19:58:59< irker378> wesnoth: Charles Dang wesnoth:master 185724fc9409 / src/gui/ (3 files in 3 dirs): tgroup: added a function to set the callback for all members https://github.com/wesnoth/wesnoth/commit/185724fc9409f9bfb391a5df9db2106a6e75769c
20160828 19:59:25< vultraz> im honestly very surprised it works
20160828 20:00:23< celmin> Why are you so surprised?
20160828 20:00:27-!- mjs-de [~mjs-de@x4db6b9d1.dyn.telefonica.de] has joined #wesnoth-dev
20160828 20:01:14< vultraz> because I'm bad with this kind of advanced stuff
20160828 20:01:19< vultraz> (well, advanced to me)
20160828 20:01:23< vultraz> (probably cake to you)
20160828 20:03:05< irker378> wesnoth: Charles Dang wesnoth:master 1a82a37ea1dd / src/gui/widgets/group.hpp: tgroup: made group_operator private and did some formatting cleanup https://github.com/wesnoth/wesnoth/commit/1a82a37ea1dd5670721065d1f4c72e7a052bf82c
20160828 20:03:08< celmin> Exaggeration.
20160828 20:03:21< celmin> I wouldn't call it cake, but nor would I consider it really hard.
20160828 20:04:22< celmin> The comment could've better gotten across the idea that it's called when the group's selected element changes (which is slightly different from setting them all individually, right?).
20160828 20:04:54< celmin> You know, when I decide to change the visibility of something, I usually just add a visibility label before and after it. >_>
20160828 20:05:01< vultraz> well to change the group's selected element they all need to change their states
20160828 20:05:12< vultraz> ...what?
20160828 20:05:20< vultraz> oh
20160828 20:05:21< celmin> Probably bad practice, really.
20160828 20:05:25-!- Nobun [~nobun@87.13.73.190] has joined #wesnoth-dev
20160828 20:14:06-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 20:14:07< travis-ci> wesnoth/wesnoth#10583 (master - d219129 : Charles Dang): The build has errored.
20160828 20:14:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155773509
20160828 20:14:07-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 20:14:34< celmin> It works! \o/
20160828 20:23:34< vultraz> what does?
20160828 20:25:27-!- Kwandulin [~Miranda@p200300760F4241EC58C10909B6FEF74E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160828 20:25:38< tad_> "sudo rm -fR /" works, but only once ;)
20160828 20:26:41< irker378> wesnoth: Charles Dang wesnoth:master 898d98ab8d28 / data/gui/ (widget/image_default.cfg window/mp_faction_select.cfg): Split image widget into two definitions, default and centered (redo of d2191297c https://github.com/wesnoth/wesnoth/commit/898d98ab8d2853a9dec6af72f14b9bbe142caa0b
20160828 20:27:04< vultraz> turns out centered isn't the best behavior everywhere
20160828 20:27:47< celmin> The grid listbox.
20160828 20:28:06< celmin> It can even have uneven cells if you don't use a linked group.
20160828 20:28:28< celmin> I feel like something's still not quite right in the grid listbox, but that can be fixed later.
20160828 20:34:27-!- JyrkiVesterinen [~JyrkiVest@78-27-120-22.bb.dnainternet.fi] has quit [Quit: .]
20160828 20:36:29 * tad_ chuckles. "Attempt to appease Travis" .. A new scenario where Konrad and Li'sar, now middle-aged, are faced with a renewed threat .. undead are invading from the far south, lead by an Ancient Lich known as "Travis". In an attempt to appease him, they sacrifice one hundred newborn lambs. But this does not work. So they steal Delfador's staff and that does not work. In desperation, they ally with the northern Orc tribes ... 
20160828 20:36:35< celmin> Trying to figure out if I can still use set_callback_value_change...
20160828 20:38:34< celmin> I think I can.
20160828 20:41:18< fabi> tad_: Is all your httt doings in?
20160828 20:43:14< tad_> fabi: still a lot of PRs. The error fixes are merged. Zookeeper (et al?) are considering "general improvements". I've not looked at the branches for several days.
20160828 20:43:28< tad_> fabi: Is there something in particular you're looking for?
20160828 20:43:46< celmin> BTW, did you find any used for [filter]type_tree?
20160828 20:43:49< celmin> ^use
20160828 20:44:00< fabi> tad_: Well, I thought about replaying the campaign. It would make sense to wait until you finished polishing.
20160828 20:44:15< tad_> celmin: It's on my "use this when next you run up against the issue" list.
20160828 20:44:40< tad_> fabi: It might help to pull the PRs and play-test.
20160828 20:44:49< celmin> You're aware it doesn't have special handling in [role] as type does, right?
20160828 20:45:36< fabi> tad_: Can you give me the git line to merge it in?
20160828 20:45:52< tad_> celmin: Yes. I s'pose I could dive back into HttT and use the new feature where it makes sense. But I'm trying to let HttT stay unchanged so any testing/thinking is not against a moving target
20160828 20:46:24< celmin> I just meant to imply that it wouldn't (currently) work as you might expect in [role].
20160828 20:46:29< tad_> fabi: I'd have to google it .. "test a PR locally" or something like that. it's not hard I just don't remember the command.
20160828 20:46:35< celmin> I think.
20160828 20:47:02< celmin> fabi: First of all, make sure you're on a branch, not master.
20160828 20:47:21< celmin> You can merge a PR with something like git pull origin refs/pull/###/head
20160828 20:47:31< celmin> Might be pulls rather than pull, or uppercase HEAD.
20160828 20:47:50< tad_> celmin: It won't do what I wanted in HttT (prioritize units for roles) but there are many places where you just want to check you have a bowman, or any avancement, and I will certainly use it when I hit those.
20160828 20:48:15< celmin> (The reason I say "make sure you're on a branch" is so that you don't accidentally merge it like mattsc did awhile ago.)
20160828 20:48:52< tad_> celmin: Yes, it's something like that. checkout -b from master to get a clean playground then refs/pull .. but I forget the detaiks .. google is your friend
20160828 20:49:01< celmin> Yeah
20160828 20:49:13< celmin> Also note that there are multiple PRs here.
20160828 20:49:46< tad_> fabi pull "general improvements" first and all the others should merge without regard to order
20160828 20:51:03< tad_> fabi: Your "normal" player probably won't see most of my fixes and improvements .. they're mostly edge conditions .. but all those subject PRs are definitely normal-player-visible.
20160828 20:52:13-!- mjs-de [~mjs-de@x4db6b9d1.dyn.telefonica.de] has quit [Remote host closed the connection]
20160828 20:53:29-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160828 20:54:48-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Client Quit]
20160828 20:56:17 * tad_ wonders if he should take a couple hours and rebase all those HttT PRs to current master and do a run-through to be sure nothing's broken ...
20160828 20:56:57< celmin> You can do a run-through in a couple of hours?
20160828 20:57:40< tad_> I use debug heavily and my process is to check the main paths work .. I don't re-test ALL the edge conditions .. that would take a week!
20160828 20:59:21< fabi> tad_: Write unit_test scenarios for the edge conditions and test them non interactiv.
20160828 21:00:30-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 21:00:31< travis-ci> wesnoth/wesnoth#10584 (master - 185724f : Charles Dang): The build has errored.
20160828 21:00:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155784555
20160828 21:00:31-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 21:00:50< tad_> fabi: How do I tell HttT S01 to kill [0..3] enemy leaders then play through to S07 and check the math for the number of random ambushers?
20160828 21:01:52< celmin> Unit tests for campaigns are kind not really supported at the moment, I think.
20160828 21:02:03< celmin> ^kinda
20160828 21:02:28< celmin> I suppose you could write a tiny [test] pair, maybe.
20160828 21:02:49< celmin> [test] does support next_scenario after all.
20160828 21:03:42< fabi> It would be nice for [test] and other scenario top level tags to support parent=
20160828 21:03:54< tad_> celmin: Didn't even know you could even attempt to automate testing a campaign. There are so MANY conditions. But I s'pose I could work it out. Probably take a month or three and definitely is a project all its own.
20160828 21:04:03< fabi> so you can derrive from the scenario you whish test.
20160828 21:04:11< celmin> The problem is that to test it, you need to copy the relevant logic into a test scenario.
20160828 21:04:32< celmin> What fabi described would be great but is also impossible, because the HTTT scenarios don't exist during testing.
20160828 21:04:58< tad_> And, I'd declare that a failed test. If I can't test the 'live' code it's not a very good test.
20160828 21:05:07< celmin> Yeah.
20160828 21:05:26< celmin> Maybe it could be tested with a plugin..
20160828 21:05:36< celmin> Though plugins only support multiplayer at the moment.
20160828 21:06:16< fabi> I don't see why a test scenario can't source the httt to be tested one 
20160828 21:06:17< celmin> I was thinking of adding campaign and editor support for them.
20160828 21:06:28< celmin> fabi: Because you can't source a scenario that doesn't exist?
20160828 21:06:36< celmin> During the test context, the HTTT scenarios are not loaded.
20160828 21:06:39< Nobun> I don't understand what kind of problem. in particular, are you facing on testing httt
20160828 21:06:42< fabi> then load it
20160828 21:06:56< fabi> With simple include directives.
20160828 21:07:13< celmin> I don't think that's a good solution, because it means the scenario is now always loaded.
20160828 21:07:17< tad_> celmin: Something like a scripted user agent. "Move Konrad to goal post. Kill side 4 leader. Jump to S07, on start event verify side 2 plus side 3 have N units ..."
20160828 21:07:20< celmin> (Or always in debug mode at least.)
20160828 21:07:29< celmin> tad_: Yeah, that seems to be what plugins do.
20160828 21:08:37< celmin> A plugin is a Lua script run as a coroutine.
20160828 21:09:00< celmin> I think the API is currently undocumented. It's used by the MP test in join.lua and host.lua.
20160828 21:09:15< celmin> And it currently only supports server multiplayer.
20160828 21:09:28< tad_> Nobun: the issue testing HttT is I have touched hundreds of lines of code adding checks for edge conditions and unexpected sequences of play and a good test suite would allow me to, effectively, do a code-coverage test checking the game state as needed.
20160828 21:09:37< celmin> I don't know what it supports once a game has actually started.
20160828 21:09:51< Nobun> thank, tad_ 
20160828 21:11:08< fabi> tad_: I don
20160828 21:11:23< fabi> 't agree with celmin on the unit test scenario issue.
20160828 21:11:50< fabi> At least the last Wesnoth version was able to select a test suite from the commandline.
20160828 21:12:16< celmin> I think there's a command-line option to set a define.
20160828 21:12:19< fabi> You can use #ifdefs to guard the code not loaded.
20160828 21:12:38< fabi> s/not loaded/not desired to be loaded always.
20160828 21:12:55< celmin> So it might be possible with some fiddling.
20160828 21:13:09< tad_> OMG you're talking thousands of #if checks! And I just got nicked for adding a couple to my WIP because, when done, they're meaningless
20160828 21:13:10< fabi> Maybe a bit c++ support would be needed.
20160828 21:13:36< tad_> %s/bit/major project/
20160828 21:13:39< Nobun> celmin, fabi... probably a solution could be to allow user to add special lua file for testing purposes (aka a test suite) wich is loaded together with the campaign and executed only when a special condition met (example adding a --enable-wmlsuite parameter on wesnoth command line)7
20160828 21:13:46< celmin> I think a plugin would actually be a good solution, because it would mean directly testing the campaign code.
20160828 21:14:02< celmin> Nobun: That's kind of what a plugin is.
20160828 21:14:03< Nobun> so when starting a game with the parameter the test suite will be used, when starting game normally not
20160828 21:14:39< celmin> Mind you, I'm not sure how long such a test suite would take… at least it wouldn't have to draw the map, but any other processing would be the same as normal.
20160828 21:14:52< tad_> Let's start with a tag-by-tag WML debuger. Then I can say "Do this, do that, and when the breakpoint fires, check this ..."
20160828 21:15:01< zookeeper> well this is only a 13 years old computer game, not a nuclear plant control system with five levels of certification and mathematical proofs that it'll work...
20160828 21:15:28< Nobun> yeah... but probably it could be needed an additional control... for example a directive that is valid only when you want to use your campaign as test suite instead of playing it
20160828 21:16:09< tad_> zookeeper: And the goal it to take it to a LOT of new players who are gonna hit it with all sorts of unexpected gameplay. My goal is to try to get it, at least, behaving rarionally when they kill the Lich before they talk to Urza Afalas.
20160828 21:16:10< Nobun> something like #iftestsuite
20160828 21:16:30< celmin> Bad idea
20160828 21:17:39< zookeeper> tad_, uh, sure. i'm just sceptical of the idea of spending a lot of time devising elaborate automated tests, when common sense says that the tests themselves will in all likelihood be buggy and will become out of date and broken anyway as soon as anyone makes a change to the campaign.
20160828 21:18:09< zookeeper> i couldn't trust a test suite to tell me that i didn't break anything
20160828 21:18:45< tad_> zookeeper: Oh, I fully agree. Besides, we're all just hacker/programmers and so any work like that has gotta fit with our code style .. which is sorta Alfred E Neuman-ish when it comes to testing.
20160828 21:21:16< zookeeper> automated testing for outright syntax errors or something like that would be nice though. hmm...
20160828 21:21:59< fabi> LoW could need outomated testing for just having all the protaginost in place after every scenario advance.
20160828 21:24:12< tad_> Gross errors like syntax tend to crash early and decisively. It's the unexpected stuff like taking a village on Elensefar before the theives appear on turn 4 that's hard.
20160828 21:28:03< celmin> Checking syntax errors would probably be as simple as launching Wesnoth with all the defines set on the command line.
20160828 21:28:05< tad_> fabi: I've been working on a new way to hande (ie., eliminate) all that store/unstore mess you see in DM .. which I presume is also an issue in LoW .. using [filter_recall] and leaving all units on the recall list. Solves a LOT of issues.
20160828 21:28:54< fabi> tad_: Oh yes. When I introduced [filter_recall] I thought about that use case.
20160828 21:29:00< celmin> Or a switch that skips #if-type directives.
20160828 21:29:09< celmin> (By which I mean it treats them as comments.)
20160828 21:30:45< zookeeper> celmin, yeah. i was just wondering whether having an easy way to do that would be good in terms of pre-release sanity checking etc.
20160828 21:31:00< tad_> fabi: celmin and I have been working on it recently. My [modify_unit] PR is in support of it. My proof-of-concept work for TSG is very clean, but has been shelved for the nonce so I can push the bug fixes sooner.
20160828 21:34:35< tad_> zookeeper: I'm taking you lack of comments on the dialog as initial approval of how I handled killing the Lich when allied with Urza Afalas and am proceeding to proof-read the remaining original dialog for glitches and gotchas like references to facts-not-in-evidence.
20160828 21:34:38< fabi> Hmmm, not having "end turn" in the context menu is not easy to get used to.
20160828 21:35:04< tad_> fabi: Not having to press shift-: and only using ; was a major shift, for me!
20160828 21:35:25< fabi> oh yes
20160828 21:35:29 * tad_ still gets it wrong at times.
20160828 21:35:43< celmin> You could always change it back. :P
20160828 21:35:46< fabi> tad_: But you can easily change that back.
20160828 21:36:04-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.4]
20160828 21:36:05< celmin> fabi: I think the end turn thing was solely a theme edit.
20160828 21:36:11< fabi> sure
20160828 21:36:15< tad_> Only if I can commit the change from ; to $ .. muhahaha
20160828 21:36:29< celmin> Not as easy to change back, but possible. Though I do think removing it is a good idae.
20160828 21:36:33< celmin> ^idea
20160828 21:37:59< zookeeper> tad_, umm, let me check...
20160828 21:38:14< tad_> Speaking of context errors. If I don't have any recalls and use the context menu to recall I don't see the popup error .. maybe it's too fast to see? .. but if I use the keyboard I get it. But I'm a keyboard-centric user so I rarely notice.
20160828 21:39:52< tad_> zookeeper: the dialog I'm referring to is in die ("Undead Leader") .. first [if] where we have Urza on side=1
20160828 21:40:37< tad_> zookeeper: and the other change was on sighted for Gruth
20160828 21:43:54< zookeeper> tad_, for starters, you have quite a few cases of "Mel´Brin" and "Mel M´Brin", it seems
20160828 21:44:07< tad_> zookeeper: Your comments yesterday lead me to think you wanted Urza to be more convinced the lich actually was Mel M'Brin so I'm hoping I'm taking it in the right direction.
20160828 21:44:47-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 21:44:48< travis-ci> wesnoth/wesnoth#10585 (master - 1a82a37 : Charles Dang): The build has errored.
20160828 21:44:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155785103
20160828 21:44:48-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 21:45:21-!- Appleman1234 [~Appleman1@KD036012021118.au-net.ne.jp] has quit [Ping timeout: 276 seconds]
20160828 21:45:27< tad_> You mentioned wanting to use \u00b4 (´) rather than apostrophe (') and sure enough it's the accent everywhere but with his name. So I'm sending up a global search and replace
20160828 21:45:53 * tad_ notes that 100 newborn lambs didn't do it and Travis demands more sacrifices.
20160828 21:46:10< zookeeper> uh, i was just saying that you've typoed the name
20160828 21:46:14< zookeeper> in different ways
20160828 21:46:47< tad_> Oh geeze. OK. I'll check the original and do it again.
20160828 21:52:21< zookeeper> tad_, ok so hylas and deoran claim that urza had said he knew mebrin, but he doesn't seem to have said that anywhere? and his "I was told this was Mel M´Brin" sounds a bit weird since he's the bandit boss there so who told him that and why wouldn't he have known mebrin himself in the first place?
20160828 21:53:42-!- gfgtdf [~chatzilla@x50abb183.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]]
20160828 21:54:05-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160828 21:55:45< tad_> I agree. I struggled at that transition. Not sure how to do it better. Would prefer to fix it at that point, but it may make more sense to change the conversation at sighted(Urza Afalas) 
20160828 21:57:44< zookeeper> also i'm not sure why you think i wanted urza to be convinced that it's really m'brin, as i think i was clearly saying the opposite :P
20160828 21:58:18< tad_> zookeeper: grep'd my branch and all references I see matching "mel.*brin" show as "Mel M'Brin" but I may have issues with accent-vs-apostrophe. Will look deeper later.
20160828 21:58:36< zookeeper> mal, not mel
20160828 21:59:11< tad_> Ah. OK. I see it now. No problem. I'll fix 'em.
20160828 22:00:54< tad_> So, the idea is that Urza knows the lich isn't really him, and Ethiliel will recognize it's not when we meet him? (The Gruth stuff, then, is correct since Urza points out that's the wrong leader)
20160828 22:01:56< zookeeper> yeah. having him be unaware that it's not the real m'brin seems kind of an unnecessary complication and potentially just raises more questions about how _wouldn't_ he know and who told him it is etc etc.
20160828 22:01:58< tad_> So I don't get why the "?" vs "Mel M'Brin" issue. Why not simple give the lich a different name, or no name at all?
20160828 22:02:16< tad_> zookeeper: I can see that.
20160828 22:02:55< tad_> So the bandits, having been tehre a while, and having worked with him, will know the lich isn't him. And Ethiliel will know once she sees the lich.
20160828 22:03:54< zookeeper> so WRT urza, i think it makes a lot more sense that 1) he's aware it's not the real m'brin, but 2) he doesn't say anything until it's been killed because otherwise deoran would never have allied with him
20160828 22:04:25< zookeeper> what one _could_ do to foreshadow that could be to have him urge you to just run and flee and not try to fight m'brin, as soon as you ally with him
20160828 22:04:40< zookeeper> because he'd rather you all get out of there so no one notices he lied
20160828 22:05:17< zookeeper> but since gerrick and co insist on fighting, he just has to tag along and it's kind of awkward when everyone finds out they're screwed because he lied
20160828 22:06:05< zookeeper> i'm not sure what you're asking WRT the lich name though
20160828 22:07:12-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160828 22:09:00< tad_> We came here, following Ethiliel, looking for Mebrin. The area is foreboding: Hylas and Ethiliel detect evil. We explore, find some undead, find some bandits, run across Gruth (Sir Gerrick is confused but Urza or Hylas set him right) and eventually find the lich. 
20160828 22:10:07< tad_> The name which appears on the Status panel .. I'd leave it blank initially. If we ally with Urza, change it to "Mel M'brin" as that's who he told us it is.
20160828 22:11:25< zookeeper> sure, whatever the name is, it should not show up in the status panel before you actually see the lich
20160828 22:11:27< tad_> If we're not allied, Ethiliel points out the entrance and we're off to S06a and S07a. Otherwise Hylas spots the fake after it's dead, confront Urza about the deception, M'Brin appears and we run like hell for the Long Match
20160828 22:12:45 * tad_ envisions the army tossing supplies and weapons and skedaddling. 
20160828 22:13:42< zookeeper> yeah, sounds about right all in all.
20160828 22:15:43< tad_> OK. Sorry, I guess I confused Urza knowing Gruth was not the leader of the undead the objectives told us to seek with Urza thinking the lich was.
20160828 22:16:44< tad_> Well, I'm VERY glad I put it up for you to review. Only wasted an evening going the wrong direction.
20160828 22:19:03< zookeeper> i'm not sure if m'brin appearing in person there is necessary, but i guess i doesn't hurt, since he's kind of a non-person for the rest of the bandit branch
20160828 22:19:42< zookeeper> although 15 animated recruits sounds a bit excessive as far as the cutscene goes
20160828 22:20:34< tad_> Well I wanted to scare the hell out of the player and we're gonna have 50 or so undead in a few minutes .. but yeah, one or two is enough.
20160828 22:20:52< zookeeper> i'd think you'd probably often end up with situations like your heroes literally surrounded by lvl2 undead?
20160828 22:22:07< tad_> Actually, that was late and what I was thinking was some move_unit_fake to have Our Heros run to the north a bit while a few undead appear then cut to end-scenario
20160828 22:22:08< zookeeper> i don't recall the map layout exactly but i think the lich was very close to the map edge, so possibly the map could be expanded at that point and the real m'brin could appear at the bottom or right edge with his draugs or whatever
20160828 22:23:38< tad_> His keep is about 3-up 3-left from lower-right corner. Lots of mountains. And the references to the underground are to the citadel. The most logical would be to appear on the citadel .. Just need to be sure to shove anyone on it to the side, first ...
20160828 22:24:43< tad_> Most times when I play, the lich moves NE to attack when I'm in range and the citadel is clear. But that may not always be the case.
20160828 22:25:48< tad_> s/NE/NW/
20160828 22:28:03< tad_> I considered using the doors from Dwarven Doors as the obvious entrance to the underground but the references were to the citadel and, frankly, I think those doors need work .. too obvious and they don't work real well with mountains, even over in HttT.
20160828 22:29:09-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160828 22:29:10< travis-ci> wesnoth/wesnoth#10586 (master - 898d98a : Charles Dang): The build has errored.
20160828 22:29:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155788760
20160828 22:29:10-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160828 22:30:07< tad_> zookeeper: OK. I'm going to kill that branch from github and re-write. I'll get with you when I'm ready for another review. Plus, I think I'll start working to minimize the diff-damage.
20160828 22:30:38-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160828 22:30:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160828 22:33:54< celmin> Yay minimized diff-damage.
20160828 22:36:20< tad_> Only thing worse than spurious changes is spurious changes which end up with a patch, a patch to the patch, and, finally, a revert.
20160828 22:38:49< shadowm> Wesnoth development in a nutshell.
20160828 22:38:53< zookeeper> yeah...
20160828 22:41:05< tad_> Well, zookeeper may wonder which lame-brained-left-field I came out of but, at least, it's a branch-review and never made it to master.
20160828 22:46:31-!- Appleman1234 [~Appleman1@KD036012013238.au-net.ne.jp] has joined #wesnoth-dev
20160828 22:54:45-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160828 22:54:51-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160828 22:55:13< celmin> Sort of works now...
20160828 22:55:25< celmin> But not quite.
20160828 22:56:10-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20160828 23:07:10-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160828 23:07:52-!- Nobun [~nobun@87.13.73.190] has quit [Quit: Salve a tutti]
20160828 23:10:03-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 240 seconds]
20160828 23:26:45-!- irker378 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160828 23:42:21-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer]
20160828 23:43:08-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160828 23:50:18< vultraz> good god these travis logs
--- Log closed Mon Aug 29 00:00:43 2016