--- Log opened Mon Aug 29 00:00:43 2016
20160829 00:01:33< celmin> ?
20160829 00:01:39< celmin> MP tests stalling again>
20160829 00:01:40< celmin> ^?
20160829 00:02:29< vultraz> seems so
20160829 00:02:41< vultraz> looks like it might have to do with my new dialog
20160829 00:15:06< vultraz> celmin: could you next work on making those 'connecting to server' popups loading screen stages?
20160829 00:15:17< vultraz> after the matriz
20160829 00:15:19< vultraz> matrix
20160829 00:15:19< celmin> Maybe?
20160829 00:15:41< celmin> I basically finished the grid listbox already, though it could probably still use some improvement.
20160829 00:15:42< vultraz> I'll take care of Random Map settings
20160829 00:15:52< vultraz> grid listbox?
20160829 00:16:08< vultraz> are you saying you have a listbox that doesn't take toggle buttons/panels?
20160829 00:17:48< vultraz> and if so, any contents, or grids specifically?
20160829 00:18:25< celmin> No, it's like a listbox but packs elements into rows.
20160829 00:18:43< vultraz> as opposed to...?
20160829 00:18:47< celmin> That's why I wanted the matrix placement policy.
20160829 00:19:15< celmin> The idea is to pack as many elements into a row as will fit, and then continue on the next row, and so forth.
20160829 00:19:21< vultraz> I see
20160829 00:19:30< vultraz> so like a table
20160829 00:20:01< celmin> Sort of.
20160829 00:20:11< vultraz> I see
20160829 00:20:12< celmin> In actuality it's more like inline-block in CSS.
20160829 00:20:24< celmin> Unless you use a linked group.
20160829 00:20:44 * vultraz doesn't know much css
20160829 00:20:59< celmin> Without a linked group, there's no clear concept of columns in the grid listbox.
20160829 00:28:42-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160829 00:42:01< vultraz> HMMMMMMMMMMMMMmmmmmmmmmmmmm
20160829 00:42:04< vultraz> [list_data]
20160829 00:42:06< vultraz> does not work
20160829 00:42:09< vultraz> with a toggle panel
20160829 00:42:10< vultraz> :|
20160829 00:43:54< vultraz> celmin: how extensive was your testing with [list_data]?
20160829 00:44:10< celmin> What? I didn't test it, just noticed it in the code.
20160829 00:44:14< celmin> How are you using it?
20160829 00:44:39< celmin> If it's not used anywhere it might actually be better to redo it.
20160829 00:44:42< vultraz> exactly as in mp_method_selection.cfg
20160829 00:44:49< celmin> Ah, it was already used there?
20160829 00:44:58< vultraz> I figured it better we use toggle_panel-based listboxes
20160829 00:45:01< vultraz> instead of buttons
20160829 00:45:04< vultraz> in all places
20160829 00:45:24< celmin> "all places"?
20160829 00:45:39< vultraz> several listboxes use rows of toggle_buttons that look like panels
20160829 00:45:55< celmin> Okay?
20160829 00:45:57< vultraz> Language was one until recently 
20160829 00:46:01< celmin> Huh?
20160829 00:46:18< vultraz> it used a list of toggle_buttons and not proper toggle_panels
20160829 00:46:42< vultraz> i changed it to a proper panel
20160829 00:46:54< celmin> The language list was not a listbox?
20160829 00:47:28< vultraz> it was
20160829 00:47:34< vultraz> but using buttons not panels :|
20160829 00:47:44< vultraz> why do I keep having to repeat that
20160829 00:48:00< celmin> What's wrong with using buttons?
20160829 00:48:38< vultraz> it looks better with the panel?
20160829 00:50:14< celmin> Does it?
20160829 00:50:27< celmin> That doesn't seem like much of a reason though.
20160829 00:50:33< vultraz> :|
20160829 00:50:37< vultraz> :| :| :|
20160829 00:50:45 * vultraz proceeds with many more :| faces
20160829 00:50:48< celmin> Given that you could probably make it look better with a new toggle button definition too.
20160829 00:50:57< celmin> Not that I really care whether it's a button or a panel.
20160829 00:51:05< vultraz> plus the panels have the nice hovered state
20160829 00:51:21< vultraz> granted, I could add them to the button definitions in question
20160829 00:51:23< celmin> I seem to recall that the MP selection dialog has a nice hovered state...
20160829 00:51:28< vultraz> but I do want to remove those 
20160829 00:51:37< celmin> What was the argument type for list.add_row again.
20160829 00:51:40< celmin> string_map?
20160829 00:51:42< vultraz> yes
20160829 00:51:48< celmin> Not map<string,string_map>?
20160829 00:52:01< vultraz> oh wait, yes
20160829 00:52:12< celmin> Or does it offer both maybe?
20160829 00:52:38< celmin> But with [list_data] it builds a vector<string_map>...
20160829 00:52:39< vultraz> it does
20160829 00:52:50< celmin> Ugh, why, XCode.
20160829 00:52:58< celmin> It won't jump me to the definitions of create_items.
20160829 00:53:22< celmin> Well, I guess they must be in generator_private.hpp though.
20160829 00:53:56< celmin> Oh huh, there's a version of create_items that takes vector<map<string,string_map>> o.o
20160829 00:54:51-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160829 00:55:06< vultraz> blah
20160829 00:55:20< celmin> create_items ultimately calls the seemingly unimplemented create_item? Huh? Is that really right?
20160829 00:55:23< vultraz> this is the only place list_data is used
20160829 00:55:37< vultraz> so i have no examples for use with a toggle panel
20160829 00:56:10< celmin> I'm trying to figure out what's happening in the code.
20160829 00:56:22< vultraz> hm..
20160829 00:56:24< vultraz> yes..
20160829 00:56:33< vultraz> [list_data] seems very rudimentary 
20160829 00:57:26< celmin> Oh, I found an implemented version...
20160829 00:57:37< celmin> Ah, but it only defers to the other version...
20160829 00:57:50< celmin> Wait, but the other version is also implemented here.
20160829 00:58:57< vultraz> let me know when you're finished :P
20160829 00:59:08< celmin> So add_row also calls create_item. I guess that should be no surprise.
20160829 00:59:28< celmin> So ultimately both methods are using the same mechanism to add things.
20160829 01:00:36< celmin> As far as I can tell, it should work identically with a toggle panel.
20160829 01:00:39< vultraz> should list_data use a vector<map<string, string_map>>
20160829 01:01:30< celmin> It would be easy to change it do use that, yeah, but it seems like it should work as it is as long as there's only one widget in the list definition.
20160829 01:01:39< vultraz> and, ok, but then what would the syntax be
20160829 01:01:41< celmin> Oh wait… I see, that's why it doesn't work with the toggle panel, I bet.
20160829 01:01:59< celmin> add_row(string_map) only sets the root widget.
20160829 01:02:13< celmin> It's equivalent to calling add_row({"", the_map})
20160829 01:02:20< celmin> Double braces there.
20160829 01:02:32< vultraz> so list_data needs to be fixed?
20160829 01:03:22< celmin> Or if using the typical idiom, it's equivalent to data.emplace("", row); add_row(data);
20160829 01:03:45< celmin> So basically yes, it would be best to change list_data to use a vector<map<string,string_map>>
20160829 01:03:54< celmin> Do you want me to do that?
20160829 01:04:02< celmin> I did touch that file recently, after all.
20160829 01:04:30< vultraz> if you have changes then please
20160829 01:04:40< vultraz> dont want to overlap
20160829 01:07:29< celmin> vultraz: Do you know if there is a way in the schema to specify "any tag is allowed here"?
20160829 01:07:36< vultraz> uhhh
20160829 01:07:42< vultraz> I do not
20160829 01:07:51< vultraz> probably one of the generic/ methods
20160829 01:10:45< celmin> Hmm, I don't see anything obvious.
20160829 01:23:07< celmin> tselect::init has special handling for toggle button/panel but none for rarer containers such as matrix or pane...
20160829 01:23:23< celmin> Unless those work with the generic grid case somehow...
20160829 01:24:06< celmin> Oh, wait, that may only apply to the toplevel.
20160829 01:24:37< celmin> Yeah, okay.
20160829 01:25:25< celmin> Wait, maybe not?
20160829 01:25:38< celmin> Well… to be honest, you probably don't want to be stuffing containers into a listbox anyway.
20160829 01:27:25< vultraz> true
20160829 01:27:40< vultraz> plus it's supposed to be the place of tlist to handle lists in a generic sense
20160829 01:27:51< celmin> Except that tlist doesn't work.
20160829 01:28:17< celmin> When I push this, you should be able to gather how it works from the schema diff.
20160829 01:28:27< vultraz> how what works?
20160829 01:28:35< celmin> Enhanced [list_data]
20160829 01:28:55< vultraz> ah
20160829 01:28:58< vultraz> sweet, sweet
20160829 01:29:00< vultraz> do push
20160829 01:29:07< celmin> I haven't even committed yet.
20160829 01:29:19< celmin> And since I need to rebase, I kinda don't want to push until I finish with hotkey categories.
20160829 01:29:22-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160829 01:29:24< vultraz> ah
20160829 01:29:25< vultraz> alright
20160829 01:29:38< celmin> It's almost done though, I just need to figure out why the filter sometimes doesn't work.
20160829 01:30:11< celmin> (The matrix placement policy could also use some work still.)
20160829 01:30:39< celmin> (It calculates its best size under the assumption that there are a fixed number of columns, but then places them in a sort of "flow".)
20160829 01:30:58< celmin> them=cells
20160829 01:31:51< celmin> (But I will push it with the policy as it is now.)
20160829 01:37:58< vultraz> ah, this confirms my suspicious about that unimplemented vertical_list thing
20160829 01:38:03< vultraz> 	tlist* widget = new tlist(true, true, tgenerator_::vertical_list, true, list_builder);
20160829 01:38:15< celmin> Hm?
20160829 01:38:23< celmin> What does it confirm?
20160829 01:38:39< vultraz> that the vertical_list stuff is indeed to go with tlist
20160829 01:38:44< celmin> The way to confirm it would be to set a breakpoint in the unimplemented thing.
20160829 01:38:57< celmin> The vertical_list stuff is used by the normal listbox, you know.
20160829 01:39:19< celmin> I don't know if that unimplemented create_item function is called, though.
20160829 01:39:36< celmin> Even if it is, it depends on when it's called, since it returns without asserting if a certain variable is set.
20160829 01:55:36< vultraz> celmin: is a push imminent 
20160829 01:55:41< vultraz> ie, should i not push stuff
20160829 01:56:06< celmin> It's not so imminent that you should hold back on pushing stuff. 
20160829 01:56:14< celmin> In other words, go ahead.
20160829 01:56:35-!- irker612 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160829 01:56:35< irker612> wesnoth: Charles Dang wesnoth:master f338c4886308 / data/gui/window/depcheck_select_new.cfg src/gui/dialogs/depcheck_select_new.cpp: Depcheck Dialog: use a toggle panel for the listbox https://github.com/wesnoth/wesnoth/commit/f338c4886308a561b1fcd535619fa9440d1462f2
20160829 01:56:46< vultraz> for the record, the #1 reason to use a panel over a button is you can have a border around the text
20160829 01:56:58< celmin> You mean that gold border?
20160829 01:57:14< celmin> But I imagine you could get that with a button too somehow, even if it means another definition. :P
20160829 01:57:33< vultraz> no I mean an actual border = "all" border
20160829 01:57:44< celmin> Oh, the invisible borders.
20160829 01:57:48< vultraz> plus for some reason, the text looks better in the panel
20160829 01:57:51 * vultraz has no idea why
20160829 01:57:59< celmin> I find that statement questionable.
20160829 01:58:23 * vultraz shrugs
20160829 01:59:05< vultraz> perhaps since the panel uses a label instead of drawing [text] directly
20160829 01:59:35< celmin> The label definition doesn't draw [text] directly?
20160829 02:02:28< vultraz> it does
20160829 02:05:20 * vultraz awaits the list_data commit
20160829 02:05:33< vultraz> then i can remove the last use of buttons-in-list
20160829 02:05:34< vultraz> hopefully
20160829 02:08:58< celmin> I think it would be good to use [list_data] for all tab bars, and for the left sidebar in prefs.
20160829 02:09:17< celmin> Speaking of tab bars, it'd be cool if we could make them look like actual tabs somehow...
20160829 02:09:33< vultraz> yes
20160829 02:09:43< vultraz> they should probably be widgetized 
20160829 02:09:57< celmin> Eh, a special toggle panel definition would probably be enough.
20160829 02:10:06< vultraz> how so?
20160829 02:11:28< vultraz> and how would they be themed?
20160829 02:11:37< celmin> I'm not sure.
20160829 02:11:56< celmin> I guess you'd probably need a background image on a canvas.
20160829 02:12:11< vultraz> but what image :)
20160829 02:12:16< celmin> No idea.
20160829 02:12:23< vultraz> anyway, now's not the tim
20160829 02:12:24< vultraz> e
20160829 02:12:32< celmin> I guess a single image won't do since that wouldn't work for variable-width tabs.
20160829 02:12:38< vultraz> I agree with your [list_data] suggestion, though
20160829 02:13:54< vultraz> also want to see what this mysterious hotkey panel thing looks like 
20160829 02:14:18< celmin> Did I call it a "hotkey panel"?
20160829 02:14:36< vultraz> well i assumed all this matrix work was for hotkeys..?
20160829 02:15:29< celmin> That was the motivation for getting it to work, yes - it's basically a "tab bar" along the top that lets you select the categories to include.
20160829 02:15:39-!- RatArmy [~RatArmy@133.15.175.65] has quit [Quit: Konversation terminated!]
20160829 02:17:00< vultraz> i'm wondering if we need the 'maximum wml menu items' pref anymore
20160829 02:17:16< vultraz> since it's pretty much useless now
20160829 02:17:30< celmin> Why is it useless? The scrollbar?
20160829 02:17:30< vultraz> the list is sized by height, not items
20160829 02:17:58< vultraz> then again, you were suggesting a 'num items visible' setting..
20160829 02:18:08< celmin> I wonder if we can make a scrollbar_container definition that doesn't use a scrollbar and instead has the arrows shown as additional rows at the top and bottom, with scrolling occurring on mouseover.
20160829 02:18:21< celmin> To make it more menu-like.
20160829 02:18:31< vultraz> dunno
20160829 02:18:47< vultraz> honestly, i don't even know what the gui1 version did..
20160829 02:18:53< vultraz> when it reached that max number
20160829 02:20:15< vultraz> ah
20160829 02:20:31< vultraz> it added 'more items/earlier items' options
20160829 02:20:41< vultraz> yeah, we don't need this pref anymore
20160829 02:21:28< vultraz> i shall remove it
20160829 02:22:16< vultraz> oh hey, there's even a todo to that effect
20160829 02:22:18< vultraz> "# TODO: It would be better to eliminate this preference and have it instead determined by the gui layout algorithm."
20160829 02:23:27< vultraz> oh dear
20160829 02:23:34< vultraz> this code is rather complicated
20160829 02:23:53< celmin> The "more items / earlier items" option is closer to the behaviour I'd want. With the GUI2 menus it currently shows a scrollbar.
20160829 02:24:16< vultraz> yes
20160829 02:24:23< vultraz> but we still don't need this 'pages' solution
20160829 02:24:25< vultraz> now
20160829 02:24:29< vultraz> either way, the list will scroll
20160829 02:24:36< celmin> Though "more items / earlier items" isn't still quite right in my opinion - a scrollable list is better.
20160829 02:24:39< vultraz> it doesn't matter how we implement that scrolling, visually
20160829 02:24:52< vultraz> whether with a scrollbar or up/down items
20160829 02:25:21< vultraz> ya see?
20160829 02:26:28< celmin> Yeah, we don't need pages.
20160829 02:27:23< celmin> Are the GUI2 images in images/ or data/images/?
20160829 02:27:48< vultraz> images/
20160829 02:27:54< vultraz> hm
20160829 02:28:08< vultraz> might be a little complicated to revert iceiceice's addition of the wmi pager :|
20160829 02:28:22< celmin> Why?
20160829 02:28:31< vultraz> it's from 2 years ago
20160829 02:28:36< celmin> So it's in 1.12?
20160829 02:28:41< vultraz> no
20160829 02:28:43< celmin> Aw.
20160829 02:28:43< vultraz> 1.13.0
20160829 02:28:51< celmin> That's unfortunate.
20160829 02:29:12< celmin> Is it integrated into the WML menu items code somehow?
20160829 02:29:20< vultraz> yes
20160829 02:29:29< celmin> I see.
20160829 02:29:54< celmin> It's unfortunate that he went to all that work only to have it discarded though.
20160829 02:30:15< vultraz> true
20160829 02:30:19< vultraz> but what can you do?
20160829 02:30:31< celmin> And it didn't even make it into a release.
20160829 02:31:17 * vultraz doesn't understand this code
20160829 02:33:47< celmin> The unfold arrow seems like it'd work for menus.
20160829 02:34:00< celmin> Flip it to point upwards for the up-scroller.
20160829 02:34:12< vultraz> yeah
20160829 02:35:36< celmin> Even with default_tiny, this takes up too much space at 800x600...
20160829 02:35:46 * celmin removes the tab padding columns.
20160829 02:36:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160829 02:37:09< celmin> I'm kinda unsure which of the two strategies is better for the matrix placement - inline-block type, or table type.
20160829 02:37:25< celmin> I feel like it was meant more for the latter sort of thing.
20160829 02:38:32< celmin> But since you can easily get that from the former by using a linked group...
20160829 02:39:56< celmin> Hmm, there's definitely room for three or maybe four columns, yet it's putting them in two.
20160829 02:40:25< celmin> Is there any way that you know of to preserve scroll position when the visibility of items changes/
20160829 02:40:27< celmin> ^?
20160829 02:41:31< celmin> Wait, I said 800x600, but I'm actually on 1024x768 right now for some reason.
20160829 02:41:39< celmin> That makes it even worse.
20160829 02:43:54< celmin> Ohhh, the hotkey ID is not necessarily the same as its index in the hotkey list. That's probably why the masking isn't working correctly.
20160829 02:44:08< celmin> In other words… I need a regular for-loop instead of for-range.
20160829 02:46:06< celmin> I think maybe I need to revist the placement policy after all. If you want I can push this first though, vultraz.
20160829 02:46:10< celmin> ^revisit
20160829 02:50:25-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 02:50:26< travis-ci> wesnoth/wesnoth#10587 (master - f338c48 : Charles Dang): The build has errored.
20160829 02:50:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155829117
20160829 02:50:26-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 02:58:06-!- kahootbird [~kahootbir@c-76-23-72-30.hsd1.tn.comcast.net] has quit [Quit: Leaving]
20160829 03:01:13< vultraz> sure
20160829 03:02:43< celmin> This actually looks better at 800x600 than at 1024x768.
20160829 03:02:52< celmin> There's definitely something wrong in the placement policy.
20160829 03:06:54< celmin> The filter still seems buggy somehow too. Unless it's just that some hotkeys are miscategorized.
20160829 03:21:07< celmin> BTW vultraz, I recommend putting a trailing comma on the last list item.
20160829 03:21:14< vultraz> hm?
20160829 03:21:20< celmin> For example, when you added "faction_select" to ignored dialogs.
20160829 03:21:28< vultraz> ah
20160829 03:21:41< celmin> If you put a trailing comma, then when you add another one later you don't need to add a comma on the preceding line.
20160829 03:21:51< celmin> It's cleaner in my opinion.
20160829 03:26:56< vultraz> blah
20160829 03:27:13< vultraz> this is trivially annoying
20160829 03:28:33< celmin> BTW, a push is now imminent.
20160829 03:28:41< celmin> Though I should probably run the tests once first...
20160829 03:29:01< vultraz> yeah, I'm not pushing anything right yet
20160829 03:32:32-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160829 03:33:16< shadowm> Germany uses dd.mm.yyyy dates, right?
20160829 03:35:41< shadowm> I should know better than to trust the Internet for a matter of life or death but Wikipedia suggests that's the correct format in two different articles, so I'll go with that.
20160829 03:36:03< pydsigner> Are you parsing dates?
20160829 03:36:24< shadowm> I'm making sure I won't get food poisoning or worse.
20160829 03:38:52< celmin> That doesn't really sound like the sort of food poisoning that could be a matter of life or death...
20160829 03:39:35< shadowm> THAT'S BESIDE THE POINT.
20160829 03:40:06< celmin> I think only the US is crazy enough to put the day in the middle.
20160829 03:40:19< celmin> Well, maybe Canada sometimes too.
20160829 03:41:16< shadowm> What about Australia and the United Kingdom?
20160829 03:41:48< celmin> No idea about Australia. I seem to recall that the UK does year-month-day, but I could be misremembering.
20160829 03:42:07< celmin> Pretty sure it doesn't put the day in the middle though.
20160829 03:42:11< vultraz> US date format is superior to all other date formats
20160829 03:42:21< shadowm> Shut up , vultraz.
20160829 03:42:26< celmin> US date format is worst date format ever invented.
20160829 03:42:56< shadowm> celmin: Yeah, I guess yyyy-mm-dd makes sense for EU member countries.
20160829 03:43:12< shadowm> So um yeah I imagine that'll be phased out in the UK in the next few years. :p
20160829 03:43:26< celmin> I doubt they'd change their date format just because they left the UK. :P
20160829 03:47:51-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 264 seconds]
20160829 03:52:52-!- vultraz [~chatzilla@124.109.10.167] has quit [Read error: Connection reset by peer]
20160829 03:54:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160829 03:55:38-!- nurupo_ [~nurupo.ga@unaffiliated/nurupo] has joined #wesnoth-dev
20160829 03:55:45< vultraz> ok, i got the wmi_pager removed
20160829 03:55:46< vultraz> celmin: awaiting your commit to make my commit
20160829 03:55:48< vultraz> push*
20160829 03:56:29-!- nurupo [~nurupo.ga@unaffiliated/nurupo] has quit [Read error: Connection reset by peer]
20160829 03:56:59-!- nurupo_ is now known as nurupo
20160829 03:59:49< celmin> I ran into a link error somehow.
20160829 04:00:09< celmin> If I can solve that it should only be a few more minutes...
20160829 04:00:49< vultraz> ok
20160829 04:02:28< celmin> Hmm, I already have an idea for fixing the placement policy. Maybe I'll be able to push that soon after.
20160829 04:03:02< celmin> (After you've pushed your stuff.)
20160829 04:08:46-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160829 04:09:28-!- JyrkiVesterinen [~jyrki@87-100-248-140.bb.dnainternet.fi] has joined #wesnoth-dev
20160829 04:09:52< celmin> Grrr, Finder is not responding.
20160829 04:15:29< celmin> This link error is XCode's fault. It's doing something stupid when I try to add the file.
20160829 04:15:31-!- Kwandulin [~Miranda@p200300760F4241050DC6399F4AD72C6E.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160829 04:17:17< celmin> I'm hoping I can manage to not have to manually edit...
20160829 04:20:02< vultraz> maybe i should push my commit so you can update xcode at the same time?
20160829 04:20:06< vultraz> instead of twice
20160829 04:20:09< vultraz> ?
20160829 04:21:17< celmin> Uhh. What's your commit?
20160829 04:21:41< vultraz> removing wmi_pager
20160829 04:21:53< celmin> Ah.
20160829 04:22:04< vultraz> you need to remove the file from xcode
20160829 04:22:22< celmin> Sure, I guess. Where's the file?
20160829 04:22:44< celmin> Oh found it.
20160829 04:22:54< celmin> It's gone.
20160829 04:23:09< celmin> Any other files to delete while I'm at it?
20160829 04:23:21< vultraz> no
20160829 04:23:23-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has joined #wesnoth-dev
20160829 04:25:23< celmin> Doing a clean build.
20160829 04:38:15< celmin> vultraz: You were going to push that, right?
20160829 04:38:23< vultraz> do you want me to?
20160829 04:38:32< celmin> I did say "sure".
20160829 04:39:17< irker612> wesnoth: Charles Dang wesnoth:master 507d00d9d97a / / (13 files in 5 dirs): Refactored out wmi_pager https://github.com/wesnoth/wesnoth/commit/507d00d9d97afefc0174948a5722ead982e41a7b
20160829 04:52:34< vultraz> i dunno why scrollbars aren't acceptable for the menus
20160829 04:52:40< vultraz> they're in the windows 10 start menu
20160829 04:52:44< celmin> They're acceptable, just not great.
20160829 04:53:33< celmin> Windows start menu probably isn't a good sample.
20160829 04:53:38< celmin> In any version of Windows.
20160829 04:54:36-!- jswensen [~jswensen@cpe-98-145-147-33.natnow.res.rr.com] has quit [Quit: jswensen]
20160829 04:57:34< celmin> vultraz: I was wrong. The link error was totally your fault.
20160829 04:57:40< vultraz> oi :|
20160829 04:57:46< celmin> You included the cpp instead of the hpp in the test case.
20160829 04:57:53< vultraz> oh
20160829 04:57:55< vultraz> blag!
20160829 04:57:58< vultraz> please fix
20160829 04:58:00< celmin> Will do.
20160829 04:58:09-!- JyrkiVesterinen [~jyrki@87-100-248-140.bb.dnainternet.fi] has quit [Quit: .]
20160829 05:05:12< celmin> I guess it's not that bad - it did get it into a dev release, at least.
20160829 05:05:27< vultraz> 6, to be precise
20160829 05:05:29< vultraz> :P
20160829 05:05:33< celmin> Yeah.
20160829 05:05:38< celmin> Though maybe only 5.
20160829 05:05:57< celmin> Finally I can run the unit tests.
20160829 05:06:05< celmin> Then I'll push.
20160829 05:06:19< celmin> And then I might try to fix the matrix placement policy.
20160829 05:14:30-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160829 05:33:04-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 05:33:05< travis-ci> wesnoth/wesnoth#10588 (master - 507d00d : Charles Dang): The build has errored.
20160829 05:33:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155845203
20160829 05:33:05-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 05:37:20-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 258 seconds]
20160829 05:43:05-!- RatArmy [~RatArmy@133.15.175.65] has joined #wesnoth-dev
20160829 05:51:43< irker612> wesnoth: Celtic Minstrel wesnoth:master c355d52778d2 / src/gui/widgets/window.cpp: Don't assert when encountering an unknown linked group https://github.com/wesnoth/wesnoth/commit/c355d52778d20df3527871c9725c67b6e5774af0
20160829 05:51:45< irker612> wesnoth: Celtic Minstrel wesnoth:master 943c1bdd575b / data/gui/schema.cfg src/gui/widgets/listbox.cpp src/gui/widgets/listbox.hpp: Support has_minimum/has_maximum in horizontal listboxes https://github.com/wesnoth/wesnoth/commit/943c1bdd575b0a61631bc59113b9085635f3af8f
20160829 05:51:47< irker612> wesnoth: Celtic Minstrel wesnoth:master 82153b1da82d / / (7 files in 4 dirs): Implement new grid_listbox widget https://github.com/wesnoth/wesnoth/commit/82153b1da82df396365af6402202ec3549f28099
20160829 05:51:49< irker612> wesnoth: Celtic Minstrel wesnoth:master d99bea9651d9 / data/gui/schema.cfg src/gui/widgets/listbox.cpp src/gui/widgets/listbox.hpp: Allow [list_data] to be used for listbox toggle-panels https://github.com/wesnoth/wesnoth/commit/d99bea9651d93df9fbc451271492c1a0710d6a24
20160829 05:51:51< irker612> wesnoth: Celtic Minstrel wesnoth:master 61aa9df286c7 / / (7 files in 5 dirs): Add hotkey categories filter to preferences https://github.com/wesnoth/wesnoth/commit/61aa9df286c7d0940f59f2f810f0ac354342eb64
20160829 05:51:53< irker612> wesnoth: Celtic Minstrel wesnoth:master 24111e7a7306 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode projet https://github.com/wesnoth/wesnoth/commit/24111e7a73062b7f132055968778237e7b388c20
20160829 05:51:55< irker612> wesnoth: Celtic Minstrel wesnoth:master 7bf1e33e5072 / src/tests/gui/test_gui2.cpp: Unit test for faction select dialog https://github.com/wesnoth/wesnoth/commit/7bf1e33e5072e7bf67f6019e02eb3acd83f6863f
20160829 05:52:02< celmin> Ugh, typo. :(
20160829 05:52:59< vultraz> ah, there they are
20160829 05:53:08< vultraz> bah
20160829 05:53:09< vultraz> "Auto packing the repository in background for optimum performance."
20160829 05:53:12< vultraz> this will take awhile
20160829 05:55:10-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160829 05:59:20-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160829 06:09:33< vultraz> celticminstrel: wesnoth crashes immediately when clicking Prefs
20160829 06:09:45< celticminstrel> Fun!
20160829 06:10:01< celticminstrel> But that alone isn't enough to track down the issue.
20160829 06:10:44< vultraz> http://pastebin.com/6KeWfvx2
20160829 06:10:53< vultraz> looks like a t_string issue
20160829 06:11:04< celticminstrel> Eh?
20160829 06:11:09-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160829 06:11:19< vultraz> hm...
20160829 06:11:23< celticminstrel> Hmm, what if you drop the const on that array of translatable strings?
20160829 06:11:26< vultraz> did i remember to remove that reference?
20160829 06:11:30< vultraz> preference*
20160829 06:11:35< vultraz> perhaps that is the issued
20160829 06:11:46< celticminstrel> I did see a removed advance preference in the diff.
20160829 06:11:57< vultraz> hm
20160829 06:12:02< vultraz> but it was an advanced preference..
20160829 06:12:48< vultraz> what const?
20160829 06:13:00< vultraz> also the only t_strings in prefs are in setup_hotkey_list
20160829 06:13:01< vultraz> hmm
20160829 06:13:12< celticminstrel> I mean the array of _()
20160829 06:14:47< vultraz> do you mean cat_names?
20160829 06:14:54< vultraz> doesn't do anything
20160829 06:15:06< celticminstrel> Try adding an empty entry at the end.
20160829 06:15:16< celticminstrel> (Not a fix, but could point to the ultimate cause.)
20160829 06:15:27< celticminstrel> (Yes I meant cat_names.)
20160829 06:17:06< celticminstrel> The reason I think it might be that is that for me there's an extra entry that shouldn't exist.
20160829 06:21:28< celticminstrel> The filter still isn't quite working right either... why...
20160829 06:22:25< celticminstrel> Well, I'll look again tomorrow.
20160829 06:22:58< celticminstrel> vultraz: Maybe change the <= on line 873 to <?
20160829 06:26:15< vultraz> celticminstrel: that fixes it
20160829 06:26:19< vultraz> (without a dummy entry)
20160829 06:26:33< celticminstrel> Guessing the dummy entry also fixed it though.
20160829 06:26:42< vultraz> i didn't try
20160829 06:26:46< celticminstrel> Ah.
20160829 06:26:51< celticminstrel> Well, good night then.
20160829 06:26:57< vultraz> the layout is rather broken, though
20160829 06:27:02< celticminstrel> It is.
20160829 06:27:05< vultraz> it's all in one column :|
20160829 06:27:06< celticminstrel> I'll be working on that.
20160829 06:27:17< celticminstrel> It looks better at 1024x768 and smaller.
20160829 06:27:22< vultraz> alright
20160829 06:27:29< celticminstrel> For some reason.
20160829 06:29:24< celticminstrel> Ohhhh, I see what the problem is.
20160829 06:29:41< celticminstrel> With the filter, I didn't exclude hidden hotkeys from consideration.
20160829 06:36:36-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160829 06:39:14-!- fabi_ [~fabi@176.7.57.40] has joined #wesnoth-dev
20160829 06:39:14-!- fabi [~fabi@176.5.22.123] has quit [Read error: Connection reset by peer]
20160829 06:39:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160829 06:39:28-!- wedge010 is now known as wedge009
20160829 06:44:37< vultraz> i don't really understand why it works better at lower reses
20160829 06:44:45< vultraz> considering the window is mostly the same size
20160829 06:45:38-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 06:45:39< travis-ci> wesnoth/wesnoth#10589 (master - 7bf1e33 : Celtic Minstrel): The build has errored.
20160829 06:45:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155852363
20160829 06:45:39-!- travis-ci [~travis-ci@ec2-54-157-56-6.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 06:45:57< irker612> wesnoth: Charles Dang wesnoth:master 7be3e454720d / src/gui/dialogs/preferences_dialog.cpp: Preferences: fixed a crash in new hotkey categories https://github.com/wesnoth/wesnoth/commit/7be3e454720dbe2c383d1df2bdf8e193695980c8
20160829 06:46:43-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160829 06:50:30< celticminstrel> Editor Selection category seems to be empty. I guess those hotkeys are all hidden ones. (Why are some hidden, anyway?)
20160829 06:52:42< vultraz> don't ask me
20160829 06:52:44< celticminstrel> Ah, they're not real hotkeys.
20160829 06:53:00< celticminstrel> Some of the editor menus are pretty hacky.
20160829 06:55:36< vultraz> oh?
20160829 07:11:36-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160829 07:20:43< irker612> wesnoth: Wedge009 wesnoth:master 6ae79eaed69b / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Updating VC project files. https://github.com/wesnoth/wesnoth/commit/6ae79eaed69b1a7411eb049dd6702563aa893290
20160829 07:23:06< shadowm> vultraz, zookeeper: Opinions on whether this is spam? I lean towards 'yes' at the moment. https://dl.dropboxusercontent.com/u/21371130/screenshots/Screenshot_20160829_042113.png
20160829 07:23:20< shadowm> (Which is why the user in question is already bancannoned.)
20160829 07:23:31< vultraz> yes
20160829 07:25:11< vultraz> wedge009: ping
20160829 07:25:21-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160829 07:25:44< wedge009> vultraz: Hai.
20160829 07:26:01< vultraz> actually, anyone: is it just me, or does the text in 'old' look worse here? https://www.dropbox.com/s/dq1c0k8l2b36f7r/Screenshot%202016-08-29%2018.24.43.png?dl=0
20160829 07:26:13< wedge009> shadowm: That looks like a forum bot to me.
20160829 07:27:25< vultraz> to me it looks significantly worse :|
20160829 07:27:32< vultraz> but as to the cause, I do not know
20160829 07:28:13< vultraz> (also looks like i mislabeled the rows)
20160829 07:28:29< wedge009> vultraz: On first glance I don't see much difference. But on focusing on the details I think 'old' does look marginally worse. Might be better to have two snippets A and B and ask people which one they think is nicer, to avoid bias.
20160829 07:28:54< wedge009> The 
20160829 07:28:57< wedge009> Sorry.
20160829 07:29:14< wedge009> The 'w' in Host Networked Game, is one example.
20160829 07:29:33< vultraz> this is really rather odd
20160829 07:29:56< wedge009> I gather you haven't changed anything you would think would be related to the text rendering?
20160829 07:30:12< vultraz> I changed the rendering method in the dialog
20160829 07:30:17< wedge009> Okay.
20160829 07:30:37< wedge009> Also, just my opinion, maybe 'Join Official Server' + 'Join a custom server'?
20160829 07:30:53< vultraz> maybe
20160829 07:30:57< vultraz> that'd be a different commit though
20160829 07:31:07< wedge009> That's fine, just a suggestion.
20160829 07:31:42< wedge009> What's current in your image, is that on master right now?
20160829 07:32:18< wedge009> Hmm, probably not, I'm seeing 'old' in my compilation.
20160829 07:32:32< wedge009> On Windows, that is.
20160829 07:32:36< irker612> wesnoth: Charles Dang wesnoth:master 6da41bffbebe / data/gui/window/mp_method_selection.cfg: MP Method Selection: use a proper toggle panel for list https://github.com/wesnoth/wesnoth/commit/6da41bffbebe363f1bcd99af748d06a9166a2963
20160829 07:32:43< vultraz> wedge009: ^ please do a test before/after
20160829 07:33:05< zookeeper> shadowm, i saw it already but wasn't sure so i left it alone
20160829 07:33:21< vultraz> i'm sure it's indeed better
20160829 07:33:25< vultraz> question is why :|
20160829 07:37:04< wedge009> vultraz: Are you sure there's nothing else uncommitted? I'm not sure I see any difference + my text still says 'Connect to Server'. For both GB and US.
20160829 07:37:18< vultraz> I did not change the text
20160829 07:37:31< wedge009> Oh, I see, tool-tip.
20160829 07:39:52-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 07:39:54< travis-ci> wesnoth/wesnoth#10590 (master - 7be3e45 : Charles Dang): The build has errored.
20160829 07:39:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155858670
20160829 07:39:54-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 07:41:18< irker612> wesnoth: Charles Dang wesnoth:master 0bc5e2ba4a4e / data/gui/widget/ (toggle_button_listbox_text.cfg toggle_button_listbox_text_with_icon.cfg): Removed listbox toggle button definitions https://github.com/wesnoth/wesnoth/commit/0bc5e2ba4a4e953b81b505a7feb9baf85beaad30
20160829 07:43:07< wedge009> vultraz: If I had to guess, the change in alignment of the text has some weird effect on the renderer. Without understanding everything you changed in the cfg, I see there's a bit of padding between the icons and the text, plus maybe a bit between each option row as well.
20160829 07:43:33< wedge009> I am noticing the improvement when I do a side-by-side comparison.
20160829 07:43:43< vultraz> the biggest change is a use of a toggle panel and a label inside it instead of a custom toggle button that uses [draw] [text]
20160829 07:43:56< vultraz> i've noticed the improvement any time i make that change
20160829 07:56:30-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160829 08:10:19< irker612> wesnoth: Charles Dang wesnoth:master 0bbe26ec5e22 / / (11 files in 5 dirs): Made use of [list_data] for static lists in various dialogs https://github.com/wesnoth/wesnoth/commit/0bbe26ec5e220d652cd220c9de78b22d14e42b86
20160829 08:12:37< wedge009> Well, that's at least one bug report that's fixed by your gui2 MP work, vultraz.
20160829 08:12:47< vultraz> hm?
20160829 08:12:52< vultraz> what bug is this?
20160829 08:16:59< vultraz> wedge009: btw, you were asking whether the image scaling in help was handled
20160829 08:17:17< vultraz> iirc, the actual algorithm is in scale_surface, in src/sdl/utils.cpp:446
20160829 08:27:16-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 08:27:17< travis-ci> wesnoth/wesnoth#10591 (master - 6ae79ea : Wedge009): The build has errored.
20160829 08:27:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155864075
20160829 08:27:17-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 08:30:52-!- Duthlet [~Duthlet@dslb-188-104-247-024.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20160829 08:32:22< wedge009> vultraz: https://gna.org/bugs/?15149
20160829 08:32:26< wedge009> Presumably first of many.
20160829 08:32:35< wedge009> I'll have a look, thanks.
20160829 08:33:01< vultraz> more like Agino r's changes
20160829 08:34:02< wedge009> Oh okay.
20160829 08:34:04< vultraz> likely*
20160829 08:34:18< wedge009> Before you had done this revamp, I noticed it was still an issue.
20160829 08:34:28< wedge009> Various MP experimental lobby bugs, I mean.
20160829 08:34:41< vultraz> also perhaps fixed when i moved prefs to gui2
20160829 08:35:06< vultraz> marking as fixed
20160829 08:35:21< vultraz> send any other newly fixed gui2 bugs myway
20160829 08:38:19< wedge009> https://gna.org/bugs/?11276 should have been closed with release of 1.13.5, I believe.
20160829 08:38:51< wedge009> I'm still not in the BfW gna group, BTW.
20160829 08:39:07< wedge009> https://gna.org/bugs/?12162 seems to be resolved with gui2.
20160829 08:39:59< vultraz> that first one wasn't fixed  until after'
20160829 08:40:27< wedge009> Oh okay.
20160829 08:40:38< wedge009> Was the original experimental lobby gui1?
20160829 08:41:18< vultraz> no
20160829 08:41:43< wedge009> You disappeared from the official server.
20160829 08:42:00< wedge009> Well, your brief presence let me test https://gna.org/bugs/?15561. Seems okay.
20160829 08:43:48< vultraz> ah yes
20160829 08:43:55< vultraz> only took 6 years :P
20160829 08:44:14< wedge009> Better than never! :D
20160829 08:46:24-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160829 08:49:25< wedge009> https://gna.org/bugs/?15690
20160829 08:50:52< vultraz> so nice to finally fix these
20160829 08:51:25< wedge009> I concur.
20160829 08:53:37< wedge009> Oh wow, love the fade-out on music mute (I know that was a PR from not too long ago).
20160829 08:56:24< wedge009> Tentative only, since it's hard to test: https://gna.org/bugs/?14741
20160829 08:57:50< wedge009> Thanks for closing that, zookeeper.
20160829 09:06:16< wedge009> vultraz: https://gna.org/bugs/?15893
20160829 09:08:58-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 09:08:59< travis-ci> wesnoth/wesnoth#10592 (master - 6da41bf : Charles Dang): The build has errored.
20160829 09:08:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155865821
20160829 09:08:59-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 09:12:04< wedge009> https://gna.org/bugs/?17324 as well.
20160829 09:12:28-!- RatArmy [~RatArmy@133.15.175.65] has quit [Ping timeout: 265 seconds]
20160829 09:13:26< wedge009> It looks like the new MP design sets a time-limit by default - is that right?
20160829 09:13:32< wedge009> I never remember using that feature before.
20160829 09:22:40< wedge009> https://gna.org/bugs/?18116
20160829 09:35:17< zookeeper> uh... lol? git interactive rebase doesn't even have instructions of how its interface works?
20160829 09:36:14-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 09:36:15< travis-ci> wesnoth/wesnoth#10593 (master - 0bc5e2b : Charles Dang): The build has errored.
20160829 09:36:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155867074
20160829 09:36:15-!- travis-ci [~travis-ci@ec2-54-92-161-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 09:36:25< JyrkiVesterinen> Are you using command-line Git? It shows a list of commands in the text editor.
20160829 09:36:28< shadowm> lol indeed.
20160829 09:36:32< JyrkiVesterinen> https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History
20160829 09:36:41< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/Screenshot_20160829_063621.png
20160829 09:37:24< zookeeper> yeah that's what i see
20160829 09:37:36< shadowm> That's instructions.
20160829 09:38:26< zookeeper> oh wait i think i get it. it's not a program that lets me do it, it just opened a file in a text editor which in my case seems to be vim which i can't use.
20160829 09:38:38< zookeeper> ...right?
20160829 09:38:45< shadowm> Probably.
20160829 09:39:02< shadowm> Providing instructions on how to use whatever text editor happens to be the default there is certainly beyond its scope.
20160829 09:39:15< zookeeper> so i could just find the file by hand and edit it with whatever i want, maybe
20160829 09:39:38< shadowm> Or you can use `git config --global core.editor nano` or whatever instead of nano.
20160829 09:40:23< zookeeper> does it need to be a command-line editor?
20160829 09:40:34< shadowm> No.
20160829 09:41:20< zookeeper> hmh
20160829 09:41:22< shadowm> I think it can be anything that will react meaningfully to a path provided in the command line.
20160829 09:41:36< shadowm> And not exit prematurely.
20160829 09:43:01< zookeeper> ah well, too hard. and has eaten up several times the time it would have taken me to just wipe everything and redo the commits by hand.
20160829 09:43:31< shadowm> No comment.
20160829 09:44:23< shadowm> Well, just the one. Something about a man and a fish.
20160829 09:44:51< zookeeper> well i just don't fish :p
20160829 09:49:34< zookeeper> oh fun i did manage to have it use notepad++.
20160829 09:51:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160829 09:52:48 * zookeeper crosses fingers
20160829 09:53:56< zookeeper> wow it worked. amazing.
20160829 09:57:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160829 10:14:25-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 10:14:26< travis-ci> wesnoth/wesnoth#10594 (master - 0bbe26e : Charles Dang): The build has errored.
20160829 10:14:27< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155871631
20160829 10:14:27-!- travis-ci [~travis-ci@ec2-54-82-66-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 10:27:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160829 10:32:26< wedge009> vultraz: I think you would know best if this one is still relevant: https://gna.org/bugs/?23822
20160829 10:39:56< vultraz> wedge009: thanks
20160829 10:40:08< wedge009> No worries.
20160829 10:43:54< wedge009> vultraz: https://gna.org/bugs/?24481
20160829 10:44:20< wedge009> Oh wait.
20160829 10:44:30< wedge009> Doesn't specifically say experimental lobby. o.o
20160829 10:44:39< vultraz> doesn't matter
20160829 10:44:44< vultraz> old lobby is going away soon anyway
20160829 10:45:07< wedge009> Oh, old lobby doesn't have filter.
20160829 10:45:35< wedge009> Yes it does.
20160829 10:45:43 * wedge009 is sounding schizophrenic
20160829 10:45:50< wedge009> Both filters are fine for me.
20160829 11:05:10< wedge009> vultraz: Perhaps not strictly related to your development, but https://gna.org/bugs/?24728 is fixed. I tested both interfaces.
20160829 11:05:17< nore> hm, is it known that showing enemy moves allows to see where enemies can go, even if the path goes through a shrouded area?
20160829 11:05:30< nore> (that's with 1.12, it may have been fixed since then)
20160829 11:07:38-!- fabi__ [~fabi@176.5.34.149] has joined #wesnoth-dev
20160829 11:08:08< wedge009> Just been reviewing the bug reports, I've seen a few relating to 'show moves'. Not specifically to shroud, but I think they point out it's not as helpful as it could/should be.
20160829 11:11:43-!- fabi_ [~fabi@176.7.57.40] has quit [Ping timeout: 255 seconds]
20160829 11:12:05-!- irker612 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160829 11:15:34< zookeeper> nore, uh, good question.
20160829 11:17:53< zookeeper> luckily that seems like it'd happen very rarely, and at least it doesn't screw the player over in any way...
20160829 11:20:15< wedge009> Hmm, my games are still hanging around on the official server even though all instances on Highwind has shut down.
20160829 11:22:01-!- Kwandulin [~Miranda@p200300760F4241050DC6399F4AD72C6E.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160829 11:28:59< wedge009> vultraz (and anyone else testing experimental MP lobby): What do you get when you try to whisper anyone and then close the whisper tab?
20160829 11:51:32-!- Kwandulin [~Miranda@p200300760F424105E4040460551DDEBB.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160829 11:57:42-!- louis94 [~~louis94@91.178.242.69] has joined #wesnoth-dev
20160829 11:59:35< wedge009> Maybe you know about it already, maybe you don't, but here are the details: https://gna.org/bugs/?25021
20160829 12:01:25-!- louis94 [~~louis94@91.178.242.69] has quit [Client Quit]
20160829 12:06:43-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160829 12:22:16< JyrkiVesterinen> Hmm, bug 25201 looks like another case of a GUI2 event handler removing itself.
20160829 12:22:53< JyrkiVesterinen> I fixed a crash like that in https://github.com/wesnoth/wesnoth/commit/af2303df778225cb837461cc9943470835d01e1f
20160829 12:51:58< celticminstrel> I see you left the tooltip in the root widget (ie the toggle panel).
20160829 12:52:30< celticminstrel> Originally the macro had only the toggle panel in MP Create so that I could add an extra tab at tiny resolution, but I ended up not doing that.
20160829 13:06:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160829 13:15:03< celticminstrel> Should this be closed? https://gna.org/bugs/?3657
20160829 13:15:19< celticminstrel> I'm not quite sure, but my Label Settings dialog might satisfy it.
20160829 13:15:50< celticminstrel> Maybe not though.
20160829 13:16:17< celticminstrel> I guess that only lists the label categories. Maybe they want a list of every label on the map.
20160829 13:17:08< celticminstrel> Should this be closed? https://gna.org/bugs/?3379
20160829 13:17:18< celticminstrel> I was pretty sure the AI does respect fog and shroud.
20160829 13:19:43< celticminstrel> vultraz: This seems pretty easy if you want to add it. https://gna.org/bugs/?4180
20160829 13:20:48< celticminstrel> Here's another one that looks relatively easy. https://gna.org/bugs/?4235
20160829 13:22:56< mattsc> celticminstrel: I’m actually not sure whether the AI respects fog and shroud.  It does take hidden units into account (ambushers etc.), I know that.
20160829 13:23:29< celticminstrel> If it doesn't respect fog or shroud, I'd consider that a bug...
20160829 13:31:22< mattsc> I’m not sure if it would be easy to do something about that.  E.g. the MtT CA relies on knowing where to move to, otherwise the AI will just be idle.
20160829 13:32:27< celticminstrel> That one is indeed difficult... if the target is a location, it would make sense to treat it as if it were unshrouded, but if it's a unit, not so much...
20160829 13:35:17< celticminstrel> This sounds like an interesting idea. https://gna.org/bugs/?6293
20160829 13:35:29< celticminstrel> I wonder if this is still an issue. https://gna.org/bugs/?7449
20160829 13:35:45< celticminstrel> Also maybe it should be a bug rather than a feature request.
20160829 13:38:08< celticminstrel> This sounds useful, though it partially duplicates the function of help. https://gna.org/bugs/?8141
20160829 13:51:31< celticminstrel> This sounds somehow obsolete. https://gna.org/bugs/?9151
20160829 13:54:48-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160829 13:54:51< celticminstrel> This sounds like a nice idea. https://gna.org/bugs/?11525
20160829 13:56:12-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160829 13:58:07< celticminstrel> This is something that's sorely needed somehow. https://gna.org/bugs/?11811
20160829 13:59:15< celticminstrel> Hmm, that last comment at least is something that could be made possible, since it's in the Lua API.
20160829 13:59:36< celticminstrel> Though that would still require extending wmlxgettext
20160829 14:03:25< celticminstrel> To understand the _("", "", 0) syntax.
20160829 14:04:05< celticminstrel> Maybe Elvish_Hunter or loonycyborg could do that? It seems a rather nontrivial change though.
20160829 14:05:17< celticminstrel> I think it would require an entirely new family of states.
20160829 14:05:41< vultraz> celticminstrel: are you referring to the tooltip in the root node in mp method selection?
20160829 14:05:48< celticminstrel> vultraz: Yes.
20160829 14:06:05< vultraz> yes I did that
20160829 14:14:02< celticminstrel> t_string itself has no plural support, huh...
20160829 14:14:08< vultraz> what's that function to ignore markup again
20160829 14:14:15< celticminstrel> Huh?
20160829 14:14:59< vultraz> i could have sworn we had a function to escape markup
20160829 14:15:23< celticminstrel> If you mean Pango markup, we do.
20160829 14:16:10< celticminstrel> escape_text in src/text.hpp
20160829 14:16:41< celticminstrel> Seems to also be one in src/serialization/string_utils.hpp for escaping characters in URLs.
20160829 14:17:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160829 14:20:04< vultraz> blahhggsgg
20160829 14:20:37< vultraz> discovered more markup problems in chat
20160829 14:24:17< vultraz> this accursed chat area has a million setters
20160829 14:25:23< vultraz> ok, let's fix tab closing
20160829 14:26:35 * vultraz ponders how to do this
20160829 14:27:14< vultraz> it needs an index..
20160829 14:28:17< vultraz> but it needs to be dynamically found..
20160829 14:28:52< vultraz> hm hm hm
20160829 14:28:55< vultraz> "	 * This represents the open chat windows (rooms and whispers at the moment)
20160829 14:28:56< vultraz> 	 * with 1 to 1 correspondence to what the user sees in the interface"
20160829 14:29:08< vultraz> I am sensing.. idea
20160829 14:40:17< vultraz> hm
20160829 14:40:22< vultraz> not working, this is
20160829 14:40:34 * vultraz runs debugger
20160829 14:42:33-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160829 14:44:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160829 14:45:07< vultraz> ok, it works now
20160829 14:46:03< vultraz> and now it's not :|
20160829 14:46:10< vultraz> why does it random decide not to work
20160829 14:47:35< vultraz> well, actually, it's a different area anyway
20160829 14:53:04-!- irker082 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160829 14:53:04< irker082> wesnoth: Charles Dang wesnoth:master 792e38b30f8f / src/gui/dialogs/lobby/ (lobby.cpp lobby.hpp): MP Lobby: some chat-related fixes https://github.com/wesnoth/wesnoth/commit/792e38b30f8f3835bb48900578a71969d84a3b03
20160829 14:54:01< celticminstrel> Ugh, I really hate the std::placeholders namespace.
20160829 14:57:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160829 15:00:42-!- Kwandulin [~Miranda@p200300760F424105E4040460551DDEBB.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160829 15:01:10< vultraz> are you working on the matrix policy?
20160829 15:01:35< celticminstrel> I got distracted by https://gna.org/bugs/?11811 but I'll get back to it soon probably.
20160829 15:03:40< vultraz> hm
20160829 15:04:00< vultraz> i just realized... my fix might not work if there are two rooms with the same name
20160829 15:04:12< celticminstrel> I would expect that to be impossible.
20160829 15:04:29< vultraz> maybe I should check &a == &b
20160829 15:05:11< vultraz> it's already possible to open two whisper sessions with yourself..
20160829 15:05:18< vultraz> but yeah, i should probably fix that itself
20160829 15:05:31< celticminstrel> It probably shouldn't be possible to open any whisper sessions with yourself.
20160829 15:07:33< vultraz> well, then, two whisper sessions with someone else
20160829 15:07:36< vultraz> (i think)
20160829 15:08:20-!- louis94 [~~louis94@91.178.242.69] has joined #wesnoth-dev
20160829 15:09:56< celticminstrel> How do I mark a bug as a duplicate of another?
20160829 15:10:05< celticminstrel> I know I can set the status to duplicate.
20160829 15:10:21< celticminstrel> But isn't there also a way to point to the other bug?
20160829 15:12:25< vultraz> i dunno, i just paste the url in the comments
20160829 15:12:42< celticminstrel> Ugh, okay.
20160829 15:15:37< celticminstrel> vultraz: https://gna.org/bugs/?24930
20160829 15:16:29< vultraz> and..?
20160829 15:16:47< vultraz> what is it you need?
20160829 15:16:53< celticminstrel> I dunno, maybe you should comment since you're the layout person.
20160829 15:17:08< celticminstrel> Not sure that it's really an issue.
20160829 15:17:15< vultraz> i have no idea why it happens
20160829 15:17:55-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160829 15:18:43< vultraz> random question:
20160829 15:19:02< vultraz> what does one do if one is sorting and wants a particular entry always on top?
20160829 15:19:37< vultraz> a < b && a == 'foo' or something?
20160829 15:19:54< celticminstrel> if(lhs == special_entry) return true;
20160829 15:20:14< celticminstrel> Otherwise return lhs < rhs
20160829 15:20:40< vultraz> ah
20160829 15:20:42< celticminstrel> I guess if rhs is also special_entry you should return false.
20160829 15:20:49-!- jswensen [~jswensen@s48075040.temp.wsu.edu] has joined #wesnoth-dev
20160829 15:21:20< celticminstrel> So if(lhs == special_entry) return rhs != special_entry; I think.
20160829 15:21:30< celticminstrel> Why do you want this BTW?
20160829 15:22:11< vultraz> want to sort the leader list in the flg manager alphabetically but always have Random on top
20160829 15:22:22< celticminstrel> Hmm.
20160829 15:22:46< celticminstrel> Isn't Random defined by the era?
20160829 15:24:06< vultraz> the flg manager constructs a list
20160829 15:24:40< celticminstrel> No, I mean, isn't Random explicitly defined as a [multiplayer_side] in the era.
20160829 15:24:56< vultraz> I'm not sure your point
20160829 15:25:17< celticminstrel> If it is, hard-coding it as a special case isn't a great idea. What if an era offers multiple random choices?
20160829 15:25:45< vultraz> random is always on top anyway
20160829 15:25:56< vultraz> I;m just ensuring it's on top post-sort
20160829 15:25:59< celticminstrel> For example, if it groups its factions into "A" and "B" groups, it could offer "Random A" and "Random B".
20160829 15:26:33< celticminstrel> So if it's defined in the era, it makes more sense to support this with a key in [multiplayer_side].
20160829 15:27:13< celticminstrel> Maybe ignore_sort=yes, or for greatest flexibility sort_key=1 (default sort_key would be 0, and higher sort keys would come first).
20160829 15:27:15< vultraz> "random" is a leader type
20160829 15:27:28< vultraz> i don't think it matters how many randoms there are
20160829 15:27:44< celticminstrel> So is it or is it not defined by the era?
20160829 15:27:55< celticminstrel> I guess I got a little confused here mixing up "faction" and "leader".
20160829 15:28:04-!- fabi_ [~fabi@176.0.30.39] has joined #wesnoth-dev
20160829 15:28:08< celticminstrel> I guess the proper question then is "is it defined by the faction".
20160829 15:28:14< vultraz> there's also a random faction option :)
20160829 15:28:22< celticminstrel> I know, that's why I got confused.
20160829 15:28:39< celticminstrel> If I recall correctly, the random faction is a separate [multiplayer_side] in the era.
20160829 15:29:04< celticminstrel> And if I recall correctly, random leader is only supported by having a separate list to choose from...
20160829 15:29:22< celticminstrel> So given that, I guess special-casing random in the leader list could be okay.
20160829 15:31:05< vultraz> [multiplayer_side] seems to handle faction
20160829 15:31:06< vultraz> s
20160829 15:31:24-!- fabi__ [~fabi@176.5.34.149] has quit [Ping timeout: 265 seconds]
20160829 15:31:35< vultraz> blah, why does it keep appearing at the END of the list :|
20160829 15:31:43< celticminstrel> [multiplayer_side] is a faction.
20160829 15:33:19< vultraz> (random, but I just realized the whole 'number of wml menu items' thing could have been avoided in the first place since even the gui1 dropdown had a scrollbar :|
20160829 15:33:41< celticminstrel> I think the motivation was a bit different.
20160829 15:34:09< vultraz> hm?
20160829 15:37:17< vultraz> ok I give up
20160829 15:37:27< vultraz> Random keeps appearing at the end :|
20160829 15:37:28< celticminstrel> ?
20160829 15:37:58< celticminstrel> What's your comparator look like?
20160829 15:38:45< zookeeper> Ravana_, uh, if you split a thread because it was a 9 year necro, then it doesn't really make sense to post in it to say you split something off of it...
20160829 15:39:02< Ravana_> ok, removing my post
20160829 15:39:18< vultraz> i've tried multiple permutations 
20160829 15:39:44< vultraz> hmmm
20160829 15:39:48< vultraz> maybe it's the dialog...
20160829 15:40:56-!- jswensen [~jswensen@s48075040.temp.wsu.edu] has quit [Quit: jswensen]
20160829 15:41:12< vultraz> yeah looks like the problem is in the dialog
20160829 15:41:21< vultraz> or is it?
20160829 15:41:31< vultraz> ponder ponder
20160829 15:41:56< vultraz> yeah .. on second thought it shouldn't be :|
20160829 15:46:20-!- Kwandulin [~Miranda@p200300760F424105C073142E1B4683BD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160829 15:47:14-!- travis-ci [~travis-ci@ec2-54-198-172-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 15:47:15< travis-ci> wesnoth/wesnoth#10596 (master - 792e38b : Charles Dang): The build has errored.
20160829 15:47:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155956471
20160829 15:47:15-!- travis-ci [~travis-ci@ec2-54-198-172-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 15:50:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 15:50:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160829 15:50:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 15:51:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20160829 15:51:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 15:58:31-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160829 16:02:27-!- esr [~esr@wesnoth/developer/esr] has quit [Quit: WeeChat 1.4]
20160829 16:07:46-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20160829 16:13:31< vultraz> celticminstrel: this works: return str2 == "random" ? str1 > str2 : str1 < str2;
20160829 16:14:46< vultraz> is that acceptable
20160829 16:14:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160829 16:16:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 16:16:22< celticminstrel> What.
20160829 16:16:51< vultraz> it works and I don't question :P
20160829 16:17:04< celticminstrel> How about return str1 == "random" ? str2 != "random" : str1 < str2;
20160829 16:17:23< celticminstrel> And if that doesn't work, try == instead of !=
20160829 16:19:15< vultraz> celticminstrel: neither works
20160829 16:19:19< celticminstrel> :|
20160829 16:19:19< vultraz> random is at the end
20160829 16:19:30< celticminstrel> Okay, so.
20160829 16:19:46< celticminstrel> The comparator should return true if str1 should come before str2.
20160829 16:19:54< celticminstrel> If str1 == str2, it should return false.
20160829 16:20:21< celticminstrel> Oh, right, is str1 "random" or "Random"?
20160829 16:20:27< vultraz> "random"
20160829 16:20:36< celticminstrel> Just checking.
20160829 16:21:34< celticminstrel> So, assuming str1 != str2, if str1 is "random" it should return true, otherwise it should return str1 < str2.
20160829 16:22:03< celticminstrel> If that logic still puts it at the end, I'd be wondering if there's something weird about how you're doing the sort.
20160829 16:22:54< vultraz> it's just a standard std::sort :| http://pastebin.com/7uBttuwf
20160829 16:25:45< celticminstrel> So what about a two-liner if(str1 == str2) return false; return str1 == "random" || str1 < str2;?
20160829 16:28:02< vultraz> nope
20160829 16:28:26< celticminstrel> Or retunr sr1 < str2 || str1 == "random";?
20160829 16:28:39< celticminstrel> ^str1
20160829 16:28:45< vultraz> just that?
20160829 16:28:46< celticminstrel> ^return
20160829 16:28:49< celticminstrel> I think so.
20160829 16:29:05< celticminstrel> Wait, no, if they're equal the str1 < str2 will be false...
20160829 16:29:08< celticminstrel> ^then
20160829 16:29:36< vultraz> nope
20160829 16:29:55< mattsc> wedge009: on [bug #23720] AI units with 0/0 moves will not attack adjacent enemies
20160829 16:30:10< mattsc> I know what’s going on here and have been thinking about a potential fix
20160829 16:30:11< vultraz> the only thing that's worked so far is  return str2 == "random" ? str1 > str2 : str1 < str2;
20160829 16:30:17< celticminstrel> Hmm.
20160829 16:30:23< celticminstrel> So why does that work.
20160829 16:30:54< celticminstrel> If they're both "random", then str1 > str2 is of course false.
20160829 16:30:56< mattsc> The “problem” is that it would have an influence on AI behavior in other situations as well, but I think that’s not a significant issue
20160829 16:31:00< celticminstrel> As is str1 < str2.
20160829 16:31:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160829 16:31:36< celticminstrel> Oh, I think I get what I was missing in the other things I suggested.
20160829 16:31:50< irker082> wesnoth: Charles Dang wesnoth:master 404f698a55e7 / src/gui/dialogs/ (preferences_dialog.cpp preferences_dialog.hpp): Preferences: cleaned up unused argument from initialize_tabs (fixup 0bbe26ec5e22 https://github.com/wesnoth/wesnoth/commit/404f698a55e7e8cce368ab0384a46515782b6e4b
20160829 16:32:01< celticminstrel> If str1 is random, you need to return true. If str2 is random, you need to return false.
20160829 16:32:01< vultraz> what was missing?
20160829 16:32:03< celticminstrel> So...
20160829 16:32:23< celticminstrel> Try return str2 == "random" ? str1 == random : str1 < str2; I think.
20160829 16:32:31< celticminstrel> Maybe one of those should be !=
20160829 16:32:49< celticminstrel> If str2 is random, you always want false.
20160829 16:33:02< celticminstrel> Hmm, that might still be missing something.
20160829 16:33:36< vultraz> it works :O
20160829 16:33:41< celticminstrel> If str2 is random, the result should always be false, because str1 is either random (and a < a is false) or str1 is not random (and thus should come after and is true).
20160829 16:34:13< celticminstrel> Hmm, well, it's not quite right, but...
20160829 16:34:56< celticminstrel> I think that implements <= for the case where one string is random.
20160829 16:35:01< mattsc> vultraz: I guess my comment up there is for you as well, since you submitted that bug
20160829 16:35:06< celticminstrel> Which is not terrible, but not perfect either.
20160829 16:35:16< mattsc> at some point I’ll get around to doing something about it ...
20160829 16:35:18< vultraz> mattsc: ?
20160829 16:35:21< vultraz> what bug?
20160829 16:35:31< celticminstrel> vultraz: Did you change one to !=?
20160829 16:35:36< vultraz> celticminstrel: no
20160829 16:36:04< mattsc> vultraz: the one I was quoting a couple minutes ago, with both bug # and subject line.
20160829 16:36:16< celticminstrel> Is there a leader beginning with a leter < R?
20160829 16:36:20< celticminstrel> ^letter
20160829 16:36:47< vultraz> < R as in before R?
20160829 16:36:50< celticminstrel> Yes.
20160829 16:36:53< vultraz> yes
20160829 16:36:58< vultraz> mattsc: oh huh I did
20160829 16:37:01< celticminstrel> I'm confused.
20160829 16:37:06< celticminstrel> mattsc: Any insight here.
20160829 16:37:27< mattsc> celticminstrel: ?
20160829 16:37:55< celticminstrel> A comparison function where one arbitrary value is treated as the minimum.
20160829 16:38:53< celticminstrel> vultraz: I might have a better idea actually. The random option is initially the first, right?
20160829 16:39:04< vultraz> yes
20160829 16:39:12< celticminstrel> Is it always present?
20160829 16:39:20< vultraz> unsure
20160829 16:39:35< vultraz> I think it's always present if options > 1
20160829 16:39:38< celticminstrel> Well, if it's present, then std::sort(begin() + 1, end());
20160829 16:40:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160829 16:40:22< celticminstrel> No custom comparator needed, just omit random from the sorted range.
20160829 16:40:34< vultraz> why didn't I think of that
20160829 16:40:37< celticminstrel> No idea!
20160829 16:40:56< celticminstrel> Maybe because std algorithm functions are most commonly used on the whole container.
20160829 16:44:10< irker082> wesnoth: Charles Dang wesnoth:master af30309687e7 / src/ (game_initialization/flg_manager.cpp gui/dialogs/multiplayer/faction_select.cpp): FLG Manager: sort leader list alphabetically, with Random first https://github.com/wesnoth/wesnoth/commit/af30309687e7e460f3ce1acad90a1b4348ecdd08
20160829 16:44:13< irker082> wesnoth: Charles Dang wesnoth:master 3b739b73e9c3 / src/gui/dialogs/lobby/lobby.cpp: MP Lobby: disable ESC closure https://github.com/wesnoth/wesnoth/commit/3b739b73e9c31ba14b0d523ab7ca5847524fe904
20160829 16:44:23< mattsc> celticminstrel: I don’t know what you mean with your comment to me up there
20160829 16:44:27< celticminstrel> I don't like that.
20160829 16:44:34< celticminstrel> mattsc: Don't worry, we've solved it.
20160829 16:44:45< mattsc> ok  good
20160829 16:45:02< celticminstrel> vultraz: ESC should close the MP lobby.
20160829 16:45:10< celticminstrel> I'd be fine with adding a confirmation, mind you/
20160829 16:45:23< vultraz> celticminstrel: no, one should use Log Out :|
20160829 16:45:38< celticminstrel> And what's the keyboard shortcut for that?
20160829 16:45:43< vultraz> nothing
20160829 16:45:52< celticminstrel> Esc should be equivalent to Log Out when used in the MP Lobby.
20160829 16:45:53< vultraz> but enabling esc closure is too dangerous
20160829 16:46:02< celticminstrel> It's not dangerous at all?
20160829 16:46:08< celticminstrel> I don't see what's dangerous about it.
20160829 16:46:13< celticminstrel> There's no data to lose in the lobby.
20160829 16:46:19< vultraz> imagine you're getting ready for a game with some people and accidentally press esc 
20160829 16:46:25< celticminstrel> Except maybe chat logs, but that's rarely important.
20160829 16:46:40< celticminstrel> Still, if that's your worry, just confirm it first.
20160829 16:47:17< celticminstrel> That said, if you're getting ready for a game and accidentally pressing escape, there's nothing to stop you from reconnecting and carrying on as before.
20160829 16:47:56< celticminstrel> vultraz: Did you confirm that the random leader option is always present, by the way? Because, if it's ever not present, that commit will be buggy.
20160829 16:48:20< vultraz> [03:39:33]	vultraz	I think it's always present if options > 1
20160829 16:48:36< celticminstrel> Emphasis on "I think"
20160829 16:48:53< vultraz> yes :)
20160829 16:49:02< celticminstrel> That implies you didn't confirm it.
20160829 16:49:12< vultraz> also, printing a 'quit' confirmation is harder than you think
20160829 16:49:53< celticminstrel> Pretty sure it's trivial. Make the MP dialog extend quit_confirmation.
20160829 16:50:28-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160829 16:51:54< vultraz> i guess that's one way to do it..
20160829 16:52:40< vultraz> i was thinking more along the lines of adding a pre_exit dialog hook
20160829 16:52:50< vultraz> like post_show, except it fires before the dialog closes
20160829 16:53:06< vultraz> it could be used for the difficulty dialog in Create too
20160829 16:53:11< celticminstrel> Um...
20160829 16:53:21< celticminstrel> How would such a hook help?
20160829 16:53:29< celticminstrel> I don't think it would let you cancel the exit.
20160829 16:53:43< celticminstrel> Maybe I'm misunderstanding something.
20160829 16:53:47< vultraz> the idea of the design would be that it would
20160829 16:53:59< vultraz> since it would fire inside of twindow::show
20160829 16:54:01< vultraz> not tdialog::show
20160829 16:54:03< celticminstrel> BTW, was Esc already equivalent to Log Out?
20160829 16:54:17< vultraz> yes
20160829 16:54:32< celticminstrel> I think extending quit_confirmation is probably better then.
20160829 16:55:01< celticminstrel> And has the added bonus of catching Cmd+Q / Alt+F4 as well.
20160829 16:55:23< vultraz> at least I think so..
20160829 16:56:06< vultraz> it has the id "quit"
20160829 16:56:08< vultraz> not "cancel"
20160829 16:56:10< vultraz> hm
20160829 16:56:17< vultraz> but there's no custom hook
20160829 16:56:33< vultraz> i think ESC might have been functionally equivalent but I'd like to be sure
20160829 16:56:53< vultraz> once we drop the gui1 lobby
20160829 16:58:54< vultraz> anyway
20160829 16:58:59< vultraz> you should fix the matrix placement
20160829 16:59:05< vultraz> before going on gettext tangents :|
20160829 16:59:09< celticminstrel> Yeah, I'll try.
20160829 16:59:35< celticminstrel> The tangent is already basically done, but then I figured that since I'd touched t_string I might as well also do the config iterator stuff I'd been planning.
20160829 16:59:49< celticminstrel> (Done but untested, admittedly.)
20160829 17:02:15-!- atarocch [~atarocch@88.131.217.34] has joined #wesnoth-dev
20160829 17:02:39-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160829 17:03:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160829 17:08:41< celticminstrel> Starting a build now, finally.
20160829 17:09:16< celticminstrel> Gonna go eat while it builds.
20160829 17:09:38< celticminstrel> After that I should be able to look at the matrix policy again.
20160829 17:11:42< celticminstrel> Well, once the errors are fixed, of course.
20160829 17:21:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 17:25:59-!- travis-ci [~travis-ci@ec2-184-72-163-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 17:26:00< travis-ci> wesnoth/wesnoth#10597 (master - 404f698 : Charles Dang): The build has errored.
20160829 17:26:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155983774
20160829 17:26:00-!- travis-ci [~travis-ci@ec2-184-72-163-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 17:26:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160829 17:26:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 17:43:57< Ravana_> is wmlindent supposed to enforce linux style line endings?
20160829 17:45:12< Ravana_> but even then, it left one unquoted \r intact
20160829 17:46:00-!- Kwandulin [~Miranda@p200300760F424105C073142E1B4683BD.dip0.t-ipconnect.de] has quit [Quit: Kwandulin]
20160829 17:49:25-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160829 17:49:39-!- louis94 [~~louis94@91.178.242.69] has quit [Ping timeout: 244 seconds]
20160829 17:53:15< Ravana_> just seems strange that it wanted to change 2300 files suddenly
20160829 17:54:17< celticminstrel> Speaking of indentation... does anyone think that one-space or two-space indentation might be better for GUI2 WML?
20160829 17:56:11< vultraz> no
20160829 17:56:28< celticminstrel> Because it gets to ridiculous levels.
20160829 17:56:31< vultraz> tabs are easiest to work witg
20160829 17:56:33< vultraz> with
20160829 17:56:36< celticminstrel> True,
20160829 17:56:41< vultraz> since i can mass-indent blocks
20160829 17:57:05< celticminstrel> I can do that regardless of whether it's spaces or tabs.
20160829 18:01:05-!- mjs-de [~mjs-de@129.217.129.160] has joined #wesnoth-dev
20160829 18:04:41-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160829 18:07:24-!- Shiki [~Shiki@141.39.226.227] has quit [Quit: Verlassend]
20160829 18:12:18-!- travis-ci [~travis-ci@ec2-184-72-163-62.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 18:12:19< travis-ci> wesnoth/wesnoth#10598 (master - 3b739b7 : Charles Dang): The build has errored.
20160829 18:12:19< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/155986514
20160829 18:12:19-!- travis-ci [~travis-ci@ec2-184-72-163-62.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 18:19:12< irker082> wesnoth: Charles Dang wesnoth:master c4a475145304 / src/gui/widgets/listbox.cpp: Attempt to appease travis on signed-ness https://github.com/wesnoth/wesnoth/commit/c4a47514530453d671e0762471fea18e40de3956
20160829 18:21:22< vultraz> down with size_t!
20160829 18:24:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160829 18:27:04< celticminstrel> Nooooo! :O
20160829 18:27:10< celticminstrel> ( :P )
20160829 18:36:44-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160829 18:39:13-!- JyrkiVesterinen [~jyrki@89-166-100-14.bb.dnainternet.fi] has joined #wesnoth-dev
20160829 18:41:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 276 seconds]
20160829 18:41:10-!- wedge010 is now known as wedge009
20160829 18:48:02-!- louis94 [~~louis94@91.178.242.69] has joined #wesnoth-dev
20160829 18:55:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160829 19:00:22-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160829 19:01:58< vultraz> huh
20160829 19:02:10< vultraz> i can access admin controls in Player Info by editing one line in the c++
20160829 19:04:09< vultraz> doesn't this mean anyone who builds wesnoth could weirdly moderate the server?
20160829 19:04:32< celticminstrel> I'm not sure what you mean.
20160829 19:06:32< vultraz> player info is the popup you get when you doubleclick a user in the list
20160829 19:06:38< vultraz> there are admin options
20160829 19:06:51< celticminstrel> For example?
20160829 19:06:56< vultraz> but only if preferences::is_authenticated()
20160829 19:07:17< vultraz> check status (gives ip), kick, and kick/ban
20160829 19:07:22< celticminstrel> My suspicion would be that having them visible doesn't mean they'll actually work.
20160829 19:07:30< vultraz> status works
20160829 19:07:36< vultraz> kick crashes wesnoth
20160829 19:07:41< vultraz> granted im using it on myself :P
20160829 19:07:53< celticminstrel> That probably doesn't help.
20160829 19:07:56< vultraz> let me test with another instance
20160829 19:08:03< celticminstrel> It's logical for status to work on yourself, honestly.
20160829 19:08:18< celticminstrel> If kicking yourself causes a crash, that should be fixed.
20160829 19:08:27-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has quit [Ping timeout: 276 seconds]
20160829 19:08:29< vultraz> yeah kick causes a crash in the client calling it
20160829 19:08:41< zookeeper> well if you can make the controls visible to you then that naturally doesn't mean they will work.
20160829 19:08:51< celticminstrel> If attempting a kick without authentication causes a crash, that should also be fixed.
20160829 19:08:56< celticminstrel> What zookeeper said.
20160829 19:09:19< celticminstrel> It's the server that gets to decide whether they actually work.
20160829 19:10:15< vultraz> ok, status seems to work for just you
20160829 19:10:24< vultraz> the crash needs to be fixed,though
20160829 19:10:57< vultraz> remind me to add a little 'you' icon to the player list next to your name
20160829 19:11:18< celticminstrel> Good idea.
20160829 19:11:47< celticminstrel> vultraz: Did it crash when you tried to kick your alt instance too?
20160829 19:11:53< vultraz> yes
20160829 19:13:36-!- travis-ci [~travis-ci@ec2-54-198-172-69.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 19:13:37< travis-ci> wesnoth/wesnoth#10599 (master - c4a4751 : Charles Dang): The build has errored.
20160829 19:13:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156011665
20160829 19:13:37-!- travis-ci [~travis-ci@ec2-54-198-172-69.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 19:14:22< celticminstrel> So it's probably getting back some sort of "not authenticated" message and not handling it correctly.
20160829 19:14:53< celticminstrel> Oh, can you kick via command as well?
20160829 19:14:59< celticminstrel> Like /kick vultraz 
20160829 19:15:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 19:15:30< vultraz> apparently it has to do with the "query" command somehow..
20160829 19:15:45< vultraz> ill look into it later
20160829 19:15:48< celticminstrel> If you can kick via command, does it also crash?
20160829 19:15:53< vultraz> right now i'l cleaning up the horrible dialog layout
20160829 19:16:02< celticminstrel> Which dialog?
20160829 19:16:13< vultraz> player info
20160829 19:16:24< vultraz> no reason admins have to deal with shitty layout :)
20160829 19:16:35< vultraz> (who even are the server admins anymore)
20160829 19:17:06< celticminstrel> I think zookeeper is one, maybe Ravana_ (or is he just a forum mod?)? No idea who else.
20160829 19:17:21< Ravana_> only forum
20160829 19:17:51 * zookeeper doesn't actually even use the admin GUI controls
20160829 19:17:55< Ravana_> they have group https://forums.wesnoth.org/memberlist.php?mode=group&g=6651
20160829 19:18:03< celticminstrel> So you can kick via command then?
20160829 19:18:07< zookeeper> which is fully enough since usually i prefer GUIs to text-based interfaces
20160829 19:18:14< zookeeper> funny, even
20160829 19:18:26< vultraz> ok, the relevant answer is "2 people" :P
20160829 19:18:37< celticminstrel> Really?
20160829 19:20:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160829 19:20:13< vultraz> zookeeper and shadow m
20160829 19:21:01< celticminstrel> That's pretty surprising.
20160829 19:23:38< celticminstrel> I wonder if there are unit tests for config / vconfig.
20160829 19:24:10< celticminstrel> There are for config, at least.
20160829 19:28:23< celticminstrel> None for vconfig, or for iterators.
20160829 19:28:36< celticminstrel> I guess vconfig is untestable at the moment, since it accesses resources::gamedata.
20160829 19:33:02-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160829 19:41:22< fabi_> hi
20160829 19:46:03< irker082> wesnoth: Charles Dang wesnoth:master 5c2792556dec / data/gui/window/lobby_player_info.cfg: Player Info: reworked layout https://github.com/wesnoth/wesnoth/commit/5c2792556decbec5785107a59f7e8cfab4523d55
20160829 19:48:13< vultraz> ironically, the bottom border now aligns perfectly with one of the lobby's horizontal lines
20160829 19:48:15< vultraz> #math
20160829 19:48:39< celticminstrel> Why is it ironic
20160829 19:50:22< vultraz> surprisingly*
20160829 19:59:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 20:00:53< celticminstrel> I get the impression that gettext relies upon the source language being English.
20160829 20:01:45-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has joined #wesnoth-dev
20160829 20:07:33-!- louis94 [~~louis94@91.178.242.69] has quit [Ping timeout: 240 seconds]
20160829 20:10:49-!- JyrkiVesterinen [~jyrki@89-166-100-14.bb.dnainternet.fi] has quit [Quit: .]
20160829 20:14:53< celticminstrel> Okay, so, it... sort of... works?
20160829 20:15:26< celticminstrel> It's returning the wrong string, though.
20160829 20:15:38< celticminstrel> That is, the string corresponding to the wrong number.
20160829 20:15:56-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has quit [Ping timeout: 258 seconds]
20160829 20:23:03< irker082> wesnoth: Charles Dang wesnoth:master c4a7ca291bbd / src/gui/dialogs/lobby/player_info.cpp: Player Info: fixed crash when using Kick/Bad admin controls https://github.com/wesnoth/wesnoth/commit/c4a7ca291bbd300875024fc77e0c8433460caa95
20160829 20:23:09< vultraz> blah
20160829 20:23:11< vultraz> typo
20160829 20:26:35< celticminstrel> Hold on, I think I see what I did wrong. When I saw the example, I assumed the msgstr index was the count, meaning that gettext supports special strings for when the count is 0. However, it seems like it's actually the count - 1, so that msgstr[0] is the value for a count of 1.
20160829 20:27:27-!- prkc [~prkc@179.43.169.226] has joined #wesnoth-dev
20160829 20:28:34< irker082> wesnoth: Charles Dang wesnoth:master e5cbc0cb7bba / data/gui/window/lobby_player_info.cfg src/gui/dialogs/lobby/player_info.cpp: Player Info: removed an invalidate_layout call https://github.com/wesnoth/wesnoth/commit/e5cbc0cb7bba7cd2ebc6da1100df8d8bc8367b1e
20160829 20:29:17< celticminstrel> You know, it might be possible to block invalidate_layout altogether in some dialogs.
20160829 20:30:15-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160829 20:30:52< vultraz> there is an invalidate_layout_blocker
20160829 20:31:00< celticminstrel> [Aug 29@2:19:12pm] irker082: wesnoth: Charles Dang wesnoth:master c4a475145304 / src/gui/widgets/listbox.cpp: Attempt to appease travis on signed-ness https://github.com/wesnoth/wesnoth/commit/c4a47514530453d671e0762471fea18e40de3956
20160829 20:31:01< celticminstrel> [Aug 29@2:21:22pm] vultraz: down with size_t!
20160829 20:31:10< vultraz> it seems that failed, yes
20160829 20:31:22< celticminstrel> Because you didn't change the signedness.
20160829 20:31:26< celticminstrel> size_t is unsigned.
20160829 20:31:37< celticminstrel> So changing it to unsigned int won't change anything.
20160829 20:31:44< vultraz> should it just be int?
20160829 20:31:57< celticminstrel> Presumably.
20160829 20:32:19< celticminstrel> Or change the source variable to size_t.
20160829 20:32:27< celticminstrel> I guess it doesn't matter which one really.
20160829 20:32:45< irker082> wesnoth: Charles Dang wesnoth:master e5354766ce12 / src/gui/dialogs/lobby/lobby.cpp: MP Lobby: enable self indicator in user list https://github.com/wesnoth/wesnoth/commit/e5354766ce12a29384ade9eea79d9418904789c3
20160829 20:33:48< vultraz> celticminstrel: for the record, i get a warning locally if it's a plain int :|
20160829 20:33:49< celticminstrel> Hmm, well, it basically works, but I guess gettext doesn't support an arbitrary number of plurals?
20160829 20:33:56< celticminstrel> What warning?
20160829 20:34:07< vultraz> Wsign-compare
20160829 20:34:12< celticminstrel> Where?
20160829 20:34:34< vultraz> cols.size() == req_cols
20160829 20:35:06< celticminstrel> Right, it should be size_t then, assuming cols is a standard container.
20160829 20:35:20< vultraz> but travis fails with size_t
20160829 20:35:34 * celticminstrel is testing this by editing en_GB.po locally to make the objectives turns left string use plurals, but msgstr[2] and msgstr[3] are not used... presumably because gettext sees that it's English and concludes that only two forms are required.
20160829 20:35:40< celticminstrel> What's the error?
20160829 20:35:47< vultraz> the same thing :|
20160829 20:35:51< celticminstrel> Where?
20160829 20:35:56< vultraz> :|
20160829 20:35:59< vultraz> where do you think
20160829 20:36:00< celticminstrel> Same place?
20160829 20:36:03< vultraz> seriously
20160829 20:36:19< celticminstrel> It's not obvious that it would be in the same place.
20160829 20:37:20-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has joined #wesnoth-dev
20160829 20:37:31< celticminstrel> Ah, it's an iterator range.
20160829 20:39:24< celticminstrel> So it should be size_t after all.
20160829 20:39:46< celticminstrel> Though unsigned int should also work...
20160829 20:40:07< celticminstrel> But you said both failed... that's weird...
20160829 20:40:17< vultraz> both fail for travis
20160829 20:40:19< vultraz> not me
20160829 20:40:25< celticminstrel> Right.
20160829 20:40:28< vultraz> then again im on gcc 5
20160829 20:40:33-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 20:40:34< travis-ci> wesnoth/wesnoth#10600 (master - 5c27925 : Charles Dang): The build has errored.
20160829 20:40:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156033839
20160829 20:40:34-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 20:40:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160829 20:43:58< celticminstrel> Push coming.
20160829 20:44:11 * vultraz drumroll
20160829 20:44:32< celticminstrel> No layout fixes yet, but I fixed the functionality.
20160829 20:45:40-!- mjs-de [~mjs-de@129.217.129.160] has quit [Remote host closed the connection]
20160829 20:47:32< irker082> wesnoth: Celtic Minstrel wesnoth:master 116ff67c6e51 / src/ (8 files in 4 dirs): Improvements to the config interfaces, mainly iterators https://github.com/wesnoth/wesnoth/commit/116ff67c6e51a51ee400539e69a95d85f5fb661b
20160829 20:47:34< irker082> wesnoth: Celtic Minstrel wesnoth:master f866039e813b / / (4 files in 3 dirs): Add support for gettext plurals to Lua API https://github.com/wesnoth/wesnoth/commit/f866039e813b5398e1356403004b02ae77a0d9ea
20160829 20:47:36< irker082> wesnoth: Celtic Minstrel wesnoth:master 85734a306844 / src/ (3 files in 2 dirs): Fixup hotkey category functionality https://github.com/wesnoth/wesnoth/commit/85734a306844e0bfa1f997bbacd764886c0a3d9f
20160829 20:47:40< celticminstrel> I'll start working on layout fixes once the near-full rebuild completes.
20160829 20:52:52< vultraz> you managed to use a lambda for a callback function? :O
20160829 20:53:07< celticminstrel> What?
20160829 20:54:14< vultraz> though i guess it's not that surprising...
20160829 20:54:30< vultraz> it's the global callback setters that take the weird argument, I think..
20160829 20:56:06-!- louis94 [~~louis94@91.178.242.69] has joined #wesnoth-dev
20160829 20:58:32< vultraz> for the record
20160829 20:58:34< vultraz> wasn't https://gna.org/bugs/index.php?24930
20160829 20:58:38< vultraz> always the behavior?
20160829 21:01:25< vultraz> and in fact i understand why ithappens
20160829 21:01:29< vultraz> (generally)
20160829 21:10:34< celticminstrel> BTW, Elvish_Hunter should probably update wmlxgettext now, when he gets a chance.
20160829 21:11:26< celticminstrel> vultraz: Yeah, pretty sure it was always the behaviour.
20160829 21:11:48< vultraz> the question is whether it should still be the behavior
20160829 21:11:58< celticminstrel> Indeed.
20160829 21:12:34< celticminstrel> [Aug 29@4:29:17pm] celticminstrel: You know, it might be possible to block invalidate_layout altogether in some dialogs.
20160829 21:12:42< celticminstrel> [Aug 29@4:30:52pm] vultraz: there is an invalidate_layout_blocker
20160829 21:12:42< celticminstrel> Yes, that's why I said that. :P
20160829 21:12:58< celticminstrel> Plus I was thinking that, if performance is still an issue in the MP lobby, blocking layout invalidation might help.
20160829 21:13:08< celticminstrel> Unless it also prevents the list box from gaining new rows.
20160829 21:13:26< celticminstrel> Or other similar things.
20160829 21:13:34< celticminstrel> Like the player list or the room tabs.
20160829 21:13:35< vultraz> what do you mean 
20160829 21:13:42< vultraz> listbox gaining new rows
20160829 21:13:51< celticminstrel> Adding rows to the game listbox.
20160829 21:14:03< vultraz> ......
20160829 21:14:04< vultraz> what??????
20160829 21:14:11< vultraz> why would you not want that
20160829 21:14:17< celticminstrel> I'll start over.
20160829 21:14:55< celticminstrel> I thought that preventing layout invalidation completely in the MP lobby might be able to help with performance, but then noted that it would be bad if it prevented the listbox from gaining new rows.
20160829 21:15:10< vultraz> ah
20160829 21:15:11< vultraz> yes
20160829 21:15:31< celticminstrel> Still, even if it prevents them from gaining new rows, it might help - block layout invalidation while adding the rows, then invalidate it once.
20160829 21:15:43< celticminstrel> Actually, is there a plural add_rows type function?
20160829 21:15:58< celticminstrel> The generator has one, so adding one to the listbox if it doesn't already have one would be trivial.
20160829 21:16:20< vultraz> matrix placement still bad
20160829 21:16:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 21:16:58< celticminstrel> That might help too
20160829 21:17:06< celticminstrel> Yeah I know it's still bad
20160829 21:17:16< vultraz> we don't even know if there's a performance problem
20160829 21:17:18< vultraz> ;|
20160829 21:17:24< celticminstrel> True.
20160829 21:17:41< celticminstrel> I'm speaking hypothetically here because a thought happened to occur to me about it at some point.
20160829 21:19:36-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160829 21:21:20-!- Duthlet [~Duthlet@dslb-188-104-247-024.188.104.pools.vodafone-ip.de] has quit [Quit: leaving]
20160829 21:21:32< vultraz> im wondering if we should call invalidate_layout when we resize the screen
20160829 21:21:47< vultraz> would that select a new correct resolution?
20160829 21:22:08< celticminstrel> I'm guessing probably not.
20160829 21:22:38< irker082> wesnoth: Charles Dang wesnoth:master a92f1751d4e4 / src/gui/dialogs/lobby/lobby.cpp: MP Lobby: removed a unnecessary invalidate_layout call https://github.com/wesnoth/wesnoth/commit/a92f1751d4e4087ebea7e92663975262d7c8dcf5
20160829 21:22:46< celticminstrel> I think a general solution to that problem is quite hard. The reason I could easily get it to work at the titlescreen is that it's shown repeatedly in a loop.
20160829 21:23:11< vultraz> which is horrible
20160829 21:23:14< vultraz> just saying 
20160829 21:23:33< celticminstrel> I honestly don't think it's that bad.
20160829 21:23:50< celticminstrel> Though I'd still suggest it be changed a bit.
20160829 21:24:30< celticminstrel> Clicking a main menu button (except tutorial, editor, or quit) shouldn't close the dialog, but if you choose to start a game from there, then the dialog should close.
20160829 21:24:52< celticminstrel> I think that would allow the titlescreen to be redrawn behind eg languages or prefs.
20160829 21:25:27< celticminstrel> ...though it would prevent the correct resolution being shown if you change resolution via prefs, so maybe the dialog should automatically close after you exit prefs.
20160829 21:29:10-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 21:29:11< travis-ci> wesnoth/wesnoth#10601 (master - c4a7ca2 : Charles Dang): The build has errored.
20160829 21:29:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156043819
20160829 21:29:11-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 21:29:54< celticminstrel> vultraz: So, does your crash fix for kick/ban boot the player to the titlescrren with an error?
20160829 21:30:05< celticminstrel> Wait, no, I guess it wouldn't.
20160829 21:30:05< vultraz> what?
20160829 21:30:14< vultraz> why would it
20160829 21:30:18< celticminstrel> Because to get the crash in the first place you would've had to... never mind.
20160829 21:30:22< vultraz> it returns 'unknown command'
20160829 21:30:34< vultraz> little sense, do you make
20160829 21:30:49< celticminstrel> Booting to the titlescreen with an error is the behaviour of find_widget with fourth argument true if the widget does not exist.
20160829 21:31:02< celticminstrel> But just after saying it I realized that that does not apply here.
20160829 21:31:03-!- mjs-de [~mjs-de@x4db66424.dyn.telefonica.de] has joined #wesnoth-dev
20160829 21:31:32< vultraz> :P
20160829 21:31:50< vultraz> now shoo, go fix matrix placement
20160829 21:31:58< celticminstrel> Fiiiine. :P
20160829 21:33:12< celticminstrel> Gyra_Solune had an excellent question in the "exciting changes" thread.
20160829 21:33:57< vultraz> the khalifate question?
20160829 21:34:03< celticminstrel> Yeah.
20160829 21:34:19< celticminstrel> Is there a reason?
20160829 21:34:28< celticminstrel> I dunno, there could be balance reasons behind it.
20160829 21:34:38-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160829 21:36:20 * vultraz braces for bug reports
20160829 21:36:37< tad_> Nah
20160829 21:37:22 * tad_ is bored. "I want my mojo back, mojo back, mojo back." Why do I suddenly have a craving for ribs?
20160829 21:38:22-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160829 21:38:51< tad_> I'm trying to look busy because the wife is learning some 3D modelling and asking all sorta of questions about stuff on her screen which I can't see and really don't want to get into, anyway.
20160829 21:39:12< fabi_> :-)
20160829 21:40:53< vultraz> tad_: start playing esports
20160829 21:40:54< tad_> Hey, at least she gave up after 5 years of asking me to do it and ignoring all my comments that it's not that hard if she'd just TRY it!
20160829 21:42:13< vultraz> esports are the best way to be busy without really being busy
20160829 21:42:14< zookeeper> in theory, 3D modelling is easy. in practise...
20160829 21:42:19< tad_> fabi_: did you decide to pull down the HttT PRs? If so, how's it looking.
20160829 21:42:31-!- Appleman1234_ [~Appleman1@KD119104105128.au-net.ne.jp] has joined #wesnoth-dev
20160829 21:42:52< tad_> zookeeper: yeah .. in practice .. load Blender .. start Blender .. boggle .. "Honey, can you build this model for me?"
20160829 21:43:11-!- Appleman1234 [~Appleman1@KD036012013238.au-net.ne.jp] has quit [Disconnected by services]
20160829 21:43:17< zookeeper> and i wasn't even referring to blender :P
20160829 21:43:21-!- Appleman1234_ is now known as Appleman1234
20160829 21:43:27< fabi_> tad_: No, I delayed replaying HttT in favour of some Kerbal Space Program.
20160829 21:43:35-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160829 21:44:51< tad_> Her answer to Blender? "Maya is so much better! Can I have 900USD to check it out?"
20160829 21:45:49< vultraz> Your wife sounds... nice :P
20160829 21:46:05< tad_> s/nice/spoiled, but I love her/
20160829 21:46:16< vultraz> :)
20160829 21:46:38< vultraz> one would hope that were the case
20160829 21:47:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160829 21:47:53< tad_> At least, this week, it's stuff on the computer which is relatively free. The past month it's been all about more fabric (and another new sewing machine) making clothes for the new great-grand-daughter.
20160829 21:48:24< fabi_> tad_: How old are you?
20160829 21:48:33< zookeeper> it would be nice if there were actually professional-level free 3D software other than blender
20160829 21:49:10< tad_> zookeeper: Or if someone would whack the Blender folk upside the head and make them fix the UI
20160829 21:50:31< tad_> fabi_: I'm old enough but not that old. The reason for the 'great' is complex. Main reason is three generations of women having a kid at 18.
20160829 21:50:52 * vultraz thought tad_ was 25 or something
20160829 21:51:05< shadowm> I thought he was at least 50.
20160829 21:52:49-!- prkc [~prkc@179.43.169.226] has quit [Ping timeout: 252 seconds]
20160829 21:53:12< tad_> OK. Tad's first computer job was on an IBM 360/30 fixing Autocoder programs from the IBM 1401 which was retired the year before he started there. And he started on the Internet with it was called "Arpa-net" doing PDP-8/9/10/11 programming getting machines speaking NCP because IP would not be invented for a could more years
20160829 21:53:15< vultraz> shadowm estimates high
20160829 21:53:29< vultraz> o_O
20160829 21:53:31< shadowm> vultraz: Casual references like that above are why I estimate high.
20160829 21:53:43< shadowm> Perhaps I just pay more attention than you.
20160829 21:53:51 * tad_ checks his license. 
20160829 21:54:06< tad_> I'm 59, I think .. (counting on fingers)
20160829 21:54:21< shadowm> Even though, technically, I'm not even here most of the time.
20160829 21:54:29< zookeeper> i was estimating somewhat in that ballpark too
20160829 21:54:43< vultraz> O_O
20160829 21:54:52< vultraz> this project gets all ages
20160829 21:54:57 * vultraz is 18 :P
20160829 21:55:08< fabi_> 38
20160829 21:55:22< tad_> So is Tad. He's just been "hold" at 18 for a few decades ...
20160829 21:56:16-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160829 21:56:51< vultraz> zookeeper: is probably...
20160829 21:56:55 * vultraz ponders
20160829 21:57:05< vultraz> 37
20160829 21:57:16< shadowm> I can't count past 2 and my memory has the constitution of wet cardboard.
20160829 21:57:31< zookeeper> vultraz, close, but a few too high
20160829 21:57:43< vultraz> 33?
20160829 21:57:50< zookeeper> yes
20160829 21:58:03< vultraz> blah, i was gonna say that first :P
20160829 21:58:25< celmin> Heh, tad also doesn't pay much attention to age?
20160829 21:59:26< celmin> It always takes me a minute or two to remember mine.
20160829 22:00:32< vultraz> wat
20160829 22:00:49< tad_> Capabililty and drive are what I look at. Although, I have to admit, reading /r/programming I do find myself wondering what they teach in college these days because I see so many articles about stuff which was basic, done-is-done-why-bother basics back when I took it and, now, it's suddenly being "discovered" ?!?!?!
20160829 22:01:16< celmin> I don't know why vultraz looks so surprised.
20160829 22:01:22< shadowm> Wats look cool.
20160829 22:01:38< celmin> I disagree, but eh.
20160829 22:01:57< vultraz> Macklemore agrees
20160829 22:02:15< shadowm> I didn't mean the word.
20160829 22:03:07< vultraz> celmin: because it surprises me
20160829 22:03:12< vultraz> age is like your name :|
20160829 22:03:18< celmin> No it's not?
20160829 22:03:32< celmin> It's pretty much meaningless once you're out of your teens.
20160829 22:03:40< shadowm> https://en.wikipedia.org/wiki/Wat
20160829 22:03:45< vultraz> well im not
20160829 22:03:48< vultraz> so 
20160829 22:03:50< vultraz> :P
20160829 22:03:53< celmin> True.
20160829 22:04:12< vultraz> honestly i find it a little funny sometimes that im the youngest person here and in charge of ordering people around
20160829 22:06:21< tad_> It's all a question of capability and desire, and a bit of timing. Someone else will eventually take charge and who people follow will depend on who the respect enough to general take things in the right direction.
20160829 22:07:15< shadowm> Nah, this is actually more like an anarchy.
20160829 22:07:23< shadowm> vultraz found an empty seat and took it.
20160829 22:07:29< celmin> So what I need is some sort of two-dimensional ordered bin packing thing…?
20160829 22:08:11< vultraz> better than viciously assassinating the previous leader in a virtual coup :P 
20160829 22:08:32-!- prkc [~prkc@192.40.89.19] has joined #wesnoth-dev
20160829 22:08:35< shadowm> Historically speaking no-one minds anyone as long as they don't single-handedly introduce more bugs than they can fix per release.
20160829 22:08:36< tad_> That's sort of how I 'took over' a project years ago. The maintainer was mainly absent, so I started a fork rolling in all the patches he'd ignored and suddenly *I* was the maintainer and my fork was the reference implementation.
20160829 22:08:52< fabi_> vultraz: That happened? Tell me more.
20160829 22:09:07< vultraz> fabi_: but it didn't :P
20160829 22:09:17< vultraz> no drama here
20160829 22:09:19< vultraz> well
20160829 22:09:23< vultraz> no drama of that sort
20160829 22:09:28< vultraz> there's plenty other drama
20160829 22:09:40< fabi_> :-)
20160829 22:09:48< shadowm> That didn't sound like drama, that sounded like e-sports.
20160829 22:10:47< shadowm> If the project admin role was decided based on people's skill at Wesnoth I suspect the AI would win.
20160829 22:10:54< celmin> Haha
20160829 22:11:01< shadowm> (The Wesnoth AI, not the developer whose username is 'AI'.)
20160829 22:11:09< celmin> Yeah, I assumed that.
20160829 22:11:32< vultraz> i embrace our new ai overlords
20160829 22:11:47< tad_> Speaking of "drama" .. there's a Ideas thread the past few days about adding a [chapter] tag. I've made some comments there and think it's a good idea for adding to the roadmap. But I have some issues with memory footprints and load times which it might become real issues if it's added.
20160829 22:12:01< shadowm> Yes but you'll soon realize your overlord is fond of suiciding units into unfavorable terrain against imopssible odds.
20160829 22:12:25< vultraz> breakfast, I go, to!
20160829 22:12:31< tad_> shadowm: Yep .. sounds like how we commit changes to the master ..
20160829 22:12:34-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 22:12:35< travis-ci> wesnoth/wesnoth#10602 (master - e5cbc0c : Charles Dang): The build has errored.
20160829 22:12:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156045345
20160829 22:12:35-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 22:17:28< tad_> zookeeper: I wasted last night looking at TSG-elven and wondering how to fix it and decided this AM the smart move is to delete all the S05 stuff about victory paths and conversational issues, fix the merge conflicts, and push up the result to my TSG PR, then do the S05 stuff as a new PR.
20160829 22:17:50< celmin> I agree about [chapter]
20160829 22:17:59< zookeeper> tad_, sure, if you prefer
20160829 22:18:05< celmin> That it's a good idea, I mean.
20160829 22:19:54< tad_> zookeeper: Well, it segregates all those changes. My preference is an all-at-once-and-move-on massive PR but S05 is taking too big of a hit and I think, if I push up all the other fixes we can merge them. The S05 work will probably be equal in size to all the rest of the patches.
20160829 22:19:57< zookeeper> i have no particular opinion on [chapter] which is why i haven't said anything. although one might want to consider an alternative of just letting multiple [campaign]s declare their relationship somehow and then the campaign menu could just illustrate that somehow.
20160829 22:20:55< tad_> TBH, when I start thinking about [chapter] I head off into "What we really need is a JiT WML interpreter and a smart loader."
20160829 22:23:19< tad_> As to campaign-to-campaign relationships .. for mainline, we might be able to do something on the Campaign selector for those who prefer to play in time-order through the story-line.
20160829 22:23:40< celmin> That'd be kinda cool.
20160829 22:24:16< celmin> Maybe something like a year= key, and probably also setting= to avoid unrelated campaigns accidentally being jumpled in.
20160829 22:24:30< celmin> ^jumbled
20160829 22:25:50< celmin> Not sure if treeviews support sorting, but I think the plan was to change the campaign selector back to a listbox anyway.
20160829 22:26:07< zookeeper> i wouldn't mind if you could choose the sorting criteria and chronology was one
20160829 22:26:27< fabi_> difficulty
20160829 22:26:57< tad_> If it's just time-ordering, we might be able to add a [campaign] tag .. start_year= and end_year= .. 
20160829 22:27:23< celmin> Do you think both start and end are needed?
20160829 22:28:03< tad_> I'm thinking of a horizontally scrolling time-line with bars for each campaign (dots for the scenario??) ...
20160829 22:28:38< tad_> And we could add non-campaign annotations to it for major events like "Delfador is born" ...
20160829 22:29:23< tad_> Might be a web-side thing. Might be nice in the game. Dunno.
20160829 22:33:07< celmin> vultraz: Do you happen to know if h/v grow causes widgets to be assigned a size larger than their "best" size?
20160829 22:43:42-!- mjs-de [~mjs-de@x4db66424.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
20160829 22:46:10-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 22:46:11< travis-ci> wesnoth/wesnoth#10603 (master - e535476 : Charles Dang): The build has errored.
20160829 22:46:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156046452
20160829 22:46:11-!- travis-ci [~travis-ci@ec2-54-92-142-249.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 22:48:34< celmin> My cursory testing suggests yes.
20160829 23:05:05< vultraz> celmin: absolutely 
20160829 23:05:17< vultraz> that is, in fact, the whole purpose :)
20160829 23:05:26< celmin> But it won't let it get smaller?
20160829 23:05:27-!- atarocch [~atarocch@88.131.217.34] has quit [Quit: Leaving]
20160829 23:05:35< celmin> Maybe? I dunno.
20160829 23:05:47< vultraz> it's sized by the grid
20160829 23:12:11< celmin> STL algorithms are great.
20160829 23:12:34 * celmin is using std::max_element, std::min_element, and std::accumulate here. (Not sure that'll be the final algorithm, but still.)
20160829 23:14:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20160829 23:17:41< celmin> So, without grow, it presumably takes its best size and no more.
20160829 23:18:01< vultraz> yes
20160829 23:18:27< vultraz> remember, *_grow cannot be used with *_alignment
20160829 23:18:42< celmin> I'm using h_grow and v_alignment, apparently.
20160829 23:20:45-!- travis-ci [~travis-ci@ec2-54-81-19-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 23:20:46< travis-ci> wesnoth/wesnoth#10604 (master - 85734a3 : Celtic Minstrel): The build has errored.
20160829 23:20:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156050106
20160829 23:20:48-!- travis-ci [~travis-ci@ec2-54-81-19-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 23:23:44-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160829 23:26:04-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 258 seconds]
20160829 23:28:44-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has left #wesnoth-dev []
20160829 23:44:21< vultraz> hm
20160829 23:44:37< vultraz> i noticed the old lobby has more than just Quick Replays as an entry option
20160829 23:44:55< vultraz> there's Normal, Quick, and Enter Blindfolded
20160829 23:46:23-!- travis-ci [~travis-ci@ec2-54-81-19-76.compute-1.amazonaws.com] has joined #wesnoth-dev
20160829 23:46:24< travis-ci> wesnoth/wesnoth#10605 (master - a92f175 : Charles Dang): The build has errored.
20160829 23:46:24< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156058944
20160829 23:46:24-!- travis-ci [~travis-ci@ec2-54-81-19-76.compute-1.amazonaws.com] has left #wesnoth-dev []
20160829 23:46:54< vultraz> will need to add that to the new lobby
20160829 23:49:12-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160829 23:58:22-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
--- Log closed Tue Aug 30 00:00:06 2016