--- Log opened Tue Aug 30 00:00:06 2016
20160830 00:12:01-!- Haldrik [~haldrik@unaffiliated/haldrik] has quit [Quit: Leaving]
20160830 00:23:51-!- louis94 [~~louis94@91.178.242.69] has quit [Ping timeout: 264 seconds]
20160830 00:37:21-!- salluc69 [~salluc69@95.237.194.135] has quit [Ping timeout: 276 seconds]
20160830 00:38:54-!- salluc69 [~salluc69@host5-197-dynamic.24-79-r.retail.telecomitalia.it] has joined #wesnoth
20160830 02:13:15-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160830 02:27:55-!- ArneBab [~quassel@55d45684.access.ecotel.net] has joined #wesnoth
20160830 02:31:58-!- ArneBab_ [~quassel@55d445ce.access.ecotel.net] has quit [Ping timeout: 255 seconds]
20160830 04:51:51-!- DMG-LP [~damage@pool-108-29-130-218.nycmny.fios.verizon.net] has quit [Quit: Leaving]
20160830 05:15:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160830 05:44:30-!- Kwandulin [~Miranda@p200300760F4241BF5CB29195B8D86938.dip0.t-ipconnect.de] has joined #wesnoth
20160830 06:13:29-!- TC02 [~quassel@venus.arosser.com] has quit [Quit: No Ping reply in 180 seconds.]
20160830 06:14:45-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth
20160830 06:19:15-!- celticminstrel is now known as celmin|sleep
20160830 06:24:21-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth
20160830 06:59:38-!- tokage [~tokage@unaffiliated/tokage] has quit [Changing host]
20160830 06:59:38-!- tokage [~tokage@fsfe/tokage] has joined #wesnoth
20160830 07:15:50-!- tokage [~tokage@fsfe/tokage] has quit [Ping timeout: 265 seconds]
20160830 07:34:22-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Ping timeout: 255 seconds]
20160830 07:43:07-!- tokage [~tokage@fsfe/tokage] has joined #wesnoth
20160830 08:53:51-!- Kwandulin [~Miranda@p200300760F4241BF5CB29195B8D86938.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160830 09:07:14-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160830 09:07:20-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth
20160830 09:20:23-!- Haldrik [~haldrik@unaffiliated/haldrik] has joined #wesnoth
20160830 09:29:06-!- Kwandulin [~Miranda@p200300760F4241BFA5A7BF0065FBCA0C.dip0.t-ipconnect.de] has joined #wesnoth
20160830 09:50:17-!- Haldrik [~haldrik@unaffiliated/haldrik] has quit [Ping timeout: 244 seconds]
20160830 10:02:21-!- Haldrik [~haldrik@unaffiliated/haldrik] has joined #wesnoth
20160830 10:32:35-!- salluc69 [~salluc69@host5-197-dynamic.24-79-r.retail.telecomitalia.it] has quit [Quit: Sto andando via]
20160830 11:03:49-!- salluc69 [~salluc69@host5-197-dynamic.24-79-r.retail.telecomitalia.it] has joined #wesnoth
20160830 11:31:31-!- cyphase [~cyphase@unaffiliated/cyphase] has quit [Ping timeout: 255 seconds]
20160830 11:32:19-!- cyphase [~cyphase@unaffiliated/cyphase] has joined #wesnoth
20160830 12:55:05-!- Kwandulin [~Miranda@p200300760F4241BFA5A7BF0065FBCA0C.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160830 12:56:17-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth
20160830 12:56:17-!- aeonchild [enchilado@defocus/yummy/enchilado] has quit [Client Quit]
20160830 12:56:30-!- aeonchild [enchilado@defocus/yummy/enchilado] has joined #wesnoth
20160830 12:57:34-!- aeonchild is now known as enchi
20160830 13:00:34-!- irco [~irco@HSI-KBW-134-3-111-4.hsi14.kabel-badenwuerttemberg.de] has joined #wesnoth
20160830 13:11:07-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160830 13:20:31-!- louis94 [~~louis94@91.178.242.113] has joined #wesnoth
20160830 13:22:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth
20160830 13:25:00-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth
20160830 13:36:44-!- celmin|sleep is now known as celticminstrel
20160830 13:56:37-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth
20160830 14:01:41-!- louis94 [~~louis94@91.178.242.113] has quit [Quit: Konversation terminated!]
20160830 14:01:55-!- louis94 [~~louis94@91.178.242.113] has joined #wesnoth
20160830 14:16:40-!- DMG-WR0K [~damage@pool-108-29-130-218.nycmny.fios.verizon.net] has joined #wesnoth
20160830 14:17:47-!- louis94 [~~louis94@91.178.242.113] has quit [Ping timeout: 265 seconds]
20160830 14:19:02-!- Kranix [~magnus@x1-6-74-44-01-e4-f1-52.cpe.webspeed.dk] has joined #wesnoth
20160830 15:02:18-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160830 15:22:49-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth
20160830 15:22:53-!- Kwandulin [~Miranda@p200300760F4241BF28724764ECD65B78.dip0.t-ipconnect.de] has joined #wesnoth
20160830 15:25:18-!- louis94 [~~louis94@91.178.242.113] has joined #wesnoth
20160830 16:15:14-!- louis94 [~~louis94@91.178.242.113] has quit [Ping timeout: 265 seconds]
20160830 16:41:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth
20160830 16:57:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20160830 16:58:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth
20160830 17:06:33< DeFender1031> celticminstrel, i take back some of what i said yesterday. I just figured out how lua's multiple returns work and javascript has nothing like that. That said, the way it handles various cases of such is crazy and unintuitive and strikes me as bordering on eval-level evilness.
20160830 17:07:57< DeFender1031> celmin, ^^^ (guess you're currently on your other nick)
20160830 17:08:10< celmin> Both ping me either way.
20160830 17:08:16< DeFender1031> ah, good to know
20160830 17:08:38< DeFender1031> then i apologize for the double-ping
20160830 17:21:28-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160830 17:50:03-!- irco [~irco@HSI-KBW-134-3-111-4.hsi14.kabel-badenwuerttemberg.de] has quit [Ping timeout: 265 seconds]
20160830 17:54:50-!- DMG-LP [~damage@pool-108-29-130-218.nycmny.fios.verizon.net] has joined #wesnoth
20160830 18:05:08< DeFender1031> what's the format of unit.overlays? just a comma-separated list?
20160830 18:05:26< celmin> Uhh, actually not sure...
20160830 18:06:12< celmin> Probably not, since the source uses lua_push.
20160830 18:06:14< DeFender1031> celmin, if you want to link me to the code that parses it, i might be able to muddle through it myself
20160830 18:06:26< celmin> …you are talking about Lua, right>
20160830 18:06:28< celmin> ^?
20160830 18:07:06< DeFender1031> er... would it not contain the same string in lua as it would in wml and c++?
20160830 18:07:13< celmin> No. In Lua, unit.overlays is an array-like table of strings.
20160830 18:07:21< celmin> So in WML it's probably a comma-separated list.
20160830 18:07:26< DeFender1031> wait, what?
20160830 18:07:30< DeFender1031> no it's not
20160830 18:07:32< celmin> In C++ it's a vector of strings.
20160830 18:07:32< DeFender1031> it's a string
20160830 18:07:46< celmin> Really? Maybe that's something that changed in 1.13 then.
20160830 18:07:54< DeFender1031> oh, i guess this is a unit i loaded through wml
20160830 18:08:09< celmin> Oh, you mean a stored unit?
20160830 18:08:17< DeFender1031> (meaning, stored into a variable and then loaded that variable into lua, rather than loading the unit directly)
20160830 18:08:20< DeFender1031> yeah
20160830 18:08:20< celmin> Right.
20160830 18:08:45< celmin> That's just a config, not a unit, from the engine's standpoint.
20160830 18:08:54< DeFender1031> true.
20160830 18:08:56< celmin> So it would be the same as working in WML.
20160830 18:09:02< DeFender1031> i suppose so
20160830 18:12:27-!- tokage is now known as t-shirt
20160830 18:15:48-!- t-shirt is now known as tokage
20160830 18:32:07< DeFender1031> celmin, so? any idea how to work with it?
20160830 18:32:55< celmin> Presumably it's comma-separated, so split it?
20160830 18:33:52< celmin> Or you could work with a not-stored unit?
20160830 18:35:57-!- irco [~irco@HSI-KBW-134-3-111-4.hsi14.kabel-badenwuerttemberg.de] has joined #wesnoth
20160830 18:42:31< DeFender1031> celmin, can't for what i'm doing. As for split it, it's presumably more complicated than a simple split by comma, as IPFs would contain commas that should not be included in a split
20160830 18:42:48< celmin> Parenthetical split.
20160830 18:42:53< DeFender1031> right
20160830 18:43:18< celmin> I think there's a function for it in wml-tags.lua, which you can copy. (In 1.13 you could require lua/wml-utils.lua instead.)
20160830 18:43:20< DeFender1031> and i can write that if that's what it is, but unless i know, it's basically shooting in the dark
20160830 18:43:51< celmin> Well, it's probably parsed in the unit constructor in units/unit.cpp.
20160830 18:44:03< DeFender1031> hmm
20160830 18:44:09< DeFender1031> i already have that open actually
20160830 18:44:12< DeFender1031> let me see here
20160830 18:44:21< celmin> Most likely in the initializer list.
20160830 18:44:41< DeFender1031> overlays_ = utils::parenthetical_split(cfg["overlays"], ',');
20160830 18:44:46< DeFender1031> yep
20160830 18:45:22< DeFender1031> it's actually not in the initializer list, but in the constructor proper.
20160830 18:45:29< DeFender1031> but yeah, it's a paren split
20160830 18:45:37< DeFender1031> i can write that easily enough
20160830 18:45:43< celmin> Or copy it.
20160830 18:45:48< DeFender1031> or copy it
20160830 18:45:59< DeFender1031> but what's the fun in that? :P
20160830 18:46:04< celmin> 9_9
20160830 18:48:28< DeFender1031> now the question is how the overlays get rendered... is it a simple blit of 0,0 onto a 72x72 areay centered on the unit?
20160830 18:50:17< celmin> Possibly.
20160830 18:51:28-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has quit [Ping timeout: 264 seconds]
20160830 18:52:04-!- APic [apic@apic.name] has quit [Ping timeout: 264 seconds]
20160830 18:56:36< DeFender1031> another question, is there some way to reference an image in the root images directory rather than in core or some add on?
20160830 18:57:04-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 260 seconds]
20160830 18:57:09-!- mic_e_ [~quassel@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 276 seconds]
20160830 18:57:18< DeFender1031> (for example, if I wanted to include {wesnothroot}/images/misc/leader-crown.png for some reason)
20160830 18:57:20< celmin> I thought the root images dir was included in the search path.
20160830 18:57:29< DeFender1031> is it?
20160830 18:57:36-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth
20160830 18:57:37< celmin> In which case "misc/leader-crown.png" would work.
20160830 18:57:41< DeFender1031> didn't think to assume so, didn't think to try it
20160830 18:57:50< DeFender1031> right
20160830 18:57:53< DeFender1031> let me check
20160830 19:03:59-!- APic [apic@apic.name] has joined #wesnoth
20160830 19:04:23< DeFender1031> celmin, yeah, of course it works. I feel like an idiot for not knowing that.
20160830 19:56:30< DeFender1031> hey vultraz, you around?
20160830 19:56:36< vultraz> yes
20160830 19:56:37< DeFender1031> got a couple more gui questions
20160830 19:56:39< DeFender1031> great
20160830 19:58:32< DeFender1031> i'm having an issue where i'm doing set_dialog_value(value, "my_pages_id", 1, "widget_id_within_pages") and it's telling me that argument 4 is bad. Is there some function I'm supposed to call before this to say "add a page numbered 1", or is there something else that i'm just missing? I've triple-checked that the id actually does refer to a widget that appears within the page's definition.
20160830 19:59:38< vultraz> hmmmmm
20160830 20:00:17< DeFender1031> i can send you the actual code if you want, but it's long and i'm not sure you'd want to look through it all.
20160830 20:00:25< vultraz> no, that looks fine...
20160830 20:00:31< vultraz> not sure what the problem is
20160830 20:00:47< vultraz> what is the widget type?
20160830 20:01:01< DeFender1031> image
20160830 20:01:10< celmin> You can't set values for images...
20160830 20:01:17< DeFender1031> yes you can
20160830 20:01:24< DeFender1031> i've been doing it all along
20160830 20:01:37< DeFender1031> how else do you set what image is showing?
20160830 20:01:38< celmin> Huh?
20160830 20:01:49< celmin> Well, you could set it in the WML before constructing the dialog.
20160830 20:02:07< celmin> I thought you couldn't change it from Lua once the dialog was up though...
20160830 20:02:12< vultraz> it works for listboxes
20160830 20:02:15< DeFender1031> celmin, you're incorrect. you can set value for image just fine
20160830 20:02:17< vultraz> it should for multipages
20160830 20:02:36< DeFender1031> celmin, the issue is that it won't resize after being set initially
20160830 20:03:03< celmin> Ohh, I misread the code when I was adding UPP support.
20160830 20:03:22< celmin> It does indeed work with images and in fact any widget with a "label".
20160830 20:03:29< DeFender1031> vultraz, is there some rule that says that the references widget which is the last parameter must be a direct child of the pages widget? (It's currently within another level of grid stuff)
20160830 20:03:46< celmin> Speaking of GUI2, has anyone ever used [matrix]?
20160830 20:03:50< vultraz> no
20160830 20:03:53< vultraz> never
20160830 20:04:09< vultraz> DeFender1031: very good question
20160830 20:04:30< vultraz> it depends
20160830 20:04:40< vultraz> and i'm not sure..
20160830 20:04:48< vultraz> in this case it shouldn't
20160830 20:04:49< DeFender1031> vultraz, uh oh... why do i feel like there's another rabbit hole here?
20160830 20:05:01< DeFender1031> hmm...
20160830 20:05:16< DeFender1031> well, i could test without the extra layer and see what happens...
20160830 20:05:24< vultraz> try that
20160830 20:05:33< DeFender1031> (not that that would solve my problem necessarily, as grids are important.)
20160830 20:05:50< celmin> Why is vultraz the one answering that question.
20160830 20:06:01< vultraz> what?
20160830 20:06:15< celmin> DeFender1031: It shouldn't need to be a direct child.
20160830 20:06:22< vultraz> celmin: what do you mean
20160830 20:06:36< vultraz> why should I not be answering?
20160830 20:06:51< celmin> vultraz: Maybe I misinterpreted your "no, never". I assumed that was answering me.
20160830 20:07:07< vultraz> celmin: I was
20160830 20:07:13< celmin> DeFender1031: If it's an integer, it would need to be a direct child.
20160830 20:07:27< celmin> vultraz: :|
20160830 20:07:40< vultraz> is the matrix even supported in lua?
20160830 20:07:50< vultraz> has it even worked as a widget?
20160830 20:07:55< DeFender1031> vultraz, yeah, it's working after i removed the extra level of grid stuff... but that's strage, it shouldn't need to be.
20160830 20:08:04< celmin> vultraz: Everything is supported in Lua.
20160830 20:08:04< vultraz> DeFender1031: hmmmm
20160830 20:08:19< vultraz> not from my experience...
20160830 20:09:12< celmin> vultraz: What I mean is, as far as I can tell, you should be able to include any widget tag in the WML when building a Lua dialog, and it should work.
20160830 20:09:40< celmin> I'm not entirely sure if the rest of the Lua API would work with it.
20160830 20:09:54< vultraz> the latter, certainly not
20160830 20:10:05< celmin> But anyway, the reason I was asking is because I'm not sure if it works, so I thought maybe someone had tried using it and knew more than I.
20160830 20:10:20< celmin> Since the matrix is a container, I wouldn't be surprised if the Lua API works perfectly with it.
20160830 20:10:35< celmin> Anyway, I'm heading out for awhile, bye.
20160830 20:10:52< celmin> I'll see any responses people give though.
20160830 20:10:56-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160830 20:11:50< DeFender1031> vultraz, so, any idea why it would suddenly stop finding a widget in a nested grid?
20160830 20:12:01< vultraz> i do not
20160830 20:12:08< vultraz> have one
20160830 20:12:10< vultraz> sorry
20160830 20:12:14< vultraz> likely an internal issue
20160830 20:12:15< DeFender1031> grr
20160830 20:12:49< DeFender1031> GUI2 seems to have a lot of rough edges unfortunately
20160830 20:14:33-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160830 20:15:49< DeFender1031> vultraz, well, in this particular case, I don't explicitly NEED them to be in a nested grid, it was just easier to set up my code that way
20160830 20:15:59< DeFender1031> though, this might pose problems for me in the future.
20160830 20:16:23< DeFender1031> let me see if i can work around it by giving the subgrid an id and adding it to the path
20160830 20:17:55< DeFender1031> anyway, vultraz i have another two-part question for you, which is (1) how to create a "profile" button (like the one on the recall list) which will open up a specific help topic when click it and (2) if it's possible to make it that when the help popup is closed, it returns to the view from which it was opened, rather than returning to the game.
20160830 20:18:20< vultraz> not possible from lua, as far as I know
20160830 20:20:14< DeFender1031> both are not possible?
20160830 20:20:26< vultraz> yeah
20160830 20:20:30< DeFender1031> :(
20160830 20:20:42< vultraz> there's no wml action for opening help
20160830 20:21:01< vultraz> or lua function, for that matter
20160830 20:21:10< DeFender1031> i thought i saw something somewhere saying you could though
20160830 20:21:38< vultraz> oh?
20160830 20:21:40< vultraz> tell me more
20160830 20:23:48< DeFender1031> i wish i could... All I have is a vague memory of having read something either on the wiki or here in the channel that seemed to say you could open a help dialog
20160830 20:24:29< DeFender1031> (also, my brain read your lines "oh?" and "tell me more" with a picture of willy wonka behind it.)
20160830 20:27:49< vultraz> #DankMemes
20160830 20:31:57< DeFender1031> vultraz, https://wiki.wesnoth.org/InterfaceActionsWML#.5Bopen_help.5D
20160830 20:32:00< DeFender1031> found it
20160830 20:32:13< vultraz> ooohh?
20160830 20:32:21< vultraz> i did not realize this was a thing
20160830 20:32:32< vultraz> then yes, what you describe is possibly possible
20160830 20:32:35< DeFender1031> though i'm not sure what effect calling a wml action from a dialog would havve....
20160830 20:32:53< DeFender1031> i can imagine three possible outcomes of trying this
20160830 20:33:17< DeFender1031> 1: It opens the help "over" my dialog and then automatically returns to it when done
20160830 20:33:44< DeFender1031> 2: it opens help but then just goes back to game when closing
20160830 20:33:51< DeFender1031> 3: it explodes completely.
20160830 20:33:59< vultraz> 3 is not likely
20160830 20:34:07< DeFender1031> no?
20160830 20:34:12< vultraz> anyway, i assume you know how to set up callbacks?
20160830 20:34:24< DeFender1031> i could imagine the game not liking wml actions being called when a dialog is open
20160830 20:34:32< DeFender1031> i'm already using callbacks.
20160830 20:34:34< DeFender1031> why?
20160830 20:34:48< vultraz> well it should be simple to test this out :)
20160830 20:34:58< DeFender1031> i'm about to do so
20160830 20:35:05< vultraz> I think 2 is the most likely scenario
20160830 20:35:10< vultraz> without manual intervention
20160830 20:35:12< DeFender1031> also, YOU taught me callbacks when you taught me all the rest
20160830 20:35:40< vultraz> you have learned well
20160830 20:35:47< DeFender1031> actually, i can think of a fourth possibility: nothing at all happens until the dialog is closed, at which point the help opens.
20160830 20:35:54< DeFender1031> vultraz, why thank you.
20160830 20:37:00< DeFender1031> which reminds me, once i'm done with my add-on i'm going to want to put special thanks in the about section for everyone who's helped me out along the way.
20160830 20:37:02-!- louis94 [~~louis94@91.178.242.113] has joined #wesnoth
20160830 20:37:24< DeFender1031> i'll have to start asking people how they want to be mentioned.
20160830 20:39:18< DeFender1031> vultraz, will set_dialog_callback will replace any previous callback set on that same widget?
20160830 20:40:27< vultraz> hmmm
20160830 20:40:31< vultraz> not sure, but likely
20160830 20:40:55< DeFender1031> well, that can be tested too
20160830 20:41:09< vultraz> it's been awhile since i did gui2 lua
20160830 20:41:19< DeFender1031> it's actually not relevant to my current case though.
20160830 20:41:20< vultraz> ive been neck-deep in gui2 c++ :|
20160830 20:41:38< DeFender1031> vultraz, is that as unpleasant as it sounds?
20160830 20:41:57< vultraz> in some respects
20160830 20:42:08< vultraz> since you deal with the full engine
20160830 20:42:28< DeFender1031> remind me how to call a wml action from lua?
20160830 20:42:28< vultraz> which can either be a good or bad thing
20160830 20:42:42< vultraz> wesnoth.wml_action.action({})
20160830 20:42:56< DeFender1031> i thought that only works for those implemented in lua
20160830 20:43:02< vultraz> no
20160830 20:43:05< vultraz> any action
20160830 20:43:08< DeFender1031> okay then
20160830 20:44:20< DeFender1031> hmm... help topic id is what? the unit's type?
20160830 20:44:39< vultraz> something like...
20160830 20:44:51< vultraz> "unit.." followed by the type id
20160830 20:44:53< vultraz> not sure
20160830 20:45:10< DeFender1031> hmm
20160830 20:45:41< DeFender1031> well, without a valid topic, it opens a blank help page, which when closed, DOES return to the dialog i had opened previously!
20160830 20:45:53< vultraz> if not, try "unit_"
20160830 20:46:38< vultraz> ah, yes
20160830 20:46:45< vultraz> unit_ and the id
20160830 20:46:49< DeFender1031> so it seems that as long as i can determine what the help topic id actually looks like, i'm set, and will have pretty fully re-implemented the unit preview pane and the unit list in lua (with one minor image glitch for units whose sprites aren't square, which could be fixed easily in 1.13, but not in 1.12)
20160830 20:47:17< vultraz> in 1.13 there's a dedicated unit_preview_pane widget
20160830 20:48:10-!- louis94 [~~louis94@91.178.242.113] has quit [Quit: Konversation terminated!]
20160830 20:48:12< vultraz> in gui2
20160830 20:48:29-!- louis94 [~~louis94@91.178.242.113] has joined #wesnoth
20160830 20:49:27< DeFender1031> vultraz, i know, which is why it doesn't help me
20160830 20:49:36-!- louis94 [~~louis94@91.178.242.113] has quit [Read error: Connection reset by peer]
20160830 20:50:04< DeFender1031> vultraz, like i said to celmin the other day, if 1.14 ends up being out before i'm done here, then it was still a good excersize in working with GUI2.
20160830 20:50:23< vultraz> true
20160830 20:50:39-!- louis94 [~~louis94@91.178.242.113] has joined #wesnoth
20160830 20:51:21< DeFender1031> and i implemented it as similarly as possible both to the existing UPP in 1.12 and in terms of the prototypes for the functions to work with it. it was fun either way.
20160830 20:52:37< DeFender1031> hmm... i seem to be having an issue with one particular unit's help topic, where it's telling me for some reason that the unit is unknown and needs to be discovered in-game, even though this is not only a unit that exists, but actually the player's hero.
20160830 20:52:59< DeFender1031> might be a variation issue
20160830 20:53:14< DeFender1031> how do i link to a specific variation's help topic?
20160830 20:54:04< vultraz> hmmmm
20160830 20:54:15< vultraz> couldn't say off the top of my head
20160830 20:54:20< vultraz> there should be a way to..
20160830 20:54:28< vultraz> id have to delve into the source code
20160830 20:54:41< vultraz> and i don't really feel like doing that right now, pre-coffee
20160830 20:54:55< vultraz> (the help c++ is... disgusting :| )
20160830 20:54:55< DeFender1031> it'd help if i could actually see from the help page what the help topic ID was somehow...
20160830 20:55:08< DeFender1031> no rush
20160830 20:55:25< vultraz> (absolutely hideous, and some of the worse source code in the game)
20160830 20:57:20< DeFender1031> yeah, if there's one thing i've learned about this business, it's that no matter how polished something looks to the end user, the deeper into the code you get, the uglier it looks.
20160830 20:57:38 * vultraz nods
20160830 21:00:15 * vultraz is currently slogging through some very tedious code pushing to add some features to the new lobby
20160830 21:01:16< DeFender1031> my main long-term project at my day job is currently unifying and organizing all the random database code all over into one cohesive library so we can make DB changes without having to edit dozens of places in code.
20160830 21:01:47< vultraz> I see
20160830 21:01:56< vultraz> then I'm sure you have come across this scenario:
20160830 21:02:29< vultraz> you want to add something somewhere... only to find the data you need is a bunch of files away in a totally different class
20160830 21:02:30< vultraz> :|
20160830 21:05:12< vultraz> and then you need to proceed to figure out how to shuttle the data from a to b
20160830 21:09:04< DeFender1031> that's pretty common, yeah
20160830 21:11:54< DeFender1031> it's like "why the heck is the code for automatically logging a user into their account on a third-party service in the class for the event scheduling GUI?"
20160830 21:12:32< vultraz> Because Reasons :P
20160830 21:13:33< DeFender1031> indeed.
20160830 21:14:04< vultraz> right now im not dealing with anything that messy
20160830 21:14:20< vultraz> just shuttling a reference to a vector across two classes
20160830 21:15:23< DeFender1031> I think some people write code in an object-DISoriented manner :P
20160830 21:17:10< vultraz> there's a vector created as the result of a function. that vector is passed to a function. that function passes it to a constructor. that constructor saves the reference and passes it to another constructor when populating a member vector. finally, that last class uses the data :|
20160830 21:17:24< vultraz> Coding Fun :|
20160830 21:25:56< DeFender1031> that sounds like it could potentially encounter some ugly stack invalidation issues...
20160830 21:26:10-!- Kwandulin [~Miranda@p200300760F4241BF28724764ECD65B78.dip0.t-ipconnect.de] has quit [Quit: Kwandulin]
20160830 21:42:51-!- Appleman1234_ [~Appleman1@119.104.100.118] has joined #wesnoth
20160830 21:42:51-!- Appleman1234 [~Appleman1@KD119104105128.au-net.ne.jp] has quit [Disconnected by services]
20160830 21:42:52-!- Appleman1234_ is now known as Appleman1234
20160830 21:48:11-!- woseshaman [5f5bea67@gateway/web/freenode/ip.95.91.234.103] has joined #wesnoth
20160830 21:49:34< janebot> Tweet (by @Wesnoth) We now have a Facebook page! Check it out: https://www.facebook.com/Battle-for-Wesnoth-1671354243186470/ #gamedev [ https://twitter.com/Wesnoth/status/770740268823752704 ]
20160830 21:51:45-!- louis94 [~~louis94@91.178.242.113] has quit [Quit: Konversation terminated!]
20160830 21:54:06-!- wario [~wario_@unaffiliated/wario] has joined #wesnoth
20160830 22:01:23-!- DMG-LP [~damage@pool-108-29-130-218.nycmny.fios.verizon.net] has quit [Ping timeout: 244 seconds]
20160830 22:03:25< DeFender1031> vultraz, as for open_help, it seems as though nothing in core uses it, and only two add-ons use it, and neither of them appears to account for the variation issue that I'm encountering.
20160830 22:10:12< vultraz> try... ..unit_id
20160830 22:10:20< vultraz> "..unit_" + the id, that s
20160830 22:14:20< DeFender1031> not sure i understand what you mean
20160830 22:14:54< vultraz> try setting the topic as "..unit_" id where id is the variation id
20160830 22:15:40< DeFender1031> with a .. at the beginning?
20160830 22:15:46< DeFender1031> inside the string?
20160830 22:15:47< vultraz> yes
20160830 22:16:17< DeFender1031> how could that possibly work without the base type in there somewhere?
20160830 22:16:45< vultraz> true...
20160830 22:17:06< vultraz> i'm not sure there's even support for variation topics from outside the base unit page
20160830 22:17:14< vultraz> for accessing
20160830 22:17:39< DeFender1031> there must be... "show unit description" on a variation unit goes to the correct topic
20160830 22:18:18< DeFender1031> in addition, the issue is that trying to access the help of a unit type which HAS variations at all doesn't work, as if even having a variation changes the id format for even the base type
20160830 22:18:24< DeFender1031> which is odd
20160830 22:18:41< vultraz> hmmm
20160830 22:18:43< vultraz> this is odd
20160830 22:18:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160830 22:19:17-!- Kranix [~magnus@x1-6-74-44-01-e4-f1-52.cpe.webspeed.dk] has quit [Quit: Konversation terminated!]
20160830 22:19:57< DeFender1031> it seems as though any given help page ought to have some kind of deterministic internal id... the question is what that format is in various cases.
20160830 22:20:27< vultraz> no documentation is available
20160830 22:20:31< vultraz> one must delve into the c++ :|
20160830 22:21:02< vultraz> DeFender1031: ok try this
20160830 22:21:53< DeFender1031> well, if it's any sort of motivator, i'd be willing to add this to the documentation on [open_help] once we know what the format actually is.
20160830 22:22:04< vultraz> parent name  + "..unit_" + variation id
20160830 22:22:59< DeFender1031> tried it already, just reconfirmed. nope.
20160830 22:23:22< vultraz> blah
20160830 22:23:27< vultraz> but the c++ has this:
20160830 22:23:27< DeFender1031> (i assume by parent name, you mean "unit_{type id}")
20160830 22:23:31< vultraz> 	if (!variation_.empty()) {
20160830 22:23:32< vultraz> 		ss << _("Base unit: ") << make_link(parent->type_name(), ".." + unit_prefix + type_.id()) << "\n";
20160830 22:23:34< vultraz> :|
20160830 22:23:45< DeFender1031> hmm
20160830 22:23:49< DeFender1031> let me try something
20160830 22:23:50< vultraz> (unit_prefix is "unit_"
20160830 22:23:51< vultraz> )
20160830 22:23:58< DeFender1031> yes, that was obvious
20160830 22:24:08< vultraz> so it'd look something like
20160830 22:24:32< vultraz> Walking_Corpse..unit_dwarf" or something?
20160830 22:24:34< vultraz> idk
20160830 22:24:36< vultraz> :|
20160830 22:24:43< DeFender1031> tried that too
20160830 22:25:34< vultraz> blah!
20160830 22:25:46< DeFender1031> i tried "unit_{type id}..unit_{variation id}", I tried "{type id}..unit_{variation id}". I tried with the prefix only before, i tried with the prefix only after.
20160830 22:25:51< DeFender1031> wait a minute
20160830 22:26:00< DeFender1031> that's a comma in that line of C++, not a .
20160830 22:26:02< DeFender1031> er
20160830 22:26:04< DeFender1031> not a +
20160830 22:26:10< vultraz> oh, hm...
20160830 22:26:12< DeFender1031> what does make_link do?
20160830 22:26:55< vultraz> 		return "<ref>text='" + help::escape(text) + "' dst='" + help::escape(dst) + "'</ref>";
20160830 22:27:03< vultraz> so the type_name part is just the displayed name..
20160830 22:27:31< vultraz> it's still just... "..unit_{type id}" :|
20160830 22:27:41< DeFender1031> is ".." some kind of thing similar to directory .. that won't work from outside?
20160830 22:27:41 * vultraz throws up hands
20160830 22:27:50< vultraz> i have no idea
20160830 22:27:53< DeFender1031> blergh
20160830 22:28:02< vultraz> welcome to the help code
20160830 22:28:13< DeFender1031> want to send me a link to the cpp and i'll see if i can make head or tail out ofi t?
20160830 22:28:53< vultraz> have fun :) https://github.com/wesnoth/wesnoth/blob/master/src/help/help_topic_generators.cpp#L231
20160830 22:29:34< DeFender1031> thanks. i probably won't.
20160830 22:29:47< vultraz> if you come running back screaming I won't blame you
20160830 22:35:34< DeFender1031> "variation_" .. unit.type .. "_" .. unit.variation
20160830 22:36:44< DeFender1031> and that works for everything but the base type which seems to use neither the usual unit format nor the variation format
20160830 22:37:02< DeFender1031> so more code diving to find that.
20160830 22:37:11< DeFender1031> still, nice that i found most of it
20160830 22:37:11< vultraz> wow, you found something
20160830 22:37:16< DeFender1031> yep
20160830 22:37:20< DeFender1031> impressed?
20160830 22:37:33< vultraz> yes :P
20160830 22:37:45< DeFender1031> there's a reason i keep saying i'll probably end up a dev someday
20160830 22:39:29-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Read error: Connection reset by peer]
20160830 22:39:34-!- celmin [~celmin@unaffiliated/celticminstrel] has joined #wesnoth
20160830 22:39:56-!- celticmistral [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth
20160830 22:40:21< DeFender1031> GOT IT!
20160830 22:40:32< celticmistral> ?????
20160830 22:40:38< DeFender1031> base id IF there are variations is "..unit_" .. unit.type
20160830 22:40:44< celticmistral> Wait why am I windy.
20160830 22:40:49< DeFender1031> if there aren't, it's without the dots.
20160830 22:40:54< DeFender1031> and the variation syntax is different
20160830 22:40:59< celticmistral> What. Why is there a celmin.
20160830 22:41:02< DeFender1031> whoever came up with this crap should be shot.
20160830 22:41:11< celticmistral> Oh! The desktop disconnected and didn't nick-fix.
20160830 22:41:35 * vultraz agrees with DeFender1031
20160830 22:41:51-!- celmin is now known as celticminstrel
20160830 22:42:05< DeFender1031> anyway, now that i've dug some of this up, i can document it on the wiki at least... in case anyone wants it.
20160830 22:42:21< celticmistral> Ugh, a Facebook page, huh.
20160830 22:42:36< DeFender1031> though, this should probably be A: documented with a note saying it's subject to change and B: CHANGED!
20160830 22:42:44< vultraz> yup
20160830 22:42:48< DeFender1031> celticmistral, what about facebook?
20160830 22:42:54< celticmistral> Nothing really.
20160830 22:42:58< vultraz> DeFender1031: problem is, gui2 can't really handle a new help browser
20160830 22:43:02< vultraz> but if someone were to come in..
20160830 22:43:08< vultraz> and make the necessary API changes..
20160830 22:43:09< celticmistral> Reading up on what I missed.
20160830 22:43:25< vultraz> :)
20160830 22:43:33< vultraz> i do have an idea, though
20160830 22:43:44< DeFender1031> vultraz, the ui could stay as it is, i'd just redo this id format into something sane and straightforward.
20160830 22:43:51< celticmistral> Speaking of API changes, it'd be nice if grids supported colspan / rowspan.
20160830 22:43:58< celticmistral> Redo what now?
20160830 22:44:00< vultraz> maybe ill get celticminstrel to implement it. I think we need something that's a mix of a multipage and a stacked widget...
20160830 22:44:23< celticmistral> There is a Lua function (at least in 1.13) to open a help topic.
20160830 22:44:26< vultraz> something where we can have different definitions for "page" layout
20160830 22:44:36< vultraz> but generate multiple copies of them
20160830 22:44:41< celticmistral> Or did you find it already?
20160830 22:45:02< DeFender1031> vultraz, for example: "{section}_{type id}_{variation id}" might be nice, with both "{section}_{type id}" and "{section}_{type id}_" pointing to the base type.
20160830 22:45:13< celticmistral> What the heck are we talking about here?
20160830 22:45:15< vultraz> perhaps
20160830 22:45:20< celticmistral> Something to do with help obviously.
20160830 22:45:25< vultraz> celticminstrel: the id formatting for help pages
20160830 22:45:37< celticmistral> It's amusing that you're autocorrecting the other nicl
20160830 22:45:39< celticmistral> ^nock
20160830 22:45:41< celticmistral> ^nick
20160830 22:45:43< celticmistral> ID formatting?
20160830 22:45:45< vultraz> which is just one aspect of the help system which deserves to burn with fire
20160830 22:45:50< DeFender1031> vultraz, but "unit_{type id}" for units without variations and "..unit_{type id}" for the base unit with them makes no sense.
20160830 22:46:45< celticmistral> So, does set_dialog_callback replace any previous callback?
20160830 22:46:59< DeFender1031> celticmistral, didn't test that yet
20160830 22:47:08< celticmistral> I suspect GUI2 in C++ isn't quite as bad as it is in Lua.
20160830 22:47:09< DeFender1031> going to bed soon, will test tomorrow.
20160830 22:47:47< celticmistral> By the way, if you're calling a WML action from Lua, the other way to do it is wesnoth.fire("action_name", config)
20160830 22:48:09< celticmistral> Which automatically substitutes variables.
20160830 22:48:20< celticmistral> If you call it directly, you don't get variable substitution, I think.
20160830 22:48:26< DeFender1031> celticmistral, yeah, that's what i had been thinking of, but i was under the misapprehension that that was NECESSARY in soem cases
20160830 22:48:28< celticmistral> (But you might not need it anyway.)
20160830 22:48:44< DeFender1031> (why do both the proxy table and .fire() exist?)
20160830 22:48:59< DeFender1031> oh, you answred that
20160830 22:49:01< celticmistral> .fire() was the older method.
20160830 22:49:08< vultraz> we should get rid of fire
20160830 22:49:12< celticmistral> But it's kept around because it's still slightly different semantically.
20160830 22:49:28< DeFender1031> vultraz, kille fire() with fire? :P
20160830 22:49:33< vultraz> yes :D
20160830 22:49:36< DeFender1031> *-e
20160830 22:49:40< celticmistral> vultraz: You presumably haven't read the comment in backwards-compatibility.lua.
20160830 22:49:50< vultraz> i did at some point
20160830 22:50:04< DeFender1031> vultraz, here, have a fire dragon.
20160830 22:50:11< celticmistral> Thus, removing it is probably not a good idea.
20160830 22:50:41< celticmistral> I really want (someone) to try out the [matrix] widget.
20160830 22:50:55< celticmistral> But I'm not sure what I'd use it for in core Wesnoth.
20160830 22:50:59< vultraz> aren't you doing it? :|
20160830 22:51:07< celticmistral> Given that most dialogs already have their layout more or less finalized.
20160830 22:51:22< celticmistral> Although there are several for which it theroretically seems applicable.
20160830 22:52:07< celticmistral> What's that about "automatically logging a user into their account on a third-party service in the class for the event scheduling GUI"?
20160830 22:52:21< celticmistral> Is that a reference to something non-Wesnoth?
20160830 22:52:22< vultraz> ?????????????
20160830 22:52:28< DeFender1031> what IS [matrix]?
20160830 22:52:31< vultraz> ah
20160830 22:52:32< celticmistral> Something DeFender1031 said earlier.
20160830 22:52:38< vultraz> DeFender1031: some widget
20160830 22:52:45< celticmistral> DeFender1031: From what I can tell, it's supposed to be like Swing's BorderLayout.
20160830 22:53:08< DeFender1031> celticmistral, yeah, that was a tangent talking about my day job.
20160830 22:53:12< celticmistral> Ah, okay.
20160830 22:53:55< DeFender1031> celticmistral, I don't know what Swing or a BorderLayout are either
20160830 22:54:14< celticmistral> There's a main central pane and up to four optional panes attached to each edge.
20160830 22:54:22< celticmistral> Swing is Java's main GUI system.
20160830 22:54:49< celticmistral> I guess in GUI2 parlance it's "grid" rather than "pane", as [pane] is something else altogether.
20160830 22:55:01-!- can-ned_food [~me@dynamic-acs-24-154-138-63.zoominternet.net] has joined #wesnoth
20160830 22:55:09< celticmistral> (I'm not actually sure what [pane] is, but the titlescreen uses it for the darkened areas.)
20160830 22:55:29< vultraz> pane is basically a grid
20160830 22:56:04< DeFender1031> hmm
20160830 22:56:27< celticmistral> Surely there's a difference between a pane and a grid though.
20160830 22:56:35< DeFender1031> am I the only one who's starting to think that a dumbed down version of html might just be simpler here? :P
20160830 22:56:57< celticmistral> I think that would be just about as complex.
20160830 22:57:08< DeFender1031> good point.
20160830 22:57:12< celticmistral> Though it might at least shift the complexity into an external library, I guess.
20160830 22:57:42< DeFender1031> or we could use Qt
20160830 22:57:44< can-ned_food> i saw “eternal library” for a second
20160830 22:57:45< DeFender1031> :P
20160830 22:58:47< celticmistral> No Qt :|
20160830 22:58:54< celticmistral> can-ned_food: Heh
20160830 22:58:56< DeFender1031> what would actually be really nice (aside from GUI2 working properly) would be some kind of interactive program where you could drag and drop widgets and it would spit out the code you'd need for that in either wml or lua
20160830 22:59:13< DeFender1031> celticmistral, y u no lik Qt?
20160830 22:59:25-!- irco [~irco@HSI-KBW-134-3-111-4.hsi14.kabel-badenwuerttemberg.de] has quit [Ping timeout: 258 seconds]
20160830 22:59:37< celticmistral> Reasons.
20160830 22:59:57< can-ned_food> a tidbit:  celticminstral, i don't know if there's a conventional standard for the WIMP nomenclature ‘pane’, but i've always thought that it should be used when the widget is analogous to a window pane.
20160830 23:00:17< celticmistral> Like apparently it requires an extra precompile flag, or it reimplements standard library things such as strings.
20160830 23:00:22< celticmistral> WIMP?
20160830 23:00:50< can-ned_food> window i-something menu pointer ... 
20160830 23:01:00< can-ned_food> icon
20160830 23:01:38< can-ned_food> sorry if that was unhelpful
20160830 23:01:49< DeFender1031> celticmistral, "reimplements standard library things such as strings" so does wesnoth, and for the same reason
20160830 23:02:23< celticmistral> What does Wesnoth reimplement?
20160830 23:02:27< DeFender1031> (then again, "use html" and "use Qt" were not serious suggestions)
20160830 23:02:27< celticmistral> Certainly not strings.
20160830 23:02:33< celticmistral> Fair enough.
20160830 23:02:45< DeFender1031> celticmistral, wesnoth doesn't have "translatable strings"?
20160830 23:03:02< celticmistral> Ah, that's true, it does have t_string.
20160830 23:03:14< celticmistral> That's not reimplementing string though, it's more like a wrapper.
20160830 23:03:16< DeFender1031> so like i said, same exact reason
20160830 23:03:22< celticmistral> (Uses string internally.)
20160830 23:03:39< DeFender1031> pretty sure qstrings do as well
20160830 23:04:54-!- wario [~wario_@unaffiliated/wario] has quit [Quit: Leaving]
20160830 23:08:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 255 seconds]
20160830 23:08:24-!- DMG-WR0K [~damage@pool-108-29-130-218.nycmny.fios.verizon.net] has quit [Quit: gone.]
20160830 23:10:14-!- ncms [and@2a02:a312:c101:f800:a19d:e280:1e2d:2d30] has joined #wesnoth
20160830 23:10:40-!- DMG-LP [~damage@pool-108-29-130-218.nycmny.fios.verizon.net] has joined #wesnoth
20160830 23:19:07-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160830 23:19:13-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth
20160830 23:46:51-!- can-ned_food [~me@dynamic-acs-24-154-138-63.zoominternet.net] has quit [Quit: Konversation terminated!]
20160830 23:56:47-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth
20160830 23:57:45-!- mic_e [~quassel@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth
--- Log closed Wed Aug 31 00:00:54 2016