--- Log opened Fri Sep 02 00:00:33 2016
20160902 00:07:01-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160902 00:08:32-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 00:08:33< travis-ci> wesnoth/wesnoth#10665 (master - 60d543c : Celtic Minstrel): The build is still failing.
20160902 00:08:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156952070
20160902 00:08:33-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 00:15:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 00:16:15< vultraz> celmin: what's that 'non-existent config' called?
20160902 00:17:25< celmin> Don't quite remember, why?
20160902 00:18:02-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160902 00:18:03< vultraz> i think calling !.empty() is not the right way to check if a child exists 
20160902 00:18:20< celmin> vultraz: About the inability to close the dialog from pre_show, I recommend writing a static show() function that determines whether to actually show the dialog. Several other dialogs do that already.
20160902 00:19:18< vultraz> ah, I needed child_or_empty
20160902 00:19:20< vultraz> nvm
20160902 00:19:33< celmin> Which returns const, right?
20160902 00:20:04< celmin> BTW, the right way to check if a child exists, wouldn't that be .has_child("tag")?
20160902 00:20:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160902 00:20:42< vultraz> oh yeah
20160902 00:21:13 * celmin is curious why you were googling std::set, too.
20160902 00:21:24 * celmin is curious about a lot of things, BTW. :P
20160902 00:21:28< vultraz> celmin: this is what I ended up with http://pastebin.com/yPMamUL3
20160902 00:21:46< vultraz> (turns out I didn't need to know anything about set)
20160902 00:21:48< celmin> And what did you end down with? :O
20160902 00:22:53< celmin> So, let me parse this.
20160902 00:22:55< vultraz> I should probably add an option to create_engine that returns a vector of the active mods instead of just strings
20160902 00:23:02< vultraz> would simplify things..
20160902 00:23:31< celmin> const bool mods_have_options = find the first mod that has no [options] child and see if it exists.
20160902 00:23:59< celmin> I'm curious why you're using find_if_not() != end() rather than find_if() == end().
20160902 00:24:11< vultraz> eh...
20160902 00:24:12< vultraz> good point
20160902 00:24:28< celmin> I don't think either could be said to be more efficient in a general sense thoug.
20160902 00:24:31< celmin> ^though
20160902 00:24:49< vultraz> [11:22:54]	vultraz	I should probably add an option to create_engine that returns a vector of the active mods instead of just strings
20160902 00:24:58< vultraz> would also simplify theoptions manager
20160902 00:25:01< celmin> I might be imagining it, but I sort feel like your condition might be inverted...
20160902 00:25:03< vultraz> I shall do this
20160902 00:26:04< vultraz> also, I cannot use a show() static method
20160902 00:26:06< celmin> ^sorta
20160902 00:26:08< celmin> Why not?
20160902 00:26:15< vultraz> since the options_manager cannot be filled until pre_show
20160902 00:26:26< celmin> That's totally irrelevant?
20160902 00:26:51< vultraz> eh true
20160902 00:26:59< vultraz> if I use this code there..
20160902 00:27:04< vultraz> true, true..
20160902 00:27:27 * vultraz ponders
20160902 00:27:32< celmin> I can't seem to wrap my head around that conditional.
20160902 00:27:41< vultraz> it works, though
20160902 00:27:44< vultraz> just ftr
20160902 00:27:52< celmin> Okay.
20160902 00:27:59< celmin> So if it was find_if(…) == end()...
20160902 00:28:02< celmin> Then...
20160902 00:28:09< celmin> Wait...
20160902 00:28:15< celmin> That's a different semantic?
20160902 00:28:19< vultraz> I'd also have to say !has_child
20160902 00:28:20< vultraz> I think
20160902 00:28:23< celmin> Oh right, why not use std::any_of?
20160902 00:28:42< celmin> Then you don't even need to compare to end().
20160902 00:28:49< celmin> And it'll be clearer, I think.
20160902 00:29:28< vultraz> any_of?
20160902 00:29:33< celmin> Yeah.
20160902 00:29:33< vultraz> what is this any_of you speak of
20160902 00:29:43< celmin> Returns true if any element of the collection satisfies the predicate.
20160902 00:29:46< celmin> There's also all_of.
20160902 00:30:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160902 00:30:03< vultraz> ahh
20160902 00:30:06< vultraz> this is useful
20160902 00:30:08< celmin> Which returns true if all elements satisfy the predicate.
20160902 00:30:13< vultraz> why have I not known about this before
20160902 00:30:17< celmin> I dunno.
20160902 00:30:25< vultraz> praise stl functions 
20160902 00:30:30< celmin> Yup ypu.
20160902 00:30:32< celmin> &ypu
20160902 00:30:33< celmin> ^ypu
20160902 00:30:35< celmin> ^yup
20160902 00:30:37< vultraz> LOL
20160902 00:30:38< celmin> Bah typos
20160902 00:31:57< celmin> I've been wondering this for awhile, but what does get_parameters() really do? From the name you'd expect it to return a value.
20160902 00:32:25< vultraz> i'd have to look
20160902 00:35:30< celmin> Not a priority or anything.
20160902 00:38:57< vultraz> hm..
20160902 00:39:38< vultraz> celmin: isn't there a function that can get an iterator range of part of a vector based on a conditional?
20160902 00:39:53< celmin> mattsc: If you have a moment, does Wesnoth still build for you?
20160902 00:40:16< celmin> vultraz: Maybe, what exactly do you need?
20160902 00:40:30< celmin> mattsc: Or more specifically, wesnothd.
20160902 00:41:40< vultraz> celmin: so I was doing this http://pastebin.com/39rFFCUH
20160902 00:42:12< vultraz> celmin: but then I realized.. get_const_extras_by_type also returns a std::vector<extras_metadata_ptr>
20160902 00:42:21< celmin> There's nothing in std that will filter an unsorted list.
20160902 00:43:00< celmin> And in general it wouldn't be possible to get an iterator range covering a set of noncontiguous elements.
20160902 00:43:07< celmin> Though I think Boost has a way to do it.
20160902 00:43:24< vultraz> er
20160902 00:44:25< vultraz> celmin: what about std::copy_if?
20160902 00:44:39< vultraz> that seems to be what I'm looking for
20160902 00:44:40< celmin> Sure. That does exactly what you posted there, but more concisely.
20160902 00:44:51< celmin> (Don't forget to use a back_inserter for the output iterator.)
20160902 00:45:34< vultraz> hm?
20160902 00:45:52< vultraz> ah
20160902 00:46:13< celmin> Because copy_if assumes that the target already has space reserved for what you're copying.
20160902 00:46:26< celmin> (Well, all the copy functions assume that.)
20160902 00:46:43-!- gfgtdf [~chatzilla@x4e369e2d.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160902 00:48:43< vultraz> oh, blah, forgot is_modification_active take an index :| that's annoying
20160902 00:51:42< vultraz> should be easy enough to add an id version...
20160902 00:51:43< vultraz> hmm
20160902 00:51:57< vultraz> ok, so it takes an index since it returns the nth child of a config
20160902 00:52:50< vultraz> ah
20160902 00:52:54< vultraz> I'll just use a find_if
20160902 00:53:48< vultraz> wait, no
20160902 00:53:48< celmin> find if what?
20160902 00:53:50< vultraz> not even that
20160902 00:53:58< vultraz> I'm passing the id directly :|
20160902 00:54:05< vultraz> i don't need to get it :D
20160902 00:54:15< celmin> Confused.
20160902 00:54:52< vultraz> is_modification_active was using an index to get the value of the nth child of a config's id= key
20160902 00:54:59< vultraz> but if I pass the id, I don't need to do that :D
20160902 00:55:40< celmin> I guess you mean the id key of the nth child.
20160902 00:55:52< vultraz> yes
20160902 00:58:17-!- RatArmy [~RatArmy@240f:b3:88e3:1:221:85ff:fec0:94bc] has joined #wesnoth-dev
20160902 01:01:29 * celmin tests to see if XCode can handle clang 3.8.
20160902 01:01:31< celmin> ^XCode 4
20160902 01:04:02< celmin> Hmm, it broke errors.
20160902 01:04:09< celmin> Or did it?
20160902 01:04:21< celmin> Okay, it didn't break errors.
20160902 01:04:48< celmin> But I'm getting bizarre link errors.
20160902 01:06:09< celmin> Oh, wait, I guess the one link error was a direct result of the compilation error, duh/
20160902 01:06:53< celmin> Still, it seems to want libarclite, which I don't want.
20160902 01:07:22< celmin> I think.
20160902 01:11:21< celmin> Or I could just symbolic-link it at the MacPorts location pointing into XCode's location.
20160902 01:11:49< celmin> Actually, better would probably be to somehow tell it to search XCode's locations in the first place...
20160902 01:11:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 01:12:00< vultraz> if(!(std::find_if_not(activemods.begin(), activemods.end(), [](mod_type& mod) { return (*mod->cfg).has_child("options"); }) != activemods.end()))
20160902 01:12:03< vultraz> must
20160902 01:12:05< vultraz> simplify
20160902 01:12:21< celmin> I thought you were going to use any_of or something?
20160902 01:12:38< vultraz> oh yeah
20160902 01:14:27< vultraz> if(std::any_of(activemods.begin(), activemods.end(), [](mod_type& mod) { return !(*mod->cfg).has_child("options"); }))
20160902 01:14:33< vultraz> much better :D
20160902 01:14:48-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 01:14:49< travis-ci> wesnoth/wesnoth#10666 (master - 0cf8a2e : Charles Dang): The build has errored.
20160902 01:14:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156952481
20160902 01:14:49-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 01:15:59< celmin> I kinda dislike using any_of and similar in an if statement.
20160902 01:16:19< celmin> (Any function that takes a lambda.)
20160902 01:16:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20160902 01:17:54-!- Bonobo [~Bonobo@2001:44b8:254:3200:2d28:7666:f53f:db78] has joined #wesnoth-dev
20160902 01:18:55< vultraz> http://pastebin.com/mfhABq9B
20160902 01:19:00< vultraz> new execute function
20160902 01:19:27< celmin> So… I probably need to somehow concoct a mini-shell-script that sets environment vars and forwards all arguments to clang-mp-3.8
20160902 01:19:52< celmin> Looks good, barring my dislike of nesting lambdas in if()
20160902 01:20:52< tad_> celmin: when you get a chance, you can merge #763
20160902 01:21:01< vultraz> for some reason I cannot keep activemods as a reference :/
20160902 01:21:03< vultraz> not sure why
20160902 01:22:42< celmin> Const reference?
20160902 01:22:59< celmin> It's likely returned by value, so a non-const reference wouldn't work.
20160902 01:23:28< vultraz> hm... that does work if the lambda argument is by-value
20160902 01:23:37< vultraz> which.. I guess it should be since it's a shared_ptr
20160902 01:23:57< celmin> Well, it wouldn't hurt for it to be by value if it's a pointer, yeah.
20160902 01:24:09< celmin> You'd only need it to be by reference if you wanted to reset it.
20160902 01:25:12< mattsc> celmin: no, wesnothd fails with 38 errors.
20160902 01:25:21< celmin> I see.
20160902 01:25:22< mattsc> This is the first one: Undefined symbols for architecture x86_64:
20160902 01:25:23< mattsc>   "___asan_after_dynamic_init"
20160902 01:25:29< celmin> Hmm.
20160902 01:26:24< vultraz> er, hm
20160902 01:26:30< celmin> Is it just wesnothd that does that, or does wesnoth also?
20160902 01:26:33< vultraz> i should probably use all_of
20160902 01:26:43< vultraz> not any_of
20160902 01:26:43< celmin> Why?
20160902 01:26:57< vultraz> since we only want to skip the dialog if all mods are option-less
20160902 01:27:02< vultraz> not if only 1 is option-less
20160902 01:27:06< mattsc> Xcode stops compiling there, as wesnothd is a prerequisite for compiling Wesnoth.  So I don’t know.
20160902 01:27:07< celmin> I thought you wanted "if any mod has an option child".
20160902 01:27:21< celmin> mattsc: Huh, for me it continues anyway.
20160902 01:27:29< vultraz> no, skip if all *don't* have an options child
20160902 01:27:31< celmin> You could temporarily remove the dependency, I guess.
20160902 01:27:39< celmin> vultraz: No, not that.
20160902 01:27:48< celmin> vultraz: Show the options if any mod has an options child.
20160902 01:27:49< vultraz> what?
20160902 01:28:09< celmin> vultraz: Which is certainly the same as what you said though - skipping if all lack an options child.
20160902 01:28:15< vultraz> this is a conditional for skipping 
20160902 01:28:17< vultraz> not showing
20160902 01:28:20< celmin> Why?
20160902 01:28:41< mattsc> celmin: Btw, this is a linker error, not a compiler error (probably obvious to you, but just in case)
20160902 01:28:43< vultraz> because it's cleaner?
20160902 01:28:51< celmin> mattsc: Yeah, it was obvious.
20160902 01:28:58< celmin> vultraz: I don't see it.
20160902 01:29:16< mattsc> celmin: I could do that later, but right now I need to be off again, sorry.  Not sure yet if I’ll be back here tonight.
20160902 01:29:45< vultraz> it's cleaner to do if(cond) return false; return dialog_execution; instead of if(cond) return false; if(true_cond) return dialog_execution; return false;
20160902 01:30:21< celmin> Huh?
20160902 01:30:34< celmin> Your "instead of" doesn't make sense somehow.
20160902 01:30:49< vultraz> I still need to return if there are no active mods
20160902 01:30:51< vultraz> so I do
20160902 01:31:05< vultraz> if no active mods OR all active mods have no options, return false;
20160902 01:31:09< vultraz> instead of
20160902 01:31:33< vultraz> if no active mods return false. if any active mods have options, return result of dialog. default return false false.
20160902 01:31:35< vultraz> see?
20160902 01:31:44< vultraz> s/false false/return false;
20160902 01:31:56< celmin> It's the difference between "if(any_of(…)) {return show_dialog();} else {return false;}" and "if(all_of(…)) {return false;} else {return show_dialog();}", isn't it?
20160902 01:32:01< celmin> No difference in cleanness.
20160902 01:32:39< vultraz> I don't use else blocks when the if() has a return statement
20160902 01:32:57< vultraz> such coding is ugly, and you need to then provide a default return value anyway
20160902 01:34:03< celmin> No you don't.
20160902 01:34:14< celmin> But that's still totally beside the point.
20160902 01:34:18< vultraz> if(foo) return a else return b; return c; is horrible. just do if(foo) return a; return b;
20160902 01:34:21< celmin> Whether the else is implicit or explicit, I mean.
20160902 01:34:26< celmin> It's not horrible.
20160902 01:34:44< celmin> Wait, hold on, it's not horrible, it's just silly.
20160902 01:34:52< celmin> Why return a value from an unreachable code-path?
20160902 01:34:57< vultraz> what are we arguing about again? 
20160902 01:35:30< celmin> You're arguing that if() {return a;} else {return b;} is horrible for some seemingly incomprehensible reason.
20160902 01:35:44< vultraz> i don't like how it looks :P
20160902 01:36:05< celmin> While I was trying to point out that if(a) {return b;} else {return c;} is no cleaner than if(!a) {return c;} else {return b;}
20160902 01:36:20< vultraz> obviously
20160902 01:36:25< vultraz> except I'm not using else :)
20160902 01:36:32< celmin> But you were claiming otherwise with the any_of / all_of thing.
20160902 01:36:43< celmin> Well, whether or not you include the else doesn't change the basic argument there.
20160902 01:36:52< celmin> The else is "implicit" anyway.
20160902 01:37:23< vultraz> not.. really? I was just saying if I want to return false I need to check all_of :|
20160902 01:37:31< celmin> That doesn't make sense?
20160902 01:37:42< vultraz> .. . .
20160902 01:38:17< celmin> Your paste has if(…) {return false;} return show();
20160902 01:38:37< celmin> That's not cleaner than if(…) {return show();} return false; is it?
20160902 01:39:00< celmin> (Obviously with a different conditional.)
20160902 01:39:00< vultraz> celmin: http://pastebin.com/Vq2tG8gi
20160902 01:39:03< vultraz> top vs bottom
20160902 01:39:35< celmin> Hmm.
20160902 01:39:41-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 01:39:42< travis-ci> wesnoth/wesnoth#10667 (master - 423fc10 : Charles Dang): The build has errored.
20160902 01:39:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156955624
20160902 01:39:42-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 01:39:53< celmin> The .empty() check might be redundant…
20160902 01:40:08< celmin> Oh, there's also none_of, huh.
20160902 01:40:22< vultraz> plus I usually write my code to return on the exception not execute on the rule.
20160902 01:41:27< celmin> any_of returns false on an empty range, so in the bottom version, the .empty() check is redundant and not needed.
20160902 01:41:56< vultraz> isn't that the case for the top version, then?
20160902 01:42:49< celmin> all_of returns true on an empty range.
20160902 01:43:11< celmin> As does none_of.
20160902 01:43:29< celmin> So I think it's redundant, yeah.
20160902 01:44:20< celmin> I think I don't have a strong preference which you choose, now that I've looked at them both.
20160902 01:44:33< vultraz> well, it's my code, so I choose :P
20160902 01:44:37< celmin> I'd probably go the any_of route myself, but whatever.
20160902 01:44:47< celmin> none_of may be better than all_of.
20160902 01:47:26< vultraz> blah, it keeps looping back to the campaign dialog
20160902 01:47:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 01:50:13< vultraz> ah
20160902 01:50:20< vultraz> the exception needs to return true
20160902 01:52:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160902 01:57:04< tad_> Got one ...
20160902 01:57:07< tad_> 20160901 20:54:03 error gui/layout: tgrid [] place: Failed to place a grid, we have 352,38 space but we need 382,38 space. This happened at a grid with the id '' in a 'N4gui28tlistboxE' with the id 'scenario_settings_list' in a 'N4gui25tgridE' with the id '' in a 'N4gui210tgeneratorINS_6policy17minimum_selection5tnoneENS1_17maximum_selection9tinfiniteENS1_9placement12tindependentENS1_13select_action5tshowEEE' with the id '_content
20160902 01:57:19< vultraz> what's this?
20160902 01:57:20-!- RatArmy [~RatArmy@240f:b3:88e3:1:221:85ff:fec0:94bc] has quit [Quit: Leaving]
20160902 01:57:35< tad_> One of those layout issues I can't reproduce
20160902 01:57:51< tad_> In this case a unit list with no units at all.
20160902 01:58:09< vultraz> uh... 
20160902 01:58:17< vultraz> in the inspector?
20160902 01:58:30< tad_> Nope. Menu. Units
20160902 01:58:47< tad_> Let me recheck.
20160902 01:59:22< vultraz> Unit List?
20160902 02:00:32< tad_> Empty unit list ... 20160901 20:58:37 error gui/layout: tgrid [] place: Failed to place a grid, we have 0,345 space but we need 281,28 space. This happened at a grid with the id '' in a 'N4gui28tlistboxE' with the id 'units_list' in a 'N4gui25tgridE' with the id '' in a 'N4gui25tgridE' with the id '_window_content_grid' in a 'N4gui25tgridE' with the id '_content_grid' in a 'N4gui216tscrollbar_panelE' with the id '' in a 'N4gui25tg
20160902 02:01:04< vultraz> so in the Unit List dialog?
20160902 02:01:14< tad_> And empty status table ... 20160901 20:59:10 error gui/layout: tgrid [] place: Failed to place a grid, we have 352,38 space but we need 382,38 space. This happened at a grid with the id '' in a 'N4gui28tlistboxE' with the id 'scenario_settings_list' in a 'N4gui25tgridE' with the id '' in a 'N4gui210tgeneratorINS_6policy17minimum_selection5tnoneENS1_17maximum_selection9tinfiniteENS1_9placement12tindependentENS1_13select_action5tsho
20160902 02:02:23< irker185> wesnoth: Charles Dang wesnoth:master 8b609040745c / src/game_initialization/ (create_engine.cpp create_engine.hpp): Create Engine: added method to get active mod data https://github.com/wesnoth/wesnoth/commit/8b609040745c3dcd03eefa12108e45ce5dbf01a4
20160902 02:02:26< tad_> I'm doing DM S08 and when I clean up the visual artifacts to fade-to-black is really black I have no units on the map and no side to show so both dialog boxes are empty. They look OK onthe screen bug give those errors on the console.
20160902 02:02:26< irker185> wesnoth: Charles Dang wesnoth:master 4bacb417f24b / src/ (4 files in 2 dirs): SP Options Configure: only show dialog if there is at least one active mod with  https://github.com/wesnoth/wesnoth/commit/4bacb417f24b8dcd48adbedd84b7d8815d13eeb2
20160902 02:02:29< irker185> wesnoth: Charles Dang wesnoth:master 19c13cf7d6be / src/gui/dialogs/multiplayer/ (mp_options_helper.cpp mp_options_helper.hpp): MP Options Helper: minor cleanup https://github.com/wesnoth/wesnoth/commit/19c13cf7d6beedfb7c5905baf3a0fabd0c42d968
20160902 02:02:40< celmin> Whoa whoa.
20160902 02:02:49< tad_> I'm doing DM S08 and when I clean up the visual artifacts to fade-to-black is really black I have no units on the map and no side to show so both dialog boxes are empty. They look OK onthe screen bug give those errors on the console.
20160902 02:03:10< vultraz> tad_: again, is this the Unit List dialog you're talking about :|
20160902 02:03:37< tad_> Menu | Unit List .. and .. Menu | Status Table
20160902 02:03:48< vultraz> ok
20160902 02:03:57< tad_> both
20160902 02:04:07< vultraz> celmin: why woah woah?
20160902 02:04:16< celmin> Big errors pasted.
20160902 02:04:38< tad_> And edge condition. No units at all and no SHOWN sides (all 3 are hidden).  Making it so a "fade to black" goes totally black.
20160902 02:04:52< vultraz> ok
20160902 02:05:03< vultraz> the solution would be to not show the dialogs if they have nothing to show
20160902 02:05:07< tad_> celmin: actually they're larger but the IRC cuts them off
20160902 02:05:15< celmin> vultraz: And instead show a transient message, right?
20160902 02:05:24< tad_> vultraz: They show fine. Just error on the console
20160902 02:05:28< vultraz> likely
20160902 02:05:34< celmin> tad_: Some clients would automatically split… maybe I should be glad that yours doesn't. >_>
20160902 02:05:45< tad_> vultraz: Plus that would mean you'll get "I click on the menu and nothing happened" reports
20160902 02:05:58< vultraz> [13:05:15]	celmin	vultraz: And instead show a transient message, right?
20160902 02:06:18< celmin> Like the popup when you have no units to recall.
20160902 02:06:33< tad_> Actually, the messages would be a LOT easier to read if vultraz added some \n here and there ...
20160902 02:07:37< tad_> Personally, I would prefer grey/disable the menu item and not have any errors or any "Sorry, not now" popups.
20160902 02:08:21< tad_> But you've been doing the popups so go with a consistent style.
20160902 02:10:54< tad_> in this particular case (which is probably rare) the player had a clue that no units were on the map since the discussion said so and they disappeared on the map and minimap a few messages earlier. But if you missed it and are checking the Menu stuff before End Scenario .. the empty dialogs are fine by me and are technically correct.
20160902 02:11:05-!- Shiki [~Shiki@141.39.226.227] has quit [Remote host closed the connection]
20160902 02:12:44< tad_> But, looking at Recruit and Recall when Delfador gets to the land of the undead a moment later .. an error popup is consistent
20160902 02:17:47< irker185> wesnoth: Charles Dang wesnoth:master 601f217ca245 / data/gui/window/sp_options_configure.cfg: SP Configure Options: increase max height https://github.com/wesnoth/wesnoth/commit/601f217ca24500aa3bd5f27876ab4492a2bfa82d
20160902 02:18:44< celmin> vultraz: Quick question, any objection to PR 763?
20160902 02:19:33< vultraz> no
20160902 02:21:42-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 02:21:43< travis-ci> wesnoth/wesnoth#10668 (master - fd53599 : Charles Dang): The build has errored.
20160902 02:21:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156959891
20160902 02:21:43-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 02:22:35< vultraz> I should probably use tdialog::execute more
20160902 02:26:20< celmin> ?
20160902 02:26:39< irker185> wesnoth: Gregory A Lundberg wesnoth:master 65134d6f0f5d / data/lua/wml-tags.lua: [role] always error on missing role= https://github.com/wesnoth/wesnoth/commit/65134d6f0f5d95dfdc1832387c16c23b5e608864
20160902 02:26:41< irker185> wesnoth: Celtic Minstrel wesnoth:master 3ca997db1b18 / data/lua/wml-tags.lua: Merge pull request #763 from GregoryLundberg/GL_role_missing_role https://github.com/wesnoth/wesnoth/commit/3ca997db1b1894c036f4e2911364d41cf2566060
20160902 02:47:59-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160902 02:50:22-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160902 02:56:20< vultraz> celmin: some dialogs have wrapper show functions instead of the proper tdialog::show/execute functions
20160902 02:56:26< vultraz> like gui2::show_unit_list
20160902 02:56:28< celmin> So now it works for me, but still need to fix it for mattsc somehow...
20160902 02:56:40< vultraz> it used to be  in dialogs.cpp, but was just moved
20160902 02:56:43< celmin> Thus, I now have clang 3.8. \o/
20160902 03:01:16< celmin> Ah, now I'm getting the same linker errors that mattsc reported, huh...
20160902 03:02:11< tad_> I'm on arch linux using gcc and just built the merge of 763 and no errors
20160902 03:04:20< vultraz> tfw you change a widely-used header and it takes forever to rebuild
20160902 03:04:50< vultraz> #JustNotHighEndPCProgrammerThings
20160902 03:05:08< celmin> tfw?
20160902 03:05:13< celmin> Oh.
20160902 03:05:24< celmin> What'd you change, config.hpp?
20160902 03:05:34< vultraz> string_utils.hpp
20160902 03:05:49< celmin> Oh? Now I'm curious.
20160902 03:06:09< vultraz> i'm testing this http://pastebin.com/JBq0W0MX
20160902 03:06:50< celmin> Whoa what.
20160902 03:06:58< vultraz> hm?
20160902 03:07:26< celmin> I don't get it.
20160902 03:07:53< vultraz> i noticed this http://en.cppreference.com/w/cpp/iterator/move_iterator
20160902 03:08:33< celmin> Won't that return ,str1str2str3?
20160902 03:08:53< vultraz> I dunno, which is why I'm testing
20160902 03:09:01< celmin> Pretty sure it will.
20160902 03:10:04< celmin> Also, using move_iterator on a const container won't do anything, I think.
20160902 03:10:15< celmin> Or rather, won't do anything different from the base iterator.
20160902 03:16:39< celmin> Sigh.
20160902 03:18:48< vultraz> blah, yeah, it doesn't build on every usecase :(
20160902 03:18:50< vultraz> sadness
20160902 03:19:34< vultraz> i tried
20160902 03:19:43< irker185> wesnoth: Celtic Minstrel wesnoth:master ac7508d42731 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Revert "XCode: Use address sanitizer in debug builds" https://github.com/wesnoth/wesnoth/commit/ac7508d427315cdc47d7586a7d43bf6c5b759687
20160902 03:20:00< celmin> Well, on the bright side, it pushed me to try integrating clang 3.8 into XCode, I guess.
20160902 03:20:30< celmin> vultraz: Even if it built, accumulate doesn't do what you appear to think it does.
20160902 03:21:02< celmin> accumulate is basically a generalization of sum(a,b,c,d,e,…)
20160902 03:21:45< celmin> So, if you pass in strings, you get the concatenation of all the strings, which is fine if the join string is empty, but not quite right if it's not.
20160902 03:22:06< celmin> You could probably wrangle it to work with accumulate, mind you.
20160902 03:22:39< celmin> By passing the first string as "initial" and using a binary operation that returns a + joiner + b.
20160902 03:22:50< celmin> (And of course starting at begin() + 1instead of begin().)
20160902 03:23:06< vultraz> eh, not worth it
20160902 03:23:09< celmin> (Obviously you'd also need to special-case the possibility of size() == 1 for that to work.)
20160902 03:23:20 * celmin shrug.
20160902 03:29:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160902 03:37:05< vultraz> hm
20160902 03:37:28< vultraz> the unit list_dialog returns from pre_show if unit_list_ is empty..
20160902 03:37:33< vultraz> why did I have that..
20160902 03:44:04-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 03:44:05< travis-ci> wesnoth/wesnoth#10670 (master - 19c13cf : Charles Dang): The build has errored.
20160902 03:44:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156982801
20160902 03:44:05-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 03:48:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 265 seconds]
20160902 03:52:44-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160902 03:53:32-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160902 03:57:08< celmin> I think I was wrong about it not breaking errors. Might need to pass output through awk or something?
20160902 04:02:30< shadowm> src/tstring.cpp:297:39: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing]
20160902 04:02:48< celmin> Oh yeah, I was going to fix that warning but forgot.
20160902 04:02:54< celmin> I'll fix it soon.
20160902 04:02:54< shadowm>   *reinterpret_cast<int32_t*>(count_val) = count;
20160902 04:03:05< shadowm> I don't know the context but ew.
20160902 04:03:26< celmin> I think using bit operators to manually break it up is more ew though.
20160902 04:03:35< celmin> (Which is what's done for textdomain IDs.)
20160902 04:03:47< shadowm> I still don't know the context but still ew.
20160902 04:04:14< celmin> Shrug!
20160902 04:05:52< celmin> As far as I can see, the output is almost exactly the same between Apple clang 4.2 and normal clang 3.8, so why doesn't it work...
20160902 04:07:24< shadowm> This is GCC 6.1.1, not clang.
20160902 04:07:34< celmin> Sorry, that was something unrelated.
20160902 04:07:59< celmin> The thing I've been doing on-and-off for the past however long.
20160902 04:09:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 04:13:06-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160902 04:13:21-!- JyrkiVesterinen [~JyrkiVest@87-100-234-151.bb.dnainternet.fi] has joined #wesnoth-dev
20160902 04:13:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160902 04:13:58< vultraz> I wonder if I should handle the 'no x available
20160902 04:14:05< vultraz> popups in execute functions
20160902 04:14:34< vultraz> or at the call site...
20160902 04:14:37< vultraz> celmin: thoughts?
20160902 04:14:59< celmin> You expect me to give an opinion with no context whatsoever?
20160902 04:16:16< vultraz> guess it doesn't matter
20160902 04:17:42-!- travis-ci [~travis-ci@ec2-54-90-255-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 04:17:43< travis-ci> wesnoth/wesnoth#10671 (master - 601f217 : Charles Dang): The build has errored.
20160902 04:17:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156984777
20160902 04:17:43-!- travis-ci [~travis-ci@ec2-54-90-255-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 04:17:51< celmin> Oh, I suddenly realized what you mean.
20160902 04:18:04< celmin> If there's only one call site, then yeah, it doesn't really matter.
20160902 04:18:35< celmin> However, if there are multiple call sites, or potentially could maybe be multiple call sites in the future, then an execute function is probably more robust.
20160902 04:18:54< vultraz> true
20160902 04:19:16< vultraz> I'm also torn on just how much data handling the execute functions should do..
20160902 04:19:51< vultraz> for example, in this case, I could keep the 'show_unit_list' function and make it generate the vector, pass it to execute, and have execute display the popup if it's empty.
20160902 04:20:03< vultraz> or I could handle everything in execute 
20160902 04:20:13< vultraz> and remove the show_unit_list function
20160902 04:22:17< celmin> I think it's good for an execute function to take the list directly. That makes it easy to pass a different list if you want to.
20160902 04:22:17< vultraz> thought in this case, the unit_list also has post-dialog actions...
20160902 04:22:27< vultraz> good point
20160902 04:34:23-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160902 04:49:30< celmin> Seems like installing the matching libclang fixes it.
20160902 04:49:58< celmin> I now seem to have working XCode 4 with clang 3.8.
20160902 04:50:35< celmin> Maybe?
20160902 04:52:02< irker185> wesnoth: Charles Dang wesnoth:master b2cd7fa1dfdd / src/ (5 files in 2 dirs): Unit List + Game Stats: don't show dialogs if nothing to show https://github.com/wesnoth/wesnoth/commit/b2cd7fa1dfdd55390a0f1033ec355b51a098df10
20160902 04:52:12-!- JyrkiVesterinen [~JyrkiVest@87-100-234-151.bb.dnainternet.fi] has quit [Quit: .]
20160902 04:52:25< vultraz> also trying out the 'pass variables by reference to dialog' thing
20160902 04:52:37< vultraz> instead of getter methods.
20160902 04:53:56< celmin> Yeah okay, that fixes regular errors but utterly breaks the indexer.
20160902 04:54:57< vultraz> are you talking to me
20160902 04:56:48< celmin> No.
20160902 04:56:53< celmin> Just rambling to myself.
20160902 04:59:37-!- travis-ci [~travis-ci@ec2-54-90-255-214.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 04:59:38< travis-ci> wesnoth/wesnoth#10672 (master - 3ca997d : Celtic Minstrel): The build has errored.
20160902 04:59:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156985532
20160902 04:59:38-!- travis-ci [~travis-ci@ec2-54-90-255-214.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 05:04:09< shadowm> Maybe you should make that clearer in general.
20160902 05:04:18< celmin> Maybe.
20160902 05:28:05-!- Kwandulin [~Miranda@p200300760F4241C47961716C22DA2FA7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160902 05:28:09-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 05:28:10< travis-ci> wesnoth/wesnoth#10674 (master - b2cd7fa : Charles Dang): The build failed.
20160902 05:28:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/157002488
20160902 05:28:10-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 05:38:04-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160902 05:38:58-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 05:38:59< travis-ci> wesnoth/wesnoth#10673 (master - ac7508d : Celtic Minstrel): The build has errored.
20160902 05:38:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/156991810
20160902 05:38:59-!- travis-ci [~travis-ci@ec2-54-205-99-206.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 05:45:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160902 05:45:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160902 05:47:01-!- edgrey [~edgrey@178.204.42.100] has joined #wesnoth-dev
20160902 05:57:31-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 06:01:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160902 06:02:05-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160902 06:24:06-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160902 07:30:39-!- aidanhs [~aidanhs@2a00:d880:6:1ad::8e27] has quit [Ping timeout: 260 seconds]
20160902 07:36:54-!- edgrey [~edgrey@178.204.42.100] has quit [Ping timeout: 258 seconds]
20160902 07:40:04-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160902 07:40:15-!- edgrey [~edgrey@178.204.42.100] has joined #wesnoth-dev
20160902 07:42:52-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160902 07:42:52-!- wedge010 is now known as wedge009
20160902 07:45:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 07:48:46-!- Bonobo [~Bonobo@2001:44b8:254:3200:2d28:7666:f53f:db78] has quit [Ping timeout: 255 seconds]
20160902 07:50:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160902 07:58:14-!- Bonobo [~Bonobo@2001:44b8:254:3200:2d28:7666:f53f:db78] has joined #wesnoth-dev
20160902 08:01:01-!- aidanhs [~aidanhs@2a00:d880:6:1ad::8e27] has joined #wesnoth-dev
20160902 08:03:10-!- Bonobo [~Bonobo@2001:44b8:254:3200:2d28:7666:f53f:db78] has quit [Ping timeout: 255 seconds]
20160902 08:03:30-!- Bonobo [~Bonobo@2001:44b8:254:3200:5cc9:2c21:da2f:ecfe] has joined #wesnoth-dev
20160902 08:09:47-!- RatArmy [~RatArmy@240f:b3:88e3:1:221:85ff:fec0:94bc] has joined #wesnoth-dev
20160902 08:10:54-!- RatArmy [~RatArmy@240f:b3:88e3:1:221:85ff:fec0:94bc] has quit [Client Quit]
20160902 08:11:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160902 08:11:55-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160902 08:36:30-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160902 08:42:27-!- edgrey [~edgrey@178.204.42.100] has quit [Ping timeout: 264 seconds]
20160902 08:48:02-!- irker185 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160902 08:49:39-!- Duthlet [~Duthlet@dslb-188-104-247-024.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20160902 08:56:04-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160902 09:07:02-!- Kwandulin [~Miranda@p200300760F4241C47961716C22DA2FA7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160902 09:26:19-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Remote host closed the connection]
20160902 09:34:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 09:39:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160902 09:42:00-!- Kwandulin [~Miranda@p200300760F4241C4C5532239151E8F2D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160902 09:43:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160902 09:48:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160902 10:05:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160902 10:58:09-!- vincent_c [~bip@vcheng.org] has quit [Ping timeout: 258 seconds]
20160902 11:00:20-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20160902 11:04:03-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160902 11:07:36-!- Netsplit *.net <-> *.split quits: Duthlet, JyrkiVesterinen, DDR, esr, Soliton, crimson_penguin
20160902 11:10:00-!- Netsplit over, joins: Duthlet, Soliton, esr, DDR, crimson_penguin
20160902 11:13:40-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-knahqdawhokfqlbl] has quit [Ping timeout: 264 seconds]
20160902 11:17:51-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-avurzyfqzdyfebqv] has joined #wesnoth-dev
20160902 11:18:14-!- matthiaskrgr is now known as Guest94942
20160902 11:21:19-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160902 11:22:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 11:26:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160902 12:00:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160902 12:51:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160902 13:01:55-!- Shiki [~Shiki@141.57.58.245] has joined #wesnoth-dev
20160902 13:07:20-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160902 13:15:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160902 13:18:03-!- Bonobo [~Bonobo@2001:44b8:254:3200:5cc9:2c21:da2f:ecfe] has quit [Quit: Leaving]
20160902 13:34:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160902 13:45:50< Shiki> building fails for me with
20160902 13:45:59< Shiki> src/gui/dialogs/game_stats.hpp:39:94: Fehler: ISO-C++ verbietet Deklaration von »execute« ohne Typ [-fpermissive]
20160902 13:46:01< Shiki> static execute(game_board& board, const int viewing_team, int& selected_index, CVideo& video)
20160902 13:48:05< vultraz> What is that in English? 'variable declaration of type'.. or something?
20160902 13:48:35< Soliton> you forgot the return type.
20160902 13:48:49< vultraz> oh
20160902 13:48:51< vultraz> bah!
20160902 13:53:19-!- aidanhs [~aidanhs@2a00:d880:6:1ad::8e27] has quit [Ping timeout: 260 seconds]
20160902 13:55:55-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160902 14:01:23-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160902 14:04:55-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160902 14:11:00-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160902 14:19:26-!- Kwandulin [~Miranda@p200300760F4241C4C5532239151E8F2D.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160902 14:24:05-!- aidanhs [~aidanhs@2a00:d880:6:1ad::8e27] has joined #wesnoth-dev
20160902 14:55:52-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160902 15:16:38-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160902 15:22:22-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160902 15:27:08-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160902 15:29:35-!- irker066 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160902 15:29:35< irker066> wesnoth: Charles Dang wesnoth:master 2c5c3f560061 / src/gui/dialogs/game_stats.hpp: Game Stats: forgot return type on execute function https://github.com/wesnoth/wesnoth/commit/2c5c3f5600615a710d5b4364114150ef3552a6c2
20160902 15:29:36< irker066> wesnoth: Charles Dang wesnoth:master 09a095b8b1f4 / src/ (9 files in 4 dirs): Preferences: refactored handling of initial page specification https://github.com/wesnoth/wesnoth/commit/09a095b8b1f4018d82320a3a8e27b8f15b530054
20160902 15:32:09-!- Kwandulin [~Miranda@p200300760F4241C47979913672DBE429.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160902 15:36:21-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160902 15:40:53-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.1 Aria]
20160902 15:42:04-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 15:44:00-!- DeFender1031 [~DeFender1@46-116-114-128.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20160902 15:51:36-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160902 16:04:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160902 16:04:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160902 16:06:31< zookeeper> fun little animation bug: https://forums.wesnoth.org/viewtopic.php?p=601738#p601738
20160902 16:07:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160902 16:23:39-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 16:23:40< travis-ci> wesnoth/wesnoth#10675 (master - 09a095b : Charles Dang): The build has errored.
20160902 16:23:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/157128508
20160902 16:23:40-!- travis-ci [~travis-ci@ec2-54-162-36-37.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 16:24:56-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160902 16:31:36-!- fabi [~fabi@176.0.57.109] has quit [Ping timeout: 244 seconds]
20160902 16:32:11-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160902 16:45:24-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160902 16:45:29 * vultraz is working on the Generator Settings dialog now
20160902 16:45:41< celticminstrel> Oh okay.
20160902 16:46:25< vultraz> btw, regarding my comment in  https://github.com/wesnoth/wesnoth/commit/09a095b8b1f4018d82320a3a8e27b8f15b530054
20160902 16:46:33< vultraz> what do you think of ids for stack layers?
20160902 16:48:55-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160902 16:53:03-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160902 16:57:48< celticminstrel> I think you're wrong about it requiring changes to tgenerator.
20160902 16:58:01< celticminstrel> Probably.
20160902 16:58:12< celticminstrel> Or it it does, they'd be quite minor changes.
20160902 16:58:31< celticminstrel> Mostly it would require changes to tstacked_widget.
20160902 16:58:38< celticminstrel> Anyway, it's not a bad idea.
20160902 16:59:55-!- fabi [~fabi@176.0.57.109] has joined #wesnoth-dev
20160902 17:02:51-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160902 17:03:18 * vultraz is doing some refactoring to default_map_generator in the process of this
20160902 17:05:35-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160902 17:06:51< vultraz> why the hell are these map parameters size_t ;|
20160902 17:07:51< celticminstrel> Quite possibly a good reason.
20160902 17:08:03< celticminstrel> Is there a problem with it>
20160902 17:08:04< celticminstrel> ^?
20160902 17:08:55< vultraz> not really
20160902 17:08:56 * zookeeper is enough of a newbie to not even know what size_t is
20160902 17:09:34< vultraz> oh well, I'm moving this stuff into a struct anyway. if i really needs to be size_t i can change it easily.
20160902 17:12:11< celticminstrel> You shouldn't randomly change the type of a variable.
20160902 17:12:24< celticminstrel> If it's size_t and you don't know why it's size_t, then you should leave it as size_t.
20160902 17:12:38< celticminstrel> If you know why it's size_t and it obviously doesn't need to be, then whatever.
20160902 17:12:52< celticminstrel> At the very least, if you insist on changing it, keep it unsigned.
20160902 17:18:40< tad_> In general, I agree with CM on that. size_t, however, is so often misused that whenever I see it I always check .. if it's related to physical memory size (such as the sizeof() for a class or struct), then it's fine. But if it's for something else (like a "character count" or an array index or size) then it's a code smell and should be evaluated. Increasing size is generally safe, changing signed-ness needs careful code reading an
20160902 17:18:59-!- fabi [~fabi@176.0.57.109] has quit [Quit: Konversation terminated!]
20160902 17:19:31< celticminstrel> If it's an array (well, vector) index or size, it should be size_t, because vector::size() returns size_t.
20160902 17:19:31< zookeeper> ehh. do we or are we supposed to use the hero/leader ellipse only on units that can't die?
20160902 17:19:41< celticminstrel> zookeeper: Huh?
20160902 17:19:44< zookeeper> tad_, oh right you're here. i was just writing some final notes on the last scenarios.
20160902 17:19:58< zookeeper> celticminstrel, do we or are we supposed to use the hero/leader ellipse only on units that can't die?
20160902 17:20:20< celticminstrel> ...why'd you repeat the question?
20160902 17:20:40< tad_> Notes on the PR are good .. easier to find and remember than doing them here
20160902 17:21:11< zookeeper> celticminstrel, well... because you asked something about it and i feel the question is so clear that it doesn't need to be re-phrased
20160902 17:21:13< tad_> The rule I've been using the the overlay and ellipse is they're a defeat-condition
20160902 17:22:26< celticminstrel> Well, I know no reason why they should only be used on units that can't die, but I also don't know of any existing uses where they're used on units that can die...
20160902 17:23:08< tad_> I think he's referring to some places where I take them off for the final scenes because they're no longer a defeat-condition.
20160902 17:23:13< zookeeper> yep
20160902 17:23:39< zookeeper> tad_, if you prefer github comments then i'll post them there...
20160902 17:23:44< tad_> It was inconsistent in TSG. Some parts were removed, for some, and not for others.
20160902 17:24:34< tad_> That's fine. The comments there are easier to remember, but I'm about to start working on the ones already there and do my aged mind won't have to remember the discussion here for long...
20160902 17:28:36< zookeeper> eh, wait, presumably gerrick would still get the leader ellipse in S07b... i was only going to comment that he should keep it in that scenario, but i think (?) that wouldn't even change since he'd just automatically use the leader ellipse when you remove his hero ellipse.
20160902 17:30:12< zookeeper> so, since that's not an issue, i don't think i have further comments to make
20160902 17:30:24< tad_> Oh .. the change for Gerrick, I think, was simply to use what I consider a better order .. I've seen problems where one overlay is added before the old removed and it caused artifacts on the screen. Usually the problem is caused by the screen redrawing when he has canrecruit and still has the hero overlay
20160902 17:30:46-!- JyrkiVesterinen [~JyrkiVest@87-92-56-30.bb.dnainternet.fi] has joined #wesnoth-dev
20160902 17:31:43< tad_> I am waiting for a make to finish so I have time to waste ...
20160902 17:32:01< zookeeper> tad_, so you said that you're working on DM next? any particular campaign you're planning on tackling after that?
20160902 17:33:55< zookeeper> oh wait you already have a DM PR and presumably are only going to revisit it a bit?
20160902 17:35:23-!- Duthlet [~Duthlet@dslb-188-104-247-024.188.104.pools.vodafone-ip.de] has quit [Quit: leaving]
20160902 17:36:06-!- tad__ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160902 17:36:16< tad__> sorry. link phase killed me.
20160902 17:36:26-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Ping timeout: 264 seconds]
20160902 17:37:31< tad__> zookeeper: I was thinking the best plan was to finish off what I started in the past then work down the list as shown on the Campaign button on the title screen since that has the new-player stuff more to the top and the advanced stuff lower down.
20160902 17:37:35< vultraz> OK, now for the WML
20160902 17:37:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 17:38:57< tad__> I did DM out of sequence because, when I started, this was mainly in response to a question I had about Wesnoth history and who-knew-what-when, DM had the answers and needed work ...
20160902 17:42:10< zookeeper> tad__, well, campaign menu order is maybe a bit of an arbitrary criteria, but sure.
20160902 17:42:39< vultraz> celticminstrel, gfgtdf, wedge009, loonycyborg, Jetrel_bot, JyrkiVesterinen, Ivanovic, Aginor, zookeeper: don't forget to post your nominations for wesnoth.inc board members in the thread
20160902 17:42:57< zookeeper> i was mainly just wondering whether you prefer to keep doing fixes like this or if you'd like to try to implement some bigger changes.
20160902 17:43:05< JyrkiVesterinen> I'm not interested enough in the topic to nominate anyone, or even vote.
20160902 17:43:09< celticminstrel> ^
20160902 17:43:15< vultraz> fair enough
20160902 17:43:20< vultraz> just a reminder to those who are
20160902 17:44:08< tad__> zookeeper: Bigger changes are fine. But I'd prefer to work through a campaign and fix the logic flaws and edge conditions ...
20160902 17:44:31< zookeeper> i find the format a bit awkward because i'm supposed to nominate people without knowing whether they might want to be
20160902 17:44:38< tad__> zookeeper: But I will come in as I start work on one so we can discuss if there are changes you'd like to see as I'm working on a campaign.
20160902 17:45:46< zookeeper> tad__, okay. as i've said before there's quite a lot of shoddy scenarios that would really warrant a partial or complete redesign or other major additions, and maybe you'd find something like that interesting.
20160902 17:46:19< tad__> zookeeper: I agree on needing re-write or even re-design.
20160902 17:47:10-!- edgrey [~edgrey@178.204.42.100] has joined #wesnoth-dev
20160902 17:47:36< tad__> zookeeper: I will come in and tell you which I'm starting on when I do and we can talk about it then. If it's just a scene or two, it would make sense to skip fixing some errors in a scene and leave them for a subject-PR for that scene.  Akin to the HttT series
20160902 17:48:51< zookeeper> tad__, all right
20160902 17:50:59< tad__> zookeeper: To my thinking, the best plan is to fix as much as possible between now and whenever we freeze for 1.14 (mid January?) to try to get what there is, even it it's terribly done, working as error-free as possible.
20160902 17:51:59 * tad__ .oO(That way we came blame on the issues on the UI/UX team ...)
20160902 17:52:21< celticminstrel> ...ooh, cool, a thought bubble.
20160902 17:52:26-!- Shiki [~Shiki@141.57.58.245] has quit [Remote host closed the connection]
20160902 18:00:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160902 18:02:13-!- fabi [~fabi@176.0.57.109] has joined #wesnoth-dev
20160902 18:02:39< fabi> Aginor: Hi, what operating system are you using your steam controller with?
20160902 18:03:30< JyrkiVesterinen> vultraz: I saw in the logs that you got admin rights in Gna. Thus, you can add me to the Wesnoth developer group there.
20160902 18:03:44< JyrkiVesterinen> Please add me. My username in Gna is jyrkive, same as in GitHub.
20160902 18:05:05< vultraz> JyrkiVesterinen: you should be in
20160902 18:05:30< tad__> zookeeper: TSG S03 Jarek .. choose: drop Quick or drop Loyal. Dropping Loyal is easiest (just remove the commit) and avoids user complaints.
20160902 18:05:44< JyrkiVesterinen> "You are both technician and manager for this tracker."
20160902 18:05:49< JyrkiVesterinen> Thanks vultraz. :)
20160902 18:06:44< zookeeper> tad__, uh, i guess drop loyal in that case. why not drop strong though?
20160902 18:08:42< vultraz> hmmmm
20160902 18:08:47< vultraz> error: invalid initialization of non-const reference of type 'int&' from an rvalue of type 'int'|
20160902 18:08:50< vultraz> blah
20160902 18:09:13< irker066> wesnoth: Jyrki Vesterinen wesnoth:master fa89aed9e75a / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/fa89aed9e75ad7cc1844c1fb81c726a64b9a8792
20160902 18:09:34< tad__> zookeeper: totally up to you which to drop .. I personally only really notice Quick in the Long March but I figure nerfing the unit would get a lot of comments.
20160902 18:09:52< tad__> zookeeper: Dropping Loyal as easiest to do
20160902 18:10:19< celticminstrel> You don't want to initialize a non-const reference of type int& with an rvalue of type int.
20160902 18:10:36< vultraz> obviously :|
20160902 18:10:53< celticminstrel> So why are you trying to do so?
20160902 18:11:18< zookeeper> tad__, drop loyal then
20160902 18:11:43< vultraz> well, the constructor takes a reference to a struct, which contains the variables I need, but register_integer takes the value as a reference to an int...
20160902 18:12:07< vultraz> so I thought I could use struct.var as the third argument, but it seems not so
20160902 18:12:15< vultraz> :/
20160902 18:12:24< celticminstrel> No, that should work.
20160902 18:12:29< celticminstrel> Unless the struct itself is an rvalue.
20160902 18:12:37< celticminstrel> But it clearly isn't here.
20160902 18:12:54< zookeeper> tad__, one could argue that he shouldn't be getting auto-recalled in all scenarios though. especially when he doesn't ever actually say anything (except when dying, and IIRC in one of the finales).
20160902 18:13:04-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160902 18:13:06< zookeeper> (and obviously when you first get him)
20160902 18:14:32< tad__> zookeeper: The case for Loyal: he's not recruited by player action. The case for dropping auto-recall: it was probably an idea never implemented and was never removed.
20160902 18:15:18< vultraz> celticminstrel: but then what could be the problem..
20160902 18:15:39< celticminstrel> Well, it's hard to say without code.
20160902 18:15:43< tad__> zookeeper: "least change" says not-loyal, and let him be.
20160902 18:15:55< zookeeper> tad__, i don't really have much preference between 1) dropping loyal and removing auto-recalling and 2) just making him loyal,whatever and keeping auto-recalling
20160902 18:16:11< zookeeper> but as far as i'm concerned, he can certainly stay as-is; non-loyal but auto-recalled
20160902 18:16:30< zookeeper> apparently it's not bothered anyone before
20160902 18:17:01< vultraz> celticminstrel: https://github.com/wesnoth/wesnoth/compare/master...Vultraz:master
20160902 18:17:44< celticminstrel> Could also be non-loyal but still not cost upkeep.
20160902 18:17:50< vultraz> (hasn't been wired in yet)
20160902 18:17:53< celticminstrel> Though that might confuse people.
20160902 18:18:14< celticminstrel> vultraz: I'll take a look once the build finishes.
20160902 18:18:27< tad__> zookeeper: As to bodyguards. Splitting a custom event for them. On victory event as we're leaving, if they're not there yet: Ethiliel: Come, my bodyguard, we must find Mebrin!" .. chorus, etc,  "You have a bodyguard?" .. cut to black
20160902 18:18:30< celticminstrel> I can't even touch Firefox while link is in progress.
20160902 18:18:38< celticminstrel> Even though it's actually open for once.
20160902 18:19:30< zookeeper> tad__, sure, that'll work.
20160902 18:20:04< tad__> I chuckle every time the chorus sings "You have a bodyguard?" ..
20160902 18:21:18< zookeeper> tad__, WRT the bodyguard placement code: i'm sure it's perfectly adequate for that scenario, but if i were to write something like that from scratch now, i'd just make a while loop which finds vacant forest hexes within an increasing radius around ethiliel until it's found enough locations, instead of the thing having a hard-coded radius.
20160902 18:22:00< zookeeper> i can write stuff like that if you come across something that looks like it should be a bit fancier
20160902 18:25:24-!- Kwandulin [~Miranda@p200300760F4241C47979913672DBE429.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160902 18:26:47< tad__> zookeeper: Sounds good. If I see it again, I'll see about doing a Lua function to generalize the solution. I must admit I thought the fixed radius was silly and through about just keeping looking for a vacant forest tile further out. Might want Lua for it especially if it's done more than here or the map has few forest tiles.
20160902 18:31:40< tad__> zookeeper: pushed new TSG .. deleted two commits and added one. New one is at end. I need to play-test it while you review it. I think that addresses all issues.
20160902 18:33:44< Ivanovic> vultraz: i have no nominations since i have been inactive for a while and no clue who would be suited
20160902 18:33:55< vultraz> alright
20160902 18:36:18< zookeeper> tad__, ok but now if you happen to get the bodyguards only at the end, you get the "You have a bodyguard?!" which won't make any sense in that context?
20160902 18:36:50< zookeeper> even just doing it completely silently would seem to work better in that case
20160902 18:37:20< tad__> Did I forget her line? DUH
20160902 18:37:44< zookeeper> i guess so :p
20160902 18:37:44< vultraz> (perhaps tad__ would like to cast a nomination?)
20160902 18:40:37< tad__> vultraz: you, zookeeper and wedge come to mind. Probably a couple others but I've not really thought about it.
20160902 18:41:05< vultraz> well if you decide on something, just post it in the thread.
20160902 18:43:41< vultraz> celticminstrel: still building?
20160902 18:44:02-!- Guest94942 [matthiaskr@gateway/shell/panicbnc/x-avurzyfqzdyfebqv] has quit [Changing host]
20160902 18:44:02-!- Guest94942 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160902 18:44:02-!- Guest94942 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20160902 18:44:02-!- Guest94942 [matthiaskr@gateway/shell/panicbnc/x-avurzyfqzdyfebqv] has joined #wesnoth-dev
20160902 18:44:03< tad__> vultraz: I think the area where the thread is is locked to non-developers. But it not, sure.
20160902 18:44:17< vultraz> ah, right
20160902 18:44:49< vultraz> well just let me know, in that case.
20160902 18:45:26< tad__> zookeeper: OK. **NOW** I think it's ready.  Remember, it's __very__ unlikely to get to victory without having __someone__ die so this is just a stop-gap I expect will rarely be seen, if ever.
20160902 18:45:31-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160902 18:45:43-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160902 18:46:37< zookeeper> tad__, well, people like to do no-deaths playthroughs and TSG is so easy that i'd think it shouldn't be hard to accomplish in that scenario? i mean sure most people will not see it, but i don't think it's as rare as you might think.
20160902 18:47:05< zookeeper> "follow the trait", eh? :P
20160902 18:47:14< tad__> grrr...
20160902 18:48:52< tad__> Well, this is why PRs and code-reads are A Good Thing(sm). Prevents a mess of "fix commit ..." commits
20160902 18:49:06< tad__> Pushed .. again.  
20160902 18:49:14< celmin> So vultraz, that's three commits, which one should I be looking at...?
20160902 18:49:22< vultraz> celmin: latest
20160902 18:49:32< vultraz> the middle one has the definition of the struct, though
20160902 18:49:39< zookeeper> tad__, looks good to me now
20160902 18:49:53< zookeeper> shall i merge the whole thing or are you still testing something?
20160902 18:50:23< celmin> I can't tell which is the latest.
20160902 18:50:55< tad__> Give me a moment to test that we don't get them twice ... should work but I'm making DUMB mistakes today .. so .. 1 moment.
20160902 18:50:57< vultraz> 		8e30620
20160902 18:53:08< celmin> So you're not using the constructor initialization list for generator_data.
20160902 18:53:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160902 18:53:50< vultraz> oh?
20160902 18:54:14< celmin> I guess it doesn't matter since they're all integral variables.
20160902 18:54:23< tad__> zookeeper: OK. Looks good to go. Except for the mess in S05 .. which I'll get to later in a new PR .. I think I'm done with TSG so if you have no more issues, tell everyone to put on the blandfolds and press the button.
20160902 18:54:54 * JyrkiVesterinen is in a branch and doesn't care :P 
20160902 18:54:55< zookeeper> all right then
20160902 18:55:01< tad__> .oO(60 commits)
20160902 18:55:01< zookeeper> i'm going to press the button, cover your ears
20160902 18:55:21< celmin> What does Jyrki not care about?
20160902 18:55:30< JyrkiVesterinen> The game potentially breaking.
20160902 18:55:35< irker066> wesnoth: Gregory A Lundberg wesnoth:master efe1812a73c2 / data/campaigns/The_South_Guard/scenarios/ (02_Proven_by_the_Sword.cfg 07a_Into_the_Depths.cfg 08b_The_Tides_of_War.cfg): TSG Remove macro artifacts https://github.com/wesnoth/wesnoth/commit/efe1812a73c2023920c617f45696de1bf549da10
20160902 18:55:36 * zookeeper ducks for cover
20160902 18:55:37< irker066> wesnoth: Gregory A Lundberg wesnoth:master 691de88d0c2f / data/campaigns/The_South_Guard/scenarios/ (05_Choice_In_The_Fog.cfg 06b_The_Long_March.cfg 08b_The_Tides_of_War.cfg): TSG [else][if] should be [elseif] https://github.com/wesnoth/wesnoth/commit/691de88d0c2fc4ff3acd751836dca398811fd6f9
20160902 18:55:39< irker066> wesnoth: Gregory A Lundberg wesnoth:master a0af7e035e95 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG [then] cannot be empty https://github.com/wesnoth/wesnoth/commit/a0af7e035e95e469c1955efc776b3ef76ae0b6cc
20160902 18:55:41< irker066> wesnoth: Gregory A Lundberg wesnoth:master 84e462e1efa4 / data/campaigns/The_South_Guard/scenarios/ (11 files): TSG Remove variable artifacts https://github.com/wesnoth/wesnoth/commit/84e462e1efa4c414a10fa71518e6e10571f6c9f4
20160902 18:55:43< irker066> wesnoth: Gregory A Lundberg wesnoth:master c1f77f34d780 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: Anyone to fort https://github.com/wesnoth/wesnoth/commit/c1f77f34d7807057e4c53f43094595c23ffd6b1c
20160902 18:55:45< irker066> wesnoth: Gregory A Lundberg wesnoth:master a9041151dc68 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: Show target first https://github.com/wesnoth/wesnoth/commit/a9041151dc68fb4f16f6a68653177857539e1b50
20160902 18:55:47< irker066> wesnoth: Gregory A Lundberg wesnoth:master 439ec667e709 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: Only Deoran can recruit https://github.com/wesnoth/wesnoth/commit/439ec667e709b1d16a57ab3723b4b14d907306d8
20160902 18:55:49< irker066> wesnoth: Gregory A Lundberg wesnoth:master be440df638a9 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: Remove target before talking https://github.com/wesnoth/wesnoth/commit/be440df638a9953e58847f4f35a429a218d1ebf1
20160902 18:55:51< irker066> wesnoth: Gregory A Lundberg wesnoth:master 222d9ec0d1c3 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: We came from Weldyn https://github.com/wesnoth/wesnoth/commit/222d9ec0d1c33323ec479ff5e99e069ee647a549
20160902 18:55:53< irker066> wesnoth: Gregory A Lundberg wesnoth:master c3c622447e24 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: Urza Mathin may die first https://github.com/wesnoth/wesnoth/commit/c3c622447e247331bde69e1981816b562e1b818e
20160902 18:55:55< irker066> wesnoth: Gregory A Lundberg wesnoth:master 623fe1e5bb05 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Fix bug: Deoran is encamped https://github.com/wesnoth/wesnoth/commit/623fe1e5bb056f938b7333e6b7868e837867fc63
20160902 18:55:57< irker066> wesnoth: Gregory A Lundberg wesnoth:master 64843c07f2c5 / data/campaigns/The_South_Guard/scenarios/01_Born_to_the_Banner.cfg: TSG S01 Capture village https://github.com/wesnoth/wesnoth/commit/64843c07f2c54f78c1cbad8b8e19d351bd86b811
20160902 18:55:59< irker066> wesnoth: Gregory A Lundberg wesnoth:master b84ae1a62029 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Fix bug: Warning is a turn late https://github.com/wesnoth/wesnoth/commit/b84ae1a620295ecbb5ed24fc11e749af62aa53a6
20160902 18:56:01< irker066> wesnoth: Gregory A Lundberg wesnoth:master e3430d21efe4 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Fix bug: Anyone will do https://github.com/wesnoth/wesnoth/commit/e3430d21efe424401a14456341e58580b771a55d
20160902 18:56:03< irker066> wesnoth: Gregory A Lundberg wesnoth:master 97a3aca98b31 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Fix bug: Where is 'here'? https://github.com/wesnoth/wesnoth/commit/97a3aca98b315ce7633bfb04bd52d7d602ea2c28
20160902 18:56:05< irker066> wesnoth: Gregory A Lundberg wesnoth:master 0356f95b9a70 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Fix bug: No victory if no Minister Hylas https://github.com/wesnoth/wesnoth/commit/0356f95b9a700ca9244ec2d59e8e72fa7f83257f
20160902 18:56:07< irker066> wesnoth: Gregory A Lundberg wesnoth:master 38eae999c134 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Fix bug: Consistent name https://github.com/wesnoth/wesnoth/commit/38eae999c134922b1f5142598de706da140ed6ce
20160902 18:56:09< irker066> wesnoth: Gregory A Lundberg wesnoth:master 6536fb89e05f / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Why wait? https://github.com/wesnoth/wesnoth/commit/6536fb89e05f7a433b83e72530a7cce2ea1c17e8
20160902 18:56:11< irker066> wesnoth: Gregory A Lundberg wesnoth:master 065f6847fa06 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Impove instruction https://github.com/wesnoth/wesnoth/commit/065f6847fa067327430744501bfafaa010193cdb
20160902 18:56:13< irker066> wesnoth: Gregory A Lundberg wesnoth:master 9c18c815f7d4 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Adjust turns to reality https://github.com/wesnoth/wesnoth/commit/9c18c815f7d48856767b6827a7f8fb6ffdddf251
20160902 18:56:15< irker066> wesnoth: Gregory A Lundberg wesnoth:master b0f7e6507346 / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Hide implementation details https://github.com/wesnoth/wesnoth/commit/b0f7e65073463634481dca7e000715a3f44663cb
20160902 18:56:17< irker066> wesnoth: Gregory A Lundberg wesnoth:master 9814931a02dc / data/campaigns/The_South_Guard/scenarios/02_Proven_by_the_Sword.cfg: TSG S02 Capture village https://github.com/wesnoth/wesnoth/commit/9814931a02dc411563fa489272c9332ca4e697c9
20160902 18:56:19< irker066> wesnoth: Gregory A Lundberg wesnoth:master 8fa8fdf4cd87 / data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg: TSG S03 Fix bug: Use id= https://github.com/wesnoth/wesnoth/commit/8fa8fdf4cd87ac94a0eb07954b230c7f54daaf9c
20160902 18:56:21< irker066> wesnoth: Gregory A Lundberg wesnoth:master 29d58a2614d4 / data/campaigns/The_South_Guard/scenarios/03_A_Desparate_Errand.cfg: TSG S03 Fix bug: Use best speaker https://github.com/wesnoth/wesnoth/commit/29d58a2614d405169f148cc9568e3908a3c0fb0b
20160902 18:56:23< irker066> wesnoth: Gregory A Lundberg wesnoth:master 2ffaaac50be2 / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S04 Fix bug: Jera Ilras is team Bandits https://github.com/wesnoth/wesnoth/commit/2ffaaac50be29de6c61cfa3225b80a01760cf3c2
20160902 18:56:25< irker066> wesnoth: Gregory A Lundberg wesnoth:master 1f3ee030cdeb / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S04 Fix bug: Separate undead comments https://github.com/wesnoth/wesnoth/commit/1f3ee030cdebeea4b9c9d03fad9ca28676b8ba05
20160902 18:56:27< irker066> wesnoth: Gregory A Lundberg wesnoth:master 403f70d95490 / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S04 Fix bug: No bodyguards for hero deaths https://github.com/wesnoth/wesnoth/commit/403f70d9549081b5e668ff9f070d939bf0c8a89d
20160902 18:56:29< irker066> wesnoth: Gregory A Lundberg wesnoth:master dae4df3befc8 / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S04 Fix bug: No bodyguards AT ALL!!! https://github.com/wesnoth/wesnoth/commit/dae4df3befc8273332bba058242d0f1e5ace527b
20160902 18:56:31< irker066> wesnoth: Gregory A Lundberg wesnoth:master 316c0dbb4b45 / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S04 Adjust objectives https://github.com/wesnoth/wesnoth/commit/316c0dbb4b458481576fdcb2b855a8d67845f9e1
20160902 18:56:33< irker066> wesnoth: Gregory A Lundberg wesnoth:master 757e25b978e3 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05 Fix bug: Don't give away the bandits https://github.com/wesnoth/wesnoth/commit/757e25b978e3eae953e0aebe0934c481f6bf5016
20160902 18:56:35< irker066> wesnoth: Gregory A Lundberg wesnoth:master 4c88b78af40a / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TGS S05 Fix bug: Linger on the lich https://github.com/wesnoth/wesnoth/commit/4c88b78af40ab0421345abb520263d5dfa7ed042
20160902 18:56:37< irker066> wesnoth: Gregory A Lundberg wesnoth:master 2322a3e3a05b / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05 Separate finding the camp https://github.com/wesnoth/wesnoth/commit/2322a3e3a05bfb0acc614c6bcc35dbb7fa24c820
20160902 18:56:39< irker066> wesnoth: Gregory A Lundberg wesnoth:master 24e60e91e21b / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05 Let Urza Afala roam free! https://github.com/wesnoth/wesnoth/commit/24e60e91e21ba11746540d1cfac5aa926e30a1ed
20160902 18:56:41< irker066> wesnoth: Gregory A Lundberg wesnoth:master d6d01004a720 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05 Fix bug: Subsumed units can move https://github.com/wesnoth/wesnoth/commit/d6d01004a7202502bd0caa58d68c310c76ae14e7
20160902 18:56:43< irker066> wesnoth: Gregory A Lundberg wesnoth:master 0588ee1e3b99 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05 Hide bandit side after subsumed https://github.com/wesnoth/wesnoth/commit/0588ee1e3b99baaccd1718b4ed73dcdab9b0d65f
20160902 18:56:45< irker066> wesnoth: Gregory A Lundberg wesnoth:master 790a6508fcf7 / data/campaigns/The_South_Guard/scenarios/05_Choice_In_The_Fog.cfg: TSG S05 Mer follow Sir Gerrick https://github.com/wesnoth/wesnoth/commit/790a6508fcf7e6a5a8430a56331bff7c4b913a40
20160902 18:56:47< irker066> wesnoth: Gregory A Lundberg wesnoth:master 66a540c744af / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Fix bug: Deoran appears on the map https://github.com/wesnoth/wesnoth/commit/66a540c744af1da477386121498993a03cc5f750
20160902 18:56:49< irker066> wesnoth: Gregory A Lundberg wesnoth:master 233bc3f3df67 / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Fix bug: No elf for line https://github.com/wesnoth/wesnoth/commit/233bc3f3df67ba55ddde6f763330c06a2be38c4b
20160902 18:56:51< irker066> wesnoth: Gregory A Lundberg wesnoth:master 7fc2ac17a440 / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Fix bug: Target zone https://github.com/wesnoth/wesnoth/commit/7fc2ac17a4406ced0bc19450e6153731c6a1d689
20160902 18:56:53< irker066> wesnoth: Gregory A Lundberg wesnoth:master 0247b6244f71 / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Fix bug: Made-up words https://github.com/wesnoth/wesnoth/commit/0247b6244f71976cfe6514b56d1b49baadcc6644
20160902 18:56:55< irker066> wesnoth: Gregory A Lundberg wesnoth:master b46ff72fd485 / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Fix bug: Sir Gerrick is a leader https://github.com/wesnoth/wesnoth/commit/b46ff72fd4857428666290346b4940b51ba80064
20160902 18:56:57< irker066> wesnoth: Gregory A Lundberg wesnoth:master f9b1ecefa565 / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Fix bug: Units in poor shape https://github.com/wesnoth/wesnoth/commit/f9b1ecefa5650e48bb9a46cf5862ccf27704e45b
20160902 18:56:59< irker066> wesnoth: Gregory A Lundberg wesnoth:master fc6c5fa3ad23 / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Clean up objectives https://github.com/wesnoth/wesnoth/commit/fc6c5fa3ad236ed5a66cc8ba333ced9f92cff466
20160902 18:57:01< irker066> wesnoth: Gregory A Lundberg wesnoth:master 3817814aae7a / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Hide side https://github.com/wesnoth/wesnoth/commit/3817814aae7a2b3a418cbaf35e9aa82e88723b17
20160902 18:57:03< irker066> wesnoth: Gregory A Lundberg wesnoth:master c38378fdf98f / data/campaigns/The_South_Guard/scenarios/06a_Tidings_Good_and_Ill.cfg: TSG S06a Can recruit mermen https://github.com/wesnoth/wesnoth/commit/c38378fdf98fcbb6a188ab5cc7b208d6086f80e3
20160902 18:57:05< irker066> wesnoth: Gregory A Lundberg wesnoth:master 101c26810e17 / data/campaigns/The_South_Guard/scenarios/07a_Into_the_Depths.cfg: TSG S07a Fix bug: No deserters https://github.com/wesnoth/wesnoth/commit/101c26810e17bed89be78da212e3022fd12b6268
20160902 18:57:07< irker066> wesnoth: Gregory A Lundberg wesnoth:master c248ce97e03c / data/campaigns/The_South_Guard/scenarios/07a_Into_the_Depths.cfg: TSG S07a Fix bug: Where is 'here'? https://github.com/wesnoth/wesnoth/commit/c248ce97e03cfb8e170ab548f309a1323e1fbd39
20160902 18:57:09< irker066> wesnoth: Gregory A Lundberg wesnoth:master 64e152f29c06 / data/campaigns/The_South_Guard/scenarios/07a_Into_the_Depths.cfg: TSG S07a Hide unused Troll side on status panel https://github.com/wesnoth/wesnoth/commit/64e152f29c06eedd0cd8313bdd8615601161df0b
20160902 18:57:11< irker066> wesnoth: Gregory A Lundberg wesnoth:master c4d2ee85d63a / data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg: TSG S07b Note no turn limit https://github.com/wesnoth/wesnoth/commit/c4d2ee85d63a5ffc546c3c8f93ad6f3201edf315
20160902 18:57:13< irker066> wesnoth: Gregory A Lundberg wesnoth:master 051e27f8187c / data/campaigns/The_South_Guard/scenarios/07b_Pebbles_in_the_Flood.cfg: TSG S07b Fix bug: Wrong overlays https://github.com/wesnoth/wesnoth/commit/051e27f8187c988e6804c07238a5137c95a5a4ef
20160902 18:57:15< irker066> wesnoth: Gregory A Lundberg wesnoth:master 81da109a854a / data/campaigns/The_South_Guard/scenarios/08a_Return_to_Kerlath.cfg: TSG S08a Fix bug: Plynry may be dead https://github.com/wesnoth/wesnoth/commit/81da109a854afd626a6d856233a7c2a192f71467
20160902 18:57:17< irker066> wesnoth: Gregory A Lundberg wesnoth:master 023526d24be3 / data/campaigns/The_South_Guard/scenarios/08b_The_Tides_of_War.cfg: TSG S08b Fix bug: Hylas is no longer a hero https://github.com/wesnoth/wesnoth/commit/023526d24be322d7ac352516f4aae7da83216605
20160902 18:57:19< irker066> wesnoth: Gregory A Lundberg wesnoth:master 20f3799b5cab / data/campaigns/The_South_Guard/scenarios/08b_The_Tides_of_War.cfg: TSG S08b Ministers are loyal https://github.com/wesnoth/wesnoth/commit/20f3799b5caba3db8a84082815a25399a450152c
20160902 18:57:21< irker066> wesnoth: Gregory A Lundberg wesnoth:master 1c739341697e / data/campaigns/The_South_Guard/scenarios/09a_Vengeance.cfg: TSG S09a Fix bug: Sir Gerrick and Minister Hylas are loyal https://github.com/wesnoth/wesnoth/commit/1c739341697e295bd45ceb96b9084a3e1f7d0044
20160902 18:57:23< irker066> wesnoth: Gregory A Lundberg wesnoth:master 1368a287ef97 / data/campaigns/The_South_Guard/scenarios/09a_Vengeance.cfg: TSG S09a Fix bug: Warn about killing https://github.com/wesnoth/wesnoth/commit/1368a287ef97eec18acfc4de4460fbd500242b17
20160902 18:57:25< irker066> wesnoth: Gregory A Lundberg wesnoth:master 41246b155e5d / data/campaigns/The_South_Guard/scenarios/09a_Vengeance.cfg: TSG S09a Note no turn limit https://github.com/wesnoth/wesnoth/commit/41246b155e5d91cb26e013d5bc32bef0a457b30e
20160902 18:57:27< irker066> wesnoth: Gregory A Lundberg wesnoth:master c2270e5e3162 / data/campaigns/The_South_Guard/scenarios/04_Vale_of_Tears.cfg: TSG S04 Always give bodyguard https://github.com/wesnoth/wesnoth/commit/c2270e5e3162f361018429ba24f76d49940456ed
20160902 18:57:29< irker066> wesnoth: Lari Nieminen wesnoth:master f7d06f67c514 / data/campaigns/The_South_Guard/scenarios/ (12 files): Merge pull request #703 from GregoryLundberg/GL_TSG_fixes https://github.com/wesnoth/wesnoth/commit/f7d06f67c514cf2a5ebb347490b4ad4324f3fe68
20160902 18:57:34< celmin> When did the game potentially breaking come up...
20160902 18:57:58< vultraz> celmin: so what should I do.. do I need a argument-less constructor?
20160902 18:58:11< celmin> What?
20160902 18:58:13< JyrkiVesterinen> Well, it's what I thought we were supposed to prepare.
20160902 18:58:19< celmin> What are we talking about?
20160902 18:58:36< JyrkiVesterinen> It was just a silly remark anyway. Forget it.
20160902 18:59:04< vultraz> [05:53:07]	celmin	So you're not using the constructor initialization list for generator_data.
20160902 18:59:11< vultraz> you said this as if it were important
20160902 18:59:15< celmin> Whoa, the random map settings dialog was actually defined in the map generator file? :|
20160902 18:59:35< celmin> vultraz: Then followed it up with a remark suggesting the opposite. :P
20160902 18:59:41-!- travis-ci [~travis-ci@ec2-54-159-91-81.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 18:59:42< travis-ci> wesnoth/wesnoth#10676 (master - fa89aed : Jyrki Vesterinen): The build has errored.
20160902 18:59:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/157166396
20160902 18:59:42-!- travis-ci [~travis-ci@ec2-54-159-91-81.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 18:59:46< vultraz> yes it is
20160902 18:59:54< tad__> OK. I'm off .. wife has RL issues I need to commit and merge ..
20160902 18:59:56< vultraz> and ok, but then what would the problem be
20160902 19:00:20-!- tad__ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160902 19:01:24< celmin> Normally you should prefer using the constructor initialization list (the : a(), b(), c() syntax) in favour of assignments in the constructor body, because with the latter an object will first be default-constructed, then copy-assigned - thus, it could be less efficient for some types of objects. With integral types though as in generator_data, the default is to leave them uninitialized, so it doesn't really matter.
20160902 19:02:14< celmin> So line 31 etc of generator_settings.cpp is a problem?
20160902 19:02:36< vultraz> yes
20160902 19:04:09< celmin> Hmm.
20160902 19:05:08< celmin> I can see one reason why it would be a problem.
20160902 19:05:18< celmin> Where was register_integer defined, again? In dialog.hpp?
20160902 19:05:53< vultraz> yes
20160902 19:06:30< vultraz> (for the record, using a constructor initilization list for the struct doesn't fix the problem)
20160902 19:07:06< celmin> I wouldn't expect it to.
20160902 19:08:27-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160902 19:09:16< vultraz> still, it's probably something I should do anyway
20160902 19:09:45< irker066> wesnoth: Jyrki Vesterinen wesnoth:debug-multiplayer-test-failures c3220676d763 / / (5 files in 4 dirs): Much more aggressive logging in code related to plugin contexts between scenario https://github.com/wesnoth/wesnoth/commit/c3220676d76349cfdb2a50600fa4513ec6408179
20160902 19:09:58< JyrkiVesterinen> ^ Time to get the first data point.
20160902 19:14:12< celmin> Might be good to get Travis running the GUI2 version of the MP test too...
20160902 19:16:27< vultraz> probably
20160902 19:16:38< vultraz> all of jyrki's testing is on the gui1 ones :/
20160902 19:17:03< JyrkiVesterinen> They are the ones which have been causing all Travis builds to error for days...
20160902 19:17:11< celmin> Well, the GUI1 MP test is also not working though, and some of the problems might be related.
20160902 19:18:37< vultraz> true
20160902 19:19:26-!- Shiki [~Shiki@141.57.58.245] has joined #wesnoth-dev
20160902 19:19:48< zookeeper> what the actual... all of a sudden shroud has no transitions.
20160902 19:20:49< celmin> So vultraz, unfortunately I think you'll need to do one of the following: 1) Use ints instead of unsigned ints in generator_data; 2) Use the more complicated version of register_integer that takes get/set functions.
20160902 19:20:59< zookeeper> all because i happened to put in a [+game_config] tag.
20160902 19:21:08< celmin> Or 3) Add a version of register_integer that works on unsigned int.
20160902 19:21:31< vultraz> is there a reason I need them to be unsigned?
20160902 19:21:51< vultraz> (as far as I know the value of any is between 0 and 3000)
20160902 19:22:05< celmin> I'm not sure.
20160902 19:23:00< vultraz> it works if the type is int
20160902 19:23:56< vultraz> why is this?
20160902 19:24:08< celmin> What's the limits on iterations, width, height?
20160902 19:24:30< vultraz> 3000, 100, 100
20160902 19:24:36< celmin> vultraz: As to why, it's because references can only bind to the exact type - no conversions between different types of integer.
20160902 19:24:43< vultraz> (I have no idea why iterations == number of hills :| )
20160902 19:24:51< celmin> Does it?
20160902 19:24:59< celmin> Hmmm...
20160902 19:25:07< JyrkiVesterinen> Regarding my MP test debugging, here is the debug output between scenarios I get on my system, for reference: https://gist.github.com/jyrkive/92c08d22178d12b6df2b3f7423f52440
20160902 19:25:09< vultraz> yes
20160902 19:25:11< vultraz> const std::string& iterations_label = _("Number of hills:");
20160902 19:25:12< vultraz> in the gui1
20160902 19:25:19< celmin> default_width and default_height are also 100, 100?
20160902 19:25:55< vultraz> yeah
20160902 19:26:35< celmin> So it could be calculating (3000 * 100 * 100) / (100 * 100).
20160902 19:27:02< celmin> Max for an int is ~2 billion.
20160902 19:27:11< celmin> That's within range, right?
20160902 19:27:32< celmin> (At every step.)
20160902 19:27:40< vultraz> yeah
20160902 19:28:34< celmin> I have no idea what max_island and max_coastal are… but there's only multiplication by 50 there so I doubt it could be a problem.
20160902 19:29:21< celmin> Aaaand you didn't update the default_map_generator_job, so I can't really check the rest of the uses easily.
20160902 19:29:34< vultraz> i need to update that
20160902 19:29:36< vultraz> ues
20160902 19:29:37< vultraz> yes
20160902 19:29:42< vultraz> preferably before i push
20160902 19:29:53 * celmin was checking by searching your commit for "data_".
20160902 19:30:51< celmin> I think logically these fields should be unsigned (since it doesn't make sense for them to be negative), but it also seems unlikely that they require the additional range of an unsigned int.
20160902 19:31:30< celmin> (But if you change them to int, then variables they're assigned to in the map generator should also be int instead of size_t.)
20160902 19:33:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 19:38:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160902 19:40:04-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160902 19:43:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160902 19:43:07-!- wedge010 is now known as wedge009
20160902 19:48:55-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160902 19:50:25< JyrkiVesterinen> Travis build of my branch isn't very far. One GCC build is about 10 minutes in, other builds haven't even started.
20160902 19:51:00< JyrkiVesterinen> I'm not going to stay up late to debug. I'm going to bed. I'll investigate the data tomorrow, the builds will definitely be finished by then.
20160902 19:51:03-!- JyrkiVesterinen [~JyrkiVest@87-92-56-30.bb.dnainternet.fi] has quit [Quit: .]
20160902 20:19:29-!- travis-ci [~travis-ci@ec2-54-159-8-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 20:19:30< travis-ci> wesnoth/wesnoth#10680 (master - f7d06f6 : Lari Nieminen): The build has errored.
20160902 20:19:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/157177575
20160902 20:19:30-!- travis-ci [~travis-ci@ec2-54-159-8-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 20:23:03< vultraz> wonder if I should add one of those set_callback_value_changed functions to tslider
20160902 20:23:17< vultraz> as an alternative to connect_signal_notify_modified
20160902 20:25:51< celmin> What's the difference?
20160902 20:27:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 20:27:27< vultraz> latter is one of the functions that pushes a function to tdispatcher. Really not sure why some widgets manually fire events internally... 
20160902 20:27:36< vultraz> but i guess in this case that wouldn't work for a slider
20160902 20:27:39 * vultraz discards idea
20160902 20:28:44< celmin> I think the reason for some widgets to fire events internally is that they already handle an event but want to provide a hook for additional handling, or something. Not quite sure though.
20160902 20:29:00< celmin> Might be better for them to stop it.
20160902 20:29:20< celmin> And use connect_signal_notify_modified everywhere.
20160902 20:30:02< vultraz> only if tdispatcher is made easily lambda-compatible
20160902 20:30:25< celmin> Whoa, the stack trace seems to change as I switch stack frames… :|
20160902 20:30:48< celmin> Making tdispatcher lambda-compatible would probably mean using templates instead of std::function.
20160902 20:31:08< vultraz> (btw, N_ means...don't translate right?)
20160902 20:31:33< vultraz> trying to figure out what this does
20160902 20:31:34< vultraz> translation::gettext(data_.island_size == 0 ? N_("Inland") : (data_.island_size < max_coastal ? N_("Coastal") : N_("Island")))
20160902 20:31:42< celmin> Yes.
20160902 20:31:45< vultraz> don't translate.. but get a translation?
20160902 20:32:17< celmin> I think _() calls gettext directly.
20160902 20:32:42< celmin> Whereas N_() marks it as translatable (for the purpose of xgettext) but doesn't translate it immediately.
20160902 20:32:52< vultraz> (also can I use your plurals thing here)
20160902 20:33:08< celmin> So, an N_() string is basically one that will be translated later.
20160902 20:33:16< celmin> Why would you use my plurals thing there?
20160902 20:33:23< celmin> It doesn't seem like it applies.
20160902 20:33:49< vultraz> singular inland, plural coastal or island.
20160902 20:33:53< vultraz> guess that doesn't make sense..
20160902 20:33:56< celmin> Also, it's not my plurals thing.
20160902 20:33:56 * vultraz needs coffee
20160902 20:34:18< celmin> I only did the Lua implementation. The _n() macro has been part of gettext forever.
20160902 20:34:36< vultraz> anyway, why can't I just return the translated string directly?
20160902 20:34:54< vultraz> return data_.island_size == 0 ? _("Inland") : (data_.island_size < max_coastal ? _("Coastal") : _("Island"))
20160902 20:35:16< vultraz> (before this was used in a streingstream, mind you)
20160902 20:35:58< celmin> _n() should only be used for actual plurals, not anything that depends on number.
20160902 20:36:16< celmin> And you can probably do that and dispense with the gettext call, yeah.
20160902 20:36:33< celmin> Actually, _() calls the textdomain version of gettext.
20160902 20:36:40< celmin> What's the textdomain in that file?
20160902 20:36:48< celmin> And are there other translatable strings?
20160902 20:38:01< vultraz> wesnoth-lib
20160902 20:38:04< vultraz> and yes
20160902 20:38:39< celmin> Using _() might actually be a translation bugfix then.
20160902 20:39:01< celmin> Since I think translation::gettext() always looks in the default textdomain, which is probably "wesnoth".
20160902 20:39:21< celmin> Which would mean that it was looking them up in the wrong textdomain.
20160902 20:40:04< celmin> Why are you crashing. :|
20160902 20:40:31< vultraz> I am not crashing :P
20160902 20:40:36< celmin> :P
20160902 20:40:54< celmin> Well, time to take a break I guess.
20160902 20:41:26< celmin> (Doesn't help that the stack trace is incomprehensible.)
20160902 20:41:55< vultraz> trying to figure out the best method for getting/setting the label suffixes..
20160902 20:42:40< vultraz> really don't like what I've come up with :|
20160902 20:42:47< celmin> Oh?
20160902 20:42:51 * vultraz really needs to refactor tslider
20160902 20:43:16< vultraz> http://pastebin.com/NJfFBbHp
20160902 20:43:18< vultraz> :|
20160902 20:43:23< vultraz> i
20160902 20:43:33< vultraz> need to rework this
20160902 20:44:10< vultraz> damn not being able to use auto for argument types :(
20160902 20:44:39-!- Shiki [~Shiki@141.57.58.245] has quit [Quit: Verlassend]
20160902 20:45:42< vultraz> or maybe i could use a template..?
20160902 20:45:55< vultraz> no, it's a function call
20160902 20:45:57< vultraz> *sigh*
20160902 20:46:01< vultraz> guess I'll overload
20160902 20:47:05-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160902 20:47:30< vultraz> oh wait, I don't want a suffix for the landform thing..
20160902 20:47:37< vultraz> I want a whole label..
20160902 20:47:39< vultraz> :|
20160902 20:48:03< vultraz> but I cannot use the set_value_labels thing in tslider since this is for a range not 1-1 correlation... :|
20160902 20:48:12 * vultraz groans
20160902 20:48:17< vultraz> COFFEE WHERE ART THOU
20160902 20:49:07< celmin> I don't really get what you're getting at.
20160902 20:49:33< vultraz> headache
20160902 20:49:35< vultraz> is what
20160902 20:49:49< vultraz> tslider isn't smart enough
20160902 20:50:19< celmin> Forgot I closed Firefox to downgrade it, so your paste is still loading.
20160902 20:50:34< vultraz> *downgrade*??
20160902 20:50:48< celmin> Yeah
20160902 20:51:46< celmin> Not sure what I'm supposed to look at in the paste.
20160902 20:51:46-!- fabi [~fabi@176.0.57.109] has quit [Ping timeout: 255 seconds]
20160902 20:51:57< vultraz> nothing really
20160902 20:52:19< celmin> Where did you want auto argument types?
20160902 20:52:25< celmin> Usually the solution to that is a template.
20160902 20:53:07< vultraz> i was thinking i could auto the third argument so then i could pass either a string or func
20160902 20:53:14< vultraz> but then i realized the func would need to be called
20160902 20:53:18< vultraz> so i cannot do that
20160902 20:53:39< celmin> I guess you need an overload then.
20160902 20:56:31< vultraz> yes
20160902 20:56:34< vultraz> it's very sad :(
20160902 20:56:42< vultraz> overloading for a 1-line difference
20160902 20:57:06< vultraz> i have another idea though
20160902 20:57:13< celmin> What's the string you're passing?
20160902 20:57:20< celmin> Is it a member of an object?
20160902 20:57:26< vultraz> no
20160902 20:57:36< vultraz> "/1000 tiles"
20160902 20:57:43< celmin> Ah.
20160902 20:57:46< celmin> (Why the slash?)
20160902 20:57:53< vultraz> because it's
20160902 20:58:00< vultraz> '$value/1000 tiles'
20160902 20:58:15< vultraz> i suppose i could make that a separate label...
20160902 20:58:25< celmin> What's $value?
20160902 20:58:31< vultraz> slider value
20160902 20:58:49< celmin> Is it actually $value or was that only illlustrative?
20160902 20:58:56< vultraz> latter
20160902 21:01:48-!- travis-ci [~travis-ci@ec2-54-145-84-169.compute-1.amazonaws.com] has joined #wesnoth-dev
20160902 21:01:49< travis-ci> wesnoth/wesnoth#10681 (debug-multiplayer-test-failures - c322067 : Jyrki Vesterinen): The build has errored.
20160902 21:01:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/157180626
20160902 21:01:49-!- travis-ci [~travis-ci@ec2-54-145-84-169.compute-1.amazonaws.com] has left #wesnoth-dev []
20160902 21:07:40< vultraz> celmin: ok, I have an idea
20160902 21:07:44< vultraz> dunno if it'll work..
20160902 21:08:04< vultraz> I'd pass the function to be bound to the widget itself
20160902 21:08:36< vultraz> since there'd be different functions, it'd be different arguments...
20160902 21:10:16-!- mjs-de [~mjs-de@x4db5144b.dyn.telefonica.de] has joined #wesnoth-dev
20160902 21:24:50-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160902 21:27:44< tad_> Some time ago I asked about an issue with side_team_name. I was thinking I'd take a while away from WML and try a little C++ .. so the issue is how side_team_name is initialized vs loaded from a scenario-start .. and I'm wondering if you can save me time searching and point me to the general area where the work appears in the C++
20160902 21:33:20< vultraz> uhh
20160902 21:33:22< vultraz> team.cpp maybe?
20160902 21:33:44< celmin> Or the team builder maybe?
20160902 21:33:46< celmin> I'm not really sure.
20160902 21:33:59-!- Shiki [~Shiki@141.57.58.245] has joined #wesnoth-dev
20160902 21:34:56< tad_> OK. I'll dig. The specific issue: it uses the first [side] for all [side]s when you play into the scenario but if you load from the start/save it uses each [side] separately.
20160902 21:35:19< vultraz> im not sure what you mean
20160902 21:36:40< tad_> When I play TSG and End Scenario from S03 and Menu|Status Table at start of S04 it shows the same name (Undead) for both side 2 and side 3. Reload using Load from title screen and it properly shows 'Bandits' for side 3
20160902 21:37:00< celmin> I vaguely remember this issue from before.
20160902 21:37:03< tad_> In TSG this is the only place. In DM it's going to happen a lot.
20160902 21:37:31< celmin> user_team_name, not side_team_name, right?
20160902 21:37:45< tad_> Probably.
20160902 21:38:45< tad_> Yeah .. user_team_name .. I grep'd for that and said it wrong here. sugh
20160902 21:38:48< tad_> sigh even
20160902 21:39:02-!- Shiki [~Shiki@141.57.58.245] has quit [Quit: Verlassend]
20160902 21:44:32-!- Appleman1234 [~Appleman1@KD119104104134.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20160902 21:45:32-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160902 21:46:24< vultraz> [08:34:55]	tad_	OK. I'll dig. The specific issue: it uses the first [side] for all [side]s 
20160902 21:46:35< vultraz> sounds like that's the problem behavior?
20160902 21:46:41< vultraz> and the on-load behavior is correct?
20160902 21:47:14< tad_> vultraz: yes, when using Load it is correct.
20160902 21:48:40-!- EliDupree [~quassel@idupree.com] has quit [Ping timeout: 258 seconds]
20160902 21:50:02< vultraz> celmin: ok, I have a better solution
20160902 21:50:25< vultraz> I'll add a method to tslider to show the value somewhere
20160902 21:50:48< vultraz> since this is behavior that's useful in multiple places
20160902 21:52:01< celmin> vultraz: I think the register_field mechanism can be used, right?
20160902 21:52:08< vultraz> hm?
20160902 21:53:26< celmin> To get a slider to display its value.
20160902 21:53:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160902 21:53:40< vultraz> there's no such mechanism currently implemented
20160902 21:53:52< celmin> Are you sure?
20160902 21:53:59< celmin> Not in tslider certainly.
20160902 21:54:08< vultraz> hmm...
20160902 21:54:10< tad_> In team.cpp I see init to empty, read from save, write to save, and change but I don't see loading from .cfg .. guessing I'm in the right area.
20160902 21:54:24< vultraz> the long form of register_integer has a save function argument
20160902 21:54:28< vultraz> that could be used, maybe...
20160902 21:54:37-!- EliDupree [~quassel@idupree.com] has joined #wesnoth-dev
20160902 21:54:52< celmin> Or register_label.
20160902 21:54:57< vultraz> how would that work?
20160902 21:55:07< celmin> Ah, but there's no long form of it...
20160902 21:55:10-!- mjs-de [~mjs-de@x4db5144b.dyn.telefonica.de] has quit [Remote host closed the connection]
20160902 21:55:10< vultraz> there's nothing that changes it
20160902 21:55:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160902 21:56:24< vultraz> but see, the long_form of register_integer gets a value from a function
20160902 21:56:28< vultraz> we have references :|
20160902 21:57:31< vultraz> wait, an idea has formed
20160902 21:58:26< celmin> But the long form of register_integer still calls set_value() rather than set_label().
20160902 21:58:39-!- abruanese [~a@45.63.97.181] has quit [Quit: ZNC 1.6.3+deb1 - http://znc.in]
20160902 21:58:52< celmin> I think a long form of register_label could work though.
20160902 21:58:54< vultraz> hm?
20160902 21:59:30< celmin> But, not sure how much work that would be...
20160902 21:59:57< vultraz> set_value?
20160902 22:00:01< vultraz> what are you talking of
20160902 22:00:06< vultraz> oh
20160902 22:00:08< vultraz> I see
20160902 22:00:13< celmin> The function it calls to set the value of the linked widget.
20160902 22:00:16< vultraz> you mean when it's loaded it sets the 
20160902 22:00:18< vultraz> yes
20160902 22:00:19< vultraz> that
20160902 22:00:53< vultraz> well that's fine..
20160902 22:00:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160902 22:01:14< vultraz> but then how do we set the value
20160902 22:01:19< vultraz> of the label
20160902 22:01:43< celmin> Well, that's why I thought using the long form of register_label, but it looks like that doesn't exist.
20160902 22:04:49< vultraz> tfield_integer isn't even implemented like the other ones..
20160902 22:06:15< celmin> Huh, I thought tnetwork_transmission was used in the addons client...
20160902 22:06:31< celmin> vultraz: What do you mean?
20160902 22:06:45< vultraz> I can't find its implementation
20160902 22:07:02-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Ping timeout: 264 seconds]
20160902 22:07:49< celmin> It's probably not specialized.
20160902 22:08:02< celmin> So its implementation is the parts that don't have <> in front of tfield.
20160902 22:08:30< celmin> ie, if it's tfield<something>::whatever, then it's not applicable to tfield_integer, but if it's just tfield::whatever, then it is applicable.
20160902 22:08:41< vultraz> I see
20160902 22:08:55-!- prkc [~prkc@192.40.89.18] has quit [Ping timeout: 252 seconds]
20160902 22:10:14-!- irker066 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160902 22:12:16-!- abruanese [~a@45.63.97.181] has joined #wesnoth-dev
20160902 22:20:36< zookeeper> are the current scenario editor features actually useful for anyone, or should they be removed for 1.14 as to stop confusing newbies?
20160902 22:21:25< celmin> I have no idea. I do think stripping out features is not a great idea in general though.
20160902 22:21:38< celmin> Then again, if they're buggy and unmaintained, I'm not against it.
20160902 22:21:46< celmin> But in that case I'd prefer it to be done as late as possible.
20160902 22:22:23-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160902 22:25:03-!- prkc [~prkc@catv-80-98-160-168.catv.broadband.hu] has joined #wesnoth-dev
20160902 22:32:56< vultraz> blah
20160902 22:32:59< vultraz> i dunno what to do here
20160902 22:33:29< celmin> Thinking of removing tnetwork_transmission altogether and add an optional progress bar to the loading screen.
20160902 22:33:43< celmin> Which would appear when uploading or downloading addons.
20160902 22:33:53< celmin> ^adding
20160902 22:35:32< celmin> …I guess I'll have to download an addon to test that, huh.
20160902 22:41:02< vultraz> blah
20160902 22:41:06-!- Appleman1234 [~Appleman1@KD119104108200.au-net.ne.jp] has joined #wesnoth-dev
20160902 22:41:08< vultraz> i'll just get it working forn ow
20160902 22:41:25< vultraz> then worry about an implementation
20160902 22:41:31< vultraz> of bound labels
20160902 22:44:32< vultraz> basically what we need is a function... that takes a label
20160902 22:44:34< vultraz> a function
20160902 22:44:36< vultraz> and a source
20160902 22:44:42< vultraz> if the source changes, the label is set
20160902 22:44:57< vultraz> but now how would one monitor the source
20160902 22:45:08< vultraz> do we have a event monitor
20160902 22:46:18< vultraz> such a thing is different from the way we do callbacks now..
20160902 22:47:20< vultraz> an alternative would be a wrapper around a setter..
20160902 22:48:04< vultraz> celmin: ot, but I've removed the link between player numbers and map size
20160902 22:48:26< celmin> How did the link actually work?
20160902 22:49:02< vultraz> so the min of width and height was calculated like so:
20160902 22:49:05< vultraz> min_width+(players_slider.value()-2)*extra_size_per_player
20160902 22:49:13< vultraz> min_width is 20, as was min_height
20160902 22:49:23< vultraz> min player value is 2
20160902 22:49:25< celmin> That seems reasonable though.
20160902 22:49:34< vultraz> extra size is 2
20160902 22:49:59< vultraz> so... 9 players would give you a min of...34
20160902 22:50:04< celmin> I noticed that the map generator forces even width BTW.
20160902 22:50:15< celmin> I don't see a problem with 34.
20160902 22:50:21< vultraz> there isn't
20160902 22:50:32< vultraz> it just seems a weirdly arbitrary thing to have 
20160902 22:51:05< celmin> I think it's sort of a sanity check type thing to try to ensure that there's really enough room on the map for that many players. (I dunno how well it actually works.)
20160902 22:51:17< vultraz> especially confusing for someone if a minimum keeps changing
20160902 22:52:45< celmin> What's confusing about that?
20160902 22:53:07< celmin> Hopefully you would only notice if you were actually at the minimum, anyway.
20160902 22:53:13< vultraz> because there's absolutely no indication it's a thing
20160902 22:53:23< celmin> You could add an indication that it's a thing.
20160902 22:53:33< vultraz> is it worth it?
20160902 22:53:45< celmin> I don't know. Can 9 players fit comfortably on a 20x20 map?
20160902 22:53:55< celmin> (Is 9 the max players?)
20160902 22:54:11< vultraz> hmmm
20160902 22:54:17< vultraz> "no valid castle location found"
20160902 22:54:49< vultraz> maybe i should implement it after all..
20160902 22:59:25< vultraz> weird ridiculous part of the tfield system...
20160902 22:59:31< vultraz> you can get the underlying widget...
20160902 22:59:38< vultraz> but only if it's tcontrol :|
20160902 23:00:45< celmin> It always is.
20160902 23:01:30< vultraz> a slider?
20160902 23:02:22< vultraz> hmm..
20160902 23:02:39< celmin> No, I mean fields only ever link to controls.
20160902 23:10:18< vultraz> wow this works 
20160902 23:10:20< vultraz> 	tslider* w = dynamic_cast<tslider*>(width_->widget());
20160902 23:10:21< vultraz> 	w->set_minimum_value(w->get_minimum_value() + extra_size);
20160902 23:10:41< vultraz> praise the mighty dynamic_cast
20160902 23:11:12< celmin> Don't do that.
20160902 23:11:21< vultraz> hm?
20160902 23:11:30< celmin> dynamic_cast may return nullptr.
20160902 23:11:47< vultraz> impossible
20160902 23:11:48< celmin> Since it's a highly unlikely event though, I'd suggest casting it to a reference instead of a pointer.
20160902 23:12:05< celmin> Then it would throw an exception instead if it's not a tslider.
20160902 23:12:35< vultraz> wait
20160902 23:12:37< celmin> So, tslider& w = dynamic_cast<tslider&>(*width_->widget())
20160902 23:12:41< vultraz> do you mean
20160902 23:12:42< vultraz> oh
20160902 23:12:52< celmin> Is that what you thought I meant?
20160902 23:13:07< celmin> Though, I suppose if widget() returned nullptr that could still be a problem, but whatever.
20160902 23:13:11< vultraz> i got the syntax wrong but yeah
20160902 23:13:35< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\dialogs\generator_settings.cpp|93|error: cannot dynamic_cast '((gui2::tgenerator_settings*)this)->gui2::tgenerator_settings::width_->gui2::tfield<int, gui2::tinteger_selector_>::<anonymous>.gui2::tfield_::widget()' (of type 'class gui2::tcontrol*') to type 'class gui2::tslider&' (source is not of class type)|
20160902 23:13:44< vultraz> I guess I need..
20160902 23:13:53< vultraz> *width_widget()
20160902 23:13:56< vultraz> ->*
20160902 23:14:03< vultraz> wait no
20160902 23:14:05< vultraz> what am I saying
20160902 23:14:09< vultraz> hm
20160902 23:14:40< vultraz> no, that does work
20160902 23:14:42< vultraz> huh
20160902 23:15:12< celmin> Yeah, you can't cast a reference to a pointer or a pointer to a reference.
20160902 23:15:25< celmin> Only ref-to-ref or ptr-to-ptr
20160902 23:15:26< vultraz> i thought you could only d_c on pointers
20160902 23:15:29< vultraz> to pointers
20160902 23:15:49< celmin> dynamic_cast can do ref-to-ref or ptr-to-ptr, but the semantics are different in the event that the cast is bad.
20160902 23:16:03< vultraz> I see
20160902 23:16:06< celmin> With pointers, it returns nullptr, but with references, it throws an exception.
20160902 23:16:35< celmin> Since you're pretty confident that the case won't be bad, feel free to ignore the exception.
20160902 23:16:37< celmin> ^cast
20160902 23:18:43< vultraz> blah
20160902 23:18:45< vultraz> assertions
20160902 23:20:02< vultraz> 	/** @todo maybe make it a VALIDATE. */
20160902 23:20:03< vultraz> 	assert(minimum_value <= get_maximum_value());
20160902 23:20:07< vultraz> verymuch so should be VALIDATE
20160902 23:20:24< celmin> Sure.
20160902 23:20:33< celmin> VALIDATE works basically the same as assert.
20160902 23:20:49< celmin> You just do VALIDATE(condition, message) rather than assert(condition && message)
20160902 23:21:00< vultraz> i am aware
20160902 23:21:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160902 23:21:19< celmin> Speaking of which, more Wesnoth asserts should probably do that (including a message).
20160902 23:21:34< vultraz> heh
20160902 23:21:41< vultraz> setting a widget's min size totally breaks it
20160902 23:22:07< celmin> Min size?
20160902 23:22:56< vultraz> yes, if i set the min value now it treats that as the max ... but if you move it it gets stuck at the old max
20160902 23:22:58< vultraz> sigh
20160902 23:23:28< vultraz> eh
20160902 23:23:30< vultraz> hm
20160902 23:23:33< vultraz> maybe it's an issue with me
20160902 23:24:01< vultraz> no, it still breaks shit
20160902 23:24:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160902 23:25:01< celmin> Oh, min value.
20160902 23:25:19< vultraz> as soon as players is past 7 shit breaks...
20160902 23:26:56< vultraz> yeah this doesn't work properly at all
20160902 23:27:00< vultraz> extremely broken
20160902 23:27:34 * vultraz curses
20160902 23:28:16< vultraz> can someone tell me why mordante thought it was a good idea to make sliders a type of scrollbar
20160902 23:28:33< celmin> Because they're almost identical behaviour?
20160902 23:30:59< vultraz> but sliders need different behavior
20160902 23:31:36< vultraz> not to mention this: https://gna.org/bugs/index.php?24531
20160902 23:32:44< vultraz> hmmm
20160902 23:32:49< celmin> What's the different behaviour? Just snap-to-valid?
20160902 23:32:58< celmin> Or is there something else too?
20160902 23:32:58< vultraz> ok, I think there was a small logic problem here
20160902 23:33:01< vultraz> celmin: yes
20160902 23:33:33< vultraz> ok
20160902 23:33:36< vultraz> i got it working...
20160902 23:33:42< vultraz> but... the slider snaps to end
20160902 23:34:43< vultraz> let's try removing some lines
20160902 23:36:16< vultraz> ok
20160902 23:36:36< vultraz> removing this line works: set_item_position(minimum_value_ + value);
20160902 23:37:33< vultraz> wonder if i should do that
20160902 23:38:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160902 23:39:13< vultraz> yeah, I think that should be removed
20160902 23:39:29< vultraz> the slider updates to its new position fine
20160902 23:40:13< celmin> Um.
20160902 23:40:22< celmin> What is "value"?
20160902 23:40:44< celmin> Is that the current integral value of the slider, or more like an index into the valid values the slider can take?
20160902 23:41:19< celmin> If the former, try set_item_position(value) maybe?
20160902 23:41:25< celmin> Though that might simply be redundant.
20160902 23:41:27< vultraz> former, I think
20160902 23:41:57< celmin> Oh, right, you probably do need to set the item position though.
20160902 23:42:04< celmin> You don't want value < minimum_value_
20160902 23:42:20< vultraz> there's a check for that 
20160902 23:42:31< vultraz> this is what it was doing
20160902 23:42:35< vultraz> 	if(value < minimum_value_) {
20160902 23:42:37< vultraz> 		set_item_position(0);
20160902 23:42:38< vultraz> 	} else {
20160902 23:42:40< vultraz> 		set_item_position(minimum_value_ + value);
20160902 23:42:41< celmin> Ah, okay.
20160902 23:42:41< vultraz> 	}
20160902 23:43:17< celmin> So yeah, I guess it seems unnecessary.
20160902 23:43:32-!- edgrey [~edgrey@178.204.42.100] has quit [Ping timeout: 244 seconds]
20160902 23:43:43< vultraz> hmm... this is odd.. only the width slider is updating..
20160902 23:43:54< vultraz> ph dug
20160902 23:43:56< vultraz> wrong field
20160902 23:43:58< vultraz> oh duh*
20160902 23:45:16< vultraz> ok... only one more issue
20160902 23:45:24< vultraz> the labels don't update 
20160902 23:45:26< vultraz> blah
20160902 23:45:33< vultraz> i guess a modified event wasn't issued
20160902 23:48:38< vultraz> guess i can manually call the callback
20160902 23:51:20< vultraz> ok, we're good
20160902 23:51:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160902 23:53:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
--- Log closed Sat Sep 03 00:00:10 2016