--- Log opened Thu Sep 08 00:00:26 2016
--- Day changed Thu Sep 08 2016
20160908 00:00:26< vultraz> I can see simple fix, but...
20160908 00:00:29< vultraz> I don't like it :|
20160908 00:00:46< vultraz> eh, wait
20160908 00:00:50< vultraz> that wouldn't work
20160908 00:00:58< celmin> ?
20160908 00:02:17< mattsc> vultraz: I’m back and have done a test with a unit that also has non-disabled weapons.
20160908 00:02:24< mattsc> It works just fine in that case.
20160908 00:02:46< vultraz> oh, geez
20160908 00:02:52< vultraz> sorry, mattsc, i got distracted
20160908 00:03:09< vultraz> by other stuff
20160908 00:03:12< mattsc> no worries; I’m just telling you that you fixed the bug I had found.
20160908 00:03:24< mattsc> You introduced another one in the process, but I bet you can handle that one too  :)
20160908 00:03:31< celmin> I don't see any template errors left. o.o
20160908 00:03:38< celmin> Unless that tuple one is one.
20160908 00:03:48< mattsc> [FYI, there’s a typo in the comment above your fix, so when you fix the crash for no enabled weapons, you could fix that one too)
20160908 00:03:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160908 00:03:55< celmin> Blargh, 'tis
20160908 00:04:36< mattsc> vultraz: question: do you know how fast/slow the get_special_bool("disable") you are using is?
20160908 00:04:45< vultraz> I do not
20160908 00:04:50< mattsc> I’m asking because I need to do something like that for fixing the AI bug
20160908 00:04:53< vultraz> I just took a look at the gui1 code and saw that
20160908 00:05:14< mattsc> and I need something that is fast for that, as it will be called for every unit with only one attack for every attack calculation ...
20160908 00:05:33-!- travis-ci [~travis-ci@ec2-54-159-31-87.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 00:05:34< travis-ci> wesnoth/wesnoth#10760 (master - 276047c : Charles Dang): The build is still failing.
20160908 00:05:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158318129
20160908 00:05:34-!- travis-ci [~travis-ci@ec2-54-159-31-87.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 00:05:56< mattsc> Okay, I’ll do some timing tests then
20160908 00:06:23< mattsc> I’m sure it is faster than a full attack simulation, which is the method how it is accessed in other parts of the AI code.
20160908 00:08:06< celmin> Fixed by changing simple bind to fugly lambda.
20160908 00:11:57< irker744> wesnoth: Charles Dang wesnoth:master a0453ad5d711 / src/mouse_events.cpp: Don't show Attack dialog if all attacker weapons are disabled https://github.com/wesnoth/wesnoth/commit/a0453ad5d711cb5374b1bb4ffd8288cf5a128bb2
20160908 00:11:59< vultraz> mattsc: ^ please test
20160908 00:12:25< celmin> That's kinda ugly, but I guess it'll work.
20160908 00:13:34< celmin> But why the heck is it (*attacker).attacks instead of attacker->attacks?
20160908 00:13:51< vultraz> does it mater?
20160908 00:13:57< celmin> Not really.
20160908 00:14:10< celmin> I prefer the arrow, personally.
20160908 00:15:29< celmin> Down to a mere five errors! \o/
20160908 00:15:44< celmin> Someone made unhandled enum value an error, huh.
20160908 00:15:55< celmin> Or am I compiling with -Werror?
20160908 00:17:33< vultraz> for the record, do we still need bind_void?
20160908 00:18:21< vultraz> the three usecases of it seem to build fine with std::bind
20160908 00:18:49< celmin> It might be an issue only on some compilers.
20160908 00:18:55< celmin> So, don't remove it.
20160908 00:19:10-!- Bonobo [~Bonobo@2001:44b8:254:3200:692d:9968:f549:2f48] has joined #wesnoth-dev
20160908 00:19:17< vultraz> can we at least test?
20160908 00:22:43< celmin> I don't really think it's worth it.
20160908 00:29:55< mattsc> vultraz: yay!  The all-weapons-disabled case works now, no more crash
20160908 00:30:08< mattsc> I’ll check a couple other things quickly too ...
20160908 00:30:12< vultraz> mattsc: and it displays the popup?
20160908 00:30:40< mattsc> It displayes the same pop-up as when you try to attack with a Boar or another unit that has no weapon.
20160908 00:30:51< mattsc> Boar?
20160908 00:31:02< mattsc> Do we have boar units?  Other than tuskers?
20160908 00:31:08< mattsc> I meant: boat.
20160908 00:32:14< vultraz> :D
20160908 00:32:44< vultraz> random suggestion: give boats a Ram attack with a special that reduces their HP by 1/3 of the damage dealt per successful hit
20160908 00:33:29< celmin> Do we have tuskers?
20160908 00:33:38< vultraz> dunn[
20160908 00:33:41< vultraz> dunno
20160908 00:33:59< celmin> Oh, it was an AI routine, right.
20160908 00:34:49< mattsc> vultraz: it almost works perfectly, but not quite
20160908 00:35:14< vultraz> oh?
20160908 00:35:18< mattsc> test case 1: single attack, weapon always disabled -> no attacks dialog, all good
20160908 00:35:45< mattsc> test case 2: 3 attacks: first always disabled, second disabled against grunts, 3rd always enabled
20160908 00:36:06< mattsc> this one shows one attack against grunts, and two against other units: all good
20160908 00:36:29< mattsc> test case 3: two attacks: first always disabled, second disabled against grunts
20160908 00:36:49< mattsc> this test case shows no attacks whether it’s against grunts or not; so that’s not good
20160908 00:37:00< mattsc> [trying to do thorough testing here …]
20160908 00:37:15< vultraz> hmm
20160908 00:37:35< mattsc> vultraz: I’ll have to be afk again, will be back later; thanks for the help so far
20160908 00:38:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 00:39:01< vultraz> I can see why that would happen
20160908 00:39:07< celmin> I think I have a vague idea of why it would happen.
20160908 00:39:10< vultraz> dunno a good way to fix it, though
20160908 00:39:14< celmin> But I can't remember off the top of my head.
20160908 00:39:15< vultraz> the battle context isn't considered
20160908 00:39:20< vultraz> just whether it has a special..
20160908 00:39:37< celmin> I think there's a function in attack to set the context possibly?
20160908 00:39:37< vultraz> in the dialog, it does consider the context
20160908 00:40:07< vultraz> i should probably move this to an execute function..
20160908 00:40:13< vultraz> evaluate the data and pass it to the dialog
20160908 00:42:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160908 00:44:20-!- ancestral [~ancestral@225.sub-174-219-6.myvzw.com] has joined #wesnoth-dev
20160908 00:46:35-!- travis-ci [~travis-ci@ec2-54-159-31-87.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 00:46:36< travis-ci> wesnoth/wesnoth#10761 (master - a0453ad : Charles Dang): The build is still failing.
20160908 00:46:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158324215
20160908 00:46:36-!- travis-ci [~travis-ci@ec2-54-159-31-87.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 00:47:07< vultraz> I'm not sure I fully understand the code, though
20160908 00:51:14< vultraz> celmin: is boost::dynamic_bitset different from std::bitset
20160908 00:51:21< celmin> Yes.
20160908 00:51:23< celmin> Why?
20160908 00:51:41< celmin> std::bitset is to boost::dynamic_bitset as std::array is to std::vector.
20160908 00:52:37< vultraz> i see
20160908 01:00:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160908 01:03:44< celmin> Not sure how to deal with the reload option here, so I'm just going to ignore it. gfgtdf or someone can feel free to reimplement it later.
20160908 01:04:03< gfgtdf> celmin: which reload option you mean ?
20160908 01:04:18< celmin> should_reload in the title screen loop.
20160908 01:06:02< celmin> If I read this right, it doesn't reload if you start the tutorial or a campaign?
20160908 01:06:56-!- ancestral [~ancestral@225.sub-174-219-6.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160908 01:18:35< vultraz> this is harder than I thought
20160908 01:22:04< celmin> Still working on the disabled attacks thing?
20160908 01:22:29< vultraz> yes
20160908 01:24:13-!- gfgtdf_ [~chatzilla@x4e3697bb.dyn.telefonica.de] has joined #wesnoth-dev
20160908 01:25:30< irker744> wesnoth: Charles Dang wesnoth:master 8c270f908173 / src/mouse_events.cpp: Slightly hacky attempt to make disabled weapons check context-aware https://github.com/wesnoth/wesnoth/commit/8c270f908173aefaf049311b42ab87a887d3e8f3
20160908 01:25:32< vultraz> mattsc: ^
20160908 01:26:25-!- gfgtdf [~chatzilla@x4e36aca5.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20160908 01:26:37-!- gfgtdf_ is now known as gfgtdf
20160908 01:28:22< gfgtdf> hmm no ida why it does that shoudl_reload stuff, usualyl the game_config_manager calss shodul atomaticalls skip reloacing if we already have the correct config loaded.
20160908 01:31:41< irker744> wesnoth: Charles Dang wesnoth:master 84de6bafb105 / src/gui/dialogs/unit_attack.cpp: Unit Attack: minor cleanup https://github.com/wesnoth/wesnoth/commit/84de6bafb105169cd3a79b6182e1fef0fce3f736
20160908 01:34:07-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160908 01:34:10< mattsc> vultraz: 8c270f9 works for all test cases I tried  :)
20160908 01:34:20< vultraz> :D
20160908 01:34:23< vultraz> awesome
20160908 01:34:24< mattsc> Do I need to test it again with 84de6?
20160908 01:34:29< vultraz> no
20160908 01:34:37< vultraz> that's code cleanup only
20160908 01:34:38< mattsc> okay, cool
20160908 01:34:49< mattsc> Thanks.
20160908 01:35:09< vultraz> glad it's fixed
20160908 01:38:26< irker744> wesnoth: Charles Dang wesnoth:master 6aee1082983d / src/ (4 files in 3 dirs): loadgame: replaced individual flag getters with data struct getter https://github.com/wesnoth/wesnoth/commit/6aee1082983d4f34ca3fc5e0625d31c90ac912c4
20160908 01:42:50< vultraz> this load_game_exception thing is evil :|
20160908 01:44:27< vultraz> evil, I say!
20160908 01:44:58< celmin> Note, "code cleanup only" is a slight oxymoron.
20160908 01:45:13< celmin> In the general case it's very likely to introduce bugs.
20160908 01:46:05< vultraz> it keeps static data members that get manipulated by various areas of the code..
20160908 01:47:07< celmin> 26 additions and 46 deletions. That's not all that minor a cleanup.
20160908 01:47:32< celmin> And from the diff it looks like a significant rewrite.
20160908 01:47:35< vultraz> it's actually just merging two functions
20160908 01:47:42< celmin> I see.
20160908 01:47:48< vultraz> the majority of pre_show was in a static function
20160908 01:47:51< vultraz> i merged them
20160908 01:47:56< vultraz> also deleted an unused function
20160908 01:48:15< celmin> 6aee10829 is pointless
20160908 01:48:21< celmin> I'd even argue it's slightly bad
20160908 01:48:36< vultraz> it allows access to the rest of the data
20160908 01:48:42< celmin> Uhuh.
20160908 01:48:47< vultraz> without individual getter functions
20160908 01:48:50< vultraz> needed to be added
20160908 01:48:55< vultraz> needing
20160908 01:49:28< celmin> And it exposes internal class details.
20160908 01:49:45< vultraz> that's why it's const
20160908 01:51:41< celmin> Still bleh
20160908 01:52:38< vultraz> bool game_launcher::is_loading() const
20160908 01:52:40< vultraz> {
20160908 01:52:41< vultraz> 	return !game::load_game_exception::game.empty();
20160908 01:52:43< vultraz> }
20160908 01:52:44 * vultraz grimaces
20160908 01:52:58< celmin> Well, it's linking.
20160908 01:53:23< celmin> So there's some good news.
20160908 01:54:17< vultraz> let's see, what throws this godforsaken exception
20160908 01:54:23< vultraz> two places
20160908 01:54:48< celmin> If you're refactoring that it may end up conflicting with titlescreen.
20160908 01:55:03< vultraz> I'm just looking for now
20160908 01:55:14< celmin> Ooh, link error.
20160908 01:55:16< vultraz> I'm expecting a huge push from you within the hour.
20160908 01:55:32< celmin> Heh...
20160908 01:55:41< celmin> Well, supper is like, now, so it might be a bit longer.
20160908 01:58:18< vultraz> this is even more evil: load_game_exception is caught and then another, unnamed exception is thrown :|
20160908 01:58:27< celmin> Unnamed?
20160908 01:58:37< vultraz> well, maybe wrong term
20160908 01:58:40< vultraz> it's just 'throw;'
20160908 01:58:45< celmin> Oh, that's "rethrow".
20160908 01:59:04< celmin> So, catch(exception e) {throw;} is equivalent to catch(exception e) {throw e;}
20160908 01:59:14< celmin> Except that it also works in catch(...)
20160908 01:59:39< celmin> So in other words, it's caught and rethrown.
20160908 02:00:45< vultraz> it might be rather difficult to get rid of this
20160908 02:00:49< gfgtdf> celmin: i dont think its the same
20160908 02:01:13< gfgtdf> celmin: the second might actuall copy the excption object and throw the copy
20160908 02:01:21-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 02:01:22< travis-ci> wesnoth/wesnoth#10762 (master - 8c270f9 : Charles Dang): The build is still failing.
20160908 02:01:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158333952
20160908 02:01:22-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 02:01:51< gfgtdf> hmm wait i just saw you dont catch by reference, might behave diferent then, not sure though.
20160908 02:01:58< vultraz> ..is there even any way to exit a game without a exception? O_O
20160908 02:02:04< celmin> Yes?
20160908 02:02:08< celmin> exit(0)
20160908 02:02:21< celmin> That's the C exit function.
20160908 02:02:26< vultraz> uh..
20160908 02:02:39< celmin> Oh, exit a game, not to desktop.
20160908 02:02:48< celmin> In that case, I don't know.
20160908 02:03:02< vultraz> yes
20160908 02:03:43-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has quit [Quit: Whoop.]
20160908 02:04:03< gfgtdf> vultraz: how do o create  anew rom in the lobby ?
20160908 02:04:23< gfgtdf> s/o/i
20160908 02:04:23< vultraz> you cannot right now
20160908 02:04:29< vultraz> but you can click on your name
20160908 02:04:31< vultraz> double click
20160908 02:04:37< vultraz> and then select Send PrivateMessage
20160908 02:04:45< vultraz> that's basically the same thing
20160908 02:04:48< gfgtdf> ok thx
20160908 02:05:59-!- Polsaker [~Polsaker@wikimedia/botters.Polsaker] has joined #wesnoth-dev
20160908 02:11:03-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]]
20160908 02:19:16< vultraz> hm
20160908 02:19:30< celmin> Well, the titlescreen is not totally broken - I can start a tutorial.
20160908 02:19:32-!- travis-ci [~travis-ci@ec2-54-146-36-64.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 02:19:33< travis-ci> wesnoth/wesnoth#10763 (master - 84de6ba : Charles Dang): The build is still failing.
20160908 02:19:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158334734
20160908 02:19:33-!- travis-ci [~travis-ci@ec2-54-146-36-64.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 02:19:37< vultraz> I still have my WIP implementation of saved games as a Create category 
20160908 02:20:01< celmin> And HTTT.
20160908 02:20:26< vultraz> i should finish it
20160908 02:20:43< celmin> So far, everything works.
20160908 02:21:20< vultraz> I guess the expected behavior would be..
20160908 02:21:25< vultraz> hm
20160908 02:21:27< vultraz> what would it be...
20160908 02:21:37< celmin> ?
20160908 02:21:39< vultraz> I guess display settings in read-only mode
20160908 02:21:51< celmin> ?
20160908 02:22:12< vultraz> celmin: I was going to implement Saved Games as a separate category in MP Create 
20160908 02:22:26< celmin> One that shows MP games only?
20160908 02:22:34< vultraz> yes
20160908 02:22:40< celmin> Though, hmm...
20160908 02:23:17< vultraz> hm?
20160908 02:25:05-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160908 02:25:16< vultraz> I'm thinking on selects a game, and you see the settings as usual
20160908 02:25:23< vultraz> except you cannot edit any of them
20160908 02:27:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 02:27:22< vultraz> all the settings are in the multiplayer tag...
20160908 02:28:17< celmin> I wonder what happens if you quit Wesnoth before the server has terminated...
20160908 02:30:02< vultraz> anarchy and panic in the streets
20160908 02:31:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160908 02:32:40< celmin> So uh.
20160908 02:33:05< vultraz> hhmmm?
20160908 02:33:17< celmin> I went to "Host a game", and am stuck in a loading screen.
20160908 02:35:23< vultraz> fun!
20160908 02:35:56< celmin> I want to know if this is just me.
20160908 02:36:34< vultraz> works for me
20160908 02:36:39< vultraz> i assume you mean Host Networked game?
20160908 02:36:42< celmin> Yes.
20160908 02:37:00< celmin> That probably means I broke it with the tnetwork_transmission -> loading screen change.
20160908 02:37:02< celmin> :|
20160908 02:37:08< vultraz> lags for awhile while it starts the server though
20160908 02:37:14-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 02:37:15< travis-ci> wesnoth/wesnoth#10764 (master - 6aee108 : Charles Dang): The build is still failing.
20160908 02:37:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158335508
20160908 02:37:15-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 02:37:17< celmin> Hmm.
20160908 02:37:27< celmin> Well I suppose I could try one more time, just in case it's very delayed.
20160908 02:41:10< vultraz> for some reason wesnoth decides to crash 
20160908 02:41:25< vultraz> LE SIGH
20160908 02:43:45< celmin> Whoops, broke map editor button.
20160908 02:45:42< celmin> The next/previous tip buttons don't seem to work.
20160908 02:47:41< celmin> Good news is that the titlescreen does now redraw.
20160908 02:48:07< celmin> I'm guessing it doesn't get a chance to finalize the close() request because its event loop is suspended.
20160908 02:48:20< celmin> (I was worried that the "close on resize" hook would mess things up.)
20160908 02:49:33< celmin> vultraz: Would you mind trying the tip buttons?
20160908 02:49:43< celmin> If you press next and previous, do you get back to the same tip?
20160908 02:49:48< celmin> Or does it give you a different one?
20160908 02:50:04< vultraz> same
20160908 02:50:37< celmin> It's giving me a different one each time I click, so I guess that's three things to fix before I can think about pushing.
20160908 02:50:49< celmin> Four if I count the host game thing, unless that was a fluke (or swap hell).
20160908 02:51:53< celmin> Well, it worked on Windows, so I'm going to treat it as a fluke unless it remanifests with the titlescreen changes.
20160908 02:53:58< celmin> Ah, I accidentally bound both buttons to the "previous tip" behaviour.
20160908 02:55:03< celmin> Incidentally, if you bind a hotkey, you can open the core select dialog even when you have no alternate cores installed.
20160908 02:55:39< celmin> (There's no default hotkey bound.)
20160908 02:57:10< celmin> Oh right, I need to test the fullscreen hotkey, and reload and console.
20160908 03:08:05< Sirp_> Aginor / celticminstrel / gfgtdf: you guys all have wesnoth forum PM's asking if you want to be considered for the Wesnoth board. Please respond when able
20160908 03:08:35< celmin> Oh, that actually did happen, huh.
20160908 03:08:50< celmin> When I didn't get a message after seeing the post that they had been sent, I was a little surprised.
20160908 03:10:29-!- jamk [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has joined #wesnoth-dev
20160908 03:21:10< vultraz> ok, I've got it to stop crashing
20160908 03:22:08< Aginor> Sirp_: I've seen it and I will respond as soon as I can. It's complicated with my current employment situation
20160908 03:23:59< Aginor> Sirp_: thank you for bringing it to my attention though :)
20160908 03:26:33< vultraz> ah, I seem to have it working :D
20160908 03:28:20< vultraz> basically
20160908 03:28:26< vultraz> will need work
20160908 03:50:44< celmin> I have my stuff working, just need to commit it and deal with two other bits I wanted to do and then I can push.
20160908 03:51:45< celmin> Aginor: People have complained about not allowing arbitrary fullscreen resolutions. What should we do about that, any ideas? I kind of like how it remembers the resolution if I switch to and from fullscreen.
20160908 03:59:03< vultraz> celmin: there was just a PR opened for that :P
20160908 04:01:22< Aginor> celmin: we can go and reintroduce resolution switching and actual fullscreen in that resolution instead of borderless windows
20160908 04:01:54< Aginor> then they can go and take their 1080p monitor and run it at 800x600 if they want
20160908 04:03:11< celmin> Ooh.
20160908 04:03:43< celmin> I was thinking maybe remember fullscreen and windowed resolution separately, but I dunno if that's good.
20160908 04:04:12< Aginor> fixing the window at specific sizes?
20160908 04:04:26< Aginor> we could do that I guess, but I don't particuraliy like it
20160908 04:04:29< celmin> Eh?
20160908 04:04:45< celmin> I mean that it remembers the size of the window, and separately remembers the fullscreen resolution.
20160908 04:06:21-!- JyrkiVesterinen [~JyrkiVest@87-100-228-176.bb.dnainternet.fi] has joined #wesnoth-dev
20160908 04:09:20< vultraz> celmin: used to do that, I removed that
20160908 04:09:41< celmin> I see.
20160908 04:09:44< celmin> Well, whatever.
20160908 04:15:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 04:19:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160908 04:26:43< celmin> So, the question of what to work on next. Prime choices are a) Various Lua API cleanup things. b) wml_tag_porting
20160908 04:27:01< vultraz> why don't we focus on MP Connect?
20160908 04:27:06< vultraz> (jointly)
20160908 04:27:39< vultraz> or, how about fixing the matrix placement?
20160908 04:27:47< celmin> I fixed it already, right?
20160908 04:28:33< vultraz> the things are all different sized
20160908 04:28:34< vultraz> sizes
20160908 04:31:08< celmin> A linked group can make them all the same size.
20160908 04:31:37< celmin> …I wonder if there's a separate function for getting the size required due to a linked group...
20160908 04:31:54< celmin> Do you happen to know the name of the dialog used by ;c?
20160908 04:32:31< celmin> Oh, I just remembered, after I do this last thing and that last thing, I still have to rebase and then fix the unit tests.
20160908 04:32:57< celmin> The title screen constructor also changed, so that's two broken dialogs.'
20160908 04:32:58< vultraz> c?
20160908 04:33:04< vultraz> there is no c
20160908 04:33:09< celmin> Choose level
20160908 04:33:23< vultraz> that's the simple item selector
20160908 04:33:34< celmin> Ah...
20160908 04:33:50< celmin> Actually, maybe that (and transient message) should have Lua API functions.
20160908 04:34:37< celmin> I just discovered something interesting.
20160908 04:34:43< celmin> Choose level does not work in the tutorial.
20160908 04:37:14< celmin> So vultraz, is MP Connect the last GUI1 dialog?
20160908 04:37:32< celmin> (Obviously there's GUI1 stuff in the game UI too, but that's not a dialog.)
20160908 04:38:21-!- jamk [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has quit [Quit: Page closed]
20160908 04:38:39-!- irker744 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160908 04:40:09< vultraz> celmin: no
20160908 04:40:18< vultraz> Addons Manager is still non-functional
20160908 04:40:30< vultraz> Statistics and Attack Predictions
20160908 04:41:45< vultraz> and Help, but that's not happening anytime soon
20160908 04:41:45< vultraz> we'll tackle that last
20160908 04:41:45< vultraz> So:
20160908 04:41:46< vultraz> MP Connect + Wait, Addons Manager, Statistics, Attack Prediction, Help
20160908 04:41:51< vultraz> that's the remainder of GUI1
20160908 04:42:00< celmin> Oh right, forgot about help.
20160908 04:42:13< celmin> Stats and attack prediction sound easy.
20160908 04:42:30< vultraz> AP will need a graph widget
20160908 04:42:38< vultraz> Stats likely is, just tedious
20160908 04:42:40< celmin> Probably could be done without one.
20160908 04:42:49< vultraz> I'll tackle Stats
20160908 04:42:50< celmin> But since someone has one in progress, we might as well wait for that.
20160908 04:44:54< vultraz> gfgtfd is widget-izing the chat area
20160908 04:45:01< celmin> So I heard.
20160908 04:45:10< vultraz> then we can do Connect
20160908 04:45:22< celmin> Connect doesn't need rooms, though.
20160908 04:45:44< celmin> Also, I think Wait is actually very different from Connect after all.
20160908 04:45:50< vultraz> Not really
20160908 04:45:58< celmin> Though there's no particular reason why they couldn't be merged.
20160908 04:46:10< celmin> They're different, but they don't have to be all that different.
20160908 04:46:22< vultraz> yes
20160908 04:46:35< celmin> Generally speaking, Wait only sees settings and cannot change them.
20160908 04:48:12< vultraz> yes
20160908 04:49:35< vultraz> Converting the mp workflow to gui2 wholly would be good for 1.13.6
20160908 04:50:11-!- JyrkiVesterinen [~JyrkiVest@87-100-228-176.bb.dnainternet.fi] has quit [Quit: .]
20160908 04:50:14< celmin> What is the expected behaviour of ;choose_level in an MP scenario...
20160908 04:50:21< vultraz> dunno
20160908 04:51:15< celmin> Apparently there's an attempt to make it able to jump within scenarios in an MP campaign.
20160908 04:52:10< celmin> Hmm, currently using it in an MP scenario brings up a list with the only option being the current scenario.
20160908 04:52:44 * vultraz waits for the Push
20160908 04:56:25-!- Kwandulin [~Miranda@p200300760F42411EA0CC8660AD17E036.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160908 04:59:02< celmin> src/menu_events.cpp:1643
20160908 04:59:10< celmin> What the heck are next and nb for.
20160908 04:59:39< celmin> As far as I can see, they're assigned and never used. I'm not missing something, am I?
20160908 04:59:53< celmin> Oh, no, next is used.
20160908 05:00:05< celmin> I get it now.
20160908 05:00:09< vultraz> yes
20160908 05:00:12< celmin> However, I'm pretty sure that won't work.
20160908 05:00:15< celmin> Because it's sorted.
20160908 05:00:15< vultraz> it sets the index of the next scenario
20160908 05:00:26< celmin> Try it, does it actually preselect the next scenario?
20160908 05:01:11< vultraz> yes
20160908 05:01:13< celmin> Also, what if there is no next?
20160908 05:01:41< celmin> Did you try it?
20160908 05:01:53< vultraz> i tried it
20160908 05:02:05< celmin> Where?
20160908 05:02:27< vultraz> htt s2
20160908 05:02:34< vultraz> just tried it in did s12
20160908 05:02:41< vultraz> it selects the current one if it's the last
20160908 05:02:47< celmin> Okay...
20160908 05:03:06< vultraz> it really should be done differently
20160908 05:03:10< celmin> Heh, HTTT's map made me think I'd been dumped back to titlescreen for a moment.
20160908 05:04:04< vultraz> those int vars are hacky :|
20160908 05:04:08< celmin> Hmm, if I think about it, I bet the only reason it works is that...
20160908 05:04:12< vultraz> why not just use find_if?
20160908 05:04:17< celmin> 1. The scenarios are already in sorted order.
20160908 05:04:29< celmin> 2. The IDs all begin with a scenario number.
20160908 05:04:42< vultraz> :|
20160908 05:04:53< vultraz> so it accidentally works
20160908 05:04:55< celmin> I am going to change it, but to std::binary_search.
20160908 05:05:02< celmin> Since it's sorted.
20160908 05:05:22< celmin> At 04, it choose 05a.
20160908 05:05:34-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160908 05:05:35-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160908 05:05:39< celmin> Which incidentally is a scenario I have never seen.
20160908 05:07:42< vultraz> it's funny how the older code is full of such things
20160908 05:07:55< vultraz> I guess the caliber of coder has gradually gone up
20160908 05:09:06< celmin> …binary_search is no good. :|
20160908 05:09:14< celmin> It's only a query "is it there".
20160908 05:09:22< celmin> Maybe upper_bound or lower_bound?
20160908 05:13:40< ancestral> Eeeek, conversation in bug #24456 is getting a little sour
20160908 05:13:45< celmin> ?
20160908 05:13:58< ancestral> http://gna.org/bugs/?24456
20160908 05:14:40< vultraz> celmin: while you're at it you can clean up do_turn to const int turn = get_data().empty() ? tod_man.turn() + 1 : lexical_cast_default<int>(get_data(), 1)
20160908 05:14:58< celmin> vultraz: What are you talking about?
20160908 05:15:32< vultraz> menu_events.cpp:1686
20160908 05:15:36< vultraz> can be cleaned up
20160908 05:15:37< vultraz> as so
20160908 05:16:55< vultraz> also, who wrote this message o_O
20160908 05:16:58< vultraz> "You are about to open a security breach in Wesnoth. Are you sure you want to continue? If you have downloaded add-ons, do not click 'ok'! They would instantly take over your computer. You have been warned."
20160908 05:17:10< celmin> ...what?
20160908 05:17:19< celmin> Where's that message?
20160908 05:17:22< vultraz> menu_events.cpp:1730
20160908 05:17:59< celmin> Well, it's fairly accurate though.
20160908 05:18:47< celmin> And you can do the menu_events.cpp:1686 thing yourself, because that has nothing to do with what I'm doing here.
20160908 05:18:53< vultraz> ok
20160908 05:29:45< celmin> Just about to commit, then all that's left before push is unit tests, which will take awhile longer.
20160908 05:33:17< celmin> Oh, right, I have to rebase as well.
20160908 05:33:27< celmin> You didn't add new files, right...
20160908 05:41:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160908 05:44:05< vultraz> no
20160908 05:45:11< celmin> Huh, conflicts.
20160908 05:46:19< celmin> vultraz: Did you change something about the sound toggles in prefs...
20160908 05:46:33< celmin> Oh wait, I see. Addition of a template argument, is that it?
20160908 05:46:47< celmin> Oh, and boolean argument removed.
20160908 05:47:51< celmin> Wait, no, the boolean argument is still there, never mind.
20160908 05:53:17-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160908 05:57:05-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 05:58:25< vultraz> yes, templateargument
20160908 05:58:29< vultraz> and function name change
20160908 06:00:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160908 06:00:32-!- wedge010 is now known as wedge009
20160908 06:03:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 06:05:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160908 06:06:33-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160908 06:08:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160908 06:13:37< celmin> Bah, missed that. :|
20160908 06:14:33< vultraz> rebasing, I assume
20160908 06:24:44-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160908 06:40:07-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has joined #wesnoth-dev
20160908 06:40:15< vultraz> celticminstrel: how's it coming?
20160908 06:40:27< celticminstrel> Almost done.
20160908 06:40:28-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160908 06:40:39< celticminstrel> By which I mean the tests build just finished failing.
20160908 06:41:06< celticminstrel> I also abandoned the other idea, because the preprocessor macros aren't in the right state and I don't want a loading screen.
20160908 06:47:01-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160908 06:50:28-!- Kwandulin [~Miranda@p200300760F42411EA0CC8660AD17E036.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160908 06:58:11-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: JyrkiVesterinen]
20160908 07:07:55-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160908 07:09:12-!- Kwandulin [~Miranda@p200300760F2C711E74D58AE4DFE319C3.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160908 07:17:42-!- irker906 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160908 07:17:42< irker906> wesnoth: Celtic Minstrel wesnoth:master b4daf7e1dd96 / src/gui/dialogs/ (dialog.cpp dialog.hpp preferences_dialog.cpp): Fix some build issues and minor cleanup of dialog field registration API https://github.com/wesnoth/wesnoth/commit/b4daf7e1dd9655efd03906feb267bf8904cacb5c
20160908 07:17:44< irker906> wesnoth: Celtic Minstrel wesnoth:master da92ac0635c3 / src/gui/dialogs/multiplayer/mp_create_game.cpp: Fix empty else warning https://github.com/wesnoth/wesnoth/commit/da92ac0635c377448cf879ac7eab3fa13f4d356c
20160908 07:17:46< irker906> wesnoth: Celtic Minstrel wesnoth:master d8de472a57be / src/gui/widgets/ (generator.cpp generator_private.hpp): Make tgenerator::get_item_shown also check the grid visibility https://github.com/wesnoth/wesnoth/commit/d8de472a57be994658e6e9c2b47131ff714012a1
20160908 07:17:48< irker906> wesnoth: Celtic Minstrel wesnoth:master fbdceb9fc6ed / src/gui/widgets/generator.cpp: Make listboxes accept arrow key input when no item is selected https://github.com/wesnoth/wesnoth/commit/fbdceb9fc6edee61b4693420b53a07ea37d00ac4
20160908 07:17:50< irker906> wesnoth: Celtic Minstrel wesnoth:master abdba44e7347 / src/gui/dialogs/ (drop_down_list.cpp drop_down_list.hpp): Enable navigating menus with the arrow keys https://github.com/wesnoth/wesnoth/commit/abdba44e73476cb81b1cca8b00f5eae0bb3b948b
20160908 07:17:52< irker906> wesnoth: Celtic Minstrel wesnoth:master e32b88568e83 / src/ (8 files in 4 dirs): Use loading screen instead of network transmission screen when connecting to the https://github.com/wesnoth/wesnoth/commit/e32b88568e83af2fa4df0c3094d7a9f59c5757c8
20160908 07:17:54< irker906> wesnoth: Celtic Minstrel wesnoth:master da437f74ca9c / src/gui/dialogs/ (dialog.cpp dialog.hpp lobby/lobby.cpp multiplayer/mp_create_game.cpp): Allow GUI2 dialogs to disable the default dialog plugins context https://github.com/wesnoth/wesnoth/commit/da437f74ca9c23625369b45ce208691c2fc8a685
20160908 07:17:56< irker906> wesnoth: Celtic Minstrel wesnoth:master d0906ceac57c / src/ (6 files in 3 dirs): Refactor titlescreen loop so that it redraws properly behind other dialogs https://github.com/wesnoth/wesnoth/commit/d0906ceac57c21edd380f41b28507dc6cf4ed18e
20160908 07:17:58< irker906> wesnoth: Celtic Minstrel wesnoth:master 045521d5f6c0 / src/menu_events.cpp: Make ;choose_level work in tutorial and test scenarios https://github.com/wesnoth/wesnoth/commit/045521d5f6c0a8441cb1aa4164b8a75c0ed615e7
20160908 07:18:00< irker906> wesnoth: Celtic Minstrel wesnoth:master 18b7549cdc5e / src/tests/gui/test_gui2.cpp: Fix unit tests https://github.com/wesnoth/wesnoth/commit/18b7549cdc5eb78f3e766a98d4eceae20c47ef90
20160908 07:18:02< irker906> wesnoth: Celtic Minstrel wesnoth:master 208a43cff16d / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/208a43cff16d369240d49d6ec4af8b31d35b2e20
20160908 07:18:11< vultraz> It's hhhheeerr!
20160908 07:18:29< celticminstrel> Whoa, it was surprisingly a lot, huh.
20160908 07:18:42< vultraz> I expected more
20160908 07:19:08< vultraz> agh
20160908 07:19:11< vultraz> why more bind_void!
20160908 07:19:18< celticminstrel> Because it was necessary.
20160908 07:19:25< vultraz> sadness :(
20160908 07:21:41< vultraz> why so much code duplication in d8de472a57be ?
20160908 07:21:52< vultraz> I mean fbdceb9fc6ed 
20160908 07:21:56< celticminstrel> Oh right, there was another thing I forgot about.
20160908 07:22:21< celticminstrel> Well, the code duplication was already there in the generator code.
20160908 07:32:18< vultraz> unused parameter
20160908 07:32:35< vultraz> ttitle_screen.cpp:335
20160908 07:33:25< vultraz> why does it tell me mynick is registered :|
20160908 07:33:30< vultraz> it's my own nick
20160908 07:33:58 * vultraz logs in
20160908 07:34:18< vultraz> celticminstrel: Log Out is broken in the mp lobby
20160908 07:34:21< vultraz> lobby never closes
20160908 07:34:37< vultraz> Esc works
20160908 07:35:22< celticminstrel> Just delete the parameter name. (I thought I already did that, but apparently not.)
20160908 07:35:44< vultraz> celticminstrel: right click menus no longer dismiss when clicking outside their area
20160908 07:36:21< vultraz> again, Esc needs to be used
20160908 07:36:52< vultraz> selection doesn't jump to the opposite end when pressing up/down at the first/last entry
20160908 07:38:04< vultraz> Options in the GUI1 addons manager doesn't show up at all
20160908 07:38:15< vultraz> ESC does nothing to remedy this
20160908 07:38:28< celticminstrel> I'm certain I remember verifying that. (Not for right-click menus, admittedly, but for regular menus.)
20160908 07:38:47< celticminstrel> I have no idea what you're talking about in the addons manager.
20160908 07:39:02< vultraz> there's a button for Options
20160908 07:39:09< vultraz> it doesn't bring up its dialog
20160908 07:39:27< celticminstrel> Are you implying it was my fault?
20160908 07:39:43< vultraz> no..
20160908 07:39:44< celticminstrel> I don't see how it could be, though.
20160908 07:39:47< celticminstrel> Okay.
20160908 07:39:47< vultraz> i don't know when it last worked
20160908 07:39:55< vultraz> it's a gui2 dialog over a gui1 dialog
20160908 07:39:57< vultraz> for the record
20160908 07:40:12< vultraz> might not be worth fixing if we get the addons manager done
20160908 07:40:48< celticminstrel> Well, the menu fix and the logout fix should be relatively simple. No idea why logout would've broken though.
20160908 07:41:30< vultraz> for some reason the lobby wants me to login
20160908 07:41:32< vultraz> every single
20160908 07:41:33< vultraz> time
20160908 07:41:35< vultraz> :|
20160908 07:41:36< vultraz> this is new
20160908 07:42:20< celticminstrel> The loading screen stuff still needs more refactoring, as well. Does it keep switching to "Loading..." for you as well?
20160908 07:42:34< vultraz> yes
20160908 07:43:18< celticminstrel> Plus I didn't properly disentangle it from the tnetwork_transmission dialog, even though it's no longer using the actual dialog.
20160908 07:45:59< irker906> wesnoth: Celtic Minstrel wesnoth:master 5024fc1305a7 / doc/manual/ (27 files): Update weapon format reference in the manual https://github.com/wesnoth/wesnoth/commit/5024fc1305a7cdebc633d2263992e33172455da6
20160908 07:50:20< vultraz> celticminstrel: figured out why Log Out is broken
20160908 07:50:29< vultraz> you removed "quit" from get_retval_by_id
20160908 07:50:37< celticminstrel> Ah, whoops.
20160908 07:50:44< vultraz> I can use "cancel" instead
20160908 07:50:58< celticminstrel> I think the lobby isn't the only thing to rely on that though?
20160908 07:51:05< celticminstrel> Might be better to put it back.
20160908 07:51:06< vultraz> perhaps
20160908 07:51:08< vultraz> yeah
20160908 07:51:24< celticminstrel> I dunno.
20160908 07:51:41< vultraz> I'll make it an alias for cancel
20160908 07:51:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 07:52:32-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160908 07:54:45-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 07:54:46< travis-ci> wesnoth/wesnoth#10766 (master - 208a43c : Celtic Minstrel): The build is still failing.
20160908 07:54:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158378731
20160908 07:54:46-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 07:55:11< vultraz> quit seems to have made the login prompt go away too
20160908 07:55:13< vultraz> huh
20160908 07:56:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160908 07:56:39< irker906> wesnoth: Charles Dang wesnoth:master 9a569df848f3 / src/ (4 files in 2 dirs): MP Create: basic implementation of saved games as their own category (debug only https://github.com/wesnoth/wesnoth/commit/9a569df848f3b7d774ac29c100a4f36c4923b7bd
20160908 07:56:42< irker906> wesnoth: Charles Dang wesnoth:master 2694c1d7a7ec / src/gui/widgets/window.cpp: Restored the "quit" retval as an alias for "cancel" https://github.com/wesnoth/wesnoth/commit/2694c1d7a7ec097cd2625d23bae249b51785612d
20160908 07:56:45< irker906> wesnoth: Charles Dang wesnoth:master 39bd46acccff / src/gui/dialogs/title_screen.cpp: Removed unused parameter https://github.com/wesnoth/wesnoth/commit/39bd46acccffb08a3241f5a61fd64bfbb7f92814
20160908 08:00:20-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160908 08:04:28-!- Kwandulin [~Miranda@p200300760F2C711E74D58AE4DFE319C3.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160908 08:21:22-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 08:21:23< travis-ci> wesnoth/wesnoth#10767 (master - 5024fc1 : Celtic Minstrel): The build is still failing.
20160908 08:21:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158384938
20160908 08:21:23-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 08:32:51-!- Kwandulin [~Miranda@p200300760F2C711E700A05BC7A3D1A98.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160908 08:45:25-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 08:45:26< travis-ci> wesnoth/wesnoth#10768 (master - 39bd46a : Charles Dang): The build is still failing.
20160908 08:45:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158386766
20160908 08:45:26-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 08:51:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160908 08:52:48-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has quit [Quit: Page closed]
20160908 09:02:24-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160908 09:09:32-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has joined #wesnoth-dev
20160908 09:10:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 09:13:53-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has quit [Client Quit]
20160908 09:13:57-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160908 09:15:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 09:15:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 09:15:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 09:16:28-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 09:25:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160908 09:32:28-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160908 09:40:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 09:44:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160908 09:46:00< vultraz> wow I got this working :o
20160908 09:56:51-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has joined #wesnoth-dev
20160908 10:00:03< irker906> wesnoth: Charles Dang wesnoth:master 640a3ff46da3 / src/gui/widgets/status_label_helper.hpp: Status Label Helper: provide different default value getters based on base type  https://github.com/wesnoth/wesnoth/commit/640a3ff46da39405bd722b9318c91c28ebd333e4
20160908 10:01:07< vultraz> ( JyrkiVesterinen or someone might want to double-check that, since there's a high possibility I could have screwed up :P )
20160908 10:03:22< vultraz> it does work, for the record
20160908 10:05:43< JyrkiVesterinen> I noticed two things.
20160908 10:06:00< JyrkiVesterinen> Is it intentional that default_value_getter returns std::string instead of t_string?
20160908 10:06:19< vultraz> hm
20160908 10:06:22< vultraz> good question
20160908 10:06:23< JyrkiVesterinen> It looks like both variants end up converting from t_string to std::string.
20160908 10:07:28< JyrkiVesterinen> Second, only tslider implements get_value_label(). The template should check for std::is_base_of<tslider> unless you plan to add get_value_label() to more widgets in the future.
20160908 10:08:22< vultraz> hmm.. good point.
20160908 10:08:36< JyrkiVesterinen> It looks like you're using std::enable_if correctly. :) I'm not 100% sure because I haven't used it myself.
20160908 10:12:05< vultraz> :D
20160908 10:26:35-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has quit [Quit: Page closed]
20160908 10:26:47-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160908 10:36:29-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 10:36:30< travis-ci> wesnoth/wesnoth#10769 (master - 640a3ff : Charles Dang): The build is still failing.
20160908 10:36:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158411393
20160908 10:36:30-!- travis-ci [~travis-ci@ec2-54-221-43-200.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 10:45:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 10:50:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20160908 11:05:16-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Ping timeout: 244 seconds]
20160908 11:43:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160908 12:07:15-!- Kwandulin [~Miranda@p200300760F2C711E700A05BC7A3D1A98.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160908 12:07:23-!- Duthlet [~Duthlet@dslb-188-104-247-024.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20160908 12:38:38< irker906> wesnoth: ln-zookeeper wesnoth:master 40b6fc888ab8 / data/core/ (22 files in 2 dirs): Animations for the new Tentacle of the Deep, mostly by homunculus https://github.com/wesnoth/wesnoth/commit/40b6fc888ab82aed897a412fa0b1e7e890bd92de
20160908 12:44:10-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160908 12:51:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160908 12:51:18< irker906> wesnoth: ln-zookeeper wesnoth:master 53b9ace13b58 / data/core/units/monsters/Tentacle.cfg: Added a ripple to the Tentacle of the Deep baseframe using IPF https://github.com/wesnoth/wesnoth/commit/53b9ace13b583935758558a92c0069c4004d43e3
20160908 13:06:52-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has joined #wesnoth-dev
20160908 13:14:16-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160908 13:14:43-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 13:14:44< travis-ci> wesnoth/wesnoth#10770 (master - 40b6fc8 : ln-zookeeper): The build is still failing.
20160908 13:14:44< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158443402
20160908 13:14:44-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 13:22:16-!- Kwandulin [~Miranda@p200300760F2C711E4871E78877D72614.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160908 13:26:04< gfgtdf> vultraz: i was thinking about how tto implement gui2 mo connect/wait. It'd be easier if we could also change the mp-connet network protocoll freely, but somehow unforunateley we canot so this is we want to stay comptible to the gui1 mp connect/wait. :s
20160908 13:26:22< gfgtdf> vultraz: do you know when we intend to grop those gui1 versions ß
20160908 13:36:51-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 13:36:52< travis-ci> wesnoth/wesnoth#10771 (master - 53b9ace : ln-zookeeper): The build is still failing.
20160908 13:36:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158446594
20160908 13:36:52-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 13:56:36-!- horus2 [~1@81-0-99-172.pool.invitel.hu] has joined #wesnoth-dev
20160908 13:58:20-!- Kwandulin [~Miranda@p200300760F2C711E4871E78877D72614.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160908 14:07:26< mattsc> Hi vultraz: Unfortunately, I am getting another assertion failure from the disabled weapon dialog code:
20160908 14:07:40< mattsc> Assertion failed: (best_weapon_ < static_cast<int>(weapon_list.get_item_count())), function pre_show, file src/gui/dialogs/unit_attack.cpp, line 187.
20160908 14:08:15< mattsc> This is for an Elvish Enchantress which has the third weapon (faerie fire) disabled.
20160908 14:12:00< mattsc> Actually, it does not matter which of the attacks I disable, as long as only one or two of the weapons are disabled, I get the crash.
20160908 14:12:18< mattsc> If I disable all of them, the “no attacks” pop-up displays correctly.
20160908 14:19:18-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160908 14:20:02< fabi> hi mattsc
20160908 14:22:55< vultraz> gfgtdf: we need the gui1 code as long as Connect/Wait is not converted. I think we can probably go all-in if we're doing that
20160908 14:24:05< gfgtdf> vultraz: ew we dont ned gui1 compability when implemeting the gui mp wait/connect ?
20160908 14:24:19< gfgtdf> s/ew/so*
20160908 14:25:10< mattsc> hi fabi 
20160908 14:26:00< gfgtdf> g/gui mp/gui2 mp
20160908 14:26:07< vultraz> gfgtdf: not if we can get it all working, no
20160908 14:26:29< gfgtdf> vultraz: are the lobby/create working good enough to replace the gui1 version ?
20160908 14:28:16< vultraz> I think so, yes
20160908 14:28:48< fabi> vultraz, gfgtdf: I wonder if that is really true. Do you know the history of the new gui2 lobby?
20160908 14:28:59< vultraz> yes
20160908 14:29:12< vultraz> have you tried it recently?
20160908 14:29:23< vultraz> we've improved it *immensely* 
20160908 14:29:36< fabi> No. Then let me ask if you test the one reason it was removed from 1.10?
20160908 14:29:43< fabi> (as the default)
20160908 14:29:47< gfgtdf> but we didnt test it with >10 games at the same time yet right ?
20160908 14:29:57< fabi> yeah
20160908 14:30:11< fabi> It was removed because it did not cope with more than a few test users well.
20160908 14:30:25< vultraz> granted we have not tested that
20160908 14:37:47< fabi> vultraz: One symptom of "not coping with many games/users" was that every recalculation of user or game list caused the scrollviewpoint to be reseted to top.
20160908 14:38:08< fabi> That made it nearly unusable.
20160908 14:38:15< vultraz> hmmm
20160908 14:38:31< gfgtdf> fabi: we might ahve fixed that one, i know for sure that we fixed it in some cases not sure whether in rthis one too.
20160908 14:38:47< vultraz> I think that's still partly an issue
20160908 14:38:54< vultraz> but I'm unsure
20160908 14:38:59< gfgtdf> vultraz: i have soem issue: when i open 2 games with 2 clients, then closte the game2, of the games show up in the gamelist for theclient 2 (even rough game1 is till running).
20160908 14:39:10< fabi> I do not want to spoil you the day. Just mentioning it.
20160908 14:39:25< gfgtdf> i was s´working an a similar issue but bnot sure whether it was on treeviews or listboxes or both.
20160908 14:39:46< vultraz> gfgtdf: you fixed tree views, I think
20160908 14:40:34< gfgtdf> vultraz: can you log in to master mpo server now ?
20160908 14:40:41< gfgtdf> mp*
20160908 14:41:19< gfgtdf> i there see 0 open games but one player (in the playerlist) in'open games'
20160908 14:41:32< gfgtdf> vultraz: 'other games' i emant
20160908 14:41:34-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160908 14:41:51< gfgtdf> vultraz: player a4 that is
20160908 14:42:04< vultraz> yes... indeed
20160908 14:42:27< vultraz> but if i double click a4 it says in lobby
20160908 14:42:48< vultraz> then again if i connect to the gui1 lobby it also says that
20160908 14:42:58< vultraz> i think it's not an issue with the lobby
20160908 14:43:35< gfgtdf> vultraz: with the mp server then?
20160908 14:43:44< vultraz> possibly 
20160908 14:43:58< vultraz> i noticed an issue the other day where celmin crashed and it still showed him as on
20160908 14:46:53< vultraz> hm
20160908 14:47:02< vultraz> I'm seeing a lot of stuff in console like
20160908 14:47:05< vultraz> 20160909 01:45:06 warning engine: User a1 has unknown game_id: 25
20160908 14:47:07< vultraz> 20160909 01:45:06 warning engine: User a4 has unknown game_id: 23
20160908 14:49:43< gfgtdf> the game also wont work properly for thse users
20160908 14:49:57< gfgtdf> like when alking for a seed for unit trait generation it wait forever
20160908 14:51:05< vultraz> what do you mean?
20160908 14:52:30< gfgtdf> when i start 2 games, game1, game2, then close game2. game1 will not oynl not show in list, it will also be corrupted so that it for examepl freezes when you recruit a unit.
20160908 14:52:49-!- Bonobo [~Bonobo@2001:44b8:254:3200:692d:9968:f549:2f48] has quit [Quit: Leaving]
20160908 14:53:50< vultraz> odd
20160908 14:54:26< vultraz> sounds like a sever thing, again :/
20160908 14:54:38< vultraz> i think i observed that too under certain circumstances
20160908 14:56:04-!- Kwandulin [~Miranda@p200300760F2C711E69E4D85B2A86A79D.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160908 14:58:18< vultraz> it would result in raw server data spamming my console :/
20160908 15:03:35< mattsc> ugh; making sure the disbale wapon special is taken care of by the AI in all cases is … a pain
20160908 15:04:04< mattsc> It’s in principle simple, but trying not to slow down the AI in simple calculations is the tricky bit
20160908 15:04:51< mattsc> I think we need to add a “simple check” for all atacks, that simply tests whether the tag is present, and if so, follow up by the full in-context check.
20160908 15:05:04< fabi> mattsc, vultraz: Can disabled weapons be displayed but greyed out?
20160908 15:05:06< mattsc> Since most attacks don’t have the special, I think that should be okay.
20160908 15:05:43< mattsc> fabi: I’ll let vultraz reply to that as I don’t know much about the displaying code
20160908 15:05:54< mattsc> I’m just trying to make the AI work correctly.
20160908 15:05:55< vultraz> :/
20160908 15:06:32< mattsc> Either way, I’ve spent my time I have for this for now.  BBL.
20160908 15:06:42-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160908 15:10:08< vultraz> gfgtdf: maybe we should preserve the gui1 version for now, but rewrite the whole mp handling loop for gui2 separately, instead of trying to mash the code together 
20160908 15:10:51-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160908 15:13:27-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20160908 15:42:08-!- ancestral [~ancestral@111.sub-174-219-1.myvzw.com] has joined #wesnoth-dev
20160908 15:44:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 15:45:03-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20160908 15:47:28-!- ancestral [~ancestral@111.sub-174-219-1.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20160908 15:47:48-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has joined #wesnoth-dev
20160908 15:48:19< gfgtdf> well my problem was more about network comminucation than about codepaths, so i not using the multiplayer.cpp code doesnt reall elp here.
20160908 15:51:28-!- irker906 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160908 15:57:13-!- prkc [~prkc@46.166.190.218] has joined #wesnoth-dev
20160908 16:03:42-!- irker852 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160908 16:03:42< irker852> wesnoth: Charles Dang wesnoth:master 1923b6598db4 / src/gui/dialogs/drop_down_list.cpp: Drop Down List: fixed dialog not dismissing when clicking outside area https://github.com/wesnoth/wesnoth/commit/1923b6598db475b245ef7247c954cddddadab438
20160908 16:03:49< vultraz> celticminstrel ^
20160908 16:07:01-!- JyrkiVesterinen [~JyrkiVest@87-92-54-42.bb.dnainternet.fi] has joined #wesnoth-dev
20160908 16:09:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160908 16:10:38-!- boucman_work [~boucman@193.56.60.161] has quit [Remote host closed the connection]
20160908 16:10:41< fabi> vultraz: The authentification dialog of the mp server login frezzes my system.
20160908 16:11:02< fabi> s/system/Wesnoth
20160908 16:11:07< vultraz> freezes how?
20160908 16:11:32< vultraz> cannot type? wesnoth unresponsive?
20160908 16:11:32< fabi> I can't do anything there anymore.
20160908 16:11:37< vultraz> odd
20160908 16:11:41< fabi> yes
20160908 16:12:16< fabi> I can join when using a not registered name.
20160908 16:13:08< vultraz> yeah, that dialog is appearing erroneously, for some reason
20160908 16:13:13< fabi> Wait
20160908 16:13:49< fabi> It is not frozzen, it is just very  very unresponsive and slow.
20160908 16:14:35< fabi> And this is not restricted to that dialog. Every gui2 dialog seems to have some delay from time to time.
20160908 16:15:29< vultraz> huh
20160908 16:15:59< fabi> But text imput fields seem to make it obvious the best.
20160908 16:16:03< gfgtdf> i somehow rmember that you are not the first one vaing problsm with that dialog.
20160908 16:16:57< fabi> The title screen (main screen) button's have a delay before highlighting of several seconds.
20160908 16:18:15< vultraz> you don't have an AMD GPU, do you 
20160908 16:18:56< fabi> nvidia
20160908 16:20:21< fabi> Whenever the applikation looses the mouse focus, It is going to be minimized.
20160908 16:20:47< fabi> That is new to me and no other game does so.
20160908 16:21:18< gfgtdf> you play in fullscreen ?
20160908 16:21:37< fabi> yes
20160908 16:22:57-!- horus2 [~1@81-0-99-172.pool.invitel.hu] has left #wesnoth-dev []
20160908 16:23:26< gfgtdf> fabi: this is afaik related to the sdl2 switch, try using SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS=0
20160908 16:23:54< gfgtdf> Aginor: might know more
20160908 16:26:50< fabi> vultraz: Okay, I have reached the lobby now. It is hard to say anything about it without other players there. The dialog itself is more ugly than the old. But nearly every dialog looks strange on my system with 1.13.
20160908 16:27:01< vultraz> ...
20160908 16:27:03< vultraz> more ugly??
20160908 16:27:05< vultraz> what??
20160908 16:27:27< fabi> I have a 3440x1440 resolution now.
20160908 16:27:35< fabi> And everything is strange here.
20160908 16:28:30< fabi> Yeah, I have always considered the old lobby to be more nice to look at than the new.
20160908 16:28:35< vultraz> :|
20160908 16:28:56< vultraz> the old lobby looks like crap
20160908 16:29:05< vultraz> the old design of the new lobby looked like worse crap
20160908 16:29:10< vultraz> i think it now looks better than both
20160908 16:29:12< fabi> The fullscreen create game dialog is also not so appealing on high resolutions.
20160908 16:30:14< vultraz> how was the gui1 one any better!
20160908 16:31:24< vultraz> the old one was also fullscreen!
20160908 16:35:18< fabi> Well, the old looked somehow like it would belong to Wesnoth. The new one reminds we about an old amiga game. It was about some war between gangs in the future.
20160908 16:35:51< fabi> But I do not mind the astetics of that dialog much.
20160908 16:36:04< fabi> I think the lobby needs to work fine.
20160908 16:36:44< fabi> But I can't do much more testing right now. Sometimes gui2 just stops everything for more than a minute.
20160908 16:37:42< fabi> vultraz: At what operating system are you coding?
20160908 16:37:50< vultraz> Windows 10
20160908 16:38:02< fabi> Is celmin also on Windows?
20160908 16:38:22< vultraz> os x and windows, I think..
20160908 16:38:31< vultraz> i mean mac os
20160908 16:38:40< fabi> There is no active Linux developer anymore?
20160908 16:39:13< vultraz> Aginor is linux
20160908 16:39:41< fabi> Maybe it works all fine on Windows and osx.
20160908 16:39:58< fabi> And it is only the exact config of my system that is broken.
20160908 16:40:22< vultraz> possibly
20160908 16:42:55-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 16:42:56< travis-ci> wesnoth/wesnoth#10772 (master - 1923b65 : Charles Dang): The build is still failing.
20160908 16:42:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158499366
20160908 16:42:56-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 16:44:19< gfgtdf> ok i think i have a fix for the wesnothd issue.
20160908 16:46:16< gfgtdf> i wonder whether it makes sesne to make the userlist a widget aswell
20160908 16:49:39< vultraz> maybe
20160908 17:17:39-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]]
20160908 17:34:57-!- Aginor [~andreas@unaffiliated/aginor] has quit [Ping timeout: 276 seconds]
20160908 17:43:45-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has joined #wesnoth-dev
20160908 17:47:39-!- Duthlet [~Duthlet@dslb-188-104-247-024.188.104.pools.vodafone-ip.de] has quit [Quit: leaving]
20160908 17:47:43-!- prkc [~prkc@46.166.190.218] has quit [Ping timeout: 255 seconds]
20160908 17:51:54-!- Kwandulin [~Miranda@p200300760F2C711E69E4D85B2A86A79D.dip0.t-ipconnect.de] has quit [Quit: Kwandulin]
20160908 17:54:12-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20160908 17:54:12-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20160908 17:54:12-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20160908 18:02:00-!- edgrey [~edgrey@178.204.112.1] has joined #wesnoth-dev
20160908 18:12:05-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160908 18:13:48< celticminstrel> ...what. The resolution switching PR author closed it.
20160908 18:15:50< zookeeper> umm. maybe it's just my build and data being slightly off-sync, but for example in the editor if i open one menu (file/map/window), i can't click anywhere outside that menu to dismiss it or open another menu. i have to pick one option from that menu or press esc to close it.
20160908 18:16:05< zookeeper> vultraz, ^?
20160908 18:16:29< celticminstrel> That was already reported and I am going to look into it today.
20160908 18:18:14< celticminstrel> Except... vultraz already did, apparently?
20160908 18:18:41< zookeeper> oh, okay
20160908 18:21:43< irker852> wesnoth: Celtic Minstrel wesnoth:master 5b806d4f6655 / src/gui/dialogs/dialog.cpp: fixup! Allow GUI2 dialogs to disable the default dialog plugins context https://github.com/wesnoth/wesnoth/commit/5b806d4f66558dd2847fa53808e2b617b46ce7dc
20160908 18:27:26< celticminstrel> vultraz: So in the list you have saved games before SP campaigns, but in the enum, it's reversed.
20160908 18:39:40< celticminstrel> vultraz: Why did you change the drop down list to always return OK, rather than returning CANCEL if you clicked outside the window?
20160908 18:42:31< celticminstrel> This means that if I select an item with the keys, then click outside the window, that item is chosen instead of the menu being dismissed.
20160908 18:43:00< gfgtdf> celticminstrel: did you see my comments in the forum about the attack_type change ?
20160908 18:43:22< celticminstrel> Yes, I already have a probable fix, but I'm looking for a way to reproduce it.
20160908 18:43:47< celticminstrel> I guess the reason UtBS works is that it uses variations...
20160908 18:44:35< celticminstrel> (Which is the same reason that regular advancement still works, I guess.)
20160908 18:51:13< celticminstrel> Eh, I'll just push it.
20160908 18:51:59< irker852> wesnoth: Celtic Minstrel wesnoth:master ac4b024fa675 / src/gui/dialogs/drop_down_list.cpp: fixup! Drop Down List: fixed dialog not dismissing when clicking outside area" https://github.com/wesnoth/wesnoth/commit/ac4b024fa67558343977595ed55207962e9b79b1
20160908 18:52:01< irker852> wesnoth: Celtic Minstrel wesnoth:master e654fbbb4911 / src/units/unit.cpp: Copy attacks when copying a unit https://github.com/wesnoth/wesnoth/commit/e654fbbb49119e49b280ee44ac44be2b400d68f9
20160908 18:57:53-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 18:57:54< travis-ci> wesnoth/wesnoth#10773 (master - 5b806d4 : Celtic Minstrel): The build is still failing.
20160908 18:57:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158533806
20160908 18:57:54-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 19:00:48< celticminstrel> What the heck is -Qunused-arguments and why is it being passed to gcc on Travis?
20160908 19:01:02< celticminstrel> I'd guess it's supposed to be -Wunused-arguments.
20160908 19:01:37< celticminstrel> Ohh, hmm.
20160908 19:01:39< celticminstrel> Idea.
20160908 19:03:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160908 19:06:23< JyrkiVesterinen> I have looked at Travis logs too.
20160908 19:06:34< JyrkiVesterinen> The odd thing is that GCC is being used in Clang builds.
20160908 19:06:42< celticminstrel> Yeah, I have a possible fix for that.
20160908 19:07:24< JyrkiVesterinen> My guess is that it started happening when you changed one file from C++ to C.
20160908 19:07:33< JyrkiVesterinen> If you have a possible fix, that's great. :)
20160908 19:07:41< celticminstrel> But... I can't see where the CXX variable is actually defined, so I'm not sure if this will work...
20160908 19:07:48< celticminstrel> I guess I'll try it on a branch first.
20160908 19:09:41< irker852> wesnoth: Celtic Minstrel wesnoth:maybe-travis-fix de0c94fc3067 / .travis.yml: Fix Travis https://github.com/wesnoth/wesnoth/commit/de0c94fc3067b768cddebf74b894af6340e91ef8
20160908 19:17:28< celticminstrel> Can someone cancel this build for me? https://travis-ci.org/wesnoth/wesnoth/builds/158546442
20160908 19:17:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160908 19:18:06< celticminstrel> Not a huge deal if it's not cancelled, but it's redundant with the previous one since I forgot to commit before pushing the branch.
20160908 19:18:21-!- mjs-de [~mjs-de@x4db5c8ce.dyn.telefonica.de] has joined #wesnoth-dev
20160908 19:23:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160908 19:30:05-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 19:30:06< travis-ci> wesnoth/wesnoth#10774 (master - e654fbb : Celtic Minstrel): The build is still failing.
20160908 19:30:06< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158542290
20160908 19:30:06-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 19:30:56-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160908 19:34:09-!- gfgtdf [~chatzilla@x4e3697bb.dyn.telefonica.de] has joined #wesnoth-dev
20160908 19:38:42-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 19:38:43< travis-ci> wesnoth/wesnoth#10776 (maybe-travis-fix - de0c94f : Celtic Minstrel): The build has errored.
20160908 19:38:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158546796
20160908 19:38:43-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 19:40:25< celticminstrel> Bash syntax error. :/
20160908 19:45:46-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160908 19:46:23< irker852> wesnoth: Celtic Minstrel wesnoth:maybe-travis-fix f29d72d6e22c / .travis.yml: Fix Travis https://github.com/wesnoth/wesnoth/commit/f29d72d6e22ca44bbc24918e97440ac3437b24bf
20160908 19:49:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160908 19:50:02-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 19:50:03< travis-ci> wesnoth/wesnoth#10775 (maybe-travis-fix - e654fbb : Celtic Minstrel): The build failed.
20160908 19:50:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158546442
20160908 19:50:03-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 19:51:14< celmin> I guess no-one cancelled it.
20160908 19:55:19< celmin> Ohh, I think I just realized why Host MP Game got stuck at the loading screen.
20160908 19:55:52< celmin> My XCode build of wesnothd crashes, so maybe the game is not equipped to deal with that possibility/
20160908 19:55:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 20:01:27-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160908 20:13:30-!- mjs-de [~mjs-de@x4db5c8ce.dyn.telefonica.de] has quit [Remote host closed the connection]
20160908 20:15:50< vultraz> celmin: set_retval closes the window, so it wouldn't be a problem
20160908 20:16:02< celmin> vultraz: Yes it is?
20160908 20:16:15< celmin> Unless you're talking about something different from what I think you're talking about.
20160908 20:16:53< vultraz> nervermind
20160908 20:16:55< vultraz> nevermind
20160908 20:18:33< irker852> wesnoth: gfgtdf wesnoth:master 1c2bb78d158c / / (9 files in 4 dirs): add mp chatbox widget https://github.com/wesnoth/wesnoth/commit/1c2bb78d158c0889d907e2c6471b0002d2d26ce4
20160908 20:18:35< irker852> wesnoth: gfgtdf wesnoth:master 59f7fab5b499 / src/server/server.cpp: fix wesnothd https://github.com/wesnoth/wesnoth/commit/59f7fab5b49902ee36dac860b61c6c6df5853f18
20160908 20:18:37< irker852> wesnoth: gfgtdf wesnoth:master f37d5d941fed / src/synced_context.cpp: Don't freeze the application when waiting too long for a random seed. https://github.com/wesnoth/wesnoth/commit/f37d5d941fed519cae78ad5a344ee342ed64a484
20160908 20:18:39< irker852> wesnoth: gfgtdf wesnoth:master 00d04b0b918a / src/game_initialization/connect_engine.hpp: use c++11 =delete in connect_engine https://github.com/wesnoth/wesnoth/commit/00d04b0b918a786589e7129a62b1be91f969c831
20160908 20:18:42< celmin> Ooh.
20160908 20:20:45< celmin> gfgtdf: Do you ever have problems with the Wesnoth process not terminating after you quit?
20160908 20:21:02-!- ancestral [~ancestral@209.248.22.57] has joined #wesnoth-dev
20160908 20:21:08< gfgtdf> celmin: hmm no, do i ned to quit froma  spaecial location ?
20160908 20:21:24-!- JyrkiVesterinen [~JyrkiVest@87-92-54-42.bb.dnainternet.fi] has quit [Quit: .]
20160908 20:21:34< celmin> gfgtdf: No, but I think it may be related to the -wconsole commandline option...
20160908 20:22:03< gfgtdf> hmm i usually don't use -wconsole.
20160908 20:22:11< celmin> Given that I somehow had three leftovers of that in the task manager.
20160908 20:23:29< irker852> wesnoth: Charles Dang wesnoth:master 7950fafba656 / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/7950fafba6568c07d3423f40291589b6a091bd98
20160908 20:23:38< celmin> …eh?
20160908 20:23:43< celmin> Oh.
20160908 20:23:51< vultraz> celmin: I've noticed it happens with wesnothd, but not wesnoth
20160908 20:23:52< celmin> New widget, of course.
20160908 20:25:02< vultraz> celmin: could you fix the password prompt displaying every single time you connect to the server?
20160908 20:25:14< celmin> Not sure, maybe.
20160908 20:26:00< vultraz> gfgtdf: many thanks for doing that :)
20160908 20:26:40< celmin> Ugh, what. :|
20160908 20:26:59< celmin> Oh, I guess leaving out the = might fix that?
20160908 20:27:02< celmin> Worth a try.
20160908 20:29:15< irker852> wesnoth: Celtic Minstrel wesnoth:master 8e8cbfb5d2a8 / .travis.yml: Fix for Travis compiling C file with g++/clang++ https://github.com/wesnoth/wesnoth/commit/8e8cbfb5d2a8140591f52fdb60f6f099258e0b05
20160908 20:30:15-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 20:30:16< travis-ci> wesnoth/wesnoth#10777 (maybe-travis-fix - f29d72d : Celtic Minstrel): The build failed.
20160908 20:30:16< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158554980
20160908 20:30:16-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 20:31:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160908 20:31:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 20:31:58< vultraz> the wiidget should probably be just called 'chatbox', though
20160908 20:32:08< celmin> Well, you can change that trivially. :)
20160908 20:32:09< vultraz> or 'chat_area'
20160908 20:32:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 20:32:15< vultraz> yes
20160908 20:32:22< celmin> Though I don't think there's much point.
20160908 20:32:25< vultraz> first I'm moving the wml into the proper place
20160908 20:32:38< celmin> It is really an MP thing after all.
20160908 20:32:42-!- wedge009 [~Thunderbi@60.241.236.92] has joined #wesnoth-dev
20160908 20:32:45< celmin> Actually, I think the WML is fine where it is.
20160908 20:32:56< celmin> Assuming the chatbox integrates tabs.
20160908 20:32:59< celmin> Does it?
20160908 20:33:02< vultraz> yes
20160908 20:33:19< celmin> Then MP Connect/Wait will need a different definition anyway.
20160908 20:33:30< celmin> One without tabs.
20160908 20:33:31< vultraz> why?
20160908 20:33:59< vultraz> anyway, definitions of widgets shouldn't be with dialogs
20160908 20:34:04< celmin> Well, it's been done before.
20160908 20:34:10< celmin> Just look at the titlescreen, for example.
20160908 20:34:17< celmin> [window_definition] at the top there.
20160908 20:34:24< vultraz> granted
20160908 20:34:29< vultraz> I'd rather split the wml out
20160908 20:34:43< vultraz> it's easier to manage
20160908 20:34:53< celmin> I think it makes sense to keep it there, because it's related to the title screen and does not have general application elsewhere.
20160908 20:35:23< vultraz> I'm talking about the chatbox :|
20160908 20:35:26< celmin> I guess there's a possibility that that does not apply to MP chat. Perhaps the tabbed/multiroom definition would have general applicability in some other currently-nonexistent place.
20160908 20:38:41< vultraz> chat is currently an mp thing, yes.
20160908 20:43:04< gfgtdf> celmin: well the whole point of my commit was use in the mp connect later.
20160908 20:43:12< celmin> I know.
20160908 20:43:49< gfgtdf> celmin: i see n reason agisnt tabs in the mp connect, i actuall think it'd be nice to have a 'game' an 'lobby' chat tab at least.
20160908 20:44:56< vultraz> indeed
20160908 20:45:08< vultraz> perfect proposal 
20160908 20:46:36-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 20:47:03-!- wedge009 [~Thunderbi@60.241.236.92] has quit [Ping timeout: 244 seconds]
20160908 20:47:04-!- wedge010 is now known as wedge009
20160908 20:47:25< irker852> wesnoth: Charles Dang wesnoth:master 765f0bfc6a51 / data/gui/ (schema.cfg widget/chatbox.cfg window/lobby_main.cfg): Moved chatbox code to its own file and updates schema https://github.com/wesnoth/wesnoth/commit/765f0bfc6a51ee355fdc66dc785db7d7a6e4677a
20160908 20:47:43< celmin> gfgtdf: Well maybe.
20160908 20:51:33-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 20:51:33< travis-ci> wesnoth/wesnoth#10778 (master - 00d04b0 : gfgtdf): The build is still failing.
20160908 20:51:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158562856
20160908 20:51:33-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 20:52:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160908 20:52:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 20:54:18< vultraz> celmin: so I've been thinking about something... we currently have no way spawn, say, a dropdown list with an arbitrarily-defined layout 
20160908 20:55:47< vultraz> it was mentioned on facebook by dugi that it could be useful to show extra data in hover/tooltip form in certain cases.
20160908 20:55:57< vultraz> but we can't do that
20160908 20:55:59< celmin> ?
20160908 20:56:02< vultraz> because the problems are the same
20160908 20:56:18< vultraz> we cannot pass custom grids 
20160908 20:56:22< vultraz> therefor
20160908 20:56:28< celmin> I don't quite get the issue.
20160908 20:56:42< vultraz> Well, let's take the dropdown list
20160908 20:56:46-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160908 20:56:46-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160908 20:56:52< vultraz> right now, we're baking every feature we want in there
20160908 20:57:04< vultraz> but I'd also like one with checkboxes
20160908 20:57:16< celmin> But that should have different behaviour.
20160908 20:57:21< celmin> (No dismiss on click.)
20160908 20:57:28< vultraz> eh, true
20160908 20:57:30< vultraz> bad example
20160908 20:57:36< celmin> (Well, unless the click is outside.)
20160908 20:57:42< vultraz> say we wanted a right-click menu on players in the lobby
20160908 20:58:07< vultraz> that brings up Friend/Ignore/PM options, and some info about them above the list
20160908 20:58:11-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 20:58:38-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 20:59:23< vultraz> or, in the case of tooltips
20160908 20:59:27< vultraz> let's say we want to say
20160908 20:59:37-!- ancestral [~ancestral@209.248.22.57] has quit [Quit: i go nstuf kthxbai]
20160908 20:59:40< vultraz> 'display a nicely formatted infograph' about this player when you hover over their name
20160908 20:59:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 264 seconds]
20160908 20:59:51< vultraz> but we can't since tooltips are just text
20160908 21:00:17< vultraz> it'd be nice if we could specify some sort of data for the tooltips
20160908 21:00:20< vultraz> or dropdowns
20160908 21:00:27< celmin> With your menu example I don't understand how that's not already possible.
20160908 21:00:40< vultraz> since what we want is the behavior, not necessarily the layout
20160908 21:02:45< vultraz> the menu example isn't possible since the dialog is only a list
20160908 21:02:47< vultraz> nothing else
20160908 21:03:48< celmin> So you mean you want extra text above the listbox.
20160908 21:04:00< celmin> I'm not sure I like the idea anyway.
20160908 21:04:09< celmin> Adding a right-click menu is a good idea though, maybe I'll try it.
20160908 21:04:39< vultraz> what don't you like about my idea?
20160908 21:05:27< celmin> Well, maybe it depends on specifically what info you're thinking of putting there.
20160908 21:05:56< vultraz> irrelevant 
20160908 21:07:06< vultraz> dugi's suggestion for the addons manager was for addon details, though 
20160908 21:09:08< celmin> In the tooltip?
20160908 21:09:16< celmin> How is the tooltip currently constructed?
20160908 21:09:30< vultraz> I dunno
20160908 21:09:48< vultraz> it has a custom window, and it's own "dialog"
20160908 21:09:56< celmin> I'm not sure on the drop down list idea, but allowing a grid in the tooltip might be reasonable.
20160908 21:10:03< vultraz> but the handling is baked into the gui2 internals
20160908 21:10:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:10:39< celmin> Blah, this is annoying.
20160908 21:10:50-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 21:11:11-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 21:11:12< travis-ci> wesnoth/wesnoth#10779 (master - 7950faf : Charles Dang): The build is still failing.
20160908 21:11:12< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158564026
20160908 21:11:12-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 21:11:28< celmin> What makes MSVC create the .user file...
20160908 21:11:40< celmin> I want to compare "defaults" to the one in the repo.
20160908 21:14:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:15:21< celmin> vultraz: You're not planning to rename those source files, are you?
20160908 21:15:34< celmin> If you are, I'll hold off on updating projects.
20160908 21:15:43< celmin> (But please do it asap in that case.)
20160908 21:15:45< vultraz> yeah I might as well
20160908 21:20:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160908 21:21:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:22:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 21:22:45-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 21:22:46< travis-ci> wesnoth/wesnoth#10780 (master - 8e8cbfb : Celtic Minstrel): The build is still failing.
20160908 21:22:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158565553
20160908 21:22:46-!- travis-ci [~travis-ci@ec2-54-144-46-154.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 21:22:58 * celmin waits for vultraz 
20160908 21:23:08< vultraz> yeah, working on it
20160908 21:23:11< vultraz> im renaming the widget
20160908 21:23:14< vultraz> not just the files
20160908 21:23:26< celmin> I suppose what you really need here is sed.
20160908 21:23:39< celmin> That'd do it all in one go, right? Though you'd want to review it just to be sure.
20160908 21:23:55< celmin> Something like sed -i~ s/mp_chatbox/chatbox/
20160908 21:24:11< celmin> Maybe it needs a space after -i
20160908 21:24:33< vultraz> got everything, I think
20160908 21:24:35< celmin> Might also need to specify target dir(s).
20160908 21:24:36< celmin> Yay.
20160908 21:24:43< celmin> Building first to be sure?
20160908 21:24:53< vultraz> of course
20160908 21:25:56< irker852> wesnoth: Charles Dang wesnoth:master b07810608a07 / / (12 files in 7 dirs): Renamed the mp_chatbox widget simply "chatbox" https://github.com/wesnoth/wesnoth/commit/b07810608a077b9582a20e30ea4091000d5b6e12
20160908 21:26:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:26:44< vultraz> go ahead
20160908 21:30:01-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:30:15-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160908 21:30:17< vultraz> I think we need to work some visual variety into our new fullscreen dialogs
20160908 21:30:27-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160908 21:30:33< vultraz> the background is so bland :/
20160908 21:30:55< vultraz> one benefit the old dialogs had
20160908 21:31:01< vultraz> a more interesting background
20160908 21:31:35< celmin> I'm not quite sure what gfgtdf was doing in 59f7fab5…
20160908 21:31:44< celmin> I feel like std algorithms could've been used, but not sure.
20160908 21:32:19< celmin> I'm just waiting for my Mac to pull the changes from my Windows PC so that I can update the XCode project.
20160908 21:32:31< celmin> It's being super-slow as usual.
20160908 21:32:37< celmin> Probably because I still have Firefox open.
20160908 21:33:04< celmin> Ah, here it comes.
20160908 21:36:39< irker852> wesnoth: Celtic Minstrel wesnoth:master 844cfc5fbf8c / src/storyscreen/render.cpp: Attempt to fix Travis missing initializer warnings https://github.com/wesnoth/wesnoth/commit/844cfc5fbf8cf08cf9d20810fdda5e199c6bd6f1
20160908 21:36:41< irker852> wesnoth: Celtic Minstrel wesnoth:master 0d47ea252222 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/0d47ea252222bd627edb6528767a3dd8021713a4
20160908 21:36:43< irker852> wesnoth: Celtic Minstrel wesnoth:master 8a80af4c6901 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/8a80af4c6901cdeb35d0dc94be95a109be94536c
20160908 21:38:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:41:38< celmin> I can't see anything in the network transmission -> loading screen change that would make it always request your password...
20160908 21:42:33< celmin> vultraz: When did that start?
20160908 21:42:42< celmin> Can I get a commit hash of a point where it was working properly?
20160908 21:42:46< vultraz> after i pulled your changes yesterday
20160908 21:42:53< celmin> Okay, so...
20160908 21:43:12< celmin> That means it was working at 6aee1082983d4f34ca3fc5e0625d31c90ac912c4, right?
20160908 21:43:33< celmin> Your flag setter -> struct setter commit.
20160908 21:44:33< celmin> And it was definitely broken before 208a43cff16d369240d49d6ec4af8b31d35b2e20
20160908 21:45:22< vultraz> basically, yeah
20160908 21:45:56-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 21:45:57< travis-ci> wesnoth/wesnoth#10781 (master - 765f0bf : Charles Dang): The build is still failing.
20160908 21:45:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158572775
20160908 21:45:58-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 21:47:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160908 21:47:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 21:49:54-!- Appleman1234_ [~Appleman1@KD119104100141.au-net.ne.jp] has joined #wesnoth-dev
20160908 21:51:24 * celmin is doing a bisect on the Windows PC right now, for the record.
20160908 21:51:32-!- Appleman1234 [~Appleman1@KD119104101149.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160908 21:52:20-!- Appleman1234_ is now known as Appleman1234
20160908 21:53:36< celmin> I feel like I've said this before, but (random thought) I wonder if the game supports unit variations having sub-variations.
20160908 21:53:44< celmin> (I have no idea why you'd want that, mind you.)
20160908 21:56:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20160908 21:57:25< Aginor> celmin: out of curiosity, why are you bisecting?
20160908 21:57:58< celmin> Aginor: Apparently I did something to make the MP server ask for your password even if it's saved, or something.
20160908 21:58:33< Aginor> ouch :/
20160908 22:01:15< vultraz> Aginor: any updates on you potentially being on the board?
20160908 22:03:57-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 22:03:58< travis-ci> wesnoth/wesnoth#10782 (master - b078106 : Charles Dang): The build is still failing.
20160908 22:03:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158581713
20160908 22:03:58-!- travis-ci [~travis-ci@ec2-54-158-197-219.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 22:06:29-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20160908 22:07:10-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 22:08:07< Aginor> vultraz: no
20160908 22:08:23< vultraz> alright
20160908 22:08:35< Aginor> I've raised it with the appropriate people and it seems it'll be bounced higher in the organisation
20160908 22:11:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160908 22:12:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 22:16:59-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has joined #wesnoth-dev
20160908 22:17:00< travis-ci> wesnoth/wesnoth#10783 (master - 8a80af4 : Celtic Minstrel): The build is still failing.
20160908 22:17:00< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/158584154
20160908 22:17:00-!- travis-ci [~travis-ci@ec2-54-81-146-178.compute-1.amazonaws.com] has left #wesnoth-dev []
20160908 22:21:28< vultraz> celmin: thoughts https://drive.google.com/file/d/0B-mR9s8FduLLSjlMVVAxdFRoaWc/view?usp=sharing
20160908 22:21:59< celmin> o.o
20160908 22:22:08< celmin> What have you done.
20160908 22:23:21< vultraz> flipped one of lordbob's story images, applied an alpha gradient and darkened it, then saved it and drew it on the canvas with a custom window definition. Obviously that last bit isn't optimal, but I think I know how to do it better. The point is the effect
20160908 22:23:43< celmin> It looks nice, but...
20160908 22:24:00< celmin> Is this just supposed to be a general thing, or change depending on the selection?
20160908 22:24:00< vultraz> (all but the gradient could be done with ipfs, actually, I think. we really need a gradient function)
20160908 22:24:23< vultraz> it could possibly change with the selection
20160908 22:24:27< vultraz> I have not investigated that
20160908 22:24:57< vultraz> only on a per-type basis, of course
20160908 22:25:29< vultraz> it's just a proof-on-concept to see what you think.
20160908 22:25:53< Aginor> there's not enough contrast between the labels and the light background
20160908 22:26:01< Aginor> over on the top right
20160908 22:26:22< celmin> I thought there might already be such an IPF, but I guess not.
20160908 22:26:26< vultraz> agreed with that
20160908 22:26:41< celmin> A mix of PLOT_ALPHA and ADJUST_ALPHA seems like what we'd want.
20160908 22:27:21< celmin> Actually, maybe just replace ADJUST_ALPHA with this, since it's otherwise almost the same as O
20160908 22:28:22< vultraz> Aginor: obviously some work needs to be done. the question is whether I should work on it :)
20160908 22:30:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160908 22:30:38< vultraz> because if no one likes the idea, it's not worth it
20160908 22:32:42< vultraz> I think it'd be a nice way to showcase some of our nice art and remove some of the monotony of the background
20160908 22:33:41< celmin> I wonder if anyone cares enough to test if GUI2 themes work now.
20160908 22:35:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 22:38:14< vultraz> how would one do that, when we don't have any other themes? :P
20160908 22:38:24< celmin> By making one and testing if it works.
20160908 22:38:29< vultraz> AFAIK gui2 themes != gui1 themes
20160908 22:38:35< celmin> Which means making an alternate definition of at least one dialog.
20160908 22:38:46< celmin> Yeah, they're not the same.
20160908 22:38:46< vultraz> yeah, no
20160908 22:38:50< celmin> No what?
20160908 22:38:58< vultraz> not gonna bother with that :P
20160908 22:39:15< celmin> It's not like you have to actually make a new definition. You could copy an existing one and tweak it. :P
20160908 22:39:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160908 22:39:53< celmin> Maybe I'll try it at some point. I have this vague impression that there are still some missing fallback cases.
20160908 22:40:02< celmin> (That is, some things that don't fall back to the default theme.)
20160908 22:48:23< vultraz> anyway, I think I know how I can set that type of background image without new definitons
20160908 22:48:35< vultraz> I'll add an image drawing layer to the window canvas
20160908 22:48:52< vultraz> then i can set it and update canvas from the c++
20160908 22:49:35< vultraz> if you adjust ADJUST_ALPHA to be a gradient function this can be done without any new images :)
20160908 22:49:58< vultraz> or definitions
20160908 22:50:18< celmin> Add an image drawing layer? What does this mean?
20160908 22:50:27< vultraz> add an [image]
20160908 22:50:39< vultraz> in [background] [draw]
20160908 22:50:52< vultraz> name = "(background_overlay)"
20160908 22:51:05< celmin> Ah, so updating the basic window definition.
20160908 22:51:07< vultraz> background_overlay will be a formula variable that can be set
20160908 22:51:16< vultraz> once it's set, the canvas updates
20160908 22:51:16< Aginor> vultraz: I will be sorely disappointed if you write a custom blitting function for this
20160908 22:51:17< vultraz> see?
20160908 22:51:24< celmin> Will that work if background_overlay is not defined?
20160908 22:51:32< vultraz> it will default to ""
20160908 22:51:46< vultraz> Aginor: custom...blitting function?
20160908 22:51:47< vultraz> no?
20160908 22:51:58< vultraz> I'm just using the gui2 canvas api
20160908 22:52:21< Aginor> ok
20160908 22:53:01< vultraz> (random thing that'd really, really be nice is alpha fadeout on canvas layers, but that's rather difficult)
20160908 22:53:53< vultraz> (or really alpha manipulation or anything at all)
20160908 22:55:41< vultraz> on*
20160908 22:56:55< vultraz> Aginor: for the record, I'm flattered you think I could write a custom blitting function xD
20160908 22:59:10-!- edgrey [~edgrey@178.204.112.1] has quit [Quit: Konversation terminated!]
20160908 22:59:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160908 23:04:36< vultraz> hmmmm
20160908 23:04:47< vultraz> one can access the canvas on a per-dialog basis
20160908 23:04:54< vultraz> it'd be nice if this could be used for that...
20160908 23:05:56< vultraz> except there's no controls for canvas drawing in [window]
20160908 23:05:58< vultraz> HM
20160908 23:06:05< vultraz> perhaps
20160908 23:06:10< vultraz> this should be added
20160908 23:07:15< celmin> You access the canvas as window.canvas(n) or something.
20160908 23:07:23< celmin> Some dialogs do that to add additional formula variables.
20160908 23:07:43< celmin> [Sep 08@6:51:24pm] celmin: Will that work if background_overlay is not defined?
20160908 23:07:44< celmin> [Sep 08@6:51:32pm] vultraz: it will default to ""
20160908 23:07:46< celmin> No, I mean...
20160908 23:07:58< celmin> Does [image] know not to do anything when the image is empty?
20160908 23:08:05< vultraz> I would assume so
20160908 23:08:09< vultraz> if not that's a bug
20160908 23:08:29< celmin> (Also, if the formula variable is actually undefined, it might end up being equivalent to looking for an image called "(null)".)
20160908 23:09:16< vultraz> and yes, you can use window.canvas
20160908 23:09:28< celmin> Hmm, "malformed credentials"?
20160908 23:09:28< vultraz> but that usually relies on there actually being something to set
20160908 23:09:42< celmin> But it didn't ask me for a password...
20160908 23:09:48< vultraz> I see window.canvas().set_variable
20160908 23:10:13< vultraz> but if I don't have something set in the canvas that says [image] name = "(variable)"
20160908 23:10:16< vultraz> it won't do anything
20160908 23:10:17< vultraz> see?
20160908 23:10:31< celmin> ?
20160908 23:10:39< vultraz> sigh
20160908 23:10:42< celmin> What are you talking about.
20160908 23:10:58< celmin> Setting a variable does something regardless, though obviously it won't have an effect if nothing accesses the variable.
20160908 23:11:10< vultraz> yes
20160908 23:11:30< vultraz> and you cannot add that 'something' to access it on a per-window basis
20160908 23:11:41< vultraz> only in [window_definition]
20160908 23:11:57< vultraz> this is why some dialogs like the titlescreen use a custom definition
20160908 23:12:04< vultraz> in order to set canvas accessors
20160908 23:12:22< celmin> Well, yes.
20160908 23:12:26< vultraz> I propose enabling this for [window] instances
20160908 23:12:33< celmin> Only the definition has access to the formula definition.
20160908 23:12:39< vultraz> oh?
20160908 23:12:39< celmin> Why do you need it for [window] instances?
20160908 23:12:45< celmin> ^formula variables
20160908 23:12:56< vultraz> to avoid creating new definitions?
20160908 23:13:11< celmin> BTW vultraz, in my bisect, all commits worked. :|
20160908 23:13:16< vultraz> or I suppose I could just add it to the master definiton
20160908 23:13:31< vultraz> I guess that works too
20160908 23:13:45< celmin> vultraz: You could either 1) Create a general definition for windows with a background or 2) Add it to the default window definition.
20160908 23:14:04< vultraz> I think we'd only want this in borderless, anyway
20160908 23:15:40< celmin> Okay, so where is my preferences file.
20160908 23:16:23< vultraz> (for the record, my password looks correct in my prefs file)
20160908 23:16:26< vultraz> hmm
20160908 23:16:46< vultraz> I wonder if you can modify stuff like x/y/w/h...
20160908 23:17:00< vultraz> I guess by making them variables :D
20160908 23:17:39< vultraz> though that seems rather... overkill
20160908 23:17:41< vultraz> oh well
20160908 23:21:19-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160908 23:21:19< celmin> vultraz: Weird thing is that I get the bad credentials error, but it doesn't ask me for the password.
20160908 23:21:34< vultraz> odd
20160908 23:22:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20160908 23:22:24-!- wedge010 is now known as wedge009
20160908 23:26:09< vultraz> "expected string but found null ((null))"
20160908 23:26:11< vultraz> well, ok
20160908 23:26:15< vultraz> so that's what happens :|
20160908 23:27:26< vultraz> maybe I'll make a borderless+bg image definition
20160908 23:30:12< celmin> Heh, I did mention something like that earlier, didn't I?
20160908 23:30:31< celmin> You could make a separate definition, or just make sure that the variable is set to "" initially.
20160908 23:30:42< vultraz> dunno how to do that
20160908 23:31:48< vultraz> .. blah..
20160908 23:31:59< vultraz> ...
20160908 23:33:07< vultraz> so it seems I cannot set variables using existing formula variables
20160908 23:33:09< vultraz> :|
20160908 23:33:14< vultraz> ie, I cannot do
20160908 23:33:32< vultraz> width - image_width
20160908 23:33:39< vultraz> in set_variable
20160908 23:34:07< vultraz> this seems like an oversight..
20160908 23:35:10< celmin> What?
20160908 23:36:09< vultraz> ok, say I have x = "(background_overlay_x")
20160908 23:36:22< vultraz> since I'd like to be able to control x placement
20160908 23:36:45< vultraz> for this case, I'd like it to be "(width - image_width)"
20160908 23:37:09< vultraz> how would I set that from canvas.set_variable?
20160908 23:37:37< celmin> Why not use that directly in the WML?
20160908 23:38:06< vultraz> because this is supposed to be a general-purpose definition? 
20160908 23:38:13< celmin> What?
20160908 23:38:28< celmin> That doesn't feel like it answers the question.
20160908 23:38:44< vultraz> I don't want to make a new definition for every single window that might use this
20160908 23:38:53< vultraz> every window may want the place the background image differently
20160908 23:39:30< celmin> Well, you could set_variable("background_overlay_x", width - image_width) if the variables are known to the C++ code.
20160908 23:39:37< celmin> I know width is, maybe not image_width though...
20160908 23:39:54< vultraz> hmmm
20160908 23:39:56< vultraz> I have an idea...
20160908 23:40:21< vultraz> what if I add a getter for canvas::variables_
20160908 23:40:36< celmin> What?
20160908 23:40:56< vultraz> eh, but then image_width might not be in scope..
20160908 23:41:42< celmin> What?
20160908 23:42:15< vultraz> tcanvas stores all its variables in a map_formula_callable object called variables_
20160908 23:42:34< celmin> Oh right, image_width has to be set at some point, so it must be known to the C++ code...
20160908 23:43:04< vultraz> blah
20160908 23:43:19< celmin> So why not do the calculation in C++?
20160908 23:43:23< vultraz> it's set locally in the canvas image drawer 
20160908 23:43:33< celmin> Ah.
20160908 23:43:46< celmin> And the background is unknown there.
20160908 23:43:49< vultraz> are you proposing getting the dimensions of the canvas
20160908 23:44:02< vultraz> and subtracting the size of the image :|
20160908 23:44:12< vultraz> that's rather... inefficient 
20160908 23:44:17< celmin> Something like that? How is it inefficient?
20160908 23:44:23< vultraz> for the dimensions to be known, we need to load the image onto a surface
20160908 23:44:40< celmin> Don't you need to do that anyway?
20160908 23:44:53< Aginor> extend the image class to cache the information of the image
20160908 23:44:58< Aginor> like dimensions
20160908 23:45:22< Aginor> don't assume that it'll always be a surface
20160908 23:46:24< vultraz> "	 * This value is only used when the image name is a formula. If it isn't a
20160908 23:46:26< vultraz> 	 * formula the image will be loaded in the constructor. If it's a formula it
20160908 23:46:27< vultraz> 	 * will be loaded every draw cycles. This allows 'changing' images.
20160908 23:46:29< vultraz> 	 */"
20160908 23:46:45< vultraz> hm
20160908 23:47:22< celmin> That seems super-inefficient.
20160908 23:47:33< celmin> At least only reload if it has actually changed.
20160908 23:47:59< vultraz> yes, Aginor has noted this
20160908 23:49:39< vultraz> I just don't see why one cannot pass a formula via set_variable... to be calculated later..
20160908 23:52:47< vultraz> uh
20160908 23:53:05< vultraz> this.. doesn't make sense
20160908 23:53:07< vultraz> you have this
20160908 23:53:09< vultraz> game_logic::map_formula_callable local_variables(variables);
20160908 23:53:14< vultraz> unsigned w = w_(local_variables);
20160908 23:53:32< celmin> What?
20160908 23:53:40< vultraz> so why does it think (image_width) is a string :
20160908 23:54:29< vultraz> oh, maybe because it's set as 
20160908 23:54:33< vultraz> ('image_width')
20160908 23:54:42< celmin> What?
20160908 23:54:56< celmin> That's not referencing a variable, BTW, it's just a string literal.
20160908 23:55:15< vultraz> yes
20160908 23:55:26< vultraz> ok, so if you do this..
20160908 23:55:32< vultraz> window.canvas()[0].set_variable("background_overlay_x", variant("width - image_width"));
20160908 23:55:37< vultraz> it becomes a string literal
20160908 23:55:41< celmin> Obviously.
20160908 23:55:51< vultraz> and you cannot do without the quotes because then it's OOS for the compiler
20160908 23:55:56< celmin> OOS?
20160908 23:56:00< vultraz> out of scope
20160908 23:56:30< celmin> There is probably no way whatsoever that it can be done.
20160908 23:56:34< vultraz> how is there no way to say "treat this as formula variables" :|
20160908 23:57:10< celmin> A formula object is just a bundle of data, there's no way for one of its fields to be calculated from the others.
20160908 23:57:13-!- fabi_ [~fabi@176.0.92.30] has joined #wesnoth-dev
20160908 23:57:29< vultraz> I.. what?
20160908 23:57:39< vultraz> that happens all the time, doesn't it
20160908 23:57:44< celmin> What? Where?
20160908 23:57:57< vultraz> what else is it doing when I set (stuff) in WML
20160908 23:58:36< celmin> That's a formula.
20160908 23:58:47< celmin> It calculates a value from the formula object.
20160908 23:58:54< vultraz> yes
20160908 23:58:57< vultraz> that's what I want :|
20160908 23:59:00< vultraz> to pass a formula
20160908 23:59:07< celmin> No, what you want is to set a variable to a formula.
20160908 23:59:11< celmin> That's not possible.
20160908 23:59:20< vultraz> blagh
20160908 23:59:22< celmin> More specifically, you want to set a formula variable to a formula.
20160908 23:59:42< vultraz> this would be possible if we weren't using a compiled language
20160908 23:59:48< vultraz> so
20160908 23:59:51< vultraz> what do you advise
--- Log closed Fri Sep 09 00:00:24 2016