--- Log opened Fri Sep 16 00:00:36 2016
20160916 00:02:22< tad_> celmin: The problem is "is tile visible" is you need to know the viewport extents. Given the way to code is, you can probably work it out. But it's not very future-proof if the UI changes to render the entire map and use a viewport on that instead of rendering just what's on-screen into a viewport.
20160916 00:04:05< irker112> wesnoth: Gregory A Lundberg wesnoth:master 8be428e9463d / changelog src/map/map.cpp: Honor special locations in terrain mask https://github.com/wesnoth/wesnoth/commit/8be428e9463daab3730550c79794c8af87ce19b1
20160916 00:04:08< irker112> wesnoth: gfgtdf wesnoth:master b9a97d893d40 / changelog src/map/map.cpp: Merge pull request #775 from GregoryLundberg/GL_terrain_mask_positions https://github.com/wesnoth/wesnoth/commit/b9a97d893d40136e32ee3b508dddde9464ce9dc4
20160916 00:04:12< celmin> tad_: There was a minor regression in [message] when I ported it to Lua which I want to fix - it now scrolls between every two units talking even if they're right next to each other, unless I'm mistaken.
20160916 00:04:51< celmin> Previously it attempted to not scroll if the second unit was already onscreen.
20160916 00:04:58< tad_> ISTM it usually bounces back and forth when two units alternate [message]s
20160916 00:05:18< celmin> Right, it shouldn't scroll in that case.
20160916 00:05:36< celmin> (Unless they don't both fit onscreen at the same time, of course.)
20160916 00:06:56< tad_> I would not mind if it flipped back and forth if they're "more than X tiles apart" as well. But less than X and both on-screen, would be smoother and faster to not scroll so often.
20160916 00:07:06 * tad_ is testing ...
20160916 00:07:09< celmin> Yeah, that's how it's supposed to be.
20160916 00:07:25< celmin> "more than X tiles apart" probably depends on the viewport size as well.
20160916 00:08:00< celmin> Maybe it would suffice to add an option to the functions that scroll to a tile...
20160916 00:08:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160916 00:08:11< celmin> minimal=yes
20160916 00:08:31< celmin> --If set, the game will not scroll if the tile is already onscreen.
20160916 00:08:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 00:08:44< celmin> Or maybe something like...
20160916 00:09:26< celmin> I don't have a word for it, but specify a minimum number of tiles between the target tile and the screen edge, and if set (to any value), the game will not scroll if the tile is at least that far from the edge of the viewport.
20160916 00:09:28< tad_> At present, HttT S03 .. units on adjacent tiles and it jumps the 1-tile scroll for each message
20160916 00:09:51< celmin> I guess these could also be options in eg [scroll_to].
20160916 00:11:56< tad_> Well, TBH, as a design change, if it bothered me, I'd just add scroll=no
20160916 00:12:21< celmin> It's still a regression relative to 1.12 though.
20160916 00:12:37 * tad_ is checking 1.12.6 ...
20160916 00:12:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160916 00:14:50< tad_> celmin: You are correct, 1.12.6 does NOT jump if they're next to each other or close by.
20160916 00:22:55-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160916 00:25:29-!- Appleman1234 [~Appleman1@KD119104049219.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160916 00:28:01-!- travis-ci [~travis-ci@ec2-54-204-241-243.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 00:28:02< travis-ci> wesnoth/wesnoth#10974 (master - b9a97d8 : gfgtdf): The build is still failing.
20160916 00:28:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160324630
20160916 00:28:03-!- travis-ci [~travis-ci@ec2-54-204-241-243.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 00:29:11-!- gfgtdf [~chatzilla@x4e368915.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]]
20160916 00:36:12< tad_> Looking at that travis failure: I don't see any errors with cmake on linux. But the files are in different directories here. wesnoth.dir/gui/dialogs intead of wesnoth-game.dir/gui/dialogs .. seems odd to me. Am I missing something on this end?
20160916 00:36:38< celmin> What?
20160916 00:36:46 * celmin is confused by the .dir
20160916 00:36:53< tad_> Building CXX object src/CMakeFiles/wesnoth-game.dir/gui/dialogs/folder_create.cpp.o
20160916 00:37:12< celmin> Oh.
20160916 00:37:13< tad_> on my system it is in wesnoth.dir not wesnoth-game.dir
20160916 00:37:32< celmin> I dunno, maybe there's an option passed to CMake or something?
20160916 00:38:06< celmin> The Travis failure is (IIRC) Vultraz's new credits thing.
20160916 00:38:19< celmin> I have yet to see if I get it in XCode.
20160916 00:38:28< tad_>  error: ‘std::stringstream’ has no member named ‘swap’
20160916 00:38:33< celmin> Might consider stashing for that purpose.
20160916 00:39:40< tad_> Ah. gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4
20160916 00:40:03< tad_> I'm on gcc 6
20160916 00:40:21< celmin> Yeah, I guess 4.8 isn't quite fully C++11-compliant or something.
20160916 00:40:32< tad_> prolly
20160916 00:40:40< celmin> Which isn't a huge issue, since MSVC 2013 isn't either, but…
20160916 00:41:03< celmin> If someone else doesn't get to it first, I'll fix it within a couple of days.
20160916 00:41:39< tad_> I was sorta nice to see all those green checkmarks on the PRs .. to bad it didn't last :)
20160916 00:42:04< celmin> Oh, the Travis Passed mark.
20160916 00:42:45< celmin> I'm guessing no-one else will get to it first, because probably no dev is actually using GCC 4.8.
20160916 00:43:10< celmin> I have no idea if my clang supports stringstream::swap, though I think it likely does.
20160916 00:47:33< tad_> Yep, looks like it was an issue in 4.8 and fixed in 6
20160916 00:49:24< celmin> What? It wasn't fixed until 6?
20160916 00:51:05< tad_> Don't see anything other than the defect report.
20160916 00:51:39< tad_> So 'before 6.2.1' is all I know
20160916 00:53:00< tad_> move was fixed in 4.7 .. might be a workaround there .. dunno
20160916 00:57:59-!- louis94 [~~louis94@91.178.241.245] has quit [Quit: Konversation terminated!]
20160916 00:58:14-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160916 01:30:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160916 01:40:39-!- Appleman1234 [~Appleman1@KD119104049219.au-net.ne.jp] has joined #wesnoth-dev
20160916 01:57:20-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160916 02:54:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160916 02:58:13< vultraz> celticminstrel: looks good
20160916 02:58:36< celticminstrel> Want to merge?
20160916 02:58:51< celticminstrel> I do have Firefox open, oddly enough, so I could do the merge myself.
20160916 02:59:18< irker112> wesnoth: Celtic Minstrel wesnoth:master fe08701b7ca3 / src/ (27 files in 13 dirs): Change most vector<bool> to dynamic_bitset https://github.com/wesnoth/wesnoth/commit/fe08701b7ca3639b17dca20023d2bb34433042c6
20160916 02:59:20< irker112> wesnoth: Charles Dang wesnoth:master 4cf5be674c6e / src/ (27 files in 13 dirs): Merge pull request #781 from wesnoth/dynamic_bitset https://github.com/wesnoth/wesnoth/commit/4cf5be674c6e2972c26a43a1d74315cf671f5f96
20160916 03:00:20< celticminstrel> any_rows_shown() could be removed now, if you want. I'd consider it optional.
20160916 03:01:04< vultraz> i need to consider
20160916 03:01:15< vultraz> you're right that it might be more efficient
20160916 03:09:50< vultraz> [05:23:08]	tad_	gui/widgets/window.cpp:	std::cerr << "window key handler fires\n";
20160916 03:09:52< vultraz> oshit
20160916 03:10:02< vultraz> accidentally committed debugging code :/
20160916 03:10:15< celticminstrel> That's what I thought it was.
20160916 03:10:41< celticminstrel> Though did you actually commit the feature that you added that debugging code for?
20160916 03:11:19< vultraz> No
20160916 03:11:32< vultraz> There seems to be some kinda of issue in the dispatcher system
20160916 03:12:05< vultraz> I can't get the Enter thing to work unless it's connected to front_child
20160916 03:13:03< celticminstrel> Something's likely setting halt/handled.
20160916 03:13:10< vultraz> the window close handler is connected to back_pre and back_child. I can move the former to back_post or front_post, but I can't move the other one.
20160916 03:13:32< vultraz> So my enter handler is in front of the window handler, which that line of debugging code want meant to confirm
20160916 03:13:33-!- JyrkiVesterinen [~JyrkiVest@87-100-223-167.bb.dnainternet.fi] has joined #wesnoth-dev
20160916 03:13:41< vultraz> and even though i set halt = true in mind, the window handler still fires
20160916 03:14:03< vultraz> only thing I can think of is it's dealing with multiple widgets and the queues for each
20160916 03:14:03< celticminstrel> I'm not exactly clear on what halt=true and handled=true mean.
20160916 03:14:21< celticminstrel> One of them prevents processing further queues, I think.
20160916 03:14:23< vultraz> halt looks like it's *supposes* to break from the loop of handling each event
20160916 03:14:36< vultraz> and handled stops the processing of the next queue 
20160916 03:14:42< vultraz> supposed
20160916 03:14:44< vultraz> *
20160916 03:14:44< celticminstrel> The three queues being pre_child, child, post_child. (back/front just represent positions in the queues.)
20160916 03:14:54< vultraz> yes, I know
20160916 03:15:11< celticminstrel> But I don't know if the other is supposed to stop processing the current queue or what.
20160916 03:15:11< vultraz> in my case, even though i set halt and handled to true
20160916 03:15:20< vultraz> and the post_child queue doesn't fire
20160916 03:15:34< vultraz> i cannot stop the window handler from firing
20160916 03:15:44< vultraz> likely mordante could help here
20160916 03:19:00< celticminstrel> Random (unrelated) thought - do GUI2 labels support clickable links?
20160916 03:19:30-!- travis-ci [~travis-ci@ec2-54-211-188-111.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 03:19:31< travis-ci> wesnoth/wesnoth#10975 (master - 4cf5be6 : Charles Dang): The build is still failing.
20160916 03:19:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160344850
20160916 03:19:31-!- travis-ci [~travis-ci@ec2-54-211-188-111.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 03:19:32< vultraz> yes
20160916 03:19:38< celticminstrel> How does that work?
20160916 03:20:00< vultraz> they don't have a visual indication when you hover over them, though
20160916 03:20:07< vultraz> but they do display a kinda ugly yellow
20160916 03:20:27< vultraz> and sometimes they don't even display in color but you can click on them
20160916 03:20:29< celticminstrel> How does it work?
20160916 03:20:41< vultraz> I think it just registers a click handler that checks if some text looks like a url
20160916 03:20:45< vultraz> take a look at the code
20160916 03:20:53< celticminstrel> Hmm, so it only works on literal URLs?
20160916 03:21:05< vultraz> yeah
20160916 03:21:13< vultraz> but I'm sure it could be expanded to other types
20160916 03:21:15< celticminstrel> Well... it's a start, I guess.
20160916 03:28:21< vultraz> shadowm: i have done so.
20160916 03:28:35< vultraz> (re [04:43:51]	shadowm	vultraz: Can you point me to a particular line and file for one of those "excessive" line breaks/indents? )
20160916 03:29:06< vultraz> This review thing is really great
20160916 03:29:34< vultraz> next time celticminstrel does a review he can group his comments instead of spamming my inbox and making me reload the page a dozen times :D
20160916 03:31:25< celticminstrel> The main things needed for a GUI2 help browser are a) The ability to wrap text around images, b) The ability to lay out tables.
20160916 03:31:38< celticminstrel> We already have b) in the form of grids, it just needs to be made a bit more dynamic.
20160916 03:32:02< celticminstrel> a) is the only really hard part. It could be mostly simulated with grids if we had to, but it probably wouldn't look quite right.
20160916 03:32:18< vultraz> let's ship a css parser :P
20160916 03:32:23< celticminstrel> No way.
20160916 03:32:39< vultraz> (you know anura does that, btw)
20160916 03:32:47< celticminstrel> Good for Anura.
20160916 03:33:22< vultraz> honestly, we don't really need text wrapping
20160916 03:33:38< vultraz> I thought the idea was to draw the portraits in the backgroud on the canvas
20160916 03:33:54< celticminstrel> Well, at the moment the text wraps around images.
20160916 03:34:04< vultraz> oh right, there's some stuff in the manual that needs wrapping..
20160916 03:34:08< celticminstrel> Not specifically portraits, other images too (which need to be updated BTW).
20160916 03:34:46< vultraz> oh yeah
20160916 03:34:50< vultraz> they all use the old font
20160916 03:35:31< vultraz> I still don't really know how we plan to keep all the data needed for the help browser
20160916 03:35:39< vultraz> without significant lag
20160916 03:36:01< vultraz> I also think the design could use a significant update
20160916 03:36:15< celticminstrel> Oh yeah, I guess we shouldn't bother updating the images yet.
20160916 03:36:29< celticminstrel> Wait until we have a releaase candidate.
20160916 03:37:01< celticminstrel> I seriously think a dymanically-built grid is a good answer for super-long texts, including both the credits and help.
20160916 03:37:02< vultraz> gui1 does perform slightly better than gui2 in such heavy load situations
20160916 03:37:23< vultraz> help has no super-long text
20160916 03:37:35< celticminstrel> The license is pretty long. And the contributors page. :P
20160916 03:38:11< vultraz> ya know, we're the only game I've played that explicitly touts its license in-game. It's funny.
20160916 03:38:11< celticminstrel> Switching to the contributors page actually causes lag in 1.12.
20160916 03:38:20< vultraz> yes, it does
20160916 03:38:34< vultraz> one of the reasons I wonder if it's worth keeping there
20160916 03:38:37< celticminstrel> Also, the drakes racial page is one of the few that actually scrolls.
20160916 03:39:09< vultraz> because its one of the few that actually has lore :P
20160916 03:39:27< vultraz> We're incredibly lazy when it comes to writing canon lore.
20160916 03:39:31< celticminstrel> Right, but the point is it's pretty long.
20160916 03:39:47< celticminstrel> Nowhere near as long as the license though.
20160916 03:39:52< vultraz> right
20160916 03:40:16< celticminstrel> The license could easily be split up into a grid cell per paragraph.
20160916 03:40:34< celticminstrel> Many other help pages could be processed like that too.
20160916 03:41:23< vultraz> we'd need to do a significant refactor of grid handling to do that
20160916 03:41:36< vultraz> maybe we could just finish tlist??
20160916 03:41:40< vultraz> :|
20160916 03:41:41< celticminstrel> I suspect it could be done pretty easily with add_row.
20160916 03:41:50< celticminstrel> Well, if you want to finshe tlist, go right ahead?
20160916 03:41:53< celticminstrel> ^-e
20160916 03:41:58< celticminstrel> ^finish
20160916 03:42:00< vultraz> why do you keep shying away from the idea of finishing tlist
20160916 03:42:17< celticminstrel> Because I have no idea how it works and it's easier to work with what I know, I guess?
20160916 03:42:19< vultraz> it's like you want to take any other solution than finishing tlist.
20160916 03:42:27< shadowm> vultraz: Your indent complaints would've been invalid back in February.
20160916 03:42:37< celticminstrel> It's not like I have any vendetta against tlist.
20160916 03:42:58< celticminstrel> Rather, I'm trying to point out that there are things that, almost certainly, already work that could be used.
20160916 03:43:16< shadowm> <vultraz> ya know, we're the only game I've played that explicitly touts its license in-game. It's funny.
20160916 03:43:25< shadowm> How many OSS games have you played, exactly?
20160916 03:43:59< vultraz> for the record, when I tried to use grid.add_row i got a warning about how adding rows to an already laid out grid could cause problems.
20160916 03:44:09< vultraz> shadowm: good point.
20160916 03:44:45< celticminstrel> Unless I'm misunderstanding something, wouldn't those problems be solved by invalidate_layout()?
20160916 03:45:12< vultraz> purge the thought!
20160916 03:45:32< vultraz> unless you mean use it in pre_show
20160916 03:45:39< vultraz> then it's possibly acceptable
20160916 03:45:43< celticminstrel> Why? That's exactly the sort of place where invalidate_layout makes sense.
20160916 03:46:02< celticminstrel> Pretty sure it's called implicitly every time you change a label's text.
20160916 03:46:19< vultraz> It is not.
20160916 03:46:34< vultraz> if it was we'd never have problems with cut off labels
20160916 03:46:37< vultraz> cut-off
20160916 03:47:05< celticminstrel> Okay, whenever you add a list row or treeview node.
20160916 03:47:19< vultraz> dunno.
20160916 03:48:54-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160916 03:51:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160916 03:51:24-!- wedge010 is now known as wedge009
20160916 03:54:36< celticminstrel> Hmm, I can't find an invalidate_layout call in either of those cases (except in the event that the scrollbar can't be used).
20160916 03:55:33< celticminstrel> That said, if it's done as I envision it, the rows will be added to the grid before the layout phase.
20160916 03:56:35< celticminstrel> Maybe we could even build a tbuilder_credits_grid that parses the [about] tags directly into a grid.
20160916 03:57:19< celticminstrel> Well, one of the tags into a grid.
20160916 03:58:26-!- JyrkiVesterinen [~JyrkiVest@87-100-223-167.bb.dnainternet.fi] has quit [Quit: .]
20160916 04:15:25-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160916 04:34:41< celticminstrel> What's the point of window_builder.cpp lines 187-235? :|
20160916 04:35:03-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Quit: WeeChat 1.4]
20160916 04:35:03< celticminstrel> As far as I can see it just asserts false if it's a known type of widget and produces a friendlier error message otherwise.
20160916 04:40:02-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has joined #wesnoth-dev
20160916 04:40:02< vultraz> celticminstrel: I have absolutely no idea
20160916 04:40:02< vultraz> i could never figure out that code
20160916 04:46:42< vultraz> also don't understand why it says they're "not in the executable"
20160916 04:46:44< vultraz> whut?
20160916 04:48:07< celticminstrel> Yeah, I don't get the comment either.
20160916 04:48:23< vultraz> what happens if you remove that?
20160916 04:48:45< celticminstrel> Haven't tried, but I'm betting nothing at all. (Though probably good to keep at least the last line or two.)
20160916 04:48:53< vultraz> also why is the unit_preview_pane there
20160916 04:48:57< vultraz> I don't remember adding that
20160916 04:49:00< celticminstrel> Someone added it. I dunno.
20160916 04:49:07< celticminstrel> Maybe it was me, who knows.
20160916 04:49:12< celticminstrel> git blame it if you care.
20160916 04:49:26< vultraz> and that list isn't even every widget :|\
20160916 04:50:13< vultraz> maybe we should remove that try block and see what happens
20160916 04:50:26< celticminstrel> Calling it a try block is a bit misleading.
20160916 04:50:41< vultraz> macro
20160916 04:50:43< vultraz> I mean
20160916 04:51:43< vultraz> yeah, nothing breaks
20160916 04:51:46 * vultraz shrugs
20160916 04:52:12< vultraz> if you want to remove it go ahead
20160916 04:53:56< vultraz> huh
20160916 04:54:00< vultraz> what is this on line 407..
20160916 04:54:16< shadowm> I really want to do away with the execute() function for tfile_dialog, and the show_file_chooser_dialog() functions.
20160916 04:55:02< vultraz> celticminstrel: is that an internal thing or some undocumented feature 
20160916 04:55:03< shadowm> And just require callers to call methods individually prior to displaying it.
20160916 04:55:13< celticminstrel> What's the line?
20160916 04:55:13< shadowm> Opinions?
20160916 04:55:27< vultraz> celticminstrel: 407
20160916 04:56:21< celticminstrel> Oh, functions? That's used by one or two widget definitions, I think.
20160916 04:56:51< vultraz> shadowm: why don't you just pass the parameters by reference to the dialog like some others do.
20160916 04:57:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 04:57:06< celticminstrel> shadowm: Personally, I prefer to specify parameters either in the constructor or using the chaining idiom.
20160916 04:57:14< vultraz> that's technically the "gui2 sanctioned way" after all
20160916 04:57:28< vultraz> even though I don't particularly like it
20160916 04:57:32< celticminstrel> ie, if you made your setters return a reference to the class, I wouldn't mind doing away with execute().
20160916 04:57:39< shadowm> vultraz: Don't speak syntax to me. I'm talking class design here.
20160916 04:57:53< vultraz> I have made a few dialogs use it...
20160916 04:57:54< shadowm> celticminstrel: That's an option I was considering.
20160916 04:58:09< shadowm> It's just that last time I checked no other GUI2 dialogs used the idiom.
20160916 04:58:22< vultraz> shadowm: I'm saying possibly keep execute but not the setter functions.
20160916 04:58:34< vultraz> and pass the parameters directly
20160916 04:58:44< shadowm> vultraz: execute() is, quite frankly, unsuitable for a dialog with this many options.
20160916 04:59:10< vultraz> in which case I would probably personally use a data struct
20160916 04:59:58< shadowm> You have the following: 1) initial path; 2) initial file selection (if it exists); 3) initial file name (might not exist); 4) read-only mode; 5) save mode (selection does not need to exist); 6) caption; 7) (not implemented yet) message.
20160916 05:00:22< shadowm> All of those are optional.
20160916 05:00:48< celticminstrel> vultraz: The technical term for what you are referring to is a "parameter pack".
20160916 05:01:14< celticminstrel> If I recall correctly, I also refactored twml_message to use that.
20160916 05:01:18< vultraz> shadowm: caption?
20160916 05:01:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160916 05:01:23< shadowm> Caption.
20160916 05:01:40< shadowm> It's a noun. In English.
20160916 05:01:57< shadowm> Quoth Wiktionary: "A title or brief explanation attached to an illustration, cartoon, user interface element, etc."
20160916 05:02:21< vultraz> What is this caption supposed to say?
20160916 05:02:37< shadowm> Load Map. Save Map. Find Executable.
20160916 05:02:45< shadowm> Load Mask. Save Mask.
20160916 05:03:00< shadowm> Import Preferences (potentially).
20160916 05:03:18< shadowm> Load Scenario. Save Scenario.
20160916 05:03:49< vultraz> why not use a MODE enum and evaluate that in preshow?
20160916 05:04:05< vultraz> you could also use that to deal with message and/o other parameters
20160916 05:04:06< shadowm> Are we writing maintainable code or not?
20160916 05:04:29< shadowm> Also, you do realize that when I said "all of those [7 options] are optional" I meant that they may be found in any order or combination?
20160916 05:05:00< shadowm> Sure, we can have a flag bitfield. Why not.
20160916 05:05:05< shadowm> Why not rewrite everything in C as well?
20160916 05:05:41 * celticminstrel is in favour of the named-constructor idiom.
20160916 05:05:43< shadowm> I'm intrigued as to why you want to introduce more magic numbers when not too long ago you embarked on a quest to rid us of those.
20160916 05:05:51< vultraz> then just use a damn parameter pack, as celticminstrel calls it
20160916 05:06:13< celticminstrel> I'd say that a parameter pack is more for when you have a large number of (mainly) compulsory options.
20160916 05:06:29< celticminstrel> Though I suppose maybe that wasn't the case for twml_message, but oh well.
20160916 05:07:11< celticminstrel> Or did I do three parameter packs, one for each option group...
20160916 05:07:38< shadowm> I think I'll go with chained setters and leave it to our Glorious Leader to defile my code with whatever suits his tastes better.
20160916 05:11:23< vultraz> celticminstrel: seems only tooltips use functions
20160916 05:12:47< vultraz> im not really clear what it does, though...
20160916 05:12:54< vultraz> evaluate functions are window creation time?
20160916 05:13:32< vultraz> no, I think it defines functions..
20160916 05:13:46< vultraz> or wait, that's just because of 'def'
20160916 05:14:13< celticminstrel> I think technically it's a formula that's evaluated at window creation time.
20160916 05:14:18< celticminstrel> But its result is not used.
20160916 05:14:26< celticminstrel> So it's only really good for defining functions.
20160916 05:14:37< vultraz> Interesting
20160916 05:14:41< vultraz> I shall keep this in mind
20160916 05:14:42< celticminstrel> Those functions can then be used by other formulas in that definition.
20160916 05:14:51< celticminstrel> They cannot be used by formulas in nested widgets.
20160916 05:15:13< vultraz> ah
20160916 05:15:15< vultraz> well that sucks
20160916 05:15:27< celticminstrel> I'm pretty sure that's the case, anyway.
20160916 05:15:52< vultraz> I was about to suggest it as a possible approach to the caption thing
20160916 05:16:50< vultraz> wait no, that wouldn't work
20160916 05:16:56< vultraz> you'd still need a parameter
20160916 05:16:58-!- Kwandulin [~Miranda@p200300760F2C71D321F5CFCA50B32CFE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160916 05:17:29< celticminstrel> Caption thing?
20160916 05:19:05< vultraz> yes
20160916 05:19:13< vultraz> the file dialog's caption thing
20160916 05:20:28< celticminstrel> I don't see how that would work.
20160916 05:21:07< vultraz> hm. is reevaluate_best_size supposed to be a bool.
20160916 05:41:29-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160916 05:51:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 05:53:49-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160916 05:56:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160916 05:57:10-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160916 06:11:57-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160916 06:38:10< shadowm> vultraz, gfgtdf: Nobody ever runs the test suite on Windows at the moment, right?
20160916 06:39:00< vultraz> uh.. don't think so
20160916 06:40:32< shadowm> How unfortunate.
20160916 06:40:42< shadowm> I'll keep adding filesystem tests that will utterly fail on Windows then.
20160916 06:43:22< irker112> wesnoth: Charles Dang wesnoth:master 002f9a83c6b1 / src/gui/dialogs/end_credits.cpp: Yet again an attempt to appease travis https://github.com/wesnoth/wesnoth/commit/002f9a83c6b152244769707a4ffdac227c2b7872
20160916 06:43:25< irker112> wesnoth: Charles Dang wesnoth:master 183abfdabb61 / data/gui/window/game_load.cfg: Game Load: fixed layout with small number of saves https://github.com/wesnoth/wesnoth/commit/183abfdabb61b9eb1de9bdcb18957f813012f7a2
20160916 06:53:23-!- Kwandulin_2 [~Miranda@p200300760F2C719621F5CFCA50B32CFE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160916 06:54:33-!- Kwandulin [~Miranda@p200300760F2C71D321F5CFCA50B32CFE.dip0.t-ipconnect.de] has quit [Ping timeout: 248 seconds]
20160916 06:55:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160916 07:02:00< shadowm> "Error loading map: File not found". Well, thanks for telling me the path?
20160916 07:03:51-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 07:03:52< travis-ci> wesnoth/wesnoth#10976 (master - 183abfd : Charles Dang): The build is still failing.
20160916 07:03:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160368644
20160916 07:03:52-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 07:04:23< zookeeper> shadowm, sounds like a well thought out error message indeed
20160916 07:04:28< vultraz> OH COME ON
20160916 07:04:32< vultraz> DAMN YOU TAVIS
20160916 07:04:34< vultraz> DAMN YOU
20160916 07:05:07< shadowm> Let's all be civil, please.
20160916 07:05:25< vultraz> this is just ridiculous 
20160916 07:07:40-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160916 07:15:39< vultraz> shadowm: debian stable has 4.9 right?
20160916 07:16:10< shadowm> Why are you asking this question?
20160916 07:17:45< vultraz> im pondering the implications of bumping travis's compiler
20160916 07:18:08< shadowm> You do realize Travis runs Ubuntu trusty, not Debian jessie, right?
20160916 07:19:43< vultraz> bumping the travis compiler is tantamount to bumping our minimum compiler version.
20160916 07:20:24< shadowm> Yes, but Ubuntu trusty doesn't have GCC 4.9.
20160916 07:22:04< shadowm> I'm not sure you want to inflate build times further by adding more external dependencies to install (if you can even find a PPA with 4.9). Or whether I agree with your approach to dealing with every small bump in the road.
20160916 07:24:31< shadowm> Sigh. I need to completely rethink the path selection logic for thid dialog. I made the whole thing undebuggable and failure-prone.
20160916 07:24:36< shadowm> *this
20160916 07:24:58-!- atarocch [~atarocch@62.134.204.4] has joined #wesnoth-dev
20160916 07:25:17< vultraz> I really don't want to use a temporary string there
20160916 07:25:22< shadowm> My biggest mistake was making the path get/set logic have side effects.
20160916 07:27:45-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20160916 07:30:44-!- boucman_work [~boucman@102.15.204.77.rev.sfr.net] has joined #wesnoth-dev
20160916 07:33:37-!- mjs-de [~mjs-de@x4db5201e.dyn.telefonica.de] has joined #wesnoth-dev
20160916 07:33:47 * shadowm stares at vultraz blankly.
20160916 07:33:53< vultraz> hmm?\
20160916 07:34:18< shadowm> You... don't need to do whatever it is you think you're doing.
20160916 07:34:32< vultraz> hmmmmmm?
20160916 07:34:39< shadowm> https://github.com/wesnoth/wesnoth/commit/002f9a83c6b152244769707a4ffdac227c2b7872
20160916 07:35:05< shadowm> The only line you modify -- there's only one reference to str further down before it goes out of scope.
20160916 07:35:32< shadowm> Why do you need to rely on being able to swap streams instead of just...
20160916 07:35:44< shadowm> ... sort of calling the only function that needs a stream... and...
20160916 07:37:24< shadowm> text_widget_->set_label(( ( !focus_str.str()empty() ) ? focus_str : str ).str());
20160916 07:37:24< vultraz> I guess I could create a string variable from .str() of the appropriate stream, yes..
20160916 07:37:32< vultraz> or that
20160916 07:37:48< vultraz> huh
20160916 07:37:50< shadowm> (Prettify with named throwaway references and if blocks or whatever as you see fit.)
20160916 07:37:52< vultraz> I would not have thought of that
20160916 07:38:09< vultraz> I'd have used .str() in both sides of : 
20160916 07:38:33< shadowm> By the way, calling your stream str? Bad idea.
20160916 07:39:18< vultraz> I always do that
20160916 07:39:22< shadowm> Not only because basic_stringstream has a public member already called that, but also because "str" is a conventional name for a string of some sort.
20160916 07:39:43< shadowm> I was struggling at first because I assumed it was a string type object.
20160916 07:40:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 07:40:24< shadowm> So I usually call throwaway formatting stringstreams 'out' or 'os' or 'ss' to avoid confusing future me.
20160916 07:40:35< shadowm> As well as any other potential readers of my code.
20160916 07:41:03< vultraz> hm
20160916 07:41:06< vultraz> ss is good
20160916 07:41:57< shadowm> Also, when reading text I tend to coalesce repeating sequences, so str.str() becomes str().
20160916 07:43:05< shadowm> (This is also why I absolutely abhor deeply nested parentheses.)
20160916 07:44:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 272 seconds]
20160916 07:45:06-!- mjs-de [~mjs-de@x4db5201e.dyn.telefonica.de] has quit [Remote host closed the connection]
20160916 07:47:30-!- boucman_work [~boucman@102.15.204.77.rev.sfr.net] has quit [Ping timeout: 244 seconds]
20160916 07:48:21-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has joined #wesnoth-dev
20160916 07:57:39< vultraz> for the record, still need to fix the bug where credits don't show if they get too long
20160916 07:59:26< irker112> wesnoth: Charles Dang wesnoth:master 7eb13d218615 / src/gui/dialogs/end_credits.cpp: End Credits: removed the use of swap https://github.com/wesnoth/wesnoth/commit/7eb13d21861579a5040d6baf2e312e8b9b6d2a5f
20160916 08:05:58< irker112> wesnoth: Charles Dang wesnoth:master fff2e3f19372 / src/gui/dialogs/end_credits.cpp: End Credits: fixed crash if exiting before scrolling starts https://github.com/wesnoth/wesnoth/commit/fff2e3f193721bcdab5b7b0c831323141acf19b1
20160916 08:08:06-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20160916 08:10:44< irker112> wesnoth: Charles Dang wesnoth:master 7def4d57eb96 / src/gui/widgets/window.cpp: Removed some accidentally-committed debug code https://github.com/wesnoth/wesnoth/commit/7def4d57eb9699ff257fdfc95d6ae520b3be7462
20160916 08:17:14< vultraz> wedge009: thanks for marking those bugs as fixed
20160916 08:30:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20160916 08:35:03-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 08:35:04< travis-ci> wesnoth/wesnoth#10979 (master - 7eb13d2 : Charles Dang): The build was fixed.
20160916 08:35:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160380245
20160916 08:35:04-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 08:37:02< irker112> wesnoth: loonycyborg wesnoth:master b0fa8110f014 / src/ (campaign_server/campaign_server.cpp server/server_base.cpp): Convert remaining boost::bind to std::bind in campaignd code https://github.com/wesnoth/wesnoth/commit/b0fa8110f014a11ffbd81cb4d34afbb663a1f524
20160916 08:49:48-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160916 09:05:04-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160916 09:08:48-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 09:08:49< travis-ci> wesnoth/wesnoth#10980 (master - fff2e3f : Charles Dang): The build has errored.
20160916 09:08:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160381576
20160916 09:08:51-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 09:13:46< vultraz> errored, you say
20160916 09:13:55< vultraz> better than failed
20160916 09:14:01< vultraz> and it looks like only 1 build errored
20160916 09:21:36-!- Kwandulin_2 [~Miranda@p200300760F2C719621F5CFCA50B32CFE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160916 09:28:03-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 09:28:04< travis-ci> wesnoth/wesnoth#10981 (master - 7def4d5 : Charles Dang): The build was fixed.
20160916 09:28:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160382427
20160916 09:28:04-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 09:28:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 09:32:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160916 09:39:53< irker112> wesnoth: loonycyborg wesnoth:master 86dc5174a8bd / src/tools/exploder_utils.cpp: Fixed compile errors in exploder https://github.com/wesnoth/wesnoth/commit/86dc5174a8bd71267650274b401a6298b5c0b073
20160916 09:43:48< vultraz> IT WAS FIXED :O
20160916 09:44:26< vultraz> loonycyborg: what was wrong with the array and unique_ptr?
20160916 09:45:46< shadowm> Why not se std::array?
20160916 09:45:49< shadowm> *use
20160916 09:46:44< vultraz> previously it used that shared_array thing we shipped with scoped_resources, so I just converted it to the appropriate shared_ptr version :/ 
20160916 09:46:52< vultraz> curious what the problem was
20160916 09:47:48< vultraz> unique_ptr<T[]> is valid :/
20160916 09:48:41< vultraz> maybe line 220 was supposed to be rgba_data[pos]
20160916 09:49:57< vultraz> s/shared_ptr/unique_ptr
20160916 09:51:07< vultraz> I'd rather we didn't use the boost version if possible
20160916 09:53:40-!- Kwandulin [~Miranda@p200300760F2C719659C709C77FF9B09F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160916 10:02:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20160916 10:10:25-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160916 10:13:51-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160916 10:16:47-!- Bonobo [~Bonobo@2001:44b8:254:3200:a5ec:2c73:d101:fb11] has joined #wesnoth-dev
20160916 10:28:16-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160916 10:28:55< loonycyborg> I'm not sure what's the correct thing to use here
20160916 10:29:18< loonycyborg> but what was there before didn't compile
20160916 10:29:24< vultraz> does unique_ptr and rgba_data[pos] work?
20160916 10:30:18< loonycyborg> shadowm: std::array isn't a pointer wrapper
20160916 10:30:26< loonycyborg> it's totally different thing
20160916 10:31:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160916 10:31:49< loonycyborg> vultraz: you'd need to delete array ptr in different way
20160916 10:31:57< loonycyborg> than scalar ptr
20160916 10:32:38< loonycyborg> I'm not sure that unique_ptr can handle arrays
20160916 10:33:08< vultraz> It can
20160916 10:33:17< vultraz> http://en.cppreference.com/w/cpp/memory/unique_ptr
20160916 10:33:46< vultraz> also that array has no custom deleter
20160916 10:33:55< vultraz> so I'm not sure what.. the issue is :/
20160916 10:34:51< vultraz> as far as I can tell the syntax i had was correct (<rgba[]>), but I didn't update the call site to use []
20160916 10:36:38< vultraz> ie, you want rgba[pos] not rgba+pos
20160916 10:38:04< loonycyborg> ok will try
20160916 10:41:25< irker112> wesnoth: loonycyborg wesnoth:master f821598ca3dc / src/tools/exploder_utils.cpp: Switch boost::shared_array to unique_ptr https://github.com/wesnoth/wesnoth/commit/f821598ca3dcf9818ff20965a197d0549ba0cbc8
20160916 10:42:10< vultraz> :D
20160916 10:42:51< loonycyborg> yeah, the error was that operator+ was used on unique_ptr
20160916 10:43:45< vultraz> thanks for fixing
20160916 10:43:49< vultraz> btw
20160916 10:43:53< vultraz> since i dont build the tools
20160916 10:45:48< loonycyborg> yw :P
20160916 10:48:08-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160916 11:01:03-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has quit [Ping timeout: 240 seconds]
20160916 11:03:53< loonycyborg> shadowm: does baldras.org server have ipv6 connectivity with its isp?
20160916 11:12:52-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160916 11:15:18< vultraz> bumbadadabum: could you maybe add a little distinction between morning and afternoon?
20160916 11:15:54< vultraz> i think morning should have a kinda warmer light
20160916 11:16:08< vultraz> more red maybe
20160916 11:16:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 11:17:40< bumbadadabum> morning is usually quite a cold light here
20160916 11:18:01-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160916 11:18:23< vultraz> hm
20160916 11:18:31< vultraz> perhaps im thinking dawn
20160916 11:18:54< vultraz> still, i think there should be a slight distinction between morning and afternoon
20160916 11:19:13-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20160916 11:19:47-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 11:19:48< travis-ci> gfgtdf/wesnoth-old#686 (fix_24927 - a2adec6 : gfgtdf): The build is still failing.
20160916 11:19:48< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/160410910
20160916 11:19:48-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 11:21:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20160916 11:32:07-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160916 11:46:43-!- atarocch [~atarocch@62.134.204.4] has quit [Remote host closed the connection]
20160916 11:54:19< irker112> wesnoth: Wedge009 wesnoth:master 1a25d297b81d / changelog src/statistics.cpp: Don't duplicate recall count decrement when undoing a recall (bug #25060) https://github.com/wesnoth/wesnoth/commit/1a25d297b81dead1fd0e6e3c5b5da8d5caea6254
20160916 11:55:12< vultraz> ah, sweet :D
20160916 11:55:37< vultraz> do assign to yourself and mark as fixed
20160916 11:56:28< wedge009> Just did that. (:
20160916 12:10:22-!- Kwandulin [~Miranda@p200300760F2C719659C709C77FF9B09F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160916 12:24:54-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160916 12:29:10-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 12:29:11< travis-ci> wesnoth/wesnoth#10986 (master - 1a25d29 : Wedge009): The build was broken.
20160916 12:29:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160424649
20160916 12:29:11-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 12:30:08< vultraz> D:
20160916 12:30:28-!- Shiki [~Shiki@141.39.226.227] has joined #wesnoth-dev
20160916 12:34:53-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160916 12:35:00< irker112> wesnoth: Charles Dang wesnoth:master a477eb4014ba / src/statistics.cpp: Fixup 1a25d297b81d (unused variable) https://github.com/wesnoth/wesnoth/commit/a477eb4014bad07bfe5662982b2cbb7596975ded
20160916 12:42:34-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160916 12:44:59 * celticminstrel still hasn't tested the ToD PR, so please let me do that first.
20160916 12:45:19-!- Shiki [~Shiki@141.39.226.227] has quit [Quit: Verlassend]
20160916 12:46:56-!- Kwandulin [~Miranda@p200300760F2C71964C4328AF7F47B233.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160916 12:53:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160916 12:54:04-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 265 seconds]
20160916 13:00:32-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160916 13:05:02-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160916 13:14:55-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 13:14:56< travis-ci> wesnoth/wesnoth#10987 (master - a477eb4 : Charles Dang): The build has errored.
20160916 13:14:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160433667
20160916 13:14:56-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 13:19:08-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160916 13:19:47-!- Kwandulin [~Miranda@p200300760F2C71964C4328AF7F47B233.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160916 13:20:05< mattsc> I’m going to merge PR 782 (tunnel moves) shortly.  I think I have heard from everybody who is likely to check it out.
20160916 13:23:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160916 13:33:04< vultraz> blah
20160916 13:33:15< vultraz> the create screen has problems on lower resolutions
20160916 13:36:46< vultraz> celticminstrel: thoughts on changing drop_down_list.cfg:30 to "screen_height - window_height"?
20160916 13:44:18< celticminstrel> ?
20160916 13:46:49< vultraz> celticminstrel: ok so, if you go into the editor and pull up the list of terrain categories, it displays above the button 
20160916 13:46:56< vultraz> which is what the list is designed to do
20160916 13:47:09< vultraz> but in gui1, that list just covered the button
20160916 13:47:14< celticminstrel> It doesn't, actually. It doesn't knoe the button is there.
20160916 13:47:17< vultraz> ie, screen_height - window_height
20160916 13:47:19< celticminstrel> ^know
20160916 13:47:52< celticminstrel> If it doesn't cover the button, that's just a happy coincidence.
20160916 13:48:15< vultraz> well, allowing it to do so would be replicating the gui1 behavior
20160916 13:48:22< vultraz> having it display above the button
20160916 13:48:24< vultraz> is rather jarring
20160916 13:48:31< celticminstrel> I'm not entirely sure if the location it shows at is dependant on exactly where you click...
20160916 13:49:34< celticminstrel> I don't think you should change the dropdown list definition just for one little GUI1 replication thing.
20160916 13:49:55< mattsc> vultraz, celticminstrel: am I going to force you to rebase anything if I merge the tunnel PR now?  Should I wait?
20160916 13:49:57< celticminstrel> I'm not sure why it's jarring for it to appear above the button.
20160916 13:50:10< celticminstrel> mattsc: It's okay, anything I have going already needs to be rebased.
20160916 13:50:17< vultraz> mattsc: nah, you can push now
20160916 13:50:31< celticminstrel> s/push/merge/
20160916 13:50:40< mattsc> cool, will do
20160916 13:51:01< vultraz> tfw you fix an issue and don't know how you did it
20160916 13:51:07< irker112> wesnoth: mattsc wesnoth:master 045284896615 / src/ (actions/move.cpp pathfind/teleport.cpp): Check for occupied tunnel exits at teleport map creation https://github.com/wesnoth/wesnoth/commit/045284896615f20488ddb600a8c5b4c2da28e752
20160916 13:51:09< irker112> wesnoth: mattsc wesnoth:master 692109f3bbcd / src/pathfind/ (teleport.cpp teleport.hpp): [tunnel] tag: add new optional parameter pass_allied_units=yes/no https://github.com/wesnoth/wesnoth/commit/692109f3bbcd0489d81f7f244c7bc244b703c669
20160916 13:51:11< irker112> wesnoth: mattsc wesnoth:master ff9450eff297 / src/ (actions/move.cpp pathfind/teleport.cpp pathfind/teleport.hpp): Merge pull request #782 from wesnoth/fix-tunnel-issues https://github.com/wesnoth/wesnoth/commit/ff9450eff2975c02549f867c5fd8dc8dee000f0f
20160916 13:52:05< vultraz> mattsc: wasn't that a long-standing bug?
20160916 13:52:19< mattsc> vultraz: yes; long-standing bug/feature.
20160916 13:52:42< mattsc> I’m going to keep the branch around for now (and hold off on changelog, release notes and wiki) since I want to work on vision issues next.
20160916 13:53:22< mattsc> May I call the parameter for toggling vision through tunnels tunnel_vision=yes/no?  :D
20160916 13:53:32< vultraz> yes :D
20160916 13:55:27< vultraz> gah, someone fix the horizontal listbox palcement
20160916 13:55:55< celticminstrel> ?
20160916 13:56:03< vultraz> it really has problems
20160916 13:57:10< vultraz> doesn't properly consider available space
20160916 14:05:14< vultraz> like
20160916 14:05:19< vultraz> for example
20160916 14:05:22< vultraz> even if i use horizontal_grow
20160916 14:05:28< vultraz> it still shows a scrollbar
20160916 14:05:30< vultraz> for some reason :|
20160916 14:05:33< vultraz> and it's disabled
20160916 14:05:42< vultraz> it's just.. *why*
20160916 14:06:03< vultraz> oh look an assert
20160916 14:08:49< vultraz> it seriously does not properly consider space..
20160916 14:10:31< vultraz> maybe it's the spacers
20160916 14:17:37< vultraz> celticminstrel: btw, are you working on the menu scrollbuttons?
20160916 14:17:50< vultraz> because I decided I will use them for MP Create.
20160916 14:17:52< celticminstrel> The what?
20160916 14:17:56< celticminstrel> Oh that.
20160916 14:18:00< celticminstrel> Not at the moment.
20160916 14:18:07< celticminstrel> I was working on something with menus a couple days ago.
20160916 14:18:15< vultraz> well, please do finish when possible
20160916 14:18:27< celticminstrel> Where are you using them in MP Create? :|
20160916 14:19:23< vultraz> i decided i will embrace the horizontal scroll-ness and use left/right buttons along the side to enable scrolling
20160916 14:19:33 * celticminstrel also tried to use a dynamic grid in credits last night / this morning. There's something missing though. Not sure why it crashes.
20160916 14:19:36< celticminstrel> ...what?
20160916 14:20:02< celticminstrel> Oh wait, in the listbox?
20160916 14:20:10< vultraz> no, the window
20160916 14:20:22< vultraz> there's no way we can stop it having a horizontal scrollbar at certain resolutions
20160916 14:20:22< celticminstrel> No no no, don't embrace window scrollbars... :|
20160916 14:20:52< vultraz> so might as well give it left/right scrollbuttons instead
20160916 14:24:23< vultraz> ahhh, i finally got the tab bar to stop acting like crazy
20160916 14:25:16-!- Kwandulin [~Miranda@p200300760F2C719635F9BE7F1C95FBCA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160916 14:28:13-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 14:28:14< travis-ci> wesnoth/wesnoth#10988 (master - ff9450e : mattsc): The build failed.
20160916 14:28:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160451983
20160916 14:28:14-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 14:30:53< irker112> wesnoth: Charles Dang wesnoth:master f4fcb330c81d / src/actions/move.cpp: Commented out unused parameter https://github.com/wesnoth/wesnoth/commit/f4fcb330c81d2c4090556671d5fcb6ce5630cbea
20160916 14:32:55< irker112> wesnoth: Charles Dang wesnoth:master 33e21fda4aaa / src/gui/widgets/generator.cpp: Commented out some aserts that were causing problems in a few places https://github.com/wesnoth/wesnoth/commit/33e21fda4aaa4d131bf57a83f66ee65a6fb20733
20160916 14:33:22< vultraz> bkah typo
20160916 14:34:12< celticminstrel> I think hitting those asserts implies that it was somehow unable to fit exactly into the requested space.
20160916 14:37:48-!- Bonobo [~Bonobo@2001:44b8:254:3200:a5ec:2c73:d101:fb11] has quit [Quit: Leaving]
20160916 14:48:12< irker112> wesnoth: Celtic Minstrel wesnoth:master 076c327d565e / src/gui/widgets/generator.cpp: "Reactivate" removed asserts as a log message https://github.com/wesnoth/wesnoth/commit/076c327d565eea06cd8324d2239cd81b0ce1894b
20160916 14:48:14< irker112> wesnoth: Celtic Minstrel wesnoth:master bc7b27e49604 / data/gui/window/end_credits.cfg src/gui/dialogs/end_credits.cpp: Minor end credits tweaks https://github.com/wesnoth/wesnoth/commit/bc7b27e4960493849aa8cabc5238a0e66eb2f101
20160916 14:50:21 * celticminstrel poke vultraz 
20160916 14:50:25< vultraz> ja?
20160916 14:50:53< celticminstrel> What's left of GUI1 is help, stats(?), attack prediction, game UI, MP Connect, right? Am I missing anything?
20160916 14:51:02< vultraz> storyscreen
20160916 14:51:10< celticminstrel> Right right.
20160916 14:51:19< vultraz> and yeah, I think that convers it
20160916 14:51:47< celticminstrel> I think storyscreen's GUI1 can be nuked without making it a proper dialog, but I'm not sure if that's worth it.
20160916 14:52:27< celticminstrel> Another thought I had with the storyscreen was to make just the panel at the bottom into a dialog, which draws over the other section.
20160916 14:52:36< celticminstrel> ^over the map etc
20160916 14:53:06< celticminstrel> My guess is that dynamically moving a window is possible using set_origin, though I haven't tested it.
20160916 14:53:38< vultraz> might be worth making it's own dialog
20160916 14:53:40< vultraz> we'll see
20160916 14:54:17-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has quit [Ping timeout: 240 seconds]
20160916 14:54:42< celticminstrel> So I shouldn't go ahead and nuke its GUI1 without converting it to a proper dialog?
20160916 14:55:42< vultraz> if you can make it use gui2 without making it a proper dialog yet go ahead
20160916 14:58:14< irker112> wesnoth: Charles Dang wesnoth:master 94b092fa9d37 / data/gui/widget/button_default.cfg: Added a definition for a really large button https://github.com/wesnoth/wesnoth/commit/94b092fa9d37f6aedd5f0fafd43abe0cf6a9c490
20160916 14:58:17< irker112> wesnoth: Charles Dang wesnoth:master cf5640099614 / / (8 files in 4 dirs): MP Create: significant layout improvements https://github.com/wesnoth/wesnoth/commit/cf56400996142ca382ca57e26d11b3a6507658fd
20160916 14:58:45< vultraz> celticminstrel: do give me your thoughts ^
20160916 14:58:47-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160916 14:59:10-!- DeFender1031 [~DeFender1@46-116-114-128.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20160916 15:00:39< vultraz> i did remove the spacer for the left column, so the right is now slightly wider... dunno if it makes that section fell too... empty
20160916 15:01:19< vultraz> might shift the decor that way to compensate
20160916 15:08:37-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 15:08:38< travis-ci> wesnoth/wesnoth#10989 (master - f4fcb33 : Charles Dang): The build was fixed.
20160916 15:08:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160462299
20160916 15:08:38-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 15:10:54-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Read error: Connection reset by peer]
20160916 15:12:30< vultraz> I'm going to post a screenshot of the current version on facebook
20160916 15:12:41< vultraz> might do a few more tweaks, but it's mostly finished
20160916 15:16:50-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160916 15:23:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160916 15:32:31-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160916 15:35:49-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has joined #wesnoth-dev
20160916 15:36:16-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 15:36:17< travis-ci> wesnoth/wesnoth#10990 (master - 33e21fd : Charles Dang): The build was fixed.
20160916 15:36:17< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160462753
20160916 15:36:17-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 15:42:43< celticminstrel> Now let's see if this works.
20160916 15:47:11-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160916 15:48:55-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160916 15:49:17-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has quit [Ping timeout: 250 seconds]
20160916 15:52:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20160916 15:52:58-!- wedge010 is now known as wedge009
20160916 15:56:48< vultraz> celticminstrel: what are you working on?
20160916 15:57:23< celticminstrel> (It didn't work because widgets apparently assume they're in a window in certain places.)
20160916 15:57:34 * celticminstrel making floating textboxes GUI2.
20160916 15:57:57< vultraz> oh yeah, I guess they do..
20160916 15:58:20< celticminstrel> Grah, sudden background! o.o
20160916 15:58:50< vultraz> hm?
20160916 15:59:02< celticminstrel> Nothing important.
20160916 15:59:38< celticminstrel> Hmm, somehow I broke hotkeys?
20160916 15:59:42< vultraz> i have discovered something interesting
20160916 15:59:52< vultraz> seems linked_group causes layout invalidation
20160916 16:00:05< vultraz> who's have thought
20160916 16:00:13< vultraz> i guess it makes sense
20160916 16:01:13-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 16:01:13< travis-ci> wesnoth/wesnoth#10991 (master - bc7b27e : Celtic Minstrel): The build was fixed.
20160916 16:01:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160466568
20160916 16:01:13-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 16:01:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 16:01:33< celticminstrel> Why'd it say it was fixed twice? :|
20160916 16:02:16< vultraz> 3 times, actually
20160916 16:02:45< celticminstrel> Blah, my Windows decided to lose the mouse and keyboard.
20160916 16:15:08-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has joined #wesnoth-dev
20160916 16:27:06-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 16:27:07< travis-ci> wesnoth/wesnoth#10992 (master - cf56400 : Charles Dang): The build has errored.
20160916 16:27:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160469359
20160916 16:27:08-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 16:27:26-!- gfgtdf [~chatzilla@x50ab6d66.dyn.telefonica.de] has joined #wesnoth-dev
20160916 16:27:58< vultraz> clang just randomly fails the tests with gui errors sometimes
20160916 16:28:09< gfgtdf> vultraz: the gamemaps seems to ahve some code to 'guess' the border tiles for border_size=0 maps, you thinkwe can remove that ?
20160916 16:28:18< gfgtdf> have*
20160916 16:28:34< vultraz> yeah
20160916 16:28:42< vultraz> the only think we need is border = yes/no for masks
20160916 16:28:46< vultraz> thing
20160916 16:29:02< celticminstrel> Maps always have a border, don't they?
20160916 16:29:41< vultraz> yes
20160916 16:30:33< gfgtdf> vultraz: my plan is to remove the border_size paremter in gamemap completeley and then let [terrain_mask] add the border to the map (for _f tiles ) in case of border=no
20160916 16:30:48< vultraz> sure
20160916 16:34:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160916 16:34:36< gfgtdf> vultraz: you know ehther its possible to place for terrain (_f) in the editor to create a mask in the ditor?
20160916 16:36:04< vultraz> gfgtdf: you can use Generate Mask
20160916 16:36:10< vultraz> idt you can place _f tho
20160916 16:36:40< celticminstrel> You can place _f in the editor.
20160916 16:36:49< celticminstrel> I think it's in the "special" category.
20160916 16:36:58< celticminstrel> You can place _s too.
20160916 16:37:01< gfgtdf> vultraz: what is te differnec betwwen mask and map from the category?
20160916 16:37:14< vultraz> what do you mean
20160916 16:37:54< gfgtdf> vultraz: hmm nevermind, i thoughtat first 'mask' was some editor mode.
20160916 16:37:56< celticminstrel> I don't remember, does _f^Vv work to overlay something on whatever was originally there?
20160916 16:38:03< celticminstrel> Or, I guess, replace the overlay.
20160916 16:38:25< celticminstrel> Pretty sure _f / _s are in the editor.
20160916 16:39:01-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160916 16:40:45< gfgtdf> celticminstrel: thx
20160916 16:41:33-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has quit [Ping timeout: 240 seconds]
20160916 16:48:41-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has joined #wesnoth-dev
20160916 16:50:01< irker112> wesnoth: Charles Dang wesnoth:master bb6baf8a78f7 / src/game_preferences.cpp: Fixed bug where entering Preferences would clear saved password https://github.com/wesnoth/wesnoth/commit/bb6baf8a78f7a58a09205ed13e2bd7de687e4ece
20160916 16:50:05< vultraz> celticminstrel: ^
20160916 16:51:17< vultraz> turns out it was an unintended side effect of MY changes :P
20160916 16:51:28< vultraz> sorry for making you go through that bisect 
20160916 16:53:05< vultraz> but seriously, who would have thought to look there 
20160916 16:53:52< vultraz> I only realized what was happening since it struck me to see if maybe clearing the saved pref value would do anything
20160916 17:01:52< irker112> wesnoth: Charles Dang wesnoth:master b48d08d68751 / data/gui/window/drop_down_list.cfg: Drop Down List: some border fixes https://github.com/wesnoth/wesnoth/commit/b48d08d687515ff06e29e51fe48f845fcb6cd9ea
20160916 17:03:35-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160916 17:03:54-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160916 17:07:08-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160916 17:07:08-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160916 17:08:39< irker112> wesnoth: Charles Dang wesnoth:master 9682df6ad0c7 / data/gui/window/game_version.cfg: Game Version: small max height bump to avoid a scrollbar in tab 2 https://github.com/wesnoth/wesnoth/commit/9682df6ad0c70bc74f6a7d8761d769d0cbef1d16
20160916 17:11:03< gfgtdf> i'm getting lau erros in TSG scneario 6 the long march, in 1.13 aswell as in 1.12, but i skipped to it with :cl so not sure whther ita also happen in normal gameplay
20160916 17:12:12-!- Kwandulin [~Miranda@p200300760F2C719635F9BE7F1C95FBCA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160916 17:12:36< celticminstrel> "lau"?
20160916 17:12:52< vultraz> can repro
20160916 17:12:54-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has joined #wesnoth-dev
20160916 17:14:45< vultraz> looks like an issue with store_locations...
20160916 17:16:16-!- JyrkiVesterinen [~JyrkiVest@87-100-192-244.bb.dnainternet.fi] has joined #wesnoth-dev
20160916 17:20:07< gfgtdf> celticminstrel: lua
20160916 17:20:42< zookeeper> hmh?
20160916 17:21:24< vultraz> celticminstrel: looks like get_terrain returns an empty string at the end...
20160916 17:21:56< zookeeper> well then someone broke something
20160916 17:22:04< zookeeper> mallets ready
20160916 17:22:42< gfgtdf> vultraz: but im also geting lua erros at 1.12 migth be for  different reason though
20160916 17:22:51< gfgtdf> vultraz: in that scenario i meant
20160916 17:22:53-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160916 17:22:55< celticminstrel> vultraz: What?
20160916 17:23:12< irker112> wesnoth: Bär Halberkamp wesnoth:master 6df17b37f481 / / (4 files in 3 dirs): EI: Rebalance S2 https://github.com/wesnoth/wesnoth/commit/6df17b37f481a72f6df65df0d87f1d589897af14
20160916 17:23:23< vultraz> celticminstrel: i printed out every value of t in store_locations, and the last value is empty
20160916 17:23:34< vultraz> so obviously get_terrain_info will complain of a nil value
20160916 17:24:22< zookeeper> gfgtdf, oh and yeah you'd get something like that if you :cl to it without certain units
20160916 17:24:40< celticminstrel> Sounds like nothing to do with get_terrain.
20160916 17:24:54< celticminstrel> Which gets a terrain code from the map.
20160916 17:25:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 17:25:31< JyrkiVesterinen> 20160916 16:27:58< vultraz> clang just randomly fails the tests with gui errors sometimes
20160916 17:25:38< JyrkiVesterinen> Not GUI errors. Timeouts.
20160916 17:25:59< vultraz> ah
20160916 17:26:02-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 17:26:03< travis-ci> wesnoth/wesnoth#10993 (master - bb6baf8 : Charles Dang): The build passed.
20160916 17:26:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160500300
20160916 17:26:03-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 17:26:08< zookeeper> gfgtdf, you might want to retry by :cl'ing only after you've allied with bandits in the previous scenario and gotten urza afalas
20160916 17:26:16< JyrkiVesterinen> For example, the latest errored build ( https://travis-ci.org/wesnoth/wesnoth/jobs/160469363 ) did print GUI errors to the log, but the tests passed regardless.
20160916 17:26:37< JyrkiVesterinen> It failed during WML tests which got stuck for some reason.
20160916 17:26:47< JyrkiVesterinen> "No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself."
20160916 17:27:05< gfgtdf> zookeeper: well i just wanted to test that the [terrain_mask] in that scneario  behaves te same as in 1.12 and that was somehow uneffected by teh lua error.
20160916 17:27:09< JyrkiVesterinen> That problem has been happening randomly as long as I have been helping the project.
20160916 17:27:45< JyrkiVesterinen> I'm not even going to try to fix the timeout problem. Randomly occurring bugs are a total pain to investigate.
20160916 17:27:47< zookeeper> gfgtdf, yeah it should be unaffected by it
20160916 17:27:57< zookeeper> (...most likely)
20160916 17:28:42< vultraz> JyrkiVesterinen: ah, I see
20160916 17:28:56-!- Kwandulin [~Miranda@p200300760F2C7196B062BF22006E7805.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160916 17:29:17< vultraz> celticminstrel: well, get_terrain takes an x,y loc, so unless get_locations is broken, what's the problem?
20160916 17:29:51< celticminstrel> Well, get_locations should return a list of locations, obviously.
20160916 17:30:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20160916 17:30:21< celticminstrel> If it returns an empty string in that list, then I'd guess there's something wrong with it.
20160916 17:30:25< vultraz> then again
20160916 17:30:31< vultraz> it could be any of the store_locations things..
20160916 17:30:41< vultraz> could be this line 
20160916 17:30:43< vultraz> x,y=$this_item.x,$this_item.y
20160916 17:30:44< celticminstrel> I don't get why you're pointing at get_terrain, though admittedly I haven't looked at the WML here.
20160916 17:30:45 * vultraz shrugs
20160916 17:33:21< zookeeper> ...what problem are you talking about?
20160916 17:34:34< vultraz> hm no, actually it's in the new_turn event, I think..
20160916 17:35:56< vultraz> ah I got it
20160916 17:36:03-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has quit [Ping timeout: 240 seconds]
20160916 17:36:48-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20160916 17:40:02< vultraz> at least, I think so
20160916 17:40:26< vultraz> hm..
20160916 17:43:23< vultraz> yeah.. not sure
20160916 17:44:27< vultraz> i thought it had something to do with this [store_locations] call using find_in = delayed_2_mp_hexes, which should be empty the first run but removing that doesn't purge the error
20160916 17:44:35-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160916 17:44:35< vultraz> will have to look into this more later
20160916 17:45:54< mattsc> zookeeper, all: see this comment by beetlenaut: https://github.com/wesnoth/wesnoth/pull/782#issuecomment-247654056
20160916 17:46:11< gfgtdf> vultraz: you know whicl filter gives that error ?
20160916 17:46:14< gfgtdf> which*
20160916 17:46:17< mattsc> I personally agree with him, but didn’t do this because of our discussion the other day.
20160916 17:46:57< zookeeper> mattsc, hmh...
20160916 17:46:59< mattsc> I need to be off now, just wanted to throw this out there.  Will read up on things later.
20160916 17:48:05-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.2 Aria]
20160916 17:49:01-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160916 17:50:06-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 17:50:07< travis-ci> gfgtdf/wesnoth-old#687 (location_refeactor - 794a602 : gfgtdf): The build is still failing.
20160916 17:50:07< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/160507156
20160916 17:50:07-!- travis-ci [~travis-ci@ec2-54-204-192-229.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 17:51:00< gfgtdf> in [terrain_mask] the locatiosn where the masks starts is actually at (x-1, y-1) becaue of the map border. I want to change this but see no way to do this without breaking conability,does anyone have an idea ?
20160916 17:51:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20160916 17:51:57< irker112> wesnoth: Celtic Minstrel wesnoth:gui2_floating_textbox de0d462273df / src/ (9 files in 2 dirs): Use GUI2 for floating textboxes (WIP) https://github.com/wesnoth/wesnoth/commit/de0d462273df73a750b4f52c9d49bf77307ff27a
20160916 17:52:01< celticminstrel> ^ Doesn't quite work yet, getting strange crashes.
20160916 17:52:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 17:52:11< celticminstrel> Any ideas welcome.
20160916 17:54:02-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 17:54:03< travis-ci> wesnoth/wesnoth#10994 (master - b48d08d : Charles Dang): The build passed.
20160916 17:54:03< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160503240
20160916 17:54:03-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 17:58:04-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has quit [Ping timeout: 265 seconds]
20160916 17:58:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160916 17:59:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 18:07:14< gfgtdf> zookeeper: is wesnoth.get_locations (and thus store locations) allowe to retrn invalid locations ?
20160916 18:07:45-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has joined #wesnoth-dev
20160916 18:07:45-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has quit [Changing host]
20160916 18:07:45-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20160916 18:07:58< mordante> servus
20160916 18:08:27-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has joined #wesnoth-dev
20160916 18:08:29< gfgtdf> zookeeper: like in [store_locations] find_in = array [/store_locations] where array contains invalid locations, shoudl it then just store these or only give back those that are valid (non negative xy)
20160916 18:09:16-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160916 18:11:18< mordante> vultraz, what is exactly the problem with the event handling?
20160916 18:11:40-!- boucman_work [~boucman@2a02-8428-034f-f800-d267-e5ff-fe3c-dad2.rev.sfr.net] has joined #wesnoth-dev
20160916 18:13:10< gfgtdf> mordante: can i throw an exception from a gui2 timer callback ?
20160916 18:13:23< zookeeper> gfgtdf, only stored the ones that are valid, i'd say
20160916 18:13:27< zookeeper> s/stored/store
20160916 18:14:13< gfgtdf> zookeeper: i'll add an extra check for map.on:map_with_border() in the filter implementation lets see whether it fixed the lua error.
20160916 18:14:53< mordante> gfgtdf, the code should be exception safe, else it is a bug
20160916 18:15:51-!- Kwandulin [~Miranda@p200300760F2C7196B062BF22006E7805.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160916 18:16:55< gfgtdf> mordante: and can i asume that the throws exception closes the dialog?
20160916 18:17:01< gfgtdf> thrown*
20160916 18:17:58-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 18:17:59< travis-ci> wesnoth/wesnoth#10995 (master - 9682df6 : Charles Dang): The build passed.
20160916 18:17:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160504813
20160916 18:17:59-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 18:19:40< mordante> gfgtdf, depends on the scope of the dialog
20160916 18:20:17< mordante> but best test it to be sure it works, it not something I recall testing
20160916 18:20:51< gfgtdf> mordante: i mean the loadingscreen in this case, in case the timer callback throws seomthig like 'filed ot load parse map' exception.
20160916 18:24:26-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160916 18:24:43-!- boucman_work [~boucman@2a02-8428-034f-f800-d267-e5ff-fe3c-dad2.rev.sfr.net] has quit [Ping timeout: 265 seconds]
20160916 18:24:52< vultraz> mordante: hm?
20160916 18:25:09< vultraz> oh, right
20160916 18:26:50< mordante> gfgtdf, do you have a pointer to a file and line number
20160916 18:27:09< vultraz> mordante: ok, so, the case here is two different widgets (text box and window) both registering SDL_KEY_DOWN events in the child queue. Text box's comes before window's (front child vs back child). Even though the first event sets halt= true it still executed the window handler, but did not proceed to the post child queue.
20160916 18:27:28< gfgtdf> mordante: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/loadscreen.cpp#L165
20160916 18:28:23-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160916 18:31:10< tad_> So I'm looking at the error "Tile at -999,-999 isn't on the map, can't scroll to the tile" which appears during early initialization and have a PR to avoid it. But after testing I'm thinking the scroll-on-map-first-loaded is not really needed even though it's been there since initial checkin in 2006
20160916 18:31:13-!- bumba [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160916 18:31:31< celmin> mordante: If you have time, could you look at this and see if there's anything obvious missing? The game crashes as soon as the textbox opens. https://github.com/wesnoth/wesnoth/commit/de0d462273df73a750b4f52c9d49bf77307ff27a
20160916 18:31:31< vultraz> tad_: what do you mean?
20160916 18:32:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Disconnected by services]
20160916 18:32:07-!- bumba is now known as bumbadadabum
20160916 18:32:08< tad_> During play controller initialization, the map is loaded and immediately checked for starting locations. If none appear we get this message.
20160916 18:32:30< vultraz> yeah, I thoight you fixed that in your pr
20160916 18:32:33< vultraz> thought
20160916 18:33:27< tad_> I fixed the error so it did not appear. But then I looked at why the code was there at all. I added a note to my PR saying when it makes sense and that I think the scroll should go away completely.
20160916 18:33:53< vultraz> so you're saying the game should NOT scroll to the leader initially?
20160916 18:34:51< tad_> I'm saying that for this scroll to mean anything the map must have the location; the [side] MUST say scroll_to_leader=no and there must be no scrolling [message]s during start
20160916 18:35:32-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 18:36:10< vultraz> the location being?
20160916 18:36:11-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160916 18:36:32< JyrkiVesterinen> Is there a way for Lua scripts to change preferences?
20160916 18:36:34< vultraz> the weird random location it scrolls  to?
20160916 18:36:39< tad_> Map special location. "Starting position" set by editor
20160916 18:36:46< celmin> tad_: Oky, so this is a "scroll to side's starting location" that happens before the normal "scroll to leader"?
20160916 18:36:46-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 18:36:55-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160916 18:37:02-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has joined #wesnoth-dev
20160916 18:37:12< tad_> celmin: yes
20160916 18:37:17< vultraz> tad_: if it's what celmin said is true, remove it
20160916 18:37:25< vultraz> JyrkiVesterinen: not that I know of
20160916 18:37:28< tad_> celmin: IFF the map knows the position and etc...
20160916 18:37:32< celmin> Seems like it wouldn't hurt to remove it.
20160916 18:37:44< JyrkiVesterinen> vultraz: OK, then I'll start implementing that myself.
20160916 18:37:48< celmin> Probably someone who said scroll_to_leader=no wouldn't actually want it to scroll anywhere.
20160916 18:37:56< tad_> Worst case, if all conditions are met the map hangs around at (0,0) until a unit moves
20160916 18:38:42< tad_> celmin: This goes to your regression on 1.12.6 and jumping messages. 
20160916 18:38:59< celmin> Huh? How so?
20160916 18:39:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160916 18:39:08< vultraz> tad_: while you're at it can you make the game select the first leader it scrolls to?
20160916 18:39:27< tad_> celmin: Specifically, it positions the map to the first human leader (or side 1) IF IT CAN and they means the map MAY avoid a jump at the start.
20160916 18:39:28< mordante> gfgtdf, why the storing of the exception in exception_?
20160916 18:39:29< vultraz> or at least displayit in the sidebar
20160916 18:39:32-!- Necrosporus_ [~Necrospor@unaffiliated/necrosporus] has joined #wesnoth-dev
20160916 18:39:49< mordante> gfgtdf, it does not show the life-time and catch point of the exception
20160916 18:39:50< gfgtdf> mordante: to transfer it from the wroking thread to te main thread.
20160916 18:39:58< tad_> vultraz: Sure. If you have two human sides (1 and 2) only put starting position for 2 in the map
20160916 18:40:12< vultraz> tad_: ?
20160916 18:40:13< mordante> gfgtdf, so I don't know whether the object is destroyed or not
20160916 18:40:38< tad_> vultraz: That would cause this early-scroll to scroll to side=2 leader
20160916 18:40:52< vultraz> I.. what...?
20160916 18:40:55< celmin> tad_: So not really related to messages then?
20160916 18:41:10< tad_> vultraz: I tested and you can NOT [scroll_to] in prestart.
20160916 18:41:32< vultraz> tad_: I'm asking you to make it select the leader it DOES scroll to initially 
20160916 18:41:49< vultraz> after you remove this excessive scroll
20160916 18:41:50< gfgtdf> mordante: they shodul get ceought be teh code that calls dialog.show(video).
20160916 18:41:51< tad_> celmin: The relationship to messages is they scroll and this pre-sets the map. So it's possible this might avoid a jump, if all conditions are met
20160916 18:42:17< vultraz> and yes, we need to fix message scrolling
20160916 18:42:19< vultraz> excessively
20160916 18:42:21< vultraz> it's horrible
20160916 18:42:32< tad_> vultraz: Ah. As coded and as I currently try to maintain in my PR it is "first human side, else side 1"
20160916 18:43:04-!- Necrosporus [~Necrospor@unaffiliated/necrosporus] has quit [Ping timeout: 255 seconds]
20160916 18:43:40< vultraz> yeah, no need to highlight that side's leader on the map, just show it in the sidebar
20160916 18:44:33< tad_> vultraz: Not "highlight" (no green selection hex) just "scroll" who appears on the sidebar is done elsewhere.
20160916 18:44:55< vultraz> yes I know...
20160916 18:45:04 * tad_ nods.
20160916 18:45:12< vultraz> I'm asking if you could add the "show in the sidebar" thing when it scrolls :|
20160916 18:45:13< tad_> Just making sure we're all clear
20160916 18:45:46< vultraz> right now if you skip/have no messages and stuff, you can end up on turn 1 with no unit displaying in the sidebar and it looks rather odd
20160916 18:45:57< tad_> vultraz: At this point: no. The UI has not been initialized; including Lua has not been initialized. All we have is the map. [side] not loaded as yet,
20160916 18:46:16< vultraz> I see
20160916 18:46:31< mordante> vultraz, gui/core/event/dispatcher.hpp:216 has the documentation. Did you set both halt and handled? 
20160916 18:46:38< vultraz> i did
20160916 18:47:46< zookeeper> vultraz, why would we want any leader to be selected automatically?
20160916 18:48:00< vultraz> zookeeper: to not have an empty sidebar at game start?
20160916 18:48:37< zookeeper> i'd argue there's nothing odd-looking about having no unit selected
20160916 18:48:59< tad_> So, my impression is what they thought, back in 2006, was "I just loaded the map and I'm about to init the UI and display it, I should try to scroll someplace reasonable." and, some time later, [message] and [side]scroll_to_leader came along and changes the issue ...
20160916 18:49:31< tad_> zookeeper: I would agree and it happens often during normal play.
20160916 18:49:40< mordante> celmin, I don't directly see an obvious error and I don't have time right now to look at it closely
20160916 18:50:28< mordante> gfgtdf, is the entire game threaded now?
20160916 18:51:05< vultraz> mordante: no, just the loadscreen
20160916 18:51:12< vultraz> celmin: why are you using set_font_size in a gui2 dialog
20160916 18:51:43< celmin> vultraz: I got the impression that it's defined in twidget or tcontrol or something.
20160916 18:52:03< celmin> I didn't really look closely though… I'll check, I guess.
20160916 18:52:13< vultraz> ah
20160916 18:52:16< vultraz> yes, you're right
20160916 18:52:24< vultraz> it's in widgets/text.hpp
20160916 18:52:32< celmin> I don't see a problem with an empty sidebar either.
20160916 18:52:43< celmin> Ah, so it's in ttext_
20160916 18:52:52< tad_> gfgtdf: Any objection to changing my PR from suppressing the error messages to simply removing the scroll attempt altogether?
20160916 18:52:55< celmin> Well, the tfloating_textbox does inherit from that.
20160916 18:53:29< vultraz> celmin: you have a stacktrace i assume?
20160916 18:54:27< mordante> vultraz, then it seems like a bug
20160916 18:54:49< vultraz> mordante: the event thing, you mean?
20160916 18:55:12< celmin> vultraz: I could get one, though it wasn't a very helpful one.
20160916 18:55:14-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20160916 18:56:39-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20160916 18:56:49< mordante> vultraz, yes
20160916 18:56:55< vultraz> potentially, yes
20160916 18:56:59< vultraz> or im doing it wrong :/
20160916 18:57:20-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 18:57:21< travis-ci> wesnoth/wesnoth#10997 (master - 6df17b3 : Bär Halberkamp): The build passed.
20160916 18:57:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160507832
20160916 18:57:21-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 18:57:35 * tad_ cheers!
20160916 19:00:29< vultraz> celmin: try setting an id for the widgets
20160916 19:00:35< vultraz> set_id or something
20160916 19:00:39< vultraz> before definiton
20160916 19:00:46< celmin> I don't think that'll help, but I'll give it a try anyway.
20160916 19:00:49< vultraz> im gonna try to get som sleep
20160916 19:00:56< celmin> Good idea.
20160916 19:01:12< vultraz> mordante: btw, i also enabled the new credits by default now
20160916 19:01:20< gfgtdf> tad_: why woudl you want to do that ?
20160916 19:01:33< vultraz> mordante: and i made a detailed bug report https://gna.org/bugs/index.php?25065
20160916 19:01:37< vultraz> about the surface thing
20160916 19:01:38< vultraz> -> out
20160916 19:02:48< tad_> gfgtdf: Seems a waste when it only happens to have an effect under limited conditions which seem rare. But, since you question it at all, I will leave the PR and consider it complete and ready to merge if you have no further issues with it.
20160916 19:02:53< gfgtdf> vultraz:  have observed a similar issue with the lua console that the text wont show anymore if its too long
20160916 19:04:12< vultraz> gfgtdf: oh? good to know
20160916 19:04:22< mordante> gfgtdf, tloadscreen::display is a static and seems the only place where the tloadscreen is created
20160916 19:04:48< mordante> gfgtdf, so it should destroy the window if that function is terminated by an exception
20160916 19:05:28< mordante> gfgtdf, maybe also make the tloadscreen's constructor private, I assume it is not wanted (allowed) to create it from other places
20160916 19:05:55< mordante> gfgtdf, that would screw up the current_load pointer
20160916 19:06:18< mordante> vultraz, nice, hope to find some time to look at the changes soonish
20160916 19:09:41-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 19:09:42< travis-ci> gfgtdf/wesnoth-old#688 (location_refeactor - 2a5755c : gfgtdf): The build is still failing.
20160916 19:09:42< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/160524614
20160916 19:09:42-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 19:09:45< zookeeper> mattsc, eh, yeah he has a point, and after some investigation it looks like a lot of [tunnel] users use a [filter][not] already, presumably to get rid of that glitch.
20160916 19:12:23-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160916 19:14:42< mattsc> zookeeper: yeah, I agree and it does make sense.
20160916 19:14:57< mattsc> By the same arguments, I think that vision through tunnels should be the default.
20160916 19:15:29< mattsc> So I’ll add that into my next PR, which will deal mostly with the vision part.
20160916 19:16:12< mattsc> I have figured out how to do that, btw.  The functionality itself is pretty simple.  The trick will be how to pass the required parameters through to the part of the code that needs them.
20160916 19:16:35< mattsc> I’d like to avoid adding yet another argument to find_routes()  :P
20160916 19:19:46< mattsc> Hmm, actually, find_routes is only called internally from within pathfind.cpp.  Everything else uses one of the wrapper functions.  So maybe adding an argument is not all that tedious.
20160916 19:22:08-!- gfgtdf [~chatzilla@x50ab6d66.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]]
20160916 19:23:18< zookeeper> vision through tunnels makes sense as the default, but i'd think an option seems warranted since there's no way to simulate a traditional teleporter otherwise
20160916 19:23:49< tad_> zookeeper: I'm working on that table of Unicode characters outside the ASCII range .. fyi there are 510 lines in 38 files which have tab (\t .. \x09) .. any desire to replace those with spaces?
20160916 19:24:03< tad_> zookeeper: in ~/data/campaigns
20160916 19:24:44< zookeeper> tad_, not really, it's not like they get in anyone's way
20160916 19:26:31< tad_> zookeeper: OK. Then, except for \t \r \n and displayable-ascii there are not that many Unicide characters and many appear to be in people's names for credits. Mainly an apostrophe and em-dash are what I see. Might be a few less-frequently used.
20160916 19:27:01< zookeeper> yeah i would't expect much others
20160916 19:27:18< celmin> Which glitch?
20160916 19:27:32< zookeeper> those and the x symbol, and... well, can't think of others off the top of my head
20160916 19:28:18< tad_> zookeeper: I'll put together a list and we can add it as  a .txt to /data if you'd like. But, to be honest, when I hit one, I use a charmap utility to get the keystroke.
20160916 19:30:23< zookeeper> ah, true, i had forgotten that windows has the character map thing that i could have used...
20160916 19:30:31< mattsc> zookeeper: yes, I am planning to make vision togglable: allow_vision=yes/no with yes as the default.
20160916 19:30:46< zookeeper> mattsc, awesome
20160916 19:31:57< JyrkiVesterinen> zookeeper: http://unicode-table.com/en/ is also useful for picking Unicode characters.
20160916 19:33:03< tad_> zookeeper: There are 3163 lines in 3131 files in data/campaign with Unicode outside base ASCII set. 3051 lines in 338 files if I ignore 'name='
20160916 19:33:13 * zookeeper bookmarks
20160916 19:34:42< celmin> Does vision currently work through tunnels?
20160916 19:35:29< zookeeper> oh wait no i'm not bookmarking that, i can't find anything in it :p
20160916 19:36:31< celmin> By the way, does anyone think it would be a good idea to do "smart quotes" conversion in [message] strings?
20160916 19:36:36< tad_> Well "Google is your friend" there's a bazillion Unicode character sites. Most for web. But Windows/Linux charmap works best for me
20160916 19:36:53< celmin> Though I guess that be difficult with translations...
20160916 19:37:00< celmin> But not impossible.
20160916 19:38:06< tad_> celmin: I don't see the need for it. If it happens much, I'd be surprised. Most of the ' I see are about 50/50 balanced and unbalanced.
20160916 19:38:32< celmin> …or maybe it would be impossible. It's solvable with respect to any languages that I know anything about in that area, but might not be generally solvable.
20160916 19:39:08< celmin> Might be cool if wmllint had an option to warn about non-smart quotes. (Or does it already? I don't usually use it.)
20160916 19:41:05< zookeeper> celmin, example?
20160916 19:41:19< celmin> Eh?
20160916 19:41:54< zookeeper> of your proposal.
20160916 19:43:08< celmin> Probably not worth it, but… set the string to «Li'sar said "Hi!"» and the game automatically corrects it to «Li’sar said “Hi!”»
20160916 19:43:24 * celmin using «» as delimiters because the string contains both ' and "
20160916 19:43:49-!- prkc [~prkc@46.166.190.231] has quit [Ping timeout: 255 seconds]
20160916 19:43:57-!- gfgtdf [~chatzilla@x50ab6d66.dyn.telefonica.de] has joined #wesnoth-dev
20160916 19:44:15< gfgtdf> vultraz: any opinion on 779 ?
20160916 19:44:15-!- prkc [~prkc@46.166.138.130] has joined #wesnoth-dev
20160916 19:45:19< celmin> Random thought - the change to dynamic_bitset could've increased efficiency in a few places (anywhere using standard algorithms, if they weren't specialized for vector<bool>).
20160916 19:46:05< zookeeper> celmin, automatic correction? huh, okay... well, i dunno.
20160916 19:46:33< zookeeper> do we even have any strings with " in them?
20160916 19:47:46< zookeeper> i mean IIRC those would be escaped like _"Li'sar said ""Hi!""" and my grep says there aren't any
20160916 19:55:35< celmin> No idea.
20160916 19:55:51< celmin> I feel like I've heard there were some, but I dunno.
20160916 19:56:01< celmin> Definitely there's a lot of ' though.
20160916 19:57:44< zookeeper> tad_, sorry, one little thing: when li'sar speaks her assault from the air line, it's... not really clear yet what's happening yet because konrad hasn't delivered his line
20160916 19:57:44< tad_> celmin: some ' and some ` and some unicode variant of ' and most are unbalanced that I see
20160916 19:58:04< zookeeper> so it comes off as her commenting on the gryphons attacking someone right now
20160916 19:58:11< celmin> What the heck is ` used for? o.o
20160916 19:58:19< tad_> zookeeper: np. Move it down or remove it?
20160916 19:58:36< tad_> celmin: `sure, I have not idea'
20160916 19:58:44< celmin> That's ridiculous.
20160916 19:58:59< celmin> Where is that used? :|
20160916 19:59:14< zookeeper> tad_, move it down i think
20160916 19:59:18< tad_> celmin: Not sure it is.
20160916 19:59:23< celmin> Oh. I hope not.
20160916 19:59:30< tad_> zookeeper: ok. takes just a moment.
20160916 20:02:06< tad_> zookeeper: OK. refresh and check now
20160916 20:03:26< tad_> celmin: Actually, data/campaign .. grep for ` .. not found
20160916 20:03:39< celticminstrel> Excellent.
20160916 20:04:58< irker112> wesnoth: Gregory A Lundberg wesnoth:master 898cf3b35d9c / data/campaigns/Heir_To_The_Throne/scenarios/ (4 files): HttT S22 Gryphons return https://github.com/wesnoth/wesnoth/commit/898cf3b35d9c63c2d01a3178f345e332f5e80bd2
20160916 20:05:00< irker112> wesnoth: Lari Nieminen wesnoth:master 479e9062db1c / data/campaigns/Heir_To_The_Throne/scenarios/ (4 files): Merge pull request #737 from GregoryLundberg/GL_HttT_S22_gryphons_return https://github.com/wesnoth/wesnoth/commit/479e9062db1c24220ac3c6179507842df236bf65
20160916 20:05:17< tad_> celticminstrel: Do not attempt to balance ' and apostrophe .. they appear properly unbalanced multiple times on some message and description lines
20160916 20:07:13-!- horus2 [~1@213.197.82.130] has joined #wesnoth-dev
20160916 20:12:07< celticminstrel> Looks like nearly all uses of ` in Wesnoth are one of: Markdown, shell script, comments/strings in the Lisp files (bad!), TEX (why!!?), manpages (what...), Python (scons?), comments in the Lua source (why!), UMC-dev changelog (GAH!).
20160916 20:12:26< celticminstrel> Markdown, shell, and Python are fine, of course, but most of those others seem bad. :(
20160916 20:12:28< irker112> wesnoth: Gregory A Lundberg wesnoth:master a87898162861 / src/playsingle_controller.cpp: Fix bug: Map may not have starting positions https://github.com/wesnoth/wesnoth/commit/a878981628612317197e17ecfb2a09d8a0273ed5
20160916 20:12:30< irker112> wesnoth: gfgtdf wesnoth:master fe85fa86cbf8 / src/playsingle_controller.cpp: Merge pull request #772 from GregoryLundberg/GL_allow_no_starting_positions https://github.com/wesnoth/wesnoth/commit/fe85fa86cbf8b6335000bf1bc6742391203f9165
20160916 20:12:46< zookeeper> tad_, any reason for https://github.com/wesnoth/wesnoth/pull/736/files#diff-ca17024acef573011c9773cb31137191R175 ? that's contrary to how ... is used everywhere else.
20160916 20:13:29-!- Greg-Boggs [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 20:13:57< tad_> zookeeper: I do not understand the question
20160916 20:14:16< zookeeper> you changed "..." to " ..." for seemingly no reason
20160916 20:14:31< celticminstrel> I can't tell which is which.
20160916 20:14:41< celticminstrel> Did he change three dots to ellipsis, or ellipsis to three dots?
20160916 20:14:47< tad_> Oh. Added a space in front of it. OK. Will put it back.
20160916 20:17:14< zookeeper> tad_, anyway i think that's otherwise good to go in. i'm not sure about whether the ambush/defense/movement effects of the book are the best possible idea, but i don't have anything else in mind myself.
20160916 20:18:10< JyrkiVesterinen> Hmm... I wonder what's going on with our version of Lua.
20160916 20:18:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160916 20:18:13< tad_> AT least they're (marginally) usefull on the following scene. Not a lot left and mostly no woods.
20160916 20:18:21< JyrkiVesterinen> From what I can tell, we are using Lua 5.2.3.
20160916 20:18:47< JyrkiVesterinen> However, we have luaL_typerror(), even though the reference manual for Lua 5.2 says:
20160916 20:18:54< JyrkiVesterinen> "luaL_typerror was removed. Write your own version if you need it."
20160916 20:19:22< JyrkiVesterinen> Not that I'm complaining, I have use for that function.
20160916 20:19:25< tad_> zookeeper: wose assistance .. refresh and it should be good to go
20160916 20:19:46< JyrkiVesterinen> It's just strange that the function is available while the documentation claims that it has been removed. :/
20160916 20:20:30< tad_> zookeeper: damn. wait
20160916 20:20:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20160916 20:20:39-!- wedge010 is now known as wedge009
20160916 20:21:01< tad_> zookeeper: somehow s22 which just merged got in it/
20160916 20:21:42< zookeeper> whoops
20160916 20:23:24< tad_> zookeeper: OK. looks good now.
20160916 20:24:02 * tad_ wonders how many players will actually notice all the changes to HttT ...
20160916 20:25:45< irker112> wesnoth: Gregory A Lundberg wesnoth:master d4ec02404827 / data/campaigns/Heir_To_The_Throne/scenarios/ (20b_Underground_Channels.cfg 25_HttT_Epilogue.cfg): HttT S20b Wose assistance quest https://github.com/wesnoth/wesnoth/commit/d4ec024048272aed0099ca8ca39d32b24219823a
20160916 20:25:47< irker112> wesnoth: Lari Nieminen wesnoth:master f5b4ecf0c368 / data/campaigns/Heir_To_The_Throne/scenarios/ (20b_Underground_Channels.cfg 25_HttT_Epilogue.cfg): Merge pull request #736 from GregoryLundberg/GL_HttT_S20b_wose_assistance https://github.com/wesnoth/wesnoth/commit/f5b4ecf0c368b04b4d68e210a3e14ebeb1dc73be
20160916 20:26:03-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 20:26:04< travis-ci> gfgtdf/wesnoth-old#689 (location_refeactor - 16b61bf : gfgtdf): The build has errored.
20160916 20:26:04< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/160541701
20160916 20:26:04-!- travis-ci [~travis-ci@ec2-54-80-22-93.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 20:28:52< zookeeper> tad_, i hope you know what you're doing with Snow Detritus #735 since it's not something i can proofread... :p
20160916 20:29:25< tad_> The Lua? I think it's good. But ..
20160916 20:29:42< tad_> celmin: Can you proof my Lua work on PR 735 for zookeeper 
20160916 20:30:36< celmin> JyrkiVesterinen: My guess is that, when switching to Lua 5.2, Wesnoth copied that function from the previous Lua version because it was used a lot.
20160916 20:30:44< celmin> Bah. Okay fine.
20160916 20:30:48< celmin> 735...
20160916 20:30:55 * tad_ nods
20160916 20:31:08-!- Greg-Bog_ [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 20:31:20< JyrkiVesterinen> celmin: even then, I'm surprised that the function is declared in lua/lauxlib.h that is one of Lua's own header files.
20160916 20:31:23< tad_> celmin: So he has a second opinion it does what's needed and is not a mistake
20160916 20:31:48-!- Greg-Boggs [~greg_bogg@131.252.200.36] has quit [Read error: Connection reset by peer]
20160916 20:31:54< celmin> Probably because whoever did it just put it back where it was in the previous version.
20160916 20:32:28< JyrkiVesterinen> That's a wrong place. We shouldn't be messing with Lua source code.
20160916 20:32:39< JyrkiVesterinen> We have our own files for Lua API extensions.
20160916 20:32:52< celmin> I think there are other places where we've messed with Lua source code.
20160916 20:33:15< celmin> Something about the tlua_jailbreak_exception, I think?
20160916 20:33:18 * tad_ agrees. Once you change upstream code you're taking responsibility for it. Not a good idea if you can avoid it
20160916 20:33:21< celmin> Maybe others, I dunno.
20160916 20:33:35< celmin> Oh, and I think gfgtdf changed its string equality implementation...
20160916 20:33:37< JyrkiVesterinen> And that makes future Lua updates even harder when we can't just drop Lua 5.3 files into the lua/ directory...
20160916 20:33:41< celmin> Yeah.
20160916 20:33:43< celmin> It does.
20160916 20:34:51< celmin> Hmm, thinking about it… maybe what I should do is drop Lua 5.2 files in, commit the changes, revert the commit, save that diff, drop Lua 5.3 files in, and attempt to apply the patch… >_>
20160916 20:35:16< celmin> So tad_, what does the snowCoverage variable contain?
20160916 20:35:38< tad_> [0..1] percentage of area.
20160916 20:35:49< celmin> Why did you shallow-parse a filter that's already fully parsed?
20160916 20:35:57< irker112> wesnoth: gfgtdf wesnoth:master 553ac0fd0529 / src/ (53 files in 17 dirs): add wml_x/y() getter & setter in map_location https://github.com/wesnoth/wesnoth/commit/553ac0fd05290c5a3d3bbdb130e75f20d1c01bdb
20160916 20:35:59< irker112> wesnoth: gfgtdf wesnoth:master 3de50e526366 / src/ (game_preferences.cpp map/map.hpp): also mark terrains in map border as encountered. https://github.com/wesnoth/wesnoth/commit/3de50e526366848ff3ca9016c892f55c2a262bba
20160916 20:36:01< irker112> wesnoth: gfgtdf wesnoth:master b43e5e697e84 / src/server/server.cpp: remove an include https://github.com/wesnoth/wesnoth/commit/b43e5e697e842527ae9faf01bfa8d07005c7e603
20160916 20:36:03< irker112> wesnoth: gfgtdf wesnoth:master e8bf29c241a5 / src/ (13 files in 5 dirs): clean some includes https://github.com/wesnoth/wesnoth/commit/e8bf29c241a596d25aeb0ab35cc73aec80a1ac2c
20160916 20:36:05< irker112> wesnoth: gfgtdf wesnoth:master 050ef3ecd9a5 / src/ (8 files in 4 dirs): make gamemap.tiles_ non-jagged https://github.com/wesnoth/wesnoth/commit/050ef3ecd9a586408868e962efb57a54779fea5e
20160916 20:36:06< celmin> :|
20160916 20:36:07< irker112> wesnoth: gfgtdf wesnoth:master 62bbab330d07 / src/ (editor/map/editor_map.hpp map/map.cpp map/map.hpp): remove unused code. https://github.com/wesnoth/wesnoth/commit/62bbab330d07a8d072d4296b571c8cc9088573f3
20160916 20:36:09< irker112> wesnoth: gfgtdf wesnoth:master 49621e3d2a7a / src/ (6 files in 4 dirs): remove border parameter from gamemap::overlay https://github.com/wesnoth/wesnoth/commit/49621e3d2a7ae8ca19c581c4880e7905e066a49f
20160916 20:36:11< irker112> wesnoth: gfgtdf wesnoth:master d9a7729dbc1b / src/map/map.cpp: fix [terrain_mask][rule]use_old=yes https://github.com/wesnoth/wesnoth/commit/d9a7729dbc1b3ad1e0d82c7282f0eb416e4e5fcd
20160916 20:36:12< tad_> No idea. You know me .. copy code and pray ..
20160916 20:36:13< irker112> wesnoth: gfgtdf wesnoth:master 296faefa20ad / src/ (map/map.cpp map/map.hpp scripting/lua_common.cpp): remove gamemap.border_size_ https://github.com/wesnoth/wesnoth/commit/296faefa20ad023bfd578a4b1f1836d422d258f0
20160916 20:36:15< celmin> I was still not finished looking at that. :/
20160916 20:36:15< irker112> wesnoth: gfgtdf wesnoth:master 94611c696730 / src/map/ (map.cpp map.hpp): remove gamema::bordercache and gamema::terrainfrequencycache https://github.com/wesnoth/wesnoth/commit/94611c696730f11c7b177c325316bb6087245bd2
20160916 20:36:17< irker112> wesnoth: gfgtdf wesnoth:master e93c6ae75e1f / src/terrain/filter.cpp: make filter never pass on off-map locations https://github.com/wesnoth/wesnoth/commit/e93c6ae75e1fe1a7141fe536a2002ee071b0991d
20160916 20:36:19< irker112> wesnoth: gfgtdf wesnoth:master 96a8635ed989 / src/minimap.hpp: fix travis build https://github.com/wesnoth/wesnoth/commit/96a8635ed98923d8b9fa1169a0ed11a28d68fc4f
20160916 20:36:21< irker112> wesnoth: gfgtdf wesnoth:master 8aa373246c64 / src/map/map.cpp: cleanup gamemap::overlay https://github.com/wesnoth/wesnoth/commit/8aa373246c6411004980a0dc5783cdf3907948ab
20160916 20:36:59< gfgtdf> celmin: hmm i somehow thought you were.
20160916 20:37:14-!- Greg-Bog_ [~greg_bogg@131.252.200.36] has quit [Remote host closed the connection]
20160916 20:37:39< celmin> I only looked at the first few commits.
20160916 20:37:43< celmin> I hadn't looked at the rest.
20160916 20:38:42< gfgtdf> celmin: sis you see my comment in the pr about making map location use wml format internally ?
20160916 20:38:44< gfgtdf> did*
20160916 20:38:49< celmin> So tad_, I don't see anything bad, per se; just stylistic things mainly.
20160916 20:39:00< celmin> gfgtdf: I don't remember if I saw it.
20160916 20:39:22< tad_> celmin: but I should remove the shallow parse and just use the cfg?
20160916 20:39:42< celmin> I'm going to comment on the PR so I can keep it straight.
20160916 20:40:05< tad_> ok
20160916 20:44:57< gfgtdf> celmin: i can leave the pr open you you can still comment on it if you want.
20160916 20:44:59-!- Greg-Boggs [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 20:46:01-!- Greg-Boggs [~greg_bogg@131.252.200.36] has quit [Remote host closed the connection]
20160916 20:46:03< tad_> zookeeper: it's late in your day, I'll have the 735 updated for you your-tomorrow.
20160916 20:46:14< zookeeper> sure
20160916 20:47:16-!- Greg-Boggs [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 20:48:54< celmin> tad_: Done.
20160916 20:50:42< celmin> gfgtdf: Idea: wesnoth.is_walkable(x y) ?
20160916 20:50:48-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20160916 20:51:00-!- Greg-Bog_ [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 20:51:42< gfgtdf> celmin: that sounds like it would test whether the terain at (x,y) is not the unwalkable terrain.
20160916 20:51:52< celmin> Hmm, point.
20160916 20:51:56< celmin> is_border?
20160916 20:52:07< celmin> Opposite meaning, but still same use.
20160916 20:52:19-!- Greg-Boggs [~greg_bogg@131.252.200.36] has quit [Read error: Connection reset by peer]
20160916 20:54:11< gfgtdf> celmin: hmm maybe, i currently have no usecases for it though.
20160916 20:54:52< gfgtdf> celmin: shodul i close the pr or do you still want to look at it ?
20160916 20:55:06< celmin> I'm looking at it right now.
20160916 20:55:25< celmin> Why does get() take the y coordinate first?
20160916 20:55:36< celmin> It should be the other way around.
20160916 20:55:49< tad_> celmin, gfgtdf: thank you for comments I will be making them now.
20160916 20:56:00< celmin> gfgtdf made comments, huh?
20160916 20:56:04< celmin> I missed that.
20160916 20:57:08< tad_> I think he made the same one you did about rolling up the array init
20160916 20:57:15< celmin> Yeah, I see now.
20160916 20:59:18-!- horus2 [~1@213.197.82.130] has left #wesnoth-dev []
20160916 20:59:50< celmin> gfgtdf: Why did you remove border from [terrain_mask]? We said it was fine to remove it from the map header, but not in [terrain_mask]...
20160916 20:59:57< celmin> It should be kept in [terrain_mask].
20160916 21:00:57< celmin> Fairly sure it needs to be in [terrain_mask] for certain masks to work properly.
20160916 21:01:27-!- Greg-Bog_ [~greg_bogg@131.252.200.36] has quit [Remote host closed the connection]
20160916 21:01:45< celmin> I'm not quite sure if reverting ab4e40407be4abe6df43e43fb0668c3f0640e76b in its entirety is the answer here...
20160916 21:02:27< celmin> (With border_size removed from the map class, it may need to be implemented differently.)
20160916 21:03:22-!- Greg-Boggs [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 21:04:09< celmin> 862178d801245baa7aeb33f81f9182b4c3c15790 may also need full or partial revert with respect to that.
20160916 21:07:40-!- Greg-Boggs [~greg_bogg@131.252.200.36] has quit [Ping timeout: 244 seconds]
20160916 21:08:31-!- Greg-Boggs [~greg_bogg@131.252.200.36] has joined #wesnoth-dev
20160916 21:09:01< tad_> celmin: Lua how to use ^ in a key ... eg PR 735 your comment about the lookup table init     Gd^Vc = 'Aa^Vca', gets } expected error
20160916 21:09:18< celmin> I actually already answered that in my comment.
20160916 21:09:31-!- aur [b024f657@gateway/web/freenode/ip.176.36.246.87] has joined #wesnoth-dev
20160916 21:09:36 * tad_ looks again.
20160916 21:09:58-!- aur [b024f657@gateway/web/freenode/ip.176.36.246.87] has quit [Client Quit]
20160916 21:11:06< tad_> AH! Now that comment you made makes sense.
20160916 21:13:23-!- Greg-Boggs [~greg_bogg@131.252.200.36] has quit [Ping timeout: 272 seconds]
20160916 21:13:31< gfgtdf> celmin: i didn remove border form terrain_mask
20160916 21:15:46-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160916 21:17:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160916 21:20:27< shadowm> loonycyborg: No idea.
20160916 21:20:59< shadowm> loonycyborg: I thought what was wanted in that code was an array of pointers but okay.
20160916 21:21:24< celmin> gfgtdf: Whoops, sorry, missed that. Okay, then what about get(y,x)?
20160916 21:22:17< gfgtdf> celmin: commented in the pr
20160916 21:22:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160916 21:23:09< celmin> gfgtdf: I didn't quite understand what you said there. Are you saying that the get function is defined as get(x,y), but that that one place deliberately transposes them?
20160916 21:24:30< gfgtdf> celmin: for some reason that code expectes the y to be in the first parameter there, the corresponging parse map (thhere are 2 of them) function also puts the y in the first parameter.
20160916 21:24:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160916 21:25:32< celmin> Hmm, that's strange...
20160916 21:25:53< celmin> Is the intent to transpose the map? Are the x/y variable names swapped? What's going on there? :|
20160916 21:26:05< tad_> celmin: Made your changes and pushed 735. If it's OK for you, let zookeeper know, please. I tested from 0 to 100% coverage and it seems fine to me.
20160916 21:27:01< gfgtdf> celmin: i don't know why they do that, i just decided not to change it that much for now.
20160916 21:27:22< celmin> tad_: One other thing, am I imagining it or do you know longer use helper.lua?
20160916 21:27:31< celmin> If so, you might want to remove the require.
20160916 21:27:35< celmin> ^no longer
20160916 21:27:47< celmin> gfgtdf: Okay, fair enough.
20160916 21:27:57< tad_> celmin: Probably correct. I'll remove it.
20160916 21:28:01< celmin> gfgtdf: But, just to be clear, get() is defined to take x,y, right?
20160916 21:28:04< celmin> Not y,x?
20160916 21:28:13< gfgtdf> celmin: yes
20160916 21:28:37< celmin> Okay, then my concerns seem to be cleared up. BTW, did you test that [terrain_mask] still works both with and without border?
20160916 21:29:12< gfgtdf> celmin: most liekey that code (terrain/builder.cpp and read_builder_map) can be 'fixed' to use them in the normal order
20160916 21:29:42< gfgtdf> celmin: i tested 2 cases in mainline with border=yes/no (so 4 in total.)
20160916 21:30:16< tad_> celmin: All done. No errors removing require. Appreciate it.
20160916 21:30:48< gfgtdf> tad_: do yu still plan to update Lo
20160916 21:30:51< gfgtdf> W
20160916 21:30:59< gfgtdf> tad_ to use starting location in masks ?
20160916 21:31:56< tad_> gfgtdf: Yes. Provided zookeeper does not kick me in the knees when I put of the PR for it :P
20160916 21:32:32< tad_> gfgtdf: I have not started work, if you have changes or suggestions, I can wait.
20160916 21:32:43< zookeeper> if possible, you should get fabi to review LoW PR's
20160916 21:32:54< tad_> zookeeper: Will do.
20160916 21:33:16< celmin> Instead of you, or as welll?
20160916 21:33:20< celmin> Gah, extra L there.
20160916 21:33:34< tad_> zookeeper: Lua checks out. 735 s/b good to go.
20160916 21:33:45< zookeeper> mmkay
20160916 21:34:35< celmin> Okay, finally I can get back to ~ADJUST_ALPHA().
20160916 21:34:43< gfgtdf> tad_: iirc fabi didn't like to 'special locatiosn' feature, but i dont see a reason why we wouldn't like using the startign locatiosn defeined in masks.
20160916 21:34:46 * tad_ chuckles.
20160916 21:35:01 * tad_ chuckles at celmin
20160916 21:35:04< celmin> And after tha, maybe back to the floating textboxes.
20160916 21:35:28< celmin> ^that
20160916 21:35:45< celmin> Authentication dialogs always like to steal focus. :/
20160916 21:35:56< tad_> gfgtdf: Well, it's good form to have a single-point-of-control and the mask and map are it for LoW. Move a castle in the editor and forget to change an x,y and he'll see why
20160916 21:37:22< tad_> gfgtdf: Frankly, given the state I found it in, Fabi had a point .. at the time.  You merged my changes, so there's a better way, nopw.
20160916 21:38:50< irker112> wesnoth: Jyrki Vesterinen wesnoth:expose-preferences-to-lua 56038bb212b8 / / (8 files in 4 dirs): Expose preferences to Lua https://github.com/wesnoth/wesnoth/commit/56038bb212b89a219afa80deffa0506eb73710fe
20160916 21:39:03< celmin> O_O
20160916 21:40:20< gfgtdf> tad_: well your changes were onyl about the case that the locatiosn were used together withs masks and in > 90% you'll use them without masks.
20160916 21:40:23< tad_> sorta surprised that was never done before
20160916 21:40:48< celmin> BTW mattsc, if you want to update the XCode project, please try to make sure the files are added in alphabetical order (I usually add them wherever, then right-click the parent group and sort them).
20160916 21:40:50< tad_> gfgtdf: Correct. But in several LoW the map is shared and the mask is what knows the positions.
20160916 21:40:59< gfgtdf> JyrkiVesterinen: what teh intention for that? i usualyl dont want to allow random addons to change my prefernces
20160916 21:41:06< irker112> wesnoth: Jyrki Vesterinen wesnoth:enable-gui2-lobby-in-gui2-lobby-test 9342c70413d7 / src/scripting/game_lua_kernel.cpp: Expose preferences to Lua https://github.com/wesnoth/wesnoth/commit/9342c70413d746763c59dfeaff0109689968e005
20160916 21:41:08< irker112> wesnoth: Jyrki Vesterinen wesnoth:enable-gui2-lobby-in-gui2-lobby-test 7aa0127982a9 / host-gui2.lua host.lua join-gui2.lua join.lua: Enable the GUI2 lobby in the GUI2 lobby test https://github.com/wesnoth/wesnoth/commit/7aa0127982a9c615a9248d2289a2e9f0fae4b603
20160916 21:41:10< irker112> wesnoth: Jyrki Vesterinen wesnoth:enable-gui2-lobby-in-gui2-lobby-test 159033242af5 / .travis.yml: Turn on GUI2 multiplayer tests in Travis CI https://github.com/wesnoth/wesnoth/commit/159033242af59a7e3191dbf622151801026eb72f
20160916 21:41:21< JyrkiVesterinen> gfgtdf: The intention is that other branch. ^ ;)
20160916 21:41:27< celmin> mattsc: Obviously that's once the above branch is merged though.
20160916 21:42:46< mattsc> celmin: yeah, I usually try to do that too
20160916 21:42:47< gfgtdf> JyrkiVesterinen: right, maybe we shodul onyl allow to access the perferenes from thepluing kernel (and not from th game_lua_kernel) ?
20160916 21:42:51< tad_> JyrkiVesterinen: Good points about random lua .. is there a way to allow read access but restrict write access to only Lua from core lua?
20160916 21:43:36< JyrkiVesterinen> I don't know if it's possible to allow operations only for plugins.
20160916 21:44:16< celmin> JyrkiVesterinen: I believe there are functions in lua_common.hpp that deal with moving config::attribute_value to and from the Lua stack. Might want to consider using those instead of push_string.
20160916 21:45:07< gfgtdf> JyrkiVesterinen: hmm just move lua_preferences::register_table(L); from lua_kernel_base.cpp to application_lua_kernel.cpp
20160916 21:45:20< celmin> JyrkiVesterinen: Also, maybe set the __metatable field to a string, like other Wesnoth metatables do?
20160916 21:46:01< celmin> Other than that, I think this is great.
20160916 21:46:17< JyrkiVesterinen> Ah, I didn't know that application_lua_kernel is exclusive to plugins.
20160916 21:46:38< tad_> I'm all for being able to read the preferences. Change them does make me a bit nervous.
20160916 21:46:42< celmin> (I see the point gfgtdf and tad_ are making, but see no need to add further input to it.)
20160916 21:47:02< JyrkiVesterinen> I'll address the feedback later on, and open PRs when I'm done.
20160916 21:47:04< celmin> Is application_lua_kernal exclusive to plugins? I know that's what you get if you press ` at the titlescreen.
20160916 21:48:59< JyrkiVesterinen> celmin: a quick source code search shows that only plugin manager creates application_lua_kernel.
20160916 21:50:21< zookeeper> maybe i've missed prior discussion, but what sort of preferences should one ever need/want to change from lua? or is this only for read access?
20160916 21:50:26< celmin> Okay.
20160916 21:50:43< celmin> zookeeper: It's for the MP tests to enable/disable the new lobby.
20160916 21:51:00< gfgtdf> i am really against redable preferences from normal wml/lua. Note that the mp paswords which are also the forum pqasswords are saved there.
20160916 21:51:16 * celmin is thinking that making the new lobby default should probably wait until 1.13.7, with a converted MP Connect.
20160916 21:51:20< zookeeper> yeah i was about to mention the passwords
20160916 21:51:34< celmin> gfgtdf: Oh, good point.
20160916 21:51:35-!- Appleman1234_ [~Appleman1@KD119104048120.au-net.ne.jp] has joined #wesnoth-dev
20160916 21:51:46< celmin> There could be a special case excluding that preference, though.
20160916 21:52:03-!- Appleman1234 [~Appleman1@KD119104049219.au-net.ne.jp] has quit [Ping timeout: 248 seconds]
20160916 21:52:12-!- Appleman1234_ is now known as Appleman1234
20160916 21:52:19< JyrkiVesterinen> I think it would be easiest to just disable read access as well.
20160916 21:52:35 * celmin shrugs.
20160916 21:52:37< JyrkiVesterinen> Until we have a use case for Lua code outside of plugins to access preferences.
20160916 21:52:43< celmin> Fair enough, I guess.
20160916 21:53:04< celmin> If we find a use case we can easily add it to the game / mapgen kernel as desired.
20160916 21:54:15< celmin> (I still thing the password should be enciphered somehow, as well, but that's unrelated to this really.)
20160916 21:55:17 * tad_ restrains himself.
20160916 21:55:23< tad_> Where is this password?
20160916 21:55:30< celmin> In preferences.
20160916 21:55:37< celmin> It's only there if you've told Wesnoth to save it, though.
20160916 21:55:48< celmin> And Wesnoth does warn you that it's saved in plaintext.
20160916 21:55:56< tad_> It needs to be encrypted with a salt.
20160916 21:56:03< tad_> Which file. I'll take a look
20160916 21:56:22< celmin> Where is it stored, or which source file?
20160916 21:56:50< celmin> If the latter, I think it's probably in game_preferences.cpp.
20160916 21:57:02< celmin> Might be preferences.cpp.
20160916 21:57:10< tad_> Where is it stored? And where sent? And where received? It needs to be stored salted and the send/receive needs a nonce.
20160916 21:57:11< celmin> ^think not thing. Wow.
20160916 21:57:39< celmin> Sent from open_connection(), as I recall. Not sure where it's received, but somewhere in src/server/ presumably.
20160916 21:57:53-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:49b5:8176:2c41:79a] has joined #wesnoth-dev
20160916 21:57:54< celmin> Stored in the preferences file in your userdata dir.
20160916 21:58:08< celmin> (At least, it's in the userdata dir for me, not sure if that's universal.)
20160916 21:58:22< tad_> OK. I'll take a look at it. It's a major security escape to store it or transmit it in plaintext.
20160916 21:58:52< celmin> I'm not sure if it's transmitted in plaintext (didn't look too closely), but if it is, then yes, that absolutely needs fixing (it's more important than the storage issue IMO).
20160916 21:59:03-!- iceiceice [~chris@pool-71-172-187-9.nwrknj.east.verizon.net] has quit [Ping timeout: 240 seconds]
20160916 21:59:04 * tad_ nods.
20160916 22:00:02< celmin> It's definitely hashed at some point, since it needs to be matched against phpBB's database, so the transmission is likely at least that much.
20160916 22:00:06< tad_> Someone with milestone access .. please add a milestone to do a security audit and correct, if needed, the password store and transmission for 1.14 ??
20160916 22:00:24< celmin> Do I have milestone access?
20160916 22:00:41< tad_> I think vultraz does. Dunno who else
20160916 22:01:24< celmin> On github, I can add PRs to milestones, but I think I can't create new milestones. Maybe GNA also has milestones?
20160916 22:01:39-!- Greg-Bog_ [~greg_bogg@2601:1c2:901:e170:49b5:8176:2c41:79a] has joined #wesnoth-dev
20160916 22:01:57< celmin> Maybe I can create new milestones, if doing so is just adding a PR to a milestone that didn't previously exist...
20160916 22:02:11-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:49b5:8176:2c41:79a] has quit [Remote host closed the connection]
20160916 22:02:31< celmin> I think campaignd (and the addons client) also has possible security issues.
20160916 22:03:07< irker112> wesnoth: Gregory A Lundberg wesnoth:master 0caaaaa596cb / data/campaigns/Heir_To_The_Throne/scenarios/ (12_Northern_Winter.cfg 13_The_Dwarven_Doors.cfg): HttT S13 Add some random snow https://github.com/wesnoth/wesnoth/commit/0caaaaa596cb5e27f4a35a25991dc69fb052655b
20160916 22:03:09< irker112> wesnoth: Lari Nieminen wesnoth:master 1ab9b923dfa3 / data/campaigns/Heir_To_The_Throne/scenarios/ (12_Northern_Winter.cfg 13_The_Dwarven_Doors.cfg): Merge pull request #735 from GregoryLundberg/GL_HttT_S13_snow_ditritus https://github.com/wesnoth/wesnoth/commit/1ab9b923dfa3ffcecc8289a5e41b513b9890f99b
20160916 22:04:58-!- JyrkiVesterinen [~JyrkiVest@87-100-192-244.bb.dnainternet.fi] has quit [Quit: Going to bed]
20160916 22:05:31< tad_> Wow. I'm down to only 4 working branches. I need to get moving on LoW or I'm going to be left with just master ...
20160916 22:05:40< celmin> :P
20160916 22:07:33< irker112> wesnoth: Gregory A Lundberg wesnoth:master 9bf3f9150367 / data/campaigns/Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg: HttT S05b Use an Advisor https://github.com/wesnoth/wesnoth/commit/9bf3f9150367c0e58e136a84d023afe58a4299bc
20160916 22:07:35< irker112> wesnoth: Lari Nieminen wesnoth:master 6d36550e1e7e / data/campaigns/Heir_To_The_Throne/scenarios/05b_Isle_of_the_Damned.cfg: Merge pull request #731 from GregoryLundberg/GL_HttT_S05b_use_advisor https://github.com/wesnoth/wesnoth/commit/6d36550e1e7e0035028f609303e0e62901fffdbd
20160916 22:08:01< tad_> 3 .. I'm definitely not working fast enough ...
20160916 22:08:05< celmin> The epic HTTT cleanup is almost finished! \o/ (Unless that was the last one?)
20160916 22:08:14< tad_> 2 more
20160916 22:08:39< tad_> then a huge DM branch which I doubt will be reviewed soon but ya never know
20160916 22:08:58< celmin> Has the changelog been updated with all this?
20160916 22:10:03< tad_> Are you kidding?  How about a one-liner "HttT has had major cleanup and new content added. Play it if you want to see what changed!"
20160916 22:10:28< zookeeper> easier to do changelog updates afterwards than to constantly redo changelog commits because they always conflict so easily
20160916 22:10:33< celmin> I dunno, but I think there should definitely be something. 
20160916 22:10:33< celmin> True.
20160916 22:11:02 * tad_ thinks players should be surprised.
20160916 22:12:51< tad_> Actually, the wose, and gryphons probably need a changelog. Maybe the thieves. But I really don't think we need note that advancements of elvish fighters are considered when making the comment in S?? and a divide-by-zero was fixes generating snow .. etc
20160916 22:14:32 * tad_ coughs and coughs again
20160916 22:14:52< tad_> I think I have a cold coming on. Someone else wanna do the changelog entries for all my HttT work?
20160916 22:14:55 * tad_ grinZ
20160916 22:19:11< gfgtdf> i think its is transmitted in plaintext
20160916 22:22:28< tad_> gfgtdf: The we need that milestone. I'm adding it to my Issues. Has anyone else do this sort of work and want to take it on? I have, but am new to the code; I can do it but might get lost finding where and need help. So if someone feels qualified, please do.
20160916 22:27:14< tad_> zookeeper: Added PR 783 for player changelog for HttT.
20160916 22:27:15< celmin> I have not done this sort of work before (though I did take a crypto class in uni). I might get to it if no-one else does, and I think it's an important thing to deal with (especially if it's transmitted in plaintext), but it's not high on my list either.
20160916 22:28:32< tad_> celmin: Make you a deal. Set it middle priority and get too it before we get to the rush for 1.14 and I'll audit your work.
20160916 22:29:44< celmin> I'll add it to my list, I guess.
20160916 22:29:56< tad_> I have it on mine, now, too.
20160916 22:30:01< zookeeper> tad_, great. remember to terminate entries with periods, and it's usually good to use scenario names instead of numbers, because numbers aren't actually player-visible anywhere in-game IIRC.
20160916 22:30:45< tad_> zookeeper: will update.
20160916 22:30:50< celmin> "all scenarios"
20160916 22:31:20< celmin> I don't remember the more logical thieves thing.
20160916 22:31:38< tad_> zookeeper: Or may I won't. All the other entries are scene numbers. :O
20160916 22:31:50< tad_> celmin: Not in, yet.
20160916 22:31:56< tad_> PR is up for it.
20160916 22:32:07< celmin> Oh, then I can easily remind myself.
20160916 22:32:17< tad_> And it's a lot of code movement so zookeeper may kick it or demand a rewrite
20160916 22:33:33< celmin> Seeing it reminds me that someone wanted [delay] to be adjusted according to your accelerated speed setting.
20160916 22:35:14< celmin> I should probably rebase spirit_po while the build is passing… but I need to stash my XCode repo for that, so might not yet.
20160916 22:38:07< tad_> 783 updated for current feedback.
20160916 22:39:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160916 22:43:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160916 22:52:09-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160916 22:52:12< celmin> So it couldn't open the image.
20160916 22:52:28< celmin> Did I mispell it...
20160916 22:53:36< celmin> Wrong file extension. 9_9
20160916 23:01:35< celmin> Hmmm, still not working...
20160916 23:02:44< celmin> I probably forgot something fundamental. Like actually calling the new function. >_>
20160916 23:03:57< tad_> Or leave it and in ten years someone can find it and wonder what the dead code was for.
20160916 23:04:08< celmin> Hehe.
20160916 23:04:13< celmin> But no.
20160916 23:04:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20160916 23:07:37< tad_> Poor zookeeper .. he's working down the HttT PRs and just got to the thieves refactoring. Even if you ignore whitespace changes, it's a mess.
20160916 23:14:11< celmin> Well! That looks interesting, but not even slightly what I was going for!
20160916 23:19:39-!- Greg-Bog_ [~greg_bogg@2601:1c2:901:e170:49b5:8176:2c41:79a] has quit [Remote host closed the connection]
20160916 23:23:25< celmin> I think I need a better test image...
20160916 23:27:27-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:49b5:8176:2c41:79a] has joined #wesnoth-dev
20160916 23:30:55< celmin> Hmmm… it actually looks like it works, basically. Though apparently I swapped the x and y coordinates. (Was half-expecting that, mind you.)
20160916 23:32:25-!- Greg-Boggs [~greg_bogg@2601:1c2:901:e170:49b5:8176:2c41:79a] has quit [Ping timeout: 255 seconds]
20160916 23:37:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 240 seconds]
20160916 23:42:31< celmin> It can get pretty slow though. :/
20160916 23:42:35< celmin> Depending on the formula.
20160916 23:48:38< celmin> sin(xy) + cos(xy) makes Dead Water's campaign image look really weird.
20160916 23:50:32-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160916 23:52:07< celmin> (x^2 + y^2) % 250 looks pretty cool (though still weird when applied to Dead Water's campaign image).
20160916 23:52:29< celmin> It gives a sort of raindrops-in-the-water ripple pattern.
20160916 23:52:45< celmin> Anyway, that's enough experimenting.
20160916 23:56:56< irker112> wesnoth: Celtic Minstrel wesnoth:master 946be0c02ca0 / / (5 files in 3 dirs): ~ADJUST_ALPHA() now takes formula https://github.com/wesnoth/wesnoth/commit/946be0c02ca09de4f0dabac0f2697dc42ae2f1a9
20160916 23:57:04-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160916 23:57:07-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has joined #wesnoth-dev
20160916 23:57:08< travis-ci> wesnoth/wesnoth#11013 (enable-gui2-lobby-in-gui2-lobby-test - 1590332 : Jyrki Vesterinen): The build failed.
20160916 23:57:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/160565804
20160916 23:57:08-!- travis-ci [~travis-ci@ec2-54-227-70-42.compute-1.amazonaws.com] has left #wesnoth-dev []
20160916 23:57:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160916 23:59:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
--- Log closed Sat Sep 17 00:00:41 2016