--- Log opened Wed Sep 21 00:00:06 2016
20160921 00:01:12-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160921 00:01:15-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has joined #wesnoth-dev
20160921 00:06:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160921 00:07:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160921 00:43:33< ancestral> Regarding zoom levels: https://gna.org/bugs/?24469
20160921 00:44:05< celmin> ancestral: I thought we addressed that ages ago? Unless we only talked about it and then did nothing.
20160921 00:44:23< ancestral> We only talked about it and then did nothing.
20160921 00:44:32< celmin> Oh wow.
20160921 00:44:37< celmin> Okay then.
20160921 00:44:51< celmin> I guess that's also what happened to pydsigner's 616 too. :/
20160921 00:44:51< ancestral> I looked to see how easy it would be to alter the code and I couldn’t think of a quick 2-minute fix
20160921 00:45:20< ancestral> celmin: Unless someone introduced this in the last 4 months and I wasn’t aware
20160921 00:45:36< celmin> Yeah, not to my knowledge (and I generally look at new commits that come in).
20160921 00:45:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 00:49:39-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: End Transmission.]
20160921 00:50:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160921 01:01:23< wedge009> celmin: Waiting on someone to agree to merge it (496), I suppose. Happy to update it if/when it's accepted.
20160921 01:02:47< celmin> wedge009: I don't see any reasons not to accept it, but should probably check with vultraz and gfgtdf as well.
20160921 01:03:18< celmin> But the changelog commit would definitely need replacing if it's to be merged.
20160921 01:04:11< celmin> Wait, has that been open since 1.13.1? o.o
20160921 01:04:34< wedge009> Yes.
20160921 01:04:58< celmin> I suppose the crash is still an issue?
20160921 01:05:54< wedge009> Should be. Going to check.
20160921 01:20:22< wedge009> Yes, still crashes.
20160921 01:22:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160921 01:22:59-!- gfgtdf_ [~chatzilla@x4e369e89.dyn.telefonica.de] has joined #wesnoth-dev
20160921 01:24:46-!- gfgtdf [~chatzilla@x50ab6c61.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160921 01:24:52-!- gfgtdf_ is now known as gfgtdf
20160921 01:30:10< wedge009> celmin: Updated the PR, for whenever others have time to (re-)review it.
20160921 02:10:27-!- irker644 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160921 02:12:10-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has joined #wesnoth-dev
20160921 02:29:45-!- gfgtdf [~chatzilla@x4e369e89.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]]
20160921 03:25:31-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160921 03:40:03-!- JyrkiVesterinen [~JyrkiVest@87-100-131-48.bb.dnainternet.fi] has joined #wesnoth-dev
20160921 03:53:19-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has quit [Quit: Page closed]
20160921 04:02:48-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160921 04:04:31-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160921 04:04:46-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20160921 04:05:28-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160921 04:20:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160921 04:20:43-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160921 04:35:19-!- JyrkiVesterinen [~JyrkiVest@87-100-131-48.bb.dnainternet.fi] has quit [Quit: .]
20160921 04:36:15-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 276 seconds]
20160921 04:47:03-!- enchi [~aeonchild@defocus/yummy/enchilado] has joined #wesnoth-dev
20160921 04:55:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 04:59:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160921 05:08:00-!- Kwandulin [~Miranda@p200300760F2C71F139F96F526B1CD220.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160921 05:12:25-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160921 05:20:27< vultraz> celticminstrel: any more thoughts on the map thing in trgroup?
20160921 05:21:20< celticminstrel> You could use std::list plus std::(unordered_)map to get map-like lookup but also predictable iteration order.
20160921 05:21:34< celticminstrel> It'd be a bit of work, though, and an iterator adaptor would be needed.
20160921 05:22:10< celticminstrel> You could try to figure out how to use Boost.MultiIndex to do what you want.
20160921 05:22:32< vultraz> that seems like overkill for a list with usually 2 or 3 members
20160921 05:22:36< celticminstrel> Agreed.
20160921 05:23:26< celticminstrel> The two-container approach is list<tselectable_*> and (unordered_)nap<string, list<tselectable_*>::iterator>
20160921 05:23:48< celticminstrel> So lookup becomes *m[key] instead of just m[key].
20160921 05:24:02< celticminstrel> And iteration, I'm not quite sure. Haven't thought on it in detail.
20160921 05:24:54< celticminstrel> You could keep a vector<string> to remember the order.
20160921 05:25:15< vultraz> I considered that
20160921 05:26:27< vultraz> btw, is there a difference between VGETTEXT and vgettext
20160921 05:26:36< celticminstrel> Probably.
20160921 05:26:54< celticminstrel> It does look like Boost.MultiIndex is actually fairly easy to use for this, but it still seems like overkill.
20160921 05:27:48< vultraz> oh, hm
20160921 05:27:52< celticminstrel> However, the way to mutate the container is a bit weird in Boost.MultiIndex, from what I understand (didn't investigate in great detail).
20160921 05:28:01< vultraz> looks like one is supposed to use vgettext not VGETTEXT
20160921 05:28:05< Aginor> do it right the first way around ;)
20160921 05:28:15< celticminstrel> But it means you can't do m[key] = val;
20160921 05:28:26< vultraz> :/
20160921 05:40:50< celticminstrel> The list+map or vector+map might be the simplest solution.
20160921 05:45:54-!- irker793 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160921 05:45:54< irker793> wesnoth: Charles Dang wesnoth:master db0cb4535296 / src/gui/widgets/chatbox.cpp: Chatbox: big code cleanup https://github.com/wesnoth/wesnoth/commit/db0cb453529679c7c9d731c92e23f749d3f87576
20160921 05:45:57< irker793> wesnoth: Charles Dang wesnoth:master 82cd550cff29 / src/gui/widgets/chatbox.cpp: Chatbox: fixed command messages not working https://github.com/wesnoth/wesnoth/commit/82cd550cff2933741cc1e3ae2cebb058a16640d6
20160921 05:47:34< vultraz> see, I put bugfixes in separate commits 
20160921 05:47:52< celticminstrel> Yay?
20160921 05:51:11< vultraz> also made use of vgettext instead of VGETTEXT
20160921 06:03:19< vultraz> celticminstrel: perhaps you could explain this config::diff_track_attribute thing
20160921 06:05:36< celticminstrel> Maybe tomorrow.
20160921 06:05:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160921 06:44:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 06:48:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20160921 06:53:16-!- Jetrel_ [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20160921 06:53:19-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Connection reset by peer]
20160921 06:55:15-!- Kwandulin [~Miranda@p200300760F2C71F139F96F526B1CD220.dip0.t-ipconnect.de] has quit [Ping timeout: 250 seconds]
20160921 06:59:00-!- Kwandulin [~Miranda@p200300760F2C710339F96F526B1CD220.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160921 07:00:54-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160921 07:31:07-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160921 07:38:35-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160921 07:42:36< zookeeper> oh wow, the portrait requirements sticky is... rather outdated: https://forums.wesnoth.org/viewtopic.php?f=9&t=24555
20160921 07:43:10 * zookeeper edits
20160921 07:56:05-!- Kwandulin [~Miranda@p200300760F2C710339F96F526B1CD220.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160921 08:15:40< vultraz> hmm
20160921 08:15:48< vultraz> ok, so my dialog displays all users on the server 
20160921 08:16:12-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has joined #wesnoth-dev
20160921 08:16:25< vultraz> and the game doesn't show up in the lobby
20160921 08:25:00-!- Kwandulin [~Miranda@p200300760F2C7103491C8132371DDB27.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160921 08:32:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 08:33:28-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160921 08:36:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 255 seconds]
20160921 09:00:40-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20160921 09:06:37-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has quit [Ping timeout: 255 seconds]
20160921 09:07:10-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has joined #wesnoth-dev
20160921 09:29:05-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has quit [Ping timeout: 250 seconds]
20160921 09:29:55-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has joined #wesnoth-dev
20160921 09:37:45-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has quit [Ping timeout: 248 seconds]
20160921 09:37:56-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has joined #wesnoth-dev
20160921 09:59:22-!- Appleman1234_ [~Appleman1@KD119104058103.au-net.ne.jp] has joined #wesnoth-dev
20160921 10:00:24-!- Appleman1234 [~Appleman1@KD119104054143.au-net.ne.jp] has quit [Ping timeout: 244 seconds]
20160921 10:09:19-!- Appleman1234_ is now known as Appleman1234
20160921 10:10:15-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has quit [Ping timeout: 250 seconds]
20160921 10:20:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 10:25:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160921 10:31:16-!- Bonobo [~Bonobo@ppp118-210-144-92.lns20.adl6.internode.on.net] has joined #wesnoth-dev
20160921 10:42:57-!- Bonobo [~Bonobo@ppp118-210-144-92.lns20.adl6.internode.on.net] has quit [Ping timeout: 272 seconds]
20160921 10:43:06-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has joined #wesnoth-dev
20160921 10:52:13-!- Kwandulin [~Miranda@p200300760F2C7103491C8132371DDB27.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160921 10:53:10-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160921 10:55:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160921 10:55:21-!- wedge010 is now known as wedge009
20160921 11:03:11-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160921 11:07:50< matthiaskrgr> https://github.com/wesnoth/wesnoth/blob/master/src/video.cpp#L151      
20160921 11:08:01< matthiaskrgr> will this ever be 'true' ? 
20160921 11:08:23< matthiaskrgr> fb = nullptr ;    if (fb != nullptr){} ... 
20160921 11:08:24< vultraz> No idea
20160921 11:08:36< vultraz> oh that
20160921 11:08:38< vultraz> uh
20160921 11:08:47< vultraz> ... yeah, doesn't look like it 
20160921 11:09:08-!- irker793 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160921 11:09:20< matthiaskrgr> it looks a bit weird
20160921 11:11:09< vultraz> ill ask Aginor about it
20160921 11:11:20< vultraz> btw, any chance you could run memory tests on one of the PRs
20160921 11:12:07< matthiaskrgr> which one?
20160921 11:12:56< matthiaskrgr> well, there is a lot of noise from stuff I already found but if there is a crash I should notice it :P
20160921 11:13:16< vultraz> this one: https://github.com/wesnoth/wesnoth/pull/776 except excluding the last 2 commits, since i need to revert those two
20160921 11:14:07< matthiaskrgr> ah it's a branch, ok 
20160921 11:15:11< matthiaskrgr> so 646ee1dc68a6b9f439f424160db1832143441a8f, right ? 
20160921 11:15:44< vultraz> yeah, and the three before that, though that is the main one that might be concerning.
20160921 11:16:07< matthiaskrgr> no I mean I will git-check that one out :) 
20160921 11:16:11< matthiaskrgr> ok
20160921 11:16:15< vultraz> ah. yeah
20160921 11:16:35< vultraz> id do it myself but i dont have valgrind or any experience dealing with memory issues.
20160921 11:17:00< matthiaskrgr> I'll have a look. it's gonna be compiled in around an hour-30 minutes 
20160921 11:17:07< matthiaskrgr> ( 30-60 minutes)
20160921 11:17:44< matthiaskrgr> what does this touch? 
20160921 11:17:51< matthiaskrgr> graphic/rendering stuff? 
20160921 11:18:28< vultraz> yes
20160921 11:18:32< matthiaskrgr> alright
20160921 11:18:49< vultraz> specifically the implementation of the SDL_Surface wrapper class
20160921 11:19:20< matthiaskrgr> I guess I'll click around a bunch of gui elements and play a bit to see if something crashes
20160921 11:19:55-!- gfgtdf [~chatzilla@x4e369e89.dyn.telefonica.de] has joined #wesnoth-dev
20160921 11:22:11-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160921 11:25:03-!- Kwandulin [~Miranda@p200300760F2C7103FD4830F8FDFE88E6.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160921 11:43:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160921 11:45:46-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160921 11:51:32-!- gfgtdf [~chatzilla@x4e369e89.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]]
20160921 11:52:59< vultraz> why does the game only appear briefly if i leave the game :/
20160921 11:55:21< vultraz> likely something in run_lobby_loop..
20160921 12:08:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 12:12:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160921 12:13:34< matthiaskrgr> vultraz: in your PR; sometimes units are invisible 
20160921 12:21:31< matthiaskrgr> but no crashes so far :) 
20160921 12:22:09-!- gfgtdf [~chatzilla@x4e369e89.dyn.telefonica.de] has joined #wesnoth-dev
20160921 12:54:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160921 12:56:42-!- Kwandulin [~Miranda@p200300760F2C7103FD4830F8FDFE88E6.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160921 13:02:25-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160921 13:10:34-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160921 13:15:53-!- midzer [~quassel@p57B45688.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160921 13:30:34< mattsc> zookeeper: There wasn’t anything I told you I’d do that I have not delivered yet, was there?
20160921 13:30:46< zookeeper> not that i recall
20160921 13:31:13< bumbadadabum> Is anyone against me merging my ToD changes?
20160921 13:31:18< mattsc> I’m traveling next week and might not be available if 1.13.6 is really going to be release then, so I am going through my check list.
20160921 13:33:28< mattsc> zookeeper: there’s currently that sentence in the release notes that HttT:S8 is using the new MAI.  If you don’t get around to doing that, could you delete that?  (Again, just in case I am not around when this happens.)
20160921 13:35:59< zookeeper> yeah, but i'll get to that probably this week
20160921 13:36:15< mattsc> zookeeper: great, thanks
20160921 13:39:07-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160921 13:42:16-!- irker630 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160921 13:42:16< irker630> wesnoth: Matthias Krüger wesnoth:master 9675440c7135 / src/reports.cpp: reports: remove unused variable "str" https://github.com/wesnoth/wesnoth/commit/9675440c71356c7da5488cad351cedd56fb42c17
20160921 13:42:16< irker630> wesnoth: Charles Dang wesnoth:master e54d8fe83279 / src/reports.cpp: Merge pull request #794 from matthiaskrgr/unused_var https://github.com/wesnoth/wesnoth/commit/e54d8fe832796bc16da550014ec6aa1ec32b4ed2
20160921 13:47:36< mattsc> vultraz: Hi; you haven’t committed anything about the save_index/create_engine issue yet, right?  Or have I missed it?
20160921 13:48:08< vultraz> mattsc: i have not yet, but I wondered if you could test something real quick...
20160921 13:48:29< mattsc> vultraz: if it’s really quick, then yes
20160921 13:49:34< vultraz> could you see if the problem persists if you move singleplayer.cpp:46-56 outside the do {} loop? 
20160921 13:51:20< mattsc> vultraz: will do in a few minutes; but just as a comment, I have in the meantime also found that I have the problem when I try to go to the MP setup screen
20160921 13:51:36< mattsc> would that be affect by something in singleplayer.cpp
20160921 13:51:39< vultraz> mp create, gui2?
20160921 13:52:21< mattsc> Local game, as soon as I click on the MP button in the main menu
20160921 13:52:40< mattsc> It then hangs there for 3 minutes or so, same as when I click the campaigns button
20160921 13:52:59-!- enchi [~aeonchild@defocus/yummy/enchilado] has quit [Ping timeout: 250 seconds]
20160921 13:53:00< vultraz> is this with the gu2 or gui1 versions
20160921 13:53:09< vultraz> well, doesn't matter i guess :/
20160921 13:53:14< vultraz> very troubling
20160921 13:55:05< mattsc> vultraz: I haven’t been paying attention, how do I toggle between gui1 and 2?
20160921 13:55:23< vultraz> Preferences -> Advances -> Experimental MP Lobby 
20160921 13:55:35< vultraz> we're using that switch for the entirety of the new gui2 mp workflow
20160921 13:57:21< mattsc> Ah, there it is.  I looked right at it and didn’t see it.  :P
20160921 13:58:27< mattsc> Let me just test it with both gui1 and gui2; I need to move my saves back into the user dir first though.
20160921 14:00:15< mattsc> vultraz: happens with both gui1 and gui2.
20160921 14:00:23< mattsc> Do you still want me to do that test?
20160921 14:01:00< mattsc> Btw, it happens after I press the ‘local game’ button, of course, not directly after the MP button.
20160921 14:01:30< mattsc> vultraz: how many saved games do you have in your saves folder?
20160921 14:01:55< mattsc> roughyl
20160921 14:02:01< mattsc> *roughly
20160921 14:04:07< mattsc> vultraz: just did the test; the problem persists
20160921 14:04:35-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160921 14:07:09< vultraz> ok
20160921 14:07:11< vultraz> thanks
20160921 14:07:33< mattsc> vultraz: how many saves do you currently have in your folder?
20160921 14:08:09< vultraz> 174, apparently o_O
20160921 14:08:12< mattsc> I’m asking because the problem for me only manifests itself when there are several hundreds of saves, and it is very much not linear.
20160921 14:08:22< mattsc> Yeah, 174 is not really a problem for me either.
20160921 14:08:38< mattsc> At around 400 it starts to get bad, and at 800 it’s entirely unusable.
20160921 14:09:02< mattsc> vultraz: could you copy in another 500 or so from somewhere, delete your save_index file, and see if it happens for you too?
20160921 14:09:35< vultraz> eh, I'm pretty sure I know why it happens
20160921 14:09:36< mattsc> Because I won’t have much time over the next couple weeks, so I might not be able to do the testing for you on short timescales.
20160921 14:09:56< mattsc> vultraz: okay
20160921 14:10:25< mattsc> As long as it gets fixed for 1.13.6, I’m happy  (since I have a local work-around if needed)
20160921 14:10:28< vultraz> the connect_engine object constructed for both sp and mp iterates over get_save_list
20160921 14:10:59< vultraz> and pushes back a connect_engine-subclass member using the save.summary() field
20160921 14:11:11< vultraz> summary() calls save_index_class::get()
20160921 14:12:13< vultraz> which in turn calls rebuild() if it's not available, which in turn calls write_save_index()]
20160921 14:12:56< vultraz> im sure the problem is somewhere there
20160921 14:13:09< vultraz> the quick fix is to revert my commit that introduced the savegame handling to connect_engine
20160921 14:14:29< mattsc> vultraz: okay; I’ll trust that you can figure it out.  :)
20160921 14:14:41< vultraz> it will be fixed for 1.13.6, don't worry
20160921 14:14:51< mattsc> Ill be available for testing, if you need me, but probably not always on short notice.
20160921 14:15:20< mattsc> vultraz: Cool.  And I’m not worried.  :)
20160921 14:27:52-!- Kwandulin [~Miranda@p200300760F2C7103F8CD40376B462EDE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160921 14:28:03-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160921 14:30:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20160921 14:37:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160921 14:39:00< matthiaskrgr> hm
20160921 14:39:28< matthiaskrgr> according to the wiki, the key for the cmdline is ":", but in my key settings it is "ö" even after resetting to defaults? o_O 
20160921 14:41:11< vultraz> it's no longer : in 1.13
20160921 14:42:10< vultraz> it's ; for me, but i believe it varies by system since it uses scancodes(?)
20160921 14:42:33< matthiaskrgr> mh
20160921 14:43:35< matthiaskrgr> is there some way to dereference keybinds in a cfg ? 
20160921 14:43:55< matthiaskrgr> (make the help always show the correct bind even if user changed it) 
20160921 14:44:49< vultraz> don't really know wht you mean
20160921 14:45:26< matthiaskrgr> instead of
20160921 14:45:27< matthiaskrgr> via the command line by prefixing them with ':' (as shown here) or via the chat  
20160921 14:45:30< matthiaskrgr> something like
20160921 14:45:47< matthiaskrgr> via the command line by prefixing them with 'getkeybind("cmdline")' (as shown here) or via the chat  
20160921 14:46:24< matthiaskrgr> or gethotkey() 
20160921 14:46:33< vultraz> no, there isn't
20160921 14:46:37< matthiaskrgr> :( mmh 
20160921 14:46:38< vultraz> that i know of
20160921 14:48:18< vultraz> thanks for memchecking the pr, btw.
20160921 14:48:31< vultraz> the invisible units are troubling :/
20160921 14:49:13< vultraz> any specific way to repro?
20160921 14:49:31< matthiaskrgr> I just played the tutorial a bit 
20160921 14:49:49< matthiaskrgr> it also appeared that some frames of animations were sometimes missing
20160921 14:49:52< matthiaskrgr> or phases
20160921 14:50:48< matthiaskrgr> is there some way to make scrolling smooth btw? 
20160921 14:50:56< matthiaskrgr> the fps cound says 50 but it feels like 15 
20160921 14:51:07< vultraz> where you playing with konrad or lisar?
20160921 14:51:14< matthiaskrgr> konrad
20160921 14:51:24< vultraz> hm
20160921 14:51:26< vultraz> ok
20160921 14:51:31< vultraz> and no, we can't fix the scrolling yet
20160921 14:51:48< vultraz> we still use software rendering and a shitty custom blitting implementation 
20160921 14:52:07< vultraz> until the custom blitting is refactored, we cannot use hardware acceleration 
20160921 14:52:46-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160921 14:53:07< vultraz> it's a huge effort :(
20160921 14:53:20< matthiaskrgr> ok 
20160921 14:53:40< vultraz> but an initial prereq is doing what I've been doing the past few months: transitioning the UI to the 'new' toolkit
20160921 14:53:51< vultraz> (I use quotes since the project was started in 2008 :| )
20160921 14:54:27< matthiaskrgr> :D
20160921 14:54:46< vultraz> but it's *finally* near completion... close but yet so far... 
20160921 14:55:03< vultraz> since the main gamescreen still requires conversion
20160921 14:55:14< vultraz> as well as a few other screens
20160921 14:56:25< vultraz> working on this one now https://drive.google.com/file/d/0B-mR9s8FduLLaDlMNWk0Wm1CcHM/view?usp=sharing
20160921 14:58:19< matthiaskrgr> ah, I reported a buffer overflow for that screen :P
20160921 14:59:05< vultraz> speaking of which..
20160921 14:59:40< vultraz> gfgtdf: i can't seem to get the game to show up in the lobby with the new dialog. it appears for a moment if you cancel the game but not before... not sure what imd oing wrong
20160921 15:15:16-!- Nobun [~nobun@5.170.105.235] has joined #wesnoth-dev
20160921 15:15:41-!- midzer [~quassel@p57B45688.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160921 15:27:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 255 seconds]
20160921 15:28:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160921 15:34:50-!- Kwandulin [~Miranda@p200300760F2C7103F8CD40376B462EDE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160921 15:53:17-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has joined #wesnoth-dev
20160921 15:53:17-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has quit [Changing host]
20160921 15:53:17-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20160921 15:53:34< mordante> servus
20160921 15:53:41-!- JyrkiVesterinen [~JyrkiVest@87-100-193-107.bb.dnainternet.fi] has joined #wesnoth-dev
20160921 16:00:39< vultraz> hello
20160921 16:01:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160921 16:03:45-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has quit [Remote host closed the connection]
20160921 16:06:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 16:07:17-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160921 16:08:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160921 16:08:48-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Client Quit]
20160921 16:08:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 16:19:58< matthiaskrgr> sometimes when moving a horeseman, he some frames are displayed on previous hexes while moving forward
20160921 16:20:06< matthiaskrgr> is there a ticket about that?
20160921 16:21:23< vultraz> yes
20160921 16:21:54< matthiaskrgr> ok
20160921 16:22:00< vultraz> likely the framebuffer doesn't swap fast enough for the movement speed or the old hex overlay doesnt't get cleared
20160921 16:22:04< vultraz> doesn't
20160921 16:34:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160921 16:38:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 16:43:03-!- irker630 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160921 16:55:06-!- mjs-de [~mjs-de@x4db55cfa.dyn.telefonica.de] has joined #wesnoth-dev
20160921 16:57:46-!- Nobun [~nobun@5.170.105.235] has quit [Ping timeout: 255 seconds]
20160921 17:03:00-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160921 17:03:00-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20160921 17:09:08-!- Bonobo [~Bonobo@2001:44b8:254:3200:4dbb:3b6b:1065:9aae] has quit [Quit: Leaving]
20160921 17:12:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160921 17:15:46-!- Nobun [~nobun@5.170.110.246] has joined #wesnoth-dev
20160921 17:37:00-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20160921 17:44:10-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160921 17:46:09-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.2 Aria]
20160921 17:51:45-!- Nobun [~nobun@5.170.110.246] has quit [Quit: Salve a tutti]
20160921 17:59:44< mattsc> celticminstrel: Is there a way to check whether a unit is visible to the current side in Lua.
20160921 17:59:45< mattsc> Other than using get_units() together with [filter_vision], I mean.
20160921 18:00:02< celticminstrel> Not sure.
20160921 18:00:21< celticminstrel> (If you already have the unit I'd suggest match_unit rather than get_units.)
20160921 18:00:44< mattsc> I’m asking because I suddenly noticed that the high XP CA does not check for invisibility.  Whoops.
20160921 18:00:59< mattsc> And of course, in that CA I am doing everything I can to avoid using filters, for speed reasons.
20160921 18:01:04< celticminstrel> I don't know of any way besides the unit filters.
20160921 18:01:25< celticminstrel> And using match_unit probably won't be that slow, since the main speed penalty in get_units would be that it has to walk the entire map.
20160921 18:01:38< celticminstrel> I could be wrong though.
20160921 18:01:40< mattsc> Yeah, me neither.  I’ll just have to make sure that it only gets called once then.
20160921 18:01:42< mattsc> okay.
20160921 18:02:11< celticminstrel> I'm guessing you already checked the wiki.
20160921 18:02:28< mattsc> yes, I did
20160921 18:02:59< mattsc> But it does happen that I miss things.
20160921 18:03:13< mattsc> Asking for similar reasons, do you think you’ll get the updated ai.get_attacks() in time for me to use with that CA before 1.13.6?
20160921 18:03:32< celticminstrel> Good question!
20160921 18:03:44< mattsc> I’m willing to push that one of into 1.13.7 if it’s a stretch.
20160921 18:04:06< mattsc> The invisible units thing needs to be fixed though.  But that’s also easy.
20160921 18:04:11< celticminstrel> It probably won't take that long if I just work on it. I'm not sure how soon 1.13.6 is going to be, but I assume very soon (unless he decides to push it to October).
20160921 18:04:23 * celticminstrel is working on a personal project at the moment.
20160921 18:05:04< mattsc> Yeah.  And in any case, I’ll be mostly unavailable for a couple weeks starting this weekend.
20160921 18:05:18< mattsc> Good to hear!
20160921 18:05:45< mattsc> That’s all for now.  Back to RL work…
20160921 18:06:50< gfgtdf> mattsc: if you thihk it makes a differenc ein speed you cna easily add a metodd to chek visiblity
20160921 18:07:00< gfgtdf> s/ein/in
20160921 18:07:51< mattsc> gfgtdf: I’m sure that’s true, but I likely won’t have time to do this week or next.
20160921 18:08:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160921 18:08:34< mattsc> I don’t think it’s a big issue for this AI.
20160921 18:09:30< gfgtdf> celticminstrel: if we add a unit:is_visible_to_team actions woudl it be better to takes a number or a lua side proxy as parameter?
20160921 18:10:39< celticminstrel> gfgtdf: If you add that, I think it should accept either. On the other hand, you could also consider instead adding team:can_see_unit.
20160921 18:10:57< gfgtdf> mordante: i marked http://gna.org/bugs/?25086 as fixed but the timer is still present
20160921 18:11:07< celticminstrel> Also, if you do add it to the unit metatable rather than the side metatable, I'd call it is_visible_to_side rather than is_visible_to_team.
20160921 18:11:21< mattsc> gfgtdf: I’m sure it’s not all that much work, but I’d have to figure out how to do it first because I have not done it before, that’s why I said I might not have time.  :)
20160921 18:12:27< mordante> gfgtdf, ok, which commit fixed it?
20160921 18:12:32< mattsc> gfgtdf: I’d vote for being able to pass it wesnoth.current.side, so that means number (or both, as celticminstrel said)
20160921 18:12:44< gfgtdf> the timer issue*
20160921 18:13:13< celticminstrel> I'll just say that anything operating on sides should accept either a number or a proxy.
20160921 18:13:15< gfgtdf> mordante: this https://github.com/wesnoth/wesnoth/commit/4d0fbc1d4e5246066e5f4fbb02a011a1f91ca8a2 fixed some of the ub notied in the report bit not all
20160921 18:13:38< mattsc> I really need to be off right now though, sorry.  Will read the logs later.  Ciao.
20160921 18:13:39-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20160921 18:14:04< celticminstrel> So you don't need to worry about which ones take a number and which ones take a proxy.
20160921 18:14:51< gfgtdf> vultraz: what teh current state of the gui2 mp connect?
20160921 18:15:30-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160921 18:16:08< vultraz> [01:59:36]	vultraz	gfgtdf: i can't seem to get the game to show up in the lobby with the new dialog. it appears for a moment if you cancel the game but not before... not sure what imd oing wrong
20160921 18:16:22< vultraz> gfgtdf: it basically needs to work correctly with the network now
20160921 18:16:25< vultraz> ie, appear in the lobby
20160921 18:16:29< vultraz> and reflect changes
20160921 18:16:37< vultraz> and need to be wired into mp wait too, actually
20160921 18:16:40< vultraz> but that's easy
20160921 18:18:49-!- irker298 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160921 18:18:50< irker298> wesnoth: Charles Dang wesnoth:master c1ca0e360e71 / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: some basic userlist handling https://github.com/wesnoth/wesnoth/commit/c1ca0e360e71e7f8b0fa251fbbfeae7e50d13b1d
20160921 18:19:08< gfgtdf> vultraz: what i don't liek is that the mp wait network code basically only handles on config diffs, 
20160921 18:19:39< vultraz> hm
20160921 18:19:44< gfgtdf> vultraz: so whena  new player joins the host gets  ['joins'] name=, side= ..., while the ml wait just get a wml diff
20160921 18:19:54< gfgtdf> while the other clients*
20160921 18:20:00< vultraz> hm
20160921 18:20:12< vultraz> idk really how to handle that i was hoping you coukd help
20160921 18:20:18< vultraz> maybe come up with a better system
20160921 18:20:24< vultraz> we don't have to preserve the gui1 stuff
20160921 18:20:33< gfgtdf> hmm ok
20160921 18:21:08< vultraz> i designed the dialog so it can be used for both hosts and players
20160921 18:21:24< vultraz> probably needs a few things disabled for players maybe but generally the layout will be the same
20160921 18:21:35< vultraz> we can do that last
20160921 18:22:03< vultraz> so it just needs to handle setting changes it gets from different clients
20160921 18:22:10< vultraz> and also reflect user joins/leaves
20160921 18:22:20< vultraz> ill set up the status label later
20160921 18:22:22< mordante> gfgtdf, ok, still need to fix some other issues, which seem to break wesnoth over here
20160921 18:24:28< vultraz> gfgtdf: holestly the whole network handling in the old mp code seems very messsy
20160921 18:25:00< vultraz> gfgtdf: i think that's why someone (idt it was mordante) wrote all the stuff in gui/dialogs/lobby/info.*pp and data.*pp
20160921 18:25:25< vultraz> it's slightly lobby-specialized but it seems it was ultimately intended to be abeter version of the gui1 code
20160921 18:25:34< vultraz> handling the gamelist and diffs and all that
20160921 18:25:58< gfgtdf> vultraz: i wonder why lobby has a seperate folder (istead of multiplayer)
20160921 18:26:08< vultraz> gfgtdf: idk i plan to move it
20160921 18:26:47< gfgtdf> vultraz: i also think we might be aale to remove the twesnothd_connection &wesnothd_connection parmaeter form lobby if the lobby_info already contains it
20160921 18:27:24< vultraz> gfgtdf: I removed the twesnothd_connection member from lobby_info
20160921 18:27:42< vultraz> gfgtdf: i figured that class should handle data parsing only
20160921 18:27:49< vultraz> and the dialogs should handle network calls
20160921 18:29:31< gfgtdf> hmo k
20160921 18:30:21< gfgtdf> mordante: does the timer code onyl work from inside gui2 dialogs or can it also be used while no gui2 dialog s showing ?
20160921 18:30:44< vultraz> gfgtdf: it extends sdl's timer code so i think it should work anywhere
20160921 18:34:37< mordante> gfgtdf, I don't exactly recall, but I'm quite sure it was not bound to GUI2
20160921 18:36:19-!- gfgtdf [~chatzilla@x4e369e89.dyn.telefonica.de] has quit [Ping timeout: 255 seconds]
20160921 18:36:20-!- gfgtdf_ [~chatzilla@x4e369e89.dyn.telefonica.de] has joined #wesnoth-dev
20160921 18:36:21-!- gfgtdf_ is now known as gfgtdf
20160921 18:42:31-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20160921 18:57:06-!- travis-ci [~travis-ci@ec2-54-158-60-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20160921 18:57:07< travis-ci> wesnoth/wesnoth#11129 (master - c1ca0e3 : Charles Dang): The build has errored.
20160921 18:57:08< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/161709023
20160921 18:57:08-!- travis-ci [~travis-ci@ec2-54-158-60-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20160921 19:01:30-!- travis-ci [~travis-ci@ec2-54-158-60-68.compute-1.amazonaws.com] has joined #wesnoth-dev
20160921 19:01:31< travis-ci> gfgtdf/wesnoth-old#697 (master - c1ca0e3 : Charles Dang): The build passed.
20160921 19:01:31< travis-ci> Build details : https://travis-ci.org/gfgtdf/wesnoth-old/builds/161710259
20160921 19:01:31-!- travis-ci [~travis-ci@ec2-54-158-60-68.compute-1.amazonaws.com] has left #wesnoth-dev []
20160921 19:06:59-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160921 19:07:54-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 265 seconds]
20160921 19:08:18-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160921 19:09:51< matthiaskrgr> uhm
20160921 19:10:10< matthiaskrgr> wesnoth: /usr/include/boost/dynamic_bitset/dynamic_bitset.hpp:633: boost::dynamic_bitset<Block, Allocator>::~dynamic_bitset() [with Block = long unsigned int; Allocator = std::allocator<long unsigned int>]: Assertion `m_check_invariants()' failed.
20160921 19:10:15< matthiaskrgr> is this new? 
20160921 19:10:27< celticminstrel> Probably, since it's a dynamic bitset.
20160921 19:10:32< celticminstrel> Stack trace?
20160921 19:10:41< celticminstrel> Wait, destructor?
20160921 19:10:44< celticminstrel> o.o
20160921 19:10:55< celticminstrel> Stack trace might still help though...
20160921 19:11:09< matthiaskrgr> Multi player -> local game -> show user maps -> boom 
20160921 19:11:20< celticminstrel> Okay...
20160921 19:11:31< matthiaskrgr> there is no asan backtrace
20160921 19:11:42< celticminstrel> My fault, so I'll take a look a bit later.
20160921 19:11:47< matthiaskrgr> 20160921 21:10:53 error config: map could not be loaded: Illegal tile in map: (Gg^Yl) 'Gg^Yl'
20160921 19:11:50< matthiaskrgr> wesnoth: /usr/include/boost/dynamic_bitset/dynamic_bitset.hpp:633: boost::dynamic_bitset<Block, Allocator>::~dynamic_bitset() [with Block = long unsigned int; Allocator = std::allocator<long unsigned int>]: Assertion `m_check_invariants()' failed.
20160921 19:11:54< matthiaskrgr> zsh: abort      ./build/wesnoth
20160921 19:11:55< celticminstrel> Unless someone else fixes it first.
20160921 19:11:56< matthiaskrgr> this is all I got, basically 
20160921 19:12:12< matthiaskrgr> hehe
20160921 19:12:13< celticminstrel> Well, you'd need to have a debugger attached to get a stack trace.
20160921 19:12:25< vultraz> cannot repro
20160921 19:12:26< celticminstrel> Since it's an assert.
20160921 19:12:53< celticminstrel> vultraz: Try hand-editing a map to add the illegal tile, in case that's related?
20160921 19:13:56< vultraz> it'd not be
20160921 19:14:08< celticminstrel> I wouldn't assume that.
20160921 19:14:45-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20160921 19:14:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160921 19:15:43< matthiaskrgr> I can't get a normal trace with gdb bc it's an asan build <.< 
20160921 19:19:38-!- mjs-de [~mjs-de@x4db55cfa.dyn.telefonica.de] has quit [Remote host closed the connection]
20160921 19:23:07< matthiaskrgr> ok, doing a regular debug build ... 
20160921 19:46:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160921 19:49:32< matthiaskrgr> hrm
20160921 19:50:40< matthiaskrgr> http://pastebin.com/k8JYerdU  
20160921 19:50:42< matthiaskrgr> quite underwhelming 
20160921 19:53:18< matthiaskrgr> ah
20160921 19:53:25< matthiaskrgr> it was probably because I had weird maps stored
20160921 19:54:56< matthiaskrgr> well, I deleted maps that I had saved and now it works 
20160921 19:55:03< matthiaskrgr> bleh
20160921 19:57:29-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 19:57:30-!- TC02 [~quassel@venus.arosser.com] has quit [Ping timeout: 264 seconds]
20160921 19:58:38-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160921 19:58:48-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 20:01:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20160921 20:02:41< matthiaskrgr> mmh
20160921 20:03:07< matthiaskrgr> vultraz: but I'm getting layout errors in the game lobby when trying to assign player lots to players
20160921 20:03:40< matthiaskrgr> http://pastebin.com/P8jhKTmh   
20160921 20:05:59-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20160921 20:11:07< matthiaskrgr> ok but I got another assert failure ...
20160921 20:11:16-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160921 20:13:16< matthiaskrgr> it's when I try to create a game with "dark forest" map 
20160921 20:16:13< matthiaskrgr> er, dark forecast
20160921 20:18:35< matthiaskrgr> mh I messed up the title, I can't change that, right? xD 
20160921 20:19:51< celticminstrel> I'll still take a look at see if I can reproduce that dynamic_bitset assert, eventually.
20160921 20:21:58< matthiaskrgr> I assume I had a corrupted map and it tried to load that or make apreview of it 
20160921 20:22:02< matthiaskrgr> which then failed 
20160921 20:25:27-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160921 20:26:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 20:37:04-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Quit: Page closed]
20160921 20:39:17-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has joined #wesnoth-dev
20160921 20:47:00< vultraz> matthiaskrgr: yeah, that's known..
20160921 20:47:08< vultraz> for some reason it doesn't show right on small resolutions
20160921 20:47:11< vultraz> just my luck :|
20160921 20:50:04-!- JyrkiVesterinen [~JyrkiVest@87-100-193-107.bb.dnainternet.fi] has quit [Quit: .]
20160921 20:50:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160921 20:51:29-!- Aginor [~andreas@unaffiliated/aginor] has quit [Quit: leaving]
20160921 20:54:27-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160921 21:02:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 21:05:50-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20160921 21:15:07< matthiaskrgr> hehehe
20160921 21:15:27< matthiaskrgr> I might have made wesnoth-optipng a bit better
20160921 21:16:51< zookeeper> maybe should switch to zopflipng instead?
20160921 21:17:04< matthiaskrgr> maybe should switch to FLIF instead :p
20160921 21:17:27< matthiaskrgr> well, so far I just wrapped a loop until the calls to the optimizers
20160921 21:17:38< matthiaskrgr> so after passing them one time, it will try another time 
20160921 21:17:55< zookeeper> it sounds fun
20160921 21:18:41< zookeeper> FLIF that is
20160921 21:18:47< matthiaskrgr> yes
20160921 21:18:55-!- irker298 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160921 21:18:55< matthiaskrgr> images might get another 20 % smaller :) 
20160921 21:20:44< tad_> zookeeper: I set fog=yes for side 1&3 create a unit for side 3 what did I forget to do so side1 fog lifts for the new side3 unit?
20160921 21:20:55< tad_> I have shared view=all
20160921 21:27:53-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160921 21:29:07-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 255 seconds]
20160921 21:39:55< zookeeper> tad_, well which side did you give it to?
20160921 21:40:03< zookeeper> should be on side 3 i believe
20160921 21:40:22< tad_> zookeeper: I got it.  [redraw]clear_shroud=yes was the missing piece
20160921 21:40:39< zookeeper> yeah... might have to do that
20160921 21:41:35< zookeeper> did the fog not get lifted even at the end of whichever event you spawned the side 3 unit in, or did you just need to have it happen mid-event?
20160921 21:41:47< tad_> zookeeper: Poor Ollin (THoT S08) I fixed the logic flaw making the scene logical, and tested. He appeared, said his lines, and immediately died when a Masked Dwarf was in his village and forced him toto the water.
20160921 21:41:58< tad_> zookeeper: Mid event
20160921 21:42:23< zookeeper> okay
20160921 21:43:28< tad_> The fog issue was I wanted him to be visible in the (fixed) village I forced him into since I added a sighted event to trigger him as well as on capture.
20160921 21:44:50< tad_> zookeeper: GL_THoT on my fork, last commit, if you're interested in the change before I do a PR ...
20160921 21:48:24< zookeeper> at least without looking at the map, i can't tell what the sighted even is about or why it's spawning ollin in a fixed location
20160921 21:48:42< zookeeper> or what prevents both events from getting fired eventually
20160921 21:48:55< tad_> Originally he appears only when side 1 captures.
20160921 21:49:42< tad_> But it's possible to run down the road and not capture, meet the enemy, and kill him. Which makes the entire end-conversation strange because your missed Ollin appearing and all that conversation
20160921 21:50:05< tad_> So I added sighted on any enemy and don't have a village x,y so had to choose one.
20160921 21:50:26< tad_> And it could be fogged and so lifted the fog
20160921 21:50:59< zookeeper> okay
20160921 21:52:04< tad_> Plays much nicer but testing it I hung back 2 turns so enemy advanced then triggered sighted and poor Ollin appears, and is killed straight away. But the scene makes sense!
20160921 21:58:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit []
20160921 22:03:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160921 22:11:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20160921 22:13:15< gfgtdf> vultraz: i tested the gui22 flg dialog and it crashes when i click on an item in the dropdown menu that was already clicked.
20160921 22:14:11< celticminstrel> gfgtdf: Is that specific to the flg dialog or does it occur in other dropdown menus, such as the prefs resolution selector?
20160921 22:18:05< gfgtdf> celticminstrel: happens in prefs aswell
20160921 22:20:17< gfgtdf> celticminstrel: also i think the gui1 addon manager beeing empty is casued by your dymaic_bistset commit, basically since thats the only nontrivial commit in the addon/ folder recently.
20160921 22:21:51< celticminstrel> gfgtdf: Could be that equality test, I suppose.
20160921 22:22:07< celticminstrel> Around line 490.
20160921 22:22:29< celticminstrel> f_.types == new_types
20160921 22:24:12< gfgtdf> celticminstrel: hmm no i think its in initial constructor call of f_.types
20160921 22:24:34< celticminstrel> Oh?
20160921 22:25:08< tad_> What would make life so much easier for this next fix for THoT would be if I could load map (like terrain_mask), select tiles from it, and discard the map ... *sigh*
20160921 22:25:45< gfgtdf> tad_: why do you mean by select tiles ?
20160921 22:26:16< celticminstrel> BTW, is there a set terrain debug command?
20160921 22:26:44< gfgtdf> celticminstrel: my guess woudl be yes but not sure.
20160921 22:27:17< tad_> I need a [avoid] and it neesd to be ONE [avoid] and I need to select a LOT of tiles. And, it's obvious the map was changed but the x,y junk in the scene.cfg never updated.
20160921 22:27:53< gfgtdf> tad_: can't you just use a doof location folter istead of explicitly xy ?
20160921 22:28:03< gfgtdf> tad_: don't know teh explicit case sry
20160921 22:28:51< tad_> I might be able to do a SLF but it's going to be gross and disgusting and hard to understand. Or I do a LLOONNGG x,y series 
20160921 22:30:20< tad_> As it is it's a lot of [avoid] and only the last one takes affect. So I need to fix it. Just wish I could make it easier to maintain when I do.
20160921 22:31:34< tad_> [avoid]mask={filename} terrain="_
20160921 22:31:47< tad_> [avoid]mask={filename} terrain="_F"[/avoid]  would be so nice
20160921 22:35:57< celticminstrel> Interesting idea.
20160921 22:37:16< tad_> Actually, make that part of SLF so it's usable everywhere. Not that hard but too much for my mind and you're busy so we need a newbie looking for a TODO for it
20160921 22:37:22< celticminstrel> Might be horribly inefficient though...
20160921 22:37:41< celticminstrel> I think it'd be fine in [avoid] (as far as I know that's stored as a terrain filter), not sure about elsewhere.
20160921 22:38:09< tad_> Load map, filter .. just need to be sure to destruct and free the map ..
20160921 22:38:38< celticminstrel> And make sure the map isn't reloaded for each tile being checked or anything idiotic like that.
20160921 22:38:48 * tad_ nods.
20160921 22:39:06< tad_> Sorta begs for a cache scheme on the map, too.
20160921 22:39:48< celticminstrel> Ooh, maybe this can already be done with [avoid[lua_function= ...
20160921 22:39:50< tad_> But it's too much for now. Maybe after 1.14
20160921 22:39:55< celticminstrel> [avoid]
20160921 22:40:17< celticminstrel> Yeah, seems pretty big.
20160921 22:41:43< tad_> When I was looking at the map for that issue with special locations I thought "this screams for a refactor" .. maybe do that and add the feature .. it's something to think about
20160921 22:53:06-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160921 22:55:29-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160921 22:55:29-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20160921 22:55:30-!- wedge010 is now known as wedge009
20160921 22:55:30-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20160921 22:55:30-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20160921 23:29:54-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20160921 23:30:00-!- janebot_ [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20160921 23:30:02-!- janebot_ is now known as janebot
20160921 23:41:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20160921 23:42:09-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160921 23:42:23-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160921 23:45:34-!- jamibaraki [3d7d7260@gateway/web/freenode/ip.61.125.114.96] has joined #wesnoth-dev
20160921 23:50:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160921 23:53:42-!- tad_ [add94167@gateway/web/freenode/ip.173.217.65.103] has quit [Ping timeout: 240 seconds]
20160921 23:55:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
--- Log closed Thu Sep 22 00:00:32 2016