--- Log opened Wed Sep 28 00:00:44 2016
20160928 00:04:59< matthiaskrgr> celticminstrel: does that fix the lobby crashes? 
20160928 00:05:18< matthiaskrgr> well not lobby, but "create game" screen 
20160928 00:12:41-!- gfgtdf [~chatzilla@x4e368841.dyn.telefonica.de] has joined #wesnoth-dev
20160928 00:24:15-!- Greg-Bog_ [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20160928 00:24:55-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 00:28:51-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160928 00:29:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 00:31:47-!- atarocch_ [~atarocch@88.131.217.34] has quit [Remote host closed the connection]
20160928 00:43:46-!- Grickit [~derek@wesnoth/developer/grickit] has quit [Ping timeout: 244 seconds]
20160928 00:43:54-!- Gambit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20160928 00:52:36< celticminstrel> matthiaskrgr: Didn't test create, but probably at least some.
20160928 00:52:47< celticminstrel> If it's related to a menu, then probably.
20160928 00:52:59< celticminstrel> I tested in prefs and editor.
20160928 00:59:30-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20160928 01:04:26-!- gfgtdf [~chatzilla@x4e368841.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 01:04:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160928 01:04:56-!- gfgtdf [~chatzilla@x4e368841.dyn.telefonica.de] has joined #wesnoth-dev
20160928 01:05:56-!- gfgtdf_ [~chatzilla@x4e368841.dyn.telefonica.de] has joined #wesnoth-dev
20160928 01:06:18< vultraz> ah, gfgtdf
20160928 01:09:05-!- gfgtdf [~chatzilla@x4e368841.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 01:09:20-!- gfgtdf_ is now known as gfgtdf
20160928 01:12:28< vultraz> gfgtdf: around?
20160928 01:16:49< vultraz> celticminstrel: I see you fixed the crash
20160928 01:16:54< vultraz> seems like a workaround only, though
20160928 01:17:54< celticminstrel> It works. Don't question it. :( (And it's relatively simple.)
20160928 01:19:34< vultraz> Actually, the problem makes sense now
20160928 01:20:03< celticminstrel> Oh?
20160928 01:20:04< vultraz> because of has_minimum = true, selecting the same entry actually deselects it (technically toggles it to off)
20160928 01:20:15< celticminstrel> Right.
20160928 01:20:31< vultraz> so you force it to off so it toggles to on
20160928 01:22:58< vultraz> I shall expand on the code comment
20160928 01:23:10< celticminstrel> 9_9
20160928 01:24:32< celticminstrel> You could probably instead attach a selection handler or something to the list box that sets selected_item_ regardless of whether it was set on or off, but that was a bigger change and this works just fine, so I went with it.
20160928 01:25:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has joined #wesnoth-dev
20160928 01:28:22-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 01:30:11-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has quit [Ping timeout: 272 seconds]
20160928 01:30:19< irker474> wesnoth: Charles Dang wesnoth:master 5f043a79f10b / src/gui/dialogs/drop_down_list.cpp: More detailed explanation of the workaround added in 6c2e2e9bf7e https://github.com/wesnoth/wesnoth/commit/5f043a79f10b4bd736d3f68d54110b068d23a1f2
20160928 01:30:23< vultraz> Now it's perfectly clear 
20160928 01:31:18-!- gfgtdf [~chatzilla@x4e368841.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 01:31:32-!- gfgtdf_ is now known as gfgtdf
20160928 01:32:06< vultraz> Instead of some future maintainer looking at that and going 'whaaa'?
20160928 01:33:29< vultraz> but thanks for fixing
20160928 01:33:31< vultraz> :)
20160928 01:58:21< irker474> wesnoth: Charles Dang wesnoth:master 1848c8c919b1 / data/gui/window/mp_method_selection.cfg: MP Method Selection: specify max username input length https://github.com/wesnoth/wesnoth/commit/1848c8c919b1c662323ee9f2451ea6166b478285
20160928 01:58:27< vultraz> Wonder why I didn't think of that before
20160928 01:59:13< vultraz> (if anyone's wondering, that's a feature I introduced a while ago to restricted savegame names to 127 characters)
20160928 02:00:34< vultraz> I wonder if there's any other place max input length makes sense
20160928 02:00:49< vultraz> celticminstrel: is there a max password length?
20160928 02:01:44< vultraz> Also, whoot! The new board has been announced! :D
20160928 02:03:31< shadowm> Goodbye project neutrality.
20160928 02:05:21< celticminstrel> vultraz: I sure hope not.
20160928 02:05:35< celticminstrel> shadowm: What are you talking about.
20160928 02:07:33< celticminstrel> vultraz: Password length should not be limited except due to actual technical limitations.
20160928 02:07:51< vultraz> sounds reasonable 
20160928 02:14:34-!- Bonobo [~Bonobo@118.211.10.176] has joined #wesnoth-dev
20160928 02:23:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 02:38:40-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 02:39:27-!- gfgtdf__ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 02:41:34-!- gfgtdf [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 02:41:36-!- gfgtdf__ is now known as gfgtdf
20160928 02:43:07-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 02:47:41-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 02:48:56-!- gfgtdf__ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 02:51:23-!- gfgtdf [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 02:51:36-!- gfgtdf__ is now known as gfgtdf
20160928 02:52:25-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160928 03:02:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has joined #wesnoth-dev
20160928 03:08:25-!- TC02 [~quassel@venus.arosser.com] has quit [Ping timeout: 255 seconds]
20160928 03:08:41-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 03:08:59-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has quit [Ping timeout: 272 seconds]
20160928 03:10:45-!- gfgtdf_ [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Client Quit]
20160928 03:11:31-!- gfgtdf [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Ping timeout: 272 seconds]
20160928 03:15:12-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20160928 03:16:16-!- TC02 [~quassel@venus.arosser.com] has quit [Read error: Connection reset by peer]
20160928 03:16:23-!- TC03 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20160928 03:17:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160928 03:17:49-!- vultraz changed the topic of #wesnoth-dev to: 1.13.6 planned for mid-October | Wesnoth Inc. board elections: https://r.wesnoth.org/t44616 (results have been announced) | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160928 03:26:18< shadowm> lol: http://www.boost.org/doc/libs/
20160928 03:26:40< shadowm> (Yes, I am aware I can use the version-specific links.)
20160928 03:30:17-!- JyrkiVesterinen [~JyrkiVest@87-100-166-95.bb.dnainternet.fi] has joined #wesnoth-dev
20160928 03:46:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 03:49:03< vultraz> heh
20160928 03:57:44< irker474> wesnoth: Jyrki Vesterinen wesnoth:master 9811ad334b0a / src/scripting/application_lua_kernel.cpp: Fix: the plugin version of wesnoth.delay() didn't wait with --nogui https://github.com/wesnoth/wesnoth/commit/9811ad334b0abd16a5f68a71c43cb9d9c6c7e409
20160928 03:59:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160928 04:00:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 04:04:37-!- JyrkiVesterinen [~JyrkiVest@87-100-166-95.bb.dnainternet.fi] has quit [Quit: .]
20160928 04:24:55-!- Nobun [~nobun@5.170.105.69] has joined #wesnoth-dev
20160928 04:25:47< Nobun> celticminstrel: during this 'insomnia' night I fixed a lot of errors and bugs on my experimental implementation for lua plural support on wmlxgettext
20160928 04:26:27< celticminstrel> Oh fun!
20160928 04:26:48< Nobun> the current version, at least on first basic tests, seems working, however it needs a lot of other tests
20160928 04:27:57< Nobun> I uploaded my personal repository (on plural branch)
20160928 04:29:05< Nobun> I also added an extra option on wmlxgettext wich is helping me a lot on tracking wmlxgettext internal errors, since writing test for wmlxgettext state sequence is pretty hard
20160928 04:30:36< Nobun> It is --DMode option wich will write an extra file 'debug.txt' with all informations about what states are runned and what is the unconsumed line
20160928 04:31:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160928 04:31:54< Nobun> I think I forgot to remove an extra debug output test (on console) I temporary needed to fix an error... I will fix it in my local drive (I will not upload it until next release)
20160928 04:32:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 04:33:30< Nobun> celticminstrel: I think it could be a nice idea if I can somehow  show the tests I made
20160928 04:34:20< Nobun> but I am unsure HOW
20160928 04:35:20< Nobun> (the general idea is... I can forget to consider a corner case or something similar)
20160928 04:36:03< Nobun> however the nice news is that the code SHOULD work for every kind of combinations for plural form
20160928 04:37:12< Nobun> I will show you the first test:
20160928 04:40:05< Nobun> celticminstrel: lua test file --> http://dpaste.com/14BTJB1
20160928 04:40:30< Nobun> celticminstrel: wmlxgettext output file --> http://dpaste.com/1MDS8N6
20160928 04:42:19< Nobun> There are still a lot of things that are not tested on purpose on this first step.
20160928 04:42:28< Nobun> In the following days I will test:
20160928 04:43:07< Nobun> 1) plural forms with existing sentences (to check if plural is updated correctly)
20160928 04:43:29< Nobun> 2) textdomain changes
20160928 04:44:59< Nobun> [END OF REPORT] --> sorry if I required a bit of time to write all the informations :P
20160928 04:47:44 * celticminstrel starts reading the report.
20160928 04:48:41< celticminstrel> Hmm.
20160928 04:49:23< celticminstrel> Your last example is missing the numner. :P (Though that doesn't matter for the purposes of wmlxgettext probably.)
20160928 04:50:11< celticminstrel> I don't remember if it was standard for pot-files to include the msgstr[1] lines.
20160928 04:50:31< Nobun> celticminstrel: what number is missing?
20160928 04:50:40< celticminstrel> The count for the plural.
20160928 04:50:53< Nobun> ah the header info, you mean
20160928 04:51:11< Nobun> right?
20160928 04:51:12< celticminstrel> I'm talking about the 2 in this example: _("one", "several", 2)
20160928 04:51:33< Nobun> it is not used on pot file
20160928 04:51:47< celticminstrel> Right.
20160928 04:51:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 04:52:25< Nobun> when translating plural forms in another language (msgid[0] msgid[1]) the header info for plural type is the one information that really matters
20160928 04:52:38< Nobun> however that header info is currently missing on purpose
20160928 04:52:45< celticminstrel> Looks like it is in fact standard to see msgstr[1] lines in the pot-file.
20160928 04:53:09< celticminstrel> Yeah, that header info should be added by the translator.
20160928 04:53:36< Nobun> yes... the count depends by the destination language (wich can require more than [0] and [1]) but those ones are the most common cases
20160928 04:53:56< celticminstrel> Some languages might only require [0].
20160928 04:53:59< Nobun> celticminstrel: actually that header info is not added by translator, but by gettext tools
20160928 04:54:09< celticminstrel> But I guess such a language could just remove the [1] line.
20160928 04:54:25< celticminstrel> Well sure, but it's presumably the translator who runs those gettext tools in order to add the header info.
20160928 04:55:07< Nobun> probably the gettext tool I mentioned will fix also that things too (and not only the header) but I can't test, becouse my locale is Italian wich works like english ([0] for singular = 1[1] for plural)
20160928 04:55:23< Nobun> celticminstrel: it is SURELY so :P
20160928 04:56:16-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Permission denied]
20160928 04:56:16< Nobun> if I remember correctly the 'msginit' tool should be used in order to perform that task
20160928 04:57:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 05:02:55< Nobun> celticminstrel: infact translator needs to have his own locale to use msginit correctly
20160928 05:03:12< Nobun> for example, I am Italian and I have locale installed in my Ubuntu
20160928 05:03:44< Nobun> 'locale -a' returns all available locales in my system
20160928 05:04:24< celticminstrel> Technically not required - you can explicitly tell msginit to use a particular locale rather than the system default.
20160928 05:04:40< Nobun> it returns all values... in my case, if I want to translate in Italian, the value on my system is 'it_IT.utf8'
20160928 05:04:41< celticminstrel> msginit -l=en_GB for example.
20160928 05:04:50< Nobun> yes but it must be installed
20160928 05:04:58< celticminstrel> Possibly. I dunno,
20160928 05:05:25< Nobun> for example italian locale, in my case, is 'it_IT.utf8'
20160928 05:05:44< Nobun> don't know if 'it_IT' can work, but I assume not
20160928 05:05:48< celticminstrel> Huh, apparently msginit can also produce Java .properties and OSX .strings files...
20160928 05:05:59< celticminstrel> it_IT would probably work, yes.
20160928 05:07:35< Nobun> however remember to inform me whenever you have an idea IF and HOW you want to add plural support also on WML
20160928 05:09:06< Nobun> (implementing this feature in WML is a bit of a pain xD)
20160928 05:09:13< celticminstrel> I'm not confident that it's possible.
20160928 05:09:45< Nobun> well, from my point of view, it is better if WML will not support it (less work for me :P)
20160928 05:10:46< celticminstrel> Of course ActionWML could be written that uses the Lua plurals, but there's no way for that to know what the file's textdomain is, I think.
20160928 05:12:14< Nobun> celticminstrel: after all, thinking deeply, perhaps it is better to DON'T add a direct support on WML
20160928 05:12:42< Nobun> it can introduce a lot of downside problems, not only related to wmlxgettext
20160928 05:12:52< celticminstrel> Parser-level support on the other hand runs into the problem that there's no way for it to know about any variable that contains the actual number to use.
20160928 05:13:14< Nobun> after all, it is not so hard to add a lua code in a WML file into a [lua] tag, if someone wants to add sentences with plural form
20160928 05:13:26< celticminstrel> Yeah, I suppose.
20160928 05:14:08< Nobun> also thinking about wmlxgettext... if we introduce WML tag we cannot be sure that wmlxgettext will work correctly with it
20160928 05:14:29< Nobun> becouse user could want to use a macro
20160928 05:14:55< Nobun> or, if implementing it as a macro, this will have downside aspect on wmlinfo collecting by wmlxgettext
20160928 05:15:26< Nobun> so, imho, using only lua it could be the best solution
20160928 05:19:20-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160928 05:22:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 240 seconds]
20160928 05:22:21-!- wedge010 is now known as wedge009
20160928 05:24:14< Nobun> celticminstrel: a little test show you was right about msginit
20160928 05:24:43< Nobun> I tried to use msginit -i test1.pot -o T2.pot -l jp_JP
20160928 05:25:01< Nobun> (obliouvsly I don't have japaneese in my system)
20160928 05:25:38< Nobun> The good news is that msginit changes NOT ONLY the header info, but also the msgstr[x] list on plural forms
20160928 05:26:23< Nobun> I don't know japanese, but all sentences with plural form (unlike italian) have only msgstr[0]
20160928 05:28:05< Nobun> so it may possibly mean that japanese don't have plural forms
20160928 05:34:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 05:43:21-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160928 05:46:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160928 05:46:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 05:54:11-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 06:02:02-!- Nobun [~nobun@5.170.105.69] has quit [Ping timeout: 244 seconds]
20160928 06:02:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 06:05:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has joined #wesnoth-dev
20160928 06:10:45-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has quit [Ping timeout: 272 seconds]
20160928 06:11:09-!- Kwandulin [~Miranda@p200300760F2C711FC4041B9F9FCA16DE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160928 06:22:47-!- Bonobo [~Bonobo@118.211.10.176] has quit [Ping timeout: 272 seconds]
20160928 06:27:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 272 seconds]
20160928 06:29:45-!- Bonobo [~Bonobo@pa49-183-181-183.pa.vic.optusnet.com.au] has joined #wesnoth-dev
20160928 06:33:25-!- Bonobo [~Bonobo@pa49-183-181-183.pa.vic.optusnet.com.au] has quit [Read error: Connection reset by peer]
20160928 06:34:28-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160928 06:55:43-!- Kwandulin [~Miranda@p200300760F2C711FC4041B9F9FCA16DE.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20160928 06:55:59-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160928 06:59:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160928 07:17:09-!- Kwandulin [~Miranda@p200300760F2C71BFC4041B9F9FCA16DE.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160928 07:45:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160928 07:50:05< zookeeper> in the in-game help, you can expand top-level items with a single click, but for example in the terrains section you have to double click on the terrain items to expand them.
20160928 07:51:16< vultraz> as with units
20160928 07:53:54-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20160928 07:59:09-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160928 08:06:41-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20160928 08:08:33-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 272 seconds]
20160928 08:11:10< shadowm> vultraz: What's the issue with the addons manager?
20160928 08:11:12-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 244 seconds]
20160928 08:22:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 08:24:36-!- boucman_work [~boucman@193.56.60.161] has joined #wesnoth-dev
20160928 08:26:38-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160928 08:37:02-!- Kwandulin [~Miranda@p200300760F2C71BFC4041B9F9FCA16DE.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160928 08:42:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160928 08:47:31-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160928 08:51:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 08:52:20-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 08:58:26< vultraz> shadowm: the Options dialog doesn't appear, and the addon list won't fill. The list displays fine in the GUI2 version.
20160928 09:00:41-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160928 09:01:50< vultraz> shadowm: the latter could possibly be a minor issue, but the former is likely more complicated. AFAIK it's the only place a GUI2 dialog opens over a GUI1 dialog, so it could be a rendering issue. Whether that would be hard to fix or not, I don't know, but I don't think it's worth fixing the GUI1 version, and instead, the GUI2 version shouldbe made functional
20160928 09:02:30< vultraz> shadowm: most of your management code from the GUI1 version be reused, I think, but I haven't gotten around to it.
20160928 09:02:39< shadowm> I doubt it.
20160928 09:03:04< shadowm> About 60% of it is tied to GUI1 calls and loops.
20160928 09:03:51< shadowm> 60% of the code in _ui.cpp, that is. The rest is obviously UI framework-agnostic.
20160928 09:04:04< shadowm> The other files, I mean. Crap.
20160928 09:05:13< vultraz> The GUI2 dialog currently correctly displays all addons and their details, and can be sorted.
20160928 09:05:20< vultraz> I just need to wire in download functionality
20160928 09:06:06< vultraz> And upload, and decide what options from the Settings/Options dialog need to be restricted to a separate dialog.
20160928 09:06:13< vultraz> s/a/the
20160928 09:07:05< vultraz> (I say this since I haven't evaluated which are now obsolete or could use new widgets)
20160928 09:08:14-!- Kwandulin [~Miranda@p200300760F2C71BFD1D1C4BD47F17A14.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160928 09:09:39< shadowm> The GUI1/GUI2 interaction theory is a reasonable one. I can click on the GUI1 dialog and hear the correct sound effects even though the display is frozen and supposedly the GUI2 dialog should be receiving events instead.
20160928 09:10:26< shadowm> The add-ons list not being displayed hardly sounds like a GUI1 issue.
20160928 09:10:37< vultraz> Granted
20160928 09:10:37< shadowm> I get the Publish entries.
20160928 09:10:48< vultraz> I don't know what the problem could be, though
20160928 09:10:52< vultraz> bbl, dinner
20160928 09:10:52< shadowm> (No Delete entries since I'm looking at a server instance that doesn't have those add-ons.)
20160928 09:13:29< shadowm>     src/gui/dialogs/lobby/info.hpp:119:1: error: version control conflict marker in file
20160928 09:13:42< shadowm> GCC. <3
20160928 09:14:17< shadowm> (Yes, that's because of something I did in my copy. No need to panic.)
20160928 09:21:53< shadowm> vultraz: I found the culprit for the empty add-ons list. It's commit fe08701b7ca3639b17dca20023d2bb34433042c6 by celmin.
20160928 09:22:32< shadowm> It has nothing to do with the options dialog glitching into the void, of course.
20160928 09:25:42-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160928 09:26:55< shadowm> The fix seems trivial enough, will test in a bit.
20160928 09:27:22 * shadowm says, not having used boost::dynamic_bitset before.
20160928 09:29:04< shadowm> The hard part is waiting for the -O0 build to finish, really.
20160928 09:38:28< irker474> wesnoth: Ignacio R. Morelle wesnoth:master c26b13372b73 / src/addon/manager_ui.cpp: addon/mg: Fix regression causing all categories to be filtered out by default https://github.com/wesnoth/wesnoth/commit/c26b13372b7370e11c899a24d4149130f41451d8
20160928 09:38:38< shadowm> celticminstrel, vultraz: ^
20160928 09:40:55< shadowm> Wasn't sure whether to use flip() instead. I thought the unsigned hex was more visible and cool-looking.
20160928 09:41:19< shadowm> Doubt there'll ever be more than 4294967295 add-on categories anyway.
20160928 09:43:02< shadowm> Also, I believe that there'd have been add-ons displayed if there were any add-ons with type = 1 (ADDON_CORE a.k.a. total conversions) on the 1.13 server.
20160928 09:43:12< shadowm> Alas.
20160928 09:50:19-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20160928 10:00:21-!- Appleman1234 [~Appleman1@KD119104055135.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160928 10:04:11-!- Appleman1234 [~Appleman1@KD119104045244.au-net.ne.jp] has joined #wesnoth-dev
20160928 10:07:24-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has joined #wesnoth-dev
20160928 10:12:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:28a1:1a4f:d5ca:2bf6] has quit [Ping timeout: 272 seconds]
20160928 10:14:37-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection]
20160928 10:15:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160928 10:25:48-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160928 10:26:10< vultraz> ahhh
20160928 10:26:14< vultraz> thanks for doing that :D
20160928 10:30:58-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160928 10:31:03-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 272 seconds]
20160928 10:37:05-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160928 10:41:45-!- louis94 [~~louis94@91.178.242.21] has quit [Ping timeout: 276 seconds]
20160928 11:05:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 276 seconds]
20160928 11:18:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 11:19:16-!- boucman_work [~boucman@193.56.60.161] has quit [Ping timeout: 244 seconds]
20160928 11:21:09-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160928 11:23:19-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20160928 11:28:36-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160928 11:31:27-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160928 11:46:54-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20160928 11:55:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 11:57:21-!- louis94 [~~louis94@91.178.242.21] has quit [Ping timeout: 240 seconds]
20160928 11:59:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160928 12:00:04-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 12:17:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160928 12:17:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 12:18:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160928 12:33:47-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160928 12:38:42-!- irker474 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160928 12:40:26-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160928 12:43:25-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 272 seconds]
20160928 12:54:29-!- Kwandulin [~Miranda@p200300760F2C71BFD1D1C4BD47F17A14.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160928 12:54:39-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 12:59:01-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160928 13:01:06-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 13:13:16< zookeeper> iceiceice, it seems you introduced https://gna.org/bugs/index.php?25131 in https://github.com/wesnoth/wesnoth/commit/b75f41798258
20160928 13:14:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160928 13:23:17-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Remote host closed the connection]
20160928 13:24:32-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160928 13:29:01-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 13:43:24-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160928 13:45:44-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20160928 13:53:03-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160928 14:08:39-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 14:09:38-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160928 14:14:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20160928 14:42:15-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Ping timeout: 276 seconds]
20160928 14:56:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 15:11:59-!- atarocch [~atarocch@88.131.217.34] has joined #wesnoth-dev
20160928 15:38:25< vultraz> zookeeper: is it not supposed to move to an adjacent passable hex?
20160928 15:39:17< zookeeper> no?
20160928 15:39:36< vultraz> what should it do?
20160928 15:39:48< zookeeper> if i tell it to _not_ check passability, then it should just perform the move regardless of, you know, passability :P
20160928 15:40:05< zookeeper> currently the option seems to do nothing
20160928 15:40:15< vultraz> oh, I misread
20160928 15:42:39-!- Kwandulin [~Miranda@p200300760F2C71BFA16925F356C51318.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160928 15:51:12< vultraz> though I don't see how your linked change could have broken it
20160928 15:51:52< vultraz> since it doesn't involve a check for passability 
20160928 15:52:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 15:52:49-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 15:56:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160928 15:57:13-!- JyrkiVesterinen [~JyrkiVest@89-166-107-164.bb.dnainternet.fi] has joined #wesnoth-dev
20160928 15:57:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 15:58:56-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 15:59:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 15:59:37< zookeeper> vultraz, i dunno, but i did check by using the lua code from the preceding revision and it worked correctly
20160928 15:59:57< zookeeper> i dunno how high i'd rate the probability that i just botched up the test, but still
20160928 16:01:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20160928 16:03:22-!- mjs-de [~mjs-de@x5ce4a3a3.dyn.telefonica.de] has joined #wesnoth-dev
20160928 16:03:31-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Remote host closed the connection]
20160928 16:04:32< zookeeper> hmh. checked again; it's not that revision after all
20160928 16:05:19 * zookeeper rates the probability at 100%
20160928 16:11:00< zookeeper> ahem
20160928 16:11:16 * zookeeper discreetly passes vultraz a slip of paper with 3acb30e1ca3ab written on it
20160928 16:11:33< zookeeper> ah
20160928 16:11:36< zookeeper> wrong piece of paper
20160928 16:11:45 * zookeeper discreetly passes vultraz the correct slip of paper with 778c840483d4 written on it
20160928 16:12:57< vultraz> well that's odd
20160928 16:13:28< vultraz> the 'or true' syntax is used a lot :/ why would it break here
20160928 16:14:58< DeFender> just a guess without seeing any sort of context, "false or true" is true.
20160928 16:15:31< vultraz> but it's not false, it's "no"
20160928 16:15:45< vultraz> which is a string and true 
20160928 16:16:45< DeFender> Is it a real "no" or a post-cfg-parsing "no", which parses to false?
20160928 16:17:15< vultraz> eh?
20160928 16:17:20< vultraz> oh, I see
20160928 16:17:26< vultraz> pretty sure the former
20160928 16:19:53< vultraz> oh, I just realized ...
20160928 16:20:00< vultraz> 'or false' is used
20160928 16:20:07< vultraz> but this is the only instance of 'or true'
20160928 16:20:16< vultraz> odd...
20160928 16:20:20< vultraz> perhaps DeFender is right
20160928 16:22:46< DeFender> the "specifiedValue or defaultFallback" trick is cute, but ultimately fails when the specified value has the potential to be falsey.
20160928 16:24:17< DeFender> it'd be better as "local whatever = someCfgValue; if whatever == nil then whatever = defaultForWhatever; end"
20160928 16:25:02< JyrkiVesterinen> The same function uses the variable this way:
20160928 16:25:03< JyrkiVesterinen> if check_passability then pass_check = current_unit end
20160928 16:25:27< JyrkiVesterinen> It assumes that the variable is already a boolean.
20160928 16:25:43< DeFender> so then it's likely i'm right.
20160928 16:26:10< vultraz> isn't there a trick to ensure it's always bool
20160928 16:26:14< JyrkiVesterinen> "or true" is definitely wrong here. It forces the variable to have a truthy value, and the if check to pass.
20160928 16:26:20< zookeeper> DeFender, as it happens, that's _exactly_ what the original code was :>
20160928 16:27:12< DeFender> this is a case where lua forces verbosity because it lacks a ternary operator. If it had it, you could just do "local whatever = (someCfgValue ~= nil ? someCfgValue : defaultForWhatever);" in one line
20160928 16:27:40< DeFender> zookeeper, sounds like someone was trying to cut down verbosity without realizing it was necessary in that case.
20160928 16:27:56< vultraz> DeFender: it was me :P
20160928 16:28:53< DeFender> vultraz, coulda happened to anyone though :P
20160928 16:29:00< JyrkiVesterinen> Lua has an equivalent to the ternary operator: https://www.lua.org/pil/3.3.html
20160928 16:29:14< vultraz> I guess I kinda got used to using the 'value or default' thing as a psuedo-ternary operator without fully understanding it.
20160928 16:29:18 * zookeeper drops a squeaky rubber duck on vultraz
20160928 16:29:26< zookeeper> this does not warrant mallet
20160928 16:29:46< DeFender> JyrkiVesterinen, interesting.
20160928 16:30:54< DeFender> vultraz, the reason it was my first thought as to what might be wrong is because i've made the same mistake in javascript more than once
20160928 16:31:34< vultraz> zookeeper: do revert that line
20160928 16:31:59< DeFender> vultraz, i no longer use that syntax for this reason.
20160928 16:33:48< DeFender> JyrkiVesterinen, that ternary trick with the "and" and "or" is fascinating, but it also ends up not being intuitive unless you're familiar with that particular pattern. Otherwise, you look at it trying to remember which operator takes precedence and trying to figure out what the result it. That said, now that i know it's there, it does make sense to use in these kinds of cases.
20160928 16:34:26< DeFender> JyrkiVesterinen, actually, just looked closer
20160928 16:34:36< DeFender> JyrkiVesterinen, there's a proviso there: "provided that b is not false."
20160928 16:34:43< JyrkiVesterinen> I have worked on commercial projects where all the programmers were aware of the pattern. It was used all over the place.
20160928 16:35:21< JyrkiVesterinen> Oh, right. I forgot about the "b is not false" requirement.
20160928 16:35:33< JyrkiVesterinen> Indeed, the ternary trick can't be used here.
20160928 16:35:38< DeFender> fine, but I could see the "provided that b is not false" thing leading to issues like this one. Heck, it wouldn't even work in this case.
20160928 16:36:53< DeFender> come to think of it, the "b is not false" thing makes this no different than using or alone, at least in this case.
20160928 16:37:46< JyrkiVesterinen> "a or c" is essentially the same thing as "a and a or c".
20160928 16:38:08< JyrkiVesterinen> In other words, it's a shortcut of the ternary syntax for the default value case.
20160928 16:38:10< vultraz> it is times like this I miss Anura's FFL syntax. There, this would be, check_passability: { type: "bool", default: true }
20160928 16:39:04-!- mjs-de [~mjs-de@x5ce4a3a3.dyn.telefonica.de] has quit [Remote host closed the connection]
20160928 16:39:05< JyrkiVesterinen> The C# programming language has a ?? operator. There you could do "bool check_passability = cfg.check_passability ?? true;"
20160928 16:39:25< vultraz> interesting 
20160928 16:39:59< DeFender> JyrkiVesterinen, and PHP recently added "?:", so you could do "$check_passability = $cfg->check_passability ?: true;"
20160928 16:40:40< DeFender> (Though i need to check if i'm correct that it does that only for null and not for other falsey values...)
20160928 16:41:26< DeFender> ah, no, wouldn't work. would return true for any falsey value.
20160928 16:42:27< JyrkiVesterinen> What's the point of ?: then? It sounds equivalent to logical OR (|| in most languages).
20160928 16:42:56< DeFender> Logical OR always returns a boolean in PHP
20160928 16:43:09< JyrkiVesterinen> Oh, okay.
20160928 16:43:20< DeFender> so "0||1" is "false", but "0?:1" is "1".
20160928 16:44:55< DeFender> i'm actually a fan of the logical operators returning booleans no matter what, as it avoids issues such as the case in point.
20160928 16:45:35< DeFender> also because soft-typing is kind of icky already
20160928 16:46:19< DeFender> and having operators whose type you don't necessarily know the output of makes it more icky
20160928 16:47:39-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160928 16:47:39-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160928 16:48:07-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160928 16:53:33-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 16:56:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160928 16:57:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 17:06:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 17:07:38-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 17:09:29-!- Kwandulin [~Miranda@p200300760F2C71BFA16925F356C51318.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160928 17:09:30-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160928 17:10:41-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20160928 17:19:17-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160928 17:23:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160928 17:23:22-!- wedge010 is now known as wedge009
20160928 17:23:24-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has joined #wesnoth-dev
20160928 17:23:24-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has quit [Changing host]
20160928 17:23:24-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20160928 17:23:38< mordante> servus
20160928 17:26:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 17:26:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 17:29:28-!- louis94 [~~louis94@91.178.242.21] has quit [Quit: Konversation terminated!]
20160928 17:29:36-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20160928 17:36:01-!- louis94 [~~louis94@91.178.242.21] has quit [Ping timeout: 272 seconds]
20160928 17:46:29-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.2 Aria]
20160928 17:47:06-!- Nobun [~nobun@5.170.116.88] has joined #wesnoth-dev
20160928 17:48:44< Nobun> celticminstrel: another test was successfully. I tested the experimental wmlxgettext against the 'stable' wmlxgettext with my tool wescheck.py (with a little change) wich 'emulates' pot-update target, making comparisons
20160928 17:49:31< Nobun> this means that current implementation should not have introduced any new bugs related to the previous features
20160928 17:51:29< Nobun> there is an interesting result, on the experimental plural branch ---> it adds a translatable string wich was previously discarded
20160928 17:53:24< Nobun> on data/lua/wml/message.lua:233 --> it recognize also the "input" translatable string found on this lua line ---> local wait_description = cfg.wait_description or _("input")
20160928 18:03:51-!- midzer_ [~quassel@p57B45DE4.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160928 18:06:21-!- midzer [~quassel@p57B452A5.dip0.t-ipconnect.de] has quit [Ping timeout: 276 seconds]
20160928 18:10:49-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160928 18:14:00< celticminstrel> Huh. Well, I guess that's a good thing though.
20160928 18:14:31< celticminstrel> Admittedly I find that string slightly dubious... but that's a different issue altogether.
20160928 18:15:40< Nobun> yes, but it is marked as translatable, so it is expected that wmlxgettext collect it (until it is on the right textdomain)
20160928 18:16:12< celmin> Right.
20160928 18:16:26 * celmin has no idea what your parenthetical means there.
20160928 18:17:58 * Nobun doesn't understand what celmin means with 'he has no idea what your parenthetical means there'
20160928 18:18:16< Nobun> :P
20160928 18:18:19-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20160928 18:18:25< celmin> Text enclosed in (parentheses) can be called a parenthetical.
20160928 18:18:45< celmin> In other words, I don't know what you mean by "until it is on the right textdomain".
20160928 18:21:08< Nobun> I mean simply that wmlxgettext must collect all translatable strings wich are under the right textdomain and not other translatable string wich uses different textdomain
20160928 18:21:20< Nobun> for example... if you run wmlxgettext --domain=wesnoth ...
20160928 18:21:49< Nobun> you must collect only sentences on 'wesnoth' textdomain and not, for example, on 'wesnoth-httt' textdomain
20160928 18:23:37-!- mjs-de [~mjs-de@x5ce4a3a3.dyn.telefonica.de] has joined #wesnoth-dev
20160928 18:24:23-!- midzer_ is now known as midzer
20160928 18:28:51-!- esr1 is now known as esr
20160928 18:32:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 18:32:06-!- mjs-de [~mjs-de@x5ce4a3a3.dyn.telefonica.de] has quit [Remote host closed the connection]
20160928 18:34:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160928 18:34:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 18:35:02-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 18:36:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 18:37:57-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160928 18:41:18-!- louis94 [~~louis94@91.178.242.21] has quit [Ping timeout: 264 seconds]
20160928 18:45:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 19:05:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 19:09:57< celmin> Ah.
20160928 19:13:09-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160928 19:15:54-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160928 19:21:45-!- Nobun [~nobun@5.170.116.88] has quit [Ping timeout: 276 seconds]
20160928 19:23:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 19:24:21-!- ancestral [~ancestral@209.181.254.220] has joined #wesnoth-dev
20160928 19:26:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 19:30:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160928 19:39:06-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20160928 19:49:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 272 seconds]
20160928 19:50:55-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160928 19:51:08-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160928 19:56:52-!- ancestral [~ancestral@209.181.254.220] has quit [Quit: i go nstuf kthxbai]
20160928 20:01:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 20:06:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160928 20:06:26-!- SeamusFD [~SeamusFD@208.163.165.173] has joined #wesnoth-dev
20160928 20:07:21-!- SeamusFD [~SeamusFD@208.163.165.173] has quit [Client Quit]
20160928 20:13:32< celmin> So I guess I did miss one instance of using the fill constructor in vector<bool>
20160928 20:13:45< celmin> I missed it because it was in the constructor's initialization list. :/
20160928 20:15:13< celmin> Not sure if shadow m's fix is perfect (does it allow you to see more than 64 addons?).
20160928 20:16:44-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160928 20:25:25-!- JyrkiVesterinen [~JyrkiVest@89-166-107-164.bb.dnainternet.fi] has quit [Quit: .]
20160928 20:30:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 20:40:38-!- mjs-de [~mjs-de@x5ce4a3a3.dyn.telefonica.de] has joined #wesnoth-dev
20160928 20:43:13-!- Nobun [~nobun@5.170.106.74] has joined #wesnoth-dev
20160928 20:43:47-!- Bonobo [~Bonobo@2001:44b8:254:3200:6c2d:bb40:fceb:98d9] has joined #wesnoth-dev
20160928 20:50:16-!- mjs-de [~mjs-de@x5ce4a3a3.dyn.telefonica.de] has quit [Remote host closed the connection]
20160928 20:54:43-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20160928 20:55:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 20:56:49-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20160928 20:59:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160928 21:08:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160928 21:08:47-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160928 21:18:36-!- Nobun [~nobun@5.170.106.74] has quit [Ping timeout: 244 seconds]
20160928 21:35:55< shadowm> celmin: 2^32 add-on categories, not 64 add-ons.
20160928 21:36:59< shadowm> <shadowm> Wasn't sure whether to use flip() instead. I thought the unsigned hex was more visible and cool-looking.
20160928 21:37:03< shadowm> <shadowm> Doubt there'll ever be more than 4294967295 add-on categories anyway.
20160928 21:37:47< celmin> I think both of us have one thing wrong here… by passing a 64-bit integer with all bits set, you're initializing the first 64 bits to 1 and the rest to 0. On the other hand, it seems somewhat unlikely that there'd even be more than 64 add-on categories, and I didn't realize the bitset applies to categories.
20160928 21:38:13-!- Nobun [~nobun@5.170.110.74] has joined #wesnoth-dev
20160928 21:38:27< shadowm> I'm passing unsigned long(0xFFFFFFFFUL) to a constructor that takes an unsigned long.
20160928 21:38:28< celmin> (Add-no categories are things like "campaign", "random map", "modification", "era", etc… right?)
20160928 21:38:52< celmin> So you're actually only initializing 32 bits.
20160928 21:39:10< celmin> Potentially. I suppose long could be 64-bit on some computers someday.
20160928 21:39:28< shadowm> I'm initializing sizeof(unsigned long)*8 bits.
20160928 21:39:45< celmin> Yes.
20160928 21:39:46< shadowm> If the constructor only takes an unsigned long I assume that means larger bitsets aren't supported.
20160928 21:40:50< shadowm> D'oh. OKay, I see what you mean by 64 versus a power.
20160928 21:41:35< shadowm> I can make it a flip instead then, although it still seems incredibly unlikely it'll ever be needed before this code meets its expiration date.
20160928 21:41:48< celmin> If I recall correctly, there are a limited number of add-on categories that are defined by us, so it's probably not that important?
20160928 21:42:25< celmin> Uh, that sounds wrong. "There are a limited number of add-on categories, and they are defined by us."
20160928 21:42:26< Nobun> long is 4 bytes, if I remember correctly, regardless of arch
20160928 21:43:01< celmin> Nobun: Wrong!
20160928 21:43:08< shadowm> sizeof(long) ≥ sizeof(int), that's the only guarantee made IIRC.
20160928 21:43:08< celmin> long is at least 4 bytes.
20160928 21:43:35< celmin> int and short are at least 2 bytes. (I think int is 4 bytes on Windows? Not quite sure.)
20160928 21:43:57< shadowm> int is 4 bytes on 32-bit and 64-bit Windows, yes.
20160928 21:44:18< celmin> And long long is at least 8 bytes.
20160928 21:44:34< celmin> And the types form an ordering short ≤ int ≤ long ≤ long long
20160928 21:44:38< celmin> (Their sizes)
20160928 21:44:55< shadowm> But then presumably on a 16-bit platform sizeof(long) == sizeof(int) == 2?
20160928 21:45:21< celmin> Presumably.
20160928 21:46:17< celmin> Apparently the value -2^n is not required to be supported in any of these types...
20160928 21:46:42-!- irker946 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160928 21:46:42< irker946> wesnoth: Ignacio R. Morelle wesnoth:master aae20e7c0c8e / src/addon/manager_ui.cpp: addon/mg: Use flip() instead of a 32-bits ulong to appease the pedants https://github.com/wesnoth/wesnoth/commit/aae20e7c0c8e45963cfdda4f6bb9a13edbd08ef3
20160928 21:46:50< celmin> Heh...
20160928 21:46:56 * celmin did say it's probably not that important.
20160928 21:47:43< shadowm> Well, now that we discussed to that extent odds are that vultraz would've demanded the change anyway.
20160928 21:47:47< shadowm> *discussed it
20160928 21:48:02< celmin> Who knows! You may be right. I dunno.
20160928 21:48:22< celmin> I suppose I should also thank you for fixing my mistake. >_>
20160928 21:49:06< shadowm> It took me a quick glance at the diff for that file to find the issue because I already knew the code, but I didn't look at any of the other files changed by the same commit.
20160928 21:49:56< shadowm> So maybe review it again in case there are any similar mistakes around?
20160928 21:50:00< celmin> Sure.
20160928 21:50:01< Nobun> celmin: you were right
20160928 21:50:08< Nobun> however I found an interesting thing
20160928 21:50:16< Nobun> Note: this allows the extreme case in which bytes are sized 64 bits, all types (including char) are 64 bits wide, and sizeof returns 1 for every type. 
20160928 21:50:19< shadowm> For example, the GUI2 unit create dialog has this line in the commit:
20160928 21:50:21< shadowm>    boost::dynamic_bitset<> show_items(list.get_item_count(), true);
20160928 21:50:25< Nobun> source --> http://en.cppreference.com/w/cpp/language/types
20160928 21:50:31< celmin> I did specifically change uses of the fill constructor to default-construct plus resize in many cases.
20160928 21:51:01< celmin> Nobun: sizeof would not return 1 for every type in that case. :P Only for every integral type.
20160928 21:51:01< shadowm> And it still looks like that as of aae20e7c0c8e.
20160928 21:51:20< celmin> shadowm: Yeah okay, looks like I didn't just miss one… :/
20160928 21:51:28< shadowm> Unit recall too.
20160928 21:52:20< Nobun> celmin: thank. I don't know those advanced expects. Usually I use sizeof in very rare cases
20160928 21:54:07< shadowm> I wouldn't say that type sizes are a particularly advanced aspect of C++ given that the language is essentially built upon leaky abstractions.
20160928 21:54:30< shadowm> Sooner or later you'll need to know your sizes, whether it be for debugging or optimizing.
20160928 21:55:12< shadowm> (Or just plain figuring out why your code triggers unexpected warnings or errors depending on platform/compiler combinations.)
20160928 21:56:35< shadowm> Plus it's not exactly uncommon to have to communicate with C libraries that want sized buffers passed around.
20160928 21:57:15< Nobun> shadowm: I am a noob programmer, after all :P I used sizeof only in past when, before learning vectors, I used malloc/realloc for dinamic data structures
20160928 21:57:24< celmin> Why does Wesnoth always seem to explicitly default-initialize everything in the constructor initialization lists?
20160928 21:57:40< shadowm> We've been over this before, celmin. :p
20160928 21:57:44< celmin> Have we?
20160928 21:57:48< celmin> Blargh.
20160928 21:58:05< shadowm> <shadowm> something something and this is why we should have the compiler warn us about missing members in initialization lists
20160928 21:59:22< celmin> I'd rather it only warn about missing members of primitive type...
20160928 21:59:38< shadowm> Ah yes: 69332b14ec2b8e37597840e3c1b776d7b831d767
20160928 21:59:41< celmin> Or at least, cases where it's not implicitly default-initialized.
20160928 21:59:44< celmin> What?
20160928 21:59:53< shadowm> This commit actually removed non-deterministic behavior from the xBRZ scaler.
20160928 22:00:08< shadowm> Which I doubt was intentional in the first place.
20160928 22:00:13< celmin> Yeah.
20160928 22:00:36-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160928 22:00:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160928 22:11:47-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160928 22:14:34-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 22:22:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160928 22:25:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160928 22:27:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20160928 22:50:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20160928 22:51:22-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 22:51:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20160928 22:53:24-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160928 23:13:55-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Quit: Disconnecting from stoned server.]
20160928 23:14:10-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160928 23:19:35-!- gfgtdf [~chatzilla@x4e36a0c0.dyn.telefonica.de] has joined #wesnoth-dev
20160928 23:23:24-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160928 23:29:58-!- Nobun [~nobun@5.170.110.74] has quit [Quit: Salve a tutti]
20160928 23:30:12< celticminstrel> So, in src/gui/dialogs/addon/filter_options.hpp
20160928 23:30:22< celticminstrel> There is an array<bool, ADDON_TYPES_COUNT>
20160928 23:30:27-!- ancestral [~ancestral@63.92.240.233] has joined #wesnoth-dev
20160928 23:30:37< celticminstrel> But the associated getter/setter works with bitsets.
20160928 23:30:54< celticminstrel> Is there any reason to not change the entire thing to just use a regular (non-dynamic) bitset?
20160928 23:32:55< celticminstrel> I dunno, maybe there's a very good reason.
20160928 23:37:20< gfgtdf> celticminstrel: i thought you were the one that made the gettes/settes use bitsets?
20160928 23:38:24< celticminstrel> gfgtdf: No, they already used bitsets (in the form of vector<bool>)
20160928 23:40:16< gfgtdf> celticminstrel: i thought you were the one that made it use std::array? :P
20160928 23:40:59< celticminstrel> I don't think so? Pretty sure I haven't touched that code in any meaningful way.
20160928 23:42:23< gfgtdf> celticminstrel: hmm yes was a joke, you chaged that code from boost:array to std::array.
20160928 23:42:48< celticminstrel> Did I? Okay then. Still doesn't count though. :P
20160928 23:43:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160928 23:44:03-!- ancestral [~ancestral@63.92.240.233] has quit [Quit: i go nstuf kthxbai]
20160928 23:45:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160928 23:48:10< irker946> wesnoth: Celtic Minstrel wesnoth:master 4488e35706ae / src/ (gui/dialogs/unit_create.cpp gui/dialogs/unit_recall.cpp whiteboard/manager.cpp): Fixup some overlooked semantic changes from fe08701b7ca3639b17dca20023d2bb344330 https://github.com/wesnoth/wesnoth/commit/4488e35706ae3f815e868174b75a4e3a7e9043cf
20160928 23:59:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
--- Log closed Thu Sep 29 00:00:13 2016