--- Log opened Thu Sep 29 00:00:13 2016
20160929 00:16:04-!- atarocch [~atarocch@88.131.217.34] has quit [Remote host closed the connection]
20160929 00:28:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 00:32:04-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Read error: error:1408F10B:SSL routines:SSL3_GET_RECORD:wrong version number]
20160929 00:32:28-!- shadowm [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20160929 00:43:22-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 00:45:05-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 00:48:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160929 00:48:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160929 00:48:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 00:49:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160929 00:50:00-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160929 00:54:07-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 01:20:35-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160929 01:25:19-!- gfgtdf [~chatzilla@x4e36a0c0.dyn.telefonica.de] has quit [Ping timeout: 272 seconds]
20160929 01:25:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160929 01:26:42-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20160929 01:26:42-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20160929 01:26:42-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 01:29:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20160929 01:29:01-!- noy_ is now known as noy
20160929 01:45:22< wedge009> Espreon: Mainly work on Windows, but I'll see what I can find on Linux. Might be tricky as I mainly use KDE/Qt-based stuff.
20160929 01:45:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160929 01:46:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 01:58:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160929 02:01:24-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 02:08:11-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160929 02:08:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 02:08:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160929 02:09:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 02:15:46< vultraz> ughh
20160929 02:16:07< vultraz> cannot figure out how to make the two connect engine instances sync up :|
20160929 02:16:19< vultraz> the host sees player 2 join
20160929 02:16:35-!- Jetrel_ [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has quit [Quit: "The highest possible stage in moral culture is when we recognize that we ought to control our thoughts." - Charles Darwin]
20160929 02:16:44< vultraz> they get listed in the player list
20160929 02:16:55< celticminstrel> BTW if you missed it the addons manager was fixed.
20160929 02:17:00< vultraz> and one of the controller selections get set to them...
20160929 02:17:12< vultraz> celticminstrel: i know, yes
20160929 02:17:12< celticminstrel> Also unit create and unit recall and something in the whiteboard.
20160929 02:17:35< vultraz> good, good
20160929 02:17:54-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20160929 02:17:56< celticminstrel> I never actually checked that they were broken, but I assume they were.
20160929 02:20:47< vultraz> hmmm hm hm hm
20160929 02:21:14< vultraz> ok, so every member of the side_engines_ vector keeps a reference to the parent connect_engine...
20160929 02:21:46< vultraz> but this doesn't do me any good, since it's populated with *this in the connect_engine constructor... 
20160929 02:22:31< celticminstrel> What is the relevance of this to the problem? For that matter, what actually is the problem?
20160929 02:22:54< vultraz> the problem is that in the gui1 dialog, Mp Wait was basically a display-only screen
20160929 02:23:04< vultraz> it received data from the network and displayed it.
20160929 02:23:22< vultraz> but now, if i want to use the same dialog (mp staging) for both the players and the host,
20160929 02:23:34< vultraz> every player gets a connect_engine instance
20160929 02:23:47< vultraz> and I have to figure out how to make them all sync up
20160929 02:24:07< celticminstrel> Maybe you could make the connect_engine instance optional - only the host gets one.
20160929 02:24:22< vultraz> but the entire dialog relies on it
20160929 02:24:27< Aginor> do you need to sync them across the network?
20160929 02:24:35< vultraz> obviously
20160929 02:24:51< vultraz> or else no one will ever see anyone's changes
20160929 02:25:14< vultraz> the idea here is to allow the host to modify all sides, but players can modify settings about their assigned sides
20160929 02:26:06< Aginor> make sure to validate input properly as it's received across the network
20160929 02:26:19< Aginor> what's the distribution model?
20160929 02:26:26< Aginor> client->server->all?
20160929 02:26:36< celticminstrel> I think so.
20160929 02:28:16< vultraz> right now the code is very inefficient 
20160929 02:28:57< vultraz> and actually my code is even more inefficient since I send changes in widget callbacks instead of batch after evaluating every widget for differences as the old dialog did..
20160929 02:29:01< celticminstrel> Basically anytime anyone changes a setting you need to send it to the server.
20160929 02:29:16< vultraz> and 'sending changes' means regenerating the config of every single side and sending it over the server
20160929 02:29:19< celticminstrel> And you need to parse data from the server to determine what needs to be updated.
20160929 02:29:44< vultraz> no matter if you change a setting on just one side, every side is sent.
20160929 02:30:07< celticminstrel> Sounds like you might want to do some server-side work here. :P 
20160929 02:31:12< vultraz> optimally, there would only be one connect_engine run on the server, with clients responsible for fetching data and sending changes for the engine to parse and the server to relay to all clients
20160929 02:31:24< vultraz> (I hope that's not the MVC model)
20160929 02:31:41< celticminstrel> Does the server even know anything about connect_engines?
20160929 02:31:57< celticminstrel> That does sound vaguely like the MVC model.
20160929 02:32:00< celticminstrel> Not sure though.
20160929 02:32:10< vultraz> the server is essentially a dumb pipe
20160929 02:32:15< vultraz> as far as i can tell
20160929 02:32:18< vultraz> it funnels configs to people
20160929 02:32:41< celticminstrel> Does it funnel any data sent to it or only recognized tags?
20160929 02:32:51< vultraz> anything, I guess
20160929 02:33:09< vultraz> every client is responsible for dealing with that data
20160929 02:33:23< vultraz> I have said before, this isn't an optimal model 
20160929 02:33:55< celticminstrel> And how does it know who to send the data to?
20160929 02:34:07< vultraz> I don't know
20160929 02:34:38< celticminstrel> Well anyway, if what you say is true, just send and process diffs or similar instead of the whole config.
20160929 02:34:51< vultraz> yeah, sure
20160929 02:34:53< vultraz> fine
20160929 02:34:57< celticminstrel> (Though maybe get it working first.)
20160929 02:35:00< vultraz> but first I need to actually get it to 
20160929 02:35:02< vultraz> yes
20160929 02:35:03< vultraz> work :|
20160929 02:35:24< celticminstrel> So what exactly is the problem?
20160929 02:35:48< vultraz> let me push and you can see
20160929 02:37:45< irker946> wesnoth: Charles Dang wesnoth:master 75636ee17cf2 / / (4 files in 3 dirs): MP Staging: some progress with getting the network processing working, as well a https://github.com/wesnoth/wesnoth/commit/75636ee17cf21c5a4d97bef0a5b298d0c7def8d3
20160929 02:38:27< vultraz> essentially, the host 'sees' the new player, but no changes to the settings on either side reflect
20160929 02:38:33< vultraz> I did get chat working, though :P
20160929 02:38:58< Aginor> the server needs to be responsible for coordinating the changes across the estate, handling conflicts and sending the appropriate events to all clients
20160929 02:39:12< vultraz> yeah, well, our server is dumb
20160929 02:39:20< vultraz> it does not run a game core instance.
20160929 02:39:20< Aginor> some of these events could/should be the update events for when state changes
20160929 02:39:28< Aginor> so?
20160929 02:39:46< celticminstrel> It doesn't need a game core instance for what Aginor describes.
20160929 02:40:25< vultraz> well then someone direct me how to make this happen, since I do not understand networking :|
20160929 02:40:43< vultraz> (I've been trying to ask gfgtdf for help but I guess he's busy or something)
20160929 02:41:46< Aginor> this has nothing to do with networking
20160929 02:42:08< Aginor> this is just a distributed problem where you need multiple nodes agreeing on a state
20160929 02:42:29< vultraz> Ok, sure. But I still need help :|
20160929 02:42:39< Aginor> network just happens to be your medium in this instance ;)
20160929 02:43:05< vultraz> Network or not, I'm still confused and need assistance to get this working :|
20160929 02:44:47< Aginor> I'd offer, but I don't have time at the moment :/
20160929 02:44:54< celticminstrel> I have no idea what the code you pushed is doing or where in it the problem lies.
20160929 02:45:24< celticminstrel> But my first impression from what you describe is... are you actually processing the updates?
20160929 02:45:44< celticminstrel> And sending them, for that matter.
20160929 02:45:55< vultraz> I essentially copied the initial receive code from the mp wait 'dialog'
20160929 02:46:00< vultraz> and yes, I'm sending them
20160929 02:46:15< vultraz> and every instance is supposed to receive them on a timer.
20160929 02:46:24< celticminstrel> "initial receive code"?
20160929 02:46:34< celticminstrel> I still think the use of timers for this is a bit silly.
20160929 02:46:47< vultraz> god dammit :|
20160929 02:46:53< vultraz> *then what is a better solution*
20160929 02:47:07< celticminstrel> wesnothd_connection should offer something like a set_receive_callback() function to set a function to process data when it arrives.
20160929 02:47:12 * Aginor frowns
20160929 02:47:15< Aginor> timers?
20160929 02:47:29< celticminstrel> (And it would be set to nullptr in post_show, probably.)
20160929 02:47:29< vultraz> yes, I use a timer to poll for updates every 4 seconds
20160929 02:47:31< vultraz> like the lobby
20160929 02:47:38< Aginor> from the server?
20160929 02:47:41< celticminstrel> Yes.
20160929 02:47:43< vultraz> yes
20160929 02:47:50< vultraz> because no one is offering a better solution!
20160929 02:47:53< vultraz> what celticminstrel would be good
20160929 02:47:54< Aginor> so it's sitting int he OS network stack for that long?
20160929 02:47:57< celticminstrel> As far as I know, he wasn't the one who did this in the lobby initially.
20160929 02:48:03< celticminstrel> Aginor: Yes.
20160929 02:48:10< Aginor> that's not ideal :/
20160929 02:48:14< celticminstrel> Yes.
20160929 02:48:28< vultraz> but using celticminstrel's paradigm for the lobby could be problematic 
20160929 02:48:46< vultraz> because if we have, say 200 games updating at once..
20160929 02:48:49< celticminstrel> I don't know exactly how Boost.Asio works for setting callbacks like that.
20160929 02:48:53< Aginor> I'd suggest spawning of a thread to deal with the network data, and push that somewhere instead
20160929 02:49:08< Aginor> and poll that data on a timer (with appropriate locking)
20160929 02:49:08< vultraz> (though in all seriousness, if we got that many games I'd redesign the lobby to not display active games)
20160929 02:49:24< vultraz> oh god, threading :|
20160929 02:49:27< Aginor> if the server is pushing data to each client, that's a better approach
20160929 02:49:38< Aginor> if we're fetching data, nevermind
20160929 02:49:43< vultraz> I know nothing about threading
20160929 02:49:51< vultraz> I don't even know what a mutex is
20160929 02:49:55< Aginor> (although threading would still be good to avoid locking the UI)
20160929 02:53:00< vultraz> I don't even know if our server supports threading
20160929 02:53:14< celticminstrel> The server is totally irrelevant to this question.
20160929 02:54:11< vultraz> maybe some of the iffyness is caused because i call level_to_gamestate...
20160929 02:54:20< vultraz> before, that was only called when entering the game..
20160929 02:54:26< vultraz> could explain a few things
20160929 02:54:33< vultraz> but not why nothing updates
20160929 02:57:02< vultraz> but I need to call level_to_gamestate or else i can't create the connect_engine
20160929 02:57:03< vultraz> :|
20160929 02:57:24 * vultraz rubs eyes
20160929 03:03:09-!- travis-ci [~travis-ci@ec2-54-158-100-125.compute-1.amazonaws.com] has joined #wesnoth-dev
20160929 03:03:10< travis-ci> wesnoth/wesnoth#11225 (master - 75636ee : Charles Dang): The build was broken.
20160929 03:03:10< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/163600448
20160929 03:03:10-!- travis-ci [~travis-ci@ec2-54-158-100-125.compute-1.amazonaws.com] has left #wesnoth-dev []
20160929 03:05:00< celticminstrel> Did you perchance forget to commit something?
20160929 03:05:40< vultraz> what?
20160929 03:06:13< celticminstrel> Or is your build currently broken?
20160929 03:06:24< celticminstrel> The error is that some member is private.
20160929 03:08:08< vultraz> oh that..
20160929 03:08:37< vultraz> really don't know if that line is needed
20160929 03:09:21< irker946> wesnoth: Charles Dang wesnoth:master 090f695c0349 / src/game_initialization/connect_engine.hpp: Made connect_engine::receive_from_server public https://github.com/wesnoth/wesnoth/commit/090f695c0349e8b2d1d6171f31dbe28d87e167f2
20160929 03:09:23< vultraz> so ill just commit that for now 
20160929 03:09:27< vultraz> forgot i was using that
20160929 03:09:53< celticminstrel> Kinda surprised it builds for you if it was private...
20160929 03:10:57< vultraz> because it was public in my working copy :p
20160929 03:11:13< celticminstrel> Then, why didn't you commit that?
20160929 03:12:31< vultraz> because i had changed a case where i used it and forgot there was another
20160929 03:38:10-!- JyrkiVesterinen [~JyrkiVest@87-100-212-53.bb.dnainternet.fi] has joined #wesnoth-dev
20160929 03:45:15-!- Ivanovic_ [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160929 03:47:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 272 seconds]
20160929 03:47:49-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20160929 03:49:08-!- Ivanovic_ is now known as Ivanovic
20160929 03:49:30-!- travis-ci [~travis-ci@ec2-54-145-184-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20160929 03:49:31< travis-ci> wesnoth/wesnoth#11226 (master - 090f695 : Charles Dang): The build has errored.
20160929 03:49:31< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/163604495
20160929 03:49:31-!- travis-ci [~travis-ci@ec2-54-145-184-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20160929 03:50:21-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160929 03:50:21-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160929 03:50:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160929 04:04:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 272 seconds]
20160929 04:06:55-!- Kwandulin [~Miranda@p200300760F2C71BF35842A3DDAEDDFF7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160929 04:12:46-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 04:14:25-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160929 04:14:26-!- wedge010 is now known as wedge009
20160929 04:39:01-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Ping timeout: 240 seconds]
20160929 04:40:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160929 04:47:00-!- JyrkiVesterinen [~JyrkiVest@87-100-212-53.bb.dnainternet.fi] has quit [Quit: .]
20160929 04:58:44-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20160929 04:59:37< irker946> wesnoth: Zheng Lv wesnoth:master 5ed58a9aea26 / src/addon/info.hpp: include ctime header for time_t https://github.com/wesnoth/wesnoth/commit/5ed58a9aea265d6291b94333ee04d5a6fb7eeb79
20160929 04:59:39< irker946> wesnoth: Celtic Minstrel wesnoth:master bbdb7fab38fc / src/addon/info.hpp: Merge pull request #805 from lv-zheng/fix_time_t https://github.com/wesnoth/wesnoth/commit/bbdb7fab38fc11cf13414c0672d0bcd6dbb1bf05
20160929 05:01:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 264 seconds]
20160929 05:20:26-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160929 05:20:26-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160929 05:33:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 05:37:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160929 05:53:09-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has quit [Changing host]
20160929 05:53:09-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20160929 05:59:22-!- travis-ci [~travis-ci@ec2-54-158-100-125.compute-1.amazonaws.com] has joined #wesnoth-dev
20160929 05:59:23< travis-ci> wesnoth/wesnoth#11228 (master - bbdb7fa : Celtic Minstrel): The build passed.
20160929 05:59:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/163615112
20160929 05:59:23-!- travis-ci [~travis-ci@ec2-54-158-100-125.compute-1.amazonaws.com] has left #wesnoth-dev []
20160929 06:11:17-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160929 06:19:54-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160929 06:27:51-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160929 06:36:34-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 06:49:36-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160929 06:54:17-!- Kwandulin_2 [~Miranda@p200300760F2C71DD35842A3DDAEDDFF7.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160929 06:54:48-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Quit: Leaving]
20160929 06:55:55-!- Kwandulin [~Miranda@p200300760F2C71BF35842A3DDAEDDFF7.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20160929 06:56:06-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160929 07:21:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 07:26:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160929 07:29:52< irker946> wesnoth: ln-zookeeper wesnoth:master 9dbb917b7b69 / data/lua/wml-tags.lua: Fixed bug #25131: [move_unit] check_passability=no doesn't work https://github.com/wesnoth/wesnoth/commit/9dbb917b7b695fd2796eaebd0dacfe6616ba7974
20160929 07:31:17-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has joined #wesnoth-dev
20160929 08:08:18-!- Kwandulin_2 [~Miranda@p200300760F2C71DD35842A3DDAEDDFF7.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160929 08:22:31-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20160929 08:22:38-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20160929 08:22:38-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160929 08:22:44< zookeeper> whoops... https://github.com/wesnoth/wesnoth/commit/7778e6f45c0e0bb7d19075b9a0ab15463b183a74#diff-2390c9a2a9647b8ee3735a55d78df204R229
20160929 08:24:05< irker946> wesnoth: ln-zookeeper wesnoth:master b2d054253fa8 / data/campaigns/Heir_To_The_Throne/scenarios/24_Battle_for_Wesnoth.cfg: Fixed broken start event https://github.com/wesnoth/wesnoth/commit/b2d054253fa8d520cafbbb35bfc9315d242b0503
20160929 08:37:21-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has quit [Ping timeout: 276 seconds]
20160929 08:38:11-!- Kwandulin [~Miranda@p200300760F2C71DD193D0F869830D5A0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160929 08:38:55-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has joined #wesnoth-dev
20160929 08:52:33-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160929 08:52:57-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:53:20-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 08:53:48-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:54:08-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 08:54:38-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:54:56-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 08:55:30-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:55:44-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 08:56:20-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:56:32-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 08:57:05-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:57:20-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 08:57:50-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 08:58:08-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Client Quit]
20160929 09:00:19< vultraz> ok, I think i know part of
20160929 09:00:21< vultraz> the problem here
20160929 09:00:44< vultraz> the side_engine isn't actually updated
20160929 09:00:50< vultraz> for the client instance
20160929 09:05:58-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160929 09:08:22< vultraz> but how would one best do this
20160929 09:10:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 09:14:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20160929 09:14:49< vultraz> ok, so, change happens, a config diff is sent to the network..
20160929 09:15:06< vultraz> it's received...
20160929 09:15:12< vultraz> but not handled..
20160929 09:15:40< vultraz> ok, that might be the thing
20160929 09:16:38< vultraz> hmmmmmmmmmmm
20160929 09:23:34-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160929 09:26:54-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160929 09:33:22< Kwandulin> Is there a way to increase the unit's level via [advancement]? I'd imagine an [effect] that affects it might do good
20160929 09:44:38< zookeeper> i don't know whether direct variable manipulation of unit.level works, but that seems like the only current possibility.
20160929 10:00:21-!- Appleman1234 [~Appleman1@KD119104045244.au-net.ne.jp] has quit [Ping timeout: 240 seconds]
20160929 10:03:09-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160929 10:08:01-!- Appleman1234 [~Appleman1@KD119104043066.au-net.ne.jp] has joined #wesnoth-dev
20160929 10:30:14-!- RatArmy [~RatArmy@om126161112041.8.openmobile.ne.jp] has joined #wesnoth-dev
20160929 10:35:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160929 10:35:27-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20160929 10:42:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160929 10:49:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160929 10:50:37-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160929 10:58:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 11:02:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160929 11:17:09-!- louis94 [~~louis94@91.178.242.249] has quit [Ping timeout: 244 seconds]
20160929 11:24:25-!- irker946 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160929 11:41:01-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has quit [Ping timeout: 240 seconds]
20160929 11:49:25-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160929 11:54:48-!- RatArmy [~RatArmy@om126161112041.8.openmobile.ne.jp] has quit [Quit: Leaving]
20160929 12:14:19-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160929 12:22:49-!- Bonobo [~Bonobo@2001:44b8:254:3200:6c2d:bb40:fceb:98d9] has quit [Quit: Leaving]
20160929 12:27:20-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160929 12:45:00-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has joined #wesnoth-dev
20160929 12:45:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 12:50:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20160929 13:02:30-!- Kwandulin [~Miranda@p200300760F2C71DD193D0F869830D5A0.dip0.t-ipconnect.de] has quit [Quit: Kwandulin]
20160929 13:40:47-!- louis94 [~~louis94@91.178.242.249] has quit [Ping timeout: 244 seconds]
20160929 13:53:03-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: JyrkiVesterinen]
20160929 14:09:40-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 14:11:38-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160929 14:13:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160929 14:13:34-!- wedge010 is now known as wedge009
20160929 14:20:27-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160929 14:24:05-!- irker462 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160929 14:24:05< irker462> wesnoth: Celtic Minstrel wesnoth:master b563d8d8cddb / data/lua/wml-tags.lua: Put fixed passability check on separate line https://github.com/wesnoth/wesnoth/commit/b563d8d8cddbab5185c9e0466accd1f9a6e915cd
20160929 14:27:53-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Remote host closed the connection]
20160929 14:29:28-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160929 14:57:53-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 15:01:37-!- gfgtdf [~chatzilla@x4e363304.dyn.telefonica.de] has joined #wesnoth-dev
20160929 15:04:39-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 15:11:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160929 15:12:35-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 15:12:45-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160929 15:13:02< celticminstrel> INSTALL seems to be skewed towards Linux users, is that desirable?
20160929 15:13:50< matthiaskrgr> as a linux user: yes 
20160929 15:13:52-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160929 15:13:54< matthiaskrgr> :p
20160929 15:15:00< celticminstrel> BTW matthiaskrgr, are you in the credits yet?
20160929 15:15:08< matthiaskrgr> altough I would say it is not that likely that a windows user tries to compile and build a package from source 
20160929 15:15:11< matthiaskrgr> uh
20160929 15:15:53< matthiaskrgr> I don't know :) 
20160929 15:16:09< matthiaskrgr> you mean because of the unused variable I removed? xD
20160929 15:16:31< celticminstrel> Well, that, but also running the sanitizer counts in my personal opinion.
20160929 15:16:35< matthiaskrgr> ah :)
20160929 15:16:46< celticminstrel> I'm asking because there are a couple "Matthias" in the credits.
20160929 15:17:13< celticminstrel> And I have no idea in particular who "Matthias Kretz" is.
20160929 15:17:22< matthiaskrgr> thats not me :) 
20160929 15:17:25< celticminstrel> Okay.
20160929 15:17:35< matthiaskrgr> where's the credit file?
20160929 15:18:00< celticminstrel> about.cfg
20160929 15:18:08< celticminstrel> In data/core
20160929 15:18:10< matthiaskrgr> ah
20160929 15:19:10< matthiaskrgr> looks like I'm not in there
20160929 15:21:32< matthiaskrgr> there should be a way to stop the credits and enable manuall scrolling :/
20160929 15:21:39< matthiaskrgr> stop == stop automatic scrolling
20160929 15:21:56< celticminstrel> Technically, manual scrolling does work. >_> Though doesn't prevent auto-scrolling.
20160929 15:22:34-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 244 seconds]
20160929 15:22:49< matthiaskrgr> well, yes :P 
20160929 15:23:04< celticminstrel> In the GUI1 version that was not the case.
20160929 15:23:25< matthiaskrgr> lol
20160929 15:23:46< matthiaskrgr> the credits slow extremely slow when I just hold down the ↓ buttin
20160929 15:24:43-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160929 15:25:32< celticminstrel> Does anyone thing we should consider splitting about.cfg into multiple files?
20160929 15:25:36< celticminstrel> ^think
20160929 15:25:48< irker462> wesnoth: Celtic Minstrel wesnoth:master d944f41b0ea3 / src/scripting/lua_unit_type.cpp: Enable #wesnoth.unit_types and #wesnoth.unit_types[type].variations https://github.com/wesnoth/wesnoth/commit/d944f41b0ea3e9b80a9d7759a778399c5e515c12
20160929 15:25:50< irker462> wesnoth: Celtic Minstrel wesnoth:master c5ce248f5469 / data/core/about.cfg host.lua join.lua src/events.cpp src/playturn.cpp: Update credits listing https://github.com/wesnoth/wesnoth/commit/c5ce248f54695316d4603c18b7e5e485b2564d24
20160929 15:25:52< irker462> wesnoth: Celtic Minstrel wesnoth:master 1fabd6f23e6c / INSTALL: Update INSTALL https://github.com/wesnoth/wesnoth/commit/1fabd6f23e6c466b89249d398483462a17355d1e
20160929 15:25:54< irker462> wesnoth: Celtic Minstrel wesnoth:master 57ff44316e64 / changelog: Update changelog https://github.com/wesnoth/wesnoth/commit/57ff44316e6423ea485b32f67f2108b10f268a30
20160929 15:27:58< zookeeper> celticminstrel, ...why would anyone want to?
20160929 15:31:41< zookeeper> well, i mean sure i can see why someone might want to consider it
20160929 15:31:51< zookeeper> but i don't see why they'd reach the conclusion that splitting it would bring any benefit
20160929 15:32:46< celticminstrel> zookeeper: Only because it's a huge file in which it can be hard to find a specific section.
20160929 15:33:13< zookeeper> i've never found it hard
20160929 15:34:42< zookeeper> i always find big files tremendously more convenient than several smaller files, as long as the bulk of the contents follows a simple pattern instead of being random stuff thrown together
20160929 15:35:16< celticminstrel> Hmm, I need ancestral now.
20160929 15:36:33< zookeeper> if i need to find the indonesian translation, that's ctrl-f indon<enter> and there i am, takes about 2 seconds
20160929 15:38:34-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Remote host closed the connection]
20160929 15:41:39< irker462> wesnoth: Celtic Minstrel wesnoth:master 357047db7864 / projectfiles/Xcode/readme.md: Update XCode readme https://github.com/wesnoth/wesnoth/commit/357047db78646447d5de3dae94f59bb7960455c2
20160929 15:41:41-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Ping timeout: 240 seconds]
20160929 15:42:07< celticminstrel> Probably should've put [skip ci] in that, oh well.
20160929 15:42:19< celticminstrel> Or was it [ci skip]...
20160929 15:42:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 15:43:08 * celticminstrel isn't actually sure if the XCode project currently needs files added...
20160929 15:43:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160929 15:43:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 15:59:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 16:06:50-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160929 16:08:05-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 16:12:20-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 16:12:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 244 seconds]
20160929 16:16:49-!- atarocch [~atarocch@88.131.217.34] has joined #wesnoth-dev
20160929 16:17:33-!- boucman_work [~boucman@209.57.66.86.rev.sfr.net] has quit [Ping timeout: 276 seconds]
20160929 16:27:13< matthiaskrgr> it's [ci skip], yes
20160929 16:38:15-!- JyrkiVesterinen [~JyrkiVest@87-92-20-31.bb.dnainternet.fi] has joined #wesnoth-dev
20160929 16:48:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 16:50:19-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160929 16:50:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 16:52:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160929 16:55:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 17:00:13-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160929 17:00:34-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20160929 17:01:11-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160929 17:16:14-!- gfgtdf [~chatzilla@x4e363304.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160929 17:17:52-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160929 17:19:04-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160929 17:19:04-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160929 17:39:32-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.2 Aria]
20160929 17:41:55-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160929 17:48:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160929 17:59:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 18:00:24-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20160929 18:10:06-!- louis94 [~~louis94@91.178.242.249] has quit [Ping timeout: 264 seconds]
20160929 18:15:09-!- mjs-de [~mjs-de@x4db634cf.dyn.telefonica.de] has joined #wesnoth-dev
20160929 18:26:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160929 18:42:35-!- irker462 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160929 18:42:42-!- irker196 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160929 18:42:42< irker196> wesnoth: Celtic Minstrel wesnoth:master a8aa38277e41 / host.lua join.lua src/events.cpp src/playturn.cpp: Revert accidentally-committed code in c5ce248f54695316d4603c18b7e5e485b2564d24. https://github.com/wesnoth/wesnoth/commit/a8aa38277e4128def2da0d8359ff8b5cc4868a17
20160929 18:47:46-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 18:59:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160929 19:00:03-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160929 19:01:04-!- JyrkiVesterinen [~JyrkiVest@87-92-20-31.bb.dnainternet.fi] has quit [Quit: .]
20160929 19:14:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 19:15:45-!- louis94 [~~louis94@91.178.242.249] has joined #wesnoth-dev
20160929 19:27:14-!- Nobun [~nobun@5.170.111.40] has joined #wesnoth-dev
20160929 19:36:16-!- mjs-de [~mjs-de@x4db634cf.dyn.telefonica.de] has quit [Remote host closed the connection]
20160929 19:38:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 19:43:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160929 19:48:04< bumbadadabum> maybe we should change the topic to say who won the wesnoth inc elections, and not the thread linkk
20160929 19:48:07< bumbadadabum> *link
20160929 19:48:32< celticminstrel> Whatever.
20160929 19:48:54< celticminstrel> I'm not sure the topic really needs to document the results, but if you think it's a good idea...
20160929 19:51:18< zookeeper> no, there's no reason to name the "winners" in the channel topic.
20160929 19:53:35-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160929 19:56:49-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 19:57:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160929 19:57:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160929 20:00:53< Nobun> Only becouse I'm curious... I don't understand what is it? The election I mean...
20160929 20:01:52< shadowm> It's old news already, why even keep the link in the topic?
20160929 20:02:03< celticminstrel> Because no-one has bothered to remove it yet?
20160929 20:02:28< shadowm> As if that would be hard work.
20160929 20:02:42-!- shadowm changed the topic of #wesnoth-dev to: 1.13.6 planned for mid-October | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20160929 20:02:50< shadowm> Less than 15 seconds.
20160929 20:02:58-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160929 20:03:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 272 seconds]
20160929 20:04:01< celticminstrel> Yup.
20160929 20:04:45-!- Samual [~Samual@2601:547:1000:86f:edcf:f111:cc48:458b] has joined #wesnoth-dev
20160929 20:04:45-!- Samual [~Samual@2601:547:1000:86f:edcf:f111:cc48:458b] has quit [Changing host]
20160929 20:04:45-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 20:14:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 20:23:25-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 20:25:45-!- Samual [~Samual@2601:547:1000:86f:edcf:f111:cc48:458b] has joined #wesnoth-dev
20160929 20:25:45-!- Samual [~Samual@2601:547:1000:86f:edcf:f111:cc48:458b] has quit [Changing host]
20160929 20:25:45-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 20:33:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20160929 20:34:04-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 20:48:41-!- DeFender [~DeFender1@89-138-252-80.bb.netvision.net.il] has quit [Read error: Connection reset by peer]
20160929 20:48:41-!- DeFender [~DeFender1@89-138-252-80.bb.netvision.net.il] has joined #wesnoth-dev
20160929 20:56:21-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 20:58:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160929 20:59:56-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 21:00:59-!- louis94 [~~louis94@91.178.242.249] has quit [Ping timeout: 244 seconds]
20160929 21:05:13-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 21:05:32-!- DeFender [~DeFender1@89-138-252-80.bb.netvision.net.il] has quit [Remote host closed the connection]
20160929 21:05:52-!- DeFender [~DeFender1@89-138-252-80.bb.netvision.net.il] has joined #wesnoth-dev
20160929 21:10:17-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 21:12:35-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160929 21:17:53-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 21:19:48-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 21:27:23-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 21:27:49-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 21:41:19-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160929 21:41:59-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160929 21:42:47-!- irker196 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160929 21:48:51-!- Nobun [~nobun@5.170.111.40] has quit [Quit: Salve a tutti]
20160929 21:51:51-!- stikonas_ is now known as stikonas
20160929 21:58:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 21:58:58-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20160929 22:00:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20160929 22:05:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160929 22:08:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160929 22:31:20-!- noy_ [~Noy@24.244.32.231] has joined #wesnoth-dev
20160929 22:31:20-!- noy_ [~Noy@24.244.32.231] has quit [Changing host]
20160929 22:31:20-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160929 22:33:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 272 seconds]
20160929 22:33:54-!- noy_ is now known as noy
20160929 22:52:46-!- enchi_ is now known as enchi
20160929 22:58:45-!- celmin [~celticmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160929 22:59:34-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160929 23:01:14< vultraz> ancestral: thou must fix your connection
20160929 23:02:12< ancestral> Not sure what my computer was doing. App updates?
20160929 23:02:40< ancestral> I suppose I’ll try quitting my client at the end of the night
20160929 23:20:03-!- gfgtdf [~chatzilla@x4e363304.dyn.telefonica.de] has joined #wesnoth-dev
20160929 23:21:14< vultraz> celticminstrel: I think i figured out what's wrong with the dialog
20160929 23:21:27< vultraz> so, the connect engine actually sends a config diff to the server
20160929 23:21:56< vultraz> the dialog receives the diff, but the dialog's listbox is generated using the side_engines vector
20160929 23:22:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 272 seconds]
20160929 23:22:13< vultraz> so even though the client receives the config diff, the side_engine is never updated 
20160929 23:22:19< vultraz> I'm pondering how best to do so
20160929 23:25:22< vultraz> I already have a unique_ptr outside the dialog scope..
20160929 23:25:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160929 23:26:20< vultraz> perhaps I should just pass the unique_ptr and it's requisite components and reset it every time a config diff comes in
20160929 23:27:39< vultraz> then again, there's an additional facet at play here..
20160929 23:27:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160929 23:27:55< vultraz> I don't actually.. do anything with the received diff :|
20160929 23:28:25< vultraz> so even if I reset the unique_ptr I'd still need to apply the diff first
20160929 23:28:27< vultraz> right?
20160929 23:29:38< vultraz> so, two different things..
20160929 23:30:31< vultraz> ok, so right now I was trying regenerating the side engines in update_and_send_diff...
20160929 23:31:16< vultraz> I guess that might not work, since it would update the engines for the sender and not the clients
20160929 23:31:23< vultraz> so would this need to be done twice?
20160929 23:31:36< vultraz> ie, update the side engines for the sender, 
20160929 23:31:46< vultraz> then apply the diff and update the engines for the clients..?
20160929 23:31:50< vultraz> that sounds reasonable 
20160929 23:31:59< vultraz> gfgtdf: perhaps you could help me out here
20160929 23:32:14-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has joined #wesnoth-dev
20160929 23:34:32< vultraz> (the most optimal solution would be the server running the only connect_engine instance and dispensing config diffs to all clients)
20160929 23:34:46< celmin> Oh hey, I was pinged.
20160929 23:34:58-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160929 23:35:22< vultraz> (I wonder how hard that would be to implement, actually...)
20160929 23:35:26< celmin> I don't see why "how to apply the diff" is such a huge issue...
20160929 23:36:35< celmin> Also when you say you have a unique_ptr I have no idea what you're talking about. (A unique_ptr to… what exactly?)
20160929 23:38:08< vultraz> celmin: so, I was trying to apply the config diff here: https://github.com/wesnoth/wesnoth/blob/master/src/game_initialization/connect_engine.cpp#L357 level_.apply_diff(dst.child("scenario_diff"), false);, but for some reason it tells me passing a cost config as 'this' violates qualifiers even though level_ is not const :|
20160929 23:38:20< vultraz> (though I dunno if that;s the best place to apply it anyway)
20160929 23:39:33< celmin> vultraz: "this" is const in that function due to that "const" at the end of the function definition.
20160929 23:39:45< celmin> So remove that and it should work.
20160929 23:39:59< celmin> It doesn't make sense (in my opinion) for receive_from_server to be const, anyway.
20160929 23:39:59< vultraz> oh 
20160929 23:40:03< vultraz> bah!
20160929 23:40:10< vultraz> why didn't I see that :|
20160929 23:40:15< celmin> No idea!
20160929 23:40:40< vultraz> ". (A unique_ptr to… what exactly?)"
20160929 23:40:45< vultraz> the connect_engine
20160929 23:40:54< vultraz> but it's outside the dialog, the dialog simply takes a reference
20160929 23:41:12< celmin> Resetting it whenever the diff comes in feels like a bit much.
20160929 23:41:25< vultraz> yes
20160929 23:41:31< vultraz> so perhaps I'll just update the side engines..
20160929 23:41:45< vultraz> [10:31:35]	vultraz	ie, update the side engines for the sender,
20160929 23:41:46< vultraz> [10:31:45]	vultraz	then apply the diff and update the engines for the clients..?
20160929 23:41:58< celmin> So the side engines are normally generated from level_ or something?
20160929 23:43:17< vultraz> hm
20160929 23:43:20< vultraz> actually, no..
20160929 23:43:27< vultraz> current_config()->child_range("side") in the constructor
20160929 23:43:39< celmin> Is current_config() different from level_?
20160929 23:43:48< vultraz> current_config() returns.. scenario()
20160929 23:44:15< vultraz> scenario() returns the [scenario] or [snapshot] child, as appropriate
20160929 23:44:25< celmin> And is that different from level_?
20160929 23:44:56< vultraz> actually it is
20160929 23:45:01< vultraz> the only time level seems to be used is
20160929 23:45:02< vultraz> level_ = mp::initial_level_config(state_);
20160929 23:45:05< vultraz> in the constructor :|
20160929 23:45:21< celmin> And what's mp::initial_level_config return?
20160929 23:45:27< celmin> (Also is level_ a reference or a value?)
20160929 23:45:37< celmin> (Wait, don't answer that.)
20160929 23:45:45< celmin> (If it was a reference it wouldn't be assigned that way.)
20160929 23:46:12< vultraz> it returns a config
20160929 23:46:18< celmin> Obviously.
20160929 23:47:09< vultraz> seems to return the actual level config generated from the gamestate
20160929 23:47:36< vultraz> level_ is used in update_and_send_diff...
20160929 23:48:02< vultraz> that function calls update_level
20160929 23:48:10< vultraz> which actually pushes back new [side] children
20160929 23:48:19< vultraz> then it generates a config
20160929 23:48:27< vultraz> diff
20160929 23:48:33< vultraz> 	config old_level = level_;
20160929 23:48:34< vultraz> 	update_level();
20160929 23:48:36< vultraz> 	config diff = level_.get_diff(old_level);
20160929 23:48:46< vultraz> in practice, wouldn't this mean the only difference would be in the [side] children?
20160929 23:49:33< celmin> Probably.
20160929 23:49:54-!- atarocch [~atarocch@88.131.217.34] has quit [Remote host closed the connection]
20160929 23:50:36< vultraz> ok, so then we have
20160929 23:50:41< vultraz> 		config scenario_diff;
20160929 23:50:42< vultraz> 		scenario_diff.add_child("scenario_diff", diff);
20160929 23:50:44< vultraz> 		send_to_server(scenario_diff);
20160929 23:51:52< vultraz> (not sure why this doesn't do config diff; diff.add_child("scenario_diff", level_.get_diff(old_level)); in the previous lines but whatever)
20160929 23:52:02< vultraz> anyway, so there's the new level config ..
20160929 23:52:27< vultraz> now this seems an ok place to update the side engines
20160929 23:52:42< vultraz> but wait
20160929 23:52:56< celmin> Isn't that exactly what it does?
20160929 23:53:01< vultraz> the side engines are already updated for the persons *sending* the config
20160929 23:53:38< vultraz> celmin: no, the side engines are in a a vector of pointers with a subclass object for each side.
20160929 23:53:48< vultraz> this deals solely with the config diff for the level
20160929 23:54:09< vultraz> so what I need to do is update the side_engines for the person *receiving* the config diff
20160929 23:54:10< celmin> I was referring to your parenthetical
20160929 23:54:33< vultraz> celmin: no, it creates 2 config objects
20160929 23:54:42< celmin> So does what you posted
20160929 23:54:57< vultraz> yes 
20160929 23:55:39< vultraz> not important now..
20160929 23:55:57< vultraz> so hm...
20160929 23:56:08< vultraz> ok, but this again raises the issue of a race condition..
20160929 23:56:18< celmin> ?
20160929 23:56:18< vultraz> because updates are only polled every 4 seconds
20160929 23:56:46< vultraz> so if 2 clients updated the same side during that time, wouldn't there be 2 config diffs coming in?
20160929 23:57:13< celmin> Worse
20160929 23:57:42< vultraz> worse?
20160929 23:57:48< celmin> (potentially)
20160929 23:57:56< vultraz> what?
20160929 23:58:25< celmin> ...
20160929 23:58:40< celmin> Wait, is it...?
20160929 23:59:00< vultraz> I saw you say "[\0x08](potentially)"
20160929 23:59:06< celmin> ...
--- Log closed Fri Sep 30 00:00:03 2016