--- Log opened Fri Sep 30 00:00:03 2016
--- Day changed Fri Sep 30 2016
20160930 00:00:03< vultraz> what :|
20160930 00:01:14< vultraz> no, seriously, what am I missing
20160930 00:01:41< celmin> I was wondering whether order is guaranteed to be the same on all clients.
20160930 00:01:51< celmin> It's TCP, so it's probably fairly safe.
20160930 00:02:02< vultraz> what was the [\0x08]
20160930 00:02:17< celmin> That's why I ellipsized when I quoted you.
20160930 00:02:29< celmin> ^you quoted me
20160930 00:03:58-!- celmin [~celticmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The minstrel departs, to spread the music to the masses!]
20160930 00:05:13< celticminstrel> Basically my client for some reason decided that my backspace belonged as part of the message. It seems to do that a lot.
20160930 00:11:55< vultraz> perhaps I should just make another dialog
20160930 00:12:11< vultraz> and not use the same interface for clients
20160930 00:13:08< celticminstrel> I dunno. I think it's probably unnecessary, but I'm not sure I really understand the issues you're having.
20160930 00:14:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 00:14:30< vultraz> the biggest is the potential for a race condition 
20160930 00:16:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 00:18:17< gfgtdf> vultraz: you pinged me ?
20160930 00:19:05-!- gfgtdf_ [~chatzilla@x4e363304.dyn.telefonica.de] has joined #wesnoth-dev
20160930 00:19:06< celticminstrel> If you send to server whenever something changes, you can probably avoid using diffs - instead send something like [set_side_attribute]side,attribute,value=2,leader,Elvish Ranger
20160930 00:19:20-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160930 00:19:21< gfgtdf_> vultraz: you pinged me? sry my connection is quite bad recently
20160930 00:19:40< celticminstrel> Then the only potential for conflict is if two people change the same thing at the same time (as opposed to any changes being made at the same time).
20160930 00:19:40< vultraz> gfgtdf_: yeah I was hoping you could advise on the network stuff for mp staging
20160930 00:19:45< vultraz> (see logs above)
20160930 00:19:57< vultraz> celticminstrel: I'd need to not use a timer, then
20160930 00:20:17< celticminstrel> Well, you probably shouldn't use one anyway, like we keep saying...
20160930 00:20:20< Aginor> celticminstrel: if you go down that route you would be better served by defining your event format
20160930 00:20:27< celticminstrel> Aginor: Hmm?
20160930 00:20:42< vultraz> but then there's the connection delay issue
20160930 00:20:59< vultraz> I think at this point, a read-only dialog for MP wait is probably best
20160930 00:21:03< gfgtdf_> vultraz: currently (in the gui2 dialog) only the hosts sends scenario diffs, the other clients send their factiosn changes with tags (note shute how exactly lets call it [change_faction]) that is then sent to the host which sends back the diff
20160930 00:21:15 * celticminstrel might try to remove the timer from the MP lobby somehow.
20160930 00:21:16< Aginor> because you're basically forwarding serialised events, so you should decide what to send and how to deal with the serialisation/deserialisation thereof
20160930 00:21:24< gfgtdf_> vultraz: i think all sides sending diffs woudl be a a bad idea
20160930 00:21:31< vultraz> gfgtdf_: yeah I'm thinking so
20160930 00:21:32< celticminstrel> I'm not sure what Aginor is getting at.
20160930 00:21:48< vultraz> gfgtdf_: so I think I'll just abandon this and make a separate dialog for mp wait.
20160930 00:21:55< Aginor> probably overkill ;)
20160930 00:22:13< vultraz> Aginor: is that to me?
20160930 00:22:14< Aginor> distributed eventing across server and clients
20160930 00:22:29-!- gfgtdf [~chatzilla@x4e363304.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160930 00:22:30-!- gfgtdf_ is now known as gfgtdf
20160930 00:22:33< Aginor> eventing from client-> server-> listeners
20160930 00:22:43< gfgtdf> vultraz: i think it'd be nice if we coudl move most of the mp connect engine stuff liek reolve rnadom etc to the server (wesnothd) but th reason againt is that it also have to work in local mp games where no wesnothd is involved.
20160930 00:22:57< vultraz> true
20160930 00:23:00< gfgtdf> vultraz: so it woudl imply some code dublication
20160930 00:23:30< vultraz> which is why I'm in favor of Anura's gameserver model where there's always a 'server' running even in local mode
20160930 00:23:35< Aginor> gfgtdf: you could use the same classes in both game and server though
20160930 00:24:09< celticminstrel> One thing you could do is have your mp_staging class similar to what it is.
20160930 00:24:19< celticminstrel> But don't register it and don't declare window_id.
20160930 00:24:23< vultraz> it would also mean the server design would have to be re imagined to actually run a game instance 
20160930 00:24:34< celticminstrel> Instead, create two subclasses which are registered as dialogs.
20160930 00:24:50< vultraz> (in nogui mode, of course)
20160930 00:24:55< celticminstrel> I almost did that with the dropdown menu, before realizing that it wouldn't actually fix the underlying issue.
20160930 00:25:33< vultraz> celticminstrel: that doesn't help at all
20160930 00:25:40< celticminstrel> I don't see why not?
20160930 00:25:48< vultraz> mp wait doesn't use a connect engine
20160930 00:26:01< vultraz> this 'other' dialog would function differently
20160930 00:26:19 * celticminstrel sigh whatever
20160930 00:27:01< gfgtdf> vultraz: i think running the game on the server is really nontrivial, specially since this would then also run umc content, which might be malicious or even just badly programmed.
20160930 00:28:01< vultraz> it'd be a huge design change, yes
20160930 00:28:17< vultraz> it would effectively eliminate OOS, though.
20160930 00:28:41< vultraz> but still out of scope of this project
20160930 00:29:10< vultraz> we need to get this finished so we can drop the gui1 versions and release 1.13.6
20160930 00:29:45< celticminstrel> We're not dropping the GUI1 versions for 1.13.6.
20160930 00:29:51< vultraz> why? :|
20160930 00:30:56< celticminstrel> Because we still haven't tested the lobby extensively enough, and because at this rate they'll likely still be buggy. We can probably drop it after 1.13.6.
20160930 00:31:09< celticminstrel> Even immediately after, if you're really that impatient.
20160930 00:31:13< vultraz> it really makes no difference when we drop it since no one uses mp in 1.13
20160930 00:31:46< celticminstrel> "No-one uses it" isn't really a good argument for arbitrarily possibly breaking everything.
20160930 00:31:48< gfgtdf> vultraz: well the clients stil have thir gamestate in what they show and it can stil be OOS if those differer for whatever reason, in order to keep the network traffic low, it migth still  be appropriate to read some data from the clients files.
20160930 00:32:14< vultraz> point taken
20160930 00:32:18< celticminstrel> If it were my decision I probably wouldn't drop the GUI1 versions until the release candidate series at the earliest, and more likely not until after 1.14.
20160930 00:32:46< vultraz> but at *least* I'm making the option default for the release
20160930 00:32:48< gfgtdf> celticminstrel: well we can still use the gui1 lobby with the gui2 mp connect if we know that that one works
20160930 00:32:51< celticminstrel> Sure.
20160930 00:33:05< celticminstrel> gfgtdf: True.
20160930 00:33:08< vultraz> need to figure out how to change people's saved preference at runtime, but only once, though
20160930 00:33:30< celticminstrel> vultraz: I think the easiest way is probably to change the preference key.
20160930 00:33:52< vultraz> hm
20160930 00:33:54< vultraz> yes
20160930 00:33:55< vultraz> good idea
20160930 00:34:25-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160930 00:34:54< vultraz> anyway, back to the dialog
20160930 00:35:14< vultraz> I wonder if we have multiple definitions of the same window..?
20160930 00:35:27< vultraz> I don't think we do
20160930 00:36:04< celticminstrel> What?
20160930 00:36:17< vultraz> like widget definitions, except for a window
20160930 00:36:45< celticminstrel> Are you talking about [window] or [window_definition]?
20160930 00:36:52< vultraz> [window]
20160930 00:37:02< celticminstrel> And what exactly is it that you want?
20160930 00:37:06< vultraz> [window_definition] is a definition of the window widget
20160930 00:37:23< vultraz> I was thinking two definitions of the same dialog with a differing listbox 
20160930 00:38:01< vultraz> but I might not...actually need that
20160930 00:38:09< vultraz> I could just put 2 listboxes in a stack
20160930 00:38:17< vultraz> and use the appropriate one
20160930 00:38:25-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160930 00:38:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 00:40:00< vultraz> though maybe I should seperate this into two dialogs
20160930 00:40:08< vultraz> separate 
20160930 00:40:11< vultraz> not sure
20160930 00:40:12 * vultraz ponders
20160930 00:40:32< vultraz> the only common threads are chat and userlist handling
20160930 00:40:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 272 seconds]
20160930 00:40:47< vultraz> yeah, I guess I'll separate them
20160930 00:45:34< vultraz> as for the reason I'm so anxious to drop the gui1 versions, it's so I can clean up the various engines
20160930 00:46:01< vultraz> I cannot touch them as long as the gui1 versions exist
20160930 00:50:19< vultraz> celticminstrel: please do remove the timer from the lobby if you can
20160930 00:50:42< vultraz> celticminstrel: but keep in mind the problems live updating could have on a large number of games
20160930 01:00:32< celticminstrel> Hmm?
20160930 01:00:50< celticminstrel> What problems?
20160930 01:01:00< vultraz> ...
20160930 01:01:13< vultraz> if we ever get too many games everything will be updating too fast
20160930 01:01:24< celticminstrel> Isn't that a good thing?
20160930 01:01:42< vultraz> then again, that's more a problem with our 'list all games on server' model
20160930 01:02:02< celticminstrel> What's the problem with updating too fast?
20160930 01:02:22< vultraz> not being able to find anything
20160930 01:02:28< vultraz> especially if the listbox jumps around
20160930 01:02:43< celticminstrel> Well, obviously we don't want it to jump around.
20160930 01:02:47< vultraz> yes
20160930 01:02:52< vultraz> I have looked into that bug
20160930 01:03:04< celticminstrel> Whichever game is selected should always remain selected unless it no longer exists.
20160930 01:03:28< vultraz> the issue seems to be that the scrollbar position is set to that the selected item aligns with the bottom of the listbox
20160930 01:03:46< celticminstrel> Huh?
20160930 01:04:38< celticminstrel> I must be missing something here, because I don't see what the issue is with that.
20160930 01:04:49< vultraz> the issue is in tscrollbar_container::show_content_rect
20160930 01:04:50< celticminstrel> (It's not ideal, but it doesn't seem bad.)
20160930 01:05:30< vultraz> if, for example, you're using the arrow keys to go down the list, it's exactly the behavior you want
20160930 01:05:50< vultraz> because then the selection is always on the bottom
20160930 01:05:59< vultraz> however, in any situation where the selection is NOT on the buttom
20160930 01:06:08< vultraz> say, the selection is in the visible area
20160930 01:06:13< vultraz> but in the middle
20160930 01:06:17< celticminstrel> Oh wait. If the selection is offscreen... then it should remain offscreen...
20160930 01:06:26< vultraz> and selecting it causes that function to be called
20160930 01:06:40< vultraz> the scrollbar will be moved to the selection aligns with the bottom of the visible area
20160930 01:07:17< vultraz> s/to/so
20160930 01:07:23< vultraz> see the problem?
20160930 01:07:30< celticminstrel> This is pretty hard to test though since there are never any games on the server. I guess I can create a couple of instances, but still...
20160930 01:07:50< vultraz> this bug can be seen in the new addons server list 
20160930 01:08:00< vultraz> use LotI as a test case
20160930 01:08:04< vultraz> ie, click on it
20160930 01:08:41< celticminstrel> Basically what's needed is a way to preserve the current selection and scroll position as precisely as possible when the listbox contents change.
20160930 01:08:42< vultraz> the scrollbar should never move unless the list position itself is changing
20160930 01:09:04< vultraz> no, it's not contents
20160930 01:09:05< celticminstrel> I would go even further and say the scrollbar should never move unless you explicitly do something to move it.
20160930 01:09:16< vultraz> well, that's false
20160930 01:09:29< vultraz> since then you could never scroll down the list with the arrow keys :P
20160930 01:09:39< vultraz> remember, the arrow keys don't move the scrollbar
20160930 01:09:40< celticminstrel> That counts as explicitly doing something to move it, silly. :P
20160930 01:10:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 01:10:07< vultraz> I'm sure you could fix this bug easily
20160930 01:10:09< vultraz> :)
20160930 01:10:27< celticminstrel> If I can reproduce it, then maybe.
20160930 01:10:35< vultraz> I just told you how to
20160930 01:11:11< vultraz> I think it's a case where std::min would be beeded
20160930 01:11:14< vultraz> needed
20160930 01:11:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160930 01:11:34< celticminstrel> The hard part is filling the list up.
20160930 01:11:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 01:11:56< vultraz> ie, min(bottom_edge,  selection_pos.y + h)
20160930 01:11:59< vultraz> or something
20160930 01:12:13< vultraz> how is that hard?
20160930 01:12:40< celticminstrel> What exactly causes the list to move? The update from the server?
20160930 01:12:57< celticminstrel> It's hard because it means running three or four instances.
20160930 01:13:05< vultraz> I.. what?
20160930 01:13:15< vultraz> I told you to look at the new addons manager :|
20160930 01:13:26< vultraz> you don't need to be in the lobby to see this problem :|
20160930 01:13:56< celticminstrel> So what do I do after clicking LotI?
20160930 01:14:03< vultraz> nothing :|
20160930 01:14:08< celticminstrel> ...
20160930 01:14:15< celticminstrel> Wait, it moves just from clicking on it?
20160930 01:14:20< vultraz> *yes*
20160930 01:14:23< celticminstrel> ...why?
20160930 01:14:27< vultraz> but this only happens with certain addons
20160930 01:14:31< vultraz> I'm not 100% sure why
20160930 01:14:40< vultraz> but it's likely something to do with layout invalidation
20160930 01:14:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160930 01:15:02< celticminstrel> Why would selecting an item invalidate the layout?
20160930 01:15:14< vultraz> because it updates the details on the right
20160930 01:15:37< vultraz> somehow, show_content_rect is being called on the listbox
20160930 01:15:39< vultraz> I don't know why
20160930 01:15:41< vultraz> but it is
20160930 01:16:11< celticminstrel> So... how is this the same as whatever lobby thing?
20160930 01:16:39-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 272 seconds]
20160930 01:17:23< vultraz> because the issue is likely present
20160930 01:17:42< vultraz> I have not been able to observe it with a large, dynamically changing list since we have no such thing
20160930 01:17:48< celticminstrel> I have no idea if I can solve this issue.
20160930 01:18:07< vultraz> so I don't know to what extent is occurs
20160930 01:18:09< vultraz> for all I know
20160930 01:18:14< vultraz> the list might jump to the top
20160930 01:18:19< vultraz> as I believe was reported before
20160930 01:18:26< vultraz> but I don't know
20160930 01:18:45< celticminstrel> Does the size of the listbox change when this happens?
20160930 01:19:01 * celticminstrel also doesn't know what show_content_rect does and why it's a bad thing for it to be called in this case.
20160930 01:19:04< vultraz> size of the widget?
20160930 01:19:06< vultraz> no
20160930 01:19:11< vultraz> size of the list?
20160930 01:19:12 * celticminstrel could probably find out, I suppose.
20160930 01:19:13< vultraz> yes
20160930 01:19:18< gfgtdf> vultraz: you say there is a problem in show_content_rect  ?
20160930 01:19:26< celticminstrel> Wait, why does the size of the list change?
20160930 01:19:35< vultraz> because games are being added/removed
20160930 01:19:45< vultraz> I don't know if that causes the list to go to the top
20160930 01:19:48< celticminstrel> I thought we were talking about the addons manager.
20160930 01:20:08< vultraz> the problem (or a similar problem) manifests itself in both places
20160930 01:20:23< celticminstrel> In the addons manager, does the size of the listbox change?
20160930 01:21:10< vultraz> no
20160930 01:21:15< vultraz> not unless you filter addons
20160930 01:21:47< gfgtdf> celticminstrel: 'show_content_rect(SDL_rect)' is a function that moves the scronllbars of a scrollbar container tto make the given (usually the selected) rectangle visiable this usually happen when scrolling with the u/down arrows.
20160930 01:22:13< celticminstrel> Ah, that sounds vaguely useful.
20160930 01:23:03< vultraz> there are essentially two problems here, likely related:
20160930 01:24:04< vultraz> * In certain dialog-dependent circumstances, clicking on an item in the listbox can result in the scrollbar moving so the selected item is aligned with the bottom
20160930 01:24:30< gfgtdf> what teh probme about that?
20160930 01:24:36< vultraz> * It was reported in the past but I have not been able to confirm, that in the new lobby, the list moved to the top if a new game was added
20160930 01:24:50< gfgtdf> the first one sounds liek expecte behviour to me
20160930 01:25:24< vultraz> Both of these are related in some way to the listbox or scrollbar_container's handling of the scrollbar position]
20160930 01:25:47< vultraz> gfgtdf: no, it is not. the scrollbar should never move if a new item is clicked on unless its rect is partially obscured
20160930 01:26:21< celticminstrel> Yeah, I agree on this.
20160930 01:26:36< celticminstrel> So the addons manager thing sounds like a subtly bug in show_content_rect.
20160930 01:26:41< celticminstrel> I don't know if the lobby issue is related.
20160930 01:26:53-!- gfgtdf_ [~chatzilla@x4e36a2c0.dyn.telefonica.de] has joined #wesnoth-dev
20160930 01:26:58< gfgtdf_> had dc
20160930 01:27:01< gfgtdf_> vultraz: when i tried to 'fix scrollbar position when inserting to listbox' last time iirc the main problem was the potentioal ordering of the list, so that when you add a new element to the list you don't know where exactly it is inserted since the order is calculated lazily. when the item is inserted after the current scrollign position you usualyl don't want the scrolling position to...
20160930 01:27:03< gfgtdf_> ...change, but when you insert before the scrolling position you want to adjust the scrolling position by the size of the object so that the visible area stays the same.
20160930 01:27:09< celticminstrel> However, I'll note that the specific report you mentioned sounds unrelated.
20160930 01:27:27< vultraz> the problem with the lobby issue is i cannot observe it since there's no one in the lobby
20160930 01:27:51< celticminstrel> Which is why multiple instances.
20160930 01:28:06< vultraz> I'd need about 10 ;|
20160930 01:28:08< celticminstrel> (Setting your resolution to 800x600 would probably help too - fewer games needed to get a scrollbar.)
20160930 01:28:24< celticminstrel> I doubt you'd need ten. Four or five at most.
20160930 01:28:30< vultraz> then again
20160930 01:28:44< vultraz> didn't jyrki add a thing to simulate lobby adtivity
20160930 01:28:57< celticminstrel> He did, yes.
20160930 01:29:08-!- gfgtdf [~chatzilla@x4e363304.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160930 01:29:11< celticminstrel> If I understand it correctly you'd need to run several instances with that plugin, though.
20160930 01:29:17-!- gfgtdf_ is now known as gfgtdf
20160930 01:29:57< shadowm> You can set game_config::version (I think) to "test" to get allowed in all official server instances.
20160930 01:30:18< shadowm> Or you can ask nicely for me to add a temporary exception for 1.13.5+dev.
20160930 01:31:36< celticminstrel> That would work if the server protocol is compatible (I have no reason to believe it isn't, but also no reason to be confident that it is).
20160930 01:31:56< gfgtdf> celticminstrel: it is at lest not compatible enough to join a game
20160930 01:32:10< celticminstrel> Well, joining a game wouldn't be needed for this.
20160930 01:32:12< vultraz> we only need to observe
20160930 01:32:16< gfgtdf> celticminstrel: lobby might work, mp connect will mostlikeley not.
20160930 01:32:16< vultraz> the lobby
20160930 01:33:10< gfgtdf> vultraz: is thre a bugrpeort about gui2 listboxes reset to top ?
20160930 01:33:20< vultraz> not that I know of
20160930 01:33:27< gfgtdf> vultraz: on the tracker i meant
20160930 01:33:37< vultraz> again not that i know of
20160930 01:34:05< celticminstrel> From the sounds of it, it's specific to the lobby, which makes me thing it's not a listbox bug but rather a lobby bug.
20160930 01:34:27< vultraz> no, the lobby is simply the only dialog with a dynamically changing list
20160930 01:34:35< gfgtdf> celticminstrel: well there arent that much listboxes where we add elements dynamically
20160930 01:34:35< celticminstrel> (Unless the listbox is expected to retain its scroll position when it's cleared and repopulated. Though I'm not sure if the lobby actually does that?)
20160930 01:34:42< vultraz> we just need an ability to view the contents of the 1.12 server in the 1.13.5+dev lobby
20160930 01:35:03< vultraz> in order to confirm this issue
20160930 01:35:10< celticminstrel> Or simulate lobby activity on the 1.13 server.
20160930 01:35:23< vultraz> better to get the real activity :P
20160930 01:35:32< celticminstrel> I wouldn't say that.
20160930 01:35:37< vultraz> if shadowm can provide such a thing, can he please do so.
20160930 01:35:43< celticminstrel> Activity is activity, whether it's real or not.
20160930 01:35:51< shadowm> Connect to wesnoth.org:14998.
20160930 01:36:01< shadowm> Hope it doesn't explode.
20160930 01:36:40< gfgtdf> shadowm: you added an exception?
20160930 01:36:50< shadowm> That's implied, yes.
20160930 01:37:06< vultraz> celticminstrel: yup, i can see the list jumping to the top
20160930 01:37:35< celticminstrel> So how exactly does the lobby update its listbox when it receives a gamelist diff?
20160930 01:37:50< celticminstrel> Does it clear and repopulate? Because I would totally expect that effect if it does that.
20160930 01:38:11< shadowm> "Allow damage calculation with Monte Carlo simulation" -- ♥ undocumented Advanced Preferences entries.
20160930 01:38:24< vultraz> celticminstrel: clear and repopulate
20160930 01:38:39< celticminstrel> shadowm: What do you mean by "undocumented"? No detailed description, or something else?
20160930 01:38:46< shadowm> celticminstrel: Yes.
20160930 01:38:46< celticminstrel> Also, how long is this exception going to exist?
20160930 01:39:08< shadowm> Unless you think that "Monte Carlo simulation" is going to mean something to people who don't have a CS degree.
20160930 01:39:26< celticminstrel> Pretty sure it will. If they have a math or stats degree. :P
20160930 01:39:42< shadowm> Who don't have a CS or maths-related (including statistics and engineering) degree.
20160930 01:40:06< vultraz> shadowm: please leave this exception up until the release
20160930 01:40:14< shadowm> Okay, will do.
20160930 01:43:04< shadowm> This looks neat.
20160930 01:43:33< vultraz> What does?
20160930 01:43:35< shadowm> There are a few margin and font size issues though. I guess I'll wait until everything else has been sorted out before going into specifics.
20160930 01:43:38< shadowm> Lobby.
20160930 01:43:52< vultraz> celticminstrel: I'd say the list jumping to the top is a bigger issue than the 'selection goes to bottom' thing
20160930 01:44:27< celticminstrel> Agreed.
20160930 01:44:40< celticminstrel> It's presumably a direct result of clearing and repopulating.
20160930 01:44:47< celticminstrel> There are thus two choices.
20160930 01:44:55< celticminstrel> 1) Don't ever clear the list.
20160930 01:45:09< celticminstrel> 2) Somehow remember where the viewport was, and restore it after repopulating.
20160930 01:45:30< celticminstrel> I'm not sure if 1 is viable (can you insert a row not at the end?).
20160930 01:46:02< celticminstrel> I know every existing use-case inserts rows at the end, but not sure if that's just because it's what they need or if it's because the listbox actually doesn't support anything else.
20160930 01:46:03< vultraz> hmmm
20160930 01:46:07< vultraz> this is *interesting*
20160930 01:46:10< celticminstrel> ?
20160930 01:46:18< vultraz> it actually doesn't jump to the *top*, per-se
20160930 01:46:28< vultraz> it jumps so the selected entry is visible at the bottom o_O
20160930 01:46:45< celticminstrel> And the selected entry is always the same?
20160930 01:46:49< vultraz> or top
20160930 01:47:02< celticminstrel> So it basically jumps so that the selected entry is visible.
20160930 01:47:07< vultraz> yeah
20160930 01:47:18< vultraz> so these two bugs are definitely related
20160930 01:47:22< celticminstrel> Which probably ends up being the top in most cases.
20160930 01:47:29< celticminstrel> Because the listbox was cleared and repopulated.
20160930 01:47:44< vultraz> no, the selected entry remains the same, it seems
20160930 01:47:45< gfgtdf> celticminstrel: i think it doesnt recaulcate the list, it te lobby has some rather complicatd that code that reads the diff to calculate whcoih games are added /modified.
20160930 01:47:59< celticminstrel> Ah.
20160930 01:48:12< vultraz> hmmm
20160930 01:48:14< vultraz> actually
20160930 01:48:16< vultraz> hmmm
20160930 01:48:17< vultraz> no...
20160930 01:48:27< vultraz> no, it doesn't jump so the selected entry is visible
20160930 01:48:30< vultraz> the code does this:
20160930 01:48:41< vultraz> clear list
20160930 01:48:47< vultraz> iterate over games
20160930 01:48:51< vultraz> find the selected game
20160930 01:48:55< vultraz> add rows
20160930 01:49:10< vultraz> then use select_row to select the selected game
20160930 01:49:20< celticminstrel> Line number?
20160930 01:49:37< vultraz> dialogs/lobby/lobby.cpp:285
20160930 01:50:16< vultraz> oh god dammit
20160930 01:50:26< vultraz> I'm noticing the chat area jumping to the top as well :|
20160930 01:50:30< gfgtdf> vultraz: on diffs it calls update_gamelist_diff() not update_gamelist()
20160930 01:50:54< vultraz> gfgtdf: hmmmm
20160930 01:51:01< vultraz> gfgtdf: good point
20160930 01:51:02< vultraz> celticminstrel: ^
20160930 01:51:49< celticminstrel> This looks really complicated. :/
20160930 01:52:02< gfgtdf> vultraz: is tzhe chat area one multi-row-label or some list single of labels?
20160930 01:52:13< gfgtdf> list of*
20160930 01:52:15< vultraz> gfgtdf: former
20160930 01:52:22< vultraz> it's a scroll label
20160930 01:52:56< vultraz> gfgtdf: iirc the chat is having the same issue as https://gna.org/bugs/index.php?24698
20160930 01:53:43< vultraz> even though there's code that's supposed to reset the scrollbar position correctly
20160930 01:53:48< vultraz> (see in the chatbox widget)
20160930 01:53:54< vultraz> that happens at times..
20160930 01:54:05< vultraz> again likely an issue with show_content_rect
20160930 01:54:18< vultraz> since listboxes and scroll labels both use a scrollbar container
20160930 01:54:30< gfgtdf> vultraz: no its not.
20160930 01:54:52< gfgtdf> vultraz: i really think that show_content_rect works as intened.
20160930 01:55:01< vultraz> if so
20160930 01:55:14< vultraz> then it's being used in places where its behavior is not desired
20160930 01:55:25< celticminstrel> Or another possibility:
20160930 01:55:31< celticminstrel> In the case of the addons manager for instance.
20160930 01:55:52< celticminstrel> Perhaps something caused the listbox to scroll (but we never see it), and then show_content_rect was called to fix it.
20160930 01:56:16< vultraz> oh come on, the user list is jumping to the top too :|
20160930 01:56:22< vultraz> DOES NOTHING NOT JUMP TO THE TOP :|
20160930 01:56:27< celticminstrel> I wonder what would happen if you add a return at the top of show_content_rect and then go click on LotI.
20160930 01:56:52< celticminstrel> vultraz: If it's being cleared and repopulated, it's obvious that it would jump to the top.
20160930 01:57:05< celticminstrel> That doesn't apply to the chat though.
20160930 01:57:26< celticminstrel> (Actually, gfgtdf brought up an interesting point - when he asked if the chat is a list...)
20160930 01:59:06< vultraz> celticminstrel: putting a return in SCR and clicking on loti makes the list jump alll the way to the top
20160930 01:59:18< vultraz> celticminstrel: so i think gfgtdf is right. scr works as intended.
20160930 01:59:27< vultraz> there's some other bullshit going on
20160930 02:00:15< vultraz> obviously, scr could be smarter and preserver the content rect's precise location
20160930 02:00:27< celticminstrel> Uhh, no.
20160930 02:00:38< vultraz> but that's not what's causing the jumps
20160930 02:01:06< gfgtdf> vultraz: hmm do ou have a stacktrace of whn add_row calls show_content_rect() ?
20160930 02:01:16< celticminstrel> Presumably by the time show_content_rect is called, the scrollbar has already moved.
20160930 02:01:18< vultraz> what?
20160930 02:01:29< vultraz> celticminstrel: likely, yes
20160930 02:01:39< vultraz> gfgtdf: no how would i get that
20160930 02:01:58< celticminstrel> So it's not a question of show_content_rect being smarter.
20160930 02:02:26< celticminstrel> vultraz: Run debugger, set breakpoint, request backtrace.
20160930 02:02:36< celticminstrel> (When the breakpoint is hit, that is)
20160930 02:02:37< vultraz> eh
20160930 02:03:03< celticminstrel> Might be easier in MSVC since you get the backtrace automatically.
20160930 02:03:19< vultraz> I... could you do this
20160930 02:07:16-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 02:08:04< vultraz> note to self:
20160930 02:08:15< vultraz> make the server selection dialog display before the loadscreen
20160930 02:10:01-!- gfgtdf [~chatzilla@x4e36a2c0.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]]
20160930 03:09:36-!- JyrkiVesterinen [~JyrkiVest@87-100-159-149.bb.dnainternet.fi] has joined #wesnoth-dev
20160930 03:13:31-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160930 03:20:52< JyrkiVesterinen> 20160930 01:28:44< vultraz> didn't jyrki add a thing to simulate lobby adtivity
20160930 03:21:10< JyrkiVesterinen> Yes, I did. And as celticminstrel said, the idea is to run multiple instances of it.
20160930 03:21:32< JyrkiVesterinen> I plan to later create some kind of script to launch a large number of instances at once.
20160930 03:22:18< vultraz> might not be necessary
20160930 03:22:38< vultraz> we now have a way to access the 1.12 server
20160930 03:23:42< JyrkiVesterinen> Is the 1.12 server usable in 1.13.5+dev (i.e. there aren't too big protocol incompatibilities)?
20160930 03:24:50< JyrkiVesterinen> 20160930 01:38:11< shadowm> "Allow damage calculation with Monte Carlo simulation" -- ♥ undocumented Advanced Preferences entries.
20160930 03:25:00< JyrkiVesterinen> It is not undocumented. It has a description.
20160930 03:25:30< JyrkiVesterinen> "Allow the damage calculation window to simulate fights instead of using exact probability calculations"
20160930 03:25:43< vultraz> it is usable to the extent that the new lobby can display its contents
20160930 03:25:44-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160930 03:27:09< JyrkiVesterinen> vultraz: Great. :) In that case I'll work on something else next.
20160930 03:27:33< vultraz> perhaps you can help us with the listbox bug we were talking about in the logs
20160930 03:28:46< celticminstrel> I think it's still useful to have a "simulate activity" script, but perhaps lower priority now.
20160930 03:29:16< celticminstrel> According to gfgtdf there are protocol incompatibilities if you try to join a game, but just viewing the lobby apparently works.
20160930 03:31:02< JyrkiVesterinen> Ctrl+F "listbox" in today's logs gives me 20 hits. I'll read later what the listbox bug is about.
20160930 03:32:51< JyrkiVesterinen> celticminstrel: Finishing activity simulation wouldn't be much work (create a script that runs 10-100 iterations of a loop that launches Wesnoth with certain command-line parameters), so I can indeed just as well do it when I have time.
20160930 03:34:28< JyrkiVesterinen> shadowm, regarding the Monte Carlo preference: if you're complaining that the description isn't detailed enough, then feel free to come up with a better one.
20160930 03:34:48< JyrkiVesterinen> I simply didn't want to make the description any longer.
20160930 03:37:46-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160930 04:11:55< shadowm> JyrkiVesterinen: Oh, sorry about that. I didn't realize the descriptions appear when clicking on the options.
20160930 04:12:41< JyrkiVesterinen> OK. I figured that it was a possibility that you hadn't noticed the description.
20160930 04:13:16< JyrkiVesterinen> (Monte Carlo simulation is the first advanced preference, which is why it's initially selected but doesn't have the description visible until it's clicked.)
20160930 04:13:33< shadowm> That seems like a bug for vultraz to fix.
20160930 04:15:04< JyrkiVesterinen> Hmm, the second advanced preference is "Auto-open whisper windows in lobby" that doesn't have a description.
20160930 04:15:30< JyrkiVesterinen> It was the first advanced preference until I implemented MC simulation.
20160930 04:15:38-!- irker529 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160930 04:15:38< irker529> wesnoth: Charles Dang wesnoth:master 12838d6f6717 / src/gui/dialogs/preferences_dialog.cpp: Preferences: fixed initial Advanced selection not being expanded if it had a des https://github.com/wesnoth/wesnoth/commit/12838d6f6717dd954d4af7a9a10905f4b4d8b731
20160930 04:15:40< vultraz> shadowm, JyrkiVesterinen ^
20160930 04:15:59< JyrkiVesterinen> That was fast. Thanks. :)
20160930 04:16:38< vultraz> It was simple :)
20160930 04:21:46-!- JyrkiVesterinen [~JyrkiVest@87-100-159-149.bb.dnainternet.fi] has quit [Quit: Going to work]
20160930 04:23:13< irker529> wesnoth: Charles Dang wesnoth:master 688c3f600d2a / data/gui/window/mp_faction_select.cfg: Faction Select: use small label for recruits list https://github.com/wesnoth/wesnoth/commit/688c3f600d2ab8467205395e3aa562f00e900bef
20160930 04:30:51-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20160930 04:52:31-!- travis-ci [~travis-ci@ec2-54-90-231-67.compute-1.amazonaws.com] has joined #wesnoth-dev
20160930 04:52:32< travis-ci> wesnoth/wesnoth#11235 (master - 12838d6 : Charles Dang): The build has errored.
20160930 04:52:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/163910533
20160930 04:52:32-!- travis-ci [~travis-ci@ec2-54-90-231-67.compute-1.amazonaws.com] has left #wesnoth-dev []
20160930 04:55:29-!- Kwandulin [~Miranda@p200300760F2C71DDA4C65495CFAAC290.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160930 04:57:44-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160930 05:15:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160930 05:25:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 05:26:56-!- travis-ci [~travis-ci@ec2-54-90-231-67.compute-1.amazonaws.com] has joined #wesnoth-dev
20160930 05:26:58< travis-ci> wesnoth/wesnoth#11236 (master - 688c3f6 : Charles Dang): The build has errored.
20160930 05:26:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/163911276
20160930 05:26:58-!- travis-ci [~travis-ci@ec2-54-90-231-67.compute-1.amazonaws.com] has left #wesnoth-dev []
20160930 05:29:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 272 seconds]
20160930 05:33:14-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160930 05:33:14-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160930 05:42:56-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160930 05:44:11-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160930 05:57:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 06:01:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160930 06:28:08-!- Kwandulin [~Miranda@p200300760F2C71DDA4C65495CFAAC290.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160930 06:55:00-!- atarocch [~atarocch@natmobil.sfa.se] has joined #wesnoth-dev
20160930 07:07:34-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160930 07:08:20-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160930 07:09:20< vultraz> ok, work on the separate wait dialog is coming along nicely
20160930 07:34:45-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has quit [Ping timeout: 272 seconds]
20160930 07:35:44-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has joined #wesnoth-dev
20160930 07:36:01-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 07:41:49-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 07:43:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160930 07:46:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 07:47:25-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 07:49:50-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 07:50:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20160930 07:58:51-!- Kwandulin [~Miranda@93.221.17.159] has joined #wesnoth-dev
20160930 08:02:50-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 244 seconds]
20160930 08:33:39-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 08:35:22-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160930 08:39:43-!- Nobun [~nobun@5.170.107.166] has joined #wesnoth-dev
20160930 08:41:56-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 08:46:32-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160930 08:47:28< zookeeper> vultraz, typo "Reservior" in mp_create_game.cfg
20160930 08:47:41< zookeeper> (twice on the line)
20160930 08:56:21-!- Kwandulin [~Miranda@93.221.17.159] has quit [Read error: Connection reset by peer]
20160930 08:58:48-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.2 Aria]
20160930 08:59:37-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 09:01:36-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 09:01:42-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160930 09:03:25-!- Nobun [~nobun@5.170.107.166] has quit [Ping timeout: 272 seconds]
20160930 09:05:57 * zookeeper wonders what the strange symbol at the bottom of the experimental MP create screen is
20160930 09:06:35-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 09:11:28-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 09:17:11-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160930 09:22:00-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20160930 09:31:58-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160930 09:34:27-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 09:34:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 09:34:48-!- atarocch [~atarocch@natmobil.sfa.se] has quit [Remote host closed the connection]
20160930 09:35:10-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 09:39:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160930 09:42:17-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection timed out]
20160930 09:42:59-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160930 09:51:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Read error: Connection reset by peer]
20160930 09:52:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20160930 09:59:09-!- Appleman1234_ [~Appleman1@KD119104051022.au-net.ne.jp] has joined #wesnoth-dev
20160930 09:59:13-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160930 10:01:03-!- Appleman1234 [~Appleman1@KD119104043066.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20160930 10:02:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160930 10:02:58-!- wedge010 is now known as wedge009
20160930 10:04:27-!- Appleman1234_ is now known as Appleman1234
20160930 10:05:15< vultraz> zookeeper: decoration
20160930 10:05:34-!- irker529 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160930 10:08:26< vultraz> thanks for pointing out the typo
20160930 10:08:55-!- RatArmy [~RatArmy@om126161124070.8.openmobile.ne.jp] has joined #wesnoth-dev
20160930 10:10:32-!- Nobun [~nobun@5.170.106.240] has joined #wesnoth-dev
20160930 10:23:17-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160930 10:31:27-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 10:32:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 272 seconds]
20160930 10:35:10-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 10:39:51-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20160930 10:40:54-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has quit [Read error: Connection reset by peer]
20160930 10:41:14-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has joined #wesnoth-dev
20160930 10:45:26-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has joined #wesnoth-dev
20160930 10:50:45-!- Nobun [~nobun@5.170.106.240] has quit [Ping timeout: 244 seconds]
20160930 11:06:17-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 11:07:10-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 11:08:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160930 11:14:39-!- RatArmy [~RatArmy@om126161124070.8.openmobile.ne.jp] has quit [Quit: Leaving]
20160930 11:23:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 11:27:11-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 11:27:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160930 11:28:13-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 11:41:29-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has quit [Read error: Connection reset by peer]
20160930 11:41:51-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has joined #wesnoth-dev
20160930 11:55:41-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 11:56:07-!- hk238 [~kvirc@unaffiliated/hk238] has joined #wesnoth-dev
20160930 11:57:16-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 11:58:51-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160930 12:05:11-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 12:06:20-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 12:10:53-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 272 seconds]
20160930 12:13:28-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Read error: Connection reset by peer]
20160930 12:13:40-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160930 12:21:39-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 272 seconds]
20160930 12:26:05-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 12:26:43-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has quit [Ping timeout: 272 seconds]
20160930 12:26:49-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 12:27:44-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has joined #wesnoth-dev
20160930 12:34:19-!- Bonobo [~Bonobo@2001:44b8:254:3200:38ee:a6bc:6e4d:5aeb] has quit [Ping timeout: 272 seconds]
20160930 12:34:29-!- Bonobo [~Bonobo@124-169-217-242.dyn.iinet.net.au] has joined #wesnoth-dev
20160930 12:36:13-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160930 12:37:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 12:39:02-!- Nobun [~nobun@5.170.110.155] has joined #wesnoth-dev
20160930 12:42:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160930 12:42:46-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20160930 13:04:09-!- Kwandulin [~Miranda@p200300760F2C71DD5DF571BF1A6EE83B.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160930 13:11:48-!- Nobun [~nobun@5.170.110.155] has quit [Ping timeout: 244 seconds]
20160930 13:21:49-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 13:27:32-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 13:29:20-!- Nobun [~nobun@5.170.111.48] has joined #wesnoth-dev
20160930 13:35:07-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 13:42:28-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 13:43:34-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Network is unreachable]
20160930 13:44:26-!- Jetrel [~Jetrel@c-73-228-139-39.hsd1.mn.comcast.net] has joined #wesnoth-dev
20160930 13:54:19-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20160930 13:54:30-!- Nobun [~nobun@5.170.111.48] has quit [Ping timeout: 264 seconds]
20160930 13:55:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160930 14:07:06 * celticminstrel pokes vultraz 
20160930 14:07:12< vultraz> si si si?
20160930 14:07:21< celticminstrel> Give tad the forum group already.
20160930 14:08:18< vultraz> I'm waiting until he comes on IRC so I he may confirm which account is his.
20160930 14:08:33< celticminstrel> Uhh. I really don't think that's necessary, but if you insist.
20160930 14:08:44< celticminstrel> I'm pretty sure "Tad_Carlucci" is his.
20160930 14:09:01< vultraz> Yes, but it's proper procedure.
20160930 14:09:23< celticminstrel> :/
20160930 14:09:26< celticminstrel> Well whatever.
20160930 14:10:35-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 14:11:00-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 14:11:54-!- Nobun [~nobun@5.170.109.178] has joined #wesnoth-dev
20160930 14:15:29-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20160930 14:16:00-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160930 14:16:17-!- Kwandulin [~Miranda@p200300760F2C71DD5DF571BF1A6EE83B.dip0.t-ipconnect.de] has quit [Ping timeout: 272 seconds]
20160930 14:20:11-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160930 14:28:54< celticminstrel> I wish doofus wouldn't edit out images from earlier posts all the time.
20160930 14:32:07< celticminstrel> Hmm. Is "homunculus" credited in about.cfg yet?
20160930 14:32:18-!- Nobun [~nobun@5.170.109.178] has quit [Ping timeout: 264 seconds]
20160930 14:33:23-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 14:38:04-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 14:43:31-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 14:44:04-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20160930 14:44:41-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160930 14:49:13-!- Samual [~Samual@xonotic/core-team/Samual] has quit [Ping timeout: 272 seconds]
20160930 14:50:30-!- Bonobo [~Bonobo@124-169-217-242.dyn.iinet.net.au] has quit [Quit: Leaving]
20160930 15:01:06< vultraz> well this is annoying :|
20160930 15:01:11< vultraz> the flg dialog won't show up :|
20160930 15:01:17< celticminstrel> Lovely!
20160930 15:02:13-!- DeFender [~DeFender1@89-138-252-80.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20160930 15:05:37-!- gfgtdf [~chatzilla@x4e36a2c0.dyn.telefonica.de] has joined #wesnoth-dev
20160930 15:07:03-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Remote host closed the connection]
20160930 15:09:52-!- irker278 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20160930 15:09:52< irker278> wesnoth: Charles Dang wesnoth:master fe2e119b251d / / (3 files in 2 dirs): MP Create Game: fixed widespread typo https://github.com/wesnoth/wesnoth/commit/fe2e119b251dd2c732fe0d20d08ac1ac61f836d2
20160930 15:09:53< irker278> wesnoth: Charles Dang wesnoth:master 45ea8c6a4311 / / (9 files in 6 dirs): Added GUI2 MP Join Game dialog https://github.com/wesnoth/wesnoth/commit/45ea8c6a4311b4a235f812aa313f883872ff3fa4
20160930 15:10:25< vultraz> gfgtdf: ^ celticminstrel ^ 
20160930 15:10:36< vultraz> (latter, xcode update)
20160930 15:11:19< vultraz> it still needs work
20160930 15:11:22-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160930 15:11:23-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160930 15:11:24< vultraz> but it's generally functional
20160930 15:12:06< vultraz> it follows the same read-only paradigm as the old dialog
20160930 15:24:35-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 244 seconds]
20160930 15:32:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20160930 15:33:44-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20160930 15:38:32-!- gfgtdf [~chatzilla@x4e36a2c0.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20160930 15:41:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 15:45:40-!- travis-ci [~travis-ci@ec2-54-160-146-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20160930 15:45:41< travis-ci> wesnoth/wesnoth#11237 (master - 45ea8c6 : Charles Dang): The build failed.
20160930 15:45:41< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/164049479
20160930 15:45:41-!- travis-ci [~travis-ci@ec2-54-160-146-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20160930 15:45:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160930 15:46:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 15:47:29< vultraz> blah
20160930 15:47:54-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20160930 15:48:46< irker278> wesnoth: Charles Dang wesnoth:master 6c5df634aa67 / src/tests/gui/test_gui2.cpp: Forgot to comment out Join Game dialog test call https://github.com/wesnoth/wesnoth/commit/6c5df634aa670c85f790a54c4b162aa1d9fc0312
20160930 15:49:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 15:50:16-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160930 15:54:55-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20160930 16:07:15-!- Nobun [~nobun@5.170.108.106] has joined #wesnoth-dev
20160930 16:09:16< Nobun> celticminstrel: I need an info, for one of the tests I will do to wmlxgettext. I need to know IF and WHERE lua plural form is currently used on wesnoth 'data' files (I mean... what domain)
20160930 16:09:58< celticminstrel> Nobun: The only current use is in data/lua/wml/message.lua
20160930 16:10:00< Nobun> for example... if plural is used on 'wesnoth' textdomain or if it used on other textdomain (and possibly, if you remember, wich lua files)
20160930 16:10:12< celticminstrel> Which I think is "wesnoth" textdomain.
20160930 16:10:14< Nobun> celticminstrel: ok, thank
20160930 16:10:55< Nobun> well it is a file only, so probably a specific test could be not required... however I'll check it
20160930 16:13:16-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20160930 16:18:26-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20160930 16:18:26-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20160930 16:18:26-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 16:19:57-!- noy_ [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20160930 16:21:30-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 264 seconds]
20160930 16:26:09-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20160930 16:27:46-!- travis-ci [~travis-ci@ec2-54-90-84-126.compute-1.amazonaws.com] has joined #wesnoth-dev
20160930 16:27:47< travis-ci> wesnoth/wesnoth#11238 (master - 6c5df63 : Charles Dang): The build was fixed.
20160930 16:27:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/164063673
20160930 16:27:47-!- travis-ci [~travis-ci@ec2-54-90-84-126.compute-1.amazonaws.com] has left #wesnoth-dev []
20160930 16:31:45-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 244 seconds]
20160930 16:57:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 16:59:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 16:59:40-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20160930 17:01:06-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20160930 17:03:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 17:09:40-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has joined #wesnoth-dev
20160930 17:16:05-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20160930 17:16:18< mordante> servus
20160930 17:23:12< vultraz> hello
20160930 17:24:34< mordante> hi vultraz 
20160930 17:29:35-!- aquileia [5fd07d56@gateway/web/freenode/ip.95.208.125.86] has joined #wesnoth-dev
20160930 17:31:33< aquileia> wedge009, celticminstrel, zookeeper: Just a quick note that I'll update aquileia/external with boost 1.62 (including the three new dependencies: bimap dynamic_bitset multi_array) as soon as my rebuild finishes
20160930 17:31:43< zookeeper> yay
20160930 17:32:26< celticminstrel> When were bimap and multi_array added? I don't remember them not being present.
20160930 17:34:01< aquileia> Well, they're header-only, so they don't require separate packages on unix systems, makng it easy to overlook. I only know that I had to add them for my new build
20160930 17:35:41 * vultraz uses the full boost source for his build, since the package-separate step on aquileia's wiki page never gives me all the files I need
20160930 17:36:41< celticminstrel> I think the Mac package similarly includes all the headers.
20160930 17:38:29< aquileia> vultraz: Well, that's because the list is being updated right now
20160930 17:38:47-!- Kwandulin [~Miranda@p5DDD119F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20160930 17:39:14< vultraz> for the record, I also have made use of <boost/algorithm/string.hpp>
20160930 17:40:42< vultraz> can someone tell me why mods are not counted in the [addon] children in lobby_info
20160930 17:42:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 17:43:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 17:43:42< aquileia> BTW, don't pull external right now, I forgot a single file and will just amend the commit
20160930 17:49:29< vultraz> wha...
20160930 17:49:32< vultraz> 		std::string require_attr = "require_" + type;
20160930 17:49:33< vultraz> 		bool require_default = (type == "era"); // By default, eras have "require_era = true", and mods have "require_modification = false"
20160930 17:49:36< vultraz> *confused* :|
20160930 17:49:53< vultraz> oh, I see..
20160930 17:50:13< vultraz> this code seems to deal with mods
20160930 17:50:19< vultraz> but they're not in the data
20160930 17:51:29< vultraz> I feel I'm missing something here
20160930 17:51:43-!- hk238 [~kvirc@unaffiliated/hk238] has quit [Quit: http://www.kvirc.net/ 4.9.2 Aria]
20160930 17:55:06-!- boucman_work [~boucman@bob75-2-81-56-46-209.fbx.proxad.net] has quit [Ping timeout: 264 seconds]
20160930 17:57:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 17:58:20< vultraz> ok, actually, it kinda makes sense
20160930 17:58:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 17:58:42-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 276 seconds]
20160930 17:59:31-!- knotwork [~markm@99.192.64.28] has joined #wesnoth-dev
20160930 17:59:31-!- knotwork [~markm@99.192.64.28] has quit [Changing host]
20160930 17:59:31-!- knotwork [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20160930 18:00:00< vultraz> I...
20160930 18:00:02< vultraz> wait
20160930 18:00:03< vultraz> what???
20160930 18:00:17< vultraz> the game's [modification] children have... an id??
20160930 18:01:03< vultraz> an addon_id would be nice..
20160930 18:01:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 18:02:27-!- louis94 [~~louis94@91.178.242.33] has joined #wesnoth-dev
20160930 18:02:49< vultraz> ok, I have this..
20160930 18:02:59< vultraz> 		for(const config& cfg : game.child_range("modification")) {
20160930 18:03:01< vultraz> 			if(const config& mod = game_config.find_child("modification", "id", cfg["id"])) {
20160930 18:03:05< vultraz> so the game's modification tags
20160930 18:03:11< vultraz> are matched by id with the game config's
20160930 18:03:16< vultraz> which DO have an addon_id key
20160930 18:03:27< vultraz> so I need to copy the addon_id key too..?
20160930 18:04:50< vultraz> I hope this isn't something in the server :|
20160930 18:05:46 * vultraz launches wesnothd instanc
20160930 18:05:48< vultraz> e
20160930 18:07:50-!- mjs-de [~mjs-de@x4db60e13.dyn.telefonica.de] has joined #wesnoth-dev
20160930 18:08:04< aquileia> wedge009, celticminstrel, zookeeper, vultraz: external is updated
20160930 18:08:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 18:10:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 18:11:53-!- Nobun [~nobun@5.170.108.106] has quit [Ping timeout: 272 seconds]
20160930 18:11:54-!- louis94 [~~louis94@91.178.242.33] has quit [Ping timeout: 264 seconds]
20160930 18:15:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 18:17:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 18:18:08-!- JyrkiVesterinen [~JyrkiVest@89-166-108-5.bb.dnainternet.fi] has joined #wesnoth-dev
20160930 18:20:41< irker278> wesnoth: Charles Dang wesnoth:master 39c99d076a29 / data/gui/window/lobby_main.cfg: Lobby: add missing border around player tree https://github.com/wesnoth/wesnoth/commit/39c99d076a292cf3b154d4baaf2800d1301aab6d
20160930 18:20:44< irker278> wesnoth: Charles Dang wesnoth:master 3e45f25d135e / src/server/server.cpp: Send modification addon_id when fetching game info from server https://github.com/wesnoth/wesnoth/commit/3e45f25d135ee0bc30db2f392e223ad9d4598ac8
20160930 18:20:47< irker278> wesnoth: Charles Dang wesnoth:master 09f919e65e4f / src/gui/dialogs/lobby/data.cpp: Lobby: enable downloading of missing eras/mods instead of just disallowing game  https://github.com/wesnoth/wesnoth/commit/09f919e65e4f070a69df3c5404dc40c154b91276
20160930 18:21:10< vultraz> loonycyborg, shadowm ^ server change
20160930 18:21:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 18:23:31< celticminstrel> ...what the heck is set_attr_dup.
20160930 18:23:53< vultraz> don't ask me I understand none of that code
20160930 18:23:57< celticminstrel> Also why is aquileia inviting me?
20160930 18:24:04< vultraz> I just copied the line above it and it works
20160930 18:24:13< vultraz> if it's the wrong way to do this, loonycyborg can fix it
20160930 18:24:28< vultraz> (please :P )
20160930 18:28:54< aquileia> celticminstrel: You did some updates to the vcproj, so I thought it wouldn't hurt to give you access to external as well
20160930 18:35:36-!- Nobun [~nobun@5.170.109.252] has joined #wesnoth-dev
20160930 18:36:39< aquileia> vultraz: BTW, were the golden borders around most text boxes removed deliberately, and if not, does it happen for anybody else?
20160930 18:36:59< vultraz> text boxes should still have borders
20160930 18:37:09< vultraz> do you have a screenshot of what you're seeing?
20160930 18:38:13< celticminstrel> This reminds me of the problems I saw when vultraz started using a renderer for GUI2 canvas.
20160930 18:38:51< celticminstrel> I don't know whether it was the full rebuild or upgrade to SDL 2.0.4 that caused them to go away. If what you're seeing is the same, I suppose it was probably the former.
20160930 18:39:02< celticminstrel> Of course, it might not be the same though...
20160930 18:43:58< aquileia> vultraz: For the attack dialogue: https://ibin.co/2wt1UQzgD0I6.jpg
20160930 18:44:22< vultraz> do you have sdl 2.0.4?
20160930 18:45:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 18:46:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 18:46:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 18:46:46< aquileia> yes, SDL_version.h states 2.0.4
20160930 18:46:52< vultraz> hmmmmm
20160930 18:46:53< vultraz> oddddd
20160930 18:46:55< vultraz> :|
20160930 18:47:08< vultraz> everyone else has had no problems once updating to 2.0.4 :/
20160930 18:49:22< aquileia> vultraz: Ah! It fixed itself after I deleted wesnoth\SDL2.dll (which was probably an older version) so that it uses external/lib/SDL2.dll
20160930 18:49:34< vultraz> :D
20160930 18:49:36< vultraz> sweet!
20160930 18:50:05< aquileia> No idea why that file was there, sorry for the worry
20160930 18:50:59-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20160930 18:50:59-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20160930 18:54:35-!- aquileia [5fd07d56@gateway/web/freenode/ip.95.208.125.86] has quit [Quit: Page closed]
20160930 19:06:47-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20160930 19:07:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160930 19:13:45-!- mjs-de [~mjs-de@x4db60e13.dyn.telefonica.de] has quit [Remote host closed the connection]
20160930 19:18:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 19:20:57-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160930 19:22:57< vultraz> booo const char*
20160930 19:23:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 264 seconds]
20160930 19:26:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160930 19:39:21< irker278> wesnoth: Jyrki Vesterinen wesnoth:master f7ee8884560c / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/f7ee8884560c0b311a3bf4937ea671e2325cb514
20160930 19:40:05< JyrkiVesterinen> Also, I can verify that the game can now be compiled without modifying the aquileia/external repository. :)
20160930 19:40:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 19:42:06< vultraz> after more observation, this listbox issue essentially renders the new lobby useless :|
20160930 19:42:10< vultraz> we *must* fix it
20160930 19:43:53< JyrkiVesterinen> Unfortunately I don't have time to investigate the listbox issue today. It's quite late.
20160930 19:44:06< JyrkiVesterinen> Recompiling the game took long because of the Boost update.
20160930 19:45:16< celticminstrel> I'm probably not going to bother with the Boost update. >_>
20160930 19:45:31< celticminstrel> I filled in all the missing headers from an official release, anyway.
20160930 19:51:11< irker278> wesnoth: Charles Dang wesnoth:master e46fc2faa382 / data/gui/window/mp_staging.cfg: MP Staging: fixed header misalignment https://github.com/wesnoth/wesnoth/commit/e46fc2faa382c7c025541e0ee8e470d1c1177d54
20160930 19:53:58< irker278> wesnoth: Jyrki Vesterinen wesnoth:master 8b5791c657cf / src/ (SDL_SavePNG/savepng.c random_new.cpp): Fix two MSVC compiler warnings https://github.com/wesnoth/wesnoth/commit/8b5791c657cf5a653e1240f0e57c754b92b5f0f3
20160930 19:57:12< vultraz> celticminstrel: any chance you could look into the faction dialog not appearing in game join
20160930 20:01:06-!- Nobun [~nobun@5.170.109.252] has quit [Ping timeout: 264 seconds]
20160930 20:09:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 20:16:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 20:20:57-!- Nobun [~nobun@5.170.109.170] has joined #wesnoth-dev
20160930 20:22:00-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20160930 20:26:50-!- Nobun [~nobun@5.170.109.170] has quit [Ping timeout: 244 seconds]
20160930 20:39:16< vultraz> anyone here speak german?
20160930 20:40:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160930 20:41:49< matthiaskrgr> nein
20160930 20:42:44< vultraz> got a pr from someone who said they could communicate better in german
20160930 20:42:47< vultraz> pm*
20160930 20:42:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 20:42:58< vultraz> though I can understand his english fine
20160930 20:45:45-!- Nobun [~nobun@5.170.108.34] has joined #wesnoth-dev
20160930 20:46:07-!- JyrkiVesterinen [~JyrkiVest@89-166-108-5.bb.dnainternet.fi] has quit [Quit: .]
20160930 20:51:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20160930 20:53:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160930 20:59:02-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20160930 21:04:08< vultraz> hm\
20160930 21:04:13< vultraz> the dialog reaches end of pre_show
20160930 21:04:18< vultraz> but doesn't show up
20160930 21:04:21< vultraz> interesting
20160930 21:15:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20160930 21:15:34< vultraz> i wonder if the loadscreen is not getting closed properly.
20160930 21:17:47< vultraz> or maybe it's because I'm opening 2 dialogs inside the post_build function of another
20160930 21:19:45< vultraz> no, putting it in pre_show doesn't work either
20160930 21:20:10 * vultraz is puzzled :|
20160930 21:26:06-!- ancestral [~ancestral@8.42.164.20] has joined #wesnoth-dev
20160930 21:35:45-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20160930 21:41:57-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20160930 21:49:36-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20160930 21:59:05-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20160930 21:59:45-!- gfgtdf [~chatzilla@x4e36a2c0.dyn.telefonica.de] has joined #wesnoth-dev
20160930 22:01:10-!- Duthlet [~Duthlet@dslb-146-060-179-135.146.060.pools.vodafone-ip.de] has quit [Quit: leaving]
20160930 22:01:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20160930 22:01:48-!- wedge010 is now known as wedge009
20160930 22:03:07-!- ancestral [~ancestral@8.42.164.20] has quit [Quit: i go nstuf kthxbai]
20160930 22:03:29< celticminstrel> Huh, I didn't know about std::random_device.
20160930 22:07:05< vultraz> entropyyyyy
20160930 22:07:51-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20160930 22:09:42< gfgtdf> hmm it seems like random files on my disk are corrupted :(
20160930 22:09:48< gfgtdf> anyonw knows what do do?
20160930 22:10:10< shadowm> I'd run in circles like a headless chicken.
20160930 22:10:15< gfgtdf> i want to know whtehr this is 1) a hardrare error 2) a virus, 3) something else.
20160930 22:11:16< shadowm> Windows is really stupid out-of-the-box when it comes to diagnostic failing disk drives in my experience.
20160930 22:11:35< gfgtdf> i just wanted to start wesnoth and it the file Rivers.cfg from some addons was replaced by this http://pastebin.com/Sc3sAcw9
20160930 22:11:43< shadowm> By which I mean it doesn't come with any tools and it doesn't always log errors to the system event log.
20160930 22:11:52< shadowm> *diagnosing
20160930 22:11:57< gfgtdf> also multiple programms cant start becasue of some unkonw erros which migth have teh same cause
20160930 22:12:19< zookeeper> gfgtdf, whatever it is, it's... bad
20160930 22:12:22< shadowm> That looks like corruption at the filesystem level.
20160930 22:12:51< vultraz> O_O
20160930 22:12:56< vultraz> oh mah gawd
20160930 22:14:14< shadowm> vultraz: Since loonycyborg seems to be dying to a flu or something I rebuilt the trunk server for you.
20160930 22:14:31< shadowm> I am assuming you know what you are doing because honestly I don't have time to review the change.
20160930 22:14:32< vultraz> thanks
20160930 22:15:06< shadowm> So yeah, hopefully it's not a backdoor in disguise I just deployed.
20160930 22:15:22< gfgtdf> shadowm: does linux have useful tools to check a windows filesystem?
20160930 22:15:24< shadowm> Otherwise there would be some severe consequences and not only for me.
20160930 22:15:31< shadowm> gfgtdf: No.
20160930 22:16:03< vultraz> shadowm: it's a very simple change and I have confirmed it works
20160930 22:16:06< vultraz> as expected
20160930 22:16:08< shadowm> There's no way it can have 100% reliable tools to check a proprietary filesystem whose internals are undocumented.
20160930 22:16:29< shadowm> So when things seem dodgy you are usually just told to run chkdsk on Windows.
20160930 22:16:47< shadowm> *undocumented and subject to change without prior notice
20160930 22:19:58< gfgtdf> shadowm: hmm i'll just do that then first.
20160930 22:22:19< shadowm> Hopefully as any good tech-savvy person who deals with computers and programmings you've got full backups done well in advance and regularly.
20160930 22:23:25< shadowm> Because in my experience, if NTFS' data structures get corrupted, you can assume that you will lose _at least_ half your files.
20160930 22:24:29< shadowm> Including OS files, obviously.
20160930 22:24:44< shadowm> *programming
20160930 22:24:48 * shadowm is off again.
20160930 22:25:17< gfgtdf> shadowm: hmm but windows itself still works.
20160930 22:25:34< gfgtdf> shadowm: you think that more and mor files will get corruppted soon?
20160930 22:28:48< zookeeper> if something that weird happens then anything's possible
20160930 22:35:12< gfgtdf> hmm right.
20160930 22:38:19< zookeeper> i'd imagine none of us here have the expertise to rule out the possibility of a virus or similar
20160930 22:41:41-!- Nobun [~nobun@5.170.108.34] has quit [Ping timeout: 272 seconds]
20160930 22:42:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160930 22:54:07-!- irker278 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20160930 22:55:09-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20160930 23:30:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 23:32:42-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20160930 23:32:54-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 264 seconds]
20160930 23:33:04-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20160930 23:33:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20160930 23:33:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20160930 23:46:40-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20160930 23:54:25-!- travis-ci [~travis-ci@ec2-54-160-146-22.compute-1.amazonaws.com] has joined #wesnoth-dev
20160930 23:54:26< travis-ci> aquileia/wesnoth#55 (master - 8b5791c : Jyrki Vesterinen): The build passed.
20160930 23:54:26< travis-ci> Build details : https://travis-ci.org/aquileia/wesnoth/builds/164176687
20160930 23:54:26-!- travis-ci [~travis-ci@ec2-54-160-146-22.compute-1.amazonaws.com] has left #wesnoth-dev []
20160930 23:57:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20160930 23:59:23-!- Bonobo [~Bonobo@2001:44b8:254:3200:e0a6:5b44:12fb:1a5e] has joined #wesnoth-dev
--- Log closed Sat Oct 01 00:00:50 2016