--- Log opened Fri Oct 07 00:00:02 2016
20161007 00:00:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 00:02:29< vultraz> since it seems slightly out-of-color-scheme
20161007 00:09:46-!- gfgtdf_ [~chatzilla@x4e3691d5.dyn.telefonica.de] has joined #wesnoth-dev
20161007 00:11:23< DeFender1031> vultraz, yeah, the color seems a little off. Also, is the gold bar only on the left intentional?
20161007 00:11:30-!- gfgtdf__ [~chatzilla@x4e3691d5.dyn.telefonica.de] has joined #wesnoth-dev
20161007 00:11:33-!- gfgtdf__ [~chatzilla@x4e3691d5.dyn.telefonica.de] has quit [Client Quit]
20161007 00:12:50-!- gfgtdf [~chatzilla@x4e3691d5.dyn.telefonica.de] has quit [Ping timeout: 244 seconds]
20161007 00:13:15< vultraz> yes
20161007 00:14:08< DeFender1031> strikes me as a little out of place...
20161007 00:15:30-!- gfgtdf_ [~chatzilla@x4e3691d5.dyn.telefonica.de] has quit [Ping timeout: 264 seconds]
20161007 00:15:36< DeFender1031> I think it might look less off to me if the corners matched the gray, not the gold...
20161007 00:16:52< DeFender1031> (Just a suggestion)
20161007 00:25:52< celmin|sleep> I'd expect you to be able to set line thickness somehow in the SDL renderer API, but I haven't looked.
20161007 00:27:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 272 seconds]
20161007 00:32:49-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161007 00:32:55-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161007 00:34:34-!- ancestral [~ancestral@75.168.189.115] has joined #wesnoth-dev
20161007 00:48:33-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161007 00:48:39-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161007 01:13:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 01:18:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161007 02:32:09-!- tad_ [~tadcarluc@173.217.65.103] has quit [Quit: Leaving]
20161007 02:33:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161007 02:42:37-!- ancestral [~ancestral@75.168.189.115] has quit [Quit: i go nstuf kthxbai]
20161007 02:46:20-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 02:49:51-!- irker657 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161007 02:53:41< vultraz> celmin|sleep: isn't this supposed to be marked  = delete  https://github.com/wesnoth/wesnoth/blob/master/src/quit_confirmation.hpp#L54
20161007 03:00:17-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 03:17:22-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 03:23:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 256 seconds]
20161007 03:27:23-!- irker380 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161007 03:27:23< irker380> wesnoth: Charles Dang wesnoth:master 6c22e41914e6 / src/quit_confirmation.hpp: Quit Confirmation: delete copy and move constructors https://github.com/wesnoth/wesnoth/commit/6c22e41914e6334cfbc9f6aad3319e63b12330f2
20161007 03:35:46-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 03:44:45< celmin|sleep> The C++03 way of making a class non-copyable is to declare the copy constructor private and never implement it. So yeah, it's correct to add =delete there.
20161007 03:53:23-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 04:10:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20161007 04:11:23-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has quit [Ping timeout: 265 seconds]
20161007 04:17:35-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has joined #wesnoth-dev
20161007 04:23:26-!- JyrkiVesterinen [~JyrkiVest@87-100-196-240.bb.dnainternet.fi] has joined #wesnoth-dev
20161007 04:28:26-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 04:34:38-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 04:46:00-!- JyrkiVesterinen [~JyrkiVest@87-100-196-240.bb.dnainternet.fi] has quit [Quit: .]
20161007 04:52:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 04:56:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20161007 04:58:25-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 04:59:31-!- Kwandulin [~Miranda@p200300760F2C71FE515FA4FEE80626AD.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161007 05:10:17-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 05:15:58-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161007 05:20:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161007 05:21:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161007 05:33:33< vultraz> Kwandulin: ping
20161007 05:42:57< Kwandulin> Uh, 0 seconds, if that's what you meant
20161007 05:43:11< vultraz> no, I meant to attract your attention
20161007 05:43:23< Kwandulin> Ah, okay, we'll here you go
20161007 05:43:43< Kwandulin> well*
20161007 05:44:17< vultraz> Kwandulin: i noticed in OoA's  campaign icon you use one of the new elf sprites, but it doesn't have a finished staff. i have a version with a shaded staff if you want to use it https://www.dropbox.com/s/e1ok2bfk3yc6nl9/Vult%20Elves.png?dl=0
20161007 05:45:37< Kwandulin> It looks alot better, yeah
20161007 05:47:12< Kwandulin> But it doesn't quite fit to the campaign. I need some nature oriented staff
20161007 05:49:59< irker380> wesnoth: Charles Dang wesnoth:master 6a28eff9dbe4 / data/gui/widget/window_tooltip_large.cfg: Tooltips: subtle blue tint https://github.com/wesnoth/wesnoth/commit/6a28eff9dbe4b00eef30fb580840f99b466adfab
20161007 05:50:06< vultraz> Kwandulin: ah, ok then
20161007 05:53:15-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161007 05:53:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161007 05:59:52-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161007 06:03:31-!- Bonobo [~Bonobo@2001:44b8:254:3200:f5c0:30d4:12ad:7c70] has joined #wesnoth-dev
20161007 06:17:33-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 06:19:59-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 06:35:14-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 06:40:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 06:44:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161007 06:56:03-!- Kwandulin [~Miranda@p200300760F2C71FE515FA4FEE80626AD.dip0.t-ipconnect.de] has quit [Ping timeout: 256 seconds]
20161007 07:01:20-!- atarocch [~atarocch@ip-48-81.sn2.clouditalia.com] has joined #wesnoth-dev
20161007 07:20:08-!- atarocch [~atarocch@ip-48-81.sn2.clouditalia.com] has quit [Remote host closed the connection]
20161007 07:30:00-!- celmin|sleep [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161007 07:30:44< irker380> wesnoth: Charles Dang wesnoth:master 77ea3b274d1a / data/gui/window/tooltip_large.cfg: Tooltips: enable markup https://github.com/wesnoth/wesnoth/commit/77ea3b274d1a4f0cd2b0f050631bd6a2871b7ca0
20161007 07:37:23< irker380> wesnoth: Charles Dang wesnoth:master da72c43c3b12 / data/gui/window/mp_method_selection.cfg: MP Connect: tweak Host Networked Game tooltip https://github.com/wesnoth/wesnoth/commit/da72c43c3b12a33e0008310fc3c5a01f2f8f499e
20161007 07:46:49< wedge009> Hexes all have numbers on them. Is this deliberate? I presume something's changed in the cfg because I haven't bother recompiling current master yet.
20161007 07:47:26< vultraz> fixed in current master
20161007 07:48:29< wedge009> Okay. I'm already on da72c43c - I presume it'll go away when I recompile.
20161007 07:57:12-!- atarocch [~atarocch@host-93-101-8-142.lottomatica.net] has joined #wesnoth-dev
20161007 07:58:52< irker380> wesnoth: Charles Dang wesnoth:master fa2340413f36 / src/gui/dialogs/multiplayer/ (mp_staging.cpp mp_staging.hpp): MP Staging: update label and button states at start https://github.com/wesnoth/wesnoth/commit/fa2340413f36cdeb8113154c173ec07377ebcf42
20161007 08:25:13-!- Kwandulin [~Miranda@p200300760F2C7117AD01C92ACC8410EA.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161007 08:27:30< Kwandulin> So you did take another look at OoA, vultraz?
20161007 08:27:52< vultraz> not yet, no
20161007 08:28:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 08:29:23-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20161007 08:31:55< wedge009> Has it changed?
20161007 08:33:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161007 08:35:01< Kwandulin> wedge009: Yes, a lot. There's more focus on the sphere-thingy, but I guess you didn't like that too much
20161007 08:35:31< wedge009> Okay, I just remember you saying I should wait till you've updated it post-1.13.5.
20161007 09:00:31< irker380> wesnoth: Wedge009 wesnoth:master 807f8d21447d / src/minimap.cpp: Avoid dereference of iterator end. https://github.com/wesnoth/wesnoth/commit/807f8d21447d4057821e37df1afbceb5b14661be
20161007 09:00:33< irker380> wesnoth: Wedge009 wesnoth:master 4600614f6d81 / changelog src/display.cpp: Avoid rare cases of mini-map producing a divide-by-zero error (bug #25155) https://github.com/wesnoth/wesnoth/commit/4600614f6d8112e92faef9e5884250c9923709a5
20161007 09:14:07-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20161007 09:20:44-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161007 09:23:30-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161007 09:57:09-!- RatArmy [~RatArmy@om126211120152.13.openmobile.ne.jp] has joined #wesnoth-dev
20161007 10:11:45< Kwandulin> Is there even an option to add icons for custom races? Currently, the whole feature feels so half-baked
20161007 10:12:09< Kwandulin> I do like the idea of race icons, though
20161007 10:14:21< zookeeper> presumably you'd just add new icons/unit-groups/race_foobar_* images
20161007 10:14:32< zookeeper> and they'd get used automatically for race foobar
20161007 10:16:22< zookeeper> but yes, i expect vultraz to get rid of them and the alignment icons as well, after a sufficient period of not wanting to remove them yet has elapsed
20161007 10:16:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 10:19:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161007 10:21:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161007 10:24:37< vultraz> Kwandulin: what zookeeper said
20161007 10:24:41< vultraz> about usage
20161007 10:25:31< vultraz> zookeeper: why would I remove them?
20161007 10:26:18< zookeeper> do you have no recollection of this being discussed many times before?
20161007 10:26:47< vultraz> i do
20161007 10:26:56< vultraz> but you imply I would want to remove them
20161007 10:29:17< zookeeper> 1) text is easier to understand, 2) images make UMC harder, 3) icons for 2 arbitrary things but nothing else looks weird
20161007 10:30:52< zookeeper> 4) visual inconsistency between places where the icons are used and the places they're not used
20161007 10:41:50-!- Kwandulin [~Miranda@p200300760F2C7117AD01C92ACC8410EA.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161007 10:52:21-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 256 seconds]
20161007 10:57:28< matthiaskrgr> something is wrong with this aquatic castle
20161007 10:57:48< matthiaskrgr> or maybe I'm doing it wrong
20161007 10:58:46< matthiaskrgr> http://imgur.com/a/o5I8L  
20161007 11:00:57-!- RatArmy [~RatArmy@om126211120152.13.openmobile.ne.jp] has quit [Quit: Leaving]
20161007 11:02:52< zookeeper> yeah you can't currently properly mix the camps and castles
20161007 11:04:09< matthiaskrgr> ah, I mixed the aquiatic camp/castles 
20161007 11:07:46< matthiaskrgr> this looks a bit weird imo  http://imgur.com/a/ZSy2A  
20161007 11:11:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161007 11:15:06-!- Kwandulin [~Miranda@p200300760F2C711705ABF997EB532C06.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161007 11:24:47< irker380> wesnoth: Charles Dang wesnoth:master 628c0ac78490 / / (3 files in 2 dirs): Unit Preview Pane: display race name next to icon instead of in tooltip https://github.com/wesnoth/wesnoth/commit/628c0ac7849008bc07dd14a304824c283ad7834e
20161007 11:24:51< matthiaskrgr> m
20161007 11:24:59< matthiaskrgr> apparently the editor can generate invalid maps somehow
20161007 11:25:01< vultraz> zookeeper: ^
20161007 11:25:19< matthiaskrgr> 20161007 13:24:35 error config: map could not be loaded: Illegal tile in map: () ''
20161007 11:25:29< zookeeper> matthiaskrgr, pastebin the map?
20161007 11:25:54-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has quit [Ping timeout: 265 seconds]
20161007 11:26:40< vultraz> zookeeper: you happy now?
20161007 11:27:16< matthiaskrgr> it's a scenario
20161007 11:27:25< matthiaskrgr> (I tried breaking the editor ^^ ) 
20161007 11:27:42< matthiaskrgr> http://pastebin.com/hFmev7DD  
20161007 11:28:14< zookeeper> well, i know nothing of the scenario editor or its quirks
20161007 11:29:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161007 11:29:54< matthiaskrgr> zookeeper: you can load the scenario in the editor, save the map as map and try to load that one
20161007 11:29:59< matthiaskrgr> assertion will still fail 
20161007 11:30:04< matthiaskrgr> wesnoth: /usr/include/boost/dynamic_bitset/dynamic_bitset.hpp:633: boost::dynamic_bitset<Block, Allocator>::~dynamic_bitset() [with Block = long unsigned int; Allocator = std::allocator<long unsigned int>]: Assertion `m_check_invariants()' failed.
20161007 11:32:36< zookeeper> works just fine for me
20161007 11:32:55< zookeeper> if you get an crash from loading a map, then you should pastebin that map
20161007 11:33:22< matthiaskrgr> hm strange
20161007 11:33:27< zookeeper> well, s/crash/error
20161007 11:33:58< zookeeper> vultraz, not really
20161007 11:34:08< vultraz> zookeeper: why not
20161007 11:34:31< zookeeper> because of the 4 reasons i already listed
20161007 11:34:48< zookeeper> except maybe scratch 1) off the list if you insist
20161007 11:35:11< vultraz> 2 is invalid
20161007 11:35:15< vultraz> 3 is invalid
20161007 11:35:16< vultraz> 4 can be fixed
20161007 11:35:43< zookeeper> how exactly are those invalid?
20161007 11:36:35< vultraz> if there's text, no icon appears
20161007 11:36:41< vultraz> er
20161007 11:36:45< vultraz> no icon appearing isn't a problem
20161007 11:37:27< vultraz> 3 isn't a problem 
20161007 11:38:02< vultraz> because other things aren't really icon-friendly
20161007 11:38:37< zookeeper> well yes it is a visual problem if some units have some kind of cartoon face next to their race, and some others don't because uhh what does that cartoon face actually do anyway?
20161007 11:39:01< matthiaskrgr> ok, it happens when resizing maps, the editor expands the map, but does not insert tiles, or something like that 
20161007 11:39:15< vultraz> it makes us look more elegant and less like a clunky linux text-based game
20161007 11:39:21< zookeeper> good grief
20161007 11:39:24< zookeeper> stop being like that
20161007 11:39:39< zookeeper> no one else but you wants those dumb-ass faces in
20161007 11:42:26-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20161007 11:43:29-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161007 11:43:47< vultraz_iOS> :(
20161007 11:44:37< vultraz_iOS> Then the solution is to improve the icons
20161007 11:47:46< zookeeper> you have never had any rationale for the icons beyond "i think it looks more professional/elegant/modern/dota/apple/whatever" and you just keep regurgitating that over and over again
20161007 11:48:10< vultraz_iOS> Because that's a perfectly valid reason
20161007 11:48:24< vultraz_iOS> What do you want me to say
20161007 11:48:44< vultraz_iOS> The icons give you the location of fountain of youth?
20161007 11:49:27< vultraz_iOS> What's the reason for using icons anywhere?
20161007 11:49:32< vultraz_iOS> Why not text for every button?
20161007 11:50:22< vultraz_iOS> Seriously, I don't know what you want me to say
20161007 11:53:13< vultraz_iOS> Hm?
20161007 11:53:13< vultraz_iOS> It's like it's not the fact that there was no text
20161007 11:53:13< vultraz_iOS> You care that the icon is there at all
20161007 11:54:25< DeFender1031> In general, "icons vs. text" is a stylistic argument, not a procedural one, and is therefore generally a matter of opinion and contemporary trends, not fact. You can't really have a debate conforming to the formal rules of discourse over matters of opinion.
20161007 11:55:36< DeFender1031> It's not like saying "you can't change this algorithm because it will break this specific case", which is either verifiably true or false.
20161007 11:56:23< zookeeper> vultraz_iOS, what i care is that these things are displayed in a readable and compact manner. text only gives you both, icons only gives you only the latter, icons+text only the former.
20161007 11:57:21< DeFender1031> zookeeper, "compact" is relative.
20161007 11:57:39< zookeeper> icons+text takes up more space than only text, while providing no concrete benefit in readability, moddability, etc.
20161007 11:58:25< DeFender1031> what's your "etc."? Because if it includes "aesthetics", then that's debatable.
20161007 11:59:21< zookeeper> it's for more concrete benefits, that is excluding subjective aesthetics
20161007 11:59:26< DeFender1031> oh, i'd also say "usability". Icons are more quickly interpreted by the brain than text, once a user is used to the icons' meanings.
20161007 12:00:27< DeFender1031> Meaning, text+icons provides proper signposting when a user is new to the interface, and a mental shortcut once a user becomes more familiar with it
20161007 12:00:57< zookeeper> and why do we use icons anywhere? well, where do we use them? basically the attack icons are the only other thing i can think of where we encode in-universe information into technically redundant icons that are there pretty much only for aesthetics.
20161007 12:01:24-!- travis-ci [~travis-ci@ec2-54-211-81-122.compute-1.amazonaws.com] has joined #wesnoth-dev
20161007 12:01:25< travis-ci> wesnoth/wesnoth#11364 (master - 628c0ac : Charles Dang): The build passed.
20161007 12:01:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/165785066
20161007 12:01:25-!- travis-ci [~travis-ci@ec2-54-211-81-122.compute-1.amazonaws.com] has left #wesnoth-dev []
20161007 12:01:45< zookeeper> DeFender1031, well, i'd disagree with the notion that icons are faster for the brain than single words.
20161007 12:02:10< DeFender1031> zookeeper, I recommend reading https://www.amazon.com/Designing-Mind-Simple-Understanding-Interface/dp/012375030X (or its second edition which i have not read)
20161007 12:03:03< DeFender1031> zookeeper, I'm pretty sure that the fact that the brain processes familiar images faster than text has been proven in many studies.
20161007 12:05:12< zookeeper> i mean, your brain doesn't need to spend extra time "reading" single words, you learn to pattern-match the shapes the same way as you learn to pattern-match icons. drastic changes in font notwithstanding, i suppose.
20161007 12:05:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 12:06:43< DeFender1031> Possibly. Depends on the length of the word. It also takes longer for the brain to develop a pattern match for words than for images.
20161007 12:08:06< DeFender1031> In addition, "compact" is nice, but if you have the real estate to add icons for a set of buttons, why not? It makes it look nicer, potentially makes it more usable, and has no downside.
20161007 12:08:37< zookeeper> maybe. but in any case the difference, whichever way it swings, is so miniscule that it doesn't really affect one's experience of the interface as far as understandability and usability goes
20161007 12:08:52< DeFender1031> I also find your argument that improving the aesthetics of the game is not a valid reason for changing things strange.
20161007 12:09:14< zookeeper> my emphasis was on the "i think" part
20161007 12:09:25< DeFender1031> Half the changes being made at the moment are aesthetic improvements
20161007 12:09:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161007 12:10:24< DeFender1031> ah, well that goes back to the point about how you can't apply the formal rules of logical discourse to matters of opinion.
20161007 12:10:37< zookeeper> of course
20161007 12:11:07< zookeeper> which is why i've avoided saying "we shouldn't have the icons because i think they don't look nice" :p
20161007 12:11:52< Kwandulin> Adding icons forces UMC creators to add their own ones in case they made a custom race. Otherwise, it'd be filled up with the custom race icon which gives the UMC an "unfinished" flavor
20161007 12:12:06< DeFender1031> no, your argument is "we shouldn't add them because they aren't there already and it's a matter of opinion whether it would be better with them"
20161007 12:13:16< zookeeper> DeFender1031, i don't know where you got that from
20161007 12:13:37< DeFender1031> Kwandulin, creating custom units requires UMC creators to add custom sprites. Creating custom attacks requires UMS creators to add an icon. Creating custom terrains... etc. I don't see this as an issue.
20161007 12:13:51< DeFender1031> zookeeper, then perhaps i misinterpreted something you said.
20161007 12:14:07< zookeeper> vultraz_iOS, compromise suggestion (for now, anyway): use icons+text for both alignment and race, making sure there's enough space for it, and then it'll be easy to remove either icons or text if needs be.
20161007 12:14:51< zookeeper> (as what you just added only adds text to race, and seems like there's no space to do the same for alignment without changing the layout)
20161007 12:21:22< zookeeper> if the prevailing opinion seems to fall on "the icons are nice" then i surely can personally live with having icons+text
20161007 12:21:51< zookeeper> but what i can't live with, and i'm pretty sure the prevailing opinion agrees, is icons only :p
20161007 12:21:52< DeFender1031> then what's the issue?
20161007 12:21:56< DeFender1031> ah
20161007 12:24:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161007 12:25:19< DeFender1031> I tend to agree. Icons-only really only makes sense in one of two cases: 1. with a very limited range of options where any possible option has an icon which clearly and unambiguously means that thing (for example, time of day or whether icons) or 2. where the icon is used alongside the text elsewhere in the program which is more prominent and more often viewed, and the associations can be formed there before the icon-inly 
20161007 12:25:20< DeFender1031> interface is encountered.
20161007 12:27:52< zookeeper> i can live with aesthetic choices i disagree with as long as i'm not expected to personally contribute to them and if the audience actually wants them
20161007 12:30:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161007 12:39:27< DeFender1031> zookeeper, and as long as they don't interfere with usability or other tangible factors.
20161007 12:39:41< DeFender1031> (obviously)
20161007 12:42:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Ping timeout: 265 seconds]
20161007 12:43:25< zookeeper> well yes, if they did then they wouldn't be (only) aesthetic choices anymore
20161007 12:48:02< DeFender1031> true, but my point is also that sometimes things which may appear "aesthetic-only" can sometimes actually have an effect on usability (either positive or negative) because it affects the efficiency of the interface between the software and the biological processing unit.
20161007 13:01:48-!- Kwandulin [~Miranda@p200300760F2C711705ABF997EB532C06.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161007 13:01:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 252 seconds]
20161007 13:07:51-!- Appleman1234_ [~Appleman1@KD106154000036.au-net.ne.jp] has joined #wesnoth-dev
20161007 13:10:01-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161007 13:11:11-!- Appleman1234 [~Appleman1@KD106154006238.au-net.ne.jp] has quit [Ping timeout: 272 seconds]
20161007 13:13:41-!- Appleman1234_ is now known as Appleman1234
20161007 13:33:51-!- Bonobo [~Bonobo@2001:44b8:254:3200:f5c0:30d4:12ad:7c70] has quit [Quit: Leaving]
20161007 14:07:59-!- Kwandulin [~Miranda@p200300760F2C71174574695A3770D4C0.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161007 14:12:30-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 264 seconds]
20161007 14:22:28-!- Netsplit *.net <-> *.split quits: matthiaskrgr, _laco, Lohengramm, pydsigner
20161007 14:22:56-!- Netsplit over, joins: pydsigner
20161007 14:23:40-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-gxfhduvtxvehypbj] has joined #wesnoth-dev
20161007 14:24:03-!- matthiaskrgr is now known as Guest7199
20161007 14:24:59-!- irker380 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161007 14:25:43-!- Guest7199 [matthiaskr@gateway/shell/panicbnc/x-gxfhduvtxvehypbj] has quit [Changing host]
20161007 14:25:43-!- Guest7199 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161007 14:25:43-!- Guest7199 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20161007 14:25:43-!- Guest7199 [matthiaskr@gateway/shell/panicbnc/x-gxfhduvtxvehypbj] has joined #wesnoth-dev
20161007 14:25:53-!- Guest7199 is now known as matthiaskrgr_
20161007 14:25:58-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161007 14:26:22-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-svfkunmtgjyxjtqc] has joined #wesnoth-dev
20161007 14:34:33-!- _laco [~laco@static.183.80.201.138.clients.your-server.de] has joined #wesnoth-dev
20161007 14:39:45-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20161007 14:50:03-!- tad_ [~tadcarluc@173.217.65.103] has joined #wesnoth-dev
20161007 15:00:20-!- DeFender1031 [~DeFender1@89-138-252-80.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20161007 15:04:22-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 265 seconds]
20161007 15:06:06-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161007 15:23:10< mattsc> zookeeper, DeFender1031: Just to recap, we agreed that [filter_vision] should match whatever units a player playing that side would see.
20161007 15:23:17< mattsc> That means that the fix is trivial, because hidden units of an allied side are always visible, no matter what share_vision is set to. (Unless they are under fog/shroud, but that's covered separately.)
20161007 15:23:50< mattsc> I have it fixed locally, just want to do a few more tests later today and then I’ll commit it.
20161007 15:24:22-!- matthiaskrgr_ is now known as matthiaskrgr
20161007 15:27:02-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has joined #wesnoth-dev
20161007 15:28:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161007 15:29:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161007 15:30:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161007 15:34:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161007 15:50:52-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161007 15:53:40< zookeeper> mattsc, great
20161007 15:54:48-!- tad_ [~tadcarluc@173.217.65.103] has quit [Quit: Leaving]
20161007 15:55:59-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20161007 15:57:45-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 272 seconds]
20161007 16:04:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161007 16:08:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 16:15:47-!- atarocch [~atarocch@host-93-101-8-142.lottomatica.net] has quit [Remote host closed the connection]
20161007 16:25:10-!- gfgtdf [~chatzilla@x4e32b4b7.dyn.telefonica.de] has joined #wesnoth-dev
20161007 16:32:50-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161007 16:49:37-!- ancestral [~ancestral@75-168-189-115.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161007 16:55:49< zookeeper> gfgtdf, regarding this issue: <zookeeper> gfgtdf, so, in 1.12 if you have a last breath event which declares defeat, the following die event won't trigger. in 1.13.5, it does.
20161007 16:55:55< zookeeper> gfgtdf, was that something you were intending on looking into?
20161007 16:56:18< zookeeper> the last i heard was that you said you're surprised it worked like that in 1.12 and that you don't know what causes the difference
20161007 17:02:49-!- tad_ [~tadcarluc@173.217.65.103] has joined #wesnoth-dev
20161007 17:09:18< gfgtdf> zookeeper: well first i think its not like follwing events  won't trigger its more liek the endlevel somehow effects which filters pass.
20161007 17:09:51< gfgtdf> zookeeper: i'd assume that the 1.12 behviour was not intended, specialyl since i coudlnt find this anywhere on the wiki.
20161007 17:11:41< zookeeper> so you think a filterless die event would still trigger even in 1.12? i can test that if you want
20161007 17:12:24< gfgtdf> zookeeper: that'd be nice, i curently cannot test it becuase some of my wesnoth files seem to be corupted.
20161007 17:12:45< zookeeper> oh right, you had that... weird problem
20161007 17:12:56< tad_> I would agree with that. However, many last breath events include a kill which should prevent the die event matching. But I would suggest it should still trigger die.
20161007 17:12:59< zookeeper> i hope you have a new hard drive at least? :P
20161007 17:14:14< gfgtdf> zookeeper: hmm no not yet, i think i should just buy a new pc since this one is already 10 years old.
20161007 17:15:05< zookeeper> well, in that case i hope you at least have backups
20161007 17:15:32< zookeeper> anyway, even a filterless die event _doesn't_ trigger in 1.12 after a last breath event has declared defeat
20161007 17:15:59< tad_> What about victory?
20161007 17:17:43< zookeeper> same
20161007 17:19:32< zookeeper> i realize the wiki doesn't specify it, but i think it's intended behavior because it makes sense that after victory/defeat is declared, no further events trigger. the scenario is over, stuff doesn't happen anymore (except for victory/defeat events).
20161007 17:19:32< tad_> At least it's consistent. Next question: does the filter-matches die event appear before or after the defeat or victory event? It seems it should occur before and the missed event is unintended; but if after, that could explain the problem.
20161007 17:20:12< gfgtdf> zookeeper: what about attack_end events?
20161007 17:21:38-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161007 17:22:01< zookeeper> gfgtdf, they trigger before last breath i think?
20161007 17:22:06< tad_> I would propose that, given 2 sides, a die with no filter should behave the same as a die using [filter]side=1,2
20161007 17:25:47-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 272 seconds]
20161007 17:25:48-!- wedge010 is now known as wedge009
20161007 17:27:35< gfgtdf> zookeeper: hmm ok, coudl you please try how this evnet haveves on 1.12 http://pastebin.com/AgRq6rQ7 ?
20161007 17:30:16< zookeeper> i see neither message
20161007 17:31:38-!- JyrkiVesterinen [~JyrkiVest@87-100-214-254.bb.dnainternet.fi] has joined #wesnoth-dev
20161007 17:33:34< gfgtdf> zookeeper: hmm this suproses me.
20161007 17:33:43-!- atarocch [~atarocch@host86-89-dynamic.27-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20161007 17:34:14< gfgtdf> zookeeper: is there a a secodn last breath event in the scenario that you used for testing ?
20161007 17:34:59< zookeeper> only a few filtered ones which wouldn't have triggered with these units
20161007 17:35:29< zookeeper> huh
20161007 17:35:31< zookeeper> weird
20161007 17:36:17< zookeeper> i changed it to this form and now i see the first message: http://pastebin.com/bQ6ff2JQ
20161007 17:36:47< zookeeper> it's not just the missing speaker= in your code, but apparently the [if] checks didn't pass
20161007 17:39:31< gfgtdf> zookeeper: hm no idea why teh if check didnt pass
20161007 17:39:40< zookeeper> maybe [have_unit] simply ignores "dying" units which don't have positive hp?
20161007 17:41:31-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161007 17:41:36< gfgtdf> zookeeper: coudl you please try this code http://pastebin.com/vTTA0Xvg ?
20161007 17:41:56< zookeeper> most certainly
20161007 17:42:58< zookeeper> i see message1
20161007 17:43:17< gfgtdf> zookeeper: i just cheked that have_unit does ineed a hp > 0 check: https://github.com/wesnoth/wesnoth/blob/1.12/src/game_events/conditional_wml.cpp#L76
20161007 17:43:35< zookeeper> ok so that was an unrelated problem
20161007 17:45:00< zookeeper> (and i'm not saying it's a problem that needs fixing)
20161007 17:48:03< tad_> Yes, [have_unit] does not match units with HP==0
20161007 17:48:49< tad_> That is documented in the Wiki
20161007 17:50:44-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161007 17:51:41< zookeeper> gfgtdf, so, that [filter] thing is pretty weird
20161007 17:53:28< gfgtdf> zookeeper: to mess it seems like [endlevel] somhow kills the currnt unit on 1.12 (which hen aborts the dying unit event chain so that die events are not fired), to me this is quite counterintuitive. I'd porpose theat people shodul just explicitly use [kill] id= $unit.id fire_event=no, if they really want this
20161007 17:55:02< zookeeper> gfgtdf, how could [endlevel] have any notion of "the current unit"?
20161007 17:55:09< zookeeper> it can be used anywhere
20161007 17:56:18< gfgtdf> zookeeper: hmm not sure, maybe this only happens if it's used in last breath or die events?
20161007 17:56:58< gfgtdf> zookeeper: there are multple action wml tags that like [object] that use the 'current unit' if possible.
20161007 17:57:23< zookeeper> well it seems pretty unlikely that the 1.12 code for [endlevel] would check what kind of event it's being fired from and then do some weird unit hack if it's from a death-related event?
20161007 17:57:37-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: KABOOM! It seems that I have exploded. Please wait while I reinstall the universe.]
20161007 17:57:58-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161007 17:59:12< zookeeper> ah
20161007 17:59:25< zookeeper> there is something like that there
20161007 18:00:07< zookeeper> https://github.com/wesnoth/wesnoth/blob/1.12/src/game_events/action_wml.cpp#L713
20161007 18:01:04< gfgtdf> zookeeper: hmm yes i think thtis code was removed in 1.13 since the menationed bug in linger doesnt happen anyore.
20161007 18:03:31< zookeeper> urgh, what a mess...
20161007 18:05:26< zookeeper> ok, so why doesn't a filterless die event trigger in 1.12 but does in 1.13? that can't be related to removing 0-hp units
20161007 18:06:14< gfgtdf> zookeeper: it is, removign unit stops the die event from beeing fired.
20161007 18:06:31< gfgtdf> zookeeper: since teh unit is removed in the last breash event which happens bwfpore the die event is fired
20161007 18:06:34< zookeeper> oh, duh, yeah of course. i wasn't thinking straight.
20161007 18:09:54< zookeeper> it also leads to a little bug in 1.12 where the dying unit just disappears on defeat, instead of playing its death animation
20161007 18:10:56 * tad_ points out that it very common to see [kill] in a last breath event
20161007 18:11:07< zookeeper> yep
20161007 18:15:54< zookeeper> the main problem i'm worrying about is, like in TRoW:06, a last breath event declaring victory/defeat (very very common) and an unrelated die event for some mundane death commentary or such.
20161007 18:16:08< zookeeper> it's not like we can easily search for those kinds of uses
20161007 18:22:34< tad_> zookeeper, I beleive we would find something like that if we looked. I'm fairly sure I've seen it. Probably in DM, possible in HttT. It would be a bit wierd-feeling, though to have last-breath declare endlevel and die to do the speaking about it, but I think I've seen something like that and it's not un-reasonable, just un-expected.
20161007 18:23:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161007 18:24:39< zookeeper> tad_, well i mean cases which have changed behavior since 1.12, such as the TRoW case. sure, the current behavior is technically reasonable.
20161007 18:26:04< tad_> Well, I would expect a [filter]-less die event to work the same as a die event where the [filter] matches any unit for all possible sides, regardless of other factors such as endlevel appearing.
20161007 18:26:08< zookeeper> i suppose we can comb mainline for similar cases
20161007 18:31:53< zookeeper> tad_, it doesn't matter how it works, what matters is how we find existing cases where the change in behavior between 1.12 and 1.13 leads to a problem
20161007 18:32:54< zookeeper> the only method i can think of is manually combing through all die events :p
20161007 18:33:11< gfgtdf> zookeeper: 'combing' ?
20161007 18:34:29< gfgtdf> zookeeper: nevermng i just thaugt that was some kindof abbrevation
20161007 18:34:34< gfgtdf> nevermind*
20161007 18:34:56< zookeeper> https://www.youtube.com/watch?v=MtkK3eijBso
20161007 18:35:02< tad_> He means one of us will have to code-read the die events to find if there are any which lack filters.
20161007 18:36:26< zookeeper> or rather, have filters which would match the unit for which a defeat/victory-declaring last breath event might have been triggered
20161007 18:37:24< gfgtdf> zookeeper: maybe instead of changing the wml we could 'fix' http://gna.org/bugs/?15113
20161007 18:39:12< gfgtdf> zookeeper: we coudl just add some "if wesnoth.current.eventname !="die" or wesnoth.current.unit1 != unit " in the lua message imcplcmnation
20161007 18:39:19< gfgtdf> implementation*
20161007 18:40:13< zookeeper> well the problem in a scenario might not be because the dying unit speaks in the die event, it could be any unit, or something else that the die event does
20161007 18:40:37< zookeeper> so i think they still need to be fixed in the scenarios
20161007 18:41:08< tad_> stylisticly: if (event != die OR dieingUnit != speaker) 
20161007 18:41:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 18:41:54-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161007 18:42:09< tad_> celticminstrel, ^
20161007 18:42:19< celticminstrel> ???
20161007 18:42:19< gfgtdf> zookeeper: hmm well, but its likeley that in most of those other cases it actualyl mkaes more sense if the die events also fired in case of an [endlevel9
20161007 18:42:49< tad_> A suggestion for Lua message to prevent unit being speaker in it's own die event
20161007 18:43:26< zookeeper> gfgtdf, sure... and currently they do fire
20161007 18:43:58-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161007 18:50:26 * zookeeper takes a timeout
20161007 18:57:03-!- Netsplit *.net <-> *.split quits: gfgtdf, Gambit, vultraz, prkc, enchi, knotwork, Ivanovic, midzer
20161007 18:57:03-!- Grickit [~derek@wesnoth/developer/grickit] has joined #wesnoth-dev
20161007 18:57:09-!- Netsplit over, joins: enchi
20161007 18:57:12-!- Netsplit over, joins: midzer
20161007 18:57:12-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161007 18:57:19-!- Netsplit over, joins: prkc, gfgtdf
20161007 18:57:19-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161007 18:57:19-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161007 18:57:19-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161007 18:57:28-!- Netsplit over, joins: knotwork
20161007 19:01:57-!- abruanese [~a@45.63.97.181] has quit [Ping timeout: 276 seconds]
20161007 19:02:35-!- irker872 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161007 19:02:35< irker872> wesnoth: mattsc wesnoth:master 6222f18ed229 / src/units/filter.cpp: [filter_vision]: fix bug of filter not matching own/allied hidden units https://github.com/wesnoth/wesnoth/commit/6222f18ed22928705c002ffd7073e9b8451878b5
20161007 19:02:52< mattsc> zookeeper, DeFender1031: ^
20161007 19:05:08-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161007 19:05:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161007 19:06:40-!- abruanese [~a@45.63.97.181] has joined #wesnoth-dev
20161007 19:08:47-!- Netsplit *.net <-> *.split quits: ToBeCloud
20161007 19:08:50-!- Netsplit *.net <-> *.split quits: wedge009, JyrkiVesterinen, ChipmunkV
20161007 19:08:54-!- Netsplit *.net <-> *.split quits: AI0867, Jetrel
20161007 19:08:56-!- Netsplit *.net <-> *.split quits: aeth
20161007 19:09:02-!- Netsplit over, joins: AI0867
20161007 19:09:11-!- Netsplit over, joins: wedge009, aeth, ChipmunkV
20161007 19:09:41-!- Netsplit over, joins: Jetrel
20161007 19:09:55-!- Netsplit over, joins: JyrkiVesterinen
20161007 19:18:41< celticminstrel> Well, the wiki already warns against messages in the die event, so I suppose you could make them not work at all somehow...
20161007 19:19:08-!- Netsplit over, joins: pydsigner
20161007 19:19:08-!- Netsplit *.net <-> *.split quits: atarocch, vincent_c, Lohengramm, esr
20161007 19:19:11-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20161007 19:19:12-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20161007 19:19:12-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20161007 19:19:18-!- Netsplit over, joins: vincent_c
20161007 19:19:26-!- Netsplit over, joins: atarocch
20161007 19:23:40-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-nxfkdovcndiaocrk] has joined #wesnoth-dev
20161007 19:25:24-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161007 19:32:28-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161007 19:32:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 19:33:37-!- Netsplit over, joins: Polsaker
20161007 19:33:37-!- Netsplit *.net <-> *.split quits: nore, Duthlet
20161007 19:34:30-!- Netsplit over, joins: nore
20161007 19:37:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161007 19:40:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 248 seconds]
20161007 19:44:55-!- JyrkiVesterinen [~JyrkiVest@87-100-214-254.bb.dnainternet.fi] has quit [Quit: .]
20161007 19:47:16-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Excess Flood]
20161007 19:47:43-!- Netsplit *.net <-> *.split quits: celticminstrel, Appleman1234, zookeeper
20161007 19:47:57-!- Netsplit *.net <-> *.split quits: iwaim_____, heirecka, higgins, elias, oldlaptop, aidanhs, Rhonda, tomreyn, Elvish_Hunter, Soliton
20161007 19:47:57-!- Rh0nda [~rhonda@anguilla.debian.or.at] has joined #wesnoth-dev
20161007 19:48:17-!- Netsplit over, joins: celticminstrel, Elvish_Hunter, zookeeper
20161007 19:48:17-!- iwaim_____ [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20161007 19:48:31-!- Netsplit over, joins: tomreyn, heirecka, elias
20161007 19:48:35-!- Netsplit over, joins: Soliton
20161007 19:48:49-!- Netsplit over, joins: aidanhs
20161007 19:49:11-!- Netsplit over, joins: higgins
20161007 19:50:02-!- Netsplit over, joins: oldlaptop
20161007 19:50:21-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-nxfkdovcndiaocrk] has quit [Read error: Connection reset by peer]
20161007 19:51:39-!- Kwandulin [~Miranda@p200300760F2C71174574695A3770D4C0.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161007 19:55:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161007 19:56:36-!- lobby [~wesnoth@wesnoth/bot/lobby] has joined #wesnoth-dev
20161007 19:56:36-!- Topic for #wesnoth-dev: 1.13.6 planned for Friday, October 14th | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161007 19:56:36-!- Topic set by vultraz [~chatzilla@wesnoth/developer/vultraz] [Thu Oct  6 04:21:01 2016]
20161007 19:56:36[Users #wesnoth-dev]
20161007 19:56:36[ _laco         ] [ ChipmunkV      ] [ gfgtdf    ] [ Jetrel_bot  ] [ oldlaptop] [ tad_     ] 
20161007 19:56:36[ abruanese     ] [ crimson_penguin] [ Grickit   ] [ kidneb      ] [ Polsaker ] [ TC01     ] 
20161007 19:56:36[ aeth          ] [ DDR            ] [ heirecka  ] [ knotwork    ] [ prkc     ] [ TheJJ    ] 
20161007 19:56:36[ AI0867        ] [ elias          ] [ higgins   ] [ lobby       ] [ pydsigner] [ tomreyn  ] 
20161007 19:56:36[ aidanhs       ] [ EliDupree      ] [ irker872  ] [ matthiaskrgr] [ Ravana_  ] [ vincent_c] 
20161007 19:56:36[ APic          ] [ Elsi           ] [ Ivanovic  ] [ midzer      ] [ Rh0nda   ] [ vultraz  ] 
20161007 19:56:36[ atarocch      ] [ Elvish_Hunter  ] [ iwaim_____] [ new_one     ] [ Sirp     ] [ wedge009 ] 
20161007 19:56:36[ bumbadadabum  ] [ enchi          ] [ janebot   ] [ nore        ] [ Soliton  ] [ Yaiyan   ] 
20161007 19:56:36[ celticminstrel] [ esr            ] [ Jetrel    ] [ nurupo      ] [ stikonas_] [ zookeeper] 
20161007 19:56:36-!- Irssi: #wesnoth-dev: Total of 54 nicks [0 ops, 0 halfops, 0 voices, 54 normal]
20161007 19:56:37-!- Aginor [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20161007 19:56:37-!- Aginor [~andreas@apollo.alternating.net] has quit [Changing host]
20161007 19:56:37-!- Aginor [~andreas@unaffiliated/aginor] has joined #wesnoth-dev
20161007 19:56:41-!- timotei [~timotei@wesnoth/developer/timotei] has joined #wesnoth-dev
20161007 19:56:43-!- Channel #wesnoth-dev created Tue Jan 27 05:28:41 2009
20161007 19:56:45-!- clavi [~clavi@163-172-10-77.rev.poneytelecom.eu] has joined #wesnoth-dev
20161007 19:56:52-!- minzbonbon [~min@meta23.net] has joined #wesnoth-dev
20161007 19:56:53-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20161007 19:56:59-!- loonycyborg [~loonycybo@wesnoth/developer/loonycyborg] has joined #wesnoth-dev
20161007 19:57:08-!- Greywhind [~Greywhind@c-71-232-29-126.hsd1.ma.comcast.net] has joined #wesnoth-dev
20161007 19:57:49-!- Irssi: Join to #wesnoth-dev was synced in 83 secs
20161007 20:03:35-!- Lohengramm [sid1929@gateway/web/irccloud.com/session] has joined #wesnoth-dev
20161007 20:06:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 20:08:21-!- Netsplit *.net <-> *.split quits: TheJJ, DDR, nurupo, Yaiyan, APic
20161007 20:08:33-!- Netsplit over, joins: nurupo, yaiyan
20161007 20:08:35-!- Netsplit over, joins: APic
20161007 20:09:25-!- Netsplit over, joins: TheJJ
20161007 20:10:05-!- Netsplit over, joins: DDR
20161007 20:10:56-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Read error: Network is unreachable]
20161007 20:11:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161007 20:11:38-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20161007 20:16:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 20:18:44-!- elias [~allefant@allegro/developer/allefant] has quit [Ping timeout: 258 seconds]
20161007 20:19:18-!- elias [~allefant@allegro/developer/allefant] has joined #wesnoth-dev
20161007 20:21:50-!- kidneb_ [~kidneb@178.79.173.107] has joined #wesnoth-dev
20161007 20:22:01-!- new_one_ [~new_one@2604:a880:1:20::22e:d001] has joined #wesnoth-dev
20161007 20:22:07-!- Netsplit *.net <-> *.split quits: kidneb, Jetrel_bot, new_one, Sirp, EliDupree, TC01, crimson_penguin, Elsi
20161007 20:22:07-!- Elsi_ [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20161007 20:22:33-!- Netsplit over, joins: Sirp, Jetrel_bot
20161007 20:22:33-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has joined #wesnoth-dev
20161007 20:22:44-!- Netsplit over, joins: EliDupree
20161007 20:22:44-!- crimson_penguin [~crimson_p@ec2.happyspork.com] has quit [Changing host]
20161007 20:22:44-!- crimson_penguin [~crimson_p@wesnoth/developer/crimsonpenguin] has joined #wesnoth-dev
20161007 20:24:03-!- TC01 [~quassel@london.acm.jhu.edu] has joined #wesnoth-dev
20161007 20:26:06-!- atarocch_ [~atarocch@host246-63-dynamic.35-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20161007 20:28:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161007 20:28:24-!- atarocch [~atarocch@host86-89-dynamic.27-79-r.retail.telecomitalia.it] has quit [Ping timeout: 258 seconds]
20161007 20:30:57-!- Lohengramm [sid1929@gateway/web/irccloud.com/session] has quit [Changing host]
20161007 20:30:57-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-pxmxwejcftmogiuk] has joined #wesnoth-dev
20161007 20:31:44-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161007 20:34:15-!- Netsplit *.net <-> *.split quits: Sirp, Soliton, crimson_penguin, stikonas_, wedge009, ToBeCloud, loonycyborg, esr, vincent_c, Aginor,  (+43 more, use /NETSPLIT to show all of them)
20161007 20:39:00-!- Netsplit over, joins: Ravana_, janebot, matthiaskrgr, _laco, bumbadadabum, tad_, enchi, Ivanovic, stikonas_, vincent_c (+21 more)
20161007 20:39:13-!- Netsplit over, joins: AI0867, loonycyborg, TC02, knotwork, Greywhind, heirecka, Elvish_Hunter, esr, pydsigner, irker872
20161007 20:39:40-!- Netsplit over, joins: vultraz, DDR, oldlaptop, celticminstrel, nore, abruanese, midzer, yaiyan, Polsaker, prkc (+1 more)
20161007 20:39:40-!- APic [apic@apic.name] has quit [Max SendQ exceeded]
20161007 20:42:00-!- APic [apic@apic.name] has joined #wesnoth-dev
20161007 20:47:59-!- Appleman1234 [~Appleman1@KD106154000036.au-net.ne.jp] has joined #wesnoth-dev
20161007 20:56:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161007 20:58:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161007 21:18:50< vultraz> everyone do try to get their changes wrapped up over the next few days
20161007 21:19:08< vultraz> celticminstrel: you need to merge your formula variable branch
20161007 21:20:47-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 256 seconds]
20161007 21:22:46-!- louis94 [~~louis94@91.178.242.187] has joined #wesnoth-dev
20161007 21:27:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 21:32:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 21:46:11-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-pxmxwejcftmogiuk] has quit [Ping timeout: 250 seconds]
20161007 21:57:25-!- atarocch_ [~atarocch@host246-63-dynamic.35-79-r.retail.telecomitalia.it] has quit [Ping timeout: 260 seconds]
20161007 21:59:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161007 22:00:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161007 22:01:31< celticminstrel> vultraz: Which branch?
20161007 22:01:41< vultraz> celticminstrel: the thing that adds [variable] formula=
20161007 22:01:47< celticminstrel> Oh that.
20161007 22:01:52< celticminstrel> Then test it for me? >_>
20161007 22:02:49< vultraz> what is a good test case?
20161007 22:03:04-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-naigmcmvhntpsrmz] has joined #wesnoth-dev
20161007 22:03:34-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-naigmcmvhntpsrmz] has quit [Remote host closed the connection]
20161007 22:03:41< celticminstrel> Maybe... calculating something from the fields of a container variable? Though it's probably good to make sure it also works on scalar variables.
20161007 22:03:56< celticminstrel> (For scalar variables you would reference the original variable as self.)
20161007 22:04:31< vultraz> i assume the key evaluates a formula and returns bool ?
20161007 22:04:53-!- mjs-de [~mjs-de@x4db5db3f.dyn.telefonica.de] has joined #wesnoth-dev
20161007 22:04:55< vultraz> or does it check that variable against a formula
20161007 22:04:57< vultraz> i forgot
20161007 22:07:56< vultraz> why would you declare struct a friend...
20161007 22:08:30-!- Bonobo [~Bonobo@2001:44b8:254:3200:24e3:cfd1:579a:d8cb] has joined #wesnoth-dev
20161007 22:09:44-!- louis94 [~~louis94@91.178.242.187] has quit [Quit: Konversation terminated!]
20161007 22:09:46< vultraz> structs are implicitly public 
20161007 22:09:48< vultraz> aren't they
20161007 22:10:06< vultraz> s/structs/struct members
20161007 22:10:32-!- louis94 [~~louis94@91.178.242.187] has joined #wesnoth-dev
20161007 22:12:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 22:13:42-!- louis94 [~~louis94@91.178.242.187] has quit [Remote host closed the connection]
20161007 22:13:43-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-ypsbtizpkvgavhyu] has joined #wesnoth-dev
20161007 22:14:06-!- louis94 [~~louis94@91.178.242.187] has joined #wesnoth-dev
20161007 22:16:19-!- louis94 [~~louis94@91.178.242.187] has quit [Remote host closed the connection]
20161007 22:18:28-!- atarocch [~atarocch@host246-63-dynamic.35-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20161007 22:24:02< vultraz> oh, I see
20161007 22:24:13< vultraz> it's so the struct can access the class's private members 
20161007 22:24:15< vultraz> odd
20161007 22:24:27< vultraz> I'd have thought then the class should be a friend of the struct
20161007 22:24:29< vultraz> oh well
20161007 22:26:44< celticminstrel> vultraz: It sets the variable to the result of the formula.
20161007 22:27:13< vultraz> celticminstrel: wait, is this in [variable] or [set_variable]?
20161007 22:27:23< celticminstrel> The latter.
20161007 22:27:31< celticminstrel> Didn't you look at the diff? :P
20161007 22:28:04< vultraz> not in awhile 
20161007 22:29:47< vultraz> though, I must question why you simply didn't make value= accept a formula
20161007 22:30:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 22:30:43< vultraz> using formulas as the values for existing keys is better than introducing new keys, potentially
20161007 22:31:17< vultraz> (as I've said before, It'd be nice if every key everywhere could accept a formula, but you insist this is not possible)
20161007 22:32:10< vultraz> in this case, though, I don't see why value= can't accept a formula
20161007 22:33:33< vultraz> hell, we could even deprecate add=,sub=,multiply=, etc, and use value=$(+4), or something.
20161007 22:33:43-!- atarocch [~atarocch@host246-63-dynamic.35-79-r.retail.telecomitalia.it] has quit [Ping timeout: 268 seconds]
20161007 22:34:01< vultraz> (a certain keeper of zoos would hate that, though)
20161007 22:34:04< vultraz> but thoughts?
20161007 22:34:53< celticminstrel> value=$() already works, of course. It would probably be more verbose though for some use-cases.
20161007 22:35:14< vultraz> how so?
20161007 22:35:21< vultraz> wouldn't one need to do formula=$() anyway?
20161007 22:35:22< Aginor> vultraz: I don't think that's a great idea because that's a core part of the API
20161007 22:35:23< tad_> Deprecating those would cause massive breakage. Hate is too mild a word for the reaction I would expect.
20161007 22:35:39< celticminstrel> What? No...
20161007 22:35:41< Aginor> zookeeper would agree with that
20161007 22:36:01< Aginor> so that he's properly highlighted
20161007 22:36:07< celticminstrel> variable=$() uses the WML variable substitution system and evaluates a formula on a null object.
20161007 22:36:26 * zookeeper doesn't even feel the need to state the obvious
20161007 22:36:57< vultraz> celticminstrel: so formula = would not need to be wrapped in $()
20161007 22:37:24< celticminstrel> formula="" evaluates a formula on the variable currently being set, as I recall, so you'd use it when you want to replace the variable with something calculated from its components... I guess it'd be better if you could separately specify the source variable though, so let's just leave this alone until I can revisit it.
20161007 22:37:32< celticminstrel> vultraz: Right.
20161007 22:37:46< celticminstrel> Though of course it could still use $() within it.
20161007 22:38:10< celticminstrel> With the same caveat as always - $() is just a plain text substitution.
20161007 22:38:27< celticminstrel> So you could say that $() in a WFL formula is akin to macros in WML.
20161007 22:38:42-!- atarocch [~atarocch@host246-63-dynamic.35-79-r.retail.telecomitalia.it] has joined #wesnoth-dev
20161007 22:38:43< celticminstrel> (Well, not just $() but also $...|)
20161007 22:40:14< vultraz> I'd question how something like "name="side 1 turn $($turn_number+1)"" is evaluated, then, if it treats it as strings
20161007 22:40:45< celticminstrel> Variable substitution is evaluated from right to left.
20161007 22:41:00< celticminstrel> The substitution engine sees $turn_number first, and substitutes that with its value.
20161007 22:41:27< celticminstrel> Supposing $turn_number is 5, it next sees $(5+1) and calls WFL to evaluate the result.
20161007 22:41:56< vultraz> oh, so you mean it substitutes the output as text
20161007 22:42:02< celticminstrel> If $turn_number instead had the value "bar", it would see $(bar+1) and call WFL to evaluate that; since the variable bar doesn't exist, you'd get back null.
20161007 22:42:18< celticminstrel> Or null() to be more precise.
20161007 22:44:35-!- jesusalva [~jesusalva@177.96.222.137.dynamic.adsl.gvt.net.br] has joined #wesnoth-dev
20161007 22:44:59< vultraz> so is there any reason[set_variable] value= could not be evaluated as a formula and $() used within it as necessary? Perhaps a local 'this' WFL variable could be added internally, so one could just do value="this + 4" or something. Say you want a different variable source, then you'd do value="$another_variable + 4"
20161007 22:45:52< celticminstrel> Changing value= to always be a formula would break all string variables ever.
20161007 22:46:05< celticminstrel> Becasuse the strings would now be interpreted as formula variables instead of as strings.
20161007 22:46:23< celticminstrel> Changing it to use tformula is not impossible though.
20161007 22:46:37< vultraz> what if we follow the gui2 convention and use the () wrapper?
20161007 22:46:37< celticminstrel> At least, it might be possible.
20161007 22:46:41< celticminstrel> That's tformula.
20161007 22:46:51< vultraz> ...what's the difference 
20161007 22:46:54< vultraz> :|
20161007 22:47:05< celticminstrel> tformula is a formula if surrounded by () and otherwise a literal.
20161007 22:47:21< celticminstrel> But even using that convention is potentially dangerous in [set_variable].
20161007 22:47:39-!- mjs-de [~mjs-de@x4db5db3f.dyn.telefonica.de] has quit [Remote host closed the connection]
20161007 22:47:57< celticminstrel> What if you had value="(Bonus objective)" or something? I dunno how likely it is, but it seems like a possible use-case.
20161007 22:48:28< tad_> What about [set_variable]formula= ???
20161007 22:49:11< vultraz> that's what he had :P
20161007 22:49:22< tad_> Then why change it?
20161007 22:49:50< vultraz> I suppose it's worth keeping value= a string literal w/ variable substitution  
20161007 22:49:52 * vultraz ponders
20161007 22:50:06< vultraz> im in a game, ill explain later, tad_ 
20161007 22:56:17-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 258 seconds]
20161007 22:57:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 22:58:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 22:59:26-!- RatArmy [~RatArmy@om126161122105.8.openmobile.ne.jp] has joined #wesnoth-dev
20161007 22:59:37-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-ypsbtizpkvgavhyu] has quit [Ping timeout: 240 seconds]
20161007 23:00:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 23:01:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 23:01:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 23:02:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 23:04:30-!- stikonas_ is now known as stikonas
20161007 23:05:05< irker872> wesnoth: Chris Beck wesnoth:master 0d2635c20a6d / src/ (gui/dialogs/lua_interpreter.cpp scripting/lua_kernel_base.hpp): fix an issue with text not properly formatted in lua console https://github.com/wesnoth/wesnoth/commit/0d2635c20a6d3c25e49a9a780c888c80a9eed3ff
20161007 23:11:22-!- atarocch [~atarocch@host246-63-dynamic.35-79-r.retail.telecomitalia.it] has quit [Remote host closed the connection]
20161007 23:12:04-!- jesusalva [~jesusalva@177.96.222.137.dynamic.adsl.gvt.net.br] has quit [Ping timeout: 244 seconds]
20161007 23:15:21< irker872> wesnoth: Chris Beck wesnoth:master d82d8c913766 / src/scripting/lua_kernel_base.cpp: fixup previous commit: don't compare std::function with nullptr https://github.com/wesnoth/wesnoth/commit/d82d8c9137669ab01d831c82ff5f7b00e6552cde
20161007 23:19:22-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161007 23:20:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161007 23:23:24-!- Lohengramm [sid1929@gateway/web/irccloud.com/x-dadfvjpayltsiixw] has joined #wesnoth-dev
20161007 23:34:07< vultraz> a rare iceiceice commit appears!
20161007 23:36:59< irker872> wesnoth: Chris Beck wesnoth:master 4dea265113ca / src/scripting/ (lua_kernel_base.cpp lua_kernel_base.hpp): add code comments and minor fixups in lua_kernel_base https://github.com/wesnoth/wesnoth/commit/4dea265113cab5b723ca578e32b1fa250c9d16f7
20161007 23:48:44< vultraz> " * For boost bind the a function sometimes needs to return a value although
20161007 23:48:46< vultraz>  * the function called doesn't return one. This wrapper function can return a
20161007 23:48:47< vultraz>  * fixed result for a certain functor."
20161007 23:48:49< vultraz> uh
20161007 23:48:50< vultraz> what?
20161007 23:49:01< vultraz> hm
20161007 23:49:06< vultraz> so it calls a function and returns R
20161007 23:49:13< vultraz> but R is not returned by func
20161007 23:50:47< vultraz> lmabdas to the rescue 
20161007 23:56:39-!- RatArmy [~RatArmy@om126161122105.8.openmobile.ne.jp] has quit [Quit: Leaving]
20161007 23:59:45< vultraz> celticminstrel: why do the hotkey functions need to return bool?
--- Log closed Sat Oct 08 00:00:10 2016