--- Log opened Wed Oct 12 00:00:53 2016
20161012 00:07:04< tad_carlucci> That was it? Two pedantic complaints about -Wpermissive and it's back to the races. I need to write them up and fire them off to lua.org
20161012 00:14:04< tad_carlucci> Wow. Now to apply the lua.org patches for known bugs and it's time to fire up HttT.
20161012 00:15:22< shadowm> Hmmmmmm.
20161012 00:18:25< shadowm> I got a segmentation fault when tabbing out of Wesnoth in fullscreen mode and now it doesn't happen again.
20161012 00:23:52-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Read error: Connection reset by peer]
20161012 00:24:44-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161012 00:32:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161012 00:33:06< tad_carlucci> Most likely, the game was in the middle of doing something and the change in the window state interrupted that. Race conditions are so hard to reproduce.
20161012 00:34:41< tad_carlucci> BaBOOM: PANIC: unprotected error in call to Lua API (library 'bit32' has been deprecated)
20161012 00:35:23< tad_carlucci> Which is two errors. We don't have a panic function set. And I'm gonna have to find the calls and fix 'em.
20161012 00:49:05< shadowm> It was simply sitting idle in the Preferences dialog.
20161012 00:53:57-!- new_one_ [~new_one@2604:a880:1:20::22e:d001] has quit [Ping timeout: 240 seconds]
20161012 00:57:02-!- new_one_ [~new_one@162.243.146.104] has joined #wesnoth-dev
20161012 01:00:17-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 240 seconds]
20161012 01:00:56-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161012 01:03:20-!- vultraz [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161012 01:03:20-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161012 01:03:20-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161012 01:04:29-!- gfgtdf_ [~chatzilla@x4e363a0d.dyn.telefonica.de] has joined #wesnoth-dev
20161012 01:04:53< vultraz> well that's unfortunate
20161012 01:07:36-!- gfgtdf [~chatzilla@x4e32b2c9.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20161012 01:07:38-!- gfgtdf_ is now known as gfgtdf
20161012 01:11:34< shadowm> vultraz: ?
20161012 01:12:06< vultraz> Could you try to get that done by January?
20161012 01:12:30< shadowm> Do you ever read the logs to check on what you missed while disconnected?
20161012 01:13:09< vultraz> Sometimes.
20161012 01:13:34< shadowm> Maybe you should get in the habit of doing that without having to be told to do so.
20161012 01:14:10< vultraz> O_O
20161012 01:14:10< shadowm> <shadowm> Well, since vultraz died I'm just going to leave this here and see if anyone can spot the differences: https://dl.dropboxusercontent.com/u/21371130/screenshots/Screenshot_20161011_204918.png
20161012 01:14:12< vultraz> O_____O
20161012 01:14:14< vultraz> why
20161012 01:14:21< vultraz> why are those lines colored and shaded
20161012 01:14:42< shadowm> Because the solid white looks distracting?
20161012 01:15:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 01:15:23< vultraz> but how did you accomplish such a thing
20161012 01:15:34< shadowm> And why are they shaded? So that it's easy to tell which segment represents the selected value. This may come in handy some day when we get better RTL language support.
20161012 01:15:48< shadowm> Oh. You asked why, not how.
20161012 01:16:00< shadowm> A wizard did it.
20161012 01:18:04< vultraz> I do like the change
20161012 01:18:17< shadowm> https://dl.dropboxusercontent.com/u/21371130/poop/gui2-borders-crap.diff
20161012 01:18:45< vultraz> iiiinteresting
20161012 01:18:47< shadowm> There's a part of that diff that I can't accurately demonstrate with screenshots.
20161012 01:20:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161012 01:20:10< TC01> (re earlier mention of issue trackers: gitlab supports "confidential" issues as of a recent release but otherwise offers a similar-to-github issues tracker experience)
20161012 01:20:31< TC01> (just a thought. that's obviously not necessarily useful for wesnoth since the code is on github though.)
20161012 01:22:30< vultraz> Github recommends using a separate, private repo for private issues.
20161012 01:22:33< vultraz> That's always an option.
20161012 01:22:51< vultraz> Not a *great* one, but it's an option
20161012 01:24:27< tad_carlucci> Wow. Deleted one line in lua_kernel_base and HttT is running.
20161012 01:31:19< tad_carlucci> vultraz, To answer your earlier question: if things keep up like they have been, expect a PR to "Upgrade to Lua 5.3.3+" in an hour or two ...
20161012 01:31:32< vultraz> :O
20161012 01:31:38< vultraz> whhhhuuttt :D
20161012 01:31:57< tad_carlucci> I'm still play-testing but so far no noticable issues with SP.
20161012 01:34:04< tad_carlucci> Of course, I expect will put it out there and I'll get pie in the face on a regular basis about it :P
20161012 01:38:09< vultraz> ah, the most fun of errors
20161012 01:38:13< vultraz> runtime errors!
20161012 01:38:48< vultraz> no assertion, stacktrace, or anything.
20161012 01:39:40< vultraz> I just love debugging these :|
20161012 01:42:06-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161012 01:42:30< vultraz> hm
20161012 01:42:36< vultraz> ok, so that's why it crashes..
20161012 01:43:39< vultraz> but why
20161012 01:44:18< tad_carlucci> An error I've seen before. Probably not Lua-related: error gui/layout: tgrid [] place: Failed to place a grid, we have 330,64 space but we need 355,64 space. This happened at a grid with the id '' in a 'N4gui215ttree_view_nodeE' with the id '' in a 'N4gui210ttree_viewE' with the id 'stuff_list' in a 'N4gui25tgridE' with the id '' in a 'N4gui210tgeneratorINS_6policy17minimum_selection5tnoneENS1_17maximum_selection9tinfiniteENS1_9placement12tind
20161012 01:44:18< tad_carlucci> ependentENS1_13select_action5tshowEEE' with the id '_content_grid' in a 'N4gui25tgridE' with the id '' in a 'N4gui215tstacked_widgetE' with the id '' in a 'N4gui25tgridE' with the id '' in a 'N4gui25tgridE' with the id '_window_content_grid' in a 'N4gui25tgridE' with the id '_content_grid' in a 'N4gui216tscrollbar_panelE' with the id '' in a 'N4gui25tgridE' with the id '' in a 'N4gui27twindowE' with the id 'gamestate_inspector'.
20161012 01:45:13< tad_carlucci> I was looking at units in debug to see if randomplacement did it's thing.
20161012 01:45:23 * vultraz curses
20161012 01:45:44 * vultraz curses again
20161012 01:46:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161012 01:46:13< tad_carlucci> No noticable on-screen error. I could scroll through them and their details.
20161012 01:47:31< tad_carlucci> I was in HttT S07 (Crossroads) start of turn 1, debug mode, inspect, units, chosoe the last and scroll it's data
20161012 01:47:55< vultraz> ok, so the crash happens if I clear the tree...
20161012 01:48:00< gfgtdf> tad_carlucci: hmm tis looks like that dialog uses a treeiew in a generator widget
20161012 01:48:18< vultraz> ah, I see
20161012 01:48:26< vultraz> it invalidates the pointers
20161012 01:48:29< vultraz> fun!
20161012 01:48:32< vultraz> well
20161012 01:48:42< vultraz> i shouldn't be clearing it anyway
20161012 01:48:46< gfgtdf> does the stacked_widget also use the tgenerator stuff?
20161012 01:48:54< vultraz> or should I be?
20161012 01:48:58< vultraz> hmmmm
20161012 01:48:58< tad_carlucci> Dunno. I've seen something like it for a while now. Just hyper-sensitive because I'm running master + Lua 5.3.3+
20161012 01:49:19< vultraz> tad_carlucci: ignore it for now and proceed with testing
20161012 01:49:34< tad_carlucci> Already ahead of you there.
20161012 01:49:48< vultraz> meanwhile, I shall ponder how to avoid le invalidating of pointers
20161012 01:50:26< vultraz> ah, I think i got it..
20161012 01:50:35< vultraz> still, this method is rather inefficient
20161012 01:51:21< vultraz> yup, that fixed it
20161012 01:51:37< vultraz> cleared the map before regenerating the tree so node pointers are reset
20161012 01:59:42< vultraz> hmmm
20161012 02:00:01< EliDupree> gfgtdf: Were you the one who fixed get_global_variable working for side= (not wesnoth.current.side)? I'm trying to use it in practice and running into OOS messages, although I haven't investigated enough to know for sure that it's not my own fault (1.12)
20161012 02:01:47 * tad_carlucci takes a deep breath: about to run the Lua random cave .. cross your fingers .. the other Lua scripts were fine but this is probably the acid test ...
20161012 02:02:00< gfgtdf> EliDupree: i did some fixes in 1.12 and some are 1.13 only
20161012 02:02:23< EliDupree> gfgtdf: Can you tell me what exactly you expect to work in 1.12?
20161012 02:02:28< gfgtdf> EliDupree: i use get_global_variable with side beeind not the current side succesfully in my 1.12 addon.
20161012 02:02:37< tad_carlucci> And we have random caves!
20161012 02:03:14< tad_carlucci> OK, vultraz it's downhill from here. Finish out the campaign, do a little cleanup and make a HUGE PR.
20161012 02:03:34< vultraz> how huge?
20161012 02:03:50< gfgtdf> EliDupree: well i basically use it to hack a synced way to show a dialog to many sides at once and sync their result after
20161012 02:04:04< EliDupree> heh
20161012 02:04:52< gfgtdf> EliDupree: in a start event.
20161012 02:05:01< tad_carlucci> Not that name commits .. 6 or so. But one of them .. don't bother reading it: it's the changeset for Lua 5.2.3 -> Lua 5.3.3 clean sources.
20161012 02:05:19< EliDupree> My stuff is side turn events, which SHOULD be just as good
20161012 02:05:44< tad_carlucci> s/name/many/
20161012 02:06:17< gfgtdf> EliDupree: you have a minimalitc ccase to reprpduce?
20161012 02:06:36< EliDupree> Unfortunately no
20161012 02:06:38< gfgtdf> EliDupree: unfortenuateley i cannot run wesnoth currently due to compuler porblems though, so i can oynl look at code
20161012 02:06:47< EliDupree> heh
20161012 02:07:01-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 248 seconds]
20161012 02:07:14< tad_carlucci> vultraz, The cleanup is I have the commit for fribidi_log2vis in and need to remove it. I had to add it for scons strict and it's up as a separate PR
20161012 02:08:38< EliDupree> I'm currently hosting a game we're problem happened. It appears that on side one turn one, MY client – which was running the AI that controlled side one – incorrectly received its OWN persistent variables when requesting the variables of other sides
20161012 02:08:59< EliDupree> I could be wrong, that's just what it looks like at first glance
20161012 02:08:59< gfgtdf> EliDupree: what m doing here: https://github.com/gfgtdf/PYR_No_Preperation_Turn/blob/master/lua/synconize_choice_workaround.lua is basically to emulate the 'wesnoth.synchronize_choices' function from 1.13
20161012 02:09:06< gfgtdf> EliDupree: hmm
20161012 02:09:24< EliDupree> And the other clients complained "global variable expected but none found"
20161012 02:09:46< gfgtdf> EliDupree: mayb you call the [get_lobal_variable] from inside a wesnoth.sync_chocie function ?
20161012 02:09:59-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 02:10:20< EliDupree> That wouldn't produce this behavior, would it?
20161012 02:10:46< gfgtdf> EliDupree: well it wouldnt cause that OOS but it would ignore the side= parmater
20161012 02:11:26< EliDupree> Oh, if you do it in the nonsynchronized context, is it supposed always default to your own client?
20161012 02:11:49< gfgtdf> EliDupree: yes you can also so network sync during  in a synconized context
20161012 02:11:59< gfgtdf> can only do*
20161012 02:12:21< EliDupree> I mean, I would've assumed that that would give me an error message, not fall back to a different behavior
20161012 02:14:33< gfgtdf> EliDupree: well somethimes you want things unsynced, for example if you have a some assond that controly your own UI settings thatis opened by aselect event.
20161012 02:15:55< gfgtdf> EliDupree: or some other  unsynced menu.
20161012 02:15:59 * vultraz groans
20161012 02:16:29< vultraz> really, really need standard color helper functions
20161012 02:16:35< EliDupree> But anyway, I'm pretty sure I'm not doing that.
20161012 02:17:00< EliDupree> Unless.....
20161012 02:17:04< EliDupree> nope
20161012 02:18:35< gfgtdf> EliDupree: hmm
20161012 02:20:23< vultraz> what the hell..
20161012 02:20:51< gfgtdf> EliDupree: do you also have these problems if you just put the [get_global_variable] wml directly ito the side turn event ?
20161012 02:22:07< EliDupree> Well, it hasn't always failed. Only in this game where my side was an AI instead of human. It's pretty likely that my own code is at fault somewhere, I just haven't figured out what the deal is yet.
20161012 02:22:36< EliDupree> or, wait
20161012 02:25:18< tad_carlucci> Some day I need to track this down and see if we can fix or suppress it: The key you just pressed is not recognized by SDL. To help get this fixed, please report this to the SDL mailing list <sdl@libsdl.org> X11 KeyCode 130 (122), X11 KeySym 0xFF31 (Hangul).
20161012 02:26:16< tad_carlucci> vultraz, HttT played using my fast-test process, checking the known Lua scripts in the campaign do their thing. No problems found.
20161012 02:26:43< tad_carlucci> Properity "wife" interrupt for trip to Wally World. I'll make the PR when I get back.
20161012 02:26:47-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Leaving]
20161012 02:29:33< EliDupree> I tried to reproduce the error by hosting the map myself and joining with a second wesnoth, but it didn't work :(
20161012 02:31:17-!- irker493 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161012 02:31:17< irker493> wesnoth: Charles Dang wesnoth:master 262188c82eb4 / / (3 files in 2 dirs): MP Join Game: converted dialog to team-based tree view like MP Staging https://github.com/wesnoth/wesnoth/commit/262188c82eb42ce178623088e2e4dac248ea0807
20161012 02:31:20< irker493> wesnoth: Charles Dang wesnoth:master ec9397e30a3c / src/game_initialization/connect_engine.cpp: Connect Engine: pass specified color id to network side config https://github.com/wesnoth/wesnoth/commit/ec9397e30a3ce399a73377252c76666278679455
20161012 02:31:38< gfgtdf> EliDupree: so you got the erro with someone else?
20161012 02:31:42< EliDupree> yes
20161012 02:31:53< gfgtdf> EliDupree: maybe he just had an optdated version of your addon or similar?
20161012 02:32:15< EliDupree> They said they didn't, but it's possible they were incorrect
20161012 02:33:18< EliDupree> Well, I just found a bug in my code... I'm not sure the bug quite explains the problem, but it might
20161012 02:34:07< EliDupree> And the reason I didn't find it with myself is that I ALREADY had the persistent variables in question. Debugging persistent variables is extra hard :/
20161012 02:40:56< irker493> wesnoth: Charles Dang wesnoth:master a027f3f6eef4 / src/game_initialization/connect_engine.hpp: Connect Engine: update color id when setting color https://github.com/wesnoth/wesnoth/commit/a027f3f6eef4c203461e3e872002cae0a1310344
20161012 02:40:59< irker493> wesnoth: Charles Dang wesnoth:master f1d2488529d0 / src/gui/dialogs/multiplayer/mp_join_game.cpp: MP Join Game: colorize side numbers instead of a separate color orb display https://github.com/wesnoth/wesnoth/commit/f1d2488529d03425bf9610813649abe0d311538b
20161012 02:41:18< vultraz> god *dammit*
20161012 02:41:21< vultraz> forgot a file *again*
20161012 02:41:33< vultraz> maybe this is what happens when you invoke git commit from src/
20161012 02:42:10< EliDupree> gfgtdf: Well, my bug is fixed. I'm still a little confused, because the bug was just a lua error - why would it out of sync? The error should have happened the same way on all clients. But I think I've run into this issue before: maybe lua errors sometimes cause out of sync where there isn't any
20161012 02:42:28-!- Bonobo [~Bonobo@2001:44b8:254:3200:64a9:4db2:6264:2472] has joined #wesnoth-dev
20161012 02:42:31< shadowm> I'm going to take vultraz's "I do like the change" as approval for pushing it.
20161012 02:42:38< irker493> wesnoth: Charles Dang wesnoth:master 860325d3dfaa / data/gui/window/mp_join_game.cfg: Supposed to be with f1d2488529d0 https://github.com/wesnoth/wesnoth/commit/860325d3dfaa6406847b96e6b1e006c4b09a7875
20161012 02:42:51< gfgtdf> EliDupree: hmm dont know without seeing the code
20161012 02:43:55< gfgtdf> EliDupree: also, how do you know its fixes when you couldnt reproduce it ?
20161012 02:44:11< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 7531e7ef2e4b / data/gui/ (macros/_initial.cfg widget/slider_default.cfg widget/slider_minimal.cfg): gui2/tslider: Improved color scheme for slider grooves https://github.com/wesnoth/wesnoth/commit/7531e7ef2e4b7dc539df114024668d8696e60c8f
20161012 02:44:26< EliDupree> I did figure out how to reproduce it: join with a client that had no pre-existing user data
20161012 02:45:44< gfgtdf> EliDupree: hmm maybe the lua erros stops the client form writing the userdata, and teh reason why it didnt appear without the error is the same  why you couldnt reproduce it before.
20161012 02:47:49< vultraz> shadowm: that looks really good in the generator settings :D
20161012 02:48:21-!- gfgtdf [~chatzilla@x4e363a0d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]]
20161012 03:09:45-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 03:09:46< travis-ci> wesnoth/wesnoth#11451 (master - ec9397e : Charles Dang): The build has errored.
20161012 03:09:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166936938
20161012 03:09:46-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 03:16:01-!- JyrkiVesterinen [~JyrkiVest@87-100-174-156.bb.dnainternet.fi] has joined #wesnoth-dev
20161012 03:17:14< shadowm> We can use <chrono>, right?
20161012 03:17:38< shadowm> Oh, we already do in one client unit, I see.
20161012 03:22:17< JyrkiVesterinen> shadowm: if you mean attack_prediction.cpp, it uses <chrono> only when the game is compiled with the combat simulation test code enabled (which is done almost never).
20161012 03:22:18< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/attack_prediction.cpp#L49-L50
20161012 03:22:36< JyrkiVesterinen> Nevertheless, <chrono> should also be usable in normal code.
20161012 03:23:35< shadowm> Yeah, that's the only one (campaignd doesn't count).
20161012 03:26:36< irker493> wesnoth: Charles Dang wesnoth:master 5c6fe6aadc22 / data/campaigns/Sceptre_of_Fire/scenarios/9_Caverns_of_Flame.cfg: SoF S9: removed [endlevel] block in victory event (bug #25164) https://github.com/wesnoth/wesnoth/commit/5c6fe6aadc22784fe5f728a994b731601822c3c9
20161012 03:29:42-!- travis-ci [~travis-ci@ec2-54-160-185-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 03:29:43< travis-ci> wesnoth/wesnoth#11452 (master - f1d2488 : Charles Dang): The build was broken.
20161012 03:29:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166938120
20161012 03:29:43-!- travis-ci [~travis-ci@ec2-54-160-185-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 03:32:17-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20161012 03:37:07< shadowm> src/gui/dialogs/multiplayer/mp_join_game.cpp:306:46: error: ‘rgb2highlight_pango’ was not declared in this scope
20161012 03:37:10< shadowm> vultraz.
20161012 03:37:53< vultraz> huh
20161012 03:38:07< vultraz> oh, I see
20161012 03:38:15< vultraz> I removed an include locally before committing
20161012 03:39:11< vultraz> still, I planned to move that elsewhere anyway..
20161012 03:39:20< vultraz> ill commit the include for now to fix builds
20161012 03:39:25< shadowm> Yeah don't care as long as I can actually build Wesnoth.
20161012 03:40:11-!- travis-ci [~travis-ci@ec2-54-160-185-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 03:40:12< travis-ci> wesnoth/wesnoth#11453 (master - 860325d : Charles Dang): The build was broken.
20161012 03:40:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166938370
20161012 03:40:13-!- travis-ci [~travis-ci@ec2-54-160-185-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 03:41:07< irker493> wesnoth: Charles Dang wesnoth:master 7ead77a10b59 / src/gui/dialogs/multiplayer/mp_join_game.cpp: Fixup f1d2488529d0 (missing include) https://github.com/wesnoth/wesnoth/commit/7ead77a10b594f7c600f6d447aaf47beb48ac65d
20161012 03:41:43< vultraz> shadowm: ^'
20161012 03:42:14< shadowm> Cool, cool.
20161012 03:43:56< vultraz> ok, need to fix a crash in staging involving the sliders..
20161012 03:44:02< vultraz> I wonder if it has something to do with me using lambdas...?
20161012 03:44:19< shadowm> Can we use variables in canvas colors?
20161012 03:44:32< vultraz> I don't think I've tried
20161012 03:44:38< vultraz> you'll have to check the code.
20161012 03:45:39< shadowm> :V
20161012 03:45:43< shadowm> We cannot.
20161012 03:45:51< vultraz> should be easy enough to add
20161012 03:46:38< shadowm> Not quite.
20161012 03:47:49< shadowm> I mean, I have an idea of how to get it done quickly but it probably will break horribly with more complicated formulas.
20161012 03:47:54< vultraz> not really sure why this crashes, though....
20161012 03:47:59< shadowm> *definitely
20161012 03:48:57< shadowm> Or I could use an alternative hack. Both approaches are just as hackish as the other really.
20161012 03:49:14< vultraz> #0 0xec0a3e	bool gui2::event::tdispatcher_implementation::thas_handler::oper<mpl_::int_<30> >(gui2::event::tevent) () (??:??)
20161012 03:49:16< vultraz> welll fuck
20161012 03:49:20< vultraz> what have I done
20161012 03:49:57< vultraz> though again, possibly a lambda thing?
20161012 03:50:04< vultraz> let's try with a member function
20161012 03:55:39< shadowm> src/gui/core/canvas.cpp:587:26: error: suggest parentheses around ‘+’ in operand of ‘&’ [-Werror=parentheses]
20161012 03:55:43< shadowm> Bleeeeeeeeeeeeeeeeeeeh.
20161012 03:58:06< shadowm>     error validation: Invalid key 'alpha=' in tag [line]
20161012 03:58:10< shadowm> Where are these defined?
20161012 03:58:24< shadowm> The canvas WML schema?
20161012 03:58:36< shadowm> Oh, never mind, found it.
20161012 03:59:42-!- travis-ci [~travis-ci@54.205.230.14] has joined #wesnoth-dev
20161012 03:59:43< travis-ci> wesnoth/wesnoth#11454 (master - 7531e7e : Ignacio R. Morelle): The build was broken.
20161012 03:59:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166938547
20161012 03:59:43-!- travis-ci [~travis-ci@54.205.230.14] has left #wesnoth-dev []
20161012 04:03:11< vultraz> ah, the joys of C-style function pointers
20161012 04:03:15< vultraz> ((*side).*fptr)(slider.get_value());
20161012 04:04:14< shadowm> Well, this is annoying.
20161012 04:04:44< shadowm> Do GUI2 DRAW events fire ever?
20161012 04:05:54< shadowm> Perhaps I used the wrong placement.
20161012 04:07:16< Aginor> they fire every 20 ms or 10 ms or whatever it is
20161012 04:07:20< irker493> wesnoth: Charles Dang wesnoth:master bbd56391f121 / src/gui/dialogs/multiplayer/ (mp_staging.cpp mp_staging.hpp): MP Staging: fixed crash involving gold/income sliders https://github.com/wesnoth/wesnoth/commit/bbd56391f121e051cc9d69d4ce3fa37a986c815e
20161012 04:07:22< Aginor> a timer is generating them
20161012 04:07:35< vultraz> (perhaps someone like JyrkiVesterinen could explain to me why that was crashing before)
20161012 04:07:43< shadowm> Yeah, but my handler doesn't run.
20161012 04:08:12< shadowm> Maybe it's because I'm binding to a widget instead of a window I don't know.?
20161012 04:08:29< vultraz> perhaps the dispatcher doesn't send a signal for that event
20161012 04:09:13< shadowm> Bleh I give up.
20161012 04:09:54< vultraz> (also why did i have to deref that shared_ptr before using it. ie, side->*fptr didn't work)
20161012 04:10:45< shadowm> Actually, I found an alternative.
20161012 04:10:48< JyrkiVesterinen> vultraz: the crash you had was caused by capturing shared_ptr by reference.
20161012 04:10:50-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161012 04:10:54< shadowm> I might not need to mess with this crap after all.
20161012 04:11:17< JyrkiVesterinen> [&] captures all accessible variables by reference (well, the ones which you use).
20161012 04:11:30< vultraz> JyrkiVesterinen: ahhhh. would i have needed something like... [&slider, ptr]?
20161012 04:11:42< JyrkiVesterinen> Yes, that would have worked.
20161012 04:11:54< vultraz> ah
20161012 04:18:28< vultraz> gah, ANOTHER crash
20161012 04:30:48< irker493> wesnoth: Charles Dang wesnoth:master b55b0e7ebc0f / src/gui/dialogs/lobby/data.cpp: MP Lobby: replace any newlines that might be in game names https://github.com/wesnoth/wesnoth/commit/b55b0e7ebc0fa18d436bc65cfd80d0c49532de3e
20161012 04:30:51< vultraz> (that wasn't the crash, ftr)
20161012 04:34:35< shadowm> Yessssss.
20161012 04:34:40< shadowm> vultraz, you are going to _love_ this.
20161012 04:35:15< vultraz> tell me more
20161012 04:35:36< shadowm> As soon as I finish putting the commit together.
20161012 04:41:57< irker493> wesnoth: Charles Dang wesnoth:master cea34e70bd76 / data/gui/window/lobby_main.cfg: MP Lobby: made gamelist expand to max available height https://github.com/wesnoth/wesnoth/commit/cea34e70bd768bdb5dc55afeb010ca00b51625b1
20161012 04:42:00< irker493> wesnoth: Charles Dang wesnoth:master 0ac4c0fcfa5a / data/gui/window/ (lobby_main.cfg mp_join_game.cfg mp_staging.cfg): Removed some unnecessary minimum size forcing https://github.com/wesnoth/wesnoth/commit/0ac4c0fcfa5ac60b52d89ed82137e938b3154d8d
20161012 04:44:24-!- travis-ci [~travis-ci@ec2-54-197-77-107.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 04:44:25< travis-ci> wesnoth/wesnoth#11456 (master - 5c6fe6a : Charles Dang): The build failed.
20161012 04:44:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166943652
20161012 04:44:25-!- travis-ci [~travis-ci@ec2-54-197-77-107.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 04:54:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 04:57:01-!- JyrkiVesterinen [~JyrkiVest@87-100-174-156.bb.dnainternet.fi] has quit [Quit: .]
20161012 04:58:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161012 05:00:51-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161012 05:00:53< irker493> wesnoth: Ignacio R. Morelle wesnoth:master b3cf75196cf0 / data/gui/schema.cfg src/gui/core/canvas.cpp: gui2/canvas: Allow overriding color alpha in [line] with a formula https://github.com/wesnoth/wesnoth/commit/b3cf75196cf065da8e022956aa5c8f23ba1d753f
20161012 05:00:56< irker493> wesnoth: Ignacio R. Morelle wesnoth:master f1d89ba4a321 / / (3 files in 2 dirs): gui2/ttext_: Add a blinking cursor to textbox widgets https://github.com/wesnoth/wesnoth/commit/f1d89ba4a3218c0f5f3873ad64584b854de1928a
20161012 05:00:59< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 7630651ea075 / data/gui/widget/text_box_default.cfg: gui2/ttext_box: Improved color scheme for the text box borders https://github.com/wesnoth/wesnoth/commit/7630651ea0750125d9753fc9c3e3f8cc9e1ee1f9
20161012 05:02:48< vultraz> O_O
20161012 05:02:51< vultraz> O__________________O
20161012 05:04:40< vultraz> oh mah gggaawwwdddd
20161012 05:04:52< vultraz> B L I N K I N G C U R S O R S
20161012 05:05:19< vultraz> SORCERY!
20161012 05:06:54< vultraz> i wonder if this could be used for alpha fadeout gradient?
20161012 05:07:06< vultraz> perhaps not
20161012 05:08:22-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161012 05:12:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 268 seconds]
20161012 05:13:00-!- wedge010 is now known as wedge009
20161012 05:13:53< shadowm> src/gui/dialogs/multiplayer/mp_staging.cpp:271:100: error: no matching function for call to ‘bind(<unresolved overloaded function type>, gui2::tmp_staging*, ng::side_engine_ptr&, std::reference_wrapper<gui2::tslider>)’
20161012 05:13:58< shadowm> vultraz.
20161012 05:14:29< vultraz> i dont get that
20161012 05:14:50< shadowm> Well, you must figure out how to fix it anyway.
20161012 05:16:04< shadowm> http://pastebin.com/6CAgW0Sq
20161012 05:16:13< shadowm> Because otherwise I can't build Wesnoth.
20161012 05:16:32< shadowm> Obviously you must've introduced this just now.
20161012 05:16:56< vultraz> could you help me out
20161012 05:18:21-!- travis-ci [~travis-ci@ec2-54-160-185-48.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 05:18:22< travis-ci> wesnoth/wesnoth#11457 (master - 7ead77a : Charles Dang): The build has errored.
20161012 05:18:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166945231
20161012 05:18:22-!- travis-ci [~travis-ci@ec2-54-160-185-48.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 05:22:03< vultraz> since i don't really understand the issue
20161012 05:22:27< shadowm> How do I test this code?
20161012 05:22:52< shadowm> I don't quite understand the issue either but I think I made the correct guess.
20161012 05:22:59< shadowm> -               &tmp_staging::on_side_slider_change<ng::side_engine::set_gold>, this, side, std::ref(slider_gold)));
20161012 05:23:02< shadowm> +               &tmp_staging::on_side_slider_change<&ng::side_engine::set_gold>, this, side, std::ref(slider_gold)));
20161012 05:23:07< shadowm> And so on.
20161012 05:23:21< vultraz> well, you'd need to start two clients, start a game with one, enetr with the other, change the gold/income slider, and check if it appears correctly in the joined client
20161012 05:24:40< shadowm> I'm going to commit the change and let you test it yourself.
20161012 05:27:45-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 05:27:46< travis-ci> wesnoth/wesnoth#11458 (master - bbd5639 : Charles Dang): The build is still failing.
20161012 05:27:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166948572
20161012 05:27:46-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 05:28:09< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 19d6d458008e / src/gui/dialogs/multiplayer/mp_staging.cpp: gui2/tmp_staging: Fix build with GCC 6.1.1 https://github.com/wesnoth/wesnoth/commit/19d6d458008ed9b9364cbe766557eba6ba710e43
20161012 05:28:13< irker493> wesnoth: Ignacio R. Morelle wesnoth:master db0b20dae774 / src/gui/widgets/ (text.cpp text.hpp): gui2/ttext_: Refactor cursor timer setup code https://github.com/wesnoth/wesnoth/commit/db0b20dae77492ae7ef4eab3d99a644a88c33ea9
20161012 05:28:14< shadowm> vultraz: ^
20161012 05:33:41< vultraz> shadowm: works
20161012 05:36:47< vultraz> thanks
20161012 05:39:35< shadowm> We need a hand cursor for links.
20161012 05:39:44< vultraz> we have it
20161012 05:40:02< vultraz> images/cursors/select.png
20161012 05:41:10< shadowm> And get that cursor color scheme sorted out.
20161012 05:41:18< shadowm> Okay, so there's a link cursor but it's not used.
20161012 05:41:33< vultraz> color scheme?
20161012 05:42:02< shadowm> Yes.
20161012 05:42:12< shadowm> I've told you this before, come on.
20161012 05:44:39< shadowm> Okay, so textbox timers keep firing (obviously) when their parent window loses focus, and they keep getting redrawn accordingly.
20161012 05:45:10< shadowm> How would I go about detecting when the parent loses focus?
20161012 05:45:14-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 05:45:15< travis-ci> wesnoth/wesnoth#11459 (master - b55b0e7 : Charles Dang): The build is still failing.
20161012 05:45:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166951166
20161012 05:45:15-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 05:45:31< vultraz> not sure
20161012 05:48:56-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161012 05:50:02< vultraz> tad_carlucci: success?
20161012 05:50:24< shadowm> Well, I got tired of waiting for celticminstrel and time is running out, so...
20161012 05:50:30< tad_carlucci> So far so good.
20161012 05:51:02< shadowm> vultraz: You reviewed my PR, right?
20161012 05:51:14< vultraz> yes
20161012 05:51:22< shadowm> Codewise?
20161012 05:51:33< shadowm> Did you review all new UI strings as well?
20161012 05:51:34< tad_carlucci> For those interested. I am doing some last-minute checks but the changeset is up: GregoryLundberg/GL_Upgrade_Lua ... the screaming and hollering may commence.
20161012 05:53:35< tad_carlucci> Do not attempt to read all 7000+ lines of change in "Replace Lua 5.2.3 with Lua 5.3.3" they say, in effect, delete everything and start with clean, unchanged sources from Lua.org
20161012 05:54:07< vultraz> shadowm: only think im pondering is if 
20161012 05:54:20< vultraz> "Bookmarks the currently selected folder" is better
20161012 05:54:24< vultraz> than "viewed"
20161012 05:54:40< shadowm> No, because that's an outright lie.
20161012 05:54:43< vultraz> ok
20161012 05:54:45< vultraz> then good to go
20161012 05:54:46< shadowm> The selected folder != the viewed folder.
20161012 05:54:57< vultraz> was baout to say that
20161012 05:54:58< shadowm> Unless you are looking at a symbolic link or the .. entry.
20161012 05:55:08< shadowm> *you've got selected a
20161012 05:55:32< shadowm> I could use "current folder" instead, though.
20161012 05:55:51< vultraz> ah
20161012 05:55:53< vultraz> that sounds good
20161012 05:55:58< vultraz> yes, do that
20161012 05:57:39< shadowm> What I need for the cursor issue is a window::do_i_have_the_focus or so method.
20161012 05:58:04< shadowm> Or a window focus lose/acquire event, which doesn't exist.
20161012 05:58:44-!- travis-ci [~travis-ci@ec2-54-197-77-107.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 05:58:45< travis-ci> wesnoth/wesnoth#11460 (master - 0ac4c0f : Charles Dang): The build is still failing.
20161012 05:58:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166952232
20161012 05:58:45-!- travis-ci [~travis-ci@ec2-54-197-77-107.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 06:00:23< shadowm> I'll need to look further into the window initialization code to see if I can figure out how multiple windows manage to coexist.
20161012 06:11:04-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161012 06:11:05< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 4915f0349c67 / / (5 files in 3 dirs): desktop: Add functionality to enumerate paths of interest https://github.com/wesnoth/wesnoth/commit/4915f0349c67c2b15130bbaa46acbfc927f427d6
20161012 06:11:08< irker493> wesnoth: Ignacio R. Morelle wesnoth:master d1951b40b92d / / (4 files in 3 dirs): gui2/tfile_dialog: Add a bookmarks bar https://github.com/wesnoth/wesnoth/commit/d1951b40b92d5cc4f34c8936c54f73fcc07149b1
20161012 06:11:11< irker493> wesnoth: Ignacio R. Morelle wesnoth:master eb3bc1f0ce88 / data/gui/window/file_dialog.cfg: gui2/tfile_dialog: Rearrange some elements https://github.com/wesnoth/wesnoth/commit/eb3bc1f0ce88a3f2b0f0e9eace1c0b868d3d7a61
20161012 06:11:14< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 71f69a8f301a / src/desktop/ (paths.cpp paths.hpp): desktop: Add support for user-defined bookmarks https://github.com/wesnoth/wesnoth/commit/71f69a8f301a0b5a09f62f53aba35047dc0030e8
20161012 06:11:17< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 007a76d72fb4 / / (3 files in 2 dirs): gui2/tfile_dialog: Add support for user-defined bookmarks https://github.com/wesnoth/wesnoth/commit/007a76d72fb4a41238a19e1eb7cb859973e3dd62
20161012 06:11:20< irker493> wesnoth: Ignacio R. Morelle wesnoth:master bb005cfe3c14 / src/gui/dialogs/ (file_dialog.cpp folder_create.cpp folder_create.hpp): gui2/tfile_dialog: Allow users to customize labels when bookmarking paths https://github.com/wesnoth/wesnoth/commit/bb005cfe3c14a6623ad4fbec0b1e9046c87f6e4e
20161012 06:13:36< vultraz> \o/
20161012 06:13:51-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 06:13:52< travis-ci> wesnoth/wesnoth#11461 (master - 7630651 : Ignacio R. Morelle): The build is still failing.
20161012 06:13:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166954236
20161012 06:13:52-!- travis-ci [~travis-ci@ec2-54-205-230-14.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 06:14:18< shadowm> You now have another thing to tweet about orsocial media about.
20161012 06:14:22< shadowm> .............
20161012 06:14:29< shadowm> You now have another thing to social media about.
20161012 06:14:49< vultraz> And you can mark https://gna.org/bugs/index.php?24517 as fixed :D
20161012 06:14:58< vultraz> well, implemented 
20161012 06:15:11< vultraz> but gna uses the Fixed moniker anyway
20161012 06:16:21< shadowm> Yes, because we chose that wording because it makes it simpler to filter completed items.
20161012 06:16:49< shadowm> Or more accurately, that's the reason why I did not add a new status for FRs.
20161012 06:17:36< vultraz> Seriously, this dialog looks *amazing* now
20161012 06:20:46< vultraz> hm
20161012 06:20:48< vultraz> 20161012 17:16:02 error desktop: enumerate_win32_drives(): GetVolumeInformation() failed (21)
20161012 06:21:00< vultraz> must be something on my end
20161012 06:22:00< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 00f6417515b3 / changelog: Changelog items for stuff https://github.com/wesnoth/wesnoth/commit/00f6417515b34d5a90b8d46f0f3a96d7d4617826
20161012 06:22:18< shadowm> Not really.
20161012 06:23:41< shadowm> > ERROR_NOT_READY -- The device is not ready
20161012 06:23:54< shadowm> I forgot I was going to demote the error.
20161012 06:26:17< irker493> wesnoth: Ignacio R. Morelle wesnoth:master fdd7b98067b9 / src/desktop/paths.cpp: desktop: Demote a bit of enumerate_storage_devices() diagnostics on Windows https://github.com/wesnoth/wesnoth/commit/fdd7b98067b9e345a63570ace5a4447d853d0dc1
20161012 06:29:18< celticminstrel> shadowm: Sorry. I've built it, though there's one compile error (probably unrelated to your PR) so I haven't actually tried it out yet.
20161012 06:29:44< shadowm> Tried again? There's been at least two build error fixes pushed to master in the last 5 hours.
20161012 06:30:06< celticminstrel> I doubt it'll help with this one, but I could try, sure.
20161012 06:30:45< shadowm> It's kind of important that OS X builds work before Sunday. :p
20161012 06:34:14< celticminstrel> I'm guessing ancestral won't get this error though.
20161012 06:34:27< celticminstrel> So it may not be all that important.
20161012 06:34:36< celticminstrel> (I'll fix it anyway, though.)
20161012 06:36:09< tad_carlucci> vultraz just flagged the Lua upgrade as a milestone .. so the builders for Xcode, CodeBlocks or whatever else will need to check the changes for Visual Studio, CMake or Scons, or get with me, to update their tool sets. VC12 project diff is pretty readable for what needs to be done.
20161012 06:36:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161012 06:36:49< vultraz> I can update cb once it's merged
20161012 06:38:00< tad_carlucci> vultraz, There are two CodeBlocks project files, btw. One says "scons" the other does not.
20161012 06:38:09< vultraz> zookeeper: will you be able to review 701 before the release? (the DM PR)
20161012 06:38:19< vultraz> tad_carlucci: yeah, no one cares for the scons one
20161012 06:38:36< tad_carlucci> vultraz, So commit a delete?
20161012 06:38:49< vultraz> no, leave it.
20161012 06:39:13< vultraz> i think one person who occasionally filters in and out uses it. they can update it if they want at some later date.
20161012 06:39:21< vultraz> i might delete it later, though
20161012 06:39:31< shadowm> tad_carlucci, vultraz: I know my opinion ceased to be relevant approximately 8 months ago, but I object to merging #822 before 1.13.6.
20161012 06:39:31< vultraz> (later is in some time in the future)
20161012 06:40:00< shadowm> The potential for breakage (not because of tad_carlucci's changes, but rather because of whatever upstream did between 5.2 and 5.3) is too big.
20161012 06:40:10< tad_carlucci> To me, your opinion is relavant.
20161012 06:40:33< vultraz> shadowm: I think it needs to go in so we can get any reports of said breakage as soon as possible. We don't have time to wait another 2 months or so.
20161012 06:40:33< shadowm> Even when I did a 5.2 -> 5.2 upgrade it turned out months later that it broke stuff for someone's add-on. That's how reliable upstream is.
20161012 06:40:50< celticminstrel> tad_carlucci: The scons one is very poorly maintained, though it was updated recently by Jamit IIRC.
20161012 06:41:32-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 06:41:33< travis-ci> wesnoth/wesnoth#11462 (master - db0b20d : Ignacio R. Morelle): The build was fixed.
20161012 06:41:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166957251
20161012 06:41:33-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 06:41:37< vultraz> shadowm: there's a potential for breakage, yes, but there are some UMC authors on 1.13, so we'll get some valuable testing.
20161012 06:42:05< zookeeper> vultraz, maybe
20161012 06:42:08< vultraz> better than wait until December and release and find out a month and a half before RC that stuff is broken
20161012 06:42:10< shadowm> Even if it turns out later than some bug/change introduced in Lua 5.3 renders a bug fix in 1.13.6 irrelevant?
20161012 06:42:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 06:42:22< shadowm> That kind of thing makes it really hard to do proper regression testing.
20161012 06:42:31< tad_carlucci> s/potential/certainty/ the question is how quickly can I get a fix in.
20161012 06:43:14< vultraz> if a bugfix is rendered irrelevant it can be removed.
20161012 06:43:18< tad_carlucci> My first concern is whether we need 5.0, 5.1 or 5.2 compatibliity. HttT and random cave generator did NOT.
20161012 06:43:24< shadowm> That's not what I meant.
20161012 06:43:55< shadowm> If you can't confirm a bug fix because a worse bug was introduced then that's no reason to remove the fix.
20161012 06:44:15< tad_carlucci> My second concern is OOS issues relating to IEEE 754 floating point support. 5.3 does not do the "fake 754" (whatever that was).
20161012 06:44:50< shadowm> vultraz: Anyway, if you are willing to rush such a massive change less than 7 days before release then hopefully you'll also be willing to release 1.13.7 3 days later in the worst case.
20161012 06:45:08< shadowm> (Or less than 3 days later.)
20161012 06:45:23< celticminstrel> Yeah, I'd say hold off on Lua upgrade until 1.13.7...
20161012 06:45:31< vultraz> I trust tad's skill and testing.
20161012 06:46:02< shadowm> We don't have sufficient test coverage for Lua given its complexity.
20161012 06:46:16< shadowm> We don't even have 100% test coverage for our own Lua API.
20161012 06:46:23< vultraz> And yes, it is a big change, but better to have a wider testing pool for longer.
20161012 06:46:46< vultraz> Specifically for the reason you just stated.
20161012 06:46:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161012 06:47:12< shadowm> And what about introducing unexpected variables to in testing?
20161012 06:47:38< tad_carlucci> My goal was to have it for 1.13.6+dev but it came ready sooner than I expected.
20161012 06:47:40< vultraz> That is potentially problematic, yes...
20161012 06:48:55< vultraz> I don't really want SpiritPO AND Lua 5.3 new in the same release, though.
20161012 06:49:22< vultraz> (assuming celticminstrel ever finishes SpiritPO)
20161012 06:51:29< tad_carlucci> My opinion: it's break it now or break it later. Either way it's going to break. How many people track -dev? No enough to get much milage on it for all the UMC, I bet.
20161012 06:51:46< vultraz> Yeah
20161012 06:51:52< vultraz> but more than we could test internally.
20161012 06:52:09< shadowm> "+dev" aren't releases and are basically used by no-one outside the dev team and a few random people with access to a working build environment.
20161012 06:52:37< shadowm> The official development releases do reach a higher number of people (still far less than official stable releases, though).
20161012 06:53:36< shadowm> celticminstrel: You might want to test this patch when you have the chance -- should be self-explanatory: https://dl.dropboxusercontent.com/u/21371130/poop/use_hostname_for_volumes_on_macos.diff
20161012 06:54:34< shadowm> And updated again because I misplaced a brace.
20161012 06:55:25< tad_carlucci> Well, I'm fried and it's late. Tomorrow I'm going to work on filling in the markdown file with notes about what it there and how I think it should be handled in the future.
20161012 06:55:31 * tad_carlucci waves.
20161012 06:55:53-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Leaving]
20161012 06:56:56< shadowm> Who was it that the other day was claiming that their Linux-based OS used something other than /media or /mnt for mounts?
20161012 06:57:10< JyrkiVesterinen> Me.
20161012 06:57:25< shadowm> Distribution and path?
20161012 06:57:35< JyrkiVesterinen> Siduction. /disks.
20161012 06:57:52< JyrkiVesterinen> I checked later on that /media does exist, though.
20161012 06:58:03< shadowm> Uh. Siduction is a Debian derivative.
20161012 06:58:19< shadowm> Why would it not use /media like Debian does...?
20161012 06:58:56< shadowm> (Also, Google is completely useless here because it doesn't take slashes.)
20161012 06:59:53< shadowm> JyrkiVesterinen: Is either of them a symbolic link to the other, perhaps?
20161012 07:00:06< JyrkiVesterinen> I haven't checked.
20161012 07:00:19< JyrkiVesterinen> (And I can't check it right now, I'm at work.)
20161012 07:00:29< vultraz> even if you wrap it in quotes?
20161012 07:00:37< vultraz> ie, "/disks"
20161012 07:00:44< shadowm> Yes.
20161012 07:00:51< shadowm> By which I mean, yes, even then.
20161012 07:01:42< vultraz> :/
20161012 07:02:07< shadowm> Yeah, sorry to break it to you, but Google is far from perfect.
20161012 07:02:17-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has joined #wesnoth-dev
20161012 07:11:30-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: Going offline]
20161012 07:11:58< Rhonda> Is the thing about stderr of wesnothd solved, or can/should I help with that still?
20161012 07:12:36< shadowm> More information is needed first.
20161012 07:18:45-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161012 07:19:52-!- vultraz_iOS [uid24821@wesnoth/developer/vultraz] has quit [Quit: Connection closed for inactivity]
20161012 07:52:39-!- yaiyan [~yaiyan@46.101.48.31] has quit [Ping timeout: 260 seconds]
20161012 07:54:02< zookeeper> mattsc, isn't this a mistake? https://git.io/vPgsd
20161012 07:54:14-!- yaiyan [~yaiyan@46.101.48.31] has joined #wesnoth-dev
20161012 07:54:39< zookeeper> oh, duh. it can also be a level, i missed that part in the wiki initially.
20161012 07:54:40< zookeeper> nevermind
20161012 08:05:44-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 08:05:45< travis-ci> wesnoth/wesnoth#11466 (master - bb005cf : Ignacio R. Morelle): The build was fixed.
20161012 08:05:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166961811
20161012 08:05:45-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 08:14:47-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20161012 08:30:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 08:32:31-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20161012 08:35:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20161012 08:42:03-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161012 08:42:19-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20161012 08:53:42< shadowm> I may have to disable the cursor blink code for 1.13.6. It seems I'll need something a bit more convoluted and requiring the collaboration of both twindow and ttext_.
20161012 08:57:20< shadowm> Unless someone can tell me exactly how to tell who is the active twindow.
20161012 08:58:17< shadowm> I've not even managed to find where in the event processing code are multiple windows taking into account so that only widgets in the active one receive events.
20161012 08:58:23< shadowm> *taken
20161012 09:03:49-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161012 09:04:44-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 09:04:45< travis-ci> wesnoth/wesnoth#11468 (master - 00f6417 : Ignacio R. Morelle): The build has errored.
20161012 09:04:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166963154
20161012 09:04:46-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 09:14:24< irker493> wesnoth: Ignacio R. Morelle wesnoth:master 0bd73c241225 / src/gui/dialogs/file_dialog.cpp: gui2/tfile_dialog: Disable the Delete button when the .. entry is selected https://github.com/wesnoth/wesnoth/commit/0bd73c241225c2d0ec491223e952fbab8b75aed8
20161012 09:17:12-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 09:43:39-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161012 09:44:35-!- louis94 [~~louis94@91.178.241.125] has joined #wesnoth-dev
20161012 09:52:21-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 09:52:22< travis-ci> wesnoth/wesnoth#11470 (master - fdd7b98 : Ignacio R. Morelle): The build was fixed.
20161012 09:52:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/166963757
20161012 09:52:22-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 10:03:31-!- louis94 [~~louis94@91.178.241.125] has quit [Quit: Konversation terminated!]
20161012 10:08:17-!- Appleman1234 [~Appleman1@KD106154018160.au-net.ne.jp] has quit [Read error: Connection reset by peer]
20161012 10:19:01-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 10:19:34-!- Appleman1234 [~Appleman1@KD106154018160.au-net.ne.jp] has joined #wesnoth-dev
20161012 10:19:49-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 248 seconds]
20161012 10:21:07< vultraz> shadowm: why?
20161012 10:21:31< vultraz> shadowm: that is, what is the issue that requires the checking of the current window.
20161012 10:23:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 240 seconds]
20161012 10:35:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Permission denied]
20161012 10:35:16-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161012 10:37:23-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20161012 10:48:47-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161012 10:52:35< tad_carlucci> When building on Visual Studio 2015 for Release a series of tests run at the end of the build. I get 158 failures for 158 tests. Is this expected or should I assume the Lua upgrade was involved and look into them?
20161012 10:53:02< JyrkiVesterinen> I don't know.
20161012 10:53:18< JyrkiVesterinen> I have disabled the tests locally because they fail for me too.
20161012 10:53:44< JyrkiVesterinen> However, I don't entirely follow the instructions in the wiki. The external\dll folder is not in my PATH.
20161012 10:54:27< JyrkiVesterinen> Instead, I have modified the project files to inject that directory to PATH when VS launches Wesnoth for debugging.
20161012 10:54:43< JyrkiVesterinen> That doesn't affect the WML test script, of course.
20161012 10:55:20< JyrkiVesterinen> Thus, the tests fail because Wesnoth can't launch when the script tries to launch it.
20161012 10:55:31< tad_carlucci> Then I will ignore the failures. PR 823 clears the NO FIFO DIR message .. doing a rebuild to verify no messages, errors or warnings for a Release build.
20161012 10:56:05< tad_carlucci> JyrkiVesterinen, I did the same thing for the path. So that explains it.
20161012 11:10:39-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: Rebooting]
20161012 11:15:54-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161012 11:20:14< irker493> wesnoth: Charles Dang wesnoth:master 107f04924a9e / src/gui/dialogs/multiplayer/mp_staging.cpp: MP Staging: fixed active status of some options when loading a saved game https://github.com/wesnoth/wesnoth/commit/107f04924a9efe6ea18b5641af50689d9afdf5e5
20161012 11:22:04-!- Bonobo [~Bonobo@2001:44b8:254:3200:64a9:4db2:6264:2472] has quit [Quit: Leaving]
20161012 11:27:21-!- Nobun [~nobun@5.170.105.156] has joined #wesnoth-dev
20161012 11:28:37< Nobun> Hi. I'm currently writing for myself a tiny python utility (temporary name: txt2utf8) wich should re-encode all txt files contained into a wesnoth addon to utf-8 format
20161012 11:29:33< Nobun> example:  txt2utf8 --addondir=/my/addon/dir --destdir=/my/addon/utf8dir --filters cfg lua txt pot po
20161012 11:29:48< Nobun> (the last parameter is optional... I showed the default value).
20161012 11:30:01< Nobun> Do you think it can be useful also for others
20161012 11:30:02< Nobun> ?
20161012 11:30:09-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 11:31:01< vultraz>  quite possibly 
20161012 11:31:05< vultraz> you should post it on the forums
20161012 11:32:40< Nobun> vultraz: I'm currently developing it for myself... however when it is ready I will submit it into forum, as you suggested
20161012 11:34:00< Nobun> thank for suggestion :)
20161012 11:36:09< tad_carlucci> Nobun, What is the encoding of the input text?
20161012 11:36:56< Nobun> tad_carlucci: It is an experimental idea... I don't know if it works. I will give NO input text encoding so python3 can read every file indipendently
20161012 11:37:20< Nobun> the outfile, instead, will be opened with encoding='utf-8'
20161012 11:38:00< tad_carlucci> Nobun, A plaing ASCII file, for instance (\u0000 to \u007f) is already utf-8 encoded.
20161012 11:38:50< tad_carlucci> Nobun, But a Windows codepage file .. you'll need to know the codepage to convert it. And you can not accurately determine that from the file.
20161012 11:39:07< Nobun> tad_carlucci: not always true. For example I discovered that a campaign I developed (under windows xp several years ago) was not utf-8, even if cfg files are .txt files
20161012 11:39:50< Nobun> the tool was mainly intendent to re-convert all .cfg files of my campaign into utf-8 text files
20161012 11:39:56-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20161012 11:40:14< tad_carlucci> Nobun, That's my point: if it had some byte value outside 0-7f and wasn't utf-8 you cannot be sure unless the human tells you the codepage.
20161012 11:41:19< Nobun> understood. But the point of using 'encode=utf-8' on dest file is to force python to write a utf-8 file as destination file
20161012 11:42:35< Nobun> As I said... I don't know if the idea work, I'm developing it rightly now. But I think that 'reading source from python, wich should understand what encoding it is, then rewrite every lines into another utf-8 files can work
20161012 11:42:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 11:43:05< Nobun> I am aware that the process can raise python errors, but it is experimental
20161012 11:43:54< tad_carlucci> http://stackoverflow.com/questions/90838/how-can-i-detect-the-encoding-codepage-of-a-text-file
20161012 11:54:05-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Leaving]
20161012 11:54:23-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161012 11:54:57-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20161012 12:07:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 12:08:26< Nobun> tad_carlucci: thank. However that link allows me to think that my idea can work.
20161012 12:09:11< tad_carlucci> How so?
20161012 12:12:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161012 12:19:19-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 12:19:40-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Leaving]
20161012 12:28:34< Nobun> becouse, if I understood correctly what it is said about c#, a read routine could read and interpret a text file on-the-fly
20161012 12:29:00< Nobun> wich is what open() will do in python (without specifying encoding)
20161012 12:29:37< Nobun> the problem is what can happen when a symbol (utf-8 incompatible) was found, when the action 'write to utf-8 file' is encountered
20161012 12:30:12-!- travis-ci [~travis-ci@ec2-54-147-58-26.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 12:30:13< travis-ci> wesnoth/wesnoth#11476 (master - 107f049 : Charles Dang): The build has errored.
20161012 12:30:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/167018708
20161012 12:30:13-!- travis-ci [~travis-ci@ec2-54-147-58-26.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 12:31:33< JyrkiVesterinen> Python likely doesn't attempt to detect character encoding of the input file. Most likely it simply assumes UTF-8.
20161012 12:32:00< JyrkiVesterinen> Which would mean that your fancy script merely copies the files without any changes.
20161012 12:40:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20161012 12:41:41< Nobun> JyrkiVesterinen: probanly you are right. However putting encoding='utf-8' on the output file should prevent to write things that are incompatible with utf-8 format... or I think so
20161012 12:49:48-!- Nobun [~nobun@5.170.105.156] has quit [Ping timeout: 265 seconds]
20161012 13:03:27-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 13:04:48-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161012 13:06:18< irker493> wesnoth: Charles Dang wesnoth:master 918e8e4102a8 / data/gui/window/preferences/03_display.cfg: Preferences: small tooltip grammar correction https://github.com/wesnoth/wesnoth/commit/918e8e4102a8ebe7b486943fe7615cb4f70f13fd
20161012 13:10:35-!- Appleman1234 [~Appleman1@KD106154018160.au-net.ne.jp] has quit [Ping timeout: 265 seconds]
20161012 13:12:17-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has quit [Ping timeout: 240 seconds]
20161012 13:14:28< irker493> wesnoth: Charles Dang wesnoth:master 524b4aaeea2f / data/advanced_preferences.cfg src/game_preferences.cpp: Point preferences::new_lobby at a new key that defaults to true https://github.com/wesnoth/wesnoth/commit/524b4aaeea2ffd0e80261d873cabe4c4a0fa1b20
20161012 13:15:50< irker493> wesnoth: Charles Dang wesnoth:master c0c87fa9dea9 / host-gui2.lua join-gui2.lua: Updated prefs key in GUI2 plugin contexts https://github.com/wesnoth/wesnoth/commit/c0c87fa9dea95986a8b93dc0248097c18bcee095
20161012 13:16:11< vultraz> new mp ui is now opt-out for all users.
20161012 13:16:38< vultraz> 1.13.6+ dev will remove the option entirely.
20161012 13:16:48< vultraz> along with the GUI1 code.
20161012 13:16:54< vultraz> and dialogs.
20161012 13:19:18< JyrkiVesterinen> You need to update host.lua and join.lua as well.
20161012 13:19:46< JyrkiVesterinen> You may also want to turn on the GUI2 MP tests in Travis CI.
20161012 13:25:39-!- Appleman1234 [~Appleman1@KD106154001050.au-net.ne.jp] has joined #wesnoth-dev
20161012 13:26:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 13:32:50-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161012 13:43:47-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 13:43:48< travis-ci> wesnoth/wesnoth#11478 (master - 918e8e4 : Charles Dang): The build passed.
20161012 13:43:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/167047352
20161012 13:43:48-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 13:46:54-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has joined #wesnoth-dev
20161012 13:52:56-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20161012 14:33:45-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 14:33:46< travis-ci> wesnoth/wesnoth#11479 (master - 524b4aa : Charles Dang): The build has errored.
20161012 14:33:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/167049618
20161012 14:33:46-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 14:35:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 14:40:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20161012 14:42:41< irker493> wesnoth: mattsc wesnoth:master 5770fa74f0eb / data/ai/lua/ai_helper.lua: ai_helper: check variable type when viewing_side is required parameter https://github.com/wesnoth/wesnoth/commit/5770fa74f0ebb9ce48a17a92d1f7df7944a8ed1c
20161012 14:44:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20161012 14:50:49< zookeeper> gah, i missed mattsc
20161012 14:53:26-!- gfgtdf [~chatzilla@x4e363a0d.dyn.telefonica.de] has joined #wesnoth-dev
20161012 14:59:18-!- Ivanovic [~ivanovic@p579FBF3F.dip0.t-ipconnect.de] has quit [Changing host]
20161012 14:59:18-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20161012 15:05:34-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161012 15:10:32 * mattsc is very sneaky at avoiding zookeeper 
20161012 15:11:01< zookeeper> mattsc, i've spent most of today on HttT S8. i think i've finally figured out how all that recruitment facet stuff works, now i just have to somehow get the gameplay to be fun.
20161012 15:12:38< mattsc> zookeeper: nice — the latter sounds hard though
20161012 15:12:56< zookeeper> i had a few problems with the recruit facets, but i probably don't have any particular examples left anymore
20161012 15:13:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161012 15:14:00< zookeeper> yeah, the main problem is that the assassins can get stuck just waffling back and forth on the enemy side of the map
20161012 15:14:15< mattsc> zookeeper: okay; I saw your comment about the ‘type=2’ thing.  That’s something flix added a couple years ago (and I agree that it’s somewhat unintuitive, but quite convenient nevertheless)
20161012 15:14:44< mattsc> zookeeper: hmm; if you send me an example, I can see if something can be done about that on the AI side
20161012 15:14:50< zookeeper> and when they don't, they're still not numerous enough to actually kill konrad if i have some gold left to just recruit a few units to help
20161012 15:15:08< mattsc> I see
20161012 15:16:14< zookeeper> so i was wondering whether they should target for example delfador, instead
20161012 15:16:38< zookeeper> but then that sort of misses the whole point of having dedicated assassins like that
20161012 15:17:39< zookeeper> anyway, what i have right now is https://paste.ee/p/g6F7h
20161012 15:17:50-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161012 15:19:10< zookeeper> so, nothing particularly fancy yet. maybe next i should try to spawn the assassin squad somewhere mid-scenario.
20161012 15:21:56< shadowm> vultraz: <shadowm> Okay, so textbox timers keep firing (obviously) when their parent window loses focus, and they keep getting redrawn accordingly.
20161012 15:22:33< shadowm> vultraz: This means that there can be more than one textbox with an active blinking cursor if they belong to different modal windows.
20161012 15:22:53< shadowm> You can see this yourself if you fire up the file dialog and then click on New Folder.
20161012 15:24:32< mattsc> zookeeper: thanks; I don’t have time for it now, will have a look later
20161012 15:29:46-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 15:33:32< zookeeper> mattsc, i wouldn't say the AI itself needs any changes, it seems to be working according to spec.
20161012 15:35:10< zookeeper> and i don't think it would make sense to muddy the spec by making it less strict or something, because then it might be indistinguishable from the normal (leader) targeting attributes.
20161012 15:47:24< mattsc> zookeeper: okay, sounds good.
20161012 15:59:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 15:59:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161012 15:59:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 16:05:56-!- travis-ci [~travis-ci@ec2-54-242-19-170.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 16:05:57< travis-ci> wesnoth/wesnoth#11481 (master - 5770fa7 : mattsc): The build has errored.
20161012 16:05:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/167075377
20161012 16:05:57-!- travis-ci [~travis-ci@ec2-54-242-19-170.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 16:07:37-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 240 seconds]
20161012 16:09:26-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has joined #wesnoth-dev
20161012 16:13:28-!- Kwandulin [~Miranda@p200300760F2C712BA5F613F6114EBEC2.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161012 16:14:18-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161012 16:20:12-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161012 16:25:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161012 16:26:37-!- Kwandulin [~Miranda@p200300760F2C712BA5F613F6114EBEC2.dip0.t-ipconnect.de] has quit [Ping timeout: 240 seconds]
20161012 16:26:43-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 16:28:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Client Quit]
20161012 16:29:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 16:38:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 16:55:10< Soliton> iceiceice, gfgtdf: we're already logging some performance stats. you can try '/query metrics' and '/query requests' to see them.
20161012 16:55:41< gfgtdf> Soliton: can i do that or do i ned more rights?
20161012 16:55:52< Soliton> for example currently one can see that one leave_game request took 10 seconds to be processed.
20161012 16:56:07< Soliton> gfgtdf: anyone can see those stats.
20161012 16:57:51< Soliton> metrics currently reports: '12663393 requests serviced. 10699877 (84%) requests were serviced immediately.'  in the logs i can see that for a previous instance that percentage was down to 20%.
20161012 16:59:29< Soliton> of course figuring out what this means and if there is an issue somewhere we can fix is another question...
20161012 16:59:47< gfgtdf> Soliton: thats still good to know thx
20161012 17:00:07< gfgtdf> Soliton: you know ehther the 1.13 boost::asio server supports this aswell ?
20161012 17:00:19< Soliton> i guess first it'd be useful to know when these lags happen. like time of day and in what situations.
20161012 17:01:10< Soliton> gfgtdf: looks like most of it is not implemented there yet.
20161012 17:01:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20161012 17:01:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 17:01:48< gfgtdf> Soliton: the first number is the total time and one one in brackets the max time?
20161012 17:02:17< Soliton> gfgtdf: indeed and it is in clock ticks so you need to divide by 100 to get seconds.
20161012 17:06:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20161012 17:07:32< gfgtdf> is the time until a package was completeley processed the pasrsing time + processing time or is there some other waitin time betwen those two?
20161012 17:07:48< gfgtdf> Soliton: like when the package ia parsed but still on some queue
20161012 17:08:24-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161012 17:09:18< Soliton> processing time is: after_processing - after_parsing
20161012 17:12:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161012 17:12:13-!- wedge010 is now known as wedge009
20161012 17:12:53-!- JyrkiVesterinen [~JyrkiVest@87-100-238-22.bb.dnainternet.fi] has joined #wesnoth-dev
20161012 17:13:27< gfgtdf> Soliton: hmm but is it possible that is waited some time on a network input queue befor its staeted beeing parsed?
20161012 17:16:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 17:18:13< JyrkiVesterinen> shadowm, I have checked the /disks and /media directories now. They are distinct, not symlinked to each other.
20161012 17:18:14< JyrkiVesterinen> https://gist.github.com/jyrkive/0dfedf1c74b8f1dd5fc1d23a58c3825a
20161012 17:18:33< Soliton> gfgtdf: parsing can only start after a complete message was received.
20161012 17:23:40< shadowm> JyrkiVesterinen: Posts from 2014 seem to suggest that's completely independent from removable storage.
20161012 17:24:18< shadowm> https://forum.siduction.org/index.php?topic=5055.msg42548#msg42548
20161012 17:24:21< JyrkiVesterinen> Hmm, that's easily possible.
20161012 17:24:33< shadowm> So I'll just keep ignoring it.
20161012 17:25:05< JyrkiVesterinen> The partitions I have in /disks are partitions in an external hard drive... but I boot siduction from the same drive.
20161012 17:26:09< JyrkiVesterinen> So, they may be "partitions which the installer was able to see when I installed the system", which means *local* partitions on most systems, not removable storage.
20161012 17:30:45-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has quit [Ping timeout: 248 seconds]
20161012 17:42:58-!- irker493 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161012 17:46:41-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has quit [Quit: leaving]
20161012 18:21:45-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161012 18:29:45-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161012 18:32:49-!- irker333 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161012 18:32:49< irker333> wesnoth: Jyrki Vesterinen wesnoth:master 76582bcf290f / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/76582bcf290fdb700f2a319cfea7ffb6b8c0e38e
20161012 18:32:49< irker333> wesnoth: Jyrki Vesterinen wesnoth:master 4fc5e25e8b8e / src/desktop/paths.cpp: Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/4fc5e25e8b8eed07bef7e14a082c3480c0df129b
20161012 18:32:50< irker333> wesnoth: Jyrki Vesterinen wesnoth:master cf65a384c1bc / host.lua join.lua: Update the preference key in GUI1 MP test plugins https://github.com/wesnoth/wesnoth/commit/cf65a384c1bc4d05393ec586ada5c6a3a82b7bbf
20161012 18:33:20< JyrkiVesterinen> 20161012 13:19:18< JyrkiVesterinen> You need to update host.lua and join.lua as well.
20161012 18:33:32< JyrkiVesterinen> I did that myself, commit cf65a384.
20161012 18:39:46< DeFender1031> vultraz, you around?
20161012 19:04:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161012 19:12:06-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161012 19:12:07< travis-ci> wesnoth/wesnoth#11483 (master - cf65a38 : Jyrki Vesterinen): The build passed.
20161012 19:12:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/167138646
20161012 19:12:07-!- travis-ci [~travis-ci@ec2-54-205-4-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161012 19:13:22-!- Nobun [~nobun@5.170.113.5] has joined #wesnoth-dev
20161012 19:18:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161012 19:56:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 20:00:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20161012 20:09:12< irker333> wesnoth: mattsc wesnoth:master 1d5aba9e8243 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/1d5aba9e824363144b2af6854acaef78a4ddb1d9
20161012 20:11:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 20:18:44-!- JyrkiVesterinen [~JyrkiVest@87-100-238-22.bb.dnainternet.fi] has quit [Quit: .]
20161012 20:21:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161012 20:22:41-!- Nobun [~nobun@5.170.113.5] has quit [Ping timeout: 265 seconds]
20161012 20:30:25-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161012 20:32:27-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161012 20:33:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 20:37:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161012 20:37:30-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 20:38:51-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 20:38:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161012 20:39:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 20:40:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161012 20:43:20-!- Nobun [~nobun@5.170.107.183] has joined #wesnoth-dev
20161012 20:44:06-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161012 20:47:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 20:54:23-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161012 20:55:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161012 21:08:54-!- zookeeper_ [~lmsnie@37.35.27.57] has joined #wesnoth-dev
20161012 21:14:06-!- EliDupree2 [~quassel@2604:a880:400:d0::9bb:2001] has joined #wesnoth-dev
20161012 21:14:11-!- iwaim__ [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20161012 21:15:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161012 21:17:06-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161012 21:17:27-!- Sirp_ [~Sirp@u17402953.onlinehome-server.com] has joined #wesnoth-dev
20161012 21:19:26-!- Netsplit *.net <-> *.split quits: Elsi_, EliDupree, zookeeper, iwaim, Sirp
20161012 21:19:51-!- enchi_ [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20161012 21:20:31-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 265 seconds]
20161012 21:20:31-!- zookeeper_ [~lmsnie@37.35.27.57] has quit [Ping timeout: 265 seconds]
20161012 21:20:31-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Ping timeout: 265 seconds]
20161012 21:20:39-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161012 21:20:42-!- Elsi [~Elsi@luwin.ulrar.net] has joined #wesnoth-dev
20161012 21:21:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161012 21:23:22-!- Netsplit *.net <-> *.split quits: Ravana_, _laco
20161012 21:23:53-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161012 21:28:18-!- _laco [~laco@static.183.80.201.138.clients.your-server.de] has joined #wesnoth-dev
20161012 21:28:18-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20161012 21:31:38-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161012 21:33:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161012 21:40:05-!- Nobun [~nobun@5.170.107.183] has quit [Quit: Salve a tutti]
20161012 22:18:05< irker333> wesnoth: mattsc wesnoth:master 2c2f79545e92 / data/ai/micro_ais/cas/ca_assassin_move.lua: Assassin Micro AI: remove unused parameters from function calls https://github.com/wesnoth/wesnoth/commit/2c2f79545e92c847de15a00cd3948ce32d26c08d
20161012 22:19:23-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161012 22:32:57< celticminstrel> So many commits in the past few days.
20161012 22:33:01< celticminstrel> Oh, you updated XCode. Thanks.
20161012 22:33:35< celticminstrel> "warning: There are too many unreachable loose objects; run 'git prune' to remove them."
20161012 22:34:19< celticminstrel> I have no idea what that means or whether git prune might do something bad...
20161012 22:34:43< celticminstrel> Also that sounds like the thing that git is supposed to automatically do periodically? ie git gc
20161012 22:38:50< celticminstrel> I need to do a thing in the XCode project actually, preferably before tad's Lua upgrade is merged.
20161012 22:39:34< mattsc> celticminstrel: no problem from my side; I am just fiddling with MAI code at the moment
20161012 22:40:09< mattsc> celticminstrel: this is an interesting question: https://forums.wesnoth.org/viewtopic.php?f=21&t=44570&p=603608#p603608
20161012 22:40:12< celticminstrel> I wonder if I can duplicate a target and change it to a static lib...
20161012 22:40:37< celticminstrel> If I create a new static lib target I'll have to update all the settings to match...
20161012 22:45:39< mattsc> celticminstrel: I have no comments on that since I don’t know anything about it.
20161012 22:45:46< mattsc> As for Micro AIs and shroud ...
20161012 22:46:15< mattsc> The problem is that wesnoth.find_path() and similar functions cannot distinguish between fog, shroud and units with the hides ability.
20161012 22:46:44< mattsc> However, I do want the MAIs to ignore hidden units (I am, in fact, in the process of adapting all the MAIs so that they do).
20161012 22:48:14< mattsc> So we could adapt those functions’ APIs so that they can distinguish between those.  Or we could just have the MAIs turn off shroud for the sides they control.
20161012 22:49:11< mattsc> celticminstrel: I don’t think what you just posted is what I’d like to do.
20161012 22:50:59< celticminstrel> I don't think the AI should ignore shroud.
20161012 22:51:15< mattsc> The AI does not work if it does not ignore shroud.
20161012 22:51:45< celticminstrel> That's a problem, then?
20161012 22:51:56< celticminstrel> Unless we're speaking specifically about the goto micro_ai here.
20161012 22:52:22< mattsc> No, I am speaking about the MtT CA of the default AI.
20161012 22:53:32< mattsc> … and probably some other such as retreat, not entirely sure and too busy with RL stuff to think about it
20161012 22:54:32< DeFender1031> one might suggest an "explorer" AI/phase... but that would be a heck of a lot of additional work
20161012 22:54:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161012 22:54:49< mattsc> indeed
20161012 22:54:54< celticminstrel> I wouldn't think retreat depends on ignoring fog.
20161012 22:55:00< DeFender1031> (meaning, if the AI can't see, it starts exploring)
20161012 22:55:02< mattsc> not fog, shroud
20161012 22:55:08< celticminstrel> That's what I meant.
20161012 22:55:09< mattsc> fog is not a problem
20161012 22:55:16< celticminstrel> Since normally you retreat to places you've already been.
20161012 22:55:36< mattsc> You might, that does not mean that the AI does.
20161012 22:55:44< celticminstrel> Also, retreat probably doesn't really require you to move across a band of shroud.
20161012 22:55:45< mattsc> As I said, I don’t know if it does.
20161012 22:56:06< celticminstrel> I'd think it would be more "move towards a safe-looking place", eg a village.
20161012 22:56:20< celticminstrel> And if there's shroud, that movement would clear it anyway.
20161012 22:56:43< mattsc> But the closest village could still be out of reach and under shroud.
20161012 22:57:00< mattsc> Anyways, that’s a detail that we don’t need to get wrapped up in right now.
20161012 22:58:04< celticminstrel> Sure, but it doesn't need to move to the closest one.
20161012 22:59:35< mattsc> As far as I am concerned, I am not going to change all the Micro AIs (and even less so the default AI) so that they work with shroud.  I do not know how many of them are affected.  I don’t see the point of requiring an AI to work with shroud set.
20161012 23:00:49< mattsc> From my point of view, it would be sufficient to add a warning to the MAI wiki page saying that an AI does (might) not work with shroud.  But I am also happy to change the setup so that it just turns off shroud for the side for which an MAI is used.
20161012 23:01:26< mattsc> As I wrote above, unfortunately we cannot currently distinguish between shroud and otherwise hidden units.
20161012 23:04:29< mattsc> And now I have to be off again …  :|
20161012 23:04:37< celticminstrel> I don't really get how that works...
20161012 23:05:01< celticminstrel> I'd rather say "this MAI doesn't work with shroud" than have it disable shroud automatically.
20161012 23:05:02< mattsc> how what works?
20161012 23:05:09< celticminstrel> The inability to distinguish
20161012 23:05:25< mattsc> find_path only has one parameter.
20161012 23:05:50< mattsc> it’s either “see all” or “use vision as per side X”
20161012 23:06:10< mattsc> I’m fine with saying that it does not work with shroud
20161012 23:06:50< mattsc> That will affect a lot of  MAIs though.
20161012 23:07:26< mattsc> s/will/does probably
20161012 23:07:35< mattsc> In any case, bye for now.
20161012 23:08:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161012 23:34:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161012 23:37:07-!- enchi_ is now known as enchi
20161012 23:37:19< mattsc> celticminstrel: I’m back in contact, but don’t have time to be at the computer right now.
20161012 23:37:19< mattsc> One thing we could do is have the MAIs pop up a warning message on the screen to turn off shroud for the side.  That way people don’t depend on actually reading TFM.
20161012 23:38:00< mattsc> [ The latter being the main problem I see with just saying so on the wiki. ]
20161012 23:49:15-!- Appleman1234 [~Appleman1@KD106154001050.au-net.ne.jp] has left #wesnoth-dev ["Leaving"]
--- Log closed Thu Oct 13 00:00:09 2016