--- Log opened Sun Oct 16 00:00:41 2016
20161016 00:27:20< vultraz> celticminstrel: any objections to merging the font pr?
20161016 00:40:05-!- enchi [enchilado@defocus/yummy/enchilado] has quit [Ping timeout: 268 seconds]
20161016 00:41:21-!- enchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20161016 00:42:51< gfgtdf> i wonder why github at https://github.com/wesnoth/wesnoth/pull/825 lists jyrkive as 'Battle for Wesnoth member' but me, celticminstrel, and GregoryLundberg not.
20161016 00:43:39< vultraz> gfgtdf: it shows you as a BfW member for me
20161016 00:44:11< vultraz> GregoryLundberg is tad and he doesn't have commit access 
20161016 00:45:10< gfgtdf> vultraz: hmm i thougth he has, since he alread has teh red naemin forums.
20161016 00:45:17< celticminstrel> [Oct 15@5:02:05pm] tad_carlucci: The issue is if C++ wants that float and asks for it as an integer, the API will crash unless the float has no fractiononal part, and can be represented as an integer.
20161016 00:45:18< celticminstrel> I wonder if we should use a custom luaW_checkinteger instead of the built-in lua_checkinteger, because a crash when trying to convert a float to an integer is pretty dumb.
20161016 00:45:37< vultraz> gfgtdf: i think he declined it
20161016 00:45:44< vultraz> i could ask again
20161016 00:45:45< celticminstrel> vultraz: No comments on the font PR. I started looking at it and gave up quickly.
20161016 00:45:51< celticminstrel> vultraz: He declined it.
20161016 00:45:58< vultraz> celticminstrel: ok, I shall merge.
20161016 00:46:05< vultraz> travis passes.
20161016 00:46:32< gfgtdf> vultraz: this is hot the page looks to me: https://s15.postimg.org/k3edgz6wb/Unbenannt.png
20161016 00:47:13< vultraz> odd
20161016 00:47:13< gfgtdf> how*
20161016 00:47:20-!- irker502 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161016 00:47:20< irker502> wesnoth: Chris Beck wesnoth:master e3417bd95443 / src/ (46 files in 10 dirs): split gui1 font interface into a font_config and sdl_ttf interface https://github.com/wesnoth/wesnoth/commit/e3417bd954430110f22f3a3b1da08125d1b2f187
20161016 00:47:22< irker502> wesnoth: Chris Beck wesnoth:master 1336306884ec / src/ (26 files in 9 dirs): move font_options, text.?pp to font folder https://github.com/wesnoth/wesnoth/commit/1336306884eceb8c00a952933dd9b180d7f5c603
20161016 00:47:24< irker502> wesnoth: Chris Beck wesnoth:master c2df4333800c / src/ (14 files in 5 dirs): move pango-related helper objects and functions to their own file https://github.com/wesnoth/wesnoth/commit/c2df4333800c7630db7cf9a046cb5cbe6691bfc5
20161016 00:47:26< irker502> wesnoth: Chris Beck wesnoth:master 42898b79f973 / src/font/ (text.cpp text.hpp): refactor font::ttext to use a vector for buffer https://github.com/wesnoth/wesnoth/commit/42898b79f973ee6cad4aa9beaf9840e0385ed166
20161016 00:47:28< irker502> wesnoth: Chris Beck wesnoth:master 1e1a23e08398 / src/font/pango/ (escape.hpp font.hpp hyperlink.hpp iter.hpp stream_ops.hpp): add missing copyright statements https://github.com/wesnoth/wesnoth/commit/1e1a23e083984c7c96aed260dd6124ccd394beb8
20161016 00:47:30< irker502> wesnoth: Chris Beck wesnoth:master 6b978a7411e5 / src/font/sdl_ttf.hpp: fix a copyright statement https://github.com/wesnoth/wesnoth/commit/6b978a7411e59f1d6490ad19efe995ea4a3b474d
20161016 00:47:32< irker502> wesnoth: Chris Beck wesnoth:master f82f996347d9 / src/ (29 files in 10 dirs): move font constants to their own compilation unit https://github.com/wesnoth/wesnoth/commit/f82f996347d948e0bbc4830e907d08d8e5f18c50
20161016 00:47:34< irker502> wesnoth: Chris Beck wesnoth:master b280639abeb2 / src/font/text.cpp: rewrite cairo format conversion function to avoid squirrely endian stuff https://github.com/wesnoth/wesnoth/commit/b280639abeb29bfcf6acb2afc3a71dbd89b43dc8
20161016 00:47:36< irker502> wesnoth: Chris Beck wesnoth:master a9f15c5795f9 / src/font/text.cpp: remove code comment related to surface buffer initialization https://github.com/wesnoth/wesnoth/commit/a9f15c5795f9f813e11843003c28dc1e87f8df84
20161016 00:47:38< irker502> wesnoth: Chris Beck wesnoth:master 7e844082f1f4 / src/font/text.cpp: fix indentation https://github.com/wesnoth/wesnoth/commit/7e844082f1f4c622de789cf27e40953afdb17937
20161016 00:47:40< irker502> wesnoth: Charles Dang wesnoth:master be51353800d4 / src/ (78 files in 16 dirs): Merge pull request #827 from cbeck88/font_refactor https://github.com/wesnoth/wesnoth/commit/be51353800d442e3c357185025271e57d470a958
20161016 00:47:49< gfgtdf> vultraz: it looks different for you ?
20161016 00:47:52< vultraz> projectfile update time!
20161016 00:48:09< vultraz> gfgtdf: yes i see you marked as a BfW member.
20161016 00:50:39< gfgtdf> vultraz: hmm
20161016 00:59:13-!- gfgtdf [~chatzilla@x4e32b220.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]]
20161016 01:09:09-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 01:12:52-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 01:15:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20161016 01:15:38-!- wedge010 is now known as wedge009
20161016 01:16:54< irker502> wesnoth: Charles Dang wesnoth:master c2f01ce2285d / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projectfile https://github.com/wesnoth/wesnoth/commit/c2f01ce2285d4b267d3e73895257dddc20264c87
20161016 01:17:11< vultraz> technically didn't need to include font/pango/ in the file, but did anyway for completeness 
20161016 01:17:29< vultraz> tad_carlucci: was the crash you observed before or after my fix commit?
20161016 01:17:38< celticminstrel> We need an XCode update too.
20161016 01:17:53< celticminstrel> tad_carlucci: Did you see what I said a little while before you showed up?
20161016 01:18:08< celticminstrel> mattsc: Do you have an updated XCode project yet? If so, feel free to commit it.
20161016 01:18:20< tad_carlucci> I believe it was before. Let me switch to Linux and check current master for recurrence. No I did not, checking now.
20161016 01:18:40< celticminstrel> I still want to separate Lua into a static lib in the XCode project, eventually...
20161016 01:20:21< tad_carlucci> celticminstrel, about a custom lua_checkinteger? 
20161016 01:21:22< celticminstrel> Yeah
20161016 01:21:35< tad_carlucci> celticminstrel, Implement it by getting the type and if it's integer, grab the integer; otherwise grab the float and use floor to fall back to 5.2 behavior and void a crash
20161016 01:21:36< celticminstrel> It really seems weird that Lua would do that, actually.
20161016 01:21:50< celticminstrel> Given that lua_checknumber and lua_checkstring automatically cast.
20161016 01:22:18< vultraz> tad_carlucci: i just merged a pr that will cause an almost-full rebuild
20161016 01:22:32< tad_carlucci> celticminstrel, I imagine the idea is to punt the ceil/floor/round question to us.
20161016 01:23:00< celticminstrel> That sounds like a terrible reason.
20161016 01:23:17< celticminstrel> Does lua_checknumber at least work for ints and floats equally?
20161016 01:23:27< tad_carlucci> vultraz, OK. So it'll be a long time testing. 
20161016 01:23:43< tad_carlucci> celticminstrel, I believe if you ask for a float it converts the integer to a float.
20161016 01:24:09< celticminstrel> Oh, what does type() return for an integer?
20161016 01:24:39< celticminstrel> Wait, I can test this.
20161016 01:24:55< celticminstrel> Looks like it's still "number"
20161016 01:25:11< celticminstrel> (Assuming type(1) takes it as an integer.)
20161016 01:26:25< tad_carlucci> I'm off for a couple minutes. Closing down Windows and starting Arch box.
20161016 01:26:28-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161016 01:28:25-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 01:28:44< tad_carlucci> Every time I do that I go "Wow, if only Windows 10 booted that fast!"
20161016 01:29:18< vultraz> I know not what this "fast boot" thing is you speak of :P
20161016 01:30:06< vultraz> (then again, that's mostly due to my absurd number of startup programs)
20161016 01:32:50< celticminstrel> W7 boots fairly quickly... not sure how it compares though. I haven't booted Fedora in ages.
20161016 01:33:11< celticminstrel> Haven't even booted Mac for awhile.
20161016 01:34:23< tad_carlucci> My Arch boots to login in about 6 seconds, wait for me to login, then desktop fully up and running in 2 more seconds.
20161016 01:34:46< celticminstrel> Not sure if Fedora's quite that fast, but I think it comes close.
20161016 01:34:55 * tad_carlucci nods.
20161016 01:35:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161016 01:36:29< celticminstrel> One bad thing about it was that the GUI package manager is useless, so I used yum to uninstall it.
20161016 01:37:11< vultraz> ...yum
20161016 01:37:13< celticminstrel> ...well, not useless, more like overly soimplified.
20161016 01:37:17< celticminstrel> ^simplified
20161016 01:37:17< vultraz> seriously
20161016 01:37:19< tad_carlucci> vultraz, One of my PRs is a 3-line change to the old src/font.cpp ... where did it move to?
20161016 01:37:22< vultraz> their package manager is named yum?
20161016 01:37:23< celticminstrel> vultraz: What?
20161016 01:37:32< celticminstrel> It used to be, they changed to a new one since then.
20161016 01:37:35< vultraz> tad_carlucci: ah... uh....
20161016 01:37:41< vultraz> tad_carlucci: which pr is this?
20161016 01:37:54< tad_carlucci> My fribidi 
20161016 01:38:00 * tad_carlucci is looking
20161016 01:38:15< celticminstrel> I'd ask iceiceice or just grep it.
20161016 01:39:22< vultraz> probably font/text_surface.*pp
20161016 01:39:49< celticminstrel> I wonder if that split will allow the text cache to be used by GUI2.
20161016 01:40:03< vultraz> splitting files alone wouldn't
20161016 01:40:07< celticminstrel> (We should probably remove the SDL_TTF stuf by the way.)
20161016 01:40:08< vultraz> you'd need to wire itin
20161016 01:40:15< vultraz> celticminstrel: can't do that yet
20161016 01:40:15< celticminstrel> Well, duh.
20161016 01:40:19< celticminstrel> Sure we can.
20161016 01:40:24< vultraz> not until gui1 is removed or uses ttext
20161016 01:40:51< celticminstrel> Yeah, making GUI1 use ttext is an assumed prerequisite. (Or dropping it altogether, but that's unlikely to happen anytime soon.)
20161016 01:41:09< celticminstrel> (In fact, I'm not confident in the ability to remove GUI2 entirely for 1.14.)
20161016 01:41:15< vultraz> yeah
20161016 01:41:21< celticminstrel> (The main issue being the game's ThemeUI.)
20161016 01:41:22< vultraz> wait what
20161016 01:41:30< vultraz> remove gui2? you mean gui1, right
20161016 01:41:34< celticminstrel> Yeah.
20161016 01:41:37< celticminstrel> Mistyped.
20161016 01:42:18< tad_carlucci> I found it ... /font/text_surface.cpp ...
20161016 01:43:07< vultraz> yes, I said that
20161016 01:44:11< vultraz> I think the comment in font/font_description is wrong...
20161016 01:44:21< vultraz> that deals with the stuff in [font], which is GUI1
20161016 01:44:36< celticminstrel> Maybe we should add a new global table, "gui", which contains all the dialog manipulation stuff... we should probably also have a userdata for the actual dialog (not quite sure if we do already)...
20161016 01:44:37< vultraz> or specifically, ttf
20161016 01:44:54< celticminstrel> ttf is the file format.
20161016 01:45:10< vultraz> sdl_ttf
20161016 01:45:30< celticminstrel> (ttf and also otf)
20161016 01:53:21< tad_carlucci> vultraz, My life would be much easier if PR 820 would merge. I have to remember to merge it, test a build, then remove it before I push.
20161016 01:53:31< irker502> wesnoth: mattsc wesnoth:master d89af04a6487 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update Xcode project https://github.com/wesnoth/wesnoth/commit/d89af04a6487a703dc0254f1b3cc013a27f501c9
20161016 01:53:46< mattsc> celticminstrel: ^
20161016 01:54:27< irker502> wesnoth: Gregory A Lundberg wesnoth:master 26449ffc58ee / src/font/text_surface.cpp: Supress warnings https://github.com/wesnoth/wesnoth/commit/26449ffc58ee232c6a0139e72431139a88003e28
20161016 01:54:29< irker502> wesnoth: Charles Dang wesnoth:master c489e189f232 / src/font/text_surface.cpp: Merge pull request #820 from GregoryLundberg/GL_fribidi_log2vis https://github.com/wesnoth/wesnoth/commit/c489e189f2325a62559d2ca52f04efa9deece524
20161016 01:56:30< vultraz> tad_carlucci: you sure you still don't want push access?
20161016 01:57:42< tad_carlucci> vultraz, Yes. I know it's a hassle on those who do, but it prevents error on my part and my PRs are better for someone having to look at them.
20161016 02:05:13< vultraz> celticminstrel: can https://github.com/wesnoth/wesnoth/pull/819 be merged?
20161016 02:05:23< celticminstrel> What is it again?
20161016 02:07:20 * celticminstrel needs the PR title
20161016 02:07:40< tad_carlucci> helper.lua: set __metatable field to guard against external access to metatables 
20161016 02:07:49< celticminstrel> Ah.
20161016 02:08:05< tad_carlucci> didn't look at it but like the subject
20161016 02:08:12< celticminstrel> I think the reason it's a PR is because I did it from the github web interface and thus didn't test it at all.
20161016 02:08:23< tad_carlucci> gak!
20161016 02:08:35< celticminstrel> Did the build pass, at least?
20161016 02:08:42< vultraz> yes
20161016 02:08:49< celticminstrel> Hmm...
20161016 02:09:10< pydsigner> Well someone pull it down and check, right?
20161016 02:09:33< pydsigner> Or does the build run all the test scenarios?
20161016 02:09:37< celticminstrel> Pretty much. Should only take a few minutes.
20161016 02:09:44< celticminstrel> The build runs all the unit test scenarios.
20161016 02:09:50< vultraz> ahhhhh fuckkkkk
20161016 02:09:58< celticminstrel> But I'm not sure if all the helper functions are used in at least one unit test scenario.
20161016 02:10:00< tad_carlucci> Just need to make a lua script to test it
20161016 02:10:08< vultraz> font pr broke stuff
20161016 02:10:12 * vultraz curses soundly
20161016 02:10:25< celticminstrel> I assumed you would have checked that before merging it. 9_9
20161016 02:10:28< celticminstrel> What'd it break?
20161016 02:10:34< vultraz> text :P
20161016 02:10:42< celticminstrel> So descriptive.
20161016 02:10:45< pydsigner> Surprise!
20161016 02:10:48< vultraz> it renders incorrectly
20161016 02:11:14< pydsigner> Hmm I guess you can't really test that with a build
20161016 02:11:50< tad_carlucci> I'm still building. Is it bad bad or fixable bad?
20161016 02:12:24< vultraz> quite-but-fixable-but-i-should-check-with-iceiceice bad
20161016 02:12:51< vultraz> actually im curious whether it displays incorrectly on other systems..
20161016 02:13:15< vultraz> so, if anyone else has a current master build, let me know if font rendering is fucked up
20161016 02:13:30 * tad_carlucci is building now
20161016 02:13:44< vultraz> since i assume iceiceice would not have declared this done with such a glaring bug, it's *possible* it's windows-specific
20161016 02:14:41< tad_carlucci> It'll be a while yet but I'll tell you if Linux looks OK. I take it it's immediately apparent upon starting the program?
20161016 02:14:49< vultraz> yes
20161016 02:15:35 * celticminstrel initiates Mac build.
20161016 02:17:47< vultraz> i have summoned iceiceice
20161016 02:17:51< celticminstrel> 292 files, huh
20161016 02:17:58< celticminstrel> What? He's summonable?
20161016 02:18:14< vultraz> @ comment on the pr :P
20161016 02:18:55< tad_carlucci> Hope he gets his emails, then. Do that to me and *maybe* the wife will mention it, but probably not.
20161016 02:18:58< vultraz> but i also have a chat open with him on Discord
20161016 02:19:01< vultraz> but he's not there rightn ow
20161016 02:19:36< tad_carlucci> Well, let's hope it's easily fixed.
20161016 02:19:59< vultraz> i have tracked down the problem code
20161016 02:21:03< celticminstrel> I think I have my github set to not email me.
20161016 02:22:38< tad_carlucci> I should do that, too.
20161016 02:22:57< vultraz> for reference, this is what I'm seeing https://drive.google.com/file/d/0B-mR9s8FduLLRW04bXNZNWM2cUk/view?usp=sharing
20161016 02:23:23< celticminstrel> I just killed Firefox to build Wesnoth, so don't expect me to look at that for awhile.
20161016 02:23:41< celticminstrel> If it was on a sane website I could probably view it with curl+ImageMagick.
20161016 02:24:14< vultraz> "sane"?
20161016 02:24:23< celticminstrel> But most image hosting websites probably aren't that sane.
20161016 02:24:28< tad_carlucci> Oh, my. Looks like an off-by-one causing the pixels to misalign.
20161016 02:24:56< celticminstrel> Well, basically to be "sane" it would need to be a direct image URL which doesn't care about the referrer. I think imgur actually qualifies (not that I'm recommending you use that).
20161016 02:25:18< irker502> wesnoth: Charles Dang wesnoth:master 0c546be54eef / INSTALL: INSTALL: make SDL 2.0.4 minimum for Linux as well https://github.com/wesnoth/wesnoth/commit/0c546be54eefe10e1a42d5d5ab2c3f763808dce8
20161016 02:25:38< celticminstrel> I don't think it's important that I view that image right now, so I'll just look at it when I next open Firefox... unless it's no longer relevant by then.
20161016 02:25:40< vultraz> tad_carlucci: if I remove the calls to unpremultiply, it displays correctly, but still with bad AA
20161016 02:26:28< tad_carlucci> celticminstrel, Imagine a white character with a black shadows and offset the white bit a pixel one way or the other.  AA sounds like the problem.
20161016 02:26:58< celticminstrel> 207/292 now
20161016 02:27:33< mattsc> vultraz: things look fine here
20161016 02:27:41< vultraz> mattsc: current master?
20161016 02:27:46< mattsc> yep
20161016 02:27:55< vultraz> you don't see anything like in the screenshot?
20161016 02:27:59< mattsc> nope
20161016 02:28:10< vultraz> well, that's... good
20161016 02:28:12< vultraz> I guess
20161016 02:28:19< vultraz> looking more and more like a windows problem...
20161016 02:28:31< tad_carlucci> Windows does do things .. differently.
20161016 02:28:40< celticminstrel> 250/292
20161016 02:28:55 * tad_carlucci needs a Spock eyebrow-raise emote.
20161016 02:29:58< pydsigner> s/differently/wrongly/ :P
20161016 02:30:29< celticminstrel> I can never decide whether to parse your name as "py-dsigner" or "pyd-signer".
20161016 02:31:16< celticminstrel> Oh, finished compiling now.
20161016 02:31:20< vultraz> I usually pronounce it "psy-dinger" even though that's wrong :P
20161016 02:31:34< celticminstrel> ...how the heck do you get that?
20161016 02:32:00< pydsigner> celticminstrel: a) is correct
20161016 02:32:21< celticminstrel> So is there a removed E there?
20161016 02:32:25< pydsigner> vultraz: I've actually heard that before so you're not the only one
20161016 02:32:27< pydsigner> celticminstrel: Yep
20161016 02:32:37< pydsigner> I thought it was cool 7 years ago
20161016 02:32:49< pydsigner> The irony is
20161016 02:33:06< pydsigner> Lots of people type it "pydesigner"
20161016 02:33:13< vultraz> pie designer? :P
20161016 02:33:22< celticminstrel> Heh...
20161016 02:33:29< celticminstrel> vultraz: No no, python, duh. :P
20161016 02:33:35< vultraz> ohh...
20161016 02:33:41< pydsigner> Lol
20161016 02:33:41< vultraz> I thought he baked pies or something
20161016 02:34:01< mattsc> I figured pi, as in the circle; reinventing the wheel  :P
20161016 02:34:16< pydsigner> mattsc: I like that aspect as well
20161016 02:34:38< vultraz> dropping the E feels like young!pydsigner was attempting to be Edgy.
20161016 02:34:44< vultraz> or should i say dgy
20161016 02:34:45< vultraz> :P
20161016 02:34:49< mattsc> pydsigner: seriously though, I seem to have always read it the way how you intended.  Got lucky, I guess.
20161016 02:35:40< celticminstrel> Text looks fine over here.
20161016 02:35:59< vultraz> ok, now we need to hear from le linux crow
20161016 02:36:00< vultraz> d
20161016 02:36:19< mattsc> vultraz: it’s a penguin, not a crow !!!
20161016 02:36:25< celticminstrel> Haha
20161016 02:36:30< mattsc> Someone once told me that vowels are overrated.  To which I replied: ndd
20161016 02:37:13< vultraz> 3edgy5me
20161016 02:37:19-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161016 02:37:27< vultraz> ah, the summoning ritual worked!
20161016 02:37:33< celticminstrel> I have no idea what ndd means.
20161016 02:37:43< celticminstrel> Maybe that's the point.
20161016 02:37:51< iceiceice> yes
20161016 02:37:53< iceiceice> 20161016 02:17:47< vultraz> i have summoned iceiceice
20161016 02:37:55< tad_carlucci> Still building, here. But from the sounds of things, I expect it's going to be Windows-only.
20161016 02:38:05< vultraz> iceiceice: I'm seeing this on windows, but people on mac os seem to have no problems https://drive.google.com/file/d/0B-mR9s8FduLLRW04bXNZNWM2cUk/view?usp=sharing
20161016 02:38:25< vultraz> iceiceice: removing the calls to unpremultiply seems to fix the color but not the bad aa
20161016 02:38:39< iceiceice> hmmm
20161016 02:38:40< vultraz> irregardless of sdl_blit or blit_surface
20161016 02:39:12< vultraz> i assume you're on linux and had no problems either
20161016 02:39:17< iceiceice> yeah i had no problems
20161016 02:39:22< iceiceice> to confirm, is it okay for you at this commit?
20161016 02:39:23< iceiceice> https://github.com/wesnoth/wesnoth/commit/f82f996347d948e0bbc4830e907d08d8e5f18c50
20161016 02:39:23< vultraz> ok, windows-only then :(
20161016 02:39:32< mattsc> celticminstrel: indeed without the vowels.
20161016 02:39:45< tad_carlucci> Bah. We don't need to stinkin' windoze.
20161016 02:39:51< vultraz> id have to revert and see...
20161016 02:40:14< iceiceice> you could just do `git checkout hash`
20161016 02:40:22< iceiceice> and then later `git checkout master` to reset
20161016 02:41:36< celticminstrel> ...wait, why is the XCode project set to generate position-dependent code?
20161016 02:41:45< celticminstrel> For Release builds only though.
20161016 02:42:13< vultraz> iceiceice: building at that
20161016 02:43:17< vultraz> iceiceice: yes, perfectly fine there
20161016 02:43:45< celticminstrel> ...what's the LUA_USE_MACOSX define for?
20161016 02:44:04< iceiceice> celticminstrel, it means that lua will use some macos x specific things in the OS lib i think
20161016 02:44:08< iceiceice> vultraz, hmmm
20161016 02:44:14< iceiceice> so i the most obvious guess is that 
20161016 02:44:15< tad_carlucci> celticminstrel, filesystem stuff mainly
20161016 02:44:46< pydsigner> echo windows >> .gitignore
20161016 02:45:10< celticminstrel> tad_carlucci, iceiceice: Do you know if it needs to be defined when including Lua headers, or is it sufficient for it to only be defined when compiling Lua itself?
20161016 02:45:34< iceiceice> celticminstrel, the headers shuld always be exactly the same for any compilation unit that includes them
20161016 02:45:42< iceiceice> which means the same preprocessor defines should be present
20161016 02:45:55< tad_carlucci> vultraz, confirming you patch fixed the crash I reported ealier
20161016 02:45:59< iceiceice> if not you can get ODR violations, link errors, undefined behavior, etc.
20161016 02:46:03< vultraz> tad_carlucci: sweet
20161016 02:46:18< vultraz> i guess it was as gfgtad said
20161016 02:46:24< vultraz> stale pointers to nodes
20161016 02:46:31< vultraz> since it was using emplace
20161016 02:46:32< tad_carlucci> vultraz, iceiceice White text looks file. Red/Blue/etc on MP Create Random, side colors is bad
20161016 02:46:46< iceiceice> vultraz, so,
20161016 02:46:48< celticminstrel> iceiceice: It seems the only place it's used is in luaconf.h, but I guess maybe that's enough...
20161016 02:46:50< tad_carlucci> So it's 'not quite' windows only
20161016 02:46:55< iceiceice> we could try swapping the definitions of R and A
20161016 02:46:59< iceiceice> for windows
20161016 02:47:07< iceiceice> which is what (I assume mordante?) was doing before
20161016 02:47:27< iceiceice> i mean that was his preprocessor busisness
20161016 02:47:27< iceiceice> https://github.com/wesnoth/wesnoth/commit/b280639abeb29bfcf6acb2afc3a71dbd89b43dc8#diff-8cbd0e34d55909a0771f5197c847d950L633
20161016 02:47:32< tad_carlucci> celticminstrel, Can you create a MP game, Random map. And check the color text on the team color drop-downs?
20161016 02:47:45< iceiceice> that might cause the artifacts you see
20161016 02:47:46< iceiceice> i guess
20161016 02:48:24< iceiceice> vultraz, i wonder if there is a way we can check what cairo thinks the endianness is
20161016 02:48:40< celticminstrel> Tooltip placement still broken.
20161016 02:49:12< celticminstrel> Okay, staging dialog is totally broken.
20161016 02:49:26< vultraz> what
20161016 02:49:36< celticminstrel> Everything disappears whenever the mouse moves, except if you hover over it.
20161016 02:49:55< celticminstrel> Also the coloured text looks bad, as tad_carlucci suggested.
20161016 02:50:13< celticminstrel> Wait, that's not quite right.
20161016 02:50:23< celticminstrel> Whenever I hover over a widget, everything else is darkened.
20161016 02:50:28< celticminstrel> Until it gets black.
20161016 02:50:33< celticminstrel> Except for that widget.
20161016 02:50:42< vultraz> yeah, know issue
20161016 02:51:00< celticminstrel> If it's known, why hasn't someone done something about it...
20161016 02:51:04< vultraz> it cannot handle partially-obscured rects
20161016 02:51:16< celticminstrel> Ah, it fixes itself when I use the window scrollbar.
20161016 02:51:53< celticminstrel> So maybe we don't need to fix the underlying issue. We just need an 800x600 definition for the dialog.
20161016 02:52:12< celticminstrel> Though fixing the underlying issue would still be great, if anyone can manage it.
20161016 02:52:21< vultraz> iceiceice: ok, using rgba on windows fixes it
20161016 02:52:26< vultraz> iceiceice: but not completely
20161016 02:52:33< vultraz> button text is the wrong color
20161016 02:52:42< iceiceice> hmmmm
20161016 02:52:49< vultraz> iceiceice: http://pastebin.com/TcRzNp9j
20161016 02:52:50< celticminstrel> I really don't like the new tooltips.
20161016 02:52:58< iceiceice> are you building using mingw or msvc?
20161016 02:53:05< vultraz> tdm gcc
20161016 02:53:06< celticminstrel> They're an ugly grey colour instead of the nice blue.
20161016 02:53:08< vultraz> which is mingw somehow
20161016 02:53:15< vultraz> celticminstrel: that's the point
20161016 02:53:18< vultraz> celticminstrel: it stands out
20161016 02:53:24< celticminstrel> I don't like it.
20161016 02:53:32< celticminstrel> Also, the gold outline was a lot nicer IMO.
20161016 02:53:33< vultraz> celticminstrel: give me a new color
20161016 02:53:40< celticminstrel> Hmm.
20161016 02:53:56< celticminstrel> I dunno, maybe a lighter blue or a dark teal or something.
20161016 02:54:21< vultraz> celticminstrel: i have yet to find such a shade that doesn't look like shit
20161016 02:54:31< celticminstrel> 1024x768 doesn't have the vanishing problem but still has a window scrollbar.
20161016 02:54:52< celticminstrel> So the 800x600 definition should probably be used at 1024x768 as well.
20161016 02:55:09< celticminstrel> MP Create still has resolution problems too.
20161016 02:55:16< vultraz> celticminstrel: there's nothing you can change for a small resolution
20161016 02:55:26< vultraz> celticminstrel: also, about Create, we need to implement overlapping panels
20161016 02:55:31< iceiceice> vultraz, this is what kristas does in anura:
20161016 02:55:32< iceiceice> https://github.com/anura-engine/anura/blob/trunk/src/cairo.cpp#L258
20161016 02:55:39< celticminstrel> Overlapping panels?
20161016 02:55:43< celticminstrel> That's stacked_widget.
20161016 02:55:49< iceiceice> actually thats a bit backwards in my mind,
20161016 02:55:54< iceiceice> she assumes that a is the last byte
20161016 02:56:02< iceiceice> even though its argb8888
20161016 02:56:04< vultraz> celticminstrel: what i imagine is, if there isn't enough space, Options would be "minimized" to the side, and you could click it to expand it
20161016 02:56:10< celticminstrel> Except I think stacked_widget only allows interacting with the top layer, so you'd need to change that.
20161016 02:56:26< celticminstrel> Minimizing to the side isn't overlapping...
20161016 02:56:31< iceiceice> but some people disagree on whether ARGB or BGRA means byte[0] is A or B
20161016 02:56:37< iceiceice> unfortunately...
20161016 02:56:40< vultraz> celticminstrel: yes, since it would need to slide out over the other stuff
20161016 02:56:51< celticminstrel> iceiceice: Pretty sure that would depend on endianness.
20161016 02:57:05< celticminstrel> vultraz: Any reason why the current left panel couldn't be a fourth tab?
20161016 02:57:06< iceiceice> sure but even like, orthogonal to endianness
20161016 02:57:33< iceiceice> it's "is the most signfiicant byte listed first or list in the sequence ARGB"
20161016 02:57:34< vultraz> celticminstrel: because stacked_widget doesn't allow more than one layer displayed at a time!
20161016 02:57:40< iceiceice> *or last
20161016 02:57:56< celticminstrel> vultraz: Uhh... pretty sure the whole point of stacked_widget was for all layers to be visible at the same time.
20161016 02:58:05< vultraz> hmmmm
20161016 02:58:07< celticminstrel> Then shadowm came along and implemented the ability to have only one visible.
20161016 02:58:12< vultraz> right
20161016 02:58:14< vultraz> ok
20161016 02:58:28< vultraz> well, it doesn't allow >1 but <max to be visible at once
20161016 02:58:35< celticminstrel> The actual problem with stacked_widget is interaction, not visibility.
20161016 02:58:54< iceiceice> vultraz, i wonder if it's an issue with how cairo is configured for you
20161016 02:59:08< iceiceice> but there should also be a way to get some kind of diagnostic i think
20161016 02:59:13< celticminstrel> If we're going to use it for something like that, then elements on any layer need to be interactable, not just the top layer.
20161016 02:59:24< celticminstrel> Oh BTW vultraz, you never did the deprecation check for stacked_widget did you.
20161016 02:59:31< vultraz> no
20161016 02:59:59< vultraz> celticminstrel: what would be really nice to have is something like dota 2 does here with this slide-out panel: https://drive.google.com/file/d/0B-mR9s8FduLLYktPRnQ4Q1A1X0U/view?usp=sharing
20161016 03:00:10< vultraz> but we have no such tech
20161016 03:00:15< vultraz> animating it least of all
20161016 03:00:21< vultraz> let alone shoving content aside
20161016 03:00:23< vultraz> :|
20161016 03:00:34< vultraz> (anura does, but we're not using that are we :| )
20161016 03:01:32< celticminstrel> Animating is the least of the issues.
20161016 03:01:39< vultraz> yes
20161016 03:01:39< celticminstrel> It doesn't need to be animated to work.
20161016 03:01:49< celticminstrel> We have stuff like that with the tree nodes.
20161016 03:02:11< celticminstrel> Maybe such a thing could be implemented with a tree view or similar widget.
20161016 03:02:11< vultraz> iceiceice: so how do you recommend i handle this
20161016 03:02:22< iceiceice> i dont know i'm going to try to read docs in cairo
20161016 03:02:27< vultraz> iceiceice: with my patch it displays right, but text colors are off
20161016 03:02:28< iceiceice> and figure out what thi smeans
20161016 03:02:48< vultraz> iceiceice: ie, the gold in buttons becomes dark blue)
20161016 03:03:09< iceiceice> vultraz, i think your patch could also use some change probably
20161016 03:03:11< vultraz> celticminstrel: do tree views work horizontally?
20161016 03:03:38< celticminstrel> Do they use a generator?
20161016 03:03:40< iceiceice> vultraz, in the original code:
20161016 03:03:41< iceiceice> https://github.com/wesnoth/wesnoth/commit/b280639abeb29bfcf6acb2afc3a71dbd89b43dc8#diff-8cbd0e34d55909a0771f5197c847d950L633
20161016 03:03:56< iceiceice> BIG_ENDIAN => alpha is p[0]
20161016 03:03:58< vultraz> celticminstrel: uhh... not sure
20161016 03:04:04< iceiceice> little endian => alpha is p[3]
20161016 03:04:25< tad_carlucci> The color issue is not just the drop-downs. The scenario objectives are almost unreadable.
20161016 03:04:42< celticminstrel> If they use a generator then it would probably be fairly simple to add a horizontal tree view (just add a new builder).
20161016 03:05:12< vultraz> i really dislike this different builders for horizontal and vertical thing
20161016 03:05:13< iceiceice> hmm i lost track of your pastebin
20161016 03:05:22< iceiceice> vultaraz: did you also change the last line of the function when you changed rgba?
20161016 03:05:24< vultraz> iceiceice: http://pastebin.com/TcRzNp9j
20161016 03:05:32< celticminstrel> The builders are pretty small classes, so I don't really see the issue.
20161016 03:05:37< tad_carlucci> Colors on the Help viewer are good, though.
20161016 03:05:41< vultraz> iceiceice: no if i do that, the text becomes a horrible horrible yellow
20161016 03:06:24< tad_carlucci> So .. what's different about how the help viewer renders colored text?
20161016 03:06:31< vultraz> ie, c = (static_cast<Uint32>(r) << 24) | (static_cast<Uint32>(g) << 16) | (static_cast<Uint32>(b) << 8) | static_cast<Uint32>(a);
20161016 03:06:44< vultraz> tad_carlucci: sdl ttf vs pango/cairo
20161016 03:06:48< iceiceice> vultraz, try this maybe
20161016 03:06:48< iceiceice> http://hastebin.com/daketeyetu.cpp
20161016 03:08:19< vultraz> iceiceice: no, as i said, that makes my text look like this: https://drive.google.com/file/d/0B-mR9s8FduLLOE41alRjdEpmRjA/view?usp=sharing
20161016 03:08:47< celticminstrel> Why is the hastebin pronounceable? o.O
20161016 03:08:50< celticminstrel> Is that normal?
20161016 03:09:02< iceiceice> not sure
20161016 03:09:15< iceiceice> alternating between vowel and consonant is a good way to make a string that humans can remember
20161016 03:09:27< iceiceice> vultraz, i'm looking at this email which i fonud:
20161016 03:09:27< iceiceice> https://mail.gnome.org/archives/gtkmm-list/2007-May/msg00111.html
20161016 03:09:51< vultraz> iceiceice: with my patch only it looks like this https://drive.google.com/file/d/0B-mR9s8FduLLbVRHOTNSU2FiR0E/view?usp=sharing
20161016 03:10:03< vultraz> iceiceice: correct rendering, but color is off
20161016 03:10:28< celticminstrel> I wonder if feeding, eg, the Oxford English dictionary to a Markov generator would produce lots of interesting "words"...
20161016 03:10:44 * celticminstrel random tangents
20161016 03:10:54< iceiceice> vultraz, yah but your patch looks wierd to me
20161016 03:10:59< vultraz> iceiceice: yes
20161016 03:11:06< iceiceice> because you are actually changing the channels around
20161016 03:11:16< iceiceice> if you don't include the part i had at the end
20161016 03:11:40< vultraz> i dont get it either
20161016 03:12:20< vultraz> but changing the last line results in baaaad rendering
20161016 03:13:52< iceiceice> vultraz, it's going to take me a while to figure out what to do
20161016 03:14:11< iceiceice> it might be worth it to make some kind of "cairo sanity check" module
20161016 03:14:27< iceiceice> also i guess i would like to see why the original code was working,
20161016 03:14:35< iceiceice> hmmm
20161016 03:14:40< iceiceice> another thing is we could try doing UBSAN
20161016 03:14:56< iceiceice> like, using one of the undefined behavior santiizers
20161016 03:15:08< iceiceice> i think my casts are legal there but you neve rknow
20161016 03:15:30< iceiceice> oh
20161016 03:15:36< iceiceice> i guess i could try building on linux with mingw?
20161016 03:15:48< iceiceice> and using the windows dependency kit?
20161016 03:15:51< iceiceice> and see if i can repro
20161016 03:20:06< iceiceice> vultraz, the simplest thing may be to just revert that commit for now on master
20161016 03:20:06< vultraz> iceiceice: ftr i have cairo 1.10.2 (runtime 1.10.0) and pango 1.28.3 (runtime same)
20161016 03:20:22< iceiceice> and can make a new PR which contains it and work it out from there
20161016 03:20:32< iceiceice> if you are worried about leaving master broken
20161016 03:20:51< iceiceice> i dont think this will be solved that quickly
20161016 03:20:56< vultraz> iceiceice: there's no release pending, so I'll leave it in for awhile
20161016 03:26:37< iceiceice> ok
20161016 03:32:24 * celticminstrel should have a commit coming soon...
20161016 03:32:54< celticminstrel> Huh? Adding -llua was enough?
20161016 03:33:08< celticminstrel> I actually expected that to not work. I kinda thought it might try to use the system Lua instead, which is 5.3...
20161016 03:34:13< celticminstrel> 5.3.1 to be precise
20161016 03:34:21< celticminstrel> Should probably update it.
20161016 03:34:48< tad_carlucci> Do NOT try to use 5.3 lib with 5.2 calls. The ABI won't fit.
20161016 03:35:04< celticminstrel> Well, it's working, so I'm assuming the system Lua is not being taken.
20161016 03:35:15< celticminstrel> I'll get mattsc to verify it works for him as well.
20161016 03:35:43< celticminstrel> As soon as I run the unit tests, I'll push it.
20161016 03:36:03< tad_carlucci> Rather than revert right now, I'd suggest giving it 48 hours or so to try to fix the text rendering issues, first.
20161016 03:36:25< celticminstrel> Oh, that's at vultraz not me I guess.
20161016 03:36:27< vultraz> iceiceice: btw i think unpremultiply would be clearer in this format http://pastebin.com/AXcLsqjf
20161016 03:36:33< celticminstrel> I was wondering why you were suddenly talking about reverting.
20161016 03:37:01< tad_carlucci> celticminstrel, You're talking about the XCode project? So it can't break anyone else.
20161016 03:37:18< celticminstrel> Yeah.
20161016 03:38:38< iceiceice> celticminstrel, well it depends if the font rendering is bad enough that it will hinder other people's dev work
20161016 03:39:11< iceiceice> idk, just thought i would mention it as an option, since its clearly broken and i dont see how to fix yet
20161016 03:39:12< celticminstrel> iceiceice: For me at least it doesn't seem that bad... although the Lua console isn't showing punctuation, but if I recall correctly that was already the case before this.
20161016 03:39:16< vultraz> iceiceice: i can make due with my patch locally and it doesn't seem to be a problem on mac os and linux
20161016 03:39:24< celticminstrel> "make do"
20161016 03:39:28< iceiceice> ok
20161016 03:39:30< vultraz> er, yes
20161016 03:39:32< vultraz> do :P
20161016 03:39:32< tad_carlucci> For me, on Linux, it's bad only for colored text and won't effect my work. IF you know what it should say, it's readable enough.
20161016 03:39:33< vultraz> typo
20161016 03:39:39< iceiceice> i will try to get my cross-compile build running again
20161016 03:39:45< iceiceice> and see if i can reproduce the problem that way
20161016 03:39:49< celticminstrel> I think even the coloured text was perfectly readable for me.
20161016 03:39:51< vultraz> tad_carlucci: yeah, I think im observing the same color issues w/ patch
20161016 03:40:01< vultraz> so it seems only mac os is perfectly unaffected..
20161016 03:40:09< iceiceice> vultraz, one crit of your pastebin:
20161016 03:40:09< iceiceice> std::min<int>(255, temp);
20161016 03:40:16< celticminstrel> Uh, no, it's not perfectly unaffected.
20161016 03:40:21< celticminstrel> Coloured text is missing pixels.
20161016 03:40:22< tad_carlucci> So we may be talking about two similar, but different, points of error.
20161016 03:40:28< iceiceice> i guess it will cause a warning on gcc maybe?
20161016 03:40:31< iceiceice> because it compares signed and unsigned
20161016 03:40:37< vultraz> iceiceice: that's why it has <int>
20161016 03:40:39< celticminstrel> That's not a comparison.
20161016 03:40:43< iceiceice> might be better with std::min<unsigned>
20161016 03:40:59< iceiceice> or std::min(255u, temp)
20161016 03:41:20< tad_carlucci> If one of the values is 8bit unsigned would be required.
20161016 03:41:29< iceiceice> dont really want temp to be converted to signed int
20161016 03:41:43< vultraz> well, whatever you think isb est
20161016 03:41:44< vultraz> 255u works
20161016 03:41:52< iceiceice> idk it probably works out the same but it's harder for me to see through it if theres more intermediate types
20161016 03:41:53< vultraz> i just think this format is easier to read
20161016 03:42:03< tad_carlucci> I hit a signed/unsigned checking Travis this morning. Probably not here, though.
20161016 03:42:10< vultraz> we should always use min/max when possible
20161016 03:42:14< iceiceice> yah ok
20161016 03:42:21< iceiceice> or `std::clamp` :p
20161016 03:42:44< vultraz> yeah, but A we don't need that here and B that's c++17
20161016 03:42:45< vultraz> :P
20161016 03:43:08< vultraz> clamp will be great for the tims we have to call min(max(max, val), min)
20161016 03:43:54< tad_carlucci> Gee, I hope you do: min(max(minv,val),maxv)
20161016 03:44:02< vultraz> ofc
20161016 03:45:15< tad_carlucci> add a ?: to order minv and maxv and don't you have clamp? Do a shim?
20161016 03:45:27< vultraz> ..wha?
20161016 03:45:57< tad_carlucci> need to handle maxv<=minv and istm that's clamp?
20161016 03:46:47< vultraz> why would maxv be < minv
20161016 03:47:04< tad_carlucci> "Never underestimate the ability of programmers to do dumb things."
20161016 03:49:53< tad_carlucci> Well, I'm not going to be much help with the text rendering issue. I'm switching back to Windows to fiddle with some ideas there.
20161016 03:50:06-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161016 03:50:45< iceiceice> vultraz, hmm i realized there is some UB in the old code
20161016 03:50:59-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 03:51:12< iceiceice> at this line:
20161016 03:51:12< iceiceice> https://github.com/wesnoth/wesnoth/commit/b280639abeb29bfcf6acb2afc3a71dbd89b43dc8#diff-8cbd0e34d55909a0771f5197c847d950L597
20161016 03:51:21< iceiceice> unsigned values[255]; is a bug,
20161016 03:51:30< iceiceice> that means that taking at index 255 is out of bounds
20161016 03:51:37< iceiceice> there should be 256 nubmers in the cache i guess
20161016 03:52:00< tad_carlucci> Linux shotdown complained about socket endpoints not connected. Probably because wesnothd didn't shut down when I quit while creating an MP and never actually entered an MP game. But noting the message, just in case.
20161016 03:52:14< shadowm> values[255 - 1] -> values[254] ?
20161016 03:53:09< shadowm> i is in [1, 256), it says values[i - 1] = 255*256/i, so even values[255] isn't accessed.
20161016 03:53:33< shadowm> (But then values[255] is left uninitialized.)
20161016 03:53:52< iceiceice> i mean values[255] is not een part of the array
20161016 03:54:01< iceiceice> i think what happens is you get UB when the alpha is 255
20161016 03:54:44< shadowm> Oh right, I got an off by one error, values[255] simply doesn't exist.
20161016 03:55:21< shadowm>     int div = decode_table.values[alpha - 1];
20161016 03:55:40< shadowm> This is the only other place (in the old decode_pixel()) that accesses that array.
20161016 03:56:06< shadowm> Presumably alpha ranges [0, 255] so it's still never going to try to access value[255].
20161016 03:57:00< iceiceice> shadowm, i see
20161016 03:57:04< iceiceice> so this is just a bug that i introduced :D
20161016 03:57:16< iceiceice> i changed it to int div = table[alpha];
20161016 03:58:28< shadowm> There are n types of bugs: something something something, and off-by-one bugs.
20161016 03:58:34< shadowm> *n+1
20161016 03:59:52< shadowm> Ah yes, alpha in decode_pixel() necessarily had to be [0, 255] because it's a uchar cast to int.
20161016 04:02:35< celticminstrel> mattsc: When you add GUI2 files, could you be sure to include them in the unit_tests target as well?
20161016 04:07:04< tad_carlucci> shadowm, But you only listed n-1 types of bugs!
20161016 04:12:31< vultraz> iceiceice: ftr i dont understand why text rendering should be such arcane magic
20161016 04:12:38< iceiceice> vultraz, i am glad that i made these notes :D
20161016 04:12:39< iceiceice> https://wiki.wesnoth.org/User:Iceiceice/Cross-compiling
20161016 04:12:55< iceiceice> it is going to take me a while to compile boost though
20161016 04:13:08< vultraz> iceiceice: it's like, something every program has to do.. and they do it fine... so why is it such an issue for us/why is it so hard
20161016 04:13:29< iceiceice> well the text.cpp and font.cpp files were kind of hideously complicated
20161016 04:13:42< iceiceice> and it sounds like pango does a number of fairly annoying things
20161016 04:13:57< iceiceice> what with making the data premultiplied alpha and depend on endianness
20161016 04:13:58< vultraz> anura actually doesn't use pango
20161016 04:14:02< vultraz> just cairo directly
20161016 04:14:02< iceiceice> no they dont
20161016 04:14:13< iceiceice> i think they use freetype directly for fonts
20161016 04:14:19< iceiceice> there are a number of opengl tutorials about how to do that
20161016 04:14:31< vultraz> well, we don't have ogl now do we :P
20161016 04:14:37< iceiceice> *no they dont was meant to be agreeing with "doesn' tuse pango"
20161016 04:14:48< iceiceice> vultraz, yah but the principle is kind of the same
20161016 04:15:03< iceiceice> freetype basically just takes a character and produces like, an alpha map for it
20161016 04:15:17< iceiceice> and then you can color it / do whatever you want with it
20161016 04:15:29< shadowm> If font rendering wasn't hard then toolkits on Linux wouldn't do everything wrong and Windows wouldn't be internally inconsistent with subpixel hinting.
20161016 04:15:44< iceiceice> vultraz, it's only hard if you want it to actually look good
20161016 04:19:38-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161016 04:22:07< celticminstrel> Ugh, unit tests are broken in icompare. :/
20161016 04:22:15< celticminstrel> Well, whatever. I'll try to fix it later.
20161016 04:23:46< vultraz> celticminstrel: I forgot...why did you remove the listbox callback handling and instead handle everything in a click event?
20161016 04:23:49< vultraz> er
20161016 04:23:51< vultraz> in dropdown
20161016 04:24:33< irker502> wesnoth: Celtic Minstrel wesnoth:master c21a64863aaf / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Some targets cleanup https://github.com/wesnoth/wesnoth/commit/c21a64863aaf23f20b5ae0d746c89f976ebd17df
20161016 04:24:35< irker502> wesnoth: Celtic Minstrel wesnoth:master 0ce1bc68ca37 / src/gui/widgets/stacked_widget.cpp: Add deprecation check for stacked_widget change https://github.com/wesnoth/wesnoth/commit/0ce1bc68ca379312dd60ec76e9fae9b18731cbbc
20161016 04:24:37< irker502> wesnoth: Celtic Minstrel wesnoth:master f7856c11d490 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Build Lua as a separate static lib https://github.com/wesnoth/wesnoth/commit/f7856c11d490ee602b44de6575959f8b2678f57c
20161016 04:24:39< irker502> wesnoth: Celtic Minstrel wesnoth:master 9908335f3f69 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: XCode: Fix unit tests compilation https://github.com/wesnoth/wesnoth/commit/9908335f3f69d97d1041306a7faa0937b2090bc0
20161016 04:24:54< celticminstrel> Probably something about the menus.
20161016 04:24:56< vultraz> oh, perhaps so changing items wouldn't dismiss it
20161016 04:24:59< celticminstrel> But I don't remember exactly.
20161016 04:25:03< vultraz> except if on click
20161016 04:26:01< vultraz> there must be some bad interaction going on here to cause the crash
20161016 04:29:38< vultraz> hmm
20161016 04:29:44< vultraz> it seems selected can be -1..
20161016 04:30:40< irker502> wesnoth: Chris Beck wesnoth:master 2bc4cf230478 / src/font/text.cpp: fix an off-by-one error, reformat unpremultiply function https://github.com/wesnoth/wesnoth/commit/2bc4cf230478123de8b4398e24177bd68a105a41
20161016 04:31:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161016 04:31:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 04:33:21< vultraz> iceiceice: text rendering is fixed after that commit
20161016 04:33:34< iceiceice> wow
20161016 04:33:38< iceiceice> so it's just a some UB thing
20161016 04:33:58< iceiceice> well let's see if anyone else reports problems
20161016 04:34:06< iceiceice> but if not that's pretty cool
20161016 04:34:22< vultraz> tad_carlucci, celticminstrel ^
20161016 04:34:46-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161016 04:36:03< iceiceice> vultraz, we dont' use boost::random anymore in master, right?
20161016 04:36:10< vultraz> don't think so
20161016 04:36:18-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 04:36:19< iceiceice> ok, i'm removing that check from scons then
20161016 04:37:00< vultraz> ah wait, we do
20161016 04:37:02< vultraz> :/
20161016 04:37:34< vultraz> boost::random::mt19937
20161016 04:37:37< vultraz> is used
20161016 04:38:00< celticminstrel> Would it hurt to switch to std::mt19937?
20161016 04:38:07< vultraz> no idea
20161016 04:38:35< vultraz> there's also a use of boost::random_device guarded by a SEED_RNG_USE_BOOST_RANDOM_DEVICE define
20161016 04:40:00< iceiceice> celticminstrel, boost::mt19937 and std::mt19937 should be the same
20161016 04:40:16< vultraz> well then feel free to change the usecases
20161016 04:40:28< iceiceice> it might be a better idea to use boost::random_device
20161016 04:40:30< iceiceice> i guess i dont know
20161016 04:40:45< celticminstrel> Isn't there also a std::random_device? I vaguely seem to recall someone using that in master recently.
20161016 04:40:58< iceiceice> yah but std::random_device is sometimes quite badly behaved
20161016 04:41:05< celticminstrel> BTW, I think random_device is overkill for game randomness.
20161016 04:41:14< iceiceice> yah i think i agree
20161016 04:41:20< tad_carlucci> Confirming color text appears correct on Linux.
20161016 04:41:23< vultraz> i think that's why it's behind a guard
20161016 04:41:24< iceiceice> mt19937 is important but random_device probly not
20161016 04:41:28< celticminstrel> You want to use random_device for encryption, but for games it's not really needed. Games don't need entropy.
20161016 04:41:40< vultraz> tad_carlucci: good, good
20161016 04:41:42< vultraz> :D
20161016 04:41:43< celticminstrel> They just need data that looks more or less random.
20161016 04:41:52< vultraz> I must say it was fixed much faster than I expected
20161016 04:42:51< tad_carlucci> 20161015 23:41:52 error display: could not open image 'misc/status.png'
20161016 04:42:51< tad_carlucci> 20161015 23:42:17 error scripting/lua: lua/wml/random_placement.lua:17: variable 'loadstring' must be assigned before being used
20161016 04:42:51< tad_carlucci> stack traceback:
20161016 04:42:51< tad_carlucci> 	[C]: in function '.error'
20161016 04:42:51< tad_carlucci> 	lua/ilua.lua:131: in metamethod '__index'
20161016 04:42:53< tad_carlucci> 	lua/wml/random_placement.lua:17: in local 'cmd'
20161016 04:42:55< tad_carlucci> 	lua/wml-utils.lua:137: in field 'handle_event_commands'
20161016 04:42:57< tad_carlucci> 	lua/wml-flow.lua:6: in function <lua/wml-flow.lua:5>
20161016 04:43:01< iceiceice> vultraz, whats the line that wesbot used to say
20161016 04:43:07< iceiceice> "sometimes we are fast" or something
20161016 04:44:41< vultraz> dunno :P
20161016 04:44:41< tad_carlucci> I entered the MP random game as both players and got that message.
20161016 04:44:41< vultraz> but thanks for coming and fixing it
20161016 04:44:41< tad_carlucci> iceiceice, Yes, thank you.
20161016 04:46:32< tad_carlucci> The status.png message I've seen before.
20161016 04:46:56< iceiceice> np :D
20161016 04:46:59< iceiceice> i go to sleep again soon
20161016 04:47:14< tad_carlucci> loadstring .. I'm looking into. I'm running my PR to Upgrade Lua and might be missing a module.
20161016 04:47:14< vultraz> ok, I've discovered the issue with the crash
20161016 04:47:37< iceiceice> tad_carlucci, i can't remember if we filter out loadstring?
20161016 04:47:42< iceiceice> i thought it is a security hole of some kind
20161016 04:47:49< iceiceice> because it also loads raw bytecode or soemthing
20161016 04:47:58< iceiceice> dont rmemeber
20161016 04:48:20< vultraz> ok, so it's this
20161016 04:49:07< vultraz> under certain circumstances, mostly if you click and move your mouse away too fast, the selected index returns -1
20161016 04:49:13< vultraz> im not sure why that happens
20161016 04:50:09< tad_carlucci> Getting the mouse position too late?  Need to be sure to record it at the click event.
20161016 04:50:18< vultraz> but we've been using connect_click_handler for events regarding the widget
20161016 04:50:24< vultraz> that calls connect_signal_mouse_left_click
20161016 04:50:40< vultraz> so even though selected is -1, those events fire
20161016 04:50:44< vultraz> and if you use get_value
20161016 04:50:46< vultraz> you get -1
20161016 04:50:55< tad_carlucci> HttT uses random_placement and does not get the error. So what's up with random MP map getting it?
20161016 04:50:57< tad_carlucci> hmm
20161016 04:51:09< vultraz> and then if you try to call something with that index you get a crash
20161016 04:51:27< vultraz> now, there's also a set_callback_state_change member
20161016 04:51:45< tad_carlucci> Ah, number of items is string in MP random and integer/number in HttT.
20161016 04:51:53< vultraz> that sets a member that's manually fired..
20161016 04:52:11< vultraz> I can guard that behind a >= 0 check
20161016 04:52:20< vultraz> so I wonder if instead of connect_click_handler we should be using set_callback_state_change
20161016 04:53:55< vultraz> yes, that seems to be the solution
20161016 04:54:30< vultraz> celticminstrel: any objections?
20161016 04:54:56< celticminstrel> Wouldn't that trigger when selecting items with the keyboard?
20161016 04:55:08< celticminstrel> I think the point is that selecting with the keyboard should require Enter to select.
20161016 04:55:19< celticminstrel> But clicking on an item should also work.
20161016 04:55:39< vultraz> this is in the menu_item handler
20161016 04:55:42< vultraz> not drop down 
20161016 04:55:48< vultraz> so no behavior change
20161016 04:57:35< celticminstrel> Huh? You've lost me now...
20161016 04:59:12< vultraz> celticminstrel: essentially, i want to change usecases of menu buttons to register a handler that's called here https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/menu_button.cpp#L153
20161016 04:59:36< vultraz> celticminstrel: instead of being registered and handled by https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/menu_button.hpp#L52
20161016 04:59:44< vultraz> celticminstrel: because the latter has no validation check
20161016 05:00:07< vultraz> celticminstrel: i could, of course, use a lambda wrapper to add such a thing
20161016 05:00:11< vultraz> celticminstrel: which would you prefer?
20161016 05:00:31< vultraz> lambda wrapper or changing all uses of menu_button.connect_click_handler to set_callback_state_change?
20161016 05:06:54< vultraz> i await your verdict 
20161016 05:07:23< tad_carlucci> celticminstrel, vultraz Desion point: Should I enable the compatability modules? The issue I just hit was due to lua 'loadstring' being deprecated in 5.2; use load instead; two occurances in master.
20161016 05:08:04< celticminstrel> I'd say enable compatibility for Lua code, yes.
20161016 05:08:37< tad_carlucci> That is a 'for now' option. It's a safe bet if Lua ever goes to 6.0 it won't be an option any longer.
20161016 05:08:57< celticminstrel> Ideally it'd give a warning if you use a deprecated function.
20161016 05:09:31< tad_carlucci> It did. I posted what you see on screen a little while ago :O
20161016 05:09:44-!- Bonobo [~Bonobo@2001:44b8:254:3200:b8da:6dd0:abc0:d027] has quit [Read error: Connection reset by peer]
20161016 05:10:12< celticminstrel> Sorry, I wasn't really paying attention.
20161016 05:10:24< celticminstrel> As long as it gives a warning, it won't matter if it's eventually removed.
20161016 05:10:32< celticminstrel> We should update the uses in master though.
20161016 05:10:40< tad_carlucci> The message about loadstring.
20161016 05:10:49< tad_carlucci> Just off the top of my scrollback now
20161016 05:10:50< celticminstrel> vultraz: I'm still lost as to what you're asking.
20161016 05:11:09< celticminstrel> tad_carlucci: That's an error, not a warning.
20161016 05:11:32< celticminstrel> What I'd like is eg a loadstring function that outputs a warning (using wesnoth.message) and then forwards to load.
20161016 05:11:47< celticminstrel> (Possibly only warning if debug mode enabled.)
20161016 05:12:05< tad_carlucci> celticminstrel, I was thinking it might be wise for me to go through 5.1, 5.2 and 5.3 release notes from Lua and upgrade all our deprecated uses. But that does not help UMC.
20161016 05:12:55-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 05:12:56< travis-ci> cbeck88/wesnoth#192 (master - 2bc4cf2 : Chris Beck): The build has errored.
20161016 05:12:56< travis-ci> Build details : https://travis-ci.org/cbeck88/wesnoth/builds/167992482
20161016 05:12:56-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 05:13:11< celticminstrel> Yes, it's for UMC that compatibility is a good idea.
20161016 05:13:21< celticminstrel> If possible, with a visible warning if they're using a deprecated function.
20161016 05:13:36< tad_carlucci> The problem with that is the Lua depends upon the deprecated function to work. In the MP, the game ran .. just no units placed because the Lua crashed. Had it not crashed, it would have used 0 for the nubmer of units, which is nearly as bad.
20161016 05:14:19< celticminstrel> What?
20161016 05:14:21< tad_carlucci> If/when we go to Lua 6.0 it means all UMC using deprecated functions will cease to work.
20161016 05:14:48< irker502> wesnoth: Chris Beck wesnoth:master 144179f694ee / src/font/text.cpp: remove an obsolete code comment, rename a variable https://github.com/wesnoth/wesnoth/commit/144179f694ee26987962d3a1eeac540ddfb7eb2f
20161016 05:15:08< tad_carlucci> lua random_placement used loadstring to convert a string to a number, it would either have errored due to the lack of a return value, or it would have used 0 and not placed any units.
20161016 05:15:16-!- celmin [461b1fb9@gateway/web/freenode/ip.70.27.31.185] has joined #wesnoth-dev
20161016 05:15:43< celmin> ...why is it using loadstring to convert a string to a number?
20161016 05:16:17< tad_carlucci> So, I'll enable compatability modes, and try to locate all mainline/ai use of depreceated functions.
20161016 05:16:30< celmin> AI counts as mainline too. :P
20161016 05:16:36< celmin> Is there a list of deprecated functions?
20161016 05:16:53< tad_carlucci> celmin, Frankly, no idea. If this were a PHP web site I'd be screaming about SQL injection
20161016 05:17:05< tad_carlucci> celmin, yes, lua.org lists them.
20161016 05:17:24< tad_carlucci> celmin, So it's just busywork. I can handle that.
20161016 05:17:55< celmin> Are there a lot?
20161016 05:18:26< tad_carlucci> celmin, not so many I can't get through them in a few hours.
20161016 05:19:41< tad_carlucci> The two uses of loadstring, however, bother me. One is a pure injection. The other takes a bit of crafting but I could do serious damange to the engine using pure WML and carefully crafted strings.
20161016 05:20:01< celmin> I assume one of them is the [lua] ActionWML.
20161016 05:20:53< tad_carlucci> ai/micros/cas/ca_fast_atttack_utils and random_placement WML tag
20161016 05:21:17< celmin> Huh? I thought loadstring was used in the [lua] tag too.
20161016 05:21:45< tad_carlucci> That's luaL_loadstring .. still supported.
20161016 05:22:01< celmin> No, I mean in data/lua/wml-tags.lua
20161016 05:22:25< tad_carlucci> Only hit two uses.
20161016 05:23:04< tad_carlucci> wml-tags.lua uses load() .. so it's been updated already.
20161016 05:23:12< celmin> Ah.
20161016 05:23:21< celmin> Was it deprecated before 5.2 then?
20161016 05:23:44< tad_carlucci> 5.2 was when it was removed (mnoved to compat mode)
20161016 05:24:19< tad_carlucci> Sorta silly to have it. It's just a call to load() in 5.1/5.2 with defaults for the other parameters.
20161016 05:25:42< celmin> I don't know when the upgrade to 5.2 was done.
20161016 05:25:44 * celmin poke vultraz 
20161016 05:27:07< tad_carlucci> luaL_loadstring is a call to luaL_loadbuffer which is a call to lua_load ... so don't be surprised it the C functions go away .. they don't do much more than count bytes and reformat parameters into a struct.
20161016 05:28:48< tad_carlucci> So, (1) I need to update the PR to enable compatability, which includes putting the bit32 lilbrary back in, and (2) spend some time hunting down mainline use of deprecated Lua (API is already clean).
20161016 05:29:44-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161016 05:29:57< celmin> Assuming Wesnoth 1.12 already uses Lua 5.2, I don't think it's important to support deprecated things from versions older than 5.2
20161016 05:31:58< tad_carlucci> 1.12 has compatability on, so you'll have to go back to when Lua was upgraded to 5.0
20161016 05:32:24< vultraz> celmin: do you want me to add a lambda wrapper around the signal in menu_button::connect_click_handler or just change all calls of that to set_callback_state_change
20161016 05:32:52< celmin> vultraz: Why do you need to do either?
20161016 05:33:07< tad_carlucci> To avoid missing mouse events
20161016 05:33:16< celmin> Huh?
20161016 05:33:24< vultraz> celmin: so prevent the callback from being called when get_value would return -1
20161016 05:33:28< tad_carlucci> The crash he's working on
20161016 05:33:51< vultraz> though...
20161016 05:33:53< vultraz> actually..
20161016 05:33:54< vultraz> hmmm
20161016 05:33:58< tad_carlucci> It's a race!
20161016 05:34:03< vultraz> I just realized something
20161016 05:34:06< vultraz> either might not be necessary
20161016 05:34:09-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Ping timeout: 252 seconds]
20161016 05:34:12< vultraz> hang on..
20161016 05:34:14< celmin> get_value shouldn't return -1 in a menu_button, should it?
20161016 05:34:26< celmin> If it's returning -1 then maybe you need to make it not do so.
20161016 05:34:39< vultraz> yeah
20161016 05:34:44< vultraz> i think i just realized i did that
20161016 05:34:50< vultraz> 1 sec
20161016 05:35:34< vultraz> ahhh
20161016 05:35:36< vultraz> yes
20161016 05:35:38< vultraz> ok, nevermind
20161016 05:36:07< vultraz> i fixed it by using an interim value and not setting the member value if the dropdown selected row was invalid
20161016 05:36:45-!- Ben24626 [d2564fc3@gateway/web/freenode/ip.210.86.79.195] has joined #wesnoth-dev
20161016 05:39:05< vultraz> tad_carlucci: id say we do need to enable compatibility mode, but all mainline lua should be updated to 5.3
20161016 05:39:07< celmin> I still don't quite get it, but if it works, then whatever.
20161016 05:39:45< irker502> wesnoth: Charles Dang wesnoth:master 7e84adf348d5 / src/gui/widgets/menu_button.cpp: Menu Button: added validation check for case where dropdown returned -1 as its s https://github.com/wesnoth/wesnoth/commit/7e84adf348d564e2154d6af9400f4a4cdb1adf2a
20161016 05:39:48< irker502> wesnoth: Charles Dang wesnoth:master a5350ea9f9c0 / src/gui/widgets/ (menu_button.cpp menu_button.hpp): Menu Button: cleaned up a duplicate member https://github.com/wesnoth/wesnoth/commit/a5350ea9f9c062327e05ffb19fdb41ae580563b0
20161016 05:39:49< vultraz> crash fixed!
20161016 05:40:16< tad_carlucci> That's my plan. Once I'm done the PR should be good to go because it won't break any Lua and our C++ is already fixed.
20161016 05:40:38< celmin> What was the helper.lua PR's number again
20161016 05:40:47< tad_carlucci> 819?
20161016 05:44:47< vultraz> I think i just fixed two bugs with that fix :D
20161016 05:45:12< irker502> wesnoth: Celtic Minstrel wesnoth:master db5cf990dedc / src/ (font/constants.hpp tooltips.cpp): Fix use of constexpr https://github.com/wesnoth/wesnoth/commit/db5cf990dedc058ec2eee5218c1283ddaaeefbde
20161016 05:45:17< celmin> MSVC project also needs update.
20161016 05:45:21< celmin> Might do it, not sure.
20161016 05:46:15< tad_carlucci> celmin, Can you go to PR 822, "Remove deprecated library" comimt and add a Code Review, Request Changes "Enable compatiblity and restore this library" .. to prevent 822 from merging until it's fixed?
20161016 05:46:41< celmin> I don't think the code reviews actually prevent merging, but sure, I can do that.
20161016 05:47:11< tad_carlucci> Oh. drat. I thought it did. It should :P
20161016 05:47:35< vultraz> tad_carlucci: could you update cmake and scons to require SDL 2.0.4 everywhere?
20161016 05:47:35< tad_carlucci> I can't do it because it's my PR
20161016 05:47:52< vultraz> I've never used either of those and don't want to screw it up
20161016 05:48:27< vultraz> ah
20161016 05:48:33< vultraz> someone else?
20161016 05:48:40< tad_carlucci> vultraz, Dunno. I can look at it. Should not be too hard. I'm still new at it .. my probability of scrwup is about equal to yours
20161016 05:49:40< tad_carlucci> IIRC loonycyborg is the man for CMake. I'll take a look now and do a quick PR if I can see it quickly.
20161016 05:51:34< vultraz> I thought he was scons?
20161016 05:53:57< tad_carlucci> NP. SCons was easy. Was 2.0.4 or 2.0.2 .. simply removed the if and it's done.
20161016 05:54:50< tad_carlucci> Same for CMake. Expect PR momentarily.
20161016 05:55:04< celmin> tad_carlucci: You can set the repo to prevent merging when changes are requested, but I don't think the Wesnoth repo is set up that way.
20161016 05:55:39< celmin> I don't think loonycyborg uses CMake.
20161016 05:55:57< tad_carlucci> I'm on it.
20161016 05:55:59< celmin> People who've updated CMake in the past include shadow m and Ivanovic IIRC.
20161016 05:56:28< tad_carlucci> And one of you should be able to set that option. It's probably a wise choice. Might want to have the board members decide, though.
20161016 05:56:54< vultraz> tad_carlucci: don't get board members confused with project admins
20161016 05:57:10< vultraz> tad_carlucci: board = wesnoth inc, the company, not responsible for project management
20161016 05:57:26< tad_carlucci> OK. Well, admins, then.
20161016 05:57:32< celmin> IIRC they're only responsible for what art to commission.
20161016 05:57:33< vultraz> tad_carlucci: I simply happen to server as both project admin and board member
20161016 05:57:46< vultraz> celmin: more than that
20161016 05:57:58 * celmin kinda hopes someone else updates the MSVC project. >_>
20161016 05:58:09< vultraz> i thought wedge009 just did thatearlier
20161016 05:58:18< celmin> ...actually I could just test this on Mac instead.
20161016 05:58:27< celmin> Huh? It seems to not be updated for the font stuff...
20161016 05:58:29< tad_carlucci> vultraz, PR 828 is up
20161016 05:58:44< tad_carlucci> coderead it and you'll see it's just right.
20161016 05:59:03< irker502> wesnoth: Gregory A Lundberg wesnoth:master 907eb5bf7e82 / CMakeLists.txt SConstruct: Require SDL2 2.0.4 on all target platforms. https://github.com/wesnoth/wesnoth/commit/907eb5bf7e82079af893a2907da657c2a9f68f27
20161016 05:59:04< irker502> wesnoth: Charles Dang wesnoth:master ae1839760894 / CMakeLists.txt SConstruct: Merge pull request #828 from GregoryLundberg/GL_Require_SDL-2.0.4 https://github.com/wesnoth/wesnoth/commit/ae183976089426bfa38b5ed8995eaa3281d490a4
20161016 05:59:12< vultraz> that's mostly what i thought was needed, i just wasn't sure
20161016 06:03:12-!- JyrkiVesterinen [~JyrkiVest@87-100-241-151.bb.dnainternet.fi] has joined #wesnoth-dev
20161016 06:25:27< shadowm> Update INSTALL, please.
20161016 06:26:08< vultraz> already done
20161016 06:26:08< tad_carlucci> vultraz, ^
20161016 06:41:47< irker502> wesnoth: Charles Dang wesnoth:master afa4bf8ea94f / src/ (3 files in 2 dirs): MP Create Game: fixed settings polluting loaded of saved games https://github.com/wesnoth/wesnoth/commit/afa4bf8ea94f2cc2d3c7cafa27b3b76ec9299b00
20161016 06:41:59< vultraz> gah
20161016 06:42:01< vultraz> typo
20161016 06:42:12< vultraz> s/of// :(\
20161016 06:43:02< vultraz> ok, what else..
20161016 06:48:08< JyrkiVesterinen> gfgtdf: You membership in a GitHub organization isn't public by default.
20161016 06:48:31< JyrkiVesterinen> Which means that only you and other members (such as me and vultraz) can see it, and only when we're logged in.
20161016 06:48:49< JyrkiVesterinen> If you want your membership to be publicly visible, you can change it here: https://github.com/orgs/wesnoth/people
20161016 06:48:56< JyrkiVesterinen> celticminstrel: ^
20161016 06:49:38< celmin> Shrug!
20161016 06:51:53< irker502> wesnoth: Charles Dang wesnoth:master fc320e463faa / src/ (game_initialization/multiplayer.cpp gui/dialogs/multiplayer/mp_create_game.cpp): MP Create Game: moved entry point selection to dialog postshow https://github.com/wesnoth/wesnoth/commit/fc320e463faa4e88ebebec218b2e7d15d982b857
20161016 06:54:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161016 06:56:31-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 06:56:32< travis-ci> wesnoth/wesnoth#11570 (master - ae18397 : Charles Dang): The build was broken.
20161016 06:56:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/167998334
20161016 06:56:32-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 06:56:55< vultraz> ooo
20161016 06:57:04< vultraz> why dis
20161016 06:57:45< vultraz> well that's odd
20161016 06:58:08< vultraz> it can't find sdl 2.0.4 :/
20161016 06:58:44< vultraz> i guess that's not in whatever repo travis is looking at :(
20161016 07:00:38< tad_carlucci> You can find the Travis configuration. Don't know who has the keys to change Travis. It should be solvable by using a better repo.
20161016 07:01:33< tad_carlucci> It says 'log in with your github account' so YOU might be able to update the Travis script if you can find a repo with 2.0.4
20161016 07:02:26-!- travis-ci [~travis-ci@ec2-54-160-188-238.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 07:02:27< travis-ci> wesnoth/wesnoth#11571 (master - afa4bf8 : Charles Dang): The build was broken.
20161016 07:02:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168001685
20161016 07:02:28-!- travis-ci [~travis-ci@ec2-54-160-188-238.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 07:02:34< vultraz> I think we just edit the travis.yml file in the repo?
20161016 07:02:41< vultraz> or maybe that's just settings..
20161016 07:03:25< vultraz> - if [ "$CXXSTD" == "1y" ]; then sudo add-apt-repository ppa:ubuntu-toolchain-r/test -y; fi
20161016 07:03:27< vultraz> hm
20161016 07:04:47-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 07:04:48< travis-ci> shikadilord/wesnoth#1 (travis-ccache - 1aff681 : Ignacio R. Morelle): The build failed.
20161016 07:04:48< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/168000612
20161016 07:04:48-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 07:05:37< tad_carlucci> There you go. You need a better ppa .. can you find it?
20161016 07:06:06< vultraz> I don't even know what a ppa is!
20161016 07:06:35-!- travis-ci [~travis-ci@ec2-54-159-152-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 07:06:36< travis-ci> wesnoth/wesnoth#11572 (master - fc320e4 : Charles Dang): The build was broken.
20161016 07:06:36< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168002479
20161016 07:06:36-!- travis-ci [~travis-ci@ec2-54-159-152-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 07:06:38< tad_carlucci> It's Ubuntu's binary distribution system. Like an RPM
20161016 07:06:42< vultraz> also isn't 1y c++17 or something
20161016 07:07:07< tad_carlucci> 1y was the pre -11 spec for C++
20161016 07:07:43< tad_carlucci> You will note we have a build for it but it is expected to fail because we don't support it any more.
20161016 07:09:11< tad_carlucci> toolchaing-r is the compilers.
20161016 07:09:28< tad_carlucci> You want a different line .. probably another ppa
20161016 07:09:56< celticminstrel> vultraz: You can merge 819.
20161016 07:10:17< irker502> wesnoth: Celtic Minstrel wesnoth:master 79647ff9d9d9 / data/lua/helper.lua: helper.lua: set __metatable field to guard against external access to metatables https://github.com/wesnoth/wesnoth/commit/79647ff9d9d9afa6be62fc042b4d04c8c5ec5331
20161016 07:10:19< irker502> wesnoth: Charles Dang wesnoth:master a8136a2b4287 / data/lua/helper.lua: Merge pull request #819 from wesnoth/lua-helper-safe-metatables https://github.com/wesnoth/wesnoth/commit/a8136a2b4287932903a5758302d5bfd62b30c7c9
20161016 07:11:02< tad_carlucci> celticminstrel, I have the C++ side of Upgrade Lua PR ready. I'm running through all the language changes. So far, not finding anything. It's possible I already found the only problems.
20161016 07:11:46< tad_carlucci> I'm going to look at Travis and find where we get the SDL2 from see if I can help vultraz fix it ...
20161016 07:11:57< vultraz> thanks
20161016 07:12:15< shadowm> From trusty.
20161016 07:12:45-!- Bonobo [~Bonobo@2001:44b8:254:3200:9d8e:1c6b:44d5:6fac] has joined #wesnoth-dev
20161016 07:12:54< shadowm> http://packages.ubuntu.com/trusty/libsdl2-2.0-0 -- So yes, you will need a PPA.
20161016 07:13:18< shadowm> And yes, Wesnoth will no longer be buildable on the previous Ubuntu LTS.
20161016 07:14:02< shadowm> But it's development releases, so who cares, I guess.
20161016 07:15:49< tad_carlucci> shadowm, 'buildable' is the operative word there. 'runnable' is what we care about. If any of our developers have not upgraded, they can spend the 45 minutes getting current.
20161016 07:16:20-!- travis-ci [~travis-ci@ec2-54-159-152-110.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 07:16:21< travis-ci> wesnoth/wesnoth#11573 (master - a8136a2 : Charles Dang): The build is still failing.
20161016 07:16:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168003952
20161016 07:16:22-!- travis-ci [~travis-ci@ec2-54-159-152-110.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 07:16:43< shadowm> I did not understand any of what you just said.
20161016 07:17:08-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161016 07:17:26< tad_carlucci> Yakety is out so we just need the ppa.
20161016 07:18:17< tad_carlucci> The issue with SDL2 2.0.4 is for building. If someone who wants to build Wesnot isn't upgraded to yakety they should do so. The build should still run on trusty.
20161016 07:18:23< shadowm> Oh, I guess you thought I was talking about developers.
20161016 07:20:40< tad_carlucci> Actually, we could use a xenial ppa as well for sdl2 2.0.4
20161016 07:24:13-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 07:24:14< travis-ci> shikadilord/wesnoth#1 (travis-ccache - 1aff681 : Ignacio R. Morelle): The build failed.
20161016 07:24:14< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/168000612
20161016 07:24:14-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 07:24:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20161016 07:43:11-!- mjs-de [~mjs-de@x4db5106b.dyn.telefonica.de] has joined #wesnoth-dev
20161016 07:47:14< tad_carlucci> libsdl2 2.0.4+dfsg2-1ubuntu1
20161016 07:48:34-!- Ben24626 [d2564fc3@gateway/web/freenode/ip.210.86.79.195] has quit [Quit: Page closed]
20161016 07:55:57< tad_carlucci> vultraz, I don't see that Travis/CI has anything but Ubuntu 'trusty' I'm looking to see if we can install 2.0.4 on trusty. It will mean adding a apt-add repository then installing the package. But I'm not finding the ppa: we'll need to add. The libsdl2 named above is the Yakkety package name. It might do but we'll need the ppa: for it. Been a few years since I did Unbutu.
20161016 07:56:07-!- celmin [461b1fb9@gateway/web/freenode/ip.70.27.31.185] has quit [Quit: Page closed]
20161016 08:03:26< shadowm> Sigh.
20161016 08:03:39< tad_carlucci> yeah
20161016 08:04:38< irker502> wesnoth: Ignacio R. Morelle wesnoth:master 2b12dd8e427d / .travis.yml: travis: Enable ccache support https://github.com/wesnoth/wesnoth/commit/2b12dd8e427d5ea4b1b720086637c1134d4dea89
20161016 08:04:41< irker502> wesnoth: Ignacio R. Morelle wesnoth:master 07492073ccd8 / src/campaign_server/campaign_server.cpp: campaignd: Ignore old-style-cast warning caused by a system macro on GCC https://github.com/wesnoth/wesnoth/commit/07492073ccd8b24f22b92fac4d4906fb334d4a36
20161016 08:08:17< JyrkiVesterinen> shadowm: You suppress warnings much more sloppily than I. :P
20161016 08:08:18< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/07492073ccd8b24f22b92fac4d4906fb334d4a36/src/gui/widgets/listbox.cpp#L316-L322
20161016 08:08:28< tad_carlucci> Ah, well. It's late and I'm off. I know it's solvable but it may not be pretty. Might be best to revert to 2.0.2 for Linux.
20161016 08:09:04< vultraz> tad_carlucci: can't. < 2.0.4 causes rendering problems
20161016 08:09:05-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161016 08:09:17-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161016 08:09:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 08:10:37-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 08:10:38< travis-ci> wesnoth/wesnoth#11574 (master - 0749207 : Ignacio R. Morelle): The build is still failing.
20161016 08:10:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168008706
20161016 08:10:38-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 08:12:10< tad_carlucci> vultraz, Ok. End-run. Set an environment variable in the Travis build and test for it in SCons and CMake and allow 2.0.2 if it's there. Slimy but should work.
20161016 08:12:47< tad_carlucci> It's not like we care about rendering errors. Or does the 2.0.4 requirement make an API change?
20161016 08:13:02< vultraz> no
20161016 08:14:09-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 08:14:10< travis-ci> shikadilord/wesnoth#4 (travis-ccache - 7e229b8 : Ignacio R. Morelle): The build passed.
20161016 08:14:10< travis-ci> Build details : https://travis-ci.org/shikadilord/wesnoth/builds/168006772
20161016 08:14:10-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 08:17:43-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161016 08:25:18-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161016 08:28:47< shadowm> JyrkiVesterinen: No-one will build campaignd with anything other than GCC.
20161016 08:29:26< JyrkiVesterinen> Well, you're still suppressing -Wold-style-cast for the entire rest of the file.
20161016 08:29:44< JyrkiVesterinen> And the suppression isn't accompanied with a comment to explain why it's necessary.
20161016 08:29:51< shadowm> The alternative didn't work for me.
20161016 08:29:55< shadowm> For travis, anyway.
20161016 08:30:21< shadowm> Probably some odd interaction with ccache.
20161016 08:31:28< shadowm> vultraz, tad_carlucci: I'm looking into the CI build deps issue but no promises.
20161016 08:32:26< irker502> wesnoth: Ignacio R. Morelle wesnoth:master d2f02b553e00 / src/campaign_server/campaign_server.hpp: campaignd: Delete campaignd::server::operator= too https://github.com/wesnoth/wesnoth/commit/d2f02b553e00cef475a7d92e11786a3545ab7c79
20161016 08:32:35< tad_carlucci> shadowm, vultraz I have scons testing if it's Travis and only requiring 2.0.2 and am working on CMake.
20161016 08:32:52< shadowm> I'm going to try to actually install 2.0.4.
20161016 08:33:03< shadowm> Emphasis on try.
20161016 08:37:31< vultraz> well this is annoying
20161016 08:37:41< vultraz> getting errors about multiple definitions of some functions..
20161016 08:38:27-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 08:38:28< travis-ci> wesnoth/wesnoth#11575 (master - d2f02b5 : Ignacio R. Morelle): The build is still failing.
20161016 08:38:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168011028
20161016 08:38:28-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 08:38:52< vultraz> and im not sure why...
20161016 08:39:38< tad_carlucci> shadowm, vultraz PR 829 checks for travis and only requires SDL 2.0.2 if found. According to Travis/CI docs, it should get the build working. Quick-and-dirty but it should work, for now.
20161016 08:41:07< tad_carlucci> And, yes, I tested it. Just don't know if the Travis docs are correct that they export TRAVIS=true as it says they do.
20161016 08:42:52< shadowm> It sounds like you have a reason to believe otherwise?
20161016 08:43:47< tad_carlucci> No just saying I can't tell for sure.
20161016 08:44:42< tad_carlucci> You know how it goes. The one time you're flying blind, it bites you.
20161016 08:46:52< tad_carlucci> Oh. It's running .. let me check the logs.
20161016 08:48:17< tad_carlucci> Yes. If all goes well in about 45 minutes my PR should pass and we'll know. But it tested and accepted 2.0.2
20161016 08:48:43< irker502> wesnoth: Jyrki Vesterinen wesnoth:master 313aa3241dac / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/313aa3241dac4ac857558459f5f148de7e03bde5
20161016 08:48:45< irker502> wesnoth: Jyrki Vesterinen wesnoth:master 988096d450cc / src/font/ (constants.cpp constants.hpp): Fix build with Visual Studio 2013 https://github.com/wesnoth/wesnoth/commit/988096d450cc059170132f89004228b7d7c66008
20161016 08:49:46< shadowm> Okay, I give up. Just override it for Travis and it should be good.
20161016 08:51:05< tad_carlucci> Either watch my PR or merge it. It's compiling master + PR now. SCons and CMake both.
20161016 08:51:28< shadowm> I don't need to watch it if you said it's running.
20161016 08:51:59< shadowm> If it's past the config stage then obviously it's going to work. And in any case it's vultraz's responsibility and I'm basically dead right now.
20161016 08:52:49< tad_carlucci> Same here. This should get us up and running. Merge it or wait to be positive, but all 4 builds are running. I'm off for bed.
20161016 08:52:53-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161016 09:03:59< vultraz> gahh why do i keep getting duplicate definition errors
20161016 09:04:03< vultraz> include guard, check...
20161016 09:04:21< vultraz> and it's a header-only file, so no cpp includes...
20161016 09:08:20-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 09:08:21< travis-ci> wesnoth/wesnoth#11577 (master - 988096d : Jyrki Vesterinen): The build is still failing.
20161016 09:08:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168012563
20161016 09:08:21-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 09:22:08< irker502> wesnoth: Gregory A Lundberg wesnoth:master 34dcd0657fc3 / CMakeLists.txt SConstruct: Test for Travis and only require SDL 2.0.2 https://github.com/wesnoth/wesnoth/commit/34dcd0657fc3b5c4750e35872518b78b363ddea4
20161016 09:22:10< irker502> wesnoth: Ignacio R. Morelle wesnoth:master db400ed1cc00 / CMakeLists.txt SConstruct: Merge pull request #829 from GregoryLundberg/GL_travis https://github.com/wesnoth/wesnoth/commit/db400ed1cc000b5613c46e5f75a00f62a618610a
20161016 09:22:57< JyrkiVesterinen> 20161016 04:40:45< celticminstrel> Isn't there also a std::random_device? I vaguely seem to recall someone using that in master recently.
20161016 09:22:59< shadowm> Yes, the -O0 GCC build failed, again it's a weird interaction between the ccache option and -W[error=]old-style-cast.
20161016 09:23:34< JyrkiVesterinen> Celticminstrel is correct. I changed the default RNG to use std::random_device for seeding.
20161016 09:23:52< shadowm> Decided to merge it anyway so that you people won't waste time trying to figure out why the build was failing.
20161016 09:24:13< JyrkiVesterinen> Previously it used the ancient C time API for that. I consider using the time API for RNG seeding as outright misuse.
20161016 09:24:14< shadowm> I'll have to revisit my own issue at a later time.
20161016 09:24:40< irker502> wesnoth: Ignacio R. Morelle wesnoth:master f6d6f9545c8b / .travis.yml: Revert "travis: Enable ccache support" https://github.com/wesnoth/wesnoth/commit/f6d6f9545c8b732be5f779c2632d4f54281756ee
20161016 09:24:53< JyrkiVesterinen> The reason why I touched it in the first place, though, was that the code implicitly truncated time_t to unsigned int and MSVC warned about it.
20161016 09:25:46< JyrkiVesterinen> I think using std::random_device for *seeding* isn't overkill. It's only used once per run, so it doesn't matter if it's slow.
20161016 09:29:00-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 09:29:00< travis-ci> wesnoth/wesnoth#11578 (master - db400ed : Ignacio R. Morelle): The build is still failing.
20161016 09:29:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168016780
20161016 09:29:01-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 09:30:36-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161016 09:32:41-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 09:32:42< travis-ci> wesnoth/wesnoth#11579 (master - f6d6f95 : Ignacio R. Morelle): The build is still failing.
20161016 09:32:42< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168017082
20161016 09:32:42-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 09:32:58< shadowm> ............
20161016 09:33:32< shadowm> JyrkiVesterinen: I think this is yours. ^
20161016 09:34:39< shadowm> "A constexpr variable must satisfy the following requirements: [...] it must be immediately constructed or assigned a value."
20161016 09:35:08< JyrkiVesterinen> Ah, OK.
20161016 09:35:28< JyrkiVesterinen> I'll need to drop the constexpr qualifier from these variables.
20161016 09:35:47< JyrkiVesterinen> I'll fix it after lunch, a couple of hours from now.
20161016 09:52:59< vultraz> ... for some reason these functions get defined multiple times...?
20161016 09:59:16< vultraz> I see
20161016 09:59:28< vultraz> I guess one cannot put implementations in a header without a class?
20161016 09:59:59< JyrkiVesterinen> Indeed, you can't do that.
20161016 10:00:02< vultraz> Ah
20161016 10:00:12< vultraz> that's what I was doing :P
20161016 10:14:15-!- JyrkiVesterinen [~JyrkiVest@87-100-241-151.bb.dnainternet.fi] has quit [Quit: Going somewhere. I'll return in a couple of hours.]
20161016 10:26:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161016 10:54:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161016 11:08:06< irker502> wesnoth: Charles Dang wesnoth:master b5d6186ea200 / / (21 files in 8 dirs): Move some pango formatting-related functions to their own file https://github.com/wesnoth/wesnoth/commit/b5d6186ea200ff2f9f3f173dc733a68ddf568ced
20161016 11:08:09< irker502> wesnoth: Charles Dang wesnoth:master ebc8ddfb78a7 / src/ (26 files in 12 dirs): Move certain text constants into the constants file https://github.com/wesnoth/wesnoth/commit/ebc8ddfb78a777db9077d7ef1a9dfbb78507c909
20161016 11:14:56-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 11:14:57< travis-ci> wesnoth/wesnoth#11580 (master - ebc8ddf : Charles Dang): The build is still failing.
20161016 11:14:57< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168029210
20161016 11:14:57-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 11:40:07-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161016 11:54:24< irker502> wesnoth: Charles Dang wesnoth:master 30c1a852d37c / src/ (font/constants.hpp tooltips.cpp): Attempt to fix compilation https://github.com/wesnoth/wesnoth/commit/30c1a852d37c555c6b5551d03d792baf9e08040e
20161016 11:54:27< irker502> wesnoth: Charles Dang wesnoth:master b6ea5106ca70 / / (42 files in 13 dirs): Moved marked-up_text.*pp to font/ https://github.com/wesnoth/wesnoth/commit/b6ea5106ca70d846922f62fccde4b8004f906239
20161016 12:00:50-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 12:00:51< travis-ci> wesnoth/wesnoth#11581 (master - b6ea510 : Charles Dang): The build is still failing.
20161016 12:00:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168034736
20161016 12:00:52-!- travis-ci [~travis-ci@ec2-54-92-195-216.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 12:01:06< matthiakrgr> ._. I'm getting a linker error
20161016 12:01:29-!- JyrkiVesterinen [~jyrki@87-92-25-47.bb.dnainternet.fi] has joined #wesnoth-dev
20161016 12:01:30< vultraz> master's a little messy r/n
20161016 12:01:34< matthiakrgr> yeh
20161016 12:01:37< vultraz> JyrkiVesterinen's supposed to do something
20161016 12:01:49< vultraz> dunno if i just did the wrong thing in 30c1a852d37c
20161016 12:01:52< vultraz> but that did make it build for me
20161016 12:01:55< vultraz> not travis, it seems
20161016 12:04:13< JyrkiVesterinen> vultraz: 30c1a852d37c is a step in the right direction, but not enough to fix it.
20161016 12:04:30< JyrkiVesterinen> For one, you didn't update the definitions in constants.cpp.
20161016 12:04:38< vultraz> oh, blah
20161016 12:04:52< JyrkiVesterinen> And a bigger problem is that these constants are used in constexpr functions.
20161016 12:05:11< JyrkiVesterinen> Those functions will need the constexpr specifier dropped as well.
20161016 12:05:43< JyrkiVesterinen> I was unable to test any of that with MSVC2013 because it isn't constexpr aware.
20161016 12:06:08< JyrkiVesterinen> Which is why I decided to wait until after lunch and boot to GNU/Linux to fix the issue.
20161016 12:06:24< vultraz> ah
20161016 12:06:26< vultraz> please do
20161016 12:06:33< JyrkiVesterinen> (Now when I can verify that Wesnoth compiles with GCC that is aware of constexpr.)
20161016 12:06:38< vultraz> I'm cleaning up serialization/string_utils
20161016 12:06:51< vultraz> a lot of these could be replaced with boost string utils
20161016 12:07:09< vultraz> instead of our own implementations 
20161016 12:09:59< vultraz> especially basic stuff like replace and strip
20161016 12:11:27< JyrkiVesterinen> vultraz: You broke the build.
20161016 12:11:28< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/commit/b6ea5106ca70d846922f62fccde4b8004f906239
20161016 12:11:38< JyrkiVesterinen> Apparently you didn't commit actually moving the files.
20161016 12:11:56< JyrkiVesterinen> CMake Error at src/CMakeLists.txt:1072 (add_library):
20161016 12:11:57< JyrkiVesterinen>   Cannot find source file:
20161016 12:11:59< JyrkiVesterinen>     font/marked-up_text.cpp
20161016 12:12:15< vultraz> DEEERPPPP :|
20161016 12:13:06< irker502> wesnoth: Charles Dang wesnoth:master 047bae7b6600 / src/ (4 files in 2 dirs): Forgot to actually commit the moved files... (fixup b6ea5106ca70) https://github.com/wesnoth/wesnoth/commit/047bae7b66003740890a3ec9dad531a0f00be17b
20161016 12:13:12< matthiakrgr> lol
20161016 12:13:52< JyrkiVesterinen> Thanks. :) I was able to start the build now.
20161016 12:14:41< JyrkiVesterinen> (Just the first build to verify that GCC build is indeed broken. My way of fixing bugs: 1) verify that you can reproduce, 2) fix and 3) verify that you can no longer reproduce.)
20161016 12:19:20< vultraz> geez, boost has a *lot* of string utils
20161016 12:22:50< vultraz> ok, utils::replace, strip, and strip_end all replaced with boost stuff
20161016 12:26:34< vultraz> wish this file didn't trigger such a huge rebuild :(
20161016 12:26:42< vultraz> #justnonccacheuserthings
20161016 12:30:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161016 12:36:44-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 12:36:45< travis-ci> wesnoth/wesnoth#11582 (master - 047bae7 : Charles Dang): The build is still failing.
20161016 12:36:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168037223
20161016 12:36:45-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 12:52:28-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20161016 13:01:30< irker502> wesnoth: Charles Dang wesnoth:master 8e3c55409476 / src/ (9 files in 6 dirs): Replace utils::replace, strip, and strip_end with their Boost equivalents https://github.com/wesnoth/wesnoth/commit/8e3c5540947680a70a440abe3d0da1cc38c193d9
20161016 13:03:53-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161016 13:10:58< vultraz> hmm
20161016 13:11:03< vultraz> how does one use boost::split..
20161016 13:11:05-!- Appleman1234 [~Appleman1@KD106154010091.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20161016 13:13:02< irker502> wesnoth: gfgtdf wesnoth:master 3b04fecb3c9f / src/gui/dialogs/multiplayer/mp_create_game.cpp: attempt to fix crash when starting a mp game  https://github.com/wesnoth/wesnoth/commit/3b04fecb3c9f73772d6f88c0c87d081c3d44ec0b
20161016 13:18:13-!- gfgtdf [~chatzilla@x4e3694ff.dyn.telefonica.de] has joined #wesnoth-dev
20161016 13:19:00< gfgtdf> vultraz: you know what currently blocks q 1.13.6 release ?
20161016 13:19:30< vultraz> gfgtdf: https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_join_game.cpp#L207
20161016 13:19:41< vultraz> dialog doesn't appear, wesnoth just stops accepting input
20161016 13:21:35< gfgtdf> vultraz: do other dialogs appearif you try to show thme in post_build ?
20161016 13:21:50< vultraz> not sure i think this is the only case
20161016 13:22:00< vultraz> but i tried moving that to pre_show and it didn't work either
20161016 13:23:02< JyrkiVesterinen> Hmm, I need to split font::constants to two classes.
20161016 13:23:25< JyrkiVesterinen> It's used by string_utils in wesnothlib. That pert needs to be in wesnothlib as well.
20161016 13:23:45< vultraz> heh, i made utils::split use boost:;split and wesnoth crashes at start
20161016 13:23:47< vultraz> nice!
20161016 13:24:08< JyrkiVesterinen> However, it also uses the inverse() function in utils/sdl_utils.hpp. Sdl_utils has way too many dependencies to live in wesnothlib.
20161016 13:24:45< JyrkiVesterinen> So, I'm going to split it to one part (in wesnothlib) that string_utils can use, and another part (in wesnoth) that contains the rest.
20161016 13:27:21-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 13:27:22< travis-ci> wesnoth/wesnoth#11583 (master - 8e3c554 : Charles Dang): The build is still failing.
20161016 13:27:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168042363
20161016 13:27:22-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 13:29:18< vultraz> hmmm
20161016 13:29:23< vultraz> maybe i don't need boost::split
20161016 13:30:16-!- Appleman1234 [~Appleman1@KD106154016079.au-net.ne.jp] has joined #wesnoth-dev
20161016 13:30:19< gfgtdf> vultraz: why do you want to change utils::split ?
20161016 13:30:53< vultraz> gfgtdf: i'm going through sterilization/string_utils.*pp to see if anything can be simplified/replaced. 
20161016 13:31:30< vultraz> i just removed a few trivial members and replaced them with boost ones
20161016 13:33:34< vultraz> i was thinking of making utils::split use boost::split
20161016 13:34:10< gfgtdf> vultraz: but e use ::strip un purpose becasue it usees portable isspace, unlirek boost which by default uses locales
20161016 13:35:36< vultraz> hm?
20161016 13:36:56< gfgtdf> vultraz: utils::trip ues our portable_isspace function to test wheterh it is a space chacter while boost::trim uses some locale dependent stuff
20161016 13:38:18< vultraz> is that bad?
20161016 13:38:19-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 13:38:21< travis-ci> wesnoth/wesnoth#11584 (master - 3b04fec : gfgtdf): The build is still failing.
20161016 13:38:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168043574
20161016 13:38:21-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 13:39:14< gfgtdf> vultraz: yes becasue it coudl means that bost::trin behaves differntly on diffent OSor wth different locales
20161016 13:43:54< vultraz> gfgtdf: how does this look for a split simplification> http://pastebin.com/rDGh56Ph
20161016 13:43:55< vultraz> ?*
20161016 13:44:24< vultraz> gfgtdf: also do you think i should revert the trim stuff?
20161016 13:45:10< mattsc> zookeeper: your comment about dealing with petrified units yesterday left me quite depressed later in the day.  ;)
20161016 13:45:31< zookeeper> uh... well, sorry? :p
20161016 13:45:45< mattsc> Yeah, I blame you for getting me thinking!
20161016 13:46:00< zookeeper> oh no
20161016 13:46:09< zookeeper> what did you think about then?
20161016 13:46:32< mattsc> Anyways, the point is that there really is no way of doing what you suggested generally so that it works consitently and intuitively for the MAIs in general.
20161016 13:47:06< zookeeper> right
20161016 13:47:07< mattsc> As in, I want the default behavior to be the same as for the default AI: “ignore” hidden and petrified units.
20161016 13:47:30< zookeeper> well, it's not a big deal? petrification is almost never used anyway
20161016 13:47:41< mattsc> Right, that’s my feeling.
20161016 13:48:13< mattsc> Including them back in with the diverse filters is not really possible then in a way that makes sense in general (for all settings).
20161016 13:48:14< gfgtdf> vultraz: i dont really see the point of 'simplyfying', becasue usualyl you can use those utilty function withotu understanding how they work in detail. So i'd usuualy rather try to make them fast even if tham mean doming some stuff 'by hand'
20161016 13:48:28< gfgtdf> if this means*
20161016 13:48:42< mattsc> That’s because it’s not just the filters, there’s path finding too etc., and that cannot be done by including some units and not others.
20161016 13:49:02< vultraz> gfgtdf: well, true, but i decided not to use boost:;split
20161016 13:49:32< mattsc> zookeeper: I wrote a little blip on the MAI page explaining what the behavior is going to be.
20161016 13:49:38< mattsc> Third bullet at https://wiki.wesnoth.org/Micro_AIs#A_Few_General_Words_about_Micro_AIs
20161016 13:49:57< vultraz> i found a method that seems to work on SO
20161016 13:50:04< vultraz> so was wondering if it's any better
20161016 13:50:08< vultraz> it's certainly simpler
20161016 13:52:24< zookeeper> mattsc, all fine by me. petrification was probably originally added solely for one HttT scenario which hasn't been seen since 1.0 or so... and it's really rare even in UMC, i believe (except for an actual statue-that-can-come-to-life here and there, perhaps).
20161016 13:53:47< mattsc> zookeeper: Thanks.  I actually use temporary petrification in my campaign Grnk, but I agree that it is likely rare.
20161016 13:54:40< mattsc> I think the most important thing is that the MAIs do not go actively for the player’s hidden units.  Everything else is icing on the cake, really.
20161016 13:54:55< zookeeper> just like walking corpses, it's one of those things that shouldn't have been a mainline thing in the first place :J
20161016 13:56:25< mattsc> Maybe, I don’t really know the background on all of this, but it is amazing how complicated the originally so simple Micro AIs got in some places because they need to take all kinds of corner cases into account that I originally didn’t think about.
20161016 13:57:00< mattsc> For example, I noticed yesterday that the new Assassin MAI can be entirely disabled by one strategically placed petrified unit!
20161016 13:57:08< gfgtdf> vultraz: i ahve to say that i curently dont really undertstnd thst code, specialyl why we do the first 'if (flags & STRIP_SPACES) ' with that loop in it, i think the trim from the main loop shodul actuall do the same
20161016 13:57:36< vultraz> yeah i don't understand that either
20161016 13:58:00< gfgtdf> vultraz: hmm wait i think its becsue that doens just trim end instead of trim all
20161016 13:58:03< gfgtdf> hmm
20161016 13:58:48< mattsc> zookeeper: anyways, the new behavior is not in mainline yet, but it will be soon.  I just need to do some more testing of such corner cases.
20161016 13:58:57< gfgtdf> vultraz: do you know a case where we call it withotu strip spaces ?
20161016 13:59:28< mattsc> After that, I’ll go on and figure out how to deal with shroud ...
20161016 13:59:56< zookeeper> mattsc, good that we generally have very simple core game rules
20161016 14:00:07< mattsc> agreed
20161016 14:00:24< zookeeper> i wonder how much something seemingly simple like the ability to swap the places of two adjacent units would complicate the AI :>
20161016 14:00:30< vultraz> gfgtdf: there seem to be two or three cases but they're very rare
20161016 14:01:07< gfgtdf> vultraz: i think the reason is that no STRIP means actuall strip at begin but not at end
20161016 14:01:38< vultraz> that doesn't really make sense
20161016 14:01:53< vultraz> since it says that STRIP means both begin and end, why should no strip only be end
20161016 14:02:16< mattsc> zookeeper: not sure; depends on whether the AI needs to be able to use it efficiently or not.  In my own AIs (incl. the MAIs), I have mechanisms that let a unit step out of the way for another.  My guess is that that example specifically could be dealt with similarly.
20161016 14:02:31< mattsc> But my experience is that these things always get more complicated than I expect.
20161016 14:02:49< gfgtdf> vultraz: hmm no wait
20161016 14:03:15< zookeeper> mattsc, yeah maybe that was a poor example since an AI could just not use the feature and it wouldn't be any worse than now
20161016 14:03:37< mattsc> zookeeper: right — but the general point is valid, I think
20161016 14:10:39< gfgtdf> vultraz: well ok i think we can simplyfy this somehow but i'd say lets do this after the 1.13.5 release, since it loks liek there is a good chance to break things if we do that.
20161016 14:11:02< vultraz> gfgtdf: i don't think we'll be doing 1.13.6 for awhile now
20161016 14:11:08< vultraz> so i think it's ok if we commit this
20161016 14:11:47< vultraz> at least 2 weeks or so until release, but most likely more.
20161016 14:11:49< gfgtdf> vultraz: just becaue of that faction dialog ?
20161016 14:12:03< vultraz> gfgtdf: nah there's also the lua stuff
20161016 14:12:19< vultraz> i want that to go in
20161016 14:12:26-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161016 14:12:41< vultraz> gfgtdf: also i realized https://gna.org/bugs/index.php?25130 applies to the Description button too
20161016 14:12:49< vultraz> so i might have to try to make the new addons manager ui
20161016 14:12:51< vultraz> work
20161016 14:13:09< vultraz> (oh wedge009 already posted that heh)
20161016 14:13:29< vultraz> gfgtdf: tl'dr there's really a lot of stuff to do
20161016 14:14:01< vultraz> gfgtdf: and i think we should also fix some of the memory bugs matthiakrgr reported
20161016 14:15:01< irker502> wesnoth: Chris Beck wesnoth:master 0f3fdb60646e / src/font/text.cpp: add a code comment to unpremultiply alpha function https://github.com/wesnoth/wesnoth/commit/0f3fdb60646ebea2a2a98a9041fc13f385e0e1ca
20161016 14:16:35< vultraz> gfgtdf: anyway it's really late so i'm gonna go get some sleep. let me know if i should commit this and ill check in the morning.
20161016 14:16:57< vultraz> gfgtdf: or if it's wrong feel free to fix it or something
20161016 14:17:03< vultraz> gfgtdf:  i just got the basic method from http://stackoverflow.com/a/236803 anyway
20161016 14:17:07 * vultraz out
20161016 14:17:21< vultraz> gfgtdf: oh, and if you want me to revert the boost::trim stuff i can do that tomorrow
20161016 14:19:18< gfgtdf> vultraz: i think both codes (yours and teh previous) are not perfect.  If you are sure that your code doesnt hcange bhaviour feel free to commit it, we can always optmize it later and doign so it easier if it easier to see how the code shodul behave.
20161016 14:19:28< gfgtdf> vultraz: about the string plit that is
20161016 14:19:44< gfgtdf> vultraz:  i can also revert the boost trim stuff, still think about it
20161016 14:20:03< gfgtdf> vultraz: although i might not have tome to do it soon.
20161016 14:23:59-!- gfgtdf [~chatzilla@x4e3694ff.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]]
20161016 14:42:42-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 14:42:43< travis-ci> wesnoth/wesnoth#11585 (master - 0f3fdb6 : Chris Beck): The build is still failing.
20161016 14:42:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168052262
20161016 14:42:43-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 15:01:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161016 15:05:06-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20161016 15:12:03< irker502> wesnoth: Chris Beck wesnoth:master 415cdd74e5be / src/font/ (constants.cpp constants.hpp): correct compilation errors, ODR violation https://github.com/wesnoth/wesnoth/commit/415cdd74e5be8a968566575c78f9ab8136fef1ca
20161016 15:17:16< irker502> wesnoth: Chris Beck wesnoth:master dd165091ffc5 / src/font/constants.cpp: fixup non-utf8 font/constants.cpp https://github.com/wesnoth/wesnoth/commit/dd165091ffc56198146a1e34040400ac894ca656
20161016 15:27:48< JyrkiVesterinen> Okay, I think I have managed to fix the build. I'm attempting to build the game locally to verify.
20161016 15:28:27< JyrkiVesterinen> (415cdd74 above is not enough, linking errors remain with it alone. I suppose iceiceice didn't actually *try* compiling.)
20161016 15:29:08< matthiakrgr> http://pastebin.com/BdRrN48W  
20161016 15:29:41< JyrkiVesterinen> Yes, I have a potential fix for those errors as well.
20161016 15:29:45< celticminstrel> JyrkiVesterinen: Did you look aat 825 again yet?
20161016 15:29:45-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161016 15:29:54< celticminstrel> iceiceice: What about the figure dash?
20161016 15:30:00< iceiceice> JyrkiVesterinen, yah i just fixed a few obvious ones from the recent commits
20161016 15:30:03< celticminstrel> Does it look like a ? to you too?
20161016 15:30:13< celticminstrel> Or is that just me?
20161016 15:30:20< iceiceice> celticminstrel, i dont know what it was supposed to be
20161016 15:30:24< iceiceice> i guess that needs fixing too
20161016 15:30:49 * celticminstrel opens Character Viewer
20161016 15:30:57< JyrkiVesterinen> Yes, I looked at PR825 again. I have no complaints other than that tad_carlucci didn't remove one comment I asked him to remove.
20161016 15:31:07< celticminstrel> I assume it should be U+2012.
20161016 15:31:55< iceiceice> ok
20161016 15:32:02< iceiceice> i guess we should put comments for each one
20161016 15:32:04< iceiceice> in case this happens again
20161016 15:32:21< celticminstrel> I can do it, then...
20161016 15:32:29< JyrkiVesterinen> Please don't add the comments right now. I believe I'm about to commit my fixes.
20161016 15:32:29< iceiceice> or i guess we could write them as like 
20161016 15:32:32< iceiceice> "\u2012"
20161016 15:32:41< iceiceice> instead of literally as the unicode characters in the source code
20161016 15:32:44< iceiceice> idk
20161016 15:32:56< iceiceice> yah ok i won't commit until you guys do
20161016 15:35:31< irker502> wesnoth: Jyrki Vesterinen wesnoth:master 5e2af01fbadb / src/ (46 files in 13 dirs): Fix build https://github.com/wesnoth/wesnoth/commit/5e2af01fbadbed8a0182a5fe9bd3b23ef95317c3
20161016 15:36:37< iceiceice> JyrkiVesterinen, do you know why we split it all up into multiple libraries like this?
20161016 15:36:50< iceiceice> like why is there wesnothlib wesnothcore etc.
20161016 15:37:10< iceiceice> i mean i assume it's to make it link faster or something
20161016 15:37:19< iceiceice> but presumably it prevents some link-time optimizations if we do that?
20161016 15:37:36< JyrkiVesterinen> Wesnothlib is used by both the server and client, as the commit message says.
20161016 15:37:52< JyrkiVesterinen> I can't really think of any other way of sharing code between them.
20161016 15:38:18< iceiceice> you could just compile each cpp file and then link it all once
20161016 15:38:32< irker502> wesnoth: Celtic Minstrel wesnoth:master 3b52ae37fc5e / src/font/constants.cpp: Fixup unicode figure dash https://github.com/wesnoth/wesnoth/commit/3b52ae37fc5ef5a41d5d8499b1c841cce896863e
20161016 15:38:41< iceiceice> i mean thats the most naive way of arranging a project
20161016 15:38:50< iceiceice> if wesnothlib were a shared library, like a dll,
20161016 15:38:58< celticminstrel> The XCode project currently just compiles those files twice, I think.
20161016 15:39:05< iceiceice> then it might make it smaller executable size overall if you need to have wesnothd and wesnoth on the same machine
20161016 15:39:11< iceiceice> but its actually a static library
20161016 15:39:12< iceiceice> iirc
20161016 15:39:24< celticminstrel> I doubt it prevents link-time optimiziation since it's a static lib...?
20161016 15:39:52< celticminstrel> At least, in theory, link-time optimization could still be performed.
20161016 15:40:13< iceiceice> i thguht that it makes it harder but maybe i'm wrong
20161016 15:40:22< JyrkiVesterinen> With "compile each cpp file and link it all once", do you mean that the files shared between server and client would be mentioned in both projects?
20161016 15:40:39< celticminstrel> I think there's a way to make MSVC not actually use the static lib, and instead directly link all the object files produced by the wesnothlib target.
20161016 15:40:40< iceiceice> i mean like, there would be one list of cpp files for the server
20161016 15:40:42< iceiceice> and one list for the client
20161016 15:40:46< iceiceice> and in cmake / scons whathave you
20161016 15:40:48< celticminstrel> I recall doing this for BoE.
20161016 15:40:57< iceiceice> you just declare an executable target from those cpp files
20161016 15:41:11< iceiceice> the thing we do where we declare mutiple intermediate libraries
20161016 15:41:19< iceiceice> i mean that's slightly more complex
20161016 15:41:20< JyrkiVesterinen> In other words, that instead of having wesnothlib, wesnoth and wesnothd, we'd only have wesnoth and wesnothd, where both wesnoth and wesnothd include, for example, serialization/string_utils.cpp?
20161016 15:41:25< iceiceice> yah
20161016 15:41:38< iceiceice> i guess you would have to compile them all twice
20161016 15:41:45< iceiceice> if you compile both wesnothd and wesnoth
20161016 15:41:49< iceiceice> but most people dont need to compile wesnothd
20161016 15:42:01< shadowm> Uh.
20161016 15:42:16< celticminstrel> wesnothd is listed as a dependency of wesnoth in the XCode project.
20161016 15:42:21< shadowm> LAN hosting requires wesnothd.
20161016 15:42:24< celticminstrel> Not sure if that's the case in MSVC.
20161016 15:42:35< iceiceice> yah but almost nobody actually does LAN hosting
20161016 15:42:41< JyrkiVesterinen> No, MSVC allows one to compile only wesnoth.
20161016 15:42:55< shadowm> iceiceice: I wouldn't say that, it might give someone weird ideas.
20161016 15:43:08< celticminstrel> I bet tons of people do LAN hosting.
20161016 15:43:09 * vultraz sticks head in
20161016 15:43:14< iceiceice> hehe
20161016 15:43:18< celticminstrel> There's no particular reason why those people would tell us though.
20161016 15:43:44-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 15:43:45< travis-ci> wesnoth/wesnoth#11586 (master - 415cdd7 : Chris Beck): The build is still failing.
20161016 15:43:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168059779
20161016 15:43:45-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 15:43:45< iceiceice> ok, forget i mentioned it
20161016 15:44:00< celticminstrel> So why is the build failing lately?
20161016 15:44:02< shadowm> They do tend to ask us once or twice every month what ports they need to forward or allow through for LAN hosting though.
20161016 15:44:15< JyrkiVesterinen> celticminstrel: Multiple reasons.
20161016 15:44:20< iceiceice> shadowm: that's news to me 
20161016 15:44:21< shadowm> Once or 0.5 times every month rather.
20161016 15:44:24-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161016 15:44:48< JyrkiVesterinen> First it was requiring SDL 2.0.4 that Travis doesn't have.
20161016 15:45:19< JyrkiVesterinen> Then the attempt to use ccache that was way too fragile.
20161016 15:45:51< JyrkiVesterinen> Next, my build fix for MSVC2013, that broke the build with all other compilers.
20161016 15:46:41< JyrkiVesterinen> And finally the commit that started to use font/constants.cpp in serialization/string_utils.cpp, breaking the build of wesnothd.
20161016 15:47:02< JyrkiVesterinen> It /should/ all be fixed now.
20161016 15:47:13< celticminstrel> Okay, great.
20161016 15:49:29< vultraz> we really should fix travis to actually use 2.0.4 proper
20161016 15:49:49< shadowm> Find a trustworthy PPA that has 2.0.4. :p
20161016 15:49:54< celticminstrel> Which is possible, by using a different package repo or something.
20161016 15:50:09< vultraz> Don't ask me how to do it, I'm a Windows user :P
20161016 15:50:10< shadowm> I couldn't even find untrustworthy PPAs with anything newer than 2.0.2.
20161016 15:50:58< shadowm> I really wouldn't worry about it. You essentially panicked about rendering issues to justify that version bump -- those are completely irrelevant to Travis.
20161016 15:51:20< shadowm> On the other hand, if your intention is to rush to use 2.0.4+ APIs...
20161016 15:51:51< vultraz> I don't *think* I used any 2.0.4 APIs
20161016 15:51:59< shadowm> You obviously didn't.
20161016 15:52:04< shadowm> If you did you would know.
20161016 15:52:15< shadowm> Mostly because there'd be no way to make Travis builds pass.
20161016 15:52:21< vultraz> Ah
20161016 15:52:38< celticminstrel> Hmm, maybe fake_unit_manager could be used to create animations without actually having a unit...
20161016 15:52:44< vultraz> Well, I wanted to bump travis since I thought travis was always supposed to build the minimum.
20161016 15:52:55< JyrkiVesterinen> Well, not a single Travis build has passed since the "require SDL 2.0.4" commit yet...
20161016 15:53:16< shadowm> JyrkiVesterinen: That's because of a combination of other build-breaking factors.
20161016 15:53:50< JyrkiVesterinen> I know. I was just pointing out that your reasoning isn't yet valid. ;)
20161016 15:53:51< shadowm> Funny how much breakage can happen in less than 36 hours.
20161016 15:54:15< JyrkiVesterinen> Right, this has been a complete mess... :/
20161016 15:54:19< vultraz> It's what happens when we decide to push back releases and start moving everything around.
20161016 15:54:52< shadowm> No, there currently is a way to fix things. Probably. If the code depended on 2.0.4 then the only way to keep Travis happy would be to conditionally replace 2.0.4+ code with reasonable fallbacks or otherwise compile them out.
20161016 15:56:05< shadowm> If no-one can find a PPA with 2.0.4 we could either build SDL 2.0.4 for trusty ourselves or break open one of the latter Ubuntu distribution packages.
20161016 15:56:32< shadowm> And then redirect the build system to look at that instead.
20161016 15:57:09< shadowm> Unless some later build is bound to newer libc, Xlib or others, this ought to work.
20161016 15:58:30< celticminstrel> Blargh, 400 files to recompile. This'll take awhile.
20161016 15:58:31< shadowm> vultraz: Ages ago (feels like it was a year ago, really) Aginor suggested having a short (1 week-ish) feature freeze prior to each release to keep this kind of thing from messing up the schedule. Perhaps you should consider this again.
20161016 15:58:38< celticminstrel> Looks like wesnothd also failed to link.
20161016 15:59:11< shadowm> vultraz: Obviously the precondition is that by the start of the feature freeze all preexisting blockers are fixed.
20161016 15:59:23< vultraz> shadowm: I shall keep this in mind
20161016 15:59:26< celticminstrel> Ah, font/constants.cpp needs to be in the server.
20161016 15:59:51< iceiceice> vultraz, i mean the thing is we just kind of did too many things at once
20161016 16:00:09< iceiceice> there were like a number of subtle problems with font pr, and then before we fixed them a bunch of other commits happened that broke things
20161016 16:00:15< iceiceice> but i dont think its that bad, it all seems pretty solvable
20161016 16:00:24< shadowm> vultraz: i.e. unlike 4.5 days ago "we shall keep pushing features while there's an outstanding blocker open" situation we had while the release was still supposed to take place yesterday.
20161016 16:00:52< JyrkiVesterinen> The font PR was the ultimate cause for most problems we had today.
20161016 16:00:59< shadowm> (And yes, I'm aware I partook in the feature-pushing too.)
20161016 16:01:20< vultraz> I'm glad I heeded JyrkiVesterinen and postponed 
20161016 16:01:56< shadowm> src/campaign_server/addon_utils.cpp:48:61: error: no match for ‘operator=’ (operand types are ‘std::__cxx11::string {aka std::__cxx11::basic_string<char>}’ and ‘void’)
20161016 16:02:00< shadowm>     res = boost::replace_all(res, "$" + sym.first, sym.second);
20161016 16:02:14< JyrkiVesterinen> SDL 2.0.4 requirement was made because of it IIRC. I needed to fix the MSVC2013 build because of it. And the moving of constant strings to font/constants.cpp (which predated requring constants.cpp in wesnothlib) was related as well.
20161016 16:02:29< vultraz> agh fuck
20161016 16:02:30< shadowm> iceiceice: I believe this is your change?
20161016 16:02:34< vultraz> shadowm: mine
20161016 16:02:44< vultraz> drop the "res ="
20161016 16:02:59< shadowm> I read Charles as Chris, sorry.
20161016 16:03:40< shadowm> What library is this from?
20161016 16:03:56< shadowm> String algorithms, got it.
20161016 16:05:13-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 16:05:14< travis-ci> wesnoth/wesnoth#11587 (master - dd16509 : Chris Beck): The build is still failing.
20161016 16:05:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168060545
20161016 16:05:15-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 16:07:35< vultraz> agh, fun, my change to utils::split broke help
20161016 16:07:49< vultraz> thankfully it's still unpushed
20161016 16:08:33-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 16:10:27< iceiceice> is master believed to be fixed right now?
20161016 16:10:30< iceiceice> i am still compiling it
20161016 16:11:00< JyrkiVesterinen> I believe I fixed it. I was able to compile it locally.
20161016 16:11:17< iceiceice> which compiler?
20161016 16:11:23< JyrkiVesterinen> GCC 6.2.0
20161016 16:11:25< iceiceice> ok
20161016 16:11:33< iceiceice> i will try with clang next i guess
20161016 16:11:37< tad_carlucci> I'm building clang now and will be doing gcc in a bit
20161016 16:11:47< iceiceice> JyrkiVesterinen, one thing about std::random_device
20161016 16:11:56< iceiceice> is that it is not properly implemented in mingw builds
20161016 16:12:07< iceiceice> it will just return the same number every time or something
20161016 16:12:30< iceiceice> for whatever reason the gcc devs didn't get around to figuring out ms crypto api
20161016 16:12:51< iceiceice> usually if you use `std::random_device` you want to guard it behind some preprocessor flags
20161016 16:13:04< iceiceice> and only use it on platforms where you know it does something good and will save you some time (MS)
20161016 16:13:10< irker502> wesnoth: Ignacio R. Morelle wesnoth:master a68692326197 / src/campaign_server/addon_utils.cpp: campaignd: Fix incorrect use of boost::replace_all() https://github.com/wesnoth/wesnoth/commit/a6869232619715c7fa87a4286dce957a1e6bd61c
20161016 16:13:13< shadowm> I built master here.
20161016 16:13:27< iceiceice> on linux and os X, std::random_device does hardly anything
20161016 16:13:49< shadowm> Since Travis requires building campaignd in at least one configuration, I believe this commit is needed for builds to pass there.
20161016 16:13:53< iceiceice> in libc++ (clang), it is basically just a dozen lines of code wrapping over `std::fopen("/dev/urandom")`
20161016 16:14:11< iceiceice> so in most cases i would say it's not really worth it to use std::random_device
20161016 16:14:21< iceiceice> i dont know exactly how boost::random_device works, it might work better actually
20161016 16:14:44< iceiceice> in general using std::random_device in mingw builds is probably a bug
20161016 16:15:00< JyrkiVesterinen> Well, I didn't know any of that. I used std::random_device because it looks good on paper: a pure C++11 way to get a random seed.
20161016 16:15:07< iceiceice> yah
20161016 16:15:23< iceiceice> they should have standardized it more rigorously or something
20161016 16:15:31< iceiceice> or its just a mingw problem
20161016 16:15:41< tad_carlucci> Anyone look at Travis/CI .. failing .. In file included from src/serialization/string_utils.hpp:19:0,
20161016 16:15:41< tad_carlucci>                  from src/color_range.cpp:25:
20161016 16:15:41< tad_carlucci> src/font/constants.hpp:19:17: fatal error: SDL.h: No such file or directory
20161016 16:15:41< tad_carlucci>  #include <SDL.h>
20161016 16:15:41< tad_carlucci>                  ^
20161016 16:15:55< iceiceice> last i checked mingw still is not fully c++11 conforming
20161016 16:15:58< shadowm> Boost 1.61's random_device seems to use urandom as well?
20161016 16:16:10< iceiceice> what does it do for mingw though?
20161016 16:16:11< JyrkiVesterinen> Hmm, released builds are probably not using MinGW anyway.
20161016 16:16:18< iceiceice> JyrkiVesterinen, i think actually they are
20161016 16:16:21< iceiceice> can ask loonycyborg
20161016 16:16:27< shadowm> iceiceice: Seems to call some system crypto library.
20161016 16:16:35 * shadowm off.
20161016 16:16:41< iceiceice> ok, then it might be better if we use boost::random_device
20161016 16:17:03< JyrkiVesterinen> OK... than I have severely broken random number generation in Windows builds. :(
20161016 16:17:06< vultraz> but what about std for the mtwhatisit?
20161016 16:17:09< loonycyborg> ask about what?
20161016 16:17:32< iceiceice> if you are stil using mingw builds for releases or if sometime in the last year while i wasn't paying attention you hit your head and started using MSVC
20161016 16:17:34< iceiceice> :p
20161016 16:17:37< JyrkiVesterinen> I'll switch it to boost::random_device ASAP.
20161016 16:18:25< loonycyborg> I'm using mingw still
20161016 16:18:51< loonycyborg> mingw-w64 for dev releases
20161016 16:19:00< JyrkiVesterinen> tad_carlucci: font/constants.hpp no longer depends on SDL.
20161016 16:19:04< JyrkiVesterinen> So it's already fixed.
20161016 16:19:23< vultraz> still don't see why you needed to split the file 
20161016 16:19:51< JyrkiVesterinen> Because of this line.
20161016 16:19:52< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/font/standard_colors.cpp#L19
20161016 16:20:07< JyrkiVesterinen> The inverse() function is from sdl/utils.hpp.
20161016 16:20:25< JyrkiVesterinen> Utils.hpp has way too many dependencies to live in wesnothlib.
20161016 16:20:39< vultraz> I see
20161016 16:20:52< vultraz> also you forgot the copyright block
20161016 16:20:57-!- louis94 [~~louis94@91.178.241.131] has joined #wesnoth-dev
20161016 16:21:11< JyrkiVesterinen> Do we use copyright blocks in .cpp files too?
20161016 16:21:35< vultraz> everywhere
20161016 16:22:06< JyrkiVesterinen> OK. I'll add a copyright block to it, and scripting/lua_preferences.cpp that I added earlier.
20161016 16:24:56< vultraz> well, glad i didn't push this utils::split change
20161016 16:25:22< vultraz> seems to work everywhere except help :/
20161016 16:26:46< irker502> wesnoth: Jyrki Vesterinen wesnoth:master 9200fc8dba26 / src/ (font/standard_colors.cpp scripting/lua_preferences.cpp): Add two copyright blocks https://github.com/wesnoth/wesnoth/commit/9200fc8dba26d171fee28d66c1e56810e77389d3
20161016 16:28:40-!- louis94 [~~louis94@91.178.241.131] has quit [Ping timeout: 250 seconds]
20161016 16:30:21< iceiceice> vultraz, btw,
20161016 16:30:27< iceiceice> a suggestion regarding the credits screen in master,
20161016 16:30:38< iceiceice> imo the fact that you press up to make it go down faster
20161016 16:30:41< iceiceice> is a little counter-intuitive
20161016 16:30:56< iceiceice> idk if you made that or someone else
20161016 16:31:08< vultraz> it was the old behavior in gui1
20161016 16:31:25< iceiceice> hmm ok
20161016 16:32:32< vultraz> (does std::getline return the characters after the last delim..?)
20161016 16:34:20-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 16:34:21< travis-ci> wesnoth/wesnoth#11588 (master - 5e2af01 : Jyrki Vesterinen): The build has errored.
20161016 16:34:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168063116
20161016 16:34:21-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 16:34:34< iceiceice> vultraz, why do you want to use std::getline?
20161016 16:34:52< iceiceice> vultraz, also, as a side comment, i think the new font makes the help look better
20161016 16:35:04< JyrkiVesterinen> tad_carlucci: I quickly tried compiling the GL_clang_cleanup branch with -Werror -Wpedantic, and got an error early on.
20161016 16:35:12< iceiceice> certainly, the deficiencies of SDL_TTF fake italics are a lot less noticeable
20161016 16:35:23< vultraz> iceiceice: http://pastebin.com/yabmEyR9
20161016 16:35:28< JyrkiVesterinen> (Then I got sidetracked with the need to change std::random_device to boost::random_device.)
20161016 16:35:37< vultraz> was looking if utils::split could be simplified
20161016 16:35:51< vultraz> thought of using boost::split but couldn't get that working so found this
20161016 16:35:56< vultraz> general method on so
20161016 16:36:29< vultraz> JyrkiVesterinen: will you be using std::mt19937
20161016 16:36:32< tad_carlucci> JyrkiVesterinen, I'm building it with clang right now. I'll be doing CMake/gcc in a bit. Not sure if I'm using -Wpedantic, will check
20161016 16:37:23< iceiceice> vultraz, i guess i think of std::getline as pretty obscure but i guess that's not a bad solution
20161016 16:37:24< JyrkiVesterinen> vultraz: Well, I can just as well switch the default RNG to std::mt19937 when I'm here.
20161016 16:37:52< JyrkiVesterinen> tad_carlucci: At least you indicated in PR825 that you fixed the warnings you found with -Wpedantic.
20161016 16:37:58< vultraz> iceiceice: seems to work, except it's crashing when launching help in basic_string::compare so idk
20161016 16:38:05< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/pull/825#issuecomment-253672599
20161016 16:38:11< vultraz> anyway im going back to sleep
20161016 16:39:00< tad_carlucci> JyrkiVesterinen, That would be good if I did but I might have meant it differently. Right now I'm waiting for the clang build and wondering what's up with Travis
20161016 16:39:25< irker502> wesnoth: gfgtdf wesnoth:master d64d871e4d9e / src/whiteboard/side_actions.cpp: attempt to fix heap buffer overflow when using planning mode https://github.com/wesnoth/wesnoth/commit/d64d871e4d9e4cb7a2af35ed4ccd70a7189bb61b
20161016 16:39:55< JyrkiVesterinen> So I don't need to check that the branch compiles with -Werror -Wpedantic?
20161016 16:40:09< tad_carlucci> celticminstrel, Oh, found ONE deprecated function being used: math.atan2() in a_helper.lua .. so that makes it 2 loadstrings and 1 atan2 and I've completed the check.
20161016 16:41:11< tad_carlucci> JyrkiVesterinen, How did you add -Wpendantic? I am using the "strict" options and don't remember whether -Wpedantic is added for them.
20161016 16:41:54< JyrkiVesterinen> cmake -DENABLE_STRICT_COMPILATION=true -DCXX_FLAGS_USER=-Wpedantic
20161016 16:42:17< vultraz> oh, huh..
20161016 16:42:25< vultraz> was a backwards check in help
20161016 16:42:46< vultraz> i suppose it never crashed before because there was always something there
20161016 16:42:55< vultraz> so, still, a problem in my code, possibly..
20161016 16:43:46< vultraz> which is why i asked if getline returned anything past the last delim
20161016 16:44:30< tad_carlucci> JyrkiVesterinen, Ah. TY. I'll see if I can work through with that option. Might be too many things to fix. But it would be nice. In the meantime when I can, I will adjust the comments to remove the confusion.
20161016 16:45:27< JyrkiVesterinen> Well, if you haven't tried fixing all the warnings -Wpedantic reports, fixing them all would probably take quite long.
20161016 16:45:51< JyrkiVesterinen> So, is it OK if I just merge PR825 after a quick check later today?
20161016 16:47:45< tad_carlucci> JyrkiVesterinen, I made the changes but I want to see what Travis says. "Failing" bothers me but it might not be current master failing.
20161016 16:47:54< celticminstrel> Is !(flags & REMOVE_EMPTY) the same as (flags &~ REMOVE_EMPTY)?
20161016 16:47:59 * celticminstrel suspects not but hopes so.
20161016 16:49:10< iceiceice> celticminstrel, i dont think so
20161016 16:49:15< celticminstrel> Oh well.
20161016 16:49:16< iceiceice> ~ is bitwise negation
20161016 16:49:22< iceiceice> so its like, flipping the mask
20161016 16:49:33< iceiceice> it depends exactly how you are using the expresion
20161016 16:49:39< celticminstrel> if()
20161016 16:49:42< iceiceice> well
20161016 16:49:57< celticminstrel> vultraz: That code looks fine to me, what's the crash like?
20161016 16:50:07< iceiceice> if (! (flags & REMOVE_EMPTY)) means, does flags have a one at any position where REMOVE_EMPTY is one
20161016 16:50:07 * tad_carlucci used to worry about how slow his old laptop was. That is, until he watched Travis/CI building wesnoth and realized his laptop is actually about the same speed.
20161016 16:50:16< celticminstrel> vultraz: Also I'd use istringstream rather than stringstream, not that it really matters.
20161016 16:50:27< iceiceice> *does flags NOT have a one at any position where REMOVE_EMPTY is one
20161016 16:50:41< iceiceice> the second means, does FLAGS have a one at a positoin where REMOVE_EMPTY is zero
20161016 16:50:50< iceiceice> so they are very different
20161016 16:51:25< JyrkiVesterinen> The expressions are not equivalent. For example, if flags is zero, the first expression returns 1 and the second returns 0.
20161016 16:51:42< iceiceice> i mean its not even the same from point of view of like de morgan's laws
20161016 16:51:58< iceiceice> !(flags & REMOVE_EMPTY) is the same as ~flags | ~ REMOVE_EMPTY
20161016 16:52:13< celticminstrel> That's even uglier.
20161016 16:52:16< iceiceice> or rather like, static_cast<bool>(~flags | ~ REMOVE_EMPTY)
20161016 16:52:54< celticminstrel> I guess in Lua you can do like... x ~~ y to test equality...
20161016 16:53:03< celticminstrel> (On integers only, of course.)
20161016 16:53:19< iceiceice> didn't know that
20161016 16:53:25< iceiceice> why wouldn't you use x == y ?
20161016 16:53:29< celticminstrel> You would.
20161016 16:53:43< celticminstrel> ~~ is more precisely bitwise xnor
20161016 16:53:53< celticminstrel> Or rather, xor plus complement.
20161016 16:54:04< celticminstrel> ie it binds as x ~ ~y
20161016 16:54:16< iceiceice> does lua have ~ as a binary operator ?
20161016 16:54:25< celticminstrel> In 5.3, yeah, it's bitwise xor.
20161016 16:54:29< iceiceice> oh i didnt know that
20161016 16:54:40< iceiceice> and also ~ as a unary operator?
20161016 16:54:42< iceiceice> that is all new
20161016 16:54:43< celticminstrel> (Because ^ was already taken by exponentiation, I guess.)
20161016 16:54:52< celticminstrel> ~ as an unary operator is not new...
20161016 16:54:56< iceiceice> i think it is
20161016 16:55:00< iceiceice> i think in 5.2, they had ~=
20161016 16:55:02< iceiceice> but not ~
20161016 16:55:06< iceiceice> which some people complained about
20161016 16:55:17< celticminstrel> Oh, wait, it's not used for logical not?
20161016 16:55:23< iceiceice> no i think it isn't
20161016 16:55:27< celticminstrel> Oh okay.
20161016 16:55:39< celticminstrel> Yeah, now that I think of it, logical not is a word operator.
20161016 16:56:06< iceiceice> at least in 5.1 they didnt have it
20161016 16:56:07< iceiceice> http://hastebin.com/uriyujasak.cpp
20161016 16:56:28< iceiceice> i dont remember if they have ! for not ?
20161016 16:56:36< celticminstrel> No.
20161016 16:57:30< iceiceice> yah i guess you are just supposed to write not
20161016 16:59:11< irker502> wesnoth: gfgtdf wesnoth:master 982d9dc42866 / src/play_controller.cpp: attempt to fix heap use after free when "reset to beginning" test map save repla https://github.com/wesnoth/wesnoth/commit/982d9dc428666aed39de8ffd1c7e8d443f7877bb
20161016 17:00:07-!- gfgtdf [~chatzilla@x4e3694ff.dyn.telefonica.de] has joined #wesnoth-dev
20161016 17:00:27< gfgtdf> matthiakrgr: please check fi tmy last 2 commits fix the bug i meantioned in thor dreciption
20161016 17:00:43< matthiakrgr> yes will have a look today 
20161016 17:00:54< matthiakrgr> (compiling right now :) ) 
20161016 17:00:56< celticminstrel> Every time I view PR825 it seems like it tells me "We went looking everywhere, but couldn’t find those commits."
20161016 17:01:10< celticminstrel> (When I view it from the notifications page.)
20161016 17:01:38< gfgtdf> celticminstrel: yes its the same for me.
20161016 17:01:39-!- travis-ci [~travis-ci@ec2-54-224-164-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 17:01:40< travis-ci> wesnoth/wesnoth#11589 (master - 3b52ae3 : Celtic Minstrel): The build has errored.
20161016 17:01:40< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168063664
20161016 17:01:40-!- travis-ci [~travis-ci@ec2-54-224-164-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 17:01:47< iceiceice> hmm 
20161016 17:01:52< iceiceice> i get linker errors with scons builds and clang
20161016 17:02:07< iceiceice> something related to boost regex detail
20161016 17:02:19< iceiceice> in libwesnoth_extras
20161016 17:02:52< iceiceice> do i need to build boost with clang also?
20161016 17:03:04< iceiceice> it might be like a C++11 string abi thing
20161016 17:03:26< celticminstrel> Boost probably needs to be built with the same compiler, yes.
20161016 17:03:35< celticminstrel> Not 100% sure though.
20161016 17:03:56< celticminstrel> When it's GCC vs clang it might be potentially binary compatible, depending on specific versions...
20161016 17:04:30< iceiceice> it used to be that clang tries to be able to use gcc compiled libs
20161016 17:04:39< iceiceice> b/c otherwise they would not get any traction in linux
20161016 17:05:18< celticminstrel> But then GCC changed their ABI IIRC, and I think clang might've been slow to catch up on that?
20161016 17:05:40< iceiceice> yah there was at least one issue
20161016 17:05:59< irker502> wesnoth: Celtic Minstrel wesnoth:master 697a9a2edda9 / projectfiles/Xcode/Wesnoth.xcodeproj/project.pbxproj: Update XCode project https://github.com/wesnoth/wesnoth/commit/697a9a2edda9fd7e23673948ff48e7dc2f010611
20161016 17:06:10< iceiceice> i guess i'll give up for now, i dont want to rebuild boost
20161016 17:06:43-!- Bonobo [~Bonobo@2001:44b8:254:3200:9d8e:1c6b:44d5:6fac] has quit [Ping timeout: 245 seconds]
20161016 17:07:56< tad_carlucci> celticminstrel, I'm able to build clang here with glibc .. I don't think I even installed the clang libs.
20161016 17:14:08< iceiceice> tad_carlucci, i tried a fresh build
20161016 17:14:13< iceiceice> like, deleting scons option cache and build dir
20161016 17:14:20< iceiceice> now i get an error when using clang
20161016 17:14:28< iceiceice> gcc: error: unrecognized command line option ‘-Qunused-arguments’
20161016 17:14:40< iceiceice> when compiling src/SDL_SavePNG/savepng.c
20161016 17:15:00< iceiceice> so i guess that scons does not properly know to use clang and not gcc when cxxtool=clang++ ?
20161016 17:15:37< tad_carlucci> iceiceice, add 'ctool=clang'
20161016 17:16:04< iceiceice> i think ctool is not actually an option of our scons
20161016 17:16:18< iceiceice> hmm it wokred 
20161016 17:16:26< iceiceice> ok, now i get the linker error though
20161016 17:16:43< tad_carlucci> iceiceice, It is (now, loonycyborg added it) and it does both c and c++ ,, wiki updated 2 days ago
20161016 17:17:03< iceiceice> it would be nice if cxxtool=clang++ would imply ctool=clang or something
20161016 17:17:23< iceiceice> or, if we could just compile savepng.c as c++ :D
20161016 17:17:30< tad_carlucci> iceiceice, Unfortunately he did it the other way around clang include clang++
20161016 17:17:46< tad_carlucci> iceiceice, There was good reason for keeping it C.
20161016 17:17:51< iceiceice> what reason?
20161016 17:18:33< tad_carlucci> Frankly, I don't remember, it was on IRC a few days ago when I had the exact issues and questions you're having and it seemed reasonable to me.
20161016 17:18:54< celticminstrel> It uses libpng and by extension setjmp.
20161016 17:19:03< iceiceice> so?
20161016 17:19:38< tad_carlucci> yeah .. and there was concern about exceptions stepping into the mix. I guess it was a future-proofing issue. But sounded reasonable enough.
20161016 17:20:35< iceiceice> if there is a bug caused by compiling it as C++ i would like to learn, i was quite careful about that
20161016 17:20:44< tad_carlucci> Anyway 'scons ctool=clang' should fix you up, iceiceice 
20161016 17:20:49< iceiceice> fair enough
20161016 17:21:03< celticminstrel> Admittedly it's still not totally exception safe when compiled as C.
20161016 17:21:17< iceiceice> celticminstrel, that's not an issue
20161016 17:21:31< iceiceice> it's not calling anything that throws
20161016 17:21:50< tad_carlucci> Well, my reaction is "This can't be worth worrying about!" but the explanantion was reasonable and the fix is in, so no need to argue over it.
20161016 17:21:52< irker502> wesnoth: gfgtdf wesnoth:master 44502938ea22 / src/whiteboard/side_actions.cpp: improve 'attempt to fix heap buffer overflow when using planning mode' https://github.com/wesnoth/wesnoth/commit/44502938ea22dcf795d62719f2ce42a7cd431bb8
20161016 17:22:31< iceiceice> tad_carlucci, i mean the fix is not really in, it's actually become a little more complex to build the project, and it now contains C code instead of only C++ files
20161016 17:22:50< iceiceice> the only reason you specify a C tool at all is to compile this one file
20161016 17:23:01< iceiceice> so that's a bit awkward imo
20161016 17:25:29< iceiceice> it's literally like 100 lines of code, there's no reason at all to compile it as C
20161016 17:25:40< iceiceice> it would be better i guess to just "remove it" and "rewrite it as C++" and commit that
20161016 17:25:59< iceiceice> except that wouldn't actually involve anything except changing the extension to .cpp
20161016 17:26:12< iceiceice> maybe changing a few const char * to std::string :p
20161016 17:26:20< celticminstrel> libpng depends heavily on setjmp so I wouldn't recommend something like that.
20161016 17:26:23< tad_carlucci> iceiceice, I fully agree but didn't feel it was worth the fight at the time. All I want is a clean run with no errors, no warning, at strict (-Wall -Werror) for both SCons and CMake and the only messages I see on MSVC are the known bugs in boost gzip
20161016 17:26:26< iceiceice> celticminstrel, that's nonsense
20161016 17:26:34< iceiceice> libpng doesn't depend heavily on setjmp,
20161016 17:26:38< celticminstrel> The best option would be not to include the source at all and just link it as a library.
20161016 17:26:40< iceiceice> and you can use libpng from a C++ program just fine
20161016 17:26:44< celticminstrel> It did lat time I looked?
20161016 17:26:47< celticminstrel> ^last
20161016 17:26:52< iceiceice> it only does that for certain error handling
20161016 17:26:57< iceiceice> and in reality those errors never happen
20161016 17:27:06< tad_carlucci> the rationale was "what if someone adds ..." 
20161016 17:27:13< iceiceice> longjmp is valid C++ anyways
20161016 17:27:55< celticminstrel> Oh sure it's valid, but it's not very safe.
20161016 17:27:58< iceiceice> celticminstrel, there are tons of C++ libraries that use libpng
20161016 17:28:03< iceiceice> we ourselves use libpng
20161016 17:28:17< iceiceice> it's not bad or wrong or unsafe at all to use libpng from a C++ program
20161016 17:28:27< iceiceice> longjmp is safe if you use it correctly
20161016 17:28:44< iceiceice> if you don't like longjmp, what you are really arguing is that we shoulnd't use libpng at all.
20161016 17:29:55< tad_carlucci> JyrkiVesterinen, Travis is done, no errors no warnings.  So I'm OK with merging PR 825 now.
20161016 17:30:24< JyrkiVesterinen> I'm yet to perform my own check.
20161016 17:30:39< JyrkiVesterinen> (In particular, this very chat distracts me...)
20161016 17:35:48< tad_carlucci> My issue with longjmp comes from training programmers in the 80s how to use it right. I think the hyper-sensitivity about it for Wesnoth comes from the mess it makes if you don't compile Lua to use exceptions instead, an inner C++ throws and the outer C++ can't catch it.
20161016 17:38:20< irker502> wesnoth: gfgtdf wesnoth:master ab1b499730a4 / src/persist_context.cpp: attempt to fix crash in [clear_gobal_variable] https://github.com/wesnoth/wesnoth/commit/ab1b499730a462c447fc406aef86c9a36313bee1
20161016 17:38:27< gfgtdf> matthiakrgr: ^
20161016 17:39:07< tad_carlucci> "attempt" commits always get me. "What, you didn't test, and are putting it out?"
20161016 17:39:24< celticminstrel> ^
20161016 17:40:01 * tad_carlucci grabs his Yoda costume: fix or fix not there is no attempt
20161016 17:40:12-!- mjs-de [~mjs-de@x4db5106b.dyn.telefonica.de] has quit [Remote host closed the connection]
20161016 17:40:39< JyrkiVesterinen> Well... okay... I fixed that crash accidentally earlier, and then backed it out because I wasn't trying to change the semantics of that function. :S
20161016 17:40:45< iceiceice> tad_carlucci, sometimes you try to fix a bug that you can't reproduce yourself
20161016 17:40:46< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/commit/39b0b28d8bee88842bfc74a9156d4564f8a3efa9
20161016 17:41:30< iceiceice> not ideal situation but by hook or by crook we get there i guess
20161016 17:41:37< iceiceice> bbl
20161016 17:41:38-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Quit: Ex-Chat]
20161016 17:42:01< gfgtdf> tad_carlucci: hmm yes, in this case the reason is tht i cannot test it becasue i cannot build wsnoth currently, i usualy try to avoid such commits.
20161016 17:44:09< mattsc> tad_carlucci: just as a side note, the loadstring in ca_fast_attack_utils.lua will be removed as soon as celticminstrel’s commit with the new ai.aspect.attacks is in.
20161016 17:44:19< mattsc> So most likely it will be gone before 1.13.6.
20161016 17:45:00< celticminstrel> I have to figure out what's wrong with that commit though... :|
20161016 17:45:03< celticminstrel> No idea where to start...
20161016 17:45:12< irker502> wesnoth: Jyrki Vesterinen wesnoth:master 442aec7ce198 / src/random_new.cpp: Use boost::random_device for seeding the default RNG https://github.com/wesnoth/wesnoth/commit/442aec7ce198729e3c4811412a92df0215048320
20161016 17:45:26< mattsc> celticminstrel: I’ll have a look to at some point
20161016 17:46:00< tad_carlucci> mattsc, I'm adding it to my Upgrade Lua because it's in two places. Plus a call to math.atan2 I need to change to atan. I'll be pushing once all my tests for theclang clenup pass locally and I can switch to the branch to make the one-liner and push.
20161016 17:47:39< tad_carlucci> mattsc, celticminstrel so whoever gets there last might have a merge conflict to fix .. but git is smart, it might figure it out.
20161016 17:48:07< celticminstrel> atan2(x,y) is just atan(x/y) right?
20161016 17:48:31< tad_carlucci> celticminstrel, Na.h  atan2(x,y) --> atan(x,y)
20161016 17:49:59< tad_carlucci> celticminstrel, My math side says you're correct. My programmer side notes there is a significant difference in performance and accuracy.
20161016 17:50:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161016 17:50:39< celticminstrel> Which makes me wonder why Lua didn't provide hypot()...
20161016 17:51:16< tad_carlucci> celticminstrel, Have you ever watches what happens to a supercomputer when you do hyberpolics?  Slow is optimistic.
20161016 17:53:22< tad_carlucci> celticminstrel, The standard C math stuff is sorta 'throw it all in' and then we have to figure out which vendors messed up their libs, which hardware has it, and which gets it wrong. I guess roberto decided to just walk away from the mess.
20161016 17:54:44< zookeeper> or hydroponics
20161016 17:54:50 * zookeeper has nothing to contribute to the discussion
20161016 17:54:56-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161016 17:55:24-!- travis-ci [~travis-ci@ec2-54-224-164-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 17:55:25< travis-ci> wesnoth/wesnoth#11591 (master - a686923 : Ignacio R. Morelle): The build was fixed.
20161016 17:55:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168069626
20161016 17:55:26-!- travis-ci [~travis-ci@ec2-54-224-164-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 17:55:51< JyrkiVesterinen> THE BUILD WAS FIXED :D
20161016 17:58:00< tad_carlucci> yes. which is why I was wanting to hold off on828
20161016 18:02:10< irker502> wesnoth: Gregory A Lundberg wesnoth:master 97b20ad60f12 / src/editor/action/mouse/ (mouse_action.hpp mouse_action_select.hpp): Missing override qualifiers https://github.com/wesnoth/wesnoth/commit/97b20ad60f12e87a12872d700052aa78c4938da5
20161016 18:02:12< irker502> wesnoth: Gregory A Lundberg wesnoth:master 0ecbbef03383 / / (6 files in 4 dirs): Apply patch to boost https://github.com/wesnoth/wesnoth/commit/0ecbbef03383db988d6ded0727210652d3967f12
20161016 18:02:14< irker502> wesnoth: Gregory A Lundberg wesnoth:master 86adfc47f802 / src/ (20 files in 13 dirs): GCC complains about float/double and useless cast https://github.com/wesnoth/wesnoth/commit/86adfc47f80295d8d1767728a853059268789d5f
20161016 18:02:16< irker502> wesnoth: Gregory A Lundberg wesnoth:master 6ef50850064c / src/ (gui/core/event/handler.cpp playturn_network_adapter.cpp show_dialog.cpp): Minor style changes per @jyrkive https://github.com/wesnoth/wesnoth/commit/6ef50850064c96d0b7b9bb28c5831b8f75d6f1c0
20161016 18:02:18< irker502> wesnoth: Gregory A Lundberg wesnoth:master 3368d5b57773 / src/scripting/lua_unit_attacks.cpp: Travis has been reporting a warning https://github.com/wesnoth/wesnoth/commit/3368d5b577736615121ccd854fd32f2cf67d6355
20161016 18:02:20< irker502> wesnoth: Jyrki Vesterinen wesnoth:master c507b78f2955 / / (29 files in 17 dirs): Merge pull request #825 from GregoryLundberg/GL_clang_cleanup https://github.com/wesnoth/wesnoth/commit/c507b78f2955d1069ddc47de521d84bec964d031
20161016 18:02:23< JyrkiVesterinen> Thank you for the fixes! :)
20161016 18:06:34-!- JyrkiVesterinen [~jyrki@87-92-25-47.bb.dnainternet.fi] has quit [Quit: Rebooting to Windows to update the MSVC project. It has been a long day...]
20161016 18:07:58-!- JyrkiVesterinen [~JyrkiVest@87-92-25-47.bb.dnainternet.fi] has joined #wesnoth-dev
20161016 18:28:46-!- mjs-de [~mjs-de@x4db5106b.dyn.telefonica.de] has joined #wesnoth-dev
20161016 18:39:33-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 18:39:34< travis-ci> wesnoth/wesnoth#11593 (master - d64d871 : gfgtdf): The build passed.
20161016 18:39:35< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168073659
20161016 18:39:35-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 18:39:51< irker502> wesnoth: Jyrki Vesterinen wesnoth:master 3858b220732f / projectfiles/VC12/ (4 files): Update Visual Studio project https://github.com/wesnoth/wesnoth/commit/3858b220732f8291d85dabe6c4e493218b0bdf97
20161016 18:46:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161016 18:46:51-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 18:49:51-!- gfgtdf [~chatzilla@x4e3694ff.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]]
20161016 18:54:58-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161016 18:55:06-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has quit [Ping timeout: 252 seconds]
20161016 18:56:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161016 18:56:49-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 18:57:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161016 19:02:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 19:07:57-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 19:07:59< travis-ci> wesnoth/wesnoth#11597 (master - ab1b499 : gfgtdf): The build passed.
20161016 19:07:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168083652
20161016 19:07:59-!- travis-ci [~travis-ci@ec2-54-145-160-49.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 19:26:19-!- JyrkiVesterinen [~JyrkiVest@87-92-25-47.bb.dnainternet.fi] has quit [Quit: .]
20161016 19:30:21-!- tad_ [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 19:33:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161016 19:34:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 19:34:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161016 19:34:57-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 19:34:58< travis-ci> wesnoth/wesnoth#11598 (master - 442aec7 : Jyrki Vesterinen): The build passed.
20161016 19:34:59< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168084644
20161016 19:34:59-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 19:40:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 19:41:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161016 19:43:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 19:48:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161016 19:48:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 19:48:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161016 19:53:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 20:00:00-!- travis-ci [~travis-ci@ec2-54-224-164-195.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 20:00:01< travis-ci> wesnoth/wesnoth#11599 (master - c507b78 : Jyrki Vesterinen): The build passed.
20161016 20:00:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168087419
20161016 20:00:01-!- travis-ci [~travis-ci@ec2-54-224-164-195.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 20:08:45-!- gfgtdf [~chatzilla@x4e3694ff.dyn.telefonica.de] has joined #wesnoth-dev
20161016 20:16:47< irker502> wesnoth: gfgtdf wesnoth:master 9d31ae24d2cc / src/units/attack_type.hpp: attempt to fix UB in tutorial start https://github.com/wesnoth/wesnoth/commit/9d31ae24d2cc6efde974104aa9f6408a28220652
20161016 20:20:16< gfgtdf> celticminstrel: both https://gna.org/bugs/?25077 and https://gna.org/bugs/?25083 are causes by leaked atztack_types, please fix this.
20161016 20:23:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161016 20:24:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161016 20:42:58-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161016 21:06:25< tad_> Yeah! I think I'm done with all by branches and will lurk waiting for 1.13.6 to be tagged before forging ahead.
20161016 21:06:40-!- tad_ is now known as tad_carlucci
20161016 21:10:39-!- Bonobo [~Bonobo@2001:44b8:254:3200:7493:5f14:427:878e] has joined #wesnoth-dev
20161016 21:15:14-!- mjs-de [~mjs-de@x4db5106b.dyn.telefonica.de] has quit [Remote host closed the connection]
20161016 21:22:25< matthiakrgr> ufff
20161016 21:28:12< gfgtdf> matthiakrgr: did you test it ?
20161016 21:28:36-!- Bonobo [~Bonobo@2001:44b8:254:3200:7493:5f14:427:878e] has quit [Quit: Leaving]
20161016 21:28:38< matthiakrgr> just commented on a bunch of issues
20161016 21:30:13< gfgtdf> thats nice, thank you :D
20161016 21:44:09< matthiakrgr> thanks for fixes :]
20161016 21:48:45-!- atarocch [~atarocch@93.56.160.28] has quit [Remote host closed the connection]
20161016 21:55:34-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161016 21:56:20-!- tad_ [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 21:56:29-!- tad_ [~lundberg@173.217.65.103] has quit [Client Quit]
20161016 21:56:46-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161016 22:02:59-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has joined #wesnoth-dev
20161016 22:03:00< travis-ci> wesnoth/wesnoth#11604 (master - 9d31ae2 : gfgtdf): The build passed.
20161016 22:03:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/168111888
20161016 22:03:01-!- travis-ci [~travis-ci@ec2-54-224-234-30.compute-1.amazonaws.com] has left #wesnoth-dev []
20161016 22:10:55-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161016 22:13:42-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161016 22:23:35-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161016 22:27:44-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161016 22:33:01-!- louis94 [~~louis94@91.178.241.131] has joined #wesnoth-dev
20161016 22:41:04< matthiakrgr> hm, looks like planned actions are discarded when loading a save? :/ 
20161016 22:43:57< gfgtdf> matthiakrgr: yes afai there is nothign in the savefileformat wml that looks related to planned actions
20161016 22:44:38< matthiakrgr> :< 
20161016 22:52:30-!- gfgtdf [~chatzilla@x4e3694ff.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.1/20160922113459]]
20161016 23:08:30-!- oldlaptop [~quassel@162.247.150.37] has quit [Read error: Connection reset by peer]
20161016 23:08:48-!- oldlaptop [~quassel@162.247.150.37] has joined #wesnoth-dev
20161016 23:15:24-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161016 23:18:43-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 258 seconds]
20161016 23:20:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161016 23:27:45-!- louis94 [~~louis94@91.178.241.131] has quit [Ping timeout: 260 seconds]
20161016 23:37:03-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161016 23:37:09-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161016 23:45:24-!- irker502 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
--- Log closed Mon Oct 17 00:00:10 2016