--- Log opened Sat Oct 22 00:00:07 2016
20161022 00:03:07< tad_carlucci> Sure but I want to get compat working first so UMC doesn't break
20161022 00:04:13< tad_carlucci> Right now I'm trying to figure out why is says "wesnoth.have_unit" is nil
20161022 00:05:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161022 00:06:08-!- karthago [~edgrey@178.204.130.234] has quit [Ping timeout: 244 seconds]
20161022 00:06:50< irker752> wesnoth: Wedge009 wesnoth:master 50146bc509b1 / data/scenario-test.cfg: Avoid division by or modulo of zero in test scenario's maths test (bug #25214) https://github.com/wesnoth/wesnoth/commit/50146bc509b18c9d9b5ab584a45497495af591a0
20161022 00:10:39< tad_carlucci> celticminstrel, How to do [have_unit] in Lua?  It says wesnoth.have_unit is not defined and I didn't see it in helper.
20161022 00:11:24< gfgtdf> tad_carlucci: you cna so #wesnoth.get_units({} ) > 0 or use wesnoth.eval_coditional
20161022 00:11:54< celticminstrel> [have_unit] is ConditionalWML, so it's in wesnoth.wml_conditionals.
20161022 00:12:17< celticminstrel> You can use wesnoth.eval_conditional() and pass the WML table containing the filter.
20161022 00:12:43< celticminstrel> Or you could call wesnoth.wml_conditionals.have_unit as a function. That's pretty much equivalent to eval_conditional though.
20161022 00:14:01< tad_carlucci> testing wml_conditionals as least-effort 
20161022 00:16:12< tad_carlucci> What does '*wfl* (null)' mean? Is wesnoth.wml_conditionals.have_unit using wfl?
20161022 00:17:45< tad_carlucci> Ignoring that message, I can finally play through to the end of the scenario. YEAH
20161022 00:19:17-!- Bonobo [~Bonobo@2001:44b8:254:3200:7c21:2773:dc23:40fd] has quit [Ping timeout: 260 seconds]
20161022 00:19:27-!- Bonobo [~Bonobo@124-169-217-242.dyn.iinet.net.au] has joined #wesnoth-dev
20161022 00:19:55< celticminstrel> tad_carlucci: What caused that?
20161022 00:20:08< celticminstrel> That looks like the message you see when using F to run an AI formula...
20161022 00:20:48< celticminstrel> ie, press F and type null() and press enter, I think that's what you would see.
20161022 00:21:06< tad_carlucci> Near as I can tell: 	if wesnoth.wml_conditionals.have_unit { side = "1,2"} then
20161022 00:21:07< celticminstrel> (Though you'd also see it if you type some random word, probably.)
20161022 00:21:36< celticminstrel> Is it possible that you accidentally invoked the formula console while playing through?
20161022 00:23:01< tad_carlucci> What formula console? Didn't see one. I'll play it again.
20161022 00:23:16< celticminstrel> The one that comes up when pressing F in-game.
20161022 00:23:25< celticminstrel> It looks exactly like the chat or command console.
20161022 00:25:23< irker752> wesnoth: mattsc wesnoth:master cf731dd9239b / data/ai/micro_ais/cas/ca_wolves_move.lua: Wolves Micro AI: fix problem with target unit filtering https://github.com/wesnoth/wesnoth/commit/cf731dd9239bd27dd19d4764545f85fa43167083
20161022 00:25:25< irker752> wesnoth: mattsc wesnoth:master d375321e64a5 / data/ai/micro_ais/cas/ (ca_fast_combat.lua ca_fast_combat_leader.lua): Fast Micro AI: fix behavior with attack_hidden_enemies=yes https://github.com/wesnoth/wesnoth/commit/d375321e64a5a53929dc39f6a279c88753218f9d
20161022 00:25:27< irker752> wesnoth: mattsc wesnoth:master bd1b45e814c3 / data/ai/lua/ai_helper.lua: ai_helper checked actions: move error string into call to error() https://github.com/wesnoth/wesnoth/commit/bd1b45e814c3573bf90da25b27dd85326f58798f
20161022 00:25:29< tad_carlucci> I didn't see it and it didn't recur. So I'm leaving the bug about the audio track for someone else, cleaning up and making a PR.
20161022 00:26:54< gfgtdf> tad_carlucci: did you fix the crash ?
20161022 00:28:30< tad_carlucci> gfgtdf, Yes. I want to do the fix for 5.3.3 in the Lua, then enable compat for a backup so UMC doesn't break. Maybe do a grep to see if any other mainline uses [..index..]
20161022 00:29:53< tad_carlucci> gfgtdf, I has to fix a couple other things to get it working well enough to play to victory/defeat.
20161022 00:30:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161022 00:51:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161022 00:55:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 01:00:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161022 01:08:20< celticminstrel> BTW, what is the second return value from helper.get_child, anyway?
20161022 01:26:43< mattsc> Index of the child
20161022 01:29:27-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161022 01:43:07-!- gfgtdf_ [~chatzilla@x4e363e7a.dyn.telefonica.de] has joined #wesnoth-dev
20161022 01:45:04-!- gfgtdf [~chatzilla@x4e368475.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
20161022 01:45:15-!- gfgtdf_ is now known as gfgtdf
20161022 01:48:11< irker752> wesnoth: Wedge009 wesnoth:master bb436220811a / src/font/text_surface.cpp: Switch to unsigned int for hashes (bug #25079) https://github.com/wesnoth/wesnoth/commit/bb436220811a1f53408c77e180ae4e0f23d5b76c
20161022 01:50:40< tad_carlucci> gfgtdf, matthiaskrgr PR 937 should fix you up.
20161022 01:50:53< tad_carlucci> s/937/837/
20161022 01:56:56< gfgtdf> tad_carlucci: hmm that doenst seem to contain a fix on the c++ side, so i think its still crashes a game when an erros is thown there ?
20161022 01:57:49< tad_carlucci> gfgtdf, The C++ needs to parse indices accepting a float like 12.0 and allowing it as an integer.
20161022 01:58:29< tad_carlucci> gfgtdf, If you know the source file off the top of your head, I can get on that, now.
20161022 01:58:53< tad_carlucci> Otherwise I'll have to search for it.
20161022 01:59:06< gfgtdf> tad_carlucci: eve if the variable is wrong, it shodul usually just give an erros and not crash teh aplication
20161022 02:00:29< tad_carlucci> gfgtdf, Well, I can repeat the work, but skip the fixes and fix the crashes. There's several of them and not all having to do with the bad integer index. It will take a while to fix them all.
20161022 02:00:38< gfgtdf> tad_carlucci: my point is that it the old lua caused a 'heap-buffer-overflow on address 0x6170001c8c70' while it shodul onyl give a printed error. and this is usually an error on the c++ side.
20161022 02:01:39< tad_carlucci> gfgtdf, Probably a buffer overrun in the parser. But I never got a heap overflow. I did get a C++ glibc crash at one point, btw. That may be hard to fix.
20161022 02:02:04< gfgtdf> tad_carlucci: ofc i am still thankful for all those fixes on the 2p_Dark_Forecast.lua fiel in paticular the 'wesnoth.have_unit' and the 'wesnoth.child_range' correction.
20161022 02:03:55< tad_carlucci> The root cause of the crash was the Lua upgrade. So I fixed that. Fixing all the overlows, null references, and a C++ runtime link-list error, caused by the error will take a while. I have to build a test case for each, then find and fix the engine bug. May take a while.
20161022 02:04:39< gfgtdf> tad_carlucci: i do think that the "local configure_gold_factor = 1" sohouldnt go into master liek that, if your wan to workarund the mp create issue, we can set a default valu in lua code with "local configure_gold_factor = ((wesnoth.get_variable("enemey_gold_factor") or 0)+ 100)/100" so that we dsont have to update the scnario again when fixing the gui2 stuff
20161022 02:05:56< tad_carlucci> gfgtdf, OK. I will push that change.
20161022 02:07:36< gfgtdf> tad_carlucci: but i also think we shodul really fix that mp create issue before 1.12.6 sicne it willmake multiple addons unplaable.
20161022 02:08:28< gfgtdf> tad_carlucci: if you still want to know, the code that parsed the numbers in the [] backets is here: https://github.com/wesnoth/wesnoth/blob/master/src/variable_info.cpp#L167
20161022 02:08:32< tad_carlucci> gfgtdf, Isn't that what vultraz is working on? (among other things)
20161022 02:08:46< tad_carlucci> gfgtdf, ty
20161022 02:09:00< gfgtdf> tad_carlucci: assuming you mean the gui2 create, then yes
20161022 02:10:35< tad_carlucci> gfgtdf, I have no idea who is or what it's called but there's no way I could do it without a steep learning curve.
20161022 02:11:15< tad_carlucci> PR 837 updated for 'or 0' as you suggested.
20161022 02:11:34< gfgtdf> tad_carlucci: i just wsnt sure whether 'gfgtdf, Isn't that what vultraz is working on? (among other things)' was an aswer to 'tad_carlucci: but i also think we shodul really fix that mp create issue  ..' or 'tad_carlucci: if you still want to know, the code that parsed the numbers in the [] backets is here ..'
20161022 02:12:00< tad_carlucci> About the UI work.
20161022 02:12:20< tad_carlucci> I will take the parsing issue which this exposed.
20161022 02:13:12< tad_carlucci> And I will work it so I find and fix as many of the other crashes as I can. 9 days until 1.13.6 should be enough. Might take 2 or 3, I'd estimate.
20161022 02:14:28< tad_carlucci> gfgtdf, Assuming, of course, no further Lua issues pull be off. The parsing should be easy to fix and I'll get on it after a coffee break.
20161022 02:22:07< gfgtdf> tad_carlucci: i think for the prsing code, its enough to just all an additional ".0" no need to mess with doubles, so like if(endptr[0] == '.' && endptr[1] == '0') { endptr += 2; } at line 171 there.
20161022 02:22:13< gfgtdf> allow*
20161022 02:23:38< vultraz> hm?
20161022 02:23:42< vultraz> what is this about?
20161022 02:24:19< gfgtdf> vultraz: [options] seem not to work
20161022 02:24:27< gfgtdf> vultraz: in current master
20161022 02:24:29< vultraz> what?? D:
20161022 02:24:32< vultraz> nuuu
20161022 02:25:01< vultraz> not work in what way?
20161022 02:25:12< gfgtdf> vultraz: the variable is not set
20161022 02:25:19< vultraz> hmmm
20161022 02:25:33< vultraz> ok
20161022 02:25:38< gfgtdf> vultraz: you can see that 2p dark forecast crashes in current master
20161022 02:25:48< gfgtdf> vultraz: becasue ithe varible is nil
20161022 02:25:57< vultraz> well feel free to fix it
20161022 02:26:02< vultraz> if you know what's wrong
20161022 02:26:08< gfgtdf> vultraz: no i don't
20161022 02:27:05< gfgtdf> vultraz: tad updated the 2p dark forecast lua code in his pr not to crash in case the options vaible is not set, but still we need to fix [options] before 1.13.6
20161022 02:29:05< gfgtdf> tad_carlucci: can you look whetehr the options variabl is in the savefile of dark forecast game?
20161022 02:29:42< tad_carlucci> 1 min.
20161022 02:29:58< gfgtdf> tad_carlucci: the savegame file should have a [multiplayer][options] tag in it
20161022 02:30:14< gfgtdf> tad_carlucci: the savegame fiel is usually compressed in gz format
20161022 02:30:19 * tad_carlucci nods.
20161022 02:30:53< gfgtdf> tad_carlucci: nods like in 'i understood' or like in 'i found the variable in [options]' ?
20161022 02:32:29< tad_carlucci> 	[options]
20161022 02:32:29< tad_carlucci> 		[multiplayer]
20161022 02:32:29< tad_carlucci> 			id="multiplayer_Aethermaw"
20161022 02:32:29< tad_carlucci> 		[/multiplayer]
20161022 02:32:29< tad_carlucci> 		[era]
20161022 02:32:30< tad_carlucci> 			id="era_default"
20161022 02:32:32< tad_carlucci> 		[/era]
20161022 02:32:36< tad_carlucci> 	[/options]
20161022 02:32:43< tad_carlucci> Is that what you wanted to see?
20161022 02:33:33< tad_carlucci> There was no UI element for the gold factor when I was starting the MP scenario
20161022 02:33:56< gfgtdf> tad_carlucci: really ? did you look in the "custom options" section ?
20161022 02:34:04< tad_carlucci> Looking now
20161022 02:34:48< gfgtdf> tad_carlucci: thx for taht wml seems liek the gold_Variable is not in it.
20161022 02:35:36< tad_carlucci> No there it is. Who would think the look there? Sure, it's jsut a click away but no notice to even look there.  gah
20161022 02:36:28< tad_carlucci> OK. I CHANGED the value and now, it's in inspect.
20161022 02:36:46< tad_carlucci> Retesting without change
20161022 02:38:38< tad_carlucci> There's the bug. If you change it, it's set. If you LOOK at it with the Options tab, it's set. But if you just click Ready it's not set.
20161022 02:39:26< gfgtdf> vultraz: ^
20161022 02:39:50< vultraz> wha
20161022 02:40:13< tad_carlucci> If you don't know to look at the custom options, the defaults are not set in the WML variables.
20161022 02:40:57< vultraz> what?
20161022 02:42:03< tad_carlucci> If you just click I'm Ready without looking at the Custom Options tab, the default value is not stored in a WML variable. LOOK at the tab, even if you don't change the value, and the WML variable now exists.
20161022 02:42:44< vultraz> I see
20161022 02:44:27-!- ancestral [~ancestral@209.181.254.220] has joined #wesnoth-dev
20161022 02:48:34< gfgtdf> tad_carlucci: i wonder, when in teh mp create dialog and you slick on 2p dark forecast then on options, then click on another scenario that doesnt have option, do the options corrently dissaper on the right side panel?
20161022 02:49:57< vultraz> I think I see the problem
20161022 02:50:00< tad_carlucci> gfgtdf, I select the scenario, get a window showing players with tabs to the right I ignored until you pointed them out, and an I'm Ready button at the bottom. So I clicked and tested, never even notices the tabs.
20161022 02:50:08< vultraz> I'm just not sure how to fix it
20161022 02:50:11< vultraz> See
20161022 02:50:33< vultraz> my options manager 'saves' the values of options when you look at them..
20161022 02:50:52< vultraz> need to figure how to do so autonomously 
20161022 02:51:29< tad_carlucci> Add a save when the player/team page first comes up and re-save if they look at the options tab or change a value on it.
20161022 02:51:46< gfgtdf> vultraz: yes, i think we need to recaulcate visible_options_ whnever the mod/era/scnario changes
20161022 02:52:26< vultraz> hmm
20161022 02:52:49< gfgtdf> vultraz: recreating the widgets might be somethign thats better sone lazily though, not sure.
20161022 02:52:50< vultraz> i think right now i only update IF you switch to that tab or something happens when you're on that tab
20161022 02:53:52< gfgtdf> vl you where to find the code for "something happens when you're on that tab" in current master ?
20161022 02:54:30< gfgtdf> vultraz:  nevermond i found
20161022 02:54:31< vultraz> ?
20161022 02:56:56< gfgtdf> maybe just moreving this 'if(i == tab::TAB_OPTIONS) ' https://github.com/wesnoth/wesnoth/blob/master/src/gui/dialogs/multiplayer/mp_create_game.cpp#L467 is enough? (so that update_options_list is always done there)
20161022 02:58:43< gfgtdf> have to go
20161022 02:58:44-!- gfgtdf [~chatzilla@x4e363e7a.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.2/20161019084923]]
20161022 03:05:23< tad_carlucci> The problem as I see it is the Custom Options tab is at the wrong place. It should be on the page where you select the players and such.
20161022 03:05:33< tad_carlucci> And it should be more apparent it's there.
20161022 03:05:37-!- ancestral_ [~ancestral@144.sub-174-219-136.myvzw.com] has joined #wesnoth-dev
20161022 03:06:31< vultraz> I disagree
20161022 03:06:31 * tad_carlucci wonders how it works now. Select a scene, look at it's options, select another scene and start. He thinkgs if you inspect you'll find the wrong options variables.
20161022 03:06:43-!- ancestral [~ancestral@209.181.254.220] has quit [Ping timeout: 245 seconds]
20161022 03:06:44-!- ancestral_ is now known as ancestral
20161022 03:06:46-!- ancestral [~ancestral@144.sub-174-219-136.myvzw.com] has quit [Client Quit]
20161022 03:07:10< vultraz> for various code reasons it's better (or necessary) where it is
20161022 03:09:06-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has joined #wesnoth-dev
20161022 03:09:07-!- esr [~esr@static-71-162-243-5.phlapa.fios.verizon.net] has quit [Changing host]
20161022 03:09:07-!- esr [~esr@wesnoth/developer/esr] has joined #wesnoth-dev
20161022 03:09:23-!- ancestral [~ancestral@144.sub-174-219-136.myvzw.com] has joined #wesnoth-dev
20161022 03:12:15< tad_carlucci> Ah. Well at least that's right. Check Options for the only scene which has them (Dark Forecast) then switch to General and select another scene and the variable is gone.
20161022 03:15:32< vultraz> well that makes sense
20161022 03:15:42< vultraz> since the selected game isn't Dark Forecast anymore
20161022 03:17:12-!- ancestral [~ancestral@144.sub-174-219-136.myvzw.com] has quit [Quit: i go nstuf kthxbai]
20161022 03:17:38< vultraz> i'll see if i can figure something out
20161022 03:40:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 03:44:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161022 03:44:58< celticminstrel> gfgtdf, tad_carlucci: I don't think we should change the variable parsing code to accept .0 on the index.
20161022 03:45:20< celticminstrel> Anyone going to fix the misspelled variable name, BTW?
20161022 03:45:31< celticminstrel> (In Dark Forecast)
20161022 03:46:03< tad_carlucci> celticminstrel, parsing: why not? variable: *shrugs*
20161022 03:47:52< tad_carlucci> 	wesnoth.set_variable("fixed_spawn[" .. spawn_index .. "]") --> 	wesnoth.set_variable("fixed_spawn[3.0]") --> Error: attempting to delete non-existing child: 3[0]
20161022 03:48:48< tad_carlucci> The . is causing it to parse as "fixed_spawn[3"["0"]
20161022 03:49:14< tad_carlucci> or soemthing like that.
20161022 03:49:29< celticminstrel> I think it parses . and [ as equivalent...
20161022 03:49:31< tad_carlucci> So it's more than parsing the .0 as integer.
20161022 03:49:38< celticminstrel> Which isn't good in the first place...
20161022 03:50:39< tad_carlucci> So it's trying to delete fixed_spawn[3][0] or losing the fixed_spawn and trying just 3[0] as the message indicates
20161022 03:51:09< celticminstrel> Well, multidimensional arrays aren't possible in the first place...
20161022 03:51:23< celticminstrel> The variable parser could definitely use some work.
20161022 03:51:27< tad_carlucci> Anyway, it can't be fixed in the index parse because it went wrong before then
20161022 03:51:52< celticminstrel> I think a good start might be not treating . and [ as equivalent...
20161022 03:52:45 * tad_carlucci grabs his computer-voice syntesizer: Sometimes the only winning move is not to play the game.
20161022 03:53:18< tad_carlucci> It's too big a project for 9 days. So it'll have to wait. The fix I have in the PR should avoid the issue.
20161022 03:53:24-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161022 03:55:38< tad_carlucci> There are so many ways to crash the engine. It's definitely a target-rich environment.
20161022 03:57:27< irker752> wesnoth: mattsc wesnoth:master cc6679159b8e / data/ai/lua/ai_helper.lua: ai_helper.robust_move_and_attack: return action result to calling function https://github.com/wesnoth/wesnoth/commit/cc6679159b8eb548d37b10c5ba4dbdba631df5bd
20161022 03:57:29< irker752> wesnoth: mattsc wesnoth:master 93f95f1d4c51 / data/ai/micro_ais/cas/ca_fast_move.lua: Fast Micro AI: better recovery from ambushes etc. https://github.com/wesnoth/wesnoth/commit/93f95f1d4c515009a70b3b262799de3988399f87
20161022 04:04:14< tad_carlucci> celticminstrel, Well, I'm at an impasse, anyway. No idea where to look, no idea what to do about it. Changing the parsing to the extent you're talking about isn't a point-release change. It should wait for 1.14.0
20161022 04:05:54< celticminstrel> I dunno about 1.14.0...
20161022 04:06:06< celticminstrel> But certainly not right now when 1.13.6 is supposedly soon.
20161022 04:06:51-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Remote host closed the connection]
20161022 04:10:18< mattsc> Blargh.
20161022 04:10:46< irker752> wesnoth: mattsc wesnoth:master 1cef83b08a02 / data/ai/lua/ai_helper.lua: ai_helper: fix indentation https://github.com/wesnoth/wesnoth/commit/1cef83b08a02f9fd3ef21158fbe2686278362157
20161022 04:10:51< mattsc> celticminstrel: ^ thanks
20161022 04:16:43-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161022 04:17:36< vultraz> tad_carlucci: http://xkcd.com/1739/
20161022 04:18:18 * tad_carlucci nods.
20161022 04:19:10< tad_carlucci> That's why I'm trying to keep free for Lua issues. I'm happy with the PR. As for the crash, it's been there for a while and, as I say, it's a target-rich environment.
20161022 04:23:20< vultraz> BTW, the 1.13.6 release date is *not* set.
20161022 04:23:39< vultraz> I will evaluate the state of master next week and see what we should do.
20161022 04:24:37-!- Ben24626 [d2564fc3@gateway/web/freenode/ip.210.86.79.195] has joined #wesnoth-dev
20161022 04:27:30< tad_carlucci> My comment on that, vultraz, is it seems like the goalposts are moving away only a bit slower than we're moving toward them.
20161022 04:27:53< vultraz> You would not be wrong.
20161022 04:29:31 * tad_carlucci .oO( feature freeze )
20161022 04:34:22< vultraz> except it's bugfixes we need
20161022 04:37:05-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161022 04:37:16-!- karthago [~edgrey@178.204.130.234] has joined #wesnoth-dev
20161022 04:50:42< tad_carlucci> Well, if we have more like I've done in the past couple of days, that's something I can help with.
20161022 04:51:12< tad_carlucci> The UI issues, all I can do is point 'em out. Too steep a learning curve.
20161022 05:11:05-!- RatArmy [~RatArmy@om126211121177.13.openmobile.ne.jp] has joined #wesnoth-dev
20161022 05:14:32-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-rfdkonskvcclgsqp] has quit [Quit: PanicBNC - https://PanicBNC.net - currently sucks]
20161022 05:16:08-!- skeletenchi [enchilado@gateway/shell/blinkenshell.org/x-czbxifzjlfojptjq] has quit [Changing host]
20161022 05:16:08-!- skeletenchi [enchilado@defocus/yummy/enchilado] has joined #wesnoth-dev
20161022 05:28:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 05:31:27-!- RatArmy [~RatArmy@om126211121177.13.openmobile.ne.jp] has quit [Quit: Leaving]
20161022 05:33:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161022 05:37:00-!- travis-ci [~travis-ci@ec2-54-81-15-201.compute-1.amazonaws.com] has joined #wesnoth-dev
20161022 05:37:01< travis-ci> wesnoth/wesnoth#11696 (master - 1cef83b : mattsc): The build has errored.
20161022 05:37:02< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/169684199
20161022 05:37:02-!- travis-ci [~travis-ci@ec2-54-81-15-201.compute-1.amazonaws.com] has left #wesnoth-dev []
20161022 05:49:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20161022 05:55:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161022 06:09:59< vultraz> tad_carlucci: exactly why it pays to have different programmers who specialize in different areas :)
20161022 06:14:31< tad_carlucci> gmg I'm supposed to specialize?  I wish someone had told me that 40 years ago!
20161022 06:16:01-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161022 06:28:07-!- karthago [~edgrey@178.204.130.234] has quit [Ping timeout: 276 seconds]
20161022 06:29:29< wedge009> So is this one already known, then? https://gna.org/bugs/?25215
20161022 06:30:53< vultraz> ask tad_carlucci 
20161022 06:31:01< tad_carlucci> Nope. Saw it once, could not reproduce it. I'll take a look and see if I can reproduce it.
20161022 06:32:01< tad_carlucci> When you say 'not a problem in Linux', you mean you've only seen it on Windows?
20161022 06:32:49< vultraz> Can reproduce on current master on windows 10
20161022 06:33:20< vultraz> the quit dialog throws cvideo::quit
20161022 06:33:24< tad_carlucci> ok. Well my build host is busy. I'll switch to Windows 10 in a while and start on it.
20161022 06:33:25< vultraz> so it's likely lua is catching this
20161022 06:34:02< tad_carlucci> The message comes from our exception bypass and means it's a catch(...) block.
20161022 06:34:30< vultraz> that message comes from luaW_pcall
20161022 06:34:49< wedge009> tad_carlucci: Only on Windows, trying to do the same in Linux has no obvious issues, no entries in stderr.
20161022 06:34:59< vultraz> hmm
20161022 06:36:17< tad_carlucci> Well, I have seen it, once, on Linux. While researching PR 837
20161022 06:36:32< vultraz> cvideo::quit is only caught in 2 places
20161022 06:36:38< vultraz> main and a gui2 thing
20161022 06:37:19-!- karthago [~edgrey@178.204.130.234] has joined #wesnoth-dev
20161022 06:38:48< vultraz> im guessing lua catches it but cannot handle it
20161022 06:39:04< vultraz> since it inherits from the lua jailbreak stuff
20161022 06:39:31< vultraz> but there's nothing to handle, so it should just fall through to main
20161022 06:39:36< tad_carlucci> Not inherits. IS
20161022 06:39:39< vultraz> ill leave it to you to figure it out
20161022 06:39:58< tad_carlucci> The question is why don't we recognize the exception.
20161022 06:41:49< vultraz> I'm raising this to a blocker
20161022 06:47:23< tad_carlucci> OK but I'll probably clear it tomorrow. I don't expect it'll be hard. Just reclassify it as a known exception.
20161022 06:47:38< tad_carlucci> One I know what it is, of course.
20161022 06:47:44< tad_carlucci> once
20161022 06:48:12-!- karthago [~edgrey@178.204.130.234] has quit [Ping timeout: 256 seconds]
20161022 06:49:12 * tad_carlucci rolls his eyes. My build host is at 80-90% CPU looking like a hair comb, 80% memory and telling me it'll take 20 minutes to finish the job.  *sighs*
20161022 06:52:38< vultraz> New machine, you need!
20161022 06:53:22< tad_carlucci> Nah. Smaller jobs.
20161022 06:53:53< vultraz> I'm trying to figure out how to fix the options problem :/
20161022 06:54:07< vultraz> the internal value save and the ui updates happen at the same time..
20161022 06:54:13< vultraz> wonder if i should decouple that..
20161022 06:54:47< tad_carlucci> Probably
20161022 06:55:28< vultraz> hmmm
20161022 06:56:24< vultraz> (ot but i reaaally wish cel min had not made options display in the order they appear in WML :| )
20161022 06:58:21< vultraz> (it looks.. so... inelegant x_x)
20161022 06:58:34< vultraz> ok, so I think what needs to be done is...
20161022 06:59:10< vultraz> well
20161022 06:59:17< vultraz> no, I don't want to loop twice :/
20161022 06:59:20< vultraz> that's inefficient..
20161022 07:00:48< vultraz> essentially, every time the options are updated, the default values are recorded
20161022 07:00:59< vultraz> and the ui set up..
20161022 07:01:14< vultraz> but if you're not in the options tab, that isn't called
20161022 07:02:32< vultraz> hmmm
20161022 07:02:38< vultraz> perhaps gfgtdf's method is sound..
20161022 07:04:07< vultraz> seems it is
20161022 07:04:37< vultraz> tad_carlucci: you said if you selected Dark Forecast and entered game w/o selecting the Options tab the variable did not appear in Inspect, correct?
20161022 07:06:42< tad_carlucci> correct
20161022 07:07:03-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161022 07:07:35< vultraz> ok, then gfgtdf's suggestion works
20161022 07:07:39< vultraz> however it is inefficient 
20161022 07:07:50< vultraz> because it makes options update every time you select a tab as well
20161022 07:08:02< celticminstrel> ...you're bringing that up again?
20161022 07:08:44< vultraz> yes because it bothers me every time I'm reminded of it :|
20161022 07:09:38 * celticminstrel sighs.
20161022 07:10:06-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161022 07:10:08< vultraz> feel free to ignore me
20161022 07:10:52< vultraz> hm
20161022 07:10:55-!- irker752 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161022 07:11:01< vultraz> I wonder if update_details should not call on_tab_select
20161022 07:11:22< vultraz> eh, I guess it should 
20161022 07:11:24< vultraz> just to be safe
20161022 07:11:29 * celticminstrel has some local changes I should probably push... but it'll have to wait until tomorrow...
20161022 07:11:48< vultraz> so I can either add a force_update parameter to on_tab_selec
20161022 07:11:49< vultraz> t
20161022 07:11:51< vultraz> which is evil
20161022 07:11:59< vultraz> or do something else
20161022 07:12:25< celticminstrel> The tab is initialized in pre_show, right?
20161022 07:12:38< vultraz> iirc
20161022 07:12:40< celticminstrel> And the data from it applied to the create_engine in post_show?
20161022 07:12:44< vultraz> yes
20161022 07:13:02< vultraz> the problem here is no data about a selected game's options is saved if you don't visit the Options tab
20161022 07:13:20< celticminstrel> So apply the defaults to the create_engine in pre_show, maybe.
20161022 07:13:38< vultraz> so I need to figure out how to always save option data when selecting a new game
20161022 07:13:40< celticminstrel> Possibly by manually triggering the callbacks. I dunno.
20161022 07:13:49< celticminstrel> Oh.
20161022 07:13:55< celticminstrel> Good point.
20161022 07:14:10< vultraz> for some reason the gui1 dialog saved the selected options in preferences
20161022 07:14:12< vultraz> no idea why
20161022 07:14:14< celticminstrel> Wait, simply viewing the tab is sufficient?
20161022 07:14:22< celticminstrel> You don't need to actually interact with the controls?
20161022 07:14:25< vultraz> i suppose to save selections?
20161022 07:14:31< vultraz> celticminstrel: correct
20161022 07:14:45< celticminstrel> Then there might be something in the tab select code that needs to be moved to pre_show?
20161022 07:14:48< vultraz> celticminstrel: viewing the tab regenerates the entire tree and the saved data
20161022 07:15:09< celticminstrel> Oh, if you had Dark Forecast already saved as the selected scenario...
20161022 07:15:17< celticminstrel> In that case, can you get away with not selecting the tab?
20161022 07:15:31< vultraz> selecting a game calls update_details -> on_tab_select which updates data from the currently selected tab
20161022 07:15:37< vultraz> s/from/for
20161022 07:15:39< celticminstrel> ie, if Dark Forecast was already selected when you open MP Create
20161022 07:15:55< vultraz> but we want on_game_select to ALWAYS update the options tab
20161022 07:16:01< celticminstrel> Selecting a game should update data from all tabs.
20161022 07:16:17< vultraz> eh?
20161022 07:16:39< celticminstrel> Did I misunderstand what you said?
20161022 07:16:40-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161022 07:16:47< vultraz> oh, hm
20161022 07:16:50< vultraz> I just realized..
20161022 07:16:53< celticminstrel> I can't quite remember what was on each tab...
20161022 07:16:57< vultraz> I already always update tab 3
20161022 07:16:58< vultraz> settings
20161022 07:17:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 07:17:03< celticminstrel> Tab 1 is mods and era...
20161022 07:17:05< vultraz> even on tab select
20161022 07:17:09< celticminstrel> Tab 2 is... game settings...
20161022 07:17:15< celticminstrel> Tab 3 is custom settings.
20161022 07:17:16< vultraz> no, tab 2 is options
20161022 07:17:23< celticminstrel> Yeah, game settings.
20161022 07:17:23< vultraz> tab 3 is game settings
20161022 07:17:27< celticminstrel> ...
20161022 07:17:29< vultraz> i already always update tab 3...
20161022 07:17:35< celticminstrel> I think we're just using different terms for the same thing,
20161022 07:17:41< celticminstrel> I mean things like income and such.
20161022 07:17:52< vultraz> ok, so I think I need to make a new function..
20161022 07:18:08< celticminstrel> So maybe the issue isn't about whether the tab is updated?
20161022 07:18:11-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161022 07:18:56< vultraz> on_tab_select is just supposed to switch to and update the contents of the currently viewed tab
20161022 07:19:15< vultraz> but on game select needs to always update tabs 2 and 3
20161022 07:19:22< celticminstrel> I don't think that should be the responsibility of on_tab_select.
20161022 07:19:37< tad_carlucci> and implicit game select on first load
20161022 07:19:53< vultraz> that's already done
20161022 07:19:56< celticminstrel> Any time one tab needs updating, you should update all of them.
20161022 07:20:01< vultraz> what?
20161022 07:20:04< celticminstrel> (Well, tab 1 might never need updating though.)
20161022 07:20:10< vultraz> tab 1 does need updating
20161022 07:20:24< celticminstrel> Does it? If you say so. I don't remember what's there besides mods and eras.
20161022 07:20:30< vultraz> eras, yes
20161022 07:20:33< celticminstrel> Oh but I guess if the selected era is not allowed for the scenario...
20161022 07:20:38< vultraz> yes
20161022 07:20:42< vultraz> well, basically
20161022 07:20:47< celticminstrel> ...actually, what do you do if that happens?
20161022 07:21:02< celticminstrel> Just autoselect the first/next allowed one?
20161022 07:21:14< vultraz> if no eras are available for the currently selected game, i disable the box and notify 
20161022 07:21:21< celticminstrel> Disable what?
20161022 07:21:25< vultraz> the era menu button
20161022 07:21:31< celticminstrel> But I wasn't asking about if no eras are available.
20161022 07:21:32< vultraz> if the currently selected era is not valid..
20161022 07:21:32-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has joined #wesnoth-dev
20161022 07:21:34< vultraz> then uh..
20161022 07:21:40< vultraz> the dependency manager should deal with that..
20161022 07:22:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 276 seconds]
20161022 07:22:42< vultraz> ughh
20161022 07:22:48< vultraz> ok, so
20161022 07:22:55< vultraz> tab 1 *can* only be updated if you're looking at it
20161022 07:23:10< vultraz> tabs 2 and 3 can be updated even if you're not
20161022 07:23:20< vultraz> tabs 2 and 3 should always be updated when selecting a game
20161022 07:23:46< vultraz> ok, perhaps a force parameter isn't that bad after all 
20161022 07:24:03< celticminstrel> I dunno.
20161022 07:24:36< vultraz> so, on_game_select would pass that parameter (which would be default false) as true, meaning tabs 2 and 3 would always be updated
20161022 07:24:52< vultraz> then, in tab selection mode, only the newly visible tab would be updated
20161022 07:25:06< celticminstrel> But wait.
20161022 07:25:19< celticminstrel> Why does the tab need to be updated in tab selection mode if it has already been updated by game select?
20161022 07:25:36< vultraz> ...ah... you're right!
20161022 07:25:47< celticminstrel> I don't think there should be any need for on_tab_select to update any data.
20161022 07:25:54< vultraz> well, except tab 1 :/
20161022 07:25:56< vultraz> tab 1 is a problem
20161022 07:26:04< celticminstrel> It's not like the data in the tabs goes away when they're hidden.
20161022 07:26:09< celticminstrel> Why is tab 1 a problem?
20161022 07:26:24< vultraz> tmenu_button& era_combo = find_widget<tmenu_button>(&window, "eras", false);
20161022 07:26:43< vultraz> unless..
20161022 07:26:52< celticminstrel> That doesn't answer my question...
20161022 07:27:13< vultraz> celticminstrel: if that layer is not visible in the stacked_widget the find_widget call will fail
20161022 07:27:17< vultraz> however
20161022 07:27:23< vultraz> if stacked_widget has a way to query a layer..
20161022 07:27:23< celticminstrel> You can easily work around that.
20161022 07:27:37< celticminstrel> Does it?
20161022 07:27:38< vultraz> AH!
20161022 07:27:39< vultraz> get_layer_grid
20161022 07:27:41< vultraz> this exists
20161022 07:27:55< celticminstrel> I was going to say "set all layers visible, search, then set the selected one visible".
20161022 07:28:00< vultraz> no no no no no
20161022 07:28:05< celticminstrel> Similar to what's done in post_show (but with an extra step).
20161022 07:28:14< tad_carlucci> Oh now THAT is a cool issue. Click the X to close, message on the game screen, nothing on --wconsole, and it's like you just hit space to go to the next step of the conversation.
20161022 07:28:18< celticminstrel> I'm not sure I can recommend get_layer_grid.
20161022 07:28:20< vultraz> you do realize the user would see that right
20161022 07:28:40< celticminstrel> I think that could be prevented.
20161022 07:28:44< celticminstrel> Not entirely sure though.
20161022 07:28:46< vultraz> not cleanly
20161022 07:28:50< vultraz> get_layer_grid is fine
20161022 07:29:02< vultraz> let's see if this works
20161022 07:29:10< vultraz> if it does it's actually a performance gain :D
20161022 07:29:19< celticminstrel> Anyway, the problem with get_layer_grid might not apply in this specific case, but... assuming which layer a control is on is not a great idea.
20161022 07:29:35< celticminstrel> It might be on a different layer depending on the resolution.
20161022 07:29:48< celticminstrel> Or it might not even be in the stacked widget at all on some resolutions.
20161022 07:29:49< vultraz> bad design
20161022 07:29:51< vultraz> if that's the case
20161022 07:29:54< tad_carlucci> So, do it again .. long wait .. boom .. "Windows is searching for a solution."
20161022 07:30:00< celticminstrel> What's bad design?
20161022 07:30:12< vultraz> if it's on a different layer
20161022 07:30:17< celticminstrel> I'm pretty sure the whole point of find_widget is specifically to support that sort of thing.
20161022 07:30:38< vultraz> I suppose i could keep a pointer in the dialog class but I hate having to do that
20161022 07:30:41< celticminstrel> To make the implementation largely independent of how the layout works.
20161022 07:31:18< vultraz> yes, but find_widget only works on *visible* widgets
20161022 07:31:20< vultraz> :|
20161022 07:31:24< celticminstrel> In theory you should be able to rework the layhout however you want with zero code changes.
20161022 07:31:26-!- Ben24626 [d2564fc3@gateway/web/freenode/ip.210.86.79.195] has quit [Ping timeout: 260 seconds]
20161022 07:31:41< vultraz> yeah, well that goes out the window with tabs
20161022 07:31:42< celticminstrel> Does find_widget work on widgets that are hidden or invisible (with set_visibility or whatever)
20161022 07:31:43< celticminstrel> ?
20161022 07:31:47< vultraz> no idea
20161022 07:31:50< celticminstrel> ^layout
20161022 07:31:51< vultraz> likely not if invisible
20161022 07:31:54< tad_carlucci> I need to write a replacement for that. "Windows has found a solution." "Click OK to install Linux."
20161022 07:31:57< celticminstrel> I suspect it does...
20161022 07:32:08< celticminstrel> But I think maybe the problem here is specifically in stacked_widget.
20161022 07:32:17< vultraz> well, that's a different thing
20161022 07:32:18< celticminstrel> Why does stacked_widget only search the visible layer in the first place?
20161022 07:32:22< vultraz> no idea
20161022 07:32:41< vultraz> if you want to update its find method, go ahead
20161022 07:32:41 * celticminstrel prods at shadowm since IIRC he implemented the ability for it to only show one layer.
20161022 07:32:45-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161022 07:32:46< vultraz> but that's not the issue right now
20161022 07:32:57< vultraz> right now the code assumes the era box is on layer 1
20161022 07:33:02< vultraz> so there will be no change
20161022 07:33:10< vultraz> whether that's good or not can be debated later
20161022 07:33:16< celticminstrel> Well, whatever.
20161022 07:33:16< vultraz> I'm going to fix this bug
20161022 07:39:55-!- celticminstrel is now known as celmin|sleep
20161022 07:51:43-!- irker109 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161022 07:51:43< irker109> wesnoth: Charles Dang wesnoth:master 80115b11faa3 / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_create_game.hpp): MP Create Game: delegate tab content updates to game selection https://github.com/wesnoth/wesnoth/commit/80115b11faa30710f2f43a893da8ec4da5734a9c
20161022 07:51:49< vultraz> tad_carlucci, gfgtaf: ^ should fix the issue 
20161022 07:51:53< vultraz> gfgtdf*
20161022 07:52:18< vultraz> and thanks to celmin|sleep, it also solves a performance issue i had been worried about :D
20161022 07:52:38< tad_carlucci> kk
20161022 07:53:00< vultraz> (for reference, before, the tab contents would be updated every time you switched to that tab :| )
20161022 08:07:28-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161022 08:18:31-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Ping timeout: 244 seconds]
20161022 08:19:15-!- boucman_work [~boucman@2a02-8428-034f-f800-fb79-8bd8-8af4-11f1.rev.sfr.net] has joined #wesnoth-dev
20161022 08:23:43-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161022 08:30:47-!- travis-ci [~travis-ci@ec2-54-158-41-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161022 08:30:48< travis-ci> wesnoth/wesnoth#11697 (master - 80115b1 : Charles Dang): The build passed.
20161022 08:30:48< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/169699223
20161022 08:30:48-!- travis-ci [~travis-ci@ec2-54-158-41-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161022 08:31:20-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161022 08:40:08-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161022 08:41:14< tad_carlucci> vultraz, On that unknown exception bug: it ONLY occurs when you close the windows with the message panel open. Other panels like objectives do not show the error.
20161022 08:41:25< vultraz> interesting
20161022 08:41:30< tad_carlucci> And, it behaves like you pressed space
20161022 08:41:52< tad_carlucci> Plus, if that opens another message panel, the program crashes hard
20161022 08:42:17< tad_carlucci> That is, close X again^
20161022 08:42:38< tad_carlucci> But, if no panel is up and you close, it closes normally.
20161022 08:43:05< tad_carlucci> So I'm thinking the Lua unknown exception message is probably always been there and the issue is the message panel.
20161022 08:43:43< tad_carlucci> I need to go to bed. I'll look at it more tomorrow. But maybe you'll see something about the message panel or can have celmin look?
20161022 08:44:20< tad_carlucci> And it is a CVideo exception, derrives from our jailbreak.
20161022 08:44:41-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161022 08:53:31-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 09:05:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 09:09:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161022 09:13:05-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-pifwupgxfraadajv] has joined #wesnoth-dev
20161022 09:13:28-!- matthiaskrgr is now known as Guest18392
20161022 09:18:56< vultraz> I wonder if c++17 fixes the need to use namespace foo {} to forward-declare a namespace class outside of said namespace.
20161022 09:19:37< vultraz> ie, class space::foo; instead of namespace space { class foo; }
20161022 09:21:24-!- mjs-de [~mjs-de@x4e31f691.dyn.telefonica.de] has joined #wesnoth-dev
20161022 09:30:29-!- Guest18392 [matthiaskr@gateway/shell/panicbnc/x-pifwupgxfraadajv] has quit [Changing host]
20161022 09:30:29-!- Guest18392 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161022 09:30:29-!- Guest18392 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20161022 09:30:29-!- Guest18392 [matthiaskr@gateway/shell/panicbnc/x-pifwupgxfraadajv] has joined #wesnoth-dev
20161022 09:30:33-!- Guest18392 is now known as matthiaskgr
20161022 09:51:42-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has quit [Ping timeout: 250 seconds]
20161022 09:52:53-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161022 09:53:51-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161022 09:57:20< irker109> wesnoth: Charles Dang wesnoth:master 374eb2ecb791 / src/sdl/ (rect.cpp rect.hpp): Added an override for point_in_rect that takes a tpoint argument https://github.com/wesnoth/wesnoth/commit/374eb2ecb79145744d5f0c7d8805b27992ed2437
20161022 09:57:23< irker109> wesnoth: Charles Dang wesnoth:master 2e982c0824a8 / src/gui/widgets/scrollbar_container.hpp: Scrollbar Container: added some member getters https://github.com/wesnoth/wesnoth/commit/2e982c0824a8b30b6ce50d002294e302e7bf3cb2
20161022 09:57:26< irker109> wesnoth: Charles Dang wesnoth:master 4595e8d3740f / src/gui/widgets/scrollbar.hpp: Scrollbar: made tstate enum public https://github.com/wesnoth/wesnoth/commit/4595e8d3740f56c65810875d8df0a349058bc652
20161022 09:57:29< irker109> wesnoth: Charles Dang wesnoth:master 632c86714436 / src/gui/dialogs/drop_down_list.cpp: Drop Down List: fixed dialog closing when scrolling with scrollbar (bug #25195) https://github.com/wesnoth/wesnoth/commit/632c8671443637d2750cdd5060ec1d3b084b324d
20161022 09:57:32< irker109> wesnoth: Charles Dang wesnoth:master 098f1a15aa40 / src/gui/dialogs/drop_down_list.cpp: Drop Down List: minor code simplification https://github.com/wesnoth/wesnoth/commit/098f1a15aa409beb4546c3fd9503b66c4044db0d
20161022 10:13:07-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161022 10:13:13-!- Bonobo [~Bonobo@124-169-217-242.dyn.iinet.net.au] has quit [Ping timeout: 250 seconds]
20161022 10:13:32-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Read error: No route to host]
20161022 10:18:14-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 252 seconds]
20161022 10:20:46-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161022 10:26:32-!- Bonobo [~Bonobo@2001:44b8:254:3200:edcf:b854:96eb:17d1] has joined #wesnoth-dev
20161022 10:27:40-!- mkdr0id [~null@unaffiliated/matthiaskrgr] has quit [Ping timeout: 250 seconds]
20161022 10:39:41< irker109> wesnoth: Charles Dang wesnoth:master c2e6fda94c01 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create Game: don't update tab contents when regenerating random maps https://github.com/wesnoth/wesnoth/commit/c2e6fda94c01357cc9605f720e1443c57942498a
20161022 10:53:38-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 10:57:58-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20161022 10:59:59-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161022 11:02:43-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 11:03:24-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 11:04:28-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 11:13:55-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 11:18:37-!- karthago [~edgrey@178.205.0.69] has joined #wesnoth-dev
20161022 11:34:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161022 11:36:57-!- gfgtdf [~chatzilla@x4e363e7a.dyn.telefonica.de] has joined #wesnoth-dev
20161022 11:37:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 11:38:33< gfgtdf> vultraz: you recent commitmessage sounds like the options are onyl regerneated whena  new game is selected, note that eras and mdfications also contains options
20161022 11:38:46< gfgtdf> vultraz: it they also need to be updated when eras /mods are toggeled
20161022 11:38:53< vultraz> .....ah....
20161022 11:39:00< vultraz> i totally forgot about that :|
20161022 11:39:21< vultraz> fix should be simple though
20161022 11:41:21< irker109> wesnoth: Charles Dang wesnoth:master afc90a03cf93 / src/gui/dialogs/multiplayer/mp_create_game.cpp: MP Create Game: also update options on mod or era select https://github.com/wesnoth/wesnoth/commit/afc90a03cf9303d68651518655c93d14a7c631f6
20161022 11:41:23< vultraz> gfgtdf: ^
20161022 11:41:38< gfgtdf> vultraz:  ok thy
20161022 11:47:32< wedge009> Is tpoint supposed to be a class or struct? Getting compiler complaints about it.
20161022 11:48:38< wedge009> Oh I see. It's defined as class in rect.hpp but struct in dispatcher.hpp.
20161022 11:48:40< gfgtdf> wedge009: i'd say struct
20161022 11:49:50< wedge009> Oh I see, vultraz added class tpoint to rect.hpp recently.
20161022 11:50:03< vultraz> ah
20161022 11:50:11< vultraz> sorry, I didn't check it's declaration
20161022 11:51:19-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 11:51:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 11:52:04-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 11:52:18-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 11:55:09-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 11:55:13< vultraz> wedge009: should i fix it or will you?
20161022 11:59:11< wedge009> vultraz: I'll do it. Just checked recompilation.
20161022 12:00:09< irker109> wesnoth: Wedge009 wesnoth:master 2d75dff147c4 / src/sdl/rect.hpp: Correct gui2::tpoint type. https://github.com/wesnoth/wesnoth/commit/2d75dff147c4c99663f4e1da0958f49b00b92437
20161022 12:06:01-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161022 12:06:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161022 12:11:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161022 12:11:44< matthiaskgr> wedge009: 
20161022 12:11:50< matthiaskgr> >Where else does this happen?
20161022 12:11:56< matthiaskgr> I thought this was implied by your previous comment
20161022 12:12:04< matthiaskgr> >Had a super-long work day yesterday so only looked at this just now. Turns out
20161022 12:12:07< matthiaskgr> a similar function is in builder.cpp and uses an unsigned int.
20161022 12:13:06< wedge009> matthiaskgr: Are you saying you're still getting problems with that one even though it already uses an unsigned int?
20161022 12:13:12< matthiaskgr> no
20161022 12:13:13-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161022 12:14:59-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20161022 12:28:13-!- louis94 [~~louis94@91.178.241.19] has quit [Ping timeout: 276 seconds]
20161022 12:32:00< irker109> wesnoth: Wedge009 wesnoth:master 749123d0bb08 / data/scenario-test.cfg: Change to numerical equality check (though it doesn't seem to help in situations https://github.com/wesnoth/wesnoth/commit/749123d0bb08dce8a1f304d29003a3a2e998d34d
20161022 12:38:15< gfgtdf> wedge009: actuall i woudln't think there is a reason to 'fix' this test scnsario, providing a way to rpdepuce a crash is something that a test scneario can be used for.
20161022 12:38:26< wedge009> Is there a way to evaluate a WML variable before checking its value?
20161022 12:38:33< wedge009> I wouldn't have thought so either.
20161022 12:42:02-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Remote host closed the connection]
20161022 12:43:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Remote host closed the connection]
20161022 12:43:02< gfgtdf> matthiaskgr: online ?
20161022 12:43:44-!- Bonobo [~Bonobo@2001:44b8:254:3200:edcf:b854:96eb:17d1] has quit [Quit: Leaving]
20161022 12:47:20< irker109> wesnoth: gfgtdf wesnoth:gfgtdf-patch-1 de96f8c04269 / src/scripting/lua_common.cpp: asdfg https://github.com/wesnoth/wesnoth/commit/de96f8c042698f7e73389c0bfe13173c067618f6
20161022 12:48:01< gfgtdf> wedge009: coudl you test if this patch https://github.com/wesnoth/wesnoth/commit/de96f8c042698f7e73389c0bfe13173c067618f6 fixes the crash in case that of simethign liek 'x- x' ?
20161022 12:57:59< matthiaskgr> it's compiling™
20161022 12:58:42-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20161022 13:00:04< gfgtdf> matthiaskgr: coudl you please test the commti i meantioned above  (not yet in master) ?
20161022 13:00:47< matthiaskgr> yes
20161022 13:00:57< matthiaskgr> building right now
20161022 13:01:00< irker109> wesnoth: Charles Dang wesnoth:master 71bc3f356ba8 / data/gui/ (macros/_initial.cfg window/file_dialog.cfg): Added GUI_WINDOW_FIXED_SIZE_CENTERED macro https://github.com/wesnoth/wesnoth/commit/71bc3f356ba8a0b7a8b922d5f4290fdb2d1957cb
20161022 13:01:22< matthiaskgr> but i have to leave in a couple of mins, so not sure if build is fast enoguh
20161022 13:03:20-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 256 seconds]
20161022 13:04:29< gfgtdf> matthiaskgr: ok thx
20161022 13:07:40-!- Appleman1234_ [~Appleman1@KD106181178136.au-net.ne.jp] has joined #wesnoth-dev
20161022 13:07:43< irker109> wesnoth: Charles Dang wesnoth:master 06570d093ee9 / data/gui/macros/_initial.cfg: Removed 'draw outline around widget' stuff https://github.com/wesnoth/wesnoth/commit/06570d093ee948ec8192ce1b3edfc67fceda91e1
20161022 13:08:38-!- Appleman1234 [~Appleman1@KD106181173238.au-net.ne.jp] has quit [Disconnected by services]
20161022 13:08:44-!- Appleman1234_ is now known as Appleman1234
20161022 13:12:40-!- mjs-de [~mjs-de@x4e31f691.dyn.telefonica.de] has quit [Remote host closed the connection]
20161022 13:16:53-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20161022 13:20:03< wedge009> gfgtdf: Yes, it looks like that allows Lua to catch the division by zero instead of making Wesnoth crash.
20161022 13:20:19< wedge009> Can revert my changes, then, if you want.
20161022 13:21:00-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161022 13:21:17< vultraz> would rather you leave it
20161022 13:21:28< wedge009> Cool.
20161022 13:24:37< wedge009> matthiaskgr: gfgtdf: I checked both division and modulo. Both have nice error message rather than a crash.
20161022 13:28:07< irker109> wesnoth: gfgtdf wesnoth:master 806a388b9d39 / src/scripting/lua_common.cpp: fix lua crashing after an lua error https://github.com/wesnoth/wesnoth/commit/806a388b9d39707fa293b6747598d04bf2633a36
20161022 13:35:44< irker109> wesnoth: Charles Dang wesnoth:master 80881de36902 / data/gui/window/ (game_load.cfg preferences.cfg): Made Preferences and Game Load windows fixed-size https://github.com/wesnoth/wesnoth/commit/80881de369028a2761efb1a1aea2580900f7d57c
20161022 13:37:11< vultraz> We've had multiple complaints about Load not being fixed-size.. well, now it is :D
20161022 13:37:19< vultraz> tad ^ (if you read logs)
20161022 13:38:00< gfgtdf> vultraz: does the gui2 creategame dialog remember the [options] values in orefrences liek the gui1 version does? Its not a blocker for 1.13.6 if it doewsn't but it's somethign we shodul fix at some point
20161022 13:38:12< vultraz> gfgtdf: it does not
20161022 13:38:52< vultraz> I could make it do so
20161022 13:39:27< gfgtdf> vultraz: woudl be nice
20161022 13:39:48< irker109> wesnoth: Charles Dang wesnoth:master d54f440cb97b / data/gui/window/game_load.cfg: Game Load: use small label for leader name https://github.com/wesnoth/wesnoth/commit/d54f440cb97be0f0c3cbb63485b1c9ff599be658
20161022 13:43:41-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161022 13:46:42-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161022 13:46:55-!- Shiki is now known as shiki|sevu
20161022 13:56:03-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 13:57:09-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 14:01:35-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 14:02:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 14:07:18< irker109> wesnoth: Charles Dang wesnoth:master 2967fdbe1957 / src/gui/dialogs/multiplayer/ (mp_create_game.cpp mp_options_helper.cpp): MP Create Game: save selected option values in prfes https://github.com/wesnoth/wesnoth/commit/2967fdbe1957cf326c051242f0e981a9fe937482
20161022 14:07:20< vultraz> gfgtdf: ^
20161022 14:11:23< gfgtdf> vultraz: i'm not sure it'll work like this, note that curently 'set_options' overwrited the options completeley and that get_options_config(); onyl returns the options loaded for th currnet game
20161022 14:11:35< gfgtdf> vultraz: so it'dd rmeove teh saves options that are not used n the curent game
20161022 14:11:48< vultraz> hmmmmm
20161022 14:11:50< vultraz> true, true..
20161022 14:11:59< vultraz> how would you recommend it be done?
20161022 14:12:22< gfgtdf> vultraz: i think this needs a change in the prefs::set_options impleentation, that it doesnt overwite them ompleles and onyl changes the passed options
20161022 14:14:43-!- shiki|sevu [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161022 14:17:40-!- Duthlet [~Duthlet@dslb-188-104-253-155.188.104.pools.vodafone-ip.de] has quit [Ping timeout: 252 seconds]
20161022 14:18:46< irker109> wesnoth: Charles Dang wesnoth:master 6826e112f0f6 / src/gui/dialogs/multiplayer/mp_options_helper.cpp: MP Options Helper: skip any game, era, or mod with no [options] subtag https://github.com/wesnoth/wesnoth/commit/6826e112f0f69032a4276a8d4a8c370a46015035
20161022 14:19:56< vultraz> gfgtdf: could you maybe do that
20161022 14:20:29-!- celmin|sleep is now known as celticminstrel
20161022 14:20:29-!- yaiyan is now known as Yaiyan
20161022 14:22:45< gfgtdf> vultraz: hmm i i think its easier to delay this to after 1.12.6 when we remove the gui1 version, so that we can chang change the [options]s torage in savefilewml/prefernves to just key=value format, so that that becomses just a config.merge call.
20161022 14:23:03< vultraz> hm ok
20161022 14:23:11< vultraz> I'll leave it as it is right now
20161022 14:23:15< vultraz> it's nothing major
20161022 14:24:14< irker109> wesnoth: Celtic Minstrel wesnoth:master 205aafc832d8 / src/scripting/lua_kernel_base.cpp: Minor improvement to Lua error messages https://github.com/wesnoth/wesnoth/commit/205aafc832d876fe3ffd7d07844775e42031f1dc
20161022 14:25:23< vultraz> celticminstrel: do you have any opinion on making all tstate enums public?
20161022 14:26:15-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161022 14:26:17< gfgtdf> vultraz: why soudl you want that ?
20161022 14:26:18-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161022 14:26:20< gfgtdf> would*
20161022 14:26:45< vultraz> gfgtdf: see commit message here https://github.com/wesnoth/wesnoth/commit/4595e8d3740f56c65810875d8df0a349058bc652
20161022 14:27:03< celticminstrel> No opinion, though I don't think it's as necessary as you believe.
20161022 14:27:21< celticminstrel> gfgtdf: You mean 1.13.6
20161022 14:27:22< gfgtdf> vultraz: ok, why shodul get_state() be public 
20161022 14:27:29< gfgtdf> celticminstrel: yes i meant 1.13.6
20161022 14:27:40< vultraz> gfgtdf: well it's useful
20161022 14:27:49< vultraz> no reason for it to be private
20161022 14:27:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161022 14:28:10< vultraz> rather stupid to have a getter function for your own private member :P
20161022 14:28:16< gfgtdf> vultraz: well its usualyl petter not to expose internal things unless you ned them.
20161022 14:28:34< gfgtdf> vultraz: do you use it seom heere where it needs to be public ?
20161022 14:28:39< gfgtdf> somehere*
20161022 14:28:42< vultraz> gfgtdf: i needed it int his case https://github.com/wesnoth/wesnoth/commit/632c8671443637d2750cdd5060ec1d3b084b324d
20161022 14:28:59< vultraz> so far that's the only case it's needed
20161022 14:29:03< vultraz> so maybe i'll leave it for now
20161022 14:35:20-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161022 14:40:45< vultraz> celticminstrel: could you possibly look into why this was introduced? https://gna.org/bugs/?25173
20161022 14:46:14-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 14:47:20-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161022 14:48:21< celticminstrel> vultraz: How is that a feature?
20161022 14:48:42< vultraz> celticminstrel: i simply meant it's deliberately done
20161022 14:48:45< vultraz> for some reason
20161022 14:48:47< celticminstrel> And why would you need to check label to prevent the text_input from displaying in every message?
20161022 14:49:00< celticminstrel> Did you look at the Lua code or the C++ code BTW?
20161022 14:49:05< vultraz> both
20161022 14:49:15< celticminstrel> Which one is relevant here?
20161022 14:49:22< vultraz> if i remove that check a text input field displays in every message
20161022 14:49:24< vultraz> c++
20161022 14:50:27< vultraz> there's a line that's something like if(!cfg.caption.empty()) { insert text box }
20161022 14:50:38< vultraz> in the dialog's c++ file i think
20161022 14:52:00< celticminstrel> I'm not seeing it...
20161022 14:52:44< celticminstrel> Oh, found it.
20161022 14:52:54< vultraz> wml_message.cpp:179
20161022 14:52:58-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 14:53:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 14:53:57< celticminstrel> Well, I suppose you could add a boolean if you really wanted.
20161022 14:54:10< celticminstrel> You could also just do something like label=" "
20161022 14:54:29-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161022 14:54:30< celticminstrel> (I mean a boolean in the paramater pack struct.)
20161022 14:55:11< vultraz> well, up to you
20161022 14:55:18< vultraz> [message] is your responsibility 
20161022 14:56:40-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 14:59:03-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161022 15:00:49-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 15:04:15-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161022 15:04:41-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 15:26:16-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161022 15:27:13-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 15:30:14-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161022 15:31:17-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 15:34:21-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161022 15:35:45-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 15:36:09-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Client Quit]
20161022 15:38:10-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161022 16:02:52-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161022 16:10:04< tad_carlucci> wedge009, vultraz gfgtdf https://gna.org/bugs/?25215 closed by https://github.com/wesnoth/wesnoth/commit/806a388b9d39707fa293b6747598d04bf2633a36 as well
20161022 16:10:22< vultraz> whut
20161022 16:10:25< vultraz> well then
20161022 16:11:02-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161022 16:11:02< tad_carlucci> Funny how much better stuff works when you fix the stack corruption.
20161022 16:11:28< vultraz> except I still seem to be seeing it here :|
20161022 16:12:20< tad_carlucci> I just synced and rebuild and cannot see it here. I'll test some more, I guess.
20161022 16:15:41-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has joined #wesnoth-dev
20161022 16:18:15< tad_carlucci> Nope, cannot reproduce it after this morning's build. No message on screen, no crashes, just closes when you click the X.
20161022 16:20:09-!- louis94 [~~louis94@91.178.241.19] has quit [Ping timeout: 260 seconds]
20161022 16:20:36< vultraz> Oh, for the use of generic lambdas :(
20161022 16:21:29< tad_carlucci> if (wishes == horsed) { beggars = kings };
20161022 16:21:55< vultraz> heh
20161022 16:22:28< vultraz> I shall just have to wrap this in a #ifdef HAVE_CXX14
20161022 16:23:04 * tad_carlucci waits for the fireworks that idea causes
20161022 16:25:52< gfgtdf> tad_carlucci: are you sue its closed by that? note that wedge said it onyl happens on some on his builds so even if you couldnt reprpduce it it doesnt mean its fixred
20161022 16:26:23< gfgtdf> wedge009: please test https://gna.org/bugs/index.php?25215
20161022 16:26:46< tad_carlucci> gfgtdf, All I know is I build with it and no crash, I'll revert it and rebuild and see what happens.
20161022 16:27:05< tad_carlucci> But Iexpect fixing the stack problem fixes myriad problems
20161022 16:27:24< gfgtdf> tad_carlucci: to me #25215 soudns liek someone is fron the with lia rethor exception thing, i mreans the spanon is not 'wesntoh crashed' its 'lua ctaches errors that it shodultn catch'
20161022 16:28:09< gfgtdf> something is wrong with the lua rethow exception*
20161022 16:28:15< tad_carlucci> If you click once it hung, click again it crashed
20161022 16:28:35< tad_carlucci> And ONLY when doing video from a lua call to c++ like [message]
20161022 16:28:59< tad_carlucci> The message on screen is gone and it closes right away now
20161022 16:29:15< gfgtdf> tad_carlucci: well makred is as 'ready to test'
20161022 16:29:33< gfgtdf> tad_carlucci: so wedge009 can check whetehr its fixed to him
20161022 16:29:56< tad_carlucci> I'll do more digging while I'm still on windows
20161022 16:32:27< vultraz> hm, perhaps I misunderstand this..
20161022 16:32:51< gfgtdf> vultraz: does exitign the game whele showing a [message] wokr for you in current master ?
20161022 16:32:59< gfgtdf> exiting*
20161022 16:32:59< vultraz> no
20161022 16:33:14< gfgtdf> vultraz: by presng the rex corner in the crossof the window i mean
20161022 16:33:22< vultraz> yeah, doesn't work
20161022 16:33:57< gfgtdf> vultraz: and you get the same erromessage as noted in that bugerport ?
20161022 16:34:03< vultraz> yeah
20161022 16:34:27< tad_carlucci> Go to the next [message[ and try a second time, does the game crash?
20161022 16:35:57< vultraz> doesn't quit
20161022 16:35:59< vultraz> either
20161022 16:37:18-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161022 16:37:23< gfgtdf> vultraz: are you sure that you have the wesnoth_lua_config.h in yoru proectfiles ?
20161022 16:37:33< vultraz> yes
20161022 16:37:59< gfgtdf> tad_carlucci: and it quites succefully to you ?
20161022 16:38:22< gfgtdf> quits*
20161022 16:38:25< tad_carlucci> Yes. I'm starting a fresh campaign and retesting. HttT S01 has a series of [messages]
20161022 16:38:53< gfgtdf> vultraz: can you please try inserting #error "asdf" at https://github.com/wesnoth/wesnoth/blob/master/src/lua/ldo.cpp#L56 and see if it complies ?
20161022 16:39:33< vultraz> it does not
20161022 16:40:00< gfgtdf> vultraz: then its bas, if wesnoth_lua_config.h were succesfulyl inclused that coudl woudl be ingnoed
20161022 16:40:12< tad_carlucci> That is the test I use to ensure the -include'd files are being used. boost-patched and wesnoth_lua_config.
20161022 16:40:28< vultraz> but it's in my projectfile..
20161022 16:41:01< tad_carlucci> Put the #error at the top of wesnoth_lua_config.h and see if you get the error compiling
20161022 16:41:39< gfgtdf> vultraz: that is, moving it there, also remove it form ldo.lua.
20161022 16:42:51< tad_carlucci> I do that to ensure it's being added to all lib sources and nowhere else
20161022 16:43:09< vultraz> no error :/
20161022 16:43:12< vultraz> the hell?
20161022 16:44:00< tad_carlucci> You need to add -include option for the lua library sources.
20161022 16:44:19< vultraz> what?
20161022 16:44:54< tad_carlucci> src/lua/*.cpp files need -include src/wesnoth_lua_config.h
20161022 16:45:27< tad_carlucci> or was it hpp whatever 
20161022 16:48:40< vultraz> ugh
20161022 16:48:42< vultraz> how to do this..
20161022 16:50:16< tad_carlucci> gfgtdf, I'm changing that pop(1) back to pop(2) and retesting
20161022 16:50:52< vultraz> got it to build but it still doesn't work
20161022 16:51:07< gfgtdf> vultraz: what doent work ?
20161022 16:51:44< vultraz> i still get the Lua caught unknown exception message
20161022 16:51:47< gfgtdf> vultraz: it now compiles for your with  #error "asdf" at https://github.com/wesnoth/wesnoth/blob/master/src/lua/ldo.cpp#L56  ?
20161022 16:52:11< vultraz> yes
20161022 16:52:26< vultraz> hm wait, i think i didn't update my wesnoth target
20161022 16:52:28< vultraz> hang on
20161022 16:54:02< vultraz> gfgtdf, tad_carlucci it works now
20161022 16:55:50< tad_carlucci> works as is does not crash, no message and closes properly? cool
20161022 16:56:07< vultraz> both
20161022 16:56:43< tad_carlucci> Well, good. So hopefully wedge009 concurs and can close the gna bug
20161022 16:56:55< irker109> wesnoth: Charles Dang wesnoth:master 755b6b801584 / projectfiles/CodeBlocks/liblua.cbp: Codeblocks: properly include wesnoth_lua_config.h in lua sources https://github.com/wesnoth/wesnoth/commit/755b6b801584a688566ccf9e0a43832e4a304884
20161022 16:57:34< vultraz> glad it's a local problem :)
20161022 16:58:52< gfgtdf> vultraz: was the 'factionselect dialog not showing' issue  fixed already?
20161022 16:58:57< vultraz> gfgtdf: no
20161022 16:59:47< gfgtdf> hmm
20161022 17:00:01< gfgtdf> is there  abugreport for it ?
20161022 17:00:05< vultraz> no
20161022 17:00:32-!- travis-ci [~travis-ci@ec2-54-158-41-72.compute-1.amazonaws.com] has joined #wesnoth-dev
20161022 17:00:33< travis-ci> wesnoth/wesnoth#11710 (master - 6826e11 : Charles Dang): The build has errored.
20161022 17:00:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/169746317
20161022 17:00:33-!- travis-ci [~travis-ci@ec2-54-158-41-72.compute-1.amazonaws.com] has left #wesnoth-dev []
20161022 17:05:13-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161022 17:05:39-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161022 17:10:47-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161022 17:22:58-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161022 17:23:04-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161022 17:26:08< irker109> wesnoth: Gregory A Lundberg wesnoth:master edacf922fbee / data/ (4 files in 4 dirs): Lua upgrade: integer indices https://github.com/wesnoth/wesnoth/commit/edacf922fbeec8ed93e507dd13046c91e959b77c
20161022 17:26:10< irker109> wesnoth: Gregory A Lundberg wesnoth:master 89aee83bbf4c / data/multiplayer/scenarios/2p_Dark_Forecast.lua: 2p_Dark_Forecast Fix bugs https://github.com/wesnoth/wesnoth/commit/89aee83bbf4c3e7664c566f1cef82103eb41add9
20161022 17:26:12< irker109> wesnoth: Gregory A Lundberg wesnoth:master 874e568e99e0 / data/multiplayer/scenarios/2p_Dark_Forecast.lua: Workarround MP work incomplete https://github.com/wesnoth/wesnoth/commit/874e568e99e02b61c66c3aacbf5479f1f4e68af5
20161022 17:26:14< irker109> wesnoth: Gregory A Lundberg wesnoth:master e28be22c6488 / src/wesnoth_lua_config.h: Enable integer string compatability https://github.com/wesnoth/wesnoth/commit/e28be22c648881afc1d0aeef12f47aa49c7b6a68
20161022 17:26:16< irker109> wesnoth: gfgtdf wesnoth:master 16e66fb1aaa0 / / (5 files in 5 dirs): Merge pull request #837 from GregoryLundberg/GL_Fix_Lua_integer_index https://github.com/wesnoth/wesnoth/commit/16e66fb1aaa02ce5ec351be5521a92d30fb5b9ce
20161022 17:35:48< tad_carlucci> I was just wondering about those
20161022 17:44:14< gfgtdf> tad_carlucci: do you want to work on the mp ui blocker issue?
20161022 17:45:15< tad_carlucci> I don't think it would be a good fit. I've never looked at the UI code so, unless it's something really basic, I don't know how much help I'd be.
20161022 17:46:39< gfgtdf> tad_carlucci: ok
20161022 17:58:33-!- tad_carlucci_ [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161022 17:58:38-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Switching to Unix to get some real work done.]
20161022 17:58:49-!- tad_carlucci_ is now known as tad_carlucci
20161022 18:14:02-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161022 18:14:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161022 18:16:29-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161022 18:18:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 265 seconds]
20161022 18:19:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161022 18:22:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161022 18:22:56-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 256 seconds]
20161022 18:25:48-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161022 18:37:46-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Read error: Connection reset by peer]
20161022 18:39:36< vultraz> decltype looks quite interesting
20161022 18:47:15< irker109> wesnoth: Charles Dang wesnoth:master cf670b99c6fa / src/gui/dialogs/multiplayer/ (mp_options_helper.cpp mp_options_helper.hpp): MP Options Helper: some refactoring to reduce redundant code https://github.com/wesnoth/wesnoth/commit/cf670b99c6fa9ec30d32aab9f34a33a6ffa70c3d
20161022 18:47:36< vultraz> I'm sure that could be simplified further in some way but meh.
20161022 18:51:42< vultraz> the lack of generic lambdas doesn't help
20161022 18:56:41-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161022 19:32:34-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has joined #wesnoth-dev
20161022 19:33:35-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has quit [Remote host closed the connection]
20161022 19:42:54< irker109> wesnoth: Charles Dang wesnoth:master 3683c7596879 / src/gui/dialogs/multiplayer/mp_options_helper.cpp: Fixup cf670b99c6fa https://github.com/wesnoth/wesnoth/commit/3683c75968792e9fd9c4d5816b5dd59bfac0e7cf
20161022 19:53:32-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20161022 19:58:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161022 20:25:32-!- karthago [~edgrey@178.205.0.69] has quit [Ping timeout: 265 seconds]
20161022 20:34:58-!- louis94 [~~louis94@91.178.241.19] has quit [Ping timeout: 256 seconds]
20161022 20:38:56-!- boucman_work [~boucman@2a02-8428-034f-f800-fb79-8bd8-8af4-11f1.rev.sfr.net] has quit [Ping timeout: 250 seconds]
20161022 20:54:43< irker109> wesnoth: mattsc wesnoth:master acecd77bb45d / data/ai/ (5 files in 2 dirs): Lua AIs: use new syntax for iterating over attacks https://github.com/wesnoth/wesnoth/commit/acecd77bb45d3e6acd9cdd4be80e8054c706ce36
20161022 20:56:50-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161022 20:57:12-!- ancestral [~ancestral@8.42.164.20] has joined #wesnoth-dev
20161022 21:16:28-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161022 21:17:15-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161022 21:17:53-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161022 21:25:16-!- ancestral [~ancestral@8.42.164.20] has quit [Quit: i go nstuf kthxbai]
20161022 21:29:24-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20161022 21:52:23-!- Bonobo [~Bonobo@2001:44b8:254:3200:e4b5:c14d:1fff:4741] has joined #wesnoth-dev
20161022 21:54:54-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161022 21:55:58< pydsigner> As requested by shadowm a few months ago: https://gist.github.com/pydsigner/12dcea9426ba242f465881d9e9c2eb0c
20161022 21:57:03< pydsigner> celticminstrel, vultraz ^
20161022 21:57:35< pydsigner> Aginor: ^
20161022 22:05:58-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Write error: Broken pipe]
20161022 22:06:01-!- midzer [~quassel@p57B45F9C.dip0.t-ipconnect.de] has quit [Write error: Broken pipe]
20161022 22:06:02-!- louis94 [~~louis94@91.178.241.19] has quit [Remote host closed the connection]
20161022 22:06:15-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161022 22:06:37-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Read error: Connection reset by peer]
20161022 22:06:56-!- louis94 [~~louis94@91.178.241.19] has joined #wesnoth-dev
20161022 22:06:59-!- midzer [~quassel@p57B45F9C.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161022 22:07:29-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161022 22:14:53< irker109> wesnoth: mattsc wesnoth:master fa48c9c2ac4c / data/ai/lua/ai_helper.lua: ai_helper: compare unit proxies directly, not by coordinate https://github.com/wesnoth/wesnoth/commit/fa48c9c2ac4c07b4ce9457db58cb738c5e0f383b
20161022 22:35:32-!- Bonobo [~Bonobo@2001:44b8:254:3200:e4b5:c14d:1fff:4741] has quit [Ping timeout: 260 seconds]
20161022 22:43:11< tad_carlucci> vultraz, https://gna.org/bugs/index.php?25132  .. mark fixed/closed (boost-patch/bind/arg.hpp is the fix for that)
20161022 22:56:26< tad_carlucci> matthiaskgr, https://gna.org/bugs/index.php?25095 .. cannot reproduce .. probably fixed by https://github.com/wesnoth/wesnoth/commit/806a388b9d39707fa293b6747598d04bf2633a36
20161022 23:15:22< tad_carlucci> vultraz, https://gna.org/bugs/?12098 and https://gna.org/bugs/index.php?24931 should both be fixed/closed as of https://github.com/wesnoth/wesnoth/pull/806 merge
20161022 23:21:46-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161022 23:25:46-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20161022 23:32:35-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161022 23:40:20-!- Aginor_ [~andreas@apollo.alternating.net] has joined #wesnoth-dev
20161022 23:43:01-!- Aginor [~andreas@unaffiliated/aginor] has quit [Ping timeout: 248 seconds]
20161022 23:44:48-!- louis94 [~~louis94@91.178.241.19] has quit [Ping timeout: 256 seconds]
--- Log closed Sun Oct 23 00:00:10 2016