--- Log opened Tue Oct 25 00:00:13 2016
20161025 00:02:05-!- _laco_ is now known as _laco
20161025 00:02:33-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161025 00:25:12-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 00:26:33-!- ShikadiLord [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20161025 00:27:00-!- Soliton [~Soliton@wesnoth/developer/soliton] has quit [Disconnected by services]
20161025 00:27:08-!- Soliton_ [~Soliton@wesnoth/developer/soliton] has joined #wesnoth-dev
20161025 00:27:27-!- Soliton_ is now known as Soliton
20161025 00:28:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20161025 00:28:11-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 245 seconds]
20161025 00:29:48-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 265 seconds]
20161025 00:48:08-!- gfgtdf [~chatzilla@x4e369617.dyn.telefonica.de] has quit [Ping timeout: 252 seconds]
20161025 00:59:55-!- gfgtdf [~chatzilla@x4e369617.dyn.telefonica.de] has joined #wesnoth-dev
20161025 01:06:59-!- gfgtdf [~chatzilla@x4e369617.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.2/20161019084923]]
20161025 01:40:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161025 02:22:31-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 02:34:08-!- nono_ [d2564fc3@gateway/web/freenode/ip.210.86.79.195] has joined #wesnoth-dev
20161025 02:40:23-!- ShikadiLord is now known as shadowm
20161025 03:03:08-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: ancestral]
20161025 03:17:24-!- irker617 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161025 03:17:24< irker617> wesnoth: Ignacio R. Morelle wesnoth:master a7678594212a / .travis.yml: travis: Conditionally install either cmake or scons as needed https://github.com/wesnoth/wesnoth/commit/a7678594212a0f507f3b573b8514d30ce5071557
20161025 03:22:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 03:26:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161025 03:56:10< vultraz> you know you've been programming too much when you dream about someone commiting bugfixes :|
20161025 03:57:09-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161025 03:57:34< tad_carlucci> Someone did. A couple of them. :P
20161025 03:59:00< vultraz> it was specifically Aginor committing a fix for the message lag :|
20161025 04:00:09< tad_carlucci> Oh. Then go back to sleep.
20161025 04:00:46< vultraz> :P
20161025 04:01:41< tad_carlucci> I _might_ have figured out how to upgrade Travis-CI with packages from Yakkety. Don't want to try it on the live system. Actually seemed to work on Windows 10 as a quick test.
20161025 04:06:27< irker617> wesnoth: Charles Dang wesnoth:master 13effa412840 / data/core/terrain-graphics.cfg: Fixed Lit Stone Walls corner transitions https://github.com/wesnoth/wesnoth/commit/13effa412840d7c4f3c870c296ec0918ada119bb
20161025 04:08:36-!- travis-ci [~travis-ci@ec2-54-166-133-174.compute-1.amazonaws.com] has joined #wesnoth-dev
20161025 04:08:37< travis-ci> wesnoth/wesnoth#11742 (master - a767859 : Ignacio R. Morelle): The build passed.
20161025 04:08:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/170338703
20161025 04:08:37-!- travis-ci [~travis-ci@ec2-54-166-133-174.compute-1.amazonaws.com] has left #wesnoth-dev []
20161025 04:10:40< wedge009> Oh vultraz, I think you have been working too much!
20161025 04:10:50< vultraz> :P
20161025 04:12:41< irker617> wesnoth: Gregory A Lundberg wesnoth:master 9d08723236c4 / / (4 files in 3 dirs): [text_input] Fix bug 25173 https://github.com/wesnoth/wesnoth/commit/9d08723236c468c72b7ead156d8cf2e64950fc57
20161025 04:12:43< irker617> wesnoth: Charles Dang wesnoth:master ee4d1f5a600d / / (4 files in 3 dirs): Merge pull request #841 from GregoryLundberg/GL_text_input https://github.com/wesnoth/wesnoth/commit/ee4d1f5a600da354924742dbf055937c2f211e3a
20161025 04:18:29-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 04:20:19< vultraz> tad_carlucci: i added you to the gna ground
20161025 04:20:48< tad_carlucci> ty
20161025 04:20:52< vultraz> ground
20161025 04:20:56< vultraz> GROUP:|
20161025 04:20:59< vultraz> jfc >_>
20161025 04:21:03 * tad_carlucci understood
20161025 04:21:15< vultraz> I should drink coffee
20161025 04:21:17< vultraz> but
20161025 04:21:20< vultraz> i'm not of filters :|
20161025 04:21:23< vultraz> OUT
20161025 04:21:42< tad_carlucci> Paper towels work if you're carefull
20161025 04:21:58< tad_carlucci> Or rinse off an old one :L
20161025 04:31:12< DeFender1031> vultraz, when I was working on my final project in my first year of college, I had a recurring dream one night where I couldn't fall asleep, and I realized that I needed to program myself to do so, but didn't know the best way to structure the code, so I got up to walk around (because I think better when I'm pacing) and in doing so, kept ACTUALLY getting out of bed and waking up, realizing that I HAD been asleep already, and 
20161025 04:31:13< DeFender1031> then repeating the whole thing. Musta happened about a dozen times that night.
20161025 04:32:05< vultraz> O_O
20161025 04:33:08< vultraz> that must've been fun
20161025 04:33:51< DeFender1031> I did manage to get my final project done and handed in on time though.
20161025 04:35:17< vultraz> well that's good
20161025 04:35:26< DeFender1031> My subconscious has made up for it several times since then though with the times that I've actually solved real problems in my sleep.
20161025 04:35:44< DeFender1031> (With solutions that still made sense once I was awake, mind you.)
20161025 04:36:02< DeFender1031> (Cause I've had plenty of the other kind too :P)
20161025 04:39:32-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 04:42:48-!- travis-ci [~travis-ci@ec2-54-198-253-36.compute-1.amazonaws.com] has joined #wesnoth-dev
20161025 04:42:49< travis-ci> wesnoth/wesnoth#11743 (master - 13effa4 : Charles Dang): The build passed.
20161025 04:42:50< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/170346709
20161025 04:42:50-!- travis-ci [~travis-ci@ec2-54-198-253-36.compute-1.amazonaws.com] has left #wesnoth-dev []
20161025 04:55:45-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 04:56:52-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 05:00:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 245 seconds]
20161025 05:09:46< wedge009> vultraz: DeFender1031: My previous employer would think on our coding issues when he was asleep and sometimes come up with solutions by the morning too. o.o
20161025 05:10:01< vultraz> see, thing is
20161025 05:10:10< vultraz> i also dreamed Aginor explaining why the fix worked
20161025 05:10:17< vultraz> but now i can't remember what the fix or explanation was :|
20161025 05:10:23< wedge009> But you can't remember what the fix...  yeah.
20161025 05:10:29< wedge009> XD
20161025 05:12:02< DeFender1031> THere's a good chance it would have been nonsense to the waking world anyway.
20161025 05:12:50< vultraz> true :P
20161025 05:17:14-!- Bonobo [~Bonobo@2001:44b8:254:3200:a123:49ae:1fe8:75b] has joined #wesnoth-dev
20161025 05:20:36-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161025 05:23:58-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161025 06:00:07< irker617> wesnoth: Charles Dang wesnoth:master d825832145db / changelog: Updated changelog https://github.com/wesnoth/wesnoth/commit/d825832145dba81f16283bffbbe3c213632460cf
20161025 06:00:43< vultraz> I wonder if we should make the changelog an MD file
20161025 06:01:13< shadowm> There's no point in doing that.
20161025 06:01:29< vultraz> Better formatting on gh?
20161025 06:01:41< shadowm> That will be constantly broken?
20161025 06:01:58< vultraz> Constantly broken?
20161025 06:02:09< shadowm> Yes, you people don't know how to maintain a changelog, sorry to be blunt.
20161025 06:03:44-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 06:04:05< vultraz> Well, the upside of using markdown would be having a standard style guide
20161025 06:04:32< vultraz> (I'd also suggest if it were done to split the file into version changelogs because holy hell this file is 13,000 lines long)
20161025 06:04:42< shadowm> Only presentation style, not content style.
20161025 06:04:56< shadowm> The content will be as ludicrously inconsistent and poorly worded as usual.
20161025 06:05:20< vultraz> true
20161025 06:05:38< shadowm> I will say this again: there are bigger fish to fry.
20161025 06:06:01< shadowm> Don't get sidetracked with pointless perfectionism.
20161025 06:06:22< vultraz> true
20161025 06:07:01-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 06:08:46-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161025 06:34:41-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161025 06:41:15-!- ShikadiLord [~ignacio@wesnoth/developer/shadowm] has joined #wesnoth-dev
20161025 06:42:27-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161025 06:42:33-!- travis-ci [~travis-ci@ec2-54-158-49-131.compute-1.amazonaws.com] has joined #wesnoth-dev
20161025 06:42:34< travis-ci> wesnoth/wesnoth#11745 (master - d825832 : Charles Dang): The build has errored.
20161025 06:42:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/170361335
20161025 06:42:34-!- travis-ci [~travis-ci@ec2-54-158-49-131.compute-1.amazonaws.com] has left #wesnoth-dev []
20161025 06:42:37-!- knotwork_ [~markm@unaffiliated/knotwork] has joined #wesnoth-dev
20161025 06:42:42-!- shadowm [~ignacio@wesnoth/developer/shadowm] has quit [Ping timeout: 265 seconds]
20161025 06:42:42-!- knotwork [~markm@unaffiliated/knotwork] has quit [Ping timeout: 265 seconds]
20161025 06:44:23-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Ping timeout: 265 seconds]
20161025 06:45:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 06:48:23-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has quit [Ping timeout: 245 seconds]
20161025 06:49:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161025 06:50:22-!- aeth [~Michael@wesnoth/umc-dev/developer/aethaeryn] has joined #wesnoth-dev
20161025 06:53:05-!- ShikadiLord is now known as shadowm
20161025 07:04:47-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161025 07:11:26< wedge009> Ludicrously inconsistent and poorly worded as usual.
20161025 07:11:33< wedge009> Like *everyone* writes that wway.
20161025 07:11:35< wedge009> way
20161025 07:12:06< wedge009> Stop saying this sort of thing against everyone collectively. It's very discouraging.
20161025 07:16:32-!- atarocch [~atarocch@37.176.64.44] has joined #wesnoth-dev
20161025 07:25:37-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 07:27:30-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 07:35:41-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161025 08:07:07-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has joined #wesnoth-dev
20161025 08:11:25-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has quit [Ping timeout: 252 seconds]
20161025 08:17:23-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Quit: Bye]
20161025 08:33:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 08:33:29-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161025 08:36:13-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161025 08:37:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161025 08:40:43-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20161025 08:44:07-!- iceiceice [~chris@unaffiliated/iceiceice] has joined #wesnoth-dev
20161025 08:56:13-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has joined #wesnoth-dev
20161025 09:04:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161025 09:06:16< irker617> wesnoth: ln-zookeeper wesnoth:master 3e08eed00631 / data/campaigns/The_Rise_Of_Wesnoth/scenarios/07_Return_to_Oldwood.cfg: Improved Jessene's unmasking cutscene https://github.com/wesnoth/wesnoth/commit/3e08eed00631c5caf74b1069a0e3e43ed57a84d3
20161025 09:06:32-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has quit [Ping timeout: 250 seconds]
20161025 09:08:22< zookeeper> i did notice that the long-standing annoying bug of [message] sometimes eating away some of the animations that immediately follow it can be prevented (at least in some cases) by a [delay]
20161025 09:08:26-!- nono_ [d2564fc3@gateway/web/freenode/ip.210.86.79.195] has quit [Ping timeout: 260 seconds]
20161025 09:10:09-!- neoriceisgood [5658167a@gateway/web/freenode/ip.86.88.22.122] has joined #wesnoth-dev
20161025 09:10:16< neoriceisgood> lo
20161025 09:11:13-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 09:11:35-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:11:58-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:12:23-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:12:46-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:13:07-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:13:34-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:13:59-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:14:24-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:14:44-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:15:10-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:15:36-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:15:36-!- atarocch [~atarocch@37.176.64.44] has quit [Ping timeout: 252 seconds]
20161025 09:15:58-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:16:24-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:16:46-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:17:11-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 09:17:34-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 09:17:46-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has joined #wesnoth-dev
20161025 09:18:06-!- atarocch [~atarocch@37.176.64.44] has joined #wesnoth-dev
20161025 09:19:27-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20161025 09:21:40< zookeeper> vultraz, celmin, etc: i can workaround the abovementioned message/animation problem by adding a wesnoth.delay(1) to the [message] implementation, i suppose that's okay. i suppose you'd need to have a really long piece of dialogue for those to add up to a noticeable delay when esc'ing through it.
20161025 09:44:21-!- travis-ci [~travis-ci@ec2-54-147-180-243.compute-1.amazonaws.com] has joined #wesnoth-dev
20161025 09:44:22< travis-ci> wesnoth/wesnoth#11746 (master - 3e08eed : ln-zookeeper): The build passed.
20161025 09:44:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/170394317
20161025 09:44:22-!- travis-ci [~travis-ci@ec2-54-147-180-243.compute-1.amazonaws.com] has left #wesnoth-dev []
20161025 09:56:46-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161025 09:57:07< tad_carlucci> vultraz, Wake up. You're not dreaming. Check PR 842.
20161025 09:57:26< vultraz> was already doing so
20161025 09:57:33< irker617> wesnoth: Gregory A Lundberg wesnoth:master a441fc97a233 / data/lua/wml/message.lua: Fix bug: Slow narrator (Partial 25186) https://github.com/wesnoth/wesnoth/commit/a441fc97a23350f4695fadd04d72639142326207
20161025 09:57:35< irker617> wesnoth: Charles Dang wesnoth:master aef1fd4e59f4 / data/lua/wml/message.lua: Merge pull request #842 from GregoryLundberg/GL_slow_messages https://github.com/wesnoth/wesnoth/commit/aef1fd4e59f4e2ae6afa281d231749e21b8c4288
20161025 09:58:12< tad_carlucci> Your earlier dream caused me to not be able to sleep. :)
20161025 09:59:35< vultraz> zookeeper: i don't really think adding a delay is good..
20161025 10:00:25< vultraz> zookeeper: one of the cool, unintentional features of the new message implementation was that the dialog does not appear to close on successive messages by the same speaker. 
20161025 10:01:54< vultraz> (which may be indicative of the lag bug somehow...)
20161025 10:01:55< zookeeper> right, this would change that
20161025 10:02:21< zookeeper> anyway, are you aware of the bug i described? i'd think you must have seen it a thousand times
20161025 10:02:35< vultraz> I have not
20161025 10:03:12< tad_carlucci> vultraz, With 842 in it's just slow but doesn't lag-to-death .. I fast clicked my test 100 times and then clicked the other option. Speed was the normal come-on-there-you-are slow instead of reboot-the-computer-it's-dead slow.
20161025 10:03:27< vultraz> I see
20161025 10:03:30< vultraz> odd...
20161025 10:04:15< zookeeper> vultraz, i see. i think it must be some kind of subtle render/redraw/frame thing, seeing how an extra delay fixes it.
20161025 10:04:50< tad_carlucci> zookeeper, I agree. I was going to look into that up to the point of rendering and found 842 on the way there.
20161025 10:08:23< vultraz> sadly we don't have anura's really great task profiler...
20161025 10:11:26< zookeeper> random note: surely this can't work without any filtering... https://github.com/wesnoth/wesnoth/blob/master/data/campaigns/Dead_Water/scenarios/10_The_Flaming_Sword.cfg#L635
20161025 10:13:21-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 10:21:28< zookeeper> the testcase for that is simple: https://gist.github.com/ln-zookeeper/b3c7f5a43ebe56be0c233f8110b4df45
20161025 10:21:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 10:24:50-!- neoriceisgood [5658167a@gateway/web/freenode/ip.86.88.22.122] has quit [Ping timeout: 260 seconds]
20161025 10:25:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161025 10:26:05< zookeeper> so, anyone who fixes that might get a virtual cookie
20161025 10:26:05-!- gfgtdf [~chatzilla@x4e36315c.dyn.telefonica.de] has joined #wesnoth-dev
20161025 10:36:06-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161025 10:36:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 10:36:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161025 10:37:12-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 10:37:30-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161025 10:39:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 11:01:24< tad_carlucci> zookeeper, According to the wiki, the default [animate_unit][filter] is "the event location" .. so is that not [filter]x,y=$x1,$y1 ???
20161025 11:02:11< zookeeper> tad_carlucci, caladon isn't at $x1,$y1 until a few lines later
20161025 11:03:18-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has joined #wesnoth-dev
20161025 11:04:37< tad_carlucci> Ah, you're right. So the idea is he teleports TO the event location. So it needs [filter]x,y=$Caladon_stored.x,$Caladon_stored.y ???
20161025 11:04:56< zookeeper> so it seems
20161025 11:05:08< zookeeper> (or just id=Caladon)
20161025 11:05:53< zookeeper> or just animate=yes in [teleport], maybe
20161025 11:06:30< tad_carlucci> zookeeper, Yes. And it didn't clean the Caladon_stored artifact.
20161025 11:06:47< zookeeper> not that he has an actual teleport animation, so one might as well copy the silver mage animation for him
20161025 11:18:51< tad_carlucci> vultraz, I tracked [message] to the gui code and don't see any way to speed it up further. I compare the slowness of the OK button and such to the "End Turn" button and it seems about as slow. So I'm done with 25186; any further work on the speed or crash will have to come from someone qualified to work at the gui/sdl level.
20161025 11:19:20< vultraz> alright
20161025 11:19:58< tad_carlucci> Now, maybe one of us can sleep :P  bbl
20161025 11:20:01-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161025 11:23:25-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161025 11:26:44-!- iceiceice [~chris@unaffiliated/iceiceice] has quit [Ping timeout: 260 seconds]
20161025 11:37:37-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161025 11:41:58< irker617> wesnoth: Charles Dang wesnoth:master 9028a8e159f3 / src/gui/dialogs/multiplayer/ (mp_options_helper.cpp mp_options_helper.hpp): MP Options Helper: refactor data storage structure https://github.com/wesnoth/wesnoth/commit/9028a8e159f31fab1cbdad094769d3d219e51ba7
20161025 11:42:02< zookeeper> noooooo
20161025 11:42:06< vultraz> hm?
20161025 11:42:15< zookeeper> i was just doing a push
20161025 11:42:16< vultraz> you were committing something?
20161025 11:42:20< vultraz> heh
20161025 11:42:49< irker617> wesnoth: ln-zookeeper wesnoth:master 1b2a135abcaf / data/campaigns/Eastern_Invasion/scenarios/04c_Mal-Ravanals_Capital.cfg: Fixed bug in prisoner index calculation https://github.com/wesnoth/wesnoth/commit/1b2a135abcaf428c0c665fa9d49adee932c63a1d
20161025 11:42:50< vultraz> gfgtdf: ^ that commit adds the framework for the option_id = value format to switch to after the release
20161025 11:42:51< irker617> wesnoth: ln-zookeeper wesnoth:master a520791a13a4 / src/gui/dialogs/multiplayer/ (mp_options_helper.cpp mp_options_helper.hpp): Merge branch 'master' of https://github.com/wesnoth/wesnoth https://github.com/wesnoth/wesnoth/commit/a520791a13a4cc87e79b7df03184be918b0b85dc
20161025 11:42:53< vultraz> gfgtdf: well
20161025 11:42:55< vultraz> mine
20161025 11:42:56< vultraz> gfgtdf: no zookeeper's
20161025 11:42:58< vultraz> :P
20161025 11:42:59< vultraz> not*
20161025 11:43:21< zookeeper> bumbadadabum, ^ another bug of yours, from 3d792e54a4e
20161025 11:43:51< zookeeper> twice today i've just innocuously grepped for a mainline campaign code example, only to be immediately greeted by something that looks obviously buggy :p
20161025 11:44:03< bumbadadabum> fuck
20161025 11:44:07< bumbadadabum> that's uhh
20161025 11:44:10< bumbadadabum> I blame lua
20161025 11:44:38< vultraz> bumbadadabum: and when you write lua you blame something else (was it java or python? :P )
20161025 11:44:48< bumbadadabum> exactly!
20161025 11:44:59< bumbadadabum> anyway sorry for being extremely afk the past few weeks
20161025 11:45:04< bumbadadabum> swamped with uni work
20161025 11:45:14< bumbadadabum> will have time for wesnoth again starting next monday
20161025 11:45:34< vultraz> zookeeper: any progress with the castle -> wall/cave wall transitions?
20161025 11:45:49< zookeeper> nope
20161025 11:45:53-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161025 11:46:05< vultraz> sadness!
20161025 11:46:45< vultraz> gfgtdf: ftr idk if a map of configs is more efficient than a map of maps but it makes it slightly easier to work with on the output
20161025 11:46:45< zookeeper> well gee, contrary to common belief i'm not a robot :p
20161025 11:46:59< vultraz> no, that would be numbers-san
20161025 11:49:09< vultraz> gfgtdf: it's a little unfortunate we can't use std::move when constructing the output config but meh
20161025 11:51:59-!- Neoriceisgood [5658167a@gateway/web/freenode/ip.86.88.22.122] has joined #wesnoth-dev
20161025 11:52:25< Neoriceisgood> hi hi
20161025 11:52:29< Neoriceisgood> https://snag.gy/xc521z.jpg progress on toy faction
20161025 11:54:12< vultraz> they remind of of Alice: Madness Returns for some reason
20161025 11:54:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 250 seconds]
20161025 11:54:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161025 11:55:20< gfgtdf> vultraz: bote aure what you are talkign about, do you want to replace a map of ,aps aith a config object?
20161025 11:55:28< gfgtdf> vultraz: and if yes then where ?
20161025 11:55:48< vultraz> im talking about https://github.com/wesnoth/wesnoth/commit/9028a8e159f31fab1cbdad094769d3d219e51ba7
20161025 11:58:17-!- JyrkiVesterinen [~JyrkiVest@nblzone-242-23.nblnetworks.fi] has quit [Quit: .]
20161025 11:58:54< gfgtdf> vultraz: generalyl a custom map is more efficient than config objects but i dont think that matters here.
20161025 11:59:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection]
20161025 12:00:07< gfgtdf> vultraz: function returns values are automaticaly moved instead of copied unless copy elison applies win which case not even the move ctor it called. Not sure if this answers your question
20161025 12:00:41< zookeeper> uh... [for] start,end=10,50 [do][/do] [/for] results in a "error scripting/lua: lua/wml-flow.lua:108: attempt to compare nil with number"
20161025 12:00:50< gfgtdf> vultraz: this is, unless you copy return a by reference or by pointer
20161025 12:00:54< zookeeper> i guess it's really hard to get anything done today...
20161025 12:06:21< gfgtdf> zookeeper: sounds like a bug in he lua implementation. Even if that particular syntax is not supported it shodul give a useful erromessage that tells you what exatly you did wrong.
20161025 12:09:44-!- Bonobo [~Bonobo@2001:44b8:254:3200:a123:49ae:1fe8:75b] has quit [Quit: Leaving]
20161025 12:09:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 12:14:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161025 12:15:30-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161025 12:35:13< gfgtdf> vultraz: also you shodultn return values by 'const' like in "const config tmp_options_helper::get_options_config()", just move te first const here
20161025 12:35:22< gfgtdf> vultraz: and in the declaration
20161025 12:35:39< vultraz> why should you not return values by const?
20161025 12:37:04< gfgtdf> vultraz: becasue ti amkes no sense, when you copy the object the const is remved anyway, liek you can still write "config c = get_options_config()" the oynl differerence is that the compler cannot use copimize it by using move constructors
20161025 12:37:29< vultraz> so you should only use const if returning by reference?
20161025 12:37:31< gfgtdf> s/cannot use copimize/cannot optimize
20161025 12:37:37< gfgtdf> vultraz: yes
20161025 12:40:41< gfgtdf> s/just move te/just remove the
20161025 12:42:53< irker617> wesnoth: Charles Dang wesnoth:master 1b37b12849fd / src/gui/dialogs/multiplayer/ (mp_options_helper.cpp mp_options_helper.hpp): MP Options Helper: remove const qualifier from get_options_config https://github.com/wesnoth/wesnoth/commit/1b37b12849fdf2995a6339062d69a46df4ba2b34
20161025 12:52:27-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20161025 12:54:27-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161025 13:05:51-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161025 13:33:36< Neoriceisgood> https://snag.gy/gtcSlf.jpg toy faction progress
20161025 13:36:57< vultraz> frogatto font detected 
20161025 13:37:36< Neoriceisgood> haha  I just made that, that's kinda my default font design
20161025 13:58:05-!- JyrkiVesterinen [~JyrkiVest@87-100-244-13.bb.dnainternet.fi] has joined #wesnoth-dev
20161025 14:11:38-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161025 14:14:02-!- gfgtdf [~chatzilla@x4e36315c.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.2/20161019084923]]
20161025 14:22:05-!- mattsc_ [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161025 14:22:37-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Read error: Connection reset by peer]
20161025 14:22:37-!- mattsc_ is now known as mattsc
20161025 14:58:03-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20161025 15:02:51-!- JyrkiVesterinen [~JyrkiVest@87-100-244-13.bb.dnainternet.fi] has quit [Quit: .]
20161025 15:07:54-!- louis94 [~~louis94@91.178.241.241] has joined #wesnoth-dev
20161025 15:10:53-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has quit [Ping timeout: 245 seconds]
20161025 15:11:11-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has joined #wesnoth-dev
20161025 15:13:46-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20161025 15:35:24-!- louis94 [~~louis94@91.178.241.241] has quit [Ping timeout: 260 seconds]
20161025 15:43:08-!- irker617 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161025 15:50:40-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20161025 15:53:51-!- louis94 [~~louis94@91.178.241.241] has joined #wesnoth-dev
20161025 16:00:27-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161025 16:01:05-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161025 16:01:45-!- gfgtdf [~chatzilla@x4e36315c.dyn.telefonica.de] has joined #wesnoth-dev
20161025 16:02:42< gfgtdf> vultraz: note that when makign that switch the function saved_game::expand_mp_options() that coped the options into the [scenario][variables] need to be updated aswell.
20161025 16:03:00< vultraz> ok
20161025 16:03:17-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161025 16:03:36-!- louis94 [~~louis94@91.178.241.241] has quit [Ping timeout: 265 seconds]
20161025 16:05:17-!- JyrkiVesterinen [~JyrkiVest@87-100-244-13.bb.dnainternet.fi] has joined #wesnoth-dev
20161025 16:10:59-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 16:11:41-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Client Quit]
20161025 16:12:15-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 16:12:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161025 16:12:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 16:14:15-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has quit [Remote host closed the connection]
20161025 16:17:14-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161025 16:22:24-!- irker038 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161025 16:22:24< irker038> wesnoth: Jyrki Vesterinen wesnoth:master 35f01dd7b5f6 / simulate-lobby-activity.lua: Simulate lobby activity: use wesnoth.random() to generate game name https://github.com/wesnoth/wesnoth/commit/35f01dd7b5f6736ff3935c8304332f6d0ef104cc
20161025 16:23:01-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 16:25:33-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161025 16:27:34< zookeeper> celticminstrel, <zookeeper> uh... [for] start,end=10,50 [do][/do] [/for] results in a "error scripting/lua: lua/wml-flow.lua:108: attempt to compare nil with number"
20161025 16:35:00-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 16:39:13-!- atarocch [~atarocch@37.176.64.44] has quit [Ping timeout: 260 seconds]
20161025 16:51:49-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161025 16:54:57-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has quit [Quit: Ex-Chat]
20161025 16:55:27-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has joined #wesnoth-dev
20161025 16:57:14-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 17:05:21-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161025 17:06:00-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161025 17:12:04< irker038> wesnoth: Jyrki Vesterinen wesnoth:master 1baaaa4bbd8c / src/gui/widgets/grid.cpp: Fix inconsistent widget IDs in GUI2 layout system documentation https://github.com/wesnoth/wesnoth/commit/1baaaa4bbd8cd477876c560151cfc5b4f9c9e48f
20161025 17:14:27< celticminstrel> vultraz: Why did you merge #841? I'm not very satisfied with it.
20161025 17:24:06-!- atarocch [~atarocch@193.92.163.210] has joined #wesnoth-dev
20161025 17:38:09< zookeeper> celticminstrel, any idea about that [for] bug?
20161025 17:40:37-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has joined #wesnoth-dev
20161025 17:40:39-!- mordante [~mordante@2001:984:5786:1:7a24:afff:fe8c:dea8] has quit [Changing host]
20161025 17:40:39-!- mordante [~mordante@wesnoth/developer/mordante] has joined #wesnoth-dev
20161025 17:40:51< mordante> servus
20161025 17:44:39-!- iceiceice [~chris@pool-173-61-153-221.cmdnnj.fios.verizon.net] has quit [Remote host closed the connection]
20161025 17:46:52< vultraz> celticminstrel: neither am I
20161025 17:46:52< vultraz> celticminstrel: I would much prefer a 'is this table not nil' check but it fixes the issue for now
20161025 17:46:52< vultraz> an*
20161025 17:46:52< vultraz> mordante: how does [instance] work?
20161025 17:49:17< mordante> vultraz, do you have some context, which widget?
20161025 17:50:24-!- Appleman1234 [~Appleman1@KD106181178103.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20161025 17:51:03-!- travis-ci [~travis-ci@ec2-54-198-253-36.compute-1.amazonaws.com] has joined #wesnoth-dev
20161025 17:51:04< travis-ci> wesnoth/wesnoth#11753 (master - 1baaaa4 : Jyrki Vesterinen): The build has errored.
20161025 17:51:05< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/170520967
20161025 17:51:05-!- travis-ci [~travis-ci@ec2-54-198-253-36.compute-1.amazonaws.com] has left #wesnoth-dev []
20161025 17:51:36< vultraz> mordante: i wanted to create a new widget, a tab bar, and i think [instance] might be useful, but I'm not sure. Essentially I thought of implementing it as a sort of "forwarding widget", that would take a provided WML and use it to create rows in a horizontal listbox. I can't exactly figure out if that's possible or not given syntax.
20161025 17:54:29< vultraz> my implementation crashed 
20161025 17:54:53< vultraz> http://pastebin.com/n21nXCqZ
20161025 17:55:32< vultraz> I suppose i could still go with option 2 and create a helper class instead of a widget
20161025 17:55:51< vultraz> since i might have to add separate definitions for the horizontal listbox and toggle panel anyway :/
20161025 17:56:09< vultraz> but anyway, I really would like to know how [instance]  is supposed to work
20161025 17:57:32< vultraz> (option 3 is not utilizing tcontainer at all but that might be reallly difficulty without hooking into tgenerator)
20161025 17:57:58< tad_carlucci> It already checks for table not nil and that didn't do it
20161025 17:58:21< vultraz> (the end result i wanted for a tab bar would be the 'clickable labels seperated by vertical or diagonal lines' that dota 2 or argentum age has)
20161025 17:58:39< vultraz> design that*
20161025 18:00:29< mordante> vultraz, I only see it in the matrix class and IIRC that class was not entirely finished
20161025 18:01:00< vultraz> Yeah, I don't think the matrix works..
20161025 18:02:08< gfgtdf> vultraz: prs are usually dont so that people can review it so iz makes sesne to leaver them open longer to give them a cacne to do so.
20161025 18:02:43< gfgtdf> done*
20161025 18:03:10< mordante> I can't remember what it was supposed to do
20161025 18:03:41< vultraz> a grid of grids
20161025 18:03:44< vultraz> i think
20161025 18:03:48< vultraz> essentially
20161025 18:03:56< vultraz> a main one and one each on every side
20161025 18:05:26< vultraz> But why you created it, I don't know
20161025 18:05:36< vultraz> (along with the viewport widget)
20161025 18:06:22< vultraz> maybe they were with an eye towards making the main game screen gui2
20161025 18:06:33< vultraz> (main grid + top and right grids)
20161025 18:07:09< mordante> the viewport was certainly not finished
20161025 18:07:22< mordante> I did some experiments to solve some issues with the listboxes
20161025 18:07:36< mordante> and to get tabbed widget working
20161025 18:09:02< vultraz> shadowm made tabbing possible in 1.13.2 by allowing stacked widgets to show 1 layer at a time.
20161025 18:09:55< vultraz> The tech is there. However, the combination of horizontal listbox + stacked widget and the 'select layer' callbacks must be replicated for every dialog that uses them.
20161025 18:10:01< vultraz> Which would be the point of a tab bar
20161025 18:10:08< vultraz> to take a provided stack and control it
20161025 18:10:19< vultraz> without having to copy code between dialogs.
20161025 18:12:21< vultraz> TBH, I do wish you'd come back and finish work on GUI2. Despite the (many) complaints I've had about it over the years, I've come to realize the more I dig into the internals that you actually had a pretty solid core design. It's main drawback is that that design was simply never completed.
20161025 18:14:52-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161025 18:16:13-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161025 18:16:14< mordante> I may at some point. But the amount of complains it got took a lot of fun out of the work
20161025 18:16:29-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 18:16:42-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20161025 18:16:46-!- VultCave is now known as vultraz
20161025 18:17:28-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161025 18:17:28-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161025 18:18:37< vultraz> mordante: certainly some stuff can be improved, but I feel most of the complaints stem from stuff simply not functioning to their full potential. 
20161025 18:19:08< vultraz> If there's one thing that's true it's that it's a world better than GUI1 :P
20161025 18:19:25< mordante> thanks :-)
20161025 18:20:28< DeFender1031> mordante is the one origianlly behind GUI2?
20161025 18:20:33< zookeeper> celticminstrel, the [for] problem seems to be that the default for step= isn't working. when i add step=1 the problem disappears.
20161025 18:20:37< vultraz> DeFender1031: yes
20161025 18:21:51< DeFender1031> mordante, I'm sorry to hear you got so many complaints. vultraz explained at least the lua side of how to work with GUI2 to me a couple of months ago, and I agree with him. The design is solid, it's merely lacking feature-completeness.
20161025 18:29:16< mordante> DeFender1031, thanks
20161025 18:33:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161025 18:34:01-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 18:36:19< DeFender1031> I mean it. I think most people just don't like to have any sort of learning curve. Once I was able to grasp the basics, it's really quite intuitive. My biggest annoyances with it really are the fact that it's only vaguely documented, and the lack of either an implicit or explicit call to recalculate the window geometry on changes, which, as above, is a missing feature. The framework itself makes sense.
20161025 18:37:00< vultraz> there is a way to explicitly recalculate the layout from c++.
20161025 18:37:06< vultraz> but you almost never want to use it
20161025 18:37:38-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161025 18:39:08< vultraz> though it's actually less an issue with fixed-sized windows
20161025 18:39:15< vultraz> now that I think of it
20161025 18:39:27< vultraz> just that it also resets stuff like scrollbar positions 
20161025 18:39:27< mordante> I don't know how well the lua part is documented, but the core should have a lot of documentation
20161025 18:39:32-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 18:39:44< mordante> at least I added a lot in the code, both for C++ as the wiki
20161025 18:40:35< vultraz> actually wonder if that means it could be used in fullscreen dialogs...
20161025 18:40:39< vultraz> nah, better not to
20161025 18:41:01< vultraz> I don't think invalidate_layout was even meant to be used in dialogs anyway
20161025 18:42:22< vultraz> one should be able to design a dialog without ever needed to fully recalculate the layout...
20161025 18:43:33< gfgtdf> i wonder whether whether it coudl be changes so that when the dialog is reiszed the game also choosed a differnet [resolution] to match th new size, currently the chosen [reolution] only depends on the wndow size when the dialog was startd.
20161025 18:46:48-!- Appleman1234 [~Appleman1@KD106181179234.au-net.ne.jp] has joined #wesnoth-dev
20161025 18:51:33< DeFender1031> vultraz, i'm not sure that's true. I was doing some IFP tweaking earlier and installed Dugi and shadowm's image test add on, had to tweak the code to close and re-instate the window every time I wanted to update the image or else it wouldn't show me anything larger than 72x72
20161025 18:53:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161025 18:54:28-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 18:56:57-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 18:59:36-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20161025 19:03:12-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161025 19:04:54-!- VultCave is now known as vultraz
20161025 19:05:00-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Read error: Connection reset by peer]
20161025 19:05:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 250 seconds]
20161025 19:05:51-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161025 19:06:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 19:11:20-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 19:12:06-!- vultraz [~chatzilla@124.109.10.167] has quit [Ping timeout: 265 seconds]
20161025 19:12:28-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161025 19:12:40-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161025 19:18:33-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161025 19:20:58-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161025 19:25:58-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 19:28:28-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161025 19:33:08< vultraz> DeFender1031: likely that was bad coding on dugi's part
20161025 19:33:28< vultraz> DeFender1031: most likely what happened was he didn't use horizontal/vertical_grow = true to make the image widget grow to all available space
20161025 19:33:44< vultraz> DeFender1031: or he only reserved the size of 1 72x72 image
20161025 19:34:42< vultraz> in GUI2 WML one might use the GUI_FORCE_WIDGET_MINIMUM_SIZE macro
20161025 19:35:00< vultraz> or one could simply make the window fixed-size and make the dialog grow
20161025 19:35:02< vultraz> er
20161025 19:35:05< vultraz> the image widgets grow
20161025 19:35:20< vultraz> DeFender1031: remember, widgets only take up as much space as they initially need unless grow is specified
20161025 19:35:23-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 19:35:39< vultraz> DeFender1031: if the initial canvas space is indeed only 72x72, then yes, the image won't display
20161025 19:35:43-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161025 19:35:45< vultraz> if it's bigger than that
20161025 19:36:55< vultraz> if the space were bigger but grow *not* specified, the image widget canvas would still only be the size of the first widget assigned to it
20161025 19:36:55-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161025 19:37:07< vultraz> which is why grow is so important 
20161025 19:38:24< DeFender1031> vultraz, my point exactly. Either the dialog is huge from the start even for icon-sized images, or it won't grow for portrait-sized ones.
20161025 19:38:48-!- mordante [~mordante@wesnoth/developer/mordante] has quit [Quit: Leaving]
20161025 19:38:53< vultraz> DeFender1031: in c++ one calls window.invalidate_layout() to recalculate size
20161025 19:39:01< DeFender1031> yeah, this is a lua add on
20161025 19:39:19< vultraz> DeFender1031: in this case, the dialog *is* a good candidate for recalculation, and as such the call would be acceptable
20161025 19:39:38< vultraz> DeFender1031: you could ask celticminstrel to add a lua wrapper for invalidate_layout
20161025 19:40:30< DeFender1031> vultraz, right. that's what i was saying. The only workaround currently is, like I said, to close and re-open the dialog with the new image on each refresh.
20161025 19:41:13< vultraz> I *could* make images always scale to fit their canvas size, or image size if smaller
20161025 19:41:22< vultraz> I'm not sure if that's good behavior or not
20161025 19:41:34< DeFender1031> vultraz, It would certainly be nice to have celticminstrel do that for future versions, but it doesn't actually help me right now unless I take the plunge and finally shift my development to 1.13
20161025 19:42:29< DeFender1031> vultraz, is there a reason that when images or text are modified, the geometry shouldn't simply be recalculated automatically?
20161025 19:43:08< vultraz> DeFender1031: the ability to recalculate canvas dimensions without affecting that of other widgets was never implemented
20161025 19:43:15< vultraz> canvas dimensions of a widget*
20161025 19:43:40< vultraz> and, in fact, in most cases you either need to recalculate everything or nothing ata ll
20161025 19:43:42< vultraz> at all*
20161025 19:43:56< DeFender1031> and would that be terrible?
20161025 19:44:12< vultraz> yes, one does not want to recalculate everything
20161025 19:44:27< DeFender1031> seems like that'd be what you want in the majority of cases of contents changing size
20161025 19:45:13< DeFender1031> also, if whatever it is is inside something with a scrollbar, wouldn't the recalculating be contained to that widget?
20161025 19:46:42< vultraz> DeFender1031: to help you in your development at least, you can add these two lines to 1.12/data/gui/default/widget/image_default.cfg:27 in your local copy: w = "(if(image_width > width, width, image_width))" h = "(if(image_height > height, height, image_height))"
20161025 19:46:47< vultraz> (I think that would work)
20161025 19:46:52< vultraz> DeFender1031: now, about scrollbars..
20161025 19:47:08< vultraz> DeFender1031: content in a scrollbar panel actually does use invalidate_layout internally
20161025 19:47:12< vultraz> er
20161025 19:47:15< vultraz> let me rephrase that
20161025 19:47:38< vultraz> the scrollbar container does use invalidate_layout in certain places pertaining to its scrollbar calculation 
20161025 19:48:01< vultraz> so it's not specifically contained to that widget.
20161025 19:48:17< DeFender1031> is that lua or WML with WFL strings?
20161025 19:48:25< vultraz> WMl with WFL strings
20161025 19:48:28< DeFender1031> ah
20161025 19:48:28< vultraz> WML*
20161025 19:49:14< vultraz> note that will make portrait-size images 72x72 or whatever the canvas size is but they'll at least display :P
20161025 19:49:28< vultraz> anyway, back to scrollbars
20161025 19:49:44< vultraz> it is possible to avoid the adverse affects of such calls with careful use of grow and grow_factor
20161025 19:50:04-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 19:50:19< vultraz> but indeed you're right that a recalculation of the area *should* apply to the widget locally
20161025 19:50:23< vultraz> but that was never implemented 
20161025 19:50:44< vultraz> I think there's framework there to do so, but it was never finished.
20161025 19:50:54< DeFender1031> i hesitate to do anything that will permanently change a behavior in ways that won't be consistent with other copies. It also doesn't help for text resizing. (This is also all purely theoretical right now, as I don't currently have any practical cases where I need resizing that i haven't been able to work around with pages or refreshing the whole dialog.
20161025 19:50:57< DeFender1031> )
20161025 19:51:32< vultraz> well, up to you
20161025 19:51:37< vultraz> just saying it's an option
20161025 19:51:43< vultraz> i might do a similar thing in master, I'm not sure
20161025 19:52:01< DeFender1031> Thanks. I'll keep it in my logs and the back of my mind in case it's every useful
20161025 19:52:28< DeFender1031> it's still unclear to me why recalculating the full geometry on a content change would be detrimental
20161025 19:52:34< vultraz> (if you're in 1.13 you can use min(width, image_width) instead)
20161025 19:53:09< DeFender1031> shouldn't content in a certain state look identical no matter how it got to that state?
20161025 19:53:18< vultraz> DeFender1031: well, the biggest reason is in the majority of cases, you do *not* want the *window* size to change
20161025 19:53:46< vultraz> DeFender1031: secondly, you also do not often want the position of widgets to change within a window
20161025 19:53:52< vultraz> for example
20161025 19:54:07< vultraz> say you have text and an image
20161025 19:54:18< vultraz> do you want the image to move if the text become shorter?
20161025 19:54:20< vultraz> not really
20161025 19:54:55< DeFender1031> wait, you're saying that recalculating the geometry will recalculate not only the particular dialog that my code may currently have opened, but EVERYTHING from the window on down?
20161025 19:55:21< vultraz> Now, since I recently fixed fixed-size windows and their positioning on screen (1.13 master only, ofc :P), the first point matters a little less
20161025 19:55:26< vultraz> DeFender1031: no, I mean everything in that particular dialog
20161025 19:55:36< vultraz> DeFender1031: most dialogs in wesnoth are dynamic-sized
20161025 19:55:37< vultraz> not fixed
20161025 19:55:39< DeFender1031> ah
20161025 19:55:43< DeFender1031> right
20161025 19:55:56< DeFender1031> though, there ARE cases where I'd want the dialog size to change.
20161025 19:56:06< vultraz> right
20161025 19:56:13< vultraz> but 98% of the time you don't
20161025 19:56:17< DeFender1031> heck, the :inspect dialog changes size all the time depending on the content of what's being inspected
20161025 19:56:26< vultraz> not so much in master
20161025 19:56:51< vultraz> :)
20161025 19:56:56< DeFender1031> right, yeah, if the dialog's outer geometry is not fixed, then i agree, recalculating on every change would be horrible.
20161025 19:57:10< vultraz> Exactly
20161025 19:57:19< vultraz> if the outer geometry IS fixed, however, we come to issue 2
20161025 19:57:22< DeFender1031> really? I actually liked it like that, but I might just be a weirdo.
20161025 19:57:23< vultraz> the internal geometry 
20161025 19:57:40< vultraz> as i said, you often don't want THAT changing either
20161025 19:58:00< DeFender1031> right. though in terms of internal geometry, i'd think there are a lot of cases where you do want it to move and a lot where you don't
20161025 19:58:15< DeFender1031> certainly a lot more than you'd want to change the outer geometry
20161025 19:58:18< vultraz> in general UX terms, items should not move unless necessary
20161025 19:58:31< DeFender1031> absolutely.
20161025 19:58:40< DeFender1031> but take, for example, a listbox
20161025 19:59:42< DeFender1031> if a row is modified such that it has larger content, you probably DO want that recalculated, and it recalculation isn't going to affect the outer geometry of the listbox, it'll just affect the outer geometry of the one row and the overall length of the scrollable content within the box.
20161025 20:00:39< vultraz> yes, listboxes use scroll containers and as such are privy to the geometry recalculation 
20161025 20:01:05< vultraz> the problem is that recalculation recalculates *everything*
20161025 20:01:17< vultraz> so stuff may move that you don't want
20161025 20:01:25< DeFender1031> i guess what i'm saying is that ideally, internal geometries in self-contained widgets ought to auto-refresh their own geometry.
20161025 20:01:29< DeFender1031> right
20161025 20:01:35-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161025 20:01:35< vultraz> take, for example, GUI2 mp create in master
20161025 20:01:49< vultraz> you can change contents by changing game type
20161025 20:01:50< DeFender1031> though that can be avoided by making sure you never changing anything in a way that it forces anything else to recalculate.
20161025 20:01:55< DeFender1031> (such as using pages)
20161025 20:02:06< vultraz> sometimes, the new content takes up less width
20161025 20:02:26< vultraz> now, normally, no recalculation happens
20161025 20:02:43< vultraz> but if it does because of some effect of another widget, then the listbox will get thinner
20161025 20:03:02< vultraz> that was a major bane when designing the dialog :|
20161025 20:03:17< vultraz> had to make some changes to certain widgets to ensure they kept their width
20161025 20:03:34< DeFender1031> i guess since any such content change would naturally be the result of a user action (such as clicking on a button), i'm less bothered by geometry changing than I would be if it were, say, a webpage with a dynamic updater that can randomly move a button around at any time.
20161025 20:03:46< vultraz> DeFender1031: you're absolutely right that a localized geometry change should take precedence over a dialog-wide one
20161025 20:03:53< vultraz> but as I said, the code was never finished
20161025 20:04:16< DeFender1031> right, i think we can all agree on that point at least.
20161025 20:04:55< vultraz> just be glad you're just working in lua and don't have to deal with these eccentricities in master ;P
20161025 20:05:16< DeFender1031> there's also all sorts of potential things where you might want certain geometry recalculated if the new content is larger, but not if it is smaller.
20161025 20:05:30< vultraz> yup
20161025 20:06:21< DeFender1031> for example, with the image tester example, if the new image you're testing is larger than the one that was there previous, i'd want the window to grow to accommodate it, but once we've grabbed that real-estate, we can stay there because why not?
20161025 20:08:00< DeFender1031> there's also the fact that even if a widget technically DOES have the space to expand, it still doesn't, probably because of the lack of localized geometry (for example, a row with two columns, one which has 15 lines of text, one which has 2, and then changing the one with 2 to have 4, only the first two lines will display, even though there's technically another 13 lines worth)
20161025 20:09:56< DeFender1031> given the image test example, having a lua hook for recalculating would work, as one could wrap it in an "if wesnoth.get_image_size(newimage) > wesnoth.get_image_size(oldimage)"
20161025 20:10:05< vultraz> DeFender1031: that;s why you would use vertical_grow = true to make sure both have all available space
20161025 20:10:13< vultraz> you don't need geometry recalculations for that :)
20161025 20:10:53< DeFender1031> IIRC, I tried that at some point and ran into a different geometry bug with it, though I'm currently at a loss as to what exactly it was
20161025 20:12:19< DeFender1031> oh, right, it was that it helped, but didn't solve the issue for my case as well as pages since the text could still be larger than its sibling.
20161025 20:12:43< DeFender1031> though, that brings up an interesting question. Is there ever a case where you DON'T want grow?
20161025 20:12:45< vultraz> both would need that
20161025 20:12:55< vultraz>  yes
20161025 20:12:58-!- irker038 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161025 20:13:10< vultraz> for widgets like labels, you almost always want grow
20161025 20:13:21< vultraz> but fixed-text labels can just use alignment=
20161025 20:13:21< vultraz> and not grow+
20161025 20:13:22< vultraz> =
20161025 20:13:36< vultraz> also, other widgets like text boxes usually don't use grow
20161025 20:13:49< vultraz> since else they'll stretch to fill all available horizontal space :P
20161025 20:14:44< DeFender1031> that's a reason why it's not necessary, not a reason why it would be detrimental though.
20161025 20:15:04< DeFender1031> I'm just wondering whether there's really a case where grow would actively BREAK something.
20161025 20:15:14< DeFender1031> And if not, why is it not just default behavior?
20161025 20:15:20< vultraz> likely not but I cannot say for sure
20161025 20:15:54< vultraz> (I should teach a class on GUI2 101 :P )
20161025 20:16:18< vultraz> anyway
20161025 20:16:20< vultraz> im out
20161025 20:16:27< vultraz> for a bit
20161025 20:16:37< vultraz> want to go get breakfast early
20161025 20:18:15< vultraz> DeFender1031: as for why it's not default, it's because it allows greater control over layout
20161025 20:19:30< DeFender1031> fair enough. Enjoy your breakfast.
20161025 20:28:43-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 20:32:45-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161025 20:34:45-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 265 seconds]
20161025 20:36:12-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161025 20:38:50-!- VultCave [~chatzilla@124.109.10.167] has quit [Ping timeout: 250 seconds]
20161025 20:42:20-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 20:54:09-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 20:54:46-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161025 20:54:53-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 20:57:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161025 21:12:54-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161025 21:14:02-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161025 21:15:41-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20161025 21:34:16-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161025 21:41:03-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161025 21:41:44-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161025 21:47:40-!- irker764 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161025 21:47:40< irker764> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox a3c8c976b01a / / (8 files in 3 dirs): WIP: a widget that forces its child widget to a fixed size https://github.com/wesnoth/wesnoth/commit/a3c8c976b01a4e835daacb8de7afa169476a64a7
20161025 21:53:29-!- JyrkiVesterinen [~JyrkiVest@87-100-244-13.bb.dnainternet.fi] has quit [Quit: Going to bed]
20161025 21:58:45-!- louis94 [~~louis94@91.178.241.241] has joined #wesnoth-dev
20161025 21:58:49-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 276 seconds]
20161025 22:14:09-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161025 22:17:49-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161025 22:24:48-!- travis-ci [~travis-ci@ec2-54-147-180-243.compute-1.amazonaws.com] has joined #wesnoth-dev
20161025 22:24:49< travis-ci> wesnoth/wesnoth#11754 (fixed-size-chatbox - a3c8c97 : Jyrki Vesterinen): The build failed.
20161025 22:24:49< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/170601948
20161025 22:24:49-!- travis-ci [~travis-ci@ec2-54-147-180-243.compute-1.amazonaws.com] has left #wesnoth-dev []
20161025 22:26:58< tad_carlucci> celticminstrel, About PR 841 and adding the flag value. The parameter is passed by reference, so the flag is needed to indicate that it's not to be used.
20161025 22:31:42-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161025 22:36:49< Neoriceisgood> https://snag.gy/3w8lZK.jpg progress on toy faction
20161025 22:44:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161025 22:44:29-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: mattsc]
20161025 23:01:30-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161025 23:05:53-!- Neoriceisgood [5658167a@gateway/web/freenode/ip.86.88.22.122] has quit [Quit: Page closed]
20161025 23:19:21-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161025 23:42:52< vultraz> celticminstrel: pure virtual functions have no implementation in the base class, correct?
20161025 23:47:20-!- louis94 [~~louis94@91.178.241.241] has quit [Ping timeout: 244 seconds]
20161025 23:49:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
--- Log closed Wed Oct 26 00:00:35 2016