--- Log opened Wed Nov 02 00:00:06 2016
20161102 00:11:04-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds]
20161102 00:28:30-!- Bonobo [~Bonobo@2001:44b8:254:3200:ec79:4a1f:c1c4:f957] has joined #wesnoth-dev
20161102 00:30:08-!- Bonobo [~Bonobo@2001:44b8:254:3200:ec79:4a1f:c1c4:f957] has quit [Client Quit]
20161102 00:30:30-!- Bonobo [~Bonobo@2001:44b8:254:3200:ec79:4a1f:c1c4:f957] has joined #wesnoth-dev
20161102 00:30:32-!- irker118 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161102 00:34:56-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161102 00:40:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161102 00:52:32-!- louis94 [~~louis94@91.178.241.185] has quit [Ping timeout: 250 seconds]
20161102 01:04:39-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161102 01:06:29< vultraz> what did you mean by
20161102 01:06:32< vultraz> 20161101 21:59:52< celticminstrel> [Nov 01@5:27:05pm] vultraz: using clear() on a vector of pointers deletes the pointers, right?
20161102 01:06:33< vultraz> 20161101 21:59:53< celticminstrel> Uhh. No.
20161102 01:08:25< celticminstrel> Using clear() on a vector of pointers just empties the vector. It doesn't do anything with the referenced objects.
20161102 01:08:49-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-pifwupgxfraadajv] has quit [Ping timeout: 260 seconds]
20161102 01:09:18< vultraz> I don't want to do anything with the objects
20161102 01:09:40< celticminstrel> Then go ahead and use clear()?
20161102 01:09:57< celticminstrel> I'm assuming a vector of raw pointers here.
20161102 01:10:09< celticminstrel> Clearing a vector calls the destructor for each element of the vector.
20161102 01:10:24< celticminstrel> The destructor for any built-in type (including pointers) is a no-op.
20161102 01:10:33< celticminstrel> But if you use smart pointers then it might delete the pointer.
20161102 01:10:40< celticminstrel> unique_ptr definitely would.
20161102 01:10:52< celticminstrel> shared_ptr may or may not, depending on whether something else references it.
20161102 01:11:48< vultraz> didn't jyrki said it DID delete the pointers :|
20161102 01:12:03< celticminstrel> Not sure, probably not.
20161102 01:13:01< celticminstrel> If you have a "vector<T*> vec", then vec.clear() does nothing with the objects that those pointers reference.
20161102 01:13:12< celticminstrel> The objects are still in memory.
20161102 01:13:15< vultraz> Yes
20161102 01:13:18< vultraz> I want that
20161102 01:13:25< celticminstrel> Okay, then go ahead with clear.
20161102 01:13:39< celticminstrel> Assuming you have a vector<T*>.
20161102 01:13:41< vultraz> yes
20161102 01:14:05< vultraz> also, I do you recommend using that boost::adapters::reverse thing or rbegin/rend?
20161102 01:14:19< celticminstrel> Whichever you think looks better?
20161102 01:14:24< celticminstrel> They should be entirely equivalent.
20161102 01:14:40< celticminstrel> Presumably rbegin/rend implies a regular for-loop rather than range-for.
20161102 01:15:22< vultraz> ok
20161102 01:15:30< vultraz> just checking there wasn't some difference
20161102 01:18:44-!- matthiaskrgr [matthiaskr@gateway/shell/panicbnc/x-vxexkgpezshdoezy] has joined #wesnoth-dev
20161102 01:19:08-!- matthiaskrgr is now known as Guest66535
20161102 02:44:52-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161102 02:50:33-!- VultCave [~chatzilla@124.109.10.167] has joined #wesnoth-dev
20161102 02:50:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20161102 02:50:55-!- VultCave is now known as vultraz
20161102 02:52:00-!- vultraz [~chatzilla@124.109.10.167] has quit [Changing host]
20161102 02:52:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161102 03:03:11-!- Jetrel [~Jetrel@2001:558:6014:1e:2422:435:dd84:bbf3] has joined #wesnoth-dev
20161102 03:30:29-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161102 03:32:06< vultraz> consttexptrrrr
20161102 03:45:30< vultraz> meh, no need for constexpr
20161102 03:53:33< vultraz> blahhh
20161102 03:53:43< vultraz> code y u no work
20161102 03:56:50< vultraz> oh... hm...
20161102 03:58:03 * vultraz curses
20161102 04:00:18< vultraz> code WOULD have worked before i had to move it
20161102 04:03:21< vultraz> oh wait no, it wouldn't
20161102 04:03:24 * vultraz ponders ponders
20161102 04:08:13< vultraz> celticminstrel: what is the behavior of min/max when the values are equal?
20161102 04:08:41< celticminstrel> Uh. Shouldn't that be obvious?
20161102 04:09:40< vultraz> do no values change, i should say.
20161102 04:09:41< celticminstrel> (Also note that we don't really support constexpr.)
20161102 04:09:59< celticminstrel> Uh. Doesn't min/max pass by value?
20161102 04:10:18< celticminstrel> Or maybe const reference.
20161102 04:10:54< vultraz> no, I mean, say I have int foo = 10; foo = max<1,1>; will foo still be 10?
20161102 04:11:31< celticminstrel> Well, that won't compile.
20161102 04:11:55< celticminstrel> And if you meant max(1,1) the answer should be very obvious.
20161102 04:12:14< celticminstrel> (Hint: It's "no")
20161102 04:12:33< Sirp> vultraz: max(x,x) will give you 'x'
20161102 04:12:38< celticminstrel> (I don't know why anyone would thing it.)
20161102 04:12:38< Sirp> if that's your question
20161102 04:12:40< celticminstrel> ^think
20161102 04:13:02< vultraz> blagh
20161102 04:13:30< celticminstrel> If you just think about it this should be very obvious.
20161102 04:13:41< celticminstrel> It's basic math.
20161102 04:14:01< vultraz> it should be but you never know if the function had some weird side effect
20161102 04:14:11< celticminstrel> It's basic math. There won't be any side-effect.
20161102 04:14:29< celticminstrel> Math functions don't have side-effects.
20161102 04:15:07< celticminstrel> (Except maybe divmod, if you count altering a reference parameter as side-effects.)
20161102 04:15:17< celticminstrel> (And similar functions.)
20161102 04:15:33< celticminstrel> (Technically a pointer parameter, but same intent.)
20161102 04:15:35< vultraz> I'm *just checking* :|
20161102 04:15:40< celticminstrel> You're being paranoid.
20161102 04:16:26< vultraz> yes, well I've spent hours trying to figure out how to work on what I'm working on and don't really want to write a bunch of stuff it only to discover it doesn't work because i didn't realize std::max did something weird
20161102 04:16:34< vultraz> if*
20161102 04:16:44< celticminstrel> It's max. There's no reason to think it does anything weird.
20161102 04:17:13< shadowm> http://en.cppreference.com/w/cpp/algorithm/max
20161102 04:17:32< shadowm> All const references. There isn't room for side-effects here.
20161102 04:17:40< celticminstrel> If there's one thing weird about it it's that it only has one template parameter (which is why you usually need to specify them manually).
20161102 04:17:47< celticminstrel> ^specify it
20161102 04:17:53< celticminstrel> (Or static_cast)
20161102 04:18:42< celticminstrel> There might be good reasons for that, I suppose.
20161102 04:18:50< celticminstrel> But I personally just find it annoying.
20161102 04:19:28< Sirp> celticminstrel: the reason it only has one template parameter is because what would the return type be if it had two?
20161102 04:19:46< celticminstrel> Sirp: I'd expect something like decltype(a+b)
20161102 04:20:24< Sirp> celticminstrel: yes but it returns by reference for performance
20161102 04:20:26< celticminstrel> But that's a valid question, because that didn't exist in the standard at the time max was defined.
20161102 04:20:37 * celticminstrel shrugs.
20161102 04:21:05< Sirp> yes but even if it did it returns by reference
20161102 04:21:19< Sirp> it's kind of an "open question" which way the best way to define min and max is
20161102 04:21:24< celticminstrel> There's really no reason for it to return by reference, at least for built-in numeric types.
20161102 04:21:31< Sirp> there's even a pretty good argument that min and max are best done as (ugh) templates
20161102 04:21:39< Sirp> sure, not for numeric types.
20161102 04:21:39< celticminstrel> Well, it is a template. :P
20161102 04:24:27< Sirp> this is a kinda dated-but-still-relevant article on the whole mess: http://www.drdobbs.com/generic-min-and-max-redivivus/184403774
20161102 05:12:16-!- irker934 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161102 05:12:17< irker934> wesnoth: Celtic Minstrel wesnoth:master a9dd8da443b8 / changelog src/scripting/lua_kernel_base.cpp: New Lua function to match WML against a filter https://github.com/wesnoth/wesnoth/commit/a9dd8da443b86c75c9f92a0165ec0eee7c57f910
20161102 05:20:04< vultraz> ok, I think i figured out what to do
20161102 05:20:12< vultraz> just need to figure out how best to do it
20161102 05:21:14< vultraz> class member variables..
20161102 05:21:21< vultraz> or static namespace variables
20161102 05:23:26-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161102 05:39:43-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161102 05:50:14-!- travis-ci [~travis-ci@ec2-54-159-244-171.compute-1.amazonaws.com] has joined #wesnoth-dev
20161102 05:50:15< travis-ci> wesnoth/wesnoth#11828 (master - a9dd8da : Celtic Minstrel): The build has errored.
20161102 05:50:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/172508870
20161102 05:50:15-!- travis-ci [~travis-ci@ec2-54-159-244-171.compute-1.amazonaws.com] has left #wesnoth-dev []
20161102 06:03:10-!- JyrkiVesterinen [~JyrkiVest@87-100-218-184.bb.dnainternet.fi] has joined #wesnoth-dev
20161102 06:11:23-!- Nikitaw99 [2e00d835@gateway/web/freenode/ip.46.0.216.53] has joined #wesnoth-dev
20161102 06:27:45-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161102 07:41:47-!- JyrkiVesterinen [~JyrkiVest@87-100-218-184.bb.dnainternet.fi] has quit [Quit: .]
20161102 07:54:54-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: ancestral]
20161102 08:05:31-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161102 08:05:37-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161102 08:06:01-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161102 08:07:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 08:11:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20161102 08:24:42-!- Appleman1234 [~Appleman1@KD106161196101.au-net.ne.jp] has quit [Ping timeout: 261 seconds]
20161102 08:37:01-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161102 08:46:45-!- Guest66535 [matthiaskr@gateway/shell/panicbnc/x-vxexkgpezshdoezy] has quit [Changing host]
20161102 08:46:45-!- Guest66535 [matthiaskr@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161102 08:46:45-!- Guest66535 [matthiaskr@unaffiliated/matthiaskrgr] has quit [Changing host]
20161102 08:46:45-!- Guest66535 [matthiaskr@gateway/shell/panicbnc/x-vxexkgpezshdoezy] has joined #wesnoth-dev
20161102 08:46:53-!- Guest66535 is now known as matthiaskrgr
20161102 08:48:03-!- Appleman1234 [~Appleman1@KD106161197252.au-net.ne.jp] has joined #wesnoth-dev
20161102 08:50:21< vultraz> ok, I think this code finally works
20161102 08:51:17< vultraz> rather complex, it is
20161102 08:51:22< vultraz> document it, I should
20161102 08:58:11< irker934> wesnoth: Charles Dang wesnoth:master 9fcc726d7255 / src/gui/widgets/tree_view_node.hpp: Tree View Node: add child type alias and implement operator== https://github.com/wesnoth/wesnoth/commit/9fcc726d72556f9a8fa022deae8a4e4b836a8f07
20161102 08:58:14< irker934> wesnoth: Charles Dang wesnoth:master 508677953528 / src/gui/widgets/ (tree_view.cpp tree_view.hpp): Tree View: cleaned up remove_node and made it return the removed node's position https://github.com/wesnoth/wesnoth/commit/50867795352861762ebe4b42da8e13b0ecb9b3ee
20161102 08:58:17< irker934> wesnoth: Charles Dang wesnoth:master 97a3188d8cd4 / src/gui/widgets/ (tree_view.cpp tree_view.hpp): Tree View: allow add_node to forward a third index argument to ttree_view_node:: https://github.com/wesnoth/wesnoth/commit/97a3188d8cd42714fc72026b2586c765a2087088
20161102 08:58:20< irker934> wesnoth: Charles Dang wesnoth:master a389d7c59d6b / src/gui/dialogs/ (4 files in 2 dirs): MP Options Helper: refactoring to prevent the entire tree being recreated every  https://github.com/wesnoth/wesnoth/commit/a389d7c59d6b3b3dfbf96d41c6087b38c0d24cb1
20161102 08:58:28< vultraz> That took *way too long* to write.
20161102 09:01:00< vultraz> possibly because I decided I wanted to write to generalize the storage of the node vectors 
20161102 09:01:30< vultraz> Even though I then decided to add specialized code :P
20161102 09:01:32< vultraz> but oh well
20161102 09:02:26< vultraz> s/to write//
20161102 09:03:20< vultraz> still, rather happy with how it turned out
20161102 09:03:41< vultraz> any new source type automatically gets its own vector for nodes
20161102 09:04:06< vultraz> hmmmm... actually, I might have overlooked something minor
20161102 09:04:34< vultraz> hm
20161102 09:04:48< vultraz> yes, now that I think of it, I think it's very possible there's a memory leak in my code
20161102 09:04:50< vultraz> :(
20161102 09:05:48< vultraz> since game types have two source ids, it's possible a pointer to a node is never deleted if one were to, say,  select an sp game after an mp game.
20161102 09:06:08< vultraz> hmmm
20161102 09:06:19< vultraz> or would it?
20161102 09:06:52< vultraz> I assume a vector's clear() function (or some equivalent) is called when its destroyed 
20161102 09:07:23< vultraz> so I guess it could be safe
20161102 09:07:25< vultraz> hmm
20161102 09:08:13< JyrkiVesterinen> You are right, the destructor of std::vector destroys all objects inside the vector.
20161102 09:08:41< vultraz> ahh ok
20161102 09:08:43< vultraz> good
20161102 09:34:52-!- travis-ci [~travis-ci@ec2-54-242-141-122.compute-1.amazonaws.com] has joined #wesnoth-dev
20161102 09:34:53< travis-ci> wesnoth/wesnoth#11829 (master - a389d7c : Charles Dang): The build passed.
20161102 09:34:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/172544671
20161102 09:34:53-!- travis-ci [~travis-ci@ec2-54-242-141-122.compute-1.amazonaws.com] has left #wesnoth-dev []
20161102 09:36:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161102 09:39:02-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161102 09:39:37-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Client Quit]
20161102 09:55:35-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 09:59:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161102 10:13:04< vultraz> JyrkiVesterinen: thanks for looking the commits over
20161102 10:13:15< JyrkiVesterinen> You're welcome. :)
20161102 10:26:22< irker934> wesnoth: Charles Dang wesnoth:master 96dfebcb776f / src/gui/ (dialogs/multiplayer/mp_options_helper.cpp widgets/tree_view.cpp): Minor cleanup, per feedback https://github.com/wesnoth/wesnoth/commit/96dfebcb776f2f0a3274ba0337fb3d00e92be696
20161102 11:06:46-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161102 11:12:24-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161102 11:29:37-!- Bonobo [~Bonobo@2001:44b8:254:3200:ec79:4a1f:c1c4:f957] has quit [Quit: Leaving]
20161102 11:43:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 11:48:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161102 11:54:08-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161102 12:02:22< irker934> wesnoth: Gregory A Lundberg wesnoth:master 1194ee751ef2 / src/filesystem_common.cpp: Fix bug: use of undeclared identifier LOCALEDIR https://github.com/wesnoth/wesnoth/commit/1194ee751ef2e50f1c61221ab0ea8a8d94b28eea
20161102 12:02:23< irker934> wesnoth: Charles Dang wesnoth:master d01bc02d56b8 / src/filesystem_common.cpp: Merge pull request #855 from GregoryLundberg/GL_missing_header https://github.com/wesnoth/wesnoth/commit/d01bc02d56b8d3a80734daf812afbb0e98c7cbec
20161102 12:13:20< zookeeper> huff, puff. i've been staring at these castles and walls for about two days now, and am almost done.
20161102 12:14:03 * vultraz does not envy
20161102 12:14:42< zookeeper> my F5 key might wear out soon from all the refreshing in the editor
20161102 12:15:10-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161102 12:24:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161102 12:30:50-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161102 12:40:34-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161102 12:50:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161102 12:54:04< Nikitaw99> zookeeper: so you use wesnoth umc dev too? :p
20161102 12:54:14-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161102 12:55:53-!- Nikitaw99 [2e00d835@gateway/web/freenode/ip.46.0.216.53] has quit [Quit: Page closed]
20161102 12:57:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161102 13:01:29< loonycyborg> vultraz: I've thought a bit about lobby, and I think I know what is needed to implement things in the way you want
20161102 13:01:58< loonycyborg> the player db could have extra "field" to track if it's still in a lobby
20161102 13:02:55< loonycyborg> but message tag would need to be extended
20161102 13:03:09< loonycyborg> to specify whether it's for game and for lobby
20161102 13:03:15< loonycyborg> *or
20161102 13:05:20< loonycyborg> about multiple rooms, it'll probably take a lot of work
20161102 13:05:44< loonycyborg> game.cpp is handling a lot of room-like functionality
20161102 13:06:34< loonycyborg> And I still don't understand it very well
20161102 13:25:22-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161102 14:15:21-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161102 14:23:02-!- Appleman1234 [~Appleman1@KD106161197252.au-net.ne.jp] has quit [Ping timeout: 250 seconds]
20161102 14:36:45-!- stikonas_ is now known as stikonas
20161102 14:57:18-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161102 15:02:52-!- irker934 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161102 15:31:38-!- gfgtdf [~chatzilla@x4e363156.dyn.telefonica.de] has joined #wesnoth-dev
20161102 16:04:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 16:07:04-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 16:07:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Read error: Connection reset by peer]
20161102 16:30:19< celticminstrel> Was the question of whether libintl support can be dropped ever settled?
20161102 16:30:30< celticminstrel> If it can't be dropped, it should be fixed.
20161102 16:31:02< celticminstrel> (Currently I believe it will cause a link error for missing compare and icompare symbols.)
20161102 16:32:10< shadowm> Since no-one responded to me back then as far as I could tell, I'd just send an email to the ML and give people a last chance to give me at least one valid reason to keep it.
20161102 16:32:33< shadowm> Except if I do that myself I probably won't get to it before Sunday.
20161102 16:32:59< celticminstrel> I suppose I could shoot off a quick mail...
20161102 16:33:39< celticminstrel> Wasn't Android or something the main reason for it originally?
20161102 16:40:47< celticminstrel> Does this sound okay? "In the past, Wesnoth has supported building with libintl in place of Boost.Locale. This has gone unmaintained recently, however, and the most active devs are of the opinion that it can be dropped. However, before doing so, there is one question that needs to be answered: is any distribution still using a libintl build?"
20161102 16:45:50< shadowm> The original reason was OpenPandora (which was dropped) and OS X (because we didn't want to force the packagers to update their Boost builds, but that's obviously been done since then due to the C++11 mess).
20161102 16:45:57< shadowm> *and IIRC OS X
20161102 16:46:31< shadowm> (Remember that this was in the context of version 1.11.19 and a lot of things regarding 1.13.x hadn't been decided or happened yet.)
20161102 16:47:13< shadowm> Android hasn't ever been a concern for anything with regards to mainline because it's not a platform that mainline Wesnoth targets.
20161102 16:59:10< gfgtdf> i do think that android is a valid reason to keep it. Afaik there is a working android port end even if we don't mainthin it ourself we shdouldn't break it for no reason.
20161102 17:00:22< vultraz> There is no 1.13 android port
20161102 17:00:30< vultraz> at least, not that i know of
20161102 17:01:03< gfgtdf> vultraz: hmm you think that the 1.12 port technique couldn't easily applied to 1.13 ?
20161102 17:01:21< vultraz> I have no idea
20161102 17:01:34< gfgtdf> I also think that it woudlbt be too hard to keep it afaik the oynl commit that break the libintil complation are 0cd131b5375 and 8508b42bed2 which woudl mostlikeley be simple to add to the gettext.cpp file aswell.
20161102 17:01:45< vultraz> 1.13 has diverged so much from 1.12, so the answer is likely no
20161102 17:02:26< celticminstrel> What is the 1.12 port technique?
20161102 17:02:28< gfgtdf> one would have to ask alep though wtehert its still 'boost::locale for android is quite a pain'
20161102 17:02:33< gfgtdf> celticminstrel: not sure
20161102 17:02:48< celticminstrel> Then how can you expect us to answer whether it could easily be applied to 1.13?
20161102 17:03:30< vultraz> Leave the discussion of port maintainers to the Board.
20161102 17:03:53< celticminstrel> That doesn't seem like something the Board needs to care about to me.
20161102 17:03:57< gfgtdf> celticminstrel: hmm just becasue i dont know doesnt means that you don't know eigher. I mean that's why i asked.
20161102 17:04:27< celticminstrel> At least, it has nothing to do with funds.
20161102 17:05:15-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161102 17:06:18< shadowm> gfgtdf: If you care about the Android port then you should ask the porter to work more closely with mainline on this kind of thing.
20161102 17:07:12< shadowm> I wouldn't ask the mainline devs to constantly make guesses as to how not to break a port that isn't even developed by the team.
20161102 17:07:22< vultraz> ^ that would be the optimal state of things
20161102 17:07:33< shadowm> If Boost.Locale is a problem then what about C++11 or SDL 2, which already happened?
20161102 17:08:00< shadowm> Or for that matter, Boost.Filesystem? (I removed the legacy implementation of the fs API early on.)
20161102 17:08:20< vultraz> We need someone who knows android to tell us these things.
20161102 17:08:26< gfgtdf> shadowm: the porter explictly said that boost.filesystem isnt a problem.
20161102 17:08:34< vultraz> I have been told that SDL2 was beneficial for an iOS port, though
20161102 17:08:56< shadowm> What about the multitude of changes that don't affect compilation? (e.g. everything to do with how we use SDL.)
20161102 17:10:07< gfgtdf> shadowm: i guess we can ship 1.13.6 without libintl support and see if somone complains.
20161102 17:10:29-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 17:10:31< celticminstrel> Hmm, looks like it was already removed.
20161102 17:11:12< gfgtdf> celticminstrel: there is  still the gettext.cpp file
20161102 17:11:21< celticminstrel> Apparently not.
20161102 17:11:36< gfgtdf> celticminstrel: https://github.com/wesnoth/wesnoth/blob/master/src/gettext.cpp
20161102 17:11:41< celticminstrel> ...
20161102 17:11:49< celticminstrel> Oh! I must've removed it on this branch.
20161102 17:11:51< shadowm> Anyway, the first thing I said there is important. Either mainline and Android cooperate (ideally the Android port's codebase should be the same as mainline's, i.e. maintained by the porter in mainline the same way OS X or Windows are) or mainline shouldn't constantly worry about such an abstract issue.
20161102 17:11:52< celticminstrel> Never mind then.
20161102 17:12:06-!- Samual [~Samual@xonotic/core-team/Samual] has joined #wesnoth-dev
20161102 17:13:07< shadowm> Otherwise you might as well bring OpenPandora back to have a marginally less abstract issue to worry about.
20161102 17:13:26 * vultraz cries
20161102 17:14:00< celticminstrel> Since no-one objected to what I quoted, I guess I'll go ahead and send that to the ML?
20161102 17:14:49< shadowm> No objections here.
20161102 17:15:24< shadowm> Again, if people could cope with C++11 and SDL 2 (in some cases by dropping support entirely) then they should be able to cope with Boost.Locale.
20161102 17:17:58< tad_carlucci> What's the issue with an Android build? Just the person doing it isn't around?
20161102 17:19:15< shadowm> That it's not part of mainline and the person doing it isn't constantly in touch with the mainline devs.
20161102 17:19:43< shadowm> As I heavily implied above.
20161102 17:19:46-!- irker793 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161102 17:19:46< irker793> wesnoth: Charles Dang wesnoth:master 7fdb2c509200 / src/gui/widgets/ (scrollbar_container.cpp tree_view_node.cpp): Tree View Node: don't add unnecessary widget height when adding child nodes https://github.com/wesnoth/wesnoth/commit/7fdb2c509200f96c17728c795c56a05490e0aac8
20161102 17:20:11< vultraz> ^ no more scrollbars when there's obviously no need for scrollbars :D
20161102 17:22:36< tad_carlucci> According to MS, windows using VS 2015 should be able to build for android. I'd try but don't have a device to test on.
20161102 17:23:37< vultraz> celticminstrel: ^ that also fixes the problem where huge amounts of extra scroll space were appearing in the inspector
20161102 17:26:09-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161102 17:27:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 17:42:51-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161102 17:48:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 17:52:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 18:03:22-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161102 18:06:28-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161102 18:07:43< vultraz> celticminstrel: ftr about that max thing... for some reason I totally forgot how c++ works and thought that maybe the lvalue was returned by the statement. ie,if(a ==b) return original value :|
20161102 18:08:01< vultraz> which is why i was inquiring...
20161102 18:08:03< vultraz> >_>
20161102 18:08:40< vultraz> obviously, once i kicked myself soundly I realized there could be no other solution than what actually happens :P
20161102 18:10:00< shadowm> ... What.
20161102 18:10:41< shadowm> For the record, l-value has a very specific meaning.
20161102 18:10:55< vultraz> I have no idea :|
20161102 18:11:07< shadowm> In C++, l-values are expressions that can receive an assignment, e.g. they can be to the left of the assignment operator.
20161102 18:11:09< vultraz> total 'idfkiwt' moment
20161102 18:11:28< shadowm> For example, in `int foo; foo = 6;`, foo is a valid l-value.
20161102 18:12:05< vultraz> yes.
20161102 18:12:14< shadowm> In `foo + 2 = 6;`, `foo + 2` is an r-value, it can't be assigned to and it doesn't have a permanent location (you couldn't take its address either).
20161102 18:12:33< shadowm> Which is why `foo + 2 = 6;` is not valid C++.
20161102 18:13:38< shadowm> ANd I couldn't understand the rest of your sentence.
20161102 18:17:27< vultraz> shadowm: i was somehow wondering if min or max(a,b) used as an assignment (ie, z = max(a,b)), left the lvalue untouched if a == b. :| 
20161102 18:17:57-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161102 18:18:16< vultraz> as i said
20161102 18:18:19< vultraz> idfkwiwt
20161102 18:24:54< zookeeper> a what
20161102 18:25:16< zookeeper> oh right
20161102 18:25:21< zookeeper> got it
20161102 18:25:33< shadowm> I don't even know what that acronym means.
20161102 18:26:27< shadowm> vultraz: oitijrwii.
20161102 18:26:59< zookeeper> spsuoea
20161102 18:27:28< vultraz> shadowm: I Don't Fucking Know What I Was Thinking
20161102 18:27:47< zookeeper> someone ask me in a year about what that was supposed to mean and we'll see if i can figure it out
20161102 18:27:55< shadowm> vultraz: ymgwrt.
20161102 18:28:33< shadowm> vultraz: (iasylbtw)
20161102 18:30:22< shadowm> (( Oh, I think I just realized what it is / Yeah, my guess was right then. / (I am speaking your language, by the way.) ))
20161102 18:30:25 * zookeeper ssaabwalt
20161102 18:36:02< tad_carlucci> wypspe,p?
20161102 18:36:51< vultraz> wspstiata
20161102 18:36:52< zookeeper> fine, if you insist
20161102 18:37:06-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161102 18:37:11-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161102 18:38:26< vultraz> zookeeper: how go the walls?
20161102 18:39:14< zookeeper> quite well in the "fixing all the stuff it broke that i didn't expect it to break" phase
20161102 18:44:57< vultraz> do finish by sunday
20161102 18:45:03< vultraz> if at all possible
20161102 18:45:24< zookeeper> sunday? certainly
20161102 18:45:30< zookeeper> maybe tomorrow, if lucky
20161102 18:48:49-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20161102 18:49:28< celticminstrel> vultraz: Actually it looks like max does return a reference to its input.
20161102 18:50:18< celticminstrel> But everything's const so there's no way for it to be changed.
20161102 18:51:31 * celticminstrel also just discovered "git config --global merge.conflictstyle diff3"
20161102 18:51:31-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161102 18:51:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 19:19:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 19:21:48-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161102 19:24:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161102 19:25:24-!- mjs-de [~mjs-de@x4db646b3.dyn.telefonica.de] has joined #wesnoth-dev
20161102 19:28:49-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20161102 19:33:32-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 19:48:21-!- louis94 [~~louis94@91.178.242.21] has quit [Ping timeout: 260 seconds]
20161102 20:20:15-!- irker793 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161102 20:34:59-!- mjs-de [~mjs-de@x4db646b3.dyn.telefonica.de] has quit [Remote host closed the connection]
20161102 20:44:00-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161102 21:10:57-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161102 21:10:57-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Remote host closed the connection]
20161102 21:12:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 21:12:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 21:17:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161102 21:23:54-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 21:31:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161102 21:32:28-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161102 21:41:06-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161102 21:51:38-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161102 21:55:46< vultraz> jyrki: (if you read logs) please submit your fixed sized chatbox pr by saturday so i can look at it
20161102 22:00:47-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 22:02:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161102 22:18:21-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 22:18:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 22:25:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 22:27:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 22:40:37-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 22:41:08-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 22:52:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161102 22:52:25-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161102 22:52:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161102 22:56:16-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161102 22:58:27< celticminstrel> vultraz: Are you still planning to do any GUI2 tweaks before Sunday?
20161102 22:58:43< vultraz> i'm still working on my mp options helper
20161102 22:58:59< vultraz> but i don't think id need to do much more tweaks to the widgets
20161102 23:00:42< vultraz> why?
20161102 23:01:11< celticminstrel> I could start the renaming if I know the files I'm working with won't be touched much.
20161102 23:01:17< celticminstrel> Obviously on a branch.
20161102 23:01:32< celticminstrel> But if you're still working on stuff I should probably wait.
20161102 23:05:48-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit []
20161102 23:07:44< celticminstrel> Oh yeah, DeFender1031, did you ever make that list?
20161102 23:08:42< DeFender1031> celticminstrel, began thinking it out, not done yet. probably tomorrow (thursdays are usually my day to work on wesnoth stuff)
20161102 23:11:46-!- louis94 [~~louis94@91.178.242.21] has joined #wesnoth-dev
20161102 23:13:50-!- Appleman1234 [~Appleman1@KD106161198196.au-net.ne.jp] has joined #wesnoth-dev
20161102 23:46:44< celticminstrel> Okay, so, scons cannot find SDL2 even though it's definitely installed. What should I do?
20161102 23:48:13< shadowm> Tried passing --config=force to scons in case it got confused by an upgrade or config interruption?
20161102 23:48:33< celticminstrel> I'll try that...
20161102 23:49:10< shadowm> (To elaborate: presing ctrl+c or otherwise interrupting the config stage of the scons recipe sometimes causes config tests to be cached as failed.)
20161102 23:49:17< celticminstrel> Gasp! It's working now!
20161102 23:49:36< celticminstrel> I wish I'd seen that suggestion in the log before.
20161102 23:49:46< celticminstrel> It's running gettext now...
20161102 23:49:55< celticminstrel> I guess I just let it run. Could be awhile.
20161102 23:51:27< celticminstrel> Gyah, now it can't find type_traits.
20161102 23:52:02 * celticminstrel tries adding -stdlib=libc++ in extra_flags_base...
20161102 23:53:50< celticminstrel> That didn't work...
20161102 23:56:15-!- louis94 [~~louis94@91.178.242.21] has quit [Quit: Konversation terminated!]
20161102 23:56:32< loonycyborg> celticminstrel: you mean you're getting a compile error?
20161102 23:56:37< celticminstrel> The flag isn't actually being passed...
20161102 23:56:49< celticminstrel> loonycyborg: Yeah, "type_traits" file not found.
20161102 23:57:02< celticminstrel> I'm guessing the include path is wrong.
20161102 23:57:28< celticminstrel> It's probably searching for C++ includes in the ancient GNU libstdc++ on my computer, or something similar.
20161102 23:58:21-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 250 seconds]
20161102 23:58:44< loonycyborg> you can just copy-paste that command that failed and adjust it
20161102 23:58:52< celticminstrel> Huh?
20161102 23:58:54< loonycyborg> to see which compiler switches would fix it
20161102 23:59:07< celticminstrel> Oh.
20161102 23:59:11< celticminstrel> You have a point.
--- Log closed Thu Nov 03 00:00:08 2016