--- Log opened Sat Nov 05 00:00:00 2016
20161105 00:10:00-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 252 seconds]
20161105 00:15:50-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 00:23:18-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161105 00:24:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161105 00:36:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 00:41:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161105 00:54:38< aeth> By the way, I remember taking a class once that had all its (online) due dates at 00:01 to avoid confusion.
20161105 00:54:46< aeth> That's not a bad way to deal with midnight stuff.
20161105 00:55:16< aeth> Even if you're technically correct with how you handle dates and times it doesn't mean everyone will interpret it correctly.
20161105 00:55:37< aeth> And a minute doesn't make a big difference in the grand scheme of things.
20161105 01:00:00-!- Appleman1234 [~Appleman1@KD106161209021.au-net.ne.jp] has quit [Ping timeout: 268 seconds]
20161105 01:02:03< vultraz> first draft for the 1.13.6 announcement is up in the mods forum
20161105 01:02:16< vultraz> of*
20161105 01:02:39< vultraz> shadowm: will you be able to do screenshots, or will I need to take them?
20161105 01:03:37< vultraz> it'd be a great help if you could
20161105 01:04:43< shadowm> You could just ask the person who helps you with social media to do it.
20161105 01:05:18< shadowm> Taking screenshots isn't a lot of work per se, the problem is I literally have no idea what I'm after.
20161105 01:05:27< shadowm> So someone better informed should do it instead.
20161105 01:05:38< shadowm> (I don't have suitable saves either.)
20161105 01:05:41< vultraz> He's rather busy with personal issues at the moment.
20161105 01:05:54< vultraz> I could give you a list of things we need.
20161105 01:06:09< pydsigner> I can send you a screenshot utilizing the story improvement
20161105 01:06:23< pydsigner> What res do you want
20161105 01:06:24< shadowm> (See, I don't even know what that is.)
20161105 01:06:51< vultraz> I have no idea what pydsigner is talking about either :|
20161105 01:06:59< pydsigner> vultraz: you merged it lol
20161105 01:07:05< vultraz> oh that
20161105 01:07:19< vultraz> nah, that's not what we're looking for
20161105 01:07:22< pydsigner> Ok
20161105 01:07:59< vultraz> We need screenshots of the new MP lobby, mp Create Game, mp game lobby (either staging or joining), one of the new Recall dialog, and one of some of doofus's new terrains
20161105 01:09:07< vultraz> Unfortunately, mp create game still has an issue where a horizontal scrollbar appears at our standard screenshot resolution :/
20161105 01:09:12< vultraz> ;_;
20161105 01:15:20-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 01:19:44-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161105 01:25:18-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161105 01:35:06-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20161105 01:39:24-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 250 seconds]
20161105 01:42:35< celticminstrel> vultraz: You may be able to avoid the horizontal scrollbar if you're careful. It likely depends on the initial state of the dialog - ie, which scenario etc is initially selected when it opens.
20161105 01:46:42-!- astrelyon [~astrelyon@78.134.226.117] has quit [Quit: WeeChat 1.4]
20161105 01:47:26-!- astrelyon [~astrelyon@78.134.226.117] has joined #wesnoth-dev
20161105 02:10:15-!- gfgtdf_ [~chatzilla@x4e369556.dyn.telefonica.de] has joined #wesnoth-dev
20161105 02:12:20-!- gfgtdf [~chatzilla@x4e369961.dyn.telefonica.de] has quit [Ping timeout: 250 seconds]
20161105 02:12:24-!- gfgtdf_ is now known as gfgtdf
20161105 02:16:10-!- irker838 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161105 02:16:11< irker838> wesnoth: Charles Dang wesnoth:master f8f2979b698e / src/gui/dialogs/multiplayer/mp_options_helper.cpp: MP Options Helper: fixed tree not being cleared when calling update_all_options https://github.com/wesnoth/wesnoth/commit/f8f2979b698e70e1ad23c6b4572f7966967bf4ba
20161105 02:17:35< vultraz> I really need to write documentation for that
20161105 02:17:45< vultraz> since the internals are all rather complicated
20161105 02:23:07-!- astrelyon [~astrelyon@78.134.226.117] has quit [Quit: WeeChat 1.4]
20161105 02:23:29-!- astrelyon [~astrelyon@78.134.226.117] has joined #wesnoth-dev
20161105 02:25:49-!- astrelyon [~astrelyon@78.134.226.117] has quit [Client Quit]
20161105 02:26:57-!- astrelyon [~astrelyon@78.134.226.117] has joined #wesnoth-dev
20161105 02:28:15-!- gfgtdf [~chatzilla@x4e369556.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.2/20161019084923]]
20161105 02:41:32-!- astrelyon [~astrelyon@78.134.226.117] has quit [Quit: WeeChat 1.4]
20161105 02:47:22< tad_carlucci> Who was working with boost filesystem?
20161105 02:47:45< celticminstrel> Probably the person who created the file dialog?
20161105 02:49:02< tad_carlucci> hmm .. ok .. I'll check github. I'm getting test failures because the test is not a valid test and cannot help but fail: src/tests/test_filesystem.cpp
20161105 03:07:03-!- Appleman1234 [~Appleman1@KD106161209021.au-net.ne.jp] has joined #wesnoth-dev
20161105 03:58:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 03:59:05< vultraz> tad_carlucci: but that file is in the repo :|
20161105 04:00:34< tad_carlucci> yes. it's a unit test and it won't work. I'll put up a PR to bypass the test if its guaranteed to fail on the builder's system.
20161105 04:00:59< shadowm> So you after an hour you still haven't figured out who wrote it?
20161105 04:01:51< tad_carlucci> I decided it didn't matter.  I did some research on what he did and saw it simply won't work on *some* Linux distro
20161105 04:02:25< shadowm> Care to explain why?
20161105 04:03:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161105 04:04:32< tad_carlucci> Sure. The function being testing is boost::filesystem::is_root() and the path being tested is "/bin" but on some distro "/bin" is a symlink to "/usr/bin" so the test "/bin/..", for example, will be "/usr" instead of the expected value of "/" .. so I called bfs::is_symlink() to bypass any test on "/bin" comparing the result to an expected path.
20161105 04:05:01 * vultraz blinks
20161105 04:05:15< shadowm> Okay, don't bother with the PR.
20161105 04:06:40< tad_carlucci> Why not? I have it ready to go just doing some cleanup to move other stuff out of the way. Or do you simply mean "until 1.13.6 is tagged" which is why I'm moving the other stuff aside.
20161105 04:06:53< shadowm> Because I have a better idea.
20161105 04:07:05< shadowm> It's also my code, in case you couldn't tell from the license header.
20161105 04:07:20< tad_carlucci> You know I never read comments :)
20161105 04:07:44< shadowm> I strongly advise quitting that habit.
20161105 04:07:53 * tad_carlucci shrugs.
20161105 04:09:00< tad_carlucci> They're often wrong. But, OK, I do read them if I'm puzzled about what's going on. But "add A to B" comments when the code says A+C .. 
20161105 04:10:29< irker838> wesnoth: Ignacio R. Morelle wesnoth:master 7a539fd17bfc / src/tests/test_filesystem.cpp: fs: Use /etc for certain tests instead of /bin https://github.com/wesnoth/wesnoth/commit/7a539fd17bfcf109900c7700bc58a6bee9344dbc
20161105 04:10:47< tad_carlucci> The reason I wondered who wrote it was I remember you had a lot of issues with is_root on Windows and at first I thought this was a side-effect of that.  It is, but not how I thought. It's that Arch is one of those distro who put everything in /usr/bin and symlinked /bin to avoid breakage.
20161105 04:12:19< tad_carlucci> I though about using /etc, too. But once bitten twice shy. I don't know anyone symlinking /etc but it could happen.
20161105 04:13:06< shadowm> No-one we need to care about would do that.
20161105 04:15:17< tad_carlucci> One would hope. Frankly I never understood why there was such a stink about /bin and /usr/bin and /usr/local/bin back in the 90s. If you're looking to run a sys 5 script on a bsd machine you gotta expect breakage so fix the script or symlink the command but don't go moving the world around just because you can.
20161105 04:15:21< shadowm> Also, for the future, if you stumble upon some code that you consider to be wrong, try first looking around to see if the author is still around, and contact them if that is the case.
20161105 04:15:54< tad_carlucci> I didn't and don't consider it wrong. It just needed a tweak.
20161105 04:16:02< shadowm> I am perfectly aware that the do-it-yourself approach is usually more time-efficient but that's not what this project is about.
20161105 04:30:06-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161105 04:35:27 * tad_carlucci sighs.
20161105 04:36:20< tad_carlucci> cmake just updated and now it's complaining about my boost patch not being found when it's checking the configuration.
20161105 04:45:31 * celticminstrel swaps channels.
20161105 04:45:38-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161105 04:45:56< celticminstrel> I'd probably use the same WML-compatible as currently, plus some extra keys (like pre_show).
20161105 04:47:05< celticminstrel> Though maybe there'd be a possibility to avoid the hooks altogether...
20161105 04:48:20< celticminstrel> I guess maybe "create_dialog" won't work well after all...
20161105 04:48:50< celticminstrel> Since it implies that it returns an object that can alter the dialog, as if you were already in (at least) post_build.
20161105 04:49:26< celticminstrel> This should be possible, if you have only a window and not a dialog, I think...
20161105 04:49:56< celticminstrel> But on the other hand, that would imply re-showing it doesn't rebuild.
20161105 04:50:55-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161105 04:53:23< tad_carlucci> Ah. It wasn't my stuff. Just needed to rm the cmake cache and it's fine.
20161105 04:53:50< shadowm> vultraz: https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.6-2-192.jpg -- The "Connected Players" heading doesn't look like a heading at all.
20161105 04:54:10< vultraz> that;s the thumbnail
20161105 04:54:17< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.6-2.jpg
20161105 04:54:48< celticminstrel> I agree.
20161105 04:55:01< celticminstrel> Maybe change its colour to match the dialog colour? I dunno.
20161105 04:55:30< celticminstrel> The » doesn't look like a button, either.
20161105 04:55:50< shadowm> Yeah, that was a concern I brought up at first and immediately dismissed.
20161105 04:56:10< shadowm> Turns out I just spent 3 minutes trying to find a way to bring up the faction selection dialog.
20161105 04:58:50< shadowm> vultraz: https://dl.dropboxusercontent.com/u/21371130/screenshots/Screenshot_20161105_015818.png
20161105 04:59:20< shadowm> You have no idea how tempting it is to upload it anyway.
20161105 04:59:23< vultraz> meep :|
20161105 05:00:00< celticminstrel> Uh. What is that.
20161105 05:00:11< shadowm> The Recall dialog.
20161105 05:00:30< celticminstrel> Oh right, that's why there's duplicates. Duh. >_>
20161105 05:00:43< celticminstrel> Ah, vertical scrollbar.
20161105 05:00:47< shadowm> They are not duplicates you insensitive monster.
20161105 05:00:54< celticminstrel> Meh close enough.
20161105 05:01:05< celticminstrel> Basically what we need is a way for listboxes to be less greedy.
20161105 05:01:08< shadowm> They each have unique stats and personalities.
20161105 05:01:16< celticminstrel> Yeah sure.
20161105 05:01:18< shadowm> It's just that I can't be bothered to give them names.
20161105 05:01:19< celticminstrel> (I doubt it)
20161105 05:01:20< irker838> wesnoth: Charles Dang wesnoth:master 72f4c95b2b9f / data/gui/window/ (mp_join_game.cfg mp_staging.cfg): MP Staging, MP Join Game: use gold_small definition for Connected Players header https://github.com/wesnoth/wesnoth/commit/72f4c95b2b9fdf9f8fac3ea0807a588885630630
20161105 05:01:45< vultraz> that scrollbar thing is because of the min size thing in the unit preview pane
20161105 05:01:52< vultraz> will have to deal with that
20161105 05:01:54< vultraz> blaghh
20161105 05:02:11< vultraz> i wonder if i should make the dialog fixed-size
20161105 05:02:20< celticminstrel> Don't make minimum sizes more than about 400>
20161105 05:02:22< celticminstrel> ^?
20161105 05:02:38< celticminstrel> (Well, heights. You can go to 600 for widths, I guess.)
20161105 05:03:15< celticminstrel> (And that obviously doesn't apply to the size of the dialog itself.)
20161105 05:04:10 * vultraz curses
20161105 05:05:55< vultraz> not sure how to deal with this
20161105 05:10:42< vultraz> ughh
20161105 05:12:49-!- Estradavi [~quassel@90.71.242.223] has quit [Ping timeout: 260 seconds]
20161105 05:14:16< vultraz> celticminstrel: also, where do you get 400
20161105 05:14:29< celticminstrel> Arbitrary.
20161105 05:14:37< celticminstrel> But less than the minimum window height.
20161105 05:16:03-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161105 05:18:03< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.6-2.png
20161105 05:18:06< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.6-1.png
20161105 05:18:09< shadowm> vultraz: ^
20161105 05:18:40< vultraz> looking good
20161105 05:18:49< shadowm> Can't take screenshots of Recall or MP Create because neither fits the screen.
20161105 05:19:05< shadowm> Can't take screenshots of the new terrains because I don't know what they are or what maps use them.
20161105 05:21:25< vultraz> Gates
20161105 05:21:32< vultraz> Aquatic castle + encampment
20161105 05:21:35< vultraz> (and keeps)
20161105 05:21:39< shadowm> What maps use them.
20161105 05:21:50< shadowm> Preferably a single one.
20161105 05:21:51< vultraz> DiD S9.2
20161105 05:21:54< irker838> wesnoth: Charles Dang wesnoth:master 37a450fe1992 / data/gui/widget/unit_preview_pane.cfg: Unit Preview Pane: don't force a minimum height for the tree view https://github.com/wesnoth/wesnoth/commit/37a450fe1992f0730cb8a75c17524013e5e821a1
20161105 05:22:23< vultraz> shadowm: ^ that should make the dialog fit on-screen without the window scrollbar
20161105 05:22:34< vultraz> I'll add some size stuff on a dialog basis
20161105 05:22:54< shadowm> What's scenario 9.2 in DiD?
20161105 05:23:01< vultraz> the one in the manor
20161105 05:23:05< shadowm> There's only one scenario 9.
20161105 05:23:15< vultraz> oh, wait
20161105 05:23:16< vultraz> 8
20161105 05:23:17< shadowm> It's the third manor scenario. The other two are scenarios 8 and 7.
20161105 05:23:18< vultraz> 08_A_Small_Favor2
20161105 05:23:33< vultraz> i'm thinking in AtS terms here
20161105 05:23:35< vultraz> heh
20161105 05:23:42< shadowm> Well that's not a particularly interesting map, sorry to say.
20161105 05:23:49< shadowm> But whatever.
20161105 05:24:10< vultraz> I know
20161105 05:24:12< vultraz> it sucks ass
20161105 05:24:25< vultraz> but it uses the new gates
20161105 05:25:04< shadowm> I prefer the way I put it, it's not blatantly insulting for the author/maintainer.
20161105 05:26:11< vultraz> very unfortunate that create can't fit on the screen :(
20161105 05:26:16< vultraz> that's the best one
20161105 05:27:13< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.6-3.png
20161105 05:30:10< vultraz> btw, what do you think of my new mp screens now having used them
20161105 05:30:27< celticminstrel> What resolution does it not fit at.
20161105 05:31:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 05:31:11< shadowm> 1280x768.
20161105 05:32:25< celticminstrel> It has a horizontal scrollbar, right?
20161105 05:32:35< celticminstrel> I don't have a 1280x768.
20161105 05:32:39< shadowm> I think so, I already forgot.
20161105 05:32:41< vultraz> yes
20161105 05:32:50< vultraz> so.. close.. to fitting :(
20161105 05:32:50< shadowm> You don't need to have a screen with that exact resolution, you know.
20161105 05:33:01< shadowm> $ wesnoth -r WIDTHxHEIGHT
20161105 05:33:09< celticminstrel> I know, but it's not offered in prefs is what I meant.
20161105 05:33:24< celticminstrel> Doesn't fit on 1360x768 either.
20161105 05:33:32< celticminstrel> (What's with that weird resolution anyway.)
20161105 05:33:36 * vultraz misses anura's relative sizes
20161105 05:33:39< shadowm> For the love of-
20161105 05:34:00< vultraz> i can maybe maybe text boxes reduce min size depending on window size..
20161105 05:34:01< celticminstrel> Pretty sure you can do relative sizes with GUI2?
20161105 05:34:11< celticminstrel> I mean, you know the screen size, right?
20161105 05:34:25< vultraz> and reduce padding in the tab bar..
20161105 05:35:06< celticminstrel> Well, there's a lot of stuff packed horizontally here...
20161105 05:35:25< shadowm> vultraz: FYI 4 screenshots was the norm during my tenure as community pseudomanager.
20161105 05:35:34< vultraz> I see
20161105 05:35:34< shadowm> https://dl.dropboxusercontent.com/u/21371130/screenshots/wesnoth-1.13.6-4.png
20161105 05:35:41-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161105 05:35:43< shadowm> No more, no less.
20161105 05:36:03< vultraz> alright, let's go with that
20161105 05:36:18< shadowm> It's the best count so that they don't get wrapped into a new row on small screens (WHICH ACTUALLY EXISTS FOR YOUR INFORMATION).
20161105 05:36:30< shadowm> *EXIST
20161105 05:36:58< celticminstrel> I feel like stacking eras/modifications vertically might help but... I think there's not just one factor forcing the scrollbar...
20161105 05:37:27< celticminstrel> (I also get the same issue that plagues the MP Staging dialog in the panel on the right.)
20161105 05:37:45< celticminstrel> (Though it's not as bad since you can scroll right and it's gone.)
20161105 05:37:58< vultraz> javla helvete
20161105 05:38:00< vultraz> :|
20161105 05:38:45< celticminstrel> Is this a known bug? If I drag the scrollbar left and the mouse leaves the window, the scrolbar still moves with the mouse even though the button is released.
20161105 05:38:46< shadowm> I don't speak Latin.
20161105 05:39:08< vultraz> it's swedish 
20161105 05:39:15< shadowm> You are not Swedish.
20161105 05:39:20< celticminstrel> I was going to say, no way is that Latin.
20161105 05:39:26< vultraz> but i know how to curse in swedish
20161105 05:39:29< shadowm> I know it's not Latin.
20161105 05:39:36< celticminstrel> So is it a known bug or not.
20161105 05:39:39< vultraz> uhh
20161105 05:39:45< vultraz> I think ive observed that :|
20161105 05:40:02 * celticminstrel suspects the mechanism for fixing that is pretty much already there - those "we missed an event" warnings you suppressed awhile back.
20161105 05:40:23< shadowm> vultraz: Uploaded to wesnoth.org numbered 1 to 4. You figure out which order suits you best aesthetics-wise.
20161105 05:40:46< shadowm> (You know, those little details which you'd never imagine I took into account when drafting announcements.)
20161105 05:41:00< celticminstrel> Oh yeah, there was a draft that I should look at before sleep...
20161105 05:42:24< shadowm> vultraz: It's doofus-01, not doofus01.
20161105 05:42:31< shadowm> (Re draft.)
20161105 05:42:48< vultraz> shadowm: thanks for dealing with the screenshots
20161105 05:44:34< vultraz> added to post
20161105 05:44:34< shadowm> I guess I'll replace all ASCII quotes and apostrophes with non-ASCII ones on the day of the announcement.
20161105 05:44:34< celticminstrel> "This option will be removed in the next release"
20161105 05:44:34< celticminstrel> So, what if users report major problems with it?
20161105 05:44:34< celticminstrel> Will it still be removed?
20161105 05:44:34< shadowm> I don't feel like reading the rest right now (and why are there so few blocky blocks this time around).
20161105 05:44:34< tad_carlucci> Maybe that will prompt people to be more vocal about problems?
20161105 05:44:34< celticminstrel> Because vultraz is too lazy too scrape the changelog to add additional blocks?
20161105 05:45:27< shadowm> Well, I'll be sad if the fancy blocks eventually get phased out considering that I still get to drag the CSS around forever.
20161105 05:45:38< celticminstrel> If you like, I could do that tomorrow, if you remind me.
20161105 05:45:46< celticminstrel> (Scraping the changelog for more blocks, I mean.)
20161105 05:46:02< celticminstrel> shadowm: The fancy blocks are great and shouldn't be phased out.
20161105 05:46:20< celticminstrel> Also [c][/c] is great.
20161105 05:46:53< shadowm> [c][/c] wasn't my invention, it was someone else's at the phpBB forums. The fancy blocks are 100% mine though.
20161105 05:47:15< celticminstrel> Well, it mightn't've been your invention but IIRC it was you who added it.
20161105 05:47:40< shadowm> "Bugs specific to macOS: * Trackpad tap clicking is sometimes not recognized (forum post)." -- Is this still a thing despite SDL 2?
20161105 05:47:56< celticminstrel> I've observed it, but in 1.12. Not sure about 1.13.
20161105 05:48:19< celticminstrel> I guess I could try it tomorrow. Remind me.
20161105 05:48:38< shadowm> Also, it's pointless to use ClearType unless it's in grayscale AA mode, so I tend to think #21648 doesn't warrant a mention anymore.
20161105 05:49:15< celticminstrel> The game can still crash when planning recruits?
20161105 05:49:25< shadowm> (Colored hinting is simply broken by design unless you can make the font rasterizer aware of the exact contents of the destination.)
20161105 05:51:24< celticminstrel> I'm guessing the issue of UI hanging (eg in the login screen) still exists?
20161105 05:51:27< shadowm> (This is why browsers on Windows and Windows' own "modern" UI for little babbies always use grayscale AA instead.)
20161105 05:52:09 * celticminstrel seems to have experienced this more than most people. Also in the Lua console and Formula debugger IIRC.
20161105 05:53:01< shadowm> celticminstrel: Yeah, I still get that bug.
20161105 05:53:13< vultraz> celticminstrel: please do add more fancy blocks
20161105 05:53:26< celticminstrel> vultraz: Should I add them in RELEASE_NOTES or just edit the post?
20161105 05:53:29< celticminstrel> (Or both?)
20161105 05:53:35< shadowm> It seems like you might have more information about it than me, so perhaps I don't need to bother with reporting it (which I really don't feel like doing right now).
20161105 05:53:40< vultraz> latter
20161105 05:53:59< celticminstrel> shadowm: Yeah, I have a vague idea of why it occurs, and I think Aginor has been made aware too.
20161105 05:54:14 * celticminstrel will assume "latter" means "just edit the post and ignore RELEASE_NOTES".
20161105 05:54:40< celticminstrel> Well, good night.
20161105 05:55:02< vultraz> removed the mention of 21648
20161105 05:55:05< vultraz> it's marked as fixed now anyway
20161105 05:55:20-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161105 05:56:41< shadowm> Back in the day (omg like it was so long ago) I noticed and eventually accepted that devs don't have the same notion of noteworthy as players, so I'd told them to add blurbs to RELEASE_NOTES for really complicated stuff that would take several lines on the changelog or warranted elaborate explanations and/or code examples.
20161105 05:57:23< shadowm> And embrace the fact that it would fall upon me to hunt for simpler noteworthy changes in the changelog.
20161105 05:57:41< shadowm> Or (more often than I'd prefer) the Git commit log.
20161105 05:58:04< shadowm> (Especially with 1.12.x.)
20161105 06:00:03< shadowm> Most of the time the stuff in R_N was vague enough that I'd have to ask individual devs to elaborate on IRC and make whatever they told me into something actually presentable.
20161105 06:00:51< shadowm> *vague/unclear/incomplete
20161105 06:01:20< shadowm> Not to mention that I had to do that anyway to filter out all the typos and awkward syntax/grammar.
20161105 06:02:45< shadowm> I adopted this workflow after too many announcements by the previous release manager where he'd just paste whatever people put into R_N, which for one feature release (1.11.6 I think?) was literally nothing at all.
20161105 06:03:32< shadowm> And at that point I started writing announcements for the release manager despite not being one myself until after 1.12.0 was released.
20161105 06:04:42< shadowm> whatever people put into R_N, which was very little or didn't cover all the most important points, and for one feature release was literally nothing at all.
20161105 06:05:07< shadowm> Skipped half a sentence there.
20161105 06:05:11< shadowm> </rant>
20161105 06:13:06< tad_carlucci> Back in the day, I would start a release announcement for the next when I tagged the current.
20161105 06:13:43< tad_carlucci> Then I'd watch the commits and update it for any added/removed features or major changes which might break things.
20161105 06:23:45-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161105 06:29:43< vultraz> tad_carlucci: that's actually not a bad idea
20161105 06:31:18< tad_carlucci> Remember, the release announcement is NOT technical documentation. It's marketing.
20161105 06:50:17< vultraz> I wonder if i should make dialogs like Recruit fixed-size
20161105 06:50:27< vultraz> or instead implement minimum_width/height
20161105 06:51:36-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161105 06:52:23< vultraz> I suppose i could do fixed for now
20161105 06:56:03< vultraz> or perhaps i should use min
20161105 06:56:19< vultraz> what if, say, a recruit with a really long name..
20161105 07:01:21< vultraz> ponder ponder
20161105 07:02:27-!- JyrkiVesterinen [~JyrkiVest@87-92-22-117.bb.dnainternet.fi] has joined #wesnoth-dev
20161105 07:06:29 * tad_carlucci looks at vultraz pondering ... looks at the clock ... and looks and the pondering again.
20161105 07:10:04< vultraz> let's see if this is as easy as it looks..
20161105 07:18:14-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161105 07:21:13< vultraz> it seems not
20161105 07:28:12< shadowm> I didn't opt for writing announcements in advance because keeping track of commits is far too stressful as it is, and the huge majority consists of inconsequential fluff.
20161105 07:29:25< shadowm> The only situation where it doesn't become counterproductive, here, is in stable branches.
20161105 07:33:42-!- RatArmy [~RatArmy@om126229092014.12.openmobile.ne.jp] has joined #wesnoth-dev
20161105 07:37:58< tad_carlucci> monitoring commits also gives you the chance to get after people to write better commit messages.
20161105 07:39:19< shadowm> Trust me, I've tried. People don't work that way.
20161105 07:42:03< tad_carlucci> Well, one good thing about using PRs is you can work on improving things before it makes it to master.
20161105 07:57:15-!- Qwerty22 [~Qwerty22@48.175.47.77.pptp.ntu-kpi.kiev.ua] has joined #wesnoth-dev
20161105 08:14:42-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 08:17:32-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161105 08:19:10-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 256 seconds]
20161105 08:37:55-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161105 08:42:22< irker838> wesnoth: Severin Glöckner wesnoth:master 7d0ca7508539 / data/core/macros/ (animation-utils.cfg deprecated-utils.cfg): moved DRAKE_FLYING_ANIM to deprecated-utils.cfg https://github.com/wesnoth/wesnoth/commit/7d0ca7508539e2995a41c0567891c7617e0e1caf
20161105 08:42:24< irker838> wesnoth: Charles Dang wesnoth:master 6f22fd5ec6ba / data/core/macros/ (animation-utils.cfg deprecated-utils.cfg): Merge pull request #860 from sevu/master https://github.com/wesnoth/wesnoth/commit/6f22fd5ec6baa556a1804063bb7a2ca67ce50e13
20161105 08:55:29< irker838> wesnoth: Charles Dang wesnoth:master da5ca8efce8a / data/gui/window/ (unit_advance.cfg unit_create.cfg unit_list.cfg unit_recall.cfg unit_recruit.cfg): GUI2: bunch of small internal layout tweaks to dialogs using unit preview panes https://github.com/wesnoth/wesnoth/commit/da5ca8efce8a9eeb83827d1a871f97839943686e
20161105 08:55:32< irker838> wesnoth: Charles Dang wesnoth:master 3c0068173eca / data/campaigns/ (11 files in 7 dirs): Campaigns: wmlindent run https://github.com/wesnoth/wesnoth/commit/3c0068173ecabc8e37f42b5d54f74a56606a6311
20161105 08:56:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161105 08:57:11< irker838> wesnoth: Gregory A Lundberg wesnoth:master 8b2a4b4bf72e / src/gui/dialogs/multiplayer/mp_join_game.cpp: Fix VC14 Warnig for unreachable code https://github.com/wesnoth/wesnoth/commit/8b2a4b4bf72e6cf606b7374021555f4eb0260a77
20161105 08:57:13< irker838> wesnoth: Charles Dang wesnoth:master d5fde6e3076c / src/gui/dialogs/multiplayer/mp_join_game.cpp: Merge pull request #851 from GregoryLundberg/GL_unreachable_code https://github.com/wesnoth/wesnoth/commit/d5fde6e3076caf338463f3e56f5d3947ced4e9e0
20161105 09:04:26< zookeeper> oh right, need to add the aquatic camps/castles to a bunch of maps before release
20161105 09:05:41< vultraz> eh?
20161105 09:06:00-!- Qwerty22 [~Qwerty22@48.175.47.77.pptp.ntu-kpi.kiev.ua] has quit []
20161105 09:06:45< zookeeper> i'd think that what i said is pretty straightforward? :x
20161105 09:07:33< vultraz> which maps"?
20161105 09:07:39< irker838> wesnoth: Charles Dang wesnoth:master 6cba21bd03e4 / data/core/ (4 files in 2 dirs): Core: wmlindent run https://github.com/wesnoth/wesnoth/commit/6cba21bd03e4334893d8e09eb51572869f2bcdd1
20161105 09:08:48< vultraz> s/"//
20161105 09:08:51< zookeeper> well you know campaign maps where they ought to be used instead of whatever is used right now
20161105 09:08:58< vultraz> DW?
20161105 09:10:52< zookeeper> mostly, yes
20161105 09:16:43< zookeeper> also to update the aquatic camp keep icon
20161105 09:19:32-!- travis-ci [~travis-ci@ec2-54-162-103-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 09:19:33< travis-ci> wesnoth/wesnoth#11861 (master - 6f22fd5 : Charles Dang): The build passed.
20161105 09:19:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173462749
20161105 09:19:33-!- travis-ci [~travis-ci@ec2-54-162-103-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 09:29:47-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161105 09:30:03-!- JyrkiVesterinen [~JyrkiVest@87-92-22-117.bb.dnainternet.fi] has quit [Quit: .]
20161105 09:32:33-!- RatArmy [~RatArmy@om126229092014.12.openmobile.ne.jp] has quit [Quit: Leaving]
20161105 09:42:56-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 268 seconds]
20161105 09:46:56-!- travis-ci [~travis-ci@ec2-54-87-32-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 09:46:57< travis-ci> wesnoth/wesnoth#11862 (master - 3c00681 : Charles Dang): The build passed.
20161105 09:46:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173463672
20161105 09:46:58-!- travis-ci [~travis-ci@ec2-54-87-32-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 09:49:09< irker838> wesnoth: ln-zookeeper wesnoth:master 5638e1dcb6e3 / data/campaigns/Dead_Water/maps/ (6 files): DW: Make use of the new aquatic encampment and castle terrains https://github.com/wesnoth/wesnoth/commit/5638e1dcb6e3d7400965ab62e3b28a7cbc64c0c3
20161105 09:56:53< irker838> wesnoth: ln-zookeeper wesnoth:master 10e4b9136ca6 / data/campaigns/Heir_To_The_Throne/maps/05b_Isle_of_the_Damned.map: HttT: Make use of the new aquatic encampment and castle terrains https://github.com/wesnoth/wesnoth/commit/10e4b9136ca6b521757fa5a912c2befaed638e08
20161105 09:58:15< irker838> wesnoth: ln-zookeeper wesnoth:master f2de11b483ca / data/campaigns/The_Rise_Of_Wesnoth/maps/14_Rough_Landing.map: TRoW: Make use of the new aquatic encampment and castle terrains https://github.com/wesnoth/wesnoth/commit/f2de11b483cafd712e233c6d25a1e11b2bae03ec
20161105 10:00:27-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161105 10:02:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 10:07:06-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 250 seconds]
20161105 10:10:59-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161105 10:13:25-!- boucman_work [~boucman@2a02-8428-034f-f800-a956-7a48-0974-d832.rev.sfr.net] has joined #wesnoth-dev
20161105 10:16:37-!- travis-ci [~travis-ci@ec2-54-91-159-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 10:16:38< travis-ci> wesnoth/wesnoth#11863 (master - d5fde6e : Charles Dang): The build passed.
20161105 10:16:39< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173463800
20161105 10:16:39-!- travis-ci [~travis-ci@ec2-54-91-159-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 10:19:54-!- Estradavi [~quassel@90.71.242.223] has joined #wesnoth-dev
20161105 10:20:04-!- Estradavi [~quassel@90.71.242.223] has quit [Remote host closed the connection]
20161105 10:44:20-!- travis-ci [~travis-ci@ec2-54-162-103-152.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 10:44:21< travis-ci> wesnoth/wesnoth#11864 (master - 6cba21b : Charles Dang): The build passed.
20161105 10:44:22< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173465167
20161105 10:44:22-!- travis-ci [~travis-ci@ec2-54-162-103-152.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 11:00:52-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161105 11:04:36< vultraz> 13 hours until release time.
20161105 11:07:41< vultraz> get anything you want included in soon.
20161105 11:08:03< zookeeper> eh, did you want release note edits to the file or the post directly?
20161105 11:08:16< zookeeper> i guess the file
20161105 11:08:18-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161105 11:09:19< vultraz> post directly.
20161105 11:09:24< vultraz> much easier
20161105 11:09:38< vultraz> no point in updating the file, since then i'll have to copy it to the post anyway
20161105 11:10:33< zookeeper> right
20161105 11:12:17< vultraz> someone tell celticminstrel if he gets back to mark type_tree as nontranslatable in wmllint
20161105 11:21:57-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Ping timeout: 260 seconds]
20161105 11:37:36-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161105 11:51:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161105 11:55:40-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161105 11:59:14-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161105 11:59:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161105 11:59:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161105 12:01:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161105 12:03:25-!- travis-ci [~travis-ci@ec2-54-87-32-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 12:03:26< travis-ci> wesnoth/wesnoth#11867 (master - f2de11b : ln-zookeeper): The build has errored.
20161105 12:03:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173469812
20161105 12:03:26-!- travis-ci [~travis-ci@ec2-54-87-32-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 12:14:14-!- RatArmy [~RatArmy@om126229092014.12.openmobile.ne.jp] has joined #wesnoth-dev
20161105 12:25:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161105 12:28:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161105 12:37:49-!- JyrkiVesterinen [~JyrkiVest@87-100-187-45.bb.dnainternet.fi] has joined #wesnoth-dev
20161105 12:53:19-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161105 12:58:24-!- irker838 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161105 13:07:55-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161105 13:24:39-!- RatArmy [~RatArmy@om126229092014.12.openmobile.ne.jp] has quit [Quit: Leaving]
20161105 13:31:38-!- boucman_work [~boucman@2a02-8428-034f-f800-a956-7a48-0974-d832.rev.sfr.net] has quit [Ping timeout: 250 seconds]
20161105 13:54:54-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161105 13:55:06-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Remote host closed the connection]
20161105 13:55:36-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161105 13:58:05-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161105 14:30:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161105 14:42:32-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161105 14:47:00-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161105 14:52:36-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20161105 14:54:02-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161105 14:56:22-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20161105 15:01:03-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has quit [Ping timeout: 265 seconds]
20161105 15:02:02-!- gfgtdf [~chatzilla@x4e369556.dyn.telefonica.de] has joined #wesnoth-dev
20161105 15:11:07-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161105 15:11:45-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has joined #wesnoth-dev
20161105 15:16:20-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161105 15:18:42-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161105 15:26:40-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161105 15:30:00-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161105 15:31:03< celticminstrel> vultraz: So I added only one box because most of the things in the changelog seemed fairly minor, though I'm sure I still missed a couple that are worth drawing attention to.
20161105 15:37:44-!- astrelyon [~astrelyon@78.134.233.63] has joined #wesnoth-dev
20161105 15:39:02-!- astrelyon [~astrelyon@78.134.233.63] has quit [Client Quit]
20161105 15:45:20-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20161105 15:46:08< zookeeper> <vultraz> someone tell celticminstrel if he gets back to mark type_tree as nontranslatable in wmllint
20161105 15:47:54< celticminstrel> Hmm. That's harder than it sounds.
20161105 15:48:40< celticminstrel> Because "type_tree" could also mean "the displayable name of the 'tree' damage type".
20161105 15:49:11< celticminstrel> I guess it's unlikely that someone would define a damage type called "tree"...
20161105 15:49:20< zookeeper> hah, yeah that's true
20161105 15:49:46< celticminstrel> (That's the reason why it's currently marked translatable, by the way.)
20161105 15:50:38< zookeeper> well, i'd say just ignore the possibility of someone having a "tree" damage type? it's not like wmllint is an exact tool anyway.
20161105 15:50:47< celticminstrel> Okay.
20161105 15:50:58< celticminstrel> So uh... which has higher precendence... "and" or "or"...
20161105 15:55:16< tad_carlucci> ( a OR b ) AND ( c OR d )
20161105 15:55:43< pydsigner> When in doubt, always paranthesize
20161105 15:55:51< pydsigner> * parenthesize
20161105 15:55:58-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161105 15:56:30< tad_carlucci> For that rule, I advocate: #define DOUBT
20161105 15:57:29< pydsigner> Like even if you figure it out, the 5 minutes you spend testing the rule everyone else who looks at the code also will have to spend
20161105 15:59:14-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161105 16:00:30< celticminstrel> Sounds like I need parens anyway.
20161105 16:02:01-!- irker147 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161105 16:02:01< irker147> wesnoth: Celtic Minstrel wesnoth:master 6ebfa8b37764 / data/tools/wmllint: wmllint: Fix type_tree being considered translatable https://github.com/wesnoth/wesnoth/commit/6ebfa8b377647c7442369689e00becd5274858ef
20161105 16:02:10< celticminstrel> <_<
20161105 16:02:26-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has joined #wesnoth-dev
20161105 16:02:32< celticminstrel> Hi DeFender1031 
20161105 16:12:47< DeFender1031> hey celticminstrel 
20161105 16:13:02< DeFender1031> how's it?
20161105 16:13:13< celticminstrel> Alright.
20161105 16:16:13-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161105 16:24:52< celticminstrel> What's src/tools/sdl2 ...
20161105 16:25:15< DeFender1031> celticminstrel, I'm nearly done putting everything documented on the wiki onto my rename list. I'll probably send you that before I source dive for the remaining stuff
20161105 16:25:28< celticminstrel> Okay.
20161105 16:36:00< zookeeper> anyone feel like playtesting a modified HttT S8 for me?
20161105 16:36:36< zookeeper> it's hard to say how well it works for someone who doesn't know the internals
20161105 16:37:33< zookeeper> also the load dialog has an awkward extraneous horizontal scrollbar
20161105 16:37:52< celticminstrel> Lots of dialogs have awkward window scrollbars. :/
20161105 16:38:27-!- travis-ci [~travis-ci@ec2-54-91-159-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 16:38:28< travis-ci> wesnoth/wesnoth#11868 (master - 6ebfa8b : Celtic Minstrel): The build passed.
20161105 16:38:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173517425
20161105 16:38:28-!- travis-ci [~travis-ci@ec2-54-91-159-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 16:42:05-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has quit [Ping timeout: 260 seconds]
20161105 16:49:10< tad_carlucci> celticminstrel, src/tools/sdl2 is a non-compilable test of SDL2 features which I've been told to delete once 1.13.6 goes out. I am working on getting the remainin tools working. At present schema_generator and schema_validator compile, although SCons and CMake differ in whether to build then. wesmage, exploder and cutter do not compile but are fixable and I'll be working on those once the dust settles.
20161105 16:49:50< celticminstrel>  Ah.
20161105 16:50:19 * celticminstrel is ignoring the tools and tests for the mass rename. Might do a separate pass of them later, though.
20161105 16:50:36< celticminstrel> I think MSVC also has a schema_generator build.
20161105 16:51:10< tad_carlucci> what is 'mass rename' if you mean bumping the version then ignore tools/sdl2 but bump the others I mentioned. 
20161105 16:51:11-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161105 16:51:24< celticminstrel> No, renaming types.
20161105 16:52:29< tad_carlucci> Be aware the tests are a special wesnoth client. Remaning types for wesnoth should effect the tests.
20161105 16:52:53< celticminstrel> Yeah, I'm just doing mass sed so it should be fine. And periodic scons builds to make sure it still builds.
20161105 16:53:07< tad_carlucci> Note also there are a few "test" programs [ having int main() ] which I've found which probably all need to be deleted unless someone objects.
20161105 16:53:27< celticminstrel> I moved one of them over to the proper tests awhile ago.
20161105 16:53:36< celticminstrel> Some of the others might work with the same treatment.
20161105 16:53:50< tad_carlucci> I'd recomment default_targets=campaignd tests wesnoth wesnothd, then
20161105 16:54:48< tad_carlucci> If you want to check schema_* you'll need to use CMake.
20161105 16:55:00< celticminstrel> I should build campaignd, yeah, good point... I'd think wesnothd is built by default?
20161105 16:56:12< irker147> wesnoth: Ignacio R. Morelle wesnoth:master 96034d43a683 / changelog: Remove changelog mention of a feature that was pulled back https://github.com/wesnoth/wesnoth/commit/96034d43a6836c0d946da0f5bdce803edf9a336d
20161105 16:56:15< irker147> wesnoth: Ignacio R. Morelle wesnoth:master 6300aa43523e / changelog players_changelog: Alphabetical... order... https://github.com/wesnoth/wesnoth/commit/6300aa43523e7a0279bdea35b14d5941ee936d7a
20161105 17:01:14< zookeeper> something seems to keep switching accelerated mode to off from time to time
20161105 17:21:32< tad_carlucci> I think it was yesterday someone said that SCons and CMake use the same build options. This is false. They disagree on which targets may be built and they disagree on features to test for, and enable, on some targets.
20161105 17:34:12-!- travis-ci [~travis-ci@ec2-54-204-227-39.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 17:34:13< travis-ci> wesnoth/wesnoth#11869 (master - 6300aa4 : Ignacio R. Morelle): The build has errored.
20161105 17:34:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173525902
20161105 17:34:14-!- travis-ci [~travis-ci@ec2-54-204-227-39.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 17:41:46-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161105 17:44:24< zookeeper> hrhrhmm. i was worried that the assassin AI might be too easy to counteract, but it's... really tricky. one might even say that the AI behavior is bordering on a tomato surprise, but it is perfectly within the rules so...
20161105 17:59:05-!- boucman_work [~boucman@2a02-8428-034f-f800-9e32-0c7c-b391-6223.rev.sfr.net] has joined #wesnoth-dev
20161105 18:02:52-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161105 18:04:27< Shiki> Could you add the new terrains to the players_changelog too?
20161105 18:07:58< Shiki> you = whoever is doing that?
20161105 18:08:29< zookeeper> i figured the release notes might be a more appropriate place
20161105 18:09:09< Shiki> maybe both?
20161105 18:10:51< Shiki> However, as it's not forgotten I'm happy.
20161105 18:24:36-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161105 18:38:43< celticminstrel>  They're mentioned in vultraz's draft post already.
20161105 18:39:20< celticminstrel> They should be in changelog (I think they are already), but not sure if they belong in players_changelog.
20161105 18:42:36< tad_carlucci> In rooting around the source tree I came across src/nacl and I find the Chrome Web Store as 1.10.0 available. I'm wondering what ever became of Chrome Native Client support.
20161105 18:43:49< shadowm> The same thing that happens to anything that isn't actively maintained by people with an active presence/contact with the BfW Project.
20161105 18:44:04-!- louis94 [~~louis94@91.178.241.199] has quit [Ping timeout: 260 seconds]
20161105 18:46:34-!- mjs-de [~mjs-de@x4db6bb5f.dyn.telefonica.de] has joined #wesnoth-dev
20161105 18:49:15< zookeeper> i'll push some stuff before midnight
20161105 18:49:24< zookeeper> (unrelated to above, naturally)
20161105 18:49:53< tad_carlucci> I guess the question is: if we brought it up to speed for 1.14 would anyone use it? Do we know if anyone actually used the 1.10 version? At present it's x86_64 and i686 only.
20161105 18:52:08< JyrkiVesterinen> It's unlikely that anyone would use the NaCl version.
20161105 18:52:34< JyrkiVesterinen> In particular, web standards bodies are working on WebAssembly, which would be a replacement to NaCl.
20161105 18:54:08< JyrkiVesterinen> I can imagine that the NaCl version was probably just an experiment someone made for fun to begin with.
20161105 18:56:24< tad_carlucci> JyrkiVesterinen, I'm making a list of cruft in the src tree .. stuff which isn't referenced .. and I guess I'll add the NaCL stuff to it. [ Too bad Chrome chose that name; when I first ran across it I was wondering why we would need another crypto package. ]
20161105 19:05:58< DeFender1031> celticminstrel, still here?
20161105 19:06:20< celticminstrel> Yeah
20161105 19:07:07< celticminstrel> How does "NaCl" evoke crypto? All I can think of when I see it is salt.
20161105 19:07:38< DeFender1031> celticminstrel, http://paste.nachsoftware.com/DeFender1031/ZvZPq2b5aa3c189f718584447581e2d8b03b82Rr Note: 1. Feel free to ask me about anything, tell me I'm a moron for something I've proposed, ignore some or all of this, etc, etc. 2. I'm not entirely satisfied with the "game" category, but some of those functions I just couldn't think of a better place for.
20161105 19:08:11< DeFender1031> celticminstrel, in answer to your question: https://en.wikipedia.org/wiki/Salt_(cryptography)
20161105 19:08:39< celticminstrel> Eh, true. Salt is a thing in crypto.
20161105 19:08:52< DeFender1031> anyway, what I just pasted is only those that are documented on https://wiki.wesnoth.org/LuaWML
20161105 19:09:21< DeFender1031> if you think the approach makes sense, i'll code-dive for the rest, but i don't want to do it if you think i'm crazy for even suggesting this.
20161105 19:10:10< tad_carlucci> celticminstrel, https://nacl.cr.yp.to/
20161105 19:11:08< JyrkiVesterinen> Is pushing to master allowed right now? I found a small (likely invisible) bug, and I'm wondering if I should push the fix to master or create a branch for it.
20161105 19:11:38< celticminstrel> Well, the categorization is good, at least.
20161105 19:11:54< DeFender1031> celticminstrel, also, I agree with you. Even though salt is a crypto thing, it's a relatively small one, and to me, naming a crypto library "NaCl" is like naming a restaurant "Salt".
20161105 19:12:34< celticminstrel> Some of the details I disagree with, but...
20161105 19:12:42< celticminstrel> It looks mostly good.
20161105 19:12:52< DeFender1031> celticminstrel, that's fine. like I said, i'm here to discuss
20161105 19:13:13< DeFender1031> and i'm not 100% satsfied with everything i did there either.
20161105 19:13:19< tad_carlucci> DeFender1031, Dan (et al) wrote that library way-back-when as part of an effort to get people to stop using unsalted passwords. It was a 'thing' for a while before OpenSSL was usable.
20161105 19:13:22< DeFender1031> but i wanted to get at least a draft to you
20161105 19:13:44< DeFender1031> who's Dan (aside from me)?
20161105 19:14:03< celticminstrel> Apparently someone who wrote a crypto library called NaCl.
20161105 19:14:32< DeFender1031> And yes, one should always use salt, pepper, and garlic when storing password data.
20161105 19:14:38< celticminstrel> Haha
20161105 19:15:10< DeFender1031> mmmmmmm... hashes. (said in homer simpson voice)
20161105 19:15:37< celticminstrel> Why does that make me think of potatoes?
20161105 19:15:57< DeFender1031> celticminstrel, https://en.wikipedia.org/wiki/Hash_browns
20161105 19:16:12< celticminstrel> Oh right.
20161105 19:16:15< DeFender1031> which are, incidentally, very tasty with salt, pepper, and garlic.
20161105 19:16:34< celticminstrel> Well, I never use pepper, but whatever.
20161105 19:16:36< DeFender1031> anyway, what parts of the rename proposal do you think need improvement?
20161105 19:16:42< celticminstrel> Oh um...
20161105 19:17:05< DeFender1031> my wife has a friend who's allergic to pepper.
20161105 19:17:16< tad_carlucci> Who is Dan? https://cr.yp.to/  and   https://en.wikipedia.org/wiki/Daniel_J._Bernstein
20161105 19:17:33< celticminstrel> Wait, what the heck does "osd" mean?
20161105 19:17:37< DeFender1031> ah, Dan Bernstein. Of course.
20161105 19:17:44< DeFender1031> celticminstrel, on-screen display
20161105 19:17:52< DeFender1031> seemed to me a better anme than "theme_items"
20161105 19:18:06< celticminstrel> Ah okay...
20161105 19:18:08< DeFender1031> because as i understood your explanation, it controls what is shown in the on screen display
20161105 19:18:31< DeFender1031> if you have a better name, that's good too
20161105 19:20:04< DeFender1031> but i don't think "theme_items" really suggests what it's actually for
20161105 19:20:08< tad_carlucci> DeFender1031, How about "on_screen_items"
20161105 19:20:44< DeFender1031> tad_carlucci, i hesitate to use the word "items" as that already refers to somethingentirely different in wesnoth
20161105 19:20:54< celticminstrel> I don't think I like textdomain being moved.
20161105 19:21:00< tad_carlucci> or just "screen_items" or "screen_elements" or anything other than an abbreviation
20161105 19:21:03< DeFender1031> celticminstrel, why not?
20161105 19:21:15< celticminstrel> Not sure exactly... might be a silly reason...
20161105 19:21:18< tad_carlucci> I trust all that renaming is for AFTER 1.13.6 tags
20161105 19:21:24< celticminstrel> Of course.
20161105 19:21:27< DeFender1031> tad_carlucci, on_screen_display would work as well
20161105 19:21:28< tad_carlucci> whew
20161105 19:21:31< celticminstrel> And that's only a draft anyway, it's not even finalized.
20161105 19:21:51< tad_carlucci> Hey, I took a quick look and I like what I saw. 
20161105 19:22:04< DeFender1031> tad_carlucci, yeah, this is nowhere near even approved, let alone going into the next release.
20161105 19:22:40< DeFender1031> it's basically an idea i had a couple weeks ago when celticminstrel suggested moving something... somewhere. Something with strings IIRC.
20161105 19:22:56< DeFender1031> and i was like "we should have the API in categories rather than floating all over the place"
20161105 19:23:34< DeFender1031> celticminstrel, i stuck textdomain in string because it's basically to get translated strings, and you're adding a bunch more string stuff, so a string category made sense.
20161105 19:23:47< DeFender1031> i dislike things that aren't in a category of some sort
20161105 19:24:00< DeFender1031> even if the category only has one item in it at the moment
20161105 19:24:04< celticminstrel> Not entirely happy with some of the category names (audio -> sound? not sure on output either); not sure I like the hook tables being moved; and I don't think everything necessarily needs to be in a subtable. There could be a few wesnoth.xxx functions that don't fit into any particular category.
20161105 19:24:11< DeFender1031> (since there may always be more added, and for consistency)
20161105 19:24:28< tad_carlucci> What I would LOVE is a file heirachy which follows the namespace/class/member structure so if I want to find gui2::dialogs::tdialog::show_dialog I can walk the tree instead of having to guess that tdialog->dialog
20161105 19:24:29< irker147> wesnoth: Jyrki Vesterinen wesnoth:master 5984daae6e1c / src/gui/widgets/grid.cpp: Fix logic error in grid "request reduce size" functions https://github.com/wesnoth/wesnoth/commit/5984daae6e1c008ffc32e52c671a1cc66270dc55
20161105 19:24:38< DeFender1031> celticminstrel, i definitely hear you, but read my last couple of lines.
20161105 19:25:12< celticminstrel> tad_carlucci: I'm renaming those GUI2 classes.
20161105 19:25:34< tad_carlucci> I like audio. It can be separated into audio/music audio/soundeffects etc
20161105 19:26:06< DeFender1031> celticminstrel, like i said, it's a draft. feel free to unmove/rename/recategorize anything you want. far be it from me as the newcomer to tell you what to do
20161105 19:26:43< DeFender1031> i tend to prefer having everything in a category, if you don't, i'm not going to throw a fit.
20161105 19:26:45< celticminstrel> I probably wouldn't bother moving location_set into the wesnoth table, as it's nicely self-contained already.
20161105 19:27:24< DeFender1031> the reason i like having everything in the wesnoth table is so that there's only one access point that you need to worry about
20161105 19:27:26< celticminstrel> Hmm...
20161105 19:27:46< DeFender1031> and the reason i like having everything in categories is for consistency and future-proofing
20161105 19:28:19< DeFender1031> you can always "local" anything you plan to use frequently in a file
20161105 19:28:23< celticminstrel> I think everything you've placed in the game table is unavailable to the mapgen kernel, except for the name generator.
20161105 19:28:39< DeFender1031> ah, interesting
20161105 19:28:54< DeFender1031> i'm not entirely satisfied with "Game" for namegen anyway.
20161105 19:29:01< celticminstrel> (Nearly everything is unavailable for the mapgen kernel though.)
20161105 19:29:12< celticminstrel> (It should have all the stuff in math, at least... and file...)
20161105 19:29:31< DeFender1031> ah. i wasn't aware that there was a difference there
20161105 19:29:36< celticminstrel> I think mapgen kernel also has access to dialogs. And output should be fine too.
20161105 19:29:39< DeFender1031> that might complicate things slightly
20161105 19:29:53< celticminstrel> I wonder if we should move print -> wesnoth.print and std_print -> print.
20161105 19:30:04< DeFender1031> well, let's try to make the categories not mix stuff that's available in mapgen with stuff that sn't
20161105 19:30:06< celticminstrel> Then again maybe there was a good reason for replacing the default print.
20161105 19:30:16< DeFender1031> hmm
20161105 19:30:33< DeFender1031> doing that would break deprecated-backwards-compat though
20161105 19:30:47< celticminstrel> I guess duplicating the Wesnothian print in the wesnoth table would be good though. Then people can jsut do "print = std_print" or "print = wesnoth.print" if they want to switch behaviours.
20161105 19:30:50< DeFender1031> you'll notice that i didn't move anything to anywhere that already means something else.
20161105 19:30:58< celticminstrel> Hmm?
20161105 19:31:05< celticminstrel> There were cases where you could've done that?
20161105 19:31:26< tad_carlucci> DeFender1031, When you're planning the naming bear in mind that, someday, we'll probably want to refactor. For instance, if I just want a unit name for a module I should not have to drag in all the unit dialogs as well. If for no other reason than to make the compiles faster. It would be good if the naming schemes lent themselves to refactoring data away from persistance and presentation
20161105 19:31:29< celticminstrel> Oh yeah, the wml stuff is available to the mapgen kernel too of course.
20161105 19:31:57< celticminstrel> Somehow I'm not sure what tad is talking about.
20161105 19:32:02< DeFender1031> yeah... i called the categories singular when i could have called them plural. (the main reason for that is that that's the convention i prefer in all my libraries, but an additional reason is that the effects category would have killed the effects proxy table)
20161105 19:32:51< DeFender1031> yeah, i'm not entirely certain I understand the extent of what tad is referring to either
20161105 19:35:49< DeFender1031> but the libs can be set up that the functions which are included are independent of the category they're in.
20161105 19:36:06< DeFender1031> meaning, not everything under wesnoth.unit needs to be in the same file
20161105 19:36:48< DeFender1031> there'd just have to be some master file that gets included before everything else that sets up empty tables for the categories, and then each file can add what it needs into that master global table
20161105 19:36:56< tad_carlucci> If I need a unit name for an ID, I want to #include "unit.hpp" and how have the entirety of GUI2 be compiled just because I wanted a name.
20161105 19:37:49< DeFender1031> not sure how that applies to lua
20161105 19:38:06< vultraz> JyrkiVesterinen: what does that logic fix improve?
20161105 19:38:22< JyrkiVesterinen> Probably nothing visible.
20161105 19:38:36-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Remote host closed the connection]
20161105 19:38:58< JyrkiVesterinen> I noticed the problem when I was reading the code because I wanted to understand how GUI2 attempts to handle situations where a widget doesn't have enough space.
20161105 19:39:24-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161105 19:39:34< JyrkiVesterinen> I have found even more breakage looking at the code. The size reduction machinery doesn't work at all, and probably is never called either.
20161105 19:42:13< JyrkiVesterinen> Ah, code analysis shows that it's being called at least.
20161105 19:42:28< celticminstrel> I recall some portion of the size reduction machinery being unimplemented.
20161105 19:42:33< JyrkiVesterinen> I'll try to fix it in a branch and send a PR about it.
20161105 19:42:37< vultraz> what celticminstrel said
20161105 19:42:39< celticminstrel> Specifically something like... demand_reduce_size or something?
20161105 19:42:49< celticminstrel> Maybe it was demand_reduce_widget etc
20161105 19:42:58< vultraz> it can be called
20161105 19:43:11< JyrkiVesterinen> Yes, the demand_reduce_width() and demand_reduce_height() functions are completely unimplemented.
20161105 19:43:18< vultraz> oh
20161105 19:43:44< vultraz> ah wait
20161105 19:43:50< JyrkiVesterinen> The problem I'm looking at right now, though, is that the request variants call calculate_best_size() at the end, which throws away everything the functions did.
20161105 19:43:53< vultraz> it's request_reduce_* that can be used
20161105 19:44:33< JyrkiVesterinen> In addition, it looks like layout isn't recalculated at the end of those functions.
20161105 19:45:01< JyrkiVesterinen> tgrid::place() calls calculate_best_size(), which, again, throws away the work of the request_reduce_* functions.
20161105 19:45:45< vultraz> JyrkiVesterinen: well i know at least one place it's called and then followed by a content_resize_request() https://github.com/wesnoth/wesnoth/blob/master/src/gui/widgets/scroll_label.cpp#L65-L67
20161105 19:46:05< DeFender1031> celticminstrel, changed audio to sound and shortened a bunch of function names there... you're right, not sure why i didn't just call it that in the first place (perhaps because of music? but meh, that's sound too.)
20161105 19:46:21< DeFender1031> celticminstrel, you said you weren't sure about "output". Got a better name for me?
20161105 19:46:24< vultraz> JyrkiVesterinen: it's a rather odd system :/
20161105 19:46:35< celticminstrel> Unfortunately no, I don't have a better name.
20161105 19:46:48< JyrkiVesterinen> I found another place myself: https://github.com/wesnoth/wesnoth/blob/5984daae6e1c008ffc32e52c671a1cc66270dc55/src/gui/widgets/window.cpp#L1318
20161105 19:46:53< vultraz> JyrkiVesterinen: because that code essentially says "cancel any resizing and make it the current size"
20161105 19:47:10< DeFender1031> celticminstrel, tad_carlucci, changed osd to "on_screen_display_elements"
20161105 19:47:28< celticminstrel> Uh, that seems too long...
20161105 19:47:48 * tad_carlucci prepares to bitch-slap someone.
20161105 19:47:57< celticminstrel> ???
20161105 19:48:55< tad_carlucci> I know, let's go back to 6 or 8 characters of uniqueness.
20161105 19:49:24< vultraz> o_s_d_e :P
20161105 19:49:34< celticminstrel> That's even worse though.
20161105 19:49:46< vultraz> I know
20161105 19:50:04< DeFender1031> celticminstrel, "osd_elements"? "on_screen_display"? "screen_readout"? "cowfish"?
20161105 19:50:54< celticminstrel> cowfish :P
20161105 19:51:22< celticminstrel> I was thinking "on_screen_elements" or "screen_elements", though the latter somehow seems wrong.
20161105 19:52:03< DeFender1031> screen_elements sounds like GUI2 widgets
20161105 19:52:13< tad_carlucci> cowfish it is
20161105 19:52:14< DeFender1031> which it's not
20161105 19:52:17< DeFender1031> hahahaha
20161105 19:52:21< DeFender1031> done :P
20161105 19:52:51< DeFender1031> seriously though, maybe "on_screen_data" is better
20161105 19:52:52< DeFender1031> ?
20161105 19:53:14< celticminstrel> Hmm. I was thinking maybe substitute a different word for "elements"... not sure if "data" is a good one though...
20161105 19:53:16< DeFender1031> i dunno, something that doesn't imply that it's gui elements and does imply that it's part of the standard onscreen UI.
20161105 19:53:22< DeFender1031> info?
20161105 19:53:23< vultraz> JyrkiVesterinen: anyway, if you can improve layout functionality it would be *really* great
20161105 19:53:27< DeFender1031> readout?
20161105 19:53:49< JyrkiVesterinen> "if you can"? The code I'm looking at is completely broken. Imrpoving it is not hard.
20161105 19:53:57< celticminstrel> Info could work...
20161105 19:54:16< celticminstrel> At least better than data...
20161105 19:54:22< DeFender1031> right
20161105 19:54:23< DeFender1031> hmm
20161105 19:54:54< vultraz> JyrkiVesterinen: "if you can" usually implies "would you do it" :)
20161105 19:54:58< DeFender1031> displayed_info?
20161105 19:55:41< celticminstrel> I dunno... displayed_gameinfo?
20161105 19:55:52< DeFender1031> i'd add a _ to that, but maybe
20161105 19:56:17< DeFender1031> wait...
20161105 19:56:23< DeFender1031> game_display
20161105 19:56:28< tad_carlucci> displayed_game_information
20161105 19:56:43< celticminstrel> Nah, "info" is a pretty common abbreviation.
20161105 19:56:48< DeFender1031> tad_carlucci, that's nearly as long as "on_screen_display_elements" :P
20161105 19:57:21< DeFender1031> but what do we think about "game_display"?
20161105 19:57:24< tad_carlucci> So .. on_screen_display_elements.displayed_game_information.  Sounds good.
20161105 19:57:35< vultraz> p_p
20161105 19:57:47< DeFender1031> tad_carlucci's taking us all for a ride on the trollercoaster.
20161105 19:58:41< vultraz> troll_carlucci
20161105 19:58:54< DeFender1031> seriously, i think i like "game_display". anyone else for "game_display"? Get yer hot, fersh "game_display" right here! Three for 2.50!
20161105 19:59:02< DeFender1031> fresh*
20161105 19:59:34< celticminstrel> game_display seems like it can work. (There's a C++ class by that name which may or may not be related, but that's irrelevant to the question.)
20161105 19:59:40< DeFender1031> ah
20161105 19:59:57< DeFender1031> well i tend to not like using names that already refer to something else elsewhere in a project
20161105 20:00:10< vultraz> zookeeper: https://forums.wesnoth.org/viewtopic.php?p=604587#p604587
20161105 20:00:21< celticminstrel> Well, it's already done in other places.
20161105 20:00:29< celticminstrel> The class that described a side is called "team".
20161105 20:00:42< celticminstrel> ^describes
20161105 20:01:03< DeFender1031> celticminstrel, yes, and those other places should be, IMO mass-renamed to clean up and avoid the ambiguity that comes from inconsistent naming.
20161105 20:01:09 * celticminstrel looks up the game_display class.
20161105 20:01:31< celticminstrel> Hmm, there's game_display::draw_sidebar(). Maybe this is the class that draws the theme items?
20161105 20:02:14< celticminstrel> It requires a reports& parameter in the constructor too, which also enforces that impression.
20161105 20:02:29< celticminstrel> Since that's the class which actually calls the Lua functions in theme_items.
20161105 20:02:36< celticminstrel> (Indirectly, I think, but still.)
20161105 20:02:38< DeFender1031> hahahaha
20161105 20:02:46< celticminstrel> What?
20161105 20:03:09< DeFender1031> so i basically came up with the name that an internal class related to this is actually already called. great.
20161105 20:06:09< DeFender1031> that's what you're telling me, is it not?
20161105 20:07:12< celticminstrel> Seems like it.
20161105 20:07:27< DeFender1031> then there's not much reason not to use the name
20161105 20:07:32< celticminstrel> It's definitely related. Not exactly the same, but definitely related.
20161105 20:07:37< DeFender1031> right
20161105 20:08:40< DeFender1031> fine.
20161105 20:09:27< DeFender1031> question, is there a development wiki or development section on the wiki or somewhere collaborative that a list such as this would be put while working on it so that multiple people can make changes to it while it's being discussed?
20161105 20:09:30-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161105 20:11:10< celticminstrel> Not that I know of, though there are quite a few ancient pages describing various abandoned projects. You can feel free to create a page, though. I was thinking that, if these renames took place, we'd document them on a new page "Lua API" and keep LuaWML for a) describing the [lua] tag and b) listing the deprecated stuff.
20161105 20:11:39< vultraz> celticminstrel: did you confirm that trackpad issue?
20161105 20:11:56< tad_carlucci> forum coders sounds like the place to propose the idea
20161105 20:12:25< celticminstrel> I did not.
20161105 20:12:39< celticminstrel> Oh yeah, forums are good too for feedback on it.
20161105 20:13:55< DeFender1031> celticminstrel, I'm thinking of creating this at https://wiki.wesnoth.org/LuaWML/Reorganization and then if/when we finalize this, we can create "Lua API" and clean up the documentation as such.
20161105 20:14:48< celticminstrel> Sounds good.
20161105 20:15:06< DeFender1031> yeah, makes sense to bring it up on the forum too, but i also wanted this to be in someplace easily referencable and editable.
20161105 20:15:11< celticminstrel> We don't actually have subpages enabled, so you won't get automatic breadcrumbs.
20161105 20:15:40< DeFender1031> celticminstrel, that's fine, there's already a bunch of "subpages" of LuaWML that aren't doing that
20161105 20:15:50< DeFender1031> https://wiki.wesnoth.org/LuaWML/Units etc.
20161105 20:15:59< celticminstrel> I know.
20161105 20:16:25< celticminstrel> I wanted to make those subpages, but it turns out there are quite a few pages that use / in the name.
20161105 20:16:39< celticminstrel> (Including some of those ancient, obsolete, abandoned projects.0
20161105 20:16:40< celticminstrel> ^)
20161105 20:17:14< celticminstrel> Last I checked (which was admittedly a very long time ago) enabling them on a wiki that already has such pages can cause problems.
20161105 20:20:46-!- travis-ci [~travis-ci@ec2-54-87-32-24.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 20:20:47< travis-ci> wesnoth/wesnoth#11872 (master - 5984daa : Jyrki Vesterinen): The build passed.
20161105 20:20:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173549080
20161105 20:20:47-!- travis-ci [~travis-ci@ec2-54-87-32-24.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 20:25:34< tad_carlucci> T-minus 200 ...
20161105 20:25:50< DeFender1031> hmm?
20161105 20:25:55< DeFender1031> what happens in 200?
20161105 20:25:55< tad_carlucci> minutes
20161105 20:26:51< tad_carlucci> 1.13.6, if all goes as planned.
20161105 20:27:04< DeFender1031> celticminstrel, IIRC, enabling subpages will turn any page with a slash whose parent page also exists into a subpage, and any that don't will continue to act as their own page, but I could be misremembering.
20161105 20:27:10< DeFender1031> tad_carlucci, ah.
20161105 20:27:12-!- louis94 [~~louis94@91.178.241.199] has quit [Ping timeout: 260 seconds]
20161105 20:27:34< celticminstrel> I seem to recall something saying you won't be able to access them, but maybe that has changed.
20161105 20:28:12< celticminstrel> It was a really long time ago.
20161105 20:30:27< DeFender1031> not sure. i could test it elsewhere.
20161105 20:38:28-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20161105 20:39:11-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20161105 20:47:07< celticminstrel> Wait, why is -D_X11 in these compiler commands.
20161105 20:47:08< celticminstrel> (scons)
20161105 20:47:37< loonycyborg> iirc for clipboard support
20161105 20:47:40< loonycyborg> in X11
20161105 20:48:51< celticminstrel> But this is a Cocoa build.
20161105 20:52:30-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20161105 20:53:31-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20161105 20:53:48-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20161105 21:00:19< irker147> wesnoth: Jyrki Vesterinen wesnoth:gui2-min-size-layout ec607db39fc3 / src/gui/widgets/grid.hpp: Make tgrid a final class https://github.com/wesnoth/wesnoth/commit/ec607db39fc37c4f895d3a5986a8685e73d29e88
20161105 21:00:21< irker147> wesnoth: Jyrki Vesterinen wesnoth:gui2-min-size-layout 852a3f7f6c0c / src/gui/widgets/ (grid.cpp grid.hpp): Lay grid out after size reduction https://github.com/wesnoth/wesnoth/commit/852a3f7f6c0c2fef44216c7c9995595a139cf11e
20161105 21:00:23< irker147> wesnoth: Jyrki Vesterinen wesnoth:gui2-min-size-layout cea1bc926fa7 / src/gui/widgets/grid.cpp: Demote the "failed to place a grid" message from error to info level https://github.com/wesnoth/wesnoth/commit/cea1bc926fa775f8bb19140036106d847c163aa8
20161105 21:00:33< celticminstrel> Oh my, finality.
20161105 21:00:50-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has quit [Read error: Connection reset by peer]
20161105 21:01:34 * celticminstrel doesn't actually remember how C++ does that for classes.
20161105 21:01:47-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has joined #wesnoth-dev
20161105 21:01:49< celticminstrel> Ah, it is the final keyword.
20161105 21:01:57 * celticminstrel slight emphasis on is
20161105 21:02:09< JyrkiVesterinen> It was the first time I used "final" in C++.
20161105 21:02:48< celticminstrel> My XCode supports override so I'd assume it also supports final...
20161105 21:03:48< JyrkiVesterinen> As far as I know, MSVC2013 is the least advanced compiler we use.
20161105 21:04:05< celticminstrel> Well, my XCode definitely supports some things that MSVC 2013 doesn't.
20161105 21:04:05< JyrkiVesterinen> And since I use it myself, nearly anything I can use should work for others as well.
20161105 21:04:13< celticminstrel> Like defaulted move constructors.
20161105 21:05:17< celticminstrel> Have you observed any notable improvements from those changes?
20161105 21:06:02< JyrkiVesterinen> Yes. I tested the MP lobby in 800x600 with my "simulate lobby traffic" script running.
20161105 21:06:24< JyrkiVesterinen> The improvement is that the lower grid (chatbox and player list) is now visible in those conditions.
20161105 21:06:33< celticminstrel> It wasn't before?
20161105 21:06:40< JyrkiVesterinen> Indeed, it wasn't.
20161105 21:06:46< celticminstrel> Oh, when there's lots of users on?
20161105 21:06:53< JyrkiVesterinen> The player list wants to be higher than available space allows.
20161105 21:07:13< JyrkiVesterinen> Exactly. The script creates 20 users (although not all of them are in the lobby).
20161105 21:07:42< gfgtdf> JyrkiVesterinen: i'd expect a crollbar to appear in that case.
20161105 21:07:52< celticminstrel> Of course you would.
20161105 21:07:58< gfgtdf> in the playerlit i mean
20161105 21:08:30< JyrkiVesterinen> The problem is that the "best size" for the player list is however much space it would need without a scrollbar.
20161105 21:09:00< JyrkiVesterinen> Initial layout fails because the player list can't be placed at the best size. (My branch doesn't improve that, BTW.)
20161105 21:09:34< JyrkiVesterinen> Later GUI2 attempts to reduce the size of the lower grid, but it doesn't do anything in master because of two issues.
20161105 21:09:47< gfgtdf> JyrkiVesterinen: yes, but still if he 'best size' it not available and the layout algorithm woudl usuualy reduce that widgetsheight and add scrollbar, if that fails it shodul all a scrollbar to the whole window.
20161105 21:09:54< gfgtdf> JyrkiVesterinen: which issues?
20161105 21:10:39< JyrkiVesterinen> The request_reduce_* functions of tgrid call calculate_best_size() at the end, and they do not lay the grid out after calculating the size.
20161105 21:11:07< JyrkiVesterinen> Calculate_best_size() clears the saved sizes, i.e. undoes everything that the request_reduce_* functions do.
20161105 21:11:25< gfgtdf> JyrkiVesterinen: does the (sp) campaogn list work as expected? (liek when you usuualy start a campaign)
20161105 21:11:47< JyrkiVesterinen> And without a re-layout, those functions merely calculate new sizes but don't put them into use.
20161105 21:12:30< celticminstrel> So, to be clear... is calculate_best_size modifying the widget's properties?
20161105 21:12:46< JyrkiVesterinen> gfgtdf: What do you mean? Are you asking "does the SP campaign list work in this branch?"
20161105 21:13:16-!- louis94 [~~louis94@91.178.241.199] has joined #wesnoth-dev
20161105 21:13:31< gfgtdf> JyrkiVesterinen: i though there problems were on master?
20161105 21:13:38< gfgtdf> JyrkiVesterinen: i was talking about master
20161105 21:13:41< JyrkiVesterinen> celticminstrel: Yes, if the arrays of row/column sizes count as widget properties.
20161105 21:14:04< JyrkiVesterinen> Can you link a bug report?
20161105 21:14:22< JyrkiVesterinen> (I'd like to understand what the problem is before trying to reproduce it.)
20161105 21:15:54-!- mjs-de [~mjs-de@x4db6bb5f.dyn.telefonica.de] has quit [Remote host closed the connection]
20161105 21:15:58< gfgtdf> JyrkiVesterinen: by problem i meant "but it doesn't do anything in master because of two issues" what you said earlier
20161105 21:16:19< JyrkiVesterinen> Yes, and I tested it with the MP lobby.
20161105 21:16:50< gfgtdf> JyrkiVesterinen: and does it wokr in sp campaign election screen?
20161105 21:16:53< JyrkiVesterinen> I haven't tried the SP campaign list in 800x600, so I have no idea which problems may exist there.
20161105 21:17:14< JyrkiVesterinen> (And I'd prefer not to rebuild master to check it right now.)
20161105 21:20:43-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161105 21:22:35< JyrkiVesterinen> Pull request 862 opened.
20161105 21:26:22< tad_carlucci> JyrkiVesterinen, Is there a specific test on the SP side you wanted? I'm about to rebuild to current master.
20161105 21:27:05< celticminstrel> Well, it was gfgtdf talking about some kinds of issues in the campaign selection dialog...
20161105 21:27:45< JyrkiVesterinen> gfgtdf is implying that there is some kind of layout problem (probably something not being drawn) in the SP campaign list at 800x600.
20161105 21:28:01< JyrkiVesterinen> If you can see such a problem, I'd appreciate a screenshot.
20161105 21:28:33< tad_carlucci> Give me a couple minutes to link and I'll take a look.  800x600 only.
20161105 21:29:07< gfgtdf> tad_carlucci: hm just open the sp capaign selection and check if it looks fine.	JyrkiVesterinen noted that there are problems with reducign the size of widgets in master.
20161105 21:29:32< tad_carlucci> One moment.
20161105 21:30:27< tad_carlucci> Normal start. Looks fine. Scrolls fine. I don't see any obvious errors.
20161105 21:30:42< JyrkiVesterinen> Hmm, OK.
20161105 21:31:14< gfgtdf> tad_carlucci: ok thx
20161105 21:31:16< JyrkiVesterinen> I guess that the campaigns are added to the list *after* placing the campaign list box.
20161105 21:31:51< JyrkiVesterinen> Placing succeeds if the list box can fit into the grid at the time it's placed.
20161105 21:32:14-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has quit [Remote host closed the connection]
20161105 21:32:45< gfgtdf> JyrkiVesterinen: note that the campaigns list aswell as the players list in mp are actualyl treeview widgets
20161105 21:33:32-!- Ivanovic [~ivanovic@wesnoth/developer/ivanovic] has joined #wesnoth-dev
20161105 21:37:18-!- travis-ci [~travis-ci@ec2-54-91-159-123.compute-1.amazonaws.com] has joined #wesnoth-dev
20161105 21:37:19< travis-ci> wesnoth/wesnoth#11873 (gui2-min-size-layout - cea1bc9 : Jyrki Vesterinen): The build failed.
20161105 21:37:20< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/173562737
20161105 21:37:20-!- travis-ci [~travis-ci@ec2-54-91-159-123.compute-1.amazonaws.com] has left #wesnoth-dev []
20161105 21:38:24< JyrkiVesterinen> From Travis logs above:
20161105 21:38:26< JyrkiVesterinen> test: /home/travis/build/wesnoth/wesnoth/src/gui/widgets/tree_view_node.cpp:496: unsigned int gui2::ttree_view_node::place(const unsigned int, gui2::tpoint, unsigned int): Assertion `width >= indentation_step_size' failed.
20161105 21:38:50< JyrkiVesterinen> Lovely. Tests are failing because widget shrinking finally works.
20161105 21:39:18< JyrkiVesterinen> Not going to fix that tonight.
20161105 21:40:31< celticminstrel> XD What
20161105 21:59:03-!- JyrkiVesterinen [~JyrkiVest@87-100-187-45.bb.dnainternet.fi] has quit [Quit: Going to bed]
20161105 22:15:18< zookeeper> ah, less than two hours, gotta get busy i suppose...
20161105 22:16:39-!- StandYourGround [~Adium@2602:30a:c02f:d050:105:5a2f:5456:31ca] has joined #wesnoth-dev
20161105 22:26:09< DeFender1031> celticminstrel, tad_carlucci, "Coder's Corner" is the forum section where I should bring this proposal up?
20161105 22:26:52< celticminstrel> Not quite sure. It does seem like a logical place... there's also "Lua Labs" though...
20161105 22:26:56< celticminstrel> And "Ideas"...
20161105 22:27:28< celticminstrel> Though the former might be more for topics about using the Wesnoth Lua API.
20161105 22:27:30< tad_carlucci> That's where I'd do it. The other choice is Developer's Discussions .. if you want to restrict posting to only those in the group.
20161105 22:28:25< DeFender1031> except that I don't have access there either...
20161105 22:28:39< tad_carlucci> So I'd suggest Coder's Corner.
20161105 22:28:50< tad_carlucci> Or have vultraz fix you up.
20161105 22:29:02< DeFender1031> I also think it makes a certain amount of sense to allow discussion from any interested party and weigh the opinions accordingly
20161105 22:29:28< DeFender1031> after all, the primary reason for a reorg here is to make it easier for the people USING the API.
20161105 22:29:38< DeFender1031> so I think anyone doing so should have some say
20161105 22:29:40-!- StandYourGround [~Adium@2602:30a:c02f:d050:105:5a2f:5456:31ca] has quit [Quit: Leaving.]
20161105 22:35:07< celticminstrel> Agreed.
20161105 22:36:39< tad_carlucci> In that case, I'd suggest Lua Labs 
20161105 22:39:57< celticminstrel> Isn't Coder's Corner also open for anyone?
20161105 22:42:45< DeFender1031> ack, already posted to coder's corner
20161105 22:43:09< DeFender1031> should i kill the post and move it to Lua Labs?
20161105 22:43:47< shadowm> I can move it for you.
20161105 22:44:03< shadowm> Done.
20161105 22:44:08< DeFender1031> if you think it makes more sense there, then go fo- okay then
20161105 22:44:13< DeFender1031> thanks
20161105 22:46:38< DeFender1031> now let's see what happens.
20161105 22:50:44< vultraz> zookeeper: will you be committing doofus's tweak?
20161105 22:50:59< DeFender1031> celticminstrel, now that i've taken this to the public forum, i'm thinking that i SHOULDN'T really add the undocumented lua stuff to this proposal until they get documented, lest people want to know what the undocumented stuff does, start using it, and complain when it changes. I figure that whenever we finalize (assuming this project actually leads somewhere), we can just move whatever is undocumented to the place that makes 
20161105 22:51:00< DeFender1031> the most sense in whatever we've finalized on.
20161105 22:51:11< zookeeper> vultraz, as soon as i get around to trying it, gotta do this HttT thing first
20161105 22:51:21< celticminstrel> Sure, I guess.
20161105 22:52:07< DeFender1031> Why the hesitation?
20161105 22:52:31< celticminstrel> Well, I kinda still want to hear your opinions on it, but I guess it's not urgent.
20161105 22:52:52< DeFender1031> oh, i was planning on doing it privately and showing you.
20161105 22:52:55< DeFender1031> sorry
20161105 22:53:02< celticminstrel> BTW, you can link to the wiki more easily with [wiki=articlename]text[/wiki]
20161105 22:53:07< DeFender1031> yes. communicating effectively. I can do that.
20161105 22:53:09< celticminstrel> That's fine.
20161105 22:53:32< DeFender1031> i'll also probably be asking for a lot more clarification on what stuff does.
20161105 22:53:43< DeFender1031> (since it's not documented and may not be clear from source alone)
20161105 22:53:58< DeFender1031> ah, interesting. Didn't know that tag existed. I'll use it next time.
20161105 22:54:28< celticminstrel> There are several nice convenient tags like that on the forums. :) I think there's one for bugs too.
20161105 22:54:33< vultraz> oh, i suppose i can ask here 
20161105 22:54:38< vultraz> celticminstrel: what's that 'final' keyword do?
20161105 22:54:59< celticminstrel> vultraz: Makes it an error to create a class inheriting from tgrid.
20161105 22:55:05< DeFender1031> wait, you can see the bb source of other peoples' posts?
20161105 22:55:19< celticminstrel> Of course.
20161105 22:55:23< celticminstrel> Anyone can, just by clicking "quote".
20161105 22:55:24< shadowm> Yes, with quote or (if you are a mod) edit.
20161105 22:55:29< DeFender1031> ah
20161105 22:55:47< vultraz> celticminstrel: interesting...
20161105 22:55:56< DeFender1031> were you going to quote me, or do you just routinely click the quote button to check on people's BB? :P
20161105 22:56:06< celticminstrel> vultraz: You can also use it on specific methods (same place as the override keyword).
20161105 22:56:20< celticminstrel> DeFender1031: Nah, I just saw that it was a wikilink and was curious. >_>
20161105 22:56:33< celticminstrel> Because it seems like the sort of thing that people might not know about.
20161105 22:57:34< celticminstrel> BTW, any opinions on these functions? https://wiki.wesnoth.org/LuaAI
20161105 22:57:40< DeFender1031> gotcha. I'd probably do similar. Thanks. ANyway, I edited to use the wiki tag because why not.
20161105 22:57:43 * celticminstrel should edit that to update the fact that some of them are deprecated.
20161105 22:58:18< DeFender1031> i'd think most of those ought to go in wesnoth.ai
20161105 22:59:01< celticminstrel> Well, they're a bit different in that the "ai" table is only available when an AI script is being executed.
20161105 22:59:20< DeFender1031> those may also be difficult for me to document, as I'm not yet versed in lua ai stuff (will be whenever I get around to tweaking the AI on my "defend the castle walls" scenario
20161105 22:59:31< DeFender1031> mmm, interesting
20161105 22:59:42< celticminstrel> I guess they're mostly well-named though, so maybe we can ignore them for the time being.
20161105 22:59:52< celticminstrel> (There's actually a separate "ai" table for each side.)
20161105 23:00:04< DeFender1031> also interesting.
20161105 23:00:18< DeFender1031> okay, so that would make it more difficult to try to shove into the wesnoth table
20161105 23:00:22< vultraz> 1 hour left
20161105 23:00:30< DeFender1031> and knowing that, it makes it make sense to be its own global
20161105 23:00:37< vultraz> anything you want in the release get it in now.
20161105 23:01:36< celticminstrel> Wasn't loonycyborg responsible for tagging?
20161105 23:01:41< DeFender1031> vultraz, sorry I wasn't able to get that string evaluation rewrite in there in time.
20161105 23:02:00< vultraz> I wasn't expecting you to O_O
20161105 23:02:56< vultraz> I expect it will take ~1 month
20161105 23:03:01< vultraz> expected*
20161105 23:03:15< vultraz> would*
20161105 23:03:21 * vultraz goes to get coffee
20161105 23:03:44< celticminstrel> You made two corrections, but only one can apply.
20161105 23:03:59< celticminstrel> Oh wait.
20161105 23:04:15< celticminstrel> I guess the second is s/will/would/ rather than s/expect/would expect/.
20161105 23:04:51-!- TheJJ [~rofl@ipbcc36896.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20161105 23:06:07< vultraz> but really, DeFender1031 only works on wesnoth on Thursdays and last i checked needed to reclone everything.
20161105 23:06:15< vultraz> and then the task is rather daunting
20161105 23:07:01< DeFender1031> more like thursdays are my day when I have the full day to work on it
20161105 23:07:13< DeFender1031> i still do stuff in the evenings on other days
20161105 23:07:33< DeFender1031> (as evidenced by the fact that i just did a bunch of stuff and it's not thursday)
20161105 23:07:54< celticminstrel> Well, it's Saturday though.
20161105 23:08:27< DeFender1031> as for daunting, i'm not sure... Parsing is something i consider myself very good at, and I think I'd actually be able to rewrite that code in a day or two if i managed to catch myself during one of my super-on-focus periods.
20161105 23:08:50< DeFender1031> celticminstrel, yeah, i don't have most of saturday either.
20161105 23:09:10-!- tad_carlucci_ [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161105 23:09:16-!- tadcarlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161105 23:09:42< loonycyborg> vultraz: yeah, definitely better let me do the tagging, only don't expect me to work on it in an hour
20161105 23:09:43< vultraz> well, I'll be happily surprised if it doesn't take a month :)
20161105 23:09:50< celticminstrel> Ooh, I should update this to accept an array of units... https://wiki.wesnoth.org/LuaAI#The_attacks_Aspect
20161105 23:09:51< loonycyborg> it's night here
20161105 23:09:54< DeFender1031> vultraz, challenge accepted :P
20161105 23:10:09< celticminstrel> Why do we have twin tads?
20161105 23:10:22< DeFender1031> celticminstrel, connection issues?
20161105 23:10:32< tad_carlucci_> Because one of me isn't nearly enough.
20161105 23:10:34-!- tad_carlucci_ [~lundberg@173.217.65.103] has quit [Client Quit]
20161105 23:10:37-!- tadcarlucci [~lundberg@173.217.65.103] has quit [Client Quit]
20161105 23:10:43< zookeeper> budding?
20161105 23:10:53< tad_carlucci> Cat walked across the keyboard.
20161105 23:10:54< celticminstrel> Triplet even.
20161105 23:11:01< celticminstrel> Oh, cats.
20161105 23:11:24-!- Appleman1234 [~Appleman1@KD106161209021.au-net.ne.jp] has quit [Ping timeout: 260 seconds]
20161105 23:11:49< DeFender1031> ugh... cats. I'm a dog person myself.
20161105 23:11:59< DeFender1031> And highly allergic to cats
20161105 23:12:06< vultraz> loonycyborg: i can tag it, would rather we get it done at the appointed time
20161105 23:12:29< celticminstrel> Maybe you should've discussed the appointed time with the person who'll be doing it.
20161105 23:12:33< tad_carlucci> Well, I'm a dog person, too. But I'm more of a wife person so I have to put up with a cat as well.
20161105 23:12:33< loonycyborg> but if I find a blocker
20161105 23:12:39< loonycyborg> I'd have to do a retag
20161105 23:13:32< shadowm> Please. No retags.
20161105 23:14:02< shadowm> The correct procedure is to test everything (including building with CMake) before tagging, it's not rocket science.
20161105 23:14:25< tad_carlucci> I've been doing that over and over for days now.
20161105 23:14:28< DeFender1031> tad_carlucci, I have a friend in the same situation. She's had the cat for longer than she's had him, so he kind of had no choice in the matter.
20161105 23:16:56< vultraz> blagh, cmake
20161105 23:17:00< vultraz> why is it cmake >_>
20161105 23:17:08< vultraz> well since I don't use cmake, I suppose i cannot test
20161105 23:17:16< tad_carlucci> I'm running it again.
20161105 23:18:18< vultraz> oh, maybe tad can test and I can tag
20161105 23:18:22< tad_carlucci> The only issue with CMage is earlier this week Arch updated to Boost 1.62, finally. CMake doesn't grok 1.62 so it takes a by-hand patch. Then CMake update this AM and errored.  Clearing the cache and starting afresh solved that.
20161105 23:18:22 * zookeeper blinks
20161105 23:18:27< zookeeper> notepad++ is behaving weird
20161105 23:18:53< tad_carlucci> I started a CMake at 2300UTC. Should finish in a bit.
20161105 23:19:44< shadowm> vultraz: Travis tests the build for you.
20161105 23:19:58< shadowm> What Travis doesn't test is the other stuff outlined in the wiki, the stuff that actually matters.
20161105 23:20:22< loonycyborg> why you want to tag so much?
20161105 23:20:23< vultraz> The problem with 1.13.5 was I did not do a general run of common functions
20161105 23:20:31< vultraz> I can do that :|
20161105 23:20:38< vultraz> I *cannot* do the tarball upload
20161105 23:20:47 * celticminstrel assumes vultraz's reason is only in order to get it done at the appointed time.
20161105 23:20:55< shadowm> Remember that you must test Wesnoth with its default settings and an empty user data directory.
20161105 23:21:07< shadowm> I had a script to do this but obviously it'll do jack on Windows.
20161105 23:21:22< shadowm> But if you took your time you could still make an equivalent for your platform.
20161105 23:21:28< shadowm> s/your/the/
20161105 23:22:10< loonycyborg> pot-update should be done before that
20161105 23:22:15< loonycyborg> I'll get to it now
20161105 23:22:15< tad_carlucci> Takes longer to find the directories on Windows than it does to delete them. The idea is to be as close as possible to a new, never seen it before, user.
20161105 23:22:17< vultraz> uh.. i can just pass a new --userdata-dir 
20161105 23:22:52< tad_carlucci> A new user will install and click. No options.
20161105 23:23:00< celticminstrel> That sounds like it should work, yes.
20161105 23:23:29 * DeFender1031 notes tad_carlucci's use of "Arch" in the same sentence as the typo "CMage" and finds it amusing.
20161105 23:24:14-!- gfgtdf [~chatzilla@x4e369556.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.2/20161019084923]]
20161105 23:24:38< celticminstrel> Heh.
20161105 23:27:16< zookeeper> tad_carlucci, all entries in players_changelog should appear in changelog as well. i just noticed that for example your HttT stuff doesn't
20161105 23:27:55< irker147> wesnoth: ln-zookeeper wesnoth:master 59ec5437b0cb / / (4 files in 3 dirs): HttT: Slight redesign of the scenario by using the assassins MicroAI https://github.com/wesnoth/wesnoth/commit/59ec5437b0cb3714a593f0d3b31e7c4de98f46bc
20161105 23:28:56< tad_carlucci> My systems bogged with a build. Someone want to copy-n-paste the changelog entries for the campaigns I updated?
20161105 23:30:37< vultraz> running general tests
20161105 23:33:27< tad_carlucci> Oh nice. So the Fencer in HttT isn't something to just ignore any longer.
20161105 23:34:25< vultraz> ahh bug found!
20161105 23:36:06< celticminstrel> Uh-oh!
20161105 23:36:24< tad_carlucci> Who has the Raid?
20161105 23:37:46< shadowm> vultraz: --userdata-dir and --userconfig-dir.
20161105 23:37:58< vultraz> what's the other do?
20161105 23:38:20< shadowm> The user data directory and user config directory are two different variables.
20161105 23:38:42< shadowm> On Windows, they default to be the same, but if you use either switch you're modifying only one variable independently.
20161105 23:39:07< shadowm> (On Linux, they point to two different paths by default.)
20161105 23:39:30 * tad_carlucci nods.
20161105 23:39:35< shadowm> We still have --config-dir around, though, that sets them both to be the same.
20161105 23:39:41< tad_carlucci> Windows should do that to if you install "all uses"
20161105 23:39:44< shadowm> I haven't gotten around to renaming it.
20161105 23:39:58< shadowm> (By the way, I wrote the latest version of the Windows logic.)
20161105 23:40:31< shadowm> (I am also quite familiarized with the Linux version since Debian is my daily driver.)
20161105 23:49:15< celticminstrel> I think it'd make more sense if you put userdata in %APPDATA% on Windows.
20161105 23:49:37< celticminstrel> Rather than in Documents\My Games
20161105 23:49:58< celticminstrel> Though I suppose the latter could be seen as "easier to find"...
20161105 23:50:07< loonycyborg> yup, a lot easier to find
20161105 23:50:19< celticminstrel> On the other hand, there's a button in prefs or about to just jump to it, so I wonder if being "easier to find" is really important.
20161105 23:51:57< loonycyborg> I've proposed to keep one of them in appdata and other in my games
20161105 23:52:03< loonycyborg> but shadowm didn't like it :P
20161105 23:52:33< vultraz> a lot of games use my games
20161105 23:52:36< vultraz> what's wrong with it
20161105 23:53:35< shadowm> I was led to believe that this approach was the best one. Personally I'd prefer %appdata% but it seems like some vocal members of our audience are paranoid about Windows applications writing into hidden paths.
20161105 23:54:43< shadowm> I am also aware that %appdata% would be Microsoft's recommendation, although Documents is still acceptable, and the previous approach that 90% of users liked so much was outright retarded.
20161105 23:54:53< irker147> wesnoth: ln-zookeeper wesnoth:master e6744037125f / data/campaigns/Under_the_Burning_Suns/ (8 files in 2 dirs): Added simple to-be-improved-upon hit/die sounds for taurochs https://github.com/wesnoth/wesnoth/commit/e6744037125f58574d6ad7e84b007a0bad6bf997
20161105 23:55:02< zookeeper> now, on to doofus's tweak...
20161105 23:55:06< shadowm> (And caused no small amount of documentation and tech support complications.)
20161105 23:55:32< vultraz> ok I'm postponing the release for *1 hour*
20161105 23:55:40< shadowm> And personally, I do not like the Linux approach of splitting config and data.
20161105 23:55:48< loonycyborg> to fix bug you found?
20161105 23:55:52-!- Appleman1234 [~Appleman1@KD106161212097.au-net.ne.jp] has joined #wesnoth-dev
20161105 23:55:56-!- vultraz changed the topic of #wesnoth-dev to: 1.13.6 planned for Sunday, November 6th (01:00 UTC) | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161105 23:56:35< vultraz> loonycyborg: yes, though i think I have the fix. but also to allow zookeeper time to commit doofus's terrain fix, and for sufficient final testing
20161105 23:56:40< shadowm> It makes sense for system-wide operations (/etc and $PREFIX/share), it does not make sense for users to have to hunt down things on two different paths and ask themselves whether XYZ thing should be considered config or data (hint: application developers tend to have a different answer for that question).
20161105 23:57:04< vultraz> loonycyborg: and for you to pot update
20161105 23:57:05< tad_carlucci> I have ti kill THREE places to wipe back to 'new' .. config cache and saves
20161105 23:57:21< loonycyborg> I'm trying to commit it but new commits keep appearing
20161105 23:57:24< shadowm> Yeah, there's .cache too.
20161105 23:57:37< shadowm> See, this is why I wrote wesnoth-defaults. Because no-one should have to do this crap.
20161105 23:57:49< shadowm> Unless they feel particularly masochistic and wasteful with their time.
20161105 23:58:29< irker147> wesnoth: loonycyborg wesnoth:master 6ff5a78be2fa / / (1502 files in 27 dirs): Pot-update and regenerate doc files https://github.com/wesnoth/wesnoth/commit/6ff5a78be2fa2e5c2ac99328aabc35a29c52c833
20161105 23:59:43< zookeeper> vultraz, nope, the tweak breaks other stuff, so that's not going in
20161105 23:59:52 * celticminstrel wonders what the "regenerate doc files" part actually means.
--- Log closed Sun Nov 06 00:00:01 2016