--- Log opened Tue Nov 08 00:00:02 2016 --- Day changed Tue Nov 08 2016 20161108 00:00:02< vultraz> it's better to clean out old code anyway 20161108 00:00:14< celticminstrel> If it's never going to be used again, sure. 20161108 00:00:24< celticminstrel> That (probably) doesn't apply in this case. 20161108 00:00:25< vultraz> It need to be totally reimplemented 20161108 00:00:28< vultraz> needs 20161108 00:00:40< celticminstrel> Okay, then go reimplement it. 20161108 00:01:09< vultraz> not I! 20161108 00:01:20< vultraz> I..know..noooothing 20161108 00:01:37< celticminstrel> If you know nothing, then how do you know it needs to be totally reimplemented? 20161108 00:02:57< vultraz> I know... some things! :D 20161108 00:03:08< celticminstrel> Uhuh. 20161108 00:04:11< vultraz> tad_carlucci: perhaps you can look and see if this is still needed https://github.com/wesnoth/wesnoth/blob/master/src/neon.hpp 20161108 00:05:27< shadowm> It's OpenPandora support cruft. It can be purged. 20161108 00:07:44< vultraz> purge it is! 20161108 00:07:45< tad_carlucci> Yes, src/neon.hpp is referenced somewhere. 20161108 00:08:22< vultraz> sdl/utils.cpp 20161108 00:09:10< tad_carlucci> yes 20161108 00:09:13 * vultraz removes 20161108 00:09:54< irker540> wesnoth: Charles Dang wesnoth:master b3af9d2b4207 / src/ (neon.hpp sdl/utils.cpp): Removed an OpenPandora support file https://github.com/wesnoth/wesnoth/commit/b3af9d2b42076404a406adb1d917ef958bd78d49 20161108 00:10:04< tad_carlucci> Which means the only programming referring to neon.hpp was create_images which is broken atm 20161108 00:11:36< celticminstrel> Errors in window.cpp. Surely that means I'm almost done with this stage. 20161108 00:16:17-!- abruanese [~a@45.63.76.107] has joined #wesnoth-dev 20161108 00:17:18< tad_carlucci> All the purging today and I still get a clean -pedantic -Wall -Wextra for clang and gcc both. 20161108 00:17:39< celticminstrel> Just don't try to get a clean -Weverything. 20161108 00:17:54< tad_carlucci> Go gods, no. I'm not insane. 20161108 00:18:22< celticminstrel> XD 20161108 00:19:00< celticminstrel> After renaming I want to try uh... -Werror=missing-override or something? 20161108 00:19:04< vultraz> should we purge src/wesmage? 20161108 00:19:11< celticminstrel> What does it do? 20161108 00:19:21< vultraz> " * Tool to test the image conversion functions." 20161108 00:19:32< celticminstrel> Sounds potentially useful? 20161108 00:19:35< tad_carlucci> Its on my list to fix. Comes along with fixing cutter, exploder and create_images. All have the same error 20161108 00:19:53< vultraz> it doesn't do much 20161108 00:20:11< tad_carlucci> Its a build target so I'm intending to fix it. 20161108 00:20:21< celticminstrel> So what does it do? 20161108 00:20:22< vultraz> ok 20161108 00:20:46< celticminstrel> Input IPF, output image file? 20161108 00:21:34< tad_carlucci> Actually those 4 tools targets would build fine, if we don't mind linking the entire wesnoth engine to them just so they can use SDL2 20161108 00:21:51< irker540> wesnoth: Wedge009 wesnoth:master 6faef63beb70 / projectfiles/VC12/ (6 files): Removing recently-deleted files from VC projects. https://github.com/wesnoth/wesnoth/commit/6faef63beb70e795ea746b63969a3b3bf9881df6 20161108 00:23:50< tad_carlucci> Yea, I should ship by test tree over to Windows and see what Visual C++ has to say about all the changes. 20161108 00:29:38< celticminstrel> Looks like it'll pass this time... 20161108 00:29:51< celticminstrel> s/pass/succeed/ 20161108 00:30:00< celticminstrel> Pretty sure it builds in alphabetical order. 20161108 00:30:07< celticminstrel> Which is helpful. 20161108 00:36:13< celticminstrel> Oh, I guess that's per target, so less helpful than it could be... still helpful though... 20161108 00:53:33< wedge009> vultraz: Apparently not, but I tested and closed https://gna.org/bugs/?22324 just now. 20161108 00:54:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 00:58:27-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 246 seconds] 20161108 01:00:38< celticminstrel> Finally finished widgets. Next, auxiliary. 20161108 01:00:45< celticminstrel> But before that, food. 20161108 01:00:45 * tad_carlucci smiles 20161108 01:00:50< celticminstrel> ? 20161108 01:01:09< tad_carlucci> Same here. And a wife to WalMart so she can spend money. 20161108 01:01:14 * tad_carlucci waves 20161108 01:01:20-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.] 20161108 01:08:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161108 01:40:56< irker540> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting f26d2f512eef / / (9 files in 4 dirs): Properly port [modify_side] to Lua https://github.com/wesnoth/wesnoth/commit/f26d2f512eef16bcdac568cbc6245a03a042ee2f 20161108 01:40:58< irker540> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 4248a2ed921c / data/lua/wml-tags.lua src/ai/manager.cpp src/scripting/game_lua_kernel.cpp: Properly port [modify_ai] to Lua https://github.com/wesnoth/wesnoth/commit/4248a2ed921c558332c6946c85292b47216978dd 20161108 01:41:00< irker540> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 154354bb7513 / / (4 files in 4 dirs): Properly port [heal_unit] to Lua https://github.com/wesnoth/wesnoth/commit/154354bb751399cb1d9dad2ca089a643ab95a95f 20161108 01:41:02< irker540> wesnoth: Celtic Minstrel wesnoth:wml_tag_porting 4e8f914300ab / changelog data/lua/wml/message.lua src/scripting/game_lua_kernel.cpp: wesnoth.scroll_to_tile can now skip if onscreen https://github.com/wesnoth/wesnoth/commit/4e8f914300ab2107907806693a618a56791b506e 20161108 02:36:55< vultraz> celticminstrel: how goes it? 20161108 02:37:20< celticminstrel> Working on aux. 20161108 02:41:34< celticminstrel> ...it's telling me I can't name a class after its parent namespace. :| 20161108 02:42:24-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 02:46:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds] 20161108 03:28:38-!- Appleman1234 [~Appleman1@KD106161202234.au-net.ne.jp] has left #wesnoth-dev ["Leaving"] 20161108 03:38:35< celticminstrel> Okay, finished aux. 20161108 03:39:54< celticminstrel> BTW, tformula is now typed_formula. 20161108 03:40:34< celticminstrel> Oh I missed one thing in aux. 20161108 03:40:37< celticminstrel> At least one. 20161108 03:43:23< celticminstrel> I should try to rewrite the case in select_orb_colors to use the iterator instead of the walker. 20161108 03:55:38-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev 20161108 04:04:00-!- astrelyon [~astrelyon@78.134.238.157] has quit [Quit: WeeChat 1.4] 20161108 04:04:17-!- JyrkiVesterinen [~JyrkiVest@87-100-170-244.bb.dnainternet.fi] has joined #wesnoth-dev 20161108 04:18:54< vultraz> yes please :D 20161108 04:22:41-!- travis-ci [~travis-ci@ec2-54-159-173-44.compute-1.amazonaws.com] has joined #wesnoth-dev 20161108 04:22:42< travis-ci> wesnoth/wesnoth#11937 (wml_tag_porting - 4e8f914 : Celtic Minstrel): The build is still failing. 20161108 04:22:43< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174090099 20161108 04:22:43-!- travis-ci [~travis-ci@ec2-54-159-173-44.compute-1.amazonaws.com] has left #wesnoth-dev [] 20161108 04:31:11-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 04:35:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds] 20161108 05:00:38< irker540> wesnoth: Ignacio R. Morelle wesnoth:1.12 e1059405c0ac / changelog src/font.cpp src/unit_animation.cpp: Fix GCC 6 -Wmisleading-indentation warnings https://github.com/wesnoth/wesnoth/commit/e1059405c0ac980b5b09d2f80f82be294f4e79a4 20161108 05:02:35< irker540> wesnoth: Ignacio R. Morelle wesnoth:1.12 213c19729f5c / changelog: Fix grammar https://github.com/wesnoth/wesnoth/commit/213c19729f5ca957eecdefdbedd964957356e4ed 20161108 05:13:50< vultraz> where is zookeepr when you need him 20161108 05:15:42 * celticminstrel working on dialog renames right now. 20161108 05:16:02 * celticminstrel working backwards from U; currently on L. Subdirectories come separately. 20161108 05:16:24< vultraz> ;_; 20161108 05:16:28< celticminstrel> ??? 20161108 05:16:46< JyrkiVesterinen> vultraz: Likely sleeping. It's only 07:16 in Finland. 20161108 05:16:49< vultraz> so far from a 20161108 05:17:27< celticminstrel> Once I'm done you might want to rename some files so that they reflect the name of the class inside. 20161108 05:17:51< tad_carlucci> after you and all my PRs I'm touching a lot of files, too 20161108 05:18:11 * celticminstrel wonders what vultraz even just said. 20161108 05:18:17 * celticminstrel thinks it looks unfinished 20161108 05:18:24< vultraz> so far from 'A'. 20161108 05:18:34< celticminstrel> Oh. 20161108 05:18:41< tad_carlucci> LOW_MEM removal PR is waiting for a compile to finish before I click Create 20161108 05:22:12< celticminstrel> Already at D FYI 20161108 05:22:32< vultraz> :O 20161108 05:22:42< vultraz> flashminstrel 20161108 05:24:02< celticminstrel> That's excluding subdirs though. 20161108 05:24:22< celticminstrel> I could probably make this go a little faster, since I'm sedding one class at a time. 20161108 05:24:33< celticminstrel> But this allows me to make unusual decisions for certain classes. 20161108 05:25:47< tad_carlucci> Bulk rename can be dangerous. Unless you're positive it's the right change, doing slow and careful is best. 20161108 05:26:38< celticminstrel> There were a lot of issues with the rename of widget classes. 20161108 05:26:47< celticminstrel> I don't anticipate many from renaming the dialogs though. 20161108 05:28:59< celticminstrel> On to subdirs now. 20161108 05:30:50< vultraz> i assume you need to do a big rebuild after this :P 20161108 05:30:59< celticminstrel> Of course. 20161108 05:31:20< celticminstrel> I was doing a rebuild after each batch. Maybe that's partly why it took longer than expected. 20161108 05:31:31< celticminstrel> This isn't the last batch though. I missed some things under widgets/ 20161108 05:31:41< vultraz> ;_; 20161108 05:31:47< celticminstrel> And possibly a few other things in other places. 20161108 05:32:39< vultraz> so much stuff to do. 20161108 05:34:32< celticminstrel> tlobby_player_info 20161108 05:34:42< celticminstrel> Do I recall hearing gripes about that being a misleading name? 20161108 05:34:48< celticminstrel> Or am I imagining things? 20161108 05:35:56< vultraz> perhaps.. 20161108 05:36:02< vultraz> but i can't remember what it should be instead 20161108 05:39:27< celticminstrel> Currently on editor/ 20161108 05:44:09< celticminstrel> vultraz: Which one was I supposed to rename to addons_manager? 20161108 05:44:09< vultraz> taddon_list 20161108 05:45:22< celticminstrel> vultraz: "namespace gui2 {" or "namespace gui2 \n{"? 20161108 05:45:46< vultraz> latter unless forward-declaring something 20161108 05:46:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 05:47:49< celticminstrel> So... "namespace gui\n{\nnamespace dialogs\n{"? 20161108 05:48:55< celticminstrel> Should I put non-dialog helpers in the dialogs namespace? (eg mp_options_helper) 20161108 05:49:27< vultraz> yes 20161108 05:50:05 * celticminstrel assumes that's "yes to both" 20161108 05:50:41< vultraz> yes 20161108 05:51:04-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds] 20161108 05:52:34< celticminstrel> vultraz: Please never use "using namespace" in a header (unless it's inside a function). 20161108 05:52:43< vultraz> eh? 20161108 05:52:47< vultraz> where did I do this 20161108 05:52:51< celticminstrel> Prefs dialog 20161108 05:53:13< vultraz> why did I do that... 20161108 05:53:24< celticminstrel> I dunno. 20161108 05:53:29< vultraz> remove it 20161108 05:53:40< celticminstrel> I'm going to move it to the source file. 20161108 05:53:55< celticminstrel> Because removing it altogether will require more extensive changes. 20161108 05:54:05< celticminstrel> (I think it's fine to have it in the source file, anyway.) 20161108 05:54:24< celticminstrel> Oh it was already there, redundantly. 20161108 05:54:26< celticminstrel> Okay then! 20161108 05:57:05-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20161108 06:05:13< celticminstrel> I wonder if C++17 allows stuff like "class gui2::label;"... 20161108 06:05:45< celticminstrel> Gasp! lobby_info isn't in the gui2 namespace! 20161108 06:05:49< celticminstrel> vultraz: Should it be? 20161108 06:06:00< celticminstrel> Seems to be intentional. 20161108 06:06:06< vultraz> uhhhhhhhhhhhhhhhhhhhhhhhhhh............. 20161108 06:06:13< celticminstrel> Since the gui2 namespace is opened right at the bottom of the file for some functions. 20161108 06:06:14< vultraz> not... sure 20161108 06:06:17< vultraz> probably 20161108 06:06:23< celticminstrel> So leave it as it is? 20161108 06:06:27< celticminstrel> Or change it? 20161108 06:07:15< vultraz> leave it for now 20161108 06:07:54< celticminstrel> I think I'll also skip adding the dialogs namespace to this file. Seems silly for just two functions. 20161108 06:08:17< celticminstrel> lobby/data.hpp doesn't even mention the gui2 namespace. 20161108 06:17:39< celticminstrel> Blargh. 20161108 06:18:20< celticminstrel> I don't like gui2::dialogs::showmessage(..., gui2::dialogs::message::yes_no_buttons) 20161108 06:22:51< vultraz> celticminstrel: then don't put it in the dialogs namespace? 20161108 06:23:02< vultraz> you're right, it doesn't really fit 20161108 06:23:07< celticminstrel> That only solves the first half/ 20161108 06:23:21< celticminstrel> Since I think message is the actual class it uses. 20161108 06:58:08-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161108 07:04:56-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.] 20161108 07:06:59-!- JyrkiVesterinen [~JyrkiVest@87-100-170-244.bb.dnainternet.fi] has quit [Quit: .] 20161108 07:53:19< vultraz> celticminstrel: progress? 20161108 07:56:26< celticminstrel> Kinda lost steam. 20161108 07:56:34< celticminstrel> I guess I'll finish it after sleeping. 20161108 07:59:32< vultraz> alright 20161108 08:05:07-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!] 20161108 08:08:59-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev 20161108 08:23:43-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20161108 08:27:32-!- atarocch [~atarocch@31.159.108.130] has joined #wesnoth-dev 20161108 08:29:50< vultraz> ah, there's zookeeper 20161108 08:31:14< zookeeper> yes 20161108 08:31:51< vultraz> zookeeper: i made some progress on fixing the bridge issue 20161108 08:32:21< vultraz> see https://github.com/wesnoth/wesnoth/commit/81659462eb331801bdcf77cbb5008393ecf9846b and https://github.com/wesnoth/wesnoth/commit/0a6a1ab80ed180f3f316f6d02eb2a0874bd5e3df 20161108 08:32:51< vultraz> https://drive.google.com/file/d/0B-mR9s8FduLLNXRuZS0tblYxWTQ/view?usp=sharing 20161108 08:33:01< vultraz> still a few weird issues, though (circled) 20161108 08:33:07< vultraz> but the general case is improved 20161108 08:33:10< vultraz> (as shown) 20161108 08:33:40< vultraz> Stone bridges even use their nice castle transition now 20161108 08:34:29< zookeeper> and you checked that that doesn't lead to layering problems with other terrains? 20161108 08:34:44< vultraz> it seems fine, yes 20161108 08:35:35< zookeeper> right 20161108 08:35:59< vultraz> the remaining issues seem to be with transitions if another hex is adjacent 20161108 08:36:12< vultraz> but I don't know where that code is 20161108 08:37:50< vultraz> like, you can see on the right that the bridge end gets overdrawn if the grass hex is adjacent to the bridge :/ 20161108 08:40:45< vultraz> say you have a dwarven castle on a hex. if one put a, say, chasm bridge to the SW, it wouldn't display right - but if there were another chasm hex to the NW, it would 20161108 08:41:32< vultraz> dwarven castles are weird :| 20161108 08:52:56-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has joined #wesnoth-dev 20161108 08:58:01-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Remote host closed the connection] 20161108 09:01:15-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity] 20161108 09:23:49-!- Bonobo [~Bonobo@2001:44b8:254:3200:8d7a:9e76:8342:3bdc] has quit [Ping timeout: 258 seconds] 20161108 09:24:10-!- Bonobo [~Bonobo@2001:44b8:254:3200:5c6f:5a87:a694:1342] has joined #wesnoth-dev 20161108 09:26:51-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [] 20161108 09:28:34-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev 20161108 09:37:54-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev 20161108 10:43:12-!- jn [d25666fe@gateway/web/freenode/ip.210.86.102.254] has joined #wesnoth-dev 20161108 11:14:40-!- jn [d25666fe@gateway/web/freenode/ip.210.86.102.254] has quit [Quit: Page closed] 20161108 11:38:52-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds] 20161108 12:09:11-!- irker540 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20161108 12:12:47-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20161108 12:19:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20161108 12:31:42-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 12:40:03-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 245 seconds] 20161108 12:40:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 12:53:28-!- Bonobo [~Bonobo@2001:44b8:254:3200:5c6f:5a87:a694:1342] has quit [Quit: Leaving] 20161108 13:51:02-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev 20161108 13:58:29-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 248 seconds] 20161108 14:35:19-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20161108 14:42:44-!- atarocch [~atarocch@31.159.108.130] has quit [Ping timeout: 252 seconds] 20161108 14:43:10-!- atarocch [~atarocch@31.159.108.130] has joined #wesnoth-dev 20161108 14:44:57-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev 20161108 14:51:41-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev 20161108 15:53:52-!- atarocch [~atarocch@31.159.108.130] has quit [Ping timeout: 252 seconds] 20161108 15:58:45-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .] 20161108 16:03:35-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has quit [Read error: Connection reset by peer] 20161108 16:04:51-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has joined #wesnoth-dev 20161108 17:01:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 17:01:12-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer] 20161108 17:04:59-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev 20161108 17:07:27-!- gfgtdf [~chatzilla@x4e32b6b5.dyn.telefonica.de] has joined #wesnoth-dev 20161108 17:08:51-!- JyrkiVesterinen [~JyrkiVest@89-166-120-46.bb.dnainternet.fi] has joined #wesnoth-dev 20161108 17:10:45-!- boucman_work [~boucman@LStLambert-657-1-76-184.w80-13.abo.wanadoo.fr] has quit [Remote host closed the connection] 20161108 17:19:47-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 17:20:41-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds] 20161108 17:29:54-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev 20161108 17:51:53-!- gfgtdf [~chatzilla@x4e32b6b5.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0.2/20161019084923]] 20161108 17:54:22-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind] 20161108 18:04:07-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev 20161108 18:04:07-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer] 20161108 18:09:23-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161108 18:10:02-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend] 20161108 18:15:34-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev 20161108 18:21:57-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev 20161108 18:36:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 18:37:13-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev 20161108 18:37:31< ancestral> I’ve built Wesnoth, but translations continues to not work 20161108 18:37:46< ancestral> `scons translations` fails 20161108 18:38:21< celticminstrel> How does it fail? 20161108 18:38:33< celticminstrel> It works for me. 20161108 18:39:40< ancestral> https://paste.ee/p/ZqZ0H 20161108 18:41:12< celticminstrel> It's claiming success, huh... 20161108 18:41:21< ancestral> Ogg Vorbis support is no, but then it just silently saying prereqs not met 20161108 18:41:38< ancestral> Want to see the config.log? 20161108 18:42:14< ancestral> https://paste.ee/p/c0yC5 20161108 18:42:43< celticminstrel> config.log shouldn't be relevant for "translations"... 20161108 18:42:55< celticminstrel> Scons is claiming it's up-to-date - are you sure it didn't work? 20161108 18:53:42< tad_carlucci> have you tried a force config 20161108 18:53:51< tad_carlucci> --config=force 20161108 18:54:28< tad_carlucci> I've had stuff update like a library to a newer version and had to do that to pick up the change 20161108 18:56:48-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind] 20161108 19:01:47< ancestral> I’ll try that 20161108 19:02:04< ancestral> NLS tools are not present… 20161108 19:02:11< ancestral> NLS catalogue installation is disabled. 20161108 19:02:12 * celticminstrel assumes you do have the gettext tools installed... 20161108 19:02:17< ancestral> `translations' is up to date. 20161108 19:02:22< ancestral> But there are no translations 20161108 19:02:36< ancestral> celticminstrel: I don’t know 20161108 19:02:55< ancestral> brew update and I’ll see 20161108 19:02:58< celticminstrel> which msgfmt 20161108 19:03:08< celticminstrel> ^execute that 20161108 19:03:19< ancestral> NOthing 20161108 19:03:26< celticminstrel> Well that would explain it.. 20161108 19:03:41< ancestral> brew install getttext or msgfmt 20161108 19:03:43< ancestral> ? 20161108 19:03:47< celticminstrel> Not sure. 20161108 19:03:50< ancestral> (one too many t's) 20161108 19:04:06< celticminstrel> Probably won't be under msgfmt. 20161108 19:04:07< ancestral> It’s not msgfmt so okau 20161108 19:04:18< celticminstrel> There should be several tools in one package. 20161108 19:04:19< ancestral> Already installed 20161108 19:04:29< ancestral> Warning: gettext-0.19.8.1 already installed 20161108 19:04:37< ancestral> remove and reinstall? 20161108 19:04:41< celticminstrel> Is there a gettext-tools or something? 20161108 19:05:16< ancestral> Hmm, no 20161108 19:06:04< ancestral> Removing and reinstalling then 20161108 19:06:19< ancestral> Maybe it broke when I went to Sierra 20161108 19:06:26< celticminstrel> Yeah, guess gettext is the correct package. 20161108 19:06:27< ancestral> celticminstrel: Also curious, got two errors when I built 20161108 19:06:32< celticminstrel> $ port provides `which msgfmt` 20161108 19:06:41< celticminstrel> /opt/local/bin/msgfmt is provided by: gettext 20161108 19:06:44< ancestral> In two .hpps 20161108 19:07:11< ancestral> concept_checks.hpp:53 and :54 20161108 19:07:17< ancestral> unused typedefs 20161108 19:07:23< celticminstrel> Where? 20161108 19:07:29< celticminstrel> src/utils or what? 20161108 19:08:07< ancestral> Boost headers 20161108 19:08:11< ancestral> There was another one 20161108 19:08:16< celticminstrel> Oh, 20161108 19:08:26< ancestral> tag_of.hpp possibly 20161108 19:09:12< ancestral> Okay I installed gettext 20161108 19:09:20< ancestral> Again, translations not working 20161108 19:09:48< celticminstrel> which msgfmt still no output? 20161108 19:10:18< ancestral> Still no output 20161108 19:10:31< celticminstrel> Weird... 20161108 19:11:47< celticminstrel> Can you check if msgfmt exists anywhere in the Homebrew install area? 20161108 19:12:00 * celticminstrel thinking it might not have been added to $PATH or something. 20161108 19:12:36< celticminstrel> (Or, Homebrew symlinks stuff to /usr/local, right? Maybe it didn't symlonk those.) 20161108 19:17:19< ancestral> celticminstrel: LDFLAGS: -L/usr/local/opt/gettext/lib 20161108 19:17:19< ancestral> CPPFLAGS: -I/usr/local/opt/gettext/include 20161108 19:17:24< ancestral> How can I add that? 20161108 19:17:48< celticminstrel> I'm not sure you need it... 20161108 19:18:28< celticminstrel> I would expect to find msgfmt in someplace like /usr/local/opt/gettext/bin 20161108 19:19:53< celticminstrel> You're only doing the translations, so it's just the tools you need, not libs and includes. 20161108 19:24:23< ancestral> celticminstrel: I do see msgfmt exactly there 20161108 19:25:21< celticminstrel> So PATH="/usr/local/opt/gettext/bin:$PATH" scons translations 20161108 19:25:24< celticminstrel> Should work 20161108 19:25:30< celticminstrel> Though it's not a permanent solution. 20161108 19:26:01< ancestral> Yeah that works 20161108 20:31:04-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev 20161108 20:34:36-!- irker990 [~irker@uruz.ai0867.net] has joined #wesnoth-dev 20161108 20:34:36< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 0475f8d5d0d8 / / (8 files in 3 dirs): WIP: a widget that forces its child widget to a fixed size https://github.com/wesnoth/wesnoth/commit/0475f8d5d0d8231400f21ee26c63a8f38841d52b 20161108 20:34:36< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox e56eef75e1ea / / (8 files in 3 dirs): Minor fixes https://github.com/wesnoth/wesnoth/commit/e56eef75e1ea8e0cd66e9190fdeb1689c097cc9f 20161108 20:34:37< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 6da69a8260fd / data/gui/ (macros/_initial.cfg schema.cfg widget/size_lock_default.cfg): The WML part https://github.com/wesnoth/wesnoth/commit/6da69a8260fd24776f817ea4bcfb3a6d3b21b6f1 20161108 20:34:38< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox a28954f49e23 / src/gui/widgets/size_lock.cpp: Fix crashes https://github.com/wesnoth/wesnoth/commit/a28954f49e2398ad6a36b7bbca7fac4efca31d01 20161108 20:34:39< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox bc7af1707106 / data/gui/ (macros/_initial.cfg widget/size_lock_default.cfg): Fix the wrapped widget not filling allocated size https://github.com/wesnoth/wesnoth/commit/bc7af1707106f009cb1639ecb3f9542d15a8e5a3 20161108 20:34:41< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox e81b47aa4a09 / src/gui/widgets/size_lock.cpp: Allow either dimension to be zero https://github.com/wesnoth/wesnoth/commit/e81b47aa4a09b36ce05fd274d61db2185a9f1c23 20161108 20:34:43< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 1b45958bc0fe / data/gui/window/ (lobby_main.cfg mp_join_game.cfg mp_staging.cfg): Lock sizes of most chat boxes https://github.com/wesnoth/wesnoth/commit/1b45958bc0fea5269f5b574941051ac77e67bc93 20161108 20:34:45< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox c981a5ecc8f3 / src/gui/widgets/ (size_lock.cpp size_lock.hpp): Handle the situation where the content initially wants to be too large https://github.com/wesnoth/wesnoth/commit/c981a5ecc8f330ceb5fe24587bff71f08c6a9ea0 20161108 20:34:47< irker990> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 47db7a9ffd6c / data/gui/window/lobby_main.cfg: Lock size of the chat box in the low-resolution MP lobby https://github.com/wesnoth/wesnoth/commit/47db7a9ffd6c344da84eb9c22a6ce5285985c6d5 20161108 20:42:22< celticminstrel> I wonder if anyone knows why underlying_id exists. 20161108 20:42:55 * celticminstrel knows that iceiceice did some stuff regarding units, so maybe he has some idea... 20161108 20:43:28< Shiki> I just saw that for 4 terrains the images doesn't get shown here https://wiki.wesnoth.org/TerrainCodeTableWML 20161108 20:43:50< Shiki> Somewhere in the middle, it's about walls 20161108 20:43:57< Shiki> anybody an idea why? 20161108 20:45:14< zookeeper> maybe due to moved/renamed images 20161108 20:46:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!] 20161108 20:47:16< zookeeper> stone wall images were recently moved, and the hewn wall became the mine wall so the names changed 20161108 20:48:02< Shiki> wesnoth/data/tools/terrain2wiki.py is the script which generates the page, it loads the images from github master, but shows the 1.12 terrains as far as i got it 20161108 20:48:27-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 20:50:00< Shiki> Could we just change this line to load the 1.12 images somewhere from? https://github.com/sevu/wesnoth/blob/3be5743d41a1acc6b10f278352bf122abdb2ef41/data/tools/terrain2wiki.py#L15 But not commiting that to master, just 1.12? 20161108 21:01:58< JyrkiVesterinen> Commit. https://github.com/wesnoth/wesnoth/commit/53bc8a7f1d5e98f42d91ef72b846767356c73952 Irker didn't notify about it for some reason. 20161108 21:02:14< celticminstrel> Come to think of it, one way to manage a prototypal unit system would be to flip the API around - make the units be managed by Lua, and the C++ unit class merely becomes a wrapper for the Lua unit. 20161108 21:02:34< celticminstrel> Lua can handle a prototype chain, I think. 20161108 21:03:08< celticminstrel> I'm not quite sure if it can be done as cleanly as JS... 20161108 21:03:12< zookeeper> Shiki, or the script in master can just always be pointing to the latest stable, since that's probably what we want on that page 20161108 21:03:19 * celticminstrel vaguely recalls some problems in attempting it once. 20161108 21:03:19< JyrkiVesterinen> Yes, Lua doesn't have any problems with prototype chains. 20161108 21:08:51-!- JyrkiVesterinen [~JyrkiVest@89-166-120-46.bb.dnainternet.fi] has quit [Quit: Going to bed] 20161108 21:13:03-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20161108 21:20:00-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev 20161108 21:21:09-!- atarocch [~atarocch@93.56.160.30] has joined #wesnoth-dev 20161108 21:24:25< Shiki> zookeeper, I think there is no url which points everytime to the last stable. 20161108 21:24:39< zookeeper> of course 20161108 21:24:50< zookeeper> i just meant that master could, right now, be made to point to 1.12 20161108 21:24:59< zookeeper> and then changed on 1.14 release 20161108 21:25:04< Shiki> yes 20161108 21:25:31-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Ping timeout: 256 seconds] 20161108 21:26:18< Shiki> though, right now we could just rerun the script once, with the url pointing to 1.12. The last update of the page was in march 2015, guess the next one will be on 1.14 then 20161108 21:38:54-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 21:39:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection] 20161108 21:43:01< vultraz> ancestral: still an issue? https://gna.org/bugs/index.php?24578 20161108 21:43:26< ancestral> Lemme see 20161108 21:43:41< ancestral> I should have the package done tonight 20161108 21:44:00< vultraz> sweet :) 20161108 21:44:07< ancestral> vultraz: Still a problem 20161108 21:44:16< vultraz> not sweet :( 20161108 21:44:21< ancestral> I don’t know enough about how to fix that 20161108 21:44:25< ancestral> Maybe celticminstrel has an idea? 20161108 21:44:42< ancestral> Cocoa notifications and Growl notifications, afaik both work 20161108 21:44:45< vultraz> he's still on 10.7 20161108 21:45:49< celticminstrel> ancestral: So they work, but are they shown as supported in the version dialog? 20161108 21:46:08< ancestral> celticminstrel: They are shown as not supported 20161108 21:46:11< ancestral> But they work 20161108 21:46:19< celticminstrel> Well that's not good. 20161108 21:46:27< ancestral> They most certainly do (at least, the last time I checked, and I should say, the notifications do anyway) 20161108 21:46:51< celticminstrel> But it sounds like it should be an easy fix. 20161108 21:46:59< ancestral> I would guess 20161108 21:51:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20161108 21:53:30< zookeeper> vultraz, btw, should you choose to announce in my absence, you can just move my desert elf thread to the UtBS feedback forum and edit out the green note. because otherwise the announcement will link to the thread but no one can actually view it. 20161108 21:53:43< vultraz> ok 20161108 21:53:51< vultraz> will do 20161108 21:54:24< zookeeper> tremendous 20161108 21:54:54-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV] 20161108 21:55:58-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 21:56:05-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20161108 21:56:13-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev 20161108 21:59:21-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds] 20161108 22:03:18-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection] 20161108 22:09:37-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 260 seconds] 20161108 22:12:19-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai] 20161108 22:16:43-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev 20161108 22:18:06-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Ping timeout: 256 seconds] 20161108 22:30:47-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev 20161108 22:46:50-!- stikonas_ is now known as stikonas 20161108 22:54:57< celticminstrel> This is taking longer than expected, though I think I can still finish it today. 20161108 22:57:25< vultraz> but you were almost done :| 20161108 22:58:12< Aginor> vultraz: rule 10; it always takes longer than the initial estimate, so double or triple the estimate (or multiply by pi) 20161108 22:58:30< celticminstrel> Haha, pi. 20161108 22:58:37< celticminstrel> vultraz: I'm still almost done. 20161108 22:58:49< celticminstrel> Currently I'm running into the difficulty of adding the namespace everywhere. 20161108 23:00:58< celticminstrel> We should probably wait at least a day before merging to give people a chance to look over it, too... 20161108 23:01:12-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev 20161108 23:05:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy] 20161108 23:07:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev 20161108 23:09:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit] 20161108 23:13:41-!- atarocch [~atarocch@93.56.160.30] has quit [Remote host closed the connection] 20161108 23:35:27-!- irker990 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout] 20161108 23:41:12-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20161108 23:41:22-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 23:45:14-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer] 20161108 23:45:56-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev 20161108 23:52:57-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev 20161108 23:59:04-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection] 20161108 23:59:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev --- Log closed Wed Nov 09 00:00:30 2016