--- Log opened Wed Nov 09 00:00:30 2016
20161109 00:01:12-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161109 00:01:30-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 00:19:25-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161109 00:21:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 00:37:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 00:40:43-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161109 00:41:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 00:41:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 00:50:26-!- ancestral [~ancestral@72.sub-174-219-7.myvzw.com] has joined #wesnoth-dev
20161109 00:56:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161109 00:59:00-!- ancestral [~ancestral@72.sub-174-219-7.myvzw.com] has quit [Remote host closed the connection]
20161109 01:05:24-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161109 01:06:34-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161109 01:06:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 01:07:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 01:10:19-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161109 01:11:14-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161109 01:22:41-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 01:23:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 01:27:34-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 01:32:07-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20161109 01:37:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 01:47:48-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161109 01:53:35-!- nore [~ncourant@sas.eleves.ens.fr] has quit [Ping timeout: 265 seconds]
20161109 01:58:48-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 02:00:53-!- nore [~ncourant@sas.eleves.ens.fr] has joined #wesnoth-dev
20161109 02:34:31-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Read error: Permission denied]
20161109 02:34:57-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161109 03:06:24< celticminstrel> Well, one more batch and I should be done.
20161109 03:17:46-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161109 03:29:20< celticminstrel> Build finished successfully, so now I can start said final batch.
20161109 03:42:04 * celticminstrel poke vultraz 
20161109 03:42:14< vultraz> :D
20161109 03:42:15< celticminstrel> src/tools/sdl2
20161109 03:42:24< celticminstrel> Was that deleted or am I imagining things
20161109 03:43:13 * celticminstrel poke vultraz again?
20161109 03:43:22< vultraz> it was
20161109 03:43:33< celticminstrel> Okay so no point renaming things there.
20161109 03:44:04< celticminstrel> nacl and neon were also deleted (the former in a PR but close enough(, anything else of note?
20161109 03:44:05< celticminstrel> ^)3
20161109 03:44:48< vultraz> uh, nope
20161109 03:45:04< celticminstrel> Hmm, wonder what the "tristate" type is for in units/frame.hpp.
20161109 03:45:10< celticminstrel> Maybe it can be replaced with boost::tribool.
20161109 03:45:24 * celticminstrel not going to investigate that closely right now though.
20161109 03:45:42< celticminstrel> Wesmage isn't being deleted, right?
20161109 03:46:18< vultraz> no
20161109 03:49:03< celticminstrel> So the plan is: 1) Rename everything I missed before. 2) Build. Fix any errors, repeat until successful. 3) Rebase to current master. 4) Same as 2.
20161109 03:49:22< celticminstrel> I hope there won't be any errors though. That'll increase the time significantly.
20161109 03:49:57< vultraz> yeah, tristate can probably be replaced with boost::tribool
20161109 03:50:11< celticminstrel> Should examine it carefully first though.
20161109 04:02:18< celticminstrel> Building. While I hope there will be no errors, I kinda think that's not likely to happen..
20161109 04:07:24-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161109 04:15:42-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 250 seconds]
20161109 04:23:10-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20161109 04:45:20-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161109 04:52:45-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161109 05:03:07-!- JyrkiVesterinen [~JyrkiVest@87-100-220-17.bb.dnainternet.fi] has joined #wesnoth-dev
20161109 05:16:46< celticminstrel> Sigh.
20161109 05:17:15< celticminstrel> Well, I fixed all the errors except possibly for some in generator, so hopefully it'll build now.
20161109 05:18:29< celticminstrel> ...
20161109 05:18:36< celticminstrel> Argh, I have to change generator.hpp now.
20161109 05:18:57< celticminstrel> Unless...
20161109 05:19:01< celticminstrel> Hmm.
20161109 05:56:21-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 05:59:49< celticminstrel> Well.
20161109 06:00:04< celticminstrel> Looks like I can push.
20161109 06:00:10< celticminstrel> After I rebase
20161109 06:07:32< vultraz> YAY \o/
20161109 06:07:39< vultraz> one bit of good news today
20161109 06:11:24< celticminstrel> wesmage complains of undefined identifier assert.
20161109 06:11:39< celticminstrel> Well, pretty sure that's not my fault, so I'll ignore it.
20161109 06:11:55< celticminstrel> I think tad was planning to fix stuff there anyway.
20161109 06:12:04< vultraz> yes
20161109 06:12:51< celticminstrel> I think I changed something in neon or something so there might be a delete-modify conflict, but that's trivially resolved.
20161109 06:13:09< celticminstrel> Oh yeah, there was that delete-delete too.
20161109 06:13:52< celticminstrel> Oh huh, modify-delete on room manager.
20161109 06:14:10< celticminstrel> I'm gonna resolve by restoring it.
20161109 06:14:19< vultraz> celticminstrel: please don't :|
20161109 06:14:37< vultraz> don't re-add files by resolving a merge conflict
20161109 06:14:47< celticminstrel> Uhh. That's how you resolve merge conflicts.
20161109 06:14:53< celticminstrel> You either delete it or put it back.
20161109 06:15:17< vultraz> i'd rather you do not restore the network code
20161109 06:15:25< celticminstrel> Why would I restore the network code?
20161109 06:15:33< celticminstrel> I'm talking about the room manager.
20161109 06:15:46< vultraz> isn't that what was deleted
20161109 06:15:54< celticminstrel> It was deleted, yes, and I was not happy about that.
20161109 06:16:04< celticminstrel> srd/tools/sdl2 was deleted, huh.
20161109 06:16:08< vultraz> i'd rather you not restore it
20161109 06:16:10< celticminstrel> Well, this time I can resolve by deleting.
20161109 06:16:21< vultraz> and if you do, do it separately 
20161109 06:16:25< vultraz> in a reversion commit
20161109 06:16:43< celticminstrel> Uhh, fine, I'll rebase again and insert a reversion commit.
20161109 06:17:35< vultraz> i still don't know why you're so unhappy
20161109 06:17:36< celticminstrel> Maybe delete-delete won't be a conflict actually.
20161109 06:17:57< celticminstrel> Huh? The boilerplate header was deleted?
20161109 06:18:00< vultraz> loonycyborg is the only one who should be unhappy
20161109 06:18:17< celticminstrel> I don't know why he should be unhappy.
20161109 06:18:31< vultraz> since he.. has to work on the room code?
20161109 06:18:37< celticminstrel> Does he?
20161109 06:18:49< celticminstrel> Was he planning to reimplement it then?
20161109 06:18:53< vultraz> yes
20161109 06:18:56< celticminstrel> Hmm.
20161109 06:19:12< vultraz> i asked him to
20161109 06:19:17< vultraz> but he said it would be some work
20161109 06:19:18< celticminstrel> And he said he would?
20161109 06:19:53< celticminstrel> Okay so why is this a rename-delete conflict...
20161109 06:20:05< celticminstrel> Was src/tests/utils/fake_event_source.cpp deleted?
20161109 06:20:12< celticminstrel> And src/boilerplate-header.cpp?
20161109 06:20:13< vultraz> iirc yes
20161109 06:20:13-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 06:20:16< vultraz> latter no
20161109 06:20:27< celticminstrel> There's no way I would've renamed either...
20161109 06:20:48< celticminstrel> "added by us"
20161109 06:20:51< celticminstrel> Uhh.
20161109 06:21:09< celticminstrel> IIRC that means "added by the base branch"?
20161109 06:21:26< vultraz> ehh?
20161109 06:21:40< celticminstrel> I'm confused by git's terminology here.
20161109 06:22:46< celticminstrel> git status says "added by us: src/boilerplate-header.cpp"
20161109 06:23:02< vultraz> i.. have no idea what's happening
20161109 06:23:23< celticminstrel> Okay, so do the two files I mentioned exist on latest master or not?
20161109 06:23:32< shadowm> boilerpalte-header.cpp does.
20161109 06:23:32< celticminstrel> I should resolve in favour of the current state of things, I think.
20161109 06:23:40< JyrkiVesterinen> They do. I checked fake_event_source.cpp.
20161109 06:23:44< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/master/src/tests/utils/fake_event_source.cpp
20161109 06:23:54< celticminstrel> Okay, so I guess I'll add them?
20161109 06:24:08< shadowm> It sounds like something went wrong at your end.
20161109 06:24:20< celticminstrel> Well yes, I'm rebasing and getting merge conflicts.
20161109 06:24:26< shadowm> boilerplate-header.png was last modified on January 2016.
20161109 06:24:33< celticminstrel> You mean .cpp right.
20161109 06:24:38< shadowm> I suspect your branch is much younger than that.
20161109 06:24:49< shadowm> Obviously .cpp.
20161109 06:24:55< celticminstrel> It's something like 100 commits behind master, yes.
20161109 06:25:20< celticminstrel> Okay srd/tools/sdl2 deleted, so that's easily resolved...
20161109 06:26:39< celticminstrel> Ah, Jyrki's added comment caused a conflict huh. Looks minor though.
20161109 06:27:18< celticminstrel> Yeah, he literally just added lines at that place, no changed lines.
20161109 06:27:23-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161109 06:27:40-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161109 06:29:00< celticminstrel> So I think I'll just push it as is for now. I can decide what to do with the room manager once loonycyborg is around.
20161109 06:29:47< celticminstrel> Flood of commits coming (feel free to disable irker if you want).
20161109 06:29:54< shadowm> How many?
20161109 06:30:16< celticminstrel> 26
20161109 06:30:22-!- mode/#wesnoth-dev [+o shadowm] by ChanServ
20161109 06:30:29-!- mode/#wesnoth-dev [+qz irker*!*@*] by shadowm
20161109 06:31:16-!- irker942 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161109 06:32:09-!- mode/#wesnoth-dev [-qzo irker*!*@* shadowm] by shadowm
20161109 06:34:03< celticminstrel> I guess irker'd be about done by now probably?
20161109 06:35:35< shadowm> Uh.
20161109 06:35:49< vultraz> did you push to a branch?
20161109 06:35:52< celticminstrel> Yes.
20161109 06:36:01< shadowm> I thought it was pretty obvious that I quieted it first, then I unquieted after it finished.
20161109 06:36:22< celticminstrel> My client doesn't show mutes/unmutes.
20161109 06:36:28< celticminstrel> So I had no idea.
20161109 06:36:29< celticminstrel> https://github.com/wesnoth/wesnoth/pull/870
20161109 06:36:29< shadowm> Your client is trash.
20161109 06:36:33< shadowm> :)
20161109 06:36:45< vultraz> i will wait for travis before merging
20161109 06:36:47< celticminstrel> Well, that's going a bit far.
20161109 06:36:58< shadowm> IRC clients really shouldn't hide channel mode changes, ever.
20161109 06:37:17< shadowm> Unless the user specifically configures their client to do that.
20161109 06:37:24< celticminstrel> vultraz: I suggest waiting to see if Aginor has anything to say too, since he was one pushing for it to be a PR.
20161109 06:37:35< vultraz> ..alright
20161109 06:37:42< shadowm> And yes, I did mean 'hide'. These notifications aren't opt-in protocol-wise.
20161109 06:38:05< celticminstrel> shadowm: Well, it pretties up the mode-changes to eg "X was promoted to operator", and I guess they forgot a fallback for unknown modes.
20161109 06:38:24< shadowm> So I could quiet you and you wouldn't know.
20161109 06:38:27 * celticminstrel forgot the by in the example, but you get the idea.
20161109 06:38:31< celticminstrel> I guess so.
20161109 06:38:53< celticminstrel> That would be pretty annoying.
20161109 06:38:57< shadowm> I could go a step further and op myself and set mode +z like I do with irker and you really wouldn't be able to tell your messages aren't getting to the channel.
20161109 06:39:14< celticminstrel> Possibly.
20161109 06:39:15< shadowm> Until you looked at the logs the next day.
20161109 06:40:04 * celticminstrel shrug
20161109 06:40:55-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 06:45:18-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20161109 06:46:07< vultraz> ..oh my god
20161109 06:46:10< vultraz> i just realized
20161109 06:46:17< vultraz> there are other merge options on gh
20161109 06:46:24< Aginor> oh, a wild PR appears
20161109 06:46:26< vultraz> besides merge commit
20161109 06:46:29< vultraz> p_p
20161109 06:46:47< celticminstrel> Huh? You didn't notice the new squash option before now?
20161109 06:46:53-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 06:48:00< vultraz> there's also a rebase option
20161109 06:48:02< vultraz> and no
20161109 06:48:21< celticminstrel> Wait what?
20161109 06:48:37< celticminstrel> Oh huh.
20161109 06:48:47< celticminstrel> There's another new option now.
20161109 06:48:55< vultraz> this is amazing
20161109 06:49:06< celticminstrel> Well, this one is definitely not something to squash though.
20161109 06:49:33< vultraz> yes
20161109 06:51:47-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20161109 06:55:45-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20161109 06:55:46< travis-ci> wesnoth/wesnoth#11952 (gui_renaming - b6c88df : Celtic Minstrel): The build failed.
20161109 06:55:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174417240
20161109 06:55:46-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20161109 06:56:10< celticminstrel> Well, I sorta thought that might happen.
20161109 06:56:38< celticminstrel> Given that one build passes, I guess it's probably the tests.
20161109 06:56:47< vultraz> no
20161109 06:56:49< vultraz> it is not
20161109 06:57:00< celticminstrel> Okay.
20161109 06:57:05< vultraz> src/gui/dialogs/message.hpp:145:11: error: declaration of ‘gui2::button* gui2::dialogs::message::tbutton_status::button’ [-fpermissive]
20161109 06:57:07< vultraz>    button* button;
20161109 06:57:08< vultraz>            ^
20161109 06:57:10< vultraz> src/gui/dialogs/message.hpp:24:7: error: changes meaning of ‘button’ from ‘class gui2::button’ [-fpermissive]
20161109 06:57:11< vultraz>  class button;
20161109 06:57:13< vultraz>        ^
20161109 06:57:22< celticminstrel> Okay, so it's the hiding that I mentioned in the PR description.
20161109 07:01:37-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161109 07:09:46-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 07:10:26< celticminstrel> Uhhh. What?
20161109 07:10:39< celticminstrel> Oh, wait, I see.
20161109 07:10:45< celticminstrel> So there is in fact an issue in the tests then.
20161109 07:12:11< celticminstrel> GCC gives the hiding errors, clang shows unit test compile errors.
20161109 07:13:04< celticminstrel> Hmm, I seem to have gcc5, so I can try that.
20161109 07:13:44< celticminstrel> After I fix the tests.
20161109 07:16:16< celticminstrel> test_drop_target? :O
20161109 07:16:30< celticminstrel> There was something like a drop target?
20161109 07:16:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 07:17:39< vultraz> gui1
20161109 07:17:49< celticminstrel> ...aww.
20161109 07:20:21< Aginor> as horrid as the ttypes were, it made it clear what was a class or variable
20161109 07:20:29< Aginor> that's less clear now
20161109 07:21:17< celticminstrel> Do you have a better suggestion?
20161109 07:22:00-!- JyrkiVesterinen [~JyrkiVest@87-100-220-17.bb.dnainternet.fi] has quit [Quit: Going to work]
20161109 07:22:12< celticminstrel> I think simply dropping the t- is fine for the dialog classes, at least.
20161109 07:22:19< Aginor> CamelCase ?
20161109 07:22:24< Aginor> not that it's much better
20161109 07:22:34< Aginor> and mixing CamelCase and snake_case will be horrible
20161109 07:22:50< Aginor> type_t mayhaps?
20161109 07:23:17< celticminstrel> It's a possibility.
20161109 07:23:23< celticminstrel> I even did that already in a few cases.
20161109 07:23:33< Aginor> yeah
20161109 07:23:35< Aginor> hmm
20161109 07:23:45< Aginor> github gave up because the PR is too big
20161109 07:24:13< celticminstrel> I was hoping that wouldn't happen...
20161109 07:24:19< Aginor> I've added some feedback, mostly where I think that the typenames are unclear
20161109 07:24:21< celticminstrel> Though are you trying to view the whole thing at once?
20161109 07:24:31< celticminstrel> Might be fine if you just view one commit at a time.
20161109 07:24:35< celticminstrel> Okay, I'll take a look.
20161109 07:24:55< Aginor> of course I'm viewing the whole thing at the same time
20161109 07:25:04< Aginor> I will however go and hunt food now
20161109 07:25:15< Aginor> it will make me less grouchy
20161109 07:25:20-!- astrelyon [~astrelyon@dh207-118-57.xnet.hr] has joined #wesnoth-dev
20161109 07:25:28< celticminstrel> Well, viewing it all at once does mean you don't see any interim changes that got wiped out, I guess.
20161109 07:25:50< celticminstrel> But I'm not surprised that that diff is too big for github.
20161109 07:25:58< Aginor> yeah, I don't really care about the interim changes you make, I only care about the end result
20161109 07:26:12< Aginor> I might load it up in a real editor later and have more of a look
20161109 07:26:18< celticminstrel> 'kay
20161109 07:27:26< celticminstrel> Wait, I don't see your comments?
20161109 07:27:44< celticminstrel> Oh, now I see them.
20161109 07:27:49< Aginor> oh, I had to submit the review
20161109 07:27:55< Aginor> good thing you said something
20161109 07:28:03< Aginor> I was just about to walk away ;)
20161109 07:32:37< celticminstrel> I may opt to just add new commits addressing feedback, rather than rebasing to edit the original commit... not sure yet.
20161109 07:33:17-!- celticminstrel is now known as celmin|sleep
20161109 07:34:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 07:40:07< Aginor> that's fine
20161109 07:40:14< Aginor> feel free to ignore if it doesn't make sense
20161109 07:54:58-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 08:08:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 08:10:06-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161109 08:19:04-!- atarocch [~atarocch@93.68.243.58] has joined #wesnoth-dev
20161109 08:19:28-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 08:24:01-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 08:34:01-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Read error: Connection reset by peer]
20161109 08:34:36-!- iwaim [~iwaim@2001:2c0:40e:2002:ec6b:8c94:26b5:67ff] has joined #wesnoth-dev
20161109 08:34:47-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 08:39:25-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 08:55:35-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20161109 08:55:37-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20161109 08:55:37-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 08:59:34-!- TC02 [~quassel@venus.arosser.com] has quit [Ping timeout: 256 seconds]
20161109 09:00:10-!- TC02 [~quassel@venus.arosser.com] has joined #wesnoth-dev
20161109 09:08:05-!- iwaim [~iwaim@2001:2c0:40e:2002:ec6b:8c94:26b5:67ff] has quit [Ping timeout: 260 seconds]
20161109 09:08:30-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20161109 09:28:06-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 09:32:12-!- irker942 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161109 09:38:08-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has joined #wesnoth-dev
20161109 09:53:05-!- irker340 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161109 09:53:05< irker340> wesnoth: ln-zookeeper wesnoth:master 28aca3e70012 / data/campaigns/Under_the_Burning_Suns/units/quenoth/ (8 files): UtBS: Added missing default AMLAs https://github.com/wesnoth/wesnoth/commit/28aca3e70012dccd2b0ee5dd4ad7f5664905016e
20161109 09:55:28-!- atarocch [~atarocch@93.68.243.58] has quit [Ping timeout: 265 seconds]
20161109 09:55:52-!- atarocch [~atarocch@93.68.243.58] has joined #wesnoth-dev
20161109 10:06:40< irker340> wesnoth: ln-zookeeper wesnoth:master 35abbb22c52d / data/campaigns/Under_the_Burning_Suns/scenarios/05_A_Subterranean_Struggle.cfg: UtBS: Prevented dextrous Quenoth Fighters https://github.com/wesnoth/wesnoth/commit/35abbb22c52dc13f861de7cf84cbb3b73f4246e2
20161109 10:16:57-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161109 10:17:26-!- astrelyon [~astrelyon@dh207-118-57.xnet.hr] has quit [Quit: WeeChat 1.4]
20161109 10:30:28-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Ping timeout: 245 seconds]
20161109 10:30:51-!- iwaim [~iwaim@rasteenie.alib.jp] has joined #wesnoth-dev
20161109 10:46:43< irker340> wesnoth: ln-zookeeper wesnoth:master 06e97799f607 / data/campaigns/Under_the_Burning_Suns/units/quenoth/Sun_Shyde.cfg: UtBS: Added missing illumination halo to Sun Shyde https://github.com/wesnoth/wesnoth/commit/06e97799f607f872d647ed34f692ffecbd251058
20161109 10:46:49< zookeeper> irker mysteriously skipped one commit in between.
20161109 10:50:48< irker340> wesnoth: ln-zookeeper wesnoth:master b850b3039e38 / data/campaigns/Under_the_Burning_Suns/scenarios/ (06a_In_the_Tunnels_of_Trolls.cfg 06b_In_the_Domain_of_Dwarves.cfg): UtBS: Fixed shydes taking damage from lava https://github.com/wesnoth/wesnoth/commit/b850b3039e3898823453b346a1ce6bd244d9f2e1
20161109 10:53:14-!- drf [d25666fe@gateway/web/freenode/ip.210.86.102.254] has joined #wesnoth-dev
20161109 10:53:29< drf> any1 important here?
20161109 10:53:37< drf> i have idea
20161109 10:53:41-!- horrowind [~Icedove@ip5f5ad776.dynamic.kabel-deutschland.de] has joined #wesnoth-dev
20161109 10:54:36< JyrkiVesterinen> drf: Ideas are better to post to the forums at https://forums.wesnoth.org/viewforum.php?f=12
20161109 10:54:47< drf> after game is over i cant pause and chat isnt in chat log so if i have game paused then i unpause and game ends and lots of chat occurs i cant see it except for the last 5 messages
20161109 10:55:25< drf> i guess i can do that too, idk its kind of small thing
20161109 10:56:04< JyrkiVesterinen> Ideas posted here in IRC are easy to forget, and no one wants to wade through the logs to find old suggestions.
20161109 10:56:07< Soliton> so chat in linger mode doesn't go to the chatlog?
20161109 10:56:22< Soliton> that rather sounds like a bug to me.
20161109 10:57:16< drf> yeah
20161109 10:57:35< zookeeper> what version does that happen with?
20161109 10:57:43< drf> 12.5
20161109 10:57:49< zookeeper> 1.12.5?
20161109 10:57:54< drf> y
20161109 10:59:13< zookeeper> what do you mean by pausing? just pressing esc?
20161109 10:59:47< zookeeper> or are you talking about viewing replays?
20161109 10:59:50< DeFender1031> what does "pausing" mean in a game that doesn't change withut input?
20161109 11:00:15< DeFender1031> s/change/progress
20161109 11:00:34< zookeeper> DeFender1031, only true on your own turn
20161109 11:00:52< DeFender1031> i didn't say "your input" i said "input"
20161109 11:01:07< drf> pausing game as observer is what i mean
20161109 11:01:32-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20161109 11:01:33< travis-ci> wesnoth/wesnoth#11956 (master - 35abbb2 : ln-zookeeper): The build has errored.
20161109 11:01:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174448105
20161109 11:01:34-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20161109 11:01:48< zookeeper> DeFender1031, well in that case pausing naturally means pausing the processing of incoming input from others
20161109 11:01:53< drf> then someones leader died after i unpaused and i missed a whole convo + whispers
20161109 11:03:06< DeFender1031> drf, you mean the chat backlog only shows the last 5 messages, and therefore you can't view the ones you missed?
20161109 11:03:16< zookeeper> ah, we do seem to have a "pause network game" hotkey.
20161109 11:13:21< drf> i mean the in game message display shows however many messages u have it set to show ( for me its 5) but when u click view chat log it shows no messages that occurred after game ended
20161109 11:13:53< drf> how does a dev not know about pause game? i use it all the time, observing games without it would be terrible
20161109 11:17:09< zookeeper> because not all devs know much about all areas of the game
20161109 11:18:14< zookeeper> i play multiplayer maybe a few times a year, and only observe games to look into bugs or for people in need of banning, and the old-school way of pausing by pressing esc works on the very rare occasion that i actually need to pause
20161109 11:26:09< zookeeper> in any case, that's certainly a bug
20161109 11:29:26< DeFender1031> besides, i'm not quite a dev yet.
20161109 12:18:35-!- astrelyon [~astrelyon@dh207-118-57.xnet.hr] has joined #wesnoth-dev
20161109 12:21:16-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161109 12:22:28-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20161109 12:22:29< travis-ci> wesnoth/wesnoth#11959 (master - b850b30 : ln-zookeeper): The build has errored.
20161109 12:22:29< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174458905
20161109 12:22:29-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20161109 12:39:12-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20161109 13:03:08-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 13:09:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 244 seconds]
20161109 13:09:41-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 13:13:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 13:22:38-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 13:26:46-!- astrelyon [~astrelyon@dh207-118-57.xnet.hr] has quit [Quit: WeeChat 1.4]
20161109 13:46:09-!- astrelyon [~astrelyon@dh207-118-57.xnet.hr] has joined #wesnoth-dev
20161109 13:47:57-!- iwaim [~iwaim@rasteenie.alib.jp] has quit [Remote host closed the connection]
20161109 13:48:37-!- iwaim [~iwaim@2001:2c0:40e:2002:805b:4060:a25c:921b] has joined #wesnoth-dev
20161109 13:51:00-!- irker340 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161109 14:01:40-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161109 14:06:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 14:24:57-!- celmin|sleep is now known as celticminstrel
20161109 14:28:59-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161109 14:36:11-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161109 14:40:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161109 14:41:17-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 14:44:15-!- boucman_work [~boucman@fw-alt.idf.smile.fr] has joined #wesnoth-dev
20161109 14:44:23-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161109 15:04:46-!- stikonas_ is now known as stikonas
20161109 15:08:50 * celticminstrel poke vultraz 
20161109 15:09:40< celticminstrel> ...oh, hmm. I can rename the data one after the comment, I guess.
20161109 15:14:37< drf> zookeeper: oh i see
20161109 15:15:01< drf> u look for people in need of banning? sounds fun :P
20161109 15:16:50< DeFender1031> huh?
20161109 15:17:09< celticminstrel> Referencing this presumably:
20161109 15:17:10< celticminstrel> [Nov 09@06:18:14am] zookeeper: i play multiplayer maybe a few times a year, and only observe games to look into bugs or for people in need of banning, and the old-school way of pausing by pressing esc works on the very rare occasion that i actually need to pause
20161109 15:19:12-!- drf [d25666fe@gateway/web/freenode/ip.210.86.102.254] has quit [Quit: Page closed]
20161109 15:19:59-!- ancestral [~ancestral@72.sub-174-219-7.myvzw.com] has joined #wesnoth-dev
20161109 15:20:54< DeFender1031> ah, missed that phrase.
20161109 15:22:05-!- ancestral [~ancestral@72.sub-174-219-7.myvzw.com] has quit [Client Quit]
20161109 15:23:31 * tad_carlucci shrugs. It's what you do. I read the forums. I don't do that looking for spammers. But when I'm there I do a quick check for them. Doesn't mean I'm actively looking and hoping to find; just that I spent a moment.
20161109 15:24:19< celticminstrel> Did anyone else care to look at the renaming PR BTW?
20161109 15:24:29< shadowm> Do I need to?
20161109 15:27:58< celticminstrel> No?
20161109 15:28:15< shadowm> Yes?
20161109 15:28:40< tad_carlucci> Just grep for 'cowfish' and if you don't find it, approve the changes :P
20161109 15:31:15< shadowm> Do you have a timetable for merging this? I kind of don't feel up to the task right now, maybe tonight.
20161109 15:48:48< celticminstrel> Well, I don't expect it to be merged by tonight.
20161109 15:49:08< celticminstrel> At least, it should pass Travis before being merged.
20161109 15:55:26< tad_carlucci> Arg.  class button; button* button;  That warning isn't well worded. It should read "What in the world were you thinking? Sure, it's a button .. WHICH button are you pointing at?"  even a lame name like "button* myButton" is better.
20161109 15:56:54< DeFender1031> tad_carlucci, well played, sir.
20161109 15:58:24-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20161109 15:58:25< travis-ci> wesnoth/wesnoth#11960 (master - bf0f1b4 : ln-zookeeper): The build has errored.
20161109 15:58:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174517522
20161109 15:58:25-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20161109 15:58:32< celticminstrel> I considered renaming some variables to stuff like the_button or my_button but didn't end up going that way.
20161109 15:59:35-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161109 16:00:49< DeFender1031> celticminstrel, what'd you do instead?
20161109 16:01:17< celticminstrel> Abbreviations.
20161109 16:01:28< celticminstrel> Or just ignore it where it compiles.
20161109 16:01:39 * tad_carlucci git checkout HEAD wall
20161109 16:01:46< celticminstrel> (Though I guess I'll have to fix that to fix Travis anyway.)
20161109 16:01:55< DeFender1031> blergh
20161109 16:01:59< celticminstrel> tad_carlucci: Note that this is still in a branch.
20161109 16:02:21< DeFender1031> at least it's now become clear why all the classes had a prefi before :P
20161109 16:02:28< DeFender1031> prefix*
20161109 16:03:05-!- atarocch [~atarocch@93.68.243.58] has quit [Ping timeout: 268 seconds]
20161109 16:06:15< celticminstrel> Nah.
20161109 16:06:33< tad_carlucci> To be honest, the both what was being fixed and what its changing to are both attempts to hide bad design behind a bad naming system.
20161109 16:06:58< celticminstrel> I'm sure it's more like variables were named that way because the t- prefix enabled it.
20161109 16:07:03 * celticminstrel isn't sure what tad is saying.
20161109 16:08:21-!- horrowind [~Icedove@ip5f5ad776.dynamic.kabel-deutschland.de] has quit [Quit: horrowind]
20161109 16:09:56< tad_carlucci> For one thing, name spaces are not classe but they're being used that way.
20161109 16:10:11< celticminstrel> Are they?
20161109 16:10:43< tad_carlucci> The concept in Wesnoth is "A namespace is a class which has no instance."
20161109 16:11:08< celticminstrel> I don't think that's true in general of Wesnoth, but okay.
20161109 16:11:31< celticminstrel> Actually, the only namespaces I can think of that fit that are "tips"...
20161109 16:19:59-!- boucman_work [~boucman@fw-alt.idf.smile.fr] has quit [Ping timeout: 256 seconds]
20161109 16:20:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 16:26:51< celticminstrel> Fixing the unit tests is surprisingly hard.
20161109 16:33:12< tad_carlucci> The question for me, today, is should I fix the problems or ignore them. The decision isn't based upon what's best for the code; it's do I want to put up with the bellyaching.
20161109 16:38:16< DeFender1031> if there's only one instance of a certain collection of data and the functions to work with it, using a namespace IS one valid way of implementing that. Others include pure-static classes and singletons.
20161109 16:52:33-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 16:52:38< tad_carlucci> OK. Here's the issue for me. Which is better: programmer convenience (mainly not changing things) or program size? Is it better for a 300K program to be 2M or the programmer to find all the sorta-related functions in the same file?
20161109 16:53:22< celticminstrel> Shouldn't the linker be able to strip unused code?
20161109 16:53:51< tad_carlucci> MODULES, yes.  FUNCTIONS and DATA? no.
20161109 16:54:05< celticminstrel> Uh.
20161109 16:54:17< celticminstrel> Not sure what you mean by modules.
20161109 16:54:23< celticminstrel> Data, obviously not.
20161109 16:54:45< tad_carlucci> A compilation unit.  The source file with all #includes included.
20161109 16:54:52< celticminstrel> Oh okay.
20161109 16:55:20< celticminstrel> I think it's good to group related functions in one file, though.
20161109 16:55:45< celticminstrel> On the other hand, if one of those has extra dependencies that pull in tons of other stuff, maybe it shouldn't be there.
20161109 16:55:46< tad_carlucci> I think it's better to have small, easy-to-understand source files.
20161109 16:56:08< celticminstrel> I do agree that it's good to keep source files relatively small.
20161109 16:56:09< tad_carlucci> We have a LOT of files over 1000 lines of actual code.
20161109 16:56:31< tad_carlucci> And that's after stripping comments and blank lines.
20161109 16:56:33< celticminstrel> Yeah, a lot of Wesnoth's files are pretty huge.
20161109 16:56:41< celticminstrel> Huh, how do you calculate that?
20161109 16:56:57< tad_carlucci> Utility which parses and counts, of course.
20161109 16:57:06< celticminstrel> I just use wc -l
20161109 16:58:48< tad_carlucci> There's a few. cloc is used often. It's basic and doesn't so some things but it's good enough when you're mainly all one language like we are: 610+/- sources 610+/- headers, 2 Objective C, 1 C and 3 unclassified (1 source fragment and 2 headers). Total about 1200 files, around 300K actual lines of code.
20161109 16:59:15< celticminstrel> The ObjC ones are also Mac-only.
20161109 16:59:20 * tad_carlucci nods.
20161109 17:00:17< tad_carlucci> And the unclassigied are actually code just with stange extensions like .ii (C++ source executable fragment) and two .tpp (template-only .hpp)
20161109 17:00:38< celticminstrel> .ii means preprocessed C++ code. :|
20161109 17:01:07< tad_carlucci> For our use it's "Never changes, not preprocessed, just included into a function body."
20161109 17:01:32< celticminstrel> Well, I mean it's the output of the preprocessor.
20161109 17:02:09< celticminstrel> It's the extension GCC uses when you tell it to just preprocess.
20161109 17:02:30< celticminstrel> cloc sounds like it could be useful, so I'm installing it.
20161109 17:03:27< tad_carlucci> run it default for overalls.  Run --by-file after you've done that
20161109 17:03:57< celticminstrel> Geh, I misspelled install.3
20161109 17:04:10< celticminstrel> Entered password only to get error message.
20161109 17:04:22< celticminstrel> At least I don't have to re-enter. It remembers for a little while.
20161109 17:05:09< tad_carlucci> My passwords are muscle-memory and I freak out when the fingers go blat and "Invalid password, retry:" appears.
20161109 17:05:23< celticminstrel> Ah, that's not what happened.
20161109 17:06:01< celticminstrel> I entered the password correctly, but I'd misspelled the command.
20161109 17:06:26< tad_carlucci> Well, usually when I mistype a sudo command the fingers go wrong with the password, too. So I try and again until I get the password right just to see the command was wrong.
20161109 17:06:38< celticminstrel> ...heh, okay.
20161109 17:09:47< celticminstrel> Every time I install something it gripes about "Warning: No port wxWidgets found in the index; can't rebuild". So annoying.
20161109 17:10:06< celticminstrel> Tests build is still running...
20161109 17:10:12< celticminstrel> Thought it'd be done by now...
20161109 17:18:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 17:19:25< tad_carlucci> On linking. Ignore .a and .so they're convenient features but not important. I have a main program which calls a function. That function is in a separate .o along side it in that .o is another function which references a function in a 3rd .o
20161109 17:19:39< celticminstrel> Tests built successfully, yay.
20161109 17:19:52< celticminstrel> Now checking I didn't break the main program with the test fixes.
20161109 17:20:12< tad_carlucci> Now that 3rd .o has a data segment initializers. The program main scans data and, if that is present (think installable addons) it calls a function pointed to from that data.
20161109 17:20:37< tad_carlucci> Now, nowhere OUTSIDE that 3rd .o is that data references using symbol names.
20161109 17:21:25< tad_carlucci> So if the linker broke the 2nd .o up to only grab the referenced function, that reference to the 3rd .o won't happen, so it's not included and the addon never installs.
20161109 17:21:42< tad_carlucci> So the linker does NOT break up .o 
20161109 17:25:56-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161109 17:37:14-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has joined #wesnoth-dev
20161109 17:43:20-!- JyrkiVesterinen [~JyrkiVest@87-92-56-60.bb.dnainternet.fi] has joined #wesnoth-dev
20161109 17:53:30-!- irker776 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161109 17:53:30< irker776> wesnoth: Celtic Minstrel wesnoth:gui_renaming 3da8a27ae7b1 / src/ (12 files in 6 dirs): Fix unit tests https://github.com/wesnoth/wesnoth/commit/3da8a27ae7b136e718667cd0cb48283d706e8a0e
20161109 17:54:18< celticminstrel> Next, the GCC5 build.
20161109 17:58:05< celticminstrel> Maybe I should edit the scons to automatically add -stdlib=c++ when building with clang.
20161109 17:58:48< celticminstrel> (Or add an option.)
20161109 17:59:21< shadowm> On Linux people using clang are likely to not have libc++ installed.
20161109 18:00:10-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161109 18:00:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 18:00:50< celticminstrel> I assume it at least won't give an error from the -stdlib flag like GCC does.
20161109 18:02:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161109 18:02:47< shadowm> 15:02:13 shadowm@nanacore ~ % clang++ helloworld.cpp -stdlib=libc++
20161109 18:02:47< shadowm> helloworld.cpp:1:10: fatal error: 'iostream' file not found
20161109 18:02:53< shadowm> It will.
20161109 18:03:20< celticminstrel> I meant the same error.
20161109 18:09:39< tad_carlucci> I get a failure even earlier: $ clang++ main.cpp module.cpp -stdlib=libc++
20161109 18:09:39< tad_carlucci> module.cpp:1:10: fatal error: 'iostream' file not found
20161109 18:09:39< tad_carlucci> #include <iostream>
20161109 18:09:39< tad_carlucci>          ^
20161109 18:09:39< tad_carlucci> 1 error generated.
20161109 18:10:27 * celticminstrel assumes -stdlib=stdlibc++ works though (and is the default).
20161109 18:10:54< tad_carlucci> invalid library argument
20161109 18:11:09< celticminstrel> Huh.
20161109 18:11:13< celticminstrel> Well.
20161109 18:12:02< celticminstrel> IIRC putting it in extra_flags_* only passes it to the compiler, so maybe a special test for that...
20161109 18:12:43< tad_carlucci> I was about to say, if it works on your system, wrap it in some feature tests so it's only on apple OS/x or whatever
20161109 18:13:24< celticminstrel> Yeah that's another possibility.
20161109 18:15:15< tad_carlucci> shadowm, Advise me. Should I try to reduce executable sizes by dead code removal or should I leave everything in over-large source files for programmer convenience? My case-in-point for an example is create_images links to about 2M when 300K is what I get after a quick pass at dead code removal.
20161109 18:17:23< celticminstrel> For a tool not intended to be distributed, I feel like executable size isn't really important.
20161109 18:18:23< tad_carlucci> I'm wondering if I'd see similar reductions for campaignd and wesnothd.  I'm thinking I will.  create_image was easiest and didn't build so needed help.
20161109 18:19:32< shadowm> Yeah 
20161109 18:19:35< shadowm> ,f
20161109 18:19:41-!- atarocch [~atarocch@93.56.160.29] has joined #wesnoth-dev
20161109 18:19:44< tad_carlucci> If I went crazy, I'd probably find some significant reductions to wesnoth, too. But 600 files is a lot to go through
20161109 18:20:13< shadowm> *Yeah, I don't see the point in worrying about the test executable's size as long as it isn't tripping any restrictions in the Travis VM.
20161109 18:20:46< shadowm> Also, it doesn't seem like it's even intended to be linked into the test suite in the first place?
20161109 18:21:29< tad_carlucci> All tools exhibit significant bloat:  create_images cutter exploder schema_generator schema_validator wesmage
20161109 18:22:06< shadowm> Oh, yes, nobody builds them.
20161109 18:22:13< tad_carlucci> So, should I take a run at seeing what it does to camnpaignd or wesnothd?
20161109 18:22:31< tad_carlucci> shadowm, Main reason is they're all erroring of you try.
20161109 18:22:35< shadowm> I have no idea what 'it' is in that last sentence so I don't know.
20161109 18:22:47< celticminstrel> campaignd isn't intended for distribution either...
20161109 18:23:41< shadowm> No tad_carlucci the main reason is they are useless for pretty much everyone.
20161109 18:24:54-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 18:25:07< tad_carlucci> Sounds like a tail-chase. They won't build so nobody can use them. Since they won't build nobody can use them. Since nobody uses them there's no point fixing them.
20161109 18:25:10< shadowm> Whereas the default targets are wesnothd and wesnoth because those are needed for running the game and optionally hosting LAN games, and Travis builds campaignd in addition to those to make sure nobody breaks campaignd's build process and I don't have to find this out probably months later when I happen to need to rebuild it on the live server again.
20161109 18:25:14-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 18:25:34< shadowm> (And otherwise running campaignd is not supported.)
20161109 18:26:03< tad_carlucci> So, sounds like I should take a run at wesnothd and see how bad the bloat is there.
20161109 18:26:06< shadowm> And this is why only wesnoth and wesnothd come with manpages.
20161109 18:28:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161109 18:28:29< shadowm> It's very likely that you'll find that wesnothd is linked against code that it doesn't use because it's part of the same archive(s) as the one(s) used for the game, campaignd, or unit tests. I would strongly advise that you don't go out of your way to rearrange things to reduce wesnothd's weight if this is the case, since we're not exactly lacking RAM for it on production.
20161109 18:28:53-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161109 18:28:59-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 18:29:19< shadowm> Or disk space, for that matter.
20161109 18:29:57< celticminstrel> I think it would be nice if a "libwml" could be separated out.
20161109 18:30:04< tad_carlucci> Linking against an archive does not cause bloat.  The source code organization into large source files is the cause.
20161109 18:30:08< celticminstrel> Or "libformula" containing just the stuff in formula/
20161109 18:30:44< tad_carlucci> NONE of the libraries are needed and building them is actually increasing build times for only marginal improvement in executable sizes.
20161109 18:31:03< celticminstrel> Huh?
20161109 18:31:18< shadowm> tad_carlucci: I don't really understand why you told me just that.
20161109 18:31:55< shadowm> Archives are effectively supersets of object files, so you're just nitpicking terminology.
20161109 18:31:59< tad_carlucci> You can build without creating the libraries. And get basically the same size program. You can put everything in one huge library and it won't change a thing.
20161109 18:32:33< tad_carlucci> It's the size/contents of the source files which is causing dead-code bloat.
20161109 18:32:47< shadowm> Yeah and the source files are part of the archives.
20161109 18:33:46< celticminstrel> BTW, by archives, does shadowm mean .tgz or .a?
20161109 18:33:57< shadowm> Latter, obviously.
20161109 18:34:01< tad_carlucci> He means .a
20161109 18:34:16< celticminstrel> Okay, somehow I thought he was referring to the former (though tad clearly wasn't).
20161109 18:34:22< tad_carlucci> And a .a is just shorthand for a collection of .o files.
20161109 18:34:50< celticminstrel> I still think it'd be nice to be able to separate out a libwml.
20161109 18:35:05< shadowm> Can't disagree with that.
20161109 18:35:17< tad_carlucci> creating libwml will increase build times and not effect build sizes.
20161109 18:35:21< celticminstrel> I don't really care too much on whether the scons build starts by building up some .a's.
20161109 18:35:22< shadowm> The problem is that the parser and preprocessor depend on the i18n code and the loading screen code.
20161109 18:36:05< celticminstrel> The latter could probably be factored out somehow, but the former is an issue...
20161109 18:36:55< tad_carlucci> Of course, then, one has to wonder why depending upon i18n implies depending upon SDL
20161109 18:37:15< celticminstrel> Huh? Does it?
20161109 18:37:32< shadowm> Okay, maybe not the latter anymore, but it also depends on the logging framework and the filesystem API.
20161109 18:37:39< tad_carlucci> It asks for colors and font options. Which pulls in stuff which pulls in stuff.
20161109 18:38:05< celticminstrel> Colours and font options? Is that really the parser or preprocessor?
20161109 18:38:30< tad_carlucci> Hang on.
20161109 18:38:56< tad_carlucci> #
20161109 18:38:57< celticminstrel> Or wait, you said the internationalization depends on it...
20161109 18:38:57< tad_carlucci> # Library 1
20161109 18:38:57< tad_carlucci> # Used by: campaignd create_images cutter exploder schema_generator schema_validator test wesmage wesnoth wesnothd
20161109 18:38:57< tad_carlucci> #
20161109 18:38:57< tad_carlucci> SRC_libwesnoth_1 += color_range.cpp
20161109 18:38:59< tad_carlucci> SRC_libwesnoth_1 += config.cpp
20161109 18:39:01< tad_carlucci> SRC_libwesnoth_1 += font/constants.cpp
20161109 18:39:03< tad_carlucci> SRC_libwesnoth_1 += game_config.cpp
20161109 18:39:05< tad_carlucci> SRC_libwesnoth_1 += gettext_boost.cpp
20161109 18:39:07< tad_carlucci> SRC_libwesnoth_1 += log.cpp
20161109 18:39:09< tad_carlucci> SRC_libwesnoth_1 += serialization/string_utils.cpp
20161109 18:39:11< tad_carlucci> SRC_libwesnoth_1 += serialization/unicode.cpp
20161109 18:39:13< tad_carlucci> SRC_libwesnoth_1 += tstring.cpp
20161109 18:39:15< tad_carlucci> SRC_libwesnoth_1 += version.cpp
20161109 18:39:27< celticminstrel> Oh hey, unused variable warnings in SDLmain.mm.
20161109 18:39:37< celticminstrel> Looks like the GCC build is done.
20161109 18:39:48< celticminstrel> Of course it can't link because my Boost is wrong.
20161109 18:40:22< tad_carlucci> I have mappings to libraries (I don't build them, just organize for them). For zero duplication, it takes a total of 12 libraries.
20161109 18:40:50< celticminstrel> I guess GCC also doesn't support Objective-C blocks.
20161109 18:41:16< tad_carlucci> Dunno what an Objective C "block" is.
20161109 18:41:23< celticminstrel> Basically a lmabda.
20161109 18:41:26< celticminstrel> lambda
20161109 18:41:28< tad_carlucci> But, GCC supports Objective C/C++
20161109 18:41:34< celticminstrel> Yeah, it clearly does.
20161109 18:41:49< celticminstrel> Otherwise it wouldn't be able to give unused parameter warnings for Objective-C methods.
20161109 18:42:18< celticminstrel> Blocks might be an Apple extension though.
20161109 18:42:59< celticminstrel> Well, this isn't important, so I'll ignore it for now.
20161109 18:44:59< celticminstrel> Unused paramaters in apple_notification.mm, too...
20161109 18:45:16< celticminstrel> And GCC doesn't support @autoreleasepool.
20161109 18:46:19< celticminstrel> Oh seriously, why give warnings for unknown pragmas?
20161109 18:46:53< tad_carlucci> Because you want to be a non-compliant compiler?  There should be a specific option to disable that.
20161109 18:49:56< celticminstrel> It's clearly impossible to produce a Mac build with GCC5, unless there are options to support things like blocks and autoreleasepool.
20161109 18:50:30-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161109 18:50:34< celticminstrel> Though I'm not going to bother investigating, because in order to produce a GCC5 build I'd also need a new Boost version (unless GCC5 can be convinced to link libc++ instead of libstdc++).
20161109 18:58:13< celticminstrel> The tip of master build failure is surely just random right...
20161109 18:59:00< celticminstrel> WML commits shouldn't be the cause of a failure generally.
20161109 19:11:12-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 19:29:15-!- stikonas_ [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 19:30:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 260 seconds]
20161109 19:32:45-!- stikonas_ is now known as stikonas
20161109 19:35:27-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161109 19:37:49-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161109 19:53:42-!- JyrkiVesterinen [~JyrkiVest@87-92-56-60.bb.dnainternet.fi] has quit [Quit: .]
20161109 19:56:45-!- ancestral [~ancestral@8.42.164.20] has joined #wesnoth-dev
20161109 20:11:10-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has joined #wesnoth-dev
20161109 20:11:11< travis-ci> wesnoth/wesnoth#11966 (gui_renaming - 3da8a27 : Celtic Minstrel): The build is still failing.
20161109 20:11:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174558063
20161109 20:11:11-!- travis-ci [~travis-ci@ec2-54-157-6-208.compute-1.amazonaws.com] has left #wesnoth-dev []
20161109 20:12:55< Aginor> hey, celticminstrel 
20161109 20:13:19< celticminstrel> ?
20161109 20:13:40< Aginor> can you run docker images? - You could use that to resolve all of your compiler and dependency issues (as a quick fix)
20161109 20:13:54< celticminstrel> No idea.
20161109 20:15:59< Aginor> you could install docker and then do "docker pull ubuntu" followed by "docker run ubuntu bash", there's a bunch of other stuff you could do as well to mount the wesnoth sources
20161109 20:16:25< Aginor> and dependencies wouldn't persist between installs
20161109 20:16:26-!- mjs-de [~mjs-de@x4e3170b5.dyn.telefonica.de] has joined #wesnoth-dev
20161109 20:19:44< Aginor> docker run -i -t ubuntu /bin/bash even
20161109 20:20:21< Aginor> https://docs.docker.com/v1.10/engine/quickstart/
20161109 20:20:52< Aginor> looks like you could use "docker commit ubuntu wesnoth-build" to save it after you've gotten the dependencies and stuff sorted
20161109 20:21:25-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161109 20:22:31< celticminstrel> Hmm, what's this about password_box missing a default definition... :|
20161109 20:23:45< celticminstrel> I'm pretty sure I didn't change anything specific to password_box that would cause that...
20161109 20:24:52-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 20:24:56< Aginor> "docker run -it -v ~/wesnoth:/wesnoth ubuntu /bin/bash"
20161109 20:25:04< Aginor> to mount your wesnoth sources
20161109 20:25:27< Aginor> that way you could try building it on ubuntu 16.04 with...
20161109 20:25:47< Aginor> gcc5 or gcc6
20161109 20:26:36< celticminstrel> Well, my current strategy seems to be basically working though, despite that GCC can't compile the ObjC files. (I just have to ignore those errors.)
20161109 20:27:56< Aginor> ok
20161109 20:32:18-!- ancestral [~ancestral@8.42.164.20] has quit [Quit: i go nstuf kthxbai]
20161109 20:36:14-!- ancestral [~ancestral@8.42.164.20] has joined #wesnoth-dev
20161109 20:36:28-!- mjs-de [~mjs-de@x4e3170b5.dyn.telefonica.de] has quit [Remote host closed the connection]
20161109 20:38:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 20:38:20-!- ancestral_ [~ancestral@63.92.240.233] has joined #wesnoth-dev
20161109 20:42:14-!- ancestral [~ancestral@8.42.164.20] has quit [Ping timeout: 256 seconds]
20161109 20:42:19-!- ancestral_ [~ancestral@63.92.240.233] has quit [Remote host closed the connection]
20161109 20:53:37-!- irker776 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161109 21:08:40-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 21:11:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20161109 21:15:33-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161109 21:16:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 21:18:13-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161109 21:20:09-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 21:20:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Remote host closed the connection]
20161109 21:20:54-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161109 21:21:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 21:22:49-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161109 21:45:03< shadowm> vultraz: Don't forget to tell me when you're about to announce so I can rebuild and restart the dev server.
20161109 21:48:16-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 21:48:51-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161109 21:49:17-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 21:51:09-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161109 21:51:56-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 21:53:53-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161109 21:54:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Read error: Connection reset by peer]
20161109 22:20:48< celticminstrel> Apparently -Werror=missing-override doesn't show anything missing... I wonder if it's reliable...
20161109 22:26:40-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 22:27:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161109 22:28:46-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161109 22:31:17-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161109 22:35:05-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161109 22:37:05< celticminstrel> Anyone have a clue what this guy is talking about? https://forums.wesnoth.org/viewtopic.php?p=604742#p604742
20161109 22:38:36< vultraz> nope
20161109 22:40:15< DeFender1031> sounds like he's saying that 1.13 requires an explicit [side] tag in MP scenarios while 1.12 just required the map to have defined start positions and would add sides automatically
20161109 22:40:28< DeFender1031> no idea if that;s accurate, but that seems to be what's being said.
20161109 22:44:15< Aginor> let's hope that's not true or it's an annoying regression
20161109 22:44:16-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161109 22:56:51< celticminstrel> I always assumed [side] tags were necessary.
20161109 22:57:50< DeFender1031> I would have also, but I don't touch MP, and since everything you can put in [side] can be configured when starting up a game, it actually makes sense that they're not required.
20161109 22:58:22< celticminstrel> Hmm, maybe...
20161109 23:08:30< celticminstrel> MESSAGE_SHOW_TOOLTIP sounds like it could be used for dynamically generated tooltips... assuming the doc comment is correct.
20161109 23:09:14-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161109 23:18:45-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161109 23:23:51-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161109 23:26:08< celticminstrel> Aginor: Did you have more feedback?
20161109 23:26:20< celticminstrel> shadowm: Still want to look at it?
20161109 23:27:41< shadowm> In a couple of hours perhaps.
20161109 23:27:52< shadowm> There's still daylight left.
20161109 23:49:29< vultraz> celticminstrel: so what's left to be done re the rename?
20161109 23:49:53< celticminstrel> Aginor requested I rename the control class.
20161109 23:50:06< celticminstrel> Also possibly the pump class.
20161109 23:50:53< celticminstrel> Then there's waiting for shadowm to look at it, and making sure Travis passes (which it should next time I push, hopefully) and, possibly, weeding out other cases of naming variables the same as their type.
20161109 23:51:14< celticminstrel> (I'll only do that if people insist on it. I'd really rather not.)
20161109 23:53:40-!- atarocch [~atarocch@93.56.160.29] has quit [Remote host closed the connection]
20161109 23:54:09< celticminstrel> (I kinda expected GCC to flag them all, but I'm pretty sure there were more than it complained of.)
20161109 23:54:22< Aginor> celticminstrel: I didn't have more time to look at it
20161109 23:54:48< vultraz> celticminstrel: i agree, do rename the control class
20161109 23:54:57< vultraz> 'control' makes it impossible to grep for
20161109 23:55:11< celticminstrel> I was considering renaming it "widget".
20161109 23:55:20< celticminstrel> But need to investigate a bit first.
20161109 23:56:12< vultraz> no, no no
20161109 23:56:46< vultraz> too easy to confuse with twidget
20161109 23:56:51< celticminstrel> ...
20161109 23:57:14< celticminstrel> You realize that twidget has already been renamed widget, right.
20161109 23:57:25< celticminstrel> If I rename control to widget, it'd become widget_base.
20161109 23:57:31< celticminstrel> But I'm not yet sure if that's appropriate.
20161109 23:57:41< vultraz> blah
--- Log closed Thu Nov 10 00:00:33 2016