--- Log opened Thu Nov 10 00:00:33 2016
20161110 00:01:04-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 00:05:08< celticminstrel> Oh, vultraz, was the disappearing credits still an issue?
20161110 00:05:16< vultraz> yes
20161110 00:05:21< vultraz> mordante hasn't looked at it
20161110 00:20:01< vultraz> celticminstrel: why?
20161110 00:20:45< celticminstrel> Something I read on the forum reminded me about how I'd investigated making it use a dynamic grid (to no success).
20161110 00:20:51< celticminstrel> I still want to do something like that.
20161110 00:21:39-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20161110 00:23:22< vultraz> I don't think that's the best solution
20161110 00:23:32< vultraz> we should figure out the root cause of the bug
20161110 00:24:06< vultraz> though using a dynamic grid *might* allow for finer layout manipulation 
20161110 00:25:15< celticminstrel> It should definitely use something listbox-like IMO, whether that's a listbox, a dynamic grid, a tree-view, or something new.
20161110 00:25:30-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161110 00:25:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161110 00:26:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 00:27:46< vultraz> well, at least the issue is currently a corner-case
20161110 00:27:58< vultraz> (it's also why the font sizes are so small. @ shadowm)
20161110 00:29:14< vultraz> large font sizes risk triggering the bug for a clean install
20161110 00:30:07< celticminstrel> Okay, so the following classes inherit from widget: control, generator, grid, pane, tree_view, viewport.
20161110 00:31:05< celticminstrel> Everything else pretty much inherits from control instead.
20161110 00:31:40< vultraz> celticminstrel: what confuses me is that (t)control seems to be specialized somewhat for label-ish widgets
20161110 00:32:22< celticminstrel> button, container, drawing, image, label matrix, menu_button, minimap, progress_bar repeating_button, scrollbar, spacer, text_box, toggle_button
20161110 00:32:24< vultraz> yet it also serves as a second base type of sorts for widgets in general
20161110 00:34:59< celticminstrel> "Base class for all visible items" ... what.
20161110 00:35:41-!- Appleman1234 [~Appleman1@KD106161199066.au-net.ne.jp] has joined #wesnoth-dev
20161110 00:35:45< vultraz> I guess that means anything you can actually see
20161110 00:35:50< celticminstrel> Okay, hmm, I can sort of see where it's going with that.
20161110 00:35:54< vultraz> ie, excluding (t)container
20161110 00:36:03< vultraz> except (t)container does inherit, you just said
20161110 00:36:08< celticminstrel> It's not the tree view that directly extends widget, just the tree view node.
20161110 00:37:18< celticminstrel> Oh, widgets that are not controls do not use [xxx_definition].
20161110 00:38:19< celticminstrel> Containers do get definitions.
20161110 00:38:39< celticminstrel> Maybe that's why they extend control.
20161110 00:39:12< vultraz> I see
20161110 00:39:20< vultraz> please add documentation as such
20161110 00:39:25< celticminstrel> Uhh.
20161110 00:39:47< celticminstrel> Well, I gleaned that from the comment in the source file...
20161110 00:39:55< vultraz> oh?
20161110 00:39:56< vultraz> ok, good
20161110 00:40:54< celticminstrel> The pane class sounds like it holds multiple items. I wonder if it would be appropriate for the credits. (Not quite sure if you can create one in WML though.)
20161110 00:41:33< vultraz> yes
20161110 00:41:35< vultraz> you can
20161110 00:41:37< vultraz> [pane]
20161110 00:41:55< celticminstrel> That'll work anywhere or only in certain places?
20161110 00:45:56< celticminstrel> Elvish_Hunter: When you have time, maybe look at PR 804?
20161110 00:47:13< vultraz> uhh
20161110 00:47:15< vultraz> not sure actually
20161110 00:50:04< vultraz> i may be mixing up pane and panel 
20161110 00:50:47< celticminstrel> I'd say pane should probably be renamed, but I don't know it well enough to decide what to.
20161110 00:51:03< vultraz> let's focus on this class rename thing first :P
20161110 00:51:25< vultraz> any chance you'll finish today?
20161110 00:51:37< celticminstrel> Yes.
20161110 00:51:53< celticminstrel> It will be finished today unless shadowm or Aginor have last-minute requests.
20161110 00:52:05< vultraz> alright
20161110 00:52:46< vultraz> and dammit, where is ancestral
20161110 00:52:48< celticminstrel> That's also assuming that I don't need to scour for cases of "xxx xxx;" and "xxx* xxx;" and "xxx& xxx;".
20161110 00:53:08< vultraz> If he doesn't show up today
20161110 00:53:19< celticminstrel> Just announce.
20161110 00:53:19< vultraz> I'm announcing without the mac package 
20161110 00:55:28< Aginor> vultraz: patience, there might be serious issues that stops ancestral
20161110 00:55:44< Aginor> or he might just be busy with work and or life
20161110 00:55:58< Aginor> he knows, and I'm sure that he's looking at it as much as he can
20161110 00:55:59< celticminstrel> I thought he already made the build.
20161110 00:56:15< celticminstrel> He had a problem with translations, but ended up resolving that.
20161110 00:56:30< celticminstrel> So, he's probably just busy with work/life.
20161110 00:56:40< celticminstrel> It is the middle of the week, after all.
20161110 01:01:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161110 01:03:54< celticminstrel> vultraz: So ny opinions on new name for control yet?
20161110 01:03:58< celticminstrel> ^any
20161110 01:04:07< vultraz> I was thinking something with _base appended
20161110 01:04:17< vultraz> control_base
20161110 01:04:20< vultraz> or maybe widget_control
20161110 01:17:03< celticminstrel> Argh, I almost forgot something more important.
20161110 01:17:20< vultraz> hm?
20161110 01:17:47< celticminstrel> Widget definition 'password_box' doesn't contain the definition for 'default'.
20161110 01:18:02< vultraz> really?
20161110 01:18:11< celticminstrel> Probably indicates an issue in the loading process rather than a problem with password_box, but not sure.
20161110 01:18:27< vultraz> wait, password box?
20161110 01:18:41< celticminstrel> Yes.
20161110 01:19:16< vultraz> I see no WML for that
20161110 01:19:37< celticminstrel> Hmm.
20161110 01:19:40< vultraz> ah, look
20161110 01:19:42< vultraz> REGISTER_WIDGET3(ttext_box_definition, password_box, "text_box_definition")
20161110 01:19:44< vultraz> it's using the text box wml
20161110 01:19:48< celticminstrel> I see.
20161110 01:20:17< celticminstrel> Oh.
20161110 01:20:32< celticminstrel> Somehow I changed "text_box_definition" to "ext_box_definition".
20161110 01:20:59< vultraz> derp :P
20161110 01:21:42< celticminstrel> What about control -> visible_widget? Or something along those lines?
20161110 01:22:13 * celticminstrel doesn't quite like that though.
20161110 01:22:19 * vultraz doesn't either
20161110 01:22:21< celticminstrel> styled_widget maybe?
20161110 01:22:25< vultraz> uhh...
20161110 01:22:35< vultraz> per...haps...
20161110 01:22:42< celticminstrel> To indicate that it can be styled with a [xxx_definition].
20161110 01:22:44< celticminstrel> Hmm...
20161110 01:23:24< vultraz> i still rather like widget_control
20161110 01:23:35< vultraz> it keeps the control moniker 
20161110 01:24:11< vultraz> and makes it sound more like an internal class
20161110 01:24:12< celticminstrel> Aginor's objection was more that it evokes MVC.
20161110 01:24:13< vultraz> which it is
20161110 01:24:21< vultraz> the horror!
20161110 01:24:36< celticminstrel> Well, I'm not sure I'd use the term "internal class". It's an abstract base class. (At least I assume it's abstract.)
20161110 01:24:45< celticminstrel> (Yeah it is, just checked.)
20161110 01:25:10< celticminstrel> "widget_control" just seems really weird to me.
20161110 01:26:03< vultraz> ui_element?
20161110 01:26:04< vultraz> meh
20161110 01:26:07< celticminstrel> Okay, so the ones that don't extend control have in common that they're for layout.
20161110 01:26:23< celticminstrel> I think it makes a lot of sense to rename control -> widget TBH.
20161110 01:26:46< vultraz> and widget widget_base?
20161110 01:26:52< celticminstrel> Yeah.
20161110 01:26:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161110 01:27:01< celticminstrel> I guess.
20161110 01:27:10< celticminstrel> Might be a better name than widget_base, but I can't think of one.
20161110 01:27:12< vultraz> still, just plain 'widget' has the problem of not being easily grep-able
20161110 01:27:22< vultraz> plus, you'll run into errors
20161110 01:27:23< celticminstrel> simple_widget?
20161110 01:27:30< celticminstrel> Though containers aren't all that simple.
20161110 01:27:32< celticminstrel> What errors?
20161110 01:27:49< vultraz> 'widget' is a variable name in a lot of places, IIRC
20161110 01:27:53< celticminstrel> Oh, yeah.
20161110 01:27:54< vultraz> you'll end up with widget& widget
20161110 01:28:02< celticminstrel> That's allowed though.
20161110 01:28:24< celticminstrel> I think I already ended up with a few similar cases.
20161110 01:28:54< celticminstrel> Some were fixed up because they caused Travis to fail. Either there were less than I thought or GCC isn't very thorough in noticing them.
20161110 01:29:30-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 01:31:29< vultraz> widget_ui?
20161110 01:31:45< vultraz> no..
20161110 01:33:31< celticminstrel> Maybe ui_element could work for the current widget class.
20161110 01:33:52< celticminstrel> Though do layout elements count as UI elements?
20161110 01:34:17< vultraz> not really
20161110 01:36:06< celticminstrel> layout_element isn't great for the opposite reason.
20161110 01:38:05< vultraz> maybe just go with control -> styled_widget
20161110 01:38:33< celticminstrel> I also came up with "themed_widget" or "themeable_widget" in a similar vein.
20161110 01:38:41-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has quit [Read error: Connection reset by peer]
20161110 01:39:41< vultraz> definitely not the latter
20161110 01:39:55< vultraz> i dunno about themed though
20161110 01:40:02< vultraz> since gui2 themes are a thing..
20161110 01:40:12< vultraz> even if we'll never use them
20161110 01:40:20< vultraz> so maybe styled makes more sense
20161110 01:40:23< celticminstrel> Okay.
20161110 01:43:09-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161110 01:43:14< celticminstrel> Uh vultraz, do widget definitions use control= or [control] for something?
20161110 01:43:23< vultraz> ehh??
20161110 01:43:28< vultraz> I've never heard of such a thing
20161110 01:43:54< celticminstrel> Well, there's a missing_mandatory_wml_key("control", "description") here for example.
20161110 01:44:10< vultraz> ...the hell?
20161110 01:44:26< vultraz> I have absolutely no idea what that's for
20161110 01:44:28< vultraz> check the schema
20161110 01:44:30< celticminstrel> In widget_definition.cpp
20161110 01:44:52< celticminstrel> It could be just a poor error message, substituting "control" for an unknown tag or something.
20161110 01:45:37< vultraz> yeah, "control" isn't in the schema at all
20161110 01:47:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 01:49:04< celticminstrel> vultraz: Aginor also thought tfield needs a more descriptive name, any ideas?
20161110 01:52:00-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 268 seconds]
20161110 01:55:18< vultraz> i thought you made it type_field
20161110 01:55:30< celticminstrel> Huh?
20161110 01:55:46< vultraz> i thought you renamed it type_field
20161110 01:55:51< vultraz> i recall you saying you did :/
20161110 01:56:08< celticminstrel> Maybe you're thinking of tformula -> typed_formula?
20161110 01:56:24< vultraz> perhaps
20161110 01:56:31< vultraz> well, use type_field for tfield then
20161110 01:57:14-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161110 01:57:16< celticminstrel> Can you explain the reasoning?
20161110 01:57:30< vultraz> well, it's used for various widget type fields
20161110 02:03:10-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161110 02:03:14< celticminstrel> I don't get it.
20161110 02:03:18< celticminstrel> What is a type field.
20161110 02:11:57-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 02:17:00-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 246 seconds]
20161110 02:26:32-!- heirecka [~heirecka@exherbo/developer/heirecka] has quit [Ping timeout: 260 seconds]
20161110 02:33:34-!- heirecka [~heirecka@exherbo/developer/heirecka] has joined #wesnoth-dev
20161110 02:34:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 02:43:55-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161110 02:48:05-!- astrelyon [~astrelyon@dh207-118-57.xnet.hr] has quit [Ping timeout: 248 seconds]
20161110 02:51:42< vultraz> celticminstrel: how about widget_field
20161110 02:51:54< vultraz> celticminstrel: and tfield_ can become field_base
20161110 02:52:47< celticminstrel> Already did the latter
20161110 03:00:35-!- astrelyon [~astrelyon@dh207-118-38.xnet.hr] has joined #wesnoth-dev
20161110 03:05:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 03:09:28-!- irker078 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161110 03:09:28< irker078> wesnoth: Celtic Minstrel wesnoth:gui_renaming 862bea0b7d7b / src/gui/ (7 files in 2 dirs): Fix GCC warnings causing Travis failure https://github.com/wesnoth/wesnoth/commit/862bea0b7d7b767afd539cb49868ccbbe0eee675
20161110 03:09:28< irker078> wesnoth: Celtic Minstrel wesnoth:gui_renaming 1208dfc2cf4d / src/ (49 files in 4 dirs): Address feedback https://github.com/wesnoth/wesnoth/commit/1208dfc2cf4d77ee7bd5c9d2deb180e46b735fd5
20161110 03:09:29< irker078> wesnoth: Celtic Minstrel wesnoth:gui_renaming ed206daf2355 / src/gui/ (123 files in 10 dirs): Rename control -> styled_widget https://github.com/wesnoth/wesnoth/commit/ed206daf23558b701f87736c59d706bfbd2068b3
20161110 03:09:38< celticminstrel> Last commit is unverified, so absolutely don't merge while Travis is still building.
20161110 03:10:17< celticminstrel> Probably should also wait for shadowm / Aginor to either offer feedback (in which case don't merge) or say they've decided not to.
20161110 03:12:24< Aginor> :D
20161110 03:12:44< Aginor> is that because we're grouchy and say no a lot?
20161110 03:12:57< Aginor> I may not have time until late tonight or tomorrow to look
20161110 03:18:24< celticminstrel> Nah, that's not the reason.
20161110 03:18:58< celticminstrel> I just think that something big like this can use as many eyes as possible.
20161110 03:19:20< celticminstrel> So if anyone says they want to look it over, they should be given a chance to do so.
20161110 03:19:27< Aginor> thank you
20161110 03:21:59-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161110 03:23:52-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161110 03:30:02-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161110 03:33:14-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 03:33:15< travis-ci> wesnoth/wesnoth#11968 (gui_renaming - ed206da : Celtic Minstrel): The build is still failing.
20161110 03:33:15< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174674700
20161110 03:33:15-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 03:49:38-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161110 03:59:35-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has quit [Remote host closed the connection]
20161110 03:59:41-!- janebot [~Gambot@unaffiliated/gambit/bot/gambot] has joined #wesnoth-dev
20161110 04:02:53-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161110 04:03:16-!- JyrkiVesterinen [~JyrkiVest@87-100-160-189.bb.dnainternet.fi] has joined #wesnoth-dev
20161110 04:11:56-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161110 04:25:56-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161110 04:26:18-!- wedge009 [~Thunderbi@60.241.236.92] has joined #wesnoth-dev
20161110 04:29:09-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Ping timeout: 260 seconds]
20161110 04:32:49-!- wedge009 [~Thunderbi@60.241.236.92] has quit [Quit: wedge009]
20161110 04:34:27-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161110 04:34:59-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161110 04:43:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 244 seconds]
20161110 04:45:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161110 04:48:32-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161110 04:52:34< shadowm> celticminstrel: Sorry, I had a bit of an unexpected situation, I'll get to it within the next 30 minutes probs.
20161110 04:57:42-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161110 04:57:57-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161110 04:59:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161110 05:01:32-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161110 05:07:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161110 05:30:28-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 05:30:51-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: End Transmission.]
20161110 05:34:57-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 258 seconds]
20161110 05:45:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 05:51:26-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 250 seconds]
20161110 06:04:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 06:09:32-!- irker078 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161110 06:14:24< shadowm> Hmmmmmmmmmmmm.
20161110 06:14:53< shadowm> Help, how to difference.
20161110 06:15:10< shadowm> I guess I'll have to use a local diff viewer instead.
20161110 06:34:13-!- vincent_c [~bip@vcheng.org] has quit [Quit: Coyote finally caught me]
20161110 06:34:55-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20161110 06:37:24< shadowm> Ugh cant' focus.
20161110 06:37:45< shadowm> I think it'll have to wait 10 hours.
20161110 06:45:10-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20161110 06:45:10-!- noy_ [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20161110 06:45:10-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 06:48:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 258 seconds]
20161110 06:48:33-!- noy_ is now known as noy
20161110 07:10:33-!- JyrkiVesterinen [~JyrkiVest@87-100-160-189.bb.dnainternet.fi] has quit [Quit: .]
20161110 07:18:48-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 07:20:08-!- irker198 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161110 07:20:08< irker198> wesnoth: Charles Dang wesnoth:gui_renaming b0140689e25d / src/gui/widgets/tree_view_node.cpp: Fixup typo in ed206daf2355 https://github.com/wesnoth/wesnoth/commit/b0140689e25db20a1f10c1da5b22aca51a220b94
20161110 07:20:23< vultraz> web commit, unverified 
20161110 07:23:16-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 252 seconds]
20161110 07:44:55-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 07:44:56< travis-ci> wesnoth/wesnoth#11970 (gui_renaming - b014068 : Charles Dang): The build is still failing.
20161110 07:44:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174704222
20161110 07:44:56-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 07:53:00-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161110 07:54:13< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 5fb810826a6c / src/play_controller.hpp: Fixup 1208dfc2cf4d77 https://github.com/wesnoth/wesnoth/commit/5fb810826a6cc330a91c4589e364e10f1baa0236
20161110 08:02:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Remote host closed the connection]
20161110 08:05:53-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 08:05:54< travis-ci> wesnoth/wesnoth#11972 (gui_renaming - 5fb8108 : Charles Dang): The build is still failing.
20161110 08:05:54< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174708201
20161110 08:05:54-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 08:06:05-!- atarocch [~atarocch@37.159.1.220] has joined #wesnoth-dev
20161110 08:10:48< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 5790e3f2dd31 / src/play_controller.hpp: More fixup https://github.com/wesnoth/wesnoth/commit/5790e3f2dd315e03f3c62d8dd46a09c172ac8253
20161110 08:14:27-!- Ravana_ [~Ravana@unaffiliated/ravana/x-2327071] has joined #wesnoth-dev
20161110 08:36:55-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 08:36:56< travis-ci> wesnoth/wesnoth#11974 (gui_renaming - 5790e3f : Charles Dang): The build is still failing.
20161110 08:36:56< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174710614
20161110 08:36:56-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 08:37:55-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161110 08:39:35< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 3d7e60ae14ff / src/play_controller.cpp: Even more fixup https://github.com/wesnoth/wesnoth/commit/3d7e60ae14ffd8954bb569b71bfcaedb25f10654
20161110 08:43:17< vultraz> celmin can merge all this tomorrow
20161110 08:47:56-!- vultraz changed the topic of #wesnoth-dev to: 1.13.6 tagged, announcing Friday 11/11/16, 00:00 UTC, 1.13.7 tentatively scheduled for December 18th (00:00 UTC) | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161110 09:07:05-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 09:11:12-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 09:11:13< travis-ci> wesnoth/wesnoth#11976 (gui_renaming - 3d7e60a : Charles Dang): The build is still failing.
20161110 09:11:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174715064
20161110 09:11:14-!- travis-ci [~travis-ci@ec2-54-205-75-120.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 09:11:36-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161110 09:15:27< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 61deb5538b87 / src/scripting/lua_gui2.cpp: More fixups for ed206daf2355 https://github.com/wesnoth/wesnoth/commit/61deb5538b8734b5687382006f467640728d34ca
20161110 09:18:29-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161110 09:51:32-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 09:51:33< travis-ci> wesnoth/wesnoth#11978 (gui_renaming - 61deb55 : Charles Dang): The build is still failing.
20161110 09:51:33< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174721963
20161110 09:51:33-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 10:01:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161110 10:08:43-!- htee [~htee@dtcqfkyj50s3g-9syvhxt-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161110 10:23:05-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161110 10:27:14-!- htee [~htee@dtcqfkyj50s3g-9syvhxt-3.rev.dnainternet.fi] has quit [Remote host closed the connection]
20161110 10:27:21-!- htee [~htee@dtcqfkyj50s3g-9syvhxt-3.rev.dnainternet.fi] has joined #wesnoth-dev
20161110 10:34:07-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161110 10:36:45-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Client Quit]
20161110 10:55:26-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 10:55:40< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 73f55a05491a / src/tests/gui/fire_event.cpp: Yet even more fixup for 1208dfc2cf4d again https://github.com/wesnoth/wesnoth/commit/73f55a05491a3bd2069de75a67614f144943eb2c
20161110 10:56:41-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161110 10:59:49-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20161110 11:27:45-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has quit [Ping timeout: 260 seconds]
20161110 11:28:13-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 11:28:14< travis-ci> wesnoth/wesnoth#11980 (gui_renaming - 73f55a0 : Charles Dang): The build is still failing.
20161110 11:28:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174742790
20161110 11:28:14-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 11:38:48< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 51938cbba7cb / src/tests/gui/test_gui2.cpp: Attempt to fix tests https://github.com/wesnoth/wesnoth/commit/51938cbba7cbb84ed4255a2a5b19cc2a30218537
20161110 11:57:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161110 11:57:52-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161110 12:27:55< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 3d58725a497f / src/gui/widgets/password_box.cpp: Fixed password_box definition id https://github.com/wesnoth/wesnoth/commit/3d58725a497f736b477e2d88add63788599d1827
20161110 12:36:13-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161110 12:37:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161110 12:38:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161110 12:39:28-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 12:39:29< travis-ci> wesnoth/wesnoth#11983 (gui_renaming - 51938cb : Charles Dang): The build is still failing.
20161110 12:39:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174751551
20161110 12:39:30-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 12:40:50< vultraz> if only travis didn't rebuild everything :|
20161110 12:41:31-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161110 12:42:38< DeFender1031> blerg.
20161110 12:42:54-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161110 12:43:46-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 12:48:12-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161110 13:05:07-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 13:05:08< travis-ci> wesnoth/wesnoth#11984 (gui_renaming - 3d58725 : Charles Dang): The build is still failing.
20161110 13:05:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174761285
20161110 13:05:09-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 13:13:54-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has joined #wesnoth-dev
20161110 13:14:59< vultraz> OHCOMEON
20161110 13:19:00< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 3f4b562e76e6 / data/gui/window/loadscreen.cfg: Fixed loading screen window id since @celticminstrel changed it for some reason https://github.com/wesnoth/wesnoth/commit/3f4b562e76e68d8a3698db1c64ea6a29adfeed1d
20161110 13:19:21< vultraz> please god let that be the end of it
20161110 13:20:46< DeFender1031> all that for an id change?
20161110 13:22:54< JyrkiVesterinen> Software is fragile. The smallest change can break everything. https://i.imgur.com/VEHey5A.gifv
20161110 13:24:52< DeFender1031> JyrkiVesterinen, software SHOULDN'T be that fragile...
20161110 13:56:54-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 13:56:55< travis-ci> wesnoth/wesnoth#11986 (gui_renaming - 3f4b562 : Charles Dang): The build is still failing.
20161110 13:56:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174773088
20161110 13:56:55-!- travis-ci [~travis-ci@ec2-54-198-0-151.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 13:56:59< vultraz> WWWHHHHHHYYYYYY
20161110 13:59:04< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 3b56c4b6daa7 / src/gui/dialogs/preferences_dialog.cpp: Fixed ANOTHER window id https://github.com/wesnoth/wesnoth/commit/3b56c4b6daa73815591b5106976a071ad0fd7222
20161110 14:00:56< vultraz> i hope i did that one right.
20161110 14:02:25< vultraz> i think i may not have
20161110 14:03:09< vultraz> ah
20161110 14:03:13< vultraz> dammit
20161110 14:06:07< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 77fa4fdd5ebd / src/gui/dialogs/preferences_dialog.cpp: Wait no the old version was correct https://github.com/wesnoth/wesnoth/commit/77fa4fdd5ebde40f5a99844cee3db2a3f5b85c01
20161110 14:06:21< irker198> wesnoth: Charles Dang wesnoth:gui_renaming 3d824ef387bb / data/gui/window/preferences.cfg: This should fix it https://github.com/wesnoth/wesnoth/commit/3d824ef387bb7ed8a29e70be8847e300c3093af2
20161110 14:06:36 * vultraz is giving 0 fucks with these commit messages
20161110 14:07:01< JyrkiVesterinen> Do you plan to squash the commits later?
20161110 14:07:07< vultraz> yes
20161110 14:07:25< JyrkiVesterinen> OK, then the commit messages don't matter.
20161110 14:07:37< vultraz> exactly :)
20161110 14:11:31< DeFender1031> Fucks don't matter anymore.
20161110 14:11:50< DeFender1031> Not after yesterday.
20161110 14:12:02< DeFender1031> Not after electing Mal-Ravanal as Archmage.
20161110 14:13:16< zookeeper> hey, don't disparage liches
20161110 14:13:23< zookeeper> they're smart
20161110 14:13:53-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 260 seconds]
20161110 14:14:12< zookeeper> hmm... malin wasn't, though. actually he was kind of an idiot with a temperament problem :>
20161110 14:14:23< zookeeper> carry on
20161110 14:14:41< DeFender1031> I dunno, man, I heard he was on record as saying he likes to grab corpses by the pelvis.
20161110 14:16:08< vultraz> xD
20161110 14:16:17< vultraz> lmfao
20161110 14:19:13< pydsigner> No that was skeletons
20161110 14:19:37-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161110 14:20:26< DeFender1031> Make Wesnoth bait again.
20161110 14:21:28< pydsigner> Make Wesnoth rise again
20161110 14:21:55< DeFender1031> dammit pydsigner, stop taking all my jokes and making them obviously funnier than I was able to make them!
20161110 14:22:04< DeFender1031> :P
20161110 14:22:09< zookeeper> i did find it exemplary that there had been no discussion or even offhand references on this channel so far, but oh well... :p
20161110 14:22:16< zookeeper> (at least as far as i had seen)
20161110 14:22:51< pydsigner> In the Wesnoth universe, vermin supreme is a legitimate candidate
20161110 14:23:52< DeFender1031> zookeeper, sorry to break that streak. :/
20161110 14:24:24< vultraz> It's nice to joke about, but also rather hard
20161110 14:24:56< DeFender1031> hard to come up with jokes?
20161110 14:25:17< pydsigner> We're fine as long we make jokes instead arguing about what actually happened
20161110 14:25:32< pydsigner> Let's keep that out of this channel
20161110 14:26:20< vultraz> DeFender1031: no, hard to joke about something so devastating :/
20161110 14:26:31< vultraz> I can, but it also feels rather like i shouldn't 
20161110 14:26:34< DeFender1031> pydsigner, i agree. As long as it remains parodies of what people say ELSEWHERE rather than opinions of what people here actually think, it should be alright.
20161110 14:26:35< vultraz> iykwim
20161110 14:27:42< DeFender1031> vultraz, well, that starts to get into potentially volatile territory, but i'll just say something that my mother always says, which she got from HER mother, who very much did not have an easy life, which is that if you keep your sense of humor, you can get through anything.
20161110 14:27:52-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 252 seconds]
20161110 14:28:04< vultraz> true that
20161110 14:28:12< DeFender1031> if my choice is to joke or scream, I choose to try to joke.
20161110 14:28:58< DeFender1031> (though there will usually be screaming at some point as well...)
20161110 14:29:52< vultraz> heh
20161110 14:34:12-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 14:34:13< travis-ci> wesnoth/wesnoth#11988 (gui_renaming - 3b56c4b : Charles Dang): The build is still failing.
20161110 14:34:13< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174781473
20161110 14:34:13-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 14:34:24< DeFender1031> (Oddly enough, my campaign's backstory actually DOES involve a former necromancer being made an Elder of Alduin...)
20161110 14:36:09< vultraz> a necromancer would be cooler than that hairy orange
20161110 14:41:05-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161110 14:41:41-!- Shiki [~Shiki@141.57.60.169] has joined #wesnoth-dev
20161110 14:46:12< vultraz> blah, im not staying up to wait for travis
20161110 14:46:19< vultraz> someone tell celticminstrel he can fix the rest
20161110 14:50:47-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161110 14:52:45< JyrkiVesterinen> [16:46:10] <vultraz> blah, im not staying up to wait for travis
20161110 14:52:45< JyrkiVesterinen> [16:46:18] <vultraz> someone tell celticminstrel he can fix the rest
20161110 14:52:46< celticminstrel> Oh my.
20161110 14:52:52< celticminstrel> Lots of fixup commits.
20161110 14:53:00< celticminstrel> I should probably squash them though.
20161110 14:53:47< celticminstrel> I didn't see any comments from shadowm though?
20161110 14:57:26 * celticminstrel now running scons -k
20161110 14:57:35< celticminstrel> (With his commits included)
20161110 15:04:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 248 seconds]
20161110 15:06:20-!- makruni [~username@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161110 15:06:43< makruni> so, I tried to get stacktrace for that latest shroud crash, but addr2line fails to resolve the addresses mostly :/
20161110 15:07:39< makruni> http://pastebin.com/zcu8rzQM  
20161110 15:09:08-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 250 seconds]
20161110 15:13:44< makruni> I'm wonder if I can somehow set an asan-breakpoint so that asan just gets me the stacktrace :/
20161110 15:13:58< makruni> asan-stacktrace on assert failure would be nice 
20161110 15:18:12< JyrkiVesterinen> Well, I doubt that ASan would be able to give you the stack trace if GCC can't do it.
20161110 15:18:29< DeFender1031> hairy orange?
20161110 15:18:38< celticminstrel> ...asan on GCC?
20161110 15:18:46< celticminstrel>  / GDB?
20161110 15:18:49< makruni> aaah
20161110 15:18:51< makruni> I think I got it now
20161110 15:19:01< JyrkiVesterinen> Ah, yes. I meant to say GDB.
20161110 15:19:05< makruni> no idea why it failed the first time
20161110 15:19:08< makruni> (with gdb)
20161110 15:20:56< makruni> https://gna.org/bugs/download.php?file_id=29356  
20161110 15:20:58< makruni> there we go =) 
20161110 15:23:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 15:23:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20161110 15:24:14< makruni> bbl
20161110 15:24:15-!- makruni [~username@unaffiliated/matthiaskrgr] has quit [Quit: leaving]
20161110 15:28:08-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 15:33:05-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161110 15:33:51-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 15:43:41-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161110 15:53:49-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161110 15:57:43-!- Shiki [~Shiki@141.57.60.169] has quit [Remote host closed the connection]
20161110 15:59:36< celticminstrel> Seems my build has no errors.
20161110 15:59:50-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has quit [Ping timeout: 250 seconds]
20161110 16:01:37< celticminstrel> Finally launches. Had to fix a few window IDs.
20161110 16:11:10-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has joined #wesnoth-dev
20161110 16:14:11< celticminstrel> Huh, irker didn't announce the push.
20161110 16:16:21-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161110 16:20:48-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Quit: .]
20161110 16:29:50-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 16:39:07-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161110 16:48:20< shadowm> celticminstrel: <shadowm> Ugh cant' focus.
20161110 16:48:22< shadowm> ce
20161110 16:48:26< shadowm> celticminstrel: <shadowm> I think it'll have to wait 10 hours.
20161110 16:49:20< shadowm> Okay, so I'm making it simpler for myself by only diffing the headers against master.
20161110 16:50:28< celticminstrel> Seems reasonable. Some of the renamed classes are source-file-only, but they're probably not that important.
20161110 16:52:06-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 16:52:07< travis-ci> wesnoth/wesnoth#11994 (gui_renaming - 478f289 : Celtic Minstrel): The build failed.
20161110 16:52:07< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174818534
20161110 16:52:07-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 16:53:46< shadowm> Seems like 1) some single-noun base classes like tfield became <noun>_base. 2) font::ttext is now font::pango_text. 3) twidget and twindow are now widget and window (instead of doing as in (1)). 4) tdialog is now modal_dialog. 5) any dialog type tfoo is now dialogs::foo. 6) tpopup is now modeless_dialog. 7) tcontrol is now styled_widget.
20161110 16:54:37< celticminstrel> That's tfield_ -> field_base actually.
20161110 16:54:52< celticminstrel> I think all or most of the ones that got the "base" suffix already had a final underscore.
20161110 16:55:08< celticminstrel> Anyway that seems to be a pretty good summary.
20161110 16:56:27< shadowm> Oh, so anything that had the trailing underscore to signify an implementation detail/abstract base class became noun_base?
20161110 16:56:53< celticminstrel> Mostly. tselectable_ and tclickable_ instead got "item" suffixed.
20161110 16:56:57< shadowm> Anything that was a class/struct, that is.
20161110 16:57:11< shadowm> Right.
20161110 16:57:37< shadowm> Well, it seems good to me as long as others to whom it may concern can readily see this information somewhere. :p
20161110 16:58:05< shadowm> e.g. vultraz and the other 2ish (?) people using GUI2.
20161110 16:58:49-!- atarocch [~atarocch@37.159.1.220] has quit [Ping timeout: 260 seconds]
20161110 16:59:08< shadowm> It's only important for devs who were used to the tprevious tnaming tscheme, so it doesn't need to go into much detail or be.
20161110 16:59:16< shadowm> into much detail.
20161110 17:00:15-!- boucman_work [~boucman@gre92-5-82-237-199-7.fbx.proxad.net] has quit [Read error: Connection reset by peer]
20161110 17:00:41< celticminstrel> Travis failed unit tests, so I guess I have to build them again...
20161110 17:01:32< celticminstrel> So it sounds like you're suggesting something like editing the style guide to mention something about the rename?
20161110 17:02:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161110 17:02:40< shadowm> We have a style guide?
20161110 17:02:53< celticminstrel> On the wiki.
20161110 17:03:00< shadowm> Oh, you mean this? https://wiki.wesnoth.org/CodingStandards No.
20161110 17:03:01< DeFender1031> Who or what is Travis?
20161110 17:03:17< shadowm> DeFender1031: Continuous integration + testing service.
20161110 17:03:19-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 17:03:23-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Remote host closed the connection]
20161110 17:03:25< shadowm> https://travis-ci.org/wesnoth/wesnoth/
20161110 17:03:29-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 17:03:31< celticminstrel> Well it does sound like you're suggesting I post something somewhere...
20161110 17:04:00< shadowm> (CI means something more general but these days people seem to equate it to building and running tests.)
20161110 17:04:14< shadowm> celticminstrel: Yes, but it doesn't have to be permanent.
20161110 17:04:23< celticminstrel> So maybe in the developer's forum?
20161110 17:04:53< celticminstrel> Just a summary of how the rename went or something?
20161110 17:04:58< shadowm> Just the PR description would do IMO.
20161110 17:05:18< shadowm> Then if someone needs to know what the rename entailed we can just link them to the closed PR.
20161110 17:05:30< celticminstrel> So edit the PR description to give more detail about how the rename went.
20161110 17:05:34< celticminstrel> Okay, I can do that.
20161110 17:05:37< shadowm> Exactly.
20161110 17:06:09< shadowm> OTOH if it's too much trouble and you are willing to answer the same questions over and over, we can just point them to you.
20161110 17:06:21< shadowm> :p
20161110 17:06:44< shadowm> If writing the list/rename rules is too much trouble, that is.
20161110 17:06:59-!- irker198 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161110 17:09:19-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 17:12:36-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
20161110 17:15:27< celticminstrel> Huh, the filesystem tests failed.
20161110 17:15:36< celticminstrel> And a config test.
20161110 17:16:54< celticminstrel> Oh my.
20161110 17:17:06< celticminstrel> I should grep to make sure there are no other instances of this error.
20161110 17:23:14< celticminstrel> Ah, the filesystem test failed because /etc is a symlink to /private/etc. That makes sense then.
20161110 17:24:35< celticminstrel> So... meh.
20161110 17:28:45< tad_carlucci> GOTCHA
20161110 17:29:43< tad_carlucci> Now we're twice bitten thrice shy on that test.
20161110 17:29:53< shadowm> Just ignore the failing test.
20161110 17:30:33< tad_carlucci> Tried that. Got overridden on the claim /etc was better than /bin because on some systems /bin is a symlink.
20161110 17:30:40< shadowm> I'm not talking to you.
20161110 17:30:57< shadowm> celticminstrel: Just ignore the failing test.
20161110 17:30:59< celticminstrel> I don't really care about the failing test TBH.
20161110 17:31:25< celticminstrel> I suppose you could fix it by iterating through / and selecting the first entry that's not a symlink.
20161110 17:31:30< celticminstrel> But is it worth it? I doubt it.
20161110 17:31:54< DeFender1031> why should wesnoth even include a test on the root filestructure? just use it whatever it happens to be
20161110 17:32:06< shadowm> I happen to have a function is_root().
20161110 17:32:13< tad_carlucci> Not just not a symlink. Needs to be a regular directory and it needs to be readable by non-root.
20161110 17:32:23< celticminstrel> I think it's a test to ensure that shadowm 's filesystem functions work correctly.
20161110 17:32:29< celticminstrel> tad_carlucci: Yeah exactly.
20161110 17:32:44< shadowm> I believe you can understand that I really need more cases than is_root("/") and is_root(".").
20161110 17:33:05< celticminstrel> is_root(".") sounds like something that could be true in rare cases.
20161110 17:33:21< tad_carlucci> So ask for the root password, sudo mkdir /shadown and test for that.
20161110 17:33:41< shadowm> I believe there are several unrelated tests that could break in rare cases as well.
20161110 17:33:46< shadowm> For starters, everything would break if data/ is absent.
20161110 17:34:21< shadowm> I maintain that we do not need to support fringe cases in the test suite since it's intended to be run under a specific environment and configuration.
20161110 17:35:10< tad_carlucci> So have the test program check for a Travis-specific thing and refuse to run for a programmer wanting to test locally.
20161110 17:35:25< celticminstrel> No way.
20161110 17:35:40< celticminstrel> It's better to have a few local-only failures than to refuse to run at all.
20161110 17:36:01< celticminstrel> (Admittedly what you describe would be as easy as doing eg "TRAVIS=yes ./test" instead of just "./test", but still.)
20161110 17:36:09< celticminstrel> (I mean if you wanted to run them anyway.)
20161110 17:36:49< shadowm> Not testing these is_root() cases would only shift the loss from other people onto the author or maintainer of the function/API.
20161110 17:37:15< shadowm> Especially if they are skipped without warning.
20161110 17:37:43< tad_carlucci> What I don't understand is why you care about the root of the filesystem as a specific target
20161110 17:38:05< shadowm> is_root().
20161110 17:38:13< shadowm> I shouldn't need to explain what it does.
20161110 17:38:15< DeFender1031> tad_carlucci, I asked that above.
20161110 17:38:17< celticminstrel> Because if you're at the root, you can't go up any further.
20161110 17:38:37< celticminstrel> (Though in practice, "cd .." at the root is a no-op, but it's still bizarre from a user perspective.)
20161110 17:38:38< tad_carlucci> I can SEE what it does. I don't understand why it EXISTS.
20161110 17:38:47< DeFender1031> celticminstrel, shadowm, yes, but again, why should wesnoth care whether something is a symlink to a dir or an actual dir?
20161110 17:38:54< shadowm> File dialog.
20161110 17:39:02< celticminstrel> IIRC he uses it to determine whether to include the ".." directory entry in the file dialog.3
20161110 17:39:14< shadowm> An alternative I'd be more willing to consider is using the WARN level instead of CHECK.
20161110 17:39:39< tad_carlucci> So get the cannonical name of the target (..) and the canonnical name of the current (.) and if different, you can go up.
20161110 17:39:41< shadowm> I'm not sure how this would affect e.g. Travis should the test clauses fail.
20161110 17:40:15< shadowm> I suspect it wouldn't mark the build as failed and no-one would find out in time if they started failing.
20161110 17:41:21< tad_carlucci> I seem to remember having to deal with the same issue years ago and the ONLY portable solution was to compare '..' to '.' 
20161110 17:41:39< shadowm> (Why wasn't I told this stuff when the PR was up.)
20161110 17:41:54< celticminstrel> Good question.
20161110 17:42:00< celticminstrel> Probably mostly coincidence.
20161110 17:42:03< tad_carlucci> And IIRC you have to deal with '.' and/or '..' not existing, as well.
20161110 17:42:10< celticminstrel> Wait what.
20161110 17:42:46-!- Shiki [~Shiki@141.57.60.169] has joined #wesnoth-dev
20161110 17:43:11< tad_carlucci> I think it was '..' that does not exist on all unix-like systems. But that was back before POSIX came out. It's possible no systems still exist which have '..' everywhere except at the root.
20161110 17:43:51< tad_carlucci> But it may have been something to do with chroot. it's been ages and I'm not positive WHY it came up but I remember dealing with '.' or '..' not existing when comparing them.
20161110 17:44:11-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has joined #wesnoth-dev
20161110 17:45:18< shadowm> bool is_root(const std::string& path) { error_code ec; const bfs::path& p = bfs::canonical(path, ec); return ec ? false : !p.has_parent_path(); }
20161110 17:45:47< tad_carlucci> something like that
20161110 17:45:50< shadowm> This is the current implementation (not that I needed to paste this here for it to be known), it's intended to be generic rather than hand-tailored to suit the dialog implementation.
20161110 17:45:58< shadowm> Current, not proposed.
20161110 17:46:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161110 17:47:07< shadowm> It's known to fail on Windows, too, so a different implementation is used on Windows.
20161110 17:47:17< shadowm> I said this a lot back in the day.
20161110 17:47:38< shadowm> I believe I spent at least two days intermittently ranting about the subject here.
20161110 17:48:30-!- JyrkiVesterinen [~JyrkiVest@87-92-61-83.bb.dnainternet.fi] has joined #wesnoth-dev
20161110 17:48:45-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161110 17:50:56-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161110 17:53:16-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 17:54:05< shadowm> BOOST_WARN(false) says nothing at all.
20161110 17:54:52< celticminstrel> Maybe there's an option for that?
20161110 17:55:00< celticminstrel> ./test --log_level=something perhaps?
20161110 17:55:15< shadowm> It really shouldn't be opt-in.
20161110 17:55:42< celticminstrel> I'm trying to figure out how to run just one test...
20161110 17:55:53< celticminstrel> --run_test=...something...
20161110 17:56:04< shadowm> Yes.
20161110 17:56:29< celticminstrel> So what do I pass there... the contents of BOOST_AUTO_TEST_CASE()?
20161110 17:56:50< shadowm> --run_test=<test suite name> or --run_test=<test suite name>/<test case name>.
20161110 17:57:04< shadowm> The test suite name is given in BOOST_AUTO_TEST_SUITE and the test case name in BOOST_AUTO_TEST_CASE.
20161110 17:57:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20161110 17:58:27< celticminstrel> Uhh... okay... what's the suite name for test_gui2 then...
20161110 17:58:41< celticminstrel> There's no BOOST_AUTO_TEST_SUITE in that file.
20161110 18:01:14< shadowm> It's just a set of stand-alone test cases.
20161110 18:01:31< shadowm> So, test_gui2.
20161110 18:01:52< shadowm> s/set/pair/   The other one is test_make_test_fake.
20161110 18:04:38< celticminstrel> Hmm, memory access violation...
20161110 18:06:01< shadowm> vultraz: What happened that you decided to extend the announcement wait from 72 hours to however long it is until Friday?
20161110 18:06:07-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 18:06:23 * celticminstrel launches up gdb.
20161110 18:06:32< celticminstrel> Seems like --auto_start_dbg doesn't work or something.
20161110 18:06:38< shadowm> 120 hours I guess?
20161110 18:06:42< shadowm> :\
20161110 18:07:02< celticminstrel> I thought he said he was going to announce last night...
20161110 18:07:15< shadowm> The topic says Friday 00:00 UTC.
20161110 18:07:23< celticminstrel> Oh I see, the topic.
20161110 18:07:33< celticminstrel> It's easy to miss that.
20161110 18:08:58< celticminstrel> Ah, looks like this crash is the file dialog crash. I'll push and hope it works on Travis, then.
20161110 18:09:37-!- irker541 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161110 18:09:37< irker541> wesnoth: Celtic Minstrel wesnoth:gui_renaming 5eb08d2587a3 / src/gui/widgets/ (debug.cpp list.cpp scrollbar_container.cpp window.cpp): Fix some missed grid() -> get_grid() https://github.com/wesnoth/wesnoth/commit/5eb08d2587a383a2ce42e5f4e86f6c16fef820e8
20161110 18:10:36< JyrkiVesterinen> What do you mean "extend the wait"? It's only six hours until Friday 00:00 UTC.
20161110 18:10:57< shadowm> From now, not from the time at which the tag was created.
20161110 18:11:16-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 268 seconds]
20161110 18:15:58< shadowm> /home/wesnoth/source/master/src/events.hpp:18:24: fatal error: SDL_events.h: No such file or directory
20161110 18:16:03< shadowm> For the love of.
20161110 18:16:42< celticminstrel> Eh?
20161110 18:16:53< shadowm> I *see* the file.
20161110 18:17:36< shadowm> But apparently the file that couldn't be built doesn't get -I/usr/include/SDL/SDL2.
20161110 18:17:58< shadowm>     g++ -o build/release/tools/dummy_video.o -c -std=c++11 -ggdb3 -DNUM_SHARDS=7 -O0 -DBANDWIDTH_MONITOR -pthread -W -Wall -O2 -include boost-patched/bind/arg.hpp -D_REENTRANT -DHAVE_CONFIG_H -DBOOST_TEST_DYN_LINK -Ibuild -I/home/wesnoth/source/master/build -Isrc -I/home/wesnoth/source/master/src /home/wesnoth/source/master/src/tools/dummy_video.cpp
20161110 18:18:19< shadowm> This one.
20161110 18:19:32< shadowm> I don't think we need that anymore when building wesnothd alone?
20161110 18:20:00< shadowm> I'm not really sure what it does.
20161110 18:20:17< celticminstrel> No idea.
20161110 18:20:30< celticminstrel> Seems like something that wesnothd shouldn't need, but...
20161110 18:20:58< shadowm> The command line that led up to this when trying to build wesnothd for wesnoth.org was:
20161110 18:21:01< shadowm>     CXXFLAGS= -ggdb3 -DNUM_SHARDS=7 -O0 -DBANDWIDTH_MONITOR LDFLAGS= scons -Y /home/wesnoth/source/master --option-cache=/home/wesnoth/builds-int/master/.scons-option-cache install-wesnothd prefix=/home/wesnoth/builds/wesnothd-trunk-git-1.13.6-46-gbf0f1b4 program_suffix=-trunk use_network_ana=false profile=0 fribidi=0 python=0 localedir= prefsdir= ...
20161110 18:21:06< shadowm> ... fifodir=/home/wesnoth/builds/wesnothd-trunk-git-1.13.6-46-gbf0f1b4/var/run raw_sockets=1 ...
20161110 18:21:09< shadowm> ... forum_user_handler=1 sdl2=no
20161110 18:21:18< shadowm> (I don't think sdl2=no has a meaning anymore, but I'll remove it anyway.)
20161110 18:25:12< shadowm> Still failing.
20161110 18:25:26< shadowm> Actually, why doesn't this happen when I build wesnothd on my own machine?
20161110 18:27:03-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161110 18:27:39< shadowm>     Checking for Simple DirectMedia Layer library version >= 2.0.4... no
20161110 18:28:09< shadowm> Oh. I see. It's because on my own machine this passes so the SDL options get added to the set used for building wesnothd-specific files.
20161110 18:28:23< shadowm> But on wesnoth.org it doesn't because we have SDL 2.0.2.
20161110 18:28:48< celticminstrel> I suppose as a quick-fix you could pretend to be Travis.
20161110 18:28:55< celticminstrel> <_<
20161110 18:29:11< celticminstrel> Might not be a good idea, not sure.
20161110 18:29:37< shadowm> Yeah, but maybe we don't need dummy_video in the first place?
20161110 18:29:41< celticminstrel> I mean, there was a reason for requiring 2.0.4, and I have no idea if it's relevant to wesnothd.
20161110 18:29:49< celticminstrel> Yeah, I suppose that's a possibility.
20161110 18:30:34< shadowm> It just provides a very bare-bones implementation of CVideo that was probably needed by... *something* in wesnothd.
20161110 18:30:55< shadowm> And hopefully  now that we don't use SDL_net we don't need it? I don't know.
20161110 18:32:01< shadowm> Even though SDL_net technically did not require SDL other than its type definitions.
20161110 18:32:02< tad_carlucci> dummy_video?
20161110 18:32:13< shadowm> dummy_video. Does what I said above.
20161110 18:32:24< tad_carlucci> It seemed to be mainly used for those tools nobody uses
20161110 18:32:25< celticminstrel> I think it's needed by the unit tests.
20161110 18:32:35< shadowm> I just built a wesnothd without dummy_video.o and it linked successfully.
20161110 18:32:40< tad_carlucci> yep
20161110 18:33:02< shadowm> So... how on earth did it wind up becoming a dependency of wesnothd?
20161110 18:33:07< tad_carlucci> Probably because something pulled in the full video implementation
20161110 18:33:18< tad_carlucci> So it SHOULD be used but it's not
20161110 18:33:42< shadowm> Notably, the CMake recipe does not pull dummy_video.o into wesnothd.
20161110 18:34:18< shadowm> So it's just SCons that had this weird notion that didn't really affect anything anyway since wesnothd needed -lSDL pre-Asio.
20161110 18:34:30< tad_carlucci> I was working out what, exactly, is required to build wesnothd but gave up because nobody seems to care if it's pulling in a lot of code it will never use.
20161110 18:34:31< shadowm> Oh well.
20161110 18:36:17< celticminstrel> I thought I said wesnothd was the only one worth caring about...
20161110 18:36:42< celticminstrel> Though someone else might've disagreed?
20161110 18:36:54< irker541> wesnoth: Ignacio R. Morelle wesnoth:master 3fbb356008bf / src/SConscript: scons: wesnothd does not need dummy_video.o, breaks wesnoth.org builds https://github.com/wesnoth/wesnoth/commit/3fbb356008bf4c555ef2b5c9aa9dd9cd47ba60ec
20161110 18:38:29< shadowm> Good thing I decided to not wait until the announcement time...
20161110 18:39:17-!- Appleman1234 [~Appleman1@KD106161199066.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20161110 18:40:04< irker541> wesnoth: Lari Nieminen wesnoth:1.12 a18843907b1a / src/ (log.cpp server/ban.cpp): Clarify the display of the remaining ban duration to banned users https://github.com/wesnoth/wesnoth/commit/a18843907b1a1ad7f24446ed770f3f3c936391a2
20161110 18:40:48-!- atarocch [~atarocch@93.56.160.31] has joined #wesnoth-dev
20161110 18:42:50< tad_carlucci> So is there any real interest in getting wesnothd trimmed down to only what it needs? Even if that means some functions need to be moved from one file to another or moved into their own source files?
20161110 18:43:46-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 18:44:20-!- travis-ci [~travis-ci@ec2-54-91-238-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 18:44:21< travis-ci> wesnoth/wesnoth#11996 (master - cbb0f98 : Ignacio R. Morelle): The build has errored.
20161110 18:44:21< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174849698
20161110 18:44:21-!- travis-ci [~travis-ci@ec2-54-91-238-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 18:45:28< celticminstrel> I think it would depend on just what isn't needed. If there's a lot, it might be worth it. If it's just two or three unused functions, probably not so much.
20161110 18:47:05< JyrkiVesterinen> I find it is important for related functions to be together if possible. It isn't okay to split functions by their dependencies only.
20161110 18:47:07< celticminstrel> Wesnoth's download size is probably dominated by the data, not the code, anyway.
20161110 18:49:13-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 258 seconds]
20161110 18:49:52< JyrkiVesterinen> Nearly every game has download size dominated by assets, especially images. I know that because I have developed mobile games with a 50 MB size limit. We had to trim the games as much as possible to stay within the limit, and even cursory analysis was enough to show that size was always dominated by images.
20161110 18:49:59 * celticminstrel wonders what "graph-includes" is.
20161110 18:50:22< celticminstrel> It doesn't exist on my system or in MacPorts, at least.
20161110 18:54:34< tad_carlucci> I'm not talking about download sizes.
20161110 18:54:51< celticminstrel> I know.
20161110 18:54:52< tad_carlucci> I'm talking about the system resources consumed and the attack surface.
20161110 18:55:44< celticminstrel> Hmm.
20161110 18:56:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 19:00:06< tad_carlucci> Aynway. There's no interest in removing duplicated or dead code so I'm looking for something else to work on.
20161110 19:00:32< tad_carlucci> Or not 'no interest' .. 'too much resistance'
20161110 19:00:41< celticminstrel> Fair enough.
20161110 19:06:49< shadowm> That's a good thing, it means people actually care about things.
20161110 19:07:08< shadowm> It doesn't mean you should instantly give up.
20161110 19:09:13< celticminstrel> Well, not starting on it doesn't need to imply giving up on pushing for it.
20161110 19:10:10-!- travis-ci [~travis-ci@ec2-54-91-238-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 19:10:11< travis-ci> wesnoth/wesnoth#11997 (gui_renaming - 5eb08d2 : Celtic Minstrel): The build is still failing.
20161110 19:10:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174851550
20161110 19:10:11-!- travis-ci [~travis-ci@ec2-54-91-238-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 19:10:18 * celticminstrel sighs.
20161110 19:12:32< tad_carlucci> Well, case in point: Did you know that using boost::asio requires linking the pull WML parser, requires linking the full Lua runtime and all AI as well as most of the GUI. And why? Because you wanted to send or receive a network packet.
20161110 19:12:33-!- travis-ci [~travis-ci@ec2-54-91-238-45.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 19:12:34< travis-ci> wesnoth/wesnoth#11996 (master - cbb0f98 : Ignacio R. Morelle): The build passed.
20161110 19:12:34< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174849698
20161110 19:12:34-!- travis-ci [~travis-ci@ec2-54-91-238-45.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 19:13:19-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has quit [Read error: Connection reset by peer]
20161110 19:13:47< loonycyborg> Anyway, I'm pretty sure I've made wesnothd sdl-free
20161110 19:13:55< celticminstrel> Uhh. I think you must have missed something in that description, because boost::asio certainly doesn't depend on WML.
20161110 19:14:39< celticminstrel> Certainly Lua, AI, and GUI have no need to be in the wesnothd. (Though with a different infrastructure, it'd be true only of the latter.)
20161110 19:14:47< tad_carlucci> Yep I meant our network asio module
20161110 19:15:06< loonycyborg> Which one of them?
20161110 19:15:21< celticminstrel> There are two WML parsers IIRC.
20161110 19:15:37< loonycyborg> Network stuff in wesnothd isn't connected much to network stuff in client atm
20161110 19:16:12< tad_carlucci> network_asio::connection::transfer -> write_gz -> parser -> AI -> GUI+Lua
20161110 19:16:36< tad_carlucci> I missed parser -> WML -> AI
20161110 19:16:44< loonycyborg> It totally makes sense to depend on parser
20161110 19:16:56< celticminstrel> Uh how does WML depend on AI...
20161110 19:17:14< loonycyborg> since our protocol uses compressed WML 
20161110 19:17:34< loonycyborg> but true, I don't see how WML could depend on AI
20161110 19:17:45< loonycyborg> I'd think it's the other way around
20161110 19:17:45< tad_carlucci> It's not a dependency. That's the problem.
20161110 19:17:55-!- tomreyn [~tomreyn@megaglest/team/tomreyn] has joined #wesnoth-dev
20161110 19:18:07< celticminstrel> Based on the XCode project, what tad said isn't true... unless it's a relic of something older.
20161110 19:18:09< tad_carlucci> It's a came-along-for-the-ride-because-people-like-bloated-source-files.
20161110 19:18:26< celticminstrel> The wesnothd project includes the following files from src:
20161110 19:19:07< loonycyborg> I remember one thing that coupled parser and gui
20161110 19:19:37< loonycyborg> there was a hook in parser to handle refreshing gui in response to loading progress
20161110 19:20:06< loonycyborg> and thus any non-gui thing that used that parser had to use dummy_video
20161110 19:20:23< celticminstrel> serialization/binary_or_text.cpp, color_range.cpp, config_cache.cpp, config.cpp(!?), filesystem_{boost,common}.cpp game_config.cpp, game.cpp, gettext_boost.cpp, log.cpp, mt_rng.cpp, serialization/parser.cpp, seed_rng.cpp, utils/sha1.cpp, serialization/tokenizer.cpp, tstring.cpp, serialization/unicode.cpp, version.cpp, font/constants.cpp
20161110 19:20:34< shadowm> loonycyborg: Ah, yes, that probably went away wih the new loading screen code?
20161110 19:20:42< celticminstrel> serialization/preprocesser.cpp
20161110 19:20:43< loonycyborg> Maybe, not sure
20161110 19:20:53< loonycyborg> It probably did
20161110 19:20:59< loonycyborg> I hope
20161110 19:21:39< celticminstrel> and serialization/string_utils.cpp
20161110 19:22:08< celticminstrel> I think that's all of them.
20161110 19:22:23< celticminstrel> So WML is in there, sure, but AI and GUI definitely isn't, nor Lua.
20161110 19:23:02< tad_carlucci> OK. It uses simple_wml to avoid that.
20161110 19:23:17-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161110 19:23:28< tad_carlucci> I get 32 files required to link wesnothd.
20161110 19:24:36< celticminstrel> That sounds the same as what XCode has.
20161110 19:26:31< tad_carlucci> My point is there is no need for the asio module to pull in the parser module. You're accepting it because in this use case you know you're going to eventually want the parser. But that's the tail wagging the doh.
20161110 19:26:33< tad_carlucci> dog
20161110 19:28:25< celticminstrel> I guess what you're saying is that it should be refactored so that the network module and the parser/serializer module are separate, unrelated dependencies for the server; so, when sending, it runs it through the serializer and then passes it to the network module; and when receiving, it passes the output from the network module through the parser.
20161110 19:28:57< celticminstrel> Though that sounds like exactly what this "network module" was intended to do in the first place.
20161110 19:29:18< shadowm> wesnothd needs the parser and preprocessor for reading and writing config files.
20161110 19:29:46< shadowm> (And yes, the config files used in production use the preprocessor, extensively.)
20161110 19:32:21< tad_carlucci> OK, so does wesnothd also do translations?
20161110 19:33:08< celticminstrel> Note that config is coupled to tstring.
20161110 19:33:11< shadowm> At the moment, no. However, translatable strings are a key feature of the WML parser and config.
20161110 19:33:29< irker541> wesnoth: Nils Kneuper wesnoth:master 8cf7bb800cb1 / / (17 files in 16 dirs): updated British English translation https://github.com/wesnoth/wesnoth/commit/8cf7bb800cb132c4377d7189b62a2fdd723abba1
20161110 19:33:31< shadowm> (As in config objects.)
20161110 19:33:42< celticminstrel> I think it could be avoided by demoting attribute_value to a template argument of config.
20161110 19:34:32< celticminstrel> Then the server could use eg basic_config<std::string> while the client uses basic_config<t_string> (probably hidden behind a typedef).
20161110 19:34:33< shadowm> Making config a template class seems like a cheap ticket to bloat hell.
20161110 19:34:49< tad_carlucci> But if y'all worked with the linker instead of actively sabatoging it none of this would be an issue.
20161110 19:34:51< celticminstrel> Or something like that.
20161110 19:35:08< celticminstrel> It wouldn't be bloat hell if you forbid using the template directly.
20161110 19:35:25< shadowm> So what do you use instead?
20161110 19:35:43< celticminstrel> The single approved instantiation defined by a typedef.
20161110 19:35:58< shadowm> I meant emitted code bloat, not C++ bloat.
20161110 19:36:36< tad_carlucci> You mean 'how do we get the linker to do it for us'? Simple. Break up your source files.
20161110 19:36:43< celticminstrel> Well, if there's only a single instantiation, I don't think the emitted code woud be any different than when it's not a template?
20161110 19:36:58< shadowm> And where does that instantiation exist? Every single translation unit?
20161110 19:37:15< shadowm> Or can you force it to exist only in config.o somehow?
20161110 19:37:28< celticminstrel> I think you can, using extern templates, but not 100% sure.
20161110 19:39:22< tad_carlucci> shadowm, When you say 'emitted code' do you mean from the compiler or from the linker?
20161110 19:39:39< shadowm> Would in that case the build time increase be negligible as with non-template types?
20161110 19:40:15< celticminstrel> I think it would be.
20161110 19:40:25< shadowm> Or would the compiler still see each use of the typedef and have to calculate the class structure (not method definitions) that matches it each time?
20161110 19:40:53< celticminstrel> Yeah, I'm not sure about all the details.
20161110 19:41:10< celticminstrel> Maybe you can answer your question by looking up "extern templates" somewhere.
20161110 19:41:42< celticminstrel> IIRC the linker would collapse any duplicate instantiations, though I guess that's not what you're concerned about.
20161110 19:42:00< celticminstrel> Maybe there could be a compiler flag.
20161110 19:42:07< shadowm> Yeah, I'm not worried about the linker, I'm worried about individual object files.
20161110 19:42:10< shadowm> One of the thing that's always bothered me the most is that the introduction of GUI2 and the refactoring of the AI engine raised compile times by at least tenfold each.
20161110 19:42:13< shadowm> *things
20161110 19:42:15< celticminstrel> -DCONFIG_TSTRING=t_string or -DCONFIG_TSTRING=std::string
20161110 19:42:23-!- Appleman1234 [~Appleman1@KD106161199066.au-net.ne.jp] has joined #wesnoth-dev
20161110 19:42:45< celticminstrel> Well, GUI2 has lots of template magic in its core, so that might be part of the raised compile times.
20161110 19:42:55< shadowm> And template overuse (which is extremely evident in some parts of GUI2) seemed like the obvious culprit, yes.
20161110 19:42:59< celticminstrel> There's some template magic in the AI engine to IIRC..
20161110 19:43:04< celticminstrel> ^too
20161110 19:43:18< celticminstrel> Mainly for aspects and the registry.
20161110 19:43:25< tad_carlucci> shadowm, My build system can build release and debug for clang and gcc in the time it takes SCons to build debug.  CMake is so much slower it's ridiculous.
20161110 19:43:50< tad_carlucci> Its a matter of not wasting time on meaningless work.
20161110 19:43:54< shadowm> I was using SCons already.
20161110 19:44:06< shadowm> I've seen the evolution of these things over time.
20161110 19:44:26< tad_carlucci> Well, SCons recreates the entire library instead of replacing only the changed module. That adds a lot of run time.
20161110 19:44:45< tad_carlucci> I don't bother with the libraries at all.
20161110 19:44:58< shadowm> Individual... object files.
20161110 19:45:19< tad_carlucci> Make handles it just fine.
20161110 19:45:43< tad_carlucci> I organized for libraries .. just never saw the need to actually build them since they don't do anything.
20161110 19:45:46< shadowm> I am perfectly aware that the ar/ranlib step is extremely I/O intensive and a huge memory hog with debug builds, that's not what I was talking about.
20161110 19:45:55< shadowm> *is an
20161110 19:46:14< shadowm> *is
20161110 19:47:39< shadowm> But I've been forced to upgrade my hardware over time as building individual object files becomes more and more expensive.
20161110 19:48:21< shadowm> Although it seems like we reached the critical point in 2012 and haven't found build times to change significantly since then.
20161110 19:49:40< irker541> wesnoth: Ignacio R. Morelle wesnoth:master cbb0f98287d3 / src/tests/test_filesystem.cpp: fs: Remove tests that rely on specific knowledge of the filesystem layout https://github.com/wesnoth/wesnoth/commit/cbb0f98287d37a96b8b0a7f4954ae4a1dfa01f7f
20161110 19:50:16< irker541> wesnoth: Charles Dang wesnoth:gui_renaming 5872f52879cc / / (8 files in 5 dirs): Fix some missed rename instances and wrong widget/window IDs https://github.com/wesnoth/wesnoth/commit/5872f52879cce2f2010ee72b5e3f77f944eb92bc
20161110 19:50:19< irker541> wesnoth: Charles Dang wesnoth:gui_renaming 8710607aabd8 / src/tests/gui/test_gui2.cpp: Fix error in tests https://github.com/wesnoth/wesnoth/commit/8710607aabd85515574b12b24eb9e932a20cd471
20161110 19:50:22< irker541> wesnoth: Celtic Minstrel wesnoth:gui_renaming 478f28963d0e / data/gui/window/ (addon_list.cfg drop_down_list.cfg logging.cfg synced_choice_wait.cfg): Fix changed window IDs https://github.com/wesnoth/wesnoth/commit/478f28963d0e48954b68b695f3f085212efb6dcb
20161110 19:50:34< celticminstrel> Uhh. What?
20161110 19:50:45< celticminstrel> Why did those suddenly announce now?
20161110 19:50:55< shadowm> Because I asked GitHub to redeliver them.
20161110 19:50:59< celticminstrel> Oh.
20161110 19:55:28-!- mjs-de [~mjs-de@x5ce33232.dyn.telefonica.de] has joined #wesnoth-dev
20161110 19:56:06-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161110 20:00:40< shadowm> loonycyborg: So, mysteriously, wesnothd wasn't linked against dummy_video.o by CMake even before the new loadscreen.
20161110 20:01:11< shadowm> loonycyborg: That said, it is the new loadscreen that dropped loadscreen_empty.o, also with SCons.
20161110 20:03:12< shadowm> Looking at the full history, dummy_video.o wasn't ever linked into wesnothd by CMake, only into cutter and exploder.
20161110 20:04:20< shadowm> So SCons carried an unnecessary internal dependency all along.
20161110 20:06:03-!- JyrkiVesterinen [~JyrkiVest@87-92-61-83.bb.dnainternet.fi] has quit [Quit: .]
20161110 20:10:08-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 20:10:09< travis-ci> wesnoth/wesnoth#11999 (master - 3fbb356 : Ignacio R. Morelle): The build passed.
20161110 20:10:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174857578
20161110 20:10:09-!- travis-ci [~travis-ci@ec2-54-158-203-205.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 20:31:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161110 20:33:48-!- Shiki [~Shiki@141.57.60.169] has quit [Remote host closed the connection]
20161110 20:36:11< irker541> wesnoth: Celtic Minstrel wesnoth:gui_renaming cd9fc1aa2d3a / / (5 files in 2 dirs): Fix changed window IDs https://github.com/wesnoth/wesnoth/commit/cd9fc1aa2d3a23a0a457184cc87cf32e084ceea8
20161110 20:36:13< irker541> wesnoth: Celtic Minstrel wesnoth:gui_renaming 6692603b908e / src/gui/widgets/ (debug.cpp list.cpp scrollbar_container.cpp window.cpp): Fix some missed grid() -> get_grid() https://github.com/wesnoth/wesnoth/commit/6692603b908eb6be5a3f0879688915d0ed3845ba
20161110 20:37:45-!- gfgtdf [~chatzilla@x4e369a12.dyn.telefonica.de] has joined #wesnoth-dev
20161110 20:40:24-!- Appleman1234 [~Appleman1@KD106161199066.au-net.ne.jp] has quit [Ping timeout: 252 seconds]
20161110 20:51:23-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Remote host closed the connection]
20161110 20:52:43-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161110 20:59:50< celticminstrel> shadowm: I updated the PR description, so feel free to take a look and let me know if it looks good.
20161110 21:01:29< celticminstrel> Aginor: I assume you still want to look over it again? Also, I can't think of a better name for the GUI2 dialog field classes. If you have any suggestions, let me know?
20161110 21:15:39< celticminstrel> Looks like Travis finally passes, so we're just waiting on Aginor now.
20161110 21:15:59< celticminstrel> (Unless the last job mysteriously fails.)
20161110 21:17:05< Aginor> celticminstrel: I will not be looking for the next 8 hours while at work
20161110 21:17:22< celticminstrel> 'kay
20161110 21:17:38< Aginor> the only thing I can promise is to look tonight, which is probably more like 10h at the bes
20161110 21:17:41< Aginor> t
20161110 21:17:50< Aginor> or tomorrow over the weekend
20161110 21:19:23-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161110 21:19:44-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161110 21:19:44-!- travis-ci [~travis-ci@ec2-54-158-218-109.compute-1.amazonaws.com] has joined #wesnoth-dev
20161110 21:19:45< travis-ci> wesnoth/wesnoth#12002 (gui_renaming - 6692603 : Celtic Minstrel): The build was fixed.
20161110 21:19:45< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/174890114
20161110 21:19:45-!- travis-ci [~travis-ci@ec2-54-158-218-109.compute-1.amazonaws.com] has left #wesnoth-dev []
20161110 21:20:31< celticminstrel> \o/
20161110 21:24:02< Aginor> but having it compile is a great achievement :)
20161110 21:25:45-!- boucman [~rosen@wesnoth/developer/boucman] has joined #wesnoth-dev
20161110 21:25:45-!- boucman [~rosen@wesnoth/developer/boucman] has quit [Read error: Connection reset by peer]
20161110 21:45:27-!- Appleman1234 [~Appleman1@KD106161199066.au-net.ne.jp] has joined #wesnoth-dev
20161110 21:53:41-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161110 21:58:43-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 22:00:16< vultraz> [05:06:01]	shadowm	vultraz: What happened that you decided to extend the announcement wait from 72 hours to however long it is until Friday?
20161110 22:00:19< vultraz> no mac package
20161110 22:01:08< celticminstrel> Oh you're up.
20161110 22:01:11< vultraz> celticminstrel: finally!
20161110 22:01:17< vultraz> celticminstrel: yes, i just woke
20161110 22:01:26< celticminstrel> I squashed all your commits.
20161110 22:01:33< vultraz> good, good
20161110 22:01:39-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 244 seconds]
20161110 22:01:41< DeFender1031> vultraz, what did you mean about a hairy orange earlier?
20161110 22:02:14< DeFender1031> (i know it wasn't really an important conversation, but i'm super curious)
20161110 22:03:10< DeFender1031> oh, nevermind
20161110 22:03:14< vultraz> DeFender1031: trump
20161110 22:03:19< vultraz> :P
20161110 22:03:21< DeFender1031> I literally JUST figured out that you- yeah
20161110 22:03:28-!- Greg-Bog_ [~greg_bogg@173.240.241.83] has quit [Ping timeout: 260 seconds]
20161110 22:03:30< vultraz> he's orange
20161110 22:03:34< DeFender1031> right right
20161110 22:03:36< vultraz> and has ridiculous hair
20161110 22:03:53 * celticminstrel was reading various things about that from my Twitter feed earlier.
20161110 22:03:56< DeFender1031> yeah, i figured it out.
20161110 22:04:37< DeFender1031> celticminstrel, yeah, you missed the discussion earlier about how Mal-Ravanal was elected Archmage.
20161110 22:04:45< DeFender1031> it was some fun.
20161110 22:05:03-!- Greg-Boggs [~greg_bogg@173.240.241.83] has joined #wesnoth-dev
20161110 22:05:04< DeFender1031> but we all agreed not to let it get too out of hand for obvoius reasons.
20161110 22:06:05< vultraz> celticminstrel: so, are we holding off on merging? 
20161110 22:06:30< celticminstrel> vultraz: About 12 hours for Aginor, yes.
20161110 22:06:49< celticminstrel> Possibly more.
20161110 22:06:57< celticminstrel> Hopefully not much more though.
20161110 22:11:18-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161110 22:21:29-!- mjs-de [~mjs-de@x5ce33232.dyn.telefonica.de] has quit [Remote host closed the connection]
20161110 22:21:54< shadowm> vultraz: It's still far too long.
20161110 22:22:19< shadowm> vultraz: I was willing to extend the wait beyond 72 hours for tier 1 platforms only for stable. Development doesn't need immediate availability.
20161110 22:22:36< vultraz> shadowm: ancestral popped in about 2 days ago saying he had a build, so I was waiting for that
20161110 22:22:46< vultraz> I would not have extended this long had he not appeared, I think
20161110 22:23:01< shadowm> Still too long.
20161110 22:23:23< shadowm> But that's your choice I guess.
20161110 22:46:06-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161110 22:50:15< zookeeper> vultraz, eh maybe i'll just move the elf thread now if you're gonna announce in an hour
20161110 22:50:24< vultraz> yes
20161110 22:51:01-!- mkdroid [~null@unaffiliated/matthiaskrgr] has joined #wesnoth-dev
20161110 22:52:12< zookeeper> i wonder if gameplay feedback is the right address, as opposed to mainline campaign development... i guess the latter
20161110 22:56:10< Aginor> is GregoryLundberg on IRC?
20161110 22:56:28< zookeeper> tad_carlucci
20161110 22:56:53< shadowm> celticminstrel: I believe type names of the form foo_t are reserved for use by the C compiler and runtime.
20161110 22:57:13< shadowm> Not sure if C++ says anything about the matter.
20161110 22:57:28< Aginor> tad_carlucci: could you give any examples of projects that stick to your one-function per file rule? - I have never come across that, ever, in any OSS or closed source projects/products I've seen
20161110 22:57:53< Aginor> and some of these things have been substantially larger than wesnoth
20161110 22:58:30-!- Appleman1234 [~Appleman1@KD106161199066.au-net.ne.jp] has quit [Remote host closed the connection]
20161110 22:58:52< shadowm> celticminstrel: The PR description is very good, thanks.
20161110 22:59:43< shadowm> As far as I'm concerned it's good to go and the foo_t thing can be ignored or addressed at a later time.
20161110 23:00:15< shadowm> Not that I really have PR blocking power for anything that isn't campaignd code.
20161110 23:01:55< tad_carlucci> I'm here
20161110 23:03:58< tad_carlucci> Aginor, I really don't care to look. Mainly because I don't think you really care.,
20161110 23:04:52< celticminstrel> :|
20161110 23:05:04-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161110 23:05:17< celticminstrel> :(
20161110 23:05:50< shadowm> I'm quite disappointed to hear that.
20161110 23:06:14-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 250 seconds]
20161110 23:13:36-!- Appleman1234 [~Appleman1@KD106161196059.au-net.ne.jp] has joined #wesnoth-dev
20161110 23:19:32< celticminstrel> :/
20161110 23:20:02-!- mkdroid [~null@unaffiliated/matthiaskrgr] has quit [Quit: I'll be back!]
20161110 23:32:33< Aginor> I do actually care or I wouldn't have asked in the first place :/
20161110 23:35:32-!- atarocch [~atarocch@93.56.160.31] has quit [Ping timeout: 256 seconds]
20161110 23:36:56-!- irker541 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161110 23:44:26-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
--- Log closed Fri Nov 11 00:00:50 2016