--- Log opened Fri Nov 11 00:00:50 2016
20161111 00:05:24< shadowm> Uh.
20161111 00:05:42-!- vultraz changed the topic of #wesnoth-dev to: 1.13.7 tentatively scheduled for December 18th (00:00 UTC) | Wesnoth Developers Channel | >>> Want to help? Go here: http://r.wesnoth.org/t42911 (and thanks!) <<< | Logs: http://irclogs.wesnoth.org | Bug tracker: http://bugs.wesnoth.org
20161111 00:06:02< shadowm> vultraz what happened to reminding me to update the dev server _before_ announcing?
20161111 00:07:18< shadowm> And I also need to hurry up and update the front page.
20161111 00:07:34< vultraz> yes, please do that
20161111 00:07:41< shadowm> But why didn't you remind me of this.
20161111 00:07:48< shadowm> Before starting.
20161111 00:08:38< vultraz> I thought you just wanted a heads up that the announcement was happening.
20161111 00:08:47< vultraz> And I already gave you the time :/
20161111 00:10:20< shadowm> I don't have a clock on my head.
20161111 00:10:29< shadowm> Or in it, for that matter.
20161111 00:10:41< shadowm> Front page and server done.
20161111 00:11:15< shadowm> Time to cull some news items.
20161111 00:14:00< vultraz> time for the bug reports to flood in
20161111 00:15:10 * matthiaskrgr launches game
20161111 00:15:16< matthiaskrgr> (jk :p ) 
20161111 00:18:07< vultraz> p_p
20161111 00:25:03< Shiki> zookeeper talked about some utbs thread earlier ... I think you forgot to make it public
20161111 00:25:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161111 00:26:54< vultraz> i think he moved it already
20161111 00:44:30< Shiki> Well, I can't find it. Could you have a look?
20161111 00:46:41< vultraz> https://forums.wesnoth.org/viewtopic.php?f=38&t=44802
20161111 00:48:44< Shiki> Ah, there it is! Thanks
20161111 00:49:11< celticminstrel> So now I need to do things and stuff if I want them in 1.13.7.
20161111 00:49:47< vultraz> ...yes?
20161111 00:50:22< celticminstrel> You didn't need to reply. :P
20161111 01:00:09< celticminstrel> Shouldn't the UI changes also mention the new file dialog?
20161111 01:03:37-!- Appleman1234 [~Appleman1@KD106161196059.au-net.ne.jp] has quit [Remote host closed the connection]
20161111 01:10:38< celticminstrel> Something I'd like to do that'll never happen: Change race=merman to race=merfolk.
20161111 01:30:13-!- Greg-Boggs [~greg_bogg@173.240.241.83] has quit [Ping timeout: 248 seconds]
20161111 02:04:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161111 02:08:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 02:14:53-!- gfgtdf [~chatzilla@x4e369a12.dyn.telefonica.de] has quit [Read error: Connection reset by peer]
20161111 02:15:02-!- gfgtdf_ [~chatzilla@x4e36a59b.dyn.telefonica.de] has joined #wesnoth-dev
20161111 02:15:03-!- gfgtdf_ is now known as gfgtdf
20161111 02:15:21-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161111 02:16:16-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c085:5fbe:baa4:8e6e] has joined #wesnoth-dev
20161111 02:21:08-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:c085:5fbe:baa4:8e6e] has quit [Ping timeout: 260 seconds]
20161111 02:36:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 02:58:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 02:59:49-!- ancestral [~ancestral@8.42.164.20] has joined #wesnoth-dev
20161111 03:00:05< ancestral> Sorry for the lateness of getting the package up. I am doing it tonight.
20161111 03:00:44< vultraz> ah, good, good
20161111 03:01:16< vultraz> i've announced already, so just let me know when it's up and ill edit it in (or you can)
20161111 03:04:41-!- ancestral [~ancestral@8.42.164.20] has quit [Ping timeout: 268 seconds]
20161111 03:23:17< celticminstrel> So WML variables don't support reverse indexing, right?
20161111 03:23:25< celticminstrel> eg $array[-1] to get the last element.
20161111 03:24:38< vultraz> not that I know of
20161111 03:25:10< celticminstrel> Seems like something that'd be useful to add.
20161111 03:25:17< celticminstrel> I might've added that for WFL already...
20161111 03:28:33 * celticminstrel was asking because what I want to do now appears to require using [find_path] and accessing the final element.
20161111 03:30:01< celticminstrel> Admittedly it's easy to do $array[$array.length-1].
20161111 03:30:19< celticminstrel> (Or I guess that would need parens.)
20161111 03:35:23< celticminstrel> Oh, wait.
20161111 03:35:46< celticminstrel> It's not an array. It's a container containing an array, and I don't need to care about the array portion.
20161111 03:36:19-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 03:53:54-!- Bonobo [~Bonobo@2001:44b8:254:3200:ba:dd51:55f7:5121] has joined #wesnoth-dev
20161111 04:03:58-!- JyrkiVesterinen [~JyrkiVest@87-100-161-142.bb.dnainternet.fi] has joined #wesnoth-dev
20161111 04:05:10-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 04:19:59-!- Appleman1234 [~Appleman1@KD106161196194.au-net.ne.jp] has joined #wesnoth-dev
20161111 04:35:08-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 04:35:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 04:40:52-!- gfgtdf [~chatzilla@x4e36a59b.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]]
20161111 05:07:40-!- horrowind [~Icedove@2a02:810a:8380:10a8:21b:fcff:fee3:c3ff] has quit [Quit: horrowind]
20161111 05:17:24-!- JyrkiVesterinen [~JyrkiVest@87-100-161-142.bb.dnainternet.fi] has quit [Quit: .]
20161111 05:18:45-!- JyrkiVesterinen [~JyrkiVest@87-100-161-142.bb.dnainternet.fi] has joined #wesnoth-dev
20161111 05:21:04-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 05:24:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 05:35:33-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 05:35:56-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 05:50:23-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 05:55:50-!- Bonobo [~Bonobo@2001:44b8:254:3200:ba:dd51:55f7:5121] has quit [Ping timeout: 258 seconds]
20161111 06:12:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 06:14:14-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161111 06:15:02-!- JyrkiVesterinen [~JyrkiVest@87-100-161-142.bb.dnainternet.fi] has quit [Quit: .]
20161111 06:21:24-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 06:32:14-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 07:16:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161111 07:28:18-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 07:36:07-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 07:36:34-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 07:43:29-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161111 07:48:04< Aginor> I approve of PR 870 :)
20161111 07:48:11< Aginor> good work
20161111 07:49:00< vultraz> alright, should I merge?
20161111 07:49:28< Aginor> let shadowm comment if he so choses to, and I'd suggest celtic can merge his on PR
20161111 07:51:36-!- Bonobo [~Bonobo@2001:44b8:254:3200:ba:dd51:55f7:5121] has joined #wesnoth-dev
20161111 07:53:37< Aginor> hmm
20161111 07:53:56< Aginor> starting up my IDE at home yet again reminds me that I wanted to buy an SSD :D
20161111 07:58:59-!- Kwandulin [~Miranda@93.221.43.143] has joined #wesnoth-dev
20161111 08:00:17< shadowm> vultraz: I think it's celtic who should push the button since he's the author?
20161111 08:00:32< shadowm> And he has push access, that is.
20161111 08:00:39< vultraz> shadowm: yeah, i'll let him
20161111 08:00:45< vultraz> do you have anything else to add to it?
20161111 08:01:10< shadowm> Aginor, vultraz: <shadowm> As far as I'm concerned it's good to go and the foo_t thing can be ignored or addressed at a later time.
20161111 08:01:20< shadowm> I told him this earlier.
20161111 08:01:25< shadowm> <shadowm> Not that I really have PR blocking power for anything that isn't campaignd code.
20161111 08:01:32< vultraz> alright, then we just wait for celmin
20161111 08:02:08< Aginor> I seem to have blocking and pissing off power :/
20161111 08:02:39< shadowm> (Re foo_t: as I said earlier, IIRC type names of the form foo_t are reserved to the C compiler and runtime library and I also said I'm not sure if this has any bearing on C++ code. It's also quite minor as far as I'm concerned since C hasn't been a rapidly-evolving language since the 90s.)
20161111 08:03:11-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161111 08:04:37 * shadowm off.
20161111 08:06:01-!- atarocch [~atarocch@37.177.3.215] has joined #wesnoth-dev
20161111 08:06:24-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has joined #wesnoth-dev
20161111 08:07:25< vultraz> Aginor: i think pretty much everyone bows to your judgement 
20161111 08:07:41< Aginor> vultraz: that's not how I want it
20161111 08:07:44< Aginor> I'm not ineffible
20161111 08:07:54< Aginor> nor infallible
20161111 08:08:10< Aginor> mostly, I'm just grouchy and stressed and tired
20161111 08:09:47< vultraz> aren't we all
20161111 08:10:30< Aginor> at least life has calmed down a bit again now
20161111 08:10:33< Aginor> for now
20161111 08:10:33< vultraz> (that wasn't supposed to sound disparaging, btw :/ )
20161111 08:13:13< vultraz> that's good
20161111 08:24:01< Aginor> not entirely
20161111 08:24:28< Aginor> a number of things didn't work out in the end
20161111 08:25:50-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161111 08:50:10-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161111 09:31:57-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161111 09:53:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161111 09:53:37-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161111 10:29:07-!- JyrkiVesterinen_ [~JyrkiVest@85-76-83-53-nat.elisa-mobile.fi] has joined #wesnoth-dev
20161111 10:32:23-!- JyrkiVesterinen [~JyrkiVest@194.157.54.14] has quit [Ping timeout: 265 seconds]
20161111 10:32:24-!- JyrkiVesterinen_ is now known as JyrkiVesterinen
20161111 11:04:02-!- Appleman1234 [~Appleman1@KD106161196194.au-net.ne.jp] has quit [Ping timeout: 256 seconds]
20161111 11:15:59-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161111 11:30:08-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161111 11:45:13-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has quit [Read error: Connection reset by peer]
20161111 11:46:00-!- vultraz [~chatzilla@wesnoth/developer/vultraz] has joined #wesnoth-dev
20161111 11:46:51-!- Appleman1234 [~Appleman1@KD106161196194.au-net.ne.jp] has joined #wesnoth-dev
20161111 11:47:45-!- Kwandulin [~Miranda@93.221.43.143] has quit [Read error: Connection reset by peer]
20161111 11:58:29-!- JyrkiVesterinen [~JyrkiVest@85-76-83-53-nat.elisa-mobile.fi] has quit [Quit: .]
20161111 12:48:03-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161111 13:06:18-!- JyrkiVesterinen [~JyrkiVest@85-76-83-53-nat.elisa-mobile.fi] has joined #wesnoth-dev
20161111 13:31:19-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161111 13:31:25-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has quit [Quit: I'm not back now.]
20161111 13:40:50-!- Bonobo [~Bonobo@2001:44b8:254:3200:ba:dd51:55f7:5121] has quit [Quit: Leaving]
20161111 13:49:56< vultraz> hmmm
20161111 13:50:04< vultraz> I have something tad could do maybe
20161111 13:51:38< vultraz> see if this smart_list thing could be removed.
20161111 13:52:36< vultraz> and replaced with some appropriate stl or boost container
20161111 13:57:01< vultraz> might be hard, though, if the game's wml event stuff is designed around the concept of non-invalidated iterators.
20161111 13:59:41< vultraz> though the question is, why was std::list not used at the time
20161111 13:59:51< vultraz> (or even std::forward_list, now)
20161111 14:05:30< vultraz> 		// push_front() is probably unneeded, but I'll leave the code here, just in case.
20161111 14:05:31< vultraz> 		// (These lists must be maintained in index order, which means pushing to the back.)
20161111 14:05:34< vultraz> so, forward_list maybe
20161111 14:07:46< vultraz> wait, list
20161111 14:07:48< vultraz> durr
20161111 14:08:07< vultraz> durrr
20161111 14:08:48< vultraz> or could forward list be used as a backwards list?
20161111 14:09:06< vultraz> it does have a reverse member
20161111 14:09:10< vultraz> still, rather inefficient, probably
20161111 14:10:16< vultraz> yes, person who wrote this code, name a custom class 'iterator'
20161111 14:10:22< vultraz> this will cause 0 confusion ever in the future
20161111 14:10:34-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has joined #wesnoth-dev
20161111 14:10:42-!- noy [~Noy@S01067cb21b205894.vs.shawcable.net] has quit [Changing host]
20161111 14:10:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 14:13:50< vultraz> Consecutive dereferences are not guaranteed to
20161111 14:13:51< vultraz> 		/// return the same element (if the list mutates between them, the next
20161111 14:13:53< vultraz> 		/// element might be returned).
20161111 14:14:01< vultraz> this somehow seems to contradict the concept of an iterator 
20161111 14:14:38< vultraz> oh wait
20161111 14:14:58< vultraz> this class is a helper list class that wraps a list implemented with a custom list type :|
20161111 14:15:04< vultraz> 	/// The interface is not the standard list interface because that would be
20161111 14:15:06< vultraz> 	/// inconvenient. The functionality implemented is that required by Wesnoth.
20161111 14:15:10< vultraz> inconvenient *how*
20161111 14:15:23< JyrkiVesterinen> It doesn't really contradict the concept. Many containers invalidate iterators when the container is modified.
20161111 14:16:02< JyrkiVesterinen> For example, if adding a new element to the vector requires the vector to reallocate its storage, all existing iterators become invalid.
20161111 14:16:25< vultraz> but doesn't that mean dereferencing them isn't allowed.
20161111 14:16:31< vultraz> ie, it crashes.
20161111 14:16:50< JyrkiVesterinen> No. Dereferencing and invalid iterator is undefined behavior.
20161111 14:16:57< vultraz> I see
20161111 14:17:04< JyrkiVesterinen> In practice, doing so often returns invalid data.
20161111 14:18:43< vultraz> I just wish someone had left a comment why std::list is "inconvenient" :|
20161111 14:21:04< vultraz> JaMiT would know
20161111 14:21:13< vultraz> Sadly, he's left the project
20161111 14:21:31-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161111 14:21:58< vultraz> huh, this was added in early 2014. not that old.
20161111 14:26:48< vultraz> left him a github comment. maybe he'll reply.
20161111 14:27:24-!- louis94 [~~louis94@91.178.240.21] has joined #wesnoth-dev
20161111 14:28:38< vultraz> and if im not here, someone tell celmin to merge the gui pr 
20161111 14:46:06-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 14:56:57-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161111 15:01:44< JyrkiVesterinen> tad_carlucci:
20161111 15:01:45< JyrkiVesterinen> [15:50:03] <vultraz> I have something tad could do maybe
20161111 15:01:45< JyrkiVesterinen> [15:51:38] <vultraz> see if this smart_list thing could be removed.
20161111 15:01:45< JyrkiVesterinen> [15:52:36] <vultraz> and replaced with some appropriate stl or boost container
20161111 15:02:18< tad_carlucci> which smart list thing?
20161111 15:02:46< JyrkiVesterinen> https://github.com/wesnoth/wesnoth/blob/dc89612dc4cde077dfa55dd062925bffdc77f6c8/src/utils/smart_list.hpp
20161111 15:03:06< JyrkiVesterinen> A container that never invalidates iterators.
20161111 15:03:24< tad_carlucci> Ah.
20161111 15:03:31< tad_carlucci> OK. thanks.
20161111 15:03:49< JyrkiVesterinen> It was intended to make programming in this project as easy as possible, but now we feel that the idea of such a container was just wrong.
20161111 15:04:19< tad_carlucci> it happens. I'm looking now.
20161111 15:07:40-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161111 15:09:23-!- irker424 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161111 15:09:23< irker424> wesnoth: Celtic Minstrel wesnoth:master 39e01dda3f62 / src/ai/actions.hpp: Rename AI result enums to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/39e01dda3f62b27975739bc37a2b4006e0e8176e
20161111 15:09:23< irker424> wesnoth: Celtic Minstrel wesnoth:master b6d862713fa9 / src/ (11 files in 3 dirs): Misc class renaming to remove t- prefix https://github.com/wesnoth/wesnoth/commit/b6d862713fa9646a3c67df842519ec94e9a7e59c
20161111 15:09:23< irker424> wesnoth: Celtic Minstrel wesnoth:master a498ceafe78e / src/ (10 files in 2 dirs): Rename WML event handling classes to remove t_ prefix https://github.com/wesnoth/wesnoth/commit/a498ceafe78e8adad885f46c7e6af89df0ee442b
20161111 15:09:24< irker424> wesnoth: Celtic Minstrel wesnoth:master e0614251c496 / src/ (18 files in 4 dirs): Rename exception classes to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/e0614251c49686bdae8e9274d56e73533020f746
20161111 15:09:25< irker424> wesnoth: Celtic Minstrel wesnoth:master b74afeff73e8 / src/ (57 files in 16 dirs): Rename terrain classes to avoid t_ prefix https://github.com/wesnoth/wesnoth/commit/b74afeff73e849d00ccb6a9f9b04424320c48a1e
20161111 15:09:27< irker424> wesnoth: Celtic Minstrel wesnoth:master 5392e306b997 / src/ (8 files in 4 dirs): Misc renaming of types to drop t- prefix https://github.com/wesnoth/wesnoth/commit/5392e306b9972461b07091a82449fa714dc7f2c2
20161111 15:09:29< irker424> wesnoth: Celtic Minstrel wesnoth:master 8df0c0023c3c / src/mp_game_settings.cpp: ttt is a terrible type name; use auto instead https://github.com/wesnoth/wesnoth/commit/8df0c0023c3ce569d10a8299c20975c210c777f0
20161111 15:09:31< irker424> wesnoth: Celtic Minstrel wesnoth:master 22bbe5465bea / src/ (9 files in 4 dirs): Rename some misc classes to drop t_ prefix https://github.com/wesnoth/wesnoth/commit/22bbe5465bea7890a3aa5a697b4d0e3d77ad2fe1
20161111 15:09:33< irker424> wesnoth: Celtic Minstrel wesnoth:master e85f8ec94ef8 / src/ (9 files in 4 dirs): Rename several types to avoid t_ prefix https://github.com/wesnoth/wesnoth/commit/e85f8ec94ef8a10d93e9a710ea3fd06d04e248c5
20161111 15:09:35< irker424> wesnoth: Celtic Minstrel wesnoth:master 2bc21b9f2e15 / src/terrain/filter.cpp: Rename internal terrain filter types to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/2bc21b9f2e15debdfd3055c194a776e49da29318
20161111 15:09:37< irker424> wesnoth: Celtic Minstrel wesnoth:master 68774b42859d / src/ (7 files in 5 dirs): Rename most of the remaining non-GUI classes with t_ prefix https://github.com/wesnoth/wesnoth/commit/68774b42859d33f84f6599a1c47ecbc10fcfafdf
20161111 15:09:39< irker424> wesnoth: Celtic Minstrel wesnoth:master 90ba2affcf55 / src/ (76 files in 8 dirs): Rename tpoint -> point https://github.com/wesnoth/wesnoth/commit/90ba2affcf55d8d4c15f155df6d2264ea50eb5c4
20161111 15:09:40< irker424> wesnoth: Celtic Minstrel wesnoth:master 77cace19db0d / src/ (13 files in 6 dirs): Rename ttext class to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/77cace19db0d8a56606dbcd27349b658224949d8
20161111 15:09:43< irker424> wesnoth: Celtic Minstrel wesnoth:master 173c4aecf36b / src/ (46 files in 4 dirs): Rename many tstate -> state_t https://github.com/wesnoth/wesnoth/commit/173c4aecf36bef3d5c6bce8e31115a78a5d3c770
20161111 15:09:45< irker424> wesnoth: Celtic Minstrel wesnoth:master e555ff9f4374 / src/ (30 files in 7 dirs): Rename twesnothd_connection -> wesnothd_connection https://github.com/wesnoth/wesnoth/commit/e555ff9f437455b290e056c410e84e12d2523c25
20161111 15:09:47< irker424> wesnoth: Celtic Minstrel wesnoth:master a1967ec16a30 / src/ (17 files in 11 dirs): Rename twml_exception -> wml_exception https://github.com/wesnoth/wesnoth/commit/a1967ec16a303efe4e5c1d47a90b9d2d8d1f4f84
20161111 15:09:49< irker424> wesnoth: Celtic Minstrel wesnoth:master 08852f613110 / src/ (31 files in 10 dirs): Rename most remaining non-GUI2 types to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/08852f613110c9fcacb289d4ee0b885944ac6f71
20161111 15:09:51< irker424> wesnoth: Celtic Minstrel wesnoth:master 749f68716d83 / src/ (19 files in 4 dirs): Rename GUI2 canvas classes to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/749f68716d838716fbf5c09bedebac2c54243d13
20161111 15:09:53< irker424> wesnoth: Celtic Minstrel wesnoth:master 4ce1277758c9 / src/ (floating_label.cpp floating_label.hpp): Nuke some remnants of SDL_GPU https://github.com/wesnoth/wesnoth/commit/4ce1277758c9936088d0a1bd78ea364c6d32e872
20161111 15:09:55< irker424> wesnoth: Celtic Minstrel wesnoth:master ee4a83ca32c1 / src/gui/ (5 files in 3 dirs): Rename tip of the day class to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/ee4a83ca32c1b9dfb3da8d404de040a702db0cdb
20161111 15:09:57< irker424> wesnoth: Celtic Minstrel wesnoth:master 8c929585aa82 / src/ (71 files in 10 dirs): Rename core GUI2 types to drop t- prefix https://github.com/wesnoth/wesnoth/commit/8c929585aa823be76fec5da606aecbe7cc5bcb6c
20161111 15:09:59< irker424> wesnoth: Celtic Minstrel wesnoth:master f9609c4bb17b / src/ (83 files in 4 dirs): Rename GUI2 widget support classes to drop t- prefix https://github.com/wesnoth/wesnoth/commit/f9609c4bb17b85c97a78926ae1660cc4f5533f0f
20161111 15:10:01< irker424> wesnoth: Celtic Minstrel wesnoth:master c09125096b24 / src/ (283 files in 21 dirs): Rename GUI2 widget classes to drop t- prefix https://github.com/wesnoth/wesnoth/commit/c09125096b24f4726564331365c3eb19f76131ef
20161111 15:10:03< irker424> wesnoth: Celtic Minstrel wesnoth:master 3c0470ad93c9 / src/ (58 files in 12 dirs): Rename GUI2 auxiliary types to avoid t- prefix https://github.com/wesnoth/wesnoth/commit/3c0470ad93c93ab4c995eca16e69f25a1a6512d9
20161111 15:10:05< irker424> wesnoth: Celtic Minstrel wesnoth:master 10b6a3461587 / src/ (214 files in 23 dirs): Rename all GUI2 dialogs to drop t- prefix https://github.com/wesnoth/wesnoth/commit/10b6a3461587966ff43bb68bf1df5697afe1bc18
20161111 15:10:07< irker424> wesnoth: Celtic Minstrel wesnoth:master b6c88df9e7da / src/ (136 files in 17 dirs): Final sweep of renames to drop t- prefix https://github.com/wesnoth/wesnoth/commit/b6c88df9e7da58921cd00813b7d99e41352bb03f
20161111 15:10:09< irker424> wesnoth: Celtic Minstrel wesnoth:master 3da8a27ae7b1 / src/ (12 files in 6 dirs): Fix unit tests https://github.com/wesnoth/wesnoth/commit/3da8a27ae7b136e718667cd0cb48283d706e8a0e
20161111 15:10:11< irker424> wesnoth: Celtic Minstrel wesnoth:master 862bea0b7d7b / src/gui/ (7 files in 2 dirs): Fix GCC warnings causing Travis failure https://github.com/wesnoth/wesnoth/commit/862bea0b7d7b767afd539cb49868ccbbe0eee675
20161111 15:10:13< irker424> wesnoth: Celtic Minstrel wesnoth:master 1208dfc2cf4d / src/ (49 files in 4 dirs): Address feedback https://github.com/wesnoth/wesnoth/commit/1208dfc2cf4d77ee7bd5c9d2deb180e46b735fd5
20161111 15:10:15< irker424> wesnoth: Celtic Minstrel wesnoth:master ed206daf2355 / src/gui/ (123 files in 10 dirs): Rename control -> styled_widget https://github.com/wesnoth/wesnoth/commit/ed206daf23558b701f87736c59d706bfbd2068b3
20161111 15:10:17< irker424> wesnoth: Charles Dang wesnoth:master 5872f52879cc / / (8 files in 5 dirs): Fix some missed rename instances and wrong widget/window IDs https://github.com/wesnoth/wesnoth/commit/5872f52879cce2f2010ee72b5e3f77f944eb92bc
20161111 15:10:20< irker424> wesnoth: Charles Dang wesnoth:master 8710607aabd8 / src/tests/gui/test_gui2.cpp: Fix error in tests https://github.com/wesnoth/wesnoth/commit/8710607aabd85515574b12b24eb9e932a20cd471
20161111 15:10:23< irker424> wesnoth: Celtic Minstrel wesnoth:master cd9fc1aa2d3a / / (5 files in 2 dirs): Fix changed window IDs https://github.com/wesnoth/wesnoth/commit/cd9fc1aa2d3a23a0a457184cc87cf32e084ceea8
20161111 15:10:25< irker424> wesnoth: Celtic Minstrel wesnoth:master 6692603b908e / src/gui/widgets/ (debug.cpp list.cpp scrollbar_container.cpp window.cpp): Fix some missed grid() -> get_grid() https://github.com/wesnoth/wesnoth/commit/6692603b908eb6be5a3f0879688915d0ed3845ba
20161111 15:10:27< irker424> wesnoth: Celtic Minstrel wesnoth:master 2545f7be566e / / (526 files in 48 dirs): Merge pull request #870 from wesnoth/gui_renaming https://github.com/wesnoth/wesnoth/commit/2545f7be566e0bf565d78d9bf18db869e38fab0e
20161111 15:10:49< vultraz> it has arrived \ o /
20161111 15:13:05< vultraz> tad_carlucci: can i merge the NaCl removal pr?
20161111 15:13:13< vultraz> it has no conflicts 
20161111 15:14:13< tad_carlucci> vultraz, If I have a PR up with no conflicts and CM's renaming is done, it can merge.
20161111 15:14:28< irker424> wesnoth: Gregory A Lundberg wesnoth:master 75c7f9ec39f2 / / (19 files in 5 dirs): Delete support for Google Native Client (Nacl). https://github.com/wesnoth/wesnoth/commit/75c7f9ec39f259bf51c404cdf891c3a6f71165e6
20161111 15:14:30< irker424> wesnoth: Gregory A Lundberg wesnoth:master 046f8e24a445 / src/ (filesystem_common.cpp wesnoth.cpp): Remove #if for __native_client__ https://github.com/wesnoth/wesnoth/commit/046f8e24a44563d242c71e0bc2ccae53270e9d01
20161111 15:14:32< irker424> wesnoth: Charles Dang wesnoth:master bd2d040f2ad4 / / (21 files in 5 dirs): Merge pull request #868 from GregoryLundberg/GL_Delete_Google_NaCL https://github.com/wesnoth/wesnoth/commit/bd2d040f2ad419a298b6ba7c3144fb36ff956ad2
20161111 15:15:00< vultraz> tad_carlucci: ok, your LOW_MEM and Lot Of Little Stuff prs have conflicts 
20161111 15:15:41< tad_carlucci> I'll get to them in a moment, then.  Need to sweep away the cruft tracking down smart_list.
20161111 15:15:52< vultraz> no rush
20161111 15:15:54< celticminstrel> LOW_MEM looks like mainly minor conflicts.
20161111 15:16:17< celticminstrel> At least, it's just changelog and widget.
20161111 15:16:30< vultraz> (smart list is used in only one place btw - game_events/handers.hpp. the big question is how much of the handler_list class there is reliant on the smart_list behavior :/ )
20161111 15:16:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 15:17:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161111 15:17:55< celticminstrel> vultraz: You have code to delete, right?
20161111 15:18:11< vultraz> (especially since handler_list itself seems to be a helper class around the list which uses the smart_list - including a custom 'iterator' subclass)
20161111 15:18:24< vultraz> celticminstrel: not right away, since i haven't started work, but ys
20161111 15:22:38< tad_carlucci> Doing a quick check to be sure LOW_MEM PR is fixed. Will push update when it's done.
20161111 15:23:28< tad_carlucci> The lotsalittlestuff PR will be quick to fix, too. One thing at a time.
20161111 15:24:18< vultraz> building the gui pr here to make sure it does so
20161111 15:24:25< vultraz> s/pr/changes
20161111 15:26:43< vultraz> i see the room manager was restored :
20161111 15:26:47< vultraz> rather unhappy about this
20161111 15:27:06< vultraz> i thought you were going to keep that separate after talking to loony :/
20161111 15:27:25< vultraz> oh well
20161111 15:29:26< celticminstrel> I probably forgot.
20161111 15:29:32< celticminstrel> No, I did forget.
20161111 15:29:52< celticminstrel> I was going to talk to loonycyborg and maybe un-add it if he didn't need it.
20161111 15:32:37< celticminstrel> Oh also vultraz, you said you might do a little GUI2 file shuffling?
20161111 15:33:07< celticminstrel> And maybe rename some files whose classes I renamed.
20161111 15:38:27-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 15:39:29-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161111 15:39:36< vultraz> perhaps
20161111 15:39:37< vultraz> ill see
20161111 15:39:48-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161111 15:39:56< vultraz> wesnoth building fine :D
20161111 15:40:19< celticminstrel> I think the t_translation namespace is confusing BTW.
20161111 15:40:55< celticminstrel> Well, I think having styled_widget in control.?pp (for example) isn't great. :P
20161111 15:41:34< vultraz> anyway, tomorrow ill work on dropping the gui1 mp screens
20161111 15:41:41 * vultraz out
20161111 15:42:01< celticminstrel> Tomorrow means tonight from my perspective, right?
20161111 15:49:02-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161111 15:51:03-!- JyrkiVesterinen [~JyrkiVest@85-76-83-53-nat.elisa-mobile.fi] has quit [Quit: .]
20161111 15:54:02-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161111 16:02:17-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Ping timeout: 240 seconds]
20161111 16:02:37-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161111 16:06:43-!- atarocch [~atarocch@37.177.3.215] has quit [Ping timeout: 245 seconds]
20161111 16:21:33< celticminstrel> Suddenly undefined symbol "_wesnoth_main"...
20161111 16:23:44-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 16:25:05< tad_carlucci> That's something to do with NaCL.
20161111 16:25:15< celticminstrel> How so?
20161111 16:25:39< tad_carlucci> int main() gets renamed (no longer) if NaCL is being compiled, IIRC.
20161111 16:25:54< celticminstrel> It's supposed to be renamed when compiling OSX.
20161111 16:27:15< tad_carlucci> Maybe I missed an apple check removing NaCL. "Works for me" but let me know if you need help finding what the removal of Google NaCL broken on OSx
20161111 16:27:57< tad_carlucci> My system is still off in lalaland rebuilding all to check removing LOW_MEM
20161111 16:28:11< celticminstrel> LOW_MEM was that widely checked?
20161111 16:28:27< tad_carlucci> No, but the source code seems that deeply coupled.
20161111 16:28:35< celticminstrel> ...this iterator is really pretty awful. :|
20161111 16:29:15< tad_carlucci> It's a compile-time option so probably some widely included header changed. Don't know, don't care.
20161111 16:30:03-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161111 16:30:06< celticminstrel> What it needs is some typedefs to smooth out the insanely long names.
20161111 16:30:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161111 16:31:10< celticminstrel> Looks like the full name would be something like gui2::iterator<gui2::iterator::policy::order<gui2::iterator::policy::visit::visit_level, gui2::polict::visit::visit_level, gui2::policy::visit::visit_level>>
20161111 16:31:27< celticminstrel> Oh, missed ::top_down after order
20161111 16:31:41< celticminstrel> (Or ::bottom_up. And visit_level can be replaced by skip_level.)
20161111 16:31:51< tad_carlucci> What it needs is those typedefs to be an implementation detail no exposed through the header. And your example only went to two lines on my screen. Some I've seen go 5 or 6.
20161111 16:32:25< celticminstrel> I mean, that seems to be what I'd have to do in order to use the iterator.
20161111 16:32:37 * tad_carlucci nods.
20161111 16:32:38-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161111 16:33:15< tad_carlucci> Use a forward declaration for a class and only define it as a typedef in the cpp implementing it
20161111 16:33:21< celticminstrel> If I could instead do eg gui2::policy::top_down_recursive. it'd be so much easier.
20161111 16:33:29< celticminstrel> All of those names are classes.
20161111 16:33:58< celticminstrel> Somehow it feels like we're talking past each other.
20161111 16:34:25< tad_carlucci> probably
20161111 16:37:43< celticminstrel> Oh, I guess visit_level is also a template... :|
20161111 16:38:05< celticminstrel> visit_level<true, gui2::iterator::walker_base::self>
20161111 16:39:36-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 16:40:56-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161111 16:42:59< celticminstrel> https://github.com/wesnoth/wesnoth/commit/3f584e2435eaf9a7a4b90c2dc34e18ffc7eaa943
20161111 16:43:18< celticminstrel> Conversation happening there regarding the smart_list. (That's also the commit introducing it.)
20161111 16:43:26< celticminstrel> Maybe you were already pointed to there, I dunno.
20161111 16:44:34-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161111 16:44:52-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161111 16:45:51< tad_carlucci> I'll look at it if my system ever finishes checking the LOW_MEM PR and I can do the lotalilthings PR.
20161111 16:46:46< celticminstrel> Yeah, looks like you deleted an #ifdef defined(__native_client__) || defined(__APPLE__)
20161111 16:51:29< tad_carlucci> Easy enough to fix.
20161111 16:51:40< celticminstrel> Already have, building now.
20161111 16:52:02 * celticminstrel just noticed I mixed #ifdef and defined() above.
20161111 16:52:27-!- atarocch [~atarocch@37.177.34.153] has joined #wesnoth-dev
20161111 16:52:41< tad_carlucci> low_mem PR should be ready
20161111 16:52:56< celticminstrel> I'll push this first, then merge it.
20161111 16:53:09< celticminstrel> (It = the PR, not this. Obviously.)
20161111 16:53:40< tad_carlucci> np
20161111 17:01:52< tad_carlucci> Doing it all over again to check fix for conflicts in the big PR.
20161111 17:02:07-!- atarocch [~atarocch@37.177.34.153] has quit [Ping timeout: 268 seconds]
20161111 17:02:33-!- atarocch [~atarocch@37.177.34.153] has joined #wesnoth-dev
20161111 17:17:56< irker424> wesnoth: Celtic Minstrel wesnoth:master 517f39732556 / src/wesnoth.cpp: Fix OSX build broken by PR #868 https://github.com/wesnoth/wesnoth/commit/517f3973255660526a011b64544a52bb1039a264
20161111 17:19:42-!- atarocch [~atarocch@37.177.34.153] has quit [Ping timeout: 258 seconds]
20161111 17:20:06< irker424> wesnoth: Gregory A Lundberg wesnoth:master f23127e65a4f / / (18 files in 8 dirs): Remove LOW_MEM compile-time option https://github.com/wesnoth/wesnoth/commit/f23127e65a4fdd64e35273a9d19bb9a20919564e
20161111 17:20:08< irker424> wesnoth: Celtic Minstrel wesnoth:master 03ba76a6ae36 / / (18 files in 8 dirs): Merge pull request #869 from GregoryLundberg/GL_Remove_LOW_MEM https://github.com/wesnoth/wesnoth/commit/03ba76a6ae363b73b71c2c705141d6538cc0dbc0
20161111 17:20:32< celticminstrel> Two jobs had already passed on Travis, for the record.
20161111 17:20:49< celticminstrel> Okay, so next is 863.
20161111 17:20:54< celticminstrel> Let me know when it's ready.
20161111 17:21:16< celticminstrel> Wonder what happened to BlackSpirit96...
20161111 17:24:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 17:26:53< tad_carlucci> celticminstrel, PR 863 is going through a final compile to check.
20161111 17:31:57-!- atarocch [~atarocch@31.157.46.56] has joined #wesnoth-dev
20161111 17:33:38-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161111 17:34:56< tad_carlucci> BlackSpirit was working on mediawiki-api a little while ago. if you need him, putting a comment on the PR should get his attention
20161111 17:35:38-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 17:37:24-!- atarocch [~atarocch@31.157.46.56] has quit [Ping timeout: 246 seconds]
20161111 17:39:46-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161111 17:41:05< celticminstrel> He just hasn't updated the PR yet, that's all.
20161111 17:41:15< celticminstrel> It's been over a week. Maybe two.
20161111 17:41:41 * celticminstrel posts comment.
20161111 17:43:48-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161111 17:44:34< ancestral> Uploading right now
20161111 17:45:02< celticminstrel> \o/
20161111 17:45:03< ancestral> SHA256 should be eb5c76cf7cd83a582bdef19d6a7c8b165eb69b4024ceab5ea1987b10753a15e8
20161111 17:45:15< ancestral> We’re going to find out if it still is once it’s uploaded
20161111 17:45:19 * celticminstrel might actually download it and use it for my new campaign.
20161111 17:45:46< ancestral> Meanwhile… if anyone else with a Mac and a little technical background would like to take over packaging, I wouldn’t mind… 
20161111 17:46:08< celticminstrel> I don't think I'm really up to it, sorry...
20161111 17:47:01< celticminstrel> As far as I know, it's just you, me, and mattsc who use Macs.
20161111 17:47:32< ancestral> I know
20161111 17:47:35< ancestral> :-\
20161111 17:48:02< ancestral> And Jetrel but he has enough on his plate
20161111 17:48:12< celticminstrel> Huh. I didn't know that.
20161111 17:48:15< ancestral> And a couple other former packagers
20161111 17:48:22< celticminstrel> Possibly iceiceice.
20161111 17:48:26< ancestral> who aren’t involved much
20161111 17:48:28< ancestral> Oh yeah
20161111 17:48:35< ancestral> Also probably has too much
20161111 17:49:28< celticminstrel> Well, maybe someone could post an announcement asking if anyone would be interested in being the new Mac packager.
20161111 17:49:32< ancestral> Well, if someone can get Jenkins up and running, maybe we can have computers do everything
20161111 17:49:45< celticminstrel> Travis could probably do it actually.
20161111 17:49:54< ancestral> Travis/Jenkins right
20161111 17:50:19< celticminstrel> I was contemplating adding an OSX build, though there are so many builds already, I dunno if it's a good idea...
20161111 17:50:42< ancestral> Continuous integration and automation is amazing
20161111 17:51:21< celticminstrel> Travis has deploy options too. Wesnoth isn't using them though.
20161111 17:51:41< tad_carlucci> I was thinking it might be nice to have Travis package things. And the solution to "so many" is to fork master into another github account and use it for builds as-needed.
20161111 17:51:58< celticminstrel> Something about auto-uploading tag artifacts to AWS.
20161111 17:52:44< celticminstrel> But getting Travis to produce a Windows build looks like it would be a major pain, and it's not very useful to be uploading the Ubuntu build because the Ubuntu packager handles that in their own way.
20161111 17:52:54< tad_carlucci> The issue with using AWS I had was figuring out if free meant always-free or free-for-a-while
20161111 17:53:32< celticminstrel> In my brief perusal of Travis's deploy options it seems there are two distinct things.
20161111 17:53:35< tad_carlucci> There's a better system for windows builds. Not painful from what I could tell.
20161111 17:53:58< tad_carlucci> I looked at it a couple days ago but forget the name today. A-something. I can find a link if you want it.
20161111 17:54:01< celticminstrel> One is AWS-only, the other has lots of options. Not sure if the latter is useful for uploading artifacts.
20161111 17:54:30< celticminstrel> Well, it wouldn't hurt to look at what you found.
20161111 17:55:01< ancestral> If there is a nominal cost, I’m sure it’d be possible
20161111 17:55:55< celticminstrel> Wait, it says S3, not AWS. https://docs.travis-ci.com/user/uploading-artifacts/
20161111 17:56:32< celticminstrel> Maybe they're the same thing though.
20161111 17:56:44< celticminstrel> The other deployment docs: https://docs.travis-ci.com/user/deployment/
20161111 17:56:44< tad_carlucci> https://www.appveyor.com/
20161111 17:57:04< celticminstrel> So it's Windows-only, huh.
20161111 17:57:21< tad_carlucci> Yes. Looks to be very similar to Travis-CI
20161111 17:57:35< tad_carlucci> Uses VC Make files.
20161111 17:58:19< celticminstrel> To get a Windows build on Travis, you'd need MinGW, which as far as I can tell means grabbing packages from several PPAs.
20161111 18:00:09< tad_carlucci> I actually put appveryor on a note (since lost, but in my head) to take a look at privately and if I could get it going, doing a PR with the config yaml and such for someone with access to consider.
20161111 18:00:13< celticminstrel> Which is why I said it'd be a major pain.
20161111 18:00:31< celticminstrel> Well, let's see what vultraz thinks of appveyor when he wakes up.
20161111 18:00:42< celticminstrel> (Of course, anyone else is welcome to comment too.)
20161111 18:00:48< celticminstrel> Looks like it'd supplement Travis.
20161111 18:00:58< celticminstrel> Or complement might be a better way to put it.
20161111 18:01:07< tad_carlucci> IT would be nice to do a CI build for all 3 main target architectures
20161111 18:01:45< tad_carlucci> And even nicer if we could come up with a way to grab pre-builts or do packages
20161111 18:02:36-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161111 18:03:53-!- JyrkiVesterinen [~JyrkiVest@78-27-124-204.bb.dnainternet.fi] has joined #wesnoth-dev
20161111 18:06:55< tad_carlucci> PR 863 pushed and ready.
20161111 18:08:10-!- louis94 [~~louis94@91.178.240.21] has quit [Ping timeout: 265 seconds]
20161111 18:09:31< tad_carlucci> smart_list is only used for event handlers. The issue will be ensuring the iterators are not invalidated when an event is removed from the list. I'm going to need some time to think on it. Taking it out looks easy. Being sure it won't break will take serious cogitation.
20161111 18:14:36-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161111 18:17:00< irker424> wesnoth: Gregory A Lundberg wesnoth:master a2695aca7852 / src/wesmage/filter.cpp: Fix errors: missing includes https://github.com/wesnoth/wesnoth/commit/a2695aca7852a1d258dc2aca03001689f3cf27af
20161111 18:17:02< irker424> wesnoth: Gregory A Lundberg wesnoth:master b3019efd4282 / src/ (9 files in 6 dirs): Fix warning: Extra semicolon https://github.com/wesnoth/wesnoth/commit/b3019efd4282aecaad2bfe16bd117f4640eb5ebf
20161111 18:17:04< irker424> wesnoth: Gregory A Lundberg wesnoth:master 465ab8fda27e / src/ (font/standard_colors.cpp scripting/lua_preferences.cpp): Fix errors: #include <> should be "" https://github.com/wesnoth/wesnoth/commit/465ab8fda27e9bb5e5dbb51ca235cacc1dccee64
20161111 18:17:06< irker424> wesnoth: Gregory A Lundberg wesnoth:master d31555f8cf21 / src/ (143 files in 28 dirs): Pedantic includes https://github.com/wesnoth/wesnoth/commit/d31555f8cf21c0408b991344b7dc9283ed5fb834
20161111 18:17:08< irker424> wesnoth: Gregory A Lundberg wesnoth:master 2d4d8e26dce9 / .gitignore: .gitignore missing build targets https://github.com/wesnoth/wesnoth/commit/2d4d8e26dce96f7b04ef6ffff8671fb4da466904
20161111 18:17:10< irker424> wesnoth: Celtic Minstrel wesnoth:master 3b46cd30a8ae / / (152 files in 33 dirs): Merge pull request #863 from GregoryLundberg/GL_cleanup https://github.com/wesnoth/wesnoth/commit/3b46cd30a8ae402f8142d91896ffdcd3056efef3
20161111 18:17:43-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161111 18:22:32< celticminstrel> Oh, I was wrong. top_down only takes three bools, not the actual visit policy types.
20161111 18:22:36< celticminstrel> That's not so bad then.
20161111 18:22:58< JyrkiVesterinen> 20161111 17:55:55< celticminstrel> Wait, it says S3, not AWS. https://docs.travis-ci.com/user/uploading-artifacts/
20161111 18:22:58< JyrkiVesterinen> 20161111 17:56:32< celticminstrel> Maybe they're the same thing though.
20161111 18:23:17< JyrkiVesterinen> Yes, S3 (Simple Storage Service) is part of AWS (Amazon Web Services).
20161111 18:25:41< JyrkiVesterinen> Regarding the AppVeyor discussion, I think it would be very good to have a Continuos Integration service verifying that the game compiles with MSVC2013 that is the most restrictive compiler we support.
20161111 18:26:05< celticminstrel> Does AppVeyor support that? I didn't look closely.
20161111 18:26:29< JyrkiVesterinen> (I'm the most active developer using MSVC, and thus it's often me who notices if MSVC2013 build breaks.)
20161111 18:27:46< celticminstrel> Hmm, the problem(?) with having an OSX build in Travis is that whenever someone (other than me or mattsc) adds a new file, the build would break because they can't update the XCode project even if they wanted to.
20161111 18:27:57< celticminstrel> ...oh wait, it could build with scons though/
20161111 18:28:03< celticminstrel> So maybe not such a problem.
20161111 18:28:26< celticminstrel> Although there seems to be problems with scons (more generally, Python) on Travis OSX images.
20161111 18:28:55< celticminstrel> It randomly fails due to "resource not available" when attempting to write output.
20161111 18:29:03< celticminstrel> Or something like that.
20161111 18:29:24 * celticminstrel could provide log link if someone wants to look.
20161111 18:30:16-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161111 18:31:12< ancestral> Okay fantastic
20161111 18:31:14< ancestral> Sha is the same
20161111 18:31:21< celticminstrel> \o/
20161111 18:31:44< celticminstrel> I really want to know why on earth mordante made this iterator non-copyable.
20161111 18:32:02< ancestral> celticminstrel: Thanks for you support
20161111 18:32:25< celticminstrel> Huh?
20161111 18:32:28< celticminstrel> Did I do something?
20161111 18:32:45< tad_carlucci> JyrkiVesterinen, Would you like to take point on checking out appveyor? See if it can do what we need? I have it on my maybe-someday list.
20161111 18:33:05< JyrkiVesterinen> Sorry, I have too much work on my plate.
20161111 18:33:08< ancestral> celticminstrel: No, just emotionally rooting for me :)
20161111 18:33:23< celticminstrel> Oh okay.
20161111 18:34:06< tad_carlucci> JyrkiVesterinen, OK. Well, I'll take a look at it eventually. Probably after I wrap up deleting smart_list<>
20161111 18:42:53< ancestral> I accidentally re-uploaded the sha256 on the tar.bz2. I didn’t edit it.
20161111 18:43:02< ancestral> vultraz: Everything’s done
20161111 18:43:22< ancestral> Do you need me to post anywhere on the forums, or you will/update the home page?
20161111 18:44:07-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Remote host closed the connection]
20161111 18:47:43< celticminstrel> ancestral: You could post in the release thread and/or edit the opening post and announcement post, if you want.
20161111 18:47:54< ancestral> Just did
20161111 18:47:59< celticminstrel> BTW, did vultraz remember to update the wiki or whatever?
20161111 18:48:07< ancestral> That is out of my hands
20161111 18:49:04-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161111 19:09:27< tad_carlucci> include/gui/dialogs/lobby/player_info.hpp:29:35: error: expected class name
20161111 19:09:27< tad_carlucci> class tlobby_player_info : public tdialog
20161111 19:09:27< tad_carlucci> include/gui/dialogs/lobby/player_info.hpp:48:16: error: unknown type name 'twindow'; did you mean 'window'?
20161111 19:09:27< tad_carlucci>         void pre_show(twindow& window);
20161111 19:09:27< tad_carlucci> src/gui/dialogs/lobby/lobby.cpp:1087:2: error: unknown type name 'lobby_player_info'; did you mean 'tlobby_player_info'?
20161111 19:09:29< tad_carlucci>         lobby_player_info dlg(*chatbox_, *info, lobby_info_);
20161111 19:09:31< tad_carlucci> src/gui/dialogs/lobby/lobby.cpp:1091:6: error: no member named 'show' in 'gui2::tlobby_player_info'
20161111 19:09:33< tad_carlucci>         dlg.show(window_->video());
20161111 19:10:01< celticminstrel> Huh?
20161111 19:10:30< tad_carlucci> What I got just now checking current master compiles before going into looking at smart_list<>
20161111 19:11:02< tad_carlucci> Did you rename some files? I might need to make some adjustments.
20161111 19:11:13< celticminstrel> I didn't rename any files...
20161111 19:11:28-!- gfgtdf [~chatzilla@x4e36a59b.dyn.telefonica.de] has joined #wesnoth-dev
20161111 19:13:35< tad_carlucci> OK. I see it. Local error.
20161111 19:15:08< tad_carlucci> I was checking the build out-of-tree and I guess I accidentially used a hard link instead of a symlink for player_info.hpp
20161111 19:22:54-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161111 19:51:08-!- Shiki [~Shiki@141.39.226.226] has quit [Ping timeout: 260 seconds]
20161111 19:51:35-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161111 19:57:20< celticminstrel> So, the iterator isn't working, and I can't figure out what I'm doing wrong.
20161111 20:01:18-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161111 20:01:44-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161111 20:05:59< vultraz> what is it im needed for
20161111 20:07:02< celticminstrel> I forget.
20161111 20:07:13< vultraz> updating wiki?
20161111 20:09:23< vultraz> done so
20161111 20:18:35< vultraz> C:\Users\Charles\Documents\wesnoth-git\src\gui\widgets\image.cpp|41|error: '::image' has not been declared|
20161111 20:18:37< vultraz> blah
20161111 20:22:05< celticminstrel> ...?
20161111 20:22:08< vultraz> so it seems my compiler takes umbrage with that gui/widgets/../../file.hpp-style lines
20161111 20:22:12-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 20:22:33< celticminstrel> What?
20161111 20:23:10< vultraz> like #include "gui/widgets/../../image.hpp" 
20161111 20:23:27< vultraz> to get the version in src/
20161111 20:23:48< celticminstrel> Ah.
20161111 20:23:58< tad_carlucci> best fix would be to elminate the duplicate name.
20161111 20:24:02< celticminstrel> Personally I think it's a bad idea to have multiple files with the same name.
20161111 20:24:09< tad_carlucci> ^
20161111 20:24:11< celticminstrel> Especially when one is in src.
20161111 20:24:18< tad_carlucci> Definitely then
20161111 20:24:23< celticminstrel> If they were both in separate subdirs it wouldn't be too bad.
20161111 20:25:22< celticminstrel> Do you want me to point out all the GUI2 files that I feel could maybe be moved or renamed?
20161111 20:25:23< tad_carlucci> Agreed.  It would taste bad but no rational build system would become confused. Now .. if one were to flatten the structure to "help" confused programmers .. well .. 
20161111 20:25:28< JyrkiVesterinen> I have even worked on a project where having multiple files with the same name wasn't possible. Doing so made SWIG ( http://swig.org/ ) upset. (We used SWIG to make C++ classes accessible from Lua.)
20161111 20:25:52< vultraz> celticminstrel: list, please
20161111 20:25:53< celticminstrel> tad_carlucci: Right, like XCode does... though it's not causing serious problems there, at least.
20161111 20:26:33< celticminstrel> vultraz: Should I just list them here, or put them in a pastebin or something?
20161111 20:27:09< vultraz> celticminstrel: pastebin, please
20161111 20:27:11< tad_carlucci> I think that was the only place ../.. appeared and I seriously considered renaming the image.hpp in widgets but dcided to wait for Celmin to do therenames
20161111 20:27:43< irker424> wesnoth: Charles Dang wesnoth:master 1194a9ac9b9b / src/gui/widgets/ (image.cpp minimap.cpp): Quick fix for odd src-relative includes not working correctly https://github.com/wesnoth/wesnoth/commit/1194a9ac9b9bc27c20e5c658ca87d9ba011ae232
20161111 20:30:12< irker424> wesnoth: Charles Dang wesnoth:master 4fffa3205eaa / src/ (tstring.cpp utils/shared_object.hpp): Removed unused shared_object util class https://github.com/wesnoth/wesnoth/commit/4fffa3205eaa846c5c65cfb7c41bce5f14382936
20161111 20:30:25< tad_carlucci> celticminstrel, pls to take a quick look at PR 873 and merge if it's ok
20161111 20:33:08< vultraz> time to start purging the gui1 mp lobby
20161111 20:33:10< vultraz> then, breakfast
20161111 20:33:17< vultraz> mp screens*
20161111 20:33:36< celticminstrel> Is that really the only missed case of variable names masking struct names?
20161111 20:33:53< irker424> wesnoth: Gregory A Lundberg wesnoth:master ff287a48552c / src/wesmage/filter.cpp: Fix error from b6c88df9e7da58921cd00813b7d99e41352bb03f https://github.com/wesnoth/wesnoth/commit/ff287a48552c1a6d56dc420db620dd342940db13
20161111 20:33:55< irker424> wesnoth: Celtic Minstrel wesnoth:master 37a29ad55720 / src/wesmage/filter.cpp: Merge pull request #873 from GregoryLundberg/GL_fix_name_conflict https://github.com/wesnoth/wesnoth/commit/37a29ad5572099e91187877b84b0c87d270639cd
20161111 20:34:03< tad_carlucci> Dunno but it's the one which caused a compile error.
20161111 20:34:18< celticminstrel> Maybe I actually accounted for the others without really realizing it. >_>
20161111 20:35:18< tad_carlucci> Probably. Note it's a target not usually built. My oot system compiles it to check but skips linking because that can be expected to fail unless I give it the entire .o list to choose from
20161111 20:35:41-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161111 20:35:45< celticminstrel> I actually did try building it when doing the renames though, mainly because there were several renames specific to it.
20161111 20:35:55< celticminstrel> Though it didn't successfully build then due to other errors IIRC.
20161111 20:36:00 * tad_carlucci nods.
20161111 20:36:23< tad_carlucci> The missing header my PR "little things" put in, most likely.
20161111 20:36:40< celticminstrel> I can't remember, but possibly...
20161111 20:36:52< celticminstrel> If it was <cxxx> or <xxx> though, likely not.
20161111 20:37:14< tad_carlucci> It was #include <assert>" which was missing
20161111 20:37:22< tad_carlucci> s/"//
20161111 20:39:01< tad_carlucci> Anyway. I've decided I need to do some TDD for removing smart_list to test the use cases against current master before I try to replace them so I'm beating my head against a wall named "Boost" ... back to it ...
20161111 20:40:25< vultraz> a what now?
20161111 20:41:39< celticminstrel> I think assert gets implicitly included a lot on my system. Actually, I don't think I've ever explicitly included it.
20161111 20:41:49< celticminstrel> I could be wrong though.
20161111 20:41:50< tad_carlucci> A wall, named "Boost" specifically boost/test .. I thought, no problem, I'll add a sample and when it works I'll change it. But NO .. two main() functions. 
20161111 20:42:58< celticminstrel> When I was looking for unit-testing for BoE I was not very enthusiastic about Boost. Can't remember all the reasons. Might've been poor documenation, or things seeming overly complicated, or something.
20161111 20:43:18< celticminstrel> (Of course it still uses other parts of Boost.)
20161111 20:43:37< celticminstrel> (But I don't feel that I have to use Boost unit testing just because I'm using other Boost stuff.)
20161111 20:44:42< tad_carlucci> Well wesnoth test is all Boost testing and if I'm putting in a unit test I might as well put it in permanently.
20161111 20:46:44< shadowm> celticminstrel: What is BoE again?
20161111 20:47:11 * shadowm refrains from suggesting "Battle of Endor" again.
20161111 20:47:16< celticminstrel> Hehe.
20161111 20:47:20< celticminstrel> Blades of Exile
20161111 20:47:26< shadowm> Oh okay.
20161111 20:50:12< vultraz> blah, why is the quit confirmation not working properly
20161111 20:50:31< celticminstrel> Maybe something is hiding something. I dunno.
20161111 20:55:01< vultraz> very likely
20161111 20:55:24< vultraz> celticminstrel: can you confirm if you go into the lobby and try to log out if the quit prompt shows up?
20161111 20:55:34-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 20:57:01< celticminstrel> Why is it requesting my password.
20161111 20:57:51< celticminstrel> Somehow the password got wiped.
20161111 20:57:57< celticminstrel> I don't remember it.
20161111 20:59:06< vultraz> it doesn't seem to be showing even if i revert my changes
20161111 20:59:08< vultraz> not my fault, then
20161111 20:59:10< vultraz> good
20161111 21:00:13< celticminstrel> Time machine has failed me.
20161111 21:00:51< gfgtdf> hmm sliders doesnt work poerprly here (wesnoth1.13.6 release) the 2p dark forecast diffuculy slider shodul go from -30 to 30 but i cannot set to to its max value (30)
20161111 21:01:05< gfgtdf> well i can set it via keybord
20161111 21:01:06< celticminstrel> Found it in my Windows prefs.
20161111 21:01:22< gfgtdf> hm not evne that
20161111 21:01:33< vultraz> gfgtdf: https://gna.org/bugs/index.php?24531
20161111 21:01:45< gfgtdf> i can set the 'turns' slider to its max valus ivia keyboard but it doent wokr for that options sliders
20161111 21:01:49< vultraz> gfgtdf: and there's something particularly wrong with that slider
20161111 21:01:53< vultraz> gfgtdf: the dark forecast one
20161111 21:02:31< vultraz> gfgtdf: i tracked the issue to scrollbar::set_item_position but i couldn't fix it
20161111 21:02:35< gfgtdf> vultraz: maybe its that step is not 1 liek for most other sliders
20161111 21:02:39< celticminstrel> Somehow I made it past the login screen.
20161111 21:02:44< vultraz> yeah
20161111 21:02:49< vultraz> partly
20161111 21:02:51< celticminstrel> I thought it was going to lag beyond repair.
20161111 21:02:55< tad_carlucci> I keep forgettting to use ./test and wondering why the command test doesn't run our test program. Maybe, someday, we should choose a better name?
20161111 21:02:59< vultraz> by the math the behavior is correct
20161111 21:03:03< celticminstrel> vultraz: I get the logout confirmation.
20161111 21:03:08< vultraz> whaaaaa
20161111 21:03:10< vultraz> :|
20161111 21:03:16< celticminstrel> When clicking the X
20161111 21:03:19< vultraz> when clicking Log Out
20161111 21:03:24< vultraz> I do get it when clicking the x
20161111 21:03:29< celticminstrel> It doesn't happen when clicking Log Out. That may be intentional, not sure.
20161111 21:03:32< vultraz> ok
20161111 21:06:25< gfgtdf> the quit confirmation only happens when there is a running game or editor since its main purpose is to save pople form losing progress.
20161111 21:06:45-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 21:06:57< gfgtdf> it afaik doesnt activate on clicking X when you are in the lobby or main menu.
20161111 21:07:33< celticminstrel> It does.
20161111 21:07:39< celticminstrel> For the lobby, not the main menu.
20161111 21:08:13< celticminstrel> There is the possibility of losing data in that case (chat logs).
20161111 21:08:21< celticminstrel> Though less important data than a game in progress.
20161111 21:08:37-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161111 21:08:45< celticminstrel> vultraz: I think I recall you complaining that it shouldn't happen when clicking Log Out, actually...
20161111 21:08:54< vultraz> oh?
20161111 21:08:59< vultraz> ok maybe im misremembering
20161111 21:10:05< celticminstrel> It could be me misremembering too. >_>
20161111 21:10:23< tad_carlucci> When I click "X" it pops up. I click "X" again to kill it. That's probably a mistake because sometimes my finger bounces and I double-click "X" and the popup appears and disappears (along with the game) just that fast.
20161111 21:11:10< gfgtdf> celticminstrel: hmm then this was added recnetly, when i first added the quit confirmation it worked as i described above.
20161111 21:11:17< celticminstrel> vultraz: BTW, use of the iterator in place of the walker currently looks like for(gui2::iterator::iterator<gui2::iterator::policy::order::top_down<true,true,true>> iter(widget); iter.at_end(), ++iter) { ... }
20161111 21:11:33< celticminstrel> gfgtdf: Yes, I made it apply to the lobby at some point.
20161111 21:11:43< vultraz> that rather looks messy
20161111 21:11:48< celticminstrel> Yup.
20161111 21:11:56< celticminstrel> It's a bit better with some using namespace, but...
20161111 21:11:58< vultraz> perhaps use the walker there
20161111 21:12:20< celticminstrel> using namespace gui2::iterator; using namespace policy::order; for(iterator<top_down<true,true,true>> iter(widget) ...
20161111 21:12:36< celticminstrel> I can't find my mouse cursor... :|
20161111 21:12:51< celticminstrel> Oh, there it is.
20161111 21:13:10 * celticminstrel had to actually thumb over the optical thing on the bottom though...
20161111 21:25:37< irker424> wesnoth: Charles Dang wesnoth:master 6fb88caefd85 / src/game_initialization/multiplayer.cpp: Initial removal of old GUI1 mp UI codepaths https://github.com/wesnoth/wesnoth/commit/6fb88caefd8508fc7a41f686c21bbd8b646d9581
20161111 21:26:05< vultraz> still need to make the scenario interim screens use the gui2 codepath
20161111 21:26:12< vultraz> i hadn't gotten to that pre-release
20161111 21:37:15< irker424> wesnoth: Charles Dang wesnoth:master 39cd63f55cd7 / data/advanced_preferences.cfg src/game_preferences.cpp src/game_preferences.hpp: Removed Experimental MP UI preference (finally!) https://github.com/wesnoth/wesnoth/commit/39cd63f55cd78d1a1dbd8bc16cc70561455492b8
20161111 21:37:23< vultraz> it has happened! \ o /
20161111 21:37:31< celticminstrel> Bleh.
20161111 21:37:36< celticminstrel> Well whatever.
20161111 21:37:55< celticminstrel> This does mean we have to make sure the new lobby performs well under load, though.
20161111 21:38:12< vultraz> of course
20161111 21:38:14< celticminstrel> Also Travis needs to be updated to run the GUI2 tests. Did you bother doing that?
20161111 21:38:20< vultraz> no
20161111 21:38:27< celticminstrel> Well, maybe you should.
20161111 21:38:41< vultraz> i don't know how 2 travis
20161111 21:38:51< celticminstrel> BTW, any objections to me pushing a rename of gui2::iterator -> gui2::iteration? (it's a namespace)
20161111 21:39:48< vultraz> no, as long as it's a namespace
20161111 21:40:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Read error: Connection reset by peer]
20161111 21:47:22< tad_carlucci> celticminstrel, vultraz What do you need added to Travis? If it's a new command to be run update ~/.travis.yml or add it to the run_wml_tests or mp_test shell scripts (whichever makes more sense) if it's part of the 'test' target you're done.
20161111 21:48:01< celticminstrel> I think all I need to do is delete something and rename something else to replace it.
20161111 21:48:05< celticminstrel> But not quite sure.
20161111 21:48:19< celticminstrel> Need to double-check that the thing being renamed isn't also already run by Travis.
20161111 21:48:33< tad_carlucci> .travis.yml will tell you
20161111 21:48:37< celticminstrel> Yeah.
20161111 21:56:56< tad_carlucci> I'm tracking down what-the-heck smart_list does and why and, tell me if I'm wrong, it looks like all it's for is handing keeping track of [event] through [event], [fire_event] and [remove-event]. So my best unit tests would be at the outermost level game_events/manager.hpp
20161111 21:57:43< celticminstrel> Oh, it was for game events?
20161111 21:57:56 * celticminstrel never really looked much.
20161111 21:58:11-!- mattsc [~mattsc@wesnoth/developer/mattsc] has joined #wesnoth-dev
20161111 21:58:20< celticminstrel> Oh hi.
20161111 21:58:44< tad_carlucci> Can't find any other references to it. Similar names in sdl and sync'd MP choices but different namespaces (if I'm reading the code correctly).
20161111 21:59:16< celticminstrel> vultraz: May not be comprehensive, but here you go. http://pastebin.com/mdN1Hv6f
20161111 21:59:43< irker424> wesnoth: Jyrki Vesterinen wesnoth:master bf5ad238797f / src/gui/widgets/generator_private.hpp: Fix build with Visual Studio https://github.com/wesnoth/wesnoth/commit/bf5ad238797fc1e7b284d1b715700b584986d932
20161111 22:00:16< irker424> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox ca81cfd56394 / / (7 files in 3 dirs): Size lock widget, the C++ part https://github.com/wesnoth/wesnoth/commit/ca81cfd56394282455776d6620563e0e3f7a0d1e
20161111 22:00:18< irker424> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox a1e68fdcb719 / data/gui/ (macros/_initial.cfg schema.cfg widget/size_lock_default.cfg): Size lock widget, the WML part https://github.com/wesnoth/wesnoth/commit/a1e68fdcb719442913419c96c00047cdcab58c95
20161111 22:00:20< irker424> wesnoth: Jyrki Vesterinen wesnoth:fixed-size-chatbox 5df75684a768 / data/gui/window/ (lobby_main.cfg mp_join_game.cfg mp_staging.cfg): Lock sizes of all chat boxes https://github.com/wesnoth/wesnoth/commit/5df75684a7683d6677e459c7f1c5ec22fba7ca24
20161111 22:00:40< JyrkiVesterinen> (Stuff in that branch is completely untested because I couldn't compile.)
20161111 22:01:13-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161111 22:01:39< mattsc> Hi.
20161111 22:02:23< mattsc> Trying to get Xcode to compile after the Lua update.
20161111 22:04:05< celticminstrel> Pretty sure I already updated it for that?
20161111 22:04:16< celticminstrel> XCode build is currently broken for other reasons though.
20161111 22:04:28< tad_carlucci> Is there a specific problem? Where I'd expect a compile issue for the Lua update would be neglecting to inject wesnoth_lua_config.h using -include for ONLY the lua/*.cpp targets
20161111 22:04:38< mattsc> okay
20161111 22:04:41< celticminstrel> Oh yeah, ancestral was able to build, so I must've updated it.
20161111 22:04:48< celticminstrel> tad_carlucci: I did that, yes.
20161111 22:05:06< tad_carlucci> I know. Just saying.
20161111 22:05:25< mattsc> ancestral probably compiled 1.13.6, which was before the changes, wasn’t it?
20161111 22:05:31< ancestral> celticminstrel: Oddly when it built for me I had an extra file, lua.a or something, sitting at the same level as the bundle
20161111 22:05:46< celticminstrel> mattsc: I was going to update XCode once things settle down, since I think vultraz plans to delete and/or rename other stuff.
20161111 22:05:52< celticminstrel> ancestral: That's expected.
20161111 22:05:54< ancestral> I figured it was not needed if it wasn’t in the package
20161111 22:05:56-!- JyrkiVesterinen [~JyrkiVest@78-27-124-204.bb.dnainternet.fi] has quit [Quit: Going to bed]
20161111 22:05:58< celticminstrel> I split out Lua into a static lib.
20161111 22:06:03< celticminstrel> It's not required for packaging.
20161111 22:06:12< ancestral> Maybe once you do that
20161111 22:06:15< ancestral> I’ll put the libs up
20161111 22:06:21< celticminstrel> Huh?
20161111 22:06:28< ancestral> The libs for builders
20161111 22:06:29< mattsc> Ah, I am getting a probllem with something that quotes liblua.a at the moment too
20161111 22:06:33< celticminstrel> It's a static lib built by the XCode project.
20161111 22:06:36< ancestral> I’ve been delinquent getting that out
20161111 22:06:39< ancestral> Ah?
20161111 22:06:43< celticminstrel> If you look in the project settings you'll see there's a new liblua target.
20161111 22:06:59< celticminstrel> mattsc: What's the error?
20161111 22:07:00< ancestral> Right
20161111 22:07:17< mattsc> Okay, but liblua complains about linit and whatever the other file was not being there
20161111 22:07:31< celticminstrel> Oh right, tad_carlucci deleted a couple of Lua files, right?
20161111 22:07:34< tad_carlucci> AFTER 1.13.6 I deleted that file.
20161111 22:07:36< mattsc> those that got removed
20161111 22:07:40< mattsc> right
20161111 22:07:48< mattsc> I am trying to compile current master, not 1.13.6
20161111 22:07:50< celticminstrel> So just remove them from the project and it should work.
20161111 22:07:51< tad_carlucci> And lua.hpp and another I forget off the top of my head
20161111 22:08:02< mattsc> they aren’t in the project, that’s one of the problem
20161111 22:08:07< mattsc> s
20161111 22:08:14< celticminstrel> I think I put them in a weird place.
20161111 22:08:28< celticminstrel> Under frameworks IIRC?
20161111 22:08:49< tad_carlucci> The three files I deleted were removed because (1) they're not used and (2) they're too dangerous to let someone accidentially try to use them.
20161111 22:08:51< celticminstrel> Or you could just go to the liblua target and remove them from the build.
20161111 22:08:58< ancestral> Any plans for compressing some data files?
20161111 22:09:05< ancestral> Wesnoth is starting to get up to half a gig
20161111 22:09:09< celticminstrel> Not that I know of?
20161111 22:09:14< celticminstrel> I kinda doubt it would help though.
20161111 22:09:26< mattsc> celticminstrel: anyways, if you are going to update later, that’s good enough for me
20161111 22:09:29< ancestral> If you gzipped all the text files, wouldn’t that make a difference?
20161111 22:09:35< mattsc> I am only working with 1.12 at the moment anyway
20161111 22:09:37< celticminstrel> I doubt it.
20161111 22:09:38< ancestral> And then when they load, just ungzip?
20161111 22:09:39< celticminstrel> Wesnoth's download size is probably dominated by the images.
20161111 22:09:50< celticminstrel> And the images are already compressed about as much as possible.
20161111 22:09:59< tad_carlucci> Second place to the images are the translations.
20161111 22:10:09< celticminstrel> Oh, good point.
20161111 22:10:31< celticminstrel> Maybe that's an argument for using po files instead of mo files.
20161111 22:10:42< celticminstrel> If we use po we can definitely also compress them.
20161111 22:11:00< celticminstrel> I don't know if Boost.Locale can be told to expect its mo files to be compressed.
20161111 22:11:37< ancestral> Okay so rough count about 11 MB of text files
20161111 22:11:41< celticminstrel> mattsc: Did you manage to find where to remove the Lua files?
20161111 22:11:59< mattsc> celticminstrel: haven’t looked since you said that
20161111 22:12:44< shadowm> celticminstrel: Can it read them from generic istreams? In that case you could just couple it with Boost.Iostreams' compressed streams functionality.
20161111 22:13:07< mattsc> celticminstrel, all: I won’t be around much by default in the foreseeable future.  But I have a little script that wget’s the logs and greps for my nick, for ‘AI” and a couple other things that I run once a day or so.  So just ping me and I’ll eventually come by.
20161111 22:13:31< ancestral> Alright, we’re going to see if any of these images can be optimized further, without Zopfli
20161111 22:13:31-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161111 22:14:00< tad_carlucci> Don't see a specific answer to 'does boost support po' but the examples in the docs use po files extensively so that may be the answer
20161111 22:14:12< celticminstrel> shadowm: I don't know much about Boost.Locale, but my vague impression is that it assumes the standard gettext layout/format, with LC_MESSAGES and .mo files and everything.
20161111 22:14:20< ancestral> All the teleport images need optimization
20161111 22:14:29< celticminstrel> But it's entirely possible that my vague impression is wrong.
20161111 22:15:00< tad_carlucci> Ah .. Boost::Locale docs punt the question to GNU gettext docs.
20161111 22:20:14-!- mattsc [~mattsc@wesnoth/developer/mattsc] has quit [Quit: So long and thanks for all the fish.]
20161111 22:21:28< celticminstrel> Ah, more hiding warnings huh...
20161111 22:21:53< celticminstrel> Not too happen about the choice of "my_placement", but I guess there aren't really any better options.
20161111 22:21:58< celticminstrel> ^happy
20161111 22:22:29< tad_carlucci> celticminstrel, From reading the GNU gettext docs it does not look like they use po directly, and only look for mo files at runtime.
20161111 22:23:27< celticminstrel> And they cannot be compressed, I assume.
20161111 22:23:38< celticminstrel> ie, gzipped or similar.
20161111 22:24:53< tad_carlucci> I'm sure you can ship them compressed but the package installer would need to expand them before they could be used.
20161111 22:25:46< celticminstrel> True, true.
20161111 22:26:01< celticminstrel> 'du translations' gives 199128.
20161111 22:26:22< celticminstrel> data is 758792...
20161111 22:26:41< celticminstrel> Not sure how I can subtract out the images, music, and sound...
20161111 22:29:11< tad_carlucci> I get 373M for data and 98M for translations 24M for wesnoth and 2M for wesnothd
20161111 22:30:48< tad_carlucci> I get 361M for data if I explude *.cfg
20161111 22:30:54< tad_carlucci> exclude
20161111 22:31:12< tad_carlucci> cd data; du -BM --exclude '*.cfg'
20161111 22:31:27-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161111 22:32:38< celticminstrel> So roughly 12M of cfg.
20161111 22:33:29< tad_carlucci> 143M	./core/music
20161111 22:33:29< tad_carlucci> 112M	./core/images
20161111 22:35:51-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161111 22:36:31< irker424> wesnoth: Celtic Minstrel wesnoth:master c630ee2fc1f2 / src/ (28 files in 3 dirs): Rename namespace gui2::iterator -> iteration https://github.com/wesnoth/wesnoth/commit/c630ee2fc1f2bf6f536bb3ff96a8d52983f9ea52
20161111 22:36:33< irker424> wesnoth: Celtic Minstrel wesnoth:master 5c57f25ce7a4 / host.lua join.lua utils/travis/mp_test_executor.sh: Remove GUI1 MP tests https://github.com/wesnoth/wesnoth/commit/5c57f25ce7a4b130acd46b881b2ed86e298b04ed
20161111 22:36:35< irker424> wesnoth: Celtic Minstrel wesnoth:master c43651f99b24 / / (6 files in 2 dirs): Rename GUI2 MP tests to replace their now-missing GUI1 counterparts https://github.com/wesnoth/wesnoth/commit/c43651f99b2436337c7c1bee88236458c4acb63d
20161111 22:41:56< irker424> wesnoth: Celtic Minstrel wesnoth:master 9322f90b3a89 / .travis.yml utils/travis/install_deps.sh: Split Travis dependency installation into a shell script https://github.com/wesnoth/wesnoth/commit/9322f90b3a8976b504f065437b842259e2c1f452
20161111 22:42:31< celticminstrel> ...wonder if I should've used travis_wait outside the script instead of inside.
20161111 22:42:33< gfgtdf> celticminstrel: boost locale can be given a cusotm file loader (which is basically a function< std::vector<char> (std::string const &file_name, std::string const &encoding ) > ) where we could inject decompresong. (ofc the decompressed files still woudl need to be mo files)
20161111 22:42:51< celticminstrel> Hmm.
20161111 22:43:28< celticminstrel> Can you explain that in more detail?
20161111 22:43:33< tad_carlucci> Do we get enough space savings to make it worth the effort?
20161111 22:44:35< celticminstrel> If you can only compress each file individually, the space savings would be less than if you could package it all into one archive, right?
20161111 22:44:38< gfgtdf> celticminstrel: this page meantioned info.callback  : http://www.boost.org/doc/libs/1_62_0/libs/locale/doc/html/messages_formatting.html#custom_file_system_support
20161111 22:46:09< celticminstrel> So the most important question is... what's the file name that Boost passes you?
20161111 22:46:14< tad_carlucci> celticminstrel, That's presuming we always want to install all languages. Might be a bigger win to have the package installer choose the language and only install the one; provide a means to go back an install more if needed.
20161111 22:47:01< celticminstrel> tad_carlucci: Well, there's also the option of "one archive per textdomain" (which does nothing about the problem you mentioned) or "one archive per language".
20161111 22:47:23< tad_carlucci> Or one downloadable package per language. :P
20161111 22:47:41-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161111 22:47:56< gfgtdf> celticminstrel: i guess "<lang>/LC_MESSAGES/<domain>.mo" but ifcourse you cna deecompose it and read a differnt file.
20161111 22:47:57< celticminstrel> That sounds prohibitive for ancestral.
20161111 22:48:18< celticminstrel> gfgtdf: Well that's the problem. That's a guess. We need an answer. :P
20161111 22:48:56< gfgtdf> celticminstrel: you coudl just debug this by printing the filename in the callback function, shoudln't be hard.
20161111 22:49:39< tad_carlucci> I'd expect gfgtdf guessed right or very close to right, though.
20161111 22:49:51< celticminstrel> Sure, but their documentation should specify this.
20161111 22:50:09< celticminstrel> (This by the way is why I used Spirit Classic instead of the new Spirit parser engine.)
20161111 22:51:11-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161111 22:51:40< tad_carlucci> What, you don't like the Boost style of "here's the template, you figure it out" documentation?
20161111 22:52:15< celticminstrel> The Spirit Classic documentation is actually pretty good (though I think it's still lacking in some areas).
20161111 22:52:24 * tad_carlucci nods.
20161111 22:52:33< celticminstrel> But quite often recently I've found Boost's documentation to be terrible.
20161111 22:52:36-!- Bonobo [~Bonobo@2001:44b8:254:3200:dc56:d7a2:24aa:1381] has joined #wesnoth-dev
20161111 22:52:44< celticminstrel> The Boost.Preprocessor documenation is pretty good as well though.
20161111 22:52:49< tad_carlucci> Some parts of Boost are fairly well documented. Other make you want to find a harder wall to beat your head against.
20161111 22:52:55< celticminstrel> (Or was when I last looked.)
20161111 22:52:57< celticminstrel> Yeah,
20161111 22:53:20-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161111 22:55:25-!- louis94 [~~louis94@91.178.240.21] has joined #wesnoth-dev
20161111 23:08:33< celticminstrel> By the way, what does NLS stand for? Something to do with the translations.
20161111 23:12:38< irker424> wesnoth: Charles Dang wesnoth:master bf58ce79fb56 / src/gui/dialogs/select_orb_colors.cpp: Fixup c630ee2fc1f2 https://github.com/wesnoth/wesnoth/commit/bf58ce79fb56eadc65730ba0c92c8f3e5c021d8f
20161111 23:12:42< vultraz> how do you keep missing these things
20161111 23:14:44< celticminstrel> I used a lot of git add -u for the renaming. >_>
20161111 23:15:04< celticminstrel> Often but not always followed by git diff --cached
20161111 23:15:53< celticminstrel> Oh, I was working in that file, so that's probably how I missed that instance.
20161111 23:16:10< celticminstrel> I was trying to get the iterator to work at the same time.
20161111 23:16:13< celticminstrel> Whoops.
20161111 23:17:03-!- travis-ci [~travis-ci@ec2-54-167-211-50.compute-1.amazonaws.com] has joined #wesnoth-dev
20161111 23:17:04< travis-ci> wesnoth/wesnoth#12017 (master - 6fb88ca : Charles Dang): The build has errored.
20161111 23:17:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175197587
20161111 23:17:04-!- travis-ci [~travis-ci@ec2-54-167-211-50.compute-1.amazonaws.com] has left #wesnoth-dev []
20161111 23:18:36< celticminstrel> So the MP test timed out.
20161111 23:18:54< celticminstrel> Probably caused by you removing the GUI1 path.
20161111 23:19:00-!- vincent_c [~bip@vcheng.org] has quit [Ping timeout: 246 seconds]
20161111 23:19:18< celticminstrel> In which case my push should fix it, as long as the GUI2 tests actually work.
20161111 23:21:12-!- vincent_c [~bip@vcheng.org] has joined #wesnoth-dev
20161111 23:21:52< irker424> wesnoth: Celtic Minstrel wesnoth:master 05d47216db4c / host.lua join.lua simulate-lobby-activity.lua: Remove reference to removed pref from MP tests https://github.com/wesnoth/wesnoth/commit/05d47216db4c3932a0df7c5231b8fe9d57d483d5
20161111 23:22:32< irker424> wesnoth: Celtic Minstrel wesnoth:master de11d7f88ad9 / .travis.yml: Travis: Add OSX build https://github.com/wesnoth/wesnoth/commit/de11d7f88ad99bea8b83a3256fdc06b7c6883209
20161111 23:22:41< celticminstrel> ...
20161111 23:22:46< celticminstrel> I meant to push that to a branch. :/
20161111 23:23:10< celticminstrel> But I did git branch name instead of git checkout -b name.
20161111 23:23:28< celticminstrel> Oh well?
20161111 23:23:42 * celticminstrel has no idea if that's sufficient to get it to actually work.
20161111 23:23:54< celticminstrel> ...actually, come to think of it, it's not sufficient.
20161111 23:24:08< celticminstrel> Should we erase that commit or just fixup?
20161111 23:24:22< vultraz> just fixup
20161111 23:24:27< gfgtdf> celticminstrel: it seems liek your t_ commit ressurected the file src/server/room_manager.hppis tis intentional?
20161111 23:24:32< celticminstrel> It'll definitely fail (scons will fail the depcheck).
20161111 23:24:37< celticminstrel> gfgtdf: Somewhat.
20161111 23:24:38< vultraz> i don't want to have to disable branch protection
20161111 23:25:20< celticminstrel> gfgtdf: I was going to ask loonycyborg whether he thought he needed it and then decide whether to resurrect it, but I kinda forgot.
20161111 23:25:34< gfgtdf> celticminstrel: in any case, even if it's inentional it's clear that it shoudln't be hidden in that commit.
20161111 23:25:42< gfgtdf> celticminstrel: the resurection i mean
20161111 23:25:51< celticminstrel> It was a merge conflict.
20161111 23:25:58< celticminstrel> I had to pick one to continue rebasing.
20161111 23:26:02-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161111 23:26:19< celticminstrel> So I picked resurrect with the intention of possibly reversing the decision later.
20161111 23:26:25< celticminstrel> And then I forgot about it.
20161111 23:26:38-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161111 23:26:39< vultraz> I assume you don't want to re-remove it :P
20161111 23:26:56< celticminstrel> Well, I don't, but it's not like I have the final say here.
20161111 23:27:05< vultraz> yeah, let loonycyborg decide
20161111 23:27:27< loonycyborg> I'm not sure myself
20161111 23:27:35< loonycyborg> I originally left them for reference\
20161111 23:27:50< loonycyborg> but I'm fine with checking out older commit
20161111 23:28:36< celticminstrel> Well, in that case I guess you can feel free to re-remove them?
20161111 23:29:19< celticminstrel> Aw, ancestral already left.
20161111 23:29:44< celticminstrel> I guess I'll just trial-and-error this unless he comes back first.
20161111 23:30:48< celticminstrel> Or maybe find a list online somewhere.
20161111 23:31:01-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 256 seconds]
20161111 23:35:17< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx 522e31fbbc58 / utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/522e31fbbc58affc8c740b6e0bc982a127b8c583
20161111 23:35:27< celticminstrel> This time I remembered the branch. :/
20161111 23:36:02< celticminstrel> Travis is like seven builds behind.
20161111 23:46:02< gfgtdf> celticminstrel: you can abort travis builds on the travis page, specially for builds that doesnt change anything that is tested by travis this often makes sense.
20161111 23:49:23-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has joined #wesnoth-dev
20161111 23:49:51-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has joined #wesnoth-dev
20161111 23:49:52< travis-ci> wesnoth/wesnoth#12019 (master - bf5ad23 : Jyrki Vesterinen): The build was canceled.
20161111 23:49:52< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175204597
20161111 23:49:52-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has left #wesnoth-dev []
--- Log closed Sat Nov 12 00:00:32 2016