--- Log opened Sat Nov 12 00:00:32 2016
20161112 00:02:27-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 265 seconds]
20161112 00:06:01-!- mjs-de [~mjs-de@x4db60200.dyn.telefonica.de] has joined #wesnoth-dev
20161112 00:10:24-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 00:10:25< travis-ci> wesnoth/wesnoth#12020 (fixed-size-chatbox - 5df7568 : Jyrki Vesterinen): The build is still failing.
20161112 00:10:25< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175204672
20161112 00:10:25-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 00:19:08-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161112 00:20:19< vultraz> celticminstrel: he's back
20161112 00:26:03-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161112 00:26:33-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has quit [Ping timeout: 256 seconds]
20161112 00:32:13-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161112 00:39:21< irker424> wesnoth: Charles Dang wesnoth:master 52105fdb4d3d / src/game_initialization/ (multiplayer.cpp multiplayer.hpp playcampaign.cpp singleplayer.cpp): Made remaining MP screens use the GUI2 dialogs https://github.com/wesnoth/wesnoth/commit/52105fdb4d3dc093b511429e3ee34eebe4dcce9a
20161112 00:42:54-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 00:42:55< travis-ci> wesnoth/wesnoth#12022 (master - c43651f : Celtic Minstrel): The build was broken.
20161112 00:42:55< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175212984
20161112 00:42:55-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 00:44:00-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 00:44:01< travis-ci> wesnoth/wesnoth#12024 (master - bf58ce7 : Charles Dang): The build was broken.
20161112 00:44:01< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175220198
20161112 00:44:01-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 00:47:25-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 00:47:26< travis-ci> wesnoth/wesnoth#12025 (master - 05d4721 : Celtic Minstrel): The build failed.
20161112 00:47:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175222095
20161112 00:47:26-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 00:48:19< vultraz> now, to remove the actual gui1 code
20161112 00:50:03-!- noy_ [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161112 00:51:13< shadowm> celticminstrel: NLS = National/Native Language Support
20161112 00:51:37-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 240 seconds]
20161112 00:51:37-!- noy_ is now known as noy
20161112 00:54:15< irker424> wesnoth: Charles Dang wesnoth:master d5fab53976a3 / src/ (21 files in 2 dirs): Removed GUI1 mp dialog code https://github.com/wesnoth/wesnoth/commit/d5fab53976a30dcff783f5b9a5515398c98b84bd
20161112 00:54:29< vultraz> 1 addition and 6,838 deletions.
20161112 00:54:32< vultraz> FEELS GOOD :D
20161112 00:55:58< irker424> wesnoth: Wedge009 wesnoth:master cb85189176e4 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Remove recently-deleted header from VC project. https://github.com/wesnoth/wesnoth/commit/cb85189176e41c0c8ec220b137bef8594536da9d
20161112 00:56:23< vultraz> wedge009: too soon, now you have to update again :P
20161112 00:58:40< celticminstrel> gfgtdf: Did that eveb before you told me about it.
20161112 00:58:45< irker424> wesnoth: Charles Dang wesnoth:master 6166220b6dd6 / projectfiles/CodeBlocks/wesnoth.cbp: Updated CB projfile https://github.com/wesnoth/wesnoth/commit/6166220b6dd6c5818e46162f67dbdbb8ead67d1a
20161112 00:59:38< celticminstrel> ^even
20161112 00:59:58< celticminstrel> vultraz: Did you see my paste, and are you going to do anything with it?
20161112 01:00:09< vultraz> celticminstrel: i saw
20161112 01:00:14< vultraz> ill see what to do
20161112 01:05:01< irker424> wesnoth: Wedge009 wesnoth:master 26ac2532a5ad / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Removing recently-deleted GUI1 MP dialogues from VC project. https://github.com/wesnoth/wesnoth/commit/26ac2532a5ad304c84e09109616c5eef32502541
20161112 01:08:40< irker424> wesnoth: Celtic Minstrel wesnoth:master bc7c66d9f01a / .travis.yml utils/travis/install_deps.sh: Travis: Wrap entire install script in travis_wait https://github.com/wesnoth/wesnoth/commit/bc7c66d9f01aea681c8ac27c0ea35dcc8d3147de
20161112 01:09:28-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 01:09:29< travis-ci> wesnoth/wesnoth#12028 (master - 52105fd : Charles Dang): The build failed.
20161112 01:09:30< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175234480
20161112 01:09:30-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 01:09:49-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 01:09:50< travis-ci> wesnoth/wesnoth#12027 (travis_osx - 522e31f : Celtic Minstrel): The build has errored.
20161112 01:09:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175224412
20161112 01:09:51-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 01:13:59-!- mjs-de [~mjs-de@x4db60200.dyn.telefonica.de] has quit [Remote host closed the connection]
20161112 01:15:41< celticminstrel> Looks like the OSX build is sorta-working.
20161112 01:16:01< celticminstrel> But didn't get as far as scons because brew gives an error when the package is already installed. 9_9
20161112 01:16:08< celticminstrel> ancestral: Do you know if there's a flag to avoid that?
20161112 01:16:25-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 01:16:26< travis-ci> wesnoth/wesnoth#12029 (master - d5fab53 : Charles Dang): The build failed.
20161112 01:16:26< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175236397
20161112 01:16:26-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 01:16:29< celticminstrel> I could just remove that dependency, of course.
20161112 01:16:33< ancestral> Oh wow
20161112 01:16:40< celticminstrel> What?
20161112 01:16:56< ancestral> You’re setting up Travis
20161112 01:17:09< ancestral> Anyway, to answer your question, probably…
20161112 01:17:10< irker424> wesnoth: Charles Dang wesnoth:master 04a511137992 / src/game_initialization/ (flg_manager.cpp flg_manager.hpp): Remove from GUI1 stuff from the FLG manager https://github.com/wesnoth/wesnoth/commit/04a5111379920f32605d7cc58844ca98665075e5
20161112 01:17:28< ancestral> I didn’t need to install scons myself
20161112 01:17:44< celticminstrel> The package that's already installed is boost, actually.
20161112 01:18:06< ancestral> Good ’ol Boost
20161112 01:18:14< celticminstrel> I can just remove it from the list of packages that I install, though, if there's no way to tell it to silently skip ones that are already installed.
20161112 01:19:53< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx c2bab32522c6 / utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/c2bab32522c66ec1f48bb785cecc126e10666437
20161112 01:22:09-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 01:22:11< travis-ci> wesnoth/wesnoth#12030 (master - cb85189 : Wedge009): The build failed.
20161112 01:22:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175236834
20161112 01:22:11-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 01:22:47< celticminstrel> I think the failures so far are primarily my commit that shifts install to a script, so my next commit should fix it mostly.
20161112 01:23:57< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx 0c9c35e7b530 / .travis.yml utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/0c9c35e7b530081772e8974df7841e8c4a71b2ca
20161112 01:24:05< celticminstrel> Next as in the one that had already been pushed about Travis.
20161112 01:24:12< celticminstrel> Not that one I just pushed now.
20161112 01:24:43< celticminstrel> The others will fail fast because of the nature of the issue.
20161112 01:25:37< irker424> wesnoth: Charles Dang wesnoth:master 7a1fec2153b2 / / (13 files in 4 dirs): Removed a bunch of now-unused GUI1 widgets https://github.com/wesnoth/wesnoth/commit/7a1fec2153b220fe98ba85590e870669c09dc0a6
20161112 01:25:46< celticminstrel> So many commits.
20161112 01:26:27< celticminstrel> Any reason you don't prepare several commits and then push them in a batch?
20161112 01:26:29< vultraz> someone will need to update test_mp_connect
20161112 01:26:35< vultraz> or i could just remove it
20161112 01:26:44< celticminstrel> Don't just remove it.
20161112 01:26:46-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 01:26:47< travis-ci> wesnoth/wesnoth#12031 (master - 6166220 : Charles Dang): The build failed.
20161112 01:26:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175237215
20161112 01:26:47-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 01:26:54< celticminstrel> Be non-lazy and update it yourself. :P
20161112 01:27:10< celticminstrel> (But if you don't, someone else will get to it eventually.)
20161112 01:27:19< vultraz> i don't build the tests
20161112 01:27:20< vultraz> so I cna't
20161112 01:27:22< vultraz> can't
20161112 01:27:40< celticminstrel> You can attempt to fix it and push it to a branch and see if Travis passes it.
20161112 01:29:05< vultraz> oh huh
20161112 01:29:12< vultraz> actually might not need updating
20161112 01:29:14< vultraz> that's commented out
20161112 01:29:20< celticminstrel> So... we have two clang builds and two GCC builds...
20161112 01:29:33< celticminstrel> And two scons and two CMake.
20161112 01:29:55< celticminstrel> I was going to ask if there's any reason to make them all run the tests, but maybe there is...
20161112 01:30:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161112 01:30:41< celticminstrel> It's just that it'd be nice to be able to tell just by looking at the jobs list whether the test failed due to building or testing.
20161112 01:30:59-!- prkc [~prkc@catv-89-133-39-230.catv.broadband.hu] has quit [Remote host closed the connection]
20161112 01:31:42< irker424> wesnoth: Charles Dang wesnoth:master bc47f05b3f93 / src/tests/test_mp_connect.cpp: Test MP Connect: cleaned up GUI1 stuff https://github.com/wesnoth/wesnoth/commit/bc47f05b3f93007f2c2f23355a5976174b1587b2
20161112 01:34:57-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 01:34:58< travis-ci> wesnoth/wesnoth#12032 (master - 26ac253 : Wedge009): The build failed.
20161112 01:34:58< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175238198
20161112 01:34:58-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 01:37:36< vultraz> celticminstrel: as to why i rapid-fire commits, it's so I don't have to rebase
20161112 01:37:51< celticminstrel> I suppose that's... a reason...
20161112 01:40:02< celticminstrel> Well, translations passed with my Travis fix, so I think that means the fix did what it was meant to do.
20161112 01:40:24< celticminstrel> No idea whether other stuff will pass though.
20161112 01:40:37< shadowm> vultraz: That's not a reason for rapid-firing commits.
20161112 01:40:50< shadowm> Why are you afraid of rebasing then?
20161112 01:40:56< celticminstrel> I wouldn't consider it a great reason but...
20161112 01:41:15< celticminstrel> I'm guessing a rebase forces him to rebuild since the commit is basically reverted and re-applied.
20161112 01:41:25< celticminstrel> I think it does that to me too (but I rebase anyway).
20161112 01:41:51< shadowm> On the other hand, polluting history with short-lived changes that will be overwritten in less than 24 hours isn't proper.
20161112 01:42:03< shadowm> Especially if it isn't even accidental.
20161112 01:42:27< vultraz> Because I don't have ccache
20161112 01:42:43< celticminstrel> That doesn't sound like it describes what he was doing?
20161112 01:42:56< shadowm> Not right now, but it's a habit he has.
20161112 01:43:01< celticminstrel> Oh okay.
20161112 01:43:10< celticminstrel> I sorta did that earlier when I removed the GUI1 test plugins.
20161112 01:43:25< celticminstrel> And then moved the GUI2 ones to the old names in a separate commit.
20161112 01:43:41< celticminstrel> Because I wanted git to show that as a rename, rather than deleting the GUI2 ones and rewriting the GUI1 ones.
20161112 01:53:02< ancestral> vultraz: Can you update the main page?
20161112 01:53:10< vultraz> the main page?
20161112 01:53:16< ancestral> For the Mac package?
20161112 01:53:21< gfgtdf> vultraz: i noticed in 1.13.6 when starting LoW in mp the flg dialog is not cmpleteley locked: i can still choose kalenz gender to be 'random' or 'male' ('female' is greyd out though)
20161112 01:53:41< vultraz> gfgtdf: yeah, i need to fix that..
20161112 01:53:55< vultraz> shadowm: can you update the front page (mac package now available)
20161112 01:54:04< celticminstrel> Even if you choose random though, I doubt it'll make him female?
20161112 01:54:08< ancestral> Files should be on the server
20161112 01:54:18< ancestral> f.w.o and sf.net
20161112 01:54:22< ancestral> shas there
20161112 01:54:29< ancestral> If you want md5 I’ll go do that
20161112 01:54:35< vultraz> i already updated the download page
20161112 01:54:43< ancestral> Ah super
20161112 01:57:46< gfgtdf> vultraz: the text in 'expierience modifer' is ellipsed when > 99
20161112 01:58:00< vultraz> :|
20161112 01:58:01< gfgtdf> vultraz: in the mp dialog slideri mean
20161112 01:58:05< gfgtdf> slider*
20161112 01:58:28< gfgtdf> vultraz: also i notived that the its not stopsize 10 as it was in the gui1 version afaik
20161112 01:58:33< gfgtdf> stepsize
20161112 01:58:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has quit [Ping timeout: 245 seconds]
20161112 01:58:55< vultraz> in gui1 there was a slider whose min and max were not multiples of strp
20161112 01:59:16< vultraz> i can't remember which one exactly but i changed it
20161112 01:59:45< gfgtdf> vultraz: i actuall think all of those sliders (speicially those time sliders) have the ellipis problme
20161112 01:59:59< vultraz> :|
20161112 02:00:23< vultraz> hm
20161112 02:00:24< vultraz> ys
20161112 02:02:49< irker424> wesnoth: Charles Dang wesnoth:master 4bd7bcd7d348 / src/game_initialization/configure_engine.cpp: Added missing copyright header https://github.com/wesnoth/wesnoth/commit/4bd7bcd7d34803a1e1be1c931f576837381fc7c1
20161112 02:02:52< irker424> wesnoth: Charles Dang wesnoth:master 9a4d7594ee9c / data/gui/window/mp_create_game.cfg: MP Create Game: fixed setting slider status labels not having enough space https://github.com/wesnoth/wesnoth/commit/9a4d7594ee9c9349583242d48c8b73ed47b99940
20161112 02:02:55< irker424> wesnoth: Charles Dang wesnoth:master c6bf9359d856 / src/game_initialization/ (create_engine.cpp create_engine.hpp): Create Engine: GUI1 markup and include cleanup https://github.com/wesnoth/wesnoth/commit/c6bf9359d856bd77bdd71ca2a9cd0b13a4209905
20161112 02:02:57< vultraz> gfgtdf: ^ fixed in the second commit
20161112 02:05:57< gfgtdf> vultraz: ok thx
20161112 02:06:17< vultraz> gfgtdf: do you know if i should delete the Campaign Settings dialog
20161112 02:06:21< vultraz> it's disabled
20161112 02:06:27< vultraz> since early 1.13
20161112 02:06:35< celticminstrel> What does it do?
20161112 02:06:59< vultraz> iirc it had stuff like era selection?
20161112 02:07:07< gfgtdf> for sp campaigns
20161112 02:07:31< celticminstrel> SP campaigns don't do eras normally.
20161112 02:07:47< gfgtdf> vultraz: hmm wll i perosnlla don't indent to activate
20161112 02:08:55< gfgtdf> it was added during a sp mp unitfication soc project whose autor wanted to have eras in sp games, but i dectvated it later
20161112 02:10:24< gfgtdf> vultraz: there are faik alos some fileds mp_game_settings:::show_connect which might be related?  Note sure exactly
20161112 02:10:48< irker424> wesnoth: Charles Dang wesnoth:master d435d861f286 / src/game_initialization/ (create_engine.cpp create_engine.hpp): Create Engine: removed surface getters from type classes https://github.com/wesnoth/wesnoth/commit/d435d861f28698c6aa57b2130d3f425a9b564fba
20161112 02:10:48-!- bumbadadabum [~bumbadada@wesnoth/developer/bumbadadabum] has joined #wesnoth-dev
20161112 02:10:49< gfgtdf> vultraz: that afaik actvates the mp connect dialog in sp campaigns.
20161112 02:10:55< vultraz> yeah
20161112 02:10:59< vultraz> though i just commented that out
20161112 02:11:02< gfgtdf> vultraz: mostlikeley that can thn be removed aswell
20161112 02:11:04< vultraz> idk if it's needed?
20161112 02:11:29< gfgtdf> vultraz: i think it was onyl possible to activate via the disables campaigns settings dialog
20161112 02:11:40< gfgtdf> via the didsabled*
20161112 02:12:04< celticminstrel> My main complaint about these rapid-fire commits is that every one creates a new build.
20161112 02:12:26< celticminstrel> So Travis gets further and further behind.
20161112 02:13:37< shadowm> vultraz: Update the forum post and then I can update the front page from that.
20161112 02:14:09< celticminstrel> The announcement post wasn't updated?
20161112 02:14:15< celticminstrel> Release post was.
20161112 02:14:42< vultraz> done
20161112 02:14:43-!- gfgtdf_ [~chatzilla@x4e368d0d.dyn.telefonica.de] has joined #wesnoth-dev
20161112 02:14:50< vultraz> remind me to drop the "You may also find packages for other platforms there as they become available." line from future announcements
20161112 02:15:17< celticminstrel> I'm pretty sure I won't remember to remind you about that.
20161112 02:15:27< vultraz> I'll remember
20161112 02:15:40< celticminstrel> So you don't actually need reminding?
20161112 02:15:47< vultraz> it's an expression
20161112 02:16:01< celticminstrel> I don't think so?
20161112 02:16:16< celticminstrel> I mean, when I say it, it's because I actually think I'm likely to forget.
20161112 02:16:53-!- gfgtdf [~chatzilla@x4e36a59b.dyn.telefonica.de] has quit [Ping timeout: 260 seconds]
20161112 02:16:53-!- gfgtdf_ is now known as gfgtdf
20161112 02:17:07< vultraz> anyway, I think I've gotten the most obvious GUI1 detritus 
20161112 02:17:11< shadowm> vultraz: I object your edit.
20161112 02:17:32< vultraz> why do you object to my exit
20161112 02:17:34< vultraz> edit
20161112 02:17:35< celticminstrel> vultraz: So, planning to shift GUI2 stuff around or no?
20161112 02:17:41< vultraz> celticminstrel: later
20161112 02:17:53< vultraz> later, later.
20161112 02:18:17< shadowm> There's no public record that the post was ever different.
20161112 02:18:45< celticminstrel> vultraz: So by later you mean possibly days?
20161112 02:19:01< vultraz> no, later today
20161112 02:19:20< celticminstrel> Oh okay. You said it twice so I thought that meant much later.
20161112 02:19:27< celticminstrel> Three times, even.
20161112 02:19:47< vultraz> shadowm: im leaving, so feel free to undo the retcon
20161112 02:20:13< shadowm> I didn't really sign up for that.
20161112 02:20:15< celticminstrel> I'll wait for you to do that before updating XCode.
20161112 02:20:32< celticminstrel> Hopefully Travis will have a working OSX build by then, too.
20161112 02:20:43< shadowm> And yes, retcon is an accurate term for what you did.
20161112 02:22:24-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161112 02:23:15 * celticminstrel doesn't really see why it's such a problem, though maybe setting the "edit reason" would be good.
20161112 02:23:31< vultraz> at least i didn't do a double mobius reacharound 
20161112 02:23:41< celticminstrel> I have no idea what that even means.
20161112 02:26:11< shadowm> Neither do I.
20161112 02:26:22< shadowm> I edited the post.
20161112 02:26:26< celticminstrel> I saw.
20161112 02:31:25< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx 3c04ccd26e3b / .travis.yml utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/3c04ccd26e3b6224f17d2f964b00c48f09861e9e
20161112 02:36:16-!- Shiki [~Shiki@141.39.226.226] has quit [Quit: Verlassend]
20161112 02:41:46-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 02:41:47< travis-ci> wesnoth/wesnoth#12038 (master - bc47f05 : Charles Dang): The build was canceled.
20161112 02:41:47< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175241432
20161112 02:41:47-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 02:46:19-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161112 02:56:09-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161112 02:56:52-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 02:56:53< travis-ci> wesnoth/wesnoth#12039 (master - c6bf935 : Charles Dang): The build was canceled.
20161112 02:56:53< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175245571
20161112 02:56:53-!- travis-ci [~travis-ci@ec2-54-221-143-0.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 02:58:25-!- louis94 [~~louis94@91.178.240.21] has quit [Ping timeout: 256 seconds]
20161112 03:01:12-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has joined #wesnoth-dev
20161112 03:02:05-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161112 03:03:53< ancestral> Well, I’ve saved 3MB so far
20161112 03:05:42< celticminstrel> ?
20161112 03:06:06< celticminstrel> BTW, if you're looking to save space you could look at matthiaskrgr's woptipng scriped.
20161112 03:06:08< celticminstrel> ^script
20161112 03:10:45-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 03:10:46< travis-ci> wesnoth/wesnoth#12040 (master - d435d86 : Charles Dang): The build failed.
20161112 03:10:46< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175246461
20161112 03:10:46-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 03:16:58< ancestral> celticminstrel: I have an ImageOptim that’s working well
20161112 03:17:12 * celticminstrel shrug.
20161112 03:17:32< ancestral> PNGOUT, OptiPNG, AdvPNG and PNGCrush all in one
20161112 03:17:34< celticminstrel> So you saved 3MB by compressing images, or by compressing text, or what?
20161112 03:17:47< ancestral> Just optimizing PNGs
20161112 03:17:52< ancestral> No compression
20161112 03:18:05< celticminstrel> The aforementioned script does that sort of thing, and also diffs the input and output to make sure pixels haven't changed.
20161112 03:18:16< ancestral> And no Zopfli, which I heard was possibly bad for some reason
20161112 03:18:59< ancestral> Hmm
20161112 03:19:04< ancestral> I mean, this shouldn’t, but sure
20161112 03:19:07< shadowm> Note that we've had libpng/SDL_image misbehave with the output of some PNG compressors in the past, so try to always test changes in-game when experimenting with new options or tools.
20161112 03:19:38< shadowm> I recall one particular run by zookeeper that left us with invisible terrains.
20161112 03:20:47< ancestral> We don’t store any metadata in our PNGs, right? No color profiles or anything?
20161112 03:21:13< ancestral> (FWIW I haven’t had this app touch any of that, so if any of it exists it’s untouched.)
20161112 03:21:35< celticminstrel> No idea, but I doubt it.
20161112 03:21:54< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx 1a4ad011e5a7 / .travis.yml utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/1a4ad011e5a714f23feb504abbc74eeb63763f1c
20161112 03:21:59< shadowm> We do, actually, until someone runs wesnoth-optipng on them, which hasn't happened in a while.
20161112 03:22:02< celticminstrel> Apparently scons wasn't installed.
20161112 03:22:12< celticminstrel> shadowm: I thought matthiaskrgr did that recently...
20161112 03:22:15< shadowm> I've told people to try to not run that often since it inflates the repository pack sizes.
20161112 03:22:31< shadowm> (For almost worthless gains.)
20161112 03:22:51< celticminstrel> Maybe it should be made a build step instead?
20161112 03:22:58< ancestral> Not saving much on this end
20161112 03:23:04< celticminstrel> Though I guess that'd be hard.
20161112 03:23:07< shadowm> (No-one benefits from a < 10 MiB reduction in size.)
20161112 03:23:22< shadowm> (It's also very taxing on the committer's CPU.)
20161112 03:23:48< shadowm> (I remember reaching 91 °C on one of my laptops years ago using it.)
20161112 03:24:02< ancestral> Good thing I’m getting a new computer in 3 weeks
20161112 03:24:25< ancestral> 9.9% savings on the wesnoth.png image file
20161112 03:25:13-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 03:25:14< travis-ci> wesnoth/wesnoth#12042 (travis_osx - 1a4ad01 : Celtic Minstrel): The build was canceled.
20161112 03:25:14< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175252746
20161112 03:25:14-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 03:26:06< ancestral> All the tooltips have some good savings
20161112 03:26:16< ancestral> ~20%
20161112 03:28:22< shadowm> Tooltips?
20161112 03:32:31-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 03:32:32< travis-ci> wesnoth/wesnoth#12042 (travis_osx - 1a4ad01 : Celtic Minstrel): The build was canceled.
20161112 03:32:32< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175252746
20161112 03:32:32-!- travis-ci [~travis-ci@ec2-54-221-3-51.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 03:33:01< celticminstrel> Okay, so it passses every check... except "Pgg Vorbiz support in SDL".
20161112 03:33:03< celticminstrel> ^Ogg
20161112 03:33:09< celticminstrel> ^Vorbis
20161112 03:33:13 * celticminstrel apparently can't type.
20161112 03:34:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161112 03:34:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 03:37:37< celticminstrel> ancestral: Do you have to do something special to install SDL2_mixer with Ogg support in Homebrew, or would ensuring libvorbis is installed first be sufficient?
20161112 03:40:55-!- iwaim [~iwaim@2001:2c0:40e:2002:805b:4060:a25c:921b] has quit [Ping timeout: 256 seconds]
20161112 03:41:30< celticminstrel> Well, I'll try that for now.
20161112 03:41:34-!- gfgtdf [~chatzilla@x4e368d0d.dyn.telefonica.de] has quit [Quit: ChatZilla 0.9.93 [Firefox 49.0.2/20161019084923]]
20161112 03:42:30< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx c18c46da5924 / .travis.yml utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/c18c46da5924747c242157a3fd4389eaa2d9330e
20161112 03:42:35 * celticminstrel notes that vultraz still has to fix the build in master.
20161112 03:47:02-!- iwaim [~iwaim@2001:2c0:40e:2002:654e:d284:6c50:56ce] has joined #wesnoth-dev
20161112 03:58:17< celticminstrel> Doesn't work.
20161112 03:58:21< celticminstrel> ancestral: Any ideas?
20161112 03:58:46< celticminstrel> I'm asking you because you use Homebrew IIRC.
20161112 04:01:49-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 04:01:50< travis-ci> wesnoth/wesnoth#12043 (travis_osx - c18c46d : Celtic Minstrel): The build failed.
20161112 04:01:51< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175254078
20161112 04:01:51-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 04:02:36-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161112 04:06:52< Aginor> celticminstrel: if I recall correctly, you can specify options to your homebrew pacakges when you install them
20161112 04:07:06< Aginor> celticminstrel: I'm pretty sure that vorbis is one of those options
20161112 04:07:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Ping timeout: 248 seconds]
20161112 04:07:48< celticminstrel> The question is how to do that.
20161112 04:09:39< Aginor> it should just pick up on it if libvorbis is installed
20161112 04:09:56< Aginor> https://github.com/Homebrew/homebrew-core/blob/master/Formula/sdl2_mixer.rb
20161112 04:10:16< celticminstrel> Hmm.
20161112 04:10:41< celticminstrel> Maybe if I install everything else in one brew command and sdl2 in a second one?
20161112 04:11:25< celticminstrel> ...though I notice that formula has no "if build.with?" line for libvorbis.
20161112 04:11:40< celticminstrel> Maybe that's not relevant though. It could be auto-added by .configure.
20161112 04:11:45< celticminstrel> ^./configure
20161112 04:11:55< Aginor> I think ./configure should pick up on that
20161112 04:12:06< Aginor> but yeah, order matters
20161112 04:12:19< celticminstrel> I did move libvorbis ahead of sdl2, but still all in one command.
20161112 04:12:29< Aginor> that may be sufficient
20161112 04:12:38< celticminstrel> Well, it doesn't seem like it was though.
20161112 04:12:56< celticminstrel> At least, it's still complaining about missing ogg support.
20161112 04:13:25< Aginor> did you reove sdl2 mixer inbetween?
20161112 04:13:43< celticminstrel> Well, it starts afresh on each build...
20161112 04:15:18< Aginor> ok
20161112 04:15:28< Aginor> does the output tell you in which order it builds them?
20161112 04:17:48< celticminstrel> Yeah.
20161112 04:18:00< celticminstrel> https://travis-ci.org/wesnoth/wesnoth/jobs/175254085
20161112 04:18:43< celticminstrel> The collapsed section just before check_utf8
20161112 04:19:04-!- Appleman1234_ [~Appleman1@KD106161201055.au-net.ne.jp] has joined #wesnoth-dev
20161112 04:19:17< celticminstrel> libvorbis clearly comes before sdl2_mixer.
20161112 04:21:01< Aginor> celticminstrel: anyway to make brew verbose though?
20161112 04:21:14-!- Appleman1234 [~Appleman1@KD106161196194.au-net.ne.jp] has quit [Disconnected by services]
20161112 04:21:16< Aginor> celticminstrel: it'd be useful to see what sdl2_mixer thinks it's configured with
20161112 04:21:20-!- Appleman1234_ is now known as Appleman1234
20161112 04:21:22< celticminstrel> No idea.
20161112 04:22:05< Aginor> celticminstrel: brew install -v
20161112 04:22:23< Aginor> might be worth doing sdl2_mixer on its own line too
20161112 04:22:28< celticminstrel> I guess I'll add that and see how it goes.
20161112 04:22:35< Aginor> do the same for libvorbis
20161112 04:23:22< Aginor> https://trac.ffmpeg.org/wiki/CompilationGuide/MacOSX <-- that *may* be applicable too
20161112 04:23:30< irker424> wesnoth: Celtic Minstrel wesnoth:travis_osx 7281fdaaadec / .travis.yml utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/7281fdaaadec5edf3e0b3b5e7a1aee82f0470276
20161112 04:41:11-!- JyrkiVesterinen [~JyrkiVest@87-100-181-150.bb.dnainternet.fi] has joined #wesnoth-dev
20161112 04:47:21< irker424> wesnoth: Charles Dang wesnoth:master c612aae4783b / src/gui/dialogs/campaign_settings.cpp: Forgot to include this in c6bf9359d856 https://github.com/wesnoth/wesnoth/commit/c612aae4783bdb2e479c376d7e7123b940375f18
20161112 04:48:07< celticminstrel> Yay.
20161112 05:04:21-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 05:09:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 240 seconds]
20161112 05:11:37-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 05:11:38< travis-ci> wesnoth/wesnoth#12046 (travis_osx - 7281fda : Celtic Minstrel): The build is still failing.
20161112 05:11:38< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175257118
20161112 05:11:39-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 05:38:00-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161112 05:51:19< irker424> wesnoth: Wedge009 wesnoth:master 098439285773 / projectfiles/VC12/ (wesnoth.vcxproj wesnoth.vcxproj.filters): Removing deleted GUI1 widgets from VC project. https://github.com/wesnoth/wesnoth/commit/09843928577325e87fc43e84ba5fad65235c7474
20161112 05:51:36-!- travis-ci [~travis-ci@ec2-54-158-183-114.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 05:51:37< travis-ci> wesnoth/wesnoth#12047 (master - c612aae : Charles Dang): The build has errored.
20161112 05:51:37< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175259033
20161112 05:51:37-!- travis-ci [~travis-ci@ec2-54-158-183-114.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 06:06:18< celticminstrel> If you manage to get it so that OSX is the only thing failing, feel free to remove it and/or add it to allowed_failures for now.
20161112 06:06:55< celticminstrel> I won't be updating it again tonight, at least.
20161112 06:07:10< celticminstrel> (It's 1am here, for reference.)
20161112 06:08:04< celticminstrel> It wasn't supposed to be active in master anyway until I actually got it working.
20161112 06:37:10-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 06:37:11< travis-ci> wesnoth/wesnoth#12048 (master - 0984392 : Wedge009): The build has errored.
20161112 06:37:11< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175264362
20161112 06:37:11-!- travis-ci [~travis-ci@ec2-54-166-106-239.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 06:41:19< irker424> wesnoth: Charles Dang wesnoth:master 4ee61013ed11 / src/tests/test_mp_connect.cpp: Fixup tests https://github.com/wesnoth/wesnoth/commit/4ee61013ed11c76e686b48cc80025736bce24481
20161112 07:19:31-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has joined #wesnoth-dev
20161112 07:29:02-!- travis-ci [~travis-ci@ec2-54-90-172-172.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 07:29:03< travis-ci> wesnoth/wesnoth#12049 (master - 4ee6101 : Charles Dang): The build has errored.
20161112 07:29:04< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175268435
20161112 07:29:04-!- travis-ci [~travis-ci@ec2-54-90-172-172.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 07:32:46-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has quit [Quit: And lo! The computer falls into a deep sleep, to awake again some other day!]
20161112 07:36:14< irker424> wesnoth: Charles Dang wesnoth:master 2df3a09c0ca3 / src/game_initialization/ (configure_engine.cpp configure_engine.hpp): Configure Engine: remove entry point code https://github.com/wesnoth/wesnoth/commit/2df3a09c0ca3005879e62170f810bafbb11dc1af
20161112 07:36:17< irker424> wesnoth: Charles Dang wesnoth:master 3ff4a189834c / utils/travis/mp_test_executor.sh: Update GUI2 test plugin names (since c43651f99b24) https://github.com/wesnoth/wesnoth/commit/3ff4a189834cfaa1b21cc95dec774e54c15c3b7c
20161112 07:40:33-!- Greg-Boggs [~greg_bogg@c-76-115-139-154.hsd1.or.comcast.net] has quit [Remote host closed the connection]
20161112 07:42:57-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161112 08:22:40-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161112 08:30:08-!- travis-ci [~travis-ci@ec2-54-158-183-114.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 08:30:09< travis-ci> wesnoth/wesnoth#12050 (master - 3ff4a18 : Charles Dang): The build has errored.
20161112 08:30:09< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175272817
20161112 08:30:09-!- travis-ci [~travis-ci@ec2-54-158-183-114.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 08:55:20-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has joined #wesnoth-dev
20161112 09:22:34-!- ancestral [~ancestral@75-168-80-79.mpls.qwest.net] has quit [Quit: i go nstuf kthxbai]
20161112 09:29:59-!- zookeeper [~lmsnie@wesnoth/developer/zookeeper] has joined #wesnoth-dev
20161112 09:41:03-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 09:46:17-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 240 seconds]
20161112 09:57:26-!- JyrkiVesterinen [~JyrkiVest@87-100-181-150.bb.dnainternet.fi] has quit [Quit: .]
20161112 10:05:47-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161112 10:36:38-!- irker424 [~irker@uruz.ai0867.net] has quit [Quit: transmission timeout]
20161112 10:52:43-!- Bonobo [~Bonobo@2001:44b8:254:3200:dc56:d7a2:24aa:1381] has quit [Ping timeout: 258 seconds]
20161112 10:53:03-!- Bonobo [~Bonobo@2001:44b8:254:3200:c01c:6ad4:bd52:b1b4] has joined #wesnoth-dev
20161112 11:43:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 11:47:37-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 240 seconds]
20161112 11:53:15-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has joined #wesnoth-dev
20161112 12:01:03-!- mjs-de [~mjs-de@x4e3163d6.dyn.telefonica.de] has joined #wesnoth-dev
20161112 12:05:15-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 256 seconds]
20161112 12:06:20-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161112 12:39:16-!- gfgtdf [~chatzilla@x4e368d0d.dyn.telefonica.de] has joined #wesnoth-dev
20161112 12:54:32-!- Bonobo [~Bonobo@2001:44b8:254:3200:c01c:6ad4:bd52:b1b4] has quit [Quit: Leaving]
20161112 13:11:31-!- JyrkiVesterinen [~JyrkiVest@87-92-2-104.bb.dnainternet.fi] has joined #wesnoth-dev
20161112 13:14:25-!- gfgtdf [~chatzilla@x4e368d0d.dyn.telefonica.de] has quit [Remote host closed the connection]
20161112 13:15:59-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161112 13:44:27-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 13:47:35-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161112 13:47:54-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 13:48:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 256 seconds]
20161112 14:03:38-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has joined #wesnoth-dev
20161112 14:06:14-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 250 seconds]
20161112 14:14:29-!- mjs-de [~mjs-de@x4e3163d6.dyn.telefonica.de] has quit [Remote host closed the connection]
20161112 14:20:40-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161112 14:37:00-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161112 14:38:17-!- prkc [~prkc@gateway/vpn/privateinternetaccess/prkc] has quit [Ping timeout: 240 seconds]
20161112 14:46:25-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161112 14:53:35-!- prkc [~prkc@46.166.190.181] has joined #wesnoth-dev
20161112 15:37:24-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161112 16:02:44-!- DeFender1031 [~DeFender1@46-116-17-86.bb.netvision.net.il] has joined #wesnoth-dev
20161112 16:03:16< DeFender1031> hey everyone!
20161112 16:08:03< DeFender1031> Huh... guess no one's around at the moment.
20161112 16:08:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161112 16:08:33-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 16:11:20-!- ToBeCloud [uid51591@wikimedia/ToBeFree] has quit [Quit: Connection closed for inactivity]
20161112 16:47:42-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161112 16:52:09-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161112 16:52:24-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 16:57:18-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161112 16:57:43-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 16:58:39-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161112 16:58:55-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 17:01:26-!- celticminstrel [~celmin@unaffiliated/celticminstrel] has joined #wesnoth-dev
20161112 17:03:31-!- wedge010 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 17:04:00-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 17:05:20-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 252 seconds]
20161112 17:05:20-!- wedge010 is now known as wedge009
20161112 17:07:57-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 240 seconds]
20161112 17:10:26-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Quit: wedge009]
20161112 17:10:46-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 17:13:16-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Client Quit]
20161112 17:15:03-!- gfgtdf [~chatzilla@x4e368d0d.dyn.telefonica.de] has joined #wesnoth-dev
20161112 17:16:53-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has joined #wesnoth-dev
20161112 17:19:37< gfgtdf> i just played a game on 1.13 server but i cannot find the replay at http://replays.wesnoth.org/1.13/
20161112 17:19:58< gfgtdf> loonycyborg: could it be tha replays are broken on current wesnothd ?
20161112 17:23:35< loonycyborg> I'm not even sure how that feature works
20161112 17:24:50< gfgtdf> at the end of the game the server stores te replay savefile to a local file
20161112 17:27:52< gfgtdf> loonycyborg: here is the function that does the work: https://github.com/wesnoth/wesnoth/blob/master/src/server/game.cpp#L1506
20161112 17:34:54-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161112 17:41:56< zookeeper> gfgtdf, how long have you waited? i think there might be a bit of a delay until they appear
20161112 17:42:30< gfgtdf> zookeeper: its still not there.
20161112 17:42:34< zookeeper> ah well, indeed looks like there haven't been any new ones in a few months
20161112 17:42:53< zookeeper> Soliton, ^ ?
20161112 18:07:16< celticminstrel> Well, one job of the latest build passed, three errored, huh...
20161112 18:07:49< celticminstrel> Timeout in MP tests.
20161112 18:08:05-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161112 18:08:09< celticminstrel> BTW vultraz, still planning on some GUI2 file shuffling, or should I update the XCode project now?
20161112 18:20:57-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has joined #wesnoth-dev
20161112 18:25:51-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161112 19:31:18< celticminstrel> The verbose log from Homebrew doesn't seem to give any additional useful information...
20161112 19:34:02< celticminstrel> Though it kinda gives off the impression that it's a binary download, not a source download... I dunno...
20161112 19:35:41-!- wedge009 [~Thunderbi@60-241-236-92.static.tpgi.com.au] has quit [Ping timeout: 260 seconds]
20161112 19:36:08-!- JyrkiVesterinen [~JyrkiVest@87-92-2-104.bb.dnainternet.fi] has quit [Remote host closed the connection]
20161112 19:36:55< celticminstrel> I wonder if it could build and run the tests even without vorbis. If so it might be easier to just not require it when run on Travis. >_>
20161112 19:37:02 * celticminstrel doesn't like that idea though.
20161112 19:38:18< celticminstrel> Still, the game should be able to handle the non-presence of the music files, since some distributions package the music separately; so it can probably also handle the music files being unloadable.
20161112 19:40:07< celticminstrel> Looks like you missed some nacl support, tad. Starting on line 345 of SConstruct.
20161112 19:42:13-!- irker618 [~irker@uruz.ai0867.net] has joined #wesnoth-dev
20161112 19:42:14< irker618> wesnoth: Celtic Minstrel wesnoth:travis_osx 5cc223a7f919 / SConstruct utils/travis/install_deps.sh: Travis hack: Don't require vorbis on OSX https://github.com/wesnoth/wesnoth/commit/5cc223a7f9196af406fb6b94aa7d4a78e014be6e
20161112 19:42:22< celticminstrel> ^ Really don't like that. Not even sure it'll work. Hope we find a better solution.
20161112 19:47:12< tad_carlucci> Travis doesn't play OGG so it won't matter there. Don't want that for release, however.
20161112 19:47:42< celticminstrel> Well, what I wasn't quite sure of was whether the logic chain in the Python code would still work with my changes.
20161112 19:49:18< tad_carlucci> Ah. Well I'd look but my head is swimming with the false dependencies on smart_list and how little it's actually used. Still checking but it looks like all the work is so to avoid features/functions/restrictions which we never use anyway.
20161112 20:07:27-!- travis-ci [~travis-ci@ec2-54-161-209-41.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 20:07:28< travis-ci> wesnoth/wesnoth#12051 (travis_osx - 5cc223a : Celtic Minstrel): The build is still failing.
20161112 20:07:28< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175361308
20161112 20:07:28-!- travis-ci [~travis-ci@ec2-54-161-209-41.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 20:09:23< celticminstrel> Looks like it works!
20161112 20:09:34< celticminstrel> It only failed because of the compile error that was also in master.
20161112 20:13:40-!- ancestral [~ancestral@8.42.164.20] has joined #wesnoth-dev
20161112 20:17:54-!- ancestral [~ancestral@8.42.164.20] has quit [Client Quit]
20161112 20:38:21< vultraz> [05:08:08]	celticminstrel	BTW vultraz, still planning on some GUI2 file shuffling, or should I update the XCode project now?
20161112 20:38:25< vultraz> celticminstrel: you can do it now
20161112 20:38:30< vultraz> i've gotten sidetracked
20161112 20:43:38< vultraz> celticminstrel: is it true that *vector*::emplace does not have the same exclusivity check as map::emplace?
20161112 20:53:15< celticminstrel> ...
20161112 20:53:35< vultraz> what?
20161112 20:53:40< vultraz> i've only asked you about map
20161112 20:53:45< celticminstrel> Exclusivity has nothing to do with emplace. It's a feature of the map and set containers.
20161112 20:53:49< vultraz> ok
20161112 20:54:11-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161112 20:54:14< vultraz> my logic was backwards then
20161112 20:54:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Client Quit]
20161112 20:55:44-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161112 20:57:03< celticminstrel> vultraz: Mind if I do a few GUI2 renames/shuffles then?
20161112 20:57:51< celticminstrel> Mainly renames.
20161112 20:58:01< vultraz> go ahead
20161112 20:58:06< celticminstrel> But I also want to move core/tips.?pp
20161112 20:58:28< vultraz> i was going to move that to aux/tip_of_the_day.*pp
20161112 21:00:29< celticminstrel> Is tools/schema used by the client?
20161112 21:05:35-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 21:09:49-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 256 seconds]
20161112 21:18:58< celticminstrel> I guess I'll leave it where it is in the XCode project for now.
20161112 21:48:07-!- stikonas [~gentoo@wesnoth/translator/stikonas] has quit [Quit: Konversation terminated!]
20161112 21:49:32-!- stikonas [~gentoo@wesnoth/translator/stikonas] has joined #wesnoth-dev
20161112 21:51:53-!- Bonobo [~Bonobo@2001:44b8:254:3200:b573:68c8:5b2a:5798] has joined #wesnoth-dev
20161112 22:01:32-!- Kwandulin [~Miranda@p5DDD2B8F.dip0.t-ipconnect.de] has quit [Read error: Connection reset by peer]
20161112 22:10:55< celticminstrel> src/text_formatting.cpp:24 font::rgb2highlight_pango
20161112 22:11:03< celticminstrel> Pretty sure most of that is redundant.
20161112 22:11:45< celticminstrel> Don't hex, setfull, setw persist until cancelled by a later directive?
20161112 22:12:05< celticminstrel> hex does for sure. Not sure on <iomanip>
20161112 22:12:13< celticminstrel> But I think it does?
20161112 22:12:27< celticminstrel> ^setfill
20161112 22:12:51< celticminstrel> ...
20161112 22:13:09< celticminstrel> Also there are quite clearly two functions there that do almost the exact same thing.
20161112 22:13:56< celticminstrel> Admittedly they take the colour in different formats (integer vs SDL_Color" and one also includes a prefix #, but still...
20161112 22:14:02< celticminstrel> ^)
20161112 22:18:15< tad_carlucci> Wow. It seems to me that the first job for removing smart_list is to break the false-dependacies on it to be able to see who's actually using it. That reduces the surface from about 30 modules to 4 or 5. Refactoring the event loop to a manager:: function reduces that to the 2 or 3 modules which actually implement the game [event] manager.
20161112 22:18:41< celticminstrel> What do you mean by false dependencies?
20161112 22:19:03< tad_carlucci> "Hello, if you change this file I don't care about, please recompile me."
20161112 22:19:13< celticminstrel> Oh yeah, I should download ancestral's build and see if the file dialog works.
20161112 22:19:51 * celticminstrel still not quite sure what you mean... has a vague idea maybe.
20161112 22:19:52< tad_carlucci> Because the file has one class it does care about. But the class which needs changing they don't care about. So move the class from one header to another and viola!
20161112 22:20:21< celticminstrel> smart_list is in the same file as another class?
20161112 22:20:29< celticminstrel> Or the event manager is?
20161112 22:20:38< celticminstrel> handler or handler_list or whatever
20161112 22:20:58< tad_carlucci> The event manager's iterator
20161112 22:21:18< irker618> wesnoth: Celtic Minstrel wesnoth:master 217a6e91f79b / .travis.yml utils/travis/install_deps.sh: Travis: Install OSX dependencies https://github.com/wesnoth/wesnoth/commit/217a6e91f79b729110bfee718e425e566981a662
20161112 22:21:20< irker618> wesnoth: Celtic Minstrel wesnoth:master 5bc16e2544b2 / SConstruct utils/travis/install_deps.sh: Travis hack: Don't require vorbis on OSX https://github.com/wesnoth/wesnoth/commit/5bc16e2544b2764012e2a9ed88165ec278a5f59a
20161112 22:21:22< irker618> wesnoth: Celtic Minstrel wesnoth:master 8e935df0b807 / / (3 files in 2 dirs): Update XCode project https://github.com/wesnoth/wesnoth/commit/8e935df0b80762ed6b5640003010c099c78b4cb9
20161112 22:21:40< celticminstrel> I think it makes sense for an iterator to be in the same class (it's often defined inside its parent class).
20161112 22:21:49< tad_carlucci> Only used in menu [event] and game [event] pumps. Is an interator loop which is identical so crying out to be moved into manager class.
20161112 22:21:57< celticminstrel> But I guess it doesn't hurt to put it in a different file either.
20161112 22:22:12< celticminstrel> Let's see if that build passes now...
20161112 22:23:26< celticminstrel> On an unrelated note, my build still lacks team colours, so it's not related to LOW_MEM.
20161112 22:23:43< celticminstrel> (That in itself is probably a reason for me to not become the official packager.)
20161112 22:23:57< tad_carlucci> Moving the class from manager.hhp to manager_impl.hpp is logical (it is an implementation detail). Just need to convert two for() loops to a function call and nobody cares about smart_list any more, outside of manager.cpp and it's detail helper modules.
20161112 22:24:48-!- atarocch [~atarocch@93.56.160.28] has quit [Ping timeout: 260 seconds]
20161112 22:25:59< celticminstrel> BTW, std::setfill is sticky, right? ie, it lasts until overridden with a new value. (Ditto std::setw)
20161112 22:26:24-!- Shiki [~Shiki@141.39.226.226] has quit [Remote host closed the connection]
20161112 22:29:08< celticminstrel> ...color2hexa isn't even used anywhere outside this file. rgb2highlight_pango is only used in one place.
20161112 22:30:37< celticminstrel> And that function is called in only two places.
20161112 22:32:35< tad_carlucci> As to putting the iterator into the class .. that makes sense if the class is the container. That's not the case here.  The manager HAS a container, but IS NOT a container.
20161112 22:33:59< tad_carlucci> By moving the while() loops to a function in the manager, even the fact a container is involved is compartmentalized into the manager class as an implementaiton detail.
20161112 22:34:02< loonycyborg> gfgtdf: Seems code that saves replays is still there, I'll test it later. It's enabled by save_replays and replay_save_path settings in server.cfg
20161112 22:34:46< tad_carlucci> brb
20161112 22:34:51-!- tad_carlucci [~lundberg@173.217.65.103] has quit [Quit: Off to resolve a merge conflict between the wife and husband branches of my real life.]
20161112 22:35:26 * celticminstrel thinks that makes sense, yes. Though he'll probably never read this.
20161112 22:36:36-!- atarocch [~atarocch@93.56.160.28] has joined #wesnoth-dev
20161112 22:40:33< celticminstrel> This file could be cleaned up significantly, but I don't feel like doing it right now...
20161112 22:40:52< celticminstrel> Half the functions aren't even used anywhere outside it.
20161112 22:57:22-!- Shiki [~Shiki@141.39.226.226] has joined #wesnoth-dev
20161112 23:17:25-!- ChipmunkV [~vova@static-89-94-113-91.axione.abo.bbox.fr] has quit [Quit: ChipmunkV]
20161112 23:17:47-!- tad_carlucci [~lundberg@173.217.65.103] has joined #wesnoth-dev
20161112 23:20:40-!- noy [~Noy@wesnoth/developer/noy] has quit [Ping timeout: 268 seconds]
20161112 23:20:53-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161112 23:21:22-!- travis-ci [~travis-ci@ec2-54-161-205-193.compute-1.amazonaws.com] has joined #wesnoth-dev
20161112 23:21:23< travis-ci> wesnoth/wesnoth#12052 (master - 8e935df : Celtic Minstrel): The build has errored.
20161112 23:21:23< travis-ci> Build details : https://travis-ci.org/wesnoth/wesnoth/builds/175385695
20161112 23:21:23-!- travis-ci [~travis-ci@ec2-54-161-205-193.compute-1.amazonaws.com] has left #wesnoth-dev []
20161112 23:22:40< gfgtdf> loonycyborg: wesnothd as shipped with 1.13.6 doesnt save replay eigher when i add save_replays=yes to lan_server.cfg
20161112 23:27:05-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has joined #wesnoth-dev
20161112 23:27:20-!- noy [~Noy@wesnoth/developer/noy] has quit [Quit: noy]
20161112 23:31:29-!- Greg-Boggs [~greg_bogg@2601:1c2:f00:9780:84ef:572:4467:d547] has quit [Ping timeout: 256 seconds]
20161112 23:39:39< celticminstrel> Hmm.
20161112 23:41:11< irker618> wesnoth: Celtic Minstrel wesnoth:master cdb164052a95 / SConstruct: fixup! Travis hack: Don't require vorbis on OSX https://github.com/wesnoth/wesnoth/commit/cdb164052a9520ee711d33cd9c0ee883b323b959
20161112 23:41:38< celticminstrel> I should've noticed that was broken earlier. :/
20161112 23:41:53< celticminstrel> I just hope that actually fixes it.
20161112 23:43:22-!- celticminstrel is now known as celmin|away
20161112 23:56:22-!- noy [~Noy@wesnoth/developer/noy] has joined #wesnoth-dev
20161112 23:57:45-!- noy [~Noy@wesnoth/developer/noy] has quit [Client Quit]
--- Log closed Sun Nov 13 00:00:04 2016